patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -119,8 +119,8 @@ public class FinishedBattle extends AbstractBattle {
m_isAmphibious = !m_amphibiousAttackFrom.isEmpty();
}
}
- for (final Unit dependence : m_dependentUnits.keySet()) {
- final Collection<Unit> dependent = m_dependentUnits.get(dependence);
+ for (final Map.Entry<Unit,... | [FinishedBattle->[unitsLostInPrecedingBattle->[isEmpty],isEmpty->[isEmpty],removeAttack->[isEmpty]]] | Remove a unit from the attacking map. find the missing unit in the battle. | It would make sense to iterate over `values()` here Also there's no need to create a new variable |
@@ -610,9 +610,10 @@ class TextAnalyticsClient(TextAnalyticsClientBase):
:type documents:
list[str] or list[~azure.ai.textanalytics.TextDocumentInput] or
list[dict[str, str]]
- :keyword bool show_opinion_mining: Whether to mine the opinions of a sentence and conduct more
+ ... | [TextAnalyticsClient->[begin_analyze->[begin_analyze]]] | Analyzes sentiment for a batch of documents. Analyzes sentiment of a sequence of documents. Get a single chunk of a chunk. | @abhahn we're going to leave the param name as `show_opinion_mining`, at least for this release. but we'll have it default to true |
@@ -295,6 +295,12 @@ class TestShelvesSerializer(ESTestCase):
assert data['addons'][0]['name'] == {'en-US': 'test addon test04'}
assert data['addons'][1]['name'] == {'en-US': 'test addon test01'}
+ def test_tag_token_substitution(self):
+ self.tag_shelf.update(title='Title for {tag}', foot... | [TestShelvesSerializer->[test_tags_shelf->[serialize,_get_result_url],test_footer_url->[serialize],test_basic->[serialize],test_basic_themes->[serialize],test_url_and_addons_search->[serialize,_get_result_url],test_url_and_addons_collections->[serialize,_get_result_url],test_addon_count->[serialize]]] | Test the tags shelf. This method is used to set the criteria to all - the - addons and also to set. | Could we have a test case with `{tag}` in a footer text/title for a shelf that isn't for "random tag"? |
@@ -1,17 +1,8 @@
<div class="clearfix border-bottom border-primary-light">
<div class="col col-12 margin-bottom-1 margin-top-0">
- <h3 class="h2 col col-6 margin-0">
+ <h3 class="h2 col col-12 margin-0">
<%= t('account.index.email_addresses') %>
</h3>
- <div class="right-align col col-6">
- ... | [No CFG could be retrieved] | Renders the nag on chain view. | Should this stay? This affects adding emails instead of phone numbers. |
@@ -77,6 +77,9 @@ public class DefaultAnalysisMode extends AbstractAnalysisMode implements Analysi
if (mediumTestMode) {
LOG.info("Medium test mode");
}
+ if (notAssociated) {
+ LOG.info("Project is not associated with the server");
+ }
}
private static String getPropertyWithFallback... | [DefaultAnalysisMode->[init->[IllegalStateException,isIssues,load],printMode->[info],isIssues->[get,equals],getPropertyWithFallback->[containsKey,get],load->[validate,getPropertyWithFallback,equals],init,properties,getLogger]] | printMode - Prints the mode of the component. | As we focus this mode for users having no knowledge of SQ server I would rephrase this log to something like: "Local analysis". WDYT @bellingard ? |
@@ -724,7 +724,7 @@ void manage_heater() {
#if TEMP_SENSOR_BED != 0
- #if ENABLED(THERMAL_PROTECTION_BED)
+ #if ENABLED(THERMAL_PROTECTION_BED) && WATCH_BED_TEMP_PERIOD > 0
thermal_runaway_protection(&thermal_runaway_bed_state_machine, &thermal_runaway_bed_timer, current_temperature_bed, target_temp... | [No CFG could be retrieved] | finds the index of the node in the system that is not in the last state get the number of non - terminal processes in the system. | No `WATCH_*_TEMP_PERIOD` check here or below. |
@@ -248,6 +248,13 @@ class DefinedVisitor(BaseAnalysisVisitor):
else:
return {op.dest}, set()
+ def visit_set_mem(self, op: SetMem) -> GenAndKill:
+ # Loading an error value may undefine the register.
+ if isinstance(op.src, LoadErrorValue) and op.src.undefines:
+ ret... | [analyze_maybe_defined_regs->[DefinedVisitor],analyze_live_regs->[LivenessVisitor],analyze_borrowed_arguments->[BorrowedArgumentsVisitor],cleanup_cfg->[get_real_target,get_cfg],analyze_must_defined_regs->[DefinedVisitor],run_analysis->[AnalysisResult],get_cfg->[CFG],analyze_undefined_regs->[UndefinedVisitor],BaseAnalys... | Visits an Assign instruction. | Since we don't modify `op.dest` but a value pointed to by it, this case can be removed. |
@@ -121,7 +121,8 @@ namespace ProtoCore.Lang
"Reorder", // kReorder
Constants.kFunctionRangeExpression, // kGenerateRange
"Sum", // kSum
- "ToString", // kToString
+ "__ToStringFromObject", // kToStrin... | [BuiltInMethods->[kNormalizeDepth,kContainsKey,kRangeExpression,kSort,kAverage,kIndexOf,kRemove,kSortPointer,ToList,kRemoveKey,kIntersection,kSleep,kTranspose,kSum,kNormalizeDepthWithRank,kUnion,kDifference,kTypeVoid,kBreak,kCount,kReverse,kIsUniformDepth,kLoadCSVWithMode,kTypeString,kSortIndexByValue,kMapTo,kImportDat... | Returns a list of all functions in the system that do not have a variable number of arguments Get a BuiltInMethod for a given MethodID. | Remind me, what is the reason we can't do type-dependent dispatch for these on an overload? |
@@ -29,7 +29,17 @@ class Sorbet::Private::FetchRBIs
# Ensure our cache is up-to-date
T::Sig::WithoutRuntime.sig {void}
def self.fetch_sorbet_typed
- if !File.directory?(RBI_CACHE_DIR)
+ if File.directory?(RBI_CACHE_DIR)
+ cached_remote = IO.popen(["git", "-C", RBI_CACHE_DIR, "config", "--get", "remo... | [paths_for_gem_version->[matching_version_directories],paths_for_ruby_version->[matching_version_directories],main->[paths_for_gem_version,vendor_rbis_within_paths,paths_for_ruby_version],main] | Fetch the last known sequence number from the git repository. | This makes the assumption that forks would only ever be hosted on github. I think this is probably fine for now, but it would make a good enhancement issue :) |
@@ -87,6 +87,9 @@ def download_file(url, filename):
except Exception:
_remove_file_failed(filename)
return False
+ except requests.exceptions.RequestException, e:
+ _remove_file_failed(filename)
+ return False
return True
| [get_file_hash->[gen,md4_hash],download_file->[_remove_file_failed],get_anime_titles_xml->[download_file],read_tvdb_map_xml->[get_anime_list_xml],get_anime_list_xml->[download_file],read_anidb_xml->[get_anime_titles_xml]] | Download a file from GitHub and return True if successful. | this is unnecessary, its already catching the more general Exception above. |
@@ -326,6 +326,12 @@ class Settings(object):
#: to an affirmative value will result in more friendly simple numeric IDs
#: counting up from 1000.
#:
+#: ``BOKEH_USE_BINARY_ARRAYS`` --- Whether to encode data arrays before sending them.
+#:
+#: Accepted values are ``yes``/``no``, ``true``/``false`` or ``0``/``1... | [Settings->[browser->[_get_str],simple_ids->[_get_bool],_get_bool->[_get,_dev_or_default],js_files->[bokehjsdir],minified->[_get_bool],docs_version->[_get_str],version->[_get_str],_get_str->[_get,_dev_or_default],resources->[_get_str],secret_key_bytes->[secret_key],css_files->[bokehjsdir],nodejs_path->[_get_str],rootdi... | A class reference for the base object. | There's no mention of any reason to turn this off, here; I think if we can't say why you'd turn it off, it shouldn't be configurable. Being able to toggle this means eventually the non-default option will be broken in a release, probably, because nobody tested it... |
@@ -42,7 +42,7 @@ def GetModulePath(module):
'''
- return imp.find_module(module)[1]
+ return os.path.dirname(KtsMp.__file__)
def GetAvailableApplication():
| [GetAvailableApplication->[GetModulePath],main->[GetModulePath,Usage,GetAvailableApplication,Commander,RunCppTests,RunTestSuitInTime],main] | Returns the path of a module using its absolute path. | This is no longer general I'd say => `GetModulePath` should now be named `GetKratosMultiphysicsPath` |
@@ -1494,6 +1494,17 @@ class Embedding(layers.Layer):
self._w = value
def forward(self, input):
+ if in_dygraph_mode():
+ attrs = {
+ 'is_sparse': self._is_sparse,
+ 'is_distributed': self._is_distributed,
+ 'remote_prefetch': self._remote_p... | [Conv3D->[_build_once->[_get_default_param_initializer]],NCE->[__init__->[_init_by_numpy_array]],Conv2D->[_build_once->[_get_default_param_initializer]]] | Computes the missing node index from the sequence. | Some suggestions: move some common codes outside `if in_dygraph_modes()` for better maintainability in the future. Seems too many duplicate codes. |
@@ -110,6 +110,7 @@ public class HadoopUtils {
// Add a new custom filesystem mapping
conf.set("fs.sftp.impl", "gobblin.source.extractor.extract.sftp.SftpLightWeightFileSystem");
conf.set("fs.sftp.impl.disable.cache", "true");
+ conf.set("fs.adl.impl", "org.apache.hadoop.fs.adl.AdlFileSystem");
r... | [HadoopUtils->[renamePath->[renamePath],copyPath->[copyPath,deleteIfExists],getConfFromProperties->[newConfiguration],sanitizePath->[sanitizePath],deletePathAndEmptyAncestors->[deletePath],movePath->[movePath,renamePath],getConfFromState->[newConfiguration],deserializeFromString->[deserializeFromString],unsafeRenameIfN... | Creates a new configuration object with the specified values. | This should not be needed. `FileSystem` uses service providers, so discovery happens automatically. |
@@ -347,6 +347,10 @@ namespace System.Windows.Forms
return false;
}
+ /// <summary>
+ /// Processes Windows messages.
+ /// </summary>
+ /// <param name="m">The Windows <see cref="Message" /> to process.</param>
protected override void WndProc(ref Message m)... | [MdiClient->[SetWindowRgn->[SetWindowRgn],OnIdle->[OnInvokedSetScrollPosition],ScaleControl->[ScaleControl],OnResize->[OnResize],ControlCollection->[Remove->[Remove],Add->[Add]],WndProc->[SetWindowRgn,WndProc],SetBoundsCore->[SetBoundsCore]]] | Override WmSetFocus in child control. | Automatic `<inheritdoc/>` is coming for `override` methods in 16.4. (It will work inside the IDE, but post-processing tools will still need to implement it separately.) |
@@ -2465,7 +2465,7 @@ void dt_thumbtable_update_accels_connection(dt_thumbtable_t *table, const int vi
static gboolean _filemanager_ensure_rowid_visibility(dt_thumbtable_t *table, int rowid)
{
if(rowid < 1) rowid = 1;
- if(!table->list || g_list_length(table->list) == 0) return FALSE;
+ if(!table || !table->list... | [No CFG could be retrieved] | This function is called by the filemanager when a rowid is changed. Moves the thumbs to the right of the last row in the list. | this should be only !table->list |
@@ -116,7 +116,7 @@ t.run('amp-image-slider', function () {
expect(win.getComputedStyle(s1.leftLabel)['padding']).to.equal('16px');
});
- describe('using mouse', () => {
+ describe.skip('using mouse', () => {
it('should move slider bar to position on mousedown', () => {
/... | [No CFG could be retrieved] | Test that the slider info is available. mouse down event. | Can you file an issue and add a TODO here? |
@@ -780,7 +780,16 @@ class GMatrixClient(MatrixClient):
# number of members changed. Verify validity of room
if room_members_count != len(room._members):
self._handle_member_join_callback(room)
- all_messages.append((room, sync_room["timeline"]["even... | [GMatrixClient->[stop_listener_thread->[node_address_from_userid],create_room->[_mkroom,create_room],_handle_message->[node_address_from_userid],_handle_responses->[_mkroom,node_address_from_userid],set_presence_state->[_send],stop->[stop_listener_thread],__init__->[GMatrixHttpApi],listen_forever->[node_address_from_us... | Handles the response of a network response. Handle an ephemeral event. | Why would there suddenly be other types? We only add a filter... |
@@ -14,6 +14,8 @@ import org.mule.runtime.deployment.model.api.policy.PolicyTemplate;
*/
public class PolicyTemplateCreationException extends RuntimeException {
+ private static final long serialVersionUID = 290125840011127492L;
+
/**
* {@inheritDoc}
*/
| [No CFG could be retrieved] | Thrown when creating a new policy template artifact. | this serialization ID does not represent a potential problem in case this is serialized? Why was this added without any modification to the class? Was this calculated in any way. |
@@ -33,8 +33,10 @@ module Engine
GAME_INFO_URL = 'https://google.com'
HOME_TOKEN_TIMING = :operating_round
+ MUST_BUY_TRAIN = :always
+ NEXT_SR_PLAYER_ORDER = :most_cash
- BIDDING_TOKES = {
+ BIDDING_TOKENS = {
"3": 6,
"4": 5,
"5": 4,
| [G1822->[operating_round->[new],setup_minors->[coordinates,add_reservation!,hex_by_id,each,city],register_colors,freeze,include,load_from_json],require_relative] | Create a new base object with all the basic components of the n - ary object. Reserve all the minor cities. | maybe we should separate this and sorted_corporations out into an include since it's the same for 1867 and 1822 |
@@ -202,11 +202,11 @@ void process(struct dt_iop_module_t *self, dt_dev_pixelpipe_iop_t *piece, const
// Matrices from CIE 1931 2° XYZ D50 to Filmlight grading RGB D65 through CIE 2006 LMS
const float XYZ_to_gradRGB[3][4] = { { 0.53346004f, 0.15226970f , -0.19946283f, 0.f },
- ... | [No CFG could be retrieved] | Color Balancer gb data. Premultiply the pipe RGB - XYZ and grading RGB matrices to spare 2 matrix products. | for_four_channel(c) white_grading_RGB[c] /= sum_white; |
@@ -99,7 +99,7 @@ func GitDiffIndex() ([]string, error) {
return nil, errors.Wrap(err, "failed to dissect git diff-index output")
}
- paths := strings.Split(m["paths"], "\t")
+ paths := strings.Split(m["paths"].(string), "\t")
if len(paths) > 1 {
modified = append(modified, paths[1])
} else {
| [CheckFormat->[ToLower,Title,Wrapf,Errorf],Title,Dir,Perm,Wrap,HasPrefix,Mode,Stat,NewBufferString,ReadFile,Clean,FindStringSubmatch,New,Errorf,RunV,MustCompile,NewScanner,HasSuffix,Text,Wrapf,Join,Output,Contains,Deps,ToSlash,ToLower,Ext,Base,Scan,Check,Split,Err,NewReplacer,Command,Printf,CheckFormat,Println,Unmarsha... | GitDiffIndex returns a list of files that differ from what is committed modified or moved. CheckNosetestsNotExecutable runs git diff and checks that all of the noset. | Why this change here? |
@@ -14,6 +14,7 @@ void GuidPartitionTable::insert(const OpenDDS::DCPS::GUID_t& guid, const DDS::St
parts.insert("");
}
+ const Result result = guid_to_partitions_.count(guid) == 0 ? ADDED : UPDATED;
const auto& x = guid_to_partitions_[guid];
std::vector<std::string> to_add;
| [insert->[ACE_GUARD,OrderedGuidSet,ACE_TEXT,write,partition_to_guid_,insert,end,add_new,empty,begin,populate_replay,erase,remove,partitions,StringSet,length,ACE_ERROR]] | Inserts a new partition into the partition table. Missing partition. | combine these to avoid needing to repeat the search (if UPDATED) |
@@ -12,7 +12,7 @@ from conans.client.tools.env import environment_append
from conans.client.tools.oss import detected_architecture, os_info
from conans.errors import ConanException
from conans.util.env_reader import get_env
-from conans.util.files import decode_text, save, mkdir_tmp
+from conans.util.files import de... | [vcvars->[vcvars_dict],vcvars_dict->[relevant_path,vcvars_command],vcvars_command->[find_windows_10_sdk,vs_installation_path],run_in_windows_bash->[escape_windows_cmd,unix_path],unix_path->[get_cased_path]] | Get the command to build a single object. Command for generating the properties file and building the command. | Sorry, I forgot to remove this unused import |
@@ -122,7 +122,10 @@ const TYPE_CHECK_TARGETS = {
// introduced. It is okay to remove a file from this list only when fixing a
// bug for cherry-pick.
'pride': {
- srcGlobs: PRIDE_FILES_GLOBS,
+ srcGlobs: [
+ ...PRIDE_FILES_GLOBS,
+ ...globby.sync('src/core/**/*.js').filter((p) => !p.includes('... | [No CFG could be retrieved] | The sources of the application are not expected to pass. A list of modules that should be included in AMP shadow. | Two bits: `TYPE_CHECK_TARGETS` should be an object literal, this will make it scan the file system on import. When dynamic values are needed, let's make it an anon function as the `extensions` target is. Second, let's leave this as `srcGlobs: PRIDE_FILES_GLOBS` and just add `'src/core/**/*.js` to `PRIDE_FILES_GLOBS`. A... |
@@ -2058,6 +2058,10 @@ describe('angular', function() {
it('should serialize undefined as undefined', function() {
expect(toJson(undefined)).toEqual(undefined);
});
+
+ it('should serialize invalid dates to null', function() {
+ expect(toJson(new Date(1 / 0))).toEqual('null');
+ });
});
... | [No CFG could be retrieved] | Checks that the JSON object is serializable. Checks that a node - like object resembling a Backbone Collection is not null and. | To cover more cases, put the invalid date inside an object (e.g. `toJson({when: new Date(1 / 0)})`). |
@@ -141,6 +141,8 @@ public class CompactionTask extends AbstractBatchIndexTask
@Nullable
private final Granularity segmentGranularity;
@Nullable
+ private final GranularitySpec granularitySpec;
+ @Nullable
private final ParallelIndexTuningConfig tuningConfig;
@JsonIgnore
private final SegmentProvide... | [CompactionTask->[createContextForSubtask->[getPriority],createDimensionsSpec->[getType],Builder->[build->[CompactionTask]],runTask->[isReady]]] | A context flag is used to ensure that the CompactionTasks s appenderators are not extern t h is a t e mplate. | You can remove this since it is no longer used |
@@ -861,6 +861,16 @@ EOT;
}
}
+ $core_checksums_files = array_filter( array_keys( $checksums ), array( $this, 'remove_wp_content_files_filter' ) );
+ $core_files = $this->get_wp_core_files();
+ $additional_files = array_diff( $core_files, $core_checksums_files );
+
+ if ( ! empty( $additional... | [Core_Command->[install->[_install],get_updates->[get_download_url],_multisite_convert->[get_error_message,tables,get_error_code],download->[cleanup_extra_files,getMessage,get_download_url,get_download_offer,has,import],_copy_overwrite_files->[isDir,getSubPathName],_extract->[extractTo,getFileName],update->[cleanup_ext... | Verify WordPress checksums. | Do we need this filter if we're ignoring the pathname above when producing the original set? |
@@ -46,7 +46,7 @@ class RequestAnalyzer implements RequestAnalyzerInterface
return;
}
- $attributes = new RequestAttributes(['host' => $request->getHost(), 'scheme' => $request->getScheme(), 'requestUri' => $request->getRequestUri()]);
+ $attributes = new RequestAttributes(['scheme... | [RequestAnalyzer->[getPostParameters->[getAttribute],getMatchType->[getAttribute],getCurrentLocalization->[getAttribute],getResourceLocatorPrefix->[getAttribute],getSegment->[getAttribute],getAttribute->[getAttribute],getResourceLocator->[getAttribute],getRedirect->[getAttribute],getPortalInformation->[getAttribute],va... | Analyze a request and add it to the request attributes if it is not already present. | I think the other variables here should also be moved to the `UrlRequestProcessor`, so that only the `RequestProcessor`s are writing into the `RequestAttributes`. However, I was not completely aware of the implications, so I left it like this. |
@@ -381,9 +381,7 @@ def thermald_thread() -> NoReturn:
# Check if we need to shut down
if power_monitor.should_shutdown(peripheralState, onroad_conditions["ignition"], in_car, off_ts, started_seen):
- cloudlog.info(f"shutting device down, offroad since {off_ts}")
- # TODO: add function for blockin... | [thermald_thread->[read_thermal,setup_eon_fan,set_offroad_alert_if_changed],handle_fan_eon->[set_eon_fan],read_thermal->[read_tz],main->[thermald_thread],main] | Thread that processes a single NVM - related resource in a thread. Get a specific panda sequence number from the panda state. Get a single nvme or modem object from the system. This function is called from the main thread. | Maybe you should add a timeout flag as well in case it gets stuck. And maybe overriding the info function instead with a blocking argument if possible. |
@@ -122,7 +122,7 @@ def reset_profiler():
core.reset_profiler()
-def start_profiler(state):
+def start_profiler(state, enable_timeline=True):
"""
Enable the profiler. Uers can use `fluid.profiler.start_profiler` and
`fluid.profiler.stop_profiler` to insert the code, except the usage of
| [profiler->[stop_profiler,start_profiler],reset_profiler->[reset_profiler]] | Starts the profiler. | Can we enable the timeline if call `enable_profiler`? |
@@ -1020,7 +1020,7 @@ vos_reserve_single(struct vos_io_context *ioc, uint16_t media,
D_ASSERT(ioc->ic_umoffs_cnt > 0);
umoff = ioc->ic_umoffs[ioc->ic_umoffs_cnt - 1];
- irec = (struct vos_irec_df *) umem_off2ptr(vos_obj2umm(obj), umoff);
+ irec = (struct vos_irec_df *) umem_off2ptr(vos_cont2umm(cont), umoff);
v... | [No CFG could be retrieved] | Reserve a single value record on the specified media. find the next record header offset. | This is probably my own ignorance, but how can the offset off of an object umem_base be the same as the offset off a container umem_base? |
@@ -4760,10 +4760,11 @@ def matmul(x, y, transpose_x=False, transpose_y=False, alpha=1.0, name=None):
if x_shape[-1] != y_shape[-2]:
raise ValueError("Invalid inputs for matmul.")
- if len(y_shape) > 2:
+ if len(y_shape) > 2 and len(x_shape) > 2:
for i, dim_x in enumer... | [ctc_greedy_decoder->[topk],py_func->[PyFuncRegistry],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],nce->[_init_by_numpy_array],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d... | Applies matrix multiplication to two tensors. Matrix - wise cross product of two variables. Compute the missing element in the cross product between two matrices. | If the len(y_shape) and `len(x_shape) > 2` are equal, the value of `y_shape[0:-2]` and `x_shape[0:-2]` should be equal. |
@@ -228,7 +228,7 @@ func (t *VirtualContainerHostConfigSpec) SetIsCreating(creating bool) {
// IsCreating is checking if this configuration is for one creating VCH VM
func (t *VirtualContainerHostConfigSpec) IsCreating() bool {
- return t.ExecutorConfig.ID == CreatingVCH
+ return strings.HasPrefix(t.ExecutorConfig.... | [X509Certificate->[IsNil,New,ParseCertificate],Certificate->[IsNil,X509KeyPair,New],SetMoref->[String]] | IsCreating - check if the container is creating. | I better name CreatingVCH as CreatingVCHPrefix or something like that. I also would use "creating" instead of "CreatingVCH" to be consistent with "init" |
@@ -107,6 +107,7 @@ public class XceiverClientGrpc extends XceiverClientSpi {
OzoneConfigKeys.OZONE_NETWORK_TOPOLOGY_AWARE_READ_KEY,
OzoneConfigKeys.OZONE_NETWORK_TOPOLOGY_AWARE_READ_DEFAULT);
this.caCert = caCert;
+ this.getBlockDNcache = new HashMap<>();
}
/**
| [XceiverClientGrpc->[reconnect->[connectToDatanode,isConnected],sendCommandAsync->[sendCommandAsync,onNext,onCompleted,isConnected],isConnected->[isConnected]]] | Creates a new instance of a XceiverClientGrpc class. Connects to the datanode with the given encoded token. | XceiverClientGrpc is shared across threads, do we need to make this ConcurrentHashMap? |
@@ -55,7 +55,8 @@ internal static partial class Interop
}
}
- private static unsafe byte[] ExtractBignum(SafeBignumHandle bignum, int targetSize)
+ [return: NotNullIfNotNull("bignum")]
+ private static unsafe byte[]? ExtractBignum(SafeBignumHandle? bignum, int targetSize)
... | [Interop->[Crypto->[ExtractBignum->[BigNumToBinary,GetBigNumBytes,ExtractBignum]]]] | ExtractBignum returns the specified number of bytes from the given bignum. If. | This is not valid. The method can still return null if `bignum` is not null... if `bignum.IsInvalid` is true. |
@@ -1873,6 +1873,8 @@ CUSTOMS_API_URL = env('CUSTOMS_API_URL', default=None)
CUSTOMS_API_KEY = env('CUSTOMS_API_KEY', default=None)
WAT_API_URL = env('WAT_API_URL', default=None)
WAT_API_KEY = env('WAT_API_KEY', default=None)
+ML_API_URL = env('ML_API_URL', default=None)
+ML_API_TIMEOUT = 10 # seconds
# Git(Hub) r... | [path->[join],get_raven_release->[fetch_git_sha,get,read,join,exists,open,loads],read_only_mode->[get,Exception],get_db_config->[update,db],,gethostname,join,env,dict,Env,r'^,bool,list,datetime,dirname,format,items,exists,float,read_env,Queue,path,keys,get,get_db_config,get_raven_release,lower] | Get the API key for the given user. | A longer prefix would be ideal. A two-letter abbreviation could mean many things. |
@@ -508,7 +508,7 @@ void manage_inactivity(const bool ignore_stepper_queue/*=false*/) {
const int HOME_DEBOUNCE_DELAY = 2500;
if (!IS_SD_PRINTING() && !READ(HOME_PIN)) {
if (!homeDebounceCount) {
- queue.inject_P(PSTR("G28"));
+ queue.enqueue_now_P(PSTR("G28"));
LCD_MESSAGEPGM(MS... | [No CFG could be retrieved] | Private methods - related to the various functions - related to the various functions - related to the if the current active_extruder has a reserved block and there is a previous move. | Seems to me that a `G28` would be fine to have cancel the remainder of the previous injected queue, otherwise who knows what would follow? |
@@ -81,13 +81,14 @@ class VtkM(CMakePackage, CudaPackage):
depends_on("tbb", when="+tbb")
depends_on("mpi", when="+mpi")
- for amdgpu_value in amdgpu_targets:
+ # Propagate AMD GPU target to kokkos for +rocm
+ for amdgpu_value in ROCmPackage.amdgpu_targets:
depends_on("kokkos@develop +rocm... | [VtkM->[check_install->[smoke_test],smoke_test->[write,print,Executable,working_dir,cmake,test,RuntimeError,open,listdir,rmtree],cmake_args->[satisfies,append,working_dir,print,format,join,InstallError],depends_on,conflicts,version,on_package_attributes,variant,run_after]] | Returns a list of options for the cuda command line. Check if a node has a missing object. Returns a list of options to use for the VDTKM. | Note I removed the amdgpu_targets for this because kokkos is already selecting the correct GPU targets. The new concretizer handles this correctly, so I removed it so when kokkos is able to handle other AMD GPU targets VTKm doesn't lag behind. |
@@ -21,6 +21,8 @@ from multiprocessing import Process
import os, sys
import time
+sys.exit(0)
+
class TestRecvOp(unittest.TestCase):
def test_send(self):
| [TestRecvOp->[init_client->[Constant,data,global_block,Executor,Send,run,program_guard,Program],init_serv->[Constant,scale,data,global_block,Executor,ListenAndServ,run,program_guard,do,Program],test_send->[init_client,system,CPUPlace,sleep,start,join,Process]],main] | Test sending of a message to the server. | Maybe add a TODO here, otherwise it's possible to forget. |
@@ -436,7 +436,9 @@ def _show_file_with_state(obj, state, new, controller):
def _show_jupyter_doc_with_state(obj, state, notebook_handle):
comms_target = make_id() if notebook_handle else None
- publish_display_data({'text/html': notebook_div(obj, comms_target)})
+ (script, div) = notebook_content(obj, co... | [show->[_run_notebook_hook],output_notebook->[_run_notebook_hook,output_notebook],_show_jupyter_doc_with_state->[_CommsHandle],push_notebook->[update],export_png->[save,_get_screenshot_as_png,_detect_filename],_get_svgs->[_save_layout_html,_wait_until_render_complete],_get_screenshot_as_png->[_crop_image,_save_layout_h... | Display a Jupyter document with a _CommsHandle. | publishing two messages here isn't ideal. I should refactor the ``script`` to create and embed a div. |
@@ -0,0 +1,9 @@
+class AmazonValidator < ActiveModel::EachValidator
+ def validate_each(record, attribute, value)
+ if value.present?
+ unless /amazon\.co\.jp\z/ === URI.parse(value).host
+ errors.add(:url, "にはAmazon.co.jpの商品URLを入力してください。")
+ end
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Unused method argument - `record`. If it's necessary, use `_` or `_record` as an argument name to indicate that it won't be used.<br>Unused method argument - `attribute`. If it's necessary, use `_` or `_attribute` as an argument name to indicate that it won't be used. |
@@ -2646,11 +2646,7 @@ void Temperature::isr() {
#if EITHER(ULTRA_LCD, EXTENSIBLE_UI)
void Temperature::set_heating_message(const uint8_t e) {
const bool heating = isHeatingHotend(e);
- #if HOTENDS > 1
- ui.status_printf_P(0, heating ? PSTR("E%i " MSG_HEATING) : PSTR("E%i " MSG_COOLING), int(... | [No CFG could be retrieved] | Print the name of the individual 1KHz ethernet network element and the state of the Print the state of the heater. | I would expect this to bloat the size of the binary more than the original code because it produces up to 12 PROGMEM strings where the previous code only generates 2 no matter how many hotends are present. |
@@ -8,6 +8,7 @@ from selfdrive.car.toyota.toyotacan import (
create_fcw_command, create_ui_command
)
from common.realtime import sec_since_boot
+from six.moves import range
class TestPackerMethods(unittest.TestCase):
| [TestPackerMethods->[test_correctness->[randint,create_fcw_command,assertEqual,create_accel_command,xrange,create_steer_command,create_ipas_steer_command,create_ui_command],test_performance->[sec_since_boot,randint,assertTrue,xrange,create_ui_command],setUp->[CANPackerOld,CANPacker]],main] | Set up the class variables for the toyota_rav4_hybrid_. | I don't like six, why do we need it here? |
@@ -123,10 +123,16 @@ public class PostgreSqlInterpreter extends Interpreter {
jdbcConnection = DriverManager.getConnection(url, user, password);
+ Set<String> keywordsCompletions = SqlCompleter.getSqlKeywordsCompletions(jdbcConnection);
+ Set<String> dataModelCompletions =
+ SqlCompleter.... | [PostgreSqlInterpreter->[close->[close],cancel->[cancel],executeSql->[close],interpret->[executeSql]]] | Open the connection. | Should it call jdbcConnection.close on catch or finally? |
@@ -1061,7 +1061,14 @@ func GeneratePackage(tool string, pkg *schema.Package) (map[string][]byte, error
if _, ok := files[relPath]; ok {
panic(errors.Errorf("duplicate file: %s", relPath))
}
- files[relPath] = []byte(contents)
+
+ // Run Go formatter on the code before saving to disk
+ formattedSource, err... | [genResource->[plainType,getDefaultValue,inputType,outputType],genType->[genInputTypes,genOutputTypes,details,genPlainType,tokenToType],plainType->[tokenToType,plainType],genFunction->[genPlainType],outputType->[tokenToType,outputType],getTypeImports->[getTypeImports,add],genConfig->[genHeader,getDefaultValue,getImport... | Invite all packages and functions in the package. fmt. Fprintf implements fmt. Printfer interface. | Nice! Didn't realize this was available as a package. |
@@ -290,12 +290,12 @@ static int chacha20_poly1305_cipher(EVP_CIPHER_CTX *ctx, unsigned char *out,
Poly1305_Update(POLY1305_ctx(actx), temp, POLY1305_BLOCK_SIZE);
}
- Poly1305_Final(POLY1305_ctx(actx), ctx->encrypt ? actx->tag
+ Poly1305_Final(POLY1305_ctx(actx), EVP_CIPHER_CTX_enc... | [int->[EVPerr,OPENSSL_memdup,chacha_init_key,ChaCha20_ctr32,Poly1305_Update,memcpy,Poly1305_Init,aead_data,chacha20_poly1305_cipher,OPENSSL_zalloc,OPENSSL_cleanse,chacha_cipher,CRYPTO_memcmp,Poly1305_ctx_size,data,CHACHA_U8TOU32,Poly1305_Final,POLY1305_ctx,memset]] | Poly1305 - CIPHER. finds the next non - zero byte in the input buffer and updates the state of the check if there is a tag in the ciphertext and if yes set it. | This line goes past 80 columns, needs being broken up differently. I suggest breaking the line after the comma. |
@@ -159,8 +159,9 @@ public class Configuration extends BaseConfiguration {
@Parameter(value = "deactivated_builtin_authentication_providers", converter = StringSetConverter.class)
private Set<String> deactivatedBuiltinAuthenticationProviders = Collections.emptySet();
+ // This is needed for backwards com... | [Configuration->[validatePasswordSecret->[getPasswordSecret],validateRootUser->[getRootPasswordSha2]]] | Returns true if this node is the master node. | Can we make this private again and add a getter with a `@Deprecated` annotation? That makes it clear in the IDE that the usage is deprecated. I think adding the annotation to the public field doesn't highlight it in the IDE. |
@@ -56,7 +56,7 @@ default, it will attempt to use a webserver both for obtaining and installing
the cert. Major SUBCOMMANDS are:
(default) run Obtain & install a cert in your current webserver
- auth Authenticate & obtain cert, but do not install it
+ certonly Obtain cert, but... | [_plugins_parsing->[add,add_group,add_plugin_args],_auth_from_domains->[_report_new_cert,_treat_as_renewal],revoke->[revoke,_determine_account],auth->[_auth_from_domains,_find_domains,_report_new_cert,choose_configurator_plugins,_init_le_client],_create_subparsers->[add,add_group,flag_default],setup_logging->[setup_log... | Command line interface for managing a single unique identifier. Return the domain of the node. | UI/UX question I don't know the answer to: Do we want to include `auth` here anymore? |
@@ -82,12 +82,10 @@ mem_pin_workaround(void)
D_GOTO(exit, crt_rc = -DER_MISC);
}
- /** Disable fastbins */
+ /* Disable fastbins; this option is not available on all systems */
rc = mallopt(M_MXFAST, 0);
- if (rc != 1) {
+ if (rc != 1)
D_ERROR("Failed to disable malloc fastbins: %d\n", errno);
- D_GOTO(exi... | [No CFG could be retrieved] | The function that is called from the initialization code. Initializes the object. | This should be a warning or info then, but not an error. |
@@ -307,9 +307,9 @@ class Scheduler:
def _metrics(self, session):
return self._from_value(self._native.lib.scheduler_metrics(self._scheduler, session))
- def poll_workunits(self, session) -> PolledWorkunits:
+ def poll_workunits(self, session, max_verbosity: int) -> PolledWorkunits:
resul... | [Scheduler->[lease_files_in_graph->[lease_files_in_graph],garbage_collect_store->[garbage_collect_store],new_nailgun_server->[new_nailgun_server],check_invalidation_watcher_liveness->[check_invalidation_watcher_liveness,_raise_or_return],graph_trace->[graph_trace],_register_task->[add_get_edge->[_to_type],_to_key,add_g... | Returns metrics for the given session. Get the list of nodes that are in the tree. | Maybe have this take `LogLevel` and convert it into `int` here, instead of on line 439. |
@@ -35,3 +35,7 @@ func fromBody(r *http.Request, data interface{}) error {
return nil
}
+
+func unixDial(_, addr string) (net.Conn, error) {
+ return net.Dial("unix", addr)
+}
| [Close,Trace,ReadAll,Unmarshal] | null - > null. | Ignore network argument here? This type seems a little strange. |
@@ -768,7 +768,7 @@ describe RequestMailer do
describe "comment_on_alert_plural" do
it 'should not create HTML entities in the subject line' do
- mail = RequestMailer.comment_on_alert_plural(FactoryGirl.create(:info_request, :title => "Here's a request"), 2, FactoryGirl.create(:comment))
+ mail = Re... | [send_alerts->[alert_new_response_reminders_internal],force_updated_at_to_past->[days,update_column,now],sent_alert_params->[get_last_public_response_event_id,id],kitten_mails->[select,body],email,create,let,it,fake_response,to,comment_on_alert,select,allow_new_responses_from,match,set_described_state,context,alert_ove... | sends a very overdue alert mail to creators of very overdue requests alert overdue requests. | Line is too long. [146/80] |
@@ -48,6 +48,13 @@ type RouteSpec struct {
// TLS provides the ability to configure certificates and termination for the route
TLS *TLSConfig `json:"tls,omitempty" description:"provides the ability to configure certificates and termination for the route"`
+
+ // RouterShard has information of a routing shard and ... | [No CFG could be retrieved] | Required. A host is a list of all the hosts that the router watches to route traffic. | don't want special flags like this in the spec... the fully qualified host should be reported in the status (either copied from spec.host, or displaying the allocated host), so a client can just consume the value from there without doing URL building |
@@ -97,7 +97,9 @@ env => {
toggleExperiment(win, 'amp-next-page', false);
});
- it('does not fetch the next document before 3 viewports away', function* () {
+ // This test is flaky on Headless Chrome on Travis because it does
+ // call fetchDocument.
+ it.skip('does not fetch the next document before 3 v... | [No CFG could be retrieved] | A javascript script that can be used to provide a function to provide a macro task that will Dispatch scroll event. | Add a TODO with the issue number. |
@@ -59,6 +59,7 @@ func createRouter(prefix string, svr *server.Server) *mux.Router {
router.HandleFunc("/api/v1/store/{id}", storeHandler.Get).Methods("GET")
router.HandleFunc("/api/v1/store/{id}", storeHandler.Delete).Methods("DELETE")
router.HandleFunc("/api/v1/store/{id}/label", storeHandler.SetLabels).Methods... | [Handle,NewRouter,New,Subrouter,GetHandler,HandleFunc,PathPrefix,Methods] | Router for all cluster resources. Routes to the list of all of the Hotspot stores. | Maybe better to handle it using namespaceHandler. What's your opinion? /cc @siddontang |
@@ -96,8 +96,8 @@ abstract class WebSocketProtocolHandler extends MessageToMessageDecoder<WebSocke
}
@Override
- public void write(final ChannelHandlerContext ctx, Object msg, ChannelPromise promise) {
- if (closeSent != null) {
+ public void write(final ChannelHandlerContext ctx, Object msg, P... | [WebSocketProtocolHandler->[close->[close],write->[write],exceptionCaught->[close]]] | Writes the given message to the channel. | Why is this additional check required now? |
@@ -594,7 +594,15 @@ namespace System.Text.Json.Serialization
}
internal virtual void WriteWithQuotes(Utf8JsonWriter writer, [DisallowNull] T value, JsonSerializerOptions options, ref WriteStack state)
- => ThrowHelper.ThrowNotSupportedException_DictionaryKeyTypeNotSupported(TypeToConvert... | [JsonConverter->[TryWriteDataExtensionProperty->[TryWrite],TryReadAsObject->[TryRead],WriteWithQuotesAsObject->[WriteWithQuotes],TryRead->[Read,OnTryRead],TryWrite->[TryWriteAsObject,IsNull,OnTryWrite]]] | Writes a value to a writer with quotes. | Since `string` is a reference type, this check cannot be optimized by the JIT. It's likely then that users registering a custom string comparer might experience unexpected performance regressions when serializing dictionary keys. Would it be possible to run a few benchmarks, and if performance difference is substantial... |
@@ -32,7 +32,16 @@ namespace NServiceBus.Timeout.Hosting.Windows
if (TimeoutsPersister.TryRemove(timeoutId, out timeoutData))
{
- MessageSender.Send(timeoutData.ToTransportMessage(), timeoutData.ToSendOptions(Configure.LocalAddress));
+ try
+ {
+ ... | [TimeoutDispatcherProcessor->[Start->[Start],Stop->[Stop]]] | Handle a TransportMessage. | I think we should set it to null? |
@@ -256,7 +256,7 @@ class Sharing_Admin {
<h3><?php _e( 'Live Preview', 'jetpack' ); ?></h3>
</td>
<td class="services">
- <h2<?php if ( count( $enabled['all'] ) > 0 ) echo ' style="display: none"'; ?>><?php _e( 'Sharing is off. Add services above to enable.', 'jetpack' ); ?></h2>
+ <h2<?ph... | [Sharing_Admin->[management_page->[output_preview,output_service]]] | Displays the administration page This is a template for the show - all - services - admin screen. Displays a table with all the services that are not enabled. Private method for generating the HTML for the unknown services. | Condition into multiple lines please. |
@@ -105,7 +105,10 @@ def test_command_line_append_flags(script, virtualenv, data):
"Analyzing links from page https://test.pypi.org"
in result.stdout
)
- assert "Skipping link %s" % data.find_links in result.stdout
+ assert (
+ 'Skipping link: not a file: {}'.format(data.find_links) ... | [test_env_vars_override_config_file->[remove,close,mkstemp,_test_env_vars_override_config_file],test_options_from_venv_config->[str,open,pip,write],test_config_file_override_stack->[_test_config_file_override_stack,remove,mkstemp,close],_test_env_vars_override_config_file->[,pip,clear,dedent],_test_config_file_override... | Test command line flags that append to defaults set by environmental variables. | IIRC this can just be `, result`, right? |
@@ -70,7 +70,7 @@ class Julia(Package):
depends_on("curl")
depends_on("git") # I think Julia @0.5: doesn't use git any more
depends_on("openssl")
- depends_on("python @2.7:2.999")
+ depends_on("python @2.7.0:2.999")
# Run-time dependencies:
# depends_on("arpack")
| [Julia->[install->[join_path,mkdirp,write,curl,Executable,isfile,git,join,julia,which,open,InstallError,make],variant,depends_on,version,patch]] | Returns a list of packages that are available on the system. Creates a new object from the given version of the n - item . | adding `.0` shall not make a difference to Version class and consequently to `depends_on`. |
@@ -82,7 +82,8 @@ final class AnnotationSubresourceMetadataFactory implements PropertyMetadataFact
$type = $propertyMetadata->getType();
$isCollection = $type->isCollection();
$resourceClass = $isCollection ? $type->getCollectionValueType()->getClassName() : $type->getClassName();
+ $m... | [AnnotationSubresourceMetadataFactory->[create->[create]]] | Updates the metadata with the subresource. | Shouldn't we check that `maxDepth` is `int` here? |
@@ -2184,7 +2184,10 @@ public abstract class SSLEngineTest {
engine.beginHandshake();
try {
engine.closeInbound();
- fail();
+ // Workaround for conscrypt bug
+ if (!Conscrypt.isEngineSupported(engine)) {
+ fail();
+ }
} ... | [SSLEngineTest->[clientInitiatedRenegotiationWithFatalAlertDoesNotInfiniteLoopServer->[initChannel->[userEventTriggered->[],TestByteBufAllocator]],MessageDelegatorChannelHandler->[channelRead0->[messageReceived]],writeAndVerifyReceived->[messageReceived],testBeginHandshakeAfterEngineClosed->[cleanupClientSslEngine],tes... | Tests whether the SSL engine should close inbound after the beginning of a handshake. | Which bug is this? Is there an github issue or similar that could be linked to? |
@@ -3,10 +3,12 @@ package evm_test
import (
"testing"
- "github.com/smartcontractkit/sqlx"
+ "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gopkg.in/guregu/null.v4"
+ "github.com/smartcontractkit/sqlx"
+
"github.com/smartcontractkit/chainlink/core/chains/evm"
"github.com/smar... | [CreateNode,ToInt,GetNodesByChainIDs,Equal,NewORM,Helper,NewSqlxDB,Chains,Nodes,GetChainsByIDs,NoError,StringFrom,Len,Int64,NewBigI,CreateChain] | testing - import evm_test templating Test_EVMORM_GetChainsByIDs - Test for the existence of a chain. | **nit** remove this space |
@@ -116,8 +116,13 @@ class GitDriver implements VcsDriverInterface
public function getTags()
{
if (null === $this->tags) {
+ $this->tags = array();
+
exec(sprintf('cd %s && git tag', escapeshellarg($this->tmpDir)), $output);
- $this->tags = array_combine... | [GitDriver->[getSource->[getUrl],getComposerInformation->[getUrl],hasComposerFile->[getComposerInformation]]] | Get tags. | There is a space missing after if here. |
@@ -39,6 +39,7 @@ func NewRevokeDeviceEngine(args RevokeDeviceEngineArgs, g *libkb.GlobalContext)
mode: RevokeDevice,
forceSelf: args.ForceSelf,
forceLast: args.ForceLast,
+ skipUserEk: args.SkipUserEK,
Contextified: libkb.NewContextified(g),
}
}
| [Run->[explicitOrImplicitDeviceID,getKIDsToRevoke]] | NewRevokeKeyEngine creates a new RevokeEngine from a given KID. IDsToRevoke returns the keys to revoke for the given user. | Maybe `skipUserEkForTesting` just to make it super obvious? |
@@ -72,8 +72,7 @@ namespace System.Net.Sockets
{
// The operation completed synchronously. Get a task for it.
t = saea.SocketError == SocketError.Success ?
- Task.FromResult(saea.AcceptSocket!) :
- Task.FromException<Socket>(GetExcept... | [Socket->[GetTaskForSendReceive->[Task],TaskSocketAsyncEventArgs->[GetCompletionResponsibility->[Task]],ReceiveFromAsync->[ReceiveFromAsync,ValueTask],AcceptAsync->[AcceptAsync],SendAsync->[ValueTask,SendAsync],SendToAsync->[ValueTask,SendToAsync],ReceiveMessageFromAsync->[ValueTask,ReceiveMessageFromAsync],AwaitableSo... | Accept the request asynchronously. | Note this is making the failure path more expensive for everyone, not just code using the APM methods. |
@@ -1,4 +1,4 @@
-<div class="dataset-key boolean-checkbox">
- <%= f.check_box :value %>
+<div class="dataset-key boolean-select">
<%= f.label :value, key.title %>
+ <%= f.select :value, [[_('No'), 0], [_('Yes'), 1]], include_blank: true %>
</div>
| [No CFG could be retrieved] | Hides the checkboxes for the boolean key. | Much nicer! Should add a `required` attribute to this to make sure someone selects it? |
@@ -968,7 +968,7 @@ public class RemoteTaskRunner implements WorkerTaskRunner, TaskLogStreamer
announcement.getTaskType(),
zkWorker.getWorker(),
TaskLocation.unknown(),
- runningTasks.get(taskId).getDataSou... | [RemoteTaskRunner->[tryAssignTask->[runPendingTasks,findWorkerRunningTask],scheduleTasksCleanupForWorker->[cancelWorkerCleanup],shutdown->[findWorkerRunningTask],run->[findWorkerRunningTask],start->[start],markWorkersLazy->[apply],getBlackListedWorkers->[getImmutableWorkerFromZK],announceTask->[isWorkerRunningTask],che... | Add a worker to the list of workers. This method is called when a task I got a chance to be run. check if there is a node in the cluster and if so start the worker. | If the task has already been shutdown, will this make it start back up again? |
@@ -172,8 +172,15 @@ public abstract class HttpServerTracer<REQUEST> {
return tracer.getCurrentSpan();
}
- public Scope withSpan(Span span) {
- return tracer.withSpan(span);
+ /**
+ * Creates new scoped context with the given span.
+ *
+ * <p>Attaches new context to the request to avoid creating du... | [HttpServerTracer->[end->[end],extract->[extract],endExceptionally->[onError,end],getCurrentSpan->[getCurrentSpan],setStatus->[setStatus],startSpan->[startSpan],withSpan->[withSpan]]] | This method is used to get the current span and set the response status. | what do u think of `startScope`? |
@@ -55,6 +55,11 @@ public class PassivationManagerImpl extends AbstractPassivationManager {
public void start() {
enabled = !persistenceManager.isReadOnly() && cfg.persistence().passivation() && cfg.persistence().usingStores();
if (enabled) {
+ if (!(persistenceManager instanceof PassivationPe... | [PassivationManagerImpl->[passivate->[isL1Key],passivateAsync->[isL1Key]]] | Checks if a is enabled. | When can this happen? |
@@ -95,8 +95,8 @@ def test_ignored(tmp_dir, scm):
tmp_dir.gen({"dir1": {"file1.jpg": "cont", "file2.txt": "cont"}})
tmp_dir.gen({".gitignore": "dir1/*.jpg"})
- assert scm.is_ignored(tmp_dir / "dir1" / "file1.jpg")
- assert not scm.is_ignored(tmp_dir / "dir1" / "file2.txt")
+ assert scm.is_ignored(s... | [test_gitignore_should_append_newline_to_gitignore->[fspath,ignore,gen,splitlines,read_text,write_text],test_init_git->[init,SCM,isinstance,fspath],TestSCMGit->[test_is_tracked->[assertTrue,remove,abspath,is_tracked,Git,add,commit,assertFalse],test_commit->[ls_files,assertIn,Git,add,commit]],test_git_stash_pop->[,Stash... | Test for ignored directories. | After the typing update these `str()` calls should no longer be needed |
@@ -1155,6 +1155,16 @@ public final class MethodType implements Serializable {
MethodType asCollectorType(Class<?> clz, int num1, int num2) {
throw OpenJDKCompileStub.OpenJDKCompileStubThrowError();
}
+
+ /*[IF Java18.3]*/
+ /**
+ * Returns the number of stack slots used by the described args in the MethodType.... | [MethodType->[writeObject->[returnType,writeObject,parameterArray],appendParameterTypes->[appendParameterTypes,methodType],parseIntoClasses->[nonPrimitiveClassFromString],methodType->[MethodType,methodType],equals->[equals],intern->[stackDescriptionBits],hashCode->[hashCode],unwrap->[methodType],readResolve->[methodTyp... | Returns a MethodHandle for the collector type. | The preprocessor tag around this is `[IF Sidecar19-SE-OpenJ9]` - shouldn't there be a new one for Java 10? |
@@ -13,9 +13,17 @@ func main() {
startTime := time.Now()
for i := 0; i < 1000; i++ {
- bls.Init(bls.BLS12_381)
var sec bls.SecretKey
sec.SetByCSPRNG()
+
+ if i == 0 {
+ testECKey, _ := ecdsa.GenerateKey(crypto.S256(), rand.Reader)
+ log.Printf("Secret Key: 0x%s", sec.GetHexString())
+ log.Printf("Se... | [Printf,Sign,Seconds,Init,Now,GetPublicKey,Fatal,SetByCSPRNG,Sub,Verify,Add,GetHexString] | main function import the message to sign and aggregate 1000 messages and return the message to verify. | what diff between testECKey and sec? one generated by ecdsa and one generated by bls |
@@ -178,6 +178,9 @@ class Boost(Package):
conflicts('+taggedlayout', when='+versionedlayout')
conflicts('+numpy', when='~python')
+ # boost-python in 1.72.0 broken with cxxstd=98
+ conflicts('cxxstd=98', when='+mpi+python @1.72.0:')
+
# Container's Extended Allocators were not added until 1.56.0
... | [Boost->[determine_bootstrap_options->[determine_toolset,bjam_python_line],install->[determine_bootstrap_options,add_buildopt_symlinks,determine_b2_options],determine_b2_options->[determine_toolset]]] | Create a new ethernet package. Deprecated. Use with caution!. | So it's not broken with `+mpi~python`, `~mpi+python`, or any other possible combo? Just making sure. |
@@ -193,6 +193,12 @@ func resourceAwsRedshiftCluster() *schema.Resource {
Computed: true,
},
+ "dns_name": {
+ Type: schema.TypeString,
+ Optional: true,
+ Computed: true,
+ },
+
"cluster_public_key": {
Type: schema.TypeString,
Optional: true,
| [Difference,GetChange,SetPartial,DisableLogging,CreateCluster,Partial,ModifyCluster,Set,NonRetryableError,MatchString,GetOk,DescribeClusters,HasChange,Errorf,Len,SetId,ModifyClusterIamRoles,RetryableError,MustCompile,Bool,DisableSnapshotCopy,DescribeLoggingStatus,ToLower,Id,Int64,Get,DeleteCluster,Printf,Sprintf,Restor... | Schema specification for a Cluster. Create a copy of the resource with optional header fields. | Any reason to not call this `address` to match the API? |
@@ -29,6 +29,8 @@ import (
"path"
"strings"
+ "path/filepath"
+
"github.com/elastic/beats/libbeat/common"
"github.com/elastic/beats/libbeat/kibana"
)
| [Dir,NewRequest,Close,Encode,Exit,WriteFile,Add,Put,Usage,GetValue,Errorf,Join,LoadFile,Unpack,Do,MkdirAll,Printf,Unmarshal,RemoveIndexPattern,String,StringToPrint,Parse,ReadAll,BoolVar] | Exports a single object to a JSON file. get returns the unique id of the object in the system. | This one isn't grouped with the other stdlibs. I wish goimports would just put them all together automatically. |
@@ -136,12 +136,13 @@ func (c *outputController) Set(outGrp outputs.Group) {
// restart consumer (potentially blocked by retryer)
c.consumer.sigContinue()
+ c.consumer.sigUnWait()
c.observer.updateOutputGroup()
}
func makeWorkQueue() workQueue {
- return workQueue(make(chan *Batch, 0))
+ return workQueue(... | [Close->[Close,sigPause,close],Reload->[Set,Name,Unpack],Set->[sigOutputAdded,updateOutputGroup,Close,sigPause,sigOutputRemoved,sigContinue,updOutput],sigContinue] | Set creates a new outputGroup and adds it to the work queue. getnanocoreonisiste fails if there is an error. | `sigUnWait` is used by the retryer, no? Why add it here? |
@@ -370,8 +370,15 @@ void MmgProcess<TMMGLibrary>::InitializeSolDataMetric()
{
KRATOS_TRY;
- // We initialize the solution data with the given modelpart
- mMmgUtilities.GenerateSolDataFromModelPart(mrThisModelPart);
+ if (mDiscretization == DiscretizationOption::ISOSURFACE) {
+ // This will only... | [No CFG could be retrieved] | Initialize the solution data based on the given modelpart. Get the isosurface variable and value from the nodes. | I think I added a static check for the version in some place |
@@ -210,10 +210,11 @@ static void encoder_destruct_EVP_PKEY(void *arg)
static int ossl_encoder_ctx_setup_for_EVP_PKEY(OSSL_ENCODER_CTX *ctx,
const EVP_PKEY *pkey,
int selection,
- ... | [No CFG could be retrieved] | Creates a new EVP_PKEY object from a given keymgmt object. Select the first encoder implementation that matches the keymgmt implementation. | Static analyser will not like derefs on the pkey followed by a check for pkey == NULL. |
@@ -59,10 +59,9 @@ public class SparkWriteHelper<T extends HoodieRecordPayload,R> extends AbstractW
}).reduceByKey((rec1, rec2) -> {
@SuppressWarnings("unchecked")
T reducedData = (T) rec1.getData().preCombine(rec2.getData());
- // we cannot allow the user to change the key or partitionPath, sin... | [SparkWriteHelper->[WriteHelperHolder->[SparkWriteHelper]]] | Deduplicate records with a given . | Hi @rmpifer thanks for your contribution It seems ` rec1.getKey()` equals `rec2.getKey()` ? each of them is ok. |
@@ -105,9 +105,9 @@ function events_post(App $a) {
goaway($onerror_url);
}
- if((! $summary) || (! $start)) {
+ if ((! $summary) || (! $start)) {
notice( t('Event title and start time are required.') . EOL);
- if(intval($_REQUEST['preview'])) {
+ if (intval($_REQUEST['preview'])) {
echo( t('Event title ... | [No CFG could be retrieved] | Post an event to the event store This is the main entry point for the event system. It can be called after the event This function is used to create a new event object. This function is used to display a single event in the event store. | Standards: Please remove parentheses from language constructs. |
@@ -141,6 +141,12 @@ function $RouteProvider(){
* Adds a new route definition to the `$route` service.
*/
this.when = function(path, route) {
+ if (path instanceof Array) {
+ for(var i = 0; i < path.length; i++) {
+ self.when(path[i], route);
+ }
+ return this;
+ }
routes[pat... | [No CFG could be retrieved] | This service is used to add a new route definition to the route service. Normalizes a given path returning a regular expression and the original path. | Shouldn't we be using `isArray()` instead ? |
@@ -452,6 +452,7 @@ class Collection(SeoModel):
Product, blank=True, related_name='collections')
background_image = VersatileImageField(
upload_to='collection-backgrounds', blank=True, null=True)
+ background_image_alt = models.CharField(max_length=128, blank=True)
is_published = models.B... | [ProductVariant->[get_absolute_url->[get_slug],get_ajax_label->[display_product,get_price],get_first_image->[get_first_image]],CollectionQuerySet->[visible_to_user->[public]],Product->[is_in_stock->[is_in_stock]],ProductQuerySet->[visible_to_user->[available_products]]] | A class that represents a single product object. Model for the unique_code field. | How about changing that to just `image`? and `background_image_alt` to `image_alt`? Right now we are using this image in way more places than just the background, also we should not predefine the usage at the database level, what if someone wants to use it, as for example, a thumbnail? |
@@ -81,7 +81,8 @@ class RubricCriterion < Criterion
# does not evaluate to a float, or if the criterion is not
# successfully saved.
def self.create_or_update_from_csv_row(row, assignment)
- if row.length < RUBRIC_LEVELS + 2
+ # we only require the user to upload... | [RubricCriterion->[add_tas->[create,size,to_a,each,assignment],mark_for->[first],load_from_yml->[to_s,max_mark,new,nil?,ta_visible,peer_visible,each,name],update_assigned_groups_count->[get_groupings_by_assignment,concat,assigned_groups_count,each,length],remove_tas->[empty?,to_a,criterion_ta_associations,destroy,each,... | Creates or updates a specific node in the database from a CSV row. | Style/ZeroLengthPredicate: Use empty? instead of length < 1. |
@@ -1476,6 +1476,8 @@ function radioInputType(scope, element, attr, ctrl) {
ctrl.$render = function() {
var value = attr.value;
+ // Strict comparison would cause a BC
+ /* jshint eqeqeq:false */
element[0].checked = (value == ctrl.$viewValue);
};
| [No CFG could be retrieved] | Input type for radio and checkbox. Check - on - click handler for the checkbox. | Are you sure ? From a (super) quick look, we seems to be updating `$viewValue` with `attr.value` and here we are comparing it with `attr.value` again. |
@@ -724,6 +724,17 @@ func (l *TeamLoader) load2InnerLockedRetry(ctx context.Context, arg load2ArgT) (
}
}
+ if ret == nil {
+ return nil, fmt.Errorf("team loader fault: got nil from load2")
+ }
+
+ encKID, gen, role, err := l.hiddenPackageGetter(mctx, arg.teamID, ret, arg.me)()
+ if err != nil {
+ return nil, ... | [checkArg->[String],ResolveNameToIDUntrusted->[Load,String],ClearMem->[ClearMem],mapTeamAncestorsHelper->[load2],NotifyTeamRename->[load2],isImplicitAdminOf->[load2],ImplicitAdmins->[String],load2Inner->[String],MapTeamAncestors->[load1],checkNeedRotateWithSigner->[isAllowedKeyerOf],load1->[ResolveNameToIDUntrusted,Str... | load2InnerLockedRetry is the inner function that does the actual load2. It is Load a Merkle tree and return a pointer to it. Load2 loads a child operation from the cache. This function is called when a user requests a secret and a link to the server. | can you say why we do this? seems like we really only need to do this for the hidden bot case, wanting to skip seedchecks... |
@@ -20,7 +20,8 @@ namespace Content.Server.Power.EntitySystems
private readonly HashSet<PowerNet> _powerNetReconnectQueue = new();
private readonly HashSet<ApcNet> _apcNetReconnectQueue = new();
- private readonly Dictionary<PowerNetworkBatteryComponent, float> _lastSupply = new();
+ p... | [No CFG could be retrieved] | Creates a power network system that manages power state and power components. Called when the application is paused. | PJB disliked that I used the dictionary and these should be stored on the component. |
@@ -1157,6 +1157,9 @@ void Planner::_buffer_line(const float &a, const float &b, const float &c, const
}
#endif // XY_FREQUENCY_LIMIT
+ block->nominal_speed = max_stepper_speed; // (mm/sec) Always > 0
+ block->nominal_rate = CEIL(block->step_event_count * inverse_mm_s); // (step/sec) Always > 0
+
// Cor... | [No CFG could be retrieved] | compute the acceleration rate and the acceleration rate for the trapezoid generator \ Function to compute acceleration. | `inverse_mm_s` is now called `inverse_secs` because that's its actual meaning. Are you working from the latest code?? |
@@ -68,7 +68,7 @@ namespace System.Data.Common
throw ADP.InvalidMultipartNameToManyParts(property, name, limit);
}
- if (-1 != leftQuote.IndexOf(separator) || -1 != rightQuote.IndexOf(separator) || leftQuote.Length != rightQuote.Length)
+ if (leftQuote.IndexOf(separ... | [MultipartIdentifier->[ParseMultipartIdentifier->[ParseMultipartIdentifier,IncrementStringCount,IsWhitespace]]] | Parse a multipart identifier. Private method for parsing a name. Append the string and check if it is a whitespace character. NameIncorrectUsageOfQuotes - This method checks if the name is in the string array and. | .... should we have a `NOT_FOUND` constant for the `IndexOf` comparisons? Also, the current comparisons make my brain hurt for what they're saying ("not not found"). Should some of these be switched to `Contains`, and others to testing against a positive index? (In another PR, obviously) |
@@ -40,6 +40,10 @@ import org.apache.commons.io.IOUtils;
public class SwaggerConnectorComponent extends DefaultConnectorComponent {
+ private String accessToken;
+
+ private AuthenticationType authenticationType;
+
private String specification;
public SwaggerConnectorComponent() {
| [SwaggerConnectorComponent->[createEndpoint->[createEndpoint]]] | Produces a component that uses a Swagger specification. Write the specification to the output. | Normally I'd prefer to add a `AuthenticationType.addToHeaders()` methods which avoid such if-else checks. But I'm fine with this (i.e. if authenticationType can be null) |
@@ -17,8 +17,7 @@ import numpy as np
import contextlib
__all__ = [
- 'Constant', 'Uniform', 'Normal', 'Xavier', 'force_init_on_cpu',
- 'init_on_cpu'
+ 'ConstantInitializer', 'UniformInitializer', 'NormalInitializer', 'XavierInitializer', 'Constant', 'Uniform', 'Normal', 'Xavier', 'force_init_on_cpu','init_... | [init_on_cpu->[force_init_on_cpu],MSRAInitializer->[__call__->[_compute_fans]],ConstantInitializer->[__call__->[force_init_on_cpu]],XavierInitializer->[__call__->[_compute_fans]]] | Creates a base class for the common interface of variable initializers. Compute the fan_in and fan_out for neural network layers if not specified. | I am not sure why we need to do this? Constant == ConstantInitializer, Uniform = UniformInitializer and so on. Could you elaborate why we need this change |
@@ -2757,6 +2757,10 @@ namespace Js
}
functionConstructor->SetHasNoEnumerableProperties(true);
+#ifdef ALLOW_JIT_REPRO
+ library->AddFunctionToLibraryObject(functionConstructor, PropertyIds::invokeJit, &JavascriptFunction::EntryInfo::InvokeJit, 1);
+#endif
+
return true;
}
| [No CFG could be retrieved] | Initialize a function constructor. | I think it would be good to have this behind a config flag as well |
@@ -78,7 +78,7 @@ public class External {
private static AtomicInteger namespaceCounter = new AtomicInteger(0);
private static final ExpansionServiceClientFactory DEFAULT =
- new DefaultExpansionServiceClientFactory(
+ DefaultExpansionServiceClientFactory.create(
endPoint -> ManagedChannelBu... | [External->[ExpandableTransform->[resolveArtifacts->[resolveArtifacts],expand->[of,expand,toOutputCollection],isJavaSDKCompatible->[isJavaSDKCompatible]],of->[getFreshNamespaceIndex]]] | get a fresh namespace index. | @iemejia looks like this indentation change breaks the spotless check: Execution failed for task ':runners:core-construction-java:spotlessJavaCheck'. > The following files had format violations: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java @@ -78,7 +78,7 @@ privat... |
@@ -251,6 +251,8 @@ class Jetpack_Top_Posts_Widget extends WP_Widget {
/** This filter is documented in modules/stats.php */
'gravatar_default' => apply_filters( 'jetpack_static_url', set_url_scheme( 'https://en.wordpress.com/i/logo/white-gray-80.png' ) ),
'avatar_size' => 40,
+ 'width' => null,
+ ... | [Jetpack_Top_Posts_Widget->[get_by_views->[get_posts],get_fallback_posts->[query,get_posts],get_by_likes->[get_posts],form->[get_field_id,defaults,get_field_name],widget->[defaults,get_by_views,get_fallback_posts,get_by_likes]]] | Displays a Top Posts widget Top Posts Widget Image options Displays the top post list Filters the permalink of items in the Top Posts widget and fires after each Top Post result Renders the top - post list layout. | Should add these to the docblock about `jetpack_top_posts_widget_image_options` below. |
@@ -88,14 +88,14 @@ public class JaasAuthenticationHandler extends AbstractUsernamePasswordAuthentic
/** {@inheritDoc} */
@Override
- protected final Principal authenticateUsernamePasswordInternal(final String username, final String password)
+ protected final HandlerResult authenticateUsernamePasswor... | [JaasAuthenticationHandler->[UsernamePasswordCallbackHandler->[handle->[equals,UnsupportedCallbackException,setName,setPassword,toCharArray]],authenticateUsernamePasswordInternal->[SimplePrincipal,debug,logout,size,getName,login,UsernamePasswordCallbackHandler,getPrincipals,LoginContext],getConfiguration,notNull]] | Internal method to authenticate a username and password. | For me, it would make sense to create a `username` property from `credential.getUsername()` if we use it more than once. And this remark is true for all handlers. Don't you think? |
@@ -484,6 +484,13 @@ class BasePipeline(object):
self.calltypes = defaultdict(lambda: types.pyobject)
self.return_type = types.pyobject
+ def stage_literal_arg(self):
+ """
+ Rewrite to move annotation about literals argument.
+ """
+ assert self.func_ir
+ find_... | [compile_ir->[compile_local->[compile_ir],compile_local,compile_ir],ir_processing_stage->[run],compile_result->[CompileResult],compile_internal->[Pipeline,compile_extra],Pipeline->[define_pipelines->[define_objectmode_pipeline,define_interpreted_pipeline,define_nopython_pipeline]],BasePipeline->[stage_objectmode_backen... | Stage the objectmode frontend. | I'm not sure that this is a rewrite? Seems like analysis? |
@@ -70,6 +70,16 @@ public class ScaleVMCmd extends BaseAsyncCmd implements UserCmd {
@Parameter(name = ApiConstants.DETAILS, type = BaseCmd.CommandType.MAP, description = "name value pairs of custom parameters for cpu,memory and cpunumber. example details[i].name=value")
private Map<String, String> details;
... | [ScaleVMCmd->[getEntityOwnerId->[getId],execute->[getCommandName],getEventDescription->[getId,getServiceOfferingId]]] | Returns the id of the node. | add "since" attribute to these parameters if needed. |
@@ -76,10 +76,15 @@ public class SchemaRegisterInjector implements Injector {
final LogicalSchema schema = cs.getStatement().getElements().toLogicalSchema();
+ final KsqlConfig ksqlConfig = cs.getConfig()
+ .cloneWithPropertyOverwrite(cs.getConfigOverrides());
+
+ final KsqlTopic ksqlTopic = Topic... | [SchemaRegisterInjector->[inject->[getStatement,registerForCreateSource,registerForCreateAs],registerSchema->[getSchemaRegistryClient,valueFeatures,of,from,value,KsqlStatementException,register,format,contains,isEmpty,toParsedSchema,name,KsqlSchemaRegistryNotConfiguredException,supportsSchemaInference],registerForCreat... | Register for create source. | SchemaRegisterInjector should delegate to `TopicFactory` to get key and value formats, so its not duplicating code. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.