patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -22,7 +22,7 @@ describe('filters', function() {
var pattern;
beforeEach(function() {
- pattern = { minInt: 1,
+ pattern = {
minFrac: 0,
maxFrac: 3,
posPre: '',
| [No CFG could be retrieved] | Replies the name of the expectation that the given filter is called when evaluating the expression. Check number format. | why remove minInt? |
@@ -53,6 +53,11 @@ module Users
end
end
+ def process_locked_out_user
+ render 'two_factor_authentication/shared/max_login_attempts_reached'
+ sign_out
+ end
+
def now
@_now ||= Time.zone.now
end
| [SessionsController->[cache_active_profile->[new],track_authentication_attempt->[new],now->[now]]] | Checks if the user needs a redirect. If it does it redirects to after_sign_. | do you think we should sign out then render? Not sure if it matters, just wondering if the page might render different content based on signed in / out status. |
@@ -203,7 +203,6 @@ namespace System
public static bool IsMacOSVersionAtLeast(int major, int minor = 0, int build = 0)
=> IsMacOS() && IsOSVersionAtLeast(major, minor, build, 0);
-/* Commented out for now, until we're ready to make changes to the public API
/// <summary>
/// In... | [No CFG could be retrieved] | Determines if a given version of the current application is running on a MacOS or a different Check for a given NIC in the TVOS release. | We should update the summary text here to make it clear that we're not using `libobjc.get_operatingSystemVersion` to get the host macOS version but returning the actual iOS support version that MacCatalyst targets. |
@@ -51,6 +51,9 @@ class NginxTlsSni01(common.TLSSNI01):
default_addr = "{0} ssl".format(
self.configurator.config.tls_sni_01_port)
+ ipv6info = self.configurator.ipv6_info(
+ self.configurator.config.tls_sni_01_port)
+
for achall in self.achalls:
vhost = s... | [NginxTlsSni01->[perform->[list,error,choose_vhost,append,fromstring,save,_mod_config,format,_setup_challenge_cert],_mod_config->[dump,UnspacedList,int,register_file_creation,MisconfigurationError,insert,_make_server_block,zip,open],_make_server_block->[get_cert_path,extend,response,join,get_key_path,to_string]],getLog... | Perform a challenge on a nginx. . | can you name the resulting booleans for clarity? |
@@ -45,6 +45,8 @@ import lombok.Getter;
*/
@Alpha
public class StaticFlowTemplate implements FlowTemplate {
+ private static final long serialVersionUID = 84641624233978L;
+
public static final String INPUT_DATASET_DESCRIPTOR_PREFIX = "gobblin.flow.dataset.descriptor.input";
public static final String OUTPUT... | [StaticFlowTemplate->[getDag->[ensureTemplateMaterialized]]] | Imports a static FlowTemplate. Construct a object. | Is this to avoid version conflict between SerDer? |
@@ -23,10 +23,9 @@ import java.util.concurrent.TimeUnit;
/**
* Interpreter related constants
- *
- *
*/
public class Constants {
+
public static final String ZEPPELIN_INTERPRETER_PORT = "zeppelin.interpreter.port";
public static final String ZEPPELIN_INTERPRETER_HOST = "zeppelin.interpreter.host";
| [Constants->[put]] | This class represents the static properties of a single object. Get the number of unique timestamps in the system. | should we move this to zeppelin-cluster module ? |
@@ -110,3 +110,13 @@ class Storage(metaclass=ABCMeta):
"""
schema = prefect.serialization.storage.StorageSchema()
return schema.dump(self)
+
+ def run_basic_healthchecks(self) -> None:
+ """
+ Runs basic healthchecks on the flows contained in this Storage class
+ """
+... | [Storage->[build->[NotImplementedError],serialize->[dump,StorageSchema],__repr__->[format,type],logger->[get_logger,type],name->[type],get_flow->[NotImplementedError],get_env_runner->[NotImplementedError]]] | Returns a serialized version of the Storage object. | So I'm wondering if we should keep this one or not; there are edge cases where this isn't necessarily required: - register flow w/ S3 storage off laptop - run flow using agent running on remote machine with all dependencies Not totally against it, as it's a good reminder for users, but just wanted to call it out |
@@ -0,0 +1,18 @@
+package gobblin.test.execution.operator;
+
+
+/**
+ * An interface for defining the operator , the operator could be a copy of file or converting a file from one format to another
+ *
+ * @author sveerama
+ */
+
+public interface Operator
+{
+ /**
+ * This method is invoked to execute an operator.... | [No CFG could be retrieved] | No Summary Found. | Are these operators only going to be used in the set up phase? If so then it may make more sense to call this SetupOperator |
@@ -1088,8 +1088,8 @@ bool MDNSResponder::setServiceProbeResultCallback(const MDNSResponder::hMDNSServ
bool MDNSResponder::setServiceProbeResultCallback(const MDNSResponder::hMDNSService p_hService,
MDNSResponder::MDNSServiceProbeFn1 p_fnCallback) {
- using namespac... | [No CFG could be retrieved] | Set a callback for probe results. The callback is called when the probe results for the host This is called when the user changes the configuration of an object. | What is obj? Prefer a more descriptive name. |
@@ -269,6 +269,8 @@ func (s *schedulerTestSuite) TestScheduler(c *C) {
"minor-dec-ratio": 0.99,
"src-tolerance-ratio": 1.05,
"dst-tolerance-ratio": 1.05,
+ "read-priorities": []interface{}{},
+ "write-priorities": []interface{}{},
}
c.Assert(conf, DeepEquals,... | [SetUpSuite->[Background,WithCancel],TearDownSuite->[cancel],TestScheduler->[SetScheduleConfig,MustPutStore,Now,GetConfig,MustPutRegion,GetClientURL,ExecuteCommand,GetScheduleConfig,GetServer,Assert,Destroy,GetRootCmd,UnixNano,Contains,BootstrapCluster,WaitLeader,Unmarshal,RunInitialServers,NewTestCluster,Sleep,GetLead... | TestScheduler tests that the scheduler is running check scheduler config check if the config is in the expected config check if the command is a valid scheduler config balance - hot - region - scheduler - shuffle - region - scheduler - show - roles - test hot region test test show scheduler with paused and disabled sta... | Perhaps, we can use a default priority. |
@@ -300,9 +300,14 @@ func zipEntries(readers map[string]entryReader, out *zip.Writer) error {
e, err := r.open()
if err != nil {
log.Warningf("error reading %s(%s): %s\n", name, r, err)
- continue
+
}
- sz := e.Size()
+
+ sz := int64(0)
+ if e != nil {
+ sz = e.Size()
+ }
+
header := &zip.FileHe... | [open->[BrowseLog,Begin,Sprintf,Vim25,Background,WriteByte,End,NewDiagnosticManager,Base,Bytes,WriteString],Seek,Size,Warningf,Now,Close,HasPrefix,Add,AttachedClusterHosts,Done,Copy,Flush,GetPprofEndpoint,Stop,ReadAt,IsVC,End,ReadDir,Errorf,TailFile,Wait,Debugf,NewWriter,Join,Infof,CreateHeader,Fprint,Name,LastIndexByt... | zipEntries zips the contents of the log into a tar. Header. tailFile writes the last n bytes of the log file to the writer. | this could also be `var sz int64` Looks a little neater. |
@@ -351,7 +351,12 @@ public final class DirectoryBrowserSupport implements HttpResponse {
VirtualFile f = dir.child(n);
e.setTime(f.lastModified());
zos.putNextEntry(e);
- Util.copyStream(f.open(), zos);
+ InputStream in = f.open();
+ try {
+ ... | [DirectoryBrowserSupport->[serveFile->[serveFile],FileComparator->[compare->[compare]],buildChildPaths->[FileComparator,Path],buildPathList->[Path,buildPathList]]] | Zip the contents of the directory with the given glob into the given output stream. | `in.close()` suffices. (I have ranted in many places about how `closeQuietly` and similar methods are evil. In `-source 7` we could use try-with-resources which would be better still.) |
@@ -21,9 +21,12 @@ class SiteConfiguration
:engine_overrides
].freeze
- DEFAULT_LOGO_PATH = "sites/logo-default.png".freeze
+ DEFAULT_LOGO_PATH = "sites/logo-default.png"
+ MODULES_WITH_NOTIFICATONS = %w(GobiertoPeople GobiertoBudgetConsultations GobiertoParticipation).freeze
+ MODULES_WITH_COLLECTIONS = ... | [SiteConfiguration->[available_locales->[available_locales],default_locale->[default_locale],available_module?]] | Initializes a new site configuration object. Defines the methods that are defined on the object. | Freeze mutable objects assigned to constants. |
@@ -433,6 +433,16 @@ public abstract class HttpObjectDecoder extends ByteToMessageDecoder {
// This method is responsible for ending requests in some situations and must be called
// when the input has been shutdown.
super.channelInactive(ctx);
+ } else if (evt instanceof H... | [HttpObjectDecoder->[userEventTriggered->[userEventTriggered],LineParser->[parse->[reset,parse]],decodeLast->[decode],readHeaders->[isContentAlwaysEmpty],resetNow->[reset],HeaderParser->[parse->[reset]]]] | Checks if a response has a reserved response code. | you could remove the break here and just let it fall through to default |
@@ -37,6 +37,9 @@ QueryData genOSVersion(QueryContext& context) {
}
// The version path plist is parsed by the OS X tool: sw_vers.
+ // We set a special ENV to ensure despite the fact Osquery is built against
+ // an pre Big Sur SDK, we want the modern numbering scheme for macOS.
+ setEnvVar("SYSTEM_VERSION_... | [genOSVersion->[LOG,INTEGER,size,uname,TEXT,at,empty]] | Generate the OS version information. | Shouldn't this be `0` ? |
@@ -69,7 +69,7 @@ public class ChannelFutureListenerInstrumentation extends Instrumenter.Default {
packageName + ".client.HttpClientResponseTracingHandler",
packageName + ".client.HttpClientTracingHandler",
// server helpers
- packageName + ".server.NettyHttpServerDecorator",
+ packageNam... | [ChannelFutureListenerInstrumentation->[OperationCompleteAdvice->[deactivateScope->[close],activateScope->[onError,getAndRemove,end,beforeFinish,cause,startSpan,currentContextWith]],typeMatcher->[named,implementsInterface],classLoaderMatcher->[hasClassesNamed],transformers->[named,getName,singletonMap,takesArgument,and... | Returns the list of helper class names. | i think all these server helpers can go away |
@@ -456,8 +456,12 @@ module Repository
@jobs.push(action: :add, path: path, file_data: file_data, mime_type: mime_type)
end
- def remove(path, expected_revision_identifier)
- @jobs.push(action: :remove, path: path, expected_revision_identifier: expected_revision_identifier)
+ def remove(path, e... | [AbstractRepository->[redis_exclusive_lock->[to_s],update_permissions->[get_full_access_users,to_s],get_users->[get_full_access_users],update_permissions_after->[update_permissions]]] | Adds a new job to the job queue. | You've changed the signature of this method by adding a required argument called `option`. Have you made sure that every piece of code that calls `remove` will provide an argument for `option`? What might be a better way of passing this argument to the `remove` method? |
@@ -118,6 +118,7 @@ function cleanupOldFiles(generator) {
generator.removeFile(`${ANGULAR_DIR}shared/login/login.component.ts`);
generator.removeFile(`${ANGULAR_DIR}shared/login/login.component.html`);
generator.removeFile(`${ANGULAR_DIR}core/auth/user-route-access-service.ts`);
+... | [No CFG could be retrieved] | Removes all TSL files from the TSL directory. Removes all the files from the shared folder. | You shouldn't do this way, 2 options here: - remove when not needed - use `this.fs.delete(this.destinationPath(...));` Otherwise any change to the file will be overwritten every regeneration. |
@@ -342,6 +342,12 @@ public class StringDimensionMergerV9 implements DimensionMergerV9<int[]>
spatialWriter.close();
}
+ if (dictionaryMergeBufferAllocations != null) {
+ for (Pair<ByteBuffer, Integer> bufferAllocation : dictionaryMergeBufferAllocations) {
+ log.info("Freeing dict... | [StringDimensionMergerV9->[toIndexSeekers->[IndexSeekerWithConversion,size,get,IndexSeekerWithoutConversion],ConvertingIndexedInts->[size->[size],get->[get],iterator->[nextInt->[nextInt,get],skip->[skip],hasNext->[hasNext],iterator]],writeIndexes->[close]]] | Writes all the indexes to the output directory. no - op if no data in the dictionary. | It would be better to structure this as a `close()` method on the iterator (have it implement both `Iterator` and `Closeable`) and to ensure, through a try-with-resources, that the iterator is actually closed. It's better for a couple reasons: encapsulation of resources (the thing that allocates the resources also clea... |
@@ -692,7 +692,7 @@ namespace System.Drawing.Drawing2D
Flatten(matrix, FlatnessDefault);
}
- public void Flatten(Matrix matrix, float flatness)
+ public void Flatten(Matrix? matrix, float flatness)
{
IntPtr m = (matrix == null) ? IntPtr.Zero : matrix.NativeMat... | [GraphicsPath->[Widen->[Widen],AddString->[AddString],IsVisible->[IsVisible],Flatten->[Flatten],Dispose->[Dispose],Warp->[Warp],IsOutlineVisible->[IsOutlineVisible],Dispose]] | Flatten the given matrix. | Cannot write on row 626-653: For all overloads of `public void AddString(string s, FontFamily family, int style, float emSize, PointF origin, StringFormat format)` method `format` is nullable |
@@ -14,7 +14,12 @@ namespace Content.Server.Alert.Click
{
public void AlertClicked(ClickAlertEventArgs args)
{
- args.Player.GetComponentOrNull<SharedPullableComponent>()?.TryStopPull(args.Player);
+ var ps = EntitySystem.Get<SharedPullingSystem>();
+ var playerPu... | [StopBeingPulled->[AlertClicked->[Player]]] | Called when an alert is clicked. | could just use a `TryGetComponent` here |
@@ -154,10 +154,6 @@ public class SqlPredicateTest {
"Error evaluating predicate (TEST1.COL0 > 100): "
+ "Invalid field type. Value must be Long.")
);
- final String rowString =
- errorStruct.getString(ProcessingLogMessageSchema.RECORD_PROCESSING_ERROR_FIELD_RECORD);
- fi... | [SqlPredicateTest->[givenSqlPredicateFor->[buildLogicalPlan]]] | Checks if record processing error should be written. | super nit: test no longer needs `throw IOException` with this removal. |
@@ -34,6 +34,8 @@ class Discourse::Cors
origin = nil
if cors_origins
+ cors_origins = cors_origins.map { |x| x.chomp('/') }
+
if origin = env['HTTP_ORIGIN']
origin = nil unless cors_origins.include?(origin)
end
| [call->[call,split,apply_headers,present?,presence],initialize->[present?,enable_cors,map],apply_headers->[include?],insert_before,enable_cors] | Applies the appropriate CORS headers to the given Hash. | should we not chomp it a bit earlier at ` cors_origins += SiteSetting.cors_origins.split('|') if SiteSetting.cors_origins.present?` |
@@ -302,12 +302,14 @@ namespace System.Drawing.Drawing2D
// depending on how sane the input is. These checks exist to replicate the exact Desktop behavior.
int count = value.Colors.Length;
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
i... | [PathGradientBrush->[ScaleTransform->[ScaleTransform],SetSigmaBellShape->[SetSigmaBellShape],MultiplyTransform->[MultiplyTransform],RotateTransform->[RotateTransform],TranslateTransform->[TranslateTransform],SetBlendTriangularShape->[SetBlendTriangularShape]]] | Retrieve a color blend from the GDIF. Matrix that can be used to calculate the gradient of the path. | Simlar question here. Why don't we pass `value` here? |
@@ -29,6 +29,9 @@ def test_cross_x86():
if self.settings.os == "Windows":
del self.options.fPIC
+ def layout(self):
+ self.folders.build = "build"
+
def generate(self):
tc = MesonToolchain(self)
tc.generate(... | [test_cross_x86->[gen_function_cpp,dedent,run_command,TestClient,run,join,save],skipif,system] | Test cross - x86. | Meson needs a clean folder, it was hardcoding "build" in ``Meson`` helper directly. Now it requires defining ``layout()`` better than that. |
@@ -0,0 +1,15 @@
+package includes
+
+import (
+ // load supported output plugins
+ _ "github.com/elastic/beats/libbeat/outputs/console"
+ _ "github.com/elastic/beats/libbeat/outputs/elasticsearch"
+ _ "github.com/elastic/beats/libbeat/outputs/fileout"
+ _ "github.com/elastic/beats/libbeat/outputs/kafka"
+ _ "github.co... | [No CFG could be retrieved] | No Summary Found. | we could generate this in the future ... but as we are not going to add outputs ... |
@@ -209,7 +209,7 @@ public class GameSelectorModel extends Observable {
* on startup.
*/
public void loadDefaultGameSameThread() {
- final String userPreferredDefaultGameUri = ClientSetting.defaultGameUri.value();
+ final String userPreferredDefaultGameUri = ClientSetting.defaultGameUri.getValue().orEl... | [GameSelectorModel->[selectByName->[resetToFactoryDefault],loadDefaultGameSameThread->[load,loadDefaultGameSameThread],setGameData->[getGameName]]] | Load a default game file if it is not already loaded. | The code below already handles an empty string as a signal that the setting is not defined. |
@@ -3539,6 +3539,7 @@ func TestKBFSOpsMaliciousMDServerRange(t *testing.T) {
// Create mallory's fake TLF using the same TLF ID as alice's.
config2 := ConfigAsUser(config1, "mallory")
+ defer func() { _ = config2.Shutdown(ctx) }()
config2.SetMode(modeNoHistory{config2.Mode()})
crypto2 := cryptoFixedTlf{config... | [WrapChild->[WrapChild,IsDir],Ready->[Ready],Get->[Get],Commit->[Commit],Put->[Put],ShouldCreateMissedLookup->[ShouldCreateMissedLookup],isShutdown->[isShutdown],Mode,Readonly,Get] | MakeRandomTlfID creates a random TLF ID from the given cryptoFixedTlf. Adds some operations to get alice s TLF and mallory s TLF. | Why the extra closure? `config2` isn't re-assigned after this. |
@@ -77,7 +77,7 @@ class GenerateLockfilesSubsystem(GoalSubsystem):
"Only generate lockfiles for the specified resolve(s).\n\n"
"Resolves are the logical names for the different lockfiles used in your project. "
"For your own code's dependencies, these come from the opt... | [setup_user_lockfile_requests->[PythonLockfileRequest,_UserLockfileRequests],determine_resolves_to_generate->[AmbiguousResolveNamesError],generate_lockfile->[PythonLockfile],generate_lockfiles_goal->[_SpecifiedUserResolves,GenerateLockfilesGoal]] | Register options for the Pants command. | Consider dropping `experimental` here, since we're planning to stabilize this in 2.10.x? |
@@ -28,12 +28,16 @@ class Dakota(CMakePackage):
homepage = 'https://dakota.sandia.gov/'
url = 'https://dakota.sandia.gov/sites/default/files/distributions/public/dakota-6.3-public.src.tar.gz'
+ version('6.12', sha256='4d69f9cbb0c7319384ab9df27643ff6767eb410823930b8fbd56cc9de0885bc9', url='https://dakota.... | [Dakota->[cmake_args->[join_path,extend],variant,depends_on,version]] | Provides a toolkit interface between the standard C - Maker and Dakota toolkit Returns a list of arguments for the cmake command. | I would update the `url` at the package-level, then you can specify a url for `6.3` and no other version. |
@@ -158,11 +158,6 @@ class CompressorTestCase(TestCase):
assert all(masks.sum((1)) == np.array([45., 45., 45., 45., 0., 0., 45., 45., 45., 45.]))
- model.layers[2].set_weights([weights[0], weights[1].numpy()])
- masks = pruner.calc_mask(layer, config_list[1]).numpy()
- masks = masks.re... | [CompressorTestCase->[test_torch_slim_pruner->[TorchModel],test_tf_fpgm_pruner->[get_tf_model],test_torch_fpgm_pruner->[TorchModel],test_torch_level_pruner->[TorchModel],test_torch_QAT_quantizer->[TorchModel],test_torch_quantizer_modules_detection->[TorchModel],test_torch_l1filter_pruner->[TorchModel],test_torch_naive_... | Test the FPGM pruner. Missing filter - only layers with sparsity 0. 2 and sparsity 0. 6. | why this part is removed? |
@@ -0,0 +1,10 @@
+# coding=utf-8
+# ------------------------------------
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+# ------------------------------------
+import sys
+
+from ._version import VERSION
+
+USER_AGENT = "azure-containerregistry/{}/{}".format(VERSION, sys.version)
| [No CFG could be retrieved] | No Summary Found. | I think azure-core will append the sys version for you |
@@ -61,4 +61,14 @@ public class GroupByStrategySelector
throw new ISE("No such strategy[%s]", strategyString);
}
}
+
+ public String getStrategy(GroupByQuery query)
+ {
+ return config.withOverrides(query).getDefaultStrategy();
+ }
+
+ public boolean useStrategyV2(GroupByQuery query)
+ {
+ r... | [GroupByStrategySelector->[strategize->[ISE,getDefaultStrategy],get]] | Strategize the group by strategy. | not sure why is this introduced? who is using this |
@@ -78,10 +78,11 @@ class User < ApplicationRecord
# 3 is used for other error exits
pipe = IO.popen("'#{Rails.configuration.validate_file}'", 'w+') # quotes to avoid choking on spaces
to_stdin = [login, password, ip].reject(&:nil?).join("\n")
- pipe.puts(to_stdin) # write to stdin of markus_... | [User->[admin?->[class],active_groupings->[where],grouping_for->[assignment_id,find],authenticate->[popen,new,instance,log,join,close,exitstatus,match,puts,validate_file],test_server?->[class],student?->[class],authorize->[first],is_a_reviewer?->[is_peer_review?,is_a?,nil?],upload_user_list->[nil?,empty?,new,size,parse... | authenticate a user by reading a key from the user config file and writing it to stdin. Get a sequence number for a user that can be authenticated. | Style/SpecialGlobalVars: Prefer $CHILD_STATUS from the stdlib 'English' module (don't forget to require it) over $?. |
@@ -153,7 +153,9 @@ int MetaDataRef::l_set_int(lua_State *L)
MetaDataRef *ref = checkobject(L, 1);
std::string name = luaL_checkstring(L, 2);
int a = luaL_checkint(L, 3);
- std::string str = itos(a);
+ std::string str = std::string("");
+ if (a != 0)
+ str = itos(a);
Metadata *meta = ref->getmeta(true);
if... | [l_set_string->[checkobject],l_get_int->[checkobject],l_to_table->[checkobject],checkobject->[luaL_checkudata_is_metadataref],l_from_table->[checkobject],l_set_int->[checkobject],l_get_float->[checkobject],l_equals->[checkobject],l_get_string->[checkobject],l_contains->[checkobject],l_set_float->[checkobject],l_get->[c... | Sets an integer value from the given Lua state. | ` = std::string("")` is superfluous. |
@@ -131,8 +131,10 @@ public class IntermediateLongSupplierSerializer implements LongSupplierSerialize
try (DataInputStream tempIn = new DataInputStream(new BufferedInputStream(ioPeon.makeInputStream(tempFile)))) {
delegate.open();
- while (tempIn.available() > 0) {
+ int available = tempIn.avail... | [IntermediateLongSupplierSerializer->[closeAndConsolidate->[closeAndConsolidate,makeDelegate],writeToChannel->[writeToChannel],makeDelegate->[size,add,open],getSerializedSize->[getSerializedSize],add->[size,add],close->[close,makeDelegate]]] | This method creates a delegate object that writes the long values from the temp file. | Hmm, the original code looks kind of sketchy. "available" is: > Returns an estimate of the number of remaining bytes that can be read (or skipped over) from this input stream without blocking by the next invocation of a method for this input stream. But this method looks like it actually wants to read the entire file. ... |
@@ -521,7 +521,7 @@ func (p *Properties) setDefaultCerts() (bool, []net.IP, error) {
var azureProdFQDNs []string
for _, location := range helpers.GetAzureLocations() {
- azureProdFQDNs = append(azureProdFQDNs, FormatAzureProdFQDNByLocation(p.MasterProfile.DNSPrefix, location))
+ azureProdFQDNs = append(azurePro... | [SetPropertiesDefaults->[setVMSSDefaultsForMasters,setAgentProfileDefaults,setVMSSDefaultsForAgents,setDefaultCerts,setStorageDefaults,HasVMSSAgentPool,setExtensionDefaults,setHostedMasterProfileDefaults,setMasterProfileDefaults,IsVirtualMachineScaleSets,setOrchestratorDefaults],setVMSSDefaultsForAgents->[BoolPtr,HasAv... | setDefaultCerts sets the default certs for the master This function is used to generate a new master certificate authority pair or generate a new master certificate This function is used to set the private keys for all certificates that are not already set. | Do we want to append the `p.GetCustomCloudName()` return value when we're not in an Azure Stack context? (e.g., the return value will be `""` in that case) |
@@ -28,6 +28,12 @@ class Jetpack_Sync_Module_Updates extends Jetpack_Sync_Module {
), 10, 2 );
add_action( 'automatic_updates_complete', $callable );
+
+ // Send data when update completes
+ add_action( '_core_updated_successfully', array( $this, 'update_core' ) );
+ add_action( 'jetpack_sync_update_core_suc... | [Jetpack_Sync_Module_Updates->[expand_updates->[get_all_updates],validate_update_change->[get_update_checksum]]] | Initializes listeners for all the registered listeners. | When you have priority 10 and a single argument, can't you omit these parameters? This isn't a blocking change, of course. |
@@ -32,6 +32,8 @@ declare var APP: Object;
*/
export function appNavigate(uri: ?string) {
return async (dispatch: Dispatch<any>, getState: Function) => {
+ dispatch(endAllSessions());
+
let location = parseURIString(uri);
// If the specified location (URI) does not identify a host, us... | [No CFG could be retrieved] | Navigates an in - app navigation to a specific route. The location property of the window. location object is the location of the window. location object. | Not sure I like this here. We need to think of how we store sessions and how many of them are allowed to stay "alive". |
@@ -204,6 +204,17 @@ func (h *Handle) Commit(ctx context.Context, sess *session.Session, waitTime *in
return nil
}
+// EmergencyCommit sets the handle's spec to nil so that Commit operation only does a state change and won't touch the extraconfig
+func (h *Handle) EmergencyCommit(ctx context.Context, sess *session... | [Commit->[Unix,MapSink,Now,UTC,OptionValueFromMap,Spec,TargetState,Encode],Unlock,NewLinuxGuest,Add,ReadFull,Error,New,End,Lock,Errorf,Debugf,Name,Remove,Spec,Get,EncodeToString,Begin,Sprintf,String,LookupIP] | Commit commits the transaction associated with the given handle. | Is there a need for this? Since there is no locking involved, you can just set `h.Spec = nil` before calling `Commit`. The name `EmergencyCommit` could mean anything. |
@@ -84,6 +84,10 @@ def parse_args():
parser_updater_trialnum.add_argument('--id', '-i', dest='id', help='the id of experiment')
parser_updater_trialnum.add_argument('--value', '-v', required=True)
parser_updater_trialnum.set_defaults(func=update_trialnum)
+ parser_updater_feed_tuning_data = parser_upd... | [parse_args->[add_argument,ArgumentParser,parse_args,set_defaults,add_subparsers,add_parser,func],nni_info->[print,get_distribution,print_error],process_startup,parse_args,get] | Parse command line arguments and return a object. Update the last known number of times and update the last number of times of the last experiment get trial job id Adds the subparsers to the command line interface. | It's too long, can it be a little shorter or use shorthand? |
@@ -4,6 +4,7 @@ package pinentry
import "os"
-func IsRemote() bool {
+func HasWindows() bool {
+ //If there is a DISPLAY then we can spawn a window to it.
return len(os.Getenv("DISPLAY")) > 0
}
| [Getenv] | IsRemote returns true if the user is on a remote machine. | My display is set originally set to `:0` since I am using i3 Window manager in Arch so by simply trying to run `keybase login email@email.com` it errors with `ERROR Failed to get getpin greeting: EOF` so in case the display is `:0` it would be also good to have hasWindow set to `false` here. Otherwise the app won't wor... |
@@ -40,10 +40,7 @@ def _report(client_id, payloads, extra_headers=None, **extra_data):
def get_order_payloads(order):
items = [
ga.item(
- ol.product_name,
- ol.unit_price.gross,
- quantity=ol.quantity,
- item_id=ol.product_sku,
+ str(ol), ol.unit_pr... | [report_view->[get_view_payloads,_report],report_order->[get_order_payloads,_report]] | Get order payload. | What do you think about renaming `ol` to something more meaningful, like `line` |
@@ -169,7 +169,7 @@ public class MongoDBGridFSIOTest implements Serializable {
TestPipeline pipeline = TestPipeline.create();
PCollection<String> output = pipeline.apply(
- MongoDbGridFSIO.read()
+ MongoDbGridFSIO.<String>read()
.withUri("mongodb://localhost:" + PORT)
... | [MongoDBGridFSIOTest->[stop->[info,stop],testReadWithParser->[apply->[longValue,assertEquals],create,of,satisfies,isEqualTo,setCoder,run],testSplit->[create,size,readFromSource,getEstimatedSizeBytes,assertSourcesEqualReferenceSource,getSource,withDatabase,splitIntoBundles,assertEquals],testFullRead->[apply->[longValue,... | Test if a sequence of keys in the grid is full read. | minor: this generates a warning in eclipse as the `<read>` is not needed. The other two tests have a similar issue. |
@@ -19,6 +19,14 @@ const (
firehoseDeliveryStreamStatusDeleted = "DESTROYED"
)
+const (
+ DestinationTypeS3 = "s3"
+ DestinationTypeExtendedS3 = "extended_s3"
+ DestinationTypeElasticsearch = "elasticsearch"
+ DestinationTypeRedshift = "redshift"
+ DestinationTypeSplunk = "splunk"
+)
+
f... | [StringLenBetween,StringValueSlice,GetChange,IgnoreAws,BoolValue,DescribeDeliveryStream,StringValueMap,StringInSlice,Set,NonRetryableError,Int64Value,GetOk,IntAtLeast,New,HasChange,Errorf,SetId,RetryableError,FirehoseTags,Bool,UpdateDestination,IgnoreConfig,StartDeliveryStreamEncryption,DeleteDeliveryStream,ToLower,Id,... | region Private functions schema. Schema for intervals. | I suggest prefixing these constants with `firehose` so that they don't at some point conflict with any constants in the package (plus it makes them private to the package). |
@@ -155,6 +155,13 @@ describes.realWin('amp-story-page', {amp: {extensions}}, (env) => {
expect(spy).to.have.been.calledOnce;
});
+ it('should call beforeVisible after layoutCallback resolves', async () => {
+ const spy = env.sandbox.spy(page, 'renderOpenAttachmentUI_');
+ page.buildCallback();
+ aw... | [No CFG could be retrieved] | Adds signals to the given element and waits for all the signals to resolve. The following methods are executed when state becomes active. | did you mean to call `beforeVisible` in this test? |
@@ -161,6 +161,10 @@ public class LegacyApiTokenAdministrativeMonitor extends AdministrativeMonitor {
@RequirePOST
public HttpResponse doRevokeAllSelected(@JsonBody RevokeAllSelectedModel content) throws IOException {
for (RevokeAllSelectedUserAndUuid value : content.values) {
+ if(value.u... | [LegacyApiTokenAdministrativeMonitor->[isActivated->[anyMatch,hasLegacyToken,getProperty],doRevokeAllSelected->[ok,getProperty,revokeToken,log,deleteApiToken,getById,save],getLegacyStatsOf->[TokenInfoAndStats,findTokenStatsById,getProperty,getUuid],getImpactedUserList->[toList,collect],getLegacyTokenOf->[getLegacyToken... | Revoke all selected users. | add space between if and ( and the same between ) and { |
@@ -748,12 +748,12 @@ func (c *ScheduleConfig) Clone() *ScheduleConfig {
const (
defaultMaxReplicas = 3
- defaultMaxSnapshotCount = 3
- defaultMaxPendingPeerCount = 16
+ defaultMaxSnapshotCount = 64
+ defaultMaxPendingPeerCount = 64
defaultMaxMergeRegionSize = 2... | [MigrateDeprecatedFlags->[migrateConfigurationMap],Parse->[Parse],RewriteFile->[GetConfigFile],IsDefined->[IsDefined],Adjust->[CheckUndecoded,Parse,IsDefined,Validate,Adjust,Child],parseDeprecatedFlag->[IsDefined],adjustLog->[IsDefined],adjust->[Child,Validate,adjust,IsDefined],Parse] | Clone returns a cloned scheduling configuration based on the given configuration. adjust adjusts the max snapshot and peer count for the schedule config based on the given meta. | Maybe make this bigger? |
@@ -422,7 +422,7 @@ class VersionControl(object):
"""
Return the url used at location
- This is used in get_info() and obtain().
+ This is used in obtain().
"""
raise NotImplementedError
| [VersionControl->[compare_urls->[normalize_url],make_rev_options->[RevOptions],get_url_rev_options->[make_rev_options,get_url_rev_args,get_url_rev],unpack->[obtain],obtain->[update,compare_urls,fetch_new,get_url_rev_options,to_display,switch,is_commit_id_equal]],get_src_requirement->[get_backend_from_location],VcsSuppo... | Returns the url used at the given location. | I would add `get_src_requirement()`. |
@@ -437,7 +437,7 @@ class BigQueryServicesImpl implements BigQueryServices {
"Unable to list table data: %s, aborting after %d retries.",
tableId, MAX_RPC_RETRIES),
Sleeper.DEFAULT,
- backoff);
+ backoff, ALWAYS_RETRY);
return dataList.getRows() == null ... | [BigQueryServicesImpl->[DatasetServiceImpl->[createDataset->[createDataset],insertAll->[insertAll]],JobServiceImpl->[startJob->[startJob],getJob->[getJob],pollJob->[pollJob]],BigQueryJsonReaderImpl->[fromTable->[fromTable,BigQueryJsonReaderImpl],getCurrent->[getCurrent],close->[close],advance->[advance],fromQuery->[fro... | Checks if a table is empty. | always_retry in separate line |
@@ -272,6 +272,10 @@ class AnyType(Type):
self.explicit = explicit
# Does this type come from omitted generics?
self.from_omitted_generics = from_omitted_generics
+ # Is this type a higher-kinded type (e.g. type of call expr to NewType or NamedTuple)?
+ # We can't fully represen... | [TypeQuery->[visit_star_type->[accept],visit_type_type->[accept],visit_overloaded->[items],query_types->[accept],visit_callable_argument->[accept]],TypeStrVisitor->[visit_callable_type->[accept],visit_typeddict_type->[accept,item_str,items],visit_star_type->[accept],visit_instance->[name],visit_tuple_type->[accept],vis... | Initialize a new AnyType object. | I'd rename this to something more general, since we don't really take advantage of the fact that these represent type constructors anywhere, and the concept of "higher-kinded type" sounds kind of complicated. My suggestion would be `special_form`, which can be applied for things other than type constructors that don't ... |
@@ -89,10 +89,10 @@ export default {
'sehen',
},
[LocalizedStringId.AMP_STORY_WARNING_LANDSCAPE_ORIENTATION_TEXT]: {
- string: 'Diese Seite is am Besten im Portrait Mode',
+ string: 'Diese Seite sieht am Besten im "Hochformat" aus',
},
[LocalizedStringId.AMP_STORY_WARNING_UNSUPPORTED_BROWSER_... | [No CFG could be retrieved] | Augments of August s Warning messages. | Just a small nit: remove quotes around Hochformat? |
@@ -37,6 +37,7 @@ type Type interface {
AssignableFrom(src Type) bool
ConversionFrom(src Type) ConversionKind
+ GetAnnotations() []interface{}
String() string
conversionFrom(src Type, unifying bool) ConversionKind
| [unify,ConversionFrom,Exists,unifyTo,conversionFrom,Assertf,assignableTo,Assert,conversionTo] | Invite a variable of type u that represents a set of 32 - bit integer values. can be used to determine if a type is assignable to a type. | This should probably return something with an API more like that of `context.Context`: a logical map keyed by package-level variables. |
@@ -99,6 +99,8 @@ class WPCOM_REST_API_V2_Endpoint_Admin_Menu extends WP_REST_Controller {
public function prepare_menu_for_response( array $menu ) {
global $submenu;
+ do_action( 'admin_menu_rest_api' );
+ global $menu;
$data = array();
/**
| [WPCOM_REST_API_V2_Endpoint_Admin_Menu->[prepare_submenu_item->[prepare_menu_item_url,parse_menu_item],prepare_menu_for_response->[prepare_submenu_item,prepare_menu_item],get_item->[prepare_menu_for_response],prepare_menu_item->[prepare_menu_item_url,prepare_menu_item_icon,parse_menu_item]]] | Prepare menu for response. | Since that hook name is not prefixed with `jetpack_`, I would expect this to be a Core hook. It doesn't appear to be. Do you think you could add a prefix and a docblock to this hook? |
@@ -63,13 +63,7 @@ func (c *cmdWotList) Run() error {
line := func(format string, args ...interface{}) {
dui.Printf(format+"\n", args...)
}
- var targetUsername string
- if c.ownWot {
- targetUsername = c.G().Env.GetUsername().String()
- } else {
- targetUsername = *c.username
- }
- line("Web-Of-Trust for %s",... | [Run->[Printf,GetUsername,Join,Error,LookupUsername,Background,G,GetDumbOutputUI,String,Errorf,GetUPAKLoader,WotListCLI],ParseArgv->[Args,New],NewContextified,ChooseCommand] | Run implements the command. Command interface. NULL - > null. | if this can be `nil` (ewhen you specify all the vouches you have written without specifying a vouchee), this will panic |
@@ -768,6 +768,18 @@ export class AmpVideo extends AMP.BaseElement {
return this.element.classList.contains('i-amphtml-poolbound');
}
+ /**
+ * Whether the video is just a placeholder and meant to be overriden
+ * @param {!Element} videoEl
+ * @return {boolean}
+ */
+ isPlaceholderVideo_(videoEl) {
... | [No CFG could be retrieved] | Creates a poster layer underneath. The video s enter method. | @gmajoulet We may not need this since we only check that on buildCallback, where the mediapool probably didn't swap the video yet. If that's the case, we can remove this function. |
@@ -3592,7 +3592,9 @@ zfs_putpage(struct inode *ip, struct page *pp, struct writeback_control *wbc)
err = sa_bulk_update(zp->z_sa_hdl, bulk, cnt, tx);
zfs_log_write(zfsvfs->z_log, tx, TX_WRITE, zp, pgoff, pglen, 0,
- zfs_putpage_commit_cb, pp);
+ wbc->sync_mode != WB_SYNC_NONE ? zfs_putpage_commit_cb : NULL,... | [No CFG could be retrieved] | Set page writeback and unlock page. Updates the system attributes of a file or directory. | Two same checks - maybe just use one usual `if`? |
@@ -309,9 +309,9 @@ namespace Dynamo.Graph.Nodes.CustomNodes
/// Validates passed Custom Node definition and synchronizes node with it.
/// </summary>
/// <param name="def">Custom Node definition.</param>
- public void ResyncWithDefinition(CustomNodeDefinition def)
+ public ... | [Output->[SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],UpdateValueCore->[UpdateValueCore]],Function->[BuildAst->[BuildAst],SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],ResyncWithDefinition->[ValidateDefinition]],Symbol->[SerializeCore->[SerializeCore],DeserializeCore->[Deserial... | ResyncWithDefinition - sync node with given definition. | you can't change a public method signature at this point, even adding a default argument is an API breaking change. |
@@ -81,7 +81,7 @@ export class Performance {
this.viewer_ = null;
/** @private {?./resources-impl.Resources} */
- this.resources = null;
+ this.resources_ = null;
/** @private {boolean} */
this.isMessagingReady_ = false;
| [No CFG could be retrieved] | Increments the value of a given key if it is not already set. If it is This method is called when the AMP page has a specific core service. | How is this not breaking things? |
@@ -962,6 +962,13 @@ func (cs *ContainerService) setAddonsConfig(isUpgrade bool) {
o.KubernetesConfig.Addons[i].Enabled = to.BoolPtr(true)
}
}
+
+ // Enable keyvault flexvolume addon during upgrade for 1.16 or greater scenarios, unless explicitly disabled
+ if isUpgrade && o.KubernetesConfig.IsAddonEnabled(com... | [setAddonsConfig->[GetSecondaryNonMasqueradeCIDR,Warnf,GetKubeProxyFeatureGates,GetLogAnalyticsWorkspaceDomain,IsAddonEnabled,Itoa,BoolPtr,FormatBool,IsKubernetesVersionGe,IsAzureStackCloud,IsAddonDisabled,GetNonMasqueradeCIDR,Bool,GetAzureCNICidr,GetCloudSpecConfig,IsFeatureEnabled,IsAzureCNI,EqualFold,HasAADAdminGrou... | setAddonsConfig sets the addons config for the container SpecConfig for the given specification. AzureStackCloud requires a clusterAutoscalerAddonConfig to be set in the cluster. Spec for the cluster - wide configuration. | I don't think we need any special logic here. We should just be able to use whatever value is already in the api model during upgrade. |
@@ -71,7 +71,7 @@ class PenaltyDecayPeriodSubmissionRule < SubmissionRule
if overtime_hours / interval < 1
total_penalty = total_penalty + deduction
else
- total_penalty = total_penalty + (overtime_hours/interval).to_i * deduction
+ total_penalty = total_penalty + (overtime_hours/in... | [PenaltyDecayPeriodSubmissionRule->[hours_sum->[sum],apply_submission_rule->[new,unit,t,extra_mark,save,revision_timestamp,get_original_result,result,description,calculate_penalty,calculate_overtime_hours_from],commit_after_collection_message->[t],after_collection_message->[t],description_of_rule->[t],calculate_penalty... | Calculates the total penalty for a . | Line is too long. [82/80]<br>Use self-assignment shorthand `+=`.<br>Surrounding space missing for operator `/`. |
@@ -67,7 +67,6 @@ namespace Dynamo.WorkspaceDependency
public void Shutdown()
{
DependencyView.Dispose();
- this.Dispose();
}
public void Startup(ViewStartupParams viewStartupParams)
| [WorkspaceDependencyViewExtension->[Shutdown->[Dispose]]] | Shutdown method. | We should probably move `DependencyView.Dispose();` to `Dispose` rather than keep it here. Feels more natural to do all disposals in `Dispose`. |
@@ -121,7 +121,9 @@ func (cs *ContainerService) setOrchestratorDefaults(isUpgrade, isScale bool) {
case NetworkPolicyCilium:
o.KubernetesConfig.NetworkPlugin = NetworkPluginCilium
case NetworkPolicyAntrea:
- o.KubernetesConfig.NetworkPlugin = NetworkPluginAntrea
+ if o.KubernetesConfig.NetworkPlugin == ""... | [SetPropertiesDefaults->[setAgentProfileDefaults,setOrchestratorDefaults,setTelemetryProfileDefaults,SetDefaultCerts,IsCustomCloudProfile,setCustomCloudProfileDefaults,setCSIProxyDefaults,setExtensionDefaults,setHostedMasterProfileDefaults,setMasterProfileDefaults,setWindowsProfileDefaults,setStorageDefaults],setAgentP... | setOrchestratorDefaults sets the default values for the Orchestrator profile and the default This function is called when the user changes the configuration of the cluster. This function is called to set the default values for all configuration options. | why don't we leave default to azure cni? @aanandr @chandanAggarwal |
@@ -85,6 +85,7 @@ RSpec.describe Jobs::GroupSmtpEmail do
it "creates an IncomingEmail record with the correct details to avoid double processing IMAP" do
subject.execute(args)
+ expect(ActionMailer::Base.deliveries.count).to eq(1)
incoming_email = IncomingEmail.find_by(post_id: post.id, topic_id: post... | [create,new,let,describe,match_array,enable_smtp,base_url,reply_by_email_address,it,first,to,before,returns,email_username,t,require,count,change,to_s,include,user,fab!,manual_polling_enabled,update,id,update!,execute,topic_id,context,created_via_types,not_to,host_for,eq,find_by,reply_by_email_enabled] | creates an EmailLog record with the correct details and does not create a post reply key creates an EmailLog record with the correct details. | The assertion here is pretty generic since any email being sent in the process will result in this test passing. Is there a simple assertion that we test the email we expect is sent? Maybe a test for the subject or template? |
@@ -847,15 +847,14 @@ const OPTIONS list_options[] = {
{"kdf-algorithms", OPT_KDF_ALGORITHMS, '-',
"List of key derivation and pseudo random function algorithms"},
{"random-generators", OPT_RANDOM_GENERATORS, '-',
- "List of random number generators"},
+ "List of random number generators"},
... | [No CFG could be retrieved] | Options for the list of all known key algorithms. The main entry point for the command line interface. | This should fit on one line now. |
@@ -198,12 +198,12 @@ export class AmpSlideScroll extends BaseSlides {
/** @override */
moveSlide(dir, animate) {
- if (this.slideIndex_ != null) {
+ if (this.slideIndex_ !== null) {
const hasNext = this.hasNext();
const hasPrev = this.hasPrev();
if ((dir == 1 && hasNext) ||
... | [No CFG could be retrieved] | This method is called when the user clicks on the slides container. Handler for the scroll event. | i would rather have this error out. you could use - dev().assertNumber here as well. |
@@ -73,12 +73,12 @@ public abstract class BootstrapIndex implements Serializable {
/**
* Check if bootstrap Index is present and ensures readable.
*/
- protected abstract boolean isPresent();
+ public abstract boolean isPresent();
/**
* Bootstrap Index Reader Interface.
*/
- public abstract s... | [BootstrapIndex->[useIndex->[isPresent,orElse],getBootstrapIndex->[getBootstrapIndexClass,loadClass]]] | Returns true if the field is present. | I reverted this method to be protected. This should not be used directly by clients. |
@@ -1,6 +1,7 @@
require 'rails_helper'
describe Report, type: :model do
+
it 'should be of class Report' do
expect(subject.class).to eq Report
end
| [class_name,is_at_most,to,have_db_column,describe,eq,validate_presence_of,case_insensitive,have_many,it,require,belong_to,should] | A basic example of how to test a report. | Extra empty line detected at block body beginning. |
@@ -447,6 +447,8 @@ class ModelBase(backwards_compatible(Keyed)):
model["scoring_history"].show()
if "variable_importances" in model and model["variable_importances"]:
model["variable_importances"].show()
+ if "model_parameters" in model and model["model_parameters"]:
+ ... | [ModelBase->[download_pojo->[download_pojo],aic->[aic],mean_residual_deviance->[mean_residual_deviance],score_history->[scoring_history],_plot->[show,scoring_history],mse->[mse],gini->[gini],std_coef_plot->[coef_norm,show],varimp_plot->[show,varimp],auc->[auc],rmsle->[rmsle],logloss->[logloss],model_performance->[type]... | Print innards of model without regards to type. get the values of the nanoseconds in the model. | We only want to make them available, not print them explicitely, as the amout of parameters could be quite large. WDYT ? |
@@ -254,6 +254,11 @@ class NetworkClusterPrinterOutputDevice(NetworkPrinterOutputDevice.NetworkPrinte
self._selected_printer = self._automatic_printer # reset to default option
self._request_job = [nodes, file_name, filter_by_machine, file_handler, kwargs]
+ # the build plates to be sent
+ ... | [NetworkClusterPrinterOutputDevice->[sendPrintJob->[connect],_compressGcode->[_compressDataAndNotifyQt],_notifyFinishedPrintJobs->[__get_username],_notifyConfigurationChangeRequired->[__filterOurPrintJobs],_showRequestSucceededMessage->[connect],_onFinished->[_finishedPrintersRequest,_finishedPrintJobsRequest,_finished... | Request a print job to write to a node. | I think all changes to this file will conflict heavily with @nallath's rewrite of the output devices. It might have to be re-implemented in that branch. |
@@ -270,6 +270,9 @@ func New(host p2p.Host, ShardID uint32, leader p2p.Peer, blsPriKey *bls.SecretKe
consensus.ReadySignal = make(chan struct{})
+ // channel for receiving newly generated VDF
+ consensus.RndChannel = make(chan [548]byte)
+
consensus.uniqueIDInstance = utils.GetUniqueValidatorIDInstance()
me... | [FindStakeInfoByNodeKey->[Msg,Warn,FromLibBLSPublicKey,Err,Logger],IndexEnabled,Info,SerializeToHexStr,Add,ToLibBLSPublicKey,Error,SetMask,GetMemProfiling,Cmp,New,AddBalance,FromLibBLSPublicKey,FindCommitteeByID,Errorf,Sub,Logger,WithCause,Debug,Store,Uint64,GetHeaderByHash,Strs,DeserializeHexStr,NewMask,Str,Msg,MustAd... | accumulateRewards creates a new object for the given block. GetHeaderByHash returns the block header with the given parent hash. | use a constant for 548? |
@@ -179,13 +179,13 @@ func (s *UserEKBoxStorage) Put(ctx context.Context, generation keybase1.EkGenera
return nil
}
-func (s *UserEKBoxStorage) unbox(ctx context.Context, userEKBoxed keybase1.UserEkBoxed) (userEK keybase1.UserEk, err error) {
+func (s *UserEKBoxStorage) unbox(ctx context.Context, userEKGeneration ... | [Get->[getCache],unbox->[Get],MaxGeneration->[getCache],DeleteExpired->[deleteMany,getCache],GetAll->[unbox,getCache],Put->[dbKey,getCache],fetchAndPut->[Get],deleteMany->[dbKey,getCache],getCache->[dbKey]] | Put puts a userEK in the storage. | I wonder if these errors should get the same special treatment as the team ones, since the team ones are expected (come out of the closet and read a chat message) but these aren't (you'd need a box that was encrypted for a device key you never made / deleted early). Then again, maybe we can express that difference when... |
@@ -133,7 +133,12 @@ public class UrlUtilsTest {
@Test
public void testParseUrlsAddressNull() {
- assertNull(UrlUtils.parseURLs(null, null));
+ String exceptionMessage = "Address is not allowed to be empty, please re-enter.";
+ try {
+ UrlUtils.parseURLs(null, null);
+ ... | [UrlUtilsTest->[testParseURLWithSpecial->[assertEquals,toString],testRevertForbid3->[add,assertEquals,revertForbid],testRevertSubscribe->[assertEquals,put,revertSubscribe],testIsItemMatch->[assertTrue,isItemMatch],testRevertRegister2->[assertEquals,put,revertRegister],testGetEmptyUrl->[getEmptyUrl,assertThat,toFullStri... | This test parses the URL address null and converts it to a register. | Modify it together. |
@@ -1196,7 +1196,15 @@ Generator.prototype.getConstraintName = function (entityName, relationshipName,
var halfLimit = Math.floor(limit/2),
entityTable = noSnakeCase ? entityName : this.getTableName(entityName.substring(0, halfLimit)),
relationTable = noSnakeCase ? relationshipName: t... | [No CFG could be retrieved] | Creates a constraint name for the given entity and relationship name. Private methods - Generate KeyStore for uaa authorization server. | the correct fix here should be changing `entityTable = noSnakeCase ? entityName : this.getTableName(entityName.substring(0, halfLimit))` to `entityTable = noSnakeCase ? entityName.substring(0, halfLimit) : this.getTableName(entityName.substring(0, halfLimit))` and changing `relationTable = noSnakeCase ? relationshipNam... |
@@ -14,4 +14,18 @@ class VerifyController < ApplicationController
def retry
flash.now[:error] = I18n.t('idv.errors.fail')
end
+
+ def activated
+ redirect_to verify_url unless active_profile?
+ end
+
+ def fail
+ redirect_to verify_url unless idv_attempter.exceeded?
+ end
+
+ private
+
+ def acti... | [VerifyController->[retry->[t,now],index->[track_event,present?,redirect_to],before_action,include]] | retry missing idv node. | what if we called this `require_no_active_profile` rather than `confirm` ? |
@@ -476,7 +476,7 @@ class ToList(ptransform.PTransform):
super(ToList, self).__init__(label)
def expand(self, pcoll):
- return pcoll | core.CombineGlobally(self.label, ToListCombineFn())
+ return pcoll | self.label >> core.CombineGlobally(ToListCombineFn())
@with_input_types(T)
| [TupleCombineFn->[add_input->[add_input]],PhasedCombineFnExecutor->[__init__->[curry_combine_fn],merge_only->[merge_accumulators],full_combine->[apply],add_only->[create_accumulator,add_inputs],extract_only->[extract_output]],SingleInputTupleCombineFn->[add_input->[add_input]],Top->[Smallest->[Of],LargestPerKey->[PerKe... | Expand the given collection with the current label. | I think we should remove these `self.label` things. (Not necessarily in this PR, but definitely a backward incompatible change.) How would this work in for example `label1 >> ToList(label2)` |
@@ -354,7 +354,7 @@ func (c *Config) Client() (interface{}, error) {
codedeployconn: codedeploy.New(sess.Copy(&aws.Config{Endpoint: aws.String(c.Endpoints["codedeploy"])})),
codepipelineconn: codepipeline.New(sess.Copy(&aws.Config{Endpoint: aws.String(c.Endpoints["codepipel... | [Client->[Copy,Printf,Println,IsDebugOrHigher,New,PushBack,String,GetSessionWithAccountIDAndPartition,ValidateAccountID,HasPrefix,Bool,Code,VersionString,ValidateRegion],String,DescribeAccountAttributes,Errorf] | Client returns a client for the HashiCorp service. Skip requesting an account id for implications. Creates a copy of all of the connection providers. List all the connections that are managed by the codepipeline. | This was a bug discovered by the new acceptance testing. |
@@ -69,7 +69,7 @@ var _ = Describe("Podman privileged container tests", func() {
})
It("podman non-privileged should have very few devices", func() {
- session := podmanTest.Podman([]string{"run", "busybox", "ls", "-l", "/dev"})
+ session := podmanTest.Podman([]string{"run", "-t", "busybox", "ls", "-l", "/dev"}... | [WaitWithDefaultTimeout,GrepString,RestoreAllArtifacts,Cleanup,ExitCode,OutputToStringArray,SystemExec,OutputToString,To,Podman,Split,Exit] | Podman should have very few devices Check if the kernel is new enough to test this feature. | What broke about this that it needs `-t` now? |
@@ -1785,11 +1785,13 @@ function addFileIntoDatabaseIndex($dir, $file, $fullpathorig = '', $mode = 'uplo
$ecmfile->fullpath_orig = $fullpathorig;
$ecmfile->gen_or_uploaded = $mode;
$ecmfile->description = ''; // indexed content
- $ecmfile->keyword = ''; // keyword content
+ $ecmfile->keywords = ''; // keywor... | [dol_delete_file->[fetch,executeHooks,loadLangs,initHooks,delete],dol_remove_file_process->[remove_attached_files,trans,load],dol_move->[fetch,create,update,delete],dol_uncompress->[trans,errorInfo,extractTo,extract,close,open,getNameIndex,load],addFileIntoDatabaseIndex->[create],completeFileArrayWithDatabaseInfo->[cre... | Adds a file into the database if result is < 0 print error message. | Setting src_object_id wihout setting src_object_type is useless. For this reason table_element mus always be set and test if (isset( is useless. And if not set, we should report an error instead of allowing to record a data that we won't be able to reuse later. |
@@ -19,13 +19,6 @@ use Yoast\WP\SEO\Helpers\Schema\Language_Helper;
*/
class FAQ extends Abstract_Schema_Piece {
- /**
- * The article helper.
- *
- * @var Article_Helper
- */
- private $article;
-
/**
* The HTML helper.
*
| [FAQ->[generate->[generate_question_block],add_accepted_answer_property->[sanitize,add_piece_language],generate_question_block->[add_accepted_answer_property,smart_strip_tags,sanitize,add_piece_language]]] | Creates a FAQ object from a given meta tags context. Generate a list of questions referencing them by ID. | This class should removed from the import statements as well. |
@@ -281,6 +281,16 @@ class GenConanfile(object):
' os.symlink(os.path.basename("{}"), '
'os.path.join(self.package_folder, "{}"))'.format(key, key, value)
for key, value in self._package_files_link.items()])
+ if self._pa... | [GenConanfile->[with_requires->[with_require],with_package_file->[with_import]]] | Returns a method that writes the package method to disk. | @danimtb I would say that this is an overly test-specific thing, that this should be implemented directly in the test, leaving ``GenConanfile()`` more generic. Only common conanfile patterns should be here. It is true that the ``_package_files_link`` was already there, but that pattern is used just exactly once in the ... |
@@ -123,9 +123,9 @@ class OpenidConnectAuthorizeForm
param_value.split(' ').compact & possible_values
end
- def validate_acr_values
- return if acr_values.present?
- errors.add(:acr_values, t('openid_connect.authorization.errors.no_valid_acr_values'))
+ def validate_ial_values
+ return if ial_value... | [OpenidConnectAuthorizeForm->[validate_privileges->[ialmax_requested?,ial2_service_provider?,ial2_requested?],scopes->[ialmax_requested?,ial2_strict_requested?,ial2_requested?],ial2_or_greater?->[ial2_strict_requested?,ial2_requested?],validate_liveness_checking_enabled_if_ial2_strict_requested->[ial2_strict_requested?... | parse_to_values returns a list of values that can be found in the request. | can we change the names back to `acr_values`? that's the parameter in the OIDC spec |
@@ -886,7 +886,12 @@ public class PlanPrinter
name = node.getJoinType().getJoinLabel() + " Unnest";
}
else if (!node.getReplicateSymbols().isEmpty()) {
- name = "CrossJoin Unnest";
+ if (node.getJoinType() == INNER) {
+ name = "... | [PlanPrinter->[textDistributedPlan->[textDistributedPlan],Visitor->[addNode->[addNode]],jsonFragmentPlan->[toJson],textLogicalPlan->[toText]]] | Visits a UnnestNode and adds it to the list of children. | I do not understand the naming pattern here. |
@@ -48,11 +48,13 @@ def main(argv):
with open(os.path.join(metrics_output_dir, "gpu_metrics"), "w") as outputFile:
pass
os.chmod(os.path.join(metrics_output_dir, "gpu_metrics"), 0o777)
- cmd = 'nvidia-smi -q -x'
+ cmd = 'nvidia-smi -q -x'.split()
while(True):
try:
- smi... | [parse_nvidia_smi_result->[outPut,getElementsByTagName,write,print,enumerate,flush,exc_info,len,asctime,dumps,localtime,processes,join,format,open,parseString],main->[parse_nvidia_smi_result,print,sleep,exc_info,chmod,check_output,format,join,open,exit,check_ready_to_run],check_ready_to_run->[list,int,append,pop,len,ge... | Main function of the GPU metrics collector. | there is try catch within `parse_nvidia_smi_result` |
@@ -48,8 +48,8 @@ public class BulkJsonWriter extends ExtensibleEntityJsonWriter<BulkStatus> {
@Override
public void writeEntityBody(BulkStatus entity, JsonGenerator jg) throws IOException {
jg.writeStringField(BULK_ID, entity.getId());
- jg.writeStringField(BULK_STATE, entity.getState().toStr... | [BulkJsonWriter->[writeEntityBody->[writeStringField,getProcessed,toString,writeNumberField,getId,getCount]]] | Write bulk status entity body. | Maybe it's worth adding next to `AbstractJsonWriter#writeSerializableField` a `writeOptionalSerializableField` wdyt ? |
@@ -927,6 +927,7 @@ class TestVersionViewSetList(AddonAndVersionViewSetDetailMixin, TestCase):
# - 1 files
# - 1 licenses
# - 1 licenses translations
+ # - 2 queries for webext_permissions - FIXME - there should only be 1
self._test_url(lang='en-US')
... | [AddonAndVersionViewSetDetailMixin->[test_get_by_slug->[_test_url,_set_tested_url],test_get_by_guid_email_short_format->[_test_url,_set_tested_url],test_get_by_id->[_test_url],test_get_by_guid->[_test_url,_set_tested_url],test_get_addon_not_found->[_set_tested_url],test_get_by_guid_email_format->[_test_url,_set_tested_... | Test queries for missing records. | Should this be fixed here? Or is there an issue filed to fix all the `FIXME` later? |
@@ -89,6 +89,11 @@ function initCommands() {
APP.store.dispatch(muteAllParticipants(localIds));
},
+ 'enable-lobby': () => {
+ const { conference } = APP.store.getState()['features/base/conference'];
+
+ conference.enableLobby();
+ },
'password': pass... | [No CFG could be retrieved] | Initializes supported commands. Tones - API. | How about disabling it? This needs to be a "toggle" command so the user can decide if they want to enable or disable it. |
@@ -44,6 +44,9 @@ class BaseRatingSerializer(serializers.ModelSerializer):
'slug': addon.slug
}
+ def get_is_developer_reply(self, obj):
+ return obj.reply_to_id is not None
+
def validate(self, data):
data = super(BaseRatingSerializer, self).validate(data)
reque... | [RatingVersionSerializer->[to_internal_value->[to_internal_value]],RatingSerializer->[RatingSerializerReply,RatingVersionSerializer]] | Returns a dict with addon id and slug. Data - Returns a data object with the flag that indicates whether the data sequence is a. | observation: a property that could be on the `Rating` model itself. Not that it'd give us anything extra, really. |
@@ -74,9 +74,10 @@ func NewReader(config Config) (*Reader, error) {
return nil, errors.Wrapf(err, `failed to expand counter (query="%v")`, counter.Query)
}
}
- if childQueries == nil || len(childQueries) == 0 {
+ // check if the pdhexpandcounterpath/pdhexpandwildcardpath functions have expanded the counte... | [Close->[Close],Read->[Itoa,Wrapf,CollectData,GetFormattedCounterValues,Debugw,Namespace,Wrap,Put],Wrapf,NewLogger,Infow,FindStringSubmatch,ExpandWildCardPath,Close,AddCounter,Open,Namespace,MustCompile] | NewReader creates a new instance of Reader. PdhGetFFFFG is called to get the values of the counter values. | Good catch here btw :slightly_smiling_face: I guess it was failing silently before? (`errors.Wrap(nil)` returns `nil`) |
@@ -1697,6 +1697,8 @@ RtpsUdpDataLink::received(const RTPS::AckNackSubmessage& acknack,
callbacks[i]->reader_exists(remote, local);
}
+ acknowledged_by_reader(local, remote);
+
ACE_GUARD(ACE_Thread_Mutex, g, lock_);
const RtpsWriterMap::iterator rw = writers_.find(local);
if (rw == writers_.end()) {... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -. | If this gets called every time we get an ACK, then are we guaranteed to always send the keys twice? Should we be storing the sequence numbers used when we sent the keys the first time and comparing against the sequence numbers sent in the ACK so we only resend when necessary? |
@@ -1289,13 +1289,13 @@ main(int argc, char *argv[])
/* argv[1] is RESOURCE or "help" or "version";
* argv[2] if provided is a resource-specific command
*/
- if (argc < 2 || strcmp(argv[1], "help") == 0) {
+ if (argc >= 2 && strcmp(argv[1], "version") == 0) {
+ fprintf(stdout, "daos version %s\n", DAOS_VERSION... | [int->[obj_op_parse,D_GOTO,tobytes,uuid_is_null,cont_set_attr_hdlr,cont_get_acl_hdlr,cmd_args_print,cont_delete_acl_hdlr,uuid_generate,FIRST_LEVEL_HELP,strdup,ARGS_VERIFY_PUUID,cont_list_attrs_hdlr,cont_create_hdlr,cont_update_acl_hdlr,getopt_long,daos_prop_free,pool_query_hdlr,cont_get_prop_hdlr,daos_pool_connect,fpri... | main function for the command line interface Common entry point for the n - th command - line entry point. | Minor suggestion: invoke help_hdlr and return nonzero status from the process when user provides command lines such as daos help blah blah blah .... (endless until shell tells you that the line is too long) daos version blah blah blah ... (endless) while still protecting against the segfault for partial commands such a... |
@@ -465,9 +465,11 @@ namespace Content.Client.ParticleAccelerator
{
_menu = menu;
_baseState = name;
- _rsi = cache.GetResource<RSIResource>($"/Textures/Constructible/Power/PA/{name}.rsi").RSI;
+ _rsi = cache.GetResource<RSIResource>($"/Textur... | [ParticleAcceleratorControlMenu->[FrameUpdate->[FrameUpdate]]] | Set the power state of the particle accelerometer. | This is pretty dirty, you're better off passing it in to the ctor directly. Also local variables are normally not prefixed with an underscore. |
@@ -35,7 +35,7 @@ const PlayerStates = {
'-1': 'unstarted',
'0': 'ended',
'1': 'playing',
- '2': 'paused',
+ '2': 'pause',
'3': 'buffering',
'5': 'video_cued',
};
| [No CFG could be retrieved] | Creates a new object with all the properties of a specific . Creates a JSON object with the default values for the object. | Nit: I think the past tense matches better with the others. They're either X-ing or X-ed. |
@@ -181,7 +181,7 @@ func WithStaticDir(dir string) RuntimeOption {
// WithHooksDir sets the directory to look for OCI runtime hooks config.
// Note we are not saving this in database, since this is really just for used
// for testing.
-func WithHooksDir(hooksDir string, dirNotExistFatal bool) RuntimeOption {
+func W... | [WithPod->[ID],ID,Wrapf,Join,Stat,MatchString,InfraContainerID,Wrap,MustCompile,ParseIP] | WithCgroupManager sets the cgroups to use. WithTmpDir sets the directory where temporary runtime files are stored. | I want to keep `dirNotExistFatal` for anything explicitly set by the caller (i.e. not hard-coded into libpod). More discussion on this in b76c150d3aa. |
@@ -96,7 +96,7 @@ public abstract class AbstractRegistry implements Registry {
protected static List<URL> filterEmpty(URL url, List<URL> urls) {
if (urls == null || urls.isEmpty()) {
- List<URL> result = new ArrayList<URL>(1);
+ List<URL> result = new ArrayList<>(1);
r... | [AbstractRegistry->[destroy->[getRegistered,getSubscribed,unregister,getUrl,unsubscribe],saveProperties->[doSaveProperties],recover->[subscribe,getRegistered,getSubscribed,register],notify->[filterEmpty,notify],SaveProperties->[run->[doSaveProperties]],toString->[toString]]] | Filter the given urls if they are empty. | curious to know why we to change the protocol type? |
@@ -24,5 +24,5 @@
* @return {string}
*/
export function internalRuntimeVersion() {
- return '$internalRuntimeVersion$';
+ return INTERNAL_RUNTIME_VERSION; // eslint-disable-line no-undef
}
| [No CFG could be retrieved] | Get the internal runtime version. | note: I could also add this to the eslint config, but wasn't sure if that were preferable |
@@ -0,0 +1,10 @@
+module DataUpdateScripts
+ class UpdatePublicReactionCountsAgain
+ def run
+ ActiveRecord::Base.connection.execute("UPDATE articles SET public_reactions_count = positive_reactions_count, previous_public_reactions_count = previous_positive_reactions_count WHERE id < #{Article.count / 2}")
+ ... | [No CFG could be retrieved] | No Summary Found. | I ran this in production console earlier, and don't think I need to adjust our database timeout for this. |
@@ -384,6 +384,9 @@ func NewBlockWithHeader(header *block.Header) *Block {
// CopyHeader creates a deep copy of a block header to prevent side effects from
// modifying a header variable.
func CopyHeader(h *block.Header) *block.Header {
+ if h == nil {
+ return nil
+ }
cpy := *h
cpy.Header = cpy.Header.Copy()
... | [ReceiptHash->[ReceiptHash],Uint64->[Uint64],Epoch->[Epoch],Sort->[Sort],NumberU64->[Uint64,Number],Vdf->[Vdf],Extra->[Extra],Body->[Transactions,StakingTransactions,IncomingReceipts,With,Uncles,Body],Coinbase->[Coinbase],GasLimit->[GasLimit],GasUsed->[GasUsed],Root->[Root],OutgoingReceiptHash->[OutgoingReceiptHash],Sh... | NewBlock creates a new block with the given header transactions and receipts. Put transactions into block and set bloom filter. | I thought about doing this as well but it's ick to give back nil with no reason but actually I think some more and in this case it's fine since caller gave nil |
@@ -49,13 +49,13 @@ func main() {
if isPrefix || err != nil {
logrus.Fatalf("Failed with isPrefix=%t err=%v", isPrefix, err)
}
- writer.WriteString(strings.Replace(string(line), "`", "` + \"`\" + `", -1))
- writer.WriteString("\n")
+ writer.WriteString(strings.Replace(string(line), "`", "` + \"`\" + ... | [Dir,Close,Exit,Walk,Flush,Error,HasSuffix,NewWriter,Create,Fprintln,Infof,Name,ReadLine,Fatalf,TrimSuffix,NewReader,Replace,Open,WriteString] | Add a new object to the Swagger file. | Is this script the same as the one above? What is going on here? (Not part of your PR, just confused) |
@@ -80,7 +80,7 @@ public class AIUtils {
* - calculate the strength of the units in a sea or land battle?
*/
public static float strength(final Collection<Unit> units, final boolean attacking, final boolean sea) {
- int strength = 0;
+ float strength = 0;
for (final Unit u : units) {
... | [AIUtils->[interleaveCarriersAndPlanes->[getIndexOfLastUnitMatching,getLastUnitMatching]]] | Count the number of hits on the unit. | This really seems to be programmer mistale error prone correctly pointed out |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.