patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -362,7 +362,10 @@ async def package_python_dist(
field_set: PythonDistributionFieldSet,
python_setup: PythonSetup,
) -> BuiltPackage:
- transitive_targets = await Get(TransitiveTargets, TransitiveTargetsRequest([field_set.address]))
+ transitive_targets = await Get(
+ TransitiveTargets,
+ ... | [declares_pkg_resources_namespace_package->[is_call_to->[is_name],has_args,is_call_to],get_sources->[SetupPySources],get_owned_dependencies->[OwnedDependency,OwnedDependencies],generate_chroot->[SetupPySourcesRequest,SetupPyChroot,InvalidEntryPoint,DependencyOwner,FinalizedSetupKwargs],get_requirements->[OwnedDependenc... | Package a built - in python distribution. | Was `include_special_cased_deps=True` necessary? I think we had found it's not iirc. We very likely do not want to set this because it results in some weird behaviors. For example, Pants has the `relocated_files` target type, which depends on some `files` targets. If `include_special_cased_deps=True`, then both the ori... |
@@ -331,7 +331,7 @@ void AddUtilitiesToPython(pybind11::module &m)
InputGetConditionNumber ThisGetConditionNumber = &ConditionNumberUtility::GetConditionNumber;
DirectGetConditionNumber ThisDirectGetConditionNumber = &ConditionNumberUtility::GetConditionNumber;
- py::class_<ConditionNumberUtility>(m,"Con... | [No CFG could be retrieved] | Define the functions that return a result of the function. Add the functions for the model part nodal var. | why is this needed? I usually use it without the `Pointer` for simple cases such as this |
@@ -91,6 +91,12 @@ public class HttpHeadersTest {
assertThat(cacheControl.noStore()).isTrue();
}
+ private static void assertSecurityHeaders(Response httpResponse) {
+ assertThat(httpResponse.headers().get("X-Frame-Options")).isNotNull().isEqualTo("SAMEORIGIN");
+ assertThat(httpResponse.headers().get(... | [HttpHeadersTest->[call->[build,propagate,execute],assertCacheInBrowser->[cacheControl,isFalse],no_browser_cache_for_ws->[call,getUrl,assertNoCacheInBrowser],no_browser_cache_for_pages->[call,getUrl,assertNoCacheInBrowser],browser_cache_on_images->[call,assertCacheInBrowser,getUrl],no_browser_cache_in_ruby_ws->[call,ge... | Assert that the given HTTP response does not cache in the browser. | no need for `isNotNull()` IMO |
@@ -164,8 +164,9 @@ func resourceComputeSubnetworkCreate(d *schema.ResourceData, meta interface{}) e
// "When creating a new subnetwork, its name has to be unique in that project for that region, even across networks.
// The same name can appear twice in a project, as long as each one is in a different region."
/... | [Patch,SetPartial,SetPrivateIpGoogleAccess,RelativeLink,Delete,Partial,Set,HasChange,All,Errorf,ForceNewIfChange,ParseCIDR,SetId,AddressRange,Timeout,Do,Contains,Id,Get,Split,Printf,DefaultTimeout,Minutes,ExpandIpCidrRange,Sprintf,Insert] | resourceComputeSubnetworkRead creates a new subnetwork and returns it. Get the n - th network from the client. | Should we set the id based on which subnet version (beta or release api) the request was sent to? Or is the id not generated from the api? |
@@ -197,10 +197,13 @@ static void _image_get_infos(dt_thumbnail_t *thumb)
static gboolean _thumb_expose_again(gpointer user_data)
{
- if(!user_data || !GTK_IS_WIDGET(user_data)) return FALSE;
+ dt_thumbnail_t *thumb = (dt_thumbnail_t *)user_data;
+ gpointer w_image = thumb->w_image;
+ if(!thumb) return FALSE;
+... | [dt_thumbnail_get_zoom100->[fmaxf,_thumb_retrieve_margins,dt_image_get_final_size],dt_thumbnail_create_widget->[GTK_CONTAINER,GTK_LABEL,gtk_widget_set_valign,g_object_ref,gtk_overlay_new,gtk_overlay_add_overlay,gtk_drag_dest_set,dt_thumbnail_resize,DT_DEBUG_CONTROL_SIGNAL_CONNECT,g_signal_connect,gtk_widget_set_name,gt... | This function is called when a user has requested to expose a thumbnail. | this test is too late as just above you use the pointer to access w_image. I would keep: `if(!user_data)) return FALSE;` as the first line on this routine. |
@@ -399,7 +399,8 @@ PYTHON_DEMOS = [
ModelArg('person-detection-retail-0013'),
ModelArg('vehicle-detection-adas-0002'),
ModelArg('vehicle-detection-adas-binary-0001', "FP32-INT1"),
- ModelArg('vehicle-license-plate-detection-barrier-0106')),
+ ModelArg('vehic... | [combine_cases->[join_cases],NativeDemo,single_option_cases,combine_cases,PythonDemo] | Add options for object - detection. The test cases for the command line. | That's python demo test, not C++ |
@@ -137,9 +137,8 @@ struct hda_chan_data {
#if HDA_DMA_PTR_DBG
struct hda_dbg_data dbg_data;
#endif
-
- void (*cb)(void *data, uint32_t type,
- struct dma_sg_elem *next); /* client callback */
+ /* client callback */
+ void (*cb)(void *data, uint32_t type, struct dma_cb_data *next);
void *cb_data; /* client ... | [inline->[dma_chan_base,io_reg_write,host_dma_reg_read,io_reg_update_bits,io_reg_read,host_dma_reg_write],void->[hda_dma_inc_link_fp,hda_dma_stop,spin_unlock_irq,atomic_sub,trace_hddma,host_dma_reg_read,cb,hda_dma_channel_put_unlocked,hda_dma_get_dbg_vals,spin_lock_irq,pm_runtime_put,hda_dma_ptr_trace,dma_get_drvdata,h... | The functions below are defined in the HDA class. read from host DMA reg and write to channel. | Can you explain why there is no need for this check, now? |
@@ -112,7 +112,9 @@ export function getMoreTabProps(stateful: Object | Function) {
&& isLocalParticipantModerator(state));
return {
+ currentFramerate: `${framerate} frames-per-second`,
currentLanguage: language,
+ desktopShareFramerates: SS_SUPPORTED_FRAMERATES,
foll... | [No CFG could be retrieved] | Returns the properties for the More tab from settings dialog from Redux. Get profile tab properties from stateful object. | Can we do i18n for `frames-per-second` or at least change it to fps maybe ...? |
@@ -42,10 +42,10 @@ def get_json_content(file_path):
print('Error: ', err)
return None
+
def generate_pcs(nni_search_space_content):
"""Generate the Parameter Configuration Space (PCS) which defines the
legal ranges of the parameters to be optimized and their default values.
-
Genera... | [generate_scenario->[generate_pcs],generate_scenario] | Load the json file content of and return it as a dict. categorical_dict is a dict of categorical keys and values in the search space. Returns the categorical dict or None if the search space is incorrect. | is it possible that low == high here ? |
@@ -58,6 +58,8 @@ namespace Pulumi
internal IEngine Engine { get; }
internal IMonitor Monitor { get; }
+ internal bool SupportsResourceReferences { get; }
+
internal Stack? _stack;
internal Stack Stack
{
| [Deployment->[Internal,TryParse,Monitor,nameof,IsNullOrEmpty,Engine,GetEnvironmentVariable,Debug]] | Creates a new instance of Deployment. Parse the result set. | Nit: spacing looks off |
@@ -137,7 +137,7 @@ ShellThickElement3D4N::MITC4Params::MITC4Params(const ShellQ4_LocalCoordinateSys
Cy = - LCS.Y1() - LCS.Y2() + LCS.Y3() + LCS.Y4();
double Alpha = std::atan( Ay / Ax );
- double Beta = 3.141592653589793 * 0.5 - std::atan( Cx / Cy );
+ double Beta = Globals::Pi * 0.5 - std::atan( C... | [No CFG could be retrieved] | Inverse of the mJacobian of the mJacobian of the mJac - - - - - - - - - - - - - - - - - - 2017 - 03 - 25. | :+1: Lets hope this doesn't change the values of the tests :D |
@@ -1232,7 +1232,16 @@ def test_skip_validation_in_init_with_kwarg():
assert Flow(name="test", edges=[e1, e2], validate=False)
-@pytest.mark.xfail(raises=ImportError, reason="viz extras not installed.")
+try:
+ import graphviz
+
+ graphviz.pipe("dot", "png", b"graph {a -- b}", quiet=True)
+ no_graphvi... | [test_warning_not_raised_for_tasks_defined_in_flow_context->[ten,add],test_flow_run_handles_error_states_when_initial_state_is_provided->[AddTask,run],TestFlowRunMethod->[test_flow_dot_run_handles_mapped_cached_states_with_differing_lengths->[StatefulTask,run,store_output,repeat_schedule],test_flow_dot_run_with_paused_... | Test visualize raises import error with python graphviz. | This is way clearer (and faster!), but isn't it true that `xfail(raises=ImportError)` will properly `FAIL` if the error type is something different? |
@@ -147,7 +147,7 @@ public class BaseSubscriber<T> implements Subscriber<T> {
VertxUtils.checkContext(context);
}
- private void runOnRightContext(final Runnable runnable) {
+ protected void runOnRightContext(final Runnable runnable) {
if (VertxUtils.isEventLoopAndSameContext(context)) {
// Exec... | [BaseSubscriber->[doOnError->[checkContext,logError,handleError],checkContext->[checkContext],doOnSubscribe->[afterSubscribe,checkContext,cancel,logError],doOnNext->[checkContext,logError,onError,handleValue,complete],complete->[cancel],cancel->[cancel],doOnComplete->[checkContext,logError,handleComplete]]] | Check context. | I'm a little confused, the first line in `makeRequest` checks the context. if that doesn't ensure our property, then what does it do? is there any reason not to just _always_ call `makeRequest` wrapped in a `runOnRightContext`? If that's the case could we keep this private and just make `makeRequest` do that? |
@@ -232,7 +232,7 @@ function profile_sidebar($profile, $block = 0) {
if (isset($profile["url"]))
$profile_url = normalise_link($profile["url"]);
else
- $profile_url = normalise_link($a->get_baseurl()."/profile/".$profile["nickname"]);
+ $profile_url = normalise_link(App::get_baseurl()."/profile/".$profile... | [get_events->[get_baseurl],get_birthdays->[get_baseurl],profile_load->[set_template_engine],profile_tabs->[get_baseurl],advanced_profile->[get_baseurl],profile_sidebar->[get_baseurl]] | profile_sidebar - profile_sidebar - profile_sidebar - profile_sidebar - profile_ This function is used to find a link to a message or a link to a contact. This function is used to generate the profile menu This function is used to create a link to a user s profile. | Standards: Can you please add brackets to this whole conditional statement? |
@@ -69,7 +69,9 @@ public class JdbcStringBasedStoreTest extends BaseStoreTest {
.dbMajorVersion(1)
.dbMinorVersion(4);
- storeBuilder.table().createOnStart(false);
+ storeBuilder.table()
+ .createOnStart(false)
+ .tableNamePrefix("mock_table_name");
J... | [JdbcStringBasedStoreTest->[factory->[segmented],createStore->[segmented]]] | This test is not used in tests. | The `TableName` is initialized in the constructor and the `tableNamePrefix` is required. |
@@ -555,12 +555,13 @@ def _compute_source_psd_epochs(epochs, inverse_operator, lambda2=1. / 9.,
except RuntimeError:
n_epochs = len(epochs.events)
extra = 'on at most %d epochs' % (n_epochs,)
- pb = False
else:
extra = 'on %d epochs' % (n_epochs,)
- pb = True
- logg... | [_source_induced_power->[_prepare_source_params],source_induced_power->[_source_induced_power],compute_source_psd_epochs->[_compute_source_psd_epochs],_compute_pow_plv->[_prepare_tfr],compute_source_psd->[_prepare_source_params],_compute_source_psd_epochs->[_prepare_source_params]] | Generate the PSD for a given set of conditions. Compute the tapered spectra in the source space and the tapered spectra Generate a sequence of the missing - block PSD for a given sequence of time series. | Enhancement: allow MTM estimation to take a string, meaning "use standard estimation". The advantage of this is that in the long run it will greatly simplify our code paths, especially if we go to implement CUDA-based multitaper estimation. |
@@ -654,3 +654,15 @@ def register_resource_package(typ: str, version: str, package):
if existing is not None:
raise ValueError(f"Cannot re-register package {key}. Previous registration was {existing}, new registration was {package}.")
RESOURCE_PACKAGES[key] = package
+
+RESOURCE_MODULES: Dict[str, An... | [serialize_property->[serialize_property,isLegalProtobufValue],resolve_properties->[unwrap_rpc_secret,is_rpc_secret],wrap_rpc_secret->[is_rpc_secret],unwrap_rpc_secret->[is_rpc_secret],translate_output_properties->[unwrap_rpc_secret,is_rpc_secret,translate_output_properties,wrap_rpc_secret],contains_unknowns->[impl->[i... | Register a package for a given type and version. | Instead of the values being typed as `Any` and assuming they are objects with `construct` function (or `construct_provider` for the case of `RESOURCE_PACKAGES`), should these just be functions typed as `Callable`? I was kind of wondering the same for the other languages, especially now that `IResourcePackage`/`IResourc... |
@@ -281,6 +281,10 @@ namespace Microsoft.Xna.Framework.Content.Pipeline.Audio
channelCount,
format,
sampleRate);
+
+ // Loop start and length in number of samples. Defaults to entire sound
+ loopStart = 0;
+ loop... | [AudioContent->[ConvertFormat->[QualityToBitRate],Read->[Read]]] | Convert the AudioContent to the specified format. External tool for reading and parsing vorbis files. This function parses the output of the ffprobe and extracts the n - tuple from the output. | Where was `loopLength` being set before? Shouldn't we be removing that code? |
@@ -559,7 +559,7 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
*/
groupSlotsForSra() {
return groupAmpAdsByType(
- this.win, this.element.getAttribute('type'), getNetworkId);
+ this.win, this.getStringData('type'), getNetworkId);
}
/**
| [AmpAdNetworkDoubleclickImpl->[extractSize->[height,extractAmpAnalyticsConfig,get,Number,setGoogleLifecycleVarsFromHeaders,width],getBlockParameters_->[serializeTargeting_,dev,isInManualExperiment,assign,join,googleBlockParameters,getMultiSizeDimensions,map],delayAdRequestEnabled->[experimentFeatureEnabled,DELAYED_REQU... | Group the slots for the SRA. | window context allows for type to be set within json? |
@@ -68,10 +68,15 @@ async function prBuildWorkflow() {
await signalPrDeployUpload('success');
} else {
await signalPrDeployUpload('skipped');
- printSkipMessage(
+ skipFollowupJobs(
jobName,
'this PR does not affect the runtime, integration tests, end-to-end tests, or visual diff tests'... | [No CFG could be retrieved] | This function processes the nomodule output and uploads it to the PR. | Log ordering nit: I think it would be cleaner to run this step immediately after line 70 (which also satisfies a different GitHub check), and only then print the skip message and create the sentinel file. |
@@ -206,7 +206,7 @@ public class MuleHttpServletResponse implements HttpServletResponse
* Format HTTP date "EEE, dd MMM yyyy HH:mm:ss 'GMT'" or "EEE, dd-MMM-yy HH:mm:ss 'GMT'"for
* cookies
*/
- public static void formatDate(StringBuffer buf, Calendar calendar, boolean cookie)
+ public static voi... | [MuleHttpServletResponse->[addDateHeader->[setDateHeader]]] | Format date. | Someone can be using this public method, but I think its OK if we include this change in the migration guide |
@@ -147,8 +147,8 @@ class Resolver(object):
self._discovered_dependencies = \
defaultdict(list) # type: DiscoveredDependencies
- def resolve(self, requirement_set):
- # type: (RequirementSet) -> None
+ def resolve(self, root_reqs, check_supported_wheels):
+ # type: (List[Ins... | [Resolver->[_resolve_one->[add_req,_get_abstract_dist_for,_check_dist_requires_python],get_installation_order->[schedule->[schedule],schedule],_check_skip_installed->[_set_req_to_reinstall,_is_upgrade_allowed],_get_abstract_dist_for->[_check_skip_installed,_set_req_to_reinstall,_is_upgrade_allowed]]] | Initialize a Resolver with a base - level configuration. Checks if there are any missing link requirements and resolves them. | Regarding the addition of `check_supported_wheels` to the signature of the resolve call -- I think making `check_supported_wheels` an attribute of the resolver, would work better for us. Yes, that'll create a Resolver->RequirementSet coupling, but given that we're now creating the RequirementSet in the resolver, it pro... |
@@ -3034,7 +3034,8 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve
String newWorkspacesDir = SystemProperties.getString(WORKSPACES_DIR_PROP);
if (newWorkspacesDir != null && !workspaceDir.equals(newWorkspacesDir)) {
- LOGGER.log(Level.WARNING, "Changing... | [Jenkins->[getUser->[get],_cleanUpShutdownTcpSlaveAgent->[add],setNumExecutors->[updateComputerList],getPlugin->[getPlugin],_cleanUpCloseDNSMulticast->[add],getViewActions->[getActions],getJDK->[getJDKs,get],setViews->[addView],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getStoredVersion->[getActiveInsta... | Sets the builds and workspaces directories. | I think this will not work. If the user changes it once, then again, the warning will not be shown when it should be. I agree with James that writing a test for this is important here. This will make it obvious that it works or not, and will make much easier for you @charanbir to test and iterate on making sure your ch... |
@@ -141,12 +141,6 @@ RSpec.describe User, type: :model do
.with_foreign_key(:reporter_id)
.dependent(:nullify)
end
-
- it do
- expect(subject).to have_many(:webhook_endpoints)
- .class_name("Webhook::Endpoint")
- .dependent(:delete_all)
- end
# rubo... | [provider_username,user_from_authorization_service,mock_username] | Test the object s properties. Validation of all required fields. | this has been moved outside a block |
@@ -327,10 +327,9 @@ class SVN(SCMBase):
return False
return True
else:
- import warnings
- warnings.warn("SVN::is_pristine for SVN v{} (less than {}) is not implemented, it is"
- " returning not-pristine always because it... | [SVN->[get_revision->[_show_item],_check_svn_repo->[run],_get_item->[_show_item],_show_item->[run,_show_item],update->[run],get_remote_url->[_remove_credentials_url,_show_item],excluded_files->[run],get_qualified_remote_url->[get_remote_url],version->[get_version],is_local_repository->[get_remote_url],get_repo_root->[_... | Check if the object is pristine or consistent. | I am not sure of this change, as logger.warning is very rarely activated. I'd say that we would want an ``output.warn()`` instead. |
@@ -147,6 +147,8 @@ type Enum struct {
Comment string
// Name for the enum.
Name string
+ // DeprecationMessage indicates whether or not the value is deprecated.
+ DeprecationMessage string
}
func (t *EnumType) String() string {
| [bindProperties->[bindType],bindResourceType->[bindResourceTypeDetails],bindEnumTypeDetails->[bindType],bindObjectType->[bindObjectTypeDetails],bindType->[String,bindType,bindPrimitiveType],bindEnumType->[bindEnumTypeDetails],bindObjectTypeDetails->[bindProperties],bindEnumValues->[String],String->[String],bindProperti... | String returns the string representation of the enum type. | Since this isn't a boolean value, it might be worth clarifying that a non-empty string indicates that the enum is deprecated. |
@@ -17,12 +17,13 @@ module Engine
# This works irrespective of if that player has sold this round
# such as in 1889 for exchanging Dougo
#
- def can_gain?(entity, bundle)
+ def can_gain?(entity, bundle, exchanging = false)
return if !bundle || !entity
corporation = bun... | [buy_shares->[corporation,game_error,buy_shares,place_home_token,floated?,can_buy?,class,name],can_gain?->[counts_for_limit,corporation,num_certs,percent,holding_ok?,cert_limit],require_relative] | Checks if the entity can gain a lease. | I wonder if exchange: false would be better? Then it would be called with exchange: true which is a bit more expressive than just passing a simple true. |
@@ -408,7 +408,7 @@ class HTTPSignature
* 'nobody' => only return the header
* 'cookiejar' => path to cookie jar file
*
- * @return object CurlResult
+ * @return CurlResult|void CurlResult
* @throws \Friendica\Network\HTTPException\InternalServerErrorExcepti... | [HTTPSignature->[fetch->[getBody,isSuccess],transmit->[post,getReturnCode],fetchRaw->[head,get,getReturnCode],parseSigheader->[get]]] | Fetch a raw activity from the server Get the status code of the last successful request. | This shouldn't return `void` but throw an Exception if the `$owner` variable is empty, but maybe it's outside of the scope of this PR. |
@@ -386,4 +386,6 @@ class Extends
delete_individual_signature_request
delete_group_signature_request
)
+
+ STI_PRELOAD_CLASSES = %w(LinkedRepository)
end
| [Extends->[freeze]] | Delete an individual signature request from the server. | Style/MutableConstant: Freeze mutable objects assigned to constants. |
@@ -1,11 +1,13 @@
from __future__ import unicode_literals
from django import forms
+from django.db import transaction
from django.forms.models import inlineformset_factory, ModelChoiceIterator
from django.utils.translation import pgettext_lazy
from ...product.models import (ProductImage, Stock, ProductVariant,... | [StockBulkDeleteForm->[delete->[delete]],VariantAttributeForm->[__init__->[CachingModelChoiceField]],CachingModelChoiceField->[_get_choices->[CachingModelChoiceIterator]],VariantBulkDeleteForm->[delete->[delete]]] | A formset that uses a choice field to select a product class. Constructor for a product variant form. | Please run `isort` on this file. |
@@ -274,7 +274,7 @@ class TestTrainer(AllenNlpTestCase):
num_epochs=4, serialization_dir=self.TEST_DIR)
epoch, _ = new_trainer._restore_checkpoint()
assert epoch == 2
- assert new_trainer._learning_rate_scheduler.lr_scheduler.last_epoch == 1
+ assert new_tr... | [TestTrainer->[test_trainer_can_run_multiple_gpu->[MetaDataCheckWrapper->[forward->[forward]],MetaDataCheckWrapper],test_trainer_raises_on_model_with_no_loss_key->[FakeModel],test_trainer_respects_keep_serialized_model_every_num_seconds->[WaitingIterator]]] | Test trainer that can resume with a learning rate scheduler. | Why does this value change? |
@@ -47,7 +47,7 @@ class AuthenticationSample(object):
form_recognizer_client = FormRecognizerClient(endpoint, AzureKeyCredential(key))
# [END create_fr_client_with_key]
- poller = form_recognizer_client.begin_recognize_receipts_from_url(self.url)
+ poller = form_recognizer_client.begin... | [AuthenticationSample,authentication_with_api_key_credential_form_recognizer_client,authentication_with_azure_active_directory_form_training_client,authentication_with_api_key_credential_form_training_client,authentication_with_azure_active_directory_form_recognizer_client] | Creates a client for use with the form recognition service. | Should `receipt` be updated to `form`? (just for clarity) Same question for the change below. |
@@ -17,7 +17,9 @@
#include <osquery/filesystem.h>
#include <osquery/tables.h>
+#include "Shlwapi.h"
#include "osquery/tables/system/windows/registry.h"
+#include "windows.h"
namespace fs = boost::filesystem;
| [getQueue->[listFilesInDirectory,INTEGER,ok,filename],genCarbonBlackInfo->[getQueue,push_back,getSettings],getSettings->[SQL_TEXT,INTEGER,queryKey,strtoll,at,str]] | Creates a queue of all binary and event events in the Black Direcotry. get settings for all the header. | Place these OS includes above boost's in their own category. |
@@ -14,8 +14,8 @@ namespace System.Collections.Specialized
/// </devdoc>
[Serializable]
[System.Runtime.CompilerServices.TypeForwardedFrom("System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
- [DesignerSerializer("System.Diagnostics.Design.StringDictionaryCodeDomSerializer, S... | [StringDictionary->[Clear->[Clear],ContainsValue->[ContainsValue],CopyTo->[CopyTo],ContainsKey->[ContainsKey],Add->[Add],Remove->[Remove]]] | Creates a StringDictionary based on a number of key - and object types. Magic number of values in the StringDictionary. | Do we have tests for this at all? How was this found? |
@@ -33,6 +33,7 @@ import java.util.Set;
/**
*/
+@PublicApi
public class Queries
{
public static List<PostAggregator> decoratePostAggregators(
| [Queries->[decoratePostAggregators->[add,decorate,newArrayListWithExpectedSize,size],prepareAggregations->[decorate,getName,size,checkArgument,getDependentFields,difference,checkNotNull,newArrayListWithExpectedSize,addAll,isEmpty,add,put]]] | Decorates post - aggregators. | Should it really be public API? |
@@ -223,7 +223,6 @@ require('react-styl')(`
.conversations-wrapper
display: flex
flex-direction: row
- height: calc(100vh - 6rem)
.conversations-list
flex: 1
overflow-y: scroll
| [No CFG could be retrieved] | Displays a block of n - node messages. Example of how to color a variable in the console. | I think this may cause an issue on desktop. Right now we limit height of the conversation window then scroll to the bottom so the user can see the latest messages. |
@@ -63,7 +63,7 @@ exemptions = {
# exemptions applied to all files.
r'.py$': {
# Exempt lines with URLs from overlong line errors.
- 501: [r'^(https?|file)\:']
+ 501: [r'(https?|file)\:']
},
}
| [flake8->[cwd_relative->[relpath,group,getcwd,join],prefix_relative->[relpath,abspath,realpath],split,mkdtemp,flake8,working_dir,print,sub,prefix_relative,copy,strip,filter_file,join,which,exit,changed_files,rmtree],filter_file->[rstrip,search,write,dirname,items,open,mkdirp],setup_parser->[add_argument],dict,Executabl... | Runs source code style checks on Spack. Requires flake8. Write a file containing the . txt file. | @tgamblin Do you want to add `git=` above too? |
@@ -1110,6 +1110,8 @@ class ModelAverage(Optimizer):
The size of average window is determined by average_window_rate,
min_average_window, max_average_window and current update times.
+ the effective average window should be larger than min_average_window and
+ larger than min(average_window_rate * num... | [AdamaxOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],MomentumOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],Optimizer->[minimize->[create_optimization_pass],_create_param_lr->[global_learning... | The main function of the n - tuple class. Initialize a ModelAverage object from a sequence of sequence numbers. | 'the' -> 'The' and 'larger'->'less ' ? |
@@ -927,7 +927,7 @@ func WaitForPipeline(t testing.TB, nodeID int, jobID int32, expectedPipelineRuns
var matched []pipeline.Run
for _, pr := range prs {
- if pr.State != state {
+ if !pr.State.Finished() && pr.State != state {
continue
}
| [Get->[Get],Delete->[Delete],NewClientAndRenderer->[MustSeedNewSession],NewHTTPClient->[MustSeedNewSession],Start->[Start],Post->[Post],Import->[Import],Patch->[Patch],Put->[Put],Stop,Get,Delete,FailNow,NewHTTPClient,Post] | WaitForPipeline returns a list of job. SpecError. AssertPipelineRunsStays asserts that the number of pipeline runs for a particular job is at. | Does this change require those go.mod/sum modifications? |
@@ -257,4 +257,13 @@ namespace System.Net.Test.Common
INADEQUATE_SECURITY = 0xc,
HTTP_1_1_REQUIRED = 0xd
}
+
+ public static class HttpVersion20
+ {
+#if !NETFRAMEWORK
+ public static readonly Version Value = HttpVersion.Version20;
+#else
+ public static readonly Version Value... | [Http2LoopbackServer->[AcceptConnectionAsync->[RemoveInvalidConnections],Dispose->[Dispose]]] | The default values for the ethernet_security_header field. | We don't compare for reference equality, so just the `#else` will work here too. |
@@ -50,11 +50,12 @@ export function createCustomEvent(win, type, detail, opt_eventInit) {
* @param {string} eventType
* @param {function(!Event)} listener
* @param {boolean=} opt_capture
+ * @param {boolean=} opt_passive
* @return {!UnlistenDef}
*/
-export function listen(element, eventType, listener, opt_cap... | [No CFG could be retrieved] | Creates a new CustomEvent with a given type and detail. Listens for the specified event on the element and removes the listener as soon as the event. | Any reason not to make this `@param {boolean|EventListenerOptions}` opt_catureOrOptions |
@@ -121,7 +121,8 @@ public class RayConfig {
}
// Namespace of this job.
- namespace = config.getString("ray.job.namespace");
+ String localNamespace = config.getString("ray.job.namespace");
+ namespace = StringUtils.isEmpty(localNamespace) ? UUID.randomUUID().toString() : localNamespace;
//... | [RayConfig->[updateSessionDir->[removeTrailingSlash],create->[RayConfig],validate,LoggerConf]] | This method is used to initialize the object. object - store. socket - name - address - password. | Does the pattern of generated namespace string match Python? |
@@ -27,9 +27,9 @@ class ApacheHttp01Test(util.ApacheTest):
self.achalls = [] # type: List[achallenges.KeyAuthorizationAnnotatedChallenge]
vh_truth = util.get_vh_truth(
self.temp_dir, "debian_apache_2_4/multiple_vhosts")
- # Takes the vhosts for encryption-example.demo, certbot.dem... | [ApacheHttp01Test->[test_enable_modules_apache_2_2->[remove,common_enable_modules_test,assertEqual],common_perform_test->[assertTrue,perform,assertEqual,isdir,find_dir,add_chall,len,response,_test_challenge_file,exists,assertFalse,_has_min_permissions,_test_challenge_conf],_test_challenge_file->[assertEqual,read,join,e... | Set up the ApacheHttp01 object. | We don't need to add these vhosts to this list do we? As far as I can tell, they are never used here. |
@@ -10,6 +10,9 @@ import (
"github.com/qrtz/nativemessaging"
)
+// Version is the build version of kbnm, overwritten during build.
+const Version = "dev"
+
// Response from the kbnm service
type Response struct {
Status string `json:"status"`
| [NewNativeJSONDecoder,Fprintf,Error,NewNativeJSONEncoder,NewEncoder,Decode,Parse,Encode,NewDecoder,Bool] | main import imports a single response from the kbnm service. | Make it real semver? 0.1.1 (< 1.0 is considered dev) |
@@ -13,6 +13,10 @@
* It calls the same functions as the generation as the code is very similar.
*/
+#include <openssl/err.h>
+#include <openssl/bn.h>
+#include <openssl/dsaerr.h>
+#include <openssl/dherr.h>
#include "internal/ffc.h"
/* FIPS186-4 A.2.2 Unverifiable partial validation of Generator g */
| [No CFG could be retrieved] | This function validates the unverifiable fields of a national non - zero national non This function validates the FIPS - 186 - 4 parameters. | These errors are a bit horrible to include here.. Should it just use ffc instead? |
@@ -46,6 +46,7 @@ func NewTraefikDefaultPointersConfiguration() *TraefikConfiguration {
defaultDocker.ExposedByDefault = true
defaultDocker.Endpoint = "unix:///var/run/docker.sock"
defaultDocker.SwarmMode = false
+ defaultDocker.SwarmRefreshPeriod = 15
// default File
var defaultFile file.Provider
| [Duration] | NewTraefikDefaultPointersConfiguration creates a new TraefikConfiguration object. Deprecated - default metrics. | Sorry, but I made a mistake, I would say `SwarmModeRefreshPeriod` in the way to be homogeneous with the option `SwarmMode` and avoid misunderstood with the old Swarm orchestrator... |
@@ -469,6 +469,14 @@ public final class CertificateUtils {
// (2) extendedKeyUsage extension
certBuilder.addExtension(Extension.extendedKeyUsage, false, new ExtendedKeyUsage(new KeyPurposeId[]{KeyPurposeId.id_kp_clientAuth, KeyPurposeId.id_kp_serverAuth}));
+ // (3) subjectAlterna... | [CertificateUtils->[generateIssuedCertificate->[generateIssuedCertificate,getUniqueSerialNumber,reverseX500Name],isTlsError->[isTlsError],getSubjectAlternativeNames->[getSubjectAlternativeNames],generateSelfSignedX509Certificate->[getUniqueSerialNumber,reverseX500Name]]] | Generate a self - signed X. 509 certificate. | Although all current uses of `generateSelfSignedX509Certificate()` appear to include a common name in the distinguished name string, common name is not necessarily required. Perhaps creating a separate method along the lines of `String getCommonName(String dn)` would allow for checking whether `getRDNs(BCStyle.CN)` ret... |
@@ -14,6 +14,8 @@ class LocalEnvironment(Environment):
used, the environment variables from this process will be passed.
Args:
+ - executor (Executor, optional): the executor to run the flow with. If not provided, the
+ default executor will be used.
- labels (List[str], optional)... | [LocalEnvironment->[execute->[on_exit,exception,runner_cls,format,on_start,get_default_flow_runner_class]]] | A class for executing a single . Called when the process exits. | The bit in here about `get_env_runner` can be removed. |
@@ -0,0 +1,18 @@
+// Licensed to Elasticsearch B.V. under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Elasticsearch B.V. licenses this file to you under
+// the Apache License, Version 2.0 (the "License"... | [No CFG could be retrieved] | No Summary Found. | The package name `metrics` is maybe a little too generic for what is provided. If you don't want to have this internal package to be used from the outside, put it into an internal package. |
@@ -166,7 +166,7 @@ class DownloadManager
* @throws \InvalidArgumentException if package have no urls to download from
* @throws \RuntimeException
*/
- public function download(PackageInterface $package, $targetDir, $preferSource = null)
+ public function download(PackageInterface $package, $tar... | [DownloadManager->[update->[download,update,getDownloaderForInstalledPackage],setOutputProgress->[setOutputProgress],download->[download,getDownloaderForInstalledPackage],remove->[remove,getDownloaderForInstalledPackage],getDownloaderForInstalledPackage->[getDownloader]]] | Downloads a package from the source and dist types. | why don't you pass in the loop at construction time instead of per method? |
@@ -276,7 +276,7 @@ function qFactory(nextTick, exceptionHandler) {
this.$$state.pending = this.$$state.pending || [];
this.$$state.pending.push([result, onFulfilled, onRejected, progressBack]);
- if (this.$$state.status > 0) scheduleProcessQueue(this.$$state);
+ if (this.$$state.status > 0) s... | [No CFG could be retrieved] | Creates a promise manager which represents a task which will finish in the future. Process the queue of functions that are waiting for a value. | There is something very weird with this change... why would you want the generated promise and only if the current promise is fulfill (and in this case, only some of the promises will be _marked_ and some will not... |
@@ -210,6 +210,14 @@ func (r *registrations) sendLog(log types.Log, orm ORM, latestHead models.Head,
continue
}
+ if !latestHead.IsInChain(log.BlockHash) {
+ logger.Tracew("Skipping because not in canonical ",
+ "chainLen", latestHead.ChainLength(), "blockHash", latestHead.Hash,
+ "logBlockHash", log.... | [sendLog->[IsV2Job,IsInChain,Add,Errorw,JobIDV2,HandleLog,CopyLog,Wait,Done,JobID],removeSubscriber->[resetHighestNumConfirmations],addSubscriber->[maybeIncreaseHighestNumConfirmations],sendLogs->[sendLog],IsInChain,Hash,Sprintf,ChainLength,Debugw,ChainHashes] | sendLog sends a log to all listeners in the list of registered listeners. This function is called by the contract log library when it is called to receive a message. | should it say "not in canonical longest chain" ? |
@@ -726,11 +726,8 @@ func (c *Container) makeBindMounts() error {
c.state.BindMounts["/etc/resolv.conf"] = newResolv
// Make /etc/hosts
- if path, ok := c.state.BindMounts["/etc/hosts"]; ok {
+ if _, ok := c.state.BindMounts["/etc/hosts"]; ok {
// If it already exists, delete so we can recreate
- if err := os... | [cleanupNetwork->[save],prepare->[mountStorage],initAndStart->[save,init,removeConmonFiles],saveSpec->[bundlePath],init->[save],cleanupStorage->[save],cleanup->[cleanupNetwork,cleanupStorage],removeConmonFiles->[bundlePath],start->[save],mountStorage->[save],generateHosts->[writeStringToRundir],isStopped->[syncContaine... | makeBindMounts creates the bind mounts for the container writeStringToRundir writes the hostname and containerenv files to the Rundir. | Any reason we aren't removing the old hosts file here? |
@@ -134,6 +134,12 @@ public abstract class AbstractExtensionObjectFactory<T> extends AbstractAnnotate
if (resolver != null) {
resolverSet.add(parameterName, resolver);
+ } else if (p.isRequired()) {
+ throw new IllegalStateException(format("Parameter '%s' of type %s from the %s '%s' is req... | [AbstractExtensionObjectFactory->[toValueResolver->[toValueResolver],resolveParameters->[toValueResolver,getParameters],getParametersAsResolverSet->[getParametersAsResolverSet,getParameters],resolveParameterGroups->[resolveParameterGroups]]] | Gets the list of parameters as a set of Resolver objects. | olEse("Unknwown") or something like that |
@@ -8,16 +8,13 @@ internal static partial class Interop
{
internal static partial class Kernel32
{
+#pragma warning disable DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
+ ... | [No CFG could be retrieved] | Gets the full path name of a long path object. | What is going to be the recommended way to make these work with GeneratedDllImports? |
@@ -94,6 +94,7 @@ func (s *statePersister) persist(ctx context.Context) error {
fs, err := s.state.GetFullState()
if err != nil {
+ s.persistFailed.Inc()
return err
}
| [starting->[WaitReady],persist->[GetFullState,WithTimeout,Position,Log,SetFullState,Debug],iteration->[persist,Log,Error],RegisterFlagsWithPrefix->[DurationVar],New,NewTimerService] | persist is used to persist the state of the user in the state store. | The current logic is fine, but typically it's more robust if you give a name to the returned `error` and then define a `defer` which increase the failed metric if the returned `error != nil` |
@@ -61,6 +61,7 @@ install_requires = [
"funcy>=1.12",
"pathspec>=0.5.9",
"shortuuid>=0.5.0",
+ "tqdm>=4.32.2",
"win-unicode-console>=0.5; sys_platform == 'win32'",
]
| [build_py->[pin_version->[write,mkpath,format,join,open],run->[run,execute]],find_packages,setup,append,dirname,read,exec,join,open] | Create a class that implements the build_py. The list of all possible dependencies for the given platform. | Just a note to ourselves: we'll need to update our conda package requirements for the next release. |
@@ -931,7 +931,7 @@ class GlobalOptions(Subsystem):
"--build-ignore",
advanced=True,
type=list,
- default=[".*/", "bower_components/", "node_modules/", "*.egg-info/"],
+ default=["bower_components/", "node_modules/", "*.egg-info/"],
help=(
... | [OwnersNotFoundBehavior->[to_glob_match_error_behavior->[GlobMatchErrorBehavior]],FilesNotFoundBehavior->[to_glob_match_error_behavior->[GlobMatchErrorBehavior]],GlobalOptions->[register_options->[register_bootstrap_options]],ExecutionOptions] | Register options not tied to any particular task or subsystem. Register a bunch of flags that can be used to find a specific hierarchical failure. Register a bunch of critical options that can be run continuously. | Should we include these too? They seem very legacy. |
@@ -286,8 +286,8 @@ def theme_checksum(theme, **kw):
def rereviewqueuetheme_checksum(rqt, **kw):
"""Check for possible duplicate theme images."""
dupe_personas = Persona.objects.filter(
- checksum=make_checksum(rqt.header_path or rqt.theme.header_path,
- rqt.footer_path o... | [theme_checksum->[make_checksum],calc_checksum->[make_checksum],rereviewqueuetheme_checksum->[make_checksum],save_theme_reupload->[rereviewqueuetheme_checksum,save_persona_image],save_theme->[create_persona_preview_images,theme_checksum,save_persona_image],bump_appver_for_legacy_addons->[bump_appver_for_addon_if_necess... | Check for possible duplicate theme images. | If this lands we should remove all files in that folder too (nothing you can do though) |
@@ -95,6 +95,16 @@ namespace Microsoft.Xna.Framework.Graphics
public static bool operator ==(DisplayMode left, DisplayMode right)
{
+ object leftMode = (object) left;
+ object rightMode = (object) right;
+ if (leftMode == null && rightMode == null)
+ {
+ ... | [DisplayMode->[ToString->[height,CurrentCulture,Format,refreshRate,width],GetHashCode->[GetHashCode],width,height,format,refreshRate]] | Replies the area of the title safe display modes. | Why is the cast to object required here? Could you not just test the original DisplayMode arguments? |
@@ -212,6 +212,7 @@ public class CorePlugin implements Plugin {
// batch
extensions.add(ProfileSensor.class);
+ extensions.add(ProfileEventsSensor.class);
extensions.add(ProjectLinksSensor.class);
extensions.add(AsynchronousMeasuresSensor.class);
extensions.add(UnitTestDecorator.class);
| [CorePlugin->[toString->[getKey],getExtensions->[add,newLinkedList]]] | This method returns a list of all extensions that are available in the system. This method returns a list of all classes that can be decorated. | Why new sensor added instead of update of ProfileSensor ? |
@@ -217,7 +217,6 @@ public class DownloadMapsWindow extends JFrame {
Interruptibles.awaitResult(SingletonManager::getMapDownloadListInBackground)
.result
- .filter(not(Collection::isEmpty))
.ifPresent(
downloads -> {
state = State.INITIALIZING;
| [DownloadMapsWindow->[showDownloadMapsWindowAndDownload->[showDownloadMapsWindowAndDownload],SingletonManager->[createAndShow->[DownloadMapsWindow]]]] | Initialize the map. | This is a bit of a fix. If we get an empty list and no other error, then clicking the 'download maps' button does nothing. Removing this filter at least has the button doing something, albeit we show an empty download maps window, but at least that is something. |
@@ -16,3 +16,5 @@ MASKER_DICT = {
'apoz': ActivationAPoZRankFilterPrunerMasker,
'mean_activation': ActivationMeanRankFilterPrunerMasker
}
+
+MAX_EPOCHS = 9999
\ No newline at end of file
| [No CFG could be retrieved] | Tenant - specific masks for Approximate and Mean Activation. | where we use this? |
@@ -444,6 +444,15 @@ public class OzoneManagerStateMachine extends BaseStateMachine {
return OMRatisHelper.smProtoToString(proto);
}
+ @Override
+ public void close() throws IOException {
+ // OM should be shutdown as the StateMachine has shutdown.
+ LOG.info("StateMachine has shutdown. Shutdown Ozone... | [OzoneManagerStateMachine->[terminate->[terminate],stop->[stop],initialize->[initialize],runCommand->[terminate],completeExceptionally->[completeExceptionally]]] | Returns the string representation of the given state machine log entry proto. | Question: I see this is called from Ratis, when any StateMachine has hit exception. In this case, do we want to terminate OM, is this handled to handle any failure of notifyConfigurationChanged where we are throwing OzoneIllegalArgumentException? |
@@ -67,11 +67,11 @@ class AvroSerializerTests(AzureTestCase):
raw_avro_object_serializer = AvroObjectSerializer()
dict_data_wrong_type = {"name": u"Ben", "favorite_number": u"something", "favorite_color": u"red"}
- with pytest.raises(avro.io.AvroTypeException):
+ with pytest.raises(Avr... | [AvroSerializerTests->[test_raw_avro_serializer->[parse,serialize,AvroObjectSerializer,deserialize],test_basic_sr_avro_serializer_without_auto_register_schemas->[AvroSerializer,parse,get_schema_properties,str,serialize,deserialize,create_basic_client,close,encode],test_raw_avro_serializer_negative->[parse,raises,serial... | Test for negative values in raw avro format. This function serializes the nanominical record in the dictionary and verifies that it is valid. | kept AvroTypeException here, since we catch the exceptions in the AvroSerializer and not the object serializer. Would we prefer to catch + except our SchemaParseError/etc. in the object serializer instead? (I believe we discussed that we would rather catch in the Avro Serializer, but correct me if I'm wrong :P ) |
@@ -39,9 +39,9 @@ import (
)
const (
- // By convention, the executor is the name of the current program
- // (pulumi-language-nodejs) plus this suffix.
- nodeExecSuffix = "-exec" // the exec shim for Pulumi to run Node programs.
+ // The path to the "run" program which will spawn the rest of the language host. Thi... | [constructArguments->[GetArgs,GetDryRun,Sprint,GetProject,GetParallel,GetMonitorAddress,GetProgram,GetPwd,GetStack],Run->[Sys,Wrapf,Join,Infoln,Error,V,constructArguments,Environ,Errorf,ExitStatus,Wrap,constructConfig,Run,Command],constructConfig->[Marshal,Name,GetConfig,ParseKey,Namespace],GetRequiredPlugins->[GetProg... | The LanguageHostServer endpoint is the language host server that spawns all of the node StringVar returns the name of the executable to use for the given language host. | Do we need to worry about path separator differences? Not sure if Go can handle that gracefully or not. |
@@ -54,7 +54,8 @@ type ConfigSchema struct {
EthHeadTrackerSamplingInterval time.Duration `env:"ETH_HEAD_TRACKER_SAMPLING_INTERVAL" default:"1s"`
EthLogBackfillBatchSize uint32 `env:"ETH_LOG_BACKFILL_BATCH_SIZE" default:"100"`
EthMaxGasPriceWei big.I... | [TypeOf,Lookup,New,Kind,FieldByName,Interface,Get,Panicf] | The default configuration for the ethernet_eth_balance_monitor module. Config variable for Ethereum header reaper. | should perhaps at first remain here but result in a warning asking to migrate to ETH_MAX_QUEUED_TRANSACTIONS ? |
@@ -10718,10 +10718,14 @@ std::string wallet2::decrypt(const std::string &ciphertext, const crypto::secret
THROW_WALLET_EXCEPTION_IF(!crypto::check_signature(hash, pkey, signature),
error::wallet_internal_error, "Failed to authenticate ciphertext");
}
- crypto::chacha20(ciphertext.data() + sizeof(iv), c... | [No CFG could be retrieved] | private private private and public key check if the account has a payment id and if so return it. | Wipe buffer. Or just use wipeable string and conver to `T`. |
@@ -45,7 +45,15 @@ const LockupConfirm = props => {
return (
<div className="text-center p-5 text-muted">
<h1>
- An error occurred confirming your token lockup, has the token expired?
+ An error occurred confirming your token lockup. Please try again or{' '}
+ <a
+ href="mai... | [No CFG could be retrieved] | Displays a hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden hidden. | 99% of the time this will be an expiry, you sure we don't want to mention something about expiry? |
@@ -34,8 +34,10 @@ module View
entity = entity.owner if entity.company? && !round.active_entities.one?
left = []
+ left << render_mode_button if @step.respond_to?(:mode_enabled?) && @step.mode_enabled?
left << h(SpecialBuy) if @current_actions.include?('special_buy')
- ... | [Operating->[render->[round,new,company?,show_other,any?,abilities,h,price_protection,one?,current_entity,include?,operator?,actions_for,each,corporation,render,owner,active_step,floated?,player?,store,respond_to?],needs],require] | Renders a node with a that is not part of the current state. Creates a tree with the top - level hierarchy for a . if there are no children return nil. | switch this to an if else? |
@@ -484,15 +484,7 @@ function _mapStateToProps(state) {
* @private
* @type {boolean}
*/
- _toolboxVisible: visible,
-
- /**
- * The indicator which determines whether the Toolbox is always visible.
- *
- * @private
- * @type {boolean}
- ... | [No CFG could be retrieved] | The indicator which determines whether the Toolbox is always visible or not. | can you explain why `alwaysVisible` needs to be removed ? |
@@ -173,8 +173,7 @@ struct work_queue_timesource platform_generic_queue[] = {
.timer_clear = platform_timer_clear,
.timer_get = platform_timer_get,
},
-#if defined(CONFIG_CANNONLAKE) || defined(CONFIG_ICELAKE) \
- || defined(CONFIG_SUECREEK)
+#if CAVS_VERSION >= CAVS_VERSION_1_8
{
.timer = {
.id = TIMER3, /... | [No CFG could be retrieved] | private static final int MAILBOX_EXCEPTION_SIZE = 0 ; private static int M The platform timer is a singleton object. | I've moved CAVS_VERSION defines change to another commit |
@@ -305,8 +305,10 @@ class Install extends BaseObject
$help .= L10n::t('You can alternatively skip this procedure and perform a manual installation. Please see the file "INSTALL.txt" for instructions.') . EOL;
}
- self::addCheck($checks, L10n::t('config/local.ini.php is writable'), $status, false, $help);
+ ... | [Install->[createConfig->[getBasePath],checkHtAccess->[getRedirectUrl,getBody,getError]]] | Checks if the local. ini file is writable. | Shouldn't it be `$this->addCheck` instead? |
@@ -672,4 +672,14 @@ def test_eog_channel():
ica.fit(inst, picks=picks1)
assert_false(any('EOG' in ch for ch in ica.ch_names))
+def test_get_sources_repr():
+ """Test __repr__ from Raw object created by ica (test for #3804)"""
+ raw = read_raw_fif(raw_fname, preload=True).crop(0.5, stop).load_... | [test_ica_reject_buffer->[dict,catch_warnings,assert_equal,assert_true,len,read_raw_fif,ICA,getvalue,catch_logging,pick_types,fit],test_ica_reset->[all,any,hasattr,_reset,catch_warnings,assert_true,read_raw_fif,ICA,pick_types],test_ica_twice->[catch_warnings,assert_equal,apply,read_raw_fif,ICA,pick_types,fit],test_run_... | Test that EOG channel is included when performing ICA. | can't we just update a test to avoid unnecessary test time? |
@@ -89,7 +89,9 @@ import org.slf4j.LoggerFactory;
public class ZetaSQLQueryPlanner implements QueryPlanner {
// TODO(BEAM-11747) Re-enable BeamJavaUdfCalcRule by default when it is safe to do so.
public static final Collection<RelOptRule> DEFAULT_CALC =
- ImmutableList.<RelOptRule>builder().add(BeamZetaSqlC... | [ZetaSQLQueryPlanner->[createPlanner->[ZetaSQLQueryPlanner],getDefaultTimezone->[getDefaultTimezone],convertToBeamRel->[convertToBeamRel],setDefaultTimezone->[setDefaultTimezone],getLanguageOptions->[getLanguageOptions]]] | This class is used to create a new planner for the BeamZetaSQLQuery. Creates a new instance of ZetaSQLQueryPlanner. | Will it make sense to create two RuleSets? One for each dialect? |
@@ -72,7 +72,7 @@ class DvcIgnoreFile(DvcIgnoreConstant):
class DvcIgnoreFilter(object):
- def __init__(self, wdir, ignore_file_handler=None):
+ def __init__(self, wdir, tree):
self.ignores = [
DvcIgnoreDir(".git"),
DvcIgnoreDir(".hg"),
| [DvcIgnoreFromFile->[__init__->[read_patterns]],DvcIgnoreFilter->[__call__->[update],update->[DvcIgnoreFromFile],_process_ignores_in_parent_dirs->[get_repo_root],__init__->[DvcIgnoreFile,DvcIgnoreDir]]] | Initialize DvcIgnoreDir object. | Maybe it would make sense to just make it a part of the tree itself? dvc_walk and walk_files are also not used without the `tree`, so it seems to make sense to move those to Tree as well. |
@@ -377,6 +377,7 @@ public class TcpNioConnection extends TcpConnectionSupport {
// only execute run() if we don't already have one running
this.executionControl.set(1);
this.taskExecutor.execute(this);
+ logger.debug("Running an assembler");
} else {
this.executionControl.decrementAndGet();
... | [TcpNioConnection->[doClose->[close],doRead->[close,allocate],run->[isOpen],getPort->[getPort],isOpen->[isOpen],ChannelInputStream->[close->[close],read->[read]],readPacket->[doRead],allocate->[allocate],ChannelOutputStream->[close->[doClose],doWrite->[write]],convert->[dataAvailable]]] | check for asynchronous tasks. | Gary, in this class there is a typo: Closing single use **cbannel** after inbound message |
@@ -417,7 +417,7 @@ describe AdminPublicBodyCategoriesController do
end
it 'saves edits to category_tag if the category has no associated bodies' do
- category = FactoryGirl.create(:public_body_category, :category_tag => 'empty')
+ category = FactoryBot.create(:public_body_category, :categ... | [create,find,describe,match_array,category_tag,create!,first,it,attributes_for,put,description,to,edit_admin_category_path,save!,before,set_locales,post,destroy_all,destroy,require,include,sort,squish,title,except,id,locale,redirect_to,context,get,eq,render_template,with_locale,reload] | on success returns a view of the public body category saves edits to a public body category in another locale. | Line is too long. [85/80] |
@@ -914,18 +914,3 @@ def smoketest(
if not success:
sys.exit(1)
-
-
-@run.command(
- help=(
- "Start an echo node.\n"
- "Mainly useful for development.\n"
- "See: https://raiden-network.readthedocs.io/en/stable/api_walkthrough.html"
- "#interacting-with-the-raiden-echo-nod... | [smoketest->[print_step,append_report],run->[write_stack_trace,run]] | Test raiden s smoketest. Raiden specific setup. Handle unclean node. Check if a node has a reserved key. | Can you update the docs as well? Makes probably the most sense to move these docs to the new echo node. |
@@ -809,9 +809,15 @@ func (pkg *pkgContext) genHeader(w io.Writer, goImports []string, importedPackag
var imports []string
if len(importedPackages) > 0 {
for k := range importedPackages {
- imports = append(imports, k)
+ imports = append(imports, fmt.Sprintf("%s", k))
}
sort.Strings(imports)
+
+ for i... | [genResource->[plainType,getDefaultValue,inputType,outputType],genType->[genInputTypes,genOutputTypes,details,genPlainType,tokenToType],plainType->[tokenToType,plainType],genFunction->[genPlainType],outputType->[tokenToType,outputType],getTypeImports->[getTypeImports,add],genConfig->[genHeader,getDefaultValue,getImport... | genHeader writes a header file to the writer. | Why is this change necessary? |
@@ -69,7 +69,10 @@ class EventHubError(Exception):
self.message += "\n{}".format(detail)
except: # pylint: disable=bare-except
self.message += "\n{}".format(details)
- super(EventHubError, self).__init__(self.message)
+ if details and isinstance(details,... | [_handle_exception->[EventDataSendError,_create_eventhub_exception,EventDataError],_create_eventhub_exception->[ConnectionLostError,ConnectError,AuthenticationError,EventHubError]] | Initialize EventHubError with message and details. | what happens if details is None? wondering if we really need this check |
@@ -645,9 +645,15 @@ namespace Dynamo.ViewModels
case "ShowWhitespaceIsChecked":
case "NodeAutocompleteIsChecked":
case "EnableTSplineIsChecked":
- UpdateSavedChangesLabel();
- break;
+ description = Res.Preferen... | [PreferencesViewModel->[AddPythonEnginesOptions->[GetPythonEngineOptions],RemoveStyleEntry->[UpdateSavedChangesLabel],AddPythonEnginesOptions]] | This method is called when a model property is changed. | ~~This way of logging is more code efficient.. But can't seem to rule out the cases for dialog initialization, because in those cases Dynamo raise property changes regardless if it's user change.. Will look a bit more on best way~~ |
@@ -745,7 +745,14 @@ function jetpack_likes_more_info() { ?>
<p><?php esc_html_e( 'Likes allow your readers to show their appreciation for your posts and other published content using their WordPress.com accounts. Your readers will then be able to review their liked posts from WordPress.com.', 'jetpack' ) ?></p>
... | [No CFG could be retrieved] | Jetpack likes more info. | This may not be necessary since they don't have access to the settings page at all if `! current_user_can( 'jetpack_manage_modules' )`, and it's not displayed on the main admin page. |
@@ -1,8 +1,10 @@
/*global define*/
define([
- 'Core/defaultValue'
+ 'Core/defaultValue',
+ 'Core/FeatureDetection'
], function(
- defaultValue) {
+ defaultValue,
+ FeatureDetection) {
"use strict";
function createMouseEvent(type, options) {
| [No CFG could be retrieved] | Define the default mouse event. missing options. | Do we need `FeatureDetection` in this file? |
@@ -0,0 +1,13 @@
+# --------------------------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for license information.
+# -----------------------------------------------... | [No CFG could be retrieved] | No Summary Found. | We don't need one file per type. |
@@ -1595,8 +1595,8 @@ class ServiceBusQueueTests(AzureMgmtTestCase):
auto_lock_renew = AutoLockRenewer()
auto_lock_renew._renew_period = 1
with auto_lock_renew: # Check that in normal operation it does not get called
- auto_lock_renew.register(receiver, renewable=MockReceivedMessag... | [ServiceBusQueueTests->[test_queue_message_batch->[message_content],test_queue_send_mapping_messages->[MappingMessage,BadMappingMessage],test_queue_receive_batch_without_setting_prefetch->[message_content]]] | Test that the mock AutoLockRenewer callback is called when the object is renewed. This function is called when the lock is expired. It is called when the lock is expired. | in this test case, 2 seconds would result in random failure on windows, so increasing the time a bit to let AutoLockRenewer to have enough time for renewing work. also, the minimum allowed lock duration by the service is 5 seconds |
@@ -1326,10 +1326,9 @@ public class ManagementServerImpl extends ManagerBase implements ManagementServe
if (s_logger.isDebugEnabled()) {
s_logger.debug("Searching for all hosts in cluster " + cluster + " for migrating VM " + vm);
}
- allHostsPair = searchForServers(... | [ManagementServerImpl->[updateClusterPassword->[getHypervisorType,updateHostsInCluster],excludeNonDPDKEnabledHosts->[getId],updateVmGroup->[updateVmGroup,getId],getHypervisors->[getId],searchForVlans->[getId],startSystemVM->[startConsoleProxy,startSecondaryStorageVm],listCapabilities->[getId],searchForAlerts->[getId],s... | This method returns a list of hosts that can be migrated to a new VM. Checks if a host is available in the system and if so returns it. Finds the host with the specified id. This method is called when a VM is migrating from a source host to a target host find a host that can be migrated to. | @davidjumani didn't see any change with respect to hosts count, does these changes fix the count issue? |
@@ -311,11 +311,9 @@ class Parser:
# Reraise a new exception with context on the option being processed at the time of error.
# Note that other exception types can be raised here that are caught by ParseError (e.g.
# BooleanConversionError), hence we reference the orig... | [Parser->[_check_shadowing->[scope_str],_validate->[error],_recursive_option_registration_args->[_recursive_option_registration_args],_invert->[_ensure_bool],_children_transitive->[_children_transitive],_compute_value->[record_option->[record_option],to_value_type->[_ensure_bool,_wrap_type],expand,record_option,to_valu... | Parses the command - line arguments and returns a value container of the missing values. Get the value of a . Missing flags are not allowed in the current namespace. | The long line is a step back in readability I think, especially since the line contains a newline. Not a blocker though. |
@@ -357,6 +357,9 @@ define([
var ps = new PassState(this);
var rs = RenderState.fromCache();
+ // default to the whole drawing buffer
+ ps.viewport = undefined;
+
this._defaultPassState = ps;
this._defaultRenderState = rs;
this._defaultTexture = undefined;
| [No CFG could be retrieved] | The constructor for the vertex array. The object that holds the pick color of the vertex attributes that can be picked. | Should this be the default in `PassState`? |
@@ -954,7 +954,6 @@ function elgg_view_annotation(\ElggAnnotation $annotation, array $vars = array()
* 'no_results' Message to display if no results (string|Closure)
*
* @return string The rendered list of entities
- * @access private
*/
function elgg_view_entity_list($entities, array $vars = array(... | [elgg_does_viewtype_fallback->[doesViewtypeFallback],elgg_view_resource->[renderView,error],elgg_view_entity->[getType,getSubtype],elgg_register_viewtype_fallback->[registerViewtypeFallback],elgg_view_layout->[getUrlSegments,getFirstUrlSegment],elgg_view_entity_annotations->[getType],elgg_view->[renderView],elgg_view_e... | This function is a wrapper for elgg_view that renders a list of entities. | @iionly it's now public |
@@ -273,7 +273,10 @@ class PublishedArticleDAO extends ArticleDAO {
*/
function getPublishedArticleById($publishedArticleId) {
$result = $this->retrieve(
- 'SELECT * FROM published_submissions WHERE published_submission_id = ?', (int) $publishedArticleId
+ 'SELECT ps.*, ss.setting_value FROM published_submi... | [PublishedArticleDAO->[getPublishedArticlesInSections->[_getArticlesInSectionsCache],getPublishedArticleByBestArticleId->[getPublishedArticleByPubId,getByArticleId],getPublishedArticleByPubId->[_getPublishedArticleCache],getByArticleId->[_getPublishedArticleCache]]] | Get a published article by its id. | maybe to put the WHERE clause in the next line? And single quotes... |
@@ -17,7 +17,7 @@ import (
func TestVersion(t *testing.T) {
prepareTestEnv(t)
- setting.AppVer = "1.1.0+dev"
+ setting.AppVer = "1.3.0+dev"
req := NewRequest(t, "GET", "/api/v1/version")
resp := MakeRequest(t, req, http.StatusOK)
| [Equal] | TestVersion tests the version of the application. | You forgot to update this like the main.go in the last commit |
@@ -369,7 +369,7 @@ namespace Internal.TypeSystem
instanceSize,
largestAlignmentRequired,
layoutMetadata.Size,
- alignUpInstanceByteSize: AlignUpInstanceByteSizeForExplicitFieldLayoutCompatQuirk(type),
+ alignUpInstanceByteSize: false,
... | [MetadataFieldLayoutAlgorithm->[ValueTypeShapeCharacteristics->[ValueTypeShapeCharacteristics],LayoutInt->[AlignBaseOffsetIfNecessary],ComputedInstanceFieldLayout->[AlignUpInstanceByteSizeForExplicitFieldLayoutCompatQuirk]]] | Compute the explicit field layout for a given type. Compute a new instance of the type with a reserved offset. | Should this rather be `true`? `true` would maintain the existing behavior for blittable and managed sequential types, but allow it to differ for auto layout and similar types. |
@@ -540,7 +540,15 @@ public final class TransformTranslator {
public void evaluate(View.AsIterable<T> transform, EvaluationContext context) {
Iterable<? extends WindowedValue<?>> iter =
context.getWindowedValues(context.getInput(transform));
- context.putPView(context.getOutput(trans... | [TransformTranslator->[groupByKey->[evaluate->[groupByKey]],combinePerKey->[evaluate->[combinePerKey]],combineGlobally->[evaluate->[combineGlobally]],writeHadoopFile->[getShardTemplate,getNumShards,getFilenamePrefix,getFilenameSuffix],storageLevel,groupByKey,parDo,readBounded,combinePerKey,window,create,viewAsIter,mult... | private static final int BASE_INDEX = 0 ;. | This can be a one-liner. |
@@ -44,6 +44,11 @@ public class Characteristic {
return key;
}
+ @CheckForNull
+ public Integer getParentId() {
+ return parentId;
+ }
+
@Override
public boolean equals(@Nullable Object o) {
if (this == o) {
| [Characteristic->[hashCode->[hashCode],equals->[equals]]] | Checks if the given object is a characteristic with the same key. | is really a characteristic with a specific key not the same as another characteristic with the same key but a different id? |
@@ -106,6 +106,7 @@ int run_test_instance (int argc, ACE_TCHAR *argv[])
<< ret << endl;
passed = false;
done = true;
+ break;
}
received_data(data, mdw, msg);
}
| [ACE_TMAIN->[shutdown,run_test_instance,run_test_next_instance,instance],received_data->[dispose,length]] | Runs a test instance of the DDS. This function is called from the constructor of the MIDI class. take_instance_w_condition - called from the server. | Same fix could be made to line 215, a potential loop is also there, copied just from that place ;-) |
@@ -33,4 +33,13 @@ public interface Pipeline extends FlowConstruct, MessageProcessorContainer, Proc
ProcessingStrategy getProcessingStrategy();
+ /**
+ * Map of current {@link EventContext} instances for {@link Event}'s that have been serialized. Entries will removed on
+ * deserialization or in the last re... | [No CFG could be retrieved] | Returns the processing strategy. | will removed -> will be removed |
@@ -221,18 +221,6 @@ static void hda_dma_get_dbg_vals(struct dma_chan_data *chan,
#define hda_dma_ptr_trace(...)
#endif
-static void hda_dma_l1_entry_notify(void *arg, enum notify_id type, void *data)
-{
- /* Notify about Host DMA usage */
- pm_runtime_get(PM_RUNTIME_HOST_DMA_L1, 0);
-}
-
-static void hda_dma_l1_ex... | [inline->[dma_chan_reg_write,dma_chan_reg_read],dma_chan_data->[tr_info,spin_unlock_irq,tr_err,spin_lock_irq,atomic_add],void->[notifier_unregister,hda_dma_inc_fp,hda_dma_inc_link_fp,spin_unlock_irq,pm_runtime_get,atomic_sub,hda_dma_channel_put_unlocked,notifier_unregister_all,spin_lock_irq,dma_chan_get_data,pm_runtime... | This is the entry and exit notification for the L1 DMA channel. | @keyonjie it took me several minutes to understand the commit message, and I think you are mixing L1 entry/exit. suggested edit: Exiting the DMA L1 state, e.g. on a timer tick when there is no data to copy, prevents the system from staying in S0ix power states. To extend S0ix residency, this L1 exit needs to happen onl... |
@@ -136,7 +136,7 @@ namespace System.Dynamic.Utils
}
}
- public static void ValidateArgumentCount(MethodBase method, ExpressionType nodeKind, int count, ParameterInfo[] pis)
+ public static void ValidateArgumentCount(MethodBase? method, ExpressionType nodeKind, int count, Parameter... | [ExpressionUtils->[RequiresCanRead->[RequiresCanRead]]] | Validate the given arguments. | Why does the method argument need to be nullable? It seems to compile just fine without it. |
@@ -183,9 +183,11 @@ class File(OnChangeMixin, ModelBase):
# Add content_scripts host matches too.
for script in parsed_data.get('content_scripts', []):
permissions.extend(script.get('matches', []))
- if permissions:
- WebextPermission.objects.create(... | [check_file->[unhide_disabled_file,hide_disabled_file],update_status->[update_status],File->[unhide_disabled_file->[move_file],hide_disabled_file->[move_file]],update_status_delete->[update_status],FileUpload->[add_file->[save],from_post->[add_file,FileUpload]]] | Create a File instance from a FileUpload a Version a platform and a parsed_data dictionary Return the file object for the current upload. | I see that we extend `permissions` with other manifest properties here. Is there any optional permission elsewhere in the `manifest` file? cc @Rob--W |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.