patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -38,3 +38,11 @@ def resolve_shipping_methods(obj, info):
return qs.applicable_shipping_methods(
price=obj.get_subtotal().gross.amount, weight=obj.get_total_weight(),
country_code=obj.shipping_address.country.code)
+
+
+def resolve_order_events(info):
+ # Filter only selected events to be di... | [resolve_orders->[filter_by_query_param,all,confirmed,prefetch_related,has_perm],resolve_order->[get_node_from_global_id,has_perm],resolve_shipping_methods->[get_total_weight,get_subtotal,is_shipping_required,applicable_shipping_methods]] | Return queryset of shipping methods that are applicable to the given object. | Do we want types to be hardcoded here? If yes, then maybe we should rename resolver to something more suggestive, for example `resolve_placed_orders`. |
@@ -632,7 +632,8 @@ class Resource:
props = tres.props
opts = tres.opts
- self._name = name
+ if tres.name and isinstance(tres.name, str):
+ self._name = tres.name
# Make a shallow clone of opts to ensure we don't modify the value p... | [ResourceOptions->[merge->[ResourceOptions]],CustomResource->[__init__->[__init__]],ProviderResource->[__init__->[__init__]],Resource->[_convert_providers->[_convert_providers],__init__->[ResourceTransformationArgs,ResourceOptions,inherited_child_alias,collapse_alias_to_urn]],ComponentResource->[__init__->[__init__]]] | Initializes a new object with the given parameters. This method is called by the Resource constructor to ensure that the parent resource is not re - This method is called when we are inside the resource_lock. | Not sure we want a type test that silently ignores here - I think we just take what the user provided and overwrite it - if they disobey the types, they will get an error that makes sense to them. |
@@ -1083,6 +1083,11 @@ module Engine
return false if from.towns.size != to.towns.size
return false if !from.label && from.cities.size != to.cities.size
+ # handle case where we are laying a yellow OO tile and want to exclude single-city tiles
+ if (from.color == :white) && from.label =... | [Base->[end_game!->[format_currency],current_entity->[current_entity],tile_cost->[format_currency],float_corporation->[format_currency],after_par->[format_currency,all_companies_with_ability],place_home_token->[home_token_locations],initialize_actions->[filtered_actions],close_corporation->[current_entity],liquidity->[... | Checks if a given entity upgrades to another entity. | would label.to_s == 'OO' work ? |
@@ -75,9 +75,9 @@ class GCObjectHeapIteratorAddressOrderedList_V1 extends GCObjectHeapIterator
excludedRangeList.add(new U8Pointer[] {heapAlloc, heapTop});
} else {
/* Might be an instrumented VM */
- U8Pointer realHeapAlloc = adjustedToRange(vmThread.allocateThreadLocalHeap().realHeapAlloc(), ... | [GCObjectHeapIteratorAddressOrderedList_V1->[peek->[hasNext],compare->[compare],next->[advanceScanPointer,hasNext],hasNext->[advanceScanPointer]]] | This method is overridden to add additional objects to the list of objects that are not currently tracked A non - zero - allocated heap is a special case. | This will fail with `NoSuchFieldError` when examining core files created before the addition of `realHeapTop`. |
@@ -113,4 +113,15 @@ public class ResequencerIntegrationTests {
assertNotNull(outputChannel.receive(0));
assertEquals(0, store.getMessageGroup("A").getMessages().size());
}
+
+ @Test
+ public void testResequencerRefServiceActivator(){
+ MessageChannel inputChannel = context.getBean("inputChannel", MessageChann... | [ResequencerIntegrationTests->[validateUnboundedResequencerLight->[assertNotNull,send,getPropertyValue,size,build,assertNull,getSequenceNumber,receive,getBean,assertEquals,ClassPathXmlApplicationContext],validateUnboundedResequencerDeep->[assertNotNull,send,getPropertyValue,size,build,assertNull,receive,getBean,assertE... | This test ensures that the unbounded resequencerDeep is not met. | A blank line before the last `}` for the each class |
@@ -3377,6 +3377,7 @@ static int www_body(int s, int stype, int prot, unsigned char *context)
err:
OPENSSL_free(buf);
BIO_free_all(io);
+ BIO_free_all(ssl_bio);
return ret;
}
| [No CFG could be retrieved] | Reads the header of the server rev buffer and returns the number of bytes read. Creates a new SSL connection and binds it to the given io and ssl_bio. | This isn't sufficient. The `io` BIO chain includes this one, so they'll be double freed. The correct fix is to set ssl_bio to NULL after the `BIO_push()` call. |
@@ -202,8 +202,9 @@ func NewMacaron() *macaron.Macaron {
Cookie: setting.CSRFCookieName,
SetCookie: true,
Secure: setting.SessionConfig.Secure,
- CookieHttpOnly: true,
+ CookieHttpOnly: setting.CSRFCookieHTTPOnly,
Header: "X-Csrf-Token",
+ CookieDomain: setting.SessionConfi... | [Status,StatusText,NewWithLogger,ServeData,Redirect,RequireRepoReaderOr,Post,New,Locale,ServerError,Any,Middleware,RequireRepoWriter,ColoredTime,Register,ColoredStatus,RepoAssignment,Csrfer,Cacher,RepoRefByType,Contexter,ColoredMethod,GetLevel,GetCommitsCount,RegisterRoutes,Dir,Now,Close,RequireRepoReader,RepoRef,SetUR... | RegisterRoutes registers the macaron routes and returns a middleware that can be used to handle RegisterRoutes registers the routes for the . | This is an important security measure and shouldn't be set to false. By setting this to false an attacker could gain access to the cookie. |
@@ -418,9 +418,8 @@ void MapgenValleys::calculateNoise()
}
for (s32 index = 0; index < csize.X * csize.Z; index++) {
- noise_heat->result[index] += noise_heat_blend->result[index] + heat_offset;
- noise_humidity->result[index] *= humidity_scale;
- noise_humidity->result[index] += noise_humidity_blend->result[i... | [terrainLevelAtPoint->[adjustedTerrainLevelFromNoise],NoiseParams->[NoiseParams],adjustedTerrainLevelFromNoise->[terrainLevelFromNoise]] | This method calculates the noise of a node. This method is used to generate the terrain noise. | Now I can remember: you shadow `index(3)` here. |
@@ -76,9 +76,8 @@ class TestOnboardingSubscription(OnboardingSubscriptionTestCase):
]
# Get the page.
- queries = 31
+ queries = 36
with self.assertNumQueries(queries):
- # 31 queries:
# - 3 users + groups
# - 2 savepoints (test)
... | [TestOnboardingSubscriptionCancel->[test_returns_404_when_switch_is_disabled->[get],test_get_returns_404_when_session_not_found->[get,Exception],test_get_does_not_set_payment_cancelled_date_when_already_paid->[get,update,now,refresh_from_db,MagicMock],test_get_sets_payment_cancelled_date->[refresh_from_db,MagicMock,get... | Test get. | I don't quite get why we have some many queries.. It seems we're fetching `previews`, `versions`, `files`, etc. many times for nothing. |
@@ -148,11 +148,16 @@ class Dipole(object):
bgcolor=(1, 1, 1), opacity=0.3,
brain_color=(1, 1, 0), fig_name=None,
fig_size=(600, 600), mode='cone',
- scale_factor=0.1e-1, colors=None, verbose=None):
- """Plot dipole loc... | [_fit_Q->[_dipole_forwards,_dipole_gof],fit_dipole->[copy,_sphere_constraint,_fit_dipoles,_make_guesses,Dipole,_surface_constraint,_dipole_forwards,DipoleFixed],_fit_eval->[_dipole_forwards],_read_dipole_text->[copy,Dipole],_fit_dipole->[_fit_Q,_fit_eval],_fit_dipole_fixed->[_fit_Q],Dipole->[plot_locations->[copy],__ge... | Plot the locations of the dipole of the environment variable. | that's a glitch |
@@ -5028,4 +5028,13 @@ ZFS_MODULE_PARAM(zfs_vdev, vdev_, validate_skip, INT, ZMOD_RW,
ZFS_MODULE_PARAM(zfs, zfs_, nocacheflush, INT, ZMOD_RW,
"Disable cache flushes");
+
+ZFS_MODULE_PARAM_CALL(zfs_vdev, zfs_vdev_, min_auto_ashift,
+ param_set_min_auto_ashift, param_get_ulong, ZMOD_RW,
+ "Minimum ashift used when c... | [No CFG could be retrieved] | ZFS module parameter. | Let's add these new module options and a description to `man/man5/zfs-module-parameters.5`. |
@@ -755,14 +755,9 @@ QUERY;
* @access private
*/
function _elgg_river_init() {
- elgg_register_page_handler('activity', '_elgg_river_page_handler');
- $item = new \ElggMenuItem('activity', elgg_echo('activity'), 'activity');
- elgg_register_menu_item('site', $item);
elgg_register_widget_type('river_widget', el... | [elgg_create_river_item->[getType,getSubtype,updateLastAction],_elgg_prefetch_river_entities->[get,getObjectEntity],registerHandler] | Initialize the menu items. | why not move the widget?? this is also UI related |
@@ -49,6 +49,16 @@ namespace Kratos
}
}
+ void Logger::Flush() {
+ auto outputs = GetOutputsInstance();
+ #pragma omp critical
+ {
+ GetDefaultOutputInstance().Flush();
+ for (auto i_output = outputs.begin(); i_output != outputs.end(); ++i_output)
+ (*i_output)->Flush();
+ }
+ }
+
std::s... | [AddOutput->[GetOutputsInstance],GetOutputsInstance->[GetOutputsInstance]] | Logger - AddOutput. | Why you need a critical here? |
@@ -50,7 +50,7 @@ type Account struct {
skbKeyring *SKBKeyringFile
secSigKey GenericKey // cached secret signing key
secEncKey GenericKey // cached secret encryption key
- lksec *LKSec // local key security
+ lksec *LKSec // local key security (this member not currently used)
pap... | [GetUnlockedPaperEncKey->[getKey],LoggedInLoad->[LocalSession],UserInfo->[LoggedIn,GetUID],LoggedInProvisionedLoad->[LocalSession],SaveState->[LocalSession],PassphraseStreamRef->[PassphraseStreamRef,PassphraseStreamCache],Keyring->[LocalSession],CreateStreamCacheViaStretch->[GetUID],saveUserConfig->[LoginSession],Locke... | NewTimedGenericKey returns a new timedGenericKey object. GetUID returns the UID of the current session. | can we delete it from the struct? |
@@ -24,15 +24,13 @@ import json
import logging
import os
import re
-import time
-
from StringIO import StringIO
-
-from apitools.base.py import encoding
-from apitools.base.py import exceptions
+import time
from apache_beam import utils
from apache_beam.internal.auth import get_service_credentials
+from apache_... | [Environment->[__init__->[Environment]],Step->[get_output->[_get_outputs],__init__->[Step]],Job->[__init__->[default_job_name,Job],__str__->[decode_shortstrings->[encode_shortstrings]]],DataflowApplicationClient->[create_job->[json,stage_file],create_job_description->[Environment],modify_job_state->[Job]]] | Dataflow client utility functions. MissingMissingProperties - Create a new . | Could this be `from apache_beam.internal.clients import dataflow` to match the other imports. |
@@ -114,7 +114,7 @@ namespace System.Drawing {
}
string sep = culture.TextInfo.ListSeparator + " ";
TypeConverter intConverter = TypeDescriptor.GetConverter(typeof(int));
- string[] args = new string[2];
+ Span<string> ... | [PointConverter->[ConvertTo->[ConvertTo],ConvertFrom->[ConvertFrom],CanConvertFrom->[CanConvertFrom],CanConvertTo->[CanConvertTo]]] | Override convertTo to handle Point and String types. | Dont know if you want a review for this, but it seems a 2 is missing here? |
@@ -34,11 +34,14 @@ import org.springframework.util.CollectionUtils;
* @author Mark Fisher
* @author Oleg Zhurakousky
* @author Artem Bilan
+ * @author Stefan Reuter
* @since 2.0
*/
public class GroovyCommandMessageProcessor extends AbstractScriptExecutingMessageProcessor<Object> {
private volatile Groov... | [GroovyCommandMessageProcessor->[executeScript->[setCustomizer]]] | Creates a new instance of a GroovyCommandMessageProcessor that can be used to execute a single The object represents a sequence of unique identifiers. | No, it's bad. You don't follow with DRY & KISS. 1. These properties have to be moved to the `AbstractScriptExecutingMessageProcessor` 2. There is no reason to do any change in the `ScriptExecutingMessageProcessor` 3. `GroovyScriptExecutingMessageProcessor` has to implement `InitializingBean` to enrich `GroovyScriptFact... |
@@ -99,7 +99,17 @@ public class SegmentTransactionalInsertAction implements TaskAction<SegmentPubli
@Override
public SegmentPublishResult perform(Task task, TaskActionToolbox toolbox) throws IOException
{
- toolbox.verifyTaskLocks(task, segments);
+ TaskActionPreconditions.checkLockCoversSegments(task, t... | [SegmentTransactionalInsertAction->[perform->[getSegments]]] | Perform the announcing of historical segments. | This may not work as you intend. I believe `lockbox.upgrade(task, interval)` only works if the lock interval is exactly `interval`, but it might not be in this case. For example, HadoopIndexTask acquires locks for a wider interval than its individual segments (it computes an umbrella interval and locks that). |
@@ -0,0 +1 @@
+#include "sick_pad.h"
| [No CFG could be retrieved] | No Summary Found. | Could add a license header here, please? |
@@ -331,12 +331,13 @@ public abstract class AbstractDiskHttpData extends AbstractHttpData {
throw e;
}
if (read == 0) {
- return EMPTY_BUFFER;
+ return allocator.allocate(0);
}
byteBuffer.flip();
- ByteBuf buffer = wrappedBuffer(byteBuffer);
... | [AbstractDiskHttpData->[renameTo->[renameTo,delete],setContent->[tempFile],delete->[delete,deleteOnExit],addContent->[tempFile],tempFile->[deleteOnExit,getPrefix,getBaseDirectory,getDiskFilename,getPostfix],getString->[getString]]] | This method returns a chunk of the file. | We can use `allocator.copyOf(byteBuffer)` |
@@ -110,7 +110,7 @@ def send_fulfillment_confirmation(order_pk, fulfillment_pk):
def send_fulfillment_confirmation_to_customer(order, fulfillment, user):
- send_fulfillment_confirmation.delay(order.pk, fulfillment.pk)
+ send_fulfillment_confirmation(order.pk, fulfillment.pk)
events.email_sent_event(
... | [send_fulfillment_update->[collect_data_for_fullfillment_email],send_staff_order_confirmation->[collect_staff_order_notification_data],send_fulfillment_confirmation->[collect_data_for_fullfillment_email],send_payment_confirmation->[collect_data_for_email],send_order_confirmation->[collect_data_for_email],collect_data_f... | Sends a confirmation message to the customer. | Emails should be a task. This is not solving the root of the issue. |
@@ -1814,7 +1814,7 @@ namespace Js
// Free unused bytes
Assert(cbNeeded + 1 <= cbUtf8Buffer);
*ppSourceInfo = Utf8SourceInfo::New(this, utf8Script, (int)length,
- cbNeeded, pSrcInfo, isLibraryCode, scriptSource);
+ cbNeeded, pSrcInfo, isLibraryCode);
... | [No CFG could be retrieved] | Allocate memory for the UTF8 output buffer. Parse and parse the javascript code. | Can we remove the scriptSource argument from the definition too? It serves no purpose if we always copies |
@@ -176,10 +176,15 @@ class UserEditForm(happyforms.ModelForm):
if not photo:
return
- if photo.content_type not in ('image/png', 'image/jpeg'):
+ image_check = ImageCheck(photo)
+ if (photo.content_type not in ('image/png', 'image/jpeg') or
+ not image_check.... | [AdminUserEditForm->[changes->[changed_fields],save->[changes,changed_fields],clean_anonymize->[changed_fields]],UserEditForm->[save->[save]]] | Check if photo is missing or invalid. | This should probably make use of `constants.IMG_TYPES` too |
@@ -56,6 +56,11 @@ public class AsJsons<InputT> extends PTransform<PCollection<InputT>, PCollection
return newTransform;
}
+ private String writeValue(InputT input) throws IOException {
+ ObjectMapper mapper = Optional.ofNullable(customMapper).orElse(DEFAULT_MAPPER);
+ return mapper.writeValueAsString(... | [AsJsons->[expand->[apply->[writeValueAsString,or,RuntimeException,getName],via,apply],ObjectMapper]] | This method is used to add a custom mapper to the output of the AsJsons transformation. | Note that we switch from Guava Optional to java Optional in the implementation here. Should be absolutely equivalent. |
@@ -143,13 +143,7 @@ public class DecodingProcessor implements EventHandler<MessageEvent> {
message = codec.decode(raw);
}
} catch (RuntimeException e) {
- String remote = "unknown source";
- final ResolvableInetSocketAddress remoteAddress = raw.getRemoteAddr... | [DecodingProcessor->[processMessage->[getRemoteAddress,postProcessMessage,create,size,decode,toString,warn,getLast,name,getCodecConfig,getSourceNodes,getCodecName,mark,isEmpty,setMessages,time,getRaw,error,stop,getJournalOffset,decodeMessages,newArrayListWithCapacity,get,setMessage,getId,add,getClass],postProcessMessag... | Process a message event. postProcessMessages - post process messages if any. | This one is missing the second placeholder. |
@@ -40,7 +40,8 @@ func (g CommandGroups) Has(c *cobra.Command) bool {
func AddAdditionalCommands(g CommandGroups, message string, cmds []*cobra.Command) CommandGroups {
group := CommandGroup{Message: message}
for _, c := range cmds {
- if !g.Has(c) {
+ // Don't show commands that has no short description
+ if !... | [optionsCmdFor->[parents],parents->[isRootCmd],Has] | templates import imports templates for the cobra. CommandGroup interface. ExposeFlags exposes the help and usage templates for the given command. | @fabianofranz @deads2k I'm not as familiar with this part... any downside to this? |
@@ -31,8 +31,16 @@ def datatype(field_decls, superclass_name=None, **kwargs):
for maybe_decl in field_decls:
# ('field_name', type)
if isinstance(maybe_decl, tuple):
- field_name, field_type = maybe_decl
- fields_with_constraints[field_name] = Exactly(field_type)
+ field_name, type_spec = ma... | [Collection->[of->[of,datatype]],TypeConstraint->[validate_satisfied_by->[satisfied_by,TypeConstraintError]],datatype->[DataType->[__getnewargs__->[_super_iter],__new__->[make_type_error],_asdict->[_super_iter],_replace->[_super_iter]]]] | A class that accounts for the type of the object. A method to check if a data type object has a field. Return a string representation of the Nested Nested Object. | Consider adding a `:raises: ...` to the function doc. |
@@ -62,6 +62,10 @@ function NotebookCtrl ($scope, $route, $routeParams, $location, $rootScope,
$scope.currentRevision = 'Head'
$scope.revisionView = isRevisionPath($location.path())
+ $scope.$watch('note', function (value) {
+ $rootScope.pageTitle = value ? value.name : ''
+ }, true)
+
$scope.$on('setCo... | [No CFG could be retrieved] | The main scope for the navigating to a specific node. Show a Bootstrap dialog to set the permission. | Should be `Zeppelin` or something? when `value` is invalid. |
@@ -495,6 +495,7 @@ export class AmpStoryBookend extends AMP.BaseElement {
/**
* @param {!./bookend-component.BookendDataDef} bookendConfig
+ * @return {!Promise<?../localization.LocalizationService>|undefined}
* @private
*/
renderBookend_(bookendConfig) {
| [AmpStoryBookend->[renderComponents_->[dev,buildElements,buildContainer,appendChild],constructor->[storyRequestService,create,storyStoreService],initializeListeners_->[BOOKEND_STATE,ESCAPE,CAN_SHOW_SHARING_UIS,preventDefault,DESKTOP_STATE,keyCode,throttle],readBookendVersion_->[user],buildReplayButton_->[buildReplayBut... | Renders the bookend. | Should this method return the rendered bookend instead? Not sure it's super useful to get the `LocalizationService` as a response of the `renderBookend_` method. |
@@ -540,11 +540,9 @@ func (s *SliceParam) UnmarshalPipelineParam(val interface{}) error {
}
*s = SliceParam(theSlice)
return nil
-
- default:
- return ErrBadInput
}
- return nil
+
+ return errors.Wrap(ErrBadInput, fmt.Sprintf("expected slice, got %T", val))
}
func (s SliceParam) FilterErrors() (SlicePar... | [Decimal->[Decimal],String->[String],UnmarshalPipelineParam->[UnmarshalPipelineParam]] | UnmarshalPipelineParam unmarshals a pipeline parameter into a slice of SliceParam. | Let's use `errors.Wrapf` here |
@@ -83,11 +83,13 @@ class Openmpi(AutotoolsPackage):
# Still supported
version('4.0.1', sha256='cce7b6d20522849301727f81282201d609553103ac0b09162cf28d102efb9709') # libmpi.so.40.20.1
version('4.0.0', sha256='2f0b8a36cfeb7354b45dda3c5425ef8393c9b04115570b615213faaa3f97366b') # libmpi.so.40.20.0
+ ver... | [Openmpi->[with_or_without_tm->[_tm_dir],with_or_without_verbs->[_verbs_dir],with_or_without_mxm->[_mxm_dir]]] | Get version of a sequence. This function returns a sequence of all sequence versions of a library that are not part of a cd3331d3792648919f9c4cee8e77. | Should we make this the new preferred version? |
@@ -1049,8 +1049,11 @@ public class NfsSecondaryStorageResource extends ServerResourceBase implements S
DataTO destData = cmd.getDestTO();
DataStoreTO srcDataStore = srcData.getDataStore();
DataStoreTO destDataStore = destData.getDataStore();
-
- if (DataStoreRole.Image == srcDataStore... | [NfsSecondaryStorageResource->[swiftDelete->[execute],findFile->[getFile],getTemplateOrVolumePostUploadCmd->[getPostUploadPSK],copySnapshotToTemplateFromNfsToNfs->[copySnapshotToTemplateFromNfsToNfsXenserver],configure->[retrieveNfsVersionFromParams,configure],execute->[swiftDelete,copyFromS3ToNfs,copyFromNfsToImage,ge... | Execute the CopyCommand. | please put this condition in a boolean method with a good descriptive name. |
@@ -200,7 +200,10 @@ public class OidcClientRecorder {
LOG.tracef("Discovery has failed, status code: %d", resp.statusCode());
return null;
}
- });
+ }).onFailure(ConnectException.class)
+ .retry()
+ .withBackOff(INITIAL_BACKOFF_... | [OidcClientRecorder->[createOidcClientUni->[apply->[get],get],setGrantClientParams->[get]]] | Discover the token endpoint. | @Yelzhasdev what happens if it is an HTTP-level response error, for example, 401 ? This block must only run if it is a connection error |
@@ -350,10 +350,8 @@ class Seq2seqAgent(Agent):
loss += self.criterion(scores.view(-1, scores.size(-1)), ys.view(-1))
loss.backward()
self.update_params()
- losskey = 'loss' if not lm else 'lmloss'
- loss_dict = {losskey: loss.mul(len(xs)).data}
- ... | [Seq2seqAgent->[add_cmdline_args->[dictionary_class],load->[load],shutdown->[save],save->[save],act->[batch_act],predict->[update_params,zero_grad],batch_act->[predict,batchify,v2t],batchify->[valid,parse],zero_grad->[zero_grad]]] | Produce a prediction from our model. | can we call this vectorize? |
@@ -269,8 +269,13 @@ class ApacheConfigurator(augeas_configurator.AugeasConfigurator):
def get_parser(self):
"""Initializes the ApacheParser"""
+ # If user provided vhost_root value in command line, use it
+ if self.conf("vhost-root"):
+ vhostroot = self.conf("vhost-root")
+ ... | [ApacheConfigurator->[perform->[restart,perform],make_addrs_sni_ready->[is_name_vhost,add_name_vhost],prepare->[constant],add_vhost_id->[_find_vhost_id],install_ssl_options_conf->[constant],_add_name_vhost_if_necessary->[is_name_vhost,add_name_vhost],cleanup->[restart],make_vhost_ssl->[_create_vhost],_find_best_vhost->... | Initializes the ApacheParser class. | nit: Won't just passing `self.conf("vhost-root")` here get the same behavior as the `if` statements above? |
@@ -131,8 +131,7 @@ REQUIRED_PACKAGES = [
# is Python standard since Python 3.7 and each Python version is compatible
# with a specific dataclasses version.
'dataclasses;python_version<"3.7"',
- # orjson, only available on Python 3.6 and above
- 'orjson<4.0;python_version>="3.6"',
+ 'orjson<4.0'... | [mypy->[run->[get_project_path]],get_version,generate_protos_first] | A function to check if a given version of cygwin is available. Package names for all versions of the library. | I believe we still support Python 3.5, so we may not be able to make this change? |
@@ -157,6 +157,7 @@ class CMake(object):
source_dir, build_dir,
cache_build_folder)
mkdir(self.build_dir)
+
arg_list = join_arguments([
self.command_line,
args_to_string(... | [CMake->[test->[_build],is_multi_configuration->[is_multi_configuration],install->[_build],configure->[_get_dirs],_build->[_run],_get_dirs->[get_dir]]] | Configures a single node in the source build folder. | I will remove those useless changes on next round |
@@ -1393,6 +1393,8 @@ describes.realWin('amp-analytics', {
});
sandbox.stub(viewer, 'isVisible').returns(false);
+ analytics.linkerManager_ = {dispose: () => {}};
+
analytics.layoutCallback();
analytics.resumeCallback();
analytics.unlayoutCallback();
| [No CFG could be retrieved] | Checks that the AMP Analytics tag is not visible. click on a tag with id and hide. | this is not needed. this test should actually capture the bug |
@@ -120,8 +120,7 @@ class ConsumerUpdateCommand(PulpCliCommand):
delta = dict((k, v) for k, v in kwargs.items() if v is not None)
if OPTION_NOTES.keyword in delta:
- notes_args = delta.pop(OPTION_NOTES.keyword)
- delta['notes'] = args_to_notes_dict(notes_args)
+ delt... | [ConsumerUpdateCommand->[run->[get_consumer_id],__init__->[add_consumer_option]]] | Update a specific node in the server. | need to remove the now-unused import statement for `args_to_notes_dict` |
@@ -68,11 +68,15 @@ class Order(models.Model, ItemSet):
if not type(self).objects.filter(token=token).exists():
self.token = token
break
- return super(Order, self).save(*args, **kwargs)
+ super(Order, self).save(*args, **kwargs)
+ if not s... | [DeliveryGroup->[change_status->[save]],Payment->[get_purchased_items->[get_items],send_confirmation_email->[get_user_email]],Order->[send_confirmation_email->[get_user_email],change_status->[save]]] | A method to save an order. | Don't touch other objects in `model.save`. If you need to create them, either add a separate method or -- even better -- do this in an appropriate form or view. Also make sure you do not change the signature of the method you are modifying. This used to return a value. |
@@ -241,8 +241,9 @@ func (b *Builder) EnableForceTargetLeader() *Builder {
return b
}
-func (b *Builder) setUseJointConsensus(useJointConsensus bool) *Builder {
- b.useJointConsensus = useJointConsensus
+func (b *Builder) setSupportJointConsensus(supportJointConsensus bool) *Builder {
+ b.allowDemote = supportJoin... | [planRemovePeer->[allowLeader],planReplaceLeaders->[allowLeader],planAddPeer->[allowLeader],comparePlan->[Empty],Copy->[Set],execChangePeerV2->[execTransferLeader],planDemotePeer->[allowLeader],peerPlan->[Empty],planPreferReplaceByNearest->[labelMatch]] | EnableForceTargetLeader enables or disables the target - leader constraint for the current state of the. | prefer to use two functions. e.g. enable/disable |
@@ -193,8 +193,8 @@ func (client *Client) Clone() *Client {
// events not published or confirmed to be processed by elasticsearch will be
// returned. The input slice backing memory will be reused by return the value.
func (client *Client) PublishEvents(
- events []common.MapStr,
-) ([]common.MapStr, error) {
+ even... | [execRequest->[NewRequest,execHTTPRequest,AddHeader,Warn],CheckTemplate->[request],request->[Marshal,Reader,execRequest,Warn],Ping->[Info,execRequest,Unmarshal,Errorf],execHTTPRequest->[SetBasicAuth,Do,Errorf,ReadAll,Add],Connect->[Ping,onConnectCallback,Errorf],LoadTemplate->[request,Info,Errorf],PublishEvent->[Warn,I... | PublishEvents publishes the given events to Elasticsearch. | Not sure what the right name here is: `datas`? |
@@ -11,10 +11,11 @@ import {
StyleSheet,
Platform,
Slider,
+ AsyncStorage,
Text,
} from 'react-native';
import { Icon } from 'react-native-elements';
-import { BlueNavigationStyle, BlueButton, BlueBitcoinAmount, BlueAddressInput } from '../../BlueComponents';
+import { BlueNavigationStyle, BlueButton, Bl... | [No CFG could be retrieved] | The base class for sending a header to a specific address. Find the first wallets that are from the given address and secret. | I hope that is not facing user yet..? I dont want to implement 'send-all' for now |
@@ -142,7 +142,8 @@ def create_global_var(shape,
def cast(x, dtype):
"""
This layer takes in the Variable :attr:`x` with :attr:`x.dtype` and casts
- it to the output with :attr:`dtype`.
+ it to the output with :attr:`dtype`. It's not meaningful if the output
+ dtype equals the input dtype, but it's ... | [ones->[fill_constant],create_parameter->[create_parameter],zeros->[fill_constant]] | This layer takes in the Variable x with dtype and casts it to the output with. | :attr:`dtype` note meaningful=>meaningless |
@@ -66,6 +66,12 @@ if (! empty($sql_query)) {
$GLOBALS['reload'] = true;
}
+ //do a dynamic reload if table is RENAMED (by sending the instruction to the AJAX response handler)
+ if (preg_match('/^RENAME\s+TABLE\s+(.*?)\s+TO\s+(.*?)($|;|\s)/i', $sql_query, $rename_table_names)) {
+ $ajax_re... | [addParam,getDisplay,doImport,isSuccess,addJSON,addString,display] | noplugin - no plugin This function is called by the user when the user is called directly or by the user when. | Please wrap lines longer than 85 characters |
@@ -10,9 +10,12 @@
<div style="float: left;">
<h2><%= title %></h2>
<p>
- <%= f.text_area :content, id: 'new_annotation_content', name: 'content', value: content, required: true %>
+ <%= f.text_area :content, id: 'new_annotation_content', name: 'content', value: content, required: true,... | [No CFG could be retrieved] | Displays a form with hidden fields content and annotation categories. A list of all annotation elements in the hierarchy. | Please insert a space before the `%>`. |
@@ -27,9 +27,11 @@ def _write_conanvcvars(conanfile, group):
return
compiler = conanfile.settings.get_safe("compiler")
- cvars = None
+ vcvars = None
if compiler == "intel":
- cvars = intel_compilervars_command(conanfile)
+ vcvars = intel_compilervars_command(conanfile)
+ eli... | [msvc_runtime_flag->[get_safe,format],_write_conanvcvars->[get_safe,split,vs_ide_version,dedent,get,len,str,format,vcvars_command,vcvars_arch,join,register_env_script,save,intel_compilervars_command],vs_ide_version->[get_safe],vcvars_command->[append,vcvars_path,join],vcvars_arch->[str,ConanException,get],vcvars_path->... | write a conanvcvars. bat file with the good args from settings. | I am not convinced this belongs here. The ``CMakeToolchain`` is already generating the intel vars script. Isn't a bit weird that you call ``VCVars().generate()`` and it will create a intel file instead of a vcvars one? |
@@ -45,7 +45,10 @@ class ShelfSerializer(serializers.ModelSerializer):
request = self.context.get('request', None)
request.GET = request.GET.copy()
request.GET.update(params)
- return AddonSearchView(request=request).data
+ addons = AddonSearchView(request=re... | [ShelfSerializer->[get_addons->[AddonSearchView,dict,parse_qsl,get,update,copy,strip],get_url->[get,drf_reverse],SerializerMethodField],ESSponsoredAddonSerializer->[get_click_url->[get,drf_reverse],SerializerMethodField]] | Get addons from the object. | `request.GET = QueryDict()` would do to get an empty GET querydict instead of looping through the keys. But it'd miss the case where we want to pass on some parameters from the `/shelves/` endpoint (e.g. `/shelves/?lang=fr` to enable French localisation) down to each of the requests. So we've got to keep a copy of the ... |
@@ -1243,7 +1243,7 @@ namespace Microsoft.Xna.Framework.Graphics
{
FeatureLevel featureLevel;
- if (graphicsDevice == null || graphicsDevice._d3dDevice == null)
+ if (graphicsDevice == null || graphicsDevice._d3dDevice == null || graphicsDevice._d3dDevice.NativePointer == I... | [GraphicsDevice->[Flush->[Flush],PlatformDrawIndexedPrimitives->[PlatformApplyState,PrimitiveTopology],SetRenderTarget->[SetRenderTarget],GetInputLayout->[GetInputLayout],PlatformDrawUserPrimitives->[PlatformApplyState,SetUserVertexBuffer,PrimitiveTopology],PlatformApplyState->[PlatformApplyState],PlatformDispose->[Cle... | PlatformGetHighestSupportedGraphicsProfile This method returns the highest supported graphics profile for the given. | Do we have any clue as to why this happens? Also what is the difference in `Device.FeatureLevel` and `Device.GetSupportedFeatureLevel()`. Why not call the static function all the time instead and avoid this issue entirely? |
@@ -221,6 +221,9 @@ class PublishedArticleDAO extends ArticleDAO {
$publishedArticles[$currSectionId]['title'] = $publishedArticle->getSectionTitle();
}
}
+ // get metadata of the current version
+ $publishedArticle = $this->getPublishedArticleByArticleId($publishedArticle->getId(), null, false, $pub... | [PublishedArticleDAO->[getPublishedArticlesInSections->[_getArticlesInSectionsCache],getPublishedArticleByBestArticleId->[getPublishedArticleByPubId,getByArticleId],getPublishedArticleByPubId->[_getPublishedArticleCache],getByArticleId->[_getPublishedArticleCache]]] | Get all published articles in a section of an issue Required section. | Hmmm... It looks like everywhere else in this class the submission revision 1 is used to get the published articles, using _fromRow without the parameters. For example in getPublishedArticlesByJournalId. Why then here only the current article version? It seems that the concept is to get the first and then later to get ... |
@@ -440,15 +440,7 @@ public class ConsumeMQTT extends AbstractMQTTProcessor implements MqttCallback {
session.getProvenanceReporter().receive(messageFlowfile, getTransitUri(mqttMessage.getTopic()));
session.transfer(messageFlowfile, REL_MESSAGE);
- session.commit();
- i... | [ConsumeMQTT->[transferQueueRecord->[transferFailure],customValidate->[customValidate],onScheduled->[onScheduled]]] | transfer queue. This method will receive all messages in the queue and transfer them to the destination. | No more warn message? |
@@ -357,7 +357,7 @@ namespace Microsoft.Extensions.DependencyModel
while (reader.Read() && reader.IsTokenTypeProperty())
{
- targets.Add(ReadTarget(ref reader, reader.GetString()));
+ targets.Add(ReadTarget(ref reader, reader.GetString()!));
}
... | [DependencyContextJsonReader->[Dispose->[Dispose]]] | Reads the list of targets from the given Utf8 reader. | I think this `!` is lying that this can't be `null`. We should make the `ReadTarget` method accept `string? targetName`. |
@@ -53,7 +53,7 @@ class modTakePos extends DolibarrModules
// It is used to group modules by family in module setup page
$this->family = "portal";
// Module position in the family on 2 digits ('01', '10', '20', ...)
- $this->module_position = '90';
+ $this->module_position = 90;
// Gives the possibility t... | [modTakePos->[init->[remove,_load_tables,_init],remove->[_remove]]] | Constructor for a new module object This table is used to save module status This is the main entry point for all modules. This is the main entry point for the module. It is used to add new pages in Dictionaries that contain a list of tables in the dictonnary that are used to This method is used to initialize the objec... | Are you sure. The title say "module_position" is on 2 digits, '01', '02', ... Same letter, example are using strings |
@@ -170,8 +170,10 @@ var ngSwitchWhenDirective = ngDirective({
require: '^ngSwitch',
compile: function(element, attrs) {
return function(scope, element, attr, ctrl, $transclude) {
- ctrl.cases['!' + attrs.ngSwitchWhen] = (ctrl.cases['!' + attrs.ngSwitchWhen] || []);
- ctrl.cases['!' + attrs.ngSwitc... | [No CFG could be retrieved] | END of directive ngSwitchWhen. | if we just eval the expression, then we are not going to update the switch should the result of the ngSwitchWhen expression change while the result of expression ngSwitch remains the same. Is this the right behavior? I'm not sure myself... |
@@ -1533,7 +1533,7 @@ int tls_psk_do_binder(SSL *s, const EVP_MD *md, const unsigned char *msgstart,
void *hdata;
hdatalen = BIO_get_mem_data(s->s3->handshake_buffer, &hdata);
- if (hdatalen <= 0) {
+ if (hdatalen == 0) {
SSLfatal(s, SSL_AD_INTERNAL_ERROR, SSL_F_TLS_PSK_DO... | [No CFG could be retrieved] | Generates the binder key and the hash of the ClientHello. 15. 2. 5. 2. | Why this change? BIO_ctrl can return negative values ... |
@@ -136,10 +136,10 @@ const App = () => {
* @private
*/
const processPushNotifications = async () => {
- notifications.setApplicationIconBadgeNumber(0);
+ Notifications.setApplicationIconBadgeNumber(0);
await new Promise(resolve => setTimeout(resolve, 200));
// sleep needed as sometimes unsus... | [No CFG could be retrieved] | Processes push notifications stored in AsyncStorage. if we have a network network we need to wait for the push notification tap to be processed. | `notification` is renamed and became capitalized, which produces unnecessary diff. this is bad because it bloats diff, and in `git blame` it overtakes line ownership and commit message. this is a bad practice. |
@@ -672,14 +672,3 @@ func (cpl ChangePeerV2Leave) CheckInProgress(cluster opt.Cluster, region *core.R
// Influence calculates the store difference that current step makes.
func (cpl ChangePeerV2Leave) Influence(opInfluence OpInfluence, region *core.RegionInfo) {}
-
-func validateStore(cluster opt.Cluster, id uint64... | [ConfVerChanged->[ConfVerChanged],IsFinish->[IsFinish,String],String->[String]] | Influence is part of the core. ChangePeer interface. | Can't use `ClusterInfo` to replace `opt.Cluster`? |
@@ -17,8 +17,10 @@ class Helics(CMakePackage):
maintainers = ['nightlark']
+ version('bms', branch='install-benchmarks', submodules=True)
version('develop', branch='develop', submodules=True)
version('master', branch='master', submodules=True)
+ version('2.6.0', sha256='450cbfc0c37b77ea051d3edc... | [Helics->[setup_run_environment->[prepend_path],cmake_args->[append,format],depends_on,extends,conflicts,version,variant]] | Creates an instance of the nightly - scalable object. Create a sequence of parameters that can be used to create a CMake instance. | Note that Spack will treat this version as being older than all other versions. |
@@ -2,6 +2,7 @@ class Podcast < ApplicationRecord
resourcify
has_many :podcast_episodes
+ has_many :users, through: :podcast_ownerships
belongs_to :creator, class_name: "User", inverse_of: :created_podcasts, optional: true
mount_uploader :image, ProfileImageUploader
| [Podcast->[admins->[with_role],unique_slug_including_users_and_orgs->[add,exists?],existing_episode->[first,present?,presence,unique_website_url?],image_90->[get],bust_cache->[perform_async],all,belongs_to,alias_attribute,published,after_save,validate,scope,validates,where,has_many,select,includes,mount_uploader]] | The Podcast model for a given application. Define the functions related to the unique object. | is the goal to have multiple owners on a podcast? It might be beneficial to call this `.owners` instead of `.users`, similar to how we call `.creator` instead of `.user` the creator of the podcast |
@@ -163,7 +163,8 @@ module OneProvision
# @param config [String] Path to the configuration file
# @param cleanup [Boolean] True to delete running VMs and images
# @param timeout [Integer] Timeout for deleting running VMs
- def create(config, cleanup, timeout)
+ # @param skip ... | [Provision->[create_resources->[create],delete_vms->[running_vms?],configure->[configure],create->[delete],delete_images->[images?],create_cluster->[create],delete->[delete],delete_object->[delete],create_hosts->[create]]] | Creates a new cluster object. | Please update this method so there is just single create action for each entity and method **ends at its end**, not in the middle by 2 extra checks/creates and returns. |
@@ -121,9 +121,9 @@ public class TestQuerySplunkIndexingStatus {
}
@Test
- public void testTimedOutEvents() throws Exception {
+ public void testAckCheckedIsTrueAndFlowFileWithTimedOutEvents() throws Exception {
// when
- testRunner.enqueue(givenFlowFile(1, System.currentTimeMillis() -... | [TestQuerySplunkIndexingStatus->[givenSplunkReturnsWithFailure->[thenReturn],testTimedOutEvents->[send,any,anyString,run,toMillis,currentTimeMillis,givenFlowFile,assertAllFlowFilesTransferred,enqueue],givenSplunkReturns->[append,ByteArrayInputStream,getBytes,thenReturn],testMoreIncomingFlowFileThanQueryLimit->[getConte... | This test is executed when the server times out and when the server times out. | Minor: you can make it more readable and shorter with Collections.singletonMap Also: this should be part of the given block |
@@ -148,6 +148,7 @@ class QAT_Quantizer(Quantizer):
types of nn.module you want to apply quantization, eg. 'Conv2d'
"""
super().__init__(model, config_list, optimizer)
+ self.quant_grad = QATGrad
modules_to_compress = self.get_modules_to_compress()
self.bo... | [DoReFaQuantizer->[quantize_weight->[get_bits_length]],QAT_Quantizer->[quantize_weight->[get_bits_length,_quantize,_dequantize,update_quantization_param],quantize_output->[get_bits_length,_dequantize,update_ema,_quantize,update_quantization_param]]] | Initialize the quantization layer. | where we use `self.quant_grad`? |
@@ -0,0 +1,18 @@
+<% lockout_time_in_words = decorated_user.lockout_time_remaining_in_words %>
+<% title t('titles.account_locked') %>
+
+<h1 class="h3 my0">
+ <%= t('titles.account_locked') %>
+</h1>
+<p>
+ <%= t('devise.two_factor_authentication.max_login_attempts_reached') %>
+</p>
+<p>
+ <%= t('devise.two_factor... | [No CFG could be retrieved] | No Summary Found. | The upside of this (vs having the HTML in the i18n string itself): - feels more railsy - easier to read Downside: - when just looking at the translation itself (`please_try_again_html`), it is not obvious that there is HTML used in the translation. Need to look at where it is called. Because of this downside, I think w... |
@@ -199,7 +199,8 @@ export function conferenceFailed(conference: Object, error: string) {
// Make the error resemble an Error instance (to the extent that
// jitsi-meet needs it).
error: {
- name: error
+ name: error,
+ recoverable: undefined
}
}... | [No CFG could be retrieved] | Dispatches events related to the and notifies the appropriate listeners. Registers listeners for the UserJoined and UserLeft events. | why do we need this? if an unknown property is checked it will return undefined anyway. |
@@ -141,6 +141,7 @@ class TestConvertImageDtype:
assert actual_max == desired_max
+# TODO: CI is skipping these tests, fix it
@pytest.mark.skipif(accimage is None, reason="accimage not available")
class TestAccImage:
| [test_normalize->[samples_from_standard_normal],TestAffine->[test_transformation_range->[_test_transformation],_test_transformation->[_to_3x3_inv],test_transformation_discrete->[_test_transformation]],_get_2d_tensor_various_types,_get_1_channel_tensor_various_types] | Test if accimage to tensor is correct. | Adding a TODO note here. |
@@ -118,6 +118,9 @@ func doEnterpriseMode(config interface{}) (retErr error) {
log.Printf("no Jaeger collector found (JAEGER_COLLECTOR_SERVICE_HOST not set)")
}
env := serviceenv.InitWithKube(serviceenv.NewConfiguration(config))
+ if err := profileutil.StartCloudProfiler("pachyderm-pachd-enterprise", env.Config(... | [Handle,NewConfiguration,StringVar,UnaryServerInterceptor,RegisterDebugServer,NewAPIServer,SetGCPercent,InitDexDB,BlockUntil,Warnf,GetDBClient,NewEnterpriseServer,RegisterHealthServer,Health,Is,Set,RegisterAPIServer,NewReporter,Router,ListenAndServeTLS,Handler,NewIdentityServer,GetCertPaths,NewSidecarAPIServer,InitWith... | doEnterpriseMode returns an object that can be used to check if the user is in enterprise achd GRPC Server. | Should startup fail if we cannot setup the profiler? |
@@ -692,7 +692,9 @@ namespace DotNetNuke.Entities.Users
public static void UserAgreedToTerms(UserInfo user)
{
Requires.NotNull("user", user);
- MembershipProvider.Instance().UserAgreedToTerms(user);
+ var u = user;
+ u.PortalID = PortalController.GetEffect... | [UserController->[IsMemberOfPortalGroup->[IsMemberOfPortalGroup],ApproveUser->[AutoAssignUsersToRoles],UpdateDisplayNames->[GetEffectivePortalId],UnLockUser->[UnLockUser,GetEffectivePortalId],GetPassword->[GetPassword],UserInfo->[CheckInsecurePassword,FixMemberPortalId,GetEffectivePortalId,GetUserLookupDictionary,AddEv... | Adds the given user to the list of terms that the user has agreed to. | `var u = user;` doesn't have any effect here. Since `UserInfo` is a class, you're still pointing to the shared instance, and this `PortalID` assignment will affect the `UserInfo` object that's passed in. I think we'd want to avoid that, so it's probably better to either pass `portalId` as a parameter to `UserAgreedToTe... |
@@ -455,6 +455,16 @@ describes.fakeWin('Viewport', {}, env => {
expect(viewport.getRect().height).to.equal(222);
});
+ it('should pass through size and scroll when not embedded', () => {
+ expect(viewport.getSize().width).to.equal(111);
+ expect(viewport.getSize().height).to.equal(222);
+ expect(vie... | [No CFG could be retrieved] | Creates a new Viewport instance. This is a test method that resizes horizontally and does not relayout on height. | Can you add an assertion that `updatePaddingTop` is not called? Or that it remains 0? |
@@ -397,4 +397,8 @@ class Paraview(CMakePackage, CudaPackage):
)
)
+ if '+debug' in spec:
+ cmake_args.append('-DCMAKE_BUILD_TYPE=Debug')
+ cmake_args.append('-DVTK_DEBUG_LEAKS:BOOL=ON')
+
return cmake_args
| [Paraview->[cmake_args->[nvariant_bool->[variant_bool],nvariant_bool,variant_bool]]] | Populate cmake arguments for ParaView. Adds flags related to CMake and CMake2. Add flags to cmake_args if necessary. Check if a is available in the current C ++ environment. Add cmake_args if not installed. | You should not set CMAKE_BUILD_TYPE as that is already set with the build_type variant. So here just set any other debug flags such as VTK_DEBUG_LEAKS |
@@ -488,8 +488,9 @@ public class SparkInterpreter extends Interpreter {
}
//Only one of py4j-0.9-src.zip and py4j-0.8.2.1-src.zip should exist
+ //TODO(zjffdu), this is not maintainable when new version is added.
String[] pythonLibs = new String[]{"pyspark.zip", "py4j-0.9-src.zip", "py4j-0.8.2.1-src... | [SparkInterpreter->[createSparkSession->[useHiveContext,isYarnMode,hiveClassesArePresent],interpretInput->[interpret],getProgress->[getJobGroup],getSQLContext_1->[useHiveContext,getSparkContext],populateSparkWebUrl->[toString,getSparkUIUrl],setupConfForPySpark->[isYarnMode],getCompletionTargetString->[toString],getProg... | Setup spark configuration for PySpark. Distributes needed libraries to workers if spark version is greater than 1. 5. 0. | agreed. I think we should follow up with a PR to change this to search under SPARK_HOME for py4j-* instead of hard coding the filename |
@@ -53,6 +53,7 @@ func newLogFileReader(
config: config,
lastTimeRead: time.Now(),
backoff: config.backoffDuration,
+ done: done,
}, nil
}
| [wait->[Sleep,Duration],Read->[Seek,Err,Size,Stat,Name,Now,wait,IsSameFile,Read,Info,Since,Continuable,Debug],Seek,New,Now] | Read reads from the underlying file. If the file is truncated or too old close it. If the file is closed it will. | I wonder if channel is required. If file get's closed by another thread (in stop method), we should get some error, right? |
@@ -25,5 +25,11 @@ namespace System.Windows.Forms
/// default button.
/// </summary>
Button3 = (int)MB.DEFBUTTON3,
+
+ /// <summary>
+ /// Specifies that the forth button on the message box should be the
+ /// default button.
+ /// </summary>
+ Button4 = ... | [DEFBUTTON1,DEFBUTTON3,DEFBUTTON2] | default button for the button. | Since the 4th button is known to be labeled help should this be changed to ``Specifies that the Help button on the message box should be the default button.``? |
@@ -264,6 +264,10 @@ static inline int sai_set_config(struct dai *dai,
val_cr2 |= REG_SAI_CR2_SYNC;
mask_cr2 |= REG_SAI_CR2_SYNC_MASK;
+
+ /* TODO: for the time being use half FIFO size as watermark */
+ dai_update_bits(dai, REG_SAI_XCR1(REG_RX_DIR),
+ REG_SAI_CR1_RFW_MASK, SAI_FIFO_WORD_SIZE / 2);
dai_update... | [inline->[REG_SAI_CR5_FBT,REG_SAI_XCR4,dai_get_drvdata,REG_SAI_XMR,dai_info,dai_update_bits,BIT,REG_SAI_CR5_WNW,REG_SAI_CR4_FRSZ,REG_SAI_XCR2,REG_SAI_XCR5,REG_SAI_CR4_SYWD,REG_SAI_CR5_W0W],void->[REG_SAI_XCR3,dai_base,dai_info,REG_SAI_XCR1,dai_update_bits,REG_SAI_XCSR,dai_read,REG_SAI_CR3_TRCE,dai_write,poll_for_regist... | Set the configuration of the SAI Frame high and 1clk before data one bit for frame sync and one bit for frame Private functions - related to SOF_DAI_FMT_CLOCK_PROVIDER Reads and writes configuration values to SAI registers. | @dbaluta I've added a new commit just for the SAI watermark. |
@@ -36,6 +36,12 @@ static void sai_start(struct dai *dai, int direction)
REG_SAI_CR1_RFW_MASK, SAI_FIFO_WORD_SIZE / 2);
dai_update_bits(dai, REG_SAI_XCR3(direction),
REG_SAI_CR3_TRCE_MASK, REG_SAI_CR3_TRCE(1));
+
+ /* add one word to FIFO after TRCE has been enabled */
+ if (direction == DAI_DIR_PLAYBACK)
+ ... | [inline->[REG_SAI_CR5_FBT,REG_SAI_XCR4,REG_SAI_XMR,dai_update_bits,BIT,REG_SAI_CR5_WNW,REG_SAI_CR4_FRSZ,REG_SAI_XCR2,trace_sai,REG_SAI_XCR5,REG_SAI_CR4_SYWD,REG_SAI_CR5_W0W],void->[REG_SAI_XCR3,REG_SAI_XCR1,dai_update_bits,REG_SAI_XCSR,dai_read,REG_SAI_CR3_TRCE,trace_sai,tracev_sai],int->[dai_update_bits,sai_stop,trace... | This function updates the SAI registers in the specified direction. This function disable both Tx and Rx Software Reset and reset their FIFOs. | io_update_bits does a read and a write. Is it safe to read from this register and to write whatever was read back to it? |
@@ -95,6 +95,10 @@ public class CommandStore implements CommandQueue, Closeable {
ConsumerConfig.ISOLATION_LEVEL_CONFIG,
IsolationLevel.READ_COMMITTED.toString().toLowerCase(Locale.ROOT)
);
+ kafkaConsumerProperties.put(
+ ConsumerConfig.AUTO_OFFSET_RESET_CONFIG,
+ "n... | [CommandStore->[getRestoreCommands->[getRestoreCommands],waitForCommandConsumer->[ensureConsumedPast],start->[start],wakeup->[wakeup],Factory->[create->[CommandStore]],getCommandTopicName->[getCommandTopicName],close->[close],getNewCommands->[getNewCommands]]] | create a new command store with the specified parameters. | is there a constant somewhere for this? |
@@ -81,10 +81,11 @@ namespace System.Text.Json.Serialization.Converters
}
}
+ Debug.Assert(moveNextTask.IsCompleted);
JsonConverter<TElement> converter = GetElementConverter(ref state);
// iterate through the enumerator while elements are being retu... | [IAsyncEnumerableOfTConverter->[Add->[Add],OnTryWrite->[OnTryWrite],OnTryRead->[OnTryRead]]] | Override OnWriteResume to handle the case where the value is being serialized synchronously. if enumerator is empty return false ;. | In a resume case, can `IsCompleted` be `false`? |
@@ -244,7 +244,7 @@ public class Http2MultiplexCodec extends Http2FrameCodec {
final void onHttp2Frame(ChannelHandlerContext ctx, Http2Frame frame) {
if (frame instanceof Http2StreamFrame) {
Http2StreamFrame streamFrame = (Http2StreamFrame) frame;
- onHttp2StreamFrame(((Http2Multip... | [Http2MultiplexCodec->[onHttp2UpgradeStreamInitialized->[registerDone],DefaultHttp2StreamChannel->[isActive->[isOpen],connect->[connect],write->[write],hashCode->[hashCode],eventLoop->[eventLoop],Http2ChannelUnsafe->[writeComplete->[closeForcibly],disconnect->[close],flush->[flush0],beginRead->[isActive,recvBufAllocHan... | This method is called when a frame is received from the client. It checks if there is. | I really like this shift of responsibility to the stream channel. |
@@ -40,6 +40,10 @@ public class KuduClientConfig
private boolean disableStatistics;
private boolean schemaEmulationEnabled;
private String schemaEmulationPrefix = "presto::";
+ private boolean kerberosAuthEnabled;
+ private String kerberosPrincipal;
+ private String kerberosKeytab;
+ private ... | [KuduClientConfig->[setMasterAddresses->[copyOf,splitToList],omitEmptyStrings,Duration]] | Gets the master addresses. | Can we have this in a separate config file ? |
@@ -122,6 +122,9 @@ namespace System.Linq.Expressions.Interpreter
#endif
}
+ [DynamicDependency("GetValue", typeof(Array))]
+ [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2075:UnrecognizedReflectionPattern",
+ Justification = "The GetValue methods will be preserved by the ... | [MethodInfoCallInstruction->[Run->[TryGetLightLambdaTarget,InterpretLambdaInvoke]],ByRefMethodInfoCallInstruction->[Run->[TryGetLightLambdaTarget,InterpretLambdaInvoke,GetArgs]]] | Creates a call instruction that can be invoked by a method with no return value. Get array accessor. | @MichalStrehovsky will confirm, but I would expect the `GetValue` to be a runtime generated method, just like the array .ctors (because it has different overloads based on the array rank). |
@@ -58,7 +58,7 @@ class Internal::UsersController < Internal::ApplicationController
@user = User.find(params[:id])
begin
Moderator::DeleteUser.call(admin: current_user, user: @user, user_params: user_params)
- flash[:success] = "@" + @user.username + " (email: " + @user.email + ", user_id: " + @us... | [user_status->[redirect_to,find,message,handle_user_roles,id],add_credits->[to_i,add_to],show->[find,organizations],edit->[find],remove_credits->[remove_from,to_i],merge->[redirect_to,find,message,id,call_merge],add_note->[create,id],add_org_credits->[to_i,find,add_to_org],update->[redirect_to,find],banish->[call,redir... | full delete - Deletes the user if it has not been deleted. | Added a default value of "no email" to make the flash message look nicer. |
@@ -533,7 +533,7 @@ module.exports = class binance extends Exchange {
async withdraw (currency, amount, address, params = {}) {
let response = await this.wapiPostWithdraw (this.extend ({
- 'asset': currency,
+ 'asset': this.commonCurrencyCode (currency),
'address': add... | [No CFG could be retrieved] | Get a private order by ID or symbol urlencode - returns url encoded query. | This one probably needs a reverse-mapping. |
@@ -26,14 +26,16 @@
if (key.indexOf('web.rest') !== -1 || key.indexOf('service') !== -1) {
vm.servicesStats[key] = value;
}
- if (key.indexOf('net.sf.ehcache.Cache') !== -1) {
+ });
+ angular.forEach(newValue.gauges, function (v... | [No CFG could be retrieved] | Initialize the metrics monitoring controller. Refresh the thread dump data. | Note to self: Need to update for NG2 version as well cc @sendilkumarn @wmarques |
@@ -632,6 +632,17 @@ public class HoodieWriteConfig extends DefaultHoodieConfig {
return clientSpecifiedViewStorageConfig;
}
+ /**
+ * Commit call back configs.
+ */
+ public boolean writeCommitCallbackOn() {
+ return Boolean.parseBoolean(props.getProperty(HoodieWriteCommitCallbackConfig.CALLBACK_ON)... | [HoodieWriteConfig->[resetViewStorageConfig->[setViewStorageConfig],Builder->[build->[HoodieWriteConfig,getBasePath,build]]]] | get the client - specified view storage config. | IMO, this property is not necessary. We can only depend on `getCallbackClass ` to specify the detailed implementation. This is a simple **SPI** mode. Otherwise, it causes two entry points in the factory you implemented. WDYT? |
@@ -1,4 +1,4 @@
-<%= form_for @user do |f| %>
+<%= form_for @user.notification_setting, url: users_notification_settings_path do |f| %>
<div class="crayons-card crayons-card--content-rows">
<header>
<h2 class="crayons-subtitle-1">
| [No CFG could be retrieved] | Renders the user s n - node message. Outputs a hidden list of all possible crayons. | Ah, I see it wasn't just a one-character change. Sorry about that. Nice catch, though! :100: |
@@ -76,6 +76,17 @@ public final class OmUtils {
private static final SecureRandom SRAND = new SecureRandom();
private static byte[] randomBytes = new byte[32];
+ private static final long TRANSACTION_ID_SHIFT = 8;
+ // from the 64 bits of ObjectID (long variable), 2 bits are reserved for
+ // epoch and 8 bit... | [OmUtils->[getOMNodeIds->[addSuffix],addKeySuffixes->[addSuffix,concatSuffixes],getHttpAddressForOMPeerNode->[addKeySuffixes],getConfSuffixedWithOMNodeId->[addKeySuffixes],getHttpsAddressForOMPeerNode->[addKeySuffixes]]] | Stateless helper functions for the server and client side of OM. Get list of OM addresses by service ids. | can we use 1 << 54 instead of Math.pow ? |
@@ -22,7 +22,8 @@ class MfaPolicy
def sufficient_factors_enabled?
mfa_user.enabled_mfa_methods_count > 1 ||
(FeatureManagement.backup_codes_as_only_2fa? &&
- mfa_user.backup_code_configurations.to_a.length.positive?)
+ mfa_user.backup_code_configurations.to_a.length.positive? &&
+ !@signup... | [MfaPolicy->[no_factors_enabled?->[zero?],sufficient_factors_enabled?->[enabled_mfa_methods_count,backup_codes_as_only_2fa?,positive?],more_than_two_factors_enabled?->[enabled_mfa_methods_count],unphishable?->[zero?,positive?],two_factor_enabled?->[any?],initialize->[new],multiple_factors_enabled?->[enabled_mfa_methods... | Checks if sufficient factors are enabled for this configuration. | Looks like we can drop the `@` here |
@@ -100,6 +100,7 @@ class GraphManager(object):
if test:
conanfile.display_name = "%s (test package)" % str(test)
conanfile.output.scope = conanfile.display_name
+ conanfile.testing_reference = str(test)
run_configure_method(conanfile, down_opti... | [load_deps_info->[get_forbidden_access_object->[InfoObjectNotDefined],get_forbidden_access_object],_RecipeBuildRequires->[__call__->[add]],GraphManager->[_recurse_build_requires->[_recurse_build_requires,_get_recipe_build_requires],_load_graph->[_recurse_build_requires,load_graph],_get_recipe_build_requires->[TestRequi... | loads a conanfile for local flow Load a single NCBI - specific configuration file. | Why ``str()`` and not the RecipeReference object? Why not ``repr()`` so we don't lose potential information like the recipe revision? |
@@ -14,6 +14,7 @@ class ApplicationController < ActionController::Base
helper_method :decorated_session, :reauthn?, :user_fully_authenticated?
+ prepend_before_action :add_new_relic_trace_attributes
prepend_before_action :session_expires_at
prepend_before_action :set_locale
before_action :disable_cachi... | [ApplicationController->[confirm_two_factor_authenticated->[user_fully_authenticated?]]] | The base controller for the action. Provides a function to handle the response of a single - node . | Should this go below `prepend_before_action :set_locale`? If there's a possibility that adding the New Relic trace attributes crashes, the locale won't be set in the app and might result in the same issue we saw on TTP launch day where people were seeing the language of the app change. |
@@ -87,6 +87,15 @@ class Post < ActiveRecord::Base
end
end
+ def publish_change_to_clients!(type)
+ MessageBus.publish("/topic/#{topic_id}", {
+ id: id,
+ post_number: post_number,
+ updated_at: Time.now,
+ type: type
+ }, group_ids: topic.secure_group_ids)
+ end
+
def t... | [Post->[rebake!->[cook],excerpt->[excerpt],set_owner->[revise],cook->[cook,cook_methods],archetype->[archetype],update_flagged_posts_count->[update_flagged_posts_count],url->[url],urls->[url],cook]] | Limit posts per day to 1 day and then destroy the topic link if it s trashed. | While not entirely correct, this will probably be fine. The client was only using it to ignore revision messages, interestingly... |
@@ -90,6 +90,11 @@ export default Component.extend({
return computedLabel;
},
+ @discourseComputed("ariaExpanded")
+ computedAriaExpanded(ariaExpanded) {
+ return ariaExpanded && ariaExpanded !== "false" ? "true" : "false";
+ },
+
click(event) {
let { action } = this;
| [No CFG could be retrieved] | noText - > empty. | Is there a reason why `ariaExpanded` attribute can't be strict and accept just `true` and `false`? |
@@ -20,6 +20,11 @@ type agentInfo interface {
AgentID() string
}
+type fleetReporter interface {
+ repo.Backend
+ Events() ([]fleetapi.SerializableEvent, func())
+}
+
// fleetGateway is a gateway between the Agent and the Fleet API, it's take cares of all the
// bidirectional communication requirements. The gate... | [Start->[worker],worker->[Error,Debug,WaitTick,Dispatch,execute],execute->[NewCheckinCmd,Execute],NewPeriodic] | EC2 - related functions worker is a long running routine that runs in a separate goroutine. It is a long running. | From what I see you don't need to have the complete interface imported here, because you are only usings `Events()`? |
@@ -795,7 +795,7 @@ end_of_options:
*/
if (def_ret == 2 && def_nid == NID_undef) {
/* The signing algorithm requires there to be no digest */
- dgst = EVP_md_null();
+ dgst = (EVP_MD *)EVP_md_null();
} else if (md == NULL
&& (md = lookup_conf(conf, section, ENV_DEF... | [No CFG could be retrieved] | Parse the command - line options and return the value of flags. Parses the command line options and returns the config file path and section. | This proliferation of casts has me wonder if we should un-constify the likes of `EVP_md_null()`, `EVP_get_digestbyname()`, ... |
@@ -887,6 +887,7 @@ namespace System.Reflection.Emit
Emit(opcode, helper);
}
+ [return: DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicMethods)]
private static Type GetConsoleType()
{
return Type.GetType("System.Console, System.Console", thr... | [ILGenerator->[EmitCall->[Emit,GetToken],BeginFaultBlock->[AddFault,LastClauseType,InternalEndClause,PatchFilterClause],ThrowException->[Emit],BeginFinallyBlock->[LastClauseType,InternalEndClause,AddFinally,PatchFilterClause],BeginExceptFilterBlock->[AddFilter,InternalEndClause],InternalEndClause->[LastClauseType],Emit... | Emit a call to a method that is not part of the current module. | Why all public methods when we need only `WriteLine` ? |
@@ -338,12 +338,14 @@ public class MemoryPool
Map<String, Long> allocations = taggedMemoryAllocations.computeIfAbsent(queryId, ignored -> new HashMap<>());
allocations.compute(allocationTag, (ignored, oldValue) -> {
if (oldValue == null) {
+ checkArgument(delta > 0, "negati... | [MemoryPool->[NonCancellableMemoryFuture->[set->[set]],reserveRevocable->[onMemoryReserved],onMemoryReserved->[onMemoryReserved],toString->[toString],moveQuery->[freeRevocable,reserve,reserveRevocable,free],tryReserve->[onMemoryReserved]]] | This method updates the tagged memory allocations. | This will print eg > delta (-5) greater than value (3) should be "absolute value of delta" or something? |
@@ -7,6 +7,9 @@
* https://www.openssl.org/source/license.html
*/
+/* Uses EVP_PKEY_new_CMAC_key{,_ex} */
+#define OPENSSL_SUPPRESS_DEPRECATED
+
#include <stdio.h>
#include <string.h>
#include <stdlib.h>
| [No CFG could be retrieved] | Creates a typedef for a specific type of object. Test method structure. | This won't work unless you also disable the callers when OPENSSL_NO_DEPRECATED_3_0 is set. Besides I'd just remove these test cases as we are removing the EVP_PKEY_new_CMAC_key_ex completely and the CMAC implementation is tested via the MAC API. The EVP_PKEY_new_CMAC_key is tested also in evp_extra_test. But there it n... |
@@ -286,9 +286,7 @@ public class PySparkInterpreter extends Interpreter implements ExecuteResultHand
}
SparkInterpreter sparkInterpreter = getSparkInterpreter();
- if (!sparkInterpreter.getSparkContext().version().startsWith("1.2") &&
- !sparkInterpreter.getSparkContext().version().startsWith("1.3... | [PySparkInterpreter->[getProgress->[getProgress],getSQLContext->[getSQLContext,getSparkInterpreter],getJavaSparkContext->[getSparkInterpreter],open->[createPythonScript],getZeppelinContext->[getZeppelinContext,getSparkInterpreter],getSparkConf->[getJavaSparkContext],cancel->[cancel],getSparkInterpreter->[open],interpre... | Interprets a string and returns a result. FAILED - Statement output. | should we make 120 a class constant? |
@@ -69,6 +69,10 @@ class IStrategy(ABC, HyperStrategyMixin):
# associated stoploss
stoploss: float
+ # custom order price
+ entryprice: Optional[float] = None
+ exitprice: Optional[float] = None
+
# trailing stoploss
trailing_stop: bool = False
trailing_stop_positive: Optional[float]... | [IStrategy->[lock_pair->[lock_pair],is_pair_locked->[is_pair_locked],_analyze_ticker_internal->[analyze_ticker],should_sell->[SellCheckTuple],advise_indicators->[populate_indicators],analyze->[analyze_pair],advise_buy->[populate_buy_trend],unlock_pair->[unlock_pair],advise_sell->[populate_sell_trend],stop_loss_reached-... | A class to hold the attributes of a single node. A dictionary of all the possible values of a single candidate. | This will not work. there is one strategy object for all of freqtrade - storing a price here will have that price apply to ALL pairs that are evaluated - and as such will lead to conditional errors (only when more than one order is open at the same time). i also really don't see why you'd need this ... |
@@ -193,9 +193,14 @@ class _TransformWatermarks(object):
def refresh(self):
with self._lock:
- pending_holder = (WatermarkManager.WATERMARK_NEG_INF
- if self._pending else
- WatermarkManager.WATERMARK_POS_INF)
+ pending_holder = WatermarkManager.WATERMAR... | [WatermarkManager->[_refresh_watermarks->[get_watermarks,_refresh_watermarks],update_watermarks->[get_watermarks],extract_fired_timers->[extract_fired_timers]]] | Refreshes the watermarks based on the current state of the watermark manager. | What is the reason for `- TIME_GRANULARITY` ? |
@@ -356,6 +356,8 @@ class UserMerger
end
def delete_source_user
+ ::MessageBus.publish '/merge_user', { message: I18n.t("admin.user.merge_user.deleting_source_user") }
+
@source_user.reload
@source_user.skip_email_validation = true
| [UserMerger->[update_username->[update_username]]] | Delete a single user in the system if it has a lease. | I like how it updates the user as it goes along! |
@@ -96,7 +96,7 @@ namespace Content.Client
factory.RegisterReference<ClothingComponent, ItemComponent>();
- factory.Register<SpeciesUI>();
+ factory.Register<MobUI>();
factory.Register<CharacterInterface>();
factory.RegisterIgnore("Construction");
| [EntryPoint->[PostInit->[PostInit],Update->[Update]]] | This method initializes the component factories. Private methods - private methods - private methods - private methods - private methods - private methods -. | @clusterfack since you wrote the mob code initially, what's your opinion on renaming `Species` to `Mob`? Personally I don't care too much although I do believe I can see why you did it. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.