patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -16,7 +16,7 @@
import {simulateKeyboardInteraction} from './utils';
-const config = describe.configure().retryOnSaucelabs().ifChrome();
+const config = describe.configure().ifChrome();
config.skip('amp-inputmask', () => {
const {testServerPort} = window.ampTestRuntimeConfig;
| [No CFG could be retrieved] | A function to simulate a specific in the browser. Simulates the keyboard interaction. | For my understanding, is `ifChrome` still needed if tests are all run on local Chrome? |
@@ -44,7 +44,7 @@ public final class HoodieMetadataConfig extends HoodieConfig {
// Enable the internal Metadata Table which saves file listings
public static final ConfigProperty<Boolean> ENABLE = ConfigProperty
.key(METADATA_PREFIX + ".enable")
- .defaultValue(true)
+ .defaultValue(false)
... | [HoodieMetadataConfig->[Builder->[HoodieMetadataConfig]]] | Configuration for the Hoodie Metadata Table. Optional. If true asynchronous cleaning is enabled for metadata table. | why this is set to false ? |
@@ -124,12 +124,14 @@ export function animateCollapse(content) {
* @return {!UnlistenDef}
*/
function animate(element, prepare, cleanup = undefined) {
+ element.classList.add('i-amphtml-animating');
let player = prepare();
player.onfinish = player.oncancel = () => {
player = null;
if (cleanup) {
... | [No CFG could be retrieved] | Provides a function to handle the un - menu - related events. | We also need to put this in `player.oncancel`. |
@@ -684,10 +684,10 @@ public class JoinCompiler
// At that point, we'll be able to fully deprecate Type.equalTo (and friends) and remove this hack.
if (type.getJavaType().equals(Slice.class) && (
type instanceof CharType ||
- type instanceof JsonType ||
... | [JoinCompiler->[CacheKey->[equals->[equals]],internalCompileHashStrategy->[generateInstanceSize],compilePagesHashStrategyFactory->[compilePagesHashStrategyFactory],compileLookupSourceFactory->[compileLookupSourceFactory]]] | Generate positionNotDistinctFromRowWithPageMethod creates a method that invokes the NOT_DI Checks if a type is a distinct from or a union of two types. | This is less readable than before |
@@ -62,11 +62,11 @@ namespace NServiceBus
}
/// <summary>
- /// Moves expired messages using the "time to reach queue" setting to the dead letter queue instead of discarding them.
+ /// Moves messages that has expired their TimeToBeReceived to the dead letter queue instead of discardin... | [MsmqConfigurationExtensions->[UseDeadLetterQueueForMessagesWithTimeToReachQueue->[UseDeadLetterQueueForMessagesWithTimeToReachQueue]]] | Use dead letter queue for messages with time to reach queue. | Moves messages that have expired their TimeToBeReceived ? |
@@ -273,7 +273,7 @@ module AutomatedTestsHelper
FileUtils.cp_r(File.join(assignment_dir, 'parse'), repo_assignment_dir)
end
else
- raise I18n.t('automated_tests.dir_not_exist', {:dir => assignment_dir})
+ raise I18n.t('automated_tests.dir_not_exist', {dir: assignment_dir})
end
end... | [run_ant_file->[short_identifier,system,each_line,new,exists?,cd,create,id,raise,pwd,now,join,close,parse_test_output,exitstatus,t,open,l],delete_test_repo->[exists?,markus_config_automated_tests_repository,rm_rf,repo_name,join],add_parser_file_link->[new,render,link_to_function,escape_javascript,t],export_repository->... | Copy Ant files from the source repository to the destination directory. Copy the missing files from the repository to the repository and run Ant. This method is called when Ant exits with non - zero exit status. | Redundant curly braces around a hash parameter.<br>Space inside { missing.<br>Space inside } missing. |
@@ -88,12 +88,15 @@ public class ServerSslConfig {
* @throws GeneralSecurityException if something failed in the context setup
*/
public SSLContext toSSLContext() throws GeneralSecurityException, IOException {
+ //TODO: static fields break config
+ Logger log = Logger.getLogger("io.quarku... | [ServerSslConfig->[load->[ofChars,size,newInputStream,InputStreamReader,read,toIntExact],toSSLContext->[defaultProtocols,parsePemContent,create,getAsInt,toArray,toString,getDefaultAlgorithm,setProtocolSelector,setSessionTimeout,warnf,SSLContextBuilder,tryCast,init,getSeconds,min,endsWith,newInputStream,getDefaultType,o... | Creates an SSLContext based on the contents of the certificate file and key files. private KeyStore keyStore ;. | Oops! My bad, I've opened #1221 and have a PR coming up. |
@@ -805,7 +805,9 @@ function dist() {
copyAliasExtensions();
}).then(() => {
if (argv.fortesting) {
- return enableLocalTesting(minifiedRuntimeTarget);
+ return enableLocalTesting(minifiedRuntimeTarget).then(() => {
+ return enableLocalTesting(minifiedRuntimeEsmTarg... | [No CFG could be retrieved] | This function cleans up the build directory and all of the files that are not already in Copy built extensions to alias extension. | In person clarification: These are almost instantaneous, so no need to parallelize with `Promise.all`. Perfect! |
@@ -54,7 +54,8 @@ class TopInterfacesController extends WidgetController
->isValid()
->select('port_id', 'device_id', 'ifName', 'ifDescr', 'ifAlias')
->groupBy('port_id', 'device_id', 'ifName', 'ifDescr', 'ifAlias')
- ->where('poll_time', '>', Carbon::now()->subMinutes(... | [TopInterfacesController->[getSettingsView->[getSettings],getView->[get,where,getSettings,limit]]] | Returns the top - interfaces widget. | Maybe isUp() instead maybe? |
@@ -291,7 +291,9 @@ class ClientCache(object):
def initialize_settings(self):
if not os.path.exists(self.settings_path):
- save(self.settings_path, normalize(get_default_settings_yml()))
+ settings_yml = default_settings_yml
+ save(self.settings_path, settings_yml)
+ ... | [ClientCache->[update_recipe_timestamp->[update_recipe_timestamp],create_build_pkg_layout->[create_build_pkg_layout],reset_settings->[initialize_settings],get_package_references->[get_package_references],get_recipe_revisions_references->[get_recipe_revisions_references],get_latest_recipe_reference->[get_latest_recipe_r... | Initialize settings file. | Could we make the same for `get_default_client_conf` to simplify the `normalize(get_default_client_conf()`? |
@@ -847,13 +847,12 @@ void MapgenV6::flowMud(s16 &mudflow_minpos, s16 &mudflow_maxpos)
}
// Drop mud on side
- for (u32 di = 0; di < 4; di++) {
- v3s16 dirp = dirs4[di];
+ for (const v3s16 &dirp : dirs4) {
u32 i2 = i;
// Move to side
vm->m_area.add_p(em, i2, dirp);
// Fail ... | [getGroundLevelAtPoint->[baseTerrainLevelFromNoise],getMudAmount->[getMudAmount],growGrass->[getBiome],getBiome->[getBiome],getSpawnLevelAtPoint->[baseTerrainLevelFromNoise],getHaveBeach->[getHaveBeach],generateCaves->[getBiome],makeChunk->[get_blockseed,NoiseParams,getBiome],addMud->[getHaveBeach,getMudAmount,find_sto... | flow - Mud flow This function is called to find the node that is not in the tree. Add a new entry in the map area. | Will this still iterate through the directions in the same order as before? |
@@ -510,12 +510,12 @@ public class NotebookRestApi {
* @throws IOException, IllegalArgumentException
*/
@DELETE
- @Path("job/{notebookId}")
+ @Path("job/{noteId}")
@ZeppelinApi
- public Response stopNoteJobs(@PathParam("notebookId") String notebookId)
- throws IOException, IllegalArgumentException... | [NotebookRestApi->[insertParagraph->[insertParagraph],runParagraph->[getParagraph],getJobListforNotebook->[getJobListforNotebook],getUpdatedJobListforNotebook->[getJobListforNotebook],deleteParagraph->[getParagraph],getParagraph->[getParagraph],cloneNote->[cloneNote],stopParagraph->[getParagraph],createNote->[createNot... | Stop a sequence of notebook jobs. | throws with next line should have 4 spaces from declaration. |
@@ -202,6 +202,12 @@ func (cs *ContainerService) setOrchestratorDefaults(isUpgrade, isScale bool) {
}
}
}
+
+ if o.KubernetesConfig.NetworkPlugin == NetworkPluginAzure {
+ if o.KubernetesConfig.NetworkMode == "" {
+ o.KubernetesConfig.NetworkMode = NetworkModeTransparent
+ }
+ }
if o.KubernetesC... | [SetPropertiesDefaults->[setAgentProfileDefaults,setOrchestratorDefaults,setTelemetryProfileDefaults,SetDefaultCerts,IsCustomCloudProfile,setCustomCloudProfileDefaults,setCSIProxyDefaults,setExtensionDefaults,setHostedMasterProfileDefaults,setMasterProfileDefaults,setWindowsProfileDefaults,setStorageDefaults],setAgentP... | setOrchestratorDefaults sets the default values for the Orchestrator profile and the default This function is used to configure the Kubernetes image based on the MCR image base. Sets the default values for the configuration object. | sorry for a dumb question but what actually actions on network mode? I couldn't find it in my novice sluething. I just found this in cse. if [[ "${NETWORK_POLICY}" == "calico" ]]; then -- 284 | sed -i 's#"mode":"bridge"#"mode":"transparent"#g' $CNI_CONFIG_DIR/10-azure.conflist |
@@ -121,7 +121,7 @@ $usercansend = (empty($conf->global->MAIN_USE_ADVANCED_PERMS) || $user->rights->
$usercancreateorder = $user->rights->commande->creer;
$usercancreateinvoice = $user->rights->facture->creer;
$usercancreatecontract = $user->rights->contrat->creer;
-$usercancreateintervention = $user->rights->fichei... | [update_price,create,form_multicurrency_rate,selectInputReason,getLinesArray,getNomUrl,setDeliveryDate,select_incoterms,begin,closeProposal,select_comptes,formInputReason,insert_discount,add_contact,setProject,getOutstandingBills,printOriginLinesList,textwithpicto,fetch_optionals,selectDate,transnoentitiesnoconv,query,... | Initialize technical object to manage hooks of page This function is used to check if a user can create an action on an object. | So if MAIN_USE_ADVANCED_PERMS is not set, it means with this change that users can always create intervention whatever are permission. Surely a bug. |
@@ -974,6 +974,8 @@ public class QueueImpl extends CriticalComponentImpl implements Queue {
public void addTail(final MessageReference ref, final boolean direct) {
enterCritical(CRITICAL_PATH_ADD_TAIL);
try {
+ enforceRing();
+
if (scheduleIfPossible(ref)) {
return;
... | [QueueImpl->[getDurableDeliveringCount->[getDurableMessageCount],scheduleDepage->[getName],configureExpiry->[getExpiryAddress],addConsumer->[debug],deleteAllReferences->[deleteAllReferences],configureSlowConsumerReaper->[equals,getName,cancel,debug],getMessageCount->[getMessageCount],getDeliveringCount->[getMessageCoun... | Adds a message reference to the tail of the queue. | Should put enforceRing below schedule and direct deliver code? |
@@ -14,7 +14,7 @@ module RememberDeviceConcern
end
def check_remember_device_preference
- return unless authentication_context?
+ return unless UserSessionContext.authentication_context?(context)
return if remember_device_cookie.nil?
return unless remember_device_cookie.valid_for_user?(
u... | [check_remember_device_preference->[authentication_context?,valid_for_user?,nil?,mfa_expiration_interval],pii_locked_for_session?->[expired_for_interval?,minutes],remember_device_cookie_expiration->[from_now],revoke_remember_device->[call],save_remember_device_preference->[encrypted,to_json],expired_for_interval?->[val... | Check if a given node is a valid remember device preference node. | big fan of this cleanup! down with ambiguous mixins! |
@@ -234,9 +234,8 @@ class EntityTable {
*
* Handles loading all tables into the correct class.
*
- * @see get_entity_as_row()
- * @see add_subtype()
- * @see get_entity()
+ * @see get_entity_as_row()
+ * @see get_entity()
*
* @access private
*
| [EntityTable->[enable->[enable],fetchFromSql->[rowToElggStar],exists->[getRow],get->[rowToElggStar,getRow,getFromCache],getUserForPermissionsCheck->[get]]] | Update an existing entity in the table. Create an entity object from a row of data. | please remove spaces |
@@ -14,3 +14,17 @@ export function useResourcesNotify() {
}
});
}
+
+/**
+ * Combines multiple refs to pass into `ref` prop.
+ * @param {...any} refs
+ * @return {function(!Element)}
+ */
+export function refs(...refs) {
+ return (element) => {
+ for (let i = 0; i < refs.length; i++) {
+ const ref = r... | [No CFG could be retrieved] | Constructor for the neccessary object. | Use `useCallback` to avoid trashing the ref. |
@@ -22,11 +22,11 @@ class TestSupportFile < ApplicationRecord
# Run delete_file method after removal from db
after_destroy :delete_file
- validates_presence_of :assignment
validates_associated :assignment
validates_presence_of :file_name
- validates_presence_of :description, if: "description.nil?"
+ ... | [TestSupportFile->[write_file->[short_identifier,write,read,join,open,file_name],sanitize_filename->[original_filename,gsub,strip!,respond_to?,file_name],delete_old_file->[delete_file,file_name_changed?],delete_file->[short_identifier,join,exist?,file_name,delete],belongs_to,original_filename,t,before_save,validates_as... | This model represents a single instance of a test support file. It can be a model that This method is called to set the name of the object. | Layout/SpaceInLambdaLiteral: Do not use spaces between -> and opening brace in lambda literals |
@@ -19,7 +19,7 @@ namespace System.Threading
/// <returns>An object that represents a system mutex, if named, or a local mutex, if nameless.</returns>
/// <exception cref="ArgumentException">.NET Framework only: The length of the name exceeds the maximum limit.</exception>
/// <exception cref... | [MutexAcl->[ValidateMutexHandle->[IsInvalid,SetHandleAsInvalid,ERROR_FILENAME_EXCED_RANGE,nameof,Format,ERROR_ALREADY_EXISTS,ERROR_INVALID_HANDLE,GetExceptionForWin32Error,Threading_WaitHandleCannotBeOpenedException_InvalidHandle,Argument_WaitHandleNameTooLong,GetLastWin32Error],Mutex->[GetSecurityDescriptorBinaryForm,... | Creates a new mutex with the specified name and security attributes. | Same for `mutexSecurity` |
@@ -3489,3 +3489,11 @@ out:
return rc;
}
+
+int
+dc_obj_anchor_split(uint32_t shard, daos_anchor_t *anchor) {
+ daos_anchor_set_zero(anchor);
+ dc_obj_shard2anchor(anchor, shard);
+ daos_anchor_set_flags(anchor, DIOF_TO_SPEC_SHARD);
+ return 0;
+}
| [No CFG could be retrieved] | return rc ;. | Does it return DAOS_ANCHOR_TYPE_EOF when we reach the end of the shard? |
@@ -985,6 +985,7 @@ func (mod *modContext) genResource(r *schema.Resource) resourceDocArgs {
if r.StateInputs != nil {
stateInputs[lang] = mod.getProperties(r.StateInputs.Properties, lang, true, false)
}
+ outputProps[lang] = filterOutputProperties(inputProps[lang], outputProps[lang])
}
allOptionalInpu... | [genResource->[genNestedTypes,genLookupParams,genConstructors,getProperties,getConstructorResourceInfo],gen->[getModuleFileName,genResource,add],genNestedTypes->[typeString],genIndex->[getModuleFileName],genConstructorCS->[typeString],genConstructors->[genConstructorTS,genConstructorGo,genConstructorCS],genLookupParams... | genResource generates a resource doc args object for a resource This function generates all the data structures that are required to satisfy the NestedType interface. | Instead of filtering the output properties after calling `getProperties` for the full list of output properties, could we do it before? That way, we just call `getProperties` with the filtered list of output properties? `getProperties` calls out to each lang code gen to generate a property's type string name for every ... |
@@ -209,14 +209,14 @@ def is_channel_usable_for_mediation(
channel_state, transfer_amount, lock_timeout
)
- return channel_usable
+ return channel_usable is IsChannelUsable.YES
def is_channel_usable_for_new_transfer(
channel_state: NettingChannelState,
transfer_amount: PaymentWithFe... | [get_current_balanceproof->[get_amount_locked],is_valid_withdraw_confirmation->[is_valid_withdraw,is_valid_channel_total_withdraw],register_secret_endstate->[is_lock_locked],handle_channel_deposit->[update_fee_schedule_after_balance_change,update_contract_balance],handle_action_withdraw->[is_valid_action_withdraw,send_... | Returns True if the channel can safely be used for mediated transfer. Checks if a is available in the channel. | Nice, this makes the failure clearer! |
@@ -2,5 +2,4 @@
// Copyright (C) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
//-------------------------------------------------------------------------------------------------------
-#pragma once
#include "JsrtPch.h"
| [No CFG could be retrieved] | License for a given . | Weird... Was JsrtPch.cpp `#include`d somewhere at some point? |
@@ -321,9 +321,14 @@ export class SubscriptionService {
} else if (entitlements) { // Not null
entitlementJson = entitlements;
}
- const entitlement = entitlementJson ?
- Entitlement.parseFromJson(entitlementJson) :
- Entitlement.empty('local');
+
+ let entitlement;
+ ... | [No CFG could be retrieved] | Provides a dialog to the user that is able to block the user s authorization. This method is called when the grant state is received from the client and the client is ready. | Hmm. I'd rather we pass it as an argument to `parseFromJson` than as a surrogate field. I don't want anyone try to emulate this with their response. |
@@ -122,7 +122,8 @@ def test_pkg_add(mock_pkg_git_repo):
with working_dir(mock_pkg_git_repo):
try:
assert ('A pkg-e/package.py' in
- git('status', '--short', output=str))
+ git('-c', 'color.status=off',
+ 'status', '--short', outpu... | [test_pkg_added->[split],test_pkg_removed->[split],split->[split],test_pkg_diff->[split],test_pkg_list->[split],test_pkg_changed->[split]] | Test if package. py is added in git. | Just curious: this seems unrelated, what's going on here? |
@@ -16,7 +16,7 @@ $rrd_options .= ' CDEF:sensor_diff=sensor_max,sensor_min,-';
$rrd_options .= ' AREA:sensor_min';
$rrd_options .= ' AREA:sensor_diff#c5c5c5::STACK';
-$rrd_options .= " LINE1.5:sensor#cc0000:'".rrdtool_escape($sensor['sensor_descr'], 21)."'";
+$rrd_options .= " LINE1.5:sensor#cc0000:'".rrdtool_escap... | [No CFG could be retrieved] | Read the RRD options file. | ipmiSensorName() is being called as a function here rather than part of an array - same for the other files. This will also run all temp sensors through this regardless of it being an ipmi based sensor or not. |
@@ -250,7 +250,7 @@ namespace System.Net.Quic.Implementations.MsQuic
{
DnsEndPoint dnsEp => (dnsEp.Host, dnsEp.Port),
IPEndPoint ipEp => (ipEp.Address.ToString(), ipEp.Port),
- _ => throw new Exception($"Unsupported remote endpoint type '{_remoteEndPoint.Get... | [MsQuicConnection->[NativeCallbackHandler->[HandleEvent],Dispose->[Dispose],Dispose]] | ConnectAsync implementation. | @scalablecory, I assume these exceptions will change to some better type. When they do, are the messages likely to change as well? Wondering if we should be moving them to the resx now or what a bit until things settle. |
@@ -95,7 +95,7 @@ public class AddGroupsAction extends BaseListAction {
* @param groups list of server groups
*/
static void setupAccessMap(RequestContext context, List<ManagedServerGroup> groups) {
- ServerGroupManager sgm = ServerGroupManager.getInstance();
+ ServerGroupManager sgm = Gl... | [AddGroupsAction->[handleDispatch->[findForward,RequestContext,forwardParams,size,getStrutsDelegate,getInstance,addServerGroup,getSet,lookupAndBindActivationKey,lookup,saveMessage,toString,getCurrentUser,put,valueOf],setupAccessMap->[setAttribute,canAccess,getInstance,getId,getCurrentUser,put],getResult->[listManagedGr... | This method is used to setup the access map. | Since GlobalInstanceHolder.SERVER_GROUP_MANAGER is static and the class field `sgm` is not passed as contructor argument, should `sgm` variable changed to static and avoid get it again in this method? |
@@ -298,9 +298,12 @@ class SetChannelsMixin(object):
Returns
-------
inst : instance of Raw | Epochs | Evoked
- Data with EEG channels re-referenced. For ``ref_channels=None``,
- an average projector will be added instead of directly subtarcting
- data.
+ ... | [ContainsMixin->[__contains__->[_contains_ch_type]],_get_T1T2_mag_inds->[pick_types],UpdateChannelsMixin->[pick_types->[pick_types]],read_ch_connectivity->[_recursive_flatten],fix_mag_coil_types->[pick_types],find_ch_connectivity->[read_ch_connectivity],SetChannelsMixin->[set_channel_types->[_check_set],rename_channels... | Set the EEG reference. This function is called when a specific sequence of data has not yet been applied to the data. | Looks like this is not returned, since you pick the first element in ``return``. |
@@ -68,7 +68,7 @@ func (m *MetricSet) Fetch(reporter mb.ReporterV2) error {
return errors.Wrap(err, "failed to retrieve serverStatus")
}
- data, err := schema.Apply(result)
+ data, err := schemaMetrics.Apply(result, schema.FailOnRequired)
if err != nil {
return errors.Wrap(err, "failed to apply schema")
}... | [Fetch->[Apply,Close,Event,Wrap,NewDirectSession,DB,Run],NewMetricSet,DefaultMetricSet,MustAddMetricSet,WithHostParser] | Fetch fetches all metrics from the database. | Take into account that with this what we are doing is to ignore all keys errors, because there are no fields marked as required. |
@@ -1380,13 +1380,11 @@ spack:
ci, 'SPACK_PR_MIRRORS_ROOT_URL', r"file:///fake/mirror")
with ev.read('test'):
- ci_cmd('generate', '--output-file', outputfile)
+ ci_cmd('generate', '--output-file', outputfile, global_args=['-d'])
with open(outputfile) as of:
... | [test_ci_generate_bootstrap_prune_dag->[_validate_needs_graph],test_ci_rebuild_basic->[set_env_var],test_ci_generate_bootstrap_artifacts_buildcache->[_validate_needs_graph],test_ci_generate_bootstrap_gcc->[_validate_needs_graph]] | Test that the. spack. yaml file is generated with the given configuration and with the. | I think this is a vestigial debugging change. |
@@ -69,6 +69,12 @@ namespace System.Windows.Forms
[DllImport(ExternDll.User32, SetLastError = true, ExactSpelling = true, CharSet = CharSet.Auto)]
internal static extern DpiAwarenessContext SetThreadDpiAwarenessContext(DpiAwarenessContext dpiContext);
+ [DllImport(ExternDll.User32, SetLastErr... | [CommonUnsafeNativeMethods->[TryFindDpiAwarenessContextsEqual->[AreDpiAwarenessContextsEqual]]] | Dll - awareness context methods. | It looks like all of the existing APIs that take DpiAwarenessContext are broken to me. They should all be working with IntPtr like your change. I don't think you need to fix that here, but we should create an issue. |
@@ -383,9 +383,12 @@ def variant_details(request, product_pk, variant_pk):
images = variant.images.all()
margin = get_margin_for_variant(variant)
+ include_taxes_in_prices = request.site.settings.include_taxes_in_prices
+ discounted_price = variant.get_price(discounts=Sale.objects.all()).gross
ct... | [ajax_available_variants_list->[get_variant_label]] | Show a listing of the product s variants. | Can be accessed via context processor |
@@ -587,11 +587,11 @@ public final class FilePath implements Serializable {
ZipEntry e = entries.nextElement();
File f = new File(dir, e.getName());
if (e.isDirectory()) {
- mkdirs(f);
+ Files.createDirectories(f.toPath());
... | [FilePath->[getTotalDiskSpace->[act],unzipFrom->[invoke->[unzip]],unzip->[invoke->[getRemote,unzip],FilePath,unzip],equals->[equals],mkdirs->[invoke->[mkdirs],exists,act,mkdirs],AbstractInterceptorCallableWrapper->[call->[call],getClassLoader->[getClassLoader]],untarFrom->[invoke->[extract]],write->[invoke->[write,mkdi... | Unzips the given zip file into the given directory. | Use `Util#toPath()` created by @dwnusbaum a while ago. Otherwise there is a risk of unhandled runtime `InvalidPathException` |
@@ -430,13 +430,12 @@ class PLNPlugin extends GenericPlugin {
*/
function getServiceDocument($journalId) {
- $plnNetworks = unserialize(PLN_PLUGIN_NETWORKS);
$journalDao =& DAORegistry::getDAO('JournalDAO');
$journal =& $journalDao->getById($journalId);
// retrieve the service document
$resul... | [PLNPlugin->[callbackJournalArchivingSetup->[getTemplatePath],callbackTemplateDisplay->[getStyleSheet],callbackLoadHandler->[getHandlerPath],termsAgreed->[getSetting],getServiceDocument->[getSetting]]] | Retrieve the service document for a given ID This method will retrieve the term elements from the node that is associated with the current journal. | if it was a setting before, it could be changed. Now it's a constant, it can't. That's not a problem? |
@@ -101,3 +101,18 @@ check_sector_size_database(char *path, int *sector_size)
{
return (0);
}
+
+void
+after_zpool_upgrade(zpool_handle_t *zhp)
+{
+ char bootfs[ZPOOL_MAXPROPLEN];
+
+ if (zpool_get_prop(zhp, ZPOOL_PROP_BOOTFS, bootfs,
+ sizeof (bootfs), NULL, B_FALSE) == 0 &&
+ strcmp(bootfs, "-") != 0) {
+... | [check_device->[strncmp,snprintf,strlcpy,check_file]] | This function is called to check if the database contains any missing sectors. | Just a final style nit: blank line after variable declarations at the top of a function |
@@ -72,15 +72,14 @@ class TextField(SequenceField[Dict[str, numpy.ndarray]]):
# _empty_ TextField, but if this is the case, token_lengths will be an empty
# list, so we add the default empty padding dictionary to the list instead.
token_lengths = [{}]
- # It... | [TextField->[count_vocab_items->[count_vocab_items],get_padding_lengths->[get_padding_lengths],empty_field->[TextField]]] | Get the padding lengths for all tokens. | This isn't just a single "token length", though I can see how the name above could make you think that. `token_lengths` is "the padding lengths for each token". If changing this to `token_padding_lengths` would make things more clear, feel free to make the change. So, we're iterating over the keys and finding the max o... |
@@ -504,6 +504,12 @@ define([
*/
this.copyGlobeDepth = false;
+ this.fogEnabled = true;
+ this.fogStartDensity = 0.00002;
+ this.fogEndDensity = 9e-8;
+ this.fogStartHeight = 2000.0;
+ this.fogEndHeight = 100000.0;
+
this._performanceDisplay = undefined;
... | [No CFG could be retrieved] | A function that determines if a given command overlaps with any other command in the scene or model Displays the color components of a color component that are tinted or tinted. | These should probably be on a new `scene.fog` object. |
@@ -375,9 +375,7 @@ public abstract class AbstractBootstrap<B extends AbstractBootstrap<B, C>, C ext
* the {@link ChannelHandler} to use for serving the requests.
*/
public B handler(ChannelHandler handler) {
- if (handler == null) {
- throw new NullPointerException("handler");
- ... | [AbstractBootstrap->[option->[self],initAndRegister->[register],handler->[self],doBind->[channel],validate->[self],attr->[self],attrs->[copiedMap],toString->[toString],options->[copiedMap],PendingRegistrationPromise->[executor->[executor]],channelFactory->[channelFactory,self],bind->[validate,bind],register->[validate]... | Sets the channel handler. | nit you can merge the above two lines |
@@ -24,6 +24,7 @@ import java.util.concurrent.Callable;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import java.util.concurrent.ScheduledExecutorS... | [StandardProcessScheduler->[stopConnectable->[getActiveThreadCount,unschedule,getStateManager],startConnectable->[getActiveThreadCount,schedule],setMaxThreadCount->[setMaxThreadCount],schedule->[run->[schedule],getSchedulingAgent],disableControllerServices->[disableControllerService],shutdown->[shutdown],getActiveThrea... | Imports a single - node object. Package methods for NIFC. | Unused import, will remove on merge |
@@ -296,6 +296,7 @@ func (consensus *Consensus) onCommit(msg *msg_pb.Message) {
return
}
+ // TODO(audit): verify signature on hash+blockNum+viewID (add a hard fork)
blockNumHash := make([]byte, 8)
binary.LittleEndian.PutUint64(blockNumHash, recvMsg.BlockNum)
commitPayload := append(blockNumHash, recvMsg.B... | [onPrepare->[Unlock,Warn,didReachPrepareQuorum,ParticipantsCount,SignersCount,With,SerializeToHexStr,Info,Error,IsQuorumAchieved,SetKey,HasMatchingViewAnnounce,Lock,Logger,Debug,Uint64,Int64,ReadBallot,Deserialize,Err,Str,Msg,switchPhase,getLogger,SubmitVote,VerifyHash],announce->[ShardID,EncodeToBytes,Hash,Warn,SendWi... | OnCommit is called when a message is received from the FBFT log. It will This function is used to read the current header and read the next header from the current shard onCommit - This function is called when a message is received from the sender of a chain OnCommit - Commit - Commit - Commit - Commit - Commit - Commi... | why is it a hard fork though, this is just at consensus level, i guess then it needs to be driven down to the blockchain level too |
@@ -27,10 +27,10 @@ const {Base} = mocha.reporters;
*/
function ciReporter(runner, options) {
Base.call(this, runner, options);
- this._mochaDotsReporter = new MochaDotsReporter(runner, options);
- this._jsonReporter = new JsonReporter(runner, options);
+ this._mochaDotsReporter = new MochaDotsReporter(runner)... | [No CFG could be retrieved] | The base reporter for the module. | Neither of these reporters support a second parameter. |
@@ -16,12 +16,13 @@ module Articles
# Timeframe values from Timeframer::DATETIMES
def top_articles_by_timeframe(timeframe:)
published_articles_by_tag.where("published_at > ?", Timeframer.new(timeframe).datetime).
- order("score DESC")
+ order("score DESC").page(@page).per(@number_of_artic... | [Feed->[default_home_feed->[default_home_feed_and_featured_story]]] | Returns an array of top - level articles ordered by published_at highest - score first -. | I feel like a bazillion bucks :D |
@@ -38,10 +38,10 @@ class RJsonlite(Package):
use with dynamic data in systems and applications."""
homepage = "https://github.com/jeroenooms/jsonlite"
- url = "https://cran.r-project.org/src/contrib/jsonlite_0.9.21.tar.gz"
+ url = "https://cran.r-project.org/src/contrib/jsonlite_1.0.tar.gz"... | [RJsonlite->[install->[R,format],version,extends]] | Install the given module. | You do not have to change the url, just adding the new version and md5 is sufficient. Also, I think there is a general preference to put the newer version on top. |
@@ -175,8 +175,7 @@ namespace System.Runtime.Serialization
3, 7, 17, 37, 89, 197, 431, 919, 1931, 4049, 8419, 17519, 36353,
75431, 156437, 324449, 672827, 1395263, 2893249, 5999471,
11998949, 23997907, 47995853, 95991737, 191983481, 383966977, 767933981, 1535867969,
- 2... | [ObjectToIdCache->[Rehash->[GetPrime,FindElement,Length],ComputeStartPosition->[GetHashCode,Length],GetPrime->[Length],FindElement->[CreateSerializationException,ComputeStartPosition,ObjectTableOverflow,ThrowHelperError,Length,DebugAssert],GetId->[Rehash,FindElement,Length],ReassignId->[FindElement,RemoveAt],RemoveAt->... | This function is used to find the largest possible array size. | Is this going to turn off the efficient pre-ininitialization path for this array? |
@@ -108,8 +108,8 @@ class Indexable_Repository {
// Find by both url_hash and url, url_hash is indexed so will be used first by the DB to optimize the query.
return $this->query()
- ->where( 'url_hash', $url_hash )
- ->where( 'url', $url )
+ ->where( 'permalink_hash', $url_hash )
+ ->where( 'per... | [Indexable_Repository->[find_by_multiple_ids_and_type->[build_for_id_and_type,find_many,save],find_for_date_archive->[build_for_date_archive,find_one],get_ancestors->[order_by_desc,find_many],find_for_home_page->[build_for_home_page,find_one],find_by_url->[find_one],find_for_post_type_archive->[build_for_post_type_arch... | Find by url. | Is there a specific reason to change this to permalink_hash? Can you explain this in the technical choices. I also would rename the methods name into `find_by_permalink.` and rename `url` to `permalink` to have a clear function. |
@@ -102,6 +102,11 @@ func (n UsernsMode) IsAuto() bool {
return parts[0] == "auto"
}
+// IsDefaultValue indicates whether the user namespace has the default value.
+func (n UsernsMode) IsDefaultValue() bool {
+ return n == "" || n == defaultType
+}
+
// GetAutoOptions returns a AutoUserNsOptions with the settings... | [IsUserDefined->[IsBridge,IsSlirp4netns,IsNS,IsHost,IsContainer,IsNone,IsDefault],Valid->[IsShareable,IsHost,IsEmpty,IsPrivate,IsContainer,IsNone],IsPrivate->[IsHost,IsContainer]] | IsAuto returns true if the mode is auto. | Shouldn't this also check for the explicit Default constant? |
@@ -25,9 +25,10 @@ define([
* scaled space, and used for horizon culling. If this point is below the horizon,
* the tile is considered to be entirely below the horizon.
* @param {Number} [vertexStride=6] The number of components in each vertex.
- * @par... | [defaultValue,orientedBoundingBox,boundingSphere3D,occludeePointInScaledSpace,vertices,center,stride,minimumHeight,function,var,maximumHeight,indices,define] | The base class for the base classes. The is an array of vertex indices that can be used to determine the vertex indices. | Is this technically a breaking change since `TerrainMesh` is public? |
@@ -411,7 +411,13 @@ class DoFnRunner(Receiver):
raise new_exn, None, original_traceback
-class _OutputProcessor(object):
+class OutputProcessor(object):
+
+ def process_outputs(self, windowed_input_element, results):
+ raise NotImplementedError
+
+
+class _OutputProcessor(OutputProcessor):
"""Processes... | [PerWindowInvoker->[__init__->[ArgPlaceholder]],_OutputProcessor->[finish_bundle_outputs->[receive],process_outputs->[receive]],DoFnRunner->[finish->[_invoke_bundle_method],process->[invoke_process,enter,exit],__init__->[create_invoker,DoFnSignature,LoggingContext],start->[_invoke_bundle_method],_invoke_bundle_method->... | Initializes _OutputProcessor. | <!--new_thread; commit:7ca389e990c4482eec47aecdc1913eeee0b169f9; resolved:0--> What is the motivation for this change? |
@@ -907,8 +907,14 @@ func NewApp(client *Client) *cli.App {
Subcommands: []cli.Command{
{
Name: "create",
- Usage: "Send <amount> Eth from node ETH account <fromAddress> to destination <toAddress>.",
+ Usage: "Send <amount> ETH (actual ETH, not wei) from node ETH account <fromAddress> to dest... | [ReplaceAll,Sprintf,FeatureExternalInitiators,NewApp,Dev,MustCompile,Bool] | Commands for the given user - specified object. Commands for handling chains and EVM chains. | You know, we probably ought to allow sending raw wei balances via an argument or something. If you want to completely drain a wallet, it could be useful. |
@@ -681,7 +681,7 @@ def tf_mixed_norm(evoked, forward, noise_cov, alpha_space=None,
X, active_set, E = tf_mixed_norm_solver(
M, gain, alpha_space, alpha_time, wsize=wsize, tstep=tstep,
maxit=maxit, tol=tol, verbose=verbose, n_orient=n_dip_per_pos,
- log_objective=True, debias=debias)
+ ... | [tf_mixed_norm->[_make_sparse_stc,_reapply_source_weighting,_prepare_gain,_make_dipoles_sparse,_compute_residual,_window_evoked],mixed_norm->[_reapply_source_weighting,_prepare_gain,_make_sparse_stc,_compute_residual,_make_dipoles_sparse],_prepare_gain->[_prepare_gain_column],_prepare_gain_column->[_prepare_weights]] | Time - Frequency Mixed - Normal estimate on time - frequency sequence. Diagonal regularization parameter. The time - courses with a non - stationary non - overlapping state in the time courses A function to compute the alpha_max and alpha_dip_per_pos of a Compute the whitened dipoles or the non - discrete whitened sour... | I suggest to have `log_objective=log_objective` here and add `log_objective=10` as a new parameter to `tf_mixed_norm`. The user might want to control the frequency of dgap evaluations. |
@@ -317,7 +317,7 @@ func findPolicy(policies []kibanaPolicy) (*kibanaPolicy, error) {
func findKey(keys []kibanaAPIKey, policy *kibanaPolicy) (*kibanaAPIKey, error) {
tokenName := envWithDefault(defaultTokenName, "FLEET_TOKEN_NAME")
for _, key := range keys {
- name := strings.TrimSpace(strings.Replace(key.Name, ... | [Executable,LookupEnv,Exit,IsNotExist,Stat,New,Start,NewClientWithConfig,Errorf,After,Wait,TrimSpace,ToLower,Runes,AgentConfigFile,TrimLeft,Command,Fprintf,Sprintf,Request,Unmarshal,Replace,Parse] | findPolicy returns a new kibana API key object based on the environment variables FLE range returns the value of a key in the system environment or the value of a key in. | can it be that there will be trailing/leading space after replace as these were removed before |
@@ -270,7 +270,7 @@ class Vtk(CMakePackage):
cmake_args.append('-DVTK_RENDERING_BACKEND:STRING=' + opengl_ver)
- if spec.satisfies('@:8.1.0'):
+ if spec.satisfies('@:8.1.0') and '~osmesa' in spec:
cmake_args.append('-DVTK_USE_SYSTEM_GLEW:BOOL=ON')
if '+osmesa' in spec:... | [Vtk->[url_for_version->[up_to,format],setup_build_environment->[set],cmake_args->[satisfies,append,Version,spec,extend,format,join],depends_on,extends,conflicts,version,patch,variant]] | Returns a list of arguments for the CakeScript that will run the given object. Enable or disable a specific . Add optional arguments to the command line for the . Check if a node - specific flag is set and if so add it to the arguments list Adds flags to cmake_args if missing. | That is fine. Seems we are moving from using spack packges toward using internal ones. |
@@ -7,7 +7,6 @@ class EncryptedAttribute
key ||= env.attribute_encryption_key
cost ||= env.attribute_cost
new_key = load_or_build_user_access_key(cost: cost, key: key).dup
- new_key.random_r = Pii::Cipher.random_key
new_key
end
| [EncryptedAttribute->[try_decrypt->[new_user_access_key,decrypt],try_decrypt_with_uak->[decrypt],try_decrypt_with_all_keys->[try_decrypt],fingerprint->[fingerprint],old_keys->[old_keys]]] | Creates a new user access key object. | was this just unnecessary because `random_r` was already being set? |
@@ -111,12 +111,14 @@ public final class TableElements implements Iterable<TableElement> {
private void throwOnDuplicateNames() {
final String duplicates = elements.stream()
- .collect(Collectors.groupingBy(TableElement::getName, Collectors.counting()))
+ .collect(Collectors.groupingBy(
+ ... | [TableElements->[of->[TableElements],stream->[stream],equals->[equals],toString->[toString],iterator->[iterator]]] | Throw on duplicate column names. | This wouldn't be needed if `ColumnName` took the new source name into account. |
@@ -31,6 +31,11 @@ class PantsRunner(object):
self._env = env or os.environ
self._start_time = start_time
+ def _enable_rust_logging(self, global_bootstrap_options):
+ levelname = global_bootstrap_options.level.upper()
+ init_rust_logger(levelname)
+ setup_logging_to_stderr(logging.getLogger(None)... | [PantsRunner->[run->[create,reset_log_location,RemotePantsRunner,reset_exiter,set_start_time,for_global_scope,format,warn,run,reset_should_print_backtrace_to_terminal]],getLogger] | Initializes the object with the given arguments and environment. | It looks like `init_rust_logger` is only ever followed by `setup_logging_to_stderr`... would it be useful to merge the methods? |
@@ -18,8 +18,9 @@ import shutil
from pathlib import Path
ArgContext = collections.namedtuple('ArgContext',
- ['source_dir', 'test_data_dir', 'dl_dir', 'model_info', 'data_sequences', 'data_sequence_dir'])
+ ['omz_dir', 'source_dir', 'test_data_dir', 'dl_dir', 'model_info', 'data_sequences', 'data_sequence_dir... | [image_retrieval_arg->[TestDataArg],DataDirectoryOrigFileNamesArg->[resolve->[resolve]],image_net_arg->[TestDataArg],DataPatternArg->[resolve->[resolve]],brats_arg->[TestDataArg],DataDirectoryArg->[resolve->[resolve],__init__->[DataPatternArg]]] | Initialize a MissingNodeException with a relative path. | This is unnecessary now. |
@@ -12,7 +12,8 @@ class CarControllerParams:
def __init__(self, CP):
if CP.carFingerprint in [CAR.SONATA, CAR.PALISADE, CAR.SANTA_FE, CAR.VELOSTER, CAR.GENESIS_G70,
CAR.IONIQ_EV_2020, CAR.KIA_CEED, CAR.KIA_SELTOS, CAR.ELANTRA_2021,
- CAR.ELANTRA_HEV_2021... | [dbc_dict,set] | Initialize the object with the values of the car fingerprint. | seems like all new cars should go here. want to submit a PR to blacklist the 255 cars? |
@@ -305,9 +305,6 @@ public final class ProPurchaseUtils {
final Territory t, final Map<Territory, ProPurchaseTerritory> purchaseTerritories) {
final List<Unit> placeUnits = new ArrayList<>();
- if (purchaseTerritories == null) {
- return placeUnits;
- }
for (final ProPurchaseTerritory purc... | [ProPurchaseUtils->[getPlaceUnits->[getPlaceUnits]]] | Get the place units of the territory. | This null check was needless? |
@@ -1661,8 +1661,8 @@ namespace Js
simdFunctions[AsmJsSIMDBuiltin_int8x16_not] = SIMDFunc(PropertyIds::not, Anew(&mAllocator, AsmJsSIMDFunction, nullptr, &mAllocator, 1, AsmJsSIMDBuiltin_int8x16_not, OpCodeAsmJs::Simd128_Not_I16, AsmJsRetType::Int8x16, AsmJsType::Int8x16));
simdFunctio... | [No CFG could be retrieved] | Registers functions that perform simple inter - precision conversions. Registers a function that simulates the logic of the comparison of two integer properties. | Does this conflict with #934? |
@@ -77,6 +77,8 @@ type Beat struct {
Config beatConfig
RawConfig *common.Config // Raw config that can be unpacked to get Beat specific config data.
+ Mapping mapping.Supporter // Get all fields of the Beat
+
keystore keystore.Keystore
index idxmgmt.Supporter
| [launch->[InitWithSettings,createBeater],TestConfig->[InitWithSettings,createBeater],Setup->[InitWithSettings,Setup,createBeater],indexSetupCallback->[Setup],createBeater->[BeatConfig],configure->[BeatConfig],Init->[InitWithSettings]] | JS - Beat provides a runnable and configurable instance of a beat. Config for the Central Component configuration. | I so wish I hadn't named it 'Supporter' :) |
@@ -109,10 +109,7 @@ func (tx *AddMemberTx) createInvite(uv keybase1.UserVersion, role keybase1.TeamR
payload.Admins = appendToInviteList(invite, payload.Admins)
case keybase1.TeamRole_OWNER:
payload.Owners = appendToInviteList(invite, payload.Owners)
- default:
- return fmt.Errorf("Unexpected role: %v", role)... | [CompleteSocialInvitesFor->[findChangeReqForUV],ReAddMemberToImplicitTeam->[sweepCryptoMembers,createInvite,sweepKeybaseInvites,addMember,completeAllKeybaseInvitesForUID],AddMemberBySBS->[sweepKeybaseInvites,addMember,sweepCryptoMembersOlderThan,CompleteInviteByID],removeMember->[changeMembershipPayload],sweepCryptoMem... | createInvite creates an invite to the given user version and role. | Still too scary. Can it just return error in a `default` case here? |
@@ -196,6 +196,12 @@ class BaseMutation(graphene.Mutation):
)
return instances
+ @classmethod
+ def get_duplicates_ids(cls, add_nodes, remove_nodes):
+ if add_nodes and remove_nodes:
+ return set(add_nodes) & set(remove_nodes)
+ return []
+
@classmethod
d... | [BaseMutation->[mutate->[check_permissions],__init_subclass_with_meta__->[get_error_fields],handle_errors->[validation_error_to_error_type],get_node_or_error->[get_node_by_pk]],BaseBulkMutation->[mutate->[handle_errors,perform_mutation,check_permissions],__init_subclass_with_meta__->[ModelMutationOptions],perform_mutat... | Get nodes or error. | I see two small things to improve here: - it's rather a utility function, it just checks two lists for common elements so I think it should be moved to some utils module, e.g. `graphql/core/utils` - let's add a docstring e.g. "Return items that appear on both provided lists." |
@@ -743,9 +743,12 @@ class ICA(object):
data *= pre_whitener
else: # pick cov
ncov = deepcopy(self.noise_cov)
- if ncov.ch_names != self.ch_names:
- ncov['data'] = ncov.data[picks][:, picks]
- assert data.shape[0] == ncov.data.shape[0]
+ ... | [ICA->[pick_sources_epochs->[_get_sources_epochs],plot_sources_epochs->[get_sources_epochs],pick_sources_raw->[_get_sources_raw],plot_sources_raw->[get_sources_raw],export_sources->[get_sources_raw],find_sources_epochs->[get_sources_epochs],find_sources_raw->[get_sources_raw]],_make_xy_sfunc] | Helper function to compute the pre - whiten noise covariance. | it's common not to mark bad channels in the noise cov and to rely on the data bads to remove the proper lines and columns in the noise cov but based on channel names. I think it would be much more robust. Basically I would take from the noise cov the channels present in the data and raise an error if one data channel i... |
@@ -2236,10 +2236,14 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase,
this->bringToFront(m_tooltip_element);
setStaticText(m_tooltip_element, tooltip_text.c_str());
s32 tooltip_width = m_tooltip_element->getTextWidth() + m_btn_height;
-#if IRRLICHT_VERSION_MAJOR <= 1 && IRRLICHT_VERSIO... | [No CFG could be retrieved] | Draw item stack and tooltip Draws the tooltip. | `MINOR` appears twice, should be `#if IRRLICHT_VERSION_MAJOR * 10000 + IRRLICHT_VERSION_MINOR * 100 + IRRLICHT_VERSION_REVISION >= 10802` ? |
@@ -65,7 +65,7 @@ def watcher_factory(conf):
try:
return WATCHER_TYPES[w_type][db_type]
except KeyError:
- return None
+ raise InvalidConfigError('invalid water config')
class GaugePortStateLogger(GaugePortStatePoller):
| [GaugePortStatsLogger->[_dp_stat_name->[port_labels,join]],GaugeMeterStatsLogger->[_format_stat_pairs->[_format_stats],_dp_stat_name->[str,join]],GaugeFlowTableLogger->[_update->[write,to_jsondict,format,join,dumps,open,_rcv_time]],GaugePortStateLogger->[_update->[write,_rcv_time,join,info,open,dpid_log]]] | Return a Gauge object based on type. | F821 undefined name 'InvalidConfigError' |
@@ -175,6 +175,7 @@ def find(parser, args):
tty.msg('No root specs')
else:
tty.msg('Root specs')
+ # TODO: Change this to not print extraneous deps and variants
display_specs(
env.user_specs, args,
decorator=lambda s, f: color.... | [find->[query_arguments,setup_env],setup_env->[strip_build]] | Find a package by name. | What specs/variants count as extraneous? |
@@ -58,8 +58,8 @@ def get_display_price(
def quantize_price(
- price: Union["TaxedMoney", "Money", "Decimal", "TaxedMoneyRange"], currency
-):
+ price: Union["TaxedMoney", "Money", "Decimal", "TaxedMoneyRange"], currency: str
+) -> Union["TaxedMoney", "Money", "Decimal", "TaxedMoneyRange"]:
precision = ... | [get_display_price->[display_gross_prices],zero_taxed_money->[zero_money]] | Quantize price by the number of places specified in the nanoseconds. | We could define a type for this case. What about `T_MoneyLike = Union["TaxedMoney", "Money", "Decimal", "TaxedMoneyRange"]` |
@@ -172,6 +172,18 @@ public abstract class MetricReportReporter extends ScheduledReporter {
}
}
+ @Override
+ protected void report(SortedMap<String, Gauge> gauges, SortedMap<String, Counter> counters,
+ SortedMap<String, Histogram> histograms, SortedMap<String, Meter> meters, SortedMap<String, Timer> ... | [MetricReportReporter->[close->[close],Builder->[convertDurationsTo->[self],convertRatesTo->[self],withTags->[self],filter->[self],withTag->[self]]]] | Creates a new object with the given tags. This method serializes all the Counters histograms and meters. | You can use `Boolean.TRUE` to avoid the boxing. |
@@ -68,7 +68,7 @@ namespace System.Security.AccessControl
public GenericAce Current
{
- get { return ((IEnumerator)this).Current as GenericAce; }
+ get { return (((IEnumerator)this).Current as GenericAce)!; }
}
public bool MoveNext()
| [RawAcl->[SetBinaryForm->[VerifyHeader],GetBinaryForm->[MarshalHeader,GetBinaryForm],SetBinaryForm],SystemAcl->[RemoveAudit->[RemoveAudit,RemoveQualifiedAces],RemoveAuditSpecific->[RemoveAuditSpecific,RemoveQualifiedAcesSpecific],AddAudit->[AddQualifiedAce,AddAudit,CheckFlags],SetAudit->[SetAudit,SetQualifiedAce,CheckF... | Moves the next in the list. | Why did you use ! here, but a hard cast on GetEnumerator? Seems like changing as-cast to hard-cast would make this look nicer. |
@@ -1,8 +1,10 @@
# Copyright 2015 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).
+import importlib
import inspect
-from typing import Dict, Optional, Tuple, Type, TypeVar, Union, cast
+import logging
+from typing import Callable, Dict, Iterable, Li... | [Subsystem->[_instance_for_scope->[UninitializedSubsystemError]]] | Creates a new object. Checks if the object is a subclass of the class. | @cosmicexplorer @blorente what should this be? I think we don't want to use the logging library directly anymore, but don't remember why or what to do instead? Something about Rust doing the logging? |
@@ -94,6 +94,9 @@ class World:
def get_basic_types(self) -> Set[Type]:
raise NotImplementedError
+ def get_valid_starting_types(self) -> Set[Type]:
+ raise NotImplementedError
+
def parse_logical_form(self, logical_form: str) -> Expression:
"""
Takes a logical form as a ... | [World->[get_valid_actions->[get_name_mapping,get_valid_actions,get_type_signatures],all_possible_actions->[get_valid_actions],_process_nested_expression->[_process_nested_expression],_get_transitions->[_get_transitions]]] | Returns a set of basic types that can be used to generate a type. | Looks like this method and the two above it need docstrings. |
@@ -709,8 +709,8 @@ func (display *ProgressDisplay) processEndSteps() {
}
}
- // If we get stack outputs, display them at the end.
- if display.stackUrn != "" {
+ // If we get stack outputs and there weren't any errors, display them at the end.
+ if display.stackUrn != "" && !sawError {
stackStep := display.e... | [filterOutUnnecessaryNodesAndSetDisplayTimes->[filterOutUnnecessaryNodesAndSetDisplayTimes],processEvents->[processNormalEvent,processEndSteps,processTick],processEndSteps->[refreshAllRowsIfInTerminal,writeSimpleMessage,refreshSingleRow,writeBlankLine],handleSystemEvent->[refreshAllRowsIfInTerminal,writeSimpleMessage],... | processEndSteps is called when the end of the processing of the progress steps. This function is called to display the error message and the stack outputs of the resource. | it's worthwhile in cases like this to explain the 'why' not the what. i.e. why would we not want to show the error. |
@@ -491,6 +491,9 @@ func (h *Server) NewConversationLocal(ctx context.Context, arg chat1.NewConversa
IdentifyBehavior: arg.IdentifyBehavior,
}
if arg.TopicName != nil {
+ if arg.MembersType == chat1.ConversationMembersType_KBFS {
+ return chat1.NewConversationLocalRes{}, errors.New("Cannot set topic name for ... | [GetThreadNonblock->[handleOfflineError,getChatUI],UpdateTyping->[remoteClient,assertLoggedIn],deleteAssets->[remoteClient],downloadAttachmentLocal->[getChatUI],DownloadFileAttachmentLocal->[handleOfflineError],Sign->[remoteClient],isOfflineError->[isOfflineError],postAttachmentLocalInOrder->[PostLocal,PostDeleteNonblo... | NewConversationLocal implements keybase. NewConversationLocal. find a conversation. If there is only one conversation return it. Otherwise return it. This is a helper function that is called from the ncr. | Why is this here? |
@@ -51,6 +51,10 @@ import org.junit.runners.Parameterized;
public class SchemaGeneratorTestCase extends AbstractMuleTestCase
{
+ @Parameterized.Parameter(0)
+ public Class<?> extensionUnderTest;
+ @Parameterized.Parameter(1)
+ public String expectedXSD;
private SchemaGenerator generator;
priva... | [SchemaGeneratorTestCase->[generate->[describe,createFrom,DefaultDescribingContext,toString,StringBuilder,setIgnoreWhitespace,identical,compareXML,getResourceAsString,setIgnoreComments,generate,setIgnoreAttributeOrder,append,println,similar,format,assertEquals,getAllDifferences,DetailedDiff,getName,setNormalizeWhitespa... | Gets the data of the missing missing - extension types. | add separation line when fields are annotated. That helps readability quite a bit |
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
-using System.Runtime.Versioning;
-
namespace System.Net
{
public class HttpListenerTimeoutManager
| [HttpListenerTimeoutManager->[ValidateTimeout->[ToInt64,MaxValue,TotalSeconds,nameof],MaxValue,Zero,ValidateTimeout,nameof]] | Creates a timeout manager that can be used to manage timeouts on a connection. Validate timeout. | It looks like this needs to be restored since we have windows-specific API annotations below. |
@@ -237,7 +237,7 @@ class CLITest(unittest.TestCase): # pylint: disable=too-many-public-methods
with mock.patch("letsencrypt.cli._init_le_client") as mock_init:
with mock.patch("letsencrypt.cli._auth_from_domains"):
self._call(["certonly", "--manual", "-d", "foo.bar"])
- ... | [DetermineAccountTest->[test_no_accounts_email->[_call],test_single_account->[_call],test_no_accounts_no_email->[_call],test_args_account_set->[_call],test_multiple_accounts->[_call]],CLITest->[test_certonly_csr->[_call],test_plugins_no_args->[_call],test_configurator_selection->[_call,_cli_missing_flag],test_certonly_... | Test if the configuration of the plugin is available. Test if a sequence number is not null. | nit: The names of the two unused variables should the idiomatic `_` or prefixed with `unused`. |
@@ -500,7 +500,6 @@ void
ds_pool_get(struct ds_pool *pool)
{
D_ASSERT(pool != NULL);
- D_ASSERT(dss_get_module_info()->dmi_xs_id == 0);
daos_lru_ref_add(&pool->sp_entry);
}
| [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - function to handle the release of a node from the pool. | It's important to keep this assert, this function is designed for xstream 0 only. I don't think the ds_pool reference counting is thread safe. |
@@ -47,12 +47,12 @@ public class TimestampSpec
private final String timestampColumn;
private final String timestampFormat;
- private final Function<Object, DateTime> timestampConverter;
// this value should never be set for production data
private final DateTime missingValue;
+ private final transient F... | [TimestampSpec->[equals->[equals],hashCode->[hashCode],mergeTimestampSpec->[equals],parseDateTime->[ParseCtx],ParseCtx]] | PUBLIC METHODS This class is used to create a TimestampSpec object from a JSON - formatted Gets the missingValue from the given missing - value object. | I thought transient just marks fields that shouldn't be serialized. But this class isn't Serializable, so what's the point? |
@@ -243,7 +243,6 @@ func resourceAwsDefaultNetworkAclUpdate(d *schema.ResourceData, meta interface{}
func resourceAwsDefaultNetworkAclDelete(d *schema.ResourceData, meta interface{}) error {
log.Printf("[WARN] Cannot destroy Default Network ACL. Terraform will remove this resource from the state file, however reso... | [Printf,Difference,GetChange,SetPartial,Partial,HasChange,ReplaceNetworkAclAssociation,DeleteNetworkAclEntry,List,Id,String,Errorf,SetId,Get,DescribeNetworkAcls] | This function is used to revoke all ingress and egress rules that the Default Network ACL is region NetworkACL. | I wonder if this is an issue that should be opened on core to have "no delete" resources? |
@@ -234,7 +234,11 @@ class CoreferenceResolver(Model):
# (num_spans_to_keep, max_antecedents),
# (1, max_antecedents),
# (1, num_spans_to_keep, max_antecedents)
- valid_antecedent_indices, valid_antecedent_offsets, valid_antecedent_log_mask = self._generate_valid_antecedents( # noqa
+... | [CoreferenceResolver->[forward->[,_compute_span_pair_embeddings,size,max,_endpoint_span_extractor,_lexical_dropout,_text_field_embedder,_attentive_span_extractor,_context_layer,int,_mention_pruner,logsumexp,min,get_device_of,_mention_recall,cat,flatten_and_batch_shift_indices,masked_log_softmax,log,get_text_field_mask,... | Forward computation of . A scalar loss to be optimised. This function is called by the base class when it is called to get the embeddings of The base implementation of the which_seq_filter method. Compute the loss of a single base - cluster antecedent. | Can you revert this file also? And all of the ones below here that aren't actually intended to be changed by this PR. |
@@ -353,6 +353,8 @@ func (repo *Repository) innerAPIFormat(e Engine, mode AccessMode, isParent bool)
repo.mustOwner(e)
+ numReleases, _ := GetReleaseCountByRepoID(repo.ID, FindReleasesOptions{IncludeDrafts: false, IncludeTags: true})
+
return &api.Repository{
ID: repo.ID,
Owner: ... | [updateSize->[RepoPath],UpdateSize->[updateSize],Link->[FullName],getTemplateRepo->[IsGenerated],DescriptionHTML->[Error,ComposeMetas,HTMLURL],mustOwner->[getOwner,Error],APIURL->[FullName],UploadAvatar->[CustomAvatarPath],generateRandomAvatar->[CustomAvatarPath],CloneLink->[cloneLink],GetAssignees->[getAssignees],RelL... | innerAPIFormat returns a new Repository with all fields populated. Returns a copy of the repository with all of its properties initialized. The object returned by the hasWiki method is a wrapper around the object returned by the external. | same way as UI calc it |
@@ -148,6 +148,13 @@ func BuildKubernetesNodeConfig(options configapi.NodeConfig) (*NodeConfig, error
server.CPUCFSQuota = true // enable cpu cfs quota enforcement by default
server.MaxPods = 110
+ switch server.NetworkPluginName {
+ case ovs.SingleTenantPluginName(), ovs.MultiTenantPluginName():
+ // set defaul... | [Warningf,Duration,NewKubeletAuth,Info,Atoi,ParseDuration,SecureTLSConfig,SplitHostPort,New,FromUnversionedClient,Env,UseTLS,Errorf,GetNamedCertificateMap,CertPoolFromFile,GetKubeClient,AnonymousClientConfig,UnsecuredKubeletConfig,Join,CanSupport,Infof,NewKubeletServer,NewAggregate,V,ParseIP,NewDefaultImageTemplate,Exp... | Initialize a new Server object proxyconfig returns the k8s proxy config and the error if any. | changes reviewed by @dcbw / @danwinship |
@@ -573,11 +573,6 @@ class JvmCompile(NailgunTaskBase):
classes_by_src[None] = list(unclaimed_classes)
return classes_by_src_by_context
- def classname_for_classfile(self, compile_context, class_file_name):
- assert class_file_name.startswith(compile_context.classes_dir)
- rel_classfile_path = clas... | [JvmCompile->[_check_unused_deps->[joined_dep_msg],_register_vts->[compute_classes_by_source],_compile_context->[_analysis_for_target,_portable_analysis_for_target],_fingerprint_strategy->[ResolvedJarAwareTaskIdentityFingerprintStrategy],do_compile->[execute],__init__->[size_estimator_by_name,compiler_plugin_types,crea... | Compute a map of ( context - > class - > list of classes for each source. Register all VTS in the compiler. | Is this not needed anywhere? |
@@ -28,14 +28,13 @@ import (
"runtime"
"sync"
- "github.com/satori/go.uuid"
- "github.com/urso/ucfg"
-
"github.com/elastic/beats/libbeat/cfgfile"
+ "github.com/elastic/beats/libbeat/common"
"github.com/elastic/beats/libbeat/filter"
"github.com/elastic/beats/libbeat/logp"
"github.com/elastic/beats/libbeat/... | [setState->[Lock,Unlock],Exit->[Do,Info],LoadConfig->[GOMAXPROCS,Init,New,Client,SetStderr,Errorf,Read,RegisterFilter,Info,Debug],Stop->[setState,Stop,getState,Cleanup,Info,Err],getState->[Lock,Unlock],Start->[setState,LoadConfig,Errorf,CommandLineSetup,Run,Config],CommandLineSetup->[Printf,HandleFlags,Parse,Errorf,Cha... | The basic environment for a single beat. Handle the flags of a single beat. | We should probably write down what rule we are following here. So far I tried to do: - go shipped packages - external packages from any source - internal packages WDYT? |
@@ -130,6 +130,13 @@ public interface MetadataStorageActionHandler<EntryType, StatusType, LogType, Lo
*/
void removeLock(long lockId);
+ /**
+ * Remove the tasks created order than the given createdTime.
+ *
+ * @param createdTime datetime to check the {@code created_date} of tasks
+ */
+ void remove... | [No CFG could be retrieved] | Remove a lock from the lock list. | maybe change to `void removeTasksOlderThan(long timestamp)` to keep consistent with TaskLogKiller#killOlderThan. |
@@ -4,8 +4,9 @@ class CreateLevels < ActiveRecord::Migration[6.0]
t.belongs_to :rubric_criterion, foreign_key: true, null: false
t.string :name, null: false
t.integer :number, null: false
- t.string :description, null: false
+ t.text :description, null: false
t.float :mark, null: f... | [CreateLevels->[change->[belongs_to,string,integer,create_table,float,timestamps]]] | Creates the change_nakagree table. | In general you shouldn't make changes to an existing migration, but also you shouldn't make changes to a migration without also committing the new `schema.rb` file. In this particular case, I'd say that you don't need to make these changes here, and instead should revert them and focus on the `Level` model file. |
@@ -25,6 +25,12 @@ class PrepareResources(Task):
super(PrepareResources, cls).register_options(register)
register('--confs', advanced=True, type=Options.list, default=['default'],
help='Prepare resources for these Ivy confs.')
+ register('--resources-dir-patterns-for-jarring', advanced=True, ... | [PrepareResources->[execute->[compute_target_dir]]] | Register options for PrepareResources. | shouldn't the default be the resource value? |
@@ -140,6 +140,7 @@ func waitForRouteToRespond(ns, execPodName, proto, host, abspath, ipaddr string,
cmd := fmt.Sprintf(`
set -e
for i in $(seq 1 %d); do
+ rc=0
code=$( curl -k -s -o /dev/null -w '%%{http_code}\n' --resolve %s:%d:%s %q ) || rc=$?
if [[ "${rc:-0}" -eq 0 ]]; then
echo $code
| [CurrentGinkgoTestDescription,By,FindRouterImage,CoreV1,Expect,HaveOccurred,FixturePath,Delete,RouteV1,It,Routes,NewForConfigOrDie,Args,AsAdmin,DumpPodLogsStartingWith,Poll,AdminKubeClient,Errorf,Namespace,Skip,TrimSpace,KubeFramework,NewDeleteOptions,Execute,NewCLI,AdminConfig,BeforeEach,Get,Split,NotTo,Pods,RunHostCm... | waitForRouteToRespond waits for a route to respond to. | nit: If we are defaulting the value this can just be `$rc`. |
@@ -183,9 +183,9 @@ class GradeEntryForm < Assessment
end
end
end
- Grade.import updated_grades,
- on_duplicate_key_update: { conflict_target: [:grade_entry_item_id, :grade_entry_student_id],
- columns: [:grade] }
+
+ Grade.upsert_all... | [GradeEntryForm->[calculate_total_percent->[max_mark],export_as_csv->[max_mark]]] | Parse the grades data and update the grades_data attribute if the user has missing any grades Updates the grade entry items and the student s grades based on the names of the grades and. | Style/MultilineIfModifier: Favor a normal unless-statement over a modifier clause in a multiline statement. |
@@ -26,7 +26,7 @@ func NewStore(secure bool, maxAgeSeconds int, secrets ...string) Store {
func (s store) Get(req *http.Request, name string) (Session, error) {
session, err := s.store.Get(req, name)
- if err != nil && err.Error() == securecookie.ErrMacInvalid.Error() {
+ if err.Error() == securecookie.ErrMacInval... | [Get->[Get,Error],Wrap->[ClearHandler],Save->[Save],NewCookieStore] | Get returns a session with the given name. | `err.Error()` can (but doesn't always) panic depending on how the particular `error` was written to handle `nil` method receivers. |
@@ -70,15 +70,15 @@ public class EventReceiverFirehoseTestClient
*
* @return
*/
- public int postEvents(Collection<Map<String, Object>> events)
+ public int postEvents(Collection<Map<String, Object>> events, ObjectMapper objectMapper, String mediaType)
{
try {
StatusResponseHolder response ... | [EventReceiverFirehoseTestClient->[postEventsFromFile->[postEvents],postEvents->[getURL]]] | POST events to the service. | Should this be try with resources? I don't see the reader closed |
@@ -17,11 +17,7 @@ namespace System.Data.Odbc
internal SQLLEN(long value)
{
-#if WIN32
- _value = new IntPtr(checked((int)value));
-#else
_value = new IntPtr(value);
-#endif
}
internal SQLLEN(IntPtr value)
| [SQLLEN->[ToInt64->[ToInt64]],OdbcStatementHandle->[Statistics->[Statistics]]] | Creates a new ODBCStatementHandle object that wraps a handle to a column of type int This function binds a column in the table. | IntPtr's ctor will throw if _value_ is out of range given the current runtime. It's the same exception type the _checked_ keyword would've produced. We're still depending on this behavior. |
@@ -134,6 +134,11 @@ class FileBasedSource(iobase.BoundedSource):
finally:
pool.terminate()
+ def validate(self):
+ """Validate if there are actual files in the specified glob pattern
+ """
+ return len(fileio.ChannelFactory.glob(self._pattern)) > 0
+
def split(
self, desired_bundl... | [FileBasedSource->[estimate_size->[_get_concat_source],split->[_get_concat_source],get_range_tracker->[_get_concat_source],default_output_coder->[_get_concat_source],read->[_get_concat_source]],_SingleFileSource->[split->[_SingleFileSource],read->[read_records]]] | Estimate the sizes of the specified file names in parallel. | Please change to '_validate(self)' |
@@ -139,6 +139,10 @@ func doGitInitTestRepository(dstPath string) func(*testing.T) {
return func(t *testing.T) {
// Init repository in dstPath
assert.NoError(t, git.InitRepository(dstPath, false))
+ repo, err := git.OpenRepository(dstPath)
+ assert.NoError(t, err)
+ assert.NoError(t, repo.SetDefaultBranch("m... | [RemoveAll,CloneWithArgs,Now,MkdirTemp,JoinHostPort,Setenv,False,Clone,WriteFile,Itoa,Error,AddChanges,Join,GenKeyPair,Contains,User,Shutdown,NewCommand,NoError,RunInDir,InitRepository,Serve,NewCommandNoGlobals,Listen,CommitChanges,WithTimeout,Sprintf,Background,Chmod,Addr,String,Parse,Sleep,True,IsExist] | onGiteaRunTB is the entry point for the Gitea test. doGitAddRemote doGitAddRepository doGitPushTestRepository doGitPushTestRepository. | We need `repo.Close()` here. |
@@ -10,9 +10,9 @@
<span class='h6'>
<%= t('instructions.password.strength.intro') %>
</span>
- <span id='pw-strength-txt' class='bold' data-forbidden-passwords='<%= @forbidden_passwords %>'>
- ...
- </span>
+ <%= tag.span '...', id: 'pw-strength-txt', class: 'bold', data: {
... | [No CFG could be retrieved] | Outputs a list of all possible n - node nodes. | is it worth adding a view spec for this partial as a regression spec to make sure this continues to be encoded correctly? |
@@ -193,9 +193,9 @@ public class HistoryLog extends JFrame {
while (nodeEnum.hasMoreElements()) {
final HistoryNode node = (HistoryNode) nodeEnum.nextElement();
final String title = node.getTitle();
- String indent = "";
+ StringBuilder indent = new StringBuilder();
for (... | [HistoryLog->[printRemainingTurn->[toString,getPlayerId],printTerritorySummary->[printTerritorySummary,toString,getPlayerId],getProduction->[getProduction],getPlayerId->[getPlayerId],toString->[toString],printProductionSummary->[toString],printDiceStatistics->[toString]]] | Print remaining turn. private boolean moving = false ; check if the object is a known object and if so show it. check if the caveat is missing check for unknown node type. | Another `final` candidate. |
@@ -153,11 +153,7 @@ class ProductTranslatableContent(CountableDjangoObjectType):
@staticmethod
def resolve_product(root: product_models.Product, info):
- return (
- product_models.Product.objects.visible_to_user(info.context.user)
- .filter(pk=root.id)
- .first()
- ... | [MenuItemTranslatableContent->[TranslationField,Field],CollectionTranslatableContent->[resolve_collection->[visible_to_user],TranslationField,Field],CategoryTranslatableContent->[TranslationField,Field],SaleTranslatableContent->[permission_required,TranslationField,Field],BaseTranslationType->[resolve_language->[Langua... | Resolve product by user. | The same here. Just return `root`? |
@@ -138,6 +138,18 @@ public abstract class AbstractReplyProducingMessageHandler extends AbstractMessa
protected abstract Object handleRequestMessage(Message<?> requestMessage);
+ /**
+ * An implementation of this interface is used to wrap the
+ * {@link AbstractReplyProducingMessageHandler#handleRequestMessage(... | [AbstractReplyProducingMessageHandler->[onInit->[onInit],AdvisedRequestHandler->[toString->[toString],handleRequestMessage->[handleRequestMessage]]]] | This method is called by the client to handle a request message. | I know what confused me else. You have a > cherry-pick to 4.2.x phrase in the PR header. But I agree with the original premise that a backport may be postponed for demand. WDYT? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.