patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -51,6 +51,7 @@ void UpdateDemKinematicsProcess::UpdateKinematics(
{
const array_1d<double,3> coordinates = rNode->Coordinates();
const array_1d<double,3> displacement = rNode->FastGetSolutionStepValue(DISPLACEMENT);
+ const array_1d<double,3> delta_displacement = rNode->FastGetSolutionStepValue(DELTA_D... | [UpdateKinematics->[Coordinates,FastGetSolutionStepValue],Execute->[NodesBegin,Nodes,GetGeometry,GetValue,UpdateKinematics]] | Updates the kinematics of the node in the dem node. | Add references if needed to avoid copies |
@@ -803,13 +803,6 @@ tse_task_complete(tse_task_t *task, int ret)
/** update task in scheduler lists. */
if (!dsp->dsp_cancelling && done)
tse_sched_process_complete(dsp);
- /** If another thread canceled, make sure we drop the ref count */
- else if (bumped)
- tse_sched_decref(dsp);
-
- /** -1 from tse_task_cr... | [No CFG could be retrieved] | This function is called from the main thread when a task is complete. It is called from Add a task to be dependent on or dep. | would this work if you actually just remove the else here? the idea was that if someone else cancelled in the middle of completion, we would need to keep it around to finish here. |
@@ -98,7 +98,12 @@ export function invite(
// For each number, dial out. On success, remove the number from
// {@link invitesLeftToSend}.
const phoneInvitePromises = phoneNumbers.map(item => {
- const numberToInvite = item.number;
+ const {
+ dtmf,
+ ... | [No CFG could be retrieved] | Invite a phone number to all the participants or rooms. Invite people and chat rooms. | Maybe store only on successful dial, if the timing works out? If dial fails then does the dtmf remain in the store? |
@@ -111,8 +111,7 @@ def plot_cov(cov, info, exclude=[], colorbar=True, proj=False, show_svd=True,
fig_cov, axes = plt.subplots(1, len(idx_names), squeeze=False,
figsize=(2.5 * len(idx_names), 2.7))
for k, (idx, name, _, _) in enumerate(idx_names):
- axes[0, k].imshow(C... | [plot_ideal_filter->[_get_flim,_check_fscale,adjust_axes,_filter_ticks],plot_filter->[_get_flim,_check_fscale,adjust_axes,_filter_ticks],plot_bem->[_plot_mri_contours]] | Plot the covariance matrix of the noise. Compute the non - zero non - zero non - zero non - zero non - zero non Plot the covariance matrix and the diagonal of the non - zero singular values. | this is a PEP8 violation |
@@ -320,6 +320,17 @@ def test_freeze_git_remote(script, tmpdir):
"""
).format(remote=origin_remote).strip()
_check_output(result.stdout, expected)
+ # check when there are no remotes. Should report local file path.
+ script.run('git', 'remote', 'remove', 'origin', cwd=repo_dir)
+ script.run(... | [test_freeze_exclude_editable->[_check_output],test_freeze_svn->[_check_output],test_freeze_git_clone_srcdir->[_check_output],_check_output->[banner],test_freeze_bazaar_clone->[_check_output],test_freeze_mercurial_clone->[_check_output],test_freeze_with_invalid_names->[_check_output,fake_install],test_freeze_with_requi... | Test freeze a git remote and return path to generated package. Tests freezing a node package. | You'd want to wrap repo_dir with `os.path.normcase` here. |
@@ -4,6 +4,18 @@ class TagUser < ActiveRecord::Base
belongs_to :tag
belongs_to :user
+ scope :notification_level_visible, -> (notification_levels) {
+ joins("LEFT OUTER JOIN tag_group_memberships ON tag_users.tag_id = tag_group_memberships.tag_id")
+ .joins("LEFT OUTER JOIN tag_group_permissions ON tag... | [TagUser->[notification_levels_for->[notification_levels]]] | Returns a function that returns an array of all notification levels for the given user. | This explicit check is required because a tag group can set its permission to only be visible to moderators (2), but the user could be an admin (1) and still be a staff (3), but unable to see the moderators tag groups. |
@@ -23,12 +23,15 @@ import { Router, ActivatedRouteSnapshot, NavigationEnd, NavigationError } from '
import { TranslateService } from '@ngx-translate/core';
<%_ } _%>
+import { AccountService } from 'app/core/auth/account.service';
+
@Component({
selector: '<%= jhiPrefixDashed %>-main',
templateUrl: './m... | [No CFG could be retrieved] | Component which is the main component of the JHipster project. Get pageTitle from route snapshot. | maybe we need to inject it in tests too ? |
@@ -16,7 +16,7 @@
static const ERR_STRING_DATA PKCS12_str_reasons[] = {
{ERR_PACK(ERR_LIB_PKCS12, 0, PKCS12_R_CANT_PACK_STRUCTURE),
- "cant pack structure"},
+ "cannot pack structure"},
{ERR_PACK(ERR_LIB_PKCS12, 0, PKCS12_R_CONTENT_TYPE_NOT_DATA),
"content type not data"},
{ERR_PACK(ERR_LIB... | [ossl_err_load_PKCS12_strings->[ERR_reason_error_string,ERR_load_strings_const],ERR_PACK] | Reads the contents of a nerr. h file and adds error messages to the Find all errors that occur in the given mac. | This needs to be reflected in openssl.txt |
@@ -12,6 +12,13 @@ class ITValidator:
def __call__(self, rest_endpoint, experiment_dir, nni_source_dir, **kwargs):
pass
+class ExportValidator(ITValidator):
+ def __call__(self, rest_endpoint, experiment_dir, nni_source_dir, **kwargs):
+ exp_id = osp.split(experiment_dir)[-1]
+ proc1 = ... | [NnicliValidator->[__call__->[get_experiment_status,print,list_trial_jobs,set_endpoint,get_job_statistics]],MetricsValidator->[__call__->[check_metrics],check_metrics->[print,get_metric_results,get,len,set,join,dumps,open,load],get_metric_results->[intermediate_result,loads,final_result]]] | Check metrics for missing nodes. | suggest to print out the content of csv and json files, so that we can check the result manually on pipeline when necessary. |
@@ -5473,6 +5473,9 @@ print_scan_status(pool_scan_stat_t *ps)
} else if (ps->pss_func == POOL_SCAN_RESILVER) {
(void) printf(gettext("resilver canceled on %s"),
ctime(&end));
+ } else if (ps->pss_func == POOL_SCAN_REBUILD) {
+ (void) printf("rebuild canceled on %s",
+ ctime(&end));
}
retur... | [zpool_do_clear->[usage],list_callback->[print_list_stats],zpool_do_detach->[usage],zpool_do_reopen->[usage],zpool_do_iostat->[usage],zpool_do_split->[print_vdev_tree,usage],zpool_do_add->[print_vdev_tree,usage],zpool_do_create->[print_vdev_tree,usage],zpool_do_online->[usage],zpool_do_export->[usage],main->[usage],zpo... | Print the status of a single block of a scan. DSS - specific functions nicenum - print info about the nics. | This needs to use gettext(). |
@@ -113,11 +113,11 @@ func (g *generator) genNode(w io.Writer, n hcl2.Node) {
g.genResource(w, n)
case *hcl2.OutputVariable:
g.genOutputAssignment(w, n)
- // TODO
- // case *hcl2.ConfigVariable:
- // g.genConfigVariable(w, n)
- // case *hcl2.LocalVariable:
- // g.genLocalVariable(w, n)
+ // TODO
+ // cas... | [genTemps->[Type,Fgenf,argumentTypeName],collectImports->[NewStringSet,Sprintf,Errorf,Packages,Add,DecomposeToken],genResource->[Title,lowerExpression,genTemps,Fgenf,Name,Traverse,DecomposeToken],genNode->[genResource,genOutputAssignment],genPostamble->[Fprint,Fprintf],genOutputAssignment->[lowerExpression,genTemps,Fge... | genNode generates code for a node in the HCL2 file. Fgenf - function for test case. | Nit: please move this closer to its use if it's logically constant. |
@@ -33,10 +33,12 @@ from apache_beam.runners.interactive import interactive_beam as ib
from apache_beam.runners.interactive import interactive_environment as ie
from apache_beam.runners.interactive import pipeline_instrument as instr
from apache_beam.runners.interactive import interactive_runner
+from apache_beam.ru... | [PipelineInstrumentTest->[test_find_out_correct_user_pipeline->[_example_pipeline],test_instrument_example_pipeline_to_write_cache->[_example_pipeline],test_instrument_example_pipeline_to_read_cache->[_example_pipeline,_mock_write_cache,TestReadCacheWireVisitor]]] | Tests for apache_beam. runners. interactive. pipeline_instrument. Assert that the version map is cached. | unintended removal of the space? |
@@ -223,7 +223,7 @@ $tabsql[24] = "SELECT rowid as rowid, code, label, active FROM ".MAIN_DB_PREFI
$tabsql[25] = "SELECT rowid as rowid, code, label, active, module FROM ".MAIN_DB_PREFIX."c_type_container as t WHERE t.entity IN (".getEntity('c_type_container').")";
//$tabsql[26]= "SELECT rowid as rowid, code, l... | [fieldList->[textwithpicto,select_account,selectExpenseRanges,trans,selectExpenseCategories,select_country,select_language,select_region,selectarray,load_tva,load,selectyesno],formconfirm,select_country,fetch_object,order,getCurrencySymbol,initHooks,errno,load,plimit,error,transnoentities,executeHooks,loadLangs,escape,... | This function returns the list of all known column names in the table. DB lookup for format cards. | In the sql instruction to create the table, the field is name "newByMonth" in v14 so we must named it the same way in code. An enhancement can be done to rename it into "newbymonth" (all columns should be lower case), but this means we must also rename the field into database. So this must be done into develop. |
@@ -378,7 +378,7 @@ public class DeltaSync implements Serializable {
// Schedule compaction if needed
if (cfg.isAsyncCompactionEnabled()) {
- scheduledCompactionInstant = writeClient.scheduleCompaction(Option.of(checkpointCommitMetadata));
+ scheduledCompactionInstant = writeClient... | [DeltaSync->[close->[close],registerAvroSchemas->[registerAvroSchemas],syncOnce->[refreshTimeline],startCommit->[startCommit]]] | Writes the records to the sink. Commit the delta stream if necessary. | Seems this was being done so that when compaction is run inline (default), we would get the checkpoints? |
@@ -209,6 +209,13 @@ void RemoteClient::GetNextBlocks (
s16 d_max_gen = std::min(adjustDist(m_max_gen_distance, prop_zoom_fov),
wanted_range);
+ s16 d_max = full_d_max;
+
+ // Don't loop very much at a time
+ s16 max_d_increment_at_time = 2;
+ if (d_max > d_start + max_d_increment_at_time)
+ d_max = d_start + m... | [markBlockposAsNotSent->[SetBlockNotSent],event->[notifyEvent,UpdatePlayerList],UpdatePlayerList->[getClientIDs],isUserLimitReached->[getClientIDs]] | This method is called by the remote client to send the next blocks to the remote player. This is the main entry point for the network. It is used to determine the number of check if any blocks are modified since last sent This function is used to find the nearest - emergefull and nearest - sent nodes in This function i... | This was `full_d_max / 9 + 1` before, why is this different? |
@@ -963,6 +963,16 @@ export class AmpStory extends AMP.BaseElement {
.then(() => this.whenPagesLoaded_(PAGE_LOAD_TIMEOUT_MS))
.then(() => this.markStoryAsLoaded_());
+ // Story is being prerendered: resolve the layoutCallback when the first
+ // page is built. Other pages will only build if the do... | [AmpStory->[onBookendStateUpdate_->[BOOKEND_ACTIVE,setHistoryState],isBrowserSupported->[Boolean,CSS],initializeMediaQueries_->[forEach,getMediaQueryService,onMediaQueryMatch,getAttribute],isStandalone_->[STANDALONE],onUIStateUpdate_->[DESKTOP_PANELS,DESKTOP_FULLBLEED,MOBILE,isExperimentOn],closeOpacityMask_->[dev,togg... | This method is called when the user opens a new story. It will create a new page If the promise is not resolved by the user it will be resolved with a failure to load. | Doesn't this need to be chained off of at least some of the stuff above? Like, if we short circuit here, then the user clicks into the story before the other promises have resolved, won't they enter in a weird state? (For example: consent not initialized, progress bar not built, etc.) |
@@ -833,6 +833,11 @@ def compute_hash(text: str) -> str:
return hashlib.md5(text.encode('utf-8')).hexdigest()
+def compute_module_hash(path: str) -> str:
+ with open(path, 'r') as f:
+ return compute_hash(f.read())
+
+
def write_cache(id: str, path: str, tree: MypyFile,
dependencies... | [is_meta_fresh->[get_stat,log],NodeInfo->[dumps->[dumps]],dump_graph->[dumps,NodeInfo],load_graph->[mark_interface_stale,parse_file,State,has_new_submodules,fix_suppressed_dependencies],strongly_connected_components->[dfs->[dfs],dfs],order_ascc->[order_ascc],State->[parse_file->[parse_file,read_with_python_encoding,wra... | Write a cache file for a given module ID. Get the stat of the next cache entry. Get the next unused interface hash. | That's pretty inefficient -- we read the source code in text mode (using the default encoding) and then `compute_hash()` encodes it back to bytes (using `utf-8`) before hashing. I also believe that we have the module source code already as an attribute in `State` in most cases so there's not even a need to read it from... |
@@ -1195,8 +1195,12 @@ def _is_equal_dict(dicts):
is_equal = []
for d in tests:
k0, v0 = d[0]
- is_equal.append(all(np.all(k == k0) and
- np.all(v == v0) for k, v in d))
+ if isinstance(v0, list) and isinstance(v0[0], dict):
+ for k, v in d:
+ ... | [write_info->[write_meas_info],write_meas_info->[_check_consistency],create_info->[copy,_update_redundant,_check_consistency],_empty_info->[Info,_update_redundant,_check_consistency],Info->[copy->[Info],__repr__->[_summarize_str]],_merge_dict_values->[_check_isinstance,_is_equal_dict,_flatten,_where_isinstance],read_me... | Check if dicts are in the same order. Return a if the values in the data list are not in the nanoseconds. | this will crash if `v0` is an empty list. |
@@ -393,7 +393,7 @@ class H2OEstimator(ModelBase):
:returns: A dict of parameters
"""
out = dict()
- for key, value in self.parms.items():
+ for key, value in self._parms.items():
if deep and isinstance(value, H2OEstimator):
deep_items = list(value.... | [H2OEstimator->[fit->[train],get_params->[get_params]]] | Obtain parameters for this estimator. | apparently `get_params` has **always** been returning the wrong set of params, making it unusable in several sklearn contexts. |
@@ -91,7 +91,7 @@ namespace CoreNodeModels.Input
//If the value field in the slider has a number greater than
//In32.Maxvalue (or MinValue), the value will be changed to Int32.MaxValue (or MinValue)
//The value will be changed, but to update the UI, this property is overridden here.
- ... | [IntegerSlider->[SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],UpdateValueCore->[UpdateValueCore]]] | The base class for the number input data object. This method is overridden to create the appropriate output Ast nodes for the given integer. | ugh, this is an API break, what about introducing a new slider class that inherits from `sliderBase<long>` ? |
@@ -79,6 +79,16 @@ describe PostsController do
let(:user) { log_in(:moderator) }
let(:post) { Fabricate(:post, user: user, post_number: 2) }
+ it 'does not allow to destroy when edit time limit expired' do
+ Guardian.any_instance.stubs(:can_delete_post?).with(post).returns(false)
+ Po... | [post_id,create,let,describe,expects,trash!,it,errors,should,xhr,to,create_post,before,body,should_not,returns,number,let!,with,destroy,never,t,require,types,user,id,post_number,delete,topic_id,twice,context,build,get,add,reload,raise_error,log_in] | can find posts as a moderator raises an error when the user doesn t have permission to see the post. | Shouldn't these two stubs both independently cause a refusal? Make it so that only one of the && clauses are false in each test. |
@@ -245,6 +245,11 @@ class AmpVideo extends AMP.BaseElement {
listen(video, 'ended', () => {
this.element.dispatchCustomEvent(VideoEvents.PAUSE);
});
+ ['durationchange', 'timeupdate', 'seeking'].map(e => {
+ listen(video, e, () => {
+ this.element.dispatchCustomEvent(VideoEvents.TIME_UP... | [No CFG could be retrieved] | Adds video to the video element. Check if the video is supported on the current platform. | Nit: Store the callback as a variable, and call listen 3 times. |
@@ -109,11 +109,13 @@ namespace System
// Windows - Schannel supports alpn from win8.1/2012 R2 and higher.
// Linux - OpenSsl supports alpn from openssl 1.0.2 and higher.
// OSX - SecureTransport doesn't expose alpn APIs. TODO https://github.com/dotnet/runtime/issues/27727
+ public sta... | [PlatformDetection->[Version->[GetType,Invoke,GetMethod,NonPublic,Static],GetDistroVersionString->[GetWindowsProductType,Id,GetDistroInfo,GetWindowsInstallationType,ToString,VersionId],GetIsInContainer->[GetValue,Exists,IsNullOrEmpty],IsLargeArrayNotSupported->[NoOptimization,MaxValue],GetSsl3Support->[GetValue],GetIsR... | Returns true if the system supports the array. Get the distribution version string. | I think you can add `IstvOS` as well here since it will be in the same boat as iOS |
@@ -355,7 +355,7 @@ std::unique_ptr<tools::wallet2> generate_from_json(const std::string& json_file,
return false;
}
- wallet.reset(new tools::wallet2(testnet, restricted));
+ wallet.reset(make_basic(vm, opts).release());
wallet->set_refresh_from_block_height(field_scan_from_height);
try... | [No CFG could be retrieved] | This function creates a new Wallet object from a secret key. This function checks if the view key secret key is valid and generates the view key. | Assignment actually works in this situation; `wallet = make_basic(vm_opts);`. The current version should have identical behavior FWIW. What happens when something is specified on the command line and the JSON file. The JSON file takes precedence ? |
@@ -168,6 +168,7 @@ class TorchAgent(Agent):
# set up the target tensors
ys = None
labels = None
+ y_lens = None
if some_labels_avail:
# randomly select one of the labels to update on (if multiple)
if labels_avail:
| [TorchAgent->[shutdown->[save],save->[save],load->[load],maintain_dialog_history->[parse]]] | Maps a batch of valid observations from an unchecked batch where a valid observation is one that This function creates a batch of the n - tuple of tensors that can be used to compute. | this isn't used, right? |
@@ -244,6 +244,9 @@ var ConvergeHistory = Mapping{
},
"public_ipv4": {
"type": "ip"
+ },
+ "account_id": {
+ "type": "text"
}
}
},
| [No CFG could be retrieved] | - A type of object that can be used to define a specific object in the network Tenant - related functions. | Should we make this a top level field? We could share the id with the tenant_id from azure and call it cloud_id or something for easier querying. |
@@ -23,4 +23,8 @@ class KineticsVideo(VisionDataset):
video, audio, info, video_idx = self.video_clips.get_clip(idx)
label = self.samples[video_idx][1]
- return video, audio, label
+ if self.transform is not None:
+ video = self.transform(video)
+
+ # return video, au... | [KineticsVideo->[__len__->[num_clips],__getitem__->[get_clip],__init__->[list,VideoClips,list_dir,make_dataset,len,sorted,super,range]]] | Get the sample with the given index. | If you are gathering the results, wouldn't you need an index for validation as well? |
@@ -199,8 +199,9 @@ angular.module('zeppelinWebApp').controller('InterpreterCtrl', function($scope,
// Add new property from edit form
var index = _.findIndex($scope.interpreterSettings, { 'id': settingId });
var setting = $scope.interpreterSettings[index];
-
- setting.properties[setting.prope... | [No CFG could be retrieved] | Adding new property from edit form. | could you please fix the indentation? |
@@ -40,8 +40,8 @@ module Admin
end
def bust_link(link)
- if link.starts_with?("https://#{ApplicationConfig['APP_DOMAIN']}")
- link.sub!("https://#{ApplicationConfig['APP_DOMAIN']}",
+ if link.starts_with?(URL.url)
+ link.sub!(URL.url,
"")
end
CacheBus... | [ToolsController->[handle_article_cache->[to_i,bust_article,touch,find],bust_link->[bust,sub!,starts_with?],bust_cache->[redirect_to,message],handle_user_cache->[path,to_i,find,bust_link,touch],handle_dead_path->[bust_link],layout]] | bust_link busts a link if it is a URL or a query string. | Seems the formatting got a bit funky here, the second argument was moved to the next line. |
@@ -58,6 +58,8 @@ def build_argparser():
help="Optional. Required for CPU custom layers. Absolute path to "
"a shared library with the kernels implementations.", type=str,
default=None)
+ args.add_argument('--no_show', action='store_true',
+ ... | [main->[compute_metrics,build_argparser,time_elapsed],main] | Builds an argument parser for the command. Returns the top - level averages of the positions. | `CONTRIBUTING.md` claims it should be `Optional. Do not visualize inference results.` |
@@ -1150,7 +1150,7 @@ define([
entity.corridor = corridor;
corridor.positions = coordinates;
if (defined(polyline)) {
- corridor.material = defined(polyline.material) ? polyline.material.color : Color.WHITE;
+ corridor.material = d... | [No CFG could be retrieved] | Process polygon and walls Get the from a linear ring. | `getValue` requires `time` as its first parameter, if we are 100% sure that `.material.color` will be a constant value (maybe it's impossible to make it time varying with kml?) then we should still use `Iso860.MINIMUM_VALUE` here. @tfili can you check if this is indeed always constant. |
@@ -1000,7 +1000,7 @@ class MainTest(unittest.TestCase): # pylint: disable=too-many-public-methods
mock_rc.return_value = mock_lineage
mock_lineage.configuration = {
'renewalparams': {'authenticator': 'webroot'}}
- with mock.patch('certbot.main.obtain_cert') as moc... | [MakeOrVerifyCoreDirTest->[test_success->[_call]],RunTest->[test_renewal_success->[_call],test_newcert_success->[_call],test_reinstall_success->[_call]],SetupLoggingTest->[test_quiet_mode->[_call],test_defaults->[_call]],ObtainCertTest->[test_find_lineage_for_domains_and_certname->[_call],test_find_lineage_for_domains_... | Test for renewing a certificate. | This should probably be `mock_renew_cert`, although I care less than I do about `afa` because this name is much better. |
@@ -1,4 +1,5 @@
-var _classes = JSON.parse("{\"button\":\"button-21aa4a8\",\"CSS\":\".button-21aa4a8{font-size:12px}\\n\"}");
+/** @enum {string}*/
+var _classes = {"button":"button-21aa4a8"};
/**
* Copyright 2020 The AMP HTML Authors. All Rights Reserved.
| [No CFG could be retrieved] | Create a new object with the button classes and styles defined in the JS. | Are we allowed to use `""` on enum keys? |
@@ -243,8 +243,9 @@ static int basefw_get_large_config(struct comp_dev *dev,
return basefw_hw_config(data_offset, data);
case IPC4_MEMORY_STATE_INFO_GET:
return basefw_mem_state_info(data_offset, data);
- /* TODO: add more support */
case IPC4_DSP_PROPERTIES:
+ return basefw_get_dsp_properties(data_offset, d... | [No CFG could be retrieved] | This function is the base implementation of the get_large_config function. This function is called by the IPC4 framework to set the large config. | @abonislawski I guess this means the data is now complete ? |
@@ -16,6 +16,8 @@ module OpenidConnect
client_id: @authorize_form.client_id,
errors: @authorize_form.errors.messages)
+ return create if already_allowed?
+
render(success ? :index : :error)
end
| [AuthorizationController->[identity_needs_verification?->[identity_not_verified?,loa3_requested?],create->[redirect_to,render,track_event,except,id,submit],authorization_params->[permit],build_authorize_form_from_params->[new],session_params->[delete],load_authorize_form_from_session->[new],destroy->[track_event,client... | This action shows the user if the user is not authorized to access this action. If the. | Do we have to go through the whole `create` action, which will perform validations and link the identity again, or can we redirect directly to `redirect_uri`? |
@@ -91,6 +91,8 @@ namespace System.Reflection.Emit
public override Type? BaseType => m_typeBuilder.BaseType;
+ public override bool IsByRefLike => false;
+
protected override ConstructorInfo? GetConstructorImpl(BindingFlags bindingAttr, Binder? binder,
CallingConventions ca... | [EnumBuilder->[IsDefined->[IsDefined],GetEvents->[GetEvents],GetInterfaces->[GetInterfaces],GetNestedType->[GetNestedType],GetMethods->[GetMethods],GetNestedTypes->[GetNestedTypes],GetFields->[GetFields],GetElementType->[GetElementType],GetMember->[GetMember],SetCustomAttribute->[SetCustomAttribute],CreateType->[Create... | Override GetConstructorImpl to override the default constructor. | Is it the case that all of these throw NotSupportedException today and this PR is just making them return false instead? |
@@ -70,10 +70,6 @@ foreach ($rrd_list as $rrd) {
$rrd_options .= ' VDEF:tot'.$i.'=octets'.$i.',TOTAL';
}
- if ($i) {
- $stack = 'STACK';
- }
-
$rrd_options .= ' AREA:inbits'.$i.'#'.$colour_in.":'".rrdtool_escape($rrd['descr'], 9)."In '$stack";
$rrd_options .= ' GPRINT:inbits'.$i.'... | [No CFG could be retrieved] | Create a string with the RRD options. XML - RRD header for the n - th element. | what about that loose `$stack` here? |
@@ -173,12 +173,10 @@ public class TestPutSQL {
runner.enqueue("INSERT INTO PERSONS_AI".getBytes()); // intentionally wrong syntax
runner.enqueue("INSERT INTO PERSONS_AI (NAME, CODE) VALUES ('Tom', 3)".getBytes());
runner.enqueue("INSERT INTO PERSONS_AI (NAME, CODE) VALUES ('Harry', 44)".getB... | [TestPutSQL->[MockDBCPService->[getConnection->[getConnection]],recreateTable->[getConnection],SQLExceptionService->[getConnection->[getConnection]],testTransactionalFlowFileFilter->[createFragmentedTransactionAttributes,getAttribute]]] | This test fails in middle with bad statement rollback on failure. This method checks if there is a related exception in putSQL. | Should we be asserting something different here? Doesn't seem like we'd need this test otherwise, since we're not running the flow or verifying any results. |
@@ -193,11 +193,15 @@ func (e *RevokeEngine) Run(ctx *Context) error {
var sigsList []libkb.JSONPayload
// Push the per-user-key sig
+
+ // Seqno when the per-user-key will be signed in.
+ var newPukSeqno keybase1.Seqno
if e.G().Env.GetSupportPerUserKey() && addingNewPUK {
sig1, err := libkb.PerUserKeyProofR... | [makeRevokeSig->[SignJSON,String,GetKID,RevokeKeysProof],getDeviceSecretKeys->[GetSecretKeyWithPrompt,GetSupportPerUserKey,G,SecretKeyPromptArg,CheckSecretKey],getPukReceivers->[GetComputedKeyFamily,GetKID,Errorf,GetEncryptionSubkeyForDevice,GetAllActiveDevices],Run->[PostJSON,GetDeviceID,GetSupportPerUserKey,GetUID,Pr... | Run executes the revoke command. This function is called by the user when it is able to decrypt the new puk. This function is called when a user adds a new key. | Do you need to add 1 here? |
@@ -59,7 +59,7 @@ module Dependabot
end
if search_url
details[:search_url] =
- search_url + "?q=#{dependency.name.downcase}&prerelease=true"
+ search_url + "?q=#{dependency.name.downcase}&prerelease=true&semVerLevel=2.0.0"
end
details
... | [UpdateChecker->[RepositoryFinder->[check_repo_response->[fetch,status,include?,raise],get_repo_metadata->[fetch,auth_header_for_token,get,excon_defaults],base_url_from_v3_metadata->[fetch],handle_timeout->[raise],default_repository_details->[downcase],search_url_from_v3_metadata->[fetch],find_dependency_urls->[uniq],k... | Build the base_url and search_url for the v2 or v3 index. | Would this still include semver level 1 releases? |
@@ -380,6 +380,17 @@ def _get_edf_info(fname, stim_channel, annot, annotmap, eog, misc, exclude,
fid.read(32 * nchan).decode() # reserved
assert fid.tell() == header_nbytes
+ if n_records == -1:
+ warn('Unable to read the number of records from the header '
+ '(per... | [read_raw_edf->[RawEDF],_read_ch->[reshape,fromfile],_read_annot->[findall,int,zeros,zip,open,float],_get_edf_info->[_update_redundant,all,any,max,where,warn,RuntimeError,tell,enumerate,info,n_samps,_empty_info,int,dict,min,timegm,zeros,range,list,append,datetime,logical_or,len,read,ravel,isinstance,float,open,zip,inde... | Extract all the information from the EDF + and BDF file. read the n - tuple of n - tuple of channels and return the n - tuple of 24BIT or 16 - bit Figure out what coil type and unit to use for a specific channel. | It probably makes sense to just always do this calculation, and `warn` if `n_records` is missing or there is a mismatch between expected and calculated |
@@ -53,7 +53,9 @@ Map::~Map()
{
WorldObject* obj = *i_worldObjects.begin();
ASSERT(obj->IsWorldObject());
+#ifdef ACORE_DEBUG
LOG_ERROR("maps", "Map::~Map: WorldObject TypeId is not a corpse! (%u)", static_cast<uint8>(obj->GetTypeId()));
+#endif
//ASSERT(obj->GetTypeId() == TYPE... | [No CFG could be retrieved] | includes functions for loading and unloading a single object from the world. Check if a map with the given id gx and gy is already present in the map. | Remove. This is not needed with the new log system |
@@ -187,7 +187,7 @@ class SubmissionCollector < ActiveRecord::Base
#Use the database to communicate to the child to stop, and restart itself
#and manually collect the submission
#The third parameter enables or disables the forking.
- def manually_collect_submission(grouping, rev_num, async=true)
+ def manual... | [SubmissionCollector->[collect_next_submission->[instance,remove_grouping_from_queue],start_collection_process->[instance],manually_collect_submission->[start_collection_process,remove_grouping_from_queue]]] | This method is called by the child process when it is able to collect a specific from. | Line is too long. [84/80]<br>Surrounding space missing in default value assignment. |
@@ -625,7 +625,7 @@ public final class InvokeHTTP extends AbstractProcessor {
final DigestAuthenticator digestAuthenticator = new DigestAuthenticator(credentials);
if(!proxyUsername.isEmpty()) {
- final String proxyPassword = context.getProperty(PROP_PROXY_PASSWORD).getValue()... | [InvokeHTTP->[convertAttributesFromHeaders->[csv],OverrideHostnameVerifier->[verify->[verify]]]] | Add the authenticator to the OkHttpClient. | This precludes the use of "plain-text" passwords with valid EL inside them, but I think it's getting more standard to support these, and eventually we will have encrypted variables, so I'm just mentioning it for posterity ;) |
@@ -766,6 +766,16 @@ define([
OPAQUE_AND_TRANSLUCENT : 2
};
+ function updateDerivedCommands(derivedCommands, command) {
+ for (var name in derivedCommands) {
+ if (derivedCommands.hasOwnProperty(name)) {
+ var derivedCommand = derivedCommands[name];
+ ... | [No CFG could be retrieved] | Creates a function that can be used to add commands to a commandList. If the styling is all opaque use the original command. If the styling is all. | Perhaps `updateDerivedCommandsShadows` to be precise? |
@@ -307,10 +307,15 @@ public final class HiveBucketing
}
public static boolean bucketedOnTimestamp(HiveBucketProperty bucketProperty, Table table)
+ {
+ return bucketedOnTimestamp(bucketProperty, table.getDataColumns(), table.getTableName());
+ }
+
+ public static boolean bucketedOnTimestamp... | [HiveBucketing->[bucketedOnTimestamp->[bucketedOnTimestamp],getBucketHashCode->[getBucketHashCode],HiveBucketFilter->[equals->[equals]],getHiveBucket->[getBucketHashCode],getHiveBucketFilter->[getHiveBuckets],getHiveBuckets->[getHiveBuckets,getBucketHashCode]]] | Checks if the given bucket property is bucketed on a timestamp. | add override with `HiveTableHandle` as argument |
@@ -299,7 +299,7 @@ class PostsController < ApplicationController
def destroy
post = find_post_from_params
- unless current_user.staff?
+ unless current_user.staff? || guardian.is_category_group_moderator?(post.topic.category)
RateLimiter.new(current_user, "delete_post_per_min", SiteSetting.max_p... | [PostsController->[destroy->[destroy],cooked->[cooked],destroy_bookmark->[destroy],recover->[recover],reply_history->[reply_history],destroy_many->[destroy],raw_email->[raw_email]]] | This action will destroy a single post if it exists. | maybe we use a guardian here? Then we get to reuse in recover. `if !guardian.can_moderate?(post)` |
@@ -143,7 +143,7 @@ public interface AgentManager {
public void pullAgentOutMaintenance(long hostId);
- boolean reconnect(long hostId);
+ void reconnect(long hostId) throws AgentUnavailableException;
void rescan();
| [No CFG could be retrieved] | Called when a host is going to be removed from the agent s maintenance list. | this change is breaking things. We need to look at it. @rafaelweingartner CAManagerImpl.java needs the boolean. should we take this to 4.12? I'm not taking the time now. |
@@ -36,6 +36,7 @@ class SvnDriver extends VcsDriver
protected $trunkPath = 'trunk';
protected $branchesPath = 'branches';
protected $tagsPath = 'tags';
+ protected $modulePath = '/';
/**
* @var \Composer\Util\Svn
| [SvnDriver->[execute->[getMessage,getErrorOutput,execute],getComposerInformation->[getMessage,write,read,format,splitLines,execute],getTags->[splitLines,execute],supports->[getErrorOutput,execute],getBranches->[splitLines,execute],initialize->[getBranches,get,getTags],normalizeUrl->[isAbsolutePath]]] | Creates an instance of the class. Initializes the object with all the properties of the object. | I think it should default to an empty string, otherwise you'll create urls like `/trunk//@123` no? |
@@ -183,7 +183,10 @@ func (t *BaseOperations) SetHostname(hostname string, aliases ...string) error {
for _, a := range append(aliases, hostname) {
Sys.Hosts.SetHost(a, lo4)
}
- if err = Sys.Hosts.Save(); err != nil {
+ if err = Sys.Hosts.Save(hostsPathBindSrc); err != nil {
+ return err
+ }
+ if err = bindMoun... | [RouteDel->[RouteDel],LinkSetAlias->[LinkSetAlias],AddrDel->[AddrDel],LinkSetUp->[LinkSetUp],dhcpLoop->[Apply],RouteAdd->[RouteAdd],AddrAdd->[AddrAdd],RuleList->[RuleList],LinkBySlot->[LinkByName],AddrList->[AddrList],LinkSetDown->[LinkSetDown],LinkSetName->[LinkSetName],LinkByName->[LinkByName],updateNameservers,Route... | SetHostname sets the hostname for the kernel. | So instead of this, you could just set `Sys.Hosts` to `etcconf.NewHosts(hostsPathBindSrc)` in an `init()` function in `/lib/tether/tether.go`. Same goes for `Sys.ResolvConf`. That way you do not need to modify the `Conf` interface. |
@@ -178,7 +178,7 @@ public class WebConfigurerTest {
@Test
public void testCustomizeServletContainerNotProd() {
- UndertowEmbeddedServletContainerFactory container = new UndertowEmbeddedServletContainerFactory();
+ UndertowServletWebServerFactory container = new UndertowServletWebServerFactory... | [No CFG could be retrieved] | Customize the Undertow servlet container. Undertow HTTP2 enabled. | MediaType.TEXT_HTML_VALUE + StandardCharsets.UTF_8.name() |
@@ -1800,6 +1800,7 @@ def write_labels_to_annot(labels, subject=None, parc=None, overwrite=False,
if n_hemi_labels == 0:
ctab = np.empty((0, 4), dtype=np.int32)
+ ctab_rgb = ctab[:, :3]
else:
hemi_labels.sort(key=lambda label: label.name)
| [BiHemiLabel->[__add__->[_blend_colors,BiHemiLabel],__sub__->[BiHemiLabel]],split_label->[Label,read_label,_split_colors],read_labels_from_annot->[Label,_read_annot,_get_annot_fname],write_label->[split],stc_to_label->[fill,Label,_n_colors],Label->[morph->[copy],get_tris->[get_vertices_used],fill->[Label],__add__->[_bl... | This function writes a list of labels to an. annot file. Check if a missing missing label is found in the data. find the number of vertices in the surface and create the color table array for the missing labels missing - label - values - values in other_ids - label - values in other_ Writes a missing color - based labe... | this is the bug fix |
@@ -81,6 +81,7 @@ type Shoot struct {
NodeLocalDNSEnabled bool
Networks *Networks
ExposureClass *gardencorev1alpha1.ExposureClass
+ BackupEntryName string
Components *Components
ETCDEncryption *etcdencryption.EncryptionConfig
| [No CFG could be retrieved] | exposureClassFunc is a function that returns the exposure class and secret for a given base name Magic type for handling extension resources. | Should this variable be a pointer? I am just thinking if it can be used somewhere without be properly initialized and this time it will be `""` instead of `"--"`. |
@@ -94,17 +94,7 @@ nes_powerpad_device::nes_powerpad_device(const machine_config &mconfig, const ch
void nes_powerpad_device::device_start()
{
save_item(NAME(m_latch));
-}
-
-
-//-------------------------------------------------
-// device_reset
-//-------------------------------------------------
-
-void nes_powe... | [No CFG could be retrieved] | PUBLIC FUNCTIONS - Constructs a nes_powerpad_device object from a machine. | Why not just use `IPT_ACTIVE_LOW` for the unused input bits so it returns the value you want and you don't need to or it with a constant here? |
@@ -13,8 +13,12 @@ class ArrayField(Field[numpy.ndarray]):
A batch of these arrays are padded to the max dimension length in the batch
for each dimension.
"""
- def __init__(self, array: numpy.ndarray, padding_value: int = 0) -> None:
+ def __init__(self,
+ array: numpy.ndarray,
+ ... | [ArrayField->[empty_field->[ArrayField,array],get_padding_lengths->[str,enumerate],as_tensor->[list,asarray,from_numpy,len,tuple,slice,format,ones,range]]] | Initialize the object with the given array and padding value. | Could you just swap the `dtype` argument to be the last argument, so it is fully backward compatible, and then this looks great! |
@@ -88,9 +88,7 @@ typedef enum OPTION_choice {
} OPTION_CHOICE;
const OPTIONS cms_options[] = {
- {OPT_HELP_STR, 1, '-', "Usage: %s [options] cert.pem...\n"},
- {OPT_HELP_STR, 1, '-',
- " cert.pem... recipient certs for encryption\n"},
+ {OPT_HELP_STR, 1, '-', "Usage: %s [options] [cert...]\n"},
... | [No CFG could be retrieved] | Options for the encryption Descriptions of the supported format of a message. | In general to distinguish between literal and replaceable parameter names (as italics cannot be used in usage outputs) the commands use capitalized words for the replaceable texts. But that would be probably a separate PR to do and maybe even not worth it. |
@@ -38,7 +38,7 @@ public class ConfigurationUtils {
public static int getServerShutdownTimeout() {
int timeout = Constants.DEFAULT_SERVER_SHUTDOWN_TIMEOUT;
Configuration configuration = Environment.getInstance().getConfiguration();
- String value = configuration.getString(Constants.SHUTDOW... | [ConfigurationUtils->[getProperty->[getProperty],parseProperties->[getProperty]]] | This method returns the timeout for the server shutdown. | Do we need to add any UT for this scenario ? |
@@ -49,13 +49,6 @@ public final class ProTerritoryValueUtils {
return value;
}
- public static Map<Territory, Double> findTerritoryValues(final PlayerId player,
- final List<Territory> territoriesThatCantBeHeld, final List<Territory> territoriesToAttack) {
-
- return findTerritoryValues(player, terri... | [ProTerritoryValueUtils->[findLandValue->[findTerritoryAttackValue],findWaterValue->[findLandValue,findTerritoryAttackValue],findTerritoryValues->[findTerritoryValues]]] | Find the value of a territory attack for a player. Get the value of a territory that is not a water. | This is one of the main keys of this PR was to remove this method and refactor areas that used it as its very slow on large maps. |
@@ -11,6 +11,12 @@ import org.mule.runtime.api.notification.NotificationListener;
public interface ServerNotificationHandler {
+ /**
+ * Fire the {@link Notification}. Regardless of is a notification is fired synchronously or asynchronously any {@link Throwable}
+ * thrown by the {@link NotificationListener} ... | [No CFG could be retrieved] | Fire a notification. | Regardless of is a notification? |
@@ -340,7 +340,8 @@ void RigidFace3D::ComputeConditionRelativeData(int rigid_neighbour_index,
if (points == 3 || points == 4)
{
unsigned int dummy_current_edge_index;
- contact_exists = GeometryFunctions::FacetCheck(this->GetGeometry(), node_coordinates, radius, LocalCoordSystem, DistPToB, Tem... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - Find the neighbouring nodes in the network. | Why is necessary this change? |
@@ -22,8 +22,8 @@ import java.util.UUID;
public final class QueryGuid {
private final String clusterNamespace;
- private final String queryUuid;
- private final String anonQueryUuid;
+ private final String queryGuid;
+ private final String structuralGuid;
private final LocalDateTime timeOfCreation;
pu... | [QueryGuid->[computeQueryId->[toString,getGenericQueryForm],getGenericQueryForm->[replaceAll],computeQueryId,now]] | Creates an instance of the class which represents a single . Get the UUID of the that matches the given query and namespace. | Curious - why the name change? |
@@ -41,6 +41,11 @@ func GetPodName(base, suffix string) string {
return GetName(base, suffix, kvalidation.DNS1123SubdomainMaxLength)
}
+// GetConfigMapName calls GetName with the length restriction for ConfigMaps
+func GetConfigMapName(base, suffix string) string {
+ return GetName(base, suffix, kvalidation.DNS112... | [Sprintf,New32a,Write,Sum32] | GetPodName returns the name of the pod with the given name. | Per kube docs, this is a convention |
@@ -56,10 +56,6 @@
#include <lcms2.h>
-// max iccprofile file name length
-// must be in synch with dt_colorspaces_color_profile_t
-#define DT_IOP_COLOR_ICC_LEN 512
-
#define LUT_SAMPLES 0x10000
DT_MODULE_INTROSPECTION(7, dt_iop_colorin_params_t)
| [No CFG could be retrieved] | includes common. h image_cache. h image_cache. h image_cache. df_iop_colorin_gui_data_t - IOP colorin. | No please, not in any of the iop because they must be self sufficient and the value should not be changed without updating the legacy_params() routine. So changing it globally would break IOP having it recorded into their params. |
@@ -231,7 +231,6 @@ require('react-styl')(`
opacity: 1
display: block
.mobile-modal-light
- touch-action: none
position: fixed
z-index: 2000
-webkit-transform: translate3d(0, 0, 0)
| [No CFG could be retrieved] | On modal modal Modal content with no - modal - content. | @shahthepro can you remember why this was added? Are we OK to make this change? |
@@ -22,13 +22,8 @@ class ObjectRemoteQueryEngine extends QueryEngine<Descriptor> {
private final EmbeddedQueryFactory queryFactory = new EmbeddedQueryFactory(this);
- ObjectRemoteQueryEngine(AdvancedCache<?, ?> cache, boolean isIndexed, Class<? extends Matcher> matcherImplClass,
- Lu... | [ObjectRemoteQueryEngine->[makeQuery->[startOffset,setParameters,create,maxResults],withEncoding,EmbeddedQueryFactory]] | This method creates a query with the given parameters. | Why was `withEncoding(IdentityEncoder.class)` removed? Note sure what this implies. |
@@ -2,6 +2,7 @@ module AutomatedTestsClientHelper
ASSIGNMENTS_DIR = File.join(MarkusConfigurator.autotest_client_dir, 'assignments')
STUDENTS_DIR = File.join(MarkusConfigurator.autotest_client_dir, 'students')
+ HOOKS_FILE = 'hooks.py'
def create_test_repo(assignment)
test_dir = File.join(ASSIGNMENTS... | [authorize_test_run->[check_user_permission],process_test_form->[process_test_file]] | Creates a test repo for the given assignment. | Style/MutableConstant: Freeze mutable objects assigned to constants. |
@@ -223,7 +223,8 @@ class Stage(object):
self.project.logger.debug("Removing '{}'".format(out.path))
os.chmod(out.path, stat.S_IWUSR)
os.unlink(out.path)
- os.chmod(out.cache, stat.S_IREAD)
+ if os.path.exists(out.cache):
+ ... | [Output->[update->[OutputIsNotFileError,mtime,update,OutputDoesNotExistError],changed->[_changed_md5],__init__->[OutputOutsideOfRepoError],save->[link,OutputAlreadyTrackedError],loadd_from->[loadd],checkout->[link],link->[OutputNoCacheError],loads_from->[loads]],Stage->[load->[loadd],dumpd->[dumpd],loadd->[loadd_from,S... | Remove all out files. | This was fixed in #379 |
@@ -1592,6 +1592,9 @@ func GetUserIssueStats(opts UserIssueStatsOptions) (*IssueStats, error) {
if opts.RepoID > 0 {
cond = cond.And(builder.Eq{"issue.repo_id": opts.RepoID})
}
+ if len(opts.RepoIDs) > 0 {
+ cond = cond.And(builder.In("issue.repo_id", opts.RepoIDs))
+ }
switch opts.FilterMode {
case Filte... | [DiffURL->[HTMLURL],ChangeStatus->[changeStatus,loadPullRequest,loadRepo,APIFormat,loadPoster],loadAttributes->[loadPullRequest,loadTotalTimes,loadRepo,loadLabels,isTimetrackerEnabled,loadPoster,loadComments,loadReactions],ClearLabels->[loadPullRequest,loadRepo,APIFormat,clearLabels,loadPoster],ReplaceLabels->[removeLa... | GetUserIssueStats returns issue statistic information for dashboard by given conditions. FilterModeCreate returns count of closed open and closed issues. | Instead of adding conditional to SQL, could this just append `opts.RepoID` to `opts.RepoIDs` slice? |
@@ -153,14 +153,7 @@ public class AzureDataSegmentPusher implements DataSegmentPusher
@Override
public Map<String, Object> makeLoadSpec(URI uri)
{
- return ImmutableMap.of(
- "type",
- AzureStorageDruidModule.SCHEME,
- "containerName",
- segmentConfig.getContainer(),
- "bl... | [AzureDataSegmentPusher->[getAzurePath->[getStorageDir],getPathForHadoop->[getPathForHadoop]]] | Makes load spec for a given segment. | It looks like hadoop indexing would still call this method so it might have issues with funny characters, but I don't think it is worth refactoring to fix the issue at this point. |
@@ -205,6 +205,7 @@ type PatchUpdateCheckpointRequest struct {
}
// AppendUpdateLogEntryRequest defines the body of a request to the append update log entry endpoint of the service API.
+// No longer sent from, but the type definition is still required for backwards compat with older clients.
type AppendUpdateLogE... | [No CFG could be retrieved] | AppendUpdateLogEntryRequest defines the body of a request to the append update log entry endpoint of. | NIT: "No longer sent from" read a little weird. Did you drop something like "the CLI" |
@@ -189,8 +189,11 @@ public class SCMRatisServerImpl implements SCMRatisServer {
return selfPeerId;
}
+ /**
+ * This will be used when the SCM HA config are not defined.
+ */
SCMHAGroupBuilder(final SCMHAConfiguration haConf,
- final ConfigurationSource conf) throws IO... | [SCMRatisServerImpl->[triggerNotLeaderException->[NotLeaderException,getMemberId,getPeers],submitRequest->[build,decode,get],start->[start],stop->[close],SCMHAGroupBuilder->[parseHosts->[size,toList,info,get,getHostName,set,collect,add],getLocalHost,size,getPort,equals,build,info,getBytes,getRaftPeerId,get,nameUUIDFrom... | Returns the peer id of this node. | Can you clarify why use `clusterId` as RaftGroup id? Is it useful somehow later? |
@@ -35,6 +35,7 @@ import (
type PersistOptions struct {
// configuration -> ttl value
ttl map[string]*cache.TTLString
+ ttlCancel map[string]context.CancelFunc
schedule atomic.Value
replication atomic.Value
pdServerConfig atomic.Value
| [GetReplicaScheduleLimit->[GetScheduleConfig],GetSchedulers->[GetScheduleConfig],IsUseRegionStorage->[GetPDServerConfig],SetAllStoresLimitTTL->[SetTTLData],GetMaxMergeRegionSize->[GetScheduleConfig],GetSplitMergeInterval->[GetScheduleConfig],SetPlacementRuleEnabled->[SetReplicationConfig,GetReplicationConfig],GetStoreL... | NewPersistOptions creates a new PersistOptions instance from a given config. GetScheduleConfig returns the schedule and replication configurations. | Why create `cache.TTLString` for each key, instead of use only 1 `cache.TTLString` for all keys? |
@@ -1033,6 +1033,12 @@ static gboolean draw(GtkWidget *widget, cairo_t *cr, dt_iop_module_t *self)
p->coeffs[2] /= p->coeffs[1];
p->coeffs[1] = 1.0;
for(int k = 0; k < 3; k++) p->coeffs[k] = fmaxf(0.0f, fminf(8.0f, p->coeffs[k]));
+
+ // If we're in a CMYG image we need to create CMYG coeffs from the RGB ones... | [No CFG could be retrieved] | draw the color picker event temperature changed in the IOP module. | draw() callback seems like a very bad place for this. |
@@ -3008,7 +3008,7 @@ func (a *apiServer) RunLoadTest(ctx context.Context, req *pfs.RunLoadTestRequest
fmt.Sprintf("cp -r /pfs/%s/* /pfs/out/", repo),
},
&pps.ParallelismSpec{
- Constant: 1,
+ Constant: 5,
},
&pps.Input{
Pfs: &pps.PFSInput{
| [stopAllJobsInPipeline->[stopJob],CreatePipelineInTransaction->[initializePipelineInfo,authorizePipelineOpInTransaction,fixPipelineInputRepoACLsInTransaction],getLogsLoki->[authorizePipelineOp],SubscribeJob->[getJobDetails],GetLogs->[GetLogs,authorizePipelineOp],UpdateJobStateInTransaction->[UpdateJobState],ActivateAut... | RunLoadTest - run load test. | Did you mean to leave this changed? |
@@ -1426,8 +1426,10 @@ class ReviewAddonVersionDraftCommentViewSet(
if not hasattr(self, 'version_object'):
self.version_object = get_object_or_404(
# The serializer will not need any of the stuff the
- # transformers give us for the version.
- self.g... | [leaderboard->[context],queue_extension->[_queue],queue_recommended->[_queue],performance->[_sum,context],ReviewAddonVersionDraftCommentViewSet->[get_queryset->[get_version_object],get_object->[_verify_object_permissions,get_queryset],get_addon_object->[get_queryset],get_extra_comment_data->[get_version_object],get_ver... | Get the version object. | can you point to the permission check/gating that limits this to just users with `Addons:ViewDeleted`? |
@@ -190,7 +190,9 @@ public class UtilHelpers {
.withCompactionStrategy(ReflectionUtils.loadClass(strategy)).build())
.orElse(HoodieCompactionConfig.newBuilder().withInlineCompaction(false).build());
HoodieWriteConfig config =
- HoodieWriteConfig.newBuilder().withPath(basePath).withPara... | [UtilHelpers->[buildSparkContext->[buildSparkConf],buildSparkConf->[buildSparkConf]]] | Creates a HoodieWriteClient with the specified configuration. | @garyli1019 @vinothchandar I assume this won't have any side effect, will it? Though it is also used by `HoodieCompactor`, the `parallelism` setting should only take effect for one of the preset modes (upsert/insert/bulkinsert). |
@@ -78,7 +78,8 @@ func GetSwap() (*SwapStat, error) {
// this can provoke too big values for used swap.
// Workaround this by assuming that all swap is free in that case.
if swap.Free > swap.Total || swap.Used > swap.Total {
- logp.Debug("memory",
+ logger := logp.NewLogger("GetSwap")
+ logger.Debugf("memory",... | [Round,IsNotImplemented,VMStat,Host,Wrap,Get,Debug] | AddMemPercentage calculates the ratio of used and total size of memory and the total swap size GetSwapEvent returns the event created from swap usage. | s/GetSwap/memory don't change the "name" when creating `NewLogger`. The names are used as "debug selector" and changing names might be considered a breaking change. |
@@ -74,6 +74,15 @@ class FEMDEM_Solution:
# for the dem contact forces coupling
self.InitializeDummyNodalForces()
+ print(" /$$$$$$$$ /$$$$$$$$ /$$ /$$ /$$$$$$ /$$$$$$$ /$$$$$$$$ /$$ /$$")
+ print("| $$_____/| $$_____/| $$$ /$$$ /$$__ $$| $$__ $$| $$_____/| $$$ /$$... | [FEMDEM_Solution->[CreateInitialSkinDEM->[GetNodeCoordinates],Initialize->[Initialize],InitializeDummyNodalForces->[GetMaximumConditionId],InitializeSolutionStep->[InitializeSolutionStep],UpdateDEMVariables->[GetNodeCoordinates],Finalize->[Finalize],GenerateDemAfterRemeshing->[GetNodeCoordinates]]] | Initialize the FEM and DEM variables. This method loops through all the possible solutions of the FEM. | You should use the logger |
@@ -195,7 +195,7 @@ public class MetadataSegmentView
sb.append("datasources=").append(ds).append("&");
}
sb.setLength(sb.length() - 1);
- query = "/druid/coordinator/v1/metadata/segments?" + sb;
+ query = "/druid/coordinator/v1/metadata/segments?includeOvershadowedStatus?" + sb;
}
... | [MetadataSegmentView->[PollTask->[run->[poll,PollTask]]]] | Gets the list of metadata segments. | I'm not sure if doing two `?` in the same URL works, but even if it does, it's poor form; the second one should be a `&`. |
@@ -76,8 +76,11 @@ let wrapWebContents = function(webContents) {
// WebContents::send(channel, args..)
webContents.send = function() {
- var args, channel;
- channel = arguments[0], args = 2 <= arguments.length ? slice.call(arguments, 1) : [];
+ var args = 2 <= arguments.length ? slice.call(arguments, ... | [No CFG could be retrieved] | The object that represents the object that represents the object that is used to render the The main method of the webContents class. | How about `(!channel)`, it'll then also catch falsy values like undefined |
@@ -399,6 +399,18 @@ class DigitalContentUrl(models.Model):
self.token = str(uuid4()).replace("-", "")
super().save(force_insert, force_update, using, update_fields)
+ def increment_download_count(self):
+ self.download_num += 1
+ self.save(update_fields=["download_num"])
+
+ ... | [ProductVariant->[get_absolute_url->[get_slug],get_ajax_label->[display_product,get_price],is_digital->[is_shipping_required],get_first_image->[get_first_image]],Product->[is_in_stock->[is_in_stock]]] | Save a lease entry. | I'd move it to `utils` to keep our models thin. It's okay for a model method to perform simple logic on model's fields but if it requires saving additional models, then we usually keep that in a function outside. |
@@ -1117,6 +1117,14 @@ func (mod *modContext) genResource(res *schema.Resource) (string, error) {
return fmt.Sprintf("pulumi.Output[%s]", ty)
})
+ // Write out Python property getters for all inputs if this is a provider resource because all inputs are implicitly outputs.
+ if res.IsProvider {
+ mod.genProperti... | [importTypeFromToken->[tokenToModule,getRelImportFromRoot],importResourceFromToken->[tokenToResource,getRelImportFromRoot],genPropertyConversionTables->[genHeader],addEnum->[add],genInit->[genHeader,hasTypes,submodulesExist,isEmpty],pyType->[pyType,tokenToResource],isEmpty->[isEmpty],addResource->[add],genConfig->[genH... | genResource generates code for a resource This function is used to generate a class definition with optional parameters. Print out the description of the object in the given writer. This function is only valid when passed in combination with a valid opts. | I'm actually not sure we want to handle this here. It doesn't look like we generate equivalent getters for the Provider resource in any of the other languages. If we do want to add these, I wonder if this should be something that gets defined in the schema, basically mirroring the InputProperties in Properties. Then th... |
@@ -207,6 +207,7 @@ class ExpeditionLineBatch extends CommonObject
$tmp->fk_origin_stock = $obj->fk_origin_stock;
$tmp->fk_expeditiondet = $obj->fk_expeditiondet;
$tmp->dluo_qty = $obj->qty;
+ $tmp->entrepot_id = $obj->fk_entrepot;
$ret[]=$tmp;
$i++;
| [ExpeditionLineBatch->[fetchAll->[free,query,num_rows,fetch_object,jdate],deletefromexp->[query],create->[query,rollback,last_insert_id,lasterror,escape,idate],fetchFromStock->[free,query,num_rows,fetch_object,jdate,lasterror]]] | fetch all the records in the database that are not part of a sequence of a sequence of. | This data come from a link that is ok just after the reception is done, but as soon as stock is empty, the line into product_batch and product_stock will no exists anymore and we won't be able to get the entrepot_id value for old reception. Is this ok for you ? |
@@ -43,6 +43,10 @@ class Install extends BaseModule
{
$a = self::getApp();
+ if (!$a->getMode()->isInstall()) {
+ Core\System::httpExit(403);
+ }
+
// route: install/testrwrite
// $baseurl/install/testrwrite to test if rewrite in .htaccess is working
if ($a->getArgumentValue(1, '') == 'testrewrite')... | [Install->[init->[getArgumentValue,getBaseURL],post->[getBasePath,getConfigCache,checkDB,getProfiler,installDatabase,getPHPPath,getURLPath,createConfig],content->[checkEnvironment,getChecks,getBaseURL],whatNext->[getBaseUrl]]] | Initialize the page. | This one is superfluous since there's one in the `init()` function. |
@@ -153,6 +153,11 @@ namespace Dynamo.Nodes
new public string Text
{
get { return base.Text; }
+ set
+ {
+ base.Text = value;
+ UpdateDataSource(true);
+ }
}
#endregion
| [DynamoTextBox->[OnPreviewKeyDown->[OnRequestReturnFocusToSearch],NodeModel->[NodeModel]],DynamoSlider->[OnThumbDragCompleted->[OnThumbDragCompleted],OnThumbDragStarted->[OnThumbDragStarted],OnPreviewMouseLeftButtonDown->[OnPreviewMouseLeftButtonDown]]] | The base text property of a node is the base text of a node. Updates the data source if the node is bound to the target. | The setter was left out (and new `Text` property created to hide the base property) intentionally, because that messes with the sequence in which undo recording is done. Is there a reason we add this now? Undo around the use of `DynamoTextBox` must be validated after this. |
@@ -33,11 +33,7 @@ import com.google.gwt.user.client.Window;
import com.google.gwt.user.client.Event.NativePreviewEvent;
import com.google.gwt.user.client.ui.*;
-import org.rstudio.core.client.BrowseCap;
-import org.rstudio.core.client.ElementIds;
-import org.rstudio.core.client.HandlerRegistrations;
-import org.rs... | [ProgressDialog->[onPreviewNativeEvent->[onPreviewNativeEvent],onUnload->[onUnload],progressDialog,displayWidget]] | Imports a single key sequence from a GUA. Package that implements the ProgressDialog interface. | Revert wildcard import back to individual imports. |
@@ -218,7 +218,7 @@ class Backtesting:
"""
# Every change to this headers list must evaluate further usages of the resulting tuple
# and eventually change the constants for indexes at the top
- headers = ['date', 'buy', 'open', 'close', 'sell', 'low', 'high']
+ headers = ['date'... | [Backtesting->[backtest_one_strategy->[backtest,_set_strategy],backtest->[handle_left_open,check_abort,_enter_trade,prepare_backtest,_get_sell_trade_entry,trade_slot_available,_get_ohlcv_as_lists],prepare_backtest->[_load_protections],start->[load_bt_data,backtest_one_strategy],_get_sell_trade_entry->[_get_close_rate],... | Helper function to convert a processed dataframes into lists for performance reasons. Get data with in the next pair of data. | This will fail for all strategies that don't define a buy signal, because the column will not exist. That part was handled in L230... |
@@ -91,6 +91,8 @@ public class ResourceLeakDetector<T> {
private static Level level;
+ private static int targetRecords;
+
private static final InternalLogger logger = InternalLoggerFactory.getInstance(ResourceLeakDetector.class);
static {
| [ResourceLeakDetector->[reportLeak->[clearRefQueue],LeakEntry->[LeakEntry],Record->[toString->[toString],Record,toString],DefaultResourceLeak->[close->[close],toString->[toString]],parseLevel]] | This method is used to determine the highest possible overhead for a given object. region ResourceLeakDetector Implementation. | is this intentionally not volatile? we may have visibility issues here, and the volatile read may increase cost of leak detection. |
@@ -45,6 +45,14 @@ typedef struct dt_lib_duplicate_t
GtkWidget *duplicate_box;
int imgid;
dt_lib_duplicate_select_t select;
+
+ int32_t buf_width;
+ int32_t buf_height;
+ cairo_surface_t *surface;
+ uint8_t *rgbbuf;
+ int buf_mip;
+ int buf_timestamp;
+
} dt_lib_duplicate_t;
const char *name(dt_lib_m... | [No CFG could be retrieved] | Creates a new object from a list of objects in the GNU General Public License. private static gboolean _lib_duplicate_init_callback _lib_duplicate_caption. | you can also remove this empty line here. |
@@ -473,6 +473,17 @@ class Experiments:
"\tdvc exp branch <exp> <branch>\n"
)
+ def _validate_new_ref(self, exp_ref: ExpRefInfo):
+ from .utils import check_ref_format
+
+ if not exp_ref.name:
+ return
+
+ check_ref_format(self.scm, exp_ref)
+
+ if self.... | [Experiments->[pull->[pull],show->[show],push->[push],run->[run],branch->[branch],diff->[diff],remove->[remove],_resume_checkpoint->[_stash_exp],new->[_stash_exp],gc->[gc],ls->[ls],apply->[apply],_update_params->[_format_new_params_msg]]] | Log the results of a single branch or a single checkpoint. | This function is used for validating a new reference, not only the name. Because we include duplication detect in it. And also the duplication detection is not to the name but to the whole reference. |
@@ -268,7 +268,7 @@ public class MojoTestBase {
assertThat(logs.contains(infoLogLevel)).isTrue();
Predicate<String> datePattern = Pattern.compile("\\d{4}-\\d{2}-\\d{2}\\s\\d{2}:\\d{2}:\\d{2},\\d{3}\\s").asPredicate();
assertThat(datePattern.test(logs)).isTrue();
- assertThat(logs.conta... | [MojoTestBase->[getHttpErrorResponse->[getHttpResponse],getHttpResponse->[getHttpResponse]]] | Checks that the output of the pom. xml file works correctly. | They are now only displayed if the user-facing extensions are used. Otherwise it's just internal plumbing and the user shouldn't be aware of it. |
@@ -1133,6 +1133,15 @@ def parse_options(args: List[str]) -> argparse.Namespace:
action="store_true",
help="Ignore unused whitelist entries",
)
+ config_group = parser.add_argument_group(
+ title='Config file',
+ description="Use a config file instead of command line arguments. "
+ ... | [_verify_signature->[_verify_arg_name,_verify_arg_default_value],get_whitelist_entries->[strip_comments],test_module->[Error],verify->[Error],main->[test_stubs,parse_options],verify_funcitem->[_verify_signature,from_inspect_signature,from_funcitem,_verify_static_class_methods,Error],get_mypy_type_of_runtime_value->[any... | Parse command line options and return a tuple of the result. | copied directly from `main.py`. |
@@ -2376,7 +2376,9 @@ def sequence_concat(input, name=None):
Examples:
.. code-block:: python
- out = fluid.layers.sequence_concat(input=[seq1, seq2, seq3])
+ x = fluid.layers.data(name='x', shape=[10], dtype='float32')
+ y = fluid.layers.data(name='y', shape=[10], dtype='f... | [ctc_greedy_decoder->[topk],py_func->[PyFuncRegistry],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],nce->[_init_by_numpy_array],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],npair_loss->[reduce_sum,reduce_mean,expand,matmul,reshape,softmax_with_cross_entropy],elementwise_min->... | Concatenates a list of sequence variables into a single sequence. | Please add `import paddle.fluid as fluid` |
@@ -430,10 +430,11 @@ class BuildManager:
reports: Reports,
options: Options,
version_id: str,
- plugin: Plugin) -> None:
+ plugin: Plugin,
+ errors: Errors) -> None:
self.start_time = time.time()
sel... | [find_modules_recursive->[BuildSource,find_module,find_modules_recursive],process_graph->[trace,log],BuildManager->[all_imported_modules_in_file->[correct_rel_imp,import_priority],get_stat->[maybe_swap_for_shadow_path],report_file->[is_source]],State->[parse_file->[parse_file,read_with_python_encoding,wrap_context,all_... | Initialize a new object with the given configuration. | Add this to the docstring too. |
@@ -546,6 +546,13 @@ export class AmpStoryAutoAds extends AMP.BaseElement {
this.uniquePageIds_[pageId] = true;
}
+ if (this.adPagesCreated_ === 0) {
+ // This is protection against us running our placement algorithm in a
+ // story where no ads have been created. Most likely because INI_LOAD... | [No CFG could be retrieved] | Private methods for handling the state change of an active page. Private method for handling the case where the ad is not loaded yet. | we should move this check together with the uniquePagesCount_ logic to the top of this method. |
@@ -101,6 +101,15 @@ export class IframeMessagingClient {
*/
setupEventListener_() {
listen(this.win_, 'message', event => {
+ if (this.hostWindowIsActuallyAnIframe_()) {
+ // this.hostWindow_ can now be set to an iframe, after it has been
+ // created but before it has finished loading. ... | [IframeMessagingClient->[setupEventListener_->[getData,listen,source,deserializeMessage],sendMessage->[dev,serializeMessage],constructor->[getMode,parent,map]]] | Setup event listener for incoming message. | why hostWindow can be an iframe? |
@@ -50,12 +50,11 @@ public class XsltTransformerBLTestCase extends FunctionalTestCase
assertThat(output, containsString("010101010101010101010101010101010101010101010101"));
}
- @Test
+ @Test(expected = TransformerMessagingException.class)
public void disabled() throws Exception
{
... | [XsltTransformerBLTestCase->[enabled->[makeInput],disabled->[makeInput]]] | Test if the flowBL is enabled or disabled. | use ExpectedException rule and assert the message also |
@@ -297,4 +297,13 @@ module TwoFactorAuthenticatable
view: view_context
)
end
+
+ def phone_configuration
+ MfaContext.new(current_user).phone_configuration(session[:phone_id])
+ end
+
+ def masked_number(number)
+ return '' if number.blank?
+ "***-***-#{number[-4..-1]}"
+ end
end
| [handle_invalid_otp->[handle_second_factor_locked_user],generic_data->[personal_key_unavailable?]] | Returns a presenter for the Two Factor Authentication method missing - if there is no presenter for the. | Not an issue introduced here, but may be worth noting that this is going to incorrectly format international numbers. |
@@ -235,6 +235,7 @@ class EventProcessor(
) = self.get_init_event_position(partition_id, checkpoint)
if partition_id in self._partition_contexts:
partition_context = self._partition_contexts[partition_id]
+ partition_context._last_received_event = None # pylint... | [EventProcessor->[stop->[_cancel_tasks_for_partitions],_close_partition->[_process_error],start->[_create_tasks_for_claimed_ownership,_cancel_tasks_for_partitions,_process_error],_close_consumer->[_close_partition],_receive->[_process_error,_close_consumer]]] | Receive a single block of events from the eventhub. Handle a unhandled exception while receiving a block of events. | Isn't this already set to None in the partition context initialized? Under what circumstances would this not be set? |
@@ -207,7 +207,7 @@ public class OldDataMonitor extends AdministrativeMonitor {
}
if (buf.length() == 0) return;
Jenkins j = Jenkins.getInstanceOrNull();
- if (j == null) {
+ if (j == null) { // TODO confirm this can never be true
// Startup failed, something is ver... | [OldDataMonitor->[report->[report,get],saveAndRemoveEntries->[get,apply],RunSaveableReference->[hashCode->[hashCode],equals->[equals]],getData->[get],SimpleSaveableReference->[hashCode->[hashCode],equals->[equals]],VersionRange->[toString->[toString]],remove->[get,remove],onDeleted->[remove],onChange->[remove]]] | Reports the errors in the given collection of errors. | Probably it _was_ true, which is why this code block was written: startup failed, Jenkins shut down, and now we are trying to report stuff. Maybe things were refactored since then to make this impossible, or maybe the author misdiagnosed a `NullPointerException`, etc. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.