patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -75,13 +75,13 @@ public class HoodieLogFileReader implements HoodieLogFormat.Reader {
public HoodieLogFileReader(FileSystem fs, HoodieLogFile logFile, Schema readerSchema, int bufferSize,
boolean readBlockLazily, boolean reverseReader) throws IOException {
FSDataInputStream fsDa... | [HoodieLogFileReader->[close->[close],next->[readBlock],prev->[next,hasNext]]] | This class is used to read a log file and read it into memory. Reads a block from the file system if it is possible to read the next block. | This piece of logic still slightly worries me a bit. I would also check fsDataInputStream.getWrappedStream().getWrappedStream() could be cast to FSInputStream and fallback to 'this.inputStream = fsDataInputStream' if it can't be. But I also would log a warning in this case as it would be unexpected situation that we ma... |
@@ -4476,7 +4476,7 @@ else if ($id > 0 || ! empty($ref))
// Show global modifiers
if (! empty($conf->global->INVOICE_USE_SITUATION))
{
- if ($object->situation_cycle_ref && $object->statut == 0) {
+ if ($object->statut == 0) { //SITUATION can add lines during cycle a additional works
print '<div class="div-... | [update_price,create,form_multicurrency_rate,get_OutstandingBill,jdate,getLinesArray,setValueFrom,getVentilExportCompta,getNomUrl,select_incoterms,begin,select_comptes,insert_discount,getLibType,setProject,add_contact,showOptionals,printOriginLinesList,textwithpicto,fetch_optionals,free,transnoentitiesnoconv,query,form... | List of payments already done on this invoice get all payment details from facture. | Why removing test on situation_cycle_ref ? Do you mean the form after is show even if the invoice is not a situation invoice ? |
@@ -405,6 +405,16 @@ func findBestGroupToScaleOut(rc *cluster.RaftCluster, strategy *Strategy, scaleO
Component: component.String(),
Count: 0,
ResourceType: resources[0].ResourceType,
+ Labels: []*metapb.StoreLabel{
+ {
+ Key: groupLabelKey,
+ Value: autoScalingGroupLabelKeyPrefix + compon... | [Warn,Now,Ceil,HasPrefix,getLabelValue,Error,GetID,Seconds,New,Errorf,NewClient,GetStores,GetStore,Uint64,GetState,Query,GetLabelValue,GetEtcdClient,GetAddress,MinUint64,String,Floor] | Component is a string representing a component in the group. | it is better to leave a TODO here because we should make sure the group name is not duplicated when there are already other groups but PD still decides to create a new group. |
@@ -126,6 +126,11 @@ var Cases = []Case{
`[ { "op": "move", "from": "/foo/1", "path": "/foo/2" } ]`,
`{ "foo": [ "all", "cows", "grass", "eat" ] }`,
},
+ {
+ `{ "foo": [ "a", "b", "c", "d", "e" ] }`,
+ `[ { "op": "move", "from": "/foo/1", "path": "/foo/2" } ]`,
+ `{ "foo": [ "a", "c", "b", "d", "e" ] }`,
+ }... | [Indent,Error,Sprintf,Apply,Unmarshal,DeepEqual,String,Errorf] | Morphology of functions Morphology chains - > graph object. | before this pull, the patch would give `a, c, d, b, e` - which is incorrect. |
@@ -43,9 +43,8 @@ public class ContextPayload {
this.context = context;
}
- public static ContextPayload from(Span span) {
+ public static ContextPayload from(Context context) {
ContextPayload payload = new ContextPayload();
- Context context = Context.current().with(span);
GlobalOpenTelemetry.... | [ContextPayload->[from->[ContextPayload],ExtractAdapter->[get->[get]],read->[ContextPayload]]] | Reads a payload from an input stream. | there's still a global call in here...that seems like a problem. |
@@ -3,13 +3,14 @@ import os
import site
import sys
-
ROOT = os.path.dirname(os.path.abspath(__file__))
-path = lambda *a: os.path.join(ROOT, *a)
+
+
+def path(*parts):
+ return os.path.join(ROOT, *parts)
prev_sys_path = list(sys.path)
-site.addsitedir(path('lib'))
site.addsitedir(path('vendor'))
# Move... | [abspath,list,path,addsitedir,append,dirname,execute_from_command_line,setdefault,join,patch,remove] | Imports the n - tuple of objects from the command line. | :confetti_ball: :tada: :fireworks: Woo! One less path hack! :fireworks: :tada: :confetti_ball: |
@@ -181,7 +181,9 @@ import ProgressBar from "./ui/progressBar";
if ( window.location.hash && window.location.hash.startsWith( "#start-indexation-" ) ) {
$( ".yoast-open-indexation" ).each( function() {
if ( window.location.hash.endsWith( $( this ).data( "settings" ) ) ) {
- $( this ).click();
+ setT... | [No CFG could be retrieved] | Start the indexation if the hash matches a settings value. | @andizer Does this mean that the empty modal will still be opened on slower sites that do not load within 500 ms? |
@@ -175,6 +175,10 @@ KratosStructuralMechanicsApplication::KratosStructuralMechanicsApplication()
mLineLoadCondition2D3N(0, Condition::GeometryType::Pointer(new Line2D3<NodeType >(Condition::GeometryType::PointsArrayType(3)))),
mLineLoadCondition3D2N(0, Condition::GeometryType::Pointer(new Line3D2<NodeTyp... | [No CFG could be retrieved] | Missing block for PointContactCondition2D1N - > PointContactCondition3D1 Missing conditions for 3D - based surface load and point moment conditions. | Isn't it necessary the same Small displacements for the axisym ? @loumalouomega |
@@ -0,0 +1,11 @@
+from azure.template import template_main
+
+
+def simple_sample():
+ print("Running simple sample")
+ template_main()
+ print("Completed running simple sample")
+
+
+if __name__ == "__main__":
+ simple_sample()
| [No CFG could be retrieved] | No Summary Found. | this file should be removed too |
@@ -1902,13 +1902,10 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
}
@Override
- public HashMap<String, VolumeStatsEntry> getVolumeStatistics(long clusterId, String poolUuid, StoragePoolType poolType, List<String> volumeLocator, int timeout) {
+ public HashMap<Str... | [UserVmManagerImpl->[removeInstanceFromInstanceGroup->[expunge],applyUserData->[getName],moveVMToUser->[doInTransactionWithoutResult->[getName,resourceCountIncrement,resourceCountDecrement],removeInstanceFromInstanceGroup,resourceLimitCheck,getName,getVmId,getSecurityGroupIdList],loadVmDetailsInMapForExternalDhcpIp->[V... | Get volume statistics for a given cluster. | Well looks like it indeed is used but you removed it @GabrielBrascher ? |
@@ -24,6 +24,12 @@ module TwoFactorAuthentication
private
+ def check_personal_key_enabled
+ return if TwoFactorAuthentication::PersonalKeyPolicy.new(current_user).enabled?
+
+ redirect_to two_factor_options_url
+ end
+
def presenter_for_two_factor_authentication_method
TwoFactorAut... | [PersonalKeyVerificationController->[password_reset_profile->[password_reset_profile],generate_new_personal_key_for_verified_users_otherwise_retire_the_key_and_ensure_two_mfa->[create],remove_personal_key->[create]]] | presenter for Two Factor Authentication Method Nic. | This will block the controller for users who don't have a personal key, but don't we also want to add a condition here for users who are IAL2? |
@@ -307,6 +307,13 @@ public class JpaOperations {
return query.stream();
}
+ @Override
+ public EntityManager getEntityManager(Class<?> clazz) {
+ String clazzName = clazz.getName();
+ String persistentUnitName = entityToPersistenceUnit.get(clazzName);
+ ... | [JpaOperations->[streamAll->[streamAll],getEntityManager->[getEntityManager],getTransactionManager->[getTransactionManager],stream->[stream],findByIdOptional->[findByIdOptional],update->[update],executeUpdate->[executeUpdate],bindParameters->[bindParameters],count->[count],exists->[exists],paramCount->[paramCount],dele... | Returns a stream of the missing nodes in the query. | I wonder if we could avoid a lot of overhead by having a generated method in the PanacheEntity/Repository return a static Literal for consumption by CDI. It would avoid the overhead of the map lookup and would also avoid the overhead of instantiating a new Literal each time we want to the get EntityManager. I'm not tha... |
@@ -55,7 +55,10 @@ class Admin::GroupsController < Admin::AdminController
# group rename is ignored for automatic groups
group.name = group_params[:name] if group_params[:name] && !group.automatic
- save_group(group) { |g| GroupActionLogger.new(current_user, g).log_change_group_settings }
+ save_group... | [can_not_modify_automatic->[t,render],create->[new,save_group],bulk->[render],remove_owner->[automatic,to_i,find,reset_counters,render,log_remove_user_as_group_owner,update_all,require,id],show->[render],save_group->[automatic,messageable_level,automatic_membership_retroactive,render_json_error,incoming_email,flair_col... | update the last n - items group finds a group in the system that matches the group_params. | lets test that the event is triggered in the controllers as well :) |
@@ -79,7 +79,7 @@ class ActionCountersTest(TransactionTestCase):
user_agent=user_agent, user=user)
u2.save()
ok_(False, "This should have triggered an IntegrityError")
- except:
+ except IntegrityError:
pass
# Try get_... | [ActionCountersTest->[test_bug694544->[mk_request],test_count_starts_at_zero->[mk_request],test_action_with_min->[mk_request],test_action_count_per_unique->[mk_request],test_action_with_max->[mk_request],test_bad_multiple_counters->[mk_request],test_basic_action_increment->[mk_request]]] | Test for bad multiple action counter records. | +:100: for narrowing exception handling here and everywhere |
@@ -8,6 +8,7 @@ class DismissTopics
def perform!
DismissedTopicUser.insert_all(rows) if rows.present?
+ @rows.map { |row| row[:topic_id] }
end
private
| [DismissTopics->[perform!->[present?,insert_all],rows->[now,id,map],since_date->[previous_visit_at,created_at,new_topic_duration_minutes,max,ago,default_other_new_topic_duration_minutes]]] | Returns an array of records for the missing nodes. | return dismissed topics ids. rows are memoized so it should not affect performance |
@@ -221,6 +221,9 @@ def get_file(fname,
Returns:
Path to the downloaded file
"""
+ if origin is None:
+ raise ValueError("Please specify the 'origin' argument (URL of the file "
+ "to download)")
if cache_dir is None:
cache_dir = os.path.join(os.path.expanduser('~'), '.keras... | [urlretrieve->[chunk_read],get_file->[_extract_archive,urlretrieve],OrderedEnqueuer->[get->[get,is_running,stop],_run->[_wait_queue,_send_sequence,on_epoch_end],_get_executor_init->[pool_fn->[get_worker_id_queue,get_pool_class]]],next_sample->[next],ThreadsafeIter->[__next__->[next]],validate_file->[_hash_file],Sequenc... | Downloads a file from a URL if it not already in the cache. Download a file if it is not already present. This function is a wrapper around the base download function. It is used by the nginx. | Nit: use `'` as quote character for consistency with the rest of the file |
@@ -37,7 +37,17 @@ func GetStatistic() (stats Statistic) {
Count int64
IsClosed bool
}
+
issueCounts := []IssueCount{}
+ stats.Counter.IssueByLabel = []IssueByLabelCount{}
+
+ _ = db.GetEngine(db.DefaultContext).
+ Select("COUNT(*) AS count, l.name as label").
+ Join("LEFT", "issue_label il", "i.id=il.is... | [GroupBy,Table,Count,Find,Select,CountSources,GetEngine] | GetStatistic returns the database statistics for the individual issue types. CountSources - Count number of sources in the database. | Is there maybe a `Count` function inside `Engine`? If yes, please use that instead. Ah, I see the potential problem with that: Then you cannot customize the resulting column names any longer, right? |
@@ -227,8 +227,8 @@ var inputType = {
* @name ng.directive:input.email
*
* @description
- * Text input with email validation. Sets the `email` validation error key if not a valid email
- * address.
+ * Text input with email validation. Sets the `email` validation error key if the email
+ * address i... | [No CFG could be retrieved] | Input type directive that validates a key input with email validation. Shows a form that changes the user s which is shown when the user enters. | I don't agree here either. If it is an email address then it is valid. I don't think this needs to change except for maybe adding the word input, similar to above. |
@@ -530,6 +530,7 @@ type AgentPoolProfile struct {
AvailabilityZones []string `json:"availabilityZones,omitempty"`
SinglePlacementGroup *bool `json:"singlePlacementGroup,omitempty"`
VnetCidrs []string `json:"vnetCidr... | [GetCustomEnvironmentJSON->[IsAzureStackCloud],HasAvailabilityZones->[HasAvailabilityZones],GetUserAssignedID->[UserAssignedIDEnabled],IsMetricsServerEnabled->[isAddonEnabled],GetFirstConsecutiveStaticIPAddress->[IsVirtualMachineScaleSets],GetUserAssignedClientID->[UserAssignedClientIDEnabled],GetCustomCloudAuthenticat... | Config for a given machine - managed network network identifier. This field is readonly as it is not used by ACS RP. | I thought the conclusion of the email discussion was to enable this by default with gradual rollout? |
@@ -263,7 +263,7 @@ namespace System.Numerics
bool isNegative;
if (byteCount > 0)
{
- byte mostSignificantByte = isBigEndian ? value[0] : value[byteCount - 1];
+ byte mostSignificantByte = isBigEndian ? value[0] : value[^1];
isNegativ... | [BigInteger->[TryParse->[TryParse],Log->[Log],ToByteArray->[ToByteArray],Equals->[Equals],Log10->[Log],CompareTo->[CompareTo],Equals,ToUInt32Span,CompareTo]] | Creates a BigInteger object from a little - endian twos - complement byte array. This method returns the next non - zero value in the byte array. | Does this impact codegen at all? I could imagine this being equivalent to `value.Length - 1`, which might result in a secondary read from memory. |
@@ -1,5 +1,11 @@
+from datetime import datetime
+
import pytest
+from kuma.core.urlresolvers import reverse
+from kuma.wiki.constants import REDIRECT_CONTENT
+from kuma.wiki.models import Document, Revision
+
@pytest.fixture
def api_settings(settings):
| [api_settings->[append]] | Add a missing key to the API settings. | How devious! :-) |
@@ -22,7 +22,7 @@
reacted to
<a href="<%= reactable_data["path"] %>" class="notification-comment-reacted-link">
<%# your article/comment or the actual title of the article/comment %>
- <%= reactable_data["title"].blank? ? "your #{reactable_data['class']['name'].downcase}" : sanitize(reactable_data... | [No CFG could be retrieved] | Renders the reaction n - node. | Where does `h` come from? |
@@ -67,11 +67,11 @@ public class SimpleWatermark implements Watermark {
long startNum = lowWatermarkValue;
long endNum = highWatermarkValue;
boolean longOverflow = false;
- while (startNum <= endNum && !longOverflow) {
+ while (startNum < endNum && !longOverflow) {
longOverflow = (Long.MAX_V... | [SimpleWatermark->[getWatermarkCondition->[getCoalesceColumnNames],getIntervals->[checkArgument,info,getInterval,put],getInterval->[info,roundToLong],getLogger]] | This method calculates the intervals between the given low and high watermark values. | This is not the same logic in the overflow case. The old logic would put endNum instead of Long.MAX_VALUE for overflow case. |
@@ -604,7 +604,7 @@ func (s *HTTPSSuite) TestWithSNIDynamicConfigRouteWithTlsConfigurationDeletion(c
cn := resp.TLS.PeerCertificates[0].Subject.CommonName
if cn == tr2.TLSClientConfig.ServerName {
- return fmt.Errorf("domain %s found in place of default one", tr2.TLSClientConfig.ServerName)
+ return fmt.Err... | [TestWithSNIDynamicConfigRouteWithTlsConfigurationDeletion->[BodyContains,adaptFile,GetRequest,StatusCodeIs,NewRequest,Do,Kill,traefikCmd,Remove,Start,Close,Errorf,Assert,Set],TestWithClientCertificateAuthenticationMultipeCAs->[BodyContains,GetRequest,Dial,Kill,traefikCmd,Start,Close,Assert,Commentf,LoadX509KeyPair],Te... | TestWithSNIDynamicConfigRouteWithTlsConfigurationDeletion tests that a Traefik server Do a request and check if the connection is closed. | "domain %s found instead of `the` default one" |
@@ -16,7 +16,7 @@ class Assessment < ApplicationRecord
# Look in lib/validators/* for more info
validates :due_date, date: true
- validates_uniqueness_of :short_identifier, case_sensitive: true
+ validates_uniqueness_of :short_identifier, case_sensitive: true, scope: :course_id
validates_presence_of :short... | [Assessment->[upcoming->[due_date,nil?,current],results_median->[to_f,zero?,empty?,completed_result_marks],results_fails->[max_mark,count],percentage_grades_array->[zero?,max_mark,map],results_zeros->[count],grade_distribution_array->[fetch,histogram,extend,first,last,count],short_identifier_unchanged->[add,short_ident... | The base class for all assessments. histogram of the number of possible . | `case_sensitive: true` is the default so you can leave it out |
@@ -37,6 +37,11 @@ import (
"github.com/elastic/beats/v7/libbeat/outputs/codec"
)
+type backoffConfig struct {
+ Init time.Duration
+ Max time.Duration
+}
+
type kafkaConfig struct {
Hosts []string `config:"hosts" validate:"required"`
TLS *tlscommon.... | [configureSarama->[ToUpper,SASLMechanism,Errorf],Validate->[ToLower,Validate,New,Errorf],BuildModuleConfig,Unpack,LoadTLSConfig,Beta,configureSarama,Version,Validate,IsEnabled,ToLower,GetGoMetrics,NewConfig,Errorf,Get,RequiredAcks,Rename] | Consumes an array of events and returns a list of events that are contained in the array Maximum number of non - zero elements in a sequence. | do these need annotations (`config:"init"` etc)? |
@@ -114,6 +114,9 @@ module Engine
'withhold'
when 'half'
'half pay'
+ else
+ @extra_train_choice = 'payout'
+ 'pay out'
end
@log << "#{current_entity.id} chooses to #{text} with the #{find_extra_train... | [Dividend->[skip!->[process_dividend],process_dividend->[dividend_options,payout_shares,log_run_payout]]] | Process a single node in the game system that has a specific node in the game system. | This should raise instead (and the broken game undone to the right point) |
@@ -116,7 +116,7 @@ func MoveUnderCgroupSubtree(subtree string) error {
scanner := bufio.NewScanner(f)
for scanner.Scan() {
line := scanner.Text()
- parts := strings.Split(line, ":")
+ parts := strings.SplitN(line, ":", 3)
if len(parts) != 3 {
return errors.Errorf("cannot parse cgroup line %q", line)
... | [IsRootless,GetUserConnection,Warnf,Close,StartTransientUnit,Mkdir,HasPrefix,GetRootlessUID,ReadFile,PropSlice,New,Errorf,NewScanner,Text,Wrapf,Join,MakeVariant,Scan,Split,Write,Sprintf,IsCgroup2UnifiedMode,TrimPrefix,Open,OpenFile] | GetCgroup returns the cgroup mount of the current process. /sys fs path for cgroup. | SplitN is your friend, I'd this very lesson this week. |
@@ -50,7 +50,10 @@ class WriteListener
case 'PUT':
case 'PATCH':
case 'POST':
- $this->dataPersister->persist($controllerResult);
+ $event->setControllerResult(
+ $this->dataPersister->persist($controllerResult)
+ ... | [WriteListener->[onKernelView->[getMethod,getControllerResult,persist,isMethodSafe,setControllerResult,has,supports,getRequest,remove]]] | if the request is not a method safe and the controller result is not persisted it is removed. | CS: We usually don't split into multiple lines like this... Just keep it in one line. |
@@ -168,7 +168,7 @@ func (u *userState) getSeries(metric model.Metric, cfg *UserStatesConfig) (model
return fp, nil, httpgrpc.Errorf(http.StatusTooManyRequests, "per-user series limit (%d) exceeded", cfg.MaxSeriesPerUser)
}
- metricName, err := util.ExtractMetricNameFromMetric(metric)
+ metricName, err := extrac... | [forSeriesMatching->[get],getOrCreateSeries->[get],getViaContext->[get],getSeries->[get]] | getSeries returns the fingerprint of the series associated with the given metric. If the metric is return fp series nil . | Why isn't this change part of the previous commit? |
@@ -108,6 +108,7 @@ type decodeResponse struct {
// NewChunkFetcher makes a new ChunkFetcher.
func NewChunkFetcher(cfg cache.Config, cacheStubs bool, storage ObjectClient) (*Fetcher, error) {
+ cfg.Prefix = "chunks"
cache, err := cache.New(cfg)
if err != nil {
return nil, err
| [Stop->[Wait,Stop],worker->[Inc,Decode,Done],writeBackCache->[Encoded,Store,ExternalKey],processCacheResponse->[Log,ExternalKey,Warn],FetchChunks->[GetChunks,Finish,Warn,New,writeBackCache,processCacheResponse,Log,Fetch],Strings,Add,worker,New,Matches,Get,ExternalKey] | filterChunksByMatchers returns a slice of chunks that match the given matchers. FetchChunks fetches a set of chunks from cache and stores them in the response channel. | This has the effect that the `name` label in `cortex_cache_hits` changes from "memcache" to "chunksmemcache". Which is a (minor) breaking change that should go in the changelog. |
@@ -409,6 +409,7 @@ class FileClient(AsyncStorageAccountHostsMixin, FileClientBase):
:type copy_id: str or ~azure.storage.file.FileProperties
:rtype: None
"""
+ timeout = kwargs.pop('timeout', None)
try:
copy_id = copy_id.copy.id
except AttributeError:
| [FileClient->[upload_range_from_url->[upload_range_from_url],upload_file->[_upload_file_helper],resize_file->[set_http_headers],abort_copy->[abort_copy],clear_range->[upload_range],upload_range->[upload_range],set_http_headers->[set_http_headers]]] | Abort an ongoing copy operation. | :keyword int timeout: not in docstring |
@@ -413,16 +413,13 @@ func lastCheckpoint(dir string) (string, int, error) {
for i := 0; i < len(dirs); i++ {
di := dirs[i]
- if !strings.HasPrefix(di.Name(), checkpointPrefix) {
+ idx, err := checkpointIndex(di.Name(), false)
+ if err != nil {
continue
}
if !di.IsDir() {
return "", -1, fmt.Erro... | [Log->[Log],performCheckpoint->[Stop,Log],run->[Stop,Log],Log] | lastCheckpoint returns the directory name and index of the most recent checkpoint in the given directory. checkall - deletes all files in the checkpoint directory. | This would consider a temporary checkpoint as a valid checkpoint for the last checkpoint, which is wrong. We should be skipping them here. |
@@ -191,6 +191,17 @@ public class DoFnOperator<InputT, OutputT>
private final boolean finishBundleBeforeCheckpointing;
+ /** Stores new finalizations being gathered. */
+ private transient InMemoryBundleFinalizer bundleFinalizer;
+ /** Pending bundle finalizations which have not been acknowledged yet. */
+ p... | [DoFnOperator->[FlinkTimerInternals->[deleteTimerInternal->[onFiredOrDeletedTimer],deleteTimer->[deleteTimer,cancelPendingTimerById],onFiredOrDeletedTimer->[onRemovedEventTimer],currentSynchronizedProcessingTime->[currentProcessingTime],currentProcessingTime->[currentProcessingTime],processPendingProcessingTimeTimers->... | Private methods for the Flink component. | This constant appears to be unused. |
@@ -97,7 +97,16 @@ class CompileHelpersTest(unittest.TestCase):
'"path/to/includes/lib2"')
# Not supported yet
env = ConfigureEnvironment(BuildInfoMock(), MockWinGccSettings())
- self.assertEquals(env.command_line, "")
+ self.assertEquals(env.... | [CompileHelpersTest->[gcc_test->[MockLinuxSettings],configure_environment_test->[BuildInfoMock,MockLinuxSettings,MockWinGccSettings,MockWinSettings]]] | Test for the environment. | I don't understand this change, how is it possible that it was passing? these are the standard env flags, not really related to this feature |
@@ -957,10 +957,10 @@ def _verify_interpreter_version_is_supported(pipeline_options):
if sys.version_info[0] == 2:
return
- if sys.version_info[0] == 3 and sys.version_info[1] == 5:
- if sys.version_info[2] < 3:
+ if sys.version_info[0:2] in [(3, 5), (3, 6)]:
+ if sys.version_info[0:3] < (3, 5, 3):
... | [translate_distribution->[to_split_int],translate_value->[to_split_int],_LegacyDataflowStager->[stage_artifact->[_gcs_file_copy]],_use_unified_worker->[_use_fnapi],Environment->[__init__->[Environment]],DataflowApplicationClient->[create_job->[json,stage_file],create_job_description->[Environment,_stage_resources,stage... | Verify that interpreter version is supported. | Can we remove this warning now? IIUC, According to @tvalentyn 3.5.0 now works. |
@@ -1063,10 +1063,16 @@ function compileJs(srcDir, srcFilename, destDir, options) {
.pipe($$.rename(destFilename))
.pipe(lazywrite())
.on('end', function() {
- appendToCompiledFile(srcFilename, destDir + '/' + destFilename);
+ appendToCompiledFile(srcFile... | [No CFG could be retrieved] | The main function of the plugin. The main entry point for the compileJs function. | Cannot wait until we move to Node 8+ as a requirement so these can become async/await. |
@@ -807,7 +807,7 @@ namespace ProtoCore.DSASM
}
// Get the cached callsite, creates a new one for a first-time call
- CallSite callsite = exe.RuntimeData.GetCallSite(exe.RuntimeData.ExecutingGraphnode, classIndex, fNode.name, exe, core.RunningBlock, runtimeCore.RuntimeOptions, cor... | [No CFG could be retrieved] | Creates a new stackframe object. Creates a context object from the given arguments. | split - line too long |
@@ -530,6 +530,7 @@ type AgentPoolProfile struct {
AvailabilityZones []string `json:"availabilityZones,omitempty"`
SinglePlacementGroup *bool `json:"singlePlacementGroup,omitempty"`
VnetCidrs []string `json:"vnetCidr... | [GetCustomEnvironmentJSON->[IsAzureStackCloud],HasAvailabilityZones->[HasAvailabilityZones],GetUserAssignedID->[UserAssignedIDEnabled],IsMetricsServerEnabled->[isAddonEnabled],GetFirstConsecutiveStaticIPAddress->[IsVirtualMachineScaleSets],GetUserAssignedClientID->[UserAssignedClientIDEnabled],GetCustomCloudAuthenticat... | Config for a given machine - managed network network identifier. This field is readonly as it is not used by ACS RP. | Does this need to be an optional behavior? I think preserving custom properties should be the default. |
@@ -221,6 +221,12 @@ public class MultimediaEditFieldActivity extends AnkiActivity
if (!f.exists()) {
bChangeToText = true;
}
+
+ long length = f.length();
+ if (length > 1024 * 1024) {
+ showCropDialog((float) (1.0 ... | [MultimediaEditFieldActivity->[onRequestPermissionsResult->[recreateEditingUi],toImageField->[recreateEditingUi],toAudioClipField->[recreateEditingUi],toAudioRecordingField->[recreateEditingUi],onActivityResult->[onActivityResult],onDestroy->[onDestroy],onOptionsItemSelected->[onOptionsItemSelected],onCreate->[onCreate... | Finish the dialog. | I'd like for the limit to be a static constant at the top of the file if at all possible, defined just one place with a clear name and then just referenced |
@@ -897,6 +897,11 @@ class Beam(object):
self.eos_top_ts = None
self.n_best_counter = 0
self.min_n_best = min_n_best
+ self.block_ngram = block_ngram
+
+ @staticmethod
+ def find_ngrams(input_list, n):
+ return list(zip(*[input_list[i:] for i in range(n)]))
def get_... | [Beam->[get_beam_dot->[get_hyp_from_finished,get_rescored_finished]],TorchAgent->[get_dialog_history->[_add_person_tokens],vectorize->[_vectorize_text,_check_truncate],load->[load],observe->[get_dialog_history,last_reply,vectorize],__init__->[dictionary_class],save->[save],batch_act->[batchify,match_batch],_copy_embedd... | Initialize the object with the properties of the base class. | wouldn't mind a proper docstring here, but (y) |
@@ -96,6 +96,12 @@ const translationDefaultConfig = {
},
};
+const kubernetesDefaultConfig = {
+ kubernetesServiceType: 'LoadBalancer',
+ monitoring: 'no',
+ istio: false,
+};
+
/** Required config for prompts to be skipped, baseName is missing */
const requiredDefaultConfig = {
...appRequiredConfig,
| [No CFG could be retrieved] | Creates a configuration object for the application. This is a convenience method for retrieving all the metamodel s fields and relationships. | Thinking about modularization, I think we should move to the Kubernetes folder, like I did with init generator. You can import here and reexport for a clean api, this is the new standard for esm/node. |
@@ -275,6 +275,15 @@ def test_populate_e10s_feature_compatibility():
addon_webextension.get_latest_file(), 'webextension.xpi')
assert storage.exists(addon_webextension.get_latest_file().file_path)
+ # One must be unlisted, and compatible.
+ addon_compatible_unlisted = addon_factory(
+ guid=... | [test_approve_addons_get_files->[get_files],test_force_signing->[call_command,setattr],test_approve_addons_approve_files_no_review_type->[approve_files,get,update,addon_factory,user_factory,reload],test_reason->[call_command,setattr],test_populate_e10s_feature_compatibility->[AMOPaths,update,addon_factory,call_command,... | Test populate_e10s_feature_compatibility. This method checks if there is a PK in the addon - compatible. feature_compatibility. | this can be added as another `kw` argument to `addon_factory` |
@@ -61,6 +61,9 @@ public class BaselineMojo extends AbstractMojo {
@Parameter(property = "bnd.baseline.continue.on.error", defaultValue = "false")
private boolean continueOnError;
+ @Parameter(property = "bnd.baseline.compare.to.snapshot", defaultValue = "true")
+ private boolean compareToShanpshot;
+
@... | [BaselineMojo->[searchForBaseVersion->[getClassifier,debug,setVersion,VersionRangeRequest,DefaultArtifact,resolveVersionRange,getGroupId,getHighestVersion,getArtifactId,getVersions,info,toString,getExtension,getVersion],setupBase->[getClassifier,debug,setArtifactId,setGroupId,setClassifier,getGroupId,setExtension,getAr... | Creates a BaselineMojo which converts the base version of the given package into OS Check if the base jar is available and if so report it. | This variable name is misspelled. |
@@ -23,7 +23,10 @@ func (bs *DockerBuildStrategy) CreateBuildPod(build *buildapi.Build) (*api.Pod,
if build.Input.DockerInput != nil {
contextDir = build.Input.DockerInput.ContextDir
}
-
+ buildJson, err := json.Marshal(build)
+ if err != nil {
+ return nil, err
+ }
pod := &api.Pod{
TypeMeta: api.TypeMeta{... | [No CFG could be retrieved] | CreateBuildPod creates a pod with the given build. | Should this go through the usual codec encoding path rather than a vanilla json processing? @smarterclayton |
@@ -287,6 +287,11 @@ class AmpJWPlayer extends AMP.BaseElement {
this.contentBackfill_ = element.getAttribute('data-content-backfill') || '';
this.contentRecency_ = element.getAttribute('data-content-recency') || '';
+ // Allow outstream playback
+ if (this.contentid_ === 'outstream') {
+ this.co... | [No CFG could be retrieved] | This method is called when the user has requested to embed a single - line video. Listen to message and send fullscreen change to player to update ui. | Can we avoid adding a generic remapping of 'outstream' to 'oi7pAMI1'? This appears to be a value that could be specified as the consent id. |
@@ -875,4 +875,18 @@ public class Constants {
public static final String METRICS_PROTOCOL = "metrics.protocol";
+ /**
+ * Serizlization ContentTypeId
+ */
+ public static final byte AVRO_SERIALIZATION_ID = 1;
+ public static final byte HESSIAN2_SERIALIZATION_ID = 2;
+ public static final by... | [Constants->[getName,min,availableProcessors,compile]] | Replies the metrics protocol. | this is wrong, avro is 10... |
@@ -62,6 +62,8 @@ public class FlinkJobInvoker implements JobInvoker {
LOG.info("Invoking job {}", invocationId);
flinkOptions.setFlinkMaster(firstNonNull(flinkOptions.getFlinkMaster(), flinkMasterUrl));
+ flinkOptions
+ .setFilesToStage(detectClassPathResourcesToStage(FlinkJobInvoker.class.getCla... | [FlinkJobInvoker->[invoke->[create],create->[FlinkJobInvoker]]] | Invoke a Flink job with a specific allocation token. | This overwrites filesToStage specified in the user's pipeline options with the classpath of job server. - Are the user's filesToStage supposed to already have been staged by now so it's irrelevant? - Who stages these filesToStage? It's definitely not the artifact staging service anymore, right? |
@@ -7,6 +7,7 @@ class Checklist < ActiveRecord::Base
belongs_to :created_by, foreign_key: 'created_by_id', class_name: 'User'
belongs_to :last_modified_by, foreign_key: 'last_modified_by_id', class_name: 'User'
has_many :checklist_items,
+ -> { order(:position) },
inverse_of: :checklist,
dependent... | [Checklist->[search->[select,where_attributes_like,offset,map],accepts_nested_attributes_for,include,belongs_to,validates,has_many]] | The base class for all checks in a checklist. | Align the parameters of a method call if they span more than one line. |
@@ -94,6 +94,15 @@ export class Xhr {
constructor(win) {
/** @const {!Window} */
this.win = win;
+
+ // TODO(@jridgewell, #9048): Once we figure out if ampdoc can always be
+ // found, remove the try catch.
+ try {
+ this.ampdoc_ = ampdocServiceFor(win).getAmpDoc();
+ } catch (e) {
+ ... | [No CFG could be retrieved] | A service that polyfills Fetch API for use within AMP. This is the main function that is called by the fetch process. It does all the necessary. | The probability of failure in PWA case here is about 100% :). I think we just need to restrict this reporting/warning to single-doc mode. The real issue is only in this mode anyway. See `AmpDocService.isSingleDoc()` |
@@ -70,7 +70,12 @@ func (s *Server) StreamAggregatedResources(server discovery.AggregatedDiscoveryS
continue
}
- typeURL := envoy.TypeURI(discoveryRequest.TypeUrl)
+ typeURL, ok := envoy.ValidURI[discoveryRequest.TypeUrl]
+ if !ok {
+ log.Error().Err(err).Msgf("Unknown/Unsupported URI: %s", discover... | [StreamAggregatedResources->[Context,Msgf,SetLastAppliedVersion,Wrap,ValidateClient,Info,Done,sendAllResponses,Error,TypeURI,GetCommonName,GetIPFromContext,Debug,GetLastSentNonce,UnregisterProxy,GetLastSentVersion,newAggregatedDiscoveryResponse,GetServiceFromEnvoyCertificate,SetLastSentVersion,GetAnnouncementsChannel,S... | StreamAggregatedResources streams aggregated resources from Envoy This function is called when a request is received from Envoy. It is called by the This function is called when a new version of the DiscoveryRequest is received. | Remove the TODO if unnecessary. I see above we are continuing on errors. |
@@ -194,7 +194,7 @@ async def serialize_property(value: 'Input[Any]',
value = _types.input_type_to_dict(value)
transform_keys = False
- if isinstance(value, Mapping): # pylint: disable=bad-option-value,isinstance-second-argument-not-valid-type
+ if isinstance(value, abc.Mapping):
obj... | [serialize_property->[serialize_property,isLegalProtobufValue],unwrap_rpc_secret->[is_rpc_secret],translate_output_properties->[unwrap_rpc_secret,is_rpc_secret,translate_output_properties],contains_unknowns->[impl->[impl],impl],deserialize_property->[deserialize_properties,unwrap_rpc_secret,is_rpc_secret,deserialize_pr... | Serializes a single Input into a form suitable for remoting to the engine. Serialize a object. Convert input type to a dict and transform keys if necessary. | While the previous code worked, we should be checking against the abstract base class from `collections.abc` rather than the type from `typing`. |
@@ -128,8 +128,8 @@ class GraphParser(Model):
@overrides
def forward(self, # type: ignore
tokens: Dict[str, torch.LongTensor],
+ metadata: List[Dict[str, Any]],
pos_tags: torch.LongTensor = None,
- metadata: List[Dict[str, Any]] = None,
... | [GraphParser->[_construct_loss->[,_arc_loss,size,_tag_loss,sum,float,view,unsqueeze],forward->[,_construct_loss,text_field_embedder,head_arc_feedforward,_dropout,ConfigurationError,tag_bilinear,cat,head_tag_feedforward,_pos_tag_embedding,get_text_field_mask,child_arc_feedforward,child_tag_feedforward,_input_dropout,_gr... | Forward computation of the SequenceLabelField. Get the tag and probability of a tag or arc. Missing tag - value dictionary. | I'd probably default to making this optional instead of moving the parameter, but I could go either way. |
@@ -393,6 +393,11 @@ class CollectionAddProducts(BaseMutation):
update_products_discounted_prices_of_catalogues_task.delay(
product_ids=[pq.pk for pq in products]
)
+ transaction.on_commit(
+ lambda: [
+ info.context.plugins.product_updated(pro... | [ProductMediaUpdate->[Arguments->[ProductMediaUpdateInput],perform_mutation->[save,ProductMediaUpdate]],CollectionCreate->[save->[save],Arguments->[CollectionCreateInput],perform_mutation->[CollectionCreate]],CollectionReorderProducts->[perform_mutation->[CollectionReorderProducts]],ProductTypeUpdate->[Arguments->[Prod... | Perform a mutation on a collection. | Should we make queryset with prefetched needed data from `products` list? |
@@ -111,8 +111,6 @@ class rTorrentAPI(GenericClient):
label = sickbeard.TORRENT_LABEL
if result.show.is_anime:
label = sickbeard.TORRENT_LABEL_ANIME
- if label:
- torrent.set_custom(1, label.lower())
if sickbeard.TORRENT_PATH:
... | [rTorrentAPI->[testAuthentication->[_get_auth]],rTorrentAPI] | Add a torrent file to the torrent. | still need to torrent.set_custom(1, label) |
@@ -51,7 +51,11 @@ public class CdContextCompleter implements OptionCompleter {
if (parts[i].isEmpty()) {
resource = resource.findAncestor(RootResource.class);
} else {
- resource = resource.getChild(parts[i]);
+ try {
+ ... | [CdContextCompleter->[complete->[getGivenCompleteValue,split,getChildrenNames,endsWith,findAncestor,substring,isLeaf,lastIndexOf,addCompleterValue,isEmpty,getActiveResource,addAllCompleterValues,getChild,length,setAppendSpace,startsWith],getChildrenNames->[forEach,emptyList,add]]] | Completes the given completion value. | Won't this just NPE in the next line instead though? |
@@ -320,7 +320,8 @@ def analyze_class_attribute_access(itype: Instance,
is_lvalue: bool,
builtin_type: Callable[[str], Instance],
not_ready_callback: Callable[[str, Context], None],
- ... | [add_class_tvars->[add_class_tvars],analyze_class_attribute_access->[handle_partial_attribute_type],analyze_member_access->[analyze_member_access]] | Analyze a class attribute access. | Add docstring. At least describe `report_type`. |
@@ -131,8 +131,9 @@ Markus::Application.configure do
###################################################################
# Location of the public and private key for the git user on the system
- GITOLITE_SETTINGS = { public_key: "/home/git/git.pub",
- private_key: "/home/git/.ssh/id_rsa"... | [env,to_s,consider_all_requests_local,exists?,cache_classes,dirname,log_level,weeks,deprecation,whiny_nils,read,join,configure,instance_eval,raise_delivery_errors,precompile,auto_explain_threshold_in_seconds] | Directory where repositories will be created. Make sure MarkUs is allowed to write to this directory. | Unnecessary spacing detected. |
@@ -262,4 +262,17 @@ class WPSEO_Metabox_Formatter {
*/
return apply_filters( 'wpseo_is_markdown_enabled', $is_markdown );
}
+
+ /**
+ * Checks whether word form recognition is active for the used language.
+ *
+ * @param string $language The used language.
+ *
+ * @return boolean Whether word form recogn... | [WPSEO_Metabox_Formatter->[get_values->[get_values]]] | Checks whether markdown support is active in the readability - and seo - analysis. | I think it's better to move this entire function to `WPSEO_Language_Utils`, as we might need this check in other places too. |
@@ -33,9 +33,11 @@ module Engine
return {} unless entity.company?
choices = @game.company_choices(entity, :stock_round)
- if !choices.empty? && entity.id == @game.class::COMPANY_OSTH
- return {} if @bid_actions.positive? || @game.player_debt(entity.owner).positive?
+ ... | [BuySellParShares->[process_par->[available_par_cash,pass!,can_buy?],process_buy_shares->[pass!],can_ipo_any?->[available_par_cash,can_buy?],can_buy?->[available_cash],get_par_prices->[available_par_cash],available_par_cash->[available_cash],can_bid?->[num_certs_with_bids],add_bid->[pass!],process_choose_ability->[avai... | Returns a block of choices that can be used to determine the choices of an entity. | Did rubocop autocorrect do the `!empty?` -> `any?` thing? IIRC `!empty?` is more performant for the compiled JS in cases where `x.any?` is meant to mean the same thing as `x.size > 0`. (`[nil].any?` returns false, so in cases where the array might have `nil` elements we can't just use `!x.empty?`, but often it just mea... |
@@ -2,7 +2,7 @@ from typing import (Dict, List, Set, Iterator, Union)
from contextlib import contextmanager
from mypy.types import Type, AnyType, PartialType
-from mypy.nodes import (Key, Node, Expression, Var, RefExpr, SymbolTableNode)
+from mypy.nodes import (Key, Expression, Var, RefExpr, literal, literal_hash)
... | [ConditionalTypeBinder->[invalidate_dependencies->[get,_cleanse_key],_add_dependencies->[_add_dependencies],allow_jump->[Frame],__init__->[Frame],pop_frame->[update_from_options],handle_continue->[unreachable,allow_jump],get->[_get],frame_context->[allow_jump,push_frame,pop_frame],top_frame_context->[push_frame,pop_fra... | A class that represents a specific point in the execution of a program. A list of frames that can escape the given string into a type. | While you're at it drop the parentheses. |
@@ -45,4 +45,15 @@ public class DeferredExpressionResolver {
}
}
+ public <T> String getExpression(ParameterResolver<T> expr) {
+ if (expr == null) {
+ return null;
+ } else if (!expr.getExpression().isPresent()
+ || !muleContext.getExpressionManager().isExpression(expr.getExpression().get(... | [DeferredExpressionResolver->[resolveExpression->[getValue,resolve,isExpression,build,isPresent,get]]] | Resolve expression. | do you still need this? Which SDK issue is still pending for this to still live? |
@@ -56,9 +56,9 @@ try:
def libs_str(self):
libs = [
- "-Wl,--whole-archive",
+ whole_start,
"-lpaddle_gserver",
- "-Wl,--no-whole-archive",
+ whole_end,
"-lpaddle_pserver",
"-lpaddle_tr... | [PaddleLDFlag->[libs_str->[append,len,filter,join,normalize_flag],cmake_bool->[endswith],parent_dir_str->[join,map],ldflag_str->[libs_dir_str,parent_dir_str,join,libs_str],normalize_flag->[split,cmake_bool,len,startswith,join,map],libs_dir_str->[join,map],__init__->[abspath,cmake_bool]]] | Returns a string representation of the library flags. | for apple, do we need to use " "-Wl,-force_load" instead, as what you does in cmake |
@@ -36,8 +36,6 @@ import org.junit.jupiter.params.provider.MethodSource;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.triplea.java.collections.IntegerMap;
-import org.triplea.util.Triple;
-import org.triplea.util.Tuple;
@ExtendWith(MockitoExtension.class)
class TotalPowe... | [TotalPowerAndTotalRollsTest->[SortAaHighToLowTest->[testAttacking->[setupUnitAttachment],testDefending->[setupUnitAttachment]],GetAaUnitPowerAndRollsForNormalBattles->[unitWithZeroRollsAlwaysGetsZeroPower->[givenUnit],strongestAaGetsSupport->[givenUnit],unitWithZeroPowerAlwaysGetsZeroRolls->[givenUnit]],GetUnitPowerAn... | Imports the packages for the unit. given a unitSupportAttachment returns a new unitType with the given name and diceType. | In a later PR, I'll split this test apart so that the AA tests are in `AaPowerStrengthAndRollsTest` and the non-AA are in `PowerStrengthAndRollsTest`. I didn't do it as part of this PR because I wanted to be able to show that I didn't break any of the existing tests. |
@@ -454,7 +454,7 @@ exec(compile(open(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
'easy-install.pth')
paths_to_remove.add_pth(easy_install_pth, './' + easy_install_egg)
- elif os.path.isfile(develop_egg_link):
+ elif develop_egg... | [parse_requirements->[parse_requirements,from_line,from_editable],RequirementSet->[cleanup_files->[remove_temporary_source],install->[remove_temporary_source,rollback_uninstall,install,uninstall,values,commit_uninstall],uninstall->[values,commit_uninstall,uninstall],create_bundle->[_clean_zip_name,bundle_requirements],... | Uninstalls a critical version of this requirement. Find all packages that are not in the namespace_packages. txt and have a package in Find console scripts that are not installed. | your updated version of `egg_link_path` will only return a path that exists, so there's no need to keep the `isfile` check here |
@@ -552,10 +552,12 @@ public class IndexTask extends AbstractTask
this.dataSchema = dataSchema;
this.ioConfig = ioConfig;
- this.tuningConfig = tuningConfig == null
- ?
- new IndexTuningConfig(null, null, null, null, null, null, null, null, (File) n... | [IndexTask->[IndexTuningConfig->[withBasePersistDirectory->[IndexTuningConfig]],makeId,makeDataSource]] | Returns the data schema for a sequence of nodes. | Avoid warnings on construction, since constructors get called on deserialization in many contexts. Also, is this useful, given there is another check is the task itself? |
@@ -36,9 +36,17 @@ func (t *operations) Setup() error {
}
func (t *operations) Cleanup() error {
+ if err := t.BaseOperations.Cleanup(); err != nil {
+ return err
+ }
+
return nil
}
+func (t *operations) Apply(endpoint *metadata.NetworkEndpoint) error {
+ return t.BaseOperations.Apply(endpoint)
+}
+
// Handl... | [HandleSessionExit->[Stop],Setup->[ListenAndServe,Info]] | Cleanup is called when the session is exiting. | `return t.BaseOperations.Cleanup()` but I don't think you need this at all if `t` is embedding `BaseOperations` |
@@ -0,0 +1,16 @@
+class AddPhoneConfirmedToOtpRequestsTracker < ActiveRecord::Migration[5.1]
+ disable_ddl_transaction!
+
+ def up
+ add_column :otp_requests_trackers, :phone_confirmed, :boolean
+ change_column_default :otp_requests_trackers, :phone_confirmed, false
+ add_index :otp_requests_trackers, ["phon... | [No CFG could be retrieved] | No Summary Found. | This works, but why not just put this on the previous line with `default: false`? |
@@ -285,6 +285,9 @@ func NewFuncMap() []template.FuncMap {
}
return false
},
+ "svg": func(icon string, size int) template.HTML {
+ return template.HTML(fmt.Sprintf(`<svg class="svg" width="%d" height="%d"><use xlink:href="%s/img/svg/icons.svg#%s" /></svg>`, size, size, setting.StaticURLPrefix, icon))
+ ... | [Title,Nanoseconds,LastIndex,Indent,Warn,Sanitize,Count,Front,HasPrefix,GetDefinitionForFilename,EncodeSha1,HTML,Error,Format,Sprint,Marshal,TrimLeftFunc,New,NewPushCommits,GetContent,RenderCommitMessage,RenderCommitMessageSubject,MustCompile,Since,TrimSpace,Next,HTMLEscapeString,FindIndex,Ext,NewReplacer,Split,EscapeS... | NewTextFuncMap returns a function map that returns the functions used to render the template. returns a string representation of the application version version built - with domain date format long date. | If the icons.svg sprite will only contain octicon. I would suggest using `svg-octicon` as the helper name. Futhermore auto-prefix with octicon- the hash to not have repated at each calls. |
@@ -2039,6 +2039,17 @@ Error:
return errorCode;
}
+JsErrorCode WScriptJsrt::ReportModuleCompletionCallback(JsModuleRecord module, JsValueRef exception)
+{
+ if (exception != nullptr)
+ {
+ JsValueRef specifier = JS_INVALID_REFERENCE;
+ ChakraRTInterface::JsGetModuleHostInfo(module, JsModuleH... | [No CFG could be retrieved] | private static final int _MAX_PATH = 64 ; Initialize a module record. | Callback used when a module completes - returns the exception if the completion was not a normal completion. This had to be added to support asynchronous module completion - note see below if the callback is not set engine will fallback to direct reporting for modules without Top Level Await to avoid any compatability ... |
@@ -371,9 +371,13 @@ def attrs(ctx, *args, **kw):
def side_nav(context, addon_type, category=None):
app = context['request'].APP.id
cat = str(category.id) if category else 'all'
- return cached(
- lambda: _side_nav(context, addon_type, category),
- 'side-nav-%s-%s-%s' % (app, addon_type, cat... | [timesince->[timesince],license_link->[render],switch_is_active->[switch_is_active],remora_url->[remora_url],_site_nav->[render,sorted_cats],PaginationRenderer->[range->[range]],static->[cache_buster],_side_nav->[render],media->[cache_buster],shuffle->[shuffle],page_title->[page_name],services_url->[url],numberfmt->[_g... | Generates a side - nav view for the given addon type and category. | fwiw, I can't see how this key would be particularly long. `app`, `addon_type` and `cat` are all constant ids so pretty short numbers. |
@@ -468,6 +468,10 @@ def _write_one_source_space(fid, this, verbose=None):
else:
raise ValueError('Unknown source space type (%d)' % this['type'])
+ data = this.get('subject_HIS_id', None)
+ if data:
+ write_string(fid, FIFF.FIFF_SUBJ_HIS_ID, data)
+
if this['type'] == 'vol':
... | [write_source_spaces->[write_source_spaces_to_fid],read_source_spaces->[read_source_spaces_from_tree],_read_one_source_space->[patch_info]] | Write one source space to file. Write the n - ary chains to the file descriptor. | can you just write subject_HIS_id as subject_his_id for naming conventions? thx |
@@ -35,8 +35,14 @@ class GoalExecutor(object):
"""
goal_workdir = os.path.join(self._context.options.for_global_scope().pants_workdir,
self._goal.name)
+
+ # Python 3.4 doesn't allow calling reversed on OrderedDict.items(). Every other interpreter is fine.
+ try:
+ ... | [RoundEngine->[TargetRootsReplacement->[propose_alternates->[ConflictingProposalsError]],attempt->[sort_goals,_prepare,attempt,_propose_alternative_target_roots],_visit_goal->[TaskOrderError,MissingProductError,_visit_goal],sort_goals->[_topological_sort,_visit_goal],_propose_alternative_target_roots->[TargetRootsRepla... | Attempts to execute the next task in the order of the goal s tasks in installed order. | Very weird Py3.4 quirk. Using the `try` construct because `future.utils` doesn't have `PY34` and I don't like using `sys.info`. |
@@ -218,12 +218,11 @@ namespace Microsoft.Extensions.Caching.Memory
internal void InvokeEvictionCallbacks() => _tokens?.InvokeEvictionCallbacks(this);
- // this simple check very often allows us to avoid expensive call to PropagateOptions(CacheEntryHelper.Current)
- [MethodImpl(MethodImplOpti... | [CacheEntry->[CheckForExpiredTime->[SetExpired],ExpirationTokensExpired->[SetExpired]]] | This method is called by the cache entry s eviction callbacks. | Why did you move the `AbsoluteExpiration` check out of this method? |
@@ -36,8 +36,8 @@ class SodShockTubeTest(KratosUnittest.TestCase):
def setUp(self):
self.print_output = False
self.print_reference_values = False
- self.check_absolute_tolerance = 1.0e-8
- self.check_relative_tolerance = 1.0e-10
+ self.check_absolute_tolerance = 1.0e-7
+ ... | [SodShockTubeTest->[_CustomizeTestSettings->[_AddReferenceValuesOutput,parameters,_AddReferenceValuesCheck,_AddOutput],_AddReferenceValuesOutput->[parameters,format,Parameters,json_output_settings],_AddOutput->[gid_output_settings,parameters,format,Parameters],_RunSodShockTubeTest->[Run,WorkFolderScope,Model,FluidDynam... | Sets up the object variables based on the passed in configuration file. | to me this tolerance does not appear to be that strict. Are u sure we don't have any pending problem with parallelism? |
@@ -404,7 +404,7 @@ func (a AssertionUID) CheckAndNormalize(_ AssertionContext) (AssertionURL, error
}
func (a AssertionTeamID) ToLookup() (key, value string, err error) {
- return "tid", a.Value, nil
+ return "id", a.Value, nil
}
func (a AssertionTeamID) CheckAndNormalize(_ AssertionContext) (AssertionURL, err... | [MatchSet->[MatchSet,matchSet],CollectUrls->[CollectUrls],HasOr->[HasOr],NeedsParens->[NeedsParens,HasOr],HasFactor->[MatchSet],String->[String],IsUID,CollectUrls,IsRemote,IsFingerprint,IsSocial,CheckAndNormalize,String,ToKeyValuePair,IsKeybase] | ToLookup returns the key - value pair for the TeamID. | Why was this the right idea? |
@@ -163,14 +163,16 @@ func (cm *CertManager) issue(cn certificate.CommonName, validityPeriod time.Dura
}
certPrivKey, err := rsa.GenerateKey(rand.Reader, cm.keySize)
if err != nil {
- log.Error().Err(err).Str(errcode.Kind, errcode.ErrGeneratingPrivateKey.String()).
+ // TODO: Need to push metric?
+ log.Error()... | [IssueCertificate->[GetSerialNumber,Msgf,Now,getFromCache,Since,issue,Debug],ListCertificates->[RUnlock,RLock],certificaterFromCertificateRequest->[SerialNumber,CommonName,String,GetIssuingCA,DecodePEMCertificate],RotateCertificate->[GetSerialNumber,Unlock,Msgf,Now,Lock,Publish,GetServiceCertValidityPeriod,Since,issue,... | issue creates a new certificate and returns it. EncodeCertReqDERtoPEM encodes a certificate request to PEM and returns the certificate. | What are these TODOs referring to, given all error codes are being generated with metrics? |
@@ -374,13 +374,13 @@ if (LCDHEIGHT > 32) {
void send_command(uint8_t command) {
micro_oled_transfer_buffer[0] = I2C_COMMAND;
micro_oled_transfer_buffer[1] = command;
- i2c_transmit(I2C_ADDRESS_SA0_1 << 1, micro_oled_transfer_buffer, 2, 100);
+ i2c_transmit(I2C_ADDRESS_SA0_0 << 1, micro_oled_transfer_buffer, 2... | [clear_screen->[set_column_address,send_data,set_page_address],send_buffer->[set_column_address,send_data,set_page_address],draw_line_hori->[draw_line],draw_char->[draw_pixel],set_page_address->[send_command],draw_line_vert->[draw_line],draw_line->[draw_pixel],draw_rect_soft->[draw_line_vert,draw_line_hori],draw_rect_f... | Sends a command to the slave. | Is this correct? @jackhumbert @ishtob |
@@ -335,6 +335,14 @@ public final class AsciiString extends ByteString implements CharSequence, Compa
}
}
+ public int hashCodeCaseInsensitive() {
+ if (caseInsensitiveHashCode == CASE_INSENSITIVE_HASHER.emptyHashValue() && length() > 0) {
+ caseInsensitiveHashCode =
+ ... | [AsciiString->[contains->[indexOf],lastIndexOf->[b2c,lastIndexOf,charAt],newInstance->[AsciiString],of->[AsciiString],equals->[equals],compareToIgnoreCase->[compare],toUpperCase->[toUpperCase,AsciiString],copy->[b2c],subSequence->[subSequence],compare->[compare],concat->[charAt,AsciiString,c2b],compareTo->[charAt,b2c],... | Returns the character at the specified index. | cache the length in a local var ? |
@@ -107,9 +107,10 @@ class PlatformRepository extends ArrayRepository
continue;
}
- $lib = new CompletePackage('lib-'.$name, $version, $prettyVersion);
- $lib->setDescription('The '.$name.' PHP library');
+ $lib = new CompletePackage('lib-' . $name, $vers... | [PlatformRepository->[initialize->[normalize,setDescription,getVersion]]] | Initializes the package. Checks if a package is missing a package and if so adds it to the packages list. | These changes should also be reverted (as well as the equivalent line 64-65) |
@@ -196,6 +196,9 @@ module T::Private::Methods
end
original_method = mod.instance_method(method_name)
+ while !original_method.owner.equal?(mod)
+ original_method = original_method.super_method
+ end
sig_block = lambda do
T::Private::Methods.run_sig(hook_mod, method_name, original_met... | [_on_method_added->[add_module_with_final,_check_final_ancestors,add_final_method],set_final_checks_on_hooks->[_hook_impl],_hook_impl->[add_module_with_final,_check_final_ancestors,module_with_final?],run_all_sig_blocks->[run_sig_block_for_key],build_sig->[signature_for_method],singleton_method_added->[_on_method_added... | Checks if a method has a and if so invokes it. If it does it calls This is the entry point for the new method. It is called by sig_block_ add a module to the hook_mod if it doesn t exist. | Can you explain what this while loop is for? |
@@ -178,9 +178,9 @@ class AutoAugment(torch.nn.Module):
else:
raise ValueError("The provided policy {} is not recognized.".format(policy))
- def _get_magnitudes(self, num_bins: int, image_size: List[int]) -> Dict[str, Tuple[Tensor, bool]]:
+ def _augmentation_space(self, num_bins: int, ima... | [AutoAugment->[forward->[_apply_op,_get_magnitudes,get_params]]] | Returns a list of transforms for the given sequence of thresholds. A list of tuples of all CIFAR10 properties. Best guess of the order of the values in the order they are defined. Returns the magnitudes for the given binning and image size. | Even thought this is a private method, I decided to use the terminology of the TrivialAugment paper as I think it describes better what we get back (combination of permitted ops and magnitudes) for the given augmentation. |
@@ -74,7 +74,7 @@ public class JGroupsConfigBuilder {
};
static {
- JGROUPS_STACK = LegacyKeySupportSystemProperties.getProperty("infinispan.test.jgroups.protocol", "protocol.stack", "tcp");
+ JGROUPS_STACK = LegacyKeySupportSystemProperties.getProperty("infinispan.test.jgroups.protocol", "protocol.... | [JGroupsConfigBuilder->[JGroupsProtocolCfg->[replaceProtocol->[addProtocol],containsProtocol->[getProtocol]],getUdpConfig->[removeMerge]]] | Returns the config file for the JGroups stack. | I'm a bit concerned about changing the default to `udp` because we've had problems with multicasting on Macs before, but I guess it's already the default in the server so it must be working now. Also, I'm thinking about changing the name to `infinispan.test.jgroups.stack`, using `infinispan.test.jgroups.protocol` as fa... |
@@ -178,17 +178,10 @@ func (ic *ContainerEngine) playKubePod(ctx context.Context, podName string, podY
return nil, err
}
- // check for name collision between pod and container
+ // Assert the pod has a name
if podName == "" {
return nil, errors.Errorf("pod does not have a name")
}
- for _, n := range pod... | [playKubePVC->[WithVolumeUID,Wrapf,GetAnnotations,WithVolumeOptions,NewVolume,Name,TrimSpace,GetLabels,WithVolumeGID,GetName,Errorf,WithVolumeDriver,WithVolumeLabels,Atoi,WithVolumeName],playKubePod->[Warn,NewPodSpecGenerator,InitializeVolumes,Close,HardwareAddr,Wrap,ToSpecGen,MountPoint,WithVolumeName,NewSpecGenerator... | playKubePod plays a Kubernetes pod support properly with a good ux Initialize the podman volumes and create a podman volume for all the volumes that have been Create files and add data to the volume mountpoint based on the Items in the volume This function creates a pod and all init containers Generate all the necessar... | I'm just wondering if it makes sense to keep this warning in play, although maybe changing the wording a bit, to let the user know of the collision so they could adjust afterwards if they wanted to. I agree with dropping the auto renam though. |
@@ -137,7 +137,7 @@ int ossl_rsa_todata(RSA *rsa, OSSL_PARAM_BLD *bld, OSSL_PARAM params[])
goto err;
/* Check private key data integrity */
- if (rsa_d != NULL) {
+ if (include_private && rsa_d != NULL) {
int numprimes = sk_BIGNUM_const_num(factors);
int numexps = sk_BIGNUM_cons... | [No CFG could be retrieved] | region Private Key Functions The function to check if the n - tuple of parameters is valid. | I am not sure if this logic is right or not ?? - should having no private selection remove the factors/exp and coeff's? |
@@ -180,7 +180,7 @@ def ctc_greedy_decoder(inputs, sequence_length, merge_repeated=True):
only the first of these is emitted. The sequence `A B B * B * B` (where '*'
is the blank label) becomes
- * `A B` if `merge_repeated=True`.
+ * `A B B B` if `merge_repeated=True`.
* `A B B B B B` if `merge_repe... | [ctc_loss->[_ctc_loss,TypeError,transpose,isinstance],ctc_greedy_decoder->[SparseTensor,_ctc_greedy_decoder],_CTCLossGrad->[_BroadcastMul],ctc_beam_search_decoder->[zip,SparseTensor,_ctc_beam_search_decoder],RegisterGradient,RegisterShape,NotDifferentiable] | Performs greedy decoding on the logits given in input. Get the most likely probable value for the given type. | Could you change this to \* `A B B B B` if `merge_repeated=False`? |
@@ -51,3 +51,11 @@ func ParseUserAndRole(ctx *cli.Context) (string, keybase1.TeamRole, error) {
}
return username, role, nil
}
+
+func ParsePermanence(ctx *cli.Context) (bool, error) {
+ permanence := ctx.String("permanence")
+ if permanence != "true" && permanence != "false" {
+ return false, errors.New("permane... | [Args,ToUpper,String,New] | returns username role. | should this be a general `parseBoolean(ctx *cli.Context, var_name string, default_value boolean)`? unsure because other methods here aren't generic |
@@ -485,12 +485,15 @@ class Context(object):
return free.value, total.value
def push(self):
- """Push context
+ """
+ Pushes this context on the current CPU Thread.
"""
driver.cuCtxPushCurrent(self.handle)
def pop(self):
- """Pop context
+ """
... | [Device->[__del__->[reset],reset->[clear],__init__->[TrashService]],host_memory_size->[host_memory_extents],Driver->[__new__->[__new__],is_available->[initialize],__getattr__->[initialize],reset->[reset],__init__->[find_driver],_check_error->[CudaAPIError]],device_to_device->[device_pointer],Module->[unload->[unload_mo... | Push and pop context - by - ref. | "Pops this context off the current CPU thread"? |
@@ -525,7 +525,7 @@ func (b *localBackend) apply(
} else {
link, err = b.bucket.SignedURL(context.TODO(), b.stackPath(stackName), nil)
if err != nil {
- return changes, result.FromError(errors.Wrap(err, "Could not get signed url for stack location"))
+ cmdutil.Diag().Warningf(diag.Message("", "Could no... | [GetHistory->[Name],CreateStack->[Name],Refresh->[GetStack],ExportDeployment->[Name],GetStack->[Name],RenameStack->[Name,RenameStack],Update->[GetStack],Destroy->[GetStack],ListStacks->[GetStack],RemoveStack->[Name],ImportDeployment->[Name],Preview->[GetStack],Query->[GetStack],GetLogs->[Name],apply->[Name,Refresh,Upda... | apply applies an update to a stack Updates the state of a managed object. addToHistory adds a checkpoint to the stack and backups it. Colorize a CollectionLink object. | 1. why did this change? 2. Why have this be a warning? |
@@ -395,9 +395,10 @@ public abstract class AbstractTableFileSystemView implements SyncableFileSystemV
public final Stream<HoodieBaseFile> getLatestBaseFilesInRange(List<String> commitsToReturn) {
try {
readLock.lock();
- return fetchAllStoredFileGroups().map(fileGroup -> Option.fromJavaOptional(
+ ... | [AbstractTableFileSystemView->[getLatestFileSlicesBeforeOrOn->[ensurePartitionLoadedCorrectly],getBaseFileOn->[ensurePartitionLoadedCorrectly],fetchMergedFileSlice->[getPendingCompactionOperationWithInstant,mergeCompactionPendingFileSlices],getLatestBaseFile->[ensurePartitionLoadedCorrectly],getLatestBaseFilesBeforeOrO... | Returns all base files that have been committed in the given list of commits. | I think it would be better if we can push the code for adding external base if present down to `fetchAllStoredFileGroups()`. It would help avoid so many changes we are making to this class to add external files, and avoid having to keep in mind to do this for future methods we might add. Also, in general I think its go... |
@@ -1032,11 +1032,12 @@ namespace Js
JavascriptString *dblStr = JavascriptString::FromVar(FormatDoubleToString(value, NumberUtilities::FormatFixed, -1, scriptContext));
const char16* szValue = dblStr->GetSz();
+ const size_t szLength = dblStr->GetLength();
-#ifdef ENABLE_GLOBALIZATION
- ... | [No CFG could be retrieved] | This function returns a pointer to a BSTR object representing the number of unique elements in the Get the next unique number in the array. | Should you be calling this with count instead of bufSize since count > bufSize, and we just allocated a larger array. Also, in the case where count > bufSize, before we did a max of two calls to GetNumberFormatEx. Now it looks like we could do 4? That is, the first call to NumberToDefaultString would do it with 0, and ... |
@@ -129,6 +129,13 @@ func SetupPostgresCollections(ctx context.Context, sqlTx *sqlx.Tx, collections .
return errors.EnsureStack(err)
}
+ for _, idx := range col.indexes {
+ createIndex := fmt.Sprintf("create index on collections.%s (%s);", col.table, indexFieldName(idx))
+ if _, err := sqlTx.Exec(createIn... | [Join,Exec,Sprintf,EnsureStack,ExecContext] | returns a description of the unique key in the table. | Unrelated: I noticed we weren't actually creating secondary indexes on the collections tables, so non-pkey queries were not efficient - fixed here. |
@@ -126,8 +126,10 @@ func (i *AgentInfo) ECSMetadata() (*ECSMeta, error) {
return &ECSMeta{
Elastic: &ElasticECSMeta{
Agent: &AgentECSMeta{
- ID: i.agentID,
- Version: release.Version(),
+ ID: i.agentID,
+ Version: release.Version(),
+ Snapshot: release.Snapshot(),
+ ... | [ECSMetadata->[Version,Info,Hostname,Host],ECSMetadataFlatMap->[Join,Sprintf,Version,Host,Hostname,Info],WriteString,String] | ECSMetadata returns the ECS metadata for the agent. | This is probably a great place to put if the agent is also upgradable. Should we add `Upgradable: false` for now, then replace it with the correct check once #21206 lands. |
@@ -100,10 +100,11 @@ func (shard *indexShard) add(metric []client.LabelPair, fp model.Fingerprint) {
defer shard.mtx.Unlock()
for _, pair := range metric {
- name, value := model.LabelName(pair.Name), model.LabelValue(pair.Value)
- values, ok := shard.idx[name]
+ value := model.LabelValue(pair.Value)
+ value... | [Add->[HashFP,add],labelNames->[RUnlock,Sort,RLock],labelValues->[RUnlock,Sort,RLock],add->[LabelValue,LabelName,Unlock,Lock,Search],Lookup->[lookup,Sort],Delete->[HashFP,delete],lookup->[LabelValue,LabelName,RLock,Sort,Matches,RUnlock],LabelValues->[labelValues],LabelNames->[labelNames],delete->[LabelValue,LabelName,U... | add adds the given metric to the indexShard. | These 2 lines (4 changes) are a no-op, right? |
@@ -48,6 +48,9 @@ const realiasGetMode =
// Terms that must not appear in our source files.
const forbiddenTerms = {
'DO NOT SUBMIT': '',
+ 'whitelist': {
+ message: 'Please use the term allowlist',
+ },
// TODO(dvoytenko, #8464): cleanup allowlist.
'(^-amp-|\\W-amp-)': {
message: 'Switch to new in... | [No CFG could be retrieved] | Provides a function to create a new service object from a list of terms that can not be JS files that are required to be used as an ID. | Should this be `allowlist` and not `whitelist`? |
@@ -27,7 +27,15 @@ site_packages_path = get_python_lib()
# PaddlePaddle whl. So here we specific `include_dirs` to avoid errors in CI.
paddle_includes = [
os.path.join(site_packages_path, 'paddle', 'include'),
- os.path.join(site_packages_path, 'paddle', 'include', 'third_party')
+ os.path.join(site_packag... | [startswith,get_python_lib,join] | Test for the given unittest object. | maybe IS_WINDOWS can be used here. |
@@ -1,10 +1,10 @@
<% @grouped_profile_fields.each do |group| %>
- <% group_name = group.name.gsub(/\s+/, "_") %>
+ <% escaped_group_name = group.name.gsub(/\s+|\./, "_") %>
<article id="profile-field-group-<%= group.id %>" class="row my-3">
<div class="card w-100">
<div class="card-header">
<... | [No CFG could be retrieved] | Renders the n - ary field in the group. Renders the nack number of profile fields. | @djuber defined here, and passed along to the other partials at line 15 and 16 of this file |
@@ -0,0 +1 @@
+#include "bigknobv2.h"
| [No CFG could be retrieved] | No Summary Found. | Need a license header here. |
@@ -55,11 +55,17 @@ func String() string {
}
func GetBuild() *Build {
+ var b string
+ if BuildNumber == "" {
+ b = "0"
+ } else {
+ b = BuildNumber
+ }
return &Build{
Version: Version,
GitCommit: GitCommit,
BuildDate: BuildDate,
- BuildNumber: BuildNumber,
+ BuildNumber: b,
State: S... | [ShortVersion->[Sprintf],String->[Sprintf,Version],IsOlder->[Equal,Atoi,Errorf],IsNewer->[IsOlder,Equal],String,BoolVar] | String returns a string representation of a build. | Just set BuildNumber to "0", no need to have another variable or an else statement |
@@ -55,7 +55,15 @@ public final class SaveGameFileChooser extends JFileChooser {
AUTOSAVE_EVEN(getEvenRoundAutoSaveFile(true));
- private final File file;
+ private final Path path;
+
+ AUTOSAVE_TYPE(final File file) {
+ path = file.toPath();
+ }
+
+ public File getFile() {
+ return pa... | [SaveGameFileChooser->[getLostConnectionAutoSaveFile->[getAutoSaveFile],getHeadlessAutoSaveFile->[getAutoSaveFile],getOddRoundAutoSaveFile->[getAutoSaveFile],ensureDirectoryExists->[ensureDirectoryExists],getEvenRoundAutoSaveFile->[getAutoSaveFile],getAfterStepAutoSaveFile->[getAutoSaveFile],getInstance->[SaveGameFileC... | Gets the autoSave file. | Actually is there anything speaking against switching to Path for the calling code? Path is obviously the more modern API. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.