patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -136,7 +136,7 @@ def test_create_address(db):
@pytest.mark.skip(
reason=(
"We should use channel from order when getting product. "
- "We should fix it in https://app.clickup.com/2549495/v/g/2dtqq-1079"
+ "We should fix it in https://app.clickup.com/t/2549495/SALEOR-649"
)
)
def... | [test_cleardb_delete_staff_parameter->[raises,call_command,refresh_from_db],test_create_superuser->[all,create_superuser],test_generate_unique_slug_with_slugable_field->[generate_unique_slug,create,get_or_create],test_create_gift_card->[create_gift_card,count],test_create_address->[exists,create_address,all],test_gener... | Test create fake order. | For person assigned to `649` would be easier if you could put there the names of the tests to fix |
@@ -170,11 +170,8 @@ void RemoteClient::GetNextBlocks (
s32 new_nearest_unsent_d = -1;
// get view range and camera fov from the client
- s16 wanted_range = sao->getWantedRange();
+ s16 wanted_range = sao->getWantedRange() + 1;
float camera_fov = sao->getFov();
- // if FOV, wanted_range are not available (old c... | [event->[notifyEvent,UpdatePlayerList],isUserLimitReached->[getClientIDs],UpdatePlayerList->[getClientIDs]] | This method is called by the remote client to get the next blocks. region BlockFinderInfo public methods A method to dump all of the data that is not currently sent to the camera. This function is used to send blocks to the mapgen. | 2 long lines. hard limit is 90 columns with tab size 4. |
@@ -1458,6 +1458,9 @@ CELERY_ROUTES = {
'kuma.wiki.tasks.render_document_chunk': {
'queue': 'mdn_wiki'
},
+ 'kuma.wiki.tasks.clean_document_chunk': {
+ 'queue': 'mdn_wiki'
+ },
'kuma.wiki.tasks.render_stale_documents': {
'queue': 'mdn_wiki'
},
| [pipeline_one_scss->[pipeline_scss],_get_locales->[path],parse_iframe_url,path,_get_locales,pipeline_scss] | This module provides a mapping of tasks to their respective queues. A dictionary of all of the configuration options for the given page. | Nit: this will block user-initiated renders in ``mdn_wiki``. I think it is OK for a task that runs once, but we may want to pick an off-time to run it. I think @davidflanagan suggested a new queue for these bulk tasks as well, we make want to establish ``mdn_bulk`` if we do more like this. |
@@ -182,7 +182,7 @@ def compileScript(infile=None, version=None, outfile=None):
else:
# We already have the text
scriptText = scriptDict[scripts]
- with io.open(eval(scripts), 'w', encoding='utf-8-sig') as f:
+ with io.open(eval(scripts), 'w', encodin... | [compileScript->[_removeDisabledComponents,_getExperiment,_makeTarget,_setVersion,_setTarget],compileScript] | This function will compile a single. psyexp file or JS PsychoPy script This function removes a single non - disabled component from the experiment and returns a copy of the Generate script to write a object to file. | Is this _really_ what we want? Shouldn't we take care of the line endings when _reading_ files? |
@@ -45,8 +45,9 @@ type MetricSet struct {
func New(base mb.BaseMetricSet) (mb.MetricSet, error) {
// Unpack additional configuration options.
config := struct {
- Username string `config:"username"`
- Password string `config:"password"`
+ Hosts []string `config:"hosts" validate:"nonzero,required"`
+ User... | [Fetch->[Wrap,loadStatus,Connect],loadStatus->[Scan,Next,Query],AddMetricSet,MakeDebug,CreateDSN,Host,Module,UnpackConfig] | creates a new metric set instance for fetching status messages from a MySQL server. loadStatus loads all the global status entries from the given database into an array. | That was only added for validation of Hosts? That would probably something that should be done on the module level as it applies to all mysql metricset (yes, there is currently only one) :-) |
@@ -59,6 +59,13 @@ class ArrayDumper
$data['dist']['shasum'] = $package->getDistSha1Checksum();
}
+ foreach (array('require', 'conflict', 'provide', 'replace', 'suggest', 'recommend') as $linkType) {
+ if ($links = $package->{'get'.ucfirst($linkType).'s'}()) {
+ ... | [ArrayDumper->[dump->[getDistUrl,getDistSha1Checksum,getSourceUrl,getDistType,getDistReference,getPrettyVersion,getSourceType,getPrettyName,getTargetDir,getSourceReference,getVersion]]] | Dumps a package into an array. | Please always use `{` and `}` to wrap foreach bodies (same for ifs btw). It avoids problems later. |
@@ -284,7 +284,7 @@ public class ProductionPanel extends JPanel {
} else {
text = "<html> x " + ResourceCollection.toStringForHTML(m_cost, m_data) + "</html>";
}
- final JLabel label = new JLabel(text, icon, SwingConstants.LEFT);
+ final JLabel label = icon.isPresent() ? new JLabel(text... | [ProductionPanel->[show->[getProduction],Rule->[setMax->[setMax],changedValue->[calculateLimits]],calculateLimits->[setLeft],getResources->[getResources]]] | This method returns the panel component. Add a label and a description to the panel that shows the missing unit types. | This line looks too long. Did you format? |
@@ -12,7 +12,7 @@ class AvatarLookup
private
def self.lookup_columns
- @lookup_columns ||= %i{id email username uploaded_avatar_id}
+ @lookup_columns ||= %i{id username uploaded_avatar_id}
end
def users
| [AvatarLookup->[initialize->[tap],user_lookup_hash->[each,id]]] | Returns an array of lookups columns and users. | Hmm is this safe to nuke without replacing it? |
@@ -20,3 +20,15 @@ def test_params_order(tmp_dir, dvc, dummy_stage):
# params are sorted during dumping, therefore p1 is first
assert list(dvc.params.show()[""]) == ["p1.yaml", p2_path, "params.yaml"]
+
+
+def test_repro_unicode(tmp_dir, dvc, dummy_stage):
+ tmp_dir.gen({"settings.json": '{"Ω_value": 1}'... | [test_params_order->[list,show,dummy_stage,join,gen,dumps_yaml]] | Test that the params are sorted in the order of the file. | Let's just use `stage.dump()` to dump on both files. This way, both the `remove_stage` will be used. |
@@ -87,16 +87,13 @@ public class MessageChunkingTestCase extends AbstractIntegrationTestCase {
flowExecutionListener.addListener(source -> messagePartsCount.getAndIncrement());
MuleClient client = muleContext.getClient();
- flowRunner("ObjectReceiver").withPayload(simpleSerializableObject).asynchronously... | [MessageChunkingTestCase->[testMessageChunkingObject->[onNotification->[getValue,assertTrue,getResourceIdentifier,assertEquals,countDown],registerListener,FunctionalTestNotificationListener,assertTrue,AtomicInteger,get,serialize,getClient,await,run,SimpleSerializableObject,ceil,Latch,FlowExecutionListener,assertEquals,... | Test that the message received by the Chunking receiver is of the correct type. Listen to notifications on the Chunking receiver and determine how many message parts have been received and. | are the changes in this class correct? why remove the latches and meke this synchronous? |
@@ -3796,7 +3796,7 @@ dfs_removexattr(dfs_t *dfs, dfs_obj_t *obj, const char *name)
cond = DAOS_COND_DKEY_UPDATE | DAOS_COND_PUNCH;
rc = daos_obj_punch_akeys(oh, th, cond, &dkey, 1, &akey, NULL);
if (rc) {
- D_ERROR("Failed to punch extended attribute %s\n", name);
+ D_INFO("Failed to punch extended attribute '... | [dfs_mount_root_cont->[dfs_cont_create,dfs_mount],dfs_umount_root_cont->[dfs_umount],dfs_lookup->[dfs_lookup],dfs_obj_local2global->[dfs_get_chunk_size],dfs_chmod->[dfs_lookup,dfs_release],dfs_access->[dfs_lookup,dfs_release]] | Remove an extended attribute from an object. D_FREE - free all resources in the object. | should this use D_CDEBUG(rc == -DER_NONEXIST, DLOG_INFO, DLOG_ERR, "Failed to punch....); Or should we use a debug bit? |
@@ -47,8 +47,8 @@ def architecture_flag(settings):
return ""
if str(compiler) in ['gcc', 'apple-clang', 'clang', 'sun-cc']:
- if str(the_os) == 'Macos' and str(subsystem) == 'Catalyst' and str(arch) == 'x86_64':
- return '-target=x86_64-apple-ios-macabi'
+ if str(the_os) == 'Mac... | [format_library_paths->[_base_compiler,adjust_path],adjust_path->[_base_compiler],format_include_paths->[adjust_path],build_type_flags->[_base_compiler],rpath_flags->[_base_compiler],sysroot_flag->[_base_compiler,adjust_path],libcxx_define->[_base_compiler],libcxx_flag->[_base_compiler],pic_flag->[_base_compiler],forma... | Returns flags specific to the target architecture and compiler Returns the last unknown version of Erbus. | I know this is not from this PR, but I think this --target might conflict with the --target that the AutotoolsBuildEnvironment will add. Please have a look at it. |
@@ -324,6 +324,7 @@ class Photo {
return;
}
+ // if script dies at this point check memory_limit setting in php.ini
$this->image = imagerotate($this->image,$degrees,0);
$this->width = imagesx($this->image);
$this->height = imagesy($this->image);
| [Photo->[orient->[is_imagick,rotate,flip,getType,is_valid],scaleImage->[scaleImage,is_imagick,getHeight,getWidth,is_valid],load_data->[get_FormatsMap,is_imagick],saveImage->[is_valid],__construct->[supportedTypes],rotate->[is_imagick,is_valid],store->[getWidth,getHeight,imageString,getType],getHeight->[is_imagick,is_va... | Rotate the image in the given degrees. | Standards: Please add a space after commas. |
@@ -415,6 +415,13 @@ $( document ).ready(function() {
</div>
<?php
+// TakePOS setup check
+if (empty($conf->global->CASHDESK_ID_THIRDPARTY) or empty($conf->global->CASHDESK_ID_BANKACCOUNT_CASH) or empty($conf->global->CASHDESK_ID_BANKACCOUNT_CB)) {
+ setEventMessages($langs->trans("ErrorModuleSetupNotComplete"),... | [executeHooks,loadLangs,trans,initHooks,get_full_arbo,close] | Displays a list of all modules that can be used to generate a sequence number. Displays a menu for the free zone menu. | To follow coding rules, try to use "||" instead of "or" |
@@ -374,9 +374,9 @@ func (r *registry) GetOrNewSet(name string, tags map[string]string) *setMetric {
}
func (r *registry) metricHash(tags map[string]string) string {
- b, err := json.Marshal(tags)
- if err != nil { // shouldn't happen on a map[string]string
- panic(err)
+ mapstrTags := common.MapStr{}
+ for k, v :... | [No CFG could be retrieved] | metricHash returns the hash of the given tags. | Could remove the need for the loop being that a `map[string]string` should be able to be converted to a `common.MapStr` `common.MapStr(tags.(map[string]interface{}))` |
@@ -1022,6 +1022,7 @@ def initialize(consoleLogging=True): # pylint: disable=too-many-locals, too-man
PROCESS_METHOD = check_setting_str(CFG, 'General', 'process_method', 'copy' if KEEP_PROCESSED_DIR else 'move')
DELRARCONTENTS = bool(check_setting_int(CFG, 'General', 'del_rar_contents', 0))
... | [start->[start],initialize->[restoreCache->[path_leaf],restoreCache,get_backlog_cycle_time]] | Initialize the environment. \ private static method to call all the registered methods. \ ~english Return all status values. \ static void main ( \ static void init_bootcar2_notifiers ( \ brief Implementation of the basic configuration of the system. | Should default to 1 I think, to keep the old behavior by default |
@@ -64,8 +64,8 @@ public class HDFSParquetImporter implements Serializable {
private static volatile Logger log = LogManager.getLogger(HDFSParquetImporter.class);
- public static final SimpleDateFormat PARTITION_FORMATTER = new SimpleDateFormat("yyyy/MM/dd");
- private static volatile Logger logger = LogManage... | [HDFSParquetImporter->[dataImport->[dataImport],main->[HDFSParquetImporter]]] | Imports HDFS Parquet files and creates a Cleaner. Reads the n - tuple from the command line. | Use `DateTimeFormatter` for thread safety |
@@ -23,12 +23,14 @@ import numpy as np
from tensorflow.python.framework import constant_op
from tensorflow.python.framework import dtypes
+from tensorflow.python.framework import ops
from tensorflow.python.framework import sparse_tensor
from tensorflow.python.framework import test_util
# Need array_grad to regis... | [SparseOpsTest->[testSparseTensorToDenseString->[assertAllEqual,SparseTensor,sparse_tensor_to_dense,evaluate],testSparseEye->[test_one->[evaluate,eye,assertAllEqual,sparse_eye,sparse_to_dense,constant],range,test_one],testDenseFromConstantToSparse->[arange,evaluate,assertAllEqual,sparse_to_dense,constant,reshape,from_d... | Test for sparse ops. Test for the constant constant in the dense tensor. | This should be moved below after the line importing `array_grad` (as the imports have to be sorted) |
@@ -100,6 +100,12 @@ func (a *apiServer) workerPodSpec(options *workerOptions) (v1.PodSpec, error) {
Name: "PACHD_POD_NAMESPACE",
Value: a.namespace,
}}
+ if a.env.NewStorageLayer {
+ sidecarEnv = append(sidecarEnv, v1.EnvVar{Name: "NEW_STORAGE_LAYER", Value: "true"})
+ }
+ if a.env.DisableCommitProgressCount... | [createWorkerSvcAndRc->[workerPodSpec,getWorkerOptions]] | workerPodSpec returns the pod spec for the worker process. The environment variables that are passed to the worker and the sidecar environment variables are passed to pach - dir - volume 64 - 0 This function is called by the daemon to configure the sidecar. | It seems like it would be better to always propagate the feature flag environment variables, not just the ones that are true. Although I don't see a future where a feature flag is enabled by default in the service environment config, I think it would be a good precedent to always propagate global environment variables ... |
@@ -502,6 +502,9 @@ export class AmpA4A extends AMP.BaseElement {
/** @override */
unlayoutCallback() {
+ if (this.uiHandler) {
+ this.uiHandler.displayUnlayoutUI();
+ }
this.lifecycleReporter.sendPing('adSlotCleared');
// Remove creative and reset to allow for creation of new ad.
if ... | [AmpA4A->[constructor->[dev,getLifecycleReporter,AmpAdApiHandler],formatCSSBlock_->[cssUtf16CharOffsets,substring],onLayoutMeasure->[headers,some,resolve,then,user,checkStillCurrent,isAdPositionAllowed,cancellation,isCryptoAvailable,creative,bytes,signature,viewerForDoc,reject,verifySignature,arrayBuffer,map],preconnec... | UnlayoutCallback is called when the layout is cleared. It is called by the layoutCallback. | When would there not be a `#uiHandler`? |
@@ -1183,7 +1183,7 @@ class Assignment < Assessment
# zip all files in the folder at +self.autotest_files_dir+ and return the
# path to the zip file
def zip_automated_test_files(user)
- zip_name = "#{self.short_identifier}-testfiles-#{user.user_name}"
+ zip_name = "#{self.short_identifier}-testfiles-#{us... | [Assignment->[to_json->[to_json],summary_json->[group_by],get_marks_list->[max_mark],group_by->[group_assignment?],current_submission_data->[group_by],average_annotations->[get_num_marked,get_num_annotations],get_num_marked->[is_criteria_mark?],summary_csv->[max_mark],past_all_collection_dates?->[past_collection_date?]... | Zip the automated test files for a given user. | For clarity maybe change the parameter name from `user` to `role` |
@@ -54,7 +54,11 @@
var ngStyleDirective = ngDirective(function(scope, element, attr) {
scope.$watchCollection(attr.ngStyle, function ngStyleWatchAction(newStyles, oldStyles) {
if (oldStyles && (newStyles !== oldStyles)) {
- forEach(oldStyles, function(val, style) { element.css(style, '');});
+ forEac... | [No CFG could be retrieved] | ngStyle directive - ng - style directive. | Would it be possible to do `newStyles[style] = ''` instead (maybe also needing a `newStyles` null check + assign). This way we will only make a single `element.css(newStyles)` call at the end instead of multiple `.css` calls. Also should this be an `undefined`/`null` check instead of just falsey check? What if `newStyl... |
@@ -46,6 +46,11 @@ class ApplicationController < ActionController::Base # rubocop:disable Metrics/C
private
+ def disable_caching
+ response.headers['Cache-Control'] = 'no-store'
+ response.headers['Pragma'] = 'no-cache'
+ end
+
def redirect_on_timeout
params = request.query_parameters
retur... | [ApplicationController->[confirm_two_factor_authenticated->[user_fully_authenticated?],user_fully_authenticated?->[reauthn?]]] | Redirect to SP if the user has not specified a lease. | Do we also need to set `Expires` header to a value long in the past? |
@@ -365,7 +365,8 @@ def settings(batch_size,
regularization=None,
is_async=False,
model_average=None,
- gradient_clipping_threshold=None):
+ gradient_clipping_threshold=None,
+ async_lagged_grad_discard_ratio=None):
"""
Set the opti... | [settings->[GradientClippingThreshold,to_setting_kwargs,__extends__,extra_settings],MomentumOptimizer,BaseRegularization] | Set the optimizer method learning rate and model average and gradient clipping threshold. This function is called by the optimizer and optimizer methods to set the necessary parameters for a . | Seems these changes broke the CI unit tests |
@@ -110,6 +110,15 @@ func (c *CachedContactsProvider) LookupAll(mctx libkb.MetaContext, emails []keyb
now := mctx.G().Clock().Now()
+ // This is a rather long-lived lock, because normally it will be held
+ // through the entire duration of the lookup, but:
+ // - We don't expect this to be called concurrently, or... | [FillUsernames->[FillUsernames],LookupAll->[LookupAll,dbKey,findFreshOrSetEmpty],FillFollowing->[FillFollowing]] | LookupAll returns a map of contacts for the given emails and numbers. LookupAll - Lookup all emails and numbers left to be looked up. | So the idea is the first one will store the cache and the second lookup will just read from cache and not burn limit? |
@@ -644,7 +644,6 @@ public class TaskoXmlRpcHandler {
* @return true if JMX system props props
*/
public boolean isJmxEnabled() {
- return StringUtils.isNotEmpty(System.getProperty("com.sun.management.jmxremote.port")) &&
- StringUtils.isNotEmpty(System.getProperty("java.rmi.serve... | [TaskoXmlRpcHandler->[lookupBunchByName->[lookupBunchByName],scheduleRuns->[scheduleRuns],scheduleBunch->[scheduleBunch],lookupScheduleByLabel->[lookupScheduleByLabel],unscheduleSatBunches->[unscheduleBunch],getSatRunStdErrorLog->[getRunStdErrorLog],scheduleSingleBunchRun->[scheduleSingleBunchRun,doBasicCheck],listSatB... | Checks if JMX is enabled. | I do not really like the fact that `/etc/rhn/taskomatic.conf` is actually interpreted as a shell script. I understand that is none of your fault, but I would still ask for a way not to build on top of that. Can we check for the presence of the necessary classes via the class loader (eg. `Class.forName`) instead of usin... |
@@ -58,7 +58,7 @@ class VcsRepository extends ArrayRepository implements ConfigurableRepositoryInt
protected $processExecutor;
/** @var bool */
protected $branchErrorOccurred = false;
- /** @var array<string, class-string> */
+ /** @var array<string, class-string<VcsDriverInterface>> */
privat... | [VcsRepository->[preProcess->[getSource,getDist],validateTag->[normalize],getRepoName->[getDriver],validateBranch->[normalizeBranch,parseConstraints],getCachedPackageVersion->[findPackage,writeError,getPrettyVersion,getVersionPackage,overwriteError,load],getDriver->[initialize],initialize->[getMessage,normalize,getWarn... | Creates a new instance of VcsRepository. Constructor for HgDriver. | this is wrong. `class-string<VcsDriverInterface>` means `VcsDriverInterface::class`, not "a class name for something extending VcsDriverInterface". |
@@ -58,6 +58,8 @@ func (e *Encoder) reset() {
gotype.Folders(
codec.MakeTimestampEncoder(),
codec.MakeBCTimestampEncoder(),
+ codec.MakeNanoTimestampEncoder(),
+ codec.MakeBCNanoTimestampEncoder(),
),
)
if err != nil {
| [Encode->[reset,Reset,Indent,Fold,Bytes],reset->[Folders,NewIterator,MakeTimestampEncoder,NewVisitor,MakeBCTimestampEncoder],reset,Unpack,RegisterType] | reset resets the encoder to the initial state. | choose one, but not both. MakeTimestampEncoder and MakeNanoTimestampEncoder have the same function signature. So to not confuse setup, select only one. Note to myself: add panic if encoders with same signature are passed. |
@@ -785,13 +785,14 @@ function item_post(App $a) {
file_tag_update_pconfig($uid,$categories_old,$categories_new,'category');
proc_run(PRIORITY_HIGH, "include/notifier.php", 'edit_post', $post_id);
- if((x($_REQUEST,'return')) && strlen($return_path)) {
+ if ((x($_REQUEST,'return')) && strlen($return_path)) {
... | [item_post->[get_hostname]] | item post action This function is used to find the post that is a child of the parent of the conversation multi - level threading - preserve the info but re - parent to our single level threading This function is called when a user is redirected to a comment in a contact. | Standards: Please add a space after commas. |
@@ -173,7 +173,7 @@ namespace DotNetNuke.Web.Common.Internal
if (Logger.IsInfoEnabled && !e.FullPath.EndsWith(".log.resources"))
Logger.Info($"Watcher Activity: {e.ChangeType}. New Path: {e.FullPath}. Old Path: {e.OldFullPath}");
- if (_handleShutdowns && !_shutdownInprogress ... | [DotNetNukeShutdownOverload->[WatcherOnCreated->[ShceduleShutdown],WatcherOnRenamed->[ShceduleShutdown],WatcherOnDeleted->[ShceduleShutdown],WatcherOnChanged->[ShceduleShutdown]]] | Notify about changes to the file system. | Please use `String#StartsWith(String, StringComparison)` |
@@ -83,6 +83,12 @@ void spiInit(uint8_t spiRate) {
clock = 4000000; // Default from the SPI library
}
spiConfig = SPISettings(clock, MSBFIRST, SPI_MODE0);
+ #if defined(MISO_PIN) && defined(SDSS) && defined(MOSI_PIN) && defined(SCK_PIN)
+ SPI.setMISO(MISO_PIN);
+ SPI.setSSEL(SDSS);
+ SPI.setMOSI(MOSI_PIN... | [spiRec->[beginTransaction,endTransaction,transfer],spiSendBlock->[beginTransaction,endTransaction,transfer],spiSend->[beginTransaction,endTransaction,transfer],spiBegin->[PIN_EXISTS,OUT_WRITE],spiInit->[SPISettings,begin],spiRead->[memset,endTransaction,beginTransaction,transfer],ENABLED] | Initialize the SPI clock according to the SPI rate. | That's looking as if it could help solving a problem with the BTT SKR PRO 1.0 . Making the onboard SD-slot usable for g-code/config? |
@@ -290,7 +290,7 @@ class PrinterOutputModel(QObject):
def _onControllerCanUpdateFirmwareChanged(self) -> None:
self.canUpdateFirmwareChanged.emit()
- # Returns the configuration (material, variant and buildplate) of the current printer
+ # Returns the active configuration (material, variant and b... | [PrinterOutputModel->[cancelPreheatBed->[cancelPreheatBed],moveHead->[moveHead],setHeadX->[updateHeadPosition,setHeadPosition],homeBed->[homeBed],homeHead->[homeHead],preheatBed->[preheatBed],setHeadZ->[updateHeadPosition,setHeadPosition],sendRawCommand->[sendRawCommand],setTargetBedTemperature->[updateTargetBedTempera... | Emits a sequence of events indicating whether the controller can update firmware changed. | Changing this property name will break the API, but I think we can change `self._printer_configuration` to `self._active_printer_configuration` so internally the naming will be more clear. |
@@ -138,9 +138,7 @@ func startTask(
adapter, err := adapters.For(tr.Task, store)
if err != nil {
- tr.Status = models.RunStatusErrored
- tr.Result.SetError(err)
- return tr
+ return tr.ApplyResult(tr.Result.SetError(err))
}
return tr.ApplyResult(adapter.Perform(input, store))
| [Ended,Perform,Now,MergeTaskParams,Merge,NewRun,Started,Save,Infow,SaveCreationHeight,MarkPendingConfirmations,Errorf,ApplyResult,MarkCompleted,SetError,For,ForLogger,MaxUint64,Sprintf,Runnable,Debugw,UnfinishedTaskRuns] | startTask returns a task run that is either completed or aborted. | Isn't `RunResult#SetError` now the same as `RunResult#WithError`? I think we should remove `SetError` altogether because it definitely misleads one into thinking it's mutating the caller. |
@@ -86,7 +86,9 @@ import javax.xml.transform.TransformerException;
import javax.xml.transform.stream.StreamResult;
import javax.xml.transform.stream.StreamSource;
-import static hudson.model.queue.Executables.getParentOf;
+import static hudson.model.queue.Executables.getParentOfOrNull;
+import hudson.model.queue.Su... | [AbstractItem->[getACL->[getACL],onLoad->[doSetName],updateByXml->[call->[onLoad,getName,getParent],getConfigFile,updateByXml,checkPermission],getRelativeNameFrom->[getRelativeNameFrom,getParent],getAbsoluteUrl->[getUrl],performDelete->[delete,getRootDir],getFullName->[getName,getFullName],doReload->[call->[onLoad,getN... | Imports the given object as an item. The base class for all items that are not Actionable. | Unused import from what I can see |
@@ -163,6 +163,14 @@ namespace Content.Server.GameObjects.Components.Arcade
_enemyInvincibilityFlag = value;
break;
}
+
+ IndicatorUpdate();
+ }
+
+ public void IndicatorUpdate()
+ {
+ _wiresComponent?.SetStatus(Indicators... | [SpaceVillainArcadeComponent->[SpaceVillainGame->[ExecutePlayerAction->[ValidateVars],CheckGameConditions->[ProcessWin],UpdateUi->[UpdateUi],GenerateEnemyName,GenerateFightVerb],Initialize->[Initialize]]] | Method called when the Wires object is updated. | Those are long bois |
@@ -668,14 +668,6 @@ AclInherit AclInheritFromString(const char *string)
return ACL_INHERIT_NOCHANGE;
}
-ServicePolicy ServicePolicyFromString(const char *string)
-{
- static const char *const SERVICE_POLICY_TYPES[] =
- { "start", "stop", "disable", "restart", "reload", NULL };
-
- return FindTypeI... | [No CFG could be retrieved] | Get the ACL inheritance from a string. This function checks if a short type is known and returns the name of the type. | I think the new behavior is equivalent to the behavior of this removed code. |
@@ -337,7 +337,16 @@ abstract class AbstractItemNormalizer extends AbstractObjectNormalizer
{
$propertyMetadata = $this->propertyMetadataFactory->create($context['resource_class'], $attribute, $this->getFactoryOptions($context));
- $attributeValue = $this->propertyAccessor->getValue($object, $att... | [AbstractItemNormalizer->[denormalizeRelation->[denormalize],setValue->[setValue],getAttributeValue->[getFactoryOptions,normalize],normalizeRelation->[normalize,createRelationSerializationContext]]] | Get the attribute value. | Why changing this behavior (unknown attributes are ignored)? |
@@ -57,7 +57,7 @@ void rgblight_set(void) {
}
i2c_init();
- i2c_transmit(0xb0, (uint8_t*)led, 3 * RGBLED_NUM, 100);
+ i2c_send(0xb0, (uint8_t*)led, 3 * RGBLED_NUM);
}
#endif
| [matrix_init_kb->[matrix_init_user],process_record_kb->[process_record_user],led_set_kb->[led_set_user],backlight_set->[writePinLow,writePinHigh],backlight_init_ports->[setPinOutput,writePinHigh],rgblight_set->[i2c_init,i2c_transmit],matrix_scan_kb->[matrix_scan_user]] | rgblight_set - Set RGBLight LEDs. | Well, there's yer problem. You didn't shift the address before passing it in. |
@@ -116,7 +116,7 @@ public class AddProjectCreatorToTemplateActionTest extends BasePermissionWsTest<
@Test
public void fail_if_not_admin_of_default_organization() throws Exception {
- userSession.logIn().addOrganizationPermission(db.getDefaultOrganization().getUuid(), QUALITY_GATE_ADMIN);
+ userSession.lo... | [AddProjectCreatorToTemplateActionTest->[fail_if_not_admin_of_default_organization->[addOrganizationPermission,execute,expect,getUuid],assertThatProjectCreatorIsPresentFor->[isPresent,selectByPermissionAndTemplateId,isTrue,getSession],fail_when_template_does_not_exist->[loginAsAdmin,getDefaultOrganization,expect,execut... | Test if user is not admin of default organization. | could use `userSession.logIn().addPermission(ADMINISTER_QUALITY_GATES, db.getDefaultOrganization());` |
@@ -355,5 +355,17 @@ describes.realWin(
expect(el.getAttribute('tabindex')).to.equal('0');
});
});
+
+ describe('[type=system]', () => {
+ it('should not throw if navigator.share fails', async () => {
+ Object.defineProperty(env.win, 'navigator', {
+ value: {share: env.sandb... | [No CFG could be retrieved] | Checks that the element has a tabindex attribute. | This line expects `handleActivation_()` not to throw _any_ error. We should either modify to specify the specific error message (it shouldn't throw with `/cancel/`) or we should ensure the other possible errors thrown by this method are not the ones causing this test to fail. |
@@ -49,15 +49,6 @@ class UserPivCacSetupForm
end
end
- def user_has_no_piv_cac
- if TwoFactorAuthentication::PivCacPolicy.new(user).enabled?
- self.error_type = 'user.piv_cac_associated'
- false
- else
- true
- end
- end
-
def extra_analytics_attributes
{
multi_factor_... | [UserPivCacSetupForm->[piv_cac_not_already_associated->[call,error_type,x509_issuer,x509_dn_uuid,x509_dn],process_valid_submission->[call,error_type],valid_submission?->[valid_token?],user_has_no_piv_cac->[enabled?,error_type],name_is_unique->[add,t,id,exists?],submit->[valid_submission?,merge,new,valid?],include,valid... | check if a piv_cac is not already associated with the current user. | this method is never called |
@@ -76,10 +76,12 @@ class TestDistMnistNCCL2DGCMultiCards(TestDistBase):
log_name=flag_name)
def tearDown(self):
- result = count_of_sparse_all_reduce_calls(
- 'test_dist_mnist_dgc_nccl_dgc_2cards_local.log')
- # same as above, but use two cards
- self.assertEqual... | [TestDistMnistNCCL2DGC->[tearDown->[count_of_sparse_all_reduce_calls]],TestDistMnistNCCL2DGCMultiCards->[tearDown->[count_of_sparse_all_reduce_calls]]] | Test for tear down of DGC. | Why import twice? |
@@ -1394,7 +1394,8 @@ static uint32_t _image_import_internal(const int32_t film_id, const char *filena
char *normalized_filename = dt_util_normalize_path(filename);
if(!normalized_filename
|| !g_file_test(normalized_filename, G_FILE_TEST_IS_REGULAR)
- || dt_util_get_file_size(normalized_filename) == 0)
... | [dt_image_write_sidecar_file->[dt_image_full_path,dt_image_path_append_version],dt_image_synch_xmps->[dt_image_write_sidecar_file],dt_image_copy_rename->[dt_image_full_path],dt_image_synch_xmp->[dt_image_write_sidecar_file,dt_image_synch_xmps],dt_image_rename->[dt_image_full_path,dt_image_path_append_version],dt_image_... | Internal function to import an image from the database. SQLite 3 - mode operation for reading images from the database. insert a v0 record if no v0 xmp exists check if we have a group or not Dark table is not in use. | If you look into the definition of dt_util_get_file_size in utility.c, i think you should compare to <1 instead of ==0 |
@@ -80,14 +80,13 @@ public abstract class AbstractLockingInterceptor extends CommandInterceptor {
protected abstract Object visitDataWriteCommand(InvocationContext ctx, DataWriteCommand command) throws Throwable;
// We need this method in here because of putForExternalRead
- protected Object visitNonTxDataW... | [AbstractLockingInterceptor->[lockKey->[lockKey]]] | This method is invoked for non - transactional commands. It locks the command key if it is. | It looks like we can remove the cleanLocksAndRethrow method as well. |
@@ -463,4 +463,7 @@ release.flags = {
' Directory path to emplace release files (defaults to "./release")',
'flavor':
' Limit this release build to a single flavor. Can be used to split the release work between multiple build machines.',
+ 'skip_commits_verification':
+ ' Skip verifying that every c... | [No CFG could be retrieved] | Directory path to emplace release files. | I wonder if it isn't enough to just have this flag, and discard the other flag. In either case we'll have to change the release automation backend to support this and to add a field to add the overridden version number for these releases, so I wouldn't want to merge this PR before the backend supports it |
@@ -334,6 +334,14 @@ class Jetpack_Gutenberg {
plugins_url( $blocks_dir . '/', JETPACK__PLUGIN_FILE )
);
+ $is_subscriptions_active = Jetpack::is_module_active( 'subscriptions' );
+ if ( $is_subscriptions_active ) {
+ // Get number of subscribers
+ $subscriptions = new Jetpack_Subscriptions_Widget();
+ ... | [No CFG could be retrieved] | Enqueue Block Editor Assets Enqueue a WordPress script that will display the Jetpack blocks editor. | Does it make sense to convert fetch_subscriber_count to a static method so that we can just call it directly? |
@@ -0,0 +1 @@
+# This is a package.
| [No CFG could be retrieved] | No Summary Found. | Do you need this file? |
@@ -141,6 +141,15 @@ func GetAttachment(ctx *context.Context) {
//If we have matched and access to release or issue
fr, err := storage.Attachments.Open(attach.RelativePath())
if err != nil {
+ // If the file is missing from the disk, it will return 404 and remove the db record.
+ if os.IsNotExist(err) {
+ log... | [Close,IncreaseDownloadCount,DeleteAttachment,URL,Redirect,Error,GetUserRepoPermission,NewAttachment,RelativePath,CanRead,JSON,Trace,ServerError,LinkedRepository,Read,Split,Query,GetAttachmentByUUID,IsErrAttachmentNotExist,Sprintf,FormFile,String,VerifyAllowedContentType,Open,Params] | ServeData serves the attachment if we have matched and access to release or issue. | No, we SHOULD not do that. Maybe it's a configuration problem. |
@@ -3400,6 +3400,7 @@ static int rev_body(int s, int stype, int prot, unsigned char *context)
int ret = 1;
SSL *con;
BIO *io, *ssl_bio, *sbio;
+ BIO *bio = NULL;
buf = app_malloc(bufsize, "server rev buffer");
io = BIO_new(BIO_f_buffer());
| [No CFG could be retrieved] | Reads the server rev header and returns the number of bytes read. The main entry point for the SSL protocol. | This has to be again surrounded with `#ifdef CHARSET_EBCDIC` |
@@ -261,7 +261,7 @@ public class KafkaTopicClientImpl implements KafkaTopicClient {
@Override
public void deleteInternalTopics(final String applicationId) {
- if (!isDeleteTopicEnabled) {
+ if (!isTopicDeleteEnabled()) {
LOG.warn("Cannot delete topics since '" + DELETE_TOPIC_ENABLE + "' is false. "... | [KafkaTopicClientImpl->[addTopicConfigLegacy->[topicConfig],deleteTopics->[deleteTopics],deleteInternalTopics->[listTopicNames,deleteTopics],validateTopicProperties->[validateTopicProperties]]] | Deletes all internal topics for the given application. | this will be called both here and later in the method (line 279) when we call deleteTopics. we should cache the result and pass it down (alternatively, we can wrap it in a MemoizedSupplier if this client is created once per user/request) |
@@ -1945,7 +1945,11 @@ class OStatus
}
XML::addElement($doc, $entry, "id", $item["uri"]);
- XML::addElement($doc, $entry, "title", $title);
+ if ($feed_mode) {
+ XML::addElement($doc, $entry, "title", html_entity_decode($title, ENT_QUOTES, 'UTF-8'));
+ } else {
+ XML::addElement($doc, $entry, "title", $t... | [OStatus->[process->[query,saveXML,registerNamespace,loadXML,item],processPost->[item,query,evaluate],salmon->[saveXML,appendChild],entryHeader->[appendChild,createElementNS,setAttribute,createElement],followEntry->[getHostName,appendChild],processRepeatedItem->[item,query,evaluate],fetchAuthor->[item,query],reshareEnt... | Adds an entry content to a document. | I would guess this is the correct form both for feed_mode and non feed_mode. But unsure how to test non feed_mode so left that one untouched. |
@@ -286,6 +286,7 @@ public class TestHDDSUpgrade {
return false;
}
} catch (IOException e) {
+ LOG.error("Exception. ", e);
return false;
}
}
| [TestHDDSUpgrade->[testDataNodeAndSCMFailuresTogetherDuringDataNodeUpgrade->[shutdown,init,injectSCMAndDataNodeFailureTogetherAtTheSameTime],testAllDataNodeFailuresAfterScmCompleteFinalization->[injectDataNodeFailureDuringSCMUpgrade],testAllDataNodeFailuresBeforeScmPreFinalizeUpgrade->[injectDataNodeFailureDuringSCMUpg... | Test post upgrade conditions on Data Nodes. | loosely related but we have a typo in this file later on, in line 994, Failuer is written in the method name instead of Failure, should we fix it here? |
@@ -2,11 +2,13 @@ import React, { Fragment } from 'react'
import Footer from 'components/footer'
import NavBar from 'components/navbar'
+import SearchBar from 'components/search/searchbar'
const Layout = ({ children }) => (
<Fragment>
<main className="d-flex flex-column">
<NavBar />
+ <Search... | [No CFG could be retrieved] | A component that renders a single . | I suspect this is a WIP, but is the search bar supposed to be rendered on all routes, just the listings page(s), or some subset of routes? |
@@ -71,7 +71,7 @@ export function parseUrl(url) {
const fromCache = cache[url];
if (fromCache) {
- return fromCache;
+ return Object.assign({}, fromCache);
}
a.href = url;
// IE11 doesn't provide full URL components when parsing relative URLs.
| [No CFG could be retrieved] | Parses a URL into a Location object. The polyfills are not supported by IE11 but the polyfills are not supported. | This is not what I thought the plan was. Where is the code where we mutate the cache contents? |
@@ -294,8 +294,6 @@ class TestAtisWorld(AllenNlpTestCase):
'number -> ["5"]',
'number -> ["26"]',
'number -> ["2200"]',
- 'number -> ["200300"]',
- 'number -> ["199100"]',
'number -> ["1991"]',
'num... | [TestAtisWorld->[test_atis_long_action_sequence->[AtisWorld,get_action_sequence],test_atis_simple_action_sequence->[AtisWorld,get_action_sequence],test_atis_local_actions->[AtisWorld,set],test_atis_global_actions->[AtisWorld,set,keys],setUp->[open,super],test_atis_from_json->[get_action_sequence,AtisWorld,len,range,loa... | Test if the local actions are valid. 1991 - 1200 - 1000 - 10. | Where do 5, 6, and 8 come from? |
@@ -728,10 +728,14 @@ class _CompressedFile(object):
pass # All is as expected!
else:
self._data += self._decompressor.flush()
+ # Record that we have hit the end of file, so we won't unnecessarily
+ # repeat the completeness verification step above.
+ self._read_e... | [TextFileReader->[read_records->[readline],seek_to_true_start_offset->[readline,is_compressed]],_CompressionType->[__ne__->[__eq__]],CompressionTypes->[_CompressionType],FileSink->[close->[close],__init__->[is_valid_compression_type],initialize_write->[ChannelFactory],display_data->[format],finalize_write->[_rename_bat... | Fetch up to num_bytes from the internal buffer. | driveby that many of these TODOs make good JIRA issues, especially to empower new potential contributors to the SDK. |
@@ -1,3 +1,7 @@
+# Needs investigation, pylint was running tests
+# Could be `pylint_pytest` plugin, skipping check for this file for now
+# pylint: skip-file
+
import os
import sys
from subprocess import check_call
| [abspath,putenv,dirname,getenv,chdir,format,join,check_call] | Check if the is present in the system. | I am not sure why, but when not skipping this file, `pylint` was running the tests for some reason. |
@@ -157,6 +157,9 @@ namespace MonoGame.Tests.Graphics
[TestCase("SampleCube64DXT1Mips", 8)]
//[TestCase("SampleCube64DXT5Mips", 16)]
+#if DESKTOPGL
+ [Ignore("GetData is not yet implemented for compressed images")]
+#endif
public void GetAndSetDataDxtDontRoundWhenOutsideBounds(string... | [TextureCubeTest->[GetAndSetDataDxtNotMultipleOf4Rounding->[Texture,Size,AreEqual,SetData,Dispose,content,GetData,AreNotEqual],GetAndSetDataDxtCompressed->[Texture,Size,AreEqual,SetData,Dispose,content,Assert,GetData],ShouldSetAndGetData->[Color,AreEqual,Dispose,SetData,GetData],GetAndSetDataDxtLowerMips->[Texture,SetD... | This test method retrieves the data of a cube from a texture and sets it on the D. | I should get rid of these ignores and see if it all check out since I implemented GetData for compressed textures in this too. |
@@ -35,5 +35,11 @@ export default createStyleSheet({
// On iPhone X there is the notch. In the two cases BoxModel.margin is
// not enough.
top: BoxModel.margin * 3
+ },
+
+ videoQualityLabel: {
+ right: 0,
+ top: 0,
+ position: 'absolute'
}
});
| [No CFG could be retrieved] | On iPhone X there is the notch. | Does the label display at the very edge of the screen or is there margin/padding somewhere that brings it away from the edge? |
@@ -545,12 +545,6 @@ namespace FFITarget
{
return x * 3;
}
-
- public static int FunctionWithLongParameterName(
- [PreferredShortName("shortName")] int longlonglonglongParameterName)
- {
- return 0;
- }
}
internal class InternalClass
| [AClass->[Dispose->[SetValue]],Dummy->[SumAll->[SumAll]],TestData->[FuncVerifyingVariousObjectTypes->[TestUint64,TestUlong,TestDerivedDummyClass,TestUshort,TestUint16,TestDerived1,TestSbyte,TestDummyDispose,TestInt,TestDecimal,TestChar,TestString,TestShort,TestBoolean,TestByte,TestFloat,TestDouble,ToChar,TestDisposeCla... | This is a convenience method for multiplication by 3 non - parsable default arguments. | Do we then need a test case for the updated attribute? |
@@ -10017,13 +10017,13 @@ void setup() {
SERIAL_ECHO_START;
// Check startup - does nothing if bootloader sets MCUSR to 0
- byte mcu = MCUSR;
+ byte mcu = HAL_get_reset_source();
if (mcu & 1) SERIAL_ECHOLNPGM(MSG_POWERUP);
if (mcu & 2) SERIAL_ECHOLNPGM(MSG_EXTERNAL_RESET);
if (mcu & 4) SERIAL_ECHOLNP... | [No CFG could be retrieved] | Initializes the object with all of the components of the n - core core. Initialize the system variables. | Other CPUs might not have the reset reasons in these bit patterns. A HAL_report_reset_reason() is probably the better solution for this. AVR would then parse the MCUSR Bytes. And others can do different things,.. |
@@ -46,7 +46,7 @@ namespace System.IO
{
ValidateHandle(safeHandle, access, bufferSize, isAsync);
- _strategy = WrapIfDerivedType(FileStreamHelpers.ChooseStrategy(this, safeHandle, access, bufferSize, isAsync));
+ _strategy = WrapIfDerivedType(FileStreamHelpe... | [FileStream->[Flush->[Flush],WriteByte->[WriteByte],BaseReadAsync->[ReadAsync],BaseEndRead->[EndRead],Lock->[Lock],Write->[Write],EndWrite->[EndWrite],Seek->[Seek],BaseRead->[Read],BaseWrite->[Write],Read->[Read],BaseEndWrite->[EndWrite],ReadByte->[ReadByte],ReadAsync->[Task,ReadAsync],Unlock->[Unlock],SetLength->[SetL... | This constructor is deprecated. Please use new FileStream instead. if - Checks if a file handle is valid. | `WrapIfDerivedType` sounds to me as a step of `ChooseStrategy`; can the former method be called inside of the latter? |
@@ -3667,7 +3667,7 @@ def average_movements(epochs, head_pos=None, orig_sfreq=None, picks=None,
@verbose
-def make_fixed_length_epochs(raw, duration=1., preload=False,
+def make_fixed_length_epochs(raw, duration=1., overlap=0., preload=False,
reject_by_annotation=True, proj=True,
... | [BaseEpochs->[equalize_event_counts->[drop,drop_bad],plot_drop_log->[plot_drop_log],_get_data->[_get_epoch_from_raw,_detrend_offset_decim,_is_good_epoch,_project_epoch],drop_bad->[_reject_setup],get_data->[_get_data],crop->[_set_times],to_data_frame->[copy,get_data],reset_drop_log_selection->[_check_consistency],__init... | Divide continuous raw data into equal - sized consecutive epochs. | @sfc-neuro you might break the code of people by inserting a new param in the middle. We usually but it just before verbose. |
@@ -143,6 +143,10 @@ export class Viewport {
this.binding_.onScroll(this.scroll_.bind(this));
this.binding_.onResize(this.resize_.bind(this));
+
+ this.onScroll(() => {
+ this.viewer_.postScroll(this.getScrollTop());
+ });
}
/** For testing. */
| [No CFG could be retrieved] | The scroll count and the viewport s top position in the document. Gets the viewport s vertical scroll position. | I think we should consider only sending scroll event once per animation frame. @cramforce WDYT? |
@@ -81,6 +81,12 @@ func Run(client *cmd.Client, args ...string) {
Usage: "Import a key file to use with the node",
Action: client.ImportKey,
},
+ {
+ Name: "bridge",
+ Aliases: []string{"b"},
+ Usage: "Add a new bridge to the node",
+ Action: client.AddBridge,
+ },
}
app.Run(args)
}
| [Run,NewApp,Bool,NewConfig] | NewProductionClient returns a new client for the chainlink - norequest client. | On second thought, to remove ambiguity, let's remove the alias `b` for bridge as well. Now they have to be explicit about which one they wish to use: `bridge` or `backup` |
@@ -535,6 +535,9 @@ class FuncDef(FuncItem, SymbolNode, Statement):
def accept(self, visitor: StatementVisitor[T]) -> T:
return visitor.visit_func_def(self)
+ def get_body(self) -> Optional['Block']:
+ return self.body
+
def serialize(self) -> JsonDict:
# We're deliberating omitt... | [SymbolNode->[deserialize->[deserialize]],ClassDef->[serialize->[serialize],is_generic->[is_generic],deserialize->[ClassDef,deserialize]],FuncDef->[serialize->[serialize],deserialize->[FuncDef,deserialize]],merge->[MroError],Decorator->[fullname->[fullname],serialize->[serialize],name->[name],deserialize->[Decorator,de... | Visit a FuncDef. | Where is this used? I only see this definition (and the one below) but no call sites. |
@@ -183,7 +183,7 @@ public class HeapMemoryTaskStorage implements TaskStorage
try {
final ImmutableList.Builder<Task> listBuilder = ImmutableList.builder();
for (final TaskStuff taskStuff : tasks.values()) {
- if (taskStuff.getStatus().isRunnable()) {
+ if (taskStuff.getStatus().isRunna... | [HeapMemoryTaskStorage->[getTask->[getTask],getTaskInfo->[getTask,getStatus],getActiveTasks->[getTask],getRecentlyFinishedTaskInfoSince->[getTask,getStatus],getNRecentlyFinishedTaskInfo->[getTask,getStatus],getStatus->[getStatus],TaskStuff->[withStatus->[TaskStuff]],getActiveTaskInfo->[getTask,getStatus]]] | Get active tasks. | I guess `task` is never null in HeapMemoryTaskStorage? |
@@ -127,6 +127,8 @@ func (i *Ingester) Shutdown() {
}
func (i *Ingester) loop() {
+ level.Debug(util.Logger).Log("msg", "we get logs in failed tests")
+
defer func() {
level.Info(util.Logger).Log("msg", "Ingester.loop() exited gracefully")
i.done.Done()
| [initRing->[AddIngester,Log,CAS,TokensFor,Info,NewDesc],updateConsul->[Unix,AddIngester,Now,Log,CAS,Info,NewDesc],processShutdown->[DrainAndClose,Error,flushAllChunks,Close,transferChunks,Log,Wait],autoJoin->[Error,GenerateTokens,AddIngester,Sort,Log,CAS,TokensFor,NewDesc],ChangeState->[changeState],unregister->[Remove... | loop is the main loop for the Ingester. It is run in a goroutine. This loop is run in a separate goroutine and will process the events from the channel and update. | is this meant to be here? |
@@ -92,6 +92,10 @@ module Canary
end
end
+ def is_committer
+ object.committer?
+ end
+
def records_count
object.episode_records_count
end
| [UserType->[description->[description],url->[url],notifications_count->[notifications_count],email->[email]]] | Check if the object has a sequence number that can be found. | Naming/PredicateName: Rename is_committer to committer?. |
@@ -326,7 +326,10 @@ public class SparkInterpreter extends Interpreter {
}
}
pythonLibUris.trimToSize();
- if (pythonLibs.length == pythonLibUris.size()) {
+
+ // Distribute two libraries(pyspark.zip and py4j-*.zip) to workers
+ // when spark version is less than or equal to 1.4.1
+ if (pyt... | [SparkInterpreter->[getProgress->[getJobGroup],interpretInput->[interpret],getSQLContext->[useHiveContext,getSparkContext],getCompletionTargetString->[toString],getProgressFromStage_1_0x->[getProgressFromStage_1_0x],getProgressFromStage_1_1x->[getProgressFromStage_1_1x],close->[close],cancel->[getJobGroup],open->[getDe... | Create a new SparkContext with the specified configuration. This method is called to add a key and value pair to the configuration. | I think it always discard user provided `spark.yarn.dist.files`. Is it okay to do? |
@@ -280,7 +280,7 @@ class CsRedundant(object):
dev = interface.get_device()
cmd = "%s -C %s" % (self.CONNTRACKD_BIN, self.CONNTRACKD_CONF)
- CsHelper.execute("%s -d" % cmd)
+ CsHelper.service("conntrackd", "restart")
CsHelper.service("ipsec", "stop")
CsHelper.serv... | [CsRedundant->[set_master->[set,release_lock,set_lock],set_fault->[release_lock,set_lock],_redundant_on->[_redundant_off],set_backup->[release_lock,set_lock]]] | Set the current router to backup mode. | @weizhouapache if `cmd` is unused can we remove it? |
@@ -29,7 +29,7 @@ public interface PolicyManager {
*
* @param executionIdentifier the unique identifier associated to the exection of a policy instance.
* @param sourceIdentifier the identifier of the message source
- * @return a {@link OperationPolicy} associated to that source.
+ * @return a {@link De... | [No CFG could be retrieved] | Find the source policy instance for the given execution identifier. | API should depend on the interface, not the implementation |
@@ -185,7 +185,11 @@ class Ascent(Package, CudaPackage):
with working_dir('spack-build', create=True):
py_site_pkgs_dir = None
if "+python" in spec:
- py_site_pkgs_dir = site_packages_dir
+ try:
+ py_site_pkgs_dir = site_packages_dir
+ ... | [Ascent->[install->[install],create_host_config->[cmake_cache_entry]]] | Installs Ascent and installs it if necessary. | Have you tried `spec['python'].package.site_packages_dir`? |
@@ -125,13 +125,7 @@ public class DnsNameResolver extends InetNameResolver {
static {
String[] searchDomains;
try {
- Class<?> configClass = Class.forName("sun.net.dns.ResolverConfiguration");
- Method open = configClass.getMethod("open");
- Method nameservers = c... | [DnsNameResolver->[toArray->[toArray],trySuccess->[trySuccess],doResolveAllCached->[tryFailure,trySuccess],doResolveAllUncached->[resolve],query0->[query0,query],doResolveAll->[doResolveAll,loopbackAddress,resolveHostsFileEntry],resolve->[resolve],executor->[executor],doResolve->[doResolve,loopbackAddress,resolveHostsF... | This method is used to determine the IPv6 and IPv4 addresses for a given host. Creates a new datagram channel that will send the given name server to the nameservers that. | @mattayres What about non unix like systems (for example windows) ? Maybe we can use `PlatformDependent.isWindows()` and only use this if it returns false ? |
@@ -112,6 +112,7 @@ class Context(Configuration):
notify_outdated_conda = PrimitiveParameter(True)
clobber = PrimitiveParameter(False)
changeps1 = PrimitiveParameter(True)
+ prompt = PrimitiveParameter("({default_env}) ")
create_default_packages = SequenceParameter(string_types)
default_pyth... | [Context->[default_python_default],determine_target_prefix->[locate_prefix_by_name],reset_context->[__init__],get_prefix->[determine_target_prefix],Context] | Configures a context object that can be used to configure a single network context object. Create a sequence of parameters for the sequence. | Should this rather be `prompt_modifier`? From `prompt`, maybe I would expect to be able to specify the whole prompt, e.g., `{orig_prompt}>{default_env}>`. Currently we only allow to prepend the modifier (which is handy for us, e.g., regarding its replacement), but maybe that could change at some point. If we use `promp... |
@@ -98,8 +98,6 @@ public final class CollectionsUtils {
@SuppressWarnings("unchecked")
public static <K, V> Map<K, V> immutableMapOf(K key, V value, Object... keyVals) {
- return Collections.unmodifiableMap(
- mapOf(HashMap::new, key, value, keyVals)
- );
+ return immutableMa... | [CollectionsUtils->[immutableMapOf->[mapOf],mapOf->[mapOf],filter->[filter],removeNullValues->[removeNullValues]]] | Returns an immutable Map of the specified key - value pairs. | This is not a test, this was duplicated code. |
@@ -68,7 +68,7 @@ func (c *NameLookupCache) GetImageStore(ctx context.Context, storeName string) (
_, ok := c.storeCache[*store]
if !ok {
- log.Info("Refreshing image cache from datastore.")
+ log.Info("ImageCache: Refreshing image cache from datastore.")
// Store isn't in the cache. Look it up in the datas... | [GetImage->[GetImage,GetImageStore],ListImages->[GetImage,GetImageStore],WriteImage->[WriteImage],GetImageStore->[GetImageStore],CreateImageStore->[CreateImageStore,GetImageStore]] | GetImageStore returns the URL of the image in the given store. This function is called when an image is found on the datastore. It will insert the image. | Should be using the `infof` function? |
@@ -31,10 +31,13 @@ import org.bson.Document;
public interface MongoDBClientService extends ControllerService {
String WRITE_CONCERN_ACKNOWLEDGED = "ACKNOWLEDGED";
String WRITE_CONCERN_UNACKNOWLEDGED = "UNACKNOWLEDGED";
- String WRITE_CONCERN_FSYNCED = "FSYNCED";
+ String WRITE_CONCERN_FSYNCED = "F... | [convertJson->[parse],build] | Package that implements the IControllerService interface. Missing property descriptor. | I think changing the string of the write concerns will create an upgrade incompatibility. If we want to communicate the deprecation of these we can create an `AllowableValue` object for these with a description of the deprecation and a note about the replacement. |
@@ -200,7 +200,14 @@ class SetupKwargs:
raise ValueError(f"Missing a `version` kwarg in the `provides` field for {address}.")
if not _allow_banned_keys:
- for arg in {"data_files", "package_dir", "package_data", "packages"}:
+ for arg in {
+ "data_files",
+ ... | [declares_pkg_resources_namespace_package->[is_call_to->[is_name],has_args,is_call_to],validate_args->[InvalidSetupPyArgs],get_sources->[SetupPySources],get_owned_dependencies->[OwnedDependency,OwnedDependencies],generate_chroot->[SetupPySourcesRequest,SetupPyChroot,InvalidEntryPoint,DependencyOwner,FinalizedSetupKwarg... | Initialize a with the given kwargs. | Alternatively, we could allow users to set some of these and have us extend the values, rather than overwriting like we were doing. I think I err on the side of banning, though. As a user, if I set `namespace_packages=['foo']`, I think I would be confused if Pants ended up adding two additional values to it. It's not c... |
@@ -812,7 +812,12 @@ func (p *blockPrefetcher) run(testSyncCh <-chan struct{}) {
}()
isShuttingDown := false
var shuttingDownCh <-chan interface{}
+ first := true
for {
+ if !first && testDoneCh != nil && !isShuttingDown {
+ testDoneCh <- struct{}{}
+ }
+ first = false
if isShuttingDown {
if p.inFli... | [applyToPtrParentsRecursive->[getParentForApply,applyToPtrParentsRecursive],request->[newPrefetch],CancelPrefetch->[cancelQueuedPrefetch],rescheduleTopBlock->[Close,cancelPrefetch],run->[applyToPtrParentsRecursive,addFetchedBytes,handleStatusRequest,getBlockSynchronously,stopIfNeeded,applyToParentsRecursive,newPrefetch... | run is the main loop for prefetching blocks. Walk up the block tree and delete every node with the given refnonce. This function handles the handling of a single non - blocking request. It is called by the This function is called when a prefetch is requested. | The purpose of this channel isn't obvious to me; why can't we use `testSyncCh`? |
@@ -52,6 +52,6 @@ public final class TableTableJoinBuilder {
throw new IllegalStateException("invalid join type");
}
- return left.withTable(result, joinParams.getSchema());
+ return left.withTable(result, joinParams.getSchema(), Optional.empty());
}
}
\ No newline at end of file
| [TableTableJoinBuilder->[build->[leftJoin,getTable,create,outerJoin,getSchema,getJoiner,IllegalStateException,join,withTable,getJoinType,getKeyColName]]] | Build a Holder of the given type with the given join. | Why do you need to explicitly avoid passing the materialization info builder here? Just curious. Is it because joins aren't materialized and the old code would have implied that they were? You could probably do `KTableHolder.unmaterialized(...)` and pass in the ExecutionKeyFactory from left to make it a bit more explic... |
@@ -281,6 +281,12 @@ def find_events(raw, stim_channel='STI 014', verbose=None):
affected by the trigger.
verbose : bool, str, int, or None
If not None, override default verbose level (see mne.verbose).
+ detect : 'onset' | 'offset'
+ Whether to report when events start or when events e... | [read_events->[loadtxt,splitext,fiff_open,len,ValueError,pick_events,close,_read_events_fif],write_events->[splitext,start_block,write_int,end_block,write,tuple,end_file,close,open,start_file],find_events->[astype,any,all,unique,pick_channels,len,where,ValueError,isinstance,warn,info,abs,zeros_like,diff],concatenate_ev... | Find events from a raw object. | this doc string sounds like 010100 would be read as only one time 1. we should take care to be sufficiently concrete and explicit here. |
@@ -50,12 +50,13 @@ NEW_TYPES_INPUT_TABLE = 'python_new_types_table'
NEW_TYPES_OUTPUT_SCHEMA = (
'{"fields": [{"name": "bytes","type": "BYTES"},'
'{"name": "date","type": "DATE"},{"name": "time","type": "TIME"}]}')
-NEW_TYPES_OUTPUT_VERIFY_QUERY = ('SELECT date FROM `%s`;')
-# There are problems with query t... | [BigQueryQueryToTableIT->[test_big_query_new_types->[_setup_new_types_env]]] | Imports the given n - tuple and returns the corresponding n - tuple. This class is used to setup the test case for a specific . | `base64.b64encode` here makes the test work around the limitation in IO. I think we need to understand first what is the intended behavior of the IO, we can continue the conversation on the associated Jira. |
@@ -218,7 +218,8 @@ func DeployCmd(noMetrics *bool) *cobra.Command {
deploy.PersistentFlags().StringVar(&etcdVolume, "static-etcd-volume", "", "Deploy etcd as a ReplicationController with one pod. The pod uses the given persistent volume.")
deploy.PersistentFlags().BoolVar(&dryRun, "dry-run", false, "Don't actuall... | [StringVar,Now,Atoi,IntVar,RunBoundedArgs,RunFixedArgs,RunIO,ReportAndFlushUserAction,WriteAmazonAssets,Errorf,Run,Bytes,WriteCustomAssets,AddCommand,ReadBytes,WriteMicrosoftAssets,PrettyPrintVersion,WriteGoogleAssets,WriteLocalAssets,DecodeString,ParseRequestURI,Write,Printf,NewReader,String,BoolVarP,PersistentFlags,F... | Construct a object with the given flags. The size of the Pachd s CPU request which we give to Kombu. | I think you could remove the `If true` part of the help message here, people will assume that the description applies to the case where the value is `true`. Also because users are unlikely to type `--dashboard=true` instead of `--dashboard`, although I think that both will work with this flag library. |
@@ -491,7 +491,15 @@ func (p *imagePruner) Run(pruneImage ImagePruneFunc, pruneStream ImageStreamPrun
pruneImages(p.g, imageNodes, pruneImage, pruneStream, pruneManifest)
layerNodes := layerNodeSubgraph(allNodes)
- pruneLayers(p.g, layerNodes, pruneLayer, pruneBlob)
+ registryURL := ""
+ if len(imageNodes) > 0 {
... | [Run->[NodeList],UniqueName,ParseDockerImageReference,EnsureReplicationControllerNode,EnsureDeploymentConfigNode,NewRequest,Now,EnsureImageStreamNode,Close,Delete,GetImageStreamForStrategy,HandleError,Has,Error,FindImage,New,ParseNameAndID,EnsurePodNode,EnsureBuildConfigNode,Errorf,EdgeKind,UpdateStatus,Sub,EnsureImage... | Run runs the image pruning. | include the error? |
@@ -15,6 +15,7 @@
grouping_id: <%= @result.submission.grouping_id %>,
assignment_id: <%= @result.submission.grouping.assessment_id %>,
role: '<%= @current_user.class.name %>',
+ num_collected: <%= @assignment.get_num_collected(ta_id) %>,
}
);
| [No CFG could be retrieved] | Renders the given . Renders the keybinding - related n - id dialog. | this shouldn't be passed as a prop. Instead, get the information when setting the `state` of the Result component. |
@@ -521,6 +521,10 @@ func (consensus *Consensus) commitBlock(blk *types.Block, committedMsg *FBFTMess
atomic.AddUint64(&consensus.blockNum, 1)
consensus.SetCurBlockViewID(committedMsg.ViewID + 1)
consensus.LeaderPubKey = committedMsg.SenderPubkeys[0]
+ // Update consensus keys at last so the change of leader stat... | [tryCatchup->[getLastMileBlocksAndMsg],HandleMessageUpdate->[IsViewChangingMode],postCatchup->[IsViewChangingMode],Start->[Start,finalizeCommits]] | commitBlock commits a block to the FBFT consensus state. | I think the better solution is to move 521-523 above OnConsensusdone(), rather than move that code from OnConsensusDone to here. |
@@ -276,9 +276,11 @@ func (t *timestampOracle) getTS(leadership *election.Leadership, count uint32) (
log.Error("invalid timestamp", zap.Any("timestamp", current), errs.ZapError(errs.ErrInvalidTimestamp))
return pdpb.Timestamp{}, errs.ErrGenerateTimestamp.FastGenByArgs("timestamp in memory isn't initialized")
... | [saveTimestamp->[getTimestampPath],UpdateTimestamp->[saveTimestamp],SyncTimestamp->[saveTimestamp,loadTimestamp],ResetUserTimestamp->[saveTimestamp],loadTimestamp->[getTimestampPath]] | getTS returns a timestamp in the memory. return a response with a non - nil error. | Do you have any benchmark? |
@@ -34,8 +34,10 @@ class _RWBuf(object):
return self._io.read() if size == -1 else self._io.read(size)
def write(self, s):
+ if not isinstance(s, bytes):
+ raise ValueError('Argument not in bytes: {0}'.format(s))
with self._lock:
- self.do_write(str(s))
+ self.do_write(s)
self.... | [FileBackedRWBuf->[do_write->[write],__init__->[__init__]],InMemoryRWBuf->[do_write->[write]],_RWBuf->[read_from->[read],read->[read],close->[close],flush->[flush]]] | Write a string to the file. | @benjyw follow up from prior discussion. Good point about prior version changing semantics. This does change semantics that now `ValueError` will be raised whereas earlier we would try to coerce into bytes. If it's safe to make this change, I agree with you this is better |
@@ -1331,6 +1331,11 @@ public abstract class GenericDaoBase<T, ID extends Serializable> extends Compone
public Pair<List<T>, Integer> searchAndDistinctCount(final SearchCriteria<T> sc, final Filter filter, final String[] distinctColumns) {
List<T> objects = search(sc, filter, null, false);
Intege... | [GenericDaoBase->[searchIncludingRemoved->[searchIncludingRemoved],findOneBy->[findOneIncludingRemovedBy],configure->[createCache,listAll],remove->[expunge,update,remove,createForUpdate,prepareAttribute],listAndCountIncludingRemovedBy->[searchIncludingRemoved,getCount],setField->[setField],findOneIncludingRemovedBy->[s... | Returns a list of objects that match the given criteria and the number of distinct columns. | Why not put count = objects.size() ? |
@@ -401,8 +401,6 @@ func opsworksConnForRegion(region string, meta interface{}) (*opsworks.OpsWorks,
return nil, fmt.Errorf("Error creating AWS session: %s", err)
}
- sess.Handlers.Build.PushBack(request.MakeAddToUserAgentHandler("APN/1.0 HashiCorp/1.0 Terraform", meta.(*AWSClient).terraformVersion))
-
newSess... | [GetChange,IgnoreAws,PushBack,Set,Code,NonRetryableError,Copy,OpsworksListTags,UpdateStack,GetOk,New,HasChange,OpsworksUpdateTags,DeleteStack,Errorf,SetId,RetryableError,Bool,Id,Get,MakeAddToUserAgentHandler,Map,NewSession,CreateStack,Sleep,Printf,StringValue,Sprintf,Print,String,DescribeStacks,Retry] | Validates that the given resource data is valid for a Stack resource. m is a helper function to populate a missing key - value map. | User agent configuration is in `originalConn.Config`. |
@@ -423,11 +423,14 @@ public class UsersResource extends RestResource {
@GET
@Path("{username}/tokens")
- @RequiresPermissions(RestPermissions.USERS_TOKENLIST)
@ApiOperation("Retrieves the list of access tokens for a user")
public TokenList listTokens(@ApiParam(name = "username", required = tru... | [UsersResource->[changeUser->[setUserRoles],listUsers->[get],listTokens->[create],toUserResponse->[get,toUserResponse,create],create->[create],generateNewToken->[create]]] | Retrieves a list of access tokens for a user. | I think the naming of that method is suboptimal, for two reasons: * Method names are not prefixed with `_` in Java. The signature already reveals that it is a private method. * The name `_tokensLoadUser` implies that it is specific to the Token management, which it is not. If it would be called `loadUser`, it would des... |
@@ -88,6 +88,13 @@ func NewServer(globalConfiguration GlobalConfiguration) *Server {
// leadership creation if cluster mode
server.leadership = cluster.NewLeadership(server.routinesPool.Ctx(), globalConfiguration.Cluster)
}
+ server.backendReloadCounter = prometheus.NewCounterFrom(
+ stdprometheus.CounterOpts{... | [Stop->[Wait],stopLeadership->[Stop],listenSignals->[Stop],prepareServer->[createTLSConfig],Close->[Stop,Close],loadConfig->[buildEntryPoints]] | NewServer creates a new server object. Group all serverEntryPoints in a goroutine. | Description seems wrong? |
@@ -302,9 +302,16 @@ def convert_var_shape_simple(x):
return x.shape
-def eval_if_exist_else_none(name):
+def eval_if_exist_else_none(name, local_symbol_table):
+ """
+ Args:
+ name([str]): Expression passed into `eval`.
+ local_symbol_table(dict): Specified from `locals()`. DO NOT use ... | [choose_shape_attr_or_api->[has_negative],convert_shape_compare->[reduce_compare,convert_logical_and],_slice_tensor_array->[false_fn,cond],convert_var_shape->[has_negative]] | Evaluate a nan nan nan nan nan nan nan nan nan nan nan nan nan nan nan nan. | high -> higher variabels -> variables hide way -> hide away? |
@@ -307,6 +307,7 @@ module.exports = class bittrex extends Exchange {
'max': undefined,
},
'leverage': {
+ 'min': 1,
'max': 1,
},
},
| [No CFG could be retrieved] | Get balance of an order order order order order order order order order order order order order order Get the balance of an order from the orderbook. | I think, if they don't have `leverage`, then we should: 1. either remove `leverage` entirely 2. or set it to `undefined` 3. or set `min` and `max` to `undefined` I would pick (1). |
@@ -698,6 +698,8 @@ func (c *Container) generateInspectContainerHostConfig(ctrSpec *spec.Spec, named
for cap := range boundingCaps {
capDrop = append(capDrop, cap)
}
+ // Sort CapDrop so it displays in consistent order (GH #9490)
+ sort.Strings(capDrop)
}
hostConfig.CapAdd = capAdd
hostConfig.CapDrop ... | [inspectLocked->[ID,Wrapf,GetDriverData,Layer,getContainerInspectData,Container],getInspectMounts->[ID,Wrapf,Volume,Driver,MountPoint],generateInspectContainerConfig->[Repeat,Hostname,Join],getContainerInspectData->[specFromState,Error,IsInfra,sortUserVolumes,getInspectMounts,generateInspectContainerConfig,Dependencies... | generateInspectContainerHostConfig generates the container host config Initialize the configuration of a node This function is used to add additional configuration values to the hostConfig object. This function is used to populate the missing configuration fields of the host configuration object. | Do we have to do the same for capAdd? |
@@ -50,7 +50,8 @@ class HMDB51(VisionDataset):
}
def __init__(self, root, annotation_path, frames_per_clip, step_between_clips=1,
- fold=1, train=True, transform=None):
+ frame_rate=None, precomputed_metadata=None, precomputed_metadata_filepath=None,
+ save_me... | [HMDB51->[__len__->[num_clips],_select_fold->[readlines,int,basename,extend,len,glob,format,strip,join,set,open,range],__getitem__->[get_clip,transform],__init__->[list,VideoClips,list_dir,make_dataset,_select_fold,subset,len,sorted,super,ValueError,format,range]]] | Initialize HMDB51 with a sequence of sample and video clips. | I would be ok exposing the `_precomputed_metadata` as a private argument in the constructor for now, and also expose the `frame_rate`, but I think that the `precomputed_metadata_filepath` and `save_metadata_filepath` should live outside of the dataset and be handled by the training code. |
@@ -166,7 +166,9 @@ public class Httpbin extends HttpTestServer {
public void _redirect(Request rq, Response rsp, int count, int response) throws URISyntaxException {
if (count > 0) {
System.out.println("redirect " + count);
- rsp.headers.put("Location", getBaseURI() + "/redirect/" + (--count) + "/" + respon... | [Httpbin->[_patch->[turnAround],_index$2dauth->[getResource,_basic$2dauth],_deflate->[getResource,write,toByteArray,DeflaterOutputStream,ByteArrayOutputStream,close,put],_encoding->[getResource,equals,forName,String,getBytes],_etag->[equals,getTime,get,isEmpty,getBytes,put],_redirect->[getBaseURI,println,put],_index->[... | Redirect to the base URI. | Shouldn't this be more than just `containsKey` and instead check the value for truthiness? In the test case you use `?relative=true`. So there seems a small disconnect there. |
@@ -464,6 +464,17 @@ def plot_evoked(evoked, picks=None, exclude='bads', unit=True, show=True,
coordinates into color values. Spatially similar channels will have
similar colors. Bad channels will be dotted. If False, the good
channels are plotted black and bad channels red. Defaults to False... | [plot_evoked_joint->[plot_evoked_joint,_connection_line,_plot_evoked],plot_evoked_image->[_plot_evoked],_plot_evoked_white->[whitened_gfp],plot_evoked->[_plot_evoked],_plot_evoked->[_plot_legend,_rgb]] | Plot an evoked data using Butterfly. Plots a butterfly plot. | Add `.. versionadded:: 0.13.0`. Same for the `evoked.plot`. |
@@ -69354,17 +69354,14 @@ var _views_builds_html = []byte(`<div ng-controller="ProjectController" class="c
</div>
<div ng-switch-when="Docker">
<div ng-if="buildConfig.spec.strategy.dockerStrategy.from">
-<dl class="dl-horizontal">
<dt>Builder image stream:</dt>
<dd>{{buildConfig.spec.strategy.dockerStrategy.from ... | [Split,Replace,Errorf] | Outputs a formatted ng - base UUID. Outputs a formatted list of all possible objects. | The wrapping < dl > shouldn't be here since the < dt > & < dd > are already within a higher level < dl > and it was causing extra bottom margin. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.