patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -10,8 +10,7 @@ class UspsConfirmationMaker
end
def perform
- entry = UspsConfirmationEntry.new_from_hash(attributes)
- UspsConfirmation.create!(entry: entry.encrypted)
+ UspsConfirmation.create!(entry: attributes.to_json)
UspsConfirmationCode.create!(
profile: profile,
otp_fingerp... | [UspsConfirmationMaker->[perform->[fingerprint,encrypted,create!,new_from_hash],generate_otp->[encode,random_number],attr_reader]] | This method will perform the necessary actions to create a new user sequence. | I think we still want this to be encrypted, right? This will result in raw PII in our database otherwise. |
@@ -8166,6 +8166,12 @@ class TestMadQueue(QueueTest):
'Unlisted versions (2)',
reverse('reviewers.review', args=['unlisted', addon.slug])
))
+ # mixed, only unlisted flagged
+ addon = self.expected_addons[2]
+ expected.append((
+ 'Unlisted versions (1)'... | [QueueTest->[get_expected_addons_by_names->[generate_files],generate_file->[generate_files],_test_results->[get_addon_latest_version],setUp->[login_as_reviewer]],TestWhiteboard->[test_whiteboard_addition->[login_as_reviewer],test_whiteboard_addition_unlisted_addon->[login_as_reviewer],test_whiteboard_addition_content_r... | This test tests the results of the version_reviewer. get_all_versions method URL of the current page. | Do we have any that have both unlisted and listed versions flagged to test that case? |
@@ -843,7 +843,14 @@ namespace TTD
}
//shouldn't have any dynamic array valued properties
- TTDAssert(!Js::DynamicType::Is(curr->GetTypeId()) || (Js::DynamicObject::FromVar(curr))->GetObjectArray() == nullptr || (Js::DynamicObject::FromVar(curr))->GetObjectArray()->GetLength() == ... | [Clear->[Clear],AddNewScriptContextRecord->[AddNewScriptContext_Helper],ClearLoadedSourcesForSnapshotRestore->[Clear],SyncRootsBeforeSnapshot_Record->[CleanRecordWeakRootMap],ProcessFunctionBodyOnLoad->[ProcessFunctionBodyOnLoad],ProcessFunctionBodyOnUnLoad->[ProcessFunctionBodyOnUnLoad],SyncCtxtsAndRootsWithSnapshot_R... | Gather all objects that are known to be path - map. This function loads all properties in the list and processes the target objects as needed. called from js - core - path - to - path - to - path - to -. | > [](start = 54, length = 1) nit: trailing whitespace |
@@ -0,0 +1,11 @@
+package io.quarkus.config;
+
+import javax.inject.Inject;
+
+import org.eclipse.microprofile.config.Config;
+
+public class ConfigHolder {
+
+ @Inject
+ Config config;
+}
| [No CFG could be retrieved] | No Summary Found. | This shouldn't be needed IIUC, you could just pull `Config` out of CDI.current() instead of wrapping in this class |
@@ -189,7 +189,12 @@ def _create_bindings(config, logger, username, password):
call_log.setLevel(logging.INFO)
# Create the connection and bindings
- conn = PulpConnection(hostname, port, username=username, password=password, cert_filename=cert_filename, logger=logger, api_responses_logger=call_log)
... | [main->[expanduser,print_cli_map,join,disable_interspersed_args,exit,PulpCli,add_option,_create_bindings,parse_args,exception_handler_class,OptionParser,_,write,_create_prompt,prompt_password,render_spacer,run,load_extensions,ClientContext,_load_configuration,_initialize_logging],_create_prompt->[parse_bool,int,PulpPro... | Creates a bindings with a fully configured PulpConnection and bindings for a specific node. | I think this might not work in python 2.4. You could simplify it as `validate_ssl_ca = config['server']['verify_ssl'].lower() != 'false'` |
@@ -106,7 +106,7 @@ public class UnaryClientStream extends AbstractClientStream implements Stream {
response.setErrorMessage(status.description);
final AppResponse result = new AppResponse();
final Metadata trailers = getTrailers() == null ? getHeaders() : getTrailers();
- ... | [UnaryClientStream->[ClientUnaryInboundTransportObserver->[getThrowable->[tranFromStatusDetails]]]] | onError - Error callback. | `grpc-status-bin` maybe null,`status.cause` should be returned |
@@ -1147,7 +1147,8 @@ describe('$route', function() {
});
- it('should not reload a route when reloadOnSearch is disabled and only .search() changes', function() {
+ it('should not reload a route when reloadOnSearch is disabled and' +
+ 'only .search() changes without resolve promises defined', func... | [No CFG could be retrieved] | Requires the ngRoute directive to match the route with and without trailing slash. This is a hack to avoid the problem when using the route change event. | Is this change to the test description correct? |
@@ -118,3 +118,16 @@ async def test_delete_operation_location(lro_poller):
async def test_request_id(lro_poller):
result = await (await lro_poller(HttpRequest("POST", "/polling/request-id"), request_id="123456789")).result()
assert result['status'] == "Succeeded"
+
+@pytest.mark.asyncio
+async def test_conti... | [test_post_with_location_and_operation_location_headers->[lro_poller],test_post_resource_location->[lro_poller],test_post_with_location_and_operation_location_headers_no_body->[lro_poller]] | Test request id. | Could you tell me which scenario we want to test in these tests? |
@@ -117,14 +117,10 @@ func (s *CfgMgmtServer) exportNodes(ctx context.Context, request *pRequest.NodeE
// even after the node no longer exists
nodeFilters["exists"] = []string{"true"}
- if sortField == "" {
- sortField = backend.CheckIn
- } else {
- sortField = params.ConvertParamToNodeRunBackend(sortField)
- }... | [NodeExport->[Context,WithDeadline,Now,Deadline,exportNodes,Add],exportNodes->[Error,FormatFiltersWithKeyConverter,GetSortableFieldValue,Errorf,GetParameters,GetNodesPageByCurser,ConvertParamToNodeRunBackend],NewWriter,Error,NewReader,Sprintf,Marshal,ExpandedRunList,MarshalString,SplitAfterN,Deprecation,String,Errorf,S... | exportNodes returns a list of nodes that can be exported if err! = nil returns a status. Internal if err! = nil. | This code was misleading because: * `sortField` will never be blank by the time the code gets here, so the first branch is not necessary. In the call to `GetNodesPageByCursor` a default is set when the string is empty so it is doubly not necessary. * `sortField` has already been passed through `ConvertParamToNodeRunBac... |
@@ -113,10 +113,9 @@ func construct(ctx context.Context, req *pulumirpc.ConstructRequest, engineConn
return nil, err
}
- // Ensure all outstanding RPCs have completed before proceeding. Also, prevent any new RPCs from happening.
- pulumiCtx.waitForRPCs()
- if pulumiCtx.rpcError != nil {
- return nil, errors.Wra... | [LastIndex,GetInputDependencies,GetProject,GetParallel,ElementType,ValueOf,GetConfig,Slice,Wrap,Set,GetAliases,GetProviders,GetParent,ToURNOutput,GetDryRun,Field,MethodByName,GetUrns,New,GetProtect,GetName,Errorf,GetInputs,NumIn,Type,GetDependencies,GetStack,GetType,Wrapf,getState,UnmarshalProperties,Interface,TypeOf,G... | finds all provider resources that are referenced by the given request. rpcPropertyDeps converts the property dependencies map for the RPC and remove duplicates. | Why should we wait for (presumably locally initiated) work to finish before returning from construct? There might be interesting work waiting to be scheduled until construct returns, that might have an opportunity to start in parallel if we do not wait here. If we had reliable cross-node callbacks, would the intent her... |
@@ -717,9 +717,9 @@ namespace DotNetNuke.Entities.Urls
//Add name part of name/value pair
if (friendlyPath.EndsWith("/"))
{
- if (pair[0].ToLower() == "tabid") //always lowercase the tabid part of the path
+ ... | [AdvancedFriendlyUrlProvider->[FriendlyUrl->[FriendlyUrl],OutputFriendlyUrlMessages->[CheckForDebug],ImproveFriendlyUrlWithMessages->[CreateFriendlyUrl,DeterminePageNameAndExtension,DetermineExtension],GetFriendlyQueryString->[AddPage],GetFriendlyAlias->[GetCultureOfSettings,GetCultureOfPath]]] | Returns the friendly query string for a given tab and path. function to handle the case where a key is missing or if the value is missing. Add a n - ary entry to the URL. | Please use `String#Equals(String, StringComparison)` |
@@ -263,8 +263,9 @@ namespace Dynamo.PackageManager
{
this.PackageManagerClientViewModel = client;
PackageManagerClientViewModel.Downloads.CollectionChanged += DownloadsOnCollectionChanged;
+ PackageManagerClientViewModel.PackageManagerExtension.PackageLoader.DuplicatePacka... | [PackageManagerSearchViewModel->[Refresh->[Sort],SetSortingKey->[Sort],SearchAndUpdateResults->[ClearSearchResults,AddToSearchResults,SearchAndUpdateResults],Sort->[Sort],Search->[Sort],PackageOnExecuted->[JoinPackageNames],KeyHandler->[SelectPrevious,SelectNext],RefreshAndSearch->[Refresh],SetSortingDirection->[Sort]]... | Sort method. | I don't think we clean these up from anywhere - probably we should do it in the PackageManagerSerachView.Unloaded framework event. |
@@ -146,6 +146,12 @@ public final class SystemColumns {
1, VERSION_ONE_NAMES
);
+ private static final Set<ColumnName> MUST_BE_MATERIALIZED_FOR_TABLE_JOINS =
+ ImmutableSet.of(
+ ROWPARTITION_NAME,
+ ROWOFFSET_NAME
+ );
+
private static Set<ColumnName>... | [SystemColumns->[isSystemColumn->[isSystemColumn],isPseudoColumn->[isPseudoColumn],pseudoColumnNames->[pseudoColumnNames],systemColumnNames->[systemColumnNames]]] | get the pseudo column names by version. | A slightly cleaner way to structure this would be to create an object representing a pseudocolumn. This object could contain the pseudocolumn name and a boolean to specify whether the column should be materialized or not. By tying the two together in this way, it is not possible for someone to come along and add a new ... |
@@ -1749,6 +1749,11 @@ namespace System.Globalization
internal CalendarData GetCalendar(CalendarId calendarId)
{
+ if (GlobalizationMode.Invariant)
+ {
+ return CalendarData.Invariant;
+ }
+
Debug.Assert(calendarId > 0 && calendarId <= Cal... | [CultureData->[CreateCultureData->[NormalizeCultureName],GetSeparator->[UnescapeNlsString],DateSeparator->[ShortDates]]] | Get a calendar with the specified calendarId. | >CalendarData [](start = 23, length = 12) that will disallow having a read/write calendar object set. |
@@ -259,9 +259,12 @@ int ACE_TMAIN(int argc, ACE_TCHAR* argv[])
ACE_INET_Addr spdp(rtps_discovery->get_spdp_port(application_domain, application_participant_id), "127.0.0.1");
ACE_INET_Addr sedp(rtps_discovery->get_sedp_port(application_domain, application_participant_id), "127.0.0.1");
- SpdpHandler spdp_vert... | [No CFG could be retrieved] | region Public API Methods Opens the related handlers for the N - tuple. | Need to cover builds that are have security disabled at compile time using `OPENDDS_SECURITY` preprocessor macro |
@@ -76,9 +76,12 @@ namespace Microsoft.Xna.Framework.Audio
static SoundEffect()
{
- InitializeSoundEffect();
}
+ /// <devdoc>
+ /// This is called by <see cref="FrameworkDispatcher.Initialize()"/>
+ /// to ensure that XAudio is initialized on main thread.
+... | [SoundEffect->[PlatformSetupInstance->[BitsPerSample,_voice,DestroyVoice,None,ReferenceEquals,Dispose,Encoding,_format,MaximumFrequencyRatio,SampleRate,Channels],PlatformShutdown->[StopEngine,Stereo,DestroyVoice,Dispose,Shutdown],PlatformLoadAudioStream->[BitsPerSample,Format,CreateBuffers,ToDataStream,Length,Channels]... | InitializeSoundEffect - This method initializes a managed device object. | If the static constructor is now empty, remove it. |
@@ -30,11 +30,13 @@ final class ReadListener
{
private $collectionDataProvider;
private $itemDataProvider;
+ private $subresourceDataProvider;
- public function __construct(CollectionDataProviderInterface $collectionDataProvider, ItemDataProviderInterface $itemDataProvider)
+ public function __con... | [ReadListener->[getItemData->[getItem,get],getCollectionData->[isMethod,getCollection],onKernelRequest->[getItemData,getCollectionData,set,getRequest]]] | This method is called when the constructor of the class is not needed. | Same here, I would just disable this feature if the `subresourceDataProvider` is not passed, without triggering a deprecation notice. |
@@ -11,15 +11,6 @@ from . import views
PACKAGE_NAME = '(?P<package_name>[_\w]+)'
-# These will all start with /addon/<addon_id>/submit/
-submit_patterns = patterns(
- '',
- url('^$', lambda r, addon_id: redirect('devhub.submit.finish', addon_id)),
- url('^details$', views.submit_details, name='devhub.subm... | [decorate,include,partial,redirect,url,patterns,replace] | Adds a decorator to the urlconf to show the specific . Returns a url for editing the add - ons. | flattened this because it didn't seem worth it for only 2 sub patterns. |
@@ -75,6 +75,8 @@ plt.hlines(threshold_bonferroni, xmin, xmax, linestyle='--', colors='r',
label='p=0.05 (Bonferroni)', linewidth=2)
plt.hlines(threshold_fdr, xmin, xmax, linestyle='--', colors='b',
label='p=0.05 (FDR)', linewidth=2)
+plt.hlines(threshold_fdr, xmin, xmax, linestyle='--', colors... | [read_events,ppf,hlines,show,dict,get_data,ttest_1samp,min,abs,fdr_correction,ylabel,plot,print,data_path,close,bonferroni_correction,xlabel,Raw,xlim,legend,Epochs,pick_types] | Plots the horizontal lines of the nanoseconds in the plot. | threshold_fdr -> threshold_lfdr |
@@ -16,7 +16,9 @@ def test_gam_model_predict():
h2o_data["C2"] = h2o_data["C2"].asfactor()
myY = "C21"
model_test_data = h2o.import_file(pyunit_utils.locate("smalldata/gam_test/predictGaussianGAM1.csv"))
- buildModelCheckPredict(h2o_data, h2o_data, model_test_data, myY, ["C11", "C12", "C13"], 'gaussi... | [buildModelCheckPredict->[predict,train,H2OGeneralizedAdditiveEstimator,compare_frames_local,drop],test_gam_model_predict->[import_file,train,predict,H2OGeneralizedAdditiveEstimator,print,h2o_data,buildModelCheckPredict,locate],standalone_test,insert,test_gam_model_predict] | Test model for gaussian and multinomial models. H2O model for fractional binomial. | Nobody will look for tests verifying PUBDEV-7444 under test for PUBDEV-7181. |
@@ -210,6 +210,12 @@ crt_context_provider_create(crt_context_t *crt_ctx, int provider)
D_GOTO(out, rc);
}
+ /*******************************************/
+ /* Intentionally crash to get a stacktrace */
+ int * crash = NULL;
+ *crash = 1;
+ /*******************************************/
+
D_RWLOCK_WRLOCK(&crt_gd... | [No CFG could be retrieved] | region Private functions Initialize the metatime. | (style) "foo * bar" should be "foo *bar" |
@@ -64,10 +64,10 @@ class Notification < ActiveRecord::Base
end
def self.ensure_consistency!
- DB.exec(<<~SQL, Notification.types[:private_message])
+ DB.exec(<<~SQL)
DELETE
FROM notifications n
- WHERE notification_type = ?
+ WHERE high_priority = TRUE
AND NOT EXISTS... | [Notification->[types->[new],post_id->[pluck_first],ensure_consistency!->[types,exec],recent_report->[user_option,to_i,limit,present?,to_a,query_single,where,take,like_notification_frequency,each,like_notification_frequency_type,length,includes],data_hash->[parse,with_indifferent_access,blank?],remove_for->[delete_all]... | Checks if there is a private message that has a lease. If so deletes the lease and. | `where high_priority` should do the trick, I think the capital true is a bit too verbose. |
@@ -1654,13 +1654,12 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager,
}
}
}
-
- final List<String> hostTags = cmd.getHostTags();
+ List<String> hostTags = cmd.getHostTags();
if (hostTags != null) {
if (s_logger... | [ResourceManagerImpl->[getGPUDevice->[listAvailableGPUDevice],updateClusterPassword->[doUpdateHostPassword],attemptMaintain->[setHostIntoMaintenance,setHostIntoPrepareForMaintenanceAfterErrorsFixed,setHostIntoErrorInMaintenance,setHostIntoErrorInPrepareForMaintenance],createHostAndAgentDeferred->[markHostAsDisconnected... | Update a host. find the host with the same id and tags. | @DK101010 why removed 'final' ? |
@@ -242,4 +242,12 @@ abstract class AbstractListBuilder implements ListBuilderInterface
{
$this->groupByFields[$fieldDescriptor->getName()] = $fieldDescriptor;
}
+
+ /**
+ * {@inheritDoc}
+ */
+ public function inArray(AbstractFieldDescriptor $fieldDescriptor, $values){
+ $this->... | [AbstractListBuilder->[whereNot->[getName],addField->[getName],where->[getName],between->[getName],addGroupBy->[getName],in->[getName]]] | Adds a field descriptor to the group by list. | @danrot would you please check this code for the list builder? |
@@ -305,7 +305,7 @@ public class Storage {
db.execute("create table if not exists graves (" + " usn integer not null,"
+ " oid integer not null," + " type integer not null" + ")");
db.execute("INSERT OR IGNORE INTO col VALUES(1,0,0," +
- ... | [Storage->[addIndices->[_updateIndices],Collection->[Collection],_addSchema->[_addSchema]]] | Adds the schema for the missing tables. create table if not exists. | Again, why can't we pass in a `Time`? |
@@ -47,8 +47,10 @@ public class CassandraDatabaseClientTracer extends DatabaseClientTracer<CqlSessi
public void onResponse(Span span, ExecutionInfo executionInfo) {
Node coordinator = executionInfo.getCoordinator();
if (coordinator != null) {
- Optional<InetSocketAddress> address = coordinator.getBroa... | [CassandraDatabaseClientTracer->[CassandraDatabaseClientTracer]] | Called when a response is received from the coordinator. | I don't think it's related to this PR since we have many instrumentations with the same pattern - I often worry about blocking an event loop with a DNS lookup just to set a span attribute. I want (someone) to remove the spec's language encouraging a DNS lookup just to resolve an attribute. Just the word resolve makes i... |
@@ -80,6 +80,8 @@ func TestForwarding(t *testing.T) {
}
func TestVIC(t *testing.T) {
+ t.Skipf("Failing with CI")
+
log.SetLevel(log.PanicLevel)
options.IP = "127.0.0.1"
| [Hits,NewContainer,AddContainer,Stop,SetQuestion,Init,IPv4,Exchange,Misses,Start,Addr,SetLevel,Fatalf,NewNetwork,BindContainer,Wait] | TestForwarding test for the case where the bridge network is not available BridgeNetwork is the network. Network that is used to create the bridge network. | can you instead check the error from `bind` and report that - we cannot currently tell if this is a cascade failure from prior test (cannot reuse port?) or a separate problem. |
@@ -291,6 +291,16 @@ _inmobi.getNewAd;
data.siteid;
data.slotid;
+// innity.js
+var innity_adZone;
+var innityAMPZone;
+var innityAMPTag;
+data.pub;
+data.zone;
+data.width;
+data.height;
+data.channel;
+
// ix.js
data.ixId;
data.ixId;
| [No CFG could be retrieved] | Constructs an instance of Criteo. Create an instance of the kargo. js class. | data.width data.height exist for every 3p iframe. Please do not add them. |
@@ -166,3 +166,12 @@ export function useImperativeHandle(ref, create, opt_deps) {
export function toChildArray(unusedChildren) {
return preact.toChildArray.apply(undefined, arguments);
}
+
+/**
+ * @param {T} current
+ * @return {{current: T}}
+ * @template T
+ */
+export function useValueRef(current) {
+ return ... | [No CFG could be retrieved] | Transform an array of child nodes into an array of child nodes. | This should be moved within `src/preact/component`. This `src/preact/index` is reserved only for the standard Preact APIs. |
@@ -286,7 +286,11 @@ func (c *ChainLink) GetUID() keybase1.UID {
}
func (c *ChainLink) GetPayloadJSON() *jsonw.Wrapper {
- return c.payloadJSON
+ payloadJSON, err := jsonw.Unmarshal([]byte(c.unpacked.payloadJSONStr))
+ if err != nil {
+ return nil
+ }
+ return payloadJSON
}
func (c *ChainLink) ToSigChainLocati... | [ToEldestKID->[GetKID],verifyPayloadV2->[getPayloadHash,getIgnoreIfUnsupportedFromPayload,getPrevFromPayload,getSeqTypeFromPayload],NeedsSignature->[NeedsSignature,IsStubbed],GetMerkleHashMeta->[IsStubbed],MatchFingerprint->[Eq],getSigPayload->[getFixedPayload,IsStubbed],HasRevocations->[GetRevokeKids,GetRevocations],I... | GetPayloadJSON - returns the JSON payload of the link. | Urg, this is pretty scary, we're swallowing an error here.... |
@@ -576,6 +576,9 @@ def tf_lcmv(epochs, forward, noise_covs, tmin, tmax, tstep, win_lengths,
provided for each frequency bin.
freq_bins : list of tuples of float
Start and end point of frequency bins of interest.
+ subtract_evoked : bool | False
+ If True, subtract the averaged evoked r... | [_lcmv_source_power->[_prepare_beamformer_input],lcmv_raw->[_apply_lcmv],lcmv->[_apply_lcmv],tf_lcmv->[_lcmv_source_power],lcmv_epochs->[_apply_lcmv]] | This function is a wrapper for the LCMV function. Universal object of type CorticalActivity where the object is not in the epochs object Compute the LCMV for a series of time windows that contain the current time window along Returns the mean time point in the current residue in the system. | bool | False means bool or False it should just be `bool` |
@@ -791,6 +791,15 @@ env:
'/x/y/z', '$spack/var/spack/repos/builtin']
+def test_write_empty_single_file_scope(tmpdir):
+ env_schema = spack.schema.env.schema
+ scope = spack.config.SingleFileScope(
+ 'test', str(tmpdir.ensure('config.yaml')), env_schema, ['spack'])
+ scope.write_section... | [test_write_key_in_memory->[check_compiler_config],test_internal_config_section_override->[write_config_file],test_config_parse_list_in_dict->[get_config_error],test_config_parse_dict_in_list->[get_config_error],test_read_config_merge_list->[write_config_file],test_read_config_override_list->[write_config_file],test_se... | Check a Spack YAML schema against some data. | Does it have to be `None`? Or could any `val` such that `bool(val) == False` be sufficient (e.g. an empty dictionary)? |
@@ -87,5 +87,17 @@ namespace Microsoft.Extensions.Hosting.Internal
message: "BackgroundService failed");
}
}
+
+ public static void BackgroundServiceStoppingHost(this ILogger logger, Exception ex)
+ {
+ if (logger.IsEnabled(LogLevel.Critical))
+ ... | [HostingLoggerExtensions->[Stopped->[Stopped],StoppedWithException->[StoppedWithException],Stopping->[Stopping],Starting->[Starting],BackgroundServiceFaulted->[BackgroundServiceFaulted],Started->[Started]]] | Background service faulted. | I think this `args: ex` can be removed now, since the exception is flown into `exception`. #Closed |
@@ -481,6 +481,11 @@ class BlobProperties(DictMixin):
container-level scope is configured to allow overrides. Otherwise an error will be raised.
:ivar bool request_server_encrypted:
Whether this blob is encrypted.
+ :ivar dict(str, dict(str, str)) object_replication_source_properties:
+ ... | [BlobProperties->[_from_generated->[BlobProperties,_from_generated,BlobType],__init__->[BlobType]],ContainerPropertiesPaged->[_build_item->[_from_generated]],BlobAnalyticsLogging->[_from_generated->[_from_generated]],Metrics->[_from_generated->[_from_generated]],ContainerProperties->[_from_generated->[_from_generated]]... | Initialize a Blob object. | Missing closing angle brackets |
@@ -220,9 +220,12 @@ class WPSEO_Post_Type_Sitemap_Provider implements WPSEO_Sitemap_Provider {
return $links;
}
- $stacked_urls = array();
$posts_to_exclude = $this->get_excluded_posts();
+ if ( $post_type === 'page' && $this->get_page_on_front_id() ) {
+ $posts_to_exclude[] = $this->get_page_on_... | [WPSEO_Post_Type_Sitemap_Provider->[get_sitemap_links->[get_page_on_front_id,get_page_for_posts_id],get_first_links->[get_page_on_front_id,get_home_url],get_post_type_archive_link->[get_page_for_posts_id]]] | Get the links for a given post type. Filter URL entry before it gets added to the sitemap. | I think this can be moved to the `get_excluded_posts` method. To keep that responsibility together. |
@@ -90,9 +90,12 @@ function isArrayLike(obj) {
return true;
}
- return isArray(obj) || !isFunction(obj) && (
- length === 0 || typeof length === "number" && length > 0 && (length - 1) in obj
- );
+ if (typeof obj !== 'object') {
+ return typeof obj === 'string';
+ }
+
+ return isArray(obj) || lengt... | [No CFG could be retrieved] | Determines if a given object or array - like object has a unique identifier for each item in For each object in obj call the iterator function and return the first object that passes the iterator. | FYI, functions have a .length property which is why the jQuery implementation was explicitly making sure it wasn't a function. Should probably continue to handle that case so functions aren't treated as ArrayLike |
@@ -1767,10 +1767,7 @@ namespace DotNetNuke.Security.Membership
//Global Data Store but not in the Local DataStore ie. A shared Global Data Store
//Initialise Login Status to Failure
- loginStatus = UserLoginStatus.LOGIN_FAILURE;
-
- DataCache.ClearUserCache(portalId, u... | [AspNetMembershipProvider->[UnLockUser->[GetCacheKey],GetPassword->[AutoUnlockUser,GetPassword],UserInfo->[AutoUnlockUser,GetCacheKey,FillUserMembership,UpdateUser],RemoveUser->[RemoveUser,DeleteMembershipUser],UpdateUsersOnline->[UpdateUsersOnline],RestoreUser->[RestoreUser],ChangePasswordQuestionAndAnswer->[ChangePas... | This method is called by the login process. It checks if the user is in the DB Check if the user has a lease and if so approve it. If it has a. | By removing this call at the beginning it is possible that when beginning the login call you will get a cached user object, which might not have been properly invalidated, thus allowing the user to be identified as a non-deleted user. I don't believe it would be safe to remove this call here? Can you confirm the valida... |
@@ -43,7 +43,7 @@ def state_transtion_acc(state, state_change):
def new_wal(state_transition: Callable, state: State = None) -> WriteAheadLog:
- serializer = JSONSerializer
+ serializer = JSONSerializer()
state_manager = StateManager(state_transition, state)
storage = SerializedSQLiteStorage(":me... | [state_transtion_acc->[AccState],test_wal_has_version->[new_wal],test_write_read_events->[new_wal],test_restore_without_snapshot_in_batches->[new_wal],test_restore_without_snapshot->[new_wal],state_transition_noop->[Empty],test_get_snapshot_before_state_change->[new_wal,AccState],test_write_read_log->[new_wal]] | Create a new WAL. | Wow, how did these test work? |
@@ -28,6 +28,8 @@ var jsdom = require('jsdom');
var path = require('path');
var request = require('request');
var url = require('url');
+// SERVE_MODE is defaulted to be 'max' if not specified
+var mode = process.env.SERVE_MODE;
app.use(bodyParser.json());
app.use('/request-bank', require('./request-bank'));
| [No CFG could be retrieved] | Provides a list of static files and directories that can be accessed via a ethernet server. Middleware for all of the Nginx pwa routes. | how about just `MODE`? |
@@ -36,7 +36,7 @@ namespace System.Net.Http.Json
public static System.Threading.Tasks.Task<T?> ReadFromJsonAsync<T>(this System.Net.Http.HttpContent content, System.Text.Json.JsonSerializerOptions? options = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken... | [No CFG could be retrieved] | Reads from json asynchronously. | If the approach in this PR looks good, then I'll take this diff to API review (likely offline). Edit: this no longer applies, per second commit. |
@@ -134,7 +134,7 @@ class TestCudaConstantMemory(CUDATestCase):
self.assertTrue(np.all(A == CONST3D))
if not ENABLE_CUDASIM:
- if cuda.runtime.get_version() in ((8, 0), (9, 0), (9, 1)):
+ if cuda.runtime.get_version() in ((8, 0), (9, 0), (9, 1), (11, 2)):
compl... | [cuconstRecAlign->[grid,array_like],cuconstAlign->[grid,array_like],cuconstRec->[grid,array_like],cuconst3d->[array_like],cuconstEmpty->[grid,len,array_like],cuconstRecEmpty->[grid,len,array_like],TestCudaConstantMemory->[test_const_align->[full,jit,all,assertTrue],test_const_record_optimization->[split,get_version,ass... | Test if a constant array of 3 - dimensional data is loaded. | What about the versions in between, e.g. 10? Are they all covered by `else`? Please remind me why :) (and then put in a note) thanks! |
@@ -27,12 +27,14 @@
import asyncio
from typing import AsyncIterator
from multidict import CIMultiDict
-from . import HttpRequest, AsyncHttpResponse
+from . import HttpRequest
+from ._http_response_impl_async import AsyncHttpResponseImpl
+from ._helpers import HeadersType
from ._helpers_py3 import iter_raw_helper, i... | [RestAioHttpTransportResponse->[iter_bytes->[iter_bytes_helper,close],close->[sleep,close],__getstate__->[copy,CIMultiDict],__init__->[get,super,CIMultiDict],iter_raw->[iter_raw_helper,close]]] | Initialize a new object with the specified nanomsg. | We need to make sure that `HeadersType` is `import`ed from the "right" location (e.g. where we expect users of the library to import it from). |
@@ -0,0 +1,13 @@
+# Copyright (c) 2017-present, Facebook, Inc.
+# All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree. An additional grant
+# of patent rights can be found in the PATENTS file in the same directory.
+
+# ... | [No CFG could be retrieved] | No Summary Found. | what is this file for? |
@@ -301,3 +301,14 @@ func getMatrixHookRequest(t *models.HookTask) (*http.Request, error) {
return req, nil
}
+
+// getTxnID creates a txnID based on the payload to ensure idempotency
+func getTxnID(payload []byte) (string, error) {
+ h := sha1.New()
+ _, err := h.Write(payload)
+ if err != nil {
+ return "", err... | [JSONPayload->[MarshalIndent],ReplaceAll,ReplaceAllString,Set,Error,Add,NewReader,Sprintf,NewRequest,New,Unmarshal,MarshalIndent,RefEndName,Errorf,MustCompile,HasPrefix,EscapeString,safePayload] | get a list of all the nodes. | It should probably be named `getMatrixTxnID` |
@@ -350,6 +350,17 @@ func resourceAwsEMRCluster() *schema.Resource {
ForceNew: true,
Optional: true,
},
+ "configurations_json": {
+ Type: schema.TypeString,
+ Optional: true,
+ ForceNew: true,
+ ValidateFunc: validateJsonString,
+ DiffSuppressFunc: suppres... | [StringValueSlice,GetChange,SetPartial,StringSlice,Close,StringValueMap,StringInSlice,RemoveTags,ListInstanceGroups,Partial,HasPrefix,NonRetryableError,Set,ListInstances,Code,ModifyInstanceGroups,ReadFile,GetOk,DescribeCluster,HasChange,ListBootstrapActions,Errorf,SetTerminationProtection,SetId,RetryableError,Bool,Trim... | The validation function for the resource - level configuration. This function is used to create a resource in the EMR cluster. It is used to. | We should prefer to also deprecate the `configurations` attribute in this process to prevent further usage after the next major release. The two attributes should also conflict with each other as well. |
@@ -58,6 +58,7 @@ export class Observable {
if (index > -1) {
this.handlers_.splice(index, 1);
}
+ dev().error('Can\'t remove nonexistent handler %s.', handler);
}
/**
| [No CFG could be retrieved] | Observes an observable sequence of events that are registered with the UnlistenDef. | We should keep this error at the story level like you did before, otherwise it might start throwing everywhere in the AMP codebase |
@@ -674,7 +674,8 @@ namespace Dynamo.Core
nodeGraph.ElementResolver,
workspaceInfo);
}
- else {
+ else
+ {
Exception ex;
if (DynamoUtilities.PathHelper.isValidJson(workspaceInfo.FileName, out jsonDoc, out e... | [CustomNodeManager->[GetAllDependenciesGuids->[Contains],RegisterCustomNodeWorkspace->[RegisterCustomNodeWorkspace,SetNodeInfo,SetFunctionDefinition,OnInfoUpdated,OnDefinitionUpdated,Remove],IsInitialized->[IsInitialized],WorkspaceModel->[RegisterCustomNodeWorkspace],CustomNodeWorkspaceModel->[RegisterCustomNodeWorkspa... | Initialize a custom node. | I see the nodeGraph is instantiated from an xml file? Is that why it doesn't get the correct element resolver as we are now using JSON? |
@@ -57,8 +57,9 @@ class FirstPartyModuleToAddressMapping:
# imports, where we don't care about the specific symbol, but only the module. For example,
# with `from my_project.app import App`, we only care about the `my_project.app` part.
#
- # We do not look past the direct parent, as t... | [ThirdPartyModuleToAddressMapping->[address_for_module->[address_for_module]],map_third_party_modules_to_addresses->[ThirdPartyModuleToAddressMapping],map_module_to_address->[address_for_module,PythonModuleOwners,addresses_for_module],map_first_party_modules_to_addresses->[create_from_stripped_path,FirstPartyModuleToAd... | Returns the addresses for the given module. | This won't run in parallel with the rest of the body of this rule. It's not critical, but another factoring might be to have both the existing and new providers of `PythonFirstPartyModuleMapping` be implemented uniformly behind the union, which would result in all of them running in parallel in this first multiget. |
@@ -80,9 +80,13 @@ public class LdapContextFactory {
private Hashtable<String, String> getEnvironment(final String principal, final String password, final String providerUrl, final boolean isSystemContext, Long domainId) {
final String factory = _ldapConfiguration.getFactory();
- final String url... | [LdapContextFactory->[createUserContext->[createInitialDirContext],createInitialDirContext->[createInitialDirContext],getEnvironment->[enableSSL],createBindContext->[createBindContext]]] | Get the environment. | Can we do a `Strings.isNullOrEmpty()` instead? |
@@ -89,7 +89,7 @@ class AccountManager:
files = os.listdir(self.keystore_path)
except OSError as ex:
msg = 'Unable to list the specified directory'
- log.error('%s %s: %s', msg, self.keystore_path, ex)
+ log.error('OsError', msg=msg, path=self... | [find_keystoredir->[find_datadir],AccountManager->[get_privkey->[address_in_keystore],__init__->[find_keystoredir]],Account->[load->[check_keystore_json,load,Account]]] | Initialize the object with a keystore path and a list of account names. | I think it would be nicer to have clearer keywords for user visible stuff: `message=msg` and `exception=ex` |
@@ -87,6 +87,10 @@ public class InlineSchemaAvroBytesDecoder implements AvroBytesDecoder
try {
return reader.read(null, DecoderFactory.get().binaryDecoder(inputStream, null));
}
+ catch (EOFException eof) {
+ // waiting for avro v1.9.0 (#AVRO-813)
+ throw new ParseException("Avro's unneces... | [InlineSchemaAvroBytesDecoder->[parse->[singletonList,ByteBufferInputStream,binaryDecoder,ParseException,read],checkArgument,parse,writeValueAsString,info,Logger]] | Parse an avro message. | Please include the JIRA link in this message and others like it. |
@@ -330,12 +330,14 @@ def spatio_temporal_cluster_test_connectivity():
T_obs, clusters, p_values_conn, hist = \
spatio_temporal_cluster_test([data1_2d, data2_2d], connectivity=conn,
n_permutations=50, tail=1, seed=1,
- threshold=thr... | [spatio_temporal_cluster_test_connectivity->[randn,dict,spatio_temporal_cluster_test,assert_equal,sum,transpose,RandomState,grid_to_graph,dstack],test_permutation_connectivity_equiv->[randn,assert_array_equal,any,dict,partial,enumerate,assert_true,len,where,zeros,RandomState,grid_to_graph,permutation_cluster_1samp_test... | Test cluster level permutations with and without connectivity. | can you test that results are exactly the same with and without buffer_size? |
@@ -194,11 +194,11 @@ public class FilterCnfConversionTest
)
)
);
- final Set<Filter> expected = ImmutableSet.of(
+ final List<Filter> expected = ImmutableList.of(
FilterTestUtils.selector("col1", "val1"),
FilterTestUtils.selector("col2", "val2")
);
- final Set... | [FilterCnfConversionTest->[visitSelectorFilters->[visitSelectorFilters],populate->[populate]]] | This method converts a set of two or more complex filters into a set of one or more Tests if a given key is in the expected list of filters. FilterTestUtils. or which is a CNF filter which performs a logical OR operation. | Another note: these were also just reorderings. |
@@ -22,17 +22,7 @@ public class AwsSdkInstrumentationModule extends InstrumentationModule {
@Override
public String[] additionalHelperClassNames() {
- return new String[] {
- "io.opentelemetry.javaagent.instrumentation.awssdk.v2_2.TracingExecutionInterceptor",
- "io.opentelemetry.instrumentation.aw... | [AwsSdkInstrumentationModule->[typeInstrumentations->[singletonList,AwsSdkInitializationInstrumentation],classLoaderMatcher->[hasClassesNamed]]] | This method is overridden to provide additional helper classes that are needed by the instrumentation. | Thanks a lot for the change!!! Just checking, will muzzle task fail if this class isn't included now? |
@@ -69,9 +69,14 @@ class DefaultSourceCallbackContext implements SourceCallbackContextAdapter {
sourceCallback.getConfigurationInstance(),
connectionHandler);
- transactionHan... | [DefaultSourceCallbackContext->[hasVariable->[containsKey],bindConnection->[IllegalArgumentException,XaTransactionHandle,getConnectionHandler,checkArgument,getSimpleName,getConfigurationInstance,isTransacted,getTransactionConfig,DefaultTransactionHandle,bindToTransaction,getTransactionManager],getVariable->[get,ofNulla... | Binds a connection to the source callback context. | I retrieve the TX Manager inside the `If` so I don't have to go to the registry, only when the given connection can be part of an XA TX |
@@ -384,6 +384,7 @@ func (g *GitlabDownloader) GetIssues(page, perPage int) ([]*base.Issue, bool, er
}
// GetComments returns comments according issueNumber
+// TODO: figure out how to transfer comment reactions
func (g *GitlabDownloader) GetComments(issueNumber int64) ([]*base.Comment, error) {
var allComments ... | [GetReleases->[convertGitlabRelease],GetTopics->[New],GetMilestones->[New],GetRepoInfo->[New],GetLabels->[New]] | GetComments returns all comments for an issue Notes - all comments. | Remove this line since line 521? |
@@ -57,11 +57,11 @@ type ProspectorConfig struct {
}
type HarvesterConfig struct {
+ common.EventMetadata `config:",inline"` // Fields and tags to add to events.
+
BufferSize int `config:"harvester_buffer_size"`
DocumentType string `config:"document_type"`
Encoding string `config:"e... | [FetchConfigs->[Info,Fatal,Fatalf],Stat,IsDir,Glob,Read,Info] | Config for the given number of non - zero non - zero non - zero non - zero Config for the object. | +1 on approaching this directly with an eventMetadata object. That makes it easy to extend it later with other fields. |
@@ -14,12 +14,14 @@ import io.restassured.RestAssured;
@QuarkusTest
public class InfinispanClientFunctionalityTest {
@Test
- public void testClientFunctionalityFromServlet() {
+ public void testGetAllKeys() {
+ System.out.println("Running getAllKeys test");
RestAssured.when().get("/test").t... | [InfinispanClientFunctionalityTest->[testQuery->[is,body],testIckleQuery->[is,body],testClientFunctionalityFromServlet->[is,body],cq->[is,body],testNearCacheInvalidation->[is,body],increment->[print,assertEquals,parseInt]]] | Test client functionality from servlet. | @wburns is this normal? I'm testing this new version ASAP btw :) |
@@ -53,14 +53,10 @@ namespace System.Xml.Linq
/// <summary>
/// Gets or sets the internal subset for this Document Type Definition (DTD).
/// </summary>
- public string InternalSubset
+ public string? InternalSubset
{
get
{
- // ... | [XDocumentType->[GetDeepHashCode->[GetHashCode],Task->[IsCancellationRequested,WriteDocTypeAsync,FromCanceled,nameof],DeepEquals->[_publicId,_name,SystemId,_internalSubset],WriteTo->[WriteDocType,nameof],Value,nameof,NotifyChanged,_name,VerifyName,GetAttribute,Name,_publicId,_internalSubset,DocumentType,Read,NotifyChan... | XML - based XNode type objects. property gets the node type for this node. | This a breaking change and needs to be added to the relevant docs for that. |
@@ -123,7 +123,9 @@ public abstract class SqlTransform extends PTransform<PInput, PCollection<Row>>
}
sqlEnvBuilder.setQueryPlannerClassName(
- input.getPipeline().getOptions().as(BeamSqlPipelineOptions.class).getPlannerName());
+ MoreObjects.firstNonNull(
+ queryPlannerClassName(),... | [SqlTransform->[Builder->[buildExternal->[build]],expand->[queryString,defaultTableProvider,autoUdfUdafLoad,queryParameters],registerUdf->[registerUdf],External->[knownBuilders->[of]],withTableProvider->[tableProviderMap]]] | Expand the query and return a collection of rows. | Do you think if it is helpful to find a "working" class name, rather than a "non null" parameter? (meaning that try first class name even if it is non-null, if there is an exception, try the next one.) |
@@ -28,10 +28,10 @@ namespace Microsoft.Extensions.Configuration
/// <summary>
/// Shorthand for GetSection("ConnectionStrings")[name].
/// </summary>
- /// <param name="configuration">The configuration.</param>
+ /// <param name="configuration">The <see cref="IConfiguration"/> ... | [ConfigurationExtensions->[IConfigurationSection->[Exists],AsEnumerable->[AsEnumerable]]] | Get connection string. | I think you also need to do the same changes in `Ref` project |
@@ -343,16 +343,6 @@ resource "aws_iot_topic_rule" "rule" {
sql = "SELECT * FROM 'topic/test'"
sql_version = "2015-10-08"
- // Fake data
- dynamodb {
- hash_key_field = "hash_key_field"
- hash_key_value = "hash_key_value"
- payload_field = "payload_field"
- range_key_field = "range_key_field"
- ... | [ParallelTest,Meta,Sprintf,TestCheckResourceAttr,RootModule,ComposeTestCheckFunc,ListTopicRules,Errorf,RandString] | A simple example of how to create a topic rule Example rule for aws_iot_topic_rule. | now we have the inverse problem where `range_key_field`, etc. is not being acceptance tested at all. Could you create a test and test configuration very similar to the new one which includes the newly optional arguments? See also `TestAccAWSIoTTopicRule_firehose_separator` which tests the optional argument separate f... |
@@ -85,6 +85,8 @@ public final class SparkContextFactory {
conf.setMaster(options.getSparkMaster());
}
conf.setAppName(options.getAppName());
+ // register immutable collections serializers because the SDK uses them.
+ conf.set("spark.kryo.registrator", BeamSparkRunnerRegistrator.class.... | [SparkContextFactory->[createSparkContext->[isStopped,getUsesProvidedSparkContext,getCanonicalName,RuntimeException,error,setAppName,JavaSparkContext,getAppName,set,contains,getSparkMaster,info,setMaster,getProvidedSparkContext,SparkConf],getSparkContext->[isStopped,getUsesProvidedSparkContext,IllegalArgumentException,... | Creates a new Spark context based on the provided options. | Seems like a trivial test to have |
@@ -53,6 +53,7 @@ func testAccPreCheck(t *testing.T) {
"GOOGLE_CREDENTIALS",
"GOOGLE_CLOUD_KEYFILE_JSON",
"GCLOUD_KEYFILE_JSON",
+ "GOOGLE_USE_DEFAULT_CREDENTIALS",
}
if v := multiEnvSearch(creds); v == "" {
t.Fatalf("One of %s must be set for acceptance tests", strings.Join(creds, ", "))
| [Join,ReadFile,Setenv,Fatal,Fatalf,Errorf,InternalValidate,Getenv] | TestProvider creates a ResourceProvider that checks for the presence of an explicit . getTestRegion returns the region of the region in which the test was run. | Does this also need to be added to `provider.go` so that the credentials will be picked up? Unless I'm mistaken this section here just pre-validates that we have some kind of credentials to move forward with. Are they picked up somewhere else that I'm not seeing? |
@@ -56,8 +56,13 @@ public class MinionGeneralPillarGenerator implements MinionPillarGenerator {
* @return the SaltPillar containing the pillar data
*/
@Override
- public Optional<SaltPillar> generatePillarData(MinionServer minion) {
- SaltPillar pillar = new SaltPillar();
+ public Optional... | [MinionGeneralPillarGenerator->[MinionGeneralPillarGenerator]] | Generate the pillar data for a given minion. | Maybe it should call `pillar.getPillar().clear()` here, to be sure that there are no obsolete entries left. The same in other Pillar Generators. |
@@ -200,7 +200,7 @@ public class JsonObjectDecoderTest {
EmbeddedChannel ch = new EmbeddedChannel(new JsonObjectDecoder());
// {"foo" : "bar\\"}
String json = "{\"foo\" : \"bar\\\\\"}";
- System.out.println(json);
+
ch.writeInbound(Unpooled.copiedBuffer(json, CharsetUt... | [JsonObjectDecoderTest->[testSpecialJsonCharsInString->[EmbeddedChannel,JsonObjectDecoder,assertFalse,copiedBuffer,release,toString,readInbound,finish,writeInbound,assertEquals],testJsonObjectOverMultipleWrites->[EmbeddedChannel,JsonObjectDecoder,assertFalse,copiedBuffer,release,toString,readInbound,finish,writeInbound... | This test fails if the backslash in the json is not found. | Remove trailing whitespaces. |
@@ -40,6 +40,7 @@ function $RouteProvider(){
}
var routes = {};
+ var self = this;
/**
* @ngdoc method
| [No CFG could be retrieved] | Provides a route provider for a n - index route. / color - brown - largecode - code - with - slashes - edit. | Don't forget to remove this as well if it is not necessary any more. |
@@ -271,6 +271,10 @@ class EventHubConsumerClient(ClientBaseAsync):
For detailed partition context information, please refer to
:class:`PartitionContext<azure.eventhub.aio.PartitionContext>`.
:type on_event: Callable[~azure.eventhub.aio.PartitionContext, ~azure.eventhub.EventData]
+ ... | [EventHubConsumerClient->[get_eventhub_properties->[super],receive->[any,start,stop,format,ValueError,EventProcessor,warning],get_partition_properties->[super],close->[super,gather,values,stop],__aexit__->[close],_create_consumer->[EventHubConsumer,format,get],get_partition_ids->[super],__init__->[dict,super,Lock,pop],... | Receive events from a partition with optional load - balancing and checkpointing. This function tracks the information about the last - enqueued event in the partition. This is This method should be called when a new internal partition consumer is created and when a new partition Create event processor and start event ... | A bit confused by the description, I would expect more explicit here: If it's None or 0, the callback won't be called. If it's specified, it will be called with `event` being None if no event is received within `max_wait_time` since `on_event` is last called. |
@@ -67,7 +67,7 @@ func (t *timestampOracle) getTimestampPath() string {
func (t *timestampOracle) loadTimestamp() (time.Time, error) {
data, err := etcdutil.GetValue(t.client, t.getTimestampPath())
if err != nil {
- return typeutil.ZeroTime, err
+ return typeutil.ZeroTime, errs.ErrEtcdKVGet.Wrap(err).FastGenWith... | [saveTimestamp->[getTimestampPath],UpdateTimestamp->[saveTimestamp],SyncTimestamp->[saveTimestamp,loadTimestamp],ResetUserTimestamp->[saveTimestamp],loadTimestamp->[getTimestampPath]] | loadTimestamp loads the timestamp from etcd. | this error has been handled in the lower level, just return it |
@@ -108,6 +108,9 @@ class MsgDispatcher(MsgDispatcherBase):
def handle_update_search_space(self, data):
self.tuner.update_search_space(data)
+ def handle_feed_tuner_data(self, data):
+ self.tuner.feed_tuner_data(data)
+
def handle_add_customized_trial(self, data):
# data: parame... | [MsgDispatcher->[load_checkpoint->[load_checkpoint],save_checkpoint->[save_checkpoint],_earlystop_notify_tuner->[_handle_final_metric_data],_handle_intermediate_metric_data->[_sort_history],handle_add_customized_trial->[_pack_parameter,_create_parameter_id],handle_request_trial_jobs->[_pack_parameter,_create_parameter_... | Handle the update of the search space. | tuner or tuning? This function is also used by the Advisor. |
@@ -731,8 +731,13 @@ public abstract class FileBasedSink<T> extends Sink<T> {
}
@Override
- public void remove(Collection<String> filenames) throws IOException {
- gcsUtil.remove(filenames);
+ public void removeDirectoryAndFiles(String directory) throws IOException {
+ IOChannelFactory facto... | [FileBasedSink->[LocalFileOperations->[copyOne->[copy]],populateDisplayData->[populateDisplayData],GcsOperations->[copy->[copy],remove->[remove],create],FileBasedWriteOperation->[removeTemporaryFiles->[buildTemporaryFilename],generateDestinationFilenames->[getFileExtension],getBaseOutputFilename],FileBasedWriter->[clos... | Remove a list of files from the GCS. | why match instead of deleting the specific files whose names we have? |
@@ -1,4 +1,4 @@
-// Copyright 2016-2021, Pulumi Corporation.
+// Copyright 2016-2020, Pulumi Corporation.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
| [RemoveAll,Dir,WriteFile,Walk,IsNotExist,Error,Stat,ReadFile,IsExist,ReadDir,Bytes,Logf,Join,Equal,Contains,Name,ToSlash,NoError,Ext,Base,Rel,Split,MkdirAll,ImportSpec,ReplaceAll,IsDir,Sprintf,Unmarshal,FromSlash,Open,Fail,Getenv,Trim] | GeneratePackageFilesFromSchema loads a schema and generates files using the provided function. LoadFiles loads the list of files from a directory and returns a map of language - >. | Why are we reverting the year? |
@@ -309,6 +309,7 @@ HRESULT RunScript(LPCWSTR fileName, LPCWSTR fileContents, BYTE *bcBuffer, char16
Error:
if (messageQueue != nullptr)
{
+ messageQueue->RemoveAll();
delete messageQueue;
}
return hr;
| [No CFG could be retrieved] | This function runs a serialized script that has already been processed by the compiler. Creates a new context object. | Is this because of the error while JsRunScript? #Resolved |
@@ -1160,6 +1160,18 @@ func (s *Deliverer) processAttachment(ctx context.Context, obr chat1.OutboxRecor
return obr, nil
}
+type unfurlerPermError struct{}
+
+func (e unfurlerPermError) Error() string {
+ return "unfurler permanent error"
+}
+
+func (e unfurlerPermError) IsImmediateFail() (chat1.OutboxErrorType, bo... | [processReactionMessage->[getMessage],SendUnfurlNonblock->[Send],failMessage->[Error,alertFailureChannels],doNotRetryFailure->[disconnectedTime,IsImmediateFail],Send->[Queue,Prepare,deleteAssets,presentUIItem],Start->[SetClock],Prepare->[processReactionMessage,addSenderToMessage,resolveOutboxIDEdit,addPrevPointersAndCh... | processAttachment processes an attachment. processUnfurl processes an unfurl message. | can you store the original error so we can make sure it's not on our end? |
@@ -254,6 +254,9 @@ func (c *MasterConfig) Run(stopCh <-chan struct{}) error {
// add post-start hooks
aggregatedAPIServer.GenericAPIServer.AddPostStartHookOrDie("template.openshift.io-sharednamespace", c.ensureOpenShiftSharedResourcesNamespace)
aggregatedAPIServer.GenericAPIServer.AddPostStartHookOrDie("authoriz... | [withNonAPIRoutes->[newOpenshiftNonAPIConfig],withOpenshiftAPI->[newOpenshiftAPIConfig],Run->[withNonAPIRoutes,withOpenshiftAPI,withKubeAPI,Run,withAPIExtensions,withAggregator],buildHandlerChain->[newWebConsoleProxy,newOAuthServerHandler]] | Run starts the master A separate gofunc that will panic if there is no healthz watching thread. | the naming was strange before. `template.openshift.io` looks like an dns name. But then we have a `-something` postfix. |
@@ -292,16 +292,6 @@ def fix_env(env=None):
return env
-def convert_to_unicode(data):
- if isinstance(data, builtin_str):
- return str(data)
- if isinstance(data, dict):
- return dict(map(convert_to_unicode, data.items()))
- if isinstance(data, (list, tuple)):
- return type(data)(... | [_visual_center->[_visual_width],to_chunks->[_split,_to_chunks_by_chunks_number],_to_chunks_by_chunks_number->[_split],dict_filter->[fix_key,dict_filter],dict_md5->[bytes_md5,dict_filter],fix_env->[is_binary],walk_files->[dvc_walk],relpath->[relpath],remove->[_chmod],boxify->[colorize],file_md5->[dos2unix]] | Convert data to unicode. | How does `data` depend on whether or not `builtin_str` is a str or not? |
@@ -56,6 +56,13 @@ namespace Dynamo.Graph.Nodes
Description = GetDescription();
ShouldDisplayPreviewCore = false;
+ if (OriginalNodeContent != null)
+ {
+ var legacyFullName = OriginalNodeContent.Attributes["function"];
+ if (legacyFullName... | [DummyNode->[SerializeCore->[SerializeCore,SaveNode],DeserializeCore->[DeserializeCore,LoadNode]]] | Creates a DummyNode object from an xml node. This method is used to find the legacyName of the nodeElement. | Oh, I missed this point. what if this DummyNode doesn't represent a DSFunction node? Should we initialize LegacyFullName = legacyName at the beginning? |
@@ -2410,7 +2410,7 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
private static class DefaultFeedAdapter implements FeedAdapter<Run> {
public String getEntryTitle(Run entry) {
- return entry+" ("+entry.getBuildStatusSummary().message+")";
+ ret... | [Run->[getIconColor->[getIconColor,isBuilding,getResult],getRootDir->[toString],getACL->[getACL],onLoad->[onLoad],getPreviousBuildInProgress->[getPreviousBuild,_this,isBuilding],getPreviousNotFailedBuild->[getPreviousBuild,getResult],writeLogTo->[getLogInputStream],doBuildTimestamp->[getTime],doConsoleText->[getLogInpu... | Get the title of the entry. | this name is localizable. I am not sure it is safe in this case |
@@ -16,8 +16,14 @@ namespace Microsoft.Xna.Framework.Graphics
private bool _isDisposed;
private BlendState _blendState;
- private BlendState _actualBlendState;
- private DepthStencilState _depthStencilState = DepthStencilState.Default;
+ private BlendState _actualBlendState;
+
+... | [GraphicsDevice->[ApplyRenderTargets->[Clear],DrawUserPrimitives->[DrawUserPrimitives],Dispose->[Dispose],SetRenderTarget->[SetRenderTarget],SetIndexBuffer,Initialize]] | Construct a new GraphicsDevice object that represents a single . The active vertex shader for a specific object. | Do you mind cleaning up the blend state declarations? Like here you have the `_blendState` and `_actualBlendState`, but have all the `_blendStateAdditive`/`_blendStateAlphaBlend`/etc down around line 300. |
@@ -127,9 +127,11 @@ describe Users::ResetPasswordsController, devise: true do
confirmed: true,
}
- expect(@analytics).to have_received(:track_event).
+ expect(@analytics).to receive(:track_event).
with(Analytics::PASSWORD_RESET_PASSWORD, analytics_hash)
+ put :up... | [stub_email_notifier->[to,receive,instance_double,and_return],create,to_not,describe,build_stubbed,instance_double,it,put,confirmed_at,stub_email_notifier,freeze,to,reset_password_within,with,t,require,count,change,generate,receive,now,redirect_to,context,build,uuid,hour,get,by,eq,render_template,and_return] | missing_password_path - > new_user_password_path - > new_ expects a user to have a password reset token and a raw reset token. | Was moving this code around related to the Rails upgrade, or a general improvement? |
@@ -256,9 +256,13 @@ void AddCustomStrategiesToPython(pybind11::module& m)
//*************************BUILDER AND SOLVER*************************
//********************************************************************
- typedef ContactResidualBasedBlockBuilderAndSolver< SparseSpaceType, LocalSpaceType, L... | [AddCustomStrategiesToPython->[,>]] | Add custom strategies to python. ************************************************************************ Structure of all the methods that define the various types of time series that are region ModelPartConfig Implementation region System constant methods region ALMFrictionalMortarConvergenceCriteriaFactory methods P... | I think `typename` required here for Pointer ! |
@@ -22,8 +22,8 @@ class Highway(torch.nn.Module):
Parameters
----------
input_dim : ``int``
- The dimensionality of :math:`x`. We assume the input has shape ``(batch_size,
- input_dim)``.
+ The dimensionality of :math:`x`. We assume the input has shape ``(batch_size, *,
+ in... | [Highway->[forward->[sigmoid,_activation,layer],__init__->[bias,Linear,super,ModuleList,range]]] | Creates a highway layer that does a gated combination of a linear transformation and a non Forward the input tensor to the next layer. | sphinx won't like the `*` here. We've typically just use `...` to indicate some arbitrary number of dimensions. |
@@ -103,7 +103,7 @@ public class GcsPath implements Path, Serializable {
* <p>This is used to separate the components. Verification is handled separately.
*/
public static final Pattern GCS_URI =
- Pattern.compile("(?<SCHEME>[^:]+)://(?<BUCKET>[^/]+)(/(?<OBJECT>.*))?");
+ Pattern.compile("^([^:]+):... | [GcsPath->[toString->[isAbsolute,toString],equals->[equals],fromUri->[fromUri,GcsPath],endsWith->[endsWith],fromObject->[GcsPath],startsWith->[startsWith],resolve->[getFileSystem,fromUri,endsWith,resolve,setFileSystem,getObject,isAbsolute,GcsPath,startsWith],NameIterator->[next->[GcsPath]],compareTo->[iterator,compareT... | Creates a GcsPath from a URI. Creates a GcsPath from a OnePlatform resource name. | Any reason why the group names were removed? The more groups the easier it they are to track with names, no? |
@@ -493,6 +493,7 @@ public class PlatformLevel4 extends PlatformLevel {
GroupMembershipFinder.class,
UserGroupsWs.class,
org.sonar.server.usergroups.ws.SearchAction.class,
+ org.sonar.server.usergroups.ws.CreateAction.class,
// permissions
PermissionFacade.class,
| [PlatformLevel4->[start->[start,getContainer,getComponentByType,installExtensions],configure->[add,newMetadata,addAll]]] | Configures the platform level. This method is called by the server - side code that creates a new instance of all the This method is called from the server - side code that creates a new action. This method is called by the server - side code that implement the actions that are not part This method is called by the act... | please never forget to add component to platformlevel4.java : ) |
@@ -978,7 +978,7 @@ var _ = SIGDescribe("ResourceQuota [Feature:PodPriority]", func() {
})
It("should verify ResourceQuota's priority class scope (quota set to pod count: 1) against 2 pods with same priority class.", func() {
-
+ framework.SkipUnlessResourceQuotaScopeSelectorsEnabled()
_, err := f.ClientSet.S... | [IsAlreadyExists,ResourceName,ExtensionsV1beta1,CoreV1,ResourceQuotas,Delete,UpdatePodWithRetries,MustParse,FromInt,Secrets,Cmp,To,Poll,ReplicationControllers,Services,PriorityClasses,ReplicaSets,Logf,GetPauseImageName,Create,NewDeleteOptions,Failf,Get,PersistentVolumeClaims,NotTo,Update,NewDefaultFramework,Sprintf,Con... | Describe all ResourceQuota resources. Example of how to create a ResourceQuota. | I believe this the place where I need to run skip. |
@@ -184,8 +184,7 @@ def config_changed(top_config_file, new_top_config_file, config_hashes):
if config_hash and not config_file_exists:
return True
# Config file hash has changed = reload.
- if config_file_exists:
- new_config_hash = config_file_hash(config_file)
- ... | [dp_include->[config_file_hash,get_logger,read_config,dp_include,dp_config_path],read_config->[get_logger],config_changed->[config_file_hash]] | Check if the top config file or any file it includes has changed. | This change erroneously reverts #2702 |
@@ -497,6 +497,9 @@ public class HudsonPrivateSecurityRealm extends AbstractPasswordBasedSecurityRea
/**
* Creates a new user account by registering a password to the user.
+ *
+ * Supports bcrypt hashed passwords if the password begins with the characters
+ * <code>#jbcrypt:</code>
*/
... | [HudsonPrivateSecurityRealm->[hash->[encodePassword],doCreateFirstAccount->[loginAndTakeBack,hasSomeUser],doFilter->[doFilter],getACL->[getACL],loginAndTakeBack->[authenticate],isPasswordValid->[isPasswordValid,encodePassword],encodePassword->[encodePassword],getAllowsSignup->[allowsSignup],checkPermission->[checkPermi... | Create a new user account. | I don't like how this method has to use the duplicated string. I'm not sure the check is needed but at a minimum it should probably use the `isPasswordHashed()` method. |
@@ -227,6 +227,7 @@ ActiveRecord::Schema.define(version: 20200221215702) do
t.string "code_challenge"
t.string "rails_session_id"
t.json "verified_attributes"
+ t.datetime "verified_at"
t.index ["access_token"], name: "index_identities_on_access_token", unique: true
t.index ["session_uuid"],... | [jsonb,bigint,string,text,add_foreign_key,datetime,integer,json,enable_extension,create_table,boolean,index,define] | Table for all the user - defined identities and job runs missing fields for this table. | Is there a missing migration file added for this new column? |
@@ -0,0 +1,18 @@
+package com.baeldung.finagle;
+
+import com.twitter.finagle.Service;
+import com.twitter.finagle.http.Request;
+import com.twitter.finagle.http.Response;
+import com.twitter.finagle.http.Status;
+import com.twitter.io.Buf;
+import com.twitter.io.Reader;
+import com.twitter.util.Future;
+
+public class... | [No CFG could be retrieved] | No Summary Found. | could we convert the whole example to unit tests? |
@@ -51,12 +51,14 @@ DEP_MAP = {
# NOTE: schema for dependencies is basically the same as for outputs, but
# without output-specific entries like 'cache' (whether or not output is
-# cached, see -o and -O flags for `dvc run`) and 'metric' (whether or not
-# output is a metrics file and how to parse it, see `-M` flag... | [loadd_from->[_get],loads_from->[_get],loads_params->[_merge_params]] | Return a dependency object based on the given parameters. | These lines are not coupling outputs with dependencies. Maybe some refactoring is needed. But this is not related to this PR. |
@@ -135,7 +135,9 @@ namespace DynamoWebServer.Messages
private void NodesDataModified(object sender, RenderCompletionEventArgs e, string sessionId)
{
var nodes = new List<ExecutedNode>();
- foreach (var node in dynamoViewModel.Model.CurrentWorkspace.Nodes)
+ var curr... | [MessageHandler->[NodesDataModified->[OnResultReady]]] | NodesDataModified - This method is called when the data of the nodes in the workspace has. | very small refactoring :) |
@@ -244,7 +244,8 @@ public final class ReferenceCountedOpenSslServerContext extends ReferenceCounted
public boolean match(long ssl, String hostname) {
ReferenceCountedOpenSslEngine engine = engineMap.get(ssl);
if (engine != null) {
- return engine.checkSniHostnameMatch(... | [ReferenceCountedOpenSslServerContext->[newSessionContext->[ServerContext]]] | Checks if the given SSL pointer matches the given hostname. | Is there an issue on tcnarive for this? |
@@ -15,6 +15,7 @@ WriteAction::WriteAction(ACE_Proactor& proactor)
, max_count_(0)
, new_key_count_(0)
, new_key_probability_(0)
+ , final_wait_for_ack_{DDS::DURATION_INFINITE_SEC, DDS::DURATION_INFINITE_NSEC}
{
}
| [No CFG could be retrieved] | Provides a basic example of how to write a single action. - - - - - - - - - - - - - - - - - -. | So if the config file doesn't specify a value, it may wait forever on a call to `stop()`? |
@@ -61,5 +61,13 @@ return array(
'default' => false,
'desc' => 'Suppress informational messages',
),
+
+ 'package_directory_remote' => array(
+ 'default' => 'https://github.com/danielbachhuber/wp-cli-package-directory.git',
+ ),
+
+ 'package_directory_local' => array(
+ 'default' => dirname( __FILE__ ) . "/pa... | [No CFG could be retrieved] | Suppress informational messages. | Open to suggestions as to where would be a better default directory. I decided to choose the same parent as `/php/commands/` |
@@ -1575,6 +1575,9 @@ class TypeChecker(StatementVisitor[None]):
Return the inferred rvalue_type and whether to infer anything about the attribute type
"""
+ if isinstance(instance_type, Instance) and isinstance(attribute_type, ClassVarType):
+ self.msg.fail("Illegal assignment to ... | [TypeChecker->[analyze_async_iterable_item_type->[accept],visit_try_without_finally->[check_assignment,accept],visit_class_def->[accept],check_usable_type->[is_unusable_type],iterable_item_type->[lookup_typeinfo],visit_for_stmt->[accept_loop],visit_operator_assignment_stmt->[accept,check_indexed_assignment],check_retur... | Checks if a member assignment is possible. Check if the dunder_set_type is a callable and if so return the inferred. | I believe this code should rather appear in ``analyze_member_access`` (there is also a special flag ``is_lvalue`` to indicate that an assignment to a member is being analysed rather that reading from it). |
@@ -1012,15 +1012,9 @@ func (s *localizerPipeline) localizeConversation(ctx context.Context, uid gregor
case chat1.ConversationMembersType_TEAM:
// do nothing
case chat1.ConversationMembersType_IMPTEAMNATIVE, chat1.ConversationMembersType_IMPTEAMUPGRADE:
- public := conversationLocal.Info.Visibility == keybase1... | [localizeConversation->[isErrPermanent,getResetUsernamesMetadata,getResetUsernamesPegboard,getConvSettingsLocal,getPinnedMsg],localizeConversations->[complete,gateCheck,getPending],Localize->[getConvs,filterSelfFinalized,filterInboxRes],start->[clearQueue],getConvSettingsLocal->[getMinWriterRoleInfoLocal],localizeLoop-... | localizeConversation takes a conversation remote and returns a conversationLocal. Private functions related to a single conversation. A custom function or through Private helper function. chat1. MessageType_MESSAGE = chat1. | I don't really understand what was going on here or why it was unneeded. |
@@ -3,8 +3,9 @@
import logging
import copy
+from nni.utils import OptimizeMode
import torch
-from schema import And, Optional
+from schema import And, Optional, SchemaError
from nni.compression.pytorch.utils.config_validation import CompressorSchema
from .constants import MASKER_DICT
from .dependency_aware_prun... | [IterativePruner->[compress->[_fresh_calculated]],ADMMPruner->[compress->[_projection],_projection->[calc_mask]],AGPPruner->[calc_mask->[calc_mask],compress->[update_epoch]]] | Initialize a model object with a specific number of training epochs and a specific number of training epochs Check if the model is dependency - aware. | What is `OptimizeMode` for? seems not used? |
@@ -428,11 +428,12 @@ class RepoTree(BaseTree):
for root, _, files in self.walk(top):
root = PathInfo(root)
- makedirs(dest, exist_ok=True)
+ dest_dir = dest / root.relative_to(top)
+ makedirs(dest_dir, exist_ok=True)
for fname in files:
... | [DvcTree->[isfile->[exists,isdir],get_file_hash->[_get_granular_checksum,_find_outs],_walk->[_walk,_add_dir],exists->[_find_outs],isdvc->[_find_outs],walk->[_walk,_add_dir,exists,_find_outs,isdir],isdir->[exists,_get_granular_checksum,_find_outs],open->[_get_granular_checksum,open,_find_outs]],RepoTree->[isfile->[isfil... | Copy a tree of files to a new location. | `dest` here was the top level destination path, rather than the expected relative path |
@@ -84,7 +84,7 @@ class Pygit2Backend(BaseGitBackend): # pylint:disable=abstract-method
def dir(self) -> str:
raise NotImplementedError
- def add(self, paths: Iterable[str]):
+ def add(self, paths: Iterable[str], update=False):
raise NotImplementedError
def commit(self, msg: str, ... | [Pygit2Object->[scandir->[Pygit2Object]],Pygit2Backend->[get_tree_obj->[Pygit2Object]]] | Return the directory of the current repository. | `add --update` is available in `libgit2`, but `pygit2` does not import the update related index functions. I'll submit the pygit PR for this at some point in the near future. |
@@ -362,10 +362,12 @@ class BaseOutput:
filter_info=filter_info,
**kwargs,
)
+ return res
except CheckoutError:
if allow_missing or self.checkpoint:
return None
raise
+ self.set_exec()
def remove(... | [BaseOutput->[isfile->[isfile],_check_can_merge->[dumpd],unprotect->[unprotect],changed_checksum->[get_hash],collect_used_dir_cache->[get_dir_cache],changed_cache->[changed_cache],remove->[ignore_remove,remove],move->[move,ignore,commit,save,ignore_remove],supported->[supported],get_used_cache->[collect_used_dir_cache]... | Checkout a node in the cache. | Oops, my fault :) |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.