patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -684,6 +684,7 @@ public class VolumeDaoImpl extends GenericDaoBase<VolumeVO, Long> implements Vol
destVol.setUuid(uuid);
destVol.setInstanceId(instanceId);
update(srcVolId, srcVol);
+ detachVolume(srcVolId);
update(destVolId, destVol);
_tags... | [VolumeDaoImpl->[remove->[remove],getImageFormat->[getHypervisorType]]] | Updates the uuid of the source volume and the destination volume. | Not good idea to do this in _updateUuid()_ , May be _detachVolume()_ can be called before / after updating the UUID (using _updateUuid()_) wherever required. |
@@ -129,6 +129,15 @@ export class InaboxMessagingHost {
return false;
}
+ const allowedTypes =
+ this.iframeMap_[request['sentinel']].iframe.dataset['ampAllowed'];
+ // having no whitelist is legacy behavior so assume all types are allowed
+ if (allowedTypes &&
+ !allowedTypes.split... | [No CFG could be retrieved] | Processes a single post message. Send position request to target element and register observer. | Let's refactor this so you can rely on the output of getFrameElement by doing the following: - change getFrameElement_ to return ?AdFrameDef - you can then do const allowedTypes = adFrame.iframe.dataSet['ampAllowed']; - modify iframe usage below to be adFrame.measurableFrame |
@@ -6,6 +6,12 @@
import unittest
import parlai.utils.testing as testing_utils
+from parlai.core.agents import create_agent
+import sys
+import warnings
+
+if not sys.warnoptions:
+ warnings.simplefilter("ignore")
@testing_utils.skipUnlessGPU
| [TestDialogptModel->[test_dialogpt->[dict,train_model,assertLessEqual],retry],main] | Test dialogpt model. | Let's not have this in the diff right now |
@@ -112,7 +112,7 @@ public class SketchAggregator implements Aggregator
} else if (update instanceof byte[]) {
union.update((byte[]) update);
} else if (update instanceof Double) {
- union.update(((Double) update));
+ union.update((Double) update);
} else if (update instanceof Integer ||... | [SketchAggregator->[updateUnion->[updateUnion],aggregate->[initUnion]]] | Update a union with an object. | Why not also update this on this line? |
@@ -2768,6 +2768,7 @@ define([
u.jointMatrixUniformName = jointMatrixUniformName;
}
}
+
}
function scaleFromMatrix5Array(matrix) {
| [No CFG could be retrieved] | Create uniform functions for the given instance of a primitive. Get quantized uniforms from the primitive. | Remove extra whitespace. |
@@ -1000,7 +1000,9 @@ export class AmpForm {
let promise;
if (e && e.response) {
const error = /** @type {!Error} */ (e);
- promise = error.response.json().catch(() => null);
+ promise = this.xhr_
+ .xssiJson(error.response, this.form_.getAttribute('xssi-prefix'))
+ .catch(() =>... | [No CFG could be retrieved] | Transitions the form submit success state and handles the given action s response. Handle a non - xhr POST request. | Nit: Dedupe the attribute name. |
@@ -13,6 +13,9 @@ if ( ! defined( 'WPSEO_VERSION' ) ) {
exit();
}
+echo '<div class="tab-block">';
+echo '<h2>Restore site</h2>';
+
echo '<p>' . esc_html__( 'Using this form you can reset a site to the default SEO settings.', 'wordpress-seo' ) . '</p>';
if ( get_blog_count() <= 100 ) {
| [select,textinput,get_site_choices] | Provides a hidden input for the WordPress network administration section. | `Restore site` is not translatable. Please use `esc_html_e()` |
@@ -496,7 +496,8 @@ TransportClient::PendingAssoc::initiate_connect(TransportClient* tc,
data_.remote_reliable_, data_.remote_durable_};
TransportImpl::AcceptConnectResult res;
-
+ GuidConverter tmp_local(tc->repo_id_);
+ GuidConverter tmp_remote(this->data_.remote_id_);
if ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - local - local - remote - remote - local - remote - local - remote - remote. | Why were these moved? |
@@ -77,9 +77,9 @@ const containerIdLen = 64
const podUIDPos = 5
func (f *LogPathMatcher) MetadataIndex(event common.MapStr) string {
- if value, ok := event["source"]; ok {
+ if value, ok := event["log"].(common.MapStr)["file"].(common.MapStr)["path"]; ok {
source := value.(string)
- logp.Debug("kubernetes", "I... | [MetadataIndex->[Split,Contains,HasPrefix,HasSuffix,Debug],Unpack,AddDefaultIndexerConfig,AddDefaultMatcherConfig,AddMatcher,NewConfig,Errorf,Debug] | MetadataIndex returns the index of the container in the log path This function is used to extract the container id from the source value. | This line probably breaks with the redis input as it does not have the fields in here. |
@@ -835,6 +835,8 @@ class RemoteFilesystem
$headers[] = 'Authorization: Bearer ' . $auth['password'];
$authenticationDisplayMessage = 'Using Bitbucket OAuth token authentication';
}
+ } elseif ($auth['password'] === 'bearer' ) {
+ $hea... | [RemoteFilesystem->[getOptionsForUrl->[get],get->[findStatusMessage,get,findHeaderValue,findStatusCode],promptAuthAndRetry->[get],handleRedirect->[get,findHeaderValue]]] | Get options for a given URL. Returns a chain of headers and options for a specific authentication. Get the authentication options. | I think this should be above, possibly the first if() of the whole block, because otherwise if you somehow want to configure a GitHub/GitLab/BitBucket domain directly using bearer auth you won't be able to reach this block. |
@@ -55,7 +55,9 @@ public class AccessControlFilter extends ZuulFilter {
if (requestUri.startsWith(serviceUrl.substring(0, serviceUrl.length() - 2))) {
if (isAuthorizedRequest(serviceUrl, serviceName, requestUri)) {
return false;
- }
+ }els... | [No CFG could be retrieved] | Filters requests on the endpoints that are not in the list of authorized microservices endpoints. Checks if the request is an ack. | In that case, instead of doing `if (isAuthorizedRequest(serviceUrl, serviceName, requestUri)) { return false; } else { return true; }` prefer doing `return !isAuthorizedRequest(serviceUrl, serviceName, requestUri);` |
@@ -374,6 +374,16 @@
<div class="alert alert-info">Used to limit the amount of articles a user can create within 30 seconds</div>
</div>
+ <div class="form-group">
+ <%= f.label :rate_limit_organization_creation %>
+ <%= f.number_field :rate_limit_organ... | [No CFG could be retrieved] | Displays a hidden field with a hidden field that contains a hidden field that contains a hidden field Hierarchy for the post with tags. | Nice thought to make this all configurable from the get-go! |
@@ -143,7 +143,7 @@ namespace System.Collections.Immutable
public void CopyTo(T[] destination) { }
public void CopyTo(T[] destination, int destinationIndex) { }
public bool Equals(System.Collections.Immutable.ImmutableArray<T> other) { throw null; }
- public override bool Equals(object... | [No CFG could be retrieved] | This method can be used to create an immutable array of objects. Returns the last index of the specified item in the list. | This is not how the particular attribute is meant to be used. It is intended for aiding static analysis of `out` parameter nullability. |
@@ -31,6 +31,8 @@ public class TaskIdUtils
{
private static final Pattern INVALIDCHARS = Pattern.compile("(?s).*[^\\S ].*");
+ private static final Joiner underscoreJoiner = Joiner.on("_");
+
public static void validateId(String thingToValidate, String stringToValidate)
{
Preconditions.checkArgument(
| [TaskIdUtils->[validateId->[checkArgument,isNullOrEmpty,matches,matcher,format,contains,startsWith],getRandomId->[append,toString,nextInt,StringBuilder],compile]] | Checks that the string is not null empty and not a sequence of characters. | I think `underscoreJoiner` should be all caps |
@@ -34,12 +34,16 @@ abstract class VcsDriver implements VcsDriverInterface
* @param string $url The URL
* @param IOInterface $io The IO instance
* @param ProcessExecutor $process Process instance, injectable for mocking
+ * @param callable $remoteFilesystemFactory Remote Filesystem factory,... | [VcsDriver->[getContents->[getContents],hasComposerFile->[getComposerInformation]]] | Constructor for a missing configuration. | Do we really need this crazyness? I mean can't it just handle itself well with one single rfs for the whole driver instance lifecycle? |
@@ -77,6 +77,8 @@ def data_sample(CI, CC, sm, can_sock, driver_status, state, mismatch_counter, ca
sm.update(0)
events = list(CS.events)
+ if sm.updated['monitorState']:
+ events += list(sm['monitorState'].events)
add_lane_change_event(events, sm['pathPlan'])
enabled = isEnabled(state)
| [state_transition->[isEnabled],controlsd_thread->[state_control,state_transition,data_sample,data_send],main->[controlsd_thread],state_control->[isActive,isEnabled],data_send->[isActive,events_to_bytes,isEnabled],data_sample->[add_lane_change_event,isEnabled],isEnabled->[isActive],main] | Receive data from sockets and create events for battery temperature and disk space. Handle a in the RHD region. Returns the sequence of events that have not been distracted. | Don't you always want to add the events? |
@@ -12,6 +12,7 @@ module View
def render
game_title = @route.match(ROUTE_FORMAT)[1]
+ game_title = game_title[0..-2] if game_title[-1] == '/'
game_class = Engine::GAMES_BY_TITLE[game_title]
| [MapPage->[render->[h,new,message,match,name,puts],needs,freeze],require_tree,require] | Renders a which is either a game object or a div that contains a link to the. | can't this be done with regex? ROUTE_FORMAT = %r{/map/(.*)/?}.freeze |
@@ -71,10 +71,11 @@ class PythonArtifact(PayloadField):
return self.name
def _compute_fingerprint(self):
- fingerprint = sha1(json.dumps((self._kw, self._binaries),
+ json_representation = json.dumps((self._kw, self._binaries),
ensure_ascii=True,
... | [PythonArtifact->[__init__->[misses->[UnsupportedArgument],has->[MissingArgument],misses,has]]] | Compute the fingerprint of the missing node. | Is there a reason we're not using `pants.base.hash_utils.stable_json_hash()`? |
@@ -308,6 +308,12 @@ module Engine
def change_entity(_action)
return unless @current_entity.passed?
+ unless @current_entity.operating_info(@game.turn, @round_num)
+ # default operating action is to payout 0, i.e. withhold
+ or_info = OperatingInfo.new([], Action::Dividend.new... | [Operating->[can_buy_train?->[corp_has_room?],next_step!->[can_buy_train?,next_step!,must_buy_train?,route?,can_buy_companies?],buy_company->[name],place_token->[place_token,name],connected_nodes->[connected_nodes],log_pass->[name],payout->[name],payout_entity->[name],liquidate->[sell_shares,name],start_operating->[fin... | change_entity_action - change_entity_action - change_entity_action -. | @current_entity.operating_history[[@game.turn, @round_num]] ||= OperatingInfo.new([], Action::Dividend.new(@game.current_entity, 'withhold'), 0) |
@@ -1848,8 +1848,11 @@ class ParforPass(object):
# input array has to be dead after loop
require(arr_var.name not in live_vars)
# loop for arr's definition, where size = arr.shape
- arr_def = get_definition(self.func_ir, s... | [simplify_parfor_body_CFG->[simplify_parfor_body_CFG],remove_dead_parfor->[list_vars],repr_arrayexpr->[repr_arrayexpr],get_parfor_array_accesses->[unwrap_parfor_blocks,wrap_parfor_blocks],get_parfor_params_inner->[get_parfor_params],prod_parallel_impl->[prod_1->[init_prange,internal_prange]],min_parallel_impl->[min_1->... | Convert loop blocks to a loop index variable. Missing - returns a new object if the header has a non - empty . finds the missing values and expressions in the loop. check for cnn - index and prange - index - index - index - index The index_var is the base of the n - node where n - node Add a dead code entry to the t... | Will raising here get caught in the `guard` for the call and permit it to continue but not be optimised? I expect it's moot if it's unreachable anyway. |
@@ -174,6 +174,9 @@ class ShippingZoneUpdate(ShippingZoneMixin, ModelMutation):
class ShippingZipCodeRulesCreateInputRange(graphene.InputObjectType):
start = graphene.String(required=True, description="Start range of the zip code.")
end = graphene.String(required=False, description="End range of the zip code... | [ShippingZipCodeRulesCreate->[Arguments->[ShippingZipCodeRulesCreateInput],perform_mutation->[ShippingZipCodeRulesCreate]],ShippingPriceCreate->[Arguments->[ShippingPriceInput]],ShippingPriceRemoveProductFromExclude->[perform_mutation->[ShippingPriceExcludeProducts]],ShippingZoneUpdate->[Arguments->[ShippingZoneUpdateI... | Create a response for a specific node. Create a new zip code exclusion range for shipping method. | I've added it as non required field to not break existing Saleor Dashboard code. I can change it. |
@@ -502,8 +502,8 @@ dependencies {
<%_ } _%>
<%_ if (databaseType === 'couchbase') { _%>
implementation "com.github.differentway:couchmove"
- implementation "com.couchbase.client:java-client"
- implementation "com.couchbase.client:encryption"
+ implementation group: 'com.couchbase.client', name:... | [No CFG could be retrieved] | The implementation string for the next version of the application. returns database name that can be used for this database type. | No need of `encryption` lib, as in maven version. |
@@ -208,6 +208,10 @@ export class IntersectionObserver extends Observable {
* @private
*/
flush_() {
+ if (!this.isElementInDoc_()) {
+ return;
+ }
+
this.flushTimeout_ = 0;
if (!this.pendingChanges_.length) {
return;
| [No CFG could be retrieved] | This method is called when a new intersection is added to the list of pending changes. It. | How expensive is this? Why aren't we just unlistening whatever listener is firing this? |
@@ -75,6 +75,6 @@ public final class CatalogSchemaTableName
@Override
public String toString()
{
- return catalogName + '.' + schemaTableName.toString();
+ return catalogName.toString() + '.' + schemaTableName.toString();
}
}
| [CatalogSchemaTableName->[toString->[toString],equals->[equals]]] | Returns the string representation of a . | Does anyone rely on `CatalogSchemaTableName.toString()`? They'll now start getting names that might include delimited parts. |
@@ -702,6 +702,16 @@ class Transpiler {
allVariables.push (catchClauseMatches[1])
}
+ // match all variables instantiated as function parameters
+ let functionParamRegex = /function (\w+) \(([^)]+)\)/g
+ js = js.replace (functionParamRegex, (match, group1, group2) => 'functi... | [Transpiler->[transpileJavaScriptToPython3->[replace,exec],getPHPRegexes->[keys,Array],regexAll->[replace],transpileJavaScriptToPHP->[trim,concat,exec,forEach,push,map],createPythonClassImports->[indexOf,safeString],transpileEverything->[argv,createFolderRecursively,bright],transpileDerivedExchangeFiles->[unlinkSync,ba... | transpile JavaScript to PHP returns a regex that matches any of the JS variables and properties that are not in the JS. | Why do we have to replace it + unCamelCase it in two places? |
@@ -351,7 +351,8 @@ class AnnotationCategoriesControllerTest < AuthenticatedControllerTest
:assignment_id => @assignment.id,
:annotation_category_list_csv => StringIO.new('name, text')
assert_response :redirect
- assert set_the_flash.to((I18n.t('annotations.upload.success', :an... | [AnnotationCategoriesControllerTest->[find,new,render_template,post_as,fixture_file_upload,assignment,put,should,to,last_editor_id,annotation_category,assert_equal,post,returns,render_with_layout,assigns,t,creator_id,assert_not_nil,header,assert_nil,empty?,get_as,make,id,length,delete,find_by_annotation_category_name,c... | on admin add_new_annotation_text on admin add_new_annotation_text on : csv_upload have valid values in database after an upload of a ISO -8859. | Align the parameters of a method call if they span more than one line. |
@@ -20,6 +20,18 @@ import (
"github.com/hashicorp/vault/helper/pgpkeys"
)
+func TestGenerateIAMPassword(t *testing.T) {
+ p := generatePassword(6)
+ if len(p) != 6 {
+ t.Fatalf("expected a 6 character password, got: %q", p)
+ }
+
+ p = generatePassword(128)
+ if len(p) != 128 {
+ t.Fatalf("expected a 128 charact... | [DecryptBytes,Test,ChangePassword,NonRetryableError,Code,Itoa,TestCheckResourceAttrSet,RandInt,RandIntRange,New,RootModule,ComposeTestCheckFunc,Errorf,MustCompile,RetryableError,Get,NewStaticCredentials,Meta,Sprintf,TestCheckResourceAttr,GetLoginProfile,String,Retry] | TestAccAWSUserLoginProfile_basic tests the specified resource for the given user name. Check - the AWS user login profile is present in the keyring. | add a check here that it is actually 6 chars :) |
@@ -40,6 +40,18 @@ const (
// environment in order to spin up pipelines, which is not yet supported by this
// package, but the other API servers work.
func WithRealEnv(cb func(*RealEnv) error, customConfig ...*serviceenv.PachdFullConfiguration) error {
+ // TODO: This means StorageV2 tests can not run in parallel w... | [NewBlockAPIServer,NewConfiguration,InitServiceEnv,Join,NewAPIServer,Endpoints,Port,NewCache,Close,JoinHostPort,Hostname,Initialize,Parse] | WithRealEnv creates a mock environment that can be used to run a single API server instance missingconfig. Config = config. | Should we be unsetting the environment variable? I think this would prevent us from running V2 tests in parallel with other V2 tests. If we setup the V2 tests to run on their own machine, then we would just need to set it. |
@@ -34,6 +34,10 @@ class ClasspathSourceAmbiguity(Exception):
"""Too many compiler instances were compatible with a CoarsenedTarget."""
+class ClasspathSourceRootOnlyWasInner(Exception):
+ """A root_only request type was used as an inner node in a compile graph."""
+
+
class _ClasspathEntryRequestClassific... | [ClasspathEntryRequest->[for_targets->[ClasspathSourceMissing,ClasspathSourceAmbiguity]],FallibleClasspathEntry->[from_fallible_process_result->[prep_output]]] | Creates a ClasspathEntry object from a given ClassVar object. The type of the object that this request subclass is required to provide a list of the fields. | `SourceRoot` makes me think of `src/java`. Maybe `ClasspathRootOnlyWasInner`, or something more vague |
@@ -949,6 +949,8 @@ class RawBTi(Raw):
eog_ch: tuple of str | None
The 4D names of the EOG channels. If None, the channels will be treated
as regular EEG channels.
+ rename_channels: bool
+ If True, rename channels Neuromag format, else leave 4-D format
verbose : bool, str, int, or None
... | [_read_config->[_correct_offset],_read_bti_header->[_read_config,_read_pfid_ed,_read_channel,_read_process,_read_assoc_file,_read_epoch,_read_event,_correct_offset],RawBTi->[__init__->[_rename_channels,_convert_dev_head_t,_read_bti_header,_setup_head_shape,_convert_coil_trans,_read_data]],_setup_head_shape->[_convert_h... | Initialize a raw object from a 4D Neuroimaging MagnesWH3600 data Checks if the config file exists and if it does raise a ValueError. | rename channels **to** Neuromag format |
@@ -715,6 +715,7 @@ function stats_reports_page( $main_chart_only = false ) {
die();
}
}
+ error_log( print_r( $get, 1) );
$body = stats_convert_post_titles( $get['body'] );
$body = stats_convert_chart_urls( $body );
$body = stats_convert_image_urls( $body );
| [stats_admin_bar_menu->[add_menu],stats_build_view_data->[get_queried_object_id],stats_print_wp_remote_error->[get_error_messages,get_error_codes]] | The Jetpack stats page Renders a path to the 3d - 3d. Return a path to the 3x3 grid. Jetpack - related section of the jupyter notebook. Renders a hidden hidden block of the n - ary resource. Renders a link to the Jetpack administration page. | Is this debug statement needed here? |
@@ -84,13 +84,13 @@
<% end %>
<button class="crayons-btn crayons-btn--outlined mr-2">
<label for="cover-image-input">
- <% if article.main_image.present? %>Change<% else %>Add a cover image<% end %>
+ <% if article.main_image.present? %><%= t("views... | [No CFG could be retrieved] | Renders the hidden element of the crayons - article - form that displays a single - Find out which tag is hidden. | Nitpicky but I'd prefer the full `cover_image` over `cover`. |
@@ -81,8 +81,8 @@ class SocketReadData {
}
// http://javaalmanac.com/egs/java.nio/DetectClosed.html
final int size = channel.read(contentBuffer);
- if (logger.isLoggable(Level.FINEST)) {
- logger.finest("read content bytes:" + size);
+ if (log.isLoggable(Level.FINEST)) {
+ log.finest("rea... | [SocketReadData->[read->[hasRemaining,allocate,getInt,read,flip,IOException,isLoggable,finest],getData->[get,capacity,flip],AtomicInteger,getLogger,getName,incrementAndGet]] | Reads a packet from the specified channel. | This if check should be redundant IMO |
@@ -114,7 +114,10 @@ class CsFile:
def search(self, search, replace):
found = False
- logging.debug("Searching for %s and replacing with %s" % (search, replace))
+ replace_filtered = replace
+ if re.search("PSK \"", replace):
+ replace_filtered = re.sub(r'".*"', '"****"',... | [CsFile->[append->[append],commit->[is_changed],section->[append],add->[append],search->[search,append]]] | Search for a line in the config file and replace with a new line. | "Searching for %s and replacing the value following it with %s" would be closer to the truth |
@@ -788,8 +788,3 @@ class ParlaiParser(argparse.ArgumentParser):
arg_group.add_argument = ag_add_argument # override _ => -
return arg_group
-
- def error(self, message):
- _sys.stderr.write('error: %s\n' % message)
- self.print_help()
- _sys.exit(2)
| [ParlaiParser->[add_parlai_args->[add_parlai_data_path],print_args->[parse_args],parse_known_args->[fix_underscores],add_model_subargs->[class2str],add_argument_group->[ag_add_argument->[fix_underscores,_handle_hidden_args]],add_extra_args->[add_model_subargs,add_image_args,add_task_args,get_model_name,add_pyt_dataset_... | Override to make arg groups also convert underscores to hyphens. | is there a reason we are removing this? |
@@ -84,6 +84,7 @@ def define_py_data_source(file_list, cls, module,
data.load_data_module = load_data_module
data.load_data_object = load_data_object
data.load_data_args = load_data_args
+ data.async_load_data = True
return data
data_cls = py_data2... | [define_py_data_sources2->[define_py_data_sources],define_py_data_sources->[define_py_data_source,__is_splitable__]] | Define a python data source. Get a single object from load_data_module load_data_object load_. | always enable double buffer. The `async load` is very confusing. It just enable double buffer in DataProvider. Maybe we should change it later. |
@@ -34,6 +34,11 @@ import (
"github.com/cortexproject/cortex/pkg/util/services"
)
+const (
+ blocksMarkedForDeletionName = "cortex_compactor_blocks_marked_for_deletion_total"
+ blocksMarkedForDeletionHelp = "Total number of blocks marked for deletion in compactor."
+)
+
var (
errInvalidBlockRanges = "compactor ... | [running->[Stop,compactUsers,NewTicker,Chan,DurationWithJitter,Wrap,Done],compactUsers->[RemoveAll,Warn,compactUserWithRetries,Inc,Info,Set,IsNotExist,Error,Stat,ownUser,discoverUsersWithRetries,listTenantsWithMetaSyncDirectories,metaSyncDirForUser,TenantDeletionMarkExists,Debug,SetToCurrentTime,Log,Err,IsDir,Shuffle],... | "path - path to filepath - path to filepath - path to filepath - path to filepath reg is a set of registers that are used to register the block ID for the block. | I'm not sure mixing this metric between compactor and blocks cleaner is a good idea. It it perhaps time for BlocksCleaner to be a separate component from Compactor (not necessarily run separately from compactor, but top-level component in Cortex), as it's doing more and more work. It's unfortunate that blocks cleaner m... |
@@ -227,6 +227,7 @@ public final class TcpSlaveAgentListener extends Thread {
AgentProtocol p = AgentProtocol.of(protocol);
if (p!=null) {
if (Jenkins.getInstance().getAgentProtocols().contains(protocol)) {
+ LOGGER.log(Level.... | [TcpSlaveAgentListener->[shutdown->[getPort],getAdvertisedPort->[getPort],ConnectionHandler->[respondHello->[getAgentProtocolNames]],getName]] | This method is invoked when a connection is accepted by the client. It checks if the connection. | What sort of value is `protocol`? |
@@ -45,7 +45,8 @@ class SessionController < ApplicationController
if user = sso.lookup_or_create_user
if SiteSetting.must_approve_users? && !user.approved?
- # TODO: need an awaiting approval message here
+ render text: "Your account is pending approval, you will recieve an email notificatio... | [SessionController->[sso_login->[return_path,redirect_to,render,nonce_valid?,parse,approved?,log_on_user,enable_sso,lookup_or_create_user,expire_nonce!,must_approve_users?,query_string],create->[email,max_password_length,performed!,allow_local_auth?,confirm_password?,require,not_allowed_from_ip_address,failed_to_login,... | This action logs the user in a single sign - on network if the user is logged in. | If this message is for the end user, it should use i18n. |
@@ -125,12 +125,16 @@ IMPLEMENT_ASN1_DUP_FUNCTION(X509)
X509 *d2i_X509(X509 **a, const unsigned char **in, long len)
{
X509 *cert = NULL;
+ int free_on_error = a != NULL && *a == NULL;
cert = (X509 *)ASN1_item_d2i((ASN1_VALUE **)a, in, len, (X509_it()));
/* Only cache the extensions if the cert ob... | [No CFG could be retrieved] | Frees all of the keys that are not used by the server. - - - - - - - - - - - - - - - - - -. | Changes in this file belong to the other commit probably? |
@@ -383,7 +383,7 @@ func (o *ImportImageOptions) importTag(stream *imageapi.ImageStream) (*imageapi.
} else {
// create a new tag
- if len(from) == 0 {
+ if len(from) == 0 && tag == imageapi.DefaultImageTag {
from = stream.Spec.DockerImageRepository
}
// if the from is still empty this means there's ... | [newImageStreamImportTags->[newImageStreamImport],newImageStreamImportAll->[newImageStreamImport]] | importTag imports a tag from an image stream create a new tag in the image stream. | What if the `tag` is empty? Can it happen? |
@@ -44,7 +44,8 @@ public class SideEffectsTest implements Serializable {
@Test
public void test() throws Exception {
- Pipeline p = Pipeline.create(pipelineOptions.getOptions());
+ SparkPipelineOptions options = pipelineOptions.getOptions();
+ Pipeline p = Pipeline.create(options);
p.apply(Creat... | [SideEffectsTest->[test->[processElement->[UserException]]]] | Test if a missing element is expected. | Is this really necessary ? |
@@ -38,12 +38,18 @@ public class BehaviorCache {
private final SymbolicExecutionVisitor sev;
private final SquidClassLoader classLoader;
+ private final SemanticModel semanticModel;
@VisibleForTesting
public final Map<String, MethodBehavior> behaviors = new LinkedHashMap<>();
public BehaviorCache(Sy... | [BehaviorCache->[isRequireNonNullMethod->[isLog4jOrSpringAssertNotNull,isObjectsRequireNonNullMethod,isValidateMethod],isGuavaPrecondition->[anyMatch],methodBehaviorForSymbol->[completeSignature,MethodBehavior,computeIfAbsent],isSpringIsNull->[startsWith],get->[methodCanNotBeOverriden,isRequireNonNullMethod,isGuavaPrec... | MethodBehaviorForSymbol returns a MethodBehavior for the given symbol. | Given the structure of the constructor this field can be null. It is only used to be passed to a bytecodeEGWalker which expects it to be non null. (No check of nullity are made on EGWalker side). I tend to think that the overloading of constructor is not required here (or at the very least should be annotated with @Vis... |
@@ -2245,3 +2245,11 @@ func (i *Ingester) getInstanceLimits() *InstanceLimits {
return l
}
+
+func (i *Ingester) checkIfAllTSDBClosing() bool {
+ if i.State() == services.Stopping {
+ level.Debug(i.logger).Log("msg", "TSDB is unavailable, as the Ingester is in the process of stopping and closing all TSDB")
+ ret... | [v2LabelValues->[Close,Querier],Head->[Head],v2QueryStreamChunks->[ChunkQuerier,Close],Blocks->[Blocks],Close->[Close],getMemorySeriesMetric->[Head],createTSDB->[Compact,Head,updateCachedShippedBlocks,setLastUpdate],PreCreation->[Head],v2LifecyclerFlush->[shipBlocks,compactBlocks],ExemplarQuerier->[ExemplarQuerier],clo... | getInstanceLimits returns the limits for the instance. | Right now when running v2 ingester ("blocks"), this state-check is done in two places: once in original "v1" call, and then again in "v2" version. I would suggest to use single check only, by moving calls to `checkRunningOrStopping()` after calls to v2 functions. Then this method (`checkIfAllTSDBClosing`, with perhaps ... |
@@ -75,11 +75,11 @@ public class ZkClientWrapper {
}
public void addListener(final IZkStateListener listener) {
- listenableFutureTask.addListener(new Runnable() {
+ completableFuture.thenRunAsync(new Runnable() {
@Override
public void run() {
try {
-... | [ZkClientWrapper->[createPersistent->[createPersistent],getChildren->[getChildren],addListener->[addListener],close->[close],start->[start],exists->[exists],createEphemeral->[createEphemeral],subscribeChildChanges->[subscribeChildChanges],delete->[delete],unsubscribeChildChanges->[unsubscribeChildChanges]]] | Add listener to listen for changes to the state of the node. | `whenComplete` or `handle` maybe better, and try to use lambda. |
@@ -107,6 +107,14 @@ namespace Microsoft.Xna.Framework
return value1;
}
+ /// <summary>
+ /// Performs vector addition on <paramref name="value1"/> and
+ /// <paramref name="value2"/>, storing the result of the
+ /// addition in <paramref name="result"/>.
+ ///... | [Vector2->[GetHashCode->[GetHashCode],Transform->[Length,Transform,Multiply],CatmullRom->[CatmullRom],SmoothStep->[SmoothStep],Hermite->[Hermite],Lerp->[Lerp],Barycentric->[Barycentric],Clamp->[Clamp],Equals->[Equals],ToString->[ToString]]] | Add two Vector2s and return the result. | This could be simpler: "The result of the vector addition." |
@@ -618,7 +618,8 @@ static int rsa_ossl_mod_exp(BIGNUM *r0, const BIGNUM *I, RSA *rsa, BN_CTX *ctx)
goto err;
if (rsa->version == RSA_ASN1_VERSION_MULTI
- && (ex_primes = sk_RSA_PRIME_INFO_num(rsa->prime_infos)) <= 0)
+ && ((ex_primes = sk_RSA_PRIME_INFO_num(rsa->prime_infos)) <= 0
+ ... | [int->[RSA_padding_check_none,BN_mul,RSA_padding_add_PKCS1_type_2,RSA_padding_add_PKCS1_OAEP,BN_BLINDING_unlock,BN_BLINDING_invert_ex,BN_is_negative,BN_new,BN_BLINDING_convert_ex,BN_cmp,RSA_padding_check_PKCS1_OAEP,BN_add,rsa_blinding_convert,BN_CTX_start,BN_bn2bin,OPENSSL_clear_free,BN_free,RSA_padding_add_SSLv23,RSAe... | Private method for RSA_RSA_OSL_MOD_EXP. private static int ex_primes = 0 ; no - op if m_i c_i d_i c_c d_ sigh. private helper functions private helper functions. | You could make that `|| ex_primes > sizeof(m))`... |
@@ -624,6 +624,15 @@ define([
this._pickUniformMapLoaded = options.pickUniformMapLoaded;
this._ignoreCommands = defaultValue(options.ignoreCommands, false);
+
+ /**
+ * By default models are y-up according to the glTF spec, however geo-referenced models will typically be z-up
+ ... | [No CFG could be retrieved] | Displays the node with the given id. A list of objects with the name property. | Should this user an explicit getter so `readonly` is enforced? |
@@ -459,15 +459,13 @@ function dfrn_request_post(&$a) {
$network = NETWORK_DFRN;
}
- logger('dfrn_request: url: ' . $url . ',network=' . $network, LOGGER_DEBUG);
-
if($network === NETWORK_DFRN) {
$ret = q("SELECT * FROM `contact` WHERE `uid` = %d AND `url` = '%s' AND `self` = 0 LIMIT 1",
intval($... | [dfrn_request_post->[get_baseurl,get_hostname,get_path],dfrn_request_content->[get_baseurl]] | This function is called when a user requests a contact from a user s profile. This function scrape the dfrn - url and save the contact record in the contact table Create a contact record on our site if there is no contact record on the other person. | Why had this vanished? |
@@ -245,7 +245,7 @@ namespace System.Dynamic.Tests
}
[Fact]
- public void NonIndexerParamterizedGetterAndSetterIndexAccess()
+ public void NonIndexerParameterizedGetterAndSetterIndexAccess()
{
dynamic d = GetObjectWithNonIndexerParameterProperty(true, true);
... | [InvokeMemberBindingTests->[GenericMethod->[TellType],ByRef->[TryParseInt],MethodHiding->[Method],NoArgumentMatch->[Method],ManyArities->[GetValue,GetValue2]]] | This method is used to test if a dynamic object has a non indexer parameter property getter and. | I think renaming unit tests is okay. But pointing to it just in case. |
@@ -88,14 +88,14 @@ def main():
log.info('OpenVINO Inference Engine')
log.info('\tbuild: {}'.format(get_version()))
- ie = IECore()
+ core = Core()
if 'MYRIAD' in args.device:
myriad_config = {'VPU_HW_STAGES_OPTIMIZATION': 'YES'}
- ie.set_config(myriad_config, 'MYRIAD')
+ ... | [build_argparser->[add_argument_group,ArgumentParser,add_mutually_exclusive_group,add_argument],main->[reportMeans,fps,RuntimeError,info,run_pipeline,get_version,open_images_capture,Presenter,build_argparser,IEModel,add_extension,append,ResultRenderer,format,open,DummyDecoder,strip,IECore,set_config],abspath,append,dir... | Entry point for the OpenVINO Inference Engine. Show a single missing label. | I think we need to remove extensions, as we do not have models with extended layers |
@@ -120,6 +120,12 @@ type Backend interface {
// GetPolicyPack returns a PolicyPack object tied to this backend, or nil if it cannot be found.
GetPolicyPack(ctx context.Context, policyPack string, d diag.Sink) (PolicyPack, error)
+ // ListPolicyGroups returns all Policy Groups for an organization in this backend,... | [GetStackResourceOutputs->[ParseStackReference,NewObjectProperty,PropertyKey,Errorf,Snapshot,NewStringProperty,GetStack],GetStackOutputs->[ParseStackReference,GetRootStackResource,Wrap,Errorf,Snapshot,GetStack],Error->[Sprintf,Replace],New] | ListStacksFilter returns a list of stacks that are tied to this backend. | "nil if it cannot be found" actually doesn't match the code, since `apitype.ListPolicyGroupsResponse` cannot have the value `nil`. It might make more sense to return a well-known error, like `var ErrOrganizationNotFound = errors.New("organization not found")` so callers can check for that instead. WDYT? |
@@ -165,6 +165,12 @@ public class DictionaryEncodedColumnPartSerde implements ColumnPartSerde
public SerializerBuilder withBitmapIndex(GenericIndexedWriter<ImmutableBitmap> bitmapIndexWriter)
{
+ if (bitmapIndexWriter == null) {
+ flags |= Feature.NO_BITMAP_INDEX.getMask();
+ } else {
+ ... | [DictionaryEncodedColumnPartSerde->[SerializerBuilder->[withValue->[getMask],build->[writeTo->[writeTo,asByte],getSerializedSize->[getSerializedSize],DictionaryEncodedColumnPartSerde]],createDeserializer->[DictionaryEncodedColumnPartSerde],getDeserializer->[read->[isSet,fromByte,getMask,read],readMultiValuedColumn->[is... | withBitmapIndex - Set bitmap index writer. | nit : @nullable annotation for bitmapIndexWriter. |
@@ -1456,7 +1456,15 @@ function createDateParser(regexp, mapping) {
map[mapping[index]] = +part;
}
});
- return new Date(map.yyyy, map.MM - 1, map.dd, map.HH, map.mm, map.ss || 0, map.sss * 1000 || 0);
+
+ var date = new Date(map.yyyy, map.MM - 1, map.dd, map.HH, map.mm, m... | [No CFG could be retrieved] | Create a date input type that parses a date string or a date object. Determines if the input value is a valid and returns it. | How about putting this before the `new Date` and doing `map.yyyy += 1900`? Then the `return new Date(...)` can be left as-is and maybe the `date` => `previousDate` change isn't needed? |
@@ -112,6 +112,7 @@ define([
* @param {Boolean} [options.debugShowRenderingStatistics=false] For debugging only. When true, draws labels to indicate the number of commands, points, triangles and features for each tile.
* @param {Boolean} [options.debugShowMemoryUsage=false] For debugging only. When true, dr... | [No CFG could be retrieved] | Options for rendering a single 3D Tileset. Add tileset to scene. | Use `{@link PointShading}` |
@@ -28,12 +28,14 @@ public class PaneConfig extends UserPrefsAccessor.Panes
public native static PaneConfig create(JsArrayString panes,
JsArrayString tabSet1,
JsArrayString tabSet2,
+ JsArr... | [PaneConfig->[getConsoleRight->[getConsoleLeft],copy->[copy,create],createDefault->[create],isValidConfig->[isSubset,makeSet,getAlwaysVisibleTabs,getHideableTabs],indexOfReplacedTab->[getReplacedTabs],validateAndAutoCorrect->[getAllPanes,getHideableTabs,getAddableTabs,getAllTabs,replaceObsoleteTabs],concat->[concat],re... | Creates a PaneConfig from a sequence of arguments. | nit: update copyright year in header |
@@ -19,12 +19,12 @@ type HTTPRoute struct {
Headers map[string]string `json:"headers:omitempty"`
}
-// TrafficTarget is a struct to represent a traffic policy between a source and destination along with its routes
-type TrafficTarget struct {
- Name string `json:"name:omitempty"`
- Destinatio... | [No CFG could be retrieved] | is a struct to represent an HTTP route comprised of a path regex methods and. | I think it would be better to have this as a set to avoid duplicates. So it would be exactly the same as above type `RouteWeightedClusters`. Lets just rename `RouteWeightedClusters` to `RouteWeightedServices` rather than creating a new one. |
@@ -93,6 +93,12 @@ PaymentID = NewType('PaymentID', T_PaymentID)
T_PaymentAmount = int
PaymentAmount = NewType('PaymentAmount', T_PaymentAmount)
+T_PrivateKey = bytes
+PrivateKey = NewType('PrivateKey', T_PrivateKey)
+
+T_PublicKey = bytes
+PublicKey = NewType('PrivateKey', T_PublicKey)
+
T_FeeAmount = int
FeeAmo... | [NewType] | Create a new type object for the NTP channel. Address = NewType. | Typo. 'PrivateKey' should be 'PublicKey'. |
@@ -300,6 +300,8 @@ public class SdkHarnessClient implements AutoCloseable {
private final InstructionRequestHandler fnApiControlClient;
private final FnDataService fnApiDataService;
+ @SuppressWarnings("unchecked") /* SdkHarnessClient does not need to know the type information of
+ BundleProcessor. */
pri... | [SdkHarnessClient->[ActiveBundle->[close->[close]],BundleProcessor->[newBundle->[getId,newBundle]],NoOpStateDelegator->[Registration->[Registration],NoOpStateDelegator],withIdGenerator->[SdkHarnessClient],getProcessor->[getProcessor,getId],usingFnApiClient->[CountingIdGenerator,SdkHarnessClient]]] | Creates a new SDK harness client that can be used to handle the given API request Provides a simple way to identify bundles that are not cached based upon the id of the process. | Can you make this `BundleProcessor<?>` instead? |
@@ -988,7 +988,7 @@ class WPSEO_Frontend {
*
* @api string $canonical The canonical URL
*/
- $this->canonical = apply_filters( 'wpseo_canonical', $canonical );
+ $this->canonical = apply_filters( 'wpseo_canonical', user_trailingslashit( $canonical ) );
}
/**
| [WPSEO_Frontend->[generate_title->[is_home_static_page,get_title_from_options,get_author_title,is_home_posts_page,get_default_title,is_posts_page,get_content_title,get_taxonomy_title],generate_canonical->[is_posts_page],metakeywords->[is_posts_page,is_home_static_page,is_home_posts_page],adjacent_rel_links->[is_home_st... | Generate the canonical url for the post. This function is used to generate a canonical post link for the current post type. Set the canonical URL for the page. | When pagination is done with Query String arguments this will give unwanted results. |
@@ -1015,11 +1015,11 @@ class WPSEO_Replace_Vars {
/* *********************** HELP TEXT RELATED ************************** */
/**
- * Create a variable help text table
+ * Create a variable help text table.
*
* @param string $type Either 'basic' or 'advanced'.
*
- * @return string Hel... | [WPSEO_Replace_Vars->[retrieve_page->[determine_pagenumbering,retrieve_sep],retrieve_pt_plural->[determine_pt_names],retrieve_pt_single->[determine_pt_names],retrieve_caption->[retrieve_excerpt_only],retrieve_pagetotal->[determine_pagenumbering],retrieve_pagenumber->[determine_pagenumbering]]] | Creates a help table for the given variable type. | You missed a full stop here? |
@@ -281,7 +281,8 @@ func setVolumeLocations(d *data.Data, conf *config.VirtualContainerHostConfigSpe
continue
}
u := *v
- u.Path = dsURL.Path
+ u.Path = filepath.Join(dsURL.Datastore, dsURL.Path)
+ u.Host = ""
d.VolumeLocations[k] = &u
}
}
| [HumanSize,ObjectName,HasPrefix,Reference,ResourcePool,Errorf,NewData,Debugf,GetResourceAllocationInfo,Join,Name,ObjectReference,Split,Sprintf,Properties,Parse,Replace,String,FromHumanSize,FromString] | getHumanSize returns a human - readable string of the given size. setHTTPProxies sets the HTTP and HTTPS proxies for the given data. | @emlin I updated this file. I want to make sure you are ok with this. |
@@ -86,7 +86,14 @@ namespace Content.Server.GameObjects.EntitySystems
if (ev.Entity.TryGetComponent(out IPhysicsComponent? physics) &&
physics.TryGetController(out MoverController controller))
{
- controller.StopMoving();
+ var weightless =
+ ... | [MoverSystem->[PlayFootstepSound->[GetTileRef,TypeId,_prototypeManager,GridIndices,ErrorS,Pick,PlayAtCoords,GetSnapGridCell,GetGridId,GetGrid,Center,PickFiles,Owner,FootstepSounds],HandleFootsteps->[GridExists,TryDistance,Coordinates,PlayFootstep,PlayFootstepSound,Transform,Sprinting,LastPosition,StepSoundDistance,inve... | This method is called when a player is detached from the system. It is called by the. | I really hope this will be improved once we have force controllers.. |
@@ -126,6 +126,9 @@ public class PutAzureDataLakeStorage extends AbstractAzureDataLakeStorageProcess
if (length > 0) {
try (final InputStream rawIn = session.read(flowFile); final BufferedInputStream bufferedIn = new BufferedInputStream(rawIn)) {
uploadCont... | [PutAzureDataLakeStorage->[init->[add,unmodifiableList,getSupportedPropertyDescriptors],uploadContent->[append,flush,min,BoundedInputStream],onTrigger->[getValue,getFileUrl,equals,evaluateFileSystemProperty,nanoTime,evaluateFileNameProperty,warn,put,getSize,evaluateDirectoryProperty,putAllAttributes,getDirectoryClient,... | On trigger. This method creates a new file on Azure Data Lake Storage if it does not exist. | Exception e is suppressed if fileClient.delete() also throws an exception. My recommendation is to put a try-catch-finally around delete(). In the catch only an error message needs to be logged, and in the finally the original exception 'e' can be thrown forward. |
@@ -38,6 +38,8 @@ public class FlowStackTestCase extends FunctionalTestCase
return "org/mule/test/integration/notifications/flow-stack-config.xml";
}
+ private static final String TEST_MESSAGE = "payload";
+
@Before
public void before()
{
| [FlowStackTestCase->[subFlowDynamicWithEnricher->[send,assertStackElements,nullValue,DefaultMuleMessage,isFlowStackElement,assertThat,not],flowDynamicWithChoice->[send,assertStackElements,nullValue,DefaultMuleMessage,isFlowStackElement,assertThat,not],subFlowDynamicWithChoice->[send,assertStackElements,nullValue,Defaul... | This method is overridden to provide a config file that can be used to configure a flow stack. | There is a TEST_MESSAGE constant already defined somewhere in the test hierarchy. Re use that one |
@@ -687,6 +687,7 @@ namespace System.Net.Sockets
LogBuffer(bytesTransferred);
}
+ SocketType? socketType = _currentSocket?.SocketType;
SocketError socketError = SocketError.Success;
switch (_completedOperation)
{
| [SocketAsyncEventArgs->[FinishOperationAsyncFailure->[OnCompleted,FinishOperationSyncFailure],ExecutionCallback->[OnCompleted],FinishWrapperConnectSuccess->[SetResults,OnCompleted,Complete],FinishOperationAsyncSuccess->[FinishOperationSyncSuccess,OnCompleted],CancelConnectAsync->[Dispose],FinishOperationSyncSuccess->[S... | Finishes the asynchronous sync operation. Called by SocketAsyncOperation when it is done. | This is good example of why the split across event sources is problematic. We're tracking bytes transferred with one event source but logging the contents with another. |
@@ -133,6 +133,12 @@ public class SingleStringInputCachingExpressionColumnValueSelector implements Co
return expression.eval(bindings);
}
+ @Override
+ public boolean isNull()
+ {
+ return eval().isNull();
+ }
+
public static class LruEvalCache
{
private final Expr expression;
| [SingleStringInputCachingExpressionColumnValueSelector->[eval->[eval],LruEvalCache->[compute->[eval]]]] | Evaluate the expression and cache it if it can be found. | Checks in this class? |
@@ -405,7 +405,17 @@ class TestReproDryNoExec(TestDvc):
self.assertEqual(ret, 0)
ret = main(
- ["run", "--no-exec", "--single-stage", "-f", DVC_FILE] + deps
+ [
+ "run",
+ "--no-exec",
+ "--single-stage",
+ "-f",
+... | [TestReproChangedDir->[test->[_run,_get_stage_target]],TestReproAllPipelines->[test->[_run]],TestReproCyclicGraph->[test->[_run]],TestReproChangedCode->[test->[_get_stage_target]],TestRepro->[setUp->[_run]],TestNonExistingOutput->[test->[_get_stage_target]],TestReproForce->[test->[_get_stage_target]],TestReproNoCommit-... | Test if there is a n - ary file in the DVC file. | On above code, `deps` are saved as list with sequence of `-d, dep` items (flattened out), i just extract every second element of the list. |
@@ -62,6 +62,7 @@ if (empty($name)) {
$status = 'error';
$message = 'Missing transport information';
} else {
+ $is_default = $is_default ? 1 : 0;
$details = array(
'transport_name' => $name,
'is_default' => $is_default
| [hasGlobalAdmin,all,fails,make,errors] | Creates a new alert transport object. Config values for transport type. | I think it would be better if you did this up above (line 53 & 55). |
@@ -938,13 +938,13 @@ class FreqtradeBot:
raise DependencyException(
f"Not enough amount to sell. Trade-amount: {amount}, Wallet: {wallet_amount}")
- def execute_sell(self, trade: Trade, limit: float, sell_reason: SellType) -> None:
+ def execute_sell(self, trade: Trade, limit: flo... | [FreqtradeBot->[execute_buy->[get_buy_rate,_get_min_pair_stake_amount],_check_available_stake_amount->[_get_available_stake_amount],_notify_sell->[get_sell_rate],cleanup->[cleanup],handle_trailing_stoploss_on_exchange->[create_stoploss_order],handle_stoploss_on_exchange->[create_stoploss_order],_calculate_unlimited_sta... | Get the amount of a node that can be sellable. Attempt to cancel the order and update the record with the next key. | I guess we were thinking of opposite: make `execute_buy()` returning None... Anyway, I understand your possible rationaly here (to have it aligned with `execute_buy()`), so it's okay, this can be reworked later... |
@@ -60,15 +60,11 @@ class Terms_Of_Service {
* @return bool
*/
public function has_agreed() {
- if ( ! $this->get_raw_has_agreed() ) {
- return false;
- }
-
if ( $this->is_development_mode() ) {
return false;
}
- return $this->is_active();
+ return $this->get_raw_has_agreed() || $this->is_acti... | [Terms_Of_Service->[is_development_mode->[is_development_mode],is_active->[is_active]]] | Has this object agreed?. | `get_raw_has_agreed` is a simpler call than `is_active`, so I agree with this ordering. It'll be more performant. The only edge case is, upon disconnection, does that imply the customer is revoking their "use" of Jetpack or do we state that any use of Jetpack following that. In either event, that's a separate issue tha... |
@@ -281,10 +281,11 @@ class RPC(object):
rate = 1.0
else:
try:
- if coin in('USDT', 'USD', 'EUR'):
- rate = 1.0 / self._freqtrade.get_sell_rate('BTC/' + coin, False)
+ pair = self._freqtrade.exchange.get_valid_pa... | [RPC->[_rpc_status_table->[RPCException],_rpc_trade_status->[RPCException],_rpc_forcesell->[RPCException,_exec_forcesell],_rpc_balance->[RPCException],_rpc_trade_statistics->[RPCException],_rpc_forcebuy->[RPCException],_rpc_count->[RPCException],_rpc_edge->[RPCException],_rpc_daily_profit->[RPCException]]] | Returns current account balance per crypto. | Need to think a bit about logic imlemented here... |
@@ -31,7 +31,7 @@ public class ValidateResponse extends AbstractTransformer {
if (response != null && response.contains("success")) {
return response;
} else {
- throw new TransformerException(I18nMessageFactory.createStaticMessage("Invalid response from service: " + response));
+ throw new T... | [ValidateResponse->[doTransform->[contains,createStaticMessage,TransformerException,toString]]] | Transform the result of the service call. | service -> flow? |
@@ -88,6 +88,17 @@ func ImageSelector(f ImageSelectorFunc) func(params *crossBuildParams) {
}
}
+// WithPlatforms sets dependencies on others platforms.
+func WithPlatforms(expressions ...string) func(params *crossBuildParams) {
+ return func(params *crossBuildParams) {
+ var list BuildPlatformList
+ for _, expr... | [Build->[Printf,Getuid,Itoa,Join,ImageSelector,ToSlash,Wrap,Rel,Getgid,RunCmd,Verbose],Printf,Build,Wrapf,Join,Println,Filter,HasPrefix,Deps,CanCrossBuild,Errorf,Chown,Defaults,Getenv,Atoi,RunWith,Walk] | WithTarget specifies the mage target to execute inside the golang - crossbuild container. With returns an error if the build platform is not supported by the GolangCrossBuilder. | It's hard to distinguish betwen when to use `ForPlatforms` and `WithPlatforms`. I suggest making this new option `AddPlatforms` because it adds to the existing list rather than "sets". |
@@ -26,6 +26,11 @@ class Conversation
const PARCEL_TWITTER = 67;
const PARCEL_UNKNOWN = 255;
+ public static function getByItemUri($item_uri)
+ {
+ return DBA::selectFirst('conversation', [], ['item-uri' => $item_uri]);
+ }
+
/**
* @brief Store the conversation data
*
| [No CFG could be retrieved] | Creates a conversation item with the given data. region Item - URI - To - URI - To - URI - To - URI - To. | please add a doxygen header |
@@ -84,6 +84,9 @@ export class AmpAdApiHandler {
this.iframe_ = iframe;
this.is3p_ = is3p;
this.iframe_.setAttribute('scrolling', 'no');
+ let iframeSrc = this.iframe_.getAttribute('src');
+ iframeSrc = iframeSrc.substring(0, iframeSrc.indexOf('#'));
+ this.useApi_ = endsWith(iframeSrc, '.html')... | [No CFG could be retrieved] | Registers listeners and events for the given entity identifier. Package that listen to ad response. | I was about to check frame.html or `RTV version + frame.html` But I don't want to create difference for localDev mode and test mode, so i only check `.html` here. I do get `this.useApi_ = false` here on an `adsense` ad with A4A experiment on |
@@ -54,7 +54,7 @@ import java.math.BigDecimal;
<%_ if (fieldsContainBlob && databaseType === 'cassandra') { _%>
import java.nio.ByteBuffer;
<%_ } _%>
-<%_ if (fieldsContainOwnerManyToMany) { _%>
+<%_ if (fieldsContainOwnerManyToMany || fieldsContainEmbedded) { _%>
import java.util.HashSet;
import java.util.Set;
<... | [No CFG could be retrieved] | Gets the primary key type based on the database type and relationships. END of Class Definition. | What does `fieldsContainEmbedded` mean? That at least one of the fields is an embedded entity? Or all of them are? |
@@ -483,6 +483,7 @@ class GcsDownloader(Downloader):
return self._size
def get_range(self, start, end):
+ self._download_stream.seek(0)
self._download_stream.truncate(0)
self._downloader.GetRange(start, end - 1)
return self._download_stream.getvalue()
| [GcsDownloader->[__init__->[parse_gcs_path]],get_new_http->[proxy_info_from_environment_var],GcsIO->[copy->[parse_gcs_path],size->[parse_gcs_path],__new__->[get_new_http],copytree->[copy],exists->[parse_gcs_path],copy_batch->[parse_gcs_path,GcsIOError],delete->[parse_gcs_path],checksum->[parse_gcs_path],delete_batch->[... | Get a range of the file. | This is fine, but I'm curious why you had to make this change--did you encounter an error before this? |
@@ -133,8 +133,7 @@ public class JoinConditionAnalysis
*/
public boolean isAlwaysFalse()
{
- return nonEquiConditions.stream()
- .anyMatch(expr -> expr.isLiteral() && !expr.eval(ExprUtils.nilBindings()).asBoolean());
+ return anyFalseLiteralNonEquiConditions;
}
/**
| [JoinConditionAnalysis->[forExpression->[JoinConditionAnalysis],equals->[equals]]] | Checks if the condition is always false. | It seems like `allTrueLiteralNonEquiConditions` is only used here; how about caching `isAlwaysTrue` directly? |
@@ -296,6 +296,11 @@ type ImageStreamStatus struct {
// DockerImageRepository represents the effective location this stream may be accessed at. May be empty until the server
// determines where the repository is located
DockerImageRepository string
+ // PublicDockerImageRepository represents the public location f... | [No CFG could be retrieved] | Returns whether the server should be able to pull the given object. | I'm tempted to say that this should be `publicImageRepository` or `publicPullSpec` to set the longer term direction. |
@@ -418,6 +418,9 @@ func (mod *modContext) typeString(t schema.Type, lang string, characteristics pr
tokenName := tokenToName(t.Token)
// Links to anchor tags on the same page must be lower-cased.
href = "#" + strings.ToLower(tokenName)
+ default:
+ // Assume primitive/built-in type if no match for cases list... | [genResource->[genNestedTypes,genLookupParams,genConstructors,getProperties,getConstructorResourceInfo],gen->[getModuleFileName,genResource,add],genNestedTypes->[typeString],genIndex->[getModuleFileName],genConstructorCS->[typeString],genConstructors->[genConstructorTS,genConstructorGo,genConstructorCS],genLookupParams... | typeString returns a propertyType for the given type with the given language and characteristics. | Actually I don't think we can assume that it would be a primitive type. The schema has other types besides just Array and Object types. I think what we should do instead is to check if the type is in-fact a primitive type by calling `schema.IsPrimitiveType(t)` and then calling `GetDocLinkForBuiltInType` to get try and ... |
@@ -216,8 +216,12 @@ func (d Delegator) post(lctx LoginContext) (err error) {
"type": S{Val: d.PushType},
"is_remote_proof": B{Val: false},
"public_key": S{Val: pub},
- "server_half": S{Val: hex.EncodeToString(d.ServerHalf)},
}
+
+ if len(string(d.ServerHalf)) > 0 {
+ hargs["server_half... | [Run->[CheckArgs],updateLocalState->[getExistingKID,IsSibkey],post->[getSigningKID]] | post posts a new key to the server. | if we don't have a server half, like in backup keys, let's just not send it. this cleans up the code on the server side and it saves space and makes the api cleaner |
@@ -142,7 +142,7 @@ class RawBrainVision(BaseRaw):
self._create_event_ch(np.empty((0, 3)), n_samples)
super(RawBrainVision, self).__init__(
- info, last_samps=[n_samples - 1], filenames=[data_filename],
+ info, last_samps=[n_samples - 1], filenames=[data_fname],
or... | [_aux_vhdr_info->[_check_hdr_version],read_annotations_brainvision->[_read_vmrk],_get_vhdr_info->[_aux_vhdr_info,_str_to_meas_date],read_raw_brainvision->[RawBrainVision]] | Initialize a new object with the specified parameters. Initialize the raw BrainVision object from a file in vmrk. | If `self._orig_units` is something every `BaseRaw` instance should have, then it should be an argument to `BaseRaw.__init__`. |
@@ -126,7 +126,7 @@ class PackageFinder(object):
for version in req.absolute_versions:
if url_name is not None and main_index_url is not None:
locations = [
- posixpath.join(main_index_url.url, version)] + locations
+ posixpath.join(main_index... | [PackageFinder->[find_requirement->[_sort_locations,mkurl_pypi_url],_sort_locations->[sort_path],_package_versions->[_sort_links]],get_requirement_from_url->[Link,splitext],HTMLPage->[get_page->[is_archive,add_page_failure,get_page,set_is_archive,add_page,too_many_failures]],Link->[splitext->[splitext]]] | Find a requirement in the index. Returns a list of version numbers that can be used to install the given distribution. Returns a if the current installed version satisfies the requirement. | just change to: `posixpath.join(main_index_url.url, version) + "/"` @agronholm or @iElectric you want to handle this in a new pull? these are less concerning though, because often these are 404's anyway. If I don't get a response, I'll just close for now, since part of this was already handled in pull #695. |
@@ -1,4 +1,4 @@
-<div id="outerContainer" class="loadingInProgress" style="width: 100%; height: 100%;">
+<div id="outerContainer" class="loadingInProgress" style="width: 100%; height: 100%; cursor: crosshair;">
<div id="mainContainer">
<div class="toolbar">
<div id="toolbarContainer">
| [No CFG could be retrieved] | Displays a list of all components of the n - ary. Displays a list of options that can be selected in the menu. | Put style in CSS? |
@@ -567,7 +567,7 @@ ds_cont_tgt_open_handler(crt_rpc_t *rpc)
DP_CONT(in->toi_pool_uuid, in->toi_uuid), rpc,
DP_UUID(in->toi_hdl));
- rc = dss_task_collective(cont_open_one, in, 0);
+ rc = dss_thread_collective(cont_open_one, in, 0);
D_ASSERTF(rc == 0, "%d\n", rc);
out->too_rc = (rc == 0 ? 0 : 1);
| [No CFG could be retrieved] | function to handle the n - ary object. returns 0 if not found. | why it has to be in open(), I thought as long as it is before normal rebuild, it should be ok? or I miss sth? |
@@ -29,7 +29,9 @@ namespace TwoMGFX
public string name;
public VertexElementUsage usage;
public int index;
+#pragma warning disable 649
public int location;
+#pragma warning restore 649
}
/// <summary>
| [ShaderData->[Clone]] | Constructor for ShaderData. | `CS0649` is declared but not assigned a value. |
@@ -46,8 +46,8 @@ class Command(BaseCommand):
def handle(self, *args, **kw):
addons, dates, index = kw['addons'], kw['date'], kw['index']
tasks = []
- for indexer in (UpdateCountIndexer, DownloadCountIndexer):
- index_data_tasks = indexer.reindex_tasks_group(
+ for indexe... | [Command->[add_arguments->[add_argument],handle->[group,reindex_tasks_group,extend]],getLogger] | Reindex the count data. | nit: could remove the loop entirely |
@@ -644,10 +644,15 @@ class Trainer:
self._model.eval()
- val_generator = self._iterator(self._validation_data,
+ if self._validation_iterator is not None:
+ val_iterator = self._validation_iterator
+ else:
+ val_iterator = self._iterator
+
+ val_generator ... | [Trainer->[_parameter_and_gradient_statistics_to_tensorboard->[add_train_scalar,is_sparse],train->[_enable_activation_logging,_validation_loss,_should_stop_early,_metrics_to_tensorboard,_enable_gradient_clipping,_metrics_to_console,_train_epoch,_get_metrics],_enable_activation_logging->[hook->[add_train_histogram]],_re... | Computes the validation loss and the number of batches. | I think you have an indentation issue here |
@@ -85,10 +85,12 @@ import com.cloud.utils.NumbersUtil;
import com.cloud.utils.component.ManagerBase;
import com.cloud.utils.concurrency.NamedThreadFactory;
import com.cloud.utils.db.SearchCriteria;
+import com.sun.mail.smtp.SMTPMessage;
+import com.sun.mail.smtp.SMTPSSLTransport;
+import com.sun.mail.smtp.SMTPTrans... | [AlertManagerImpl->[sendAlert->[sendAlert],generateEmailAlert->[sendAlert],checkForAlerts->[recalculateCapacity],EmailAlert->[sendMessage->[run->[sendMessage]]],generateAlert->[sendAlert],clearAlert->[clearAlert]]] | Implementation of the alert manager. Injection for all of the DAOs. | another interface change! Please realise that this is incompatible! |
@@ -401,7 +401,7 @@ func (b *localBackend) apply(ctx context.Context, kind apitype.UpdateKind, stack
fmt.Printf(
op.Opts.Display.Color.Colorize(
colors.SpecHeadline+"Permalink: "+
- colors.Underline+colors.BrightBlue+"file://%s"+colors.Reset+"\n"), stack.(*localStack).Path())
+ colors.Underline+colo... | [GetHistory->[Name],CreateStack->[Name],Refresh->[GetStack],ExportDeployment->[Name],GetStack->[Name],StateDir->[Dir],GetStackCrypter->[Name],getLocalStacks->[Name],Update->[GetStack],Destroy->[GetStack],RemoveStack->[Name],ListStacks->[GetStack],ImportDeployment->[Name],Preview->[GetStack],GetLogs->[Name],apply->[Name... | apply is the main entry point for the local backend. It creates the necessary resources and updates The main loop of the update process. This is a trivial implementation of the n - node command that does not require a checkpoint. | What kind of a link is this? Is the user expected to be able to click on it? The gocloud.dev URLs work for gocloud.dev APIs, but not in your browser. If you need the latter, you can use `Bucket.SignedURL`. |
@@ -91,8 +91,8 @@ def get_new_version_number(version):
def sign_addons(addon_ids, force=False, **kw):
"""Used to sign all the versions of an addon.
- This is used in the 'process_addons --task sign_addons' management
- command.
+ This is used in the 'process_addons --task resign_addons_for_cose'
+ m... | [sign_addons->[,all,get_new_version_number,filter,info,move,copy,set,bool,update_version_number,error,sign_file,update,len,send_mail,get_dev_url,format,absolutify,version_int,get,isfile,values_list,add],get_new_version_number->[groupdict,int,search,format],getLogger,compile] | Signs all the addons. Updates the version number and the file object if we signed the file. | Shouldn't this be done earlier, in `process_addons` task declaration ? |
@@ -0,0 +1,6 @@
+def handle_seo_fields(data):
+ """Extract and assign seo fields to given dictionary."""
+ seo_fields = data.pop('seo_fields', None)
+ if seo_fields:
+ data['seo_title'] = seo_fields.get('seo_title')
+ data['seo_description'] = seo_fields.get('seo_description')
| [No CFG could be retrieved] | No Summary Found. | Maybe `clean_seo_fields`? I know it is not really cleaning but it's always used as part of "clean". |
@@ -807,8 +807,8 @@ class ostatus {
// Don't do a completion on liked content
if (((intval(get_config('system','ostatus_poll_interval')) == -2) AND (count($item) > 0)) OR
($item["verb"] == ACTIVITY_LIKE) OR ($conversation_url == "")) {
- $item_stored = item_store($item, true);
- return($item_stored);
+ ... | [ostatus->[add_author->[appendChild,createElement],follow_entry->[get_hostname,appendChild],entry_header->[setAttribute,createElementNS,createElement,appendChild],add_header->[setAttribute,createElementNS,appendChild],source_entry->[createElement],like_entry->[appendChild,createElement],fetchauthor->[item,query],salmon... | This function is used to perform a complete action on a single item in a conversation. Zabbix - API - StatusNet - Conversation fetch all items from a conversation This function creates a temporary file containing the object and all of its children. | Standards: Can you please add a space after commas? |
@@ -188,12 +188,15 @@ func (mod *modContext) typeString(t schema.Type, input, wrapInput, optional bool
if wrapInput && typ != "any" {
typ = fmt.Sprintf("pulumi.Input<%s>", typ)
}
+ if constValue != nil && typ == "string" {
+ typ = fmt.Sprintf("%q", constValue.(string))
+ }
+ if constValue != nil && typ == "pulu... | [genResource->[getConstValue,genAlias,getDefaultValue,genPlainType,typeString],genTypes->[genType,sdkImports,getImports,genHeader,details],genType->[details,genPlainType],gen->[genResource,genTypes,sdkImports,genFunction,isReservedSourceFileName,getImports,genHeader,add,genConfig],genFunction->[genPlainType],getTypeImp... | typeString returns a string representation of a type. schema. AssetType - > schema. Asset | schema. Asset | schema. AnyType. | I'm not sure if this special case makes sense here, or if this should be handled differently? |
@@ -79,6 +79,9 @@ class OrderEvent(CountableDjangoObjectType):
shipping_costs_included = graphene.Boolean(
description="Define if shipping costs were included to the refund."
)
+ related_order = graphene.Field(
+ lambda: Order, description="The related order to this one."
+ )
clas... | [OrderEvent->[resolve_lines->[OrderEventOrderLineObject]],OrderLine->[resolve_variant->[resolve_variant]]] | Relations for the order events. Get the email_type and amount from the root event. | Why not just `order`? |
@@ -38,12 +38,16 @@ import subprocess
import sys
import tempfile
import timeit
-
+import cv2 as cv
+import numpy as np
from pathlib import Path
from args import ArgContext, ModelArg
from cases import DEMOS
+from crop_size import CROP_SIZE
from data_sequences import DATA_SEQUENCES
+from similarity_measurement i... | [main->[option_to_args->[resolve_arg],collect_result,option_to_args,temp_dir_as_path,prepare_models,parse_args],parse_args->[parse_args],main] | Parse command line options. | Surround third party imports with empty lines. |
@@ -260,7 +260,7 @@ func (repo *Repository) searchCommits(id SHA1, opts SearchCommitsOptions) (*list
hashCmd := NewCommand("log", "-1", prettyLogFormat)
hashCmd.AddArguments(args...)
hashCmd.AddArguments(v)
- hashMatching, err := hashCmd.RunInDirBytes(repo.Path)
+ hashMatching, err := hashCmd.RunIn... | [GetBranchCommit->[GetCommit,GetBranchCommitID],CommitsBetweenIDs->[CommitsBetween,GetCommit],GetBranchCommitID->[GetRefCommitID],GetCommitsFromIDs->[GetCommit],getCommitByPathWithID->[getCommit],GetTagCommit->[GetTagCommitID,GetCommit],getCommitsBefore->[commitsBefore],getCommitsBeforeLimit->[commitsBefore],GetCommit-... | searchCommits searches for commits matching the given criteria. Get the list of all nodes in the system. | This cannot be right. |
@@ -250,7 +250,7 @@ RSpec.describe Dependabot::Python::UpdateChecker::PipenvVersionResolver do
it "raises an error" do
expect { subject }.to raise_error(Dependabot::DependencyFileNotResolvable) do |error|
expect(error.message).to include(
- "SyntaxError while installing dep... | [context,to,new,let,start_with,include,describe,fixture,latest_resolvable_version,resolvable?,project_dependency_files,eq,subject,it,require,raise_error] | end of the section below missing dependencies with extra requirements. | Not sure we're still able to detect python 2/3 mismatches, given that pipenv dropped support for 2.7 entirely in this release |
@@ -130,3 +130,18 @@ class Dist(Entity):
def __ne__(self, other):
return not self.__eq__(other)
+
+ # ############ conda-build compatibility ################
+
+ def split(self, sep=None, maxsplit=-1):
+ assert sep == '::'
+ return [self.channel, self.dist_name] if self.channel else ... | [Dist->[__lt__->[__key__],__hash__->[__key__],__le__->[__key__],__gt__->[__key__],__eq__->[__key__],__ne__->[__eq__],build_number->[quad],__ge__->[__key__]]] | Return True if self is not equal to other. | If there's much additional code work in this PR, it should likely happen right here. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.