patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -370,7 +370,16 @@ function stats_reports_page() {
if ( isset( $_GET['dashboard'] ) )
return stats_dashboard_widget_content();
- $blog_id = stats_get_option( 'blog_id' );
+ if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) {
+ $blog_id = get_current_blog_id();
+ $bloginfo = get_blog_details( (int) $blog_id );
+ $dom... | [stats_print_wp_remote_error->[get_error_messages,get_error_codes],stats_admin_bar_menu->[add_menu],stats_template_redirect->[get_queried_object_id]] | Renders the page that displays the Jetpack stats page. Renders a page with a header that can be used to display the site stats. This function is used to send a request to the stats server This function is used to handle the GET request. | We have a handly method `Jetpack::build_raw_urls( $url )` that we can use here. `Jetpack::build_raw_urls( get_home_url() )` should do the trick. |
@@ -71,6 +71,8 @@ int RAND_poll_ex(RAND_poll_fn cb, void *arg)
ok++;
}
CryptReleaseContext(hProvider, 0);
+ if (ok)
+ return 1;
}
/* poll the Pentium PRG with CryptoAPI */
| [RAND_event->[RAND_poll,RAND_status],RAND_poll_ex->[rand_read_tsc,CryptReleaseContext,cb,CryptGenRandom,BCryptGenRandom,rand_read_cpu,CryptAcquireContextW],RAND_screen->[RAND_poll]] | RAND_poll_ex - implementation of RAND_poll. | do you still need the ok++ ? |
@@ -23,7 +23,8 @@ import (
"github.com/openshift/origin/pkg/version"
)
-const adminLong = `OpenShift Administrative Commands
+const adminLong = `
+OpenShift Administrative Commands
Commands for managing an OpenShift cluster are exposed here. Many administrative
actions involve interaction with the OpenShift cl... | [NewCmdRegistry,NewCommandNodeConfig,NewCommandCreateKeyPair,NewCmdPolicy,Add,NewCmdConfig,DefaultSubCommandRun,NewCmdIPFailoverConfig,New,NewVersionCommand,NewCmdNewProject,NewCommandManageNode,NewCommandCreateKubeConfig,AddCommand,NewCmdRouter,NewCmdBuildChain,NewCommandOverwriteBootstrapPolicy,NewCommandCreateSigner... | NewCommandAdmin creates a new admin command NewCmdNewProject returns a new command that creates a new . | Why add the newline that's just going to get trimmed later on? Also, why force someone making a template to know that they need to trim? |
@@ -1517,7 +1517,7 @@ public class ReferenceCountedOpenSslEngine extends SSLEngine implements Referenc
for (int i = 0; i < enabled.length; i++) {
String mapped = toJavaCipherSuite(enabled[i]);
final String cipher = mapped == null ? enabled[i] : mapped;
- ... | [ReferenceCountedOpenSslEngine->[handshakeException->[shutdown],needPendingStatus->[isOutboundDone,isInboundDone],getSSLParameters->[getSSLParameters],retain->[retain],sslReadErrorResult->[shutdownWithError],getOcspResponse->[getOcspResponse],setKeyMaterial->[setKeyMaterial],getDelegatedTask->[run->[run]],wrap->[releas... | Returns the list of cipher suites that are enabled for this connection. | Does this just mask the problem? My concern is that the contents of `String[] enabled` are what are truly enabled by the SSL engine and this is just filtering them out. |
@@ -116,7 +116,7 @@ func (eb *ethBroadcaster) Trigger() {
func (eb *ethBroadcaster) monitorEthTxs() {
defer close(eb.chDone)
for {
- pollDatabaseTimer := time.NewTimer(databasePollInterval)
+ t := time.NewTimer(databasePollInterval)
keys, err := eb.store.Keys()
| [tryAgainWithHigherGasPrice->[handleInProgressEthTx]] | monitorEthTxs polls the database for new keys and blocks them if necessary. | I liked the initial name better, it's more descriptive. |
@@ -25,7 +25,7 @@ class NavierStokesCompressibleExplicitSolver(FluidSolver):
elif custom_settings["domain_size"].GetInt() == 3:
self.condition_name = "SurfaceCondition" # TODO: We need to create a Compressible NS condition (now using the base ones)
else:
- err_mgs = "Wrong doma... | [NavierStokesCompressibleExplicitSolver->[Initialize->[Initialize]]] | Initialize the Navier Stokes Compressible Explicit solver. | This is the typo I refer to |
@@ -1277,6 +1277,7 @@ namespace System.Windows.Forms
}
_created.Remove(control);
+ control.LostFocus -= OnControlLostFocus;
}
}
}
| [ToolTip->[TimerHandler->[Hide],DestroyHandle->[DestroyHandle],RemoveAll->[HandleDestroyed,DestroyRegion,HandleCreated,ClearTopLevelControlEvents],ToString->[ToString],WmMove->[Reposition],SetTool->[Hide,GetWinTOOLINFO],Show->[ShowTooltip,IsWindowActive],WndProc->[Dispose,WmWindowPosChanging,GetToolTip,WmWindowPosChang... | Sets the tool tip of a control. | I don't really understand this logic, didn't you already unsubscribe for `(empty && exists)` condition above? (Double unsubscribe doesn't hurt though, its a no-op, it will just confuse future readers of the code.) |
@@ -10,10 +10,10 @@ namespace Internal
// Some CoreCLR tests use it for internal printf-style debugging in System.Private.CoreLib
public static class Console
{
- public static void Write(string? s) => DebugProvider.WriteCore(s);
+ public static void Write(string? s) => DebugProvider.WriteCo... | [Console->[Write->[WriteCore],WriteLine->[Write,NewLineConst]]] | Write to the standard output. | FYI, this is a functional change to match coreclr's behavior. This is also just internal debug code, though, anyway. |
@@ -306,7 +306,7 @@ class LibraryInstaller implements InstallerInterface
return "#!/usr/bin/env sh\n".
'SRC_DIR="`pwd`"'."\n".
- 'cd "`dirname "$0"`"'."\n".
+ 'cd "${0%[/\\\\]*}"'."\n".
'cd '.escapeshellarg(dirname($binPath))."\n".
'BIN_TARGET="`pw... | [LibraryInstaller->[updateCode->[installCode,getInstallPath,update],installCode->[getInstallPath],installBinaries->[getBinaries,getInstallPath],removeBinaries->[getBinaries],removeCode->[getPackageBasePath],getBinaries->[getBinaries]]] | Generate code for proxying a Windows proxy. | Here's another opportunity to eliminate a `fork`: Use `$PWD` in sh instead of `pwd`. |
@@ -183,6 +183,7 @@ namespace Dynamo.Logging
/// </summary>
/// <param name="tag">Usage tag</param>
/// <param name="data">Usage data</param>
+ [Obsolete("Function will be deprecated in Dynamo 3.0 as Dynamo will no longer support GA instrumentation.")]
public static void LogPi... | [Analytics->[TrackScreenView->[TrackScreenView],ShutDown->[Dispose,ShutDown],TrackException->[TrackException],TrackEvent->[TrackEvent],TrackTimedEvent->[TrackTimedEvent],Start->[Start],LogPiiInfo->[LogPiiInfo],TrackPreference->[TrackPreference]]] | Log PII info. | I find this message confusing. Using `Obsolete` is already deprecating this function. Did you mean to say `removed` instead? Also saying `GA instrumentation` makes it unclear if it refers to `Instrumentation` or `Google Analytics`. If I understood correctly, we are talking about `Instrumentation`, right? |
@@ -971,7 +971,6 @@ namespace System.Data.OleDb
StringMemHandle? sptr = null;
bool mustReleaseStringHandle = false;
-
RuntimeHelpers.PrepareConstrainedRegions();
try
{
| [OleDbCommand->[ExecuteScalar->[ExecuteScalar,ExecuteReaderInternal],InitializeCommand->[CloseInternalCommand,CloseInternalParameters,HasParameters,ExpandCommandText,CreateAccessor],GetPropertyValue->[ICommandProperties],ExecuteReaderInternal->[Dispose,CloseFromDataReader],Clone->[Clone],ExecuteCommandTextForSingleRow-... | Execute the table direct. if any of the results in the current thread are not managed by the system. | Some of these files now just have whitespace changes... revert? |
@@ -1000,6 +1000,7 @@ public class VirtualFileTest {
}
@Test
+ @Ignore("TODO doesn't pass on ci.jenkins.io due to root user being used in container tests")
public void testCanRead_False_FileVF() throws Exception {
File ws = tmp.newFolder("ws");
String childString = "child";
| [VirtualFileTest->[testReadLink_IllegalSymLink_FileVF->[readLink,child],list_IllegalSymlink_FileVF->[list,child],simpleList_AbstractBase->[list],testOpenNoFollowLinks_NoFollowsLinkInternalSymlink_FilePathVF->[getName,open,child],testLastModified_FilePathVF->[child,lastModified],forFile_listOnlyDescendants_withoutIllega... | This test fails if the file can t be read on Windows. | feel free to amend this with assume or whatever, all I have time for now |
@@ -45,10 +45,8 @@ module TwoFactorAuthenticatable
def handle_second_factor_locked_user(type)
analytics.track_event(Analytics::MULTI_FACTOR_AUTH_MAX_ATTEMPTS)
-
- sign_out
-
render 'two_factor_authentication/shared/max_login_attempts_reached', locals: { type: type }
+ sign_out
end
def requi... | [handle_invalid_otp->[handle_second_factor_locked_user],generic_data->[personal_key_unavailable?]] | This is a helper method that handles the second factor authentication attempt. It is called when a. | NOTE this order change -- I needed to do this, otherwise was getting a nil error on `current_user.decorate` -- I think it was working before because we memoized `decorated_user` |
@@ -674,6 +674,8 @@ class CallableType(FunctionLike):
# 'dict')
'from_type_type', # Was this callable generated by analyzing Type[...]
# instantiation?
+ 'from_overloads', # Was this callable generated by synthesi... | [TypeQuery->[visit_star_type->[accept],visit_type_type->[accept],visit_overloaded->[items],visit_forwardref_type->[accept],query_types->[accept],visit_callable_argument->[accept]],TypeStrVisitor->[visit_callable_type->[accept],visit_typeddict_type->[accept,item_str,items],visit_star_type->[accept],visit_instance->[name... | Initialize a new object with a . | I don't see where this flag is actually used. |
@@ -24,15 +24,8 @@ const (
)
// ConcatBytes appends a bunch of byte arrays into a single byte array
-func ConcatBytes(bufs ...[]byte) ([]byte, error) {
- buffer := bytes.NewBuffer([]byte{})
- for _, b := range bufs {
- _, err := buffer.Write(b)
- if err != nil {
- return nil, err
- }
- }
- return buffer.Bytes(... | [ForEach,Add,PutUint64,Exp,Cmp,New,Neg,Errorf,Bytes,Sub,NewBuffer,Sign,LeftPadBytes,Write,SetInt64,Sprintf,BitLen,NewInt,Div,SetString,ParseFloat] | ConcatBytes converts a gjson. Result into a byte array. EVMEncodeBytes encodes arbitrary bytes as expected by the EVM. | Let's get rid of this. |
@@ -81,6 +81,9 @@ public class GameProperties extends GameDataComponent {
if (editableProperties.containsKey(key)) {
return editableProperties.get(key).getValue();
}
+ if (playerProperties.containsKey(key)) {
+ return playerProperties.get(key).getValue();
+ }
return constantProperties.g... | [GameProperties->[applyByteMapToChangeProperties->[streamToIEditablePropertiesList],get->[get],applyListToChangeProperties->[get],getEditableProperties->[get]]] | Get the value of the property with the specified key. | It probably doesn't matter now because bonus income percentage only exists under the player properties at this point. However, thinking to the future, could there ever be a case of a property being specified at the game level **and** the player level? If so, my assumption would be that the value of a player property ov... |
@@ -63,6 +63,16 @@ from spack.version import Version
from spack.package_prefs import get_package_dir_permissions, get_package_group
+# Filename for the unsuccessful Spack build log
+_spack_build_errfile = 'spack-build-err.txt'
+
+# Filename for the successful Spack build log
+_spack_build_logfile = 'spack-build-ou... | [PackageBase->[do_patch->[do_stage],_if_make_target_execute->[_has_make_target],check_for_unfinished_installation->[remove_prefix],do_stage->[do_fetch],dependency_activations->[extends],do_deactivate->[is_activated,_sanity_check_extension,do_deactivate],do_install->[build_process->[do_stage,_stage_and_write_lock,do_fak... | Creates a class that can be used to install a single phase of the installation. A phase decorator that executes pre - conditions on the instance attributes at the beginning of a phase. | Should we just make the `spack-` prefixed versions the name and not have different names in the build and install directories? The prefix is to differentiate the files from other build files in the stage directory, but it kind of doesn't matter if it's also called `spack-build-out.txt` when it's moved to `$prefix/.spac... |
@@ -315,7 +315,7 @@ namespace System.Windows.Forms.Design
dateTimeFormatsListBox.Visible = false;
}
- if (secondRowLabel.Text == "")
+ if (secondRowLabel.Text.Length == 0)
{
secondRowLabel.Visible = false;
}
| [FormatControl->[NumericFormatType->[Parse->[ParseStatic],PushFormatStringIntoFormatType->[Parse],ToString],DateTimeFormatsListBoxItem->[ToString->[ToString]],ScientificFormatType->[Parse->[ParseStatic],PushFormatStringIntoFormatType->[Parse],ToString],DateTimeFormatType->[Parse->[ParseStatic],PushFormatStringIntoForma... | Update the visibility of the control. Checks if there is a second row label and if so displays it. | :warning: :warning: Can the `Text` property be null in any case? If it can be null, then my change can null reference exception :warning: :warning: |
@@ -64,6 +64,11 @@ type RequiredPolicy struct {
// Where the Policy Pack can be downloaded from.
PackLocation string `json:"packLocation,omitempty"`
+
+ // The configuration that is to be passed to the Policy Pack. This is map a of policies
+ // mapped to their configuration. Each individual configuration must co... | [No CFG could be retrieved] | Requirements are the information regarding a specific Policy Pack. GetPolicyPackResponse - get policy pack response. | I *think* all of our uses of `*json.RawMessage` should be `json.RawMessage`. Applies throughout this PR. |
@@ -77,7 +77,7 @@ export const ANALYTICS_CONFIG = {
'suffix': '&ref=${documentReferrer}',
'pageview': '${base}&' +
'p=${title}&' +
- 's2=${level2}${suffix}',
+ 's2=${level2}${extraUrlParams}${suffix}',
'click': '${base}&' +
'pclick=${title}&' +
's2click=${le... | [No CFG could be retrieved] | A dictionary of all the possible values of the navigable object. Ajoute un nuevo nuevo nuevo nuevo nue. | just an observation. You are adding extraUrlParams to the pageview request. Would you not want to add it to the beginning of suffix? |
@@ -804,7 +804,10 @@ describes.repeated('', {
expect(form.className).to.not.contain('amp-form-submit-error');
expect(form.className).to.not.contain('amp-form-submit-success');
fetchRejecter();
- return timer.promise(5).then(() => {
+
+ return ampForm.xhrSubmitPromiseForTesting()... | [No CFG could be retrieved] | This method is used to fetch the form data from AMP. AJAX - based request trigger which triggers an error event on the AMP - Form. | `assert.fail('submit should have failed.');` ditto above. |
@@ -551,8 +551,11 @@ static int volume_prepare(struct comp_dev *dev)
comp_set_period_bytes(sinkb->sink, dev->frames, &cd->sink_format,
&sink_period_bytes);
- /* rewrite params format for all downstream */
- dev->params.frame_fmt = cd->sink_format;
+ /* Rewrite params format for this component to match the... | [No CFG could be retrieved] | This function prepares the volume components. - EINVAL if no . | @singalsu setting the frame_fmt in prepare() might be a little too late if the idea is to propagate it to the components upstream/downstream. prepare() is always called params |
@@ -57,8 +57,10 @@ func TestConfigAgentHandler_AuthorizationMiddleware(t *testing.T) {
}
func TestConfigAgentHandler_KillSwitchMiddleware(t *testing.T) {
+ cfg, err := config.Setup(config.DefaultConfig(beatertest.MockBeatVersion()), nil)
+ require.NoError(t, err)
t.Run("Off", func(t *testing.T) {
- rec, err := r... | [Reset,Equal,AssertApproveResult,MustNewConfigFrom,NewRequest,DefaultConfig,CompareMonitoringInt,Name,MockBeatVersion,NoError,ContextWithResponseRecorder,NotEqual,Bytes,Run,True] | TestConfigAgentHandler_AuthorizationMiddleware - A middleware that checks if the user is authorized to TestConfigAgentHandler_PanicMiddleware tests the panic middleware for config agent. | This is reused multiple times, how about creating a `testDefaultConfig` either in the `config` package for general usage, or in the `mux_test.go`? |
@@ -197,7 +197,10 @@ func (c *namespacedScaleClient) Update(resource schema.GroupResource, scale *aut
Body(scaleUpdateBytes).
Do()
if err := result.Error(); err != nil {
- return nil, fmt.Errorf("could not update the scale for %s %s: %v", resource.String(), scale.Name, err)
+ // propagate "raw" error from the... | [Update->[pathAndVersionFor],Get->[pathAndVersionFor,Get]] | Update updates a scale Decode the raw object from a Scale endpoint. | @deads2k @tnozicka isn't this "just enough" fix to stop the flakiness of scaler and leave us with rest in 1.10 world? |
@@ -414,6 +414,13 @@ def get_filetype(path_name):
return output.strip()
+def chgrp_if_not_world_writable(path, group):
+ """chgrp path to group if path is not world writable"""
+ mode = os.stat(path).st_mode
+ if mode & stat.S_IWOTH:
+ chgrp(path, group)
+
+
def mkdirp(*paths, **kwargs):
... | [copy->[set_install_permissions,copy,copy_mode],working_dir->[mkdirp],temp_cwd->[working_dir],install->[copy],traverse_tree->[traverse_tree],change_sed_delimiter->[filter_file],find_headers->[HeaderList,find],FileList->[__radd__->[__add__],__str__->[joined]],remove_dead_links->[join_path],touchp->[mkdirp,touch],files_i... | Creates a directory as well as parent directories if needed. | typo "final cr**AE**ted directory" |
@@ -377,7 +377,8 @@ describes.realWin('amp-sticky-ad 1.0 with real ad child', {
});
});
- it('should collapse and reset borderBottom when its child do', () => {
+ // TODO(zhouyx, #18574): Fix failing borderWidth check and re-enable.
+ it.skip('should collapse and reset borderBottom when its child do', () =... | [No CFG could be retrieved] | Adds a function to the DOM that will be mutated and will collapse and reset the borderBottom Only called if the AMPDoc is available. | Does this test pass now with the change to `Object.defineProperty`? |
@@ -472,10 +472,11 @@ void mapblock_mesh_generate_special(MeshMakeData *data,
for(u32 j=0; j<4; j++)
{
v3s16 neighbordir = cornerdir - halfdirs[j];
- content_t content = neighbor_contents[neighbordir];
+
+ NeighbourData &neighbour_data = neighbour_datas[NeighbourToIndex(neighbordir)];
+ cont... | [makeCuboid->[assert,vertices,MYMIN,append],inline->[getNodeNoEx,nodeboxConnects],mapblock_mesh_generate_special->[getParam2,FATAL_ERROR,getIndexCount,rotateBy,getFaceDir,getNodeBoxes,vertices,MapBlock_LightColor,getSceneManager,end,begin,v3s16,decode_light,cloneMesh,drop,getMeshManipulator,append,recalculateBoundingBo... | This method is called when a mesh is not in a mesh. It is called by the NodeNoEx - node no ex This function is used to render a node if it has no edge or edge - edge - region ITreeViewProvider Implementation private int _max_depth = 0 ; This function is used to draw a node in the MapBlock system. | Sorry for nit picks, but two style errors: `content_t &content` and { on same line as if |
@@ -601,6 +601,11 @@ public class ReferenceCountedOpenSslEngine extends SSLEngine implements Referenc
}
}
+ if (dst.remaining() < MAX_ENCRYPTED_PACKET_LENGTH) {
+ // Can not hold the maximum packet so we need to tell the caller to use a bigger destination
+ ... | [ReferenceCountedOpenSslEngine->[getSSLParameters->[getSSLParameters],retain->[retain],readPendingBytesFromBIO->[readEncryptedData,shutdown],OpenSslSession->[handshakeFinished->[isDestroyed,toJavaCipherSuite],getPeerCertificateChain->[isEmpty],initPeerCerts->[isEmpty],getPeerPort->[getPeerPort],invalidate->[isDestroyed... | Wrap the given bytes in the buffer. Returns the next pending data or null if there is no pending data. Pending bytes from the buffer. | Is it correct to use a constant here or should we get this value from the session? Or does the session always return this constant? |
@@ -140,6 +140,13 @@ def start_procs(args):
current_node_ip = args.node_ip
node_ips = [x.strip() for x in args.cluster_node_ips.split(',')]
node_id = node_ips.index(current_node_ip)
+ if args.use_paddlecloud:
+ # solve PADDLE_TRAINERS=null when using single node.
+ # you can automaticall... | [launch->[_print_arguments,start_procs,_parse_args],launch] | Start the processes and commands that need to be run. This function is called when a node is missing a node in the network. It is called. | 1. It's used only when running on paddlecloud multi nodes. And 2. these arguments should be checked with arguments from users. |
@@ -1081,7 +1081,7 @@ define([
(Math.abs(left.z - right.z) <= epsilon) &&
(Math.abs(left.w - right.w) <= epsilon));
};
-
+
/**
* An immutable Quaternion instance initialized to (0.0, 0.0, 0.0, 0.0).
*
| [No CFG could be retrieved] | Determines if the provided quaternions componentwise and returns true if they are within the provided Returns a new Quaternion instance if this quaternion is componentwise and returns false otherwise. | Please revert this unnecessary whitespace change. |
@@ -270,6 +270,14 @@ class Device extends BaseModel
return Time::formatInterval($this->uptime, $short);
}
+ public function formatDowntime($short = false)
+ {
+ $ret = static::where('hostname', $this->hostname)->first(['hostname', 'last_polled']);
+ if (!empty($ret)) {
+ r... | [Device->[getIconAttribute->[loadOs],shortDisplayName->[displayName],name->[displayName]]] | Format uptime and logo. | Why are you running an sql query here? `$this->last_polled` holds the value. |
@@ -526,9 +526,14 @@ func (c *clusterInfo) handleRegionHeartbeat(region *regionInfo) error {
// Region meta is updated, update kv and cache.
if r.GetVersion() > o.GetVersion() || r.GetConfVer() > o.GetConfVer() {
+ log.Infof("update region %v origin %v", region, origin)
return c.putRegionLocked(region)
}
... | [putRegionLocked->[setRegion],getMetaRegions->[getMetaRegions],unblockStore->[unblockStore],handleRegionHeartbeat->[putRegionLocked,setRegion,getRegion],randFollowerRegion->[randFollowerRegion],getStores->[getStores],getRegions->[getRegions],getStoreLeaderCount->[getStoreLeaderCount],searchRegion->[getRegion,searchRegi... | handleRegionHeartbeat handles heartbeat for a given region. | Need to log region id, or I think you may just log `region` and `origin` as above. |
@@ -34,6 +34,15 @@ def _place_obj(place):
return p
+def _is_pserver_mode(main_program):
+ main = main_program if main_program \
+ else framework.default_main_program()
+ for op in main.global_block().ops:
+ if op.type in ["send", "recv"]:
+ return True
+ return False
+
+
clas... | [CompiledProgram->[_compile->[_compile_inference,_compile_data_parallel,_place_obj]]] | Creates a CompiledProgram for a single object with a single object. Initialize a model with the given program instance. | this is very fragile. Can you use a better solution? tag program in transpiler? |
@@ -30,8 +30,6 @@ import logging
from typing import Any, Union, Optional, AsyncIterator as AsyncIteratorType
import urllib3 # type: ignore
-import requests
-
from azure.core.exceptions import (
ServiceRequestError,
ServiceResponseError
| [AsyncioRequestsTransport->[send->[_get_running_loop],sleep->[sleep]],AsyncioRequestsTransportResponse->[stream_download->[AsyncioStreamDownloadGenerator]],_get_running_loop->[_get_running_loop],AsyncioStreamDownloadGenerator->[__anext__->[_get_running_loop,sleep]]] | This function returns the base object that represents the given which is referenced by all of A wrapper around asyncio. _get_running_loop. | Given this file is about requests, I would keep it up by principle. It might mean we need the 3.7 perf system for the entire file if we want benefits here. |
@@ -948,6 +948,15 @@ class Toolbox extends Component<Props, State> {
return !this.props._isProfileDisabled && this._shouldShowButton('profile');
}
+ /**
+ * Returns true if the camera toggle button is visible and false otherwise.
+ *
+ * @returns {boolean}
+ */
+ _isToggleCameraVis... | [No CFG could be retrieved] | Renders the list elements of the overflow menu. Displays a confirmation dialog if the user has selected a block of blocks. | We could put this check inside the button, setting the `visible` prop. As we do on mobile for all buttons. |
@@ -38,6 +38,14 @@ import java.util.List;
import java.util.concurrent.ExecutorService;
import java.util.function.Function;
+/**
+ * {@link CachePopulator} implementation that uses a {@link ExecutorService} thread pool to populate a cache in the
+ * background. Used if config "druid.*.cache.numBackgroundThreads" is ... | [BackgroundCachePopulator->[populateCache->[size,createGenerator,incrementOk,writeObject,toByteArray,incrementOversized,ByteArrayOutputStream,incrementError,warn,put],wrap->[onFailure->[error],onSuccess->[clear,populateCache],apply,directExecutor,map,addCallback,allAsList,add,withEffect,submit],checkNotNull,listeningDe... | PUBLIC CONSTRUCTORS This class is exported for use with a background thread. Wrap a sequence in a cache. | I don't understand the relation with `maxEntrySize`, again, and what does "can stop retaining values early" mean. Please reword. |
@@ -1280,9 +1280,15 @@ TICKET_RETURN tls_decrypt_ticket(SSL *s, const unsigned char *etick,
size_t mlen;
unsigned char tick_hmac[EVP_MAX_MD_SIZE];
HMAC_CTX *hctx = NULL;
- EVP_CIPHER_CTX *ctx;
+ EVP_CIPHER_CTX *ctx = NULL;
SSL_CTX *tctx = s->session_ctx;
+ /* Need at least keyname + iv */... | [No CFG could be retrieved] | This function is called by the server when a ticket is received from the server. - - - - - - - - - - - - - - - - - -. | In practice this is probably fine, but the EVP *MAX* IV length is not really the right value for a check like this. |
@@ -64,4 +64,16 @@ RSpec.describe "articles/show", type: :view do
expect(rendered).to have_text("example.com")
expect(rendered).to have_text("Updated on")
end
+
+ it "shows the original publication time for crossposts" do
+ allow(article1).to receive(:canonical_url).and_return("https://example.com/lama... | [create_comment->[create,id],create,text,new,let,describe,current,at,it,name,decorate,to,before,extend,have_text,require,all?,assign,title,id,have_css,without_partial_double_verification,and_return] | expects the element s text is the same as the example text. | we expect to have content `</time>` but not have text `</time>` - it might be sufficient (and locale safe in the future) to just say that instead. |
@@ -116,7 +116,7 @@ final class ParDoEvaluatorFactory<InputT, OutputT> implements TransformEvaluator
mainOutputTag,
sideOutputTags,
stepContext,
- fnManager.<InputT, OutputT>get(),
+ fnManager.<InputT, OutputT>get().getFn(),
fnManager),
... | [ParDoEvaluatorFactory->[createParDoEvaluator->[create,error,getAll,addSuppressed,getWindowingStrategy,remove],forApplication->[getSideInputs,getAll,getKey,getMainOutputTag,getTransform,getNewFn,createEvaluator],cleanup->[values,removeAllFromManagers],getManagerForCloneOf->[getUnchecked],load->[of],createEvaluator->[ge... | Creates an evaluator that can be used to evaluate the given parameters. | So, I think the status of this is that it makes sense to pass the `DoFnInvoker` here without pulling out the `DoFn`. This, I believe, will require adding `DoFnRunners.forInvoker` which may (or may not) pull out the `DoFn` in order to get its signature, or you could add `DoFnInvoker.getSignature()` which would be more f... |
@@ -350,10 +350,13 @@ func (ms *MetricSet) initClient() error {
return errors.Wrap(err, "failed to enable auditing in the kernel")
}
}
+
if err := ms.client.WaitForPendingACKs(); err != nil {
return errors.Wrap(err, "failed to wait for ACKs")
}
- if err := ms.client.SetPID(libaudit.WaitForReply); err !=... | [receiveEvents->[initClient],EventsLost->[EventsLost]] | initClient initializes the client This function is called to set the backlog wait time for auditing and auditing. Error - failed to set audit PID. | want to move this into a constant outside of the scope of this function? |
@@ -190,12 +190,8 @@ class TrashItemController extends AbstractRestController implements ClassResourc
$trashItems = \array_map(
function(array $trashItem) use ($hiddenFieldDescriptors) {
- if (isset($trashItem['resourceKey'])) {
- $trashItem['resourceKey'] = $th... | [TrashItemController->[getAction->[getResourceSecurityContext,getOneBy,getResourceSecurityObjectId,getResourceSecurityObjectType,handleView,checkPermission,view],getResourceTranslation->[trans],getRequiredFieldDescriptors->[createFieldDescriptor],postTriggerAction->[all,toArray,handleView,restoreTrashItem,getRequestPar... | Returns a list of all items in the trash. Returns a list of trash items. | not sure if we are testing this controller. if we do, it would be nice to test the `restoreType` too |
@@ -1068,10 +1068,12 @@ def _inline_arraycall(func_ir, cfg, visited, loop, swapped, enable_prange=False,
# this doesn't work in objmode as it's effectively untyped
if typed:
len_func_var = ir.Var(scope, mk_unique_var("len_func"), loc)
- from numba.cpython.rangeobj import range_... | [_find_iter_range->[_make_debug_print,debug_print],InlineWorker->[inline_ir->[copy_ir],run_untyped_passes->[run],inline_function->[inline_ir],__init__->[check]],_inline_const_arraycall->[inline_array->[_new_definition,debug_print],list_var_used,State,_make_debug_print,reset],_find_arraycall->[_make_debug_print],_inline... | Internal function to find array call in a given loop. Get the definition of a function. Checks if the predecessor set of the loop header block is the same as loop entries plus Add a to the loop entry. | I'm happy with this choice of name, thanks for altering it! |
@@ -93,7 +93,7 @@ public class ZoneAwareClusterInvoker<T> extends AbstractClusterInvoker<T> {
// load balance among all registries, with registry weight count in.
- Invoker<T> balancedInvoker = select(loadbalance, invocation, invokers, null);
+ Invoker<T> balancedInvoker = select(ExtensionLoa... | [ZoneAwareClusterInvoker->[list->[list],shouldMigrate->[shouldMigrate]]] | Invokes the method with the given arguments. Returns a if it is available otherwise picks one from the invokers. | better avoid calling getExtension() every time |
@@ -0,0 +1,18 @@
+// Copyright 2015 Keybase, Inc. All rights reserved. Use of
+// this source code is governed by the included BSD license.
+
+// +build !darwin,!android
+
+package libkb
+
+import "os"
+
+func NewSecretStoreAll(g *GlobalContext) SecretStoreAll {
+ // In order to not break production build releases, onl... | [No CFG could be retrieved] | No Summary Found. | Is the idea here that we'll just use this var for our own testing, until we're ready for this to be in prod? |
@@ -489,3 +489,12 @@ type BuildLogOptions struct {
// is not available yet. Otherwise the server will wait until the build has started.
NoWait bool
}
+
+// SecretSpec specifies a secret to be included in a build pod and its corresponding mount point
+type SecretSpec struct {
+ // SecretSource is a reference to the... | [No CFG could be retrieved] | Returns true if the build is not available yet. | SecretSource or SecretVolumeMount is probably more accurate. You can probably still call the field "Secrets" but the type should be more specific. |
@@ -193,6 +193,17 @@ class BlockChainService:
return self.address_to_secret_registry[address]
+ def service_registry(self, address: Address) -> ServiceRegistry:
+ with self._secret_registry_creation_lock:
+ if address not in self.address_to_service_registry:
+ self.addre... | [BlockChainService->[block_number->[block_number],estimate_blocktime->[block_number],wait_until_block->[block_number],next_block->[block_number],is_synced->[block_number],payment_channel->[token_network]]] | Returns a SecretRegistry object for the given address. | Is it intentional that this is reusing the `_secret_registry_creation_lock`? |
@@ -204,7 +204,7 @@ class ArgSplitter:
An arg is a spec if it looks like an AddressSpec or a FilesystemSpec.
In the future we can expand this heuristic to support other kinds of specs, such as URLs.
"""
- return os.path.sep in arg or ':' in arg or os.path.isdir(arg)
+ return os.path.sep in arg or '... | [ArgSplitter->[_check_for_help_request->[GoalsHelp,VersionHelp,OptionsHelp],_consume_flags->[_check_for_help_request],split_args->[UnknownGoalHelp,SplitArgs,NoGoalHelp,add_scope,assign_flag_to_scope,_check_for_help_request]]] | Checks if arg looks like a spec. | Note that the statement "the path must exist to be considered a spec" is only true for top-level files/dirs. Anything else will have at least one `os.path.sep` in it, so will be read as a spec: `./pants path/to/nonexistent/file` will totally work, because of the first condition. |
@@ -298,7 +298,6 @@ public final class GameParser {
throw new RuntimeException(String.format("Map: %s, Could not find in classpath %s", mapName, dtdFile));
}
final String dtdSystem = url.toExternalForm();
- final String system = dtdSystem.substring(0, dtdSystem.length() - 8);
final Do... | [GameParser->[getProductionFrontier->[getValidatedObject],getDocument->[parse],parseRepairRules->[getChildren],findAttachment->[getRelationshipType,getUnitType,getTerritoryEffect,getTerritory,newGameParseException,getTechnology,getPlayerId,getResource],parseHeldUnits->[getPlayerId,getUnitType],parseShallow->[parseShall... | Get the document. | It seems as if `dtdSystem` could be moved along with `system`. |
@@ -616,7 +616,7 @@ class Jetpack_Subscriptions_Widget extends WP_Widget {
<p class="error"><?php esc_html_e( 'You have already subscribed to this site. Please check your inbox.', 'jetpack' ); ?></p>
<?php break;
case 'success' :
- echo wpautop( $success_message );
+ echo wpautop( str_replace( '... | [Jetpack_Subscriptions->[get_settings->[get_default_settings]],Jetpack_Subscriptions_Widget->[form->[defaults,fetch_subscriber_count]]] | This function is used to create a widget Renders the subscriptions page. Renders the jetpack - subscriber - widget. JS Event widget. | This looks good. The only issue I have is that the success message isn't style able. It would be really nice if you could pass a class to wpautop, but, alas. Maybe wrap it in a div with a "jetpack-subscribe-success" class? |
@@ -1186,6 +1186,14 @@ class CheckoutComplete(BaseMutation):
)
raise e
+ if payment_id:
+ _qs = checkout.payments.filter(is_active=True)
+ payment = cls.get_node_or_error(
+ info, payment_id, only_type=Payment, qs=_qs
+ ... | [CheckoutBillingAddressUpdate->[perform_mutation->[CheckoutBillingAddressUpdate,save,get_checkout_by_token]],CheckoutComplete->[perform_mutation->[CheckoutComplete,get_checkout_by_token]],CheckoutCreate->[save->[save],Arguments->[CheckoutCreateInput],clean_input->[retrieve_shipping_address,retrieve_billing_address,clea... | Perform a single node - level mutation. This function returns a CheckoutComplete object with all required data. | Shouldn't we use here `get_active_payments` here? |
@@ -138,7 +138,11 @@ function defaultHttpResponseTransform(data, headers) {
if (tempData) {
var contentType = headers('Content-Type');
if ((contentType && (contentType.indexOf(APPLICATION_JSON) === 0)) || isJsonLike(tempData)) {
- data = fromJson(tempData);
+ try {
+ data = fro... | [No CFG could be retrieved] | Provides a getter for the jQuery - like param serializer that serializes and parses the given HTTP headers Reads headers from header file and returns parsed headers if any. | We already have an `$httpMinErr` instance. Use that. |
@@ -84,6 +84,7 @@ namespace System.Net.Sockets.Tests
}
[Fact]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/55053", TestPlatforms.AnyUnix)]
public async Task Connect_DualMode_MultiAddressFamilyConnect_RetrievedEndPoints_Success()
{
if (!SupportsMultiC... | [ConnectCancellableTask->[Task->[Stream,Token,Windows,CancelAfter,Tcp,ConnectAsync,Parse,Cancel,Assert,InterNetwork]],Connect->[Task->[Stream,Disconnect,OSX,Connected,Port,AddressFamily,ConnectAsync,InterNetwork,ExecuteAsync,IPv6Loopback,SocketTestServerFactory,Bind,RemoteEndPoint,Async,LocalEndPoint,Min,TimedOut,Delay... | This method checks if the connection to the server is in a dual mode and if it is. | Did these ever fail on macOS, or only on Linux? |
@@ -6,6 +6,7 @@ import (
"github.com/containers/image/v5/docker/reference"
"github.com/containers/image/v5/types"
+ "github.com/containers/buildah/pkg/parse"
podmanVersion "github.com/containers/libpod/version"
)
| [Sprintf] | GetSystemContext imports a system context from a parent context. Set signature policy path from parent. | Can you remove this blank line? |
@@ -91,6 +91,11 @@ def _test_raw_reader(reader, test_preloading=True, **kwargs):
# gh-5604
assert _handle_meas_date(raw.info['meas_date']) >= 0
+ # test resetting raw
+ raw2 = reader(**raw._init_kwargs)
+ assert set(raw.info.keys()) == set(raw2.info.keys())
+ assert_array_almost_equal(raw.times,... | [test_meas_date_orig_time->[_raw_annot],test_deprecated_meas_date_orig_time->[_raw_annot]] | Test reading writing and slicing of raw classes. Test if a sequence of missing missing values is present in the raw data. Check if a is present in the raw data. | assert_array_equal should work here. |
@@ -64,6 +64,10 @@ class Order(models.Model, ItemSet):
editable=False)
token = models.CharField(
pgettext_lazy('Order field', 'token'), max_length=36, unique=True)
+ total = PriceField(
+ pgettext_lazy('Order field', 'total'),
+ currency=setti... | [OrderedItem->[change_quantity->[save,get_total_quantity,get_items,update_delivery_cost,change_status],OrderedItemManager],DeliveryGroup->[can_ship->[is_shipping_required],update_delivery_cost->[save,get_delivery_total,is_shipping_required],change_status->[save],DeliveryGroupManager],Payment->[get_purchased_items->[get... | Save the order in the database. | Can we have explicit "total_net" and "total_tax"? Then a "total" property could return a correct price object. |
@@ -87,4 +87,8 @@ KRATOS_CREATE_VARIABLE(bool, QUAD_ON);
// Additional strain measures
KRATOS_CREATE_VARIABLE(Vector, HENCKY_STRAIN_VECTOR);
KRATOS_CREATE_VARIABLE(Matrix, HENCKY_STRAIN_TENSOR);
+
+// For MPC implementations
+KRATOS_CREATE_VARIABLE(bool, IS_SLAVE)
+KRATOS_CREATE_VARIABLE(MpcData, MPC_DATA) // Amap o... | [No CFG could be retrieved] | Additional strain measures. | do not add IS_SLAVE (as explained before) |
@@ -74,7 +74,13 @@ public class JavaAstScanner {
cancelled = true;
break;
}
- executionTimeReport.start(inputFile.toString());
+ int lengthInBytes = -1;
+ try {
+ lengthInBytes = inputFile.contents().length();
+ } catch (IOException e) {
+ len... | [JavaAstScanner->[logUndefinedTypes->[logUndefinedTypes],collectUndefinedTypes->[collectUndefinedTypes],analysisCancelled->[analysisCancelled],scanSingleFileForTests->[setVisitorBridge,scan,JavaAstScanner,scanSingleFileForTests]]] | Scan the input files and find the most specific file that can be analyzed. | Because some implementations of InputFile load the file content at each `contents()` call, it would be better to have `executionTimeReport.start(inputFile)` without content length computation and only compute the length in the `if (currentAnalysisTime >= minRecordedOrderedExecutionTime) {` block. |
@@ -30,6 +30,7 @@ const host = process.env.SERVE_HOST;
const port = process.env.SERVE_PORT;
const useHttps = process.env.SERVE_USEHTTPS == 'true' ? true : false;
const gulpProcess = process.env.SERVE_PROCESS_ID;
+const quiet = process.env.SERVE_QUIET == 'true' ? true : false;
// Exit if the port is in use.
proce... | [No CFG could be retrieved] | Creates a new http server to handle a single object. Start gulp process that listens for the and then serve it. | this could have just been `const quiet = process.env.SERVE_QUIET == 'true';` (that already returns a boolean) right? |
@@ -99,6 +99,7 @@ func NewCommandStartAllInOne(basename string, out, errout io.Writer, stopCh <-ch
},
}
cmds.SetOutput(out)
+ cmds.Deprecated = "all-in-one is deprecated, not supported for production, and will be removed in a future release. Please use `oc cluster up` for local development."
flags := cmds.F... | [IsWriteConfigOnly->[Provided],Validate->[Value,IsRunFromConfig,Validate,New,IsWriteConfigOnly],StartAllInOne->[Fprintf,RunMaster,SplitHostPort,RunNode,SdNotify,IsWriteConfigOnly],Complete->[Provided,Value,Join,IsRunFromConfig,Itoa,Disable,Infof,Sprintf,ToLower,Default,JoinHostPort,Enabled,V,GetMasterAddress,String,Def... | Command line interface to start a server with missing configuration. default value is highly discouraged. | does this remove the whole `openshift start` command tree from `openshift --help`? |
@@ -1006,6 +1006,11 @@ daos_event_init(struct daos_event *ev, daos_handle_t eqh,
evx->evx_sched = &eqx->eqx_sched;
daos_eq_putref(eqx);
} else {
+ if (daos_sched_g.ds_udata == NULL) {
+ D_ERROR("The DAOS client library is not initialized: "
+ DF_RC"\n", DP_RC(-DER_EQ_UNINIT));
+ return -DER_EQ_UNINIT;
+... | [No CFG could be retrieved] | Adds an event to the parent event list. Unlink events from various lists parent_list child list and event queue hash list and destroy. | For this code path, before calling tse_task_schedule, dc_task_create() is called which calls this daos_event_init() to check the daos_sched_g. Since the seg fault is happening in tse_task_schedule, all of this call must after dc_task_create() succeed? is it possible there are cases that tse_task_schedule() is called wi... |
@@ -7,7 +7,14 @@ export const getNextOnboardingPage = user => {
return null
} else if (!user.termsAgreedAt) {
return '/terms'
- } else if (!user.revisedScheduleAgreedAt && !user.revisedScheduleRejected) {
+ } else if (
+ // Already agreed, don't display revised schedule
+ !user.revisedScheduleAgree... | [No CFG could be retrieved] | Imports the next onboarding page for a user. | We could also have an enum with 3 values: Agreed, Rejected, Abstained. And a separate agreedAt column with a date. Probably not worth the extra complexity. |
@@ -2014,13 +2014,13 @@ dfs_readdir(dfs_t *dfs, dfs_obj_t *obj, daos_anchor_t *anchor, uint32_t *nr,
if (rc)
return rc;
- D_ALLOC_ARRAY(kds, *nr);
+ D_MM_ALLOC_ARRAY(kds, *nr);
if (kds == NULL)
return ENOMEM;
- D_ALLOC_ARRAY(enum_buf, *nr * DFS_MAX_PATH);
+ D_MM_ALLOC_ARRAY(enum_buf, *nr * DFS_MAX_PATH);
... | [dfs_mount_root_cont->[dfs_cont_create,dfs_mount],dfs_umount_root_cont->[dfs_umount],dfs_lookup->[dfs_lookup],dfs_obj_local2global->[dfs_get_chunk_size],dfs_chmod->[dfs_lookup,dfs_release],dfs_access->[dfs_lookup,dfs_release]] | readdir - read directory entries if no key in kds list. | A better way to improve performance of this function would be to simple save kds and enum_buf between calls by hanging them on the dfs_obj_t somewhere. I think performance orientated users would likely call dfs_iterate() over dfs_readdir() so this function wouldn't be high on my list. |
@@ -80,6 +80,7 @@
$TemplateCacheProvider,
$TemplateRequestProvider,
$$TestabilityProvider,
+ $TimeProvider,
$TimeoutProvider,
$$RAFProvider,
$$AsyncCallbackProvider,
| [No CFG could be retrieved] | A component that provides information about the current AngularJS version. Publish external API for angular - angular. | Shouldn't this be `$DateProvider` ? |
@@ -133,6 +133,14 @@ export class AmpA4A extends AMP.BaseElement {
/** @private {!Array<!Promise<!Array<!Promise<?PublicKeyInfoDef>>>>} */
this.keyInfoSetPromises_ = this.getKeyInfoSets_();
+ // TODO(tdrl): Temporary, while we're verifying whether this is an
+ // acceptable solution to the 'Safari on ... | [AmpA4A->[constructor->[dev,getLifecycleReporter,AmpAdApiHandler],formatCSSBlock_->[cssUtf16CharOffsets,substring],onLayoutMeasure->[headers,some,resolve,then,user,checkStillCurrent,isAdPositionAllowed,cancellation,isCryptoAvailable,creative,bytes,signature,viewerForDoc,reject,verifySignature,arrayBuffer,map],preconnec... | private private void members_ =. | Either this should be a boolean or renamed (e.g. experimentalNonAmpCreativeRenderMethod_). |
@@ -129,7 +129,8 @@ public class UgiFilter implements Filter {
Token<OzoneTokenIdentifier> token = new Token(identifier.getBytes(),
identifier.getSignature().getBytes(StandardCharsets.UTF_8),
identifier.getKind(),
- omService);
+ null);
+// omService);
remo... | [UgiFilter->[doFilter->[doFilter],validateAccessId->[wrapOS3Exception]]] | This method is invoked when a servlet request is received and there is no match in the request Adds a token for the remote user. | I believe we don't need this filter class, once after we rebase with apache main branch |
@@ -159,7 +159,7 @@ class ADMMPruner(OneshotPruner):
# step 1: optimize W with AdamOptimizer
for epoch in range(self._training_epochs):
self._trainer(self.bound_model, optimizer=optimizer,
- criterion=criterion, epoch=epoch, callback=callback)
+ ... | [ADMMPruner->[validate_config->[And,Optional,validate,CompressorSchema],__init__->[set_wrappers_attribute,super],compress->[callback->[enumerate,get_modules_wrapper],parameters,_trainer,append,Adam,CrossEntropyLoss,_projection,info,enumerate,range,update_mask,zeros_like,get_modules_wrapper],_projection->[mul,deepcopy,c... | Compress the model with Adam and Adam optimizer. Compute the n - node model - node index using the Kalman filter. | can we handle the criterion in trainer? |
@@ -122,7 +122,7 @@ public class HazelcastTicketRegistry extends AbstractDistributedTicketRegistry {
*/
@Override
public Ticket getTicket(final String ticketId) {
- return this.registry.get(ticketId);
+ return getProxiedTicketInstance(this.registry.get(ticketId));
}
/**
| [HazelcastTicketRegistry->[shutdown->[shutdown],addTicket->[addTicket]]] | Gets ticket. | Why this? Are you getting proxy objects back that you need to find the real ticket instance? |
@@ -602,5 +602,14 @@ _%>
public void dtoEqualsVerifier() throws Exception {
TestUtil.equalsVerifier(<%= entityClass %>DTO.class);
}
+ <%_ if (databaseType == 'sql') { _%>
+
+ @Test<% if (databaseType == 'sql') { %>
+ @Transactional<% } %>
+ public void testEntityFromId() {
+ as... | [No CFG could be retrieved] | dtoEqualsVerifier - Tests if entity is DTO. | minor improvement: this second test on sql is no need |
@@ -25,7 +25,7 @@ from spack.fetch_strategy import URLFetchStrategy, FetchStrategyComposite
from spack.util.executable import ProcessError
from spack.relocate import needs_binary_relocation, needs_text_relocation
from spack.relocate import strings_contains_installroot
-from spack.relocate import get_patchelf, reloca... | [test_elf_paths->[substitute_rpath,get_relative_rpaths],has_gnupg2->[gpg],test_relocate_text->[write,relocate_text,strings_contains_installroot,as_cwd,close,open],test_needs_relocation->[needs_text_relocation,needs_binary_relocation],test_macho_paths->[macho_make_paths_relative,macho_replace_paths],fake_fetchify->[appe... | A context manager for testing the binary packaging infrastructure. A test suite that downloads a package from a file. | this is minor, but when there are this many imports, I would just import `spack.relocate as rel` or something like that, and prefix the usages in the code with `rel.` |
@@ -990,6 +990,9 @@ export class ViewportBindingNaturalIosEmbed_ {
/** @private {number} */
this.paddingTop_ = 0;
+ /** @private {number} */
+ this.lastPaddingTop_ = 0;
+
// Microtask is necessary here to let Safari to recalculate scrollWidth
// post DocumentReady signal.
whenDocumentRe... | [No CFG could be retrieved] | A class that represents a natural viewport binding that can be used to embed an iframe in iOS Styles for the element. | Is this needed? |
@@ -549,8 +549,12 @@ cont_create(struct rdb_tx *tx, struct ds_pool_hdl *pool_hdl,
/* Verify the pool handle capabilities. */
if (!(pool_hdl->sph_capas & DAOS_PC_RW) &&
- !(pool_hdl->sph_capas & DAOS_PC_EX))
+ !(pool_hdl->sph_capas & DAOS_PC_EX)) {
+ D_ERROR(DF_CONT": rpc=%p pool handle capabilities check... | [No CFG could be retrieved] | Initializes the container metadata for the given pool and container service. copy the default values of the properties. | Did you intend to do the following instead? if (rc != -DER_NONEXIST) { if (rc == 0) D_DEBUG(...); else D_ERROR(...); D_GOTO(out, rc); } |
@@ -335,7 +335,7 @@ public class PAssertTest implements Serializable {
/** Test that we throw an error for false assertion on singleton. */
@Test
- @Category({ValidatesRunner.class, UsesFailureMessage.class})
+ @Category({ValidatesRunner.class, UsesFailureMessage.class, UsesSideInputs.class})
public void t... | [PAssertTest->[testNotEqualTo->[of],testContainsInAnyOrderNotSerializable->[of,NotSerializableObject],testIsEqualTo->[of],throwWrappedError->[throwNestedError],testEmpty->[of],countAssertsSucceeds->[of],testWindowedSerializablePredicate->[of],testWindowedIsEqualTo->[of],testGlobalWindowContainsInAnyOrder->[of],testSucc... | Checks that the value of the singleton is not equal to the value of the singleton. | This doesn't use side inputs. |
@@ -554,6 +554,9 @@ create_bio_bdev(struct bio_xs_context *ctxt, struct spdk_bdev *bdev)
/* Try to load blobstore without specifying 'bstype' first */
bs = load_blobstore(ctxt, bdev, NULL, false);
if (bs == NULL) {
+ D_DEBUG(DB_MGMT, "Creating bs for %s\n",
+ spdk_bdev_get_name(bdev));
+
/* Create bl... | [No CFG could be retrieved] | load_blobstore loads a blobstore from disk and creates a blobstore if it doesn find the first target count of the blobstore. | (style) code indent should use tabs where possible |
@@ -1848,6 +1848,9 @@ define([
var environmentState = scene._environmentState;
var renderPass = frameState.passes.render;
environmentState.skyBoxCommand = (renderPass && defined(scene.skyBox)) ? scene.skyBox.update(frameState) : undefined;
+ if (defined(scene.skyAtmosphere)) {
+ ... | [No CFG could be retrieved] | Creates a wireframe with the geometry. The main entry point for the translucent commands. | Make sure to check that the globe is defined as well, otherwise the line below will throw an error. |
@@ -530,7 +530,9 @@ export const VideoServiceSignals = {
/** @param {!AmpElement|!VideoOrBaseElementDef} video */
export function delegateAutoplay(video) {
- video.signals().signal(VideoServiceSignals.AUTOPLAY_DELEGATED);
+ whenUpgradedToCustomElement(video).then(el => {
+ el.signals().signal(VideoServiceSigna... | [No CFG could be retrieved] | A function to set the autoplay state on a video. | Shouldn't we also add this to `userInteractedWith` below? |
@@ -1769,6 +1769,8 @@ class Grunion_Contact_Form_Field extends Crunion_Contact_Form_Shortcode {
if ( isset( $_POST[$field_id] ) ) {
$this->value = stripslashes( (string) $_POST[$field_id] );
+ } elseif ( isset( $_GET[$field_id] ) ) {
+ $this->value = stripslashes( (string) $_GET[$field_id] );
} elseif (
... | [Grunion_Contact_Form_Plugin->[widget_shortcode_hack->[add_shortcode]],Crunion_Contact_Form_Shortcode->[__toString->[esc_attr]],Grunion_Contact_Form_Field->[validate->[get_attribute,add_error],render->[get_attribute,is_error],__construct->[get_attribute,unesc_attr],add_error->[get_attribute]],Grunion_Contact_Form->[__c... | Renders the field This function renders the comment field in the contact form. This function renders the comment field in the form. This function renders the field in the form. This function renders the field in the form field_html - renders the contact form field. | can you please add spaces in bracket like `$_GET[ $field_id ]`? |
@@ -33,6 +33,9 @@ var (
_ = ptypes.DynamicAny{}
)
+// define the regex for a UUID once up-front
+var _authenticate_uuidPattern = regexp.MustCompile("^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$")
+
// Validate checks the field values on AuthenticateRequest with the rules
// defin... | [Error->[Sprintf],New,Duration] | Validate checks the field values on AuthenticateRequest with the rules defined in the proto definition for this. | Huh this means we must have also upgraded our deps...? Not a bad thing. It means we could use the `uuid` well-known string type in a few places, maybe. |
@@ -34,7 +34,7 @@ export class IframeMessagingClient {
this.win_ = win;
/** @private {?string} */
this.rtvVersion_ = getMode().rtvVersion || null;
- /** @private {!Window} */
+ /** @private {!(Window|Element)} */
this.hostWindow_ = win.parent;
/** @private {?string} */
this.sentinel_... | [IframeMessagingClient->[setupEventListener_->[getData,listen,source,deserializeMessage],sendMessage->[dev,serializeMessage],constructor->[getMode,parent,map]]] | A window is a child of the given window. | Is there a type specific to frames? |
@@ -477,7 +477,8 @@ int main (int argc, char *argv[])
{
TimeMonitor timerMultiVectorFill(*TimeMonitor::getNewTimer("4) MultiVectorFill"));
- auto value = X->getLocalView<typename exec_space::memory_space>(Tpetra::Access::OverwriteAll);
+ using device_type = typename tpetra_multivector_ty... | [No CFG could be retrieved] | Index to Jagged Index - - - - - - - - - - - - - - - - - -. | OK, but prefer use of getLocalViewDevice(Tpetra::Access::OverwriteAll). |
@@ -31,8 +31,17 @@ class Payment(models.Model):
"""
gateway = models.CharField(max_length=255)
- is_active = models.BooleanField(default=True)
+ is_active = models.BooleanField(
+ default=True,
+ help_text=(
+ "Inactive payments do not contribute toward checkout / orders, "
+ ... | [Transaction->[get_amount->[Money],CharField,JSONField,DateTimeField,ForeignKey,DecimalField,Decimal,BooleanField],Payment->[get_last_transaction->[all,attrgetter,max],Meta->[GinIndex],get_total->[Money],is_authorized->[all,any],get_authorized_amount->[Money,all,any,zero_money],get_captured_amount->[Money],CharField,Po... | A model that represents a single payment object. ManyToMany relationship between checkout and order. | Is the help text actually used anywhere? It should rather be part of a description in API. |
@@ -1,6 +1,16 @@
+try:
+ import torchdata
+except (ModuleNotFoundError, TypeError) as error:
+ raise ModuleNotFoundError(
+ "`torchvision.prototype.datasets` depends on PyTorch's `torchdata` (https://github.com/pytorch/data). "
+ "You can install it with `pip install git+https://github.com/pytorch/d... | [No CFG could be retrieved] | Load the from the database. | The `torchdata` library hosted on PyPI fails for me at import with an `TypeError`. This is why we can aggregate both failure cases here. |
@@ -3072,6 +3072,7 @@ namespace System
Unix = 4,
Xbox = 5,
MacOSX = 6,
+ Unknown = 7,
}
public partial class PlatformNotSupportedException : System.NotSupportedException
{
| [No CFG could be retrieved] | Exception that is thrown when the runtime is out of memory. NextBytes - This method is used to generate the next chunk of data. | Was this API reviewed? |
@@ -271,7 +271,11 @@ NATIVE_DEMOS = [
]
PYTHON_DEMOS = [
- # TODO: 3d_segmentation_demo: no input data
+ PythonDemo(subdirectory='3d_segmentation_demo', device_keys=['-d'], test_cases=combine_cases(
+ TestCase(options={'-m': ModelArg('brain-tumor-segmentation-0001'),
+ '-o': '.... | [combine_cases->[join_cases],NativeDemo,single_option_cases,combine_cases,PythonDemo] | Creates a test case for the n - node image - related options. Instance Segmentation with optional options. | Do we really need to create multiple cases for different inputs? What do we cover that wouldn't be covered with a single case? |
@@ -112,6 +112,16 @@ public abstract class ResponseContext
"uncoveredIntervalsOverflowed",
(oldValue, newValue) -> (boolean) oldValue || (boolean) newValue
),
+ /**
+ * Expected remaining number of responses from query nodes.
+ * The value is initialized in {@code CachingClusteredC... | [ResponseContext->[merge->[add],createEmpty->[createEmpty],removeNodeElementsToSatisfyCharsLimit->[remove],get->[get],remove->[remove],registerKey->[getName],deserialize->[keyOf,createEmpty],put->[put,keyOf,getName],add->[keyOf,getMergeFunction,getName],serializeWith->[add,remove,getDelegate]]] | This class is used to register a key in the extension response context. - A variable indicates when a running query should be expired and is effective only when timeout. | This should be added to `DirectDruidClient.removeMagicResponseContextFields` or something similar, so it doesn't end up in the response to the user. |
@@ -51,13 +51,12 @@ class BodyReplacerProcessor(RecordingProcessor):
def _replace_keys(self, body):
def _replace_recursively(dictionary):
- if type(dictionary) != dict:
- return
for key in dictionary:
+ value = dictionary[key]
if... | [BodyReplacerProcessor->[_replace_keys->[_replace_recursively->[_replace_recursively],_replace_recursively]],ResponseReplacerProcessor->[process_response->[sanitize_dict->[sanitize_dict],sanitize_dict]]] | Replace keys in body with replacement keys in body. | i wonder if somehow using type instead of isinstance did something |
@@ -54,6 +54,7 @@ performance.flags = {
'threshold':
' Fraction by which metrics are allowed to increase. Number between 0.0 and 1.0',
'quiet': ' Does not log progress per page',
+ 'debug': ' Run with a head and devtools open.',
'url': ' Page to test. Overrides urls set in config.json',
};
| [No CFG could be retrieved] | The performance module. | What if you split this up into headless and devtools flags? And for headless, note that this defaults to false, and the flag overrides the config. |
@@ -356,7 +356,17 @@ def plot_trans(info, trans='auto', subject=None, subjects_dir=None,
if coord_frame not in valid_coords:
raise ValueError('coord_frame must be one of %s' % (valid_coords,))
- show_head = (subject is not None)
+ meg_picks = pick_types(info, meg=True, ref_meg=ref_meg)
+ eeg_pi... | [plot_source_estimates->[_limits_to_control_points],_sensor_shape->[_make_tris_fan]] | Plot MEG or EEG head surface and helmet in 3D. Returns a nanomagical record. Check if a node in the system has a non - zero number of components. get the n - th N - th N - th N - th N - th N Warn if EEG is explicitly requested or if no channel or no data is provided. | head = len(ecog_picks) == 0 and subject is not None |
@@ -95,7 +95,7 @@ namespace System.Reflection.Metadata.Tests
Assert.Equal(item.Version, assemblyName.Version);
Assert.Equal(item.Name, assemblyName.Name);
Assert.Equal(item.ContentType, assemblyName.ContentType);
- Assert.Null(assemblyNam... | [AssemblyDefinitionTests->[ValidateAssemblyNameForAssemblyDefinition->[WindowsRuntime,NamespaceTests,ContentType,ValidateDefinitionAssemblyNameAgainst,AssemblyReferences,GetAssemblyName,AppCS,GetPublicKeyToken,CultureName,SHA1,Null,HashAlgorithm,Equal,None,Name,Default,GetAssemblyDefinition,ApplyWindowsRuntimeProjectio... | Checks that the name of the managed assembly is correct. | >Equal [](start = 27, length = 5) The same here - let's check the display name. |
@@ -61,6 +61,9 @@ var _ = oadmission.Validator(&projectRequestLimit{})
// Admit ensures that only a configured number of projects can be requested by a particular user.
func (o *projectRequestLimit) Admit(a admission.Attributes) (err error) {
+ if o.config == nil {
+ return nil
+ }
if a.GetResource() != projecta... | [Admit->[Resource,GetObject,GetUserInfo,NewForbidden,maxProjectsByRequester,GetName,GetResource,projectCountByRequester,Errorf],maxProjectsByRequester->[AsSelector,Matches,Users,Get,Set],Validate->[Errorf],projectCountByRequester->[ByIndex],NewHandler,ToAggregate,WantsProjectCache,ReadYAML,Errorf,RegisterPlugin,WantsOp... | Admit is the default admission function for project requests. | I really wish these could get out of the chain if they had a nil config (if the func passed to admission.RegisterPlugin could return something that said "actually, I don't want to be in the chain). |
@@ -79,6 +79,10 @@ export const component = () => {
creatable
/>
</div>
+ <div data-e2e="12-hour">
+ Without a value
+ <TimePicker nullable />
+ </div>
</div>
);
};
| [No CFG could be retrieved] | - Element. | Can you add a custom placeholder so that it can be included in the VRT? |
@@ -124,6 +124,11 @@ module SignUp
pii_dob ? pii_dob.to_date.to_formatted_s(:long) : ''
end
+ def verified_at
+ timestamp = current_user.active_profile&.verified_at
+ I18n.l(timestamp, format: :event_timestamp) if timestamp
+ end
+
def pii_to_displayable_attributes
{
f... | [CompletionsController->[track_completion_event->[analytics_attributes],email->[email]]] | missing pii dob. | What does the `&` do here? |
@@ -124,7 +124,7 @@ func Spawn(opts *serveropts.Opts) error {
// ChefRuns
chefIngest := server.NewChefIngestServer(client, authzProjectsClient, nodeMgrServiceClient,
- opts.MaxNumberOfBundledRunMsgs, opts.MaxNumberOfBundledActionMsgs)
+ opts.MaxNumberOfBundledRunMsgs, opts.MaxNumberOfBundledActionMsgs, opts.Num... | [NewEsSidecarClient,Close,Info,SetChefIngestServer,RegisterIngestStatusServer,NewNodeManagerServiceClient,NewJobScheduler,Error,Dial,New,InitializeStore,NewManager,Start,NewAutomateEventHandlerServer,NewJobSchedulerServer,NewProjectsClient,RegisterChefIngesterServer,RegisterJobSchedulerServer,RegisterDataLifecycleManag... | returns an object that can be used to query the node manager and the event. RegisterEventHandlerServer registers the event handler server. | would it make sense to start passing the entire `opts` struct? My rule is 3 or more parameters from the same struct it is worth passing the entire pointer and use it internally inside the function. |
@@ -1455,7 +1455,7 @@ if (is_object($objcanvas) && $objcanvas->displayCanvasExists($action))
// Type - Workforce/Staff
print '<tr><td>'.$form->editfieldkey('ThirdPartyType', 'typent_id', '', $object, 0).'</td><td class="maxwidthonsmartphone"'.($conf->browser->layout == 'phone' ? ' colspan="3"' : '').'>'."\n";
... | [create,setValueFrom,getNomUrl,select_juridicalstatus,check_codefournisseur,select_incoterms,setCategories,begin,display_canvas,textwithpicto,assign_values,fetch_optionals,transnoentitiesnoconv,query,getCanvas,trans,showphoto,select_civility,select_localtax,select_country,create_individual,select_all_categories,lasterr... | Print a list of all possible keys for a given object. Print the form for a single object. | In the dictionary, there is currently a type TYPE_UNKNOWN that was dedicated when value is unknown so similar to nothing selected into the combo. If we allow empty value as suggested (better), we should also remove the value unknown from dictionary. This may also have side effect on some join (inner join may need to be... |
@@ -107,7 +107,8 @@ public final class VolumeArgs {
public static class Builder {
private String adminName;
private String ownerName;
- private String volumeQuota;
+ private String volumeSsQuota;
+ private long volumeNsQuota;
private List<OzoneAcl> listOfAcls;
private Map<String, String>... | [VolumeArgs->[Builder->[build->[VolumeArgs],addMetadata->[put]],newBuilder->[Builder]]] | Sets the admin name. | `volumeSsQuota` and `volumeNsQuota` ditto, consider a better naming, it will be easier to for others to use and maintain. |
@@ -54,6 +54,7 @@ class Jetpack_Options {
'dismissed_connection_banner', // (bool) True if the connection banner has been dismissed
'onboarding', // (string) Auth token to be used in the onboarding connection flow
'tos_agreed', // (bool) Whether or not the TOS for conn... | [Jetpack_Options->[get_raw_option->[get_var,prepare],delete_raw_option->[query,prepare],update_raw_option->[query,prepare]]] | Get the option names. A list of all the configuration options that can be set in Wordpress. This method is used to determine which modules are currently installed and which are currently active. This method is called after the legacy Gallery Widgets have been converted to the new Core. | Perhaps: > Array of user ids that have been automatically disconnected |
@@ -409,7 +409,7 @@ describe RequestController, "when showing one request" do
:pending => {
"waiting_response" => "<strong>No response</strong> has been received <small>(maybe there's just an acknowledgement)</small>",
"waiting_clarification" => "<strong>Clarification</strong> has been req... | [expect_redirect->[post_status],get_attachment,expect_hidden,expect_redirect,post_status] | when there are no valid state transitions for the request it should set the state transitions for the missing_transitions - list of state transitions expected_transitions - list of state transitions. | Line is too long. [92/80] |
@@ -2592,7 +2592,7 @@ CommonNumber:
return TRUE;
}
- if (!TaggedNumber::Is(thisInstance))
+ if (!TaggedNumber::Is(instance))
{
return JavascriptOperators::SetProperty(RecyclableObject::UnsafeFromVar(thisInstance), RecyclableObject::UnsafeFromVar(instance), pro... | [No CFG could be retrieved] | This is a hack to work around the bug in the JS library. Set the property of the necase object. | >RecyclableObject::UnsafeFromVar(thisInstance) [](start = 52, length = 45) Now that !TaggedNumber::Is(thisInstance) is changed does the callers validate that thisInstance is a valid non tagged var? |
@@ -679,6 +679,12 @@ public class DoFnOperator<InputT, OutputT> extends AbstractStreamOperator<Window
pushbackDoFnRunner.finishBundle();
elementCount = 0L;
lastFinishBundleTime = getProcessingTimeService().getCurrentProcessingTime();
+ // callback only after current bundle was fully finalized
... | [DoFnOperator->[processElement2->[addSideInputValue,setPushedBackWatermark],processElement1->[setPushedBackWatermark],snapshotState->[invokeFinishBundle,snapshotState],TaggedKvCoder->[decode->[decode],verifyDeterministic->[verifyDeterministic],encode->[encode]],FlinkTimerInternals->[deleteTimer->[cleanupPendingTimer],c... | Finishes the bundle if it is not already done. | Could you share more from your findings? It looks like the only difference is that `elementCount/lastFinishBundleTime` is reset before calling `bundleFinishedCallback`. I see that starting a new bundle can cause problems because it may be finalized immediately due to the element count not being reset yet. |
@@ -1603,6 +1603,18 @@ namespace lfg
_SaveToDB(gguid);
+ // Select a player inside to be teleported to
+ WorldLocation const* teleportLocation = nullptr;
+ for (GroupReference* itr = grp->GetFirstMember(); itr != nullptr; itr = itr->next())
+ {
+ Player* plr = itr->Ge... | [No CFG could be retrieved] | Adds a member to the group or random dungeon if it is not in the group Add a specific to the group and return the id of the newly created . | I see that further down you use static_cast and here not. What is the difference between the different cases? |
@@ -1240,6 +1240,15 @@ func findLogsWithTopic(
return logs
}
+// formatNegativeValue ..
+func formatNegativeValue(num *big.Int) string {
+ value := "0"
+ if num != nil && num.Cmp(big.NewInt(0)) == 1 {
+ value = fmt.Sprintf("-%v", new(big.Int).Abs(num))
+ }
+ return value
+}
+
// getGenesisSpec ..
func getGenesi... | [getAllUndelegationPayoutTransactions->[isCommitteeSelectionBlock],specialBlockTransaction->[isCommitteeSelectionBlock],preStakingRewardBlockTransaction->[getBlockSignerInfo],String] | getGenesisSpec - get generators for log. | this is a generic function, can it be moved to some common lib? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.