patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1121,10 +1121,14 @@ test_gurt_hash_decref(void **state)
assert_int_equal(rc, 0);
assert_int_equal(entry->tl_ref, 2);
- /* Drop 20 refs, which should fail but remove and free the descriptor */
+ /* Drop 20 refs, which should fail but not remove or free the descriptor */
rc = d_hash_rec_ndecref(thtab, 20, tes... | [No CFG could be retrieved] | Create a minimum - size hash table and insert a new entry in the table. This function checks if the n - ary entry is in the hash table and if not it. | (style) line over 80 characters |
@@ -183,7 +183,7 @@
"test:watch": "<%= clientPackageManager %> test <%= optionsForwarder %>--watch --clearCache",
"webpack:dev": "<%= clientPackageManager %> run webpack-dev-server <%= optionsForwarder %>--config webpack/webpack.dev.js --inline --hot --port=9060 --watch-content-base --env.stats=minimal",
... | [No CFG could be retrieved] | The main function for the main application. clientPackageManager run test. | but this means you won't have the progress when running these outside of maven/gradle as well right? My goal was not to have the progress at all when running from maven gradle and have progress and stats when running via npm |
@@ -171,10 +171,16 @@ public abstract class AbstractTestRestApi {
String sparkHome = getSparkHome();
if (sparkHome != null) {
- sparkIntpSetting.getProperties().setProperty("master", "spark://" + getHostname() + ":7071");
+ if (System.getenv("SPARK_MASTER") != null) {
+ ... | [AbstractTestRestApi->[isNotAllowed->[responsesWith],isCreated->[responsesWith],getSparkHomeRecursively->[getSparkHomeRecursively],isNotFound->[responsesWith],isBadRequest->[responsesWith],isAllowed->[responsesWith],isForbiden->[responsesWith]]] | Starts up the server. Determines if the first one is spark or not. | Disable HiveContext, otherwise will hit the issue of multiple derby instance. |
@@ -104,10 +104,17 @@ class UserController extends RestController implements ClassResourceInterface, S
$em = $this->getDoctrine()->getManager();
$user = new User();
- $user->setContact($this->getContact($request->get('contact')['id']));
+ $user->setContact($this->getCon... | [UserController->[addUserGroup->[addUserGroup],addUserRole->[addUserRole],encodePassword->[encodePassword],patchAction->[isUsernameUnique]]] | Adds a new user to the user list. | `) {` should go into a new line. |
@@ -1179,6 +1179,15 @@ namespace System.Text
return this;
}
+ unsafe
+ {
+ Span<char> tempBuffer = stackalloc char[28]; // should be enough for all primitives
+ if (value.TryFormat(tempBuffer, out int charsWrittenToTmp, format: default,... | [StringBuilder->[MakeRoom->[AssertInvariants,CopyTo],CopyTo->[AssertInvariants,CopyTo],ReplaceInPlaceAtChunk->[CopyTo],ChunkEnumerator->[MoveNext->[MoveNext]],ExpandByABlock->[AssertInvariants],ToString->[AssertInvariants],Remove->[AssertInvariants,CopyTo],AssertInvariants]] | Append a formattable object to this buffer. | Why is unsafe necessary? |
@@ -802,7 +802,7 @@ static FnCallResult FnCallCountClassesMatching(EvalContext *ctx, FnCall *fp, Rli
ClassTableIteratorDestroy(iter);
}
- return (FnCallResult) { FNCALL_SUCCESS, { StringFromLong(count), RVAL_TYPE_SCALAR } };
+ return FnReturnF("%u", count);
}
/*********************************... | [bool->[VarRefDestroy,DataTypeToString,EvalContextVariableGet,strcspn,snprintf,VarRefParse,PrependItem,Log,HostKeyAddressUnknown],FnCallUserExists->[getpwuid,xstrdup,strcpy,Str2Uid,StringIsNumeric,RlistScalarValue,getpwnam],int->[DoubleFromString,RlistFromSplitRegex,VarRefDestroy,VarRefParseFromBundle,RlistDestroy,isal... | Count the number of classes matching the given arguments. if arg has any tags in tagset return it else return expr. | If count really is a long, as the old code appeared to believe, you should use "%ul" (and if it were a long long, you'd be using a woolly format specifier, in Norwegian). |
@@ -707,7 +707,7 @@ func WaitForABuild(c buildv1clienttyped.BuildInterface, name string, isOK, isFai
return err
}
// wait longer for the build to run to completion
- err = wait.Poll(5*time.Second, 10*time.Minute, func() (bool, error) {
+ err = wait.Poll(5*time.Second, 20*time.Minute, func() (bool, error) {
li... | [AssertFailure->[DumpLogs],AssertSuccess->[DumpLogs]] | WaitForABuild waits for a build object to match either isOK or isFailed conditions. CheckBuildSuccess returns true if the build has a sequence number and false if it has a. | i'm pretty sure the e2e framework itself is capping out individual tests at 15 mins. We need to stay under that because when the framework kills the test, we get zero information about the failure. @smarterclayton can you confirm the ginkgo test timeout? |
@@ -256,10 +256,14 @@ using DCPS::TimeDuration;
using DCPS::SystemTimePoint;
using DCPS::Serializer;
using DCPS::Encoding;
-using DCPS::ENDIAN_BIG;
-using DCPS::ENDIAN_LITTLE;
-const Encoding sedp_encoding(Encoding::KIND_XCDR1, ENDIAN_LITTLE);
+namespace {
+ const Encoding sedp_encoding(Encoding::KIND_XCDR1, DCPS... | [No CFG could be retrieved] | Check and assign locators in the given object. Return list of all objects. | It's unclear from the name what this is |
@@ -353,7 +353,7 @@ public class RealtimeIndexTask extends AbstractTask
nextFlush = new DateTime().plus(intermediatePersistPeriod).getMillis();
}
}
- catch (FormattedException e) {
+ catch (Exception e) {
log.warn(e, "unparseable line");
fireDepartmen... | [RealtimeIndexTask->[getQueryRunner->[getQueryRunner],run->[unannounceSegment->[unannounceSegment],announceSegment->[announceSegment],unannounceSegments->[unannounceSegments],announceSegments->[announceSegments],getVersion->[getVersion]],makeDatasource,makeTaskId]] | This method is called when a new task is created. announces a set of segments and releases a lock if it is acquired. This method is called from the main thread. It is called by the realtime metrics monitor if there is a next flush in the queue then we need to flush the queue and then. | same here, Exception may be too broad |
@@ -770,6 +770,11 @@ def dynamic_lstmp(input,
the bias is initialized zero. Default: None.
use_peepholes(bool): Whether to enable diagonal/peephole connections,
default `True`.
+ cell_clip(float): If provided the cell state is clipped
+ ... | [ctc_greedy_decoder->[topk],py_func->[PyFuncRegistry],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],nce->[_init_by_numpy_array],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d... | Dynamic LSTMP layer which does dynamic LSTMP projection. This function returns the hidden state of a dynamic_lstmp layer which supports variable - time Variable is a matrix with shape T x 4D D x 4D. Forget gate and output gate. | How about another name like `cell_clip_threshold`, and adding an assert `assert(cell_clip_threshold>=0)` ? |
@@ -190,6 +190,11 @@ func (c *Controller) runDeleteShootFlow(o *operation.Operation, errorContext *er
Fn: flow.TaskFn(botanist.SyncClusterResourceToSeed).RetryUntilTimeout(defaultInterval, defaultTimeout),
})
+ _ = g.Add(flow.Task{
+ Name: "Ensuring that ShootState exists",
+ Fn: flow.TaskFn(botanist.... | [updateShootStatusDeleteStart->[TryUpdateShootStatus,NewTime,Now,UTC,GardenCore,Get],runDeleteShootFlow->[ToExecute,DoIf,SkipIf,RequiredExtensionsExist,NewGraph,Compile,RetryUntilTimeout,HandleErrors,MinorError,SevereError,Errors,Add,Done,Error,HasAnnotation,New,Ok,NotOk,Errorf,Run,Key,TaskFn,HasDeletionTimestamp,Infof... | runDeleteShootFlow runs the delete shoot flow Check if Seed object for shooted seed has been deleted and if it has been deleted NamespaceInDeletion checks whether the resource in the shoot namespace has already been deleted or if This function checks whether the cluster is needed and if so it can be deployed. | Just to double check: Is it correct that no other task is depending on this one? |
@@ -13,9 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-import java.net.*;
-import java.io.*;
-import java.nio.channels.*;
+
import java.util.Properties;
public class MavenWrapperDownloader {
| [MavenWrapperDownloader->[main->[FileInputStream,getProperty,println,mkdirs,downloadFileFromURL,Properties,exit,printStackTrace,close,exists,File,getAbsolutePath,load],downloadFileFromURL->[getPasswordAuthentication->[PasswordAuthentication],setDefault,FileOutputStream,Authenticator,getenv,transferFrom,openStream,newCh... | Creates a MavenWrapperDownloader which downloads the MavenWrapper. jar from a given URL. Main method of the download. | Isn't this required for the Authenticator class in line 101? I don't think this file needs to be changed since it is autogenerated by the maven wrapper plugin |
@@ -75,13 +75,14 @@ public class KsqlContextTest {
queryStreams,
null,
... | [KsqlContextTest->[getQueryMetadata->[expectLastCall,mock,start,toString,PersistentQueryMetadata,asList],shouldRunSimpleStatements->[verify,andReturn,mock,replay,QueryId,emptyList,getQueryMetadata,KsqlContext,sql]]] | Gets the query metadata. | formatting of this is still a bit all over the place. Seems that checkstyle is not running against test classes |
@@ -43,6 +43,11 @@ import static org.hamcrest.Matchers.containsInAnyOrder;
import static org.hamcrest.Matchers.hasSize;
import static org.junit.Assert.assertEquals;
+/* @RequiresApi(api = Build.VERSION_CODES.O)
+ * java.nio.file.Path#
+ * java.nio.file.Paths#
+ * java.nio.file.Files#
+ */
@RunWith(AndroidJUnit4.cl... | [AnkiPackageExporterTest->[addTempFileToMediaAndNote->[getName,exists,IllegalStateException,println,PrintWriter,addFile,addNoteUsingBasicModel,createTempFile,format,close,dir,File,delete],missingFileInDeckExportDoesSkipsFile->[addTempFileToMediaAndNote,getExporterForDeckWithMedia,assertThat,getTargetContext,createTempD... | Returns true if the node has a node id and is not in the database. | We can fix this one |
@@ -41,6 +41,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
f.BoolVar(&cfg.BatchIterators, "querier.batch-iterators", false, "Use batch iterators to execute query, as opposed to fully materialising the series in memory. Takes precedent over the -querier.iterators flag.")
f.BoolVar(&cfg.IngesterStreaming,... | [Select->[Select,NewMergeSeriesSet,metadataQuery],LabelValues->[LabelValuesForLabelName,LabelName],metadataQuery->[Time,MetricsForLabelMatchers],RegisterFlags->[DurationVar,BoolVar,Lookup,IntVar],QueryableFunc,Querier,NewEngine] | RegisterFlags registers flags for the query metrics. | Hmm, minor nit. Should this be `0`? Making this `24h` could break deployments that use like `48h` chunk time :P This is an esoteric example, but the point being this modifies current behaviour. Am I being too pendantic? /cc @bboreham @tomwilkie |
@@ -293,7 +293,7 @@ namespace System.Net.Sockets
{
// Update the state if we've become connected after a non-blocking connect.
_isConnected = true;
- _rightEndPoint = _nonBlockingConnectRightEndPoint;
+ _rightEndPoint ??= _... | [Socket->[SetLingerOption->[SetLingerOption],SetIPProtectionLevel->[SetIPProtectionLevel],DoBind->[Bind],Send->[Send],ConnectAsync->[Connect,ConnectAsync,CanTryAddressFamily],Shutdown->[Shutdown],UpdateStatusAfterSocketError->[SetToDisconnected,UpdateStatusAfterSocketError],ReceiveAsync->[ReceiveAsync,Receive],GetSocke... | Get the next possible in the buffer. Returns an IPEndPoint. | In what situation will it be non-null? I'm wondering in what situation we previously would have overwritten it and now we won't... |
@@ -33,13 +33,17 @@ import java.nio.charset.UnsupportedCharsetException;
* encoder.addParam("recipient", "world");
* assert encoder.toString().equals("/hello?recipient=world");
* </pre>
+ *
* @see QueryStringDecoder
*/
public class QueryStringEncoder {
- private final String charsetName;
+ private fi... | [QueryStringEncoder->[toUri->[toString,URI],addParam->[checkNotNull,appendComponent,append],toString->[toString],appendComponent->[UnsupportedCharsetException,charAt,append,indexOf,encode,length],name,StringBuilder]] | Creates a new encoder that encodes a URL - encoded URI from a path string and key - Adds a parameter to the URI. | nit: could be bit more more compact as `= "0123456789ABCDEF".toCharArray();` |
@@ -284,6 +284,8 @@ namespace MGCB
if (arg.StartsWith("/@:") || arg.StartsWith("-@:"))
{
var file = arg.Substring(3);
+ Directory.SetCurrentDirectory(Path.GetDirectoryName(file));
+
var commands = File.ReadAllLines(file);
... | [CommandLineParameterAttribute->[Property,Field,Method],MGBuildParser->[ChangeType->[GetConverter,ConvertFromInvariantString],IsList->[PropertyType,FieldType,IsAssignableFrom],PreprocessorPropertyCollection->[Add,Equals,CurrentValue],IList->[GetValue],Preprocess->[Format,Add,Length,ReadAllLines,Count,IsNullOrEmpty,Inse... | This method processes the command line arguments and returns the output. This function finds the n - ary command and adds it to the output array. | I'm nervous at this sort of change. It has the potential to break every other file operation. First why was this not a problem before? We've been using MGCB on Mac/Linux for months now... at least a year on Windows. What is different about your case and what happens to all the previously working cases? |
@@ -166,7 +166,7 @@ public class RawMessage implements Serializable {
}
public DateTime getTimestamp() {
- return new DateTime(msgBuilder.getTimestamp()); // TODO PERFORMANCE object creation
+ return new DateTime(msgBuilder.getTimestamp(), DateTimeZone.UTC); // TODO PERFORMANCE object creation... | [RawMessage->[getTimestamp->[getTimestamp],SourceNode->[getId],getVersion->[getVersion],toString->[getRemoteAddress,getTimestamp,toString],decode->[RawMessage]]] | getTimestamp - Get the timestamp of the message. | Can this cause problems on the reading side of the journal? Just changing it from the local TZ to UTC might have consequences. |
@@ -75,11 +75,15 @@ foreach(_FRAMEWORK ${{{name}_FRAMEWORKS_FOUND{build_type_suffix}}})
list(APPEND {name}_LIBRARIES{build_type_suffix} ${{_FRAMEWORK}})
endforeach()
-foreach(_SYSTEM_LIB ${{{name}_SYSTEM_LIB{build_type_suffix}}})
+foreach(_SYSTEM_LIB ${{{name}_SYSTEM_LIBS{build_type_suffix}}})
list(APPEND ... | [No CFG could be retrieved] | Set all the missing - node - packages and missing - node - packages. | Not sure why dependencies are being added to this variable, it seems defined for self package things, not for the transitive dependencies values. |
@@ -408,7 +408,7 @@ public class Anki2Importer extends Importer {
if (srcScm.equals(dstScm)) {
// they do; we can reuse this mid
Model model = srcModel.deepClone();
- model.put("id", mid);
+ model.put("id", (long) mid);
model.... | [Anki2Importer->[_importCards->[_did],_mungeMedia->[_dstMediaData,_writeDstMedia,_srcMediaData],_dstMediaData->[_mediaData],_did->[_did],publishProgress->[publishProgress],_srcMediaData->[_mediaData]]] | Private method to find the next missing id in the source table. | interesting! I guess that was a confluence of your change at the same time as the "less long" PR |
@@ -1398,7 +1398,9 @@ class Variable(object):
# TODO(minqiyang): Support lod_level in dygraph mode
if in_dygraph_mode():
raise Exception("Dygraph model DO NOT supprt lod")
- return self.desc.lod_level()
+
+ if self.type == core.VarDesc.VarType.LOD_TENSOR:
+ return... | [cuda_places->[is_compiled_with_cuda,_cuda_ids],_varbase_creator->[convert_np_dtype_to_dtype_],Program->[_construct_from_desc->[Program,_sync_with_cpp,Block],__repr__->[__str__],parse_from_string->[Program,_sync_with_cpp,Block],to_string->[_debug_string_,to_string],_version->[_version],_prune_with_input->[Program,_sync... | Returns a function to create a new variable with a lod level. | self.type != core.VarDesc.VarType.LOD_TENSOR |
@@ -19,6 +19,10 @@ AutoUpdater.prototype.quitAndInstall = function () {
return app.quit()
}
+AutoUpdater.prototype.GetFeedURL = function () {
+ return this.updateURL
+}
+
AutoUpdater.prototype.setFeedURL = function (updateURL, headers) {
this.updateURL = updateURL
}
| [No CFG could be retrieved] | Create an instance of AutoUpdater that can be used to update a Cordova application. Error object and message are not supported. | I think this should be `getFeedURL`, lower case `G` |
@@ -192,14 +192,10 @@ class _SingleFileConfig(Config):
return self.configparser.has_section(section)
def has_option(self, section, option):
- return (self.configparser.has_option(section, option) or
- self.configparser.has_option(self._DEFAULT_SECTION, option))
+ return self.configparser.has_... | [_ChainedConfig->[get_source_for_option->[get_source_for_option,has_option],get_value->[has_section,get_value],sections->[sections],sources->[sources],has_option->[has_option],has_section->[has_section]],_SingleFileConfig->[get_source_for_option->[sources,has_option],get_value->[has_option,get],sections->[sections],has... | Returns True if the given section has the given option. | I thought the ini parser did the fallback to the DEFAULT section itself. Was that not actually the case? Does it only do interpolation? In which case, isn't this a major change in how our config parser works? |
@@ -88,6 +88,7 @@ Seq2SeqEncoder.register("rnn")(_Seq2SeqWrapper(torch.nn.RNN))
Seq2SeqEncoder.register("augmented_lstm")(_Seq2SeqWrapper(AugmentedLstm))
Seq2SeqEncoder.register("alternating_lstm")(_Seq2SeqWrapper(StackedAlternatingLstm))
Seq2SeqEncoder.register("stacked_bidirectional_lstm")(_Seq2SeqWrapper(StackedB... | [_Seq2SeqWrapper->[__call__->[from_params,Params],from_params->[pop_bool,as_dict,PytorchSeq2SeqWrapper,ConfigurationError,_module_class]],_Seq2SeqWrapper,debug,getLogger,is_available,register] | PytorchSeq2SeqWrapper for all - torch - seq2 - encoder. | Could you call this `bidirectional_transformer` - it's not intuitive that it would be bidirectional naturally. |
@@ -424,7 +424,7 @@ class Facture extends CommonInvoice
else // Old behaviour, if linked_object has only one link per type, so is something like array('contract'=>id1))
{
$origin_id = $tmp_origin_id;
- $ret = $this->add_object_linked($origin, $origin... | [Facture->[is_erasable->[getNextNumRef,getVentilExportCompta],getLinesArray->[fetch_lines],deleteline->[delete,fetch],insert_discount->[fetch],getSumDepositsUsed->[getSumDepositsUsed],update_percent->[update],info->[fetch],createFromOrder->[create],getSumCreditNotesUsed->[getSumCreditNotesUsed],get_prev_sits->[fetch],d... | create a new currency This function initializes the object with all necessary data. This function is called from the FACER_FACILITY_VIEW function. It This method is used to insert a new record in the database. | I don't understand this change. When we create an invoice, we can set the array linked_objects with key 'otherobject", 'idofotherobject', so dolibarr can create link during creation. So we should have here $origin and $originid coming from the loop on each element of $this->linked_objects Name of var is not clever. Sho... |
@@ -108,9 +108,11 @@ class WelcomePage extends AbstractWelcomePage {
className = { `welcome ${showAdditionalContent
? 'with-content' : 'without-content'}` }
id = 'new_welcome_page'>
+ <div className = 'welcome-watermark'>
+ ... | [No CFG could be retrieved] | A component that renders a single header. Displays a form with a button to enter a room. | Not introduced by this PR, but do we keep the old welcome page somewhere? Why do we call it new_welcome_page? :) |
@@ -28,7 +28,8 @@ EXCLUDED_PACKAGE_VERSIONS = {
'azure-storage-file-datalake': '12.2.0b1',
'azure-communication-identity': '1.0.0',
'azure-communication-phonenumbers': '1.0.0',
- 'azure-communication-sms': '1.0.0'
+ 'azure-communication-sms': '1.0.0',
+ 'azure-search-documents': '11.2.0b3',
}
... | [git_checkout_tag->[info,run_check_call,format],git_checkout_branch->[info,run_check_call,format,error],get_release_tag->[PyPIClient,error,parse,len,str,format,get_ordered_versions,info,reverse],clone_repo->[error,run_check_call,isdir,format,info,exit],getLogger] | Get release tag for a package. | To make sure we are on same page, we want to skip 11.0.0, 11.1.0 and all betas. We want to start with 11.2.0. Is this correct? |
@@ -87,7 +87,7 @@ public class VictoryTest {
final String error =
moveDelegate.move(libya.getUnits().getUnits(), gameData.getMap().getRoute(libya, britishCongo));
moveDelegate.end();
- assertTrue(error.equals(MoveValidator.NOT_ALL_UNITS_CAN_BLITZ));
+ assertEquals(error, MoveValidator.NOT_ALL_U... | [VictoryTest->[testFuelCostAndFuelFlatCost->[changeOwner,assertTrue,create,addUnits,getQuantity,start,advanceToStep,getRoute,getUnits,end,performChange,setDelegateBridgeAndPlayer,assertEquals,startsWith,move],testNotEnoughMultipleResourcesToPurchase->[assertNotNull,purchase,advanceToStep,start,getProductionRule,subtrac... | Test if there is no blitz through mountain. | The argument order should be reversed |
@@ -35,6 +35,10 @@ class AccountRegister(ModelMutation):
description="Fields required to create a user.", required=True
)
+ requires_confirmation = graphene.Boolean(
+ description="Informs whether users need to confirm their email address."
+ )
+
class Meta:
descriptio... | [AccountDelete->[perform_mutation->[clean_instance]],AccountRequestDeletion->[perform_mutation->[AccountRequestDeletion]],AccountRegister->[save->[save],Arguments->[AccountRegisterInput]],AccountUpdate->[Arguments->[AccountInput]]] | Create a new user object. Update the account of the logged - in user. | Let's add `required=True` since this field will always return some boolean value and never a `null`. |
@@ -10,4 +10,13 @@ module Helpers
end
end
end
+
+ # Reset the repos to empty
+ def destroy_repos
+ conf = Hash.new
+ conf['IS_REPOSITORY_ADMIN'] = true
+ conf['REPOSITORY_STORAGE'] = MarkusConfigurator.markus_config_repository_storage
+ conf['REPOSITORY_PERMISSION_FILE'] = 'dummyfile'
+ ... | [create_ta_memberships->[each,create]] | Create tas memberships for groupings. | Line is too long. [84/80] |
@@ -265,7 +265,7 @@ size_t rand_drbg_get_nonce(RAND_DRBG *drbg,
return 0;
memset(&data, 0, sizeof(data));
- pool = rand_pool_new(0, min_len, max_len);
+ pool = rand_pool_new(0, 0, min_len, max_len);
if (pool == NULL)
return 0;
| [RAND_DRBG->[RAND_DRBG_set,RAND_DRBG_instantiate,RAND_DRBG_free,RAND_DRBG_secure_new_ex,rand_drbg_enable_locking],RAND_DRBG_get0_private->[OPENSSL_CTX_get0_private_drbg],RAND_DRBG_get0_public->[OPENSSL_CTX_get0_public_drbg],RAND_DRBG_secure_new->[RAND_DRBG_secure_new_ex],void->[RAND_DRBG_free],RAND_DRBG_bytes->[RAND_DR... | Get a random nonce from the random number generator. | Are nonces secret? I'm not sure without more thought. I'd err conservatively if there is any doubt. @davidmakepeace @slontis any thoughts? |
@@ -167,14 +167,14 @@ func (c Config) MinimumServiceDuration() time.Duration {
return c.viper.GetDuration(EnvVarName("MinimumServiceDuration"))
}
-// EthGasBumpThreshold represents the maximum amount a transaction's ETH amount
-// should be increased in order to facilitate a transaction.
+// EthGasBumpThreshold re... | [Set->[Set],Generate->[RootDir],tlsDir->[RootDir],CreateProductionLogger->[LogLevel,RootDir,CreateProductionLogger,LogToDisk,JSONConsole],KeyFile->[TLSKeyPath,tlsDir],SessionOptions->[SecureCookies],CertFile->[TLSCertPath,tlsDir],KeysDir->[RootDir],Set] | MinimumServiceDuration returns the minimum service duration for the given configuration. | Maybe note that the measurement for the interval is number of blocks. |
@@ -75,7 +75,7 @@ public abstract class BaseBinaryCipherExecutor extends AbstractCipherExecutor<by
@Override
public byte[] encode(final byte[] value) {
try {
- final Key key = new SecretKeySpec(this.encryptionSecretKey.getBytes(StandardCharsets.UTF_8),
+ final Key key = new Secr... | [BaseBinaryCipherExecutor->[encode->[getMessage,RuntimeException,error,AesCipherService,sign,getBytes,SecretKeySpec],decode->[RuntimeException,getMessage,AesCipherService,getBytes,verifySignature,SecretKeySpec],generateOctetJsonWebKeyOfSize->[getMessage,RuntimeException,error,toString,generateJwk,toParams],generateOcte... | Encode the given value. | Use `EncodingUtils` please. |
@@ -633,8 +633,6 @@ public class ServerModel extends Observable implements IConnectionChangeListener
serverLauncher.connectionLost(node);
return;
}
- notifyLobby(
- (lobbyConnection, gameId) -> lobbyConnection.playerLeft(gameId, node.getPlayerName()));
// we lost a node. Remove the pla... | [ServerModel->[connectionRemoved->[takePlayerInternal,notifyLobby],setPlayerEnabled->[takePlayerInternal],disablePlayer->[setPlayerEnabled],getServerProps->[cancel],createServerMessenger->[cancel,gameDataChanged],getAvailableGames->[getAvailableGames],enablePlayer->[setPlayerEnabled],getLauncher->[disallowRemoveConnect... | Notify all players that a connection has been lost. | This return statement was the culprit, for in progress games `serverLauncher != null` |
@@ -105,7 +105,7 @@ class TestUserProfile(TestCase):
assert user.auth_id
assert user.auth_id != old_auth_id
assert user.fxa_id == '0824087ad88043e2a52bd41f51bbbe79'
- assert user.display_name is None
+ assert user.display_name == ''
assert user.homepage == ''
a... | [TestUserHistory->[test_user_find->[find_users],test_user_find_multiple->[find_users]],TestUserProfile->[test_delete_with_related_content_exclude_addons_with_other_devs->[setup_user_to_be_have_content_disabled]]] | Test deletion of a user. | Why did this change from `None` to `''`? |
@@ -312,7 +312,7 @@ def run_eval(valid_worlds, opt, datatype, max_exs=-1, write_log=False):
reports, tasks, micro=opt.get('aggregate_micro', True)
)
- metrics = '{}:{}'.format(datatype, report)
+ metrics = f'[ eval completed in {round(timer.time(), 2)}s ]\n{datatype}:{report}'
print(metrics)
... | [TrainLoop->[train->[_maybe_load_eval_worlds,save_model,validate,log,run_eval],_average_dicts->[_average_dicts],validate->[_maybe_load_eval_worlds,_save_best_valid,save_model,run_eval],_sync_training_metrics->[_average_dicts],_nice_format->[_nice_format],log->[_nice_format,_compute_eta,_cleanup_inaccurate_metrics,_sync... | Evaluate on validation and test data. with optional parameters. | i'm all for f-strings but this is just abusive... |
@@ -335,8 +335,7 @@ namespace System.Dynamic.Tests
int arg10) => 11;
}
- // We're not testing compilation, but we do need Reflection.Emit for the test
- [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotLinqExpressionsBuiltWithIsInterpretingOnly))]
+ ... | [InvokeMemberBindingTests->[GenericMethod->[TellType],ByRef->[TryParseInt],MethodHiding->[Method],NoArgumentMatch->[Method],ManyArities->[GetValue,GetValue2]]] | Tests that the dynamic values are the same. Tests that d contains all values in order to be used in the D - Map. | This was probably hitting some .NET Native specific issues with dynamic keyword. I don't see it using Ref.Emit anywhere so leaving like this. |
@@ -53,12 +53,12 @@ namespace Microsoft.Extensions.Configuration
private void Load(bool reload)
{
- IFileInfo file = Source.FileProvider?.GetFileInfo(Source.Path);
+ IFileInfo? file = Source.FileProvider?.GetFileInfo(Source.Path ?? string.Empty);
if (file == null |... | [FileConfigurationProvider->[Dispose->[Dispose],Load->[ToString,Load]]] | Load if necessary. | Why is this using a different strategy than the above change? Here we are checking for null and passing in empty. Above we are suppressing the `null` warnings. |
@@ -184,5 +184,17 @@ if (currentPlatformSupportsAppIndicator()) {
process.env.XDG_CURRENT_DESKTOP = 'Unity'
}
+// Quit when all windows are closed and no other one is listening to this.
+app.on('window-all-closed', () => {
+ if (app.listenerCount('window-all-closed') === 1) {
+ app.quit()
+ }
+})
+
+const { ... | [No CFG could be retrieved] | Load main. js and transfer control to C ++. | Your point in the call this morning gave me some thoughts on this, maybe there should be an explicit way to opt-out of this default without setting an empty menu. E.g. Setting `process.noDefaultMenu` to `true` (similar to our `process.noAsar`) |
@@ -178,6 +178,10 @@
// customer must be logged in to browse
return TEXT_AUTHORIZATION_PENDING_PRICE;
break;
+ case ((int)$_SESSION['customers_authorization'] == 2):
+ // customer is logged in and was changed to must be approved to see prices
+ return TEXT_AUTHORIZATION_PEN... | [zen_get_buy_now_qty->[in_cart_mixed],zen_get_products_price_is_free->[Execute],zen_get_products_discount_price_qty->[in_cart_mixed_discount_quantity,Execute],zen_get_products_actual_price->[Execute],zen_get_products_quantity_order_min->[Execute],zen_update_salemaker_product_prices->[MoveNext,Execute],zen_get_products_... | Returns the output price of a specific product limit 1 limit 2 limit 3 limit 4 limit 5 limit 5 limit 5 limit 5 limit 5 ZeDISCOUNT = 1 This function returns the price of a node in the order of the product. | `break` is not necessary when returning early - the rest of this should be cleaned up, preferably to remove the switch/case. |
@@ -157,6 +157,7 @@ def diag_embed(*args):
@deprecated(
since="2.0.0",
update_to="paddle.nn.utils.remove_weight_norm",
+ level=1,
reason="remove_weight_norm in paddle.nn will removed in future")
def remove_weight_norm(*args):
'''
| [diag_embed->[diag_embed],remove_weight_norm->[remove_weight_norm],weight_norm->[weight_norm]] | remove_weight_norm is a wrapper for remove_weight_norm. | will be removed |
@@ -1,6 +1,9 @@
# :reek:TooManyMethods
# :reek:RepeatedConditional
class AccountShow # rubocop:disable Metrics/ClassLength
+ include ActionView::Helpers::TagHelper
+ include LocalTimeHelper
+
attr_reader :decorated_user, :decrypted_pii, :personal_key
def initialize(decrypted_pii:, personal_key:, decorated_... | [AccountShow->[manage_personal_key_partial->[blank?],password_reset_partial->[present?],piv_cac_partial->[enabled?],personal_key_partial->[present?],header_personalization->[email,present?,first_name],verified_account_badge_partial->[identity_verified?],totp_partial->[enabled?],piv_cac_content->[t,enabled?],backup_code... | Initializes the object with the values of decrypted_pii personal_key and decorated_user. | Looking back over this and realizing I actually need to pull out these helpers. |
@@ -221,7 +221,9 @@ public class TestDeleteWithSlowFollower {
}
Assert.assertNotNull(follower);
Assert.assertNotNull(leader);
- // shutdown the slow follower
+ //ensure that the chosen follower is still a follower
+ Assert.assertTrue(ContainerTestHelper.isRatisFollower(follower, pipeline));
+ ... | [TestDeleteWithSlowFollower->[shutdown->[shutdown]]] | Test delete key with slow follower. This method is used to close a container. check if there are no pending deletion blocks on the leader and if so read the chunk and. | Do we want to fail the test if `follower` is no longer a follower, or should we just ignore test result in that case? If the latter, it may be better to change this to `Assume.assumeTrue`. |
@@ -102,6 +102,7 @@ export class AmpAutoAds extends AMP.BaseElement {
adNetwork.isResponsiveEnabled()
).run();
const stickyAdAttributes = /** @type {!JsonObject} */ (Object.assign(
+ {},
attributes,
getAttributesFromConfigObj(configObj, Attributes.STICKY_AD_AT... | [No CFG could be retrieved] | Selects into the use responsive ads for sizing in a responsive experiment branch. Returns a promise that resolves to the given object. | Should probably do dict({}) instead of {} so that the type is JsonObject will require importing dict: import {dict} from '../../../src/utils/object'; |
@@ -552,6 +552,7 @@ class Jetpack_Options {
'jpo_site_type',
'jpo_homepage_format',
'jpo_contact_page',
+ 'jetpack_extensions_exclusions',
);
}
| [Jetpack_Options->[get_raw_option->[get_var,prepare],delete_raw_option->[query,prepare],update_raw_option->[get_var,query,prepare]]] | This method returns an array of all WordPress options that can be used in a Jetpack This method is read only from jetpack. xml. | Nit: I'd likely go with `jetpack_excluded_extensions` as this would make the option name more consistent with our naming scheme, which often is `(jetpack_)?(ADJECTIVE_)?(NOUN)`. Definitely not a requirement and no hard feelings about this one (I assume the option name is already decided), just wanted to share my $0.02.... |
@@ -1485,6 +1485,10 @@ update_cancel(struct vos_io_context *ioc)
/* Cancel NVMe reservations */
vos_publish_blocks(ioc->ic_cont, &ioc->ic_blk_exts, false,
VOS_IOS_GENERIC);
+
+ /* Abort dedup entries */
+ vos_dedup_process(vos_cont2pool(ioc->ic_cont), &ioc->ic_dedup_entries,
+ true /* abort */);
}
st... | [No CFG could be retrieved] | region Resource Management functions vos_ts_set_get_entry_from_vos_ts_. | (style) 'dedup' may be misspelled - perhaps 'dedupe'? (style) 'dedup' may be misspelled - perhaps 'dedupe'? |
@@ -365,6 +365,8 @@ void MapBlock::serialize(std::ostream &os, u8 version, bool disk, int compressio
FATAL_ERROR_IF(version < SER_FMT_VER_LOWEST_WRITE, "Serialisation version error");
+ std::ostringstream oss(std::ios_base::binary);
+ std::ostream &os = version >= 29 ? oss : out;
// First byte
u8 flags = 0;
... | [No CFG could be retrieved] | Allocate a global id for a block and write it to the output stream. region Generator methods. | Rename suggestion: * `oss` -> `os_raw` * `out` -> `os_compressed` |
@@ -29,6 +29,7 @@ from typing import Any, List, Union, Generic, TypeVar
from azure.core.pipeline import PipelineRequest, PipelineResponse, PipelineContext
from azure.core.pipeline.policies import AsyncHTTPPolicy, SansIOHTTPPolicy
+from azure.core.common import ImplPoliciesType, PoliciesType
AsyncHTTPResponseType... | [AsyncPipeline->[__aexit__->[__aexit__],__aenter__->[__aenter__],run->[send,_AsyncTransportRunner],__init__->[_AsyncTransportRunner,_SansIOAsyncHTTPPolicyRunner]],_AsyncTransportRunner->[send->[send]],_SansIOAsyncHTTPPolicyRunner->[send->[send]]] | This function will deal in a software with all of the possible permissions and conditions defined for the Async implementation of the SansIO policy. | AsyncHTTPResponseType is already defined in azure.core.common |
@@ -466,6 +466,15 @@ var config = {
// downloadAppsUrl: 'https://docs.example.com/our-apps.html'
// },
+ // Options related to the remote participant menu.
+ // remoteVideoMenu: {
+ // // If set to true the 'Kick out' button will be disabled.
+ // disableKick: true
+ // },
+
+ /... | [No CFG could be retrieved] | The interval in milliseconds at which analytics events will be sent. The function that handles the undocumented settings used in lib - jitsi - me. | Why is this not part of the remoteVideoMenu thing? |
@@ -46,7 +46,8 @@ public class ContainerLocator {
.flatMap(container -> getMappedPort(container, port)
.flatMap(containerPort -> Optional.ofNullable(containerPort.getPublicPort())
.map(port -> {
- ... | [ContainerLocator->[getMappedPort->[findAny],locateContainer->[getPublicPort,ContainerAddress,getIp,flatMap,infof,getImage,empty,getUrl,getId,map],lookup->[findAny],getPublicPort,getPrivatePort,getLogger,equals]] | Locate a container by name and port. | Does that work when you use a custom network? |
@@ -74,4 +74,12 @@ public class MetastoreTest {
Assert.assertNull(structuredDataSource4);
}
+ @Test
+ public void shouldGetTheCorrectSourceNameForTopic() {
+ final StructuredDataSource structuredDataSource = metaStore.getSourceForTopic("TEST2");
+ assertThat(structuredDataSource, instanceOf(KsqlTable.... | [MetastoreTest->[init->[getNewMetaStore,TestFunctionRegistry],testTopicMap->[assertNotNull,getTopic,KsqlTopic,putTopic,KsqlJsonTopicSerDe,assertNull],testDelete->[assertNotNull,deleteSource,getSchema,KsqlStream,putSource,assertNull,getTimestampExtractionPolicy,getKsqlTopic,getSource,getKeyField],testStreamMap->[assertN... | Test deletion of order by key field. | We should add a case for a topic that doesn't have a stream created for it yet. |
@@ -0,0 +1,11 @@
+module Notifications
+ class RemoveAllByActionJob < ApplicationJob
+ queue_as :remove_all_by_action_notifications
+
+ def perform(notifiable_ids, notifiable_type, action, service = Notifications::RemoveAllByAction)
+ return unless %w[Article Comment Mention].include?(notifiable_type)
+
+ ... | [No CFG could be retrieved] | No Summary Found. | @rhymes @lightalloy I ended up adding the guard clause in the job, and used `return` instead of `raise` so the job wouldn't attempt to run multiple times. But maybe it should fail loudly? Also, I ended up adding it in the job, but maybe the logic should be in the service itself? |
@@ -3,7 +3,7 @@ class BadgesController < ApplicationController
# No authorization required for entirely public controller
def show
- @badge = Badge.find_by_slug(params[:slug])
+ @badge = Badge.find_by_slug(params[:slug]) || not_found
set_surrogate_key_header "badges-show-action"
end
end
| [BadgesController->[show->[set_surrogate_key_header,find_by_slug],before_action]] | shows a single badge. | I suggest `@badge = Badge.find_by!(slug: params[:slug])` . Using the bang method will raise `ActiveRecord::RecordNotFound` which makes more sense. The exception will be caught by rails 404 page will be rendered. |
@@ -102,6 +102,16 @@ class OffsetRestrictionTracker(RestrictionTracker):
def current_watermark(self):
return self._current_watermark
+ def current_progress(self):
+ with self._lock:
+ if self._current_position is None:
+ fraction = 0.0
+ else:
+ fraction = (
+ float(self... | [OffsetRange->[split->[OffsetRange]],OffsetRestrictionTracker->[defer_remainder->[checkpoint],checkpoint->[OffsetRange],__init__->[OffsetRange]]] | Returns the current watermark. | Assert (self._range.stop > self._range.start) before this ? |
@@ -376,7 +376,7 @@ opthelp:
/* No extra arguments. */
argc = opt_num_rest();
- if (argc != 0)
+ if (argc != 0 || (verify && in_fname == NULL))
goto opthelp;
if (parent_config != NULL) {
| [CONF->[app_load_config_bio,BIO_s_mem,BIO_new,CONF_modules_load,NCONF_free,write_config_header,BIO_free,write_config_fips_section],int->[app_load_config,OSSL_LIB_CTX_load_config,OPENSSL_buf2hexstr,NCONF_get_string,memcmp,EVP_MAC_CTX_get_mac_size,NCONF_free,print_mac,BIO_read,EVP_MAC_update,strcmp,BIO_printf,OPENSSL_hex... | Main entry point for the fips - install command. Parse the options and check for missing security checks. Duplicate a module file. errors - check if the missing configuration file is present in the config file CHECK - FREE ALL resources in system. | It not a big deal, but I am not sure why we couldnt use stdin if in_fname is NULL (i.e. blah.txt | fipsinstall) app_load_config would use that if the filename is NULL inside the verify(). We could delete this check and change the docs back? |
@@ -22,6 +22,12 @@ namespace System.Runtime.InteropServices.JavaScript
{
SetHandle(jsHandle);
AnyRefHandle = GCHandle.Alloc(this, ownsHandle ? GCHandleType.Weak : GCHandleType.Normal);
+ if (!ownsHandle)
+ {
+ bool _addRefSucceeded = false;
+ ... | [AnyRef->[Release->[Assert,Decrement],AddRef->[Increment],FreeGCHandle->[Free],SetHandle,Normal,Weak,Alloc]] | Free GCHandle. | Where is the DangerousRelease counterpart? |
@@ -115,9 +115,14 @@ public class HoodieLogFormatReader implements HoodieLogFormat.Reader {
inputStream.seek(currentPos);
log.info("Next available block in " + logFile + " starts at " + nextBlockOffset);
int corruptedBlockSize = (int) (nextBlockOffset - currentPos);
- byte[] content = new byte[corrupt... | [HoodieLogFormatReader->[close->[close],next->[hasNext],hasNext->[readBlock]]] | This method is used to create a corrupt block. | I do think this needs to be pushed into blocks still.. I can't think of any other way for us to decouple how blocks are physically laid out for each log version.. i.e parts after magic, length, type, version.. |
@@ -358,13 +358,14 @@ void Hud::drawLuaElements(const v3s16 &camera_offset)
switch (e->type) {
case HUD_ELEM_TEXT: {
irr::gui::IGUIFont *textfont = font;
- unsigned int font_size = g_fontengine->getDefaultFontSize();
+ unsigned int default_font_size = g_fontengine->getDefaultFontSize();
+ unsigned ... | [No CFG could be retrieved] | Draws all the HUD elements in the system. the actual scaling. | I don't think the check on L367 is needed. `g_fontengine` is cached, hence it should return `font` anyway if the default values are provided. |
@@ -1001,9 +1001,15 @@ class RaidenService(Runnable):
state_changes: List[StateChange] = list()
for event in poll_result.events:
+ # Important: `blockchainevent_to_statechange` has to be called
+ # with the block of the current confirmed head! An unconfirmed
+ ... | [RaidenService->[handle_and_track_state_changes->[add_pending_greenlet],_poll_until_target->[_log_sync_progress,handle_and_track_state_changes],start_mediated_transfer_with_secret->[PaymentStatus,handle_and_track_state_changes,async_start_health_check_for,matches,initiator_init],stop->[stop],_start_alarm_task->[start],... | Poll blockchain events up to target_block_number. This method is called when a block has received a new block number event. It is called This function is called when a new block has not yet been mined and has not yet. | This was the bug, the value `poll_result.polled_block_number` could be old enough to be pruned. The fix is to use the confirmed head instead. |
@@ -122,7 +122,7 @@ static inline void _blendif_lab_a(const float *const restrict pixels, float *con
{
for(size_t x = 0, j = 0; x < stride; x++, j += DT_BLENDIF_LAB_CH)
{
- mask[x] *= _blendif_compute_factor(pixels[j + 1] / 128.0f, invert_mask, parameters);
+ mask[x] *= _blendif_compute_factor(pixels[j + 1... | [No CFG could be retrieved] | Private functions for blendif_lab_a and blendif_lab_b. Private functions for the blending if function. | shouldn't that be 255 ? |
@@ -332,6 +332,16 @@ export class ActionService {
const element = dev().assertElement(event.target);
this.trigger(element, name, event, ActionTrust.HIGH);
});
+ } else if (name == 'focus') {
+ this.root_.addEventListener(name, event => {
+ const element = dev().assertElement(even... | [No CFG could be retrieved] | Adds a debounced action to the action target that will receive all designated actions. Triggers the specified event on the specified target element. | There is one tricky thing we need to figure out: `focus`/ `blur` can happen on elements without user interaction in certain cases such as using `#idOfInput` in Url or using `autofocus` attribute . We should either not fire the events in those cases or fire it with "Low-trust" (I vote for former). I am not sure how we c... |
@@ -612,6 +612,9 @@ void Server::handleCommand_Init2(NetworkPacket* pkt)
m_clients.event(pkt->getPeerId(), CSE_GotInit2);
u16 protocol_version = m_clients.getProtocolVersion(pkt->getPeerId());
+ std::string lang;
+ if (pkt->getSize() > 0)
+ *pkt >> lang;
/*
Send some initialization data
| [handleCommand_Interact->[process_PlayerPos],handleCommand_PlayerPos->[process_PlayerPos]] | Handle a command that requires to be initialized from a client. | ~~this defaults to `""`, right?~~ it does |
@@ -1460,6 +1460,9 @@ public class Queue extends ResourceController implements Saveable {
// allocate buildable jobs to executors
for (BuildableItem p : new ArrayList<BuildableItem>(
buildables)) {// copy as we'll mutate the list in the loop
+ if (p.task ins... | [Queue->[BuildableItem->[leave->[all],enter->[all,add],isStuck->[getEstimatedDuration,getAssignedLabel],getCauseOfBlockage->[isEmpty,getAssignedLabel,isBlockedByShutdown]],getApproximateItemsQuickly->[get],isBuildBlocked->[isBuildBlocked],getItems->[add],withLock->[call],isEmpty->[isEmpty],LockedJUCCallable->[call->[wi... | Maintains the queue. This method is called from the QueueSorter. DEFAULT_BLOCKED_ITEM_COMPARATOR JENKINS - 28926 check if there is a sequence of comments in a tabpanel. | Where do we allocate tasks to executors? Seems features like Load balancers or build blockers will never work for flyweight tasks after the change |
@@ -31,7 +31,7 @@
var tx = (InMemoryOutboxTransaction) transaction;
tx.Enlist(() =>
{
- if (!storage.TryAdd(message.MessageId, new StoredMessage(message.MessageId, message.TransportOperations.ToList())))
+ if (!storage.TryAdd(message.MessageId, new St... | [InMemoryOutboxStorage->[StoredMessage->[Equals->[Equals],GetHashCode->[GetHashCode]]]] | Store a message in the storage. | Should be able to remove this `ToArray()` call since `TransportOperations` is already an array now, or is there some reason you need a copy of the collection? |
@@ -185,7 +185,7 @@ public class ItemsTest {
JenkinsRule.WebClient wc = wc(r);
wc.getOptions().setRedirectEnabled(false);
wc.getOptions().setThrowExceptionOnFailingStatusCode(false); // redirect perversely counts as a failure
- WebResponse webResponse = ... | [ItemsTest->[overwriteNonexistentTarget->[overwriteTargetSetUp],getAllItems->[getAllItems],overwriteHiddenTarget->[cannotOverwrite],overwriteKnownTarget->[cannotOverwrite],allItems->[allItems],overwriteVisibleTarget->[cannotOverwrite],cannotOverwrite->[overwriteTargetSetUp]]] | Create a new item in the given target. | BTW we could probably introduce `WebClient.postTo(String)` (or something) as a convenience. |
@@ -43,6 +43,9 @@ public interface IpAddressManager {
"If true, when account has dedicated public ip range(s), once the ips dedicated to the account have been consumed ips will be acquired from the system pool",
true, ConfigKey.Scope.Account);
+ static final ConfigKey<Boolean> RulesContinueOnErro... | [No CFG could be retrieved] | Imports a single config key. This method is called when a user has failed to associate an IP address with a user. | The default for RulesContinueOnError is set to true, means the errors will be ignored. Shouldn't the default be set to false ? |
@@ -160,9 +160,9 @@ class DomainUtilities(object):
print("::[--Domain Utilities-]:: Add boundary nodes to fluid domains ")
try:
- import KratosMultiphysics.SolidMechanicsApplication as KratosSolid
+ import KratosMultiphysics.PfemFluidDynamicsApplication as PfemF... | [DomainUtilities->[BuildModelPartBoundary->[BuildModelPartBoundary]]] | Adds boundary nodes to all fluid domains. | Just wondering if the changes in this file might affect other users of the `DelaunayMeshingApplication`. |
@@ -222,9 +222,12 @@ class ETagMismatchError(DvcException):
class FileMissingError(DvcException):
- def __init__(self, path):
+ def __init__(self, path, hint=None):
self.path = path
- super().__init__(f"Can't find '{path}' neither locally nor on remote")
+ self.hint = "" if hint is Non... | [GitHookAlreadyExistsError->[__init__->[format_link,super,format]],DownloadError->[__init__->[super]],FileMissingError->[__init__->[super]],RecursiveAddingWhileUsingFilename->[__init__->[super]],CircularDependencyError->[__init__->[super,format,isinstance]],CheckoutErrorSuggestGit->[__init__->[super]],NoPlotsError->[__... | Initialize a object. | self.hint is not used |
@@ -65,6 +65,8 @@ class SlidingEstimator(BaseEstimator, TransformerMixin):
X.shape = (n_samples, n_features_1, n_features_2, n_tasks)
y : array, shape (n_samples,) | (n_samples, n_targets)
The target values.
+ **fit_params : dict of string -> object
+ Parameters to p... | [_sl_transform->[transform],_gl_transform->[transform],GeneralizingEstimator->[decision_function->[_transform],score->[_check_Xy],predict_proba->[_transform],_transform->[_check_Xy,_check_method],transform->[_transform],predict->[_transform]],SlidingEstimator->[decision_function->[_transform],score->[_check_Xy],predict... | Fit a series of independent estimators to the dataset. | just `dict` is fine here, the fact that they get passed is clear in the description |
@@ -43,7 +43,7 @@ namespace Dynamo.Search.SearchElements
this.functionDescriptor = functionDescriptor;
Name = functionDescriptor.UserFriendlyName;
-
+
if (functionDescriptor.IsOverloaded)
{
var parameters = new StringBuilder();
| [ZeroTouchSearchElement->[NodeModel->[IsVarArg],GetIconName->[IsOverloaded,IsNullOrEmpty,FunctionName,QualifiedName,TypedParametersToString,NormalizeAsResourceName],GetIconName,UserFriendlyName,IsOverloaded,Count,IsBuiltIn,Add,MangledName,Format,Append,Category,Description,Select,Packaged,ZeroTouch,Join,Name,GetFileNam... | Creates a ZeroTouchSearchElement object which is the base name of the entry which consists of. | Looks like this file can be reverted. |
@@ -966,10 +966,10 @@ func throttleEvents(ctx context.Context, throttleDuration time.Duration, pool *s
return eventsChanBuffered
}
-func isInternalService(forwardTo v1alpha1.HTTPRouteForwardTo) bool {
- return forwardTo.ServiceName == nil &&
- forwardTo.BackendRef != nil &&
- forwardTo.BackendRef.Kind == traefik... | [makeGatewayStatus->[New,Now,Append],createGatewayConf->[makeGatewayStatus,fillGatewayConf,UpdateGatewayStatus,Errorf],entryPointName->[FormatInt,HasSuffix,Errorf],fillGatewayConf->[Normalize,Sprintf,GetHTTPRoutes,Now,SelectorFromSet,entryPointName],newK8sClient->[FromContext,Infof,Sprintf,Parse,Errorf,Getenv],Provide-... | isInternalService returns true if the given route forward - to is an internal service. | I do not understand that change. Why would we make a more complicated signature given that serviceName and backendRef are both fields of the same object? |
@@ -231,10 +231,16 @@ class Version(OnChangeMixin, ModelBase):
return ''
return reverse('addons.versions', args=[self.addon.slug, self.version])
- def delete(self):
+ def delete(self, hard=False):
log.info(u'Version deleted: %r (%s)' % (self, self.id))
amo.log(amo.LOG.DEL... | [update_status->[update_status],Version->[is_public->[is_public],flush_urls->[flush_urls],transformer->[rollup,_compat_map],is_allowed_upload->[compatible_platforms],from_upload->[from_upload],transformer_activity->[rollup],VersionManager],watch_source->[save],inherit_nomination->[reset_nomination_time],License->[Licen... | Get the url path of the version. | I'm unsure if `force` would be a better name which is used imho quite often to describe some action that really really has to be done. (not sure if I described my intention clearly though :smile:) |
@@ -248,7 +248,8 @@ public abstract class HoodieBackedTableMetadataWriter implements HoodieTableMeta
if (!latestMetadataInstant.isPresent()) {
LOG.warn("Metadata Table will need to be re-bootstrapped as no instants were found");
rebootstrap = true;
- } else if (datasetMetaClient.getActiveT... | [HoodieBackedTableMetadataWriter->[syncFromInstants->[initTableMetadata],close->[close],bootstrapFromFilesystem->[initTableMetadata]]] | Checks if the metadata table needs to be bootstrapped. | Modify to avoid re-bootstrap for empty table. |
@@ -626,9 +626,14 @@ public class HoodieCopyOnWriteTable<T extends HoodieRecordPayload> extends Hoodi
private Boolean deleteFileAndGetResult(String deletePathStr) throws IOException {
Path deletePath = new Path(deletePathStr);
logger.debug("Working on delete path :" + deletePath);
- boolea... | [HoodieCopyOnWriteTable->[getUpsertPartitioner->[UpsertPartitioner],deleteFilesFunc->[PartitionCleanStat,addDeleteFilePatterns,addDeletedFileResult],UpsertPartitioner->[assignInserts->[addUpdateBucket,BucketInfo,InsertBucket],addUpdateBucket->[BucketInfo],getSmallFiles->[SmallFile]],handleInsertPartition->[handleUpsert... | Delete file and return result. | Worried about the extra globStatus.. the FileSlice also has the log files. lets just reimplement without the extra call or special casing. |
@@ -2110,6 +2110,14 @@ ds_pool_connect_handler(crt_rpc_t *rpc)
D_GOTO(out_map_version, rc);
}
+ rc = ds_sec_pool_get_origin(&in->pci_cred, &machine);
+
+ if (rc != 0) {
+ D_ERROR(DF_UUID": unable to retrieve origin error: "DF_RC"\n",
+ DP_UUID(in->pci_op.pi_uuid),DP_RC(rc));
+ D_GOTO(out_map_version, rc);
+ ... | [No CFG could be retrieved] | finds the n - ary object in the pool and bcasts it if it is Transfer the pool map to remote_bulk. | (style) space required after that ',' (ctx:VxV) |
@@ -675,7 +675,10 @@ func applyTransformations(t, name string, props Input, resource Resource, opts [
res := transformation(args)
if res != nil {
- resOptions := merge(res.Opts...)
+ resOptions, err := tryMergeWithoutAwaiting(res.Opts...)
+ if err != nil {
+ return nil, nil, nil, err
+ }
if res... | [ReadResource->[ReadResource,DryRun],RegisterComponentResource->[RegisterResource],collapseAliases->[Project,Stack],registerResource->[RegisterResource,DryRun,getResource],Invoke->[Invoke,DryRun],resolve->[resolve],RegisterRemoteComponentResource->[registerResource],prepareResourceInputs->[DryRun],RegisterResourceOutpu... | registerResource registers a component resource with the given name and input. It returns the input options Copy returns a copy of the specific package if any. | Currently will fail if asked to await, however we can switch this to await here. This runs within contexts that are resolving resources already. |
@@ -24,7 +24,7 @@ const (
// GenesisShardNum is the number of shard at genesis
GenesisShardNum = 4
// GenesisShardSize is the size of each shard at genesis
- GenesisShardSize = 50
+ GenesisShardSize = 5
// CuckooRate is the percentage of nodes getting reshuffled in the second step of cuckoo resharding.
Cuckoo... | [Reshard->[cuckooResharding,sortCommitteeBySize,assignNewNodes,assignLeaders],assignNewNodes->[sortCommitteeBySize],Reshard] | Package containing all of the magic numbers and the various parameters of the type of a magic number assignNewNodes assigns new nodes to the N - 2 active committees evenly. | don't change the default value. |
@@ -7,13 +7,14 @@ feature 'idv verify step' do
start_idv_from_sp
complete_idv_steps_before_verify_step
- expect(page).to have_content(t('idv.titles.expectations'))
- expect(page).to have_current_path(verify_path)
+ expect(page).to have_current_path(idv_jurisdiction_path)
+ expect(page).to have_c... | [it_behaves_like,to,include,have_content,context,feature,have_current_path,t,it,require] | adds features for idv verify step. | We'll probably want to rename this spec |
@@ -508,6 +508,15 @@ MACHINE_CONFIG_START(renegade_state::renegade)
MACHINE_CONFIG_END
+MACHINE_CONFIG_START(renegade_state::renegadeb)
+ renegade(config);
+ MCFG_CPU_MODIFY("maincpu")
+ MCFG_CPU_PROGRAM_MAP(renegade_nomcu_map)
+
+ MCFG_DEVICE_REMOVE("mcu")
+MACHINE_CONFIG_END
+
+
MACHINE_CONFIG_START(renegade_st... | [No CFG could be retrieved] | Configures the n - tuple of the n - tuple of the n - tuple of the n 16k for code + bank switched ROM - - - - - - - - - - - - - - - - - -. | There's no need to make a duplicate machine configuration - nust use the existing one. |
@@ -27,9 +27,7 @@ module CriteriaHelper
criterion.save!
pos += 1
successes += 1
- rescue ActiveRecord::RecordInvalid # E.g., both visibility options are false.
- crit_format_errors << criterion_yml[0]
- rescue RuntimeError # An error occurred.
+ rescue ActiveRecord::Reco... | [reset_results_total_mark->[each,update,update_total_mark],upload_criteria_from_yaml->[position,empty?,load_from_yml,save!,each,raise,assessment_id,reset_results_total_mark,join,destroy_all,casecmp,t,id]] | Upload all the criteria from the given YAML data. | Metrics/LineLength: Line is too long. [97/80] |
@@ -111,6 +111,15 @@ class DvcTree(BaseTree):
for out in outs:
trie[out.path_info.parts] = out
+ if out.is_dir_checksum and (self.fetch or self.stream):
+ # will pull dir cache if needed
+ with self.repo.state:
+ cache = out.collect_use... | [DvcTree->[isfile->[exists,isdir],_walk->[_walk],exists->[_find_outs],isdvc->[_find_outs],walk->[exists,isdir,_walk,_find_outs],isdir->[exists,_find_outs],open->[open,_find_outs]],RepoTree->[exists->[exists],open->[open],__init__->[DvcTree]]] | Walks the directory tree and returns all files that have a in the tree. | So it doesn't pull the whole dir (i mean with the files contents), yet, right? That will be introduced later? Just making sure I follow :slightly_smiling_face: |
@@ -175,12 +175,12 @@ void Environment::continueRaycast(RaycastState *state, PointedThing *result)
bool is_colliding = false;
// Minimal distance of all collisions
float min_distance_sq = 10000000;
+ // ID of the current box (loop counter)
+ u16 id = 0;
v3f npf = intToFloat(np, BS);
- for (std::... | [ m_time_of_day_speed->[getU32,getBool,getFloat],continueRaycast->[,getCenter,getVector,getNeighbors,end,empty,begin,getSelectionBoxIntUnion,boxLineCollision,pop,getMap,top,getSelectedActiveObjects,next,push,getSelectionBoxes,getNodeNoEx,intToFloat,getIndex,isPointableNode,floatToInt],getDayNightRatio->[time_to_daynigh... | This method is called when a raycast is done. This method is used to check if a node is in the tree. Get all nodes that are selected with a selection box. This method is called from the ray - search code to find the nearest object in the ray. | wrong reference, previously we copied the object |
@@ -188,11 +188,14 @@ func (s *balanceRegionScheduler) Schedule(cluster opt.Cluster) []*operator.Opera
}
if op := s.transferPeer(plan); op != nil {
+ s.retryQuota.ResetLimit(plan.source)
op.Counters = append(op.Counters, schedulerCounter.WithLabelValues(s.GetName(), "new-operator"))
return []*ope... | [Schedule->[GetName],EncodeConfig->[EncodeConfig],IsScheduleAllowed->[GetType],transferPeer->[GetName]] | Schedule creates a balance plan that schedules the regions that have a pending peer in the source store picks the region in the source store if it has the leader in the source store. BalanceRegionType creates a new balance region move operator. | it may be better that the limit recover same with the failed? |
@@ -64,5 +64,7 @@ def add_parser(subparsers, parent_parser):
description=DAEMON_ANALYTICS_HELP,
help=DAEMON_ANALYTICS_HELP,
)
- daemon_analytics_parser.add_argument("target", help="Analytics file.")
+ daemon_analytics_parser.add_argument(
+ "target", help="Analytics file.", choices=c... | [CmdDaemonAnalytics->[run->[send]],add_parser->[add_argument,set_defaults,add_subparsers,add_parser,fix_subparsers],CmdDaemonUpdater->[run->[fetch,get,Updater,join,find_root,Config]]] | Adds a parser to subparsers to run D - AEMON. | Is there a way to tell shtab that it shouldn't complete these commands? `daemon` is hidden (kinda) and shouldn't be completed. |
@@ -206,12 +206,9 @@ public class DefaultHttp2RemoteFlowController implements Http2RemoteFlowControll
frame.error(t);
return;
}
+ // Write data to channel but don't flush as more writes may be coming and we want to
+ // allow a flush to coalesce them
state.write... | [DefaultHttp2RemoteFlowController->[writePendingBytes->[windowSize,flush],AbstractState->[incrementStreamableBytesForTree->[incrementStreamableBytesForTree],streamableBytesForTree],ChildFeeder->[visit->[state,streamableBytesForTree,allocateBytesForTree],feedHungryChildren->[visit]],streamableBytesForTree->[streamableBy... | Sends a flow controlled frame. | Do you want to remove all calls to flush from the `DefaultHttp2RemoteFlowController` and have something higher-level control when flushing occurs? |
@@ -51,10 +51,5 @@ func PushUpdate(ctx *macaron.Context) {
}
return
}
-
- log.Trace("TriggerTask '%s/%s' by %s", repo.Name, branch, pusher.Name)
-
- go models.HookQueue.Add(repo.ID)
- go models.AddTestPullRequestTask(pusher, repo.ID, branch, true)
ctx.Status(202)
}
| [AddTestPullRequestTask,Status,Error,GetUserByID,Trace,Decode,PushUpdate,TrimPrefix,IsErrUserNotExist,JSON,NewDecoder,Add] | This method is called when a task is triggered by a pusher. | This line is actually removed (as opposed to simply being moved to `models/update.go`), since the repo ID is already added to `HookQueue` by `CommitRepoAction(..)` |
@@ -58,7 +58,9 @@ function extractPercyKeys() {
'Error: PERCY_TOKEN doesn\'t look like a valid Percy API key'));
process.exit(1);
}
- util.log('Percy token: ', util.colors.magenta('<redacted>'));
+ // Note: The secret percy token only gets printed during local use. Travis
+ // will hide it in public... | [No CFG could be retrieved] | Extracts Percy project and secret keys from the environment. Get the webpage and screen widths for a single . | Who will be able to see the token? |
@@ -397,8 +397,13 @@ func (node *Node) VerifyNewBlock(newBlock *types.Block) error {
func (node *Node) numSignaturesIncludedInBlock(block *types.Block) uint32 {
count := uint32(0)
- pubkeys := node.Consensus.Decider.Participants()
- mask, err := internal_bls.NewMask(pubkeys, nil)
+ members := node.Consensus.Decide... | [PostConsensusProcessing->[BroadcastNewBlock,numSignaturesIncludedInBlock],HandleMessage->[processSkippedMsgTypeByteValue]] | numSignaturesIncludedInBlock returns the number of signatures included in the given block. | from participants to mask could be cached per epoch. may be in the next PR. |
@@ -3757,7 +3757,7 @@ p {
*/
$base_url = apply_filters(
'jetpack_stats_base_url',
- set_url_scheme( 'http://pixel.wp.com/g.gif' )
+ set_url_scheme( 'https://pixel.wp.com/g.gif' )
);
$url = add_query_arg( $args, $base_url );
return $url;
| [Jetpack->[verify_json_api_authorization_request->[add_nonce],is_staging_site->[get_cloud_site_options],get_locale->[guess_locale_from_lang],admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],authenticate_jetpack->[verify_xml_rpc_signature],admin_page_load->[disconnect,unlink_user,can_displ... | Build the Stats tracking URL. | If we want to use `HTTPS` all the time, we'll need to get rid of `set_url_scheme()` here. |
@@ -29,8 +29,10 @@ def test_retrieve_stripe_checkout_session():
stripe_retrieve.assert_called_once_with(stripe_session_id)
-@override_settings(STRIPE_API_SPONSORED_PRICE_ID="sponsored-price-id")
-def test_create_stripe_checkout_session():
+@override_settings(
+ STRIPE_API_SPONSORED_YEARLY_PRICE_ID="year... | [test_create_stripe_customer_portal->[assert_called_once_with,addon_factory,create_stripe_customer_portal,patch,reverse,absolutify],test_create_stripe_webhook_event->[assert_called_once_with,create_stripe_webhook_event,patch],test_retrieve_stripe_checkout_session->[assert_called_once_with,retrieve_stripe_checkout_sessi... | Test to create a session with a single nagios - like object. | I believe this test is for sponsored, not verified. Also, you're missing an `n` in the word `sessio`. |
@@ -202,7 +202,7 @@ class BaseTasksSection(PulpCliSection):
finish_time = _('N/A')
result = _('N/A')
elif task.was_cancelled():
- state = _('Cancelled')
+ state = _('Canceled')
result = _('N/A')
return state, start_... | [AllTasksSection->[__init__->[__init__]],RepoTasksSection->[__init__->[__init__]],BaseTasksSection->[__init__->[__init__]]] | Parses the state of the task in the order of their creation and completion. | Ahhhhh, perhaps this is why I thought the API was "cancelled" - the CLI was printing "Cancelled" as the task status and I assumed it was that stupid CLI thing where it capitalizes words from the API when printing them. It turns out that we had code that detected "canceled" and then printed "cancelled"! lol. |
@@ -42,6 +42,14 @@ public class AttributeEvaluator {
return this;
}
+ private String sanitize(String attributeValue) {
+ if (attributeValue != null) {
+ attributeValue = attributeValue.trim().replaceAll("\n", "").replaceAll("\r", "").replaceAll("\t", "");
+ }
+
+ return attributeValue;
+ }
+
... | [AttributeEvaluator->[resolveValue->[isParseExpression,isExpression],resolveTypedValue->[isParseExpression,isExpression],resolveStringValue->[resolveValue],resolveBooleanValue->[resolveValue],resolveIntegerValue->[resolveValue]]] | Initialize the evaluator. | What is this?. Seems this must be solved elsewhere. Perhaps in the parsers? |
@@ -68,7 +68,7 @@ public class StandardHttpFlowFileServerProtocol extends AbstractFlowFileServerPr
}
@Override
- protected HandshakeProperties doHandshake(Peer peer) throws IOException, HandshakeException {
+ protected HandshakeProperties doHandshake(Peer peer) throws IOException {
HttpServ... | [StandardHttpFlowFileServerProtocol->[commitReceiveTransaction->[commitReceiveTransaction,holdTransaction],commitTransferTransaction->[commitTransferTransaction,holdTransaction],holdTransaction->[holdTransaction]]] | Do the handshake. | another spot where we're changing the API/exception handling that we should back out for now in my opinion |
@@ -472,6 +472,16 @@ func (pc *Client) PublishPolicyPack(ctx context.Context, orgName string,
return errors.Wrapf(err, "Failed to upload compressed PolicyPack")
}
+ //
+ // Step 3: Signal to the service that the PolicyPack publish operation is complete.
+ //
+
+ err = pc.restCall(ctx, "POST",
+ publishPolicyPac... | [CancelUpdate->[restCallWithOptions],GetStack->[restCall],ExportStackDeployment->[restCall],RenameStack->[restCall],RecordEngineEvents->[updateRESTCall],DeleteStack->[restCall],GetCLIVersionInfo->[restCall],PublishPolicyPack->[restCall],CreateUpdate->[restCall],GetLatestConfiguration->[restCall],ImportStackDeployment->... | PublishPolicyPack publishes the policy pack to the specified org. NULL - > null. | nit: you could use `http.MethodPost` |
@@ -5,10 +5,10 @@ class Membership < ActiveRecord::Base
belongs_to :grouping
has_many :grace_period_deductions
- validates_presence_of :user_id, :message => 'needs a user id'
- validates_associated :user, :message => 'associated user needs to be valid'
+ validates_presence_of :user_id, message: 'ne... | [Membership->[validates_associated,validates_presence_of,belongs_to,has_many]] | belongs to user and has_many. | Line is too long. [88/80]<br>Put one space between the method name and the first argument. |
@@ -274,7 +274,8 @@ def read_inverse_operator(fname, verbose=None):
@verbose
-def write_inverse_operator(fname, inv, verbose=None):
+def write_inverse_operator(fname, inv, include_proj=True,
+ include_bads=True, verbose=None):
"""Write an inverse operator to a FIF file
Paramet... | [prepare_inverse_operator->[combine_xyz],apply_inverse->[prepare_inverse_operator,_assemble_kernel,_subject_from_inverse,_check_ch_names,_check_ori,combine_xyz,_check_method,_pick_channels_inverse_operator],apply_inverse_raw->[prepare_inverse_operator,_assemble_kernel,_subject_from_inverse,_check_ch_names,_check_ori,co... | Write an inverse operator to a FIF file. This function writes the noise covariance matrix and the source covariance matrix to the FITS file. | `include_proj` and `include_bads` should not be options, right? I assume this is just leftover from debugging...? |
@@ -59,11 +59,11 @@ var _ = rest.GetterWithOptions(&REST{})
// one for deployments (replication controllers) and one for pods to get the necessary
// attributes to assemble the URL to which the request shall be redirected in order to
// get the deployment logs.
-func NewREST(dcClient appsclient.DeploymentConfigsGett... | [waitForExistingDeployment->[Get],Get->[Get],New,Get] | REST returns a RESTStorage object that will work against the . returns the unique id of the node that the client is authorized to log the node in. | I recall a discussion with @sttts (I think) where the registry bits will always be internal, has something changed? @deads2k @mfojtik ? |
@@ -93,7 +93,7 @@ namespace Dynamo.Models
/// <summary>
/// Fired when this NodeModel is disposed.
/// </summary>
- public event Action Disposed;
+ public event Action<NodeModel> Disposed;
/// <summary>
/// Called by nodes for behavior that they want ... | [NodeModel->[BuildAst->[BuildOutputAst],DisconnectInput->[OnNodeModified],Warning->[Warning],p_PortDisconnected->[DisconnectOutput,DisconnectInput,ValidateConnections],GetPortVerticalOffset->[GetPortIndexAndType],Deselect->[ValidateConnections],ClearRuntimeError->[ClearTooltipText],RegisterAllPorts->[RegisterInputPorts... | region Public methods - Dictionary of ports and PortData for the Input Ports of this NodeModel Definitions for the Input Ports of this NodeModel. | This is okay, but I'm assuming you've checked this does not break anything in DynamoRevit. |
@@ -36,6 +36,8 @@ import java.util.Map;
*/
public interface Event extends MuleEvent {
+ public static final ThreadLocal<Event> currentEvent = new ThreadLocal<>();
+
/**
* @return the context applicable to all events created from the same root {@link Event} from a {@link MessageSource}.
*/
| [builder->[DefaultEventBuilder]] | Returns the event context. | public is redundant here isn't it? I don't think it's a good idea to expose both getter/setter and field though TBH. Is there something else we can do to reduce visibility of this, even if it gets put somewhere else instead. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.