patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -8,6 +8,13 @@ import (
)
// NewRegistry returns a registry object that knows how to evaluate quota usage of OpenShift resources.
-func NewRegistry(osClient osclient.Interface) kquota.Registry {
- return image.NewImageRegistry(osClient)
+// Registry for resource quota controller cannot be used with resource quota... | [NewImageRegistry] | NewRegistry returns a registry object that knows how to evaluate quota usage of OpenShift resources. | No else blocks when you return in the if. |
@@ -81,9 +81,10 @@ class SliceInfo(QObject, Extension):
@pyqtSlot(result = str)
def getExampleData(self) -> str:
if self._example_data_content is None:
- file_path = os.path.join(PluginRegistry.getInstance().getPluginPath(self.getPluginId()), "example_data.json")
- with open(fil... | [SliceInfo->[_onWriteStarted->[callDecoration,getMetaDataEntry,getMetaData,start,printTimes,SliceInfoJob,getVersion,getMeshData,int,getProperty,DepthFirstIterator,dict,getDisplayString,getInstance,log,logException,values,print_times,time,list,getMachineManager,system,getController,type,getExtruderPositionValueWithDefau... | Returns example data. | If getPluginPath(...) returns None for some reason, the statement will fail. |
@@ -171,3 +171,18 @@ def price_range_as_dict(price_range):
return None
return {'maxPrice': price_as_dict(price_range.max_price),
'minPrice': price_as_dict(price_range.min_price)}
+
+
+def get_variant_url_from_product(product, attributes):
+ return '%s?%s' % (product.get_absolute_url(), url... | [price_range_as_dict->[price_as_dict],products_for_cart->[products_visible_to_user],products_for_homepage->[products_with_details],get_variant_picker_data->[get_availability],products_with_details->[products_visible_to_user]] | Returns price_range as a dictionary. | Do we need this function? It's used only once in `get_variant_url` below, so maybe instead of introducing it, we could move this logic to `get_variant_url`. |
@@ -95,10 +95,10 @@ namespace Content.Server.GameObjects.Components.Disposal
private readonly List<string> _targetList = new();
[ViewVariables]
- private string _target = "";
+ private string? _target = string.Empty;
[ViewVariables(VVAccess.ReadWrite)]
- private strin... | [DisposalMailingUnitComponent->[UpdateVisualState->[UpdateVisualState],ToggleEngage->[CanFlush],OnUiReceiveMessage->[TogglePower,TryEjectContents,ToggleEngage,PlayerCanUse],TryDrop->[CanInsert,AfterInsert],PowerStateChanged->[UpdateVisualState,TryFlush,TryQueueEngage],TryFlush->[CanFlush,TryInsert,Remove],DragDropOn->[... | A disposal unit is a container of entities that are part of the disposal unit. region IEntityInterface Implementation. | Looks like there's some internal code that only checks null so these should be null. |
@@ -59,7 +59,7 @@ WantedBy=multi-user.target
Expect(stop.ExitCode()).To(Equal(0))
}()
- create := podmanTest.Podman([]string{"create", "--name", "redis", "redis"})
+ create := podmanTest.Podman([]string{"create", "--name", "redis", redis})
create.WaitWithDefaultTimeout()
Expect(create.ExitCode()).To(Eq... | [InspectContainerToJSON,WaitWithDefaultTimeout,Cleanup,ExitCode,Contains,Remove,OutputToString,To,SeedImages,Podman,Sleep,Exit,WriteFile,Setup] | description = redis container description podman run container with systemd PID1. | Just double-checking is removing the quotes here intended/valid? |
@@ -627,7 +627,6 @@ define([
},
set : function(value) {
defaultFill = value;
- defaultFillMaterialProperty = new ColorMaterialProperty(defaultFill);
}
},
/**
| [No CFG could be retrieved] | Properties for the object. Get an object that maps the href property of a crs link to a callback function which takes. | It's weird that this got picked up, but `defaultStrokeMaterialProperty` and `defaultStrokeWidthProperty` variables in this file (which are also unused) didn't. Any idea why? Can you remove them as well. Thanks. |
@@ -17,14 +17,16 @@ module Engine
'i' => :ignore_one_sale,
's' => :safe_par,
'x' => :par_1,
+ 'X' => :par_overlap,
'z' => :par_2,
+ 'w' => :par_3,
'C' => :convert_range,
'm' => :max_price,
'u' => :phase_limited,
}.freeze
# Types which are info only ... | [SharePrice->[to_s->[name],highlight?->[include?],from_code->[each,new,match,to_i],can_par?->[include?],id->[join],initialize->[first,include?],attr_reader,freeze,coordinates]] | Creates a new object from the given code. | isn't that super confusing with the previous? |
@@ -1453,7 +1453,7 @@ public class NotebookServer extends WebSocketServlet implements
String commitMessage = (String) fromMessage.get("commitMessage");
AuthenticationInfo subject = new AuthenticationInfo(fromMessage.principal);
Revision revision = notebook.checkpointNote(noteId, commitMessage, subject);
... | [NotebookServer->[pushAngularObjectToRemoteRegistry->[broadcastExcept],broadcastInterpreterBindings->[broadcast],copyParagraph->[insertParagraph,updateParagraph],onRemove->[broadcast,notebook],generateNotesInfo->[notebook],updateParagraph->[permissionError,getOpenNoteId,broadcastParagraph],onLoad->[broadcast],unicastNo... | Checkpoint note. | maybe we can come up with a better implementation here like `revision.isEmpty()` or `Revision.isEmpty(revision)` what do you think |
@@ -118,6 +118,17 @@ public class ZooKeeperStateProvider extends AbstractStateProvider {
private byte[] auth;
private List<ACL> acl;
+ private String keyStorePath;
+ private String keyStorePassword;
+ private String keyStoreType;
+ private String trustStorePath;
+ private String trustStorePas... | [ZooKeeperStateProvider->[createNode->[invalidateClient,createNode],invalidateClient->[shutdown],setState->[verifyEnabled,serialize,setState,invalidateClient,getZooKeeper,getComponentPath],clear->[verifyEnabled,setState],replace->[verifyEnabled,setState],onComponentRemoved->[getComponentPath,invalidateClient,onComponen... | Creates a new instance of NiFi. Shutdown the node. | Should this be marked private? |
@@ -245,6 +245,8 @@ type Alias struct {
// Resource describes a Pulumi resource.
type Resource struct {
+ // Package is the package that defines the resource.
+ Package *Package
// Token is the resource's Pulumi type token.
Token string
// Comment is the description of the resource, if any.
| [bindProperties->[bindType],bindObjectType->[bindObjectTypeDetails],bindType->[String,bindType,bindPrimitiveType],bindObjectTypeDetails->[bindProperties],String->[String],bindProperties,bindObjectType,ImportLanguages,bindObjectTypeDetails,String] | ITS type description. Inputs - A type that can be used to create a new object. | Probably also want to add this to `Function`. |
@@ -2,6 +2,10 @@ from __future__ import absolute_import, division #makes KratosMultiphysics backw
import KratosMultiphysics as Kratos
from KratosMultiphysics.analysis_stage import AnalysisStage
+from KratosMultiphysics.kratos_utilities import IsMPIAvailable
+
+if IsMPIAvailable():
+ import KratosMultiphysics.mpi... | [FSIAnalysis->[OutputSolutionStep->[_GetFluidRestartUtility,super,_GetStructureRestartUtility,SaveRestart],_CreateSolver->[CreateSolver],_GetSimulationName->[project_parameters],Initialize->[PrettyPrintJsonString,_GetSimulationName,_SetUpRestart,_GetFluidRestartUtility,ExecuteBeforeSolutionLoop,Exception,LoadRestart,Mo... | Initialize the object. computes the n - ary entry in the system. | I don't think this check is needed |
@@ -91,10 +91,10 @@ class Patch(object):
Args:
stage: stage for the package that needs to be patched
"""
- stage.chdir_to_source()
- # Use -N to allow the same patches to be applied multiple times.
- _patch = which("patch", required=True)
- _patch('-s', '-p', s... | [FilePatch->[__init__->[absolute_path_for_package]]] | Apply the patch at self. path to the source code in the specified stage. | It looks like you handled swapping sha256 for md5 for a couple packages. Out of curiosity was that all the packages using UrlPatch? |
@@ -773,7 +773,9 @@ class FormRecognizerTest(AzureTestCase):
field_type = expected.type
assert adjust_value_type(field_type) == document_fields[label].value_type
assert expected.confidence == document_fields[label].confidence
- assert expected.content == document_fields... | [FormRecognizerTest->[generate_fake_token->[FakeTokenCredential],assertDocumentFieldsTransformCorrect->[assertSpanTransformCorrect],assertFormFieldsTransformCorrect->[assertFormFieldValueTransformCorrect],assertUnlabeledRecognizedFormHasValues->[assertFormPagesHasValues],assertFormSelectionMarkHasValues->[assertBoundin... | Checks that the given document fields are correct. | what is the testcase that repros this? I'm thinking we should return what the service returns here, but don't quite understand why the content would be "" if there was a value detected. |
@@ -39,6 +39,7 @@ import org.apache.zeppelin.helium.HeliumPackage;
import org.apache.zeppelin.interpreter.InterpreterGroup;
import org.apache.zeppelin.interpreter.remote.RemoteAngularObjectRegistry;
import org.apache.zeppelin.interpreter.thrift.InterpreterCompletion;
+import org.apache.zeppelin.rest.message.Interpre... | [NotebookServer->[pushAngularObjectToRemoteRegistry->[broadcastExcept],checkpointNotebook->[serializeMessage],onRemove->[broadcast,notebook],onLoad->[broadcast],updateParagraph->[permissionError,getOpenNoteId,broadcast],unicastNoteList->[generateNotebooksInfo,unicast],onOutputAppend->[broadcast],broadcast->[serializeMe... | Imports a single object from a list of objects. Imports a single version of the object that represents a Zeppelin websocket. | I think you'd better move this class into proper one. It's used in binding method only. |
@@ -280,6 +280,9 @@ public final class ContainerDataYaml {
String state = (String) nodes.get(OzoneConsts.STATE);
kvData
.setState(ContainerProtos.ContainerDataProto.State.valueOf(state));
+ String schemaVersion = (String) nodes.get(OzoneConsts.SCHEMA_VERSION);
+ kvData.setSc... | [ContainerDataYaml->[ContainerDataRepresenter->[representJavaBeanProperty->[representJavaBeanProperty],getProperties->[getProperties]],readContainer->[readContainer]]] | Construct a KeyValueContainerData object from a node. | When reading old containerDataYaml which does not container the Schema version field, what value would be returned? IIRC and it returns null, then we should set it to version V1. |
@@ -88,8 +88,8 @@ func (d DocLanguageHelper) GetLanguageTypeString(pkg *schema.Package, moduleName
glog.Errorf("cannot calculate type string for type %q. could not find a package for module %q", t.String(), moduleName)
os.Exit(1)
}
- if _, ok := t.(*schema.EnumType); ok {
- return modPkg.inputType(t)
+ if typ,... | [GetResourceFunctionResultName->[GetFunctionName],GetDocLinkForResourceInputOrOutputType->[GetDocLinkForResourceType],GetDocLinkForFunctionInputOrOutputType->[GetDocLinkForResourceType],GetModuleDocLink->[GetDocLinkForResourceType]] | GetLanguageTypeString returns the language string for the given type. | What happens if we delete these lines entirely? I have a feeling that the call to `typeString` below will do the right thing. |
@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class AddRecentSearches < ActiveRecord::Migration[6.1]
+ def change
+ add_column :user_options, :oldest_search_log_date, :datetime
+
+ add_index :search_logs, [:user_id, :created_at]
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I'm not 100% sure but I don't think we need to index rows where `user_id` is null. |
@@ -725,6 +725,13 @@ public class HoodieBackedTableMetadataWriter implements HoodieTableMetadataWrite
throw new HoodieMetadataException("Failed to commit metadata table records at instant " + instantTime);
}
});
+ // trigger cleaning, compaction, with suffixes based on the same instant t... | [HoodieBackedTableMetadataWriter->[syncFromInstants->[initTableMetadata],bootstrapFromFilesystem->[initTableMetadata]]] | Commits the records in the given recordRDD to the metadata table. | This is a good idea. I hope it does not break some function which may depend on yyyyMMddHHmmss format of the instantTime. |
@@ -411,7 +411,9 @@ class BaseZincCompile(JvmCompile):
snapshots.extend(java_sources_snapshots)
# Ensure the dependencies and compiler bridge jars are available in the execution sandbox.
- relevant_classpath_entries = dependency_classpath + [compiler_bridge_classpath_entry]
+ relevant_classpath_entrie... | [BaseZincCompile->[_maybe_get_plugin_name->[process_info_file],__init__->[validate_arguments],_compute_local_only_inputs->[_get_analysis_snapshot,_get_classes_dir_snapshot],compile->[post_compile_extra_resources,javac_classpath,relative_to_exec_root,_get_zinc_arguments,scalac_classpath_entries],_compile_nonhermetic->[Z... | Compile a single Hermetic target. The main entry point for the compiler. Capture a single missing - tag jar file or directory entry in the workspace. | We should open a ticket about finding a way to do this that doesn't involve the user's participation. As odd as it is, this ... should maybe be an engine intrinsic, or a well-define type, so that a user doesn't need to include it in the sandbox manually. |
@@ -738,7 +738,6 @@ def file_validation(request, addon_id, addon, file_id):
'filename': file_.filename,
'timestamp': file_.created,
'addon': addon,
- 'automated_signing': file_.automated_signing,
}
if file_.has_been_validated:
| [submit_version_source->[_submit_source],upload_for_version->[upload],submit_version_details->[_submit_details],upload->[handle_upload],upload_detail->[get_fileupload_by_uuid_or_404,json_upload_detail],submit_version_upload->[_submit_upload],submit_addon_theme_wizard->[_submit_upload],submit_version_auto->[_submit_uplo... | Show validation page for a single file. | not actually used in the template |
@@ -36,7 +36,7 @@ type Sender interface {
var baseRoundTrippers = func(rt http.RoundTripper) (http.RoundTripper, error) {
rt = NewFleetUserAgentRoundTripper(rt, release.Version())
- return rt, nil
+ return apmhttp.WrapRoundTripper(rt), nil
}
func init() {
| [Version,New,NewWithConfig,Unmarshal,Errorf,LookupEnv,ReadAll,NewDebugRoundTripper] | Invite implements the sender interface for the given message. WithConfig creates a new fleet - server client that uses the given API key and a fleet. | this will add DT headers to the request, right? getting some tracing between fleet server and the agents would be amazing! if so, have you tried getting a sample trace between them? |
@@ -163,8 +163,13 @@ abstract class PubObjectsExportPlugin extends ImportExportPlugin {
assert($filter != null);
// Get the XML
$exportXml = $this->exportXML($objects, $filter, $context);
- header('Content-type: application/xml');
- echo $exportXml;
+ $exportFileName = $this->getExportFileName($object... | [PubObjectsExportPlugin->[getExportPath->[getPluginSettingsPrefix],_instantiateExportDeployment->[getExportDeploymentClassName],executeCLI->[getIssueFilter,usage,getSubmissionFilter,getRepresentationFilter],getExportFileName->[getExportPath],executeCLICommand->[exportXML,usage,getExportFileName],getDepositStatusSetting... | Executes the export action. | Some of this is starting to reinvent the TemporaryFileManager; I haven't worked with that class for a while, but I think it should be pretty quick to make use of it instead for management of file creation/deletion/etc. |
@@ -157,6 +157,11 @@ def _supplement_index_with_system(index):
rec = _make_virtual_package('__cuda', cuda_version)
index[rec] = rec
+ libc_family, libc_version = context.libc_family_version
+ if libc_family:
+ rec = _make_virtual_package('__' + libc_family, libc_version)
+ index[... | [_supplement_index_with_system->[_make_virtual_package],get_index->[check_whitelist],get_reduced_index->[push_record->[push_spec],_supplement_index_with_cache,_supplement_index_with_system,push_spec,_supplement_index_with_prefix,push_record]] | Add a sequence of nanoseconds to the index. | I'm wondering a bit on how this will behave on systems where we have musl + glibc-wrapper, e.g. the `miniconda3:4.7.10-alpine` docker image. |
@@ -22,6 +22,10 @@ class Dd4hep(CMakePackage):
version('1.11.0', commit='280c7d748d56a704699408ac8e57815d029b169a')
version('1.10.0', commit='9835d1813c07d9d5850d1e68276c0171d1726801')
+ # Workarounds for various TBB issues in DD4hep v1.11
+ # See https://github.com/AIDASoft/DD4hep/pull/613 .
+ pat... | [Dd4hep->[cmake_args->[format,satisfies],variant,depends_on,version]] | Creates a class which can be used to create a specific object. Return the list of arguments for the command. | Shouldn't we limit this to newer TBB releases? Apart from that, builds fine for me! :tada: |
@@ -10,6 +10,7 @@ namespace System.Reflection.Metadata
{
[System.CLSCompliantAttribute(false)]
public unsafe static bool TryGetRawMetadata(this System.Reflection.Assembly assembly, out byte* blob, out int length) { throw null; }
+ public static void ApplyUpdate(Assembly assembly, ReadOnlyS... | [AssemblyLoadContext->[ContextualReflectionScope->[Never]]] | This method is used to try to get the raw metadata from the given assembly. | I'm surprised we decided to make the last parameter optional given that we don't actually expect many folks to be calling this method. |
@@ -43,7 +43,8 @@ def ps_roi_align(
Returns:
Tensor[K, C / (output_size[0] * output_size[1]), output_size[0], output_size[1]]: The pooled RoIs
"""
- _log_api_usage_once("ops", "ps_roi_align")
+ if not torch.jit.is_scripting() and not torch.jit.is_tracing():
+ _log_api_usage_once(ps_roi_a... | [ps_roi_align->[ps_roi_align],PSRoIAlign->[forward->[ps_roi_align]]] | Applies the alignment of a single element of a sequence in a Light - Head RoI The pooled RoIs . | Same, missing from the class. |
@@ -224,6 +224,18 @@ public class DefaultMuleMessage implements MuleMessage, ThreadSafeAccess, Deseri
resetAccessControl();
}
+ private MuleMessageDataTypeWrapper<?> createDataTypeWrapper(DataType<?> dataType)
+ {
+ if (dataType instanceof MuleMessageDataTypeWrapper)
+ {
+ ... | [DefaultMuleMessage->[getPayloadAsBytes->[getPayload],setProperty->[setProperty,removeProperty],getDoubleProperty->[assertAccess,getInboundProperty],setDataType->[getEncoding,setMimeType,setEncoding],equals->[equals],setIntProperty->[setOutboundProperty,assertAccess],setStringProperty->[setOutboundProperty,assertAccess... | copyMessagePropertiesContext - copy message properties context. | Does this happen somewhere, or it's just incase? I assume you can't just return 'dataType' because it may have a diferent message instance? When would this happen? If it's only when cloning message then maybe new wrapper can be created in line 218? |
@@ -20,7 +20,6 @@ module Engine
connection = connection.branch!(path)
next if connection.paths.include?(path)
next if (connection.nodes & path.nodes).any?
- next if connection.paths.any? { |p| p.hex == hex && (p.exits & path.exits).any? }
connections[connection] = ... | [Connection->[matches?->[reverse],hexes->[map],connect!->[walk,all?,partition,new,add_path,empty?,connections,reject!,include?,paths,hex,branch!,any?,node?,each],complete?->[size],include?->[include?],branch!->[new,connections,size,select,each],nodes->[flat_map],add_path->[raise,size],inspect->[name,join],id->[walk,nod... | Finds connection between two nodes and edges. | was this removed due to lanes? will this cause issues? |
@@ -145,10 +145,13 @@ class SQUADConverter(BaseFormatConverter):
tokens.append("[SEP]" if self.support_vocab else SEP_ID)
segment_ids.append(0)
- for i in range(doc_span.length):
- split_token_index = doc_span.start + i
- tokens.ap... | [SQUADConverter->[_load_examples->[_is_whitespace],convert->[_load_examples]]] | Convert the examples to a sequence of tokens. This function creates a sequence identifier and adds it to the list of annotations. | @mzuevx do you know, in which scenarious here TypeError possible? |
@@ -29,6 +29,7 @@ module TwoFactorAuthCode
end
def fallback_question
+ return if @hide_fallback_question
t('two_factor_authentication.piv_cac_fallback.question')
end
| [PivCacAuthenticationPresenter->[fallback_question->[t],help_text->[t],piv_cac_capture_text->[t],header->[t],cancel_link->[sign_out_path,account_path,locale],attr_reader,include,url_helpers]] | fallback_question - if there is no question in fallback list return t. | this is new behavior, right? should we spec this? |
@@ -8,6 +8,7 @@ using System.Runtime.InteropServices;
using System.Security.Cryptography;
using System.Security.Cryptography.Asn1;
+#nullable enable
namespace System.Security.Cryptography.Asn1
{
[StructLayout(LayoutKind.Sequential)]
| [DirectoryStringAsn->[Encode->[PrintableString,T61String,BMPString,HasSameClassAndValue,UTF8String,WriteEncodedValue,WriteCharacterString,Span,HasValue,TryDecode],Decode->[PrintableString,T61String,ReadCharacterString,BMPString,nameof,HasSameClassAndValue,UniversalString,UTF8String,Utf8String,PeekTag,ReadEncodedValue,B... | Creates an object that represents a sequence of unique tags. This method writes the string representation of the tag number. | These .xml.cs files are generated by a tool. If we're changing them, we should also update the templates that's used to create them. Otherwise, we'll lose these changes the next time someone runs that tool. |
@@ -556,6 +556,9 @@ WebContents.prototype._init = function () {
if (prefs.webviewTag && prefs.contextIsolation) {
electron.deprecate.log('Security Warning: A WebContents was just created with both webviewTag and contextIsolation enabled. This combination is fundamentally less secure and effectively bypasse... | [No CFG could be retrieved] | Create a new browser window for the native implementation of the window. open. Set zoom level zoom factor and frameRate properties. | Can we fit a "You should be using contextIsolation instead" kind of message in here as well? |
@@ -16,7 +16,6 @@ let PaginationButtonStateDef;
/** @const {!Object<string, !PaginationButtonStateDef>} */
const BackButtonStates = {
- HIDDEN: {className: 'i-amphtml-story-button-hidden'},
PREVIOUS_PAGE: {
className: 'i-amphtml-story-back-prev',
triggers: EventType.PREVIOUS_PAGE,
| [No CFG could be retrieved] | A preact implementation of AMPHTML s standard standard standard standard standard standard standard standard standard Displays a pagination button with a hidden button. | Instead of having separate `BackButtonStates` and `ForwardButtonStates`, consider merging the two into a single `ButtonStates`. (Optional change since these states existed before this PR) |
@@ -55,6 +55,18 @@ public class HadoopUtils {
return yarnClient.getApplicationReport(yarnAppId).getTrackingUrl();
}
+ public static int getFlinkRestPort(String yarnAppId) throws IOException, YarnException {
+ YarnClient yarnClient = YarnClient.createYarnClient();
+ YarnConfiguration yarnConf = new Yarn... | [HadoopUtils->[downloadJar->[createTempDir,Path,makeQualified,getName,Configuration,get,copyToLocalFile,IOException,exists,getAbsolutePath],cleanupStagingDirInternal->[Path,getClusterId,Configuration,get,toString,warn,getHomeDirectory,info,delete],getYarnAppTrackingUrl->[getTrackingUrl,YarnConfiguration,createYarnClien... | Gets the tracking URL for YARN application. | It is almost the same as the function above, but it would be good to separate it with the `getApplicationReport()` function. |
@@ -259,7 +259,7 @@ func EnsureDeploymentNode(g osgraph.MutableUniqueGraph, deployment *extensions.D
node := osgraph.EnsureUnique(g,
nodeName,
func(node osgraph.Node) graph.Node {
- return &DeploymentNode{Node: node, Deployment: deployment}
+ return &DeploymentNode{Node: node, Deployment: deployment, IsFoun... | [EnsureUnique,AddEdge] | EnsureStatefulSetSpecNode adds edges to nodes if there is no edge with a node with a EnsureDaemonSetNode adds a node for the daemon set if it does not already exist. | why are we setting this to true? I thought that only got set when we verified its existence in the API |
@@ -125,7 +125,7 @@ def hash_balance_data(
assert locksroot != b''
assert len(locksroot) == 32
if transferred_amount == 0 and locked_amount == 0 and locksroot == EMPTY_HASH:
- return EMPTY_HASH
+ return BalanceHash(EMPTY_HASH)
return Web3.soliditySha3( # pylint: disable=no-value-for... | [hash_balance_data->[soliditySha3,len],get_state_change_with_balance_proof_by_balance_hash->[str,serialize_bytes,get_latest_state_change_by_data_field,to_checksum_address],get_state_change_with_balance_proof_by_locksroot->[str,serialize_bytes,get_latest_state_change_by_data_field,to_checksum_address],get_event_with_bal... | Returns a balance hash for the given tokens. | This should be typed constant in `constant.py` |
@@ -4,3 +4,6 @@
.elgg-icon-report-this:before {
content: "\f071";
}
+.elgg-menu-extras .elgg-menu-item-report-this .elgg-anchor-label {
+ display: none;
+}
\ No newline at end of file
| [No CFG could be retrieved] | Report this icon. | Inaccessible way to hide text, but with font icons I don't have a better solution. |
@@ -307,7 +307,9 @@ namespace System.Runtime.InteropServices
{
TManager? localManager; // Use register for null comparison rather than byref
manager = localManager = memory.GetObjectStartLength(out _, out _) as TManager;
+#pragma warning disable 8762 // "Parameter 'manager' may not ha... | [MemoryMarshal->[T->[GetReference],Write->[GetReference],AsRef->[GetReference],Cast->[GetReference],TryGetArray->[TryGetArray],TryRead->[GetReference],TryWrite->[GetReference]]] | Try to get a managed object from a read - only memory. | >#pragma warning disable 8762 [](start = 0, length = 29) :memo: commit 11 experimented with replacing pragma with `Debug.Assert`, but that results in different IL, so I reverted. |
@@ -52,6 +52,7 @@ public class StorageNodeModule implements Module
{
JsonConfigProvider.bind(binder, "druid.server", DruidServerConfig.class);
JsonConfigProvider.bind(binder, "druid.segmentCache", SegmentLoaderConfig.class);
+ JsonConfigProvider.bind(binder, "druid.segmentCache.locationSelector.strategy... | [StorageNodeModule->[getDataNodeService->[getTier,equals,DataNodeService,ProvisionException,getMaxSize,getPriority,getServerType,info],getMetadata->[getTier,getHostAndPort,ProvisionException,getMaxSize,getPriority,getHostAndTlsPort,DruidServerMetadata,getServerType,getHostAndPortToUse],isSegmentCacheConfigured->[isEmpt... | Configure the availables configuration. | Should this be `druid.segmentCache.locationSelector` instead? |
@@ -0,0 +1,11 @@
+package org.infinispan.api.reactive;
+
+/**
+ * A {@link KeyValueStore} entry status. Used by listeners and Continuous Query
+ *
+ * @author Katia Aresti, karesti@redhat.com
+ * @since 10.0
+ */
+public enum EntryStatus {
+ CREATED, UPDATED, DELETED
+}
| [No CFG could be retrieved] | No Summary Found. | Nitpick, but we should probably be consistent with the version String and use `10.0` everywhere. |
@@ -1105,12 +1105,14 @@ FW_VERSIONS = {
b'\x028965B0R01400\x00\x00\x00\x008965B0R02400\x00\x00\x00\x00',
],
(Ecu.fwdRadar, 0x750, 0xf): [
+ b'\0018821F3301200\000\000\000\000',
b'\x018821F3301100\x00\x00\x00\x00',
b'\x018821F3301200\x00\x00\x00\x00',
b'\x018821F3301300\x00\x00... | [CarControllerParams->[max],dbc_dict,set] | Array of sequence codes that can be passed to a sequence of sequence sequence functions. A list of all possible tokens that can be passed to the ROM - AH algorithm Return a sequence of 16 - bit words that are contained in a sequence of 16 - bit. | Not needed, it's already in the list |
@@ -196,10 +196,9 @@ static void
vdev_label_write(zio_t *zio, vdev_t *vd, int l, abd_t *buf, uint64_t offset,
uint64_t size, zio_done_func_t *done, void *private, int flags)
{
- ASSERT(spa_config_held(zio->io_spa, SCL_ALL, RW_WRITER) == SCL_ALL ||
- (spa_config_held(zio->io_spa, SCL_CONFIG | SCL_STATE, RW_RE... | [No CFG could be retrieved] | Returns the vdev label associated with the passed in offset. Generate the stats for the specified nvlist. | It's the `dsl_pool_sync_context` intentionally removed? |
@@ -1220,7 +1220,10 @@ class ActionComm extends CommonObject
if (! empty($conf->dol_no_mouse_hover)) $notooltip=1; // Force disable tooltips
- $label = $this->label;
+ if ((!$user->rights->agenda->allactions->read && $this->author->id != $user->id) || (!$user->rights->agenda->myactions->read &&... | [ActionComm->[getActions->[fetch],info->[fetch],build_exportfile->[fetch],createFromClone->[create],add->[create]]] | Returns a link to the node with a link to the node with a link to the node Renders a link to the action dialog. Dolgenis de la link de la nueva a un link de la n Get nom url of current action. | Are you sure it is a || I think it should be && |
@@ -268,7 +268,8 @@ public final class TestExecutorUtil {
final StubKafkaService stubKafkaService,
final TestExecutionListener listener
) {
- final ImmutableList.Builder<PersistentQueryAndSources> queriesBuilder = new Builder<>();
+ final Map<QueryId, PersistentQueryAndSources> queries = new Hash... | [TestExecutorUtil->[PlannedStatementIterator->[planStatement->[execute,of],of->[PlannedStatementIterator],next->[hasNext],hasNext->[hasNext]],execute->[planTestCase],executePlan->[execute]]] | Executes a single sequence of plans for a given sequence number. | This will likely results in the _order_ of entries in the returned list changing from what it was before, and not being non-deterministic. Not sure if this is important, just flagging as a potential unforeseen side effect of the change. |
@@ -0,0 +1,7 @@
+module Risc
+ class ConfigurationController < ApplicationController
+ def index
+ render json: RiscConfigurationPresenter.new.configuration
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | When I added the OpenID discovery endpoint, I added caching headers because I'm pretty sure some specification required it....but I can't find it and didn't see any caching direction on the specs for this. I left out caching, but it's a one-liner so happy to add it if anybody feels strongly |
@@ -146,10 +146,11 @@ def add_variants_to_checkout(
channel_listings_by_product_id = {cl.product_id: cl for cl in channel_listings}
# check if variants are published
- for variant in variants:
- product_channel_listing = channel_listings_by_product_id[variant.product_id]
- if not product_ch... | [change_shipping_address_in_checkout->[_check_new_checkout_address],add_voucher_to_checkout->[get_voucher_discount_for_checkout],get_prices_of_discounted_specific_product->[get_discounted_lines],add_variant_to_checkout->[check_variant_in_stock],get_voucher_discount_for_checkout->[_get_products_voucher_discount,_get_shi... | Adds a list of variants to a checkout. Bulk create checkout node. | It was here before but since we are touching this - could you check if we could move this entire validation to `clean_input`? `add_variants_to_checkout` is supposed to only save things and validation should happen earlier. |
@@ -798,14 +798,14 @@ WasmBytecodeGenerator::EmitCall()
switch (info.type)
{
case WasmTypes::F32:
- if (wasmOp == wbCallImport)
+ if (isImportCall)
{
throw WasmCompilationException(_u("External calls with float argument NYI"));
... | [No CFG could be retrieved] | END of function cseq emit call arguments. | nit. ternary operator might look better here. |
@@ -379,8 +379,11 @@ func (ctx *Context) ReadResource(
// Merge providers.
providers := mergeProviders(t, options.Parent, options.Provider, options.Providers)
+ // Get the provider for the resource.
+ provider := getProvider(t, options.Provider, providers)
+
// Create resolvers for the resource's outputs.
- res... | [ReadResource->[ReadResource,DryRun],RegisterComponentResource->[RegisterResource],collapseAliases->[Project,Stack],registerResource->[RegisterResource,DryRun,getResource],Invoke->[Invoke,DryRun],resolve->[resolve],RegisterRemoteComponentResource->[registerResource],prepareResourceInputs->[DryRun],RegisterResourceOutpu... | ReadResource reads a custom resource ReadResource reads a resource. nul l I m not sure what this is. | This seems like a bugfix for provider not being pulled out of providers map when options.Provider is nil? |
@@ -2,10 +2,9 @@ require "rails_helper"
describe Rack::Attack, type: :request, throttle: true do
before do
- redis_url = "redis://localhost:6379"
- cache_db = ActiveSupport::Cache::RedisStore.new(redis_url)
+ cache_db = ActiveSupport::Cache.lookup_store(:redis_cache_store)
allow(Rails).to receive(:c... | [create,new,let,describe,secret,it,map,freeze,to,before,post,with,require,to_json,times,receive,each,title,id,get,not_to,eq,sign_in,flushdb,and_return] | requires rails_helper to be installed get api_write_throttle valid_responses. | We actually want redis cache store here which is what Rails.cache uses. |
@@ -63,6 +63,8 @@ module GobiertoPlans
end
end
end
+
+ assert has_content? "Strategic Plan footer"
end
end
end
| [PlanShowTest->[plan->[gobierto_plans_plans],test_plan->[visit,within,to_s,size,has_content?,with_javascript,each_with_index,assert,has_selector?,with_current_site],test_show_table_header->[visit,update_attribute,trigger,within,configuration_data,pretty_generate,with_javascript,refute,assert,has_selector?,with_current_... | Checks if there is a node with a non - content n - node element that is not. | Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -10,6 +10,6 @@ internal static partial class Interop
internal static partial class Sys
{
[DllImport(Libraries.SystemNative, EntryPoint = "SystemNative_GetSocketType")]
- internal static extern Error GetSocketType(SafeSocketHandle socket, out AddressFamily addressFamily, out SocketType socke... | [Interop->[Sys->[Error->[SystemNative]]]] | Retrieves the socket type and protocol information for a given socket handle. | This should be isListening, not isBlocking. |
@@ -108,7 +108,7 @@ class _AbstractOrderedSet(ABC, AbstractSet[T], Sequence[T]):
"""Returns True if other is the same type with the same elements and same order."""
if not isinstance(other, self.__class__):
return NotImplemented
- return self._items == other._items
+ return ... | [_AbstractOrderedSet->[intersection->[intersection],index->[index],symmetric_difference->[union],difference->[union]],OrderedSet->[pop->[pop],clear->[clear],update->[add]]] | Returns True if other is the same type with the same elements and same order. | Is the idea here to early return? I believe `self._items == other._items` will already do this because it will resort to `dict'`s `__eq__` implementation, which is already highly optimized. NB that this `__eq__` implementation is stricter than Twitter Commons. We enforce that it's the same class, e.g. `OrderedSet != Fr... |
@@ -128,7 +128,7 @@ module GobiertoPlans
end
def test_show_table_header
- with_javascript do
+ with(js: true) do
with_current_site(site) do
visit @path
| [PlanShowTest->[plan->[gobierto_plans_plans],test_plan->[visit,within,to_s,has_content?,with_javascript,each_with_index,assert,has_selector?,with_current_site,count],test_show_table_header->[visit,update_attribute,trigger,within,configuration_data,pretty_generate,with_javascript,assert,has_selector?,with_current_site,c... | Checks if there is a show table header node with a javascript object that can be used to. | Block has too many lines. [39/25] |
@@ -1389,14 +1389,6 @@ c. Must order mtimes of files to decide whether to re-process; depends
d. from P import M; checks filesystem whether module P.M exists in
filesystem.
-e. Race conditions, where somebody modifies a file while we're
- processing. I propose not to modify the algorithm to handle this,
- b... | [find_modules_recursive->[BuildSource,find_module,find_modules_recursive],verify_module->[is_file],process_graph->[add_stats,trace,log],_build->[BuildSourceSet,BuildResult],BuildManager->[all_imported_modules_in_file->[correct_rel_imp,import_priority],log_fine_grained->[log],get_stat->[maybe_swap_for_shadow_path],repor... | The main entry point for the dependency manager. This is a bug in the activestate. | Maybe keep the bullet with the first sentence and replace the rest with "Solved by FileSystemClass"? |
@@ -258,7 +258,7 @@ def install_req_from_line(
elif '=' in req and not any(op in req for op in operators):
add_msg = "= is not a valid operator. Did you mean == ?"
else:
- add_msg = traceback.format_exc()
+ add_msg = ""
raise Installa... | [install_req_from_editable->[parse_editable],parse_editable->[_strip_extras],install_req_from_line->[deduce_helpful_msg,_strip_extras]] | Creates an InstallRequirement from a line of setup. py filename or URL. Install a missing - check constraint for a missing - check requirement. | Ideally, I'd say we'd llike an additional `logger.debug()` to have the traceback in verbose mode |
@@ -180,7 +180,7 @@ public class VirtualRoutingResource {
boolean finalResult = false;
for (ConfigItem configItem : cfg) {
long startTimestamp = System.currentTimeMillis();
- ExecutionResult result = applyConfigToVR(cmd.getRouterAccessIp(), configItem);
+ ExecutionRe... | [VirtualRoutingResource->[connect->[connect],execute->[generateCommandCfg,applyConfigToVR],applyConfigToVR->[applyConfigToVR],applyConfig->[applyConfigToVR]]] | This method applies the given config to the VR and returns the answer. | @insom Since you're now checking the timeout's validity when calling `applyConfigToVR` shouldn't the last parameter passed through this call be `timeout` instead of `VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT`? |
@@ -26,6 +26,8 @@ from .runtime.settings import get_root_resource
from .metadata import get_project, get_stack
+from . import _types
+
if TYPE_CHECKING:
from .output import Input, Inputs, Output
from .runtime.stack import Stack
| [ResourceOptions->[merge->[ResourceOptions]],CustomResource->[__init__->[__init__]],ProviderResource->[__init__->[__init__]],Resource->[_convert_providers->[_convert_providers],__init__->[ResourceTransformationArgs,ResourceOptions,inherited_child_alias,collapse_alias_to_urn]],ComponentResource->[__init__->[__init__]]] | Creates a new object of the Resource module containing all resource - related definitions. Compute the alias that should be applied to a child based on an alias applied to it s. | Why all the line breaks in the imports here? |
@@ -370,11 +370,12 @@ func unversionedRESTMux(grpcURI string, dopts []grpc.DialOption) (http.Handler,
func versionedRESTMux(grpcURI string, dopts []grpc.DialOption, toggles gwRouteFeatureFlags) (http.Handler, func(), error) {
endpointMap := map[string]registerFunc{
- "policies v2": pb_iam.RegisterPoliciesHandlerF... | [ProfileTarHandler->[Header,Write,Itoa,Error,Infof,Sprintf,Decode,authRequest,ComplianceProfilesServiceClient,Recv,GetData,NewDecoder,Split,Set,ReadTar],ProfileCreateHandler->[Copy,Write,Create,Error,Sprintf,Marshal,Decode,authRequest,Bytes,ComplianceProfilesServiceClient,Close,FormFile,Send,CloseAndRecv,Get,NewDecoder... | muxFromRegisterMap returns a mux that can be used to serve a single endpoint. Allocate a new for the REST Gateway. | should we drop `v2` from these? |
@@ -59,7 +59,12 @@ public class HudsonExceptionNote extends ConsoleNote<Object> {
text.addHyperlinkLowKey(charPos,end,annotateClassName(line.substring(charPos,end)));
return new ConsoleAnnotator() {
+ @Override
public ConsoleAnnotator annotate(Object context, MarkupText text)... | [HudsonExceptionNote->[annotate->[indexOf,annotateClassName,matches,ConsoleAnnotator,addHyperlinkLowKey,substring,getText,length],compile]] | Method to annotate a message with a key. | Should just be deleted, we have Git history. |
@@ -130,5 +130,12 @@ public class OMBucketAddAclRequest extends OMBucketAclRequest {
}
}
+ @Override
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ long trxnLogIndex, OzoneManagerDoubleBufferHelper omDoubleBufferHelper) {
+ ozoneManager.getMetrics().incNumAddAcl();
+ ... | [OMBucketAddAclRequest->[onComplete->[getPath,getAcls]]] | Called when the operation is complete. | How about moving this line after true `operationResult` branch of `onComplete()` at line-120 ? |
@@ -221,6 +221,10 @@ class PublishedArticleDAO extends ArticleDAO {
$publishedArticles[$currSectionId]['title'] = $publishedArticle->getSectionTitle();
}
}
+
+ // get galleys of the current version
+ $publishedArticle->setGalleys($this->galleyDao->getBySubmissionId($row['submission_id'], null, $publi... | [PublishedArticleDAO->[getPublishedArticlesInSections->[_getArticlesInSectionsCache],getPublishedArticleByBestArticleId->[getPublishedArticleByPubId,getByArticleId],getPublishedArticleByPubId->[_getPublishedArticleCache],getByArticleId->[_getPublishedArticleCache]]] | Get all published articles in a section of an issue Required section. | do we not get this already above with _fromRow? -- if we look after the MAX(ss.submission_revision)? |
@@ -0,0 +1,12 @@
+package presenters
+
+type LogResource struct {
+ JAID
+ LogLevel string `json:"logLevel"`
+ LogSql bool `json:"logSql"`
+}
+
+// GetName implements the api2go EntityNamer interface
+func (r LogResource) GetName() string {
+ return "logs"
+}
| [No CFG could be retrieved] | No Summary Found. | You can omit the `Log` prefix from these fields as they are already inside a `LogResource` |
@@ -110,4 +110,14 @@ class WPSEO_OnPage_Option {
return get_option( self::OPTION_NAME, array( self::STATUS => self::NOT_FETCHED, self::LAST_FETCH => 0 ) );
}
+ /**
+ * @deprecated 3.0.2
+ *
+ * Returns the indexable status of the website.
+ *
+ * @return bool
+ */
+ public function is_indexable() {
+ _dep... | [WPSEO_OnPage_Option->[__construct->[get_option]]] | Get the current configuration options. | We can just return `self::IS_INDEXABLE === $this->get_status()` |
@@ -362,7 +362,8 @@ define([
pickVertexShaderLoaded : getPickVertexShaderCallback(content),
pickFragmentShaderLoaded : batchTable.getPickFragmentShaderCallback(),
pickUniformMapLoaded : batchTable.getPickUniformMapCallback(),
- addBatchIdToGeneratedShaders : (batchLengt... | [No CFG could be retrieved] | The base shader for the pick - pick - model. The batched version of the update method. | Remove all occurrences of `pickPrimitive` now that there's `pickInfo`. Also `pickObject` may be a better name now. Also include `primitive` (= tileset) and `content` into the pick object. Create the pick object as a variable above so this area is cleaner. |
@@ -31,6 +31,7 @@ var expectedGroupPreferredVersions []string = []string{
// keep this sorted:
"apps/v1beta1,authentication.k8s.io/v1",
"authorization.k8s.io/v1",
+ "authorization.openshift.io/v1",
"autoscaling/v1",
"batch/v1",
"certificates.k8s.io/v1beta1",
| [AnyResourcesForVersionEnabled,Join,DeepEqual,Duration,Sort,AllPreferredGroupVersions,NewCMServer,NewServerRunOptions,Errorf,StringDiff,ObjectReflectDiff,ParseIP,Logf,NewSchedulerServer,AllResourcesForVersionEnabled] | The list of expected versions TestClusterConfig creates a new config with the specified name and version. | @deads2k this makes no sense to me. |
@@ -6,14 +6,15 @@ class ClassifiedListingsController < ApplicationController
before_action :authenticate_user!, only: %i[edit update new dashboard]
def index
- @displayed_classified_listing = ClassifiedListing.find_by!(slug: params[:slug]) if params[:slug]
+ published_listings = ClassifiedListing.where(pu... | [ClassifiedListingsController->[new->[new],create->[new]]] | This view shows the next n - ary listing for a given category. | Should this still be `find_by!` with the exclamation point? |
@@ -120,7 +120,7 @@ class InstanceImpl<T> implements Instance<T> {
}
@Override
- public void destroy(T instance) {
+ public void destroy(Object instance) {
Objects.requireNonNull(instance);
if (instance instanceof ClientProxy) {
ClientProxy proxy = (ClientProxy) instance... | [InstanceImpl->[destroy->[destroy],getBeanInstance->[get],InstanceIterator->[next->[next,getBeanInstance],hasNext->[hasNext],iterator]]] | Destroy the given instance. | Why `Object`, the instance should still be of type `T`, right? |
@@ -5082,10 +5082,10 @@ acls:
class FaucetTaggedGlobalIPv4RouteTest(FaucetTaggedTest):
- def _vids():
- return [i for i in range(100, 148)]
+ def _vids(): # pylint: disable=no-method-argument,no-self-use
+ return range(100, 148)
- def global_vid():
+ def global_vid(): # pylint: disabl... | [FaucetUntaggedIPv6ControlPlaneFuzzTest->[test_fuzz_controller->[note]],InfluxPostHandler->[do_POST->[_log_post]],Faucet8021XFailureTest->[test_untagged->[require_lag_status->[],learn_then_down_hosts->[],port_up->[],post_test_checks,try_8021x]],Faucet8021XMABTest->[test_untagged->[require_lag_status->[],learn_then_down... | Return a list of all the unique vids. | W1638 range built-in referenced when not iterating |
@@ -430,6 +430,7 @@ class FuseOperations(llfuse.Operations, FuseBackend):
data_cache_capacity = int(os.environ.get('BORG_MOUNT_DATA_CACHE_ENTRIES', os.cpu_count() or 1))
logger.debug('mount data cache capacity: %d chunks', data_cache_capacity)
self.data_cache = LRUCache(capacity=data_cache_ca... | [FuseOperations->[listxattr->[get_item,get],readdir->[getattr],lookup->[check_pending_archive,getattr],__init__->[get,__init__],opendir->[check_pending_archive],getxattr->[get_item,get],mount->[fuse_main,_create_filesystem,pop_option],readlink->[get_item],getattr->[get_item,get],read->[get_item,get],open->[get_item]],F... | Initialize the FuseBackend. | guess we'll need capacity > 1 if parallel reading of more than a file should perform better? |
@@ -77,10 +77,7 @@ const (
func newStoreInfo(opt *config.ScheduleConfig, store *core.StoreInfo) *StoreInfo {
s := &StoreInfo{
- Store: &MetaStore{
- Store: store.GetMeta(),
- StateName: store.GetState().String(),
- },
+ Store: NewMetaStore(store.GetMeta(), store.GetState().String()),
Status: &StoreSt... | [SetStoreLimitScene->[SetStoreLimitScene,Get],SetAllLimit->[Get],SetState->[Get],GetStoreLimitScene->[GetStoreLimitScene,Get],GetAllLimit->[Get],SetLimit->[Get]] | newStoreInfo returns a new StoreInfo instance with all of the fields of the given store Score returns a score of the current state of the object. | Why not just copy a `metapb.Store` here and set the `State` field to empty? |
@@ -116,13 +116,13 @@ public class DefaultJmxSupportAgent extends AbstractAgent
// there must be only one jmx agent, so lookup by type instead
if (registry.lookupObject(AbstractJmxAgent.class) == null)
{
- registry.registerAgent(agent);
+ registerAgen... | [DefaultJmxSupportAgent->[initialise->[getRegistry,registerAgent,unregisterAgent,InitialisationException,createJdmkAgent,lookupObject,createJmxAgent,createProfilerAgent,createJmxNotificationAgent,createMx4jAgent,isAgentRegistered,createRmiAgent],createJdmkAgent->[JdmkAgent],setHost->[warn],setLoadLog4jAgent->[warn],cre... | Initialise the agent. | Should not be the other agents also initialised before register them? |
@@ -434,10 +434,13 @@ public class IdleStateHandler extends ChannelDuplexHandler {
if (buf != null) {
int messageHashCode = System.identityHashCode(buf.current());
long pendingWriteBytes = buf.totalPendingWriteBytes();
+ long flushProgress = buf.currentProgr... | [IdleStateHandler->[schedule->[schedule],channelRegistered->[channelRegistered],channelInactive->[channelInactive],write->[write],WriterIdleTimeoutTask->[run->[schedule,newIdleStateEvent,channelIdle,ticksInNanos,hasOutputChanged]],channelActive->[channelActive],ReaderIdleTimeoutTask->[run->[channelIdle,schedule,ticksIn... | Checks if the channel has output changed. | I would perform the assignment to flushProgress and the check directly on the if expression to avoid the currentProgress() load to happen regardless the pendingWriteBytes value |
@@ -232,8 +232,14 @@ public class PutFile extends AbstractProcessor {
final Path rootDirPath = configuredRootDirPath.toAbsolutePath();
String filename = flowFile.getAttribute(CoreAttributes.FILENAME.key());
final Path tempCopyFile = rootDirPath.resolve("." + filename);
- ... | [PutFile->[onTrigger->[getValue,getParent,asFileAttribute,equals,getElapsed,renameTo,SimpleDateFormat,toString,warn,setLastModified,info,toFile,setGroup,setPosixFilePermissions,setOwner,getTime,lookupPrincipalByGroupName,getFileAttributeView,exportTo,isEmpty,transfer,getAttribute,ProcessException,error,debug,asBoolean,... | On trigger. check if there is a missing file in the output directory and if so penalize it Private method to handle the case where the file is not found in the system. This method is called when a dot copy file is created. | I would provide the two path values that were compared/tested so the user can understand what really happened. |
@@ -44,7 +44,7 @@ class ChatChannel < ApplicationRecord
end
def clear_channel
- messages.delete_all
+ messages.destroy_all
Pusher.trigger(pusher_channels, "channel-cleared", { chat_channel_id: id }.to_json)
true
rescue Pusher::Error => e
| [ChatChannel->[adjusted_slug->[direct?],pusher_channels->[invite_only?,open?],user_obj->[last_opened_at]]] | clear_channel Clear the next non - nil channel in the push. | This is necessary because not chat_channels and messages are bound with a foreign key constraint, thus messages with no chat channel id are no longer valid (and existing ones have been removed prior to those foreign keys migrations anyway) |
@@ -714,7 +714,9 @@ public abstract class AbstractTestQueries
" approx_percentile(orderkey, 0.5), " +
" approx_percentile(totalprice, 0.5)," +
" approx_percentile(orderkey, 2, 0.5)," +
- " approx_percentile(totalprice, 2, 0.5)\n" +
+ ... | [AbstractTestQueries->[assertExplainDdl->[assertExplainDdl]]] | This test method checks that the order key and total price are within 1% of requested rank This method checks if there is a free free key in the totalPrices and totalPriceWeight. | @martint error seems to be coming from here? I don't see anything wrong, any insight? > [ERROR] TestJdbcDistributedQueries>AbstractTestQueries.testApproxPercentile:712->AbstractTestQueryFramework.computeActual:113->AbstractTestQueryFramework.computeActual:118 Runtime |
@@ -65,8 +65,8 @@ class CertificateClient(AsyncKeyVaultClientBase):
:param bool enabled: Determines whether the object is enabled.
:param tags: Application specific metadata in the form of key-value pairs.
:type tags: dict(str, str)
- :returns: The created CertificateOperation
- ... | [CertificateClient->[get_deleted_certificate->[get_deleted_certificate],get_certificate->[get_certificate],restore_certificate->[restore_certificate],get_certificate_operation->[get_certificate_operation],recover_deleted_certificate->[recover_deleted_certificate],delete_certificate_operation->[delete_certificate_operat... | Creates a new certificate. Create a new certificate in Vault. | I'd link to `Certificate` and `CertificateOperation` here. |
@@ -351,8 +351,7 @@ public class ECKeyOutputStream extends KeyOutputStream {
try {
// Since it's a fullcell, let's write all content from buffer.
writeToOutputStream(current, len, bytesToWrite.array(),
- bytesToWrite.array().length, 0, current.getWrittenDataLength(),
- isP... | [ECKeyOutputStream->[getXceiverClientFactory->[getXceiverClientFactory],writeToOutputStream->[write],Builder->[build->[ECKeyOutputStream]],getStreamEntries->[getStreamEntries],checkAndWriteParityCells->[handleStripeFailure],getExcludeList->[getExcludeList],getLocationInfoList->[getLocationInfoList],closeCurrentStreamEn... | Write the data to the output stream. | if we remove the changes to writeLen, during the exception handling, then we can just increase the offset before the write in the try block. Though I am not sure why this change is happening, can you share some reasoning? The original idea here is that there might be a partial write, and if that happened, we wanted to ... |
@@ -65,6 +65,7 @@ public class RemoteInterpreterContext implements org.apache.thrift.TBase<RemoteI
private static final org.apache.thrift.protocol.TField GUI_FIELD_DESC = new org.apache.thrift.protocol.TField("gui", org.apache.thrift.protocol.TType.STRING, (short)8);
private static final org.apache.thrift.protoco... | [RemoteInterpreterContext->[RemoteInterpreterContextStandardScheme->[write->[validate],read->[setReplNameIsSet,setParagraphTitleIsSet,setAuthenticationInfoIsSet,setParagraphTextIsSet,setConfigIsSet,setLocalPropertiesIsSet,validate,setNoteIdIsSet,setParagraphIdIsSet,setGuiIsSet,setNoteGuiIsSet]],findByThriftIdOrThrow->[... | This method gets all fields from the Thrift protocol. Required context object. | You miss the thrift file change. |
@@ -510,14 +510,11 @@ func (s *Server) ProfileTarHandler(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Length", contentLength)
w.Header().Set("Content-Type", "application/x-gzip")
w.Header().Set("Accept-Ranges", "bytes")
- w.Write(data.GetData())
+ w.Write(data.GetData()) // nolint: errch... | [ProfileTarHandler->[Context,Header,Write,Itoa,Error,Infof,Sprintf,Decode,WithCancel,authRequest,ComplianceProfilesServiceClient,Recv,GetData,NewDecoder,Split,Set,ReadTar],ProfileCreateHandler->[Context,authRequest,Close,Copy,Error,Marshal,CloseAndRecv,Bytes,Create,Send,Get,NewDecoder,Split,Query,Write,Sprintf,Decode,W... | ProfileTarHandler handles a profile tar request. ReportExportHandler returns a handler for the report export endpoint NewDecoder - creates a new decoder for the protocol buffer. | It's not really your responsibility to fix this in this PR, but these functions silently failing when trying to write data seems like a big deal... |
@@ -115,6 +115,16 @@ module Dependabot
end
# rubocop:enable Metrics/PerceivedComplexity
+ def local_tag_for_pinned_version
+ return unless pinned?
+
+ ref = dependency_source_details.fetch(:ref)
+ tags = local_tags.select { |t| t.commit_sha == ref }
+ return if tags.empty?
+
+ ta... | [GitCommitChecker->[pinned_ref_looks_like_commit_sha?->[pinned?],pinned?->[git_dependency?],pinned_ref_in_release?->[pinned?,git_dependency?],branch_behind_release?->[git_dependency?],head_commit_for_current_branch->[pinned?],pinned_ref_looks_like_version?->[pinned?],wants_prerelease?->[pinned_ref_looks_like_version?]]... | Checks if a node is a node in the git repository that is reachable from local upload pack. | This probably needs a sort first - e.g. if a single commit is tagged with `v2.3.4`, `v2.3` and `v2`. That's a common pattern. |
@@ -33,7 +33,10 @@ class TestDistMnistNCCL2DGC(TestDistBase):
if fluid.core.is_compiled_with_cuda():
self.check_with_place(
"dist_mnist.py",
- delta=1e-5,
+ # FIXME(wangxi): DGC may need a new unit test because its algo flow
+ # is qui... | [TestDistMnistNCCL2DGCMultiCards->[test_dist_train->[check_with_place_multi_cards,is_compiled_with_cuda]],TestDistMnistNCCL2DGC->[test_dist_train->[check_with_place,is_compiled_with_cuda]],splitext,main] | Check if missing missing data is train. | How to assert when DGC be disabled? |
@@ -2820,7 +2820,9 @@ describes.fakeWin('Resources.add/upgrade/remove', {amp: true}, env => {
});
});
- it('should not schedule pass when immediate build fails', () => {
+ // TODO(amphtml, #15748): Fails on Safari 11.1.0.
+ it.configure().skipSafari('should not schedule pass when immediate ' +
+ 'buil... | [No CFG could be retrieved] | Tests that the elements in the page are built immediately if the document is ready. Add element to pending build when document is ready. | Ditto here. /cc @jridgewell |
@@ -1,6 +1,10 @@
import django_filters
from graphene_django.filter import GlobalIDMultipleChoiceFilter
+from saleor.graphql.core.filters import EnumFilter
+from saleor.graphql.warehouse.enums import WarehouseClickAndCollectOptionEnum
+from saleor.warehouse import WarehouseClickAndCollectOption
+
from ...warehouse.... | [filter_search_warehouse->[prefech_qs_for_filter]] | This function is a decorator to provide a filter that can be used to filter a queryset by Input method for the StockFilterSet. | It's should be relative imports. |
@@ -289,3 +289,10 @@ def merge_dict(to_update: dict, other_dict: dict):
merge_dict(to_update[key], value)
else:
to_update[key] = value
+
+
+def optional_address_to_string(address: typing.Address = None) -> typing.Optional[str]:
+ if address is None:
+ return None
+
+ retu... | [lpex->[pex],privatekey_to_publickey->[ishash],merge_dict->[merge_dict],publickey_to_address->[sha3],get_contract_path->[get_project_root,get_relative_path],eth_sign_sha3->[sha3],privtopub->[privatekey_to_publickey],privatekey_to_address->[publickey_to_address,privatekey_to_publickey]] | merges a dict into a dict. | the `optional_` prefix is used to indicate the type of return value which IMO is not required. `address_to_string` should suffice. |
@@ -68,11 +68,13 @@ class WPSEO_Configuration_Structure {
* @param string $identifier Identifier for this step.
* @param string $title Title to display for this step.
* @param array $fields Fields to use on the step.
+ * @param bool $navigaton Show navigation buttons.
*/
- protected function a... | [WPSEO_Configuration_Structure->[__construct->[add_step,get_identifier,get_fields]]] | Adds a step to the list of steps. | I think there is a typo in `$navigaton` ??? |
@@ -381,9 +381,15 @@ frappe.ui.Page = Class.extend({
}
} else {
- return $('<button class="btn btn-default btn-xs" style="margin-left: 10px;">'+__(label)+'</btn>')
- .on("click", _action)
- .appendTo(this.inner_toolbar.removeClass("hide"));
+ var button = this.inner_toolbar.find('button')
+ .filte... | [No CFG could be retrieved] | Add button to button group. Private functions - Menu menu. | I don't think it is a good idea to make `add_inner_button ` take so many decisions. It should be fixed at it's usage. |
@@ -3137,7 +3137,13 @@ namespace Js
} autoRestore(this->GetThreadContext());
+ // xplat-todo: (obastemur) Enable JIT on Debug mode
+ // CodeGen entrypoint can be deleted before we are able to unregister
+ // due to how we handle xdata on xplat, resetting the entrypoints below might aff... | [No CFG could be retrieved] | On debugger detach or detach a function from the debugger. END TRANSLATE_OOM_TO_HRESULT_NESTED - This. | Can we open a tracking issue for this? |
@@ -94,7 +94,7 @@ module Users
end
def handle_unsuccessful_password_reset(result)
- if result.errors[:reset_password_token]
+ if result.errors[:reset_password_token].present?
flash[:error] = t('devise.passwords.token_expired')
redirect_to new_user_password_path
return
| [ResetPasswordsController->[update->[new],build_user->[new],edit->[new],create->[new],new->[new]]] | if the user has not received a password reset token redirect to the new user password path otherwise. | Was this related to the Rails upgrade in some way, or just catching a best practice? |
@@ -11,7 +11,7 @@ exports.config = {
],
capabilities: {
- 'browserName': 'chrome',
+ 'browserName': 'firefox',
'phantomjs.binary.path': require('phantomjs').path,
'phantomjs.ghostdriver.cli.args': ['--loglevel=DEBUG']
},
| [No CFG could be retrieved] | Config for the jasmine2 - browser. | why are you using Firefox instead of Chrome? |
@@ -109,7 +109,7 @@ public class OnwireClassRegistry {
if (filePath != null) {
// WINDOWS HACK
if (filePath.indexOf("%20") > 0)
- filePath = filePath.replaceAll("%20", " ");
+ filePath = filePath... | [OnwireClassRegistry->[getFromDirectory->[getFromDirectory],getClasses->[getClasses]]] | This method returns a set of classes that are available in the given package. | @bd2019us did you intent to make this one a char as well, instead of " ", ' '? |
@@ -18,6 +18,7 @@ static void print_help()
"Commands:\n"
"\tdump - Print the contents of a database file\n"
"\tdiagnose - Assess the health of one or more database files\n"
+ "\tbackup - Copy database files to a timestamped folder\n"
"\tversion - Print version information\n"
... | [void->[printf],main->[diagnose_main,StringEndsWith,print_help,lmdump_main,StringSafeEqual_IgnoreCase,printf,print_version]] | Prints help for the given missing - block block. | Should we not allow an arg of file glob like `/var/cfengine/state/*.lmdb` and instead just use that path always since we mention "database files"? |
@@ -31,6 +31,6 @@ class HelpCommand(Command):
raise CommandError(' - '.join(msg))
command = commands_dict[cmd_name]()
- command.parser.print_help()
+ command.print_help()
return SUCCESS
| [HelpCommand->[run->[get_similar_commands,append,CommandError,print_help,join]]] | Run the command. | Maybe pass verbose=True here? or even options.verbose? |
@@ -435,6 +435,12 @@ public class VirtualMachineManagerImpl extends ManagerBase implements VirtualMac
final VirtualMachineProfileImpl vmProfile = new VirtualMachineProfileImpl(vmFinal, template, serviceOffering, null, null);
+ Long rootDiskSize = rootDiskOfferingInfo.getSize();
+ if (vm.getTy... | [VirtualMachineManagerImpl->[migrateWithStorage->[expunge],orchestrateStart->[areAffinityGroupsAssociated,orchestrateStart,changeState,setupAgentSecurity,getVmGuru,changeToStartState,findById],replugNic->[findById],migrateVmForScaleThroughJobQueue->[VmJobVirtualMachineOutcome],upgradeVmDb->[findById],scanStalledVMInTra... | Allocate a virtual machine from a template. allocate disks for final image check if there is a nagios object in the VM pool. | @ustcweizhou should there be a check for `> 0` ? |
@@ -28,6 +28,7 @@ import java.io.OutputStream;
/**
*/
+@Deprecated
public class FileOutputSupplier implements OutputSupplier<OutputStream>
{
private final File file;
| [FileOutputSupplier->[getOutput->[FileOutputStream]]] | Output Supplier for a single . | Needs a "use XXX instead" note |
@@ -1060,9 +1060,10 @@ public class ErrataHandler extends BaseHandler {
List<Errata> errataToClone = new ArrayList<Errata>();
List<Long> errataIds = new ArrayList<Long>();
+ Optional<Org> originalChannelOrg = ofNullable(original).map(c -> c.getOrg());
//We loop through once, making s... | [ErrataHandler->[publishAsOriginal->[publish,lookupErrata],cloneAsOriginalAsync->[clone],lookupVendorAndUserErrataByAdvisoryAndOrg->[lookupVendorAndUserErrataByAdvisoryAndOrg],create->[getRequiredAttribute],cloneAsOriginal->[clone],delete->[lookupErrata],cloneAsync->[clone],clone->[clone,lookupErrata],publish->[publish... | Clones an errata of the given type. Clones the errata in the channel if it has not yet finished. | Are we sure this is the only place where we should use the new method? |
@@ -130,6 +130,11 @@ public abstract class AbstractTestingPrestoClient<T>
properties.put(connectorProperties.getKey() + "." + entry.getKey(), entry.getValue());
}
}
+ for (Entry<CatalogName, Map<String, String>> connectorProperties : session.getConnectorProperties().entrySe... | [AbstractTestingPrestoClient->[tableExists->[execute,tableExists],execute->[getResultSession,execute],listTables->[execute,listTables]]] | Creates a new client session from a session. | Had to add this because I was running into a problem where the `allow_aggregation_pushdown` property was being dropped in the transaction block. |
@@ -30,7 +30,7 @@ function crepair_init(App $a)
if (DBA::isResult($contact)) {
$a->data['contact'] = $contact;
- Profile::load($a, "", 0, Contact::getDetailsByURL($contact["url"]));
+ Profile::load($a, "", 0, Module\Contact::getDetailsByURL($contact["url"]));
}
}
| [No CFG could be retrieved] | Create a new contact Contact settings. | This method is in `Model\Contact`. |
@@ -151,12 +151,13 @@ public class SpecificSegmentQueryRunner<T> implements QueryRunner<T>
);
}
- private void appendMissingSegment(Map<String, Object> responseContext)
+ private void appendMissingSegment(ResponseContext responseContext)
{
- List<SegmentDescriptor> missingSegments = (List<SegmentDescr... | [SpecificSegmentQueryRunner->[doNamed->[get],run->[makeYielder->[close->[close],isDone->[isDone],get->[get],next->[next]],toYielder->[toYielder],accumulate->[accumulate],run],appendMissingSegment->[get]]] | Override to provide a sequence that can be used to generate a sequence of segments. Override to provide a sequence that can be used to handle missing segments. | - Did you explore if this method can belong to ResponseContext? - This block looks like `computeIfAbsent()`. |
@@ -51,6 +51,7 @@ function pushBuildWorkflow() {
jobName,
`${experiment} is expired, misconfigured, or does not exist`
);
+ reportTestSkipped();
}
}
| [No CFG could be retrieved] | Runs the given job pushing the build workflow if necessary. | When called from within a `gulp` task, `reportTestSkipped()` infers the test type from the command line. I don't believe calling it from within `experiment-tests.js` will do anything because this is the job script wrapper and there is no `gulp` task running at this point. One option is to change `reportAllExpectedTests... |
@@ -49,6 +49,18 @@ public class RemoteTaskRunnerConfig extends WorkerTaskRunnerConfig
@Min(1)
private int pendingTasksRunnerNumThreads = 1;
+ @JsonProperty
+ @Min(1)
+ private int maxRetriesBeforeBlacklist = 5;
+
+ @JsonProperty
+ @Min(60000)
+ private long taskBlackListBackoffTimeMillis = 900000;
+
+ @J... | [RemoteTaskRunnerConfig->[hashCode->[hashCode],equals->[equals]]] | Returns the period after which the task assignment should be scheduled. | Can we switch this to a Period? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.