patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1461,8 +1461,13 @@ class Database
$row = $this->fetchFirst($sql, $condition);
- // Ensure to always return either a "null" or a numeric value
- return is_numeric($row['count']) ? (int)$row['count'] : $row['count'];
+ if (empty($row['count'])) {
+ $this->logger->notice('Invalid count.', ['table' => $tabl... | [Database->[processlist->[toArray,p],isResult->[numRows],getVariable->[fetchFirst],reconnect->[disconnect,connect],p->[p,reconnect,replaceParameters,anyValueFallback],lastInsertId->[lastInsertId],close->[close],select->[p],lock->[e],selectFirst->[fetch],toArray->[fetch],unlock->[e],update->[e,replace],count->[fetchFirs... | Count the number of records matching the given conditions. | This would also be triggered when the `$row['count']` would be 0. |
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module Engine
+ module Game
+ module G1829
+ module Step
+ class CloseCompanyVoluntary < Engine::Step::BuyTrain
+ def process_close_company(_action)
+ @log << "#{company.name} is closed."
+ company.close!
+ @log... | [No CFG could be retrieved] | No Summary Found. | why do you need 2 logs? just have one |
@@ -451,7 +451,7 @@ class BBCode
// Only send proxied pictures to API and for internal display
if (!in_array($simplehtml, [self::INTERNAL, self::API])) {
return $image;
- } elseif ($uriid) {
+ } elseif ($uriid > 0) {
return Post\Link::getByLink($uriid, $image, $size);
} else {
return ProxyUtils::... | [BBCode->[limitBodySize->[get],scaleExternalImages->[isValid,getWidth,getHeight,get,scaleDown,getContentType,getBody,isSuccess],removePictureLinksCallback->[fetch,query,loadHTML,get,set,isSuccess,head,getHeader],convertShareCallback->[t],convert->[getUrlPath,t,getHostname,get],embedURL->[info],convertAttachment->[saveT... | Proxy the image to the API or the internal display. | Why did we need to be more specific? |
@@ -3648,10 +3648,12 @@ def is_unsafe_overlapping_overload_signatures(signature: CallableType,
return (is_callable_compatible(signature, other,
is_compat=is_more_precise_or_partially_overlapping,
is_compat_return=lambda l, r: not is_subtype(l,... | [TypeChecker->[analyze_async_iterable_item_type->[accept],visit_try_without_finally->[check_assignment,accept],visit_class_def->[accept],iterable_item_type->[lookup_typeinfo],visit_for_stmt->[accept_loop],visit_operator_assignment_stmt->[check_assignment,accept],check_return_stmt->[get_generator_return_type,accept,get_... | Checks if two overloaded function signatures may be unsafely overlapping. Checks if the signature and other are compatible with the . | TBH, I don't like the term "potential compatibility". Why not "partial overlap"? After all, IIUC, this is the same as `Union[A, B]` vs `Union[B, C]` but for arg counts. |
@@ -93,7 +93,7 @@ public class PlatformDatabaseMigration implements DatabaseMigration {
return;
}
- running.getAndSet(true);
+ running.set(true);
executorService.execute(new Runnable() {
@Override
public void run() {
| [PlatformDatabaseMigration->[doDatabaseMigration->[create,error,doRecreateWebRoutes,getAndSet,Date,doRestartContainer,doUpgradeDb,startInfo,stopInfo],startIt->[getName,isLocked,get,trace,unlock,tryLock,startAsynchronousDBMigration],doRecreateWebRoutes->[recreate,createIfTrace,startTrace],doRestartContainer->[stopTrace,... | Start asynchronous database migration. | this has nothing to do with this commit |
@@ -84,5 +84,15 @@ func ValidateControllerRegistrationSpecUpdate(new, old *core.ControllerRegistrat
return allErrs
}
+ kindTypeToPrimary := make(map[string]*bool, len(old.Resources))
+ for _, resource := range old.Resources {
+ kindTypeToPrimary[resource.Kind+resource.Type] = resource.Primary
+ }
+ for i, resou... | [Index,Sprintf,ValidateImmutableField,Forbidden,ValidateObjectMetaUpdate,Duplicate,DeepEqual,ValidateObjectMeta,Child,NewPath,Required] | allErrors - count all the n - node - node - node - node - node -. | I'm not sure if this validation makes sense because an operator can easily circumvent it by removing the resource from the list and adding it again afterwards. WDYT? |
@@ -243,8 +243,9 @@ func (s *Server) Run() {
// ServeHTTP hijack the HTTP connection and switch to RPC.
func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
- // Before hijacke any connection, make sure the pd is initialized.
+ // Before hijack any connection, make sure the pd is initialized.
if s... | [leaderTxn->[txn],Close->[Close],ServeHTTP->[Close,isClosed],StartEtcd->[StartEtcd]] | ServeHTTP implements the http. Handler interface. | Can the client handle this response properly? |
@@ -402,12 +402,17 @@ public class RestTestExecutor implements Closeable {
final ImmutableList<Response> expectedResponse = ImmutableList.of(queryResponse);
final ImmutableList<String> statements = ImmutableList.of(querySql);
+ final long waitMs = 10;
final long threshold = System.currentTimeMilli... | [RestTestExecutor->[waitForWarmStateStores->[verifyResponses],RqttAdminResponse->[verify->[replaceMacros,asJson]],query->[close],close->[close],RqttQueryResponse->[verify->[replaceMacros,asJson]]]] | Waits for a block of state stores to be warmed up. | Is this change related to this PR? When I run this locally with and without this change they both pass and the old code ran the code marginally faster. Given this is test code, why the change? |
@@ -120,7 +120,6 @@ def menu_item_create(request, menu_pk, root_pk=None):
msg = pgettext_lazy(
'Dashboard message', 'Added menu item %s') % (menu_item,)
messages.success(request, msg)
- update_menu(menu)
if root_pk:
return redirect(
'dashboard... | [ajax_menu_links->[get_group_repr->[get_obj_repr],get_group_repr]] | Create a new menu item. | Why is that? The menu is kept as `JSON` and we need to update it each time it changed. |
@@ -247,6 +247,11 @@ func (p *Provider) applicationFilter(app marathon.Application) bool {
constraintTags = append(constraintTags, label)
}
}
+ if p.FilterMarathonConstraints && app.Constraints != nil && len(*app.Constraints) > 0 {
+ for _, constraintParts := range *app.Constraints {
+ constraintTags = appe... | [getCircuitBreakerExpression->[getAppLabel],getFrontendName->[getServiceNameSuffix],hasMaxConnLabels->[getAppLabel],getWeight->[getLabel],getBasicAuth->[getLabel],hasLoadBalancerLabels->[getAppLabel],hasCircuitBreakerLabels->[getAppLabel],hasStickinessLabel->[getAppLabel],getMaxConnAmount->[getAppLabel],getHealthCheckP... | applicationFilter returns true if the application is allowed to run. | We can omit the last expression on the constraint length. |
@@ -58,7 +58,9 @@ def generate_text_table(data: Dict[str, Dict], stake_currency: str, max_open_tra
floatfmt=floatfmt, tablefmt="pipe") # type: ignore
-def generate_text_table_sell_reason(data: Dict[str, Dict], results: DataFrame) -> str:
+def generate_text_table_sell_reason(
+ data: Dict[st... | [generate_text_table_strategy->[round,tabulate,append,mean,sum,len,str,timedelta,items],generate_edge_table->[append,round,tabulate,items],generate_text_table_sell_reason->[round,tabulate,append,results,len,result],generate_text_table->[round,tabulate,append,mean,sum,len,str,timedelta,isnull]] | Generate small table outlining Backtest results . | I made a very small change to this section to align quotes to be identical with the lines prior to this. While i don't really care which quotes we use - i think within "the same area" we should try to be consistent when doing the same thing. Since it's VERY nitpicky, i made the change myself - hope you don't mind. |
@@ -204,7 +204,10 @@ func Compute(subComm *shard.Committee, epoch *big.Int) (*Roster, error) {
ourPercentage = ourPercentage.Add(member.OverallPercent)
}
- roster.Voters[staked[i].BlsPublicKey] = &member
+ // TODO: make sure external user's BLS key can be same as harmony's bls keys
+ if _, ok := roster.Vote... | [MarshalJSON->[Marshal,EncodeToString,MustAddressToBech32,Hex],String->[Marshal],SliceStable,Equal,Quo,NewDec,HarmonyVotePercent,OneDec,New,ZeroDec,InstanceForEpoch,ExternalVotePercent,IsZero,Sub,Add,Mul] | This function creates a new accommodateHarmonyVote struct for each member NewRoster creates a roster for the given shard ID. | do you need to print out a log if the abnormal situation is found? |
@@ -89,8 +89,6 @@ const WHITELISTED_KEYS = [
'disableAGC',
'disableAP',
'disableAudioLevels',
- 'disableDesktopSharing',
- 'disableDesktopSharing',
'disableH264',
'disableHPF',
'disableNS',
| [No CFG could be retrieved] | A helper function to create a unique identifier for a call. This function is a utility function that can be used to enable TCC and TCC -. | Does enableFeaturesBased need to be added in the whitelist? enableUserRolesBasedOnToken is added already. |
@@ -42,10 +42,10 @@ class Cblas(Package):
def patch(self):
mf = FileFilter('Makefile.in')
- mf.filter('^BLLIB =.*', 'BLLIB = %s/libblas.a' %
- self.spec['blas'].prefix.lib)
+ mf.filter('^BLLIB =.*', 'BLLIB = {0}'.format(
+ ' '.join(self.spec['blas'].libs.l... | [Cblas->[install->[install,mkdirp,make],patch->[FileFilter,filter],depends_on,version]] | Patch cblas. a to make all the missing libraries. | not that this should be blocking here, but: What about OSX? Will it also be `cblas_LINUX.a`? |
@@ -423,14 +423,10 @@ func LoadUser(arg LoadUserArg) (ret *User, err error) {
return ret, err
}
+ cacheUserServiceSummary(m, ret)
} else if !arg.publicKeyOptional {
m.Debug("No active key for user: %s", ret.GetUID())
-
- var emsg string
- if arg.self {
- emsg = "You don't have a public key; try `keyb... | [checkUIDName->[String],ToMerkleOpts,MetaContext,WithForceMerkleServerPolling,WithStaleOK,WithPublicKeyOptional,WithUID,checkUIDName,checkSelf,String,WithCachedOnly,resolveUID] | loadUser loads a user from the server. loadUserLoad returns the user in the system if it s in a known state. If. | @maxtaco I removed this old message about importing PGP keys |
@@ -194,13 +194,13 @@ namespace System.Text.Json
public static System.Threading.Tasks.ValueTask<TValue?> DeserializeAsync<[System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute(System.Diagnostics.CodeAnalysis.DynamicallyAccessedMemberTypes.PublicConstructors | System.Diagnostics.CodeAnalysis.Dyna... | [No CFG could be retrieved] | Deserialize a DynamicallyAccessedMembersAttribute. | rewritten by the generator presumably? |
@@ -58,7 +58,7 @@ func init() {
flags := saveCommand.Flags()
flags.BoolVar(&saveCommand.Compress, "compress", false, "Compress tarball image layers when saving to a directory using the 'dir' transport. (default is same compression type as source)")
flags.StringVar(&saveCommand.Format, "format", v2s2Archive, "Save... | [StringVar,Wrapf,Join,Flag,SetHelpTemplate,SaveImage,Shutdown,GetString,StringVarP,GetRuntime,StringInSlice,Errorf,IsTerminal,ValidateFileName,SetUsageTemplate,BoolVarP,Flags,BoolVar] | saveCmd saves the imageID to a tar file or to a file if compress is set to true then compress is not set and output is set to stdout. | If the added above before terminal, here too. |
@@ -228,7 +228,9 @@ class TestModelPart(KratosUnittest.TestCase):
self.assertEqual(model_part.NumberOfProperties(), 0)
self.assertEqual(model_part.NumberOfProperties(0), 0)
+ self.assertEqual(model_part.HasProperties(1), False)
model_part.AddProperties(Properties(1))
+ self.as... | [TestModelPart->[test_model_part_conditions->[AddProperties,GetCondition,NumberOfConditions,CreateNewNode,assertEqual,len,RemoveConditionFromAllLevels,GetSubModelPart,Properties,assertRaises,CreateSubModelPart,CreateNewCondition,GetProperties,CreateModelPart,Model,RemoveCondition],test_add_element->[assertTrue,assertRa... | This method tests the properties of the model part. Updates the properties of the two inlets model parts. Tests that the model part has the n - th inlet and n - th inlet. | @philbucher this is a test |
@@ -41,11 +41,11 @@ const config = {
tokens: [],
messagingAccount: '0xBfDd843382B36FFbAcd00b190de6Cb85ff840118',
messaging: {
- messagingNamespace: 'origin',
- globalKeyServer: 'http://localhost:6647'
+ messagingNamespace: 'origin:dev',
+ globalKeyServer: 'https://messaging.dev.originprotocol.com'
... | [No CFG could be retrieved] | The gateway and RPC interfaces for the network interfaces. Config for the Nexus - Alembic - Alembic - Token -. | Just curious, we do not want the localhost to point to the local running messenger container? |
@@ -273,9 +273,12 @@ class PythonRuntimePackageDependencies(StringSequenceField):
"""Addresses to targets that can be built with the `./pants package` goal and whose resulting
assets should be included in the test run.
- Pants will build the asset as if it had run `./pants package`, and will include the ... | [PythonRequirementsField->[compute_value->[format_invalid_requirement_string_error]]] | Compute the value of a specific . A timeout for the number of seconds that the total runtime of all tests in this target covers. | Technically the "dist_dir" is configurable. But not sure that that level of detail is necessary here. |
@@ -1424,7 +1424,7 @@ class CI_DB_active_record extends CI_DB_driver {
$this->limit($limit);
}
- $sql = $this->_update($this->_protect_identifiers($this->ar_from[0], TRUE, NULL, FALSE), $this->ar_set, $this->ar_where, $this->ar_orderby, $this->ar_limit);
+ $sql = $this->_update($this->_protect_identifiers($t... | [CI_DB_active_record->[_reset_write->[_reset_run],update->[where,set,limit],get->[from,limit],get_compiled_select->[from],count_all_results->[from],delete->[delete,where,limit],insert->[set],_reset_select->[_reset_run],_track_aliases->[_track_aliases],get_where->[from,where,limit],replace->[set],_merge_cache->[_track_a... | Update a record in the database. | , , is not correct (at the end).... |
@@ -184,11 +184,13 @@ public class LiteralUtilsTest {
assertThat(LiteralUtils.is0xff(tree)).isFalse();
}
+ @Test
public void isTrue_withNonBooleanLiteral_returnsFalse() {
ExpressionTree tree = getFirstExpression("void foo(java.util.Properties props){ props.setProperty(\"myKey\", \"myValue\"); }");
... | [LiteralUtilsTest->[test_int_and_long_value->[startsWith,isEqualTo],setUp->[parse,toList,get,collect,File],isFalse_withNonBooleanLiteral_returnsFalse->[getFirstExpression,isFalse],getClassTree->[SquidClassLoader,parse,get,emptyList,createFor],testTrimQuotes->[isEqualTo],testTrimLongSuffix->[isEqualTo],private_construct... | Checks whether the return value is 0xff or 0x01. | Ouch! Can we think of a new rule to catch that? |
@@ -57,7 +57,7 @@ public class TestHiveTransactionalTable
throw new SkipException("Presto Hive transactional tables are supported with Hive version 3 or above");
}
- String tableName = "test_full_acid_table_read";
+ String tableName = format("test_full_acid_table_read_%s", randomTa... | [TestHiveTransactionalTable->[testReadFullAcid->[getHiveVersionMajor,compactTableAndWait,row,SkipException,valueOf,containsExactly,executeQuery,containsOnly,hiveTableProperties,getHiveClustering],testFailAcidBeforeHive3->[executeQuery,failsWithMessage,getHiveVersionMajor,SkipException],testReadInsertOnly->[getHiveVersi... | This test tests whether the table read is full acid. check if there is a row with a non - zero nagios in the table. | just use `"test_full_acid_table_read_" + randomTableSuffix()` (see other tests) |
@@ -302,9 +302,10 @@ def train_parallel(avg_loss, infer_prog, optimizer, train_reader, test_reader,
if iters == args.skip_batch_num:
start_time = time.time()
num_samples = 0
- if iters == args.iterations:
+ # NOTE: if use reader ops, the input data is... | [train_parallel->[test],main->[print_arguments,train,train_parallel,append_nccl2_prepare,dist_transpile,parse_args],train->[test],parse_args->[parse_args],main] | Train a single batch of data using parallel processing. Train a single . | I don't think `iters >= args.iterations / args.gpus` is appropriate. Because the model's accuracy is highly related to the new parameters that have learned, but the new parameters may be related to the times of updating parameter. So maybe we should not do that. |
@@ -67,7 +67,9 @@ namespace SystemTestServices
if (assemblyResolver == null)
{
assemblyResolver = new AssemblyResolver();
- assemblyResolver.Setup(testConfig.DynamoCorePath);
+ assemblyResolver.Setup(testConfig.DynamoCorePath, new [] {
+ ... | [SystemTestBase->[TearDown->[TearDown],Setup->[Setup],GetSublistItems->[GetSublistItems],StartDynamo->[GetLibrariesToPreload]]] | Initialize DynamoModelTest . | same as in another PR - would be good to check this does not cause issues on master-15 |
@@ -208,8 +208,11 @@ namespace System.Windows.Forms
// Calculate area for background box
Rectangle boxBounds = bounds;
- boxBounds.Y += font.Height / 2;
- boxBounds.Height -= font.Height / 2;
+ if (font is not null)
+ {
+ boxBounds.Y... | [GroupBoxRenderer->[DrawParentBackground->[DrawParentBackground],IsBackgroundPartiallyTransparent->[IsBackgroundPartiallyTransparent],DrawGroupBox->[DrawGroupBox]]] | Draw the themed group box with the text. Draw clipped portion of background in each segment in the device context. | Q: what happen when font is null? when do we expect it to be null here? |
@@ -64,7 +64,7 @@ class Extends
API_VERSIONS = ['20170715']
# Array used for injecting names of additional authentication methods for API
- API_PLUGABLE_AUTH_METHODS = []
+ API_PLUGABLE_AUTH_METHODS = [:azure_jwt_auth]
OMNIAUTH_PROVIDERS = [:linkedin]
| [No CFG could be retrieved] | This method is used to provide additional information about the repository rows. | Style/MutableConstant: Freeze mutable objects assigned to constants. |
@@ -55,8 +55,8 @@ public class JDBCExtractionNamespace implements ExtractionNamespace
final MetadataStorageConnectorConfig connectorConfig,
@NotNull @JsonProperty(value = "table", required = true)
final String table,
- @NotNull @JsonProperty(value = "keyColumn", required = true)
- final S... | [JDBCExtractionNamespace->[hashCode->[hashCode],toString->[toString],equals->[equals]]] | Creates an ExtractionNamespace for a given . Get the table name of the object. | We need to maintain backwards compatibility here; if someone provides "keyColumn" that should continue to work. |
@@ -32,15 +32,17 @@ public class OperationMessageProcessorObjectFactory extends AbstractExtensionObj
private final ExtensionModel extensionModel;
private final OperationModel operationModel;
+ private final PolicyManager policyManager;
private ConfigurationProvider configurationProvider;
private String... | [OperationMessageProcessorObjectFactory->[getObject->[inject,MuleRuntimeException,withContextClassLoader,createMessageProcessor,getClassLoader,getParametersAsResolverSet],createMessageProcessor->[isPresent,getExtensionManager,InterceptingOperationMessageProcessor,PagedOperationMessageProcessor,OperationMessageProcessor... | Returns a message processor that can be used to process the operation. | If you decide to keep the getter in the mule context then this new argument is unnecesary |
@@ -432,7 +432,17 @@ public class QueryElasticsearchHttp extends AbstractElasticsearchHttpProcessor {
Map<String, String> attributes = new HashMap<>();
for(Iterator<Entry<String, JsonNode>> it = source.fields(); it.hasNext(); ) {
Entry<String, JsonNode>... | [QueryElasticsearchHttp->[buildRequestURL->[getValue,isDynamic,getName,addPathSegment,addQueryParameter,getKey,newBuilder,url,MalformedURLException,isEmpty,collect,joining,entrySet,valueOf],onTrigger->[getValue,getMessage,equals,getPage,nanoTime,remove,buildRequestURL,yield,getLocalizedMessage,getClient,hasIncomingConn... | Gets a page of the response. This method is called when the client is requesting a response from Elasticsearch. get number of missing entries in page. | I think it might be better if the value of `separator` didn't change. What do you think about adding each item's text to an array and then doing something like a `StringUtils.join()` on it? |
@@ -52,6 +52,8 @@ import lombok.extern.slf4j.Slf4j;
@AllArgsConstructor
@Getter
public class CopyableDatasetRequestor implements PushDownRequestor<FileSet<CopyEntity>> {
+ private final static String CONF_PREFIX = CopyConfiguration.COPY_PREFIX + "." + CopyableDatasetRequestor.class.getSimpleName();
+ private final... | [CopyableDatasetRequestor->[getRequests->[iterator],Factory->[apply->[CopyableDatasetRequestor]]]] | Creates a new requestor that copies a file set into a file set. private IterableCopyableDatasetRequestor iterableCopyableDatasetRequestor ;. | Can you put the configuration key in `CopyConfiguration`? Also, a more descriptive and less specific key might be better. A suggestion might be `gobblin.copy.abortOnSingleDatasetFailure`. |
@@ -67,7 +67,13 @@ namespace Dynamo.ViewModels
private readonly DynamoModel model;
private Point transformOrigin;
private bool showStartPage = false;
-
+
+ private ObservableCollection<SimpleViewModel<string>> defaultPythonEngineOptions = new ObservableCollection<SimpleViewMode... | [DynamoViewModel->[CanZoomOut->[CanZoomOut],SaveAs->[SaveAs,AddToRecentFiles,Save],ExportToSTL->[ExportToSTL],ShowOpenDialogAndOpenResult->[Open,CanOpen],ShowSaveDialogIfNeededAndSave->[SaveAs],ImportLibrary->[ImportLibrary],ReportABug->[ReportABug],ClearLog->[ClearLog],Escape->[CancelActiveState],ShowSaveDialogIfNeede... | Creates a view model which can be used to view a specific view model. is a property that can be set to a point in the model. | why the need for the field? |
@@ -69,12 +69,14 @@ public class KryoTranscoder implements Transcoder<Object> {
/** Logging instance. */
private final Logger logger = LoggerFactory.getLogger(getClass());
- /** Maximum size of single encoded object in bytes. */
- private final int bufferSize;
-
/** Map of class to serializer tha... | [KryoTranscoder->[encode->[CachedData,encodeToBytes],decode->[getData,wrap,readClassAndObject],encodeToBytes->[limit,getCause,get,writeClassAndObject,allocate,getBuffer,warn],initialize->[SimpleWebApplicationServiceSerializer,get,register,setRegistrationOptional,URLSerializer,RegisteredServiceSerializer,DateSerializer,... | Creates a transcoder that uses the kryo API. Register types we know about and do not require external configuration. | Lets mark this as final and initialize in the empty ctor. That would allow the ctor to actually do something useful. |
@@ -11,9 +11,13 @@ from collections import OrderedDict
MIN_SERVER_COMPATIBLE_VERSION = '0.12.0'
-default_settings_yml = """os: [Windows, Linux, Macos, Android, iOS, FreeBSD]
+default_settings_yml = """os: [Windows, Linux, Macos, Android, iOS, FreeBSD, SunOS]
arch: [x86, x86_64, ppc64le, ppc64, armv6, armv7, armv7... | [ConanClientConfigParser->[__init__->[__init__],storage->[get_conf],settings_defaults->[get_conf],proxies->[get_conf],_mix_settings_with_env->[get_env_value,get_setting_name]]] | Get the environment variables and values of a specific node. Creates a client config object that will read the configuration file and return the missing section. | maybe rename it to sun-cc? Just so people do not assume that this would be a generic C++ compiler |
@@ -540,7 +540,8 @@ path to the CMake binary directory, like this:
parser.add_argument("package", nargs="?", default="",
help='Package ID to regenerate. e.g., '
'9cf83afd07b678d38a9c1645f605875400847ff3'
- ' If not s... | [Command->[upload->[upload],copy->[copy],package->[package],test->[test_package],export->[export],info->[_get_tuples_list_from_extender_arg,_get_build_sources_parameter,_get_simple_and_package_tuples,info],install->[_get_tuples_list_from_extender_arg,install,_get_build_sources_parameter,_parse_args,_get_simple_and_pack... | Package a specific package with a specific recipe. | Maybe "If not specified, ALL binaries for this recipe are re-packaged" should be maintained? |
@@ -73,9 +73,9 @@ class ContainerClient(AsyncStorageAccountHostsMixin, ContainerClientBase):
:param str container_url:
The full URI to the container. This can also be a URL to the storage
account, in which case the blob container must also be specified.
- :param container:
- The contain... | [ContainerClient->[delete_blob->[delete_blob],upload_blob->[upload_blob]]] | This function returns either the primary endpoint or the secondary endpoint depending on the current location_mode Create a container client directly. | :type container_name: str or ~azure.storage.blob.ContainerProperties |
@@ -728,7 +728,15 @@ class TopicQuery
end
result = apply_ordering(result, options)
- result = result.listable_topics
+
+ all_listable_topics = @guardian.filter_allowed_categories(Topic.unscoped.listable_topics)
+
+ if options[:include_pms]
+ all_pm_topics = Topic.unscoped.private_messages_for_... | [TopicQuery->[list_suggested_for->[get_pm_params],default_results->[get_category_id,apply_ordering,apply_custom_filters],remove_muted_categories->[get_category_id],list_private_messages_sent->[not_archived],initialize->[valid_options],new_results->[new_filter],list_related_for->[get_pm_params],unread_messages->[unread_... | Returns a list of all the records that match the specified conditions. find - Finds a in the database. Returns a list of nodes that are referenced by a node in the system. Find all nodes in the system that match the specified object. | One thing I noticed while working on search is that querying for all the topics can be expensive and hard to optimize. How does the performance on this query look on a fairly large site? |
@@ -659,6 +659,8 @@ func FillOutSpecGen(s *specgen.SpecGenerator, c *ContainerCLIOpts, args []string
s.PidFile = c.PidFile
s.Volatile = c.Rm
+ // Initcontainers
+ s.InitContainerType = c.InitContainerType
return nil
}
| [CoresToPeriodAndQuota,Duration,ParseNamespace,RAMInBytes,Fields,Wrap,HasPrefix,ParseUserNamespace,ValidateSysctls,Atoi,UsernsMode,ParseUlimit,GetAllLabels,NamespaceMode,New,ParseIDMapping,Errorf,ParseInt,SplitN,Wrapf,Join,Contains,ToLower,ParseSlice,ParseUint,Split,ParseFile,IsDefaultValue,validate,Unmarshal,Environ,F... | makeHealthCheckFromCli creates a health check configuration from command line arguments. if cmdArr is not a list of consecutive commands it will be treated as a single command. | Replace this block with simply s.InitContainerType = c.InitContainerType |
@@ -41,6 +41,7 @@ MiddlewareRegistry.register(store => next => action => {
case SET_ROOM:
return _setRoom(store, next, action);
+ case PRESENTER_TRACK_ADDED:
case TRACK_ADDED: {
const result = next(action);
const { track } = action;
| [No CFG could be retrieved] | Registers a middleware function which is invoked when a feature base action is being dispatched. Determines if the application state has changed and dispatches the video mute event. | why is this needed? |
@@ -50,6 +50,8 @@ func (a *Configuration) SetDefaults() {
a.CAServer = lego.LEDirectoryProduction
a.Storage = "acme.json"
a.KeyType = "RSA4096"
+ a.RenewBeforeExpiry = 720
+ a.ExpirationCheckInterval = 1
}
// CertAndStore allows mapping a TLS certificate to a TLS store.
| [watchNewDomains->[resolveDomains],resolveCertificate->[getClient],renewCertificates->[addCertificateForDomain,getClient]] | SetDefaults sets the default values for the configuration. | Is there a reason to change the default interval from 24 hours to 1 hour? Probably better to maintain the old default if it is overridable? |
@@ -61,6 +61,12 @@ class CrfTagger(Model):
Used to initialize the model parameters.
regularizer : ``RegularizerApplicator``, optional (default=``None``)
If provided, will be used to calculate the regularization penalty during training.
+ top_k : ``int``, optional (default=``None``)
+ If... | [CrfTagger->[decode->[get_token_from_index],forward->[_feedforward,text_field_embedder,tag_projection_layer,metric,_f1_metric,viterbi_tags,get_text_field_mask,crf,encoder,float,enumerate,values,dropout],__init__->[get_index_to_token_vocabulary,SpanBasedF1Measure,CategoricalAccuracy,ConditionalRandomField,get_input_dim,... | Initialize a sequence tag model from a sequence of tags. This method converts a sequence of tags into a vocabulary. | The default here should match the constructor below. |
@@ -117,8 +117,10 @@ class FormProduct
{
$obj = $this->db->fetch_object($resql);
if ($sumStock) $obj->stock = price2num($obj->stock,5);
+ $o = new Entrepot($this->db);
+ $o->fetch($obj->rowid);
$this->cache_warehouses[$obj->rowid]['id'] =$obj->rowid;
- $this->cache_warehouses[$obj->rowid]['l... | [FormProduct->[formSelectWarehouses->[selectWarehouses],selectWarehouses->[loadWarehouses]]] | Load all Warehouses Load all Warehouses in the database. | For a better compatibility and to match other dolibarr code part, i suggest 2 changes: Keep here $this->cache_warehouses[$obj->rowid]['label']=$obj->label; and to introduce a new entry $this->cache_warehouses[$obj->rowid]['parent_id']=$obj->fk_parent; Then, instead of making a new and a fetch for each line, i suggest t... |
@@ -25,7 +25,7 @@ class CAR:
KIA_STINGER = "KIA STINGER GT2 2018"
KONA = "HYUNDAI KONA 2019"
KONA_EV = "HYUNDAI KONA ELECTRIC 2019"
- SANTA_FE = "HYUNDAI SANTA FE LIMITED 2019"
+ SANTA_FE = "HYUNDAI SANTA FE 2019-2020"
SANTA_FE_1 = "HYUNDAI SANTA FE has no scc"
SONATA = "HYUNDAI SONATA 2020"
SONATA_... | [dbc_dict] | Enumerate all possible values of the neccesary names of the individual node. The Eleanra Gt I30 table. 8 - bit mask for the sequence of numbers. | No need to change the year in the car name. |
@@ -4,6 +4,7 @@
# license information.
# -------------------------------------------------------------------------
+from typing import List
from .._models import JoinCallOptions, PlayAudioOptions
from .._generated.models import (
JoinCallRequest,
| [JoinCallRequestConverter->[convert->[JoinCallRequest,ValueError]],CancelMediaOperationRequestConverter->[convert->[ValueError,CancelMediaOperationRequest]],PlayAudioRequestConverter->[convert->[PlayAudioRequest,ValueError]],TransferCallRequestConverter->[convert->[ValueError,TransferCallRequest]],CancelAllMediaOperati... | Creates a new object of type NetworkCallRequest class. Converts a NetworkResponse to a NetworkResponse. | I didn't see List was used in this file, why we change this file, |
@@ -338,4 +338,15 @@ public class DefaultHttpListenerConfig extends AbstractAnnotatedObject implement
{
this.connectionIdleTimeout = connectionIdleTimeout;
}
+
+ @Override
+ public String toString() {
+ StringBuilder buf = new StringBuilder();
+ buf.append("org.mule.module.htt... | [DefaultHttpListenerConfig->[addRequestHandler->[addRequestHandler],createWorkManager->[createWorkManager],stop->[stop],start->[createWorkManager,start],listenerUrl->[getHost,getPort]]] | This method sets the connection idle timeout. | I don't think the full class name is necessary. |
@@ -30,15 +30,9 @@ final class DocumentationAction
/**
* Gets API doc.
- *
- * @param Request $request
- *
- * @return array
*/
- public function __invoke(Request $request)
+ public function __invoke() : JsonResponse
{
- $request->attributes->set('_api_format', 'json... | [DocumentationAction->[__invoke->[getApiDocumentation,set]]] | Returns the API documentation for the given request. | I really do not see why we should use the `JsonResponse` class at all. Content negotiation should take place for these requests as well... |
@@ -67,7 +67,7 @@ def build_wheels(builder, pep517_requirements, legacy_requirements, session):
# install for those.
builder.build(
legacy_requirements,
- session=session, autobuilding=True
+ autobuilding=True,
)
return build_failures
| [InstallCommand->[run->[build_wheels]],build_wheels->[is_wheel_installed]] | Build wheels for requirements depending on whether wheel is installed. | nit: Add trailing commas while we're changing this? |
@@ -0,0 +1,11 @@
+import paddle.v2.framework.core as core
+import paddle.v2.framework.proto.op_proto_pb2 as op_proto_pb2
+
+
+def get_all_op_protos():
+ protostrs = core.get_all_op_protos()
+ ret_values = []
+ for pbstr in protostrs:
+ op_proto = op_proto_pb2.OpProto.FromString(str(pbstr))
+ ret_... | [No CFG could be retrieved] | No Summary Found. | if this `str()` method the way to fix the Unicode problem? |
@@ -94,8 +94,12 @@ public class Kernel32Utils {
}
}
+ /**
+ * @deprecated Use {@link Util#isSymlink} to detect symbolic links and junctions instead.
+ */
+ @Deprecated
public static boolean isJunctionOrSymlink(File file) throws IOException {
- return (file.exists() && (Kernel32... | [Kernel32Utils->[isJunctionOrSymlink->[getWin32FileAttributes]]] | Creates a symbolic link. | Could deprecate `createSymbolicLink` now too, right? |
@@ -7,6 +7,7 @@ FactoryBot.define do
sequence(:x) { |n| n }
workflow_order { MyModule.where(experiment_id: experiment.id).count + 1 }
experiment
+ my_module_status
my_module_group { create :my_module_group, experiment: experiment }
trait :with_tag do
tags { create_list :tag, 3, projec... | [factory,tags,create,trait,days,workflow_order,project,sequence,between,create_list,due_date,today,define,my_module_group,count] | The task sequence is built in the order that they are created. | I wouldn't add it here. Could be a separate trait, because it is optional. |
@@ -41,7 +41,7 @@ namespace Dynamo.Interfaces
// Formats double value into string. E.g. 1054.32179 => "1054.32179"
// For more info: https://msdn.microsoft.com/en-us/library/kfsatb94(v=vs.110).aspx
private const string numberFormat = "g";
-
+ private static int listitems;
priv... | [DefaultWatchHandler->[ToString->[ToLower,ToString,ReferenceEquals,NullString],WatchViewModel->[GetElements,Count,ProcessThing,ToList,ClassName,IsNull,Add,GetDescription,IsFunctionPointer,Class,IsCollection,Empty,NullString,Select,idx,GetType,Any,NumberFormat,Data,DefaultDateFormat,ReferenceEquals,Name,callback,element... | The object that will be used to create the WatchViewModel. Missing string. | Looks it is not used. |
@@ -3181,6 +3181,15 @@ SSL_CTX *SSL_CTX_new_ex(OSSL_LIB_CTX *libctx, const char *propq,
if (ret == NULL)
goto err;
+ /* Init the reference counting before any call to SSL_CTX_free */
+ ret->references = 1;
+ ret->lock = CRYPTO_THREAD_lock_new();
+ if (ret->lock == NULL) {
+ ERR_raise(... | [No CFG could be retrieved] | This function compares two SSL_SESSION objects. Initialize the SSL object. | one could argue that this should be `goto err` in line with the earlier and later code flows. |
@@ -179,7 +179,7 @@ class SuggestionEngine:
if no_any:
self.flex_any = 1.0
- self.max_guesses = 16
+ self.max_guesses = 64
self.use_fixme = use_fixme
def suggest(self, function: str) -> str:
| [TypeFormatter->[visit_callable_type->[is_tricky_callable]],get_return_types->[ReturnFinder],is_implicit_any->[is_explicit_any],StrToText->[__init__->[builtin_type]],any_score_callable->[any_score_type],SuggestionEngine->[get_suggestion->[filter_options,get_trivial_type,SuggestionFailure,get_return_types,find_best,get_... | Initialize a new object with the given configuration. | An unrelated note: maybe we should make this configurable? |
@@ -4479,6 +4479,10 @@ class Program(object):
Args:
other(Program): Other program
+ pruned_origin_block_id_map(map{int:int}): A map from block id in self
+ to block id in other. For example, {0:0, 1:1, 2:3} means block 0 in self is
+ cloned from block 0 in othe... | [cuda_places->[is_compiled_with_cuda,_cuda_ids],_varbase_creator->[convert_np_dtype_to_dtype_],Program->[_construct_from_desc->[Program,_sync_with_cpp,Block],__repr__->[__str__],parse_from_string->[Program,_sync_with_cpp,Block],to_string->[_debug_string_,to_string],_version->[_version],_prune_with_input->[Program,_sync... | Copy the information of data variables from other program to self. | `map{int:int}` means `dict{int:int}` ? The type of `pruned_origin_block_id_map` is `dict` in Python. |
@@ -3930,7 +3930,7 @@ use \Friendica\Core\Config;
$success = array('success' => false, 'search_results' => 'nothing found');
else {
$ret = Array();
- foreach($r as $item) {
+ foreach ($r as $item) {
if ($box == "inbox" || $item['from-url'] != $profile_url){
$recipient = $user_info;
$send... | [api_oauth_access_token->[fetch_access_token,getMessage],api_oauth_request_token->[fetch_request_token,getMessage],api_friendica_notification->[getAll],api_error->[getMessage],api_friendica_notification_seen->[getByID,setSeen],api_statusnet_config->[get_hostname],api_statuses_mediap->[purify,set],api_statuses_update->[... | direct messages search api_format_direct_message_search - Format direct message search results. | Standards: Please add braces to the above condition. |
@@ -619,6 +619,13 @@ bool GUIChatConsole::OnEvent(const SEvent& event)
m_chat_backend->scroll(rows);
}
}
+#if defined(IRRLICHT_VERSION_MT_REVISION) && (IRRLICHT_VERSION_MT_REVISION >= 2)
+ else if(event.EventType == EET_STRING_INPUT_EVENT)
+ {
+ prompt.input(std::wstring(event.StringInput.Str->c_str()));
+ r... | [No CFG could be retrieved] | This function checks if the user has pressed a key press and if so calls the appropriate method. | Since this is client code you can count on `IRRLICHT_VERSION_MT_REVISION` being defined. |
@@ -46,10 +46,11 @@ def as_numpy(tensor):
assert isinstance(tensor, core.LoDTensor)
lod = tensor.lod()
tensor_data = np.array(tensor)
- if len(lod) == 0:
- ans = tensor_data
- else:
- raise RuntimeError("LoD Calculate lacks unit tests and buggy")
+ ans = tensor_data
+ # if len(l... | [Executor->[run->[global_scope,as_numpy,run,has_feed_operators,has_fetch_operators,aslodtensor],aslodtensor->[accumulate->[accumulate],parselod->[accumulate],parselod],__init__->[Executor]],as_numpy->[as_numpy],scope_guard->[switch_scope]] | Returns the tensor as a numpy array if the tensor is a LoD tensor. | I saw an related issue #8038 . #8038 seems failed here. I am not quite familiar with the codes. @kexinzhao could you please explain some about this? @qingqing01 could you have a look? |
@@ -45,6 +45,9 @@ func NewVMEvent(be types.BaseEvent) *VMEvent {
ee = events.ContainerMigrated
case *types.DrsVmMigratedEvent:
ee = events.ContainerMigratedByDrs
+ case *types.VmRelocatedEvent:
+ ee = events.ContainerRelocated
+
}
e := be.GetEvent()
return &VMEvent{
| [Topic->[Topic,NewEventType],GetEvent,String] | VMEvent returns a new VMEvent object based on the event. | same here, it would be great to see panic here for default use case. |
@@ -18,6 +18,13 @@ class OutputLOCAL(OutputBase):
REMOTE = RemoteLOCAL
sep = os.sep
+ def __init__(self, *args, **kwargs):
+ super().__init__(*args, **kwargs)
+
+ if self.repo and path_isin(self.def_path, self.repo.root_dir):
+ self.def_path = relpath(self.def_path, self.repo.roo... | [OutputLOCAL->[dumpd->[relpath,super],_parse_path->[abspath,lstrip,path_cls,fspath_py35,is_absolute,normpath,urlparse],is_in_repo->[urlparse,isabs],__str__->[str,path_isin,getcwd,relpath],verify_metric->[istextfile,DvcException,isdir,fspath_py35,format,exists]],getLogger] | Parse path and return path_cls object. | Tried to move from `base` to `local` but not sure about the distinction between `def_path` and `path_info` |
@@ -300,6 +300,11 @@ exports.extensionBundles = [
options: {hasCss: true},
type: TYPES.MISC,
},
+ {
+ name: 'amp-recaptcha-input',
+ version: '0.1',
+ type: TYPES.MISC,
+ },
/**
* @deprecated `amp-slides` is deprecated and will be deleted before 1.0.
* Please see {@link AmpCarousel} w... | [No CFG could be retrieved] | AmpCarousel is a special element with a version of 0. 1 and a version A mensagemory of extensions that can be processed by AMP. | Also add `options: {hasCss: true}` here. |
@@ -177,8 +177,8 @@ crt_hg_pool_init(struct crt_hg_context *hg_ctx)
rc = crt_hg_pool_enable(hg_ctx, CRT_HG_POOL_MAX_NUM,
CRT_HG_POOL_PREPOST_NUM);
if (rc != 0)
- D_ERROR("crt_hg_pool_enable, hg_ctx %p, failed rc:%d.\n",
- hg_ctx, rc);
+ D_ERROR("crt_hg_pool_enable, hg_ctx %p, failed rc: " DF_RC "\n",
+ h... | [No CFG could be retrieved] | Initialize the chp_num and chp_max_num fields of the given object get the next object in the chain. | this output format used in the changes in this file differs from the others introduced in this patch. Is it intended? For example on this line the change has "failed rc: " DF_RC "\n" rather than "failed, " DF_RC "\n". |
@@ -134,7 +134,11 @@ class ServicesBundle:
)
-def load_deployed_contracts_data(config: RaidenConfig, chain_id: ChainID) -> Dict[str, Any]:
+def load_deployed_contracts_data(
+ config: RaidenConfig,
+ chain_id: ChainID,
+ development_environment: ContractDevEnvironment = ContractDevEnvironment.... | [raiden_bundle_from_contracts_deployment->[RaidenBundle],services_bundle_from_contracts_deployment->[ServicesBundle]] | Sets the contract deployment data depending on the network id and environment type. | Is it missing a `.value`, or does it really expects an enum type? |
@@ -600,6 +600,11 @@ public class LogicalPlanner {
final JoinKey joinKey = buildJoinKey(root);
+ Optional<ColumnName> leftJoinNonKeyColumn = Optional.empty();
+ if (isForeignKeyJoin) {
+ leftJoinNonKeyColumn = getLeftJoinNonKeyColumn(root);
+ }
+
final PlanNode left = prepareSourceForJoin(
... | [LogicalPlanner->[getSinkTopic->[getWindowInfo],buildJoin->[buildJoin,prepareSourceForJoin],buildAggregateNode->[getTargetSchema],isInnerNode->[isInnerNode],prepareSourceForJoin->[prepareSourceForJoin,buildInternalProjectNode,buildInternalRepartitionNode],RewrittenAggregateAnalysis->[getAggregateFunctions->[getAggregat... | Build a join node. | Could we embed this into `verifyJoin` and change it's return type from `boolean` to `Optional<ColumnName>` ? If the optional is empty, it's a PK join, otherwise it's a FK-join? (Or would this be too messy?) |
@@ -262,7 +262,13 @@ class MechanicalSolver(PythonSolver):
raise Exception("::[MechanicalSolver]:: Time stepping not defined!")
def GetComputingModelPart(self):
- return self.main_model_part
+ computing_sub_model_part_name = self.settings["computing_sub_model_part_name"].GetString()
+ ... | [MechanicalSolver->[AddDofs->[AddDofs],_create_convergence_criterion->[_get_convergence_criterion_settings],_create_builder_and_solver->[get_linear_solver],_execute_after_reading->[import_constitutive_laws],Initialize->[Initialize],_create_line_search_strategy->[GetComputingModelPart,get_solution_scheme,get_builder_and... | Get the computer model part. | I would have used the complete path as compute model part and would only check if it is a sub of main model part rather than going only one step down |
@@ -0,0 +1,9 @@
+require 'rails_helper'
+
+describe Reports::SpActiveUsersReport do
+ subject { described_class.new }
+
+ it 'is empty' do
+ expect(subject.call).to eq('[]')
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | is our convention that we at least add one row to make sure the report isn't completely empty? |
@@ -143,6 +143,14 @@ func InitIssueIndexer(syncReindex bool) {
var populate bool
switch setting.Indexer.IssueType {
case "bleve":
+ defer func() {
+ if err := recover(); err != nil {
+ log.Error("PANIC whilst initializing issue indexer: %v\nStacktrace: %s", err, log.Stack(2))
+ log.Error("The inde... | [cancel->[Broadcast,Lock,Unlock],set->[Broadcast,Lock,Unlock],get->[RUnlock,Wait,RLock],Warn,Index,Now,Close,Delete,cancel,Info,Search,Done,IsShutdown,NewCond,CreateQueue,Error,Init,RunAtTerminate,set,Errorf,LoadDiscussComments,Trace,After,Since,Terminate,RLocker,IssueList,Debug,SearchRepositoryByName,IsChild,RunWithSh... | Process data and create the issue indexer RunWithShutdownFns runs the issue indexer and then exits. | Since we don't have a `delete indexes` command (yet?), could we also print something like "You can completely remove the %s directory to make Gitea recreate the indexes". |
@@ -914,8 +914,8 @@ def _read_bti_header(pdf_fname, config_fname, sort_by_ch_name=True):
in [c_['chan_no'] for c_ in chans]]
# check all pdf channels are present in config
- match = [c['chan_no'] for c in chans_cfg] == \
- [c['chan_no'] for c in chans]
+ mat... | [_bti_open->[_bytes_io_mock_context],_read_config->[_bti_open,_correct_offset],_read_bti_header_pdf->[_bti_open,_read_pfid_ed,_read_channel,_read_process,_read_assoc_file,_read_epoch,_read_event,_correct_offset],_read_bti_header->[_read_bti_header_pdf,_read_config],_process_bti_headshape->[_get_ctf_head_to_head_t,_read... | Read BTI header. This function returns a dict with the values of the object. | I suspect that this will not be enough, and that you actually need to reorder one to match the other. See a few lines below, we just `zip` over them -- this implies they are equivalently ordered already. |
@@ -223,6 +223,17 @@ describe AdminPublicBodyHeadingsController do
expect(flash[:notice]).to eq('Heading was successfully updated.')
end
+ it "creates a new translation if there isn't one for the default_locale" do
+ AlaveteliLocalization.set_locales('es en_GB', 'en_GB')
+
+ post :u... | [make_request->[post],create,find,describe,first,it,name,put,make_request,to,save!,before,post,destroy_all,destroy,require,include,sort,edit_admin_heading_path,match,id,redirect_to,context,assert_response,merge,get,eq,render_template,with_locale,reload] | save! - > save! - > check_conditions - > check_conditions adds a new translation for the given node. | Line is too long. [81/80] |
@@ -26,6 +26,8 @@ namespace Microsoft.Xna.Framework.Graphics
public RenderTarget2D(GraphicsDevice graphicsDevice, int width, int height, bool mipMap, SurfaceFormat preferredFormat, DepthFormat preferredDepthFormat, int preferredMultiSampleCount, RenderTargetUsage usage, bool shared, int arraySize)
: bas... | [RenderTarget2D->[GraphicsDeviceResetting->[GraphicsDeviceResetting]]] | The base class for all 2D objects. | QueryRenderTargetFormat() is called after the base class (Texture2D) is initialized with the preferredFormat. |
@@ -96,7 +96,9 @@ class CondaHttpAuth(AuthBase):
# TODO: make this class thread-safe by adding some of the requests.auth.HTTPDigestAuth() code
def __call__(self, request):
- request.url = CondaHttpAuth.add_binstar_token(request.url)
+ request.url, token = CondaHttpAuth.add_binstar_token(reques... | [CondaHttpAuth->[handle_407->[close,send]],CondaSession->[__init__->[EnforceUnusedAdapter]]] | Add a binstar token to the request and return a new request object. | Is there a reason for having the token prepended with "Bearer"? It seems not super necessary to me |
@@ -482,6 +482,10 @@ def is_valid_lock_expired(
msg = 'Invalid LockExpired message. Same lockhash handled twice.'
result = (False, msg, None)
+ elif lock_registered_on_chain:
+ msg = 'Invalid LockExpired message. Secret registered on-chain.'
+ result = (False, msg, None)
+
else... | [get_current_balanceproof->[get_amount_locked],register_secret_endstate->[is_lock_locked],handle_block->[is_deposit_confirmed,get_status],send_refundtransfer->[create_sendlockedtransfer],handle_send_directtransfer->[get_current_balanceproof,get_status,send_directtransfer,get_distributable],send_directtransfer->[create_... | Checks if a lock is valid. Checks if a lock has been received and if so checks if it is valid. | I think we can clarify this, the secret being registered on-chain doesn't imply the lock was unlocked. The lock is unlocked iff the block number in which the secret was registered is before the lock expiration. So I think `Invalid LockExpired mesage. Lock was unlocked on-chain` is a bit more unambiguous |
@@ -442,7 +442,7 @@ func Migrate(ctx *context.APIContext, form auth.MigrateRepoForm) {
case migrations.IsTwoFactorAuthError(err):
ctx.Error(422, "", "Remote visit required two factors authentication.")
case models.IsErrReachLimitOfRepo(err):
- ctx.Error(422, "", fmt.Sprintf("You have already reached your limit ... | [QueryBool,Status,CanWrite,NotifyMigrateRepository,IssuesConfig,IsErrOrgNotExist,GetUnit,StartToMirror,GetUserByID,ToCorrectPageSize,MigrateRepository,Set,ChangeRepositoryName,IsErrRepoNotExist,CreateRepository,NewRepoRedirect,GetOwner,SetArchiveRepoState,Error,GetRepositoryByID,GetErrMsg,URLSanitizedError,NotFound,Can... | PullRequests - a function to migrate a repository. Get returns a single repository. | why this change? `ctxUser` could be organization imho and than this would be organization limit not users |
@@ -36,7 +36,7 @@ module Api
user
end
- def organization_article?(reaction)
+ def org_article?(reaction)
reaction.reactable_type == "Article" && reaction.reactable.organization_id
end
end
| [ReactionsController->[organization_article?->[organization_id,reactable_type],onboarding->[each,perform_async,id,map],create->[create,render,user,to_json,organization_article?,send_reaction_notification,id,organization,delete],valid_user->[has_role?,find_by],skip_before_action]] | Checks if a user has a lease and if so returns it. | Should we update this to check for the actual organization rather than just the id in the event that the organization is removed? |
@@ -2041,8 +2041,9 @@ int s_client_main(int argc, char **argv)
#endif
sbio = BIO_new_dgram(sock, BIO_NOCLOSE);
- if ((peer_info.addr = BIO_ADDR_new()) == NULL) {
+ if (sbio == NULL || (peer_info.addr = BIO_ADDR_new()) == NULL) {
BIO_printf(bio_err, "memory allocation failure\n... | [No CFG could be retrieved] | Reads the n - n records from the network. Reads the socket information from the network and sets it as connected and closes the socket. | This is unnecessary here. |
@@ -56,15 +56,14 @@ class KafkaWriter<K, V> extends DoFn<ProducerRecord<K, V>, Void> {
checkForFailures();
ProducerRecord<K, V> record = ctx.element();
- KV<K, V> kv = KV.of(record.key(), record.value());
-
Long timestampMillis =
spec.getPublishTimestampFunction() != null
? spe... | [KafkaWriter->[finishBundle->[flush,checkForFailures],SendCallback->[onCompletion->[getMessage,warn]],teardown->[close],processElement->[getValue,send,getTopic,of,SendCallback,value,inc,getKey,key,element,getMillis,checkForFailures,getPublishTimestampFunction],setup->[apply,getProducerFactoryFn],checkForFailures->[form... | Process an element of the queue. | Just noticed, we should honor timestamp in the producer record if getPublishTimestampFunction() is not set. |
@@ -516,6 +516,7 @@ class ApiPlatformExtensionTest extends TestCase
'api_platform.listener.view.respond',
'api_platform.listener.view.serialize',
'api_platform.listener.view.validate',
+ 'ApiPlatform\Core\Filter\QueryParameterValidateListener',
'api_platfor... | [ApiPlatformExtensionTest->[getBaseContainerBuilderProphecy->[getPartialContainerBuilderProphecy]]] | Gets the partial container builder prophecy. This method is called when a child definition is needed. This function is called when a problem is not found in the prophecy. php This is a temporary hack to avoid the duplicate code in the code. | Please change to `api_platform.listener.view.validate_query_parameters` for consistency (we don't use id as services name yet) |
@@ -247,7 +247,7 @@ class OverlappingOutputPathsError(DvcException):
class CheckoutErrorSuggestGit(DvcException):
def __init__(self, target, cause):
super(CheckoutErrorSuggestGit, self).__init__(
- "Did you mean 'git checkout {}'?".format(target), cause=cause
+ "Did you mean `git ch... | [GitHookAlreadyExistsError->[__init__->[super,format]],DownloadError->[__init__->[super,format]],FileMissingError->[__init__->[super,format]],RecursiveAddingWhileUsingFilename->[__init__->[super]],CircularDependencyError->[__init__->[super,format,isinstance]],CheckoutErrorSuggestGit->[__init__->[super,format]],UrlNotDv... | Initialize a NestedError object. | This is the only one I'm not sure about. |
@@ -3277,6 +3277,10 @@ define([
setUniforms[uniformVariableScale] = true;
setUniforms[uniformVariableTranslate] = true;
break;
+ default:
+ //>>includeStart('debug... | [No CFG could be retrieved] | This function is used to determine if the quantized attributes should be set to the identity function get the function that can be used to compute the quantized uniform values. | RuntimeErrors should not have pragmas. |
@@ -278,7 +278,7 @@ func (o *orm) processNextUnclaimedTaskRun(ctx context.Context, fn ProcessTaskRun
return errors.Wrap(err, "could not mark pipeline_run as finished")
}
// Emit a Postgres notification if this is the final `ResultTask`
- err = o.db.Exec(`SELECT pg_notify('pipeline_run_completed', ?::text... | [processNextUnclaimedTaskRun->[GormTransaction,Raw,Error,First,Errorw,Exec,Infow,Find,CombinedContext,Now,Preload,Wrap,Where,StringFrom,IsFinalPipelineOutput,DatabaseMaximumTxDuration,Scan],CreateSpec->[GormTransaction,Create,OutputIndex,OutputTask,CombinedContext,DotID,TasksInDependencyOrder,WithStack,Errorf,SetOutput... | processNextUnclaimedTaskRun processes the next unclaimed task run in the pipeline This method is used to find the next task run in the pipeline. This is the callback function that is called when a pipeline task run is completed. | Is this part of the upgrade? |
@@ -33,15 +33,7 @@ class Source extends BaseAdmin
{
parent::content($parameters);
- $a = DI::app();
-
- $guid = null;
- // @TODO: Replace with parameter from router
- if (!empty($a->argv[3])) {
- $guid = $a->argv[3];
- }
-
- $guid = $_REQUEST['guid'] ?? $guid;
+ $guid = basename($_REQUEST['guid'] ?? '')... | [Source->[content->[t]]] | Content for a . | When `$_REQUEST['guid']` is null then this will create a notice. |
@@ -601,6 +601,8 @@ namespace Kratos {
const double mass_that_should_have_been_inserted_so_far = mass_flow * (current_time - inlet_start_time);
+ std::uniform_int_distribution<> distrib(0, valid_elements_length - 1);
+
int i=0;
for (i... | [No CFG could be retrieved] | This function calculates the inlet velocity and the actual inlet velocity. injectedSoFar - if mass_that_should_have_been_inserted. | Is it possible to create this object in the constructor? If so, it would be created only once. It should be possible to save it as a member variable. |
@@ -62,13 +62,15 @@ public final class OmVolumeArgs extends WithObjectID implements Auditable {
@SuppressWarnings({"checkstyle:ParameterNumber", "This is invoked from a " +
"builder."})
private OmVolumeArgs(String adminName, String ownerName, String volume,
- long quotaInBytes, Map<St... | [OmVolumeArgs->[removeAcl->[removeAcl],Builder->[addOzoneAcls->[addAcl],build->[OmVolumeArgs]],copyObject->[OmVolumeArgs,copyObject],equals->[equals],getProtobuf->[build],getFromProtobuf->[getVolume,getFromProtobuf,OmVolumeArgs,getModificationTime,getCreationTime,getAdminName,getQuotaInBytes,getOwnerName],setAcls->[set... | Construct an OmVolumeArgs object. Adds an ACL to the ACL map. | The same line could be indented by 4 space. |
@@ -65,7 +65,7 @@ public abstract class BaseTableMetadata implements HoodieTableMetadata {
// Directory used for Spillable Map when merging records
protected final String spillableMapDirectory;
- private transient HoodieMetadataMergedInstantRecordScanner timelineRecordScanner;
+ private TimelineMergedTableMet... | [BaseTableMetadata->[fetchAllPartitionPaths->[getAllPartitionPaths],getAllPartitionPaths->[getAllPartitionPaths],findInstantsToSync->[findInstantsToSync]]] | Abstract class for creating and reading Hoodie table metadata. Default configuration for the file system. | this is also serialized now, so we don't list the data timeline for merging over and over. |
@@ -61,6 +61,14 @@ class InstallOperation extends SolverOperation
*/
public function __toString()
{
- return 'Installing '.$this->package->getPrettyName().' ('.$this->formatVersion($this->package).')';
+ return 'Installing '.$this->getChangeAsString();
+ }
+
+ /**
+ * {@inheritDo... | [InstallOperation->[__toString->[formatVersion,getPrettyName]]] | Returns a string representation of the missing package. | Why not just use `__toString` ? |
@@ -7,7 +7,9 @@ from ..embed import notebook_div
@abstract
class Component(Model):
- """ A base class for all embeddable models, i.e. plots and widgets. """
+ """ A base class for all embeddable models, i.e. plots, layouts and widgets.
+
+ """
disabled = Bool(False, help="""
Whether the widget ... | [Component->[__repr_html__->[notebook_div],html->[__repr_html__,HTML],Bool]] | A base class for all embeddable models i. e. plots and widgets. | I guess "embeddable" is not the right work here anymore. Maybe "for all DOM-level components, i.e. plots, layouts, and widgets" |
@@ -48,13 +48,13 @@ OPTIONS = [
click.option(
'--registry-contract-address',
help='hex encoded address of the registry contract.',
- default='32c5dab9b099a5b6c0e626c1862c07b30f58d76a', # testnet default
+ default='bbc60aa23059b039407ac008bd0b7e902890d382', # testnet default
... | [app->[prompt,RuntimeError,join,enumerate,AccountManager,configure,get_privkey,copy,startswith,address_in_keystore,ContractDiscovery,list,print,len,BlockChainService,format,App,discovery,split_endpoint,keys,address_decoder,encode,exit],run->[signal,APIServer,print,start,stop,pop,register_registry,register,Console,wait,... | Option - line tool to handle the raiden ethernet network related options. Logging options. | What about defining these constants in the constant module? including the older addresses |
@@ -32,6 +32,8 @@ export const urls = {
thirdPartyFrameHost: env['thirdPartyFrameHost'] || 'ampproject.net',
thirdPartyFrameRegex: thirdPartyFrameRegex || /^d-\d+\.ampproject\.net$/,
cdn: env['cdnUrl'] || 'https://cdn.ampproject.org',
+ cdnProxyRegex: /^https:\/\/([a-zA-Z0-9_-]+\.)?cdn\.ampproject\.org/,
+ l... | [No CFG could be retrieved] | A mix of the third party and CDN urls. | We need to allow `localhost` as well, not just `localhost:3000`. |
@@ -1959,7 +1959,7 @@ public abstract class AbstractProject<P extends AbstractProject<P,R>,R extends A
}
}
return FormValidation.okWithMarkup(Messages.AbstractProject_LabelLink(
- j.getRootUrl(), Util.escape(l.getName()), l.getUrl(), l.getNodes().size(), l.g... | [AbstractProject->[setAssignedLabel->[save],onLoad->[onLoad,createBuildMixIn],getFirstBuild->[getFirstBuild],removeFromList->[save,updateTransientActions],workspaceOffline->[getWorkspace,getAssignedLabel,isAllSuitableNodesOffline],getRelevantLabels->[getAssignedLabel],doWs->[getSomeWorkspace],removeRun->[removeRun],get... | Validate a label expression. | spider senses are pining on this one... but I don't know why... maybe because the method as is can be used outside of any web request (but I doubt it ever is) or maybe for some other reason |
@@ -7,8 +7,9 @@
// license: structural_mechanics_application/license.txt
//
// Main authors: Philip Kalkbrenner
-// Alejandro Cornejo
-//
+// Massimo Petracca
+// Alejandro Cornejo
+//
//
// System includes
| [No CFG could be retrieved] | Provides a function to calculate the material response of a non - standard kratos object. DamageDPlusDMinusMasonry2DLaw - DamageD. | The style guide is not respected but is not important |
@@ -417,7 +417,7 @@ class HTTPSignature
* @return \Friendica\Network\HTTPClient\Capability\ICanHandleHttpResponses CurlResult
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/
- public static function fetchRaw($request, $uid = 0, $opts = ['accept_content' => ['application/activity+json... | [HTTPSignature->[fetch->[getBody,isSuccess],transmit->[post,getReturnCode],fetchRaw->[head,get,getReturnCode],parseSigheader->[get]]] | Fetch a raw response from the server Get the result of a cURL call. | This is the correct way of having several values for the same header instead of having a single value by repeated header. |
@@ -16,9 +16,10 @@ module Liquid
end
assigns.merge!(local_assigns.stringify_keys)
- liquid = Liquid::Template.parse(template)
+ liquid = Liquid::Template.parse(template)
liquid.send(render_method, assigns, filters: filters, registers: registers).html_safe
end
+
... | [TemplateHandler->[render->[send,parse,merge!,html_safe,content_for,stringify_keys,assigns,respond_to?,content_for?]]] | Renders the template with the given assigns. | Extra empty line detected at class body end. |
@@ -1647,11 +1647,6 @@ class NewSemanticAnalyzer(NodeVisitor[None],
self.add_symbol(imported_id, gvar, imp)
continue
if node and node.kind != UNBOUND_IMPORTED and not node.module_hidden:
- if not node:
- # Normalization failed beca... | [names_modified_in_lvalue->[names_modified_in_lvalue],NewSemanticAnalyzer->[analyze_comp_for->[analyze_lvalue],name_not_defined->[is_incomplete_namespace,add_fixture_note,record_incomplete_ref,lookup_fully_qualified_or_none],check_classvar->[is_self_member_ref],visit_lambda_expr->[analyze_function],visit_for_stmt->[fai... | Visit an ImportFrom node. Add missing missing module attribute. | This is dead code. |
@@ -72,7 +72,7 @@
</div>
<section class='dialog-actions'>
- <%= submit_tag t(:upload), data: { disable_with: t(:uploading_please_wait) } %>
+ <%= submit_tag t(:upload), data: { disable_with: t(:uploading_please_wait) }, id: 'upload', disabled: true %>
<%= button_to_function I18n.t(:close), ... | [No CFG could be retrieved] | View for the list of all user - defined nodes. | The same is true here, too. `t(:upload)`, `data:`, `id`, and `disabled` should all be aligned. |
@@ -24,7 +24,7 @@ class ArticleSuggester
end
def self.memoized_articles_count
- @memoized_articles_count ||= Article.published.estimated_count
+ Article.published.estimated_count
end
private
| [ArticleSuggester->[suggestions_by_tag->[first],other_suggestions->[first,id],memoized_articles_count->[estimated_count],cached_tag_list_array->[split],articles->[suggestions_by_tag,size,other_suggestions,any?,union,map],initialize->[memoized_articles_count],attr_reader]] | Count the number of articles that have been published. | Wouldn't this method no longer be considered memoized? |
@@ -57,6 +57,11 @@ class TemporalStatisticsProcess(Kratos.Process):
if (not Kratos.KratosGlobals.HasVariable(statistics_control_variable_name)):
raise Exception("Unknown statistics control variable. [ \"statistics_control_variable_name\" = \"" + statistics_control_variable_name + "\" ]")
+ ... | [TemporalStatisticsProcess->[__init__->[__init__]]] | Initialize the object with the given model and settings. This method is called when the control variable is not set in the settings. | STEP should also work properly with restart afaik |
@@ -189,7 +189,7 @@ int legacy_params(dt_iop_module_t *self, const void *const old_params, const int
new->order = old->order;
new->radius = old->radius;
new->shadows = old->shadows;
- new->reserved1 = old->reserved1;
+ new->whitepoint = old->reserved1;
new->reserved2 = old->reserved2;
new... | [No CFG could be retrieved] | The legacy_params function. - - - - - - - - - - - - - - - - - -. | That doesn't feel completely safe to me... Are you completely sure it isn't better to just verbosely default it to whatever the default/legacy-safe value? |
@@ -633,7 +633,10 @@ func InstallKBNM(context Context, binPath string, log Log) error {
}
defer fp.Close()
+ // Truncate in case there is other stuff in the file already.
+ fp.Truncate(0)
encoder := json.NewEncoder(fp)
+ encoder.SetIndent("", " ")
return encoder.Encode(&hostManifest)
}
| [GetRunMode,Dir,CheckPlist,Statfs,MakeParentDirs,WaitForStatus,Executable,ListServices,GetRuntimeDir,StatusFromCode,SplitPath,Count,Lstat,CombineErrors,Close,Encode,Info,WaitForServiceInfoFile,HasPrefix,Mode,ComponentName,GetServiceInfoPath,Uninstall,IsNotExist,CombinedOutput,Error,Stat,FormatBool,Clean,NewEncoder,NewE... | HostManifest creates a JSON file containing the KBNM host manifest. uninstalls the components that are not in components. | If this fails? |
@@ -1,15 +1,10 @@
-# frozen_string_literal: true
-
Rails.application.configure do
# Settings specified here will take precedence over those in config/application.rb.
- # Enable/disable caching. By default caching is disabled.
- is_cache_enabled = Rails.root.join("tmp/caching-dev.txt").exist?
-
# In the devel... | [fetch,megabytes,file_watcher,after_initialize,raise_delivery_errors,headers,consider_all_requests_local,asset_host,cache_classes,imgix,deprecation,exist?,verbose_query_logs,enabled,to_i,migration_error,delivery_method,bullet_logger,eager_load,default_url_options,enable,cache_store,perform_caching,rails_logger,ip_addre... | Configure the application. The domain and port of the SMTP SMTP server. | Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -72,6 +72,15 @@ class ContainerRegistryClient(ContainerRegistryBaseClient):
:return: ItemPaged[str]
:rtype: :class:`~azure.core.paging.ItemPaged`
:raises: :class:`~azure.core.exceptions.ResourceNotFoundError`
+
+ .. admonition:: Example:
+
+ .. literalinclude:: ../samples... | [ContainerRegistryClient->[delete_repository->[delete_repository],list_repositories->[get_next->[prepare_request]]]] | List all repositories that have a specific . Retrieves a single critical node. This function is a wrapper around pipeline_response which returns ItemPaged. | is there a reason you pointed to this sample rather than the `list_repositories` call in `sample_create_client.py`? As a user who wants to see how `list_repositories` is being used, I would probably think to look in `sample_create_client.py` (or some other all-encompassing sample or a separate `list_repositories` sampl... |
@@ -662,7 +662,10 @@ def _concat_partitions_with_op(partition_tensor_list, tensor, partition_index,
def _init_comm_for_send_recv():
- if not PROCESS_GROUP_MAP["global_group"].is_instantiate():
+ if not PROCESS_GROUP_MAP:
+ genv = _get_global_env()
+ PROCESS_GROUP_MAP["global_group"] = ProcessGr... | [reshard->[remove_no_need_in_main,find_op_desc_seq,_need_reshard,remove_no_need_in_startup,parse_op_desc],remove_no_need_in_main->[_remove_no_need_vars,_remove_no_need_ops],_concat_partitions->[_compute_concat_info,_concat_partitions],_compute_partition_index->[_compute_process_index,_compute_partition_shape],find_op_d... | Initialize the comm for send and receive. | LGTM but later in next prwe need to move the group instantiate step into parallelizer.py in order to unify the comm group instantiation. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.