patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -37,7 +37,6 @@ public abstract class KafkaQueryRunnerBuilder<T extends TestingKafka>
protected final T testingKafka;
protected Map<String, String> extraKafkaProperties = ImmutableMap.of();
protected Module extension = DEFAULT_EXTENSION;
- protected ImmutableList.Builder<Module> additionalModulesBui... | [KafkaQueryRunnerBuilder->[createKafkaQueryRunner->[KafkaPlugin,installPlugin,combine,copyOf,createCatalog,getConnectString,putIfAbsent],setExtraKafkaProperties->[copyOf,requireNonNull],build->[createKafkaQueryRunner,setLevel,build,start,preInit,closeAllSuppress,postInit,initialize],setExtension->[requireNonNull],addMo... | Creates a builder for a specific Kafka query runner. Add modules to the partition. | I can extract single commit per change if you like. I thought that having 5 commits per simple change is an overkill, on the other hand this commit is not super readable either. Please let me know what do you think about it. |
@@ -249,6 +249,16 @@ public class SelectQueryQueryToolChest extends QueryToolChest<Result<SelectResul
{
}
),
+ (Set<String>) jsonMapper.convertValue(
+ resultIter.next(), new TypeReference<Set<String>>()
+ ... | [SelectQueryQueryToolChest->[preMergeQueryDecoration->[run->[run]]]] | Gets the cache strategy. This method is used to prepare a function for cache. | Since the layout of the cached object is changed here, We need to change the cacheKey also, otherwise the queries which were already cached will start failing after upgrade. Probably upgrading the byte for SELECT_QUERY would be fine. |
@@ -11,6 +11,14 @@ export class HDLegacyBreadwalletWallet extends HDLegacyP2PKHWallet {
static type = 'HDLegacyBreadwallet';
static typeReadable = 'HD Legacy Breadwallet (P2PKH)';
+ // track address index at which wallet switched to segwit
+ _external_segwit_index = null; // eslint-disable-line camelcase
+ _... | [No CFG could be retrieved] | Provides a class which implements the HDLegacyBreadwallet interface. Get the address of the with the given index. | its not in constructor. is that legit? |
@@ -981,7 +981,7 @@ abstract class AbstractContactManager implements ContactManagerInterface
* Updates the given phone.
*
* @param Phone $phone The phone object to update
- * @param $entry The entry with the new data
+ * @param array<string, string> $entry The entry with the new data
*
... | [AbstractContactManager->[setMainUrl->[setMainUrl],addPhone->[addPhone],processFaxes->[setMainFax],addFax->[addFax],processAddresses->[unsetMain,updateAddress,createAddress],addNewContactRelations->[setMainUrl,setMainForCollection,setMainPhone,setMainFax,setMainEmail],updateBankAccount->[getBooleanValue],setMainPhone->... | Returns an address by callback - condition. Adds new relations for a given contact. | think we should only use `array` here too because this is the same array as the one that is passed to the `addUrl` |
@@ -997,14 +997,9 @@ public class DiceRoll implements Externalizable {
final GameData data,
final boolean defence,
final boolean allies) {
- final Set<UnitSupportAttachment> rules =
- UnitSupportAttachment.get(data)
- .parallelStream()
- .filter(usa -> (usa.getRoll()... | [DiceRoll->[size->[size],getUnitPowerAndRollsForNormalBattles->[getUnitPowerAndRollsForNormalBattles],rollAa->[getTotalAaAttacks,DiceRoll],rollDiceLowLuck->[getUnitPowerAndRollsForNormalBattles,getTotalPower,DiceRoll],sortAaHighToLow->[sortAaHighToLow,getMaxAaAttackAndDiceSides],getMaxAaAttackAndDiceSides->[getMaxAaAtt... | Get sorted support. | If support rules are only used in `DiceRoll`, what's the rational to move them to `UnitTypeList`? |
@@ -151,6 +151,10 @@ public abstract class HttpRequestHandlingEndpointSupport extends MessagingGatewa
private volatile boolean shuttingDown;
+ private volatile Expression statusCodeExpression;
+
+ private volatile EvaluationContext statusCodeEvaluationContext;
+
private final AtomicInteger activeCount = new Ato... | [HttpRequestHandlingEndpointSupport->[doStart->[doStart],onInit->[onInit]]] | Creates a list of message converters that will be used to convert the request to the correct type. | Maybe we should just call this `generalEvaluationContext` or similar (we might need it again for other uses). |
@@ -76,6 +76,10 @@ public abstract class BaseCommitActionExecutor<T extends HoodieRecordPayload, I,
// TODO : Remove this once we refactor and move out autoCommit method from here, since the TxnManager is held in {@link AbstractHoodieWriteClient}.
this.txnManager = new TransactionManager(config, table.getMeta... | [BaseCommitActionExecutor->[finalizeWrite->[finalizeWrite],getCommitActionType->[getCommitActionType],commitOnAutoCommit->[runPrecommitValidators]]] | Execute the HoodieWriteMetadata algorithm. | Thanks for doing this. the storage layout abstraction is something I wish we added before. but when done with real use-cases, makes it lot easier. |
@@ -93,7 +93,7 @@
<div class="panel-body">
<div class="col-xs-24 col-sm-12">
<a href="#" class="btn btn-primary pull-right row" data-trigger="invite-users"
- data-modal-id="team-invite-users-modal">
+ data-turbolinks="false" data-modal-id="team-invite-users-modal">
... | [No CFG could be retrieved] | Displays a block of the team s nics description. Very basic layout for the user - id - not - unique. | This doesn't seem to be needed, so remove it. |
@@ -169,3 +169,7 @@ def fetch_discounts(date: datetime.date):
)
for sale in sales
]
+
+
+def fetch_active_discounts():
+ return fetch_discounts(datetime.date.today())
| [calculate_discounted_price->[get_product_discounts],fetch_discounts->[_fetch_collections,_fetch_products,_fetch_categories],get_product_discount_on_sale->[are_product_collections_on_sale],get_product_discounts->[get_product_discount_on_sale]] | Fetch all discounts for a given date. | We should use `timezone.now()` instead of `datetime.date.today()` |
@@ -35,3 +35,4 @@ using System.Windows;
[assembly: InternalsVisibleTo("ViewExtensionLibraryTests")]
[assembly: InternalsVisibleTo("DynamoWPFCLI")]
[assembly: InternalsVisibleTo("CommandLineTests")]
+[assembly: InternalsVisibleTo("Watch3DNodeModelsWpf")]
| [SourceAssembly,ExternalAssembly] | Sequence of unique identifiers. | Why is this needed? Are you exposing internals from `DynamoCoreWpf` in `Watch3DNodeModelsWpf`? |
@@ -106,12 +106,10 @@ export class IframeMessagingClient {
/**
* Register callback function for message with type messageType.
- * As it stands right now, only one callback can exist at a time.
- * All future calls will overwrite any previously registered
- * callbacks.
* @param {string} messag... | [IframeMessagingClient->[setupEventListener_->[getData]]] | Register a callback for a specific message type. | is it not the case anymore? |
@@ -50,9 +50,9 @@ import java.net.URL;
@Retention(RUNTIME)
public @interface WithPlugin {
/**
- * Name of the plugin.
+ * Whitespace separated list of plugin names.
*
- * For now, this has to be one of the plugins statically available in resources
+ * For now, this has to be one or more of ... | [RuleRunnerImpl->[decorateHome->[getResource,File,copyURLToFile,value]],RunnerImpl->[decorateHome->[getResource,File,copyURLToFile,value]]] | PUBLIC METHODS IN THE SOFTWARE. This method is used to setup a new This is a class decorator that will decorate the Hudson test case with a plugin manager. | imho whitespace is bad delimiter, i already had experience with AD where whitespace is valid. Now i use only CSV, wouldn't it better to use CSV? |
@@ -3351,7 +3351,7 @@ obj_list_common(tse_task_t *task, int opc, daos_obj_list_t *args)
if ((args->dkey_anchor != NULL &&
daos_anchor_get_flags(args->dkey_anchor) & DIOF_TO_LEADER) ||
- (obj_auxi->is_ec_obj && !obj_auxi->io_retry))
+ obj_auxi->is_ec_obj)
obj_auxi->to_leader = 1;
if (args->dke... | [No CFG could be retrieved] | region DAO List Methods get object spec_shard. | not sure why originally with !obj_auxi->io_retry? |
@@ -24,7 +24,7 @@ public class PrometheusRecorder {
return new Function<Router, Route>() {
@Override
public Route apply(Router router) {
- return router.route(path).produces(TextFormat.CONTENT_TYPE_004);
+ return router.route(path).order(1).produces("text... | [PrometheusRecorder->[route->[apply->[produces]],getHandler->[PrometheusHandler]]] | Route method. | I might have missed this somewhere, but should the content type be changed? I thought "004" was the right one for Prometheus? |
@@ -224,6 +224,11 @@ public class FileCreateUtils {
public static void createBaseFile(String basePath, String partitionPath, String instantTime, String fileId, long length)
throws Exception {
+ createBaseFile(basePath, partitionPath, instantTime, fileId, length, Instant.now().toEpochMilli());
+ }
+
+ p... | [FileCreateUtils->[createDeltaCommit->[createMetaFile],createInflightRollbackFile->[createMetaFile],createRequestedCompaction->[createAuxiliaryMetaFile],createCommit->[createMetaFile],createInflightCommit->[createMetaFile],createInflightCleanFile->[createMetaFile],createInflightReplaceCommit->[createMetaFile],createRep... | Creates a base file if it does not exist. | may I know why we need to set mod time explicitly. I thought these are newly created files and so modificaiton time will be set to creation time and these are immutable files. can you help me understand. |
@@ -224,12 +224,12 @@ public class StreamedQueryResource implements KsqlConfigurable {
"Statement type `%s' not supported for this resource",
statement.getClass().getName()));
} catch (final TopicAuthorizationException e) {
- return Errors.accessDeniedFromKafka(e);
+ return errorHan... | [StreamedQueryResource->[writeValueAsString->[writeValueAsString]]] | Handles a single statement. handle pull query with a . | Can we move `generateResponse` into the `Errors` class? Not sure why a separate class is needed. |
@@ -117,12 +117,15 @@ public class ControllerStatusReportingTask extends AbstractReportingTask {
builder.append(processorBorderLine);
builder.append("\n");
- printProcessorStatus(controllerStatus, builder, showDeltas);
+ printProcessorStatus(controllerStatus, builder, showDeltas, divis... | [ControllerStatusReportingTask->[printConnectionStatus->[compare->[compare],populateConnectionStatuses],populateConnectionStatuses->[populateConnectionStatuses],printProcessorStatus->[compare->[compare],toDiff,populateProcessorStatuses],populateProcessorStatuses->[populateProcessorStatuses],toDiff->[toDiff]]] | On trigger. | Since String.format() is being used, recommend incorporating the parentheses in the COUNTER_LINE_FORMAT definition to avoid the String concatenation. |
@@ -60,7 +60,7 @@ public class ResultToMessageIteratorTestCase {
CursorProviderFactory cursorProviderFactory = mock(CursorProviderFactory.class);
BaseEventContext eventCtx = mock(BaseEventContext.class);
- return new ResultToMessageIterator(list.iterator(), cursorProviderFactory, eventCtx);
+ return n... | [ResultToMessageIteratorTestCase->[resultOf->[build],iteratesOverAllElements->[hasNext,getValue,add,assertOutput,createResultToMessageIterator],forEachRemainingIteratesOverAllElements->[getValue,add,forEachRemaining,assertOutput,createResultToMessageIterator],assertOutput->[assertThat,hasItems],createResultToMessageIte... | Creates a ResultToMessageIterator. | i know this is a test, but this may be confusing if looking for examples of this. Can you pass a mock or new location for this? |
@@ -15,7 +15,7 @@ public class KogitoDevModeIT extends RunAndCheckMojoTestBase {
@Test
public void testThatTheKogitoApplicationRuns() throws MavenInvocationException, IOException {
testDir = initProject("projects/simple-kogito", "projects/project-classic-run-kogito");
- run();
+ run("-e... | [KogitoDevModeIT->[testThatTheKogitoApplicationRuns->[run,until,initProject,equals]]] | Test that the kogito application runs. | Do we want to keep that? |
@@ -807,6 +807,14 @@ class MatrixTransport(Runnable):
)
self._set_room_id_for_address(peer_address, room.room_id)
+ is_peer_reachable = (
+ self._userid_to_presence.get(sender_id) in _PRESENCE_REACHABLE_STATES and
+ self._address_to_presence.get(peer_address) in ... | [_RetryQueue->[enqueue->[_expiration_generator,_MessageData],_run->[_check_and_send],enqueue_global->[enqueue],_check_and_send->[message_is_in_queue]],MatrixTransport->[_send_with_retry->[enqueue,_get_retrier],_handle_presence_change->[_spawn,UserPresence],_handle_invite->[join_room->[join_room],_spawn],_get_retrier->[... | Handle a message from a room. Check if a message has a reserved user or room. This method is called when a message is not signed by sender!. | I think this block is overcautious, can't see how `_userid_to_presence` and `_address_to_presence` could ever get out of sync. If you wanna keep it, please, add a TODO above |
@@ -384,8 +384,11 @@ async function doBuildExtension(extensions, extension, options) {
* @param {?Object} options
*/
function watchExtension(extDir, name, version, latestVersion, hasCss, options) {
- const watchFunc = function () {
- removeFromBabelCache(extDir);
+ const watchFunc = function (modifiedFile) {
... | [No CFG could be retrieved] | Builds a single extension. Builds a single extension. | Doh! Of course. |
@@ -555,7 +555,7 @@ func (b *Botanist) checkControlPlane(
return exitCondition, err
}
if gardenletfeatures.FeatureGate.Enabled(features.Logging) {
- if exitCondition, err := checker.CheckLoggingControlPlane(b.Shoot.SeedNamespace, b.isLoggingHealthCheckObsolete(), condition, seedStatefulSetLister); err != nil ||... | [CheckControlPlane->[checkRequiredDeployments,checkRequiredEtcds,checkDeployments,checkEtcds],checkSystemComponents->[CheckManagedResource,FailedCondition,CheckExtensionCondition],CheckLoggingControlPlane->[checkRequiredStatefulSets,checkStatefulSets],checkControlPlane->[CheckControlPlane,CheckLoggingControlPlane,Check... | checkControlPlane checks the control plane with the given health checker. Check if the control plane is healthy. | A few lines below, there is a temporary code about the metrics server health checking that can be removed in g/g@v1.14.x. |
@@ -242,7 +242,7 @@ namespace System.Xml.Serialization
}
}
- public XmlSerializer(Type type, XmlAttributeOverrides overrides, Type[] extraTypes, XmlRootAttribute root, string defaultNamespace, string location)
+ public XmlSerializer(Type type, XmlAttributeOverrides? overrides, Type... | [XmlSerializer->[FromMappings->[FromMappings],Serialize->[Serialize],Deserialize->[Deserialize],GetXmlSerializerAssemblyName->[GetXmlSerializerAssemblyName],XmlSerializerMappingKey->[GetHashCode->[GetHashCode]],FromTypes->[FromMappings]]] | Generate a temporary assembly for the given type. Get the unique identifier for an object in the system. | Many overloads that funnel into this one should be able to receive null values but are not annotated as such. See lines 159, 164, 168 & 172. |
@@ -237,8 +237,8 @@ def subliminal(ctx, addic7ed, legendastv, opensubtitles, subscenter, cache_dir,
ctx.obj = {'provider_configs': {}}
if addic7ed:
ctx.obj['provider_configs']['addic7ed'] = {'username': addic7ed[0], 'password': addic7ed[1]}
- if legendastv:
- ctx.obj['provider_configs']['le... | [MutexLock->[acquire_read_lock->[acquire_read_lock],acquire_write_lock->[acquire_write_lock],release_write_lock->[release_write_lock],release_read_lock->[release_read_lock]],Config->[write->[write],read->[read]],AgeParamType,LanguageParamType] | Subtitles faster than your thoughts. | this is removing the context for LTV |
@@ -1006,6 +1006,17 @@ def TestData(data_config, async_load_data=None):
" Data definition")
g_config.test_data_config.async_load_data = async_load_data
+'''
+caffe_mode: compute the output size using floor instead of ceil,
+ which is consistent of caffe and CuDNN's conventi... | [MaxOut->[__init__->[add_keys]],ConcatenateLayer2->[__init__->[config_assert,calc_parameter_dims,calc_output_size,calc_bias_size,set_layer_size,calc_parameter_size,get_input_layer,gen_parameter_name,create_bias_parameter,create_input_parameter]],BlockExpand->[__init__->[add_keys]],MDLstmLayer->[__init__->[config_assert... | Test data. Adjusts the output_x and output_y values to match the padding. | `caffe_mode` can be set true by default, because it only set false once in exconv layer. Looks good to me. @hedaoyuan please help to review again. |
@@ -286,8 +286,6 @@ public final class ThriftSchema extends GetterBasedSchemaProvider {
actualValue = value;
}
thrift.setFieldValue(field, actualValue);
- } else if (!TUnion.class.isInstance(thrift)) {
- thrift.setFieldValue(field, value); // nullness checks don't allow setting null her... | [ThriftSchema->[Customizer->[provider->[ThriftSchema]],schemaFor->[schemaFor],beamType->[schemaFor,beamType],restoreThriftObject->[thriftFieldDescriptors],FieldExtractor->[toString->[name]],ThriftSchema]] | Sets the value of the given field in the thrift object. thrift type for all types. | This seemed like a good idea at the time, as it prevented null values in the beam row from ending up as fields with default values in thrift (in case defaults were provided in the thrift descriptor), so it seemed closer to a "symmetrical" transformation. However, leaving the fields unset when they're null in the source... |
@@ -378,7 +378,10 @@ class StandaloneAuthenticator(common.Plugin):
results_if_failure.append(False)
if not self.tasks:
raise ValueError("nothing for .perform() to do")
- if self.already_listening(challenges.DVSNI.PORT):
+ port = challenges.DVSNI.PORT
+ if self... | [StandaloneAuthenticator->[perform->[already_listening,start_listener],start_listener->[do_parent_process,do_child_process]]] | Perform the challenge. Returns the result of a failure - check. | can we put that into `constants.py`? `BOULDER_TEST_MODE_PORT = 5001` |
@@ -313,6 +313,11 @@ func shouldShow(step engine.StepEventMetadata, opts backend.DisplayOptions) bool
return opts.ShowSameResources
}
+ // If this step refers to a default provider resource, we do not display any changes.
+ if providers.IsProviderType(step.URN.Type()) && step.URN.Name() == "default" {
+ return ... | [PastTense,NewTicker,Colorize,GetResourceOutputsPropertiesString,Strings,Itoa,Stop,GetResourcePropertiesSummary,IgnoreError,Tick,NewSpinnerAndTicker,GetResourcePropertiesDetails,Prefix,Type,GetIndent,Failf,Fprint,Fprintf,Reset,Sprintf,String,EmojiOr] | isRootStack returns true if the step is a root stack. | should we consider putting this as the first thing we check in thsi function? right now, if we have a default provider, and an opsame and showsameresources=true, then we'll show things. Is that what we want? Or should we always hide a default provider? |
@@ -14,12 +14,13 @@ type ORM interface {
}
type orm struct {
- db *sqlx.DB
+ db *sqlx.DB
+ lggr Logger
}
// NewORM initializes a new ORM
-func NewORM(db *sqlx.DB) *orm {
- return &orm{db}
+func NewORM(db *sqlx.DB, lggr Logger) *orm {
+ return &orm{db, lggr.Named("LoggerORM")}
}
// GetServiceLogLevel retur... | [GetServiceLogLevel->[Get,Is],SetServiceLogLevel->[Wrap,ExecContext]] | GetServiceLogLevel returns the log level for the given service. | I still think its something of an antipattern to have a logger "ORM" at all. |
@@ -39,7 +39,7 @@ class WebspaceSubscriber extends AbstractMappingSubscriber
return array(
// should happen after content is hydrated
Events::HYDRATE => array('handleHydrate', -10),
- Events::PERSIST => array('handlePersist', 10),
+ Events::PERSIST => array('hand... | [WebspaceSubscriber->[doPersist->[doHydrate],doHydrate->[getWebspace,set,getDocument]]] | Returns an array of events that can be subscribed to. | What does this need to be after? |
@@ -785,7 +785,12 @@ class BigQueryWriteFn(DoFn):
logging.debug('Creating or getting table %s with schema %s.',
table_reference, schema)
- table_schema = self.get_table_schema(schema)
+ if schema == SCHEMA_AUTODETECT:
+ raise ValueError('Schema auto-detection is not supported for st... | [RowAsDictJsonCoder->[RowAsDictJsonCoder],BigQueryReader->[BigQueryReader],WriteToBigQuery->[expand->[BigQueryWriteFn,_compute_method],table_schema_to_dict->[get_table_field->[get_table_field],get_table_field],__init__->[validate_write,validate_create],get_dict_table_schema->[table_schema_to_dict,get_table_schema_from_... | Create a table if necessary. | Are we assuming that this helper only gets called only in streaming inserts codepath? Perhaps we should strengthen the condition to something like: `if schema == SCHEMA_AUTODETECT and method == STREAMING_INSERTS`, or move this check somewhere up the call stack to fail early? |
@@ -837,6 +837,7 @@ def wait_assert(func: Callable, *args, **kwargs) -> None:
try:
func(*args, **kwargs)
except AssertionError as e:
+ print(str(e))
try:
gevent.sleep(0.5)
except gevent.Timeout:
| [transfer_and_assert_path->[watch_for_unlock_failures],assert_synced_channel_state->[assert_channel_values,assert_deposit,assert_balance_proof],assert_succeeding_transfer_invariants->[assert_synced_channel_state],_transfer_unlocked->[watch_for_unlock_failures]] | Utility to re - run func if it raises an AssertionError. Return once func doesn t hit. | hmmmm wtf is this doing here? Should remove it :) |
@@ -5,4 +5,4 @@ Markus::Application.config.session_store :cookie_store, key: MarkusConfigurator.
# Use the database for sessions instead of the cookie-based default,
# which shouldn't be used to store highly confidential information
# (create the session table with "rails generate session_migration")
-# Markus::Appl... | [session_store,markus_config_session_cookie_name] | This is a legacy method that uses the database for sessions instead of the cookie - based default. | Missing space after #. |
@@ -319,5 +319,11 @@ public interface EmbeddedCacheManager extends CacheContainer, Listenable {
throw new UnsupportedOperationException();
}
-
+ /**
+ * Returns an entry point for a Health Check API.
+ *
+ * @since 9.0
+ * @return Health API for this {@link EmbeddedCacheManager}.
+ */
+ ... | [getCacheConfigurationNames->[UnsupportedOperationException],executor->[UnsupportedOperationException]] | default cluster executor. | I'd leave out the `@return` tag, it just repeats the sentence above. And I'd also leave out "Returns" from the sentence above :) |
@@ -30,8 +30,7 @@ module ApplicationHelper
end
def page_with_trust?
- current_page?(controller: 'sign_up/passwords', action: 'new') ||
- current_page?(controller: 'users/reset_passwords', action: 'edit')
+ !current_page?(controller: 'users/sessions', action: 'new')
end
def ial2_requested?
| [cancel_link_text->[user_signing_up?],sign_up_or_idv_no_js_link->[user_verifying_identity?,user_signing_up?],liveness_checking_enabled?->[liveness_checking_enabled?]] | Checks if the user is on the page with trust. | this is making sure we don't do google analytics on pages that prompt for passwords, right?, we should still exclude the reset passwords page? |
@@ -59,7 +59,7 @@ namespace DSCoreNodesUI
void ColorRange_PropertyChanged(object sender, PropertyChangedEventArgs e)
{
- if (e.PropertyName != "IsUpdated")
+ if (e.PropertyName != "CachedValue")
return;
if (InPorts.Any(x => x.Connectors.Count == ... | [ColorRange->[ColorRange_PropertyChanged->[OnRequestChangeColorRange],Connectors_CollectionChanged->[OnRequestChangeColorRange]]] | ColorRange_PropertyChanged - check if property is updated or not. | This component is also erroneously using `IsUpdated`, which could potentially cause it to initiate multiple rapid and potentially unnecessary updates. |
@@ -168,7 +168,7 @@ func mcfgFromConfig(cfg *common.Config) (*ModuleConfig, error) {
mcfg.Filesets = map[string]*FilesetConfig{}
for name, filesetConfig := range dict {
- if name == "module" || name == "enabled" {
+ if name == "module" || name == "enabled" || name == "path" {
continue
}
| [GetInputConfigs->[getInputConfig,Errorf],InfoString->[Sprintf],ModuleFilesets->[Resolve],SetupML->[Warn,Sprintf,Empty,ModuleNames,SetupModule,HaveXpackML,Errorf],LoadML->[ImportMachineLearningJob,Warn,GetMLConfigs,HaveXpackML,Errorf],Warn,NewConfigFrom,Stat,ReadFile,New,ReadDir,Errorf,MergeConfigs,Join,Unpack,Name,Rea... | getCurrentModuleName returns the current module name and a flag indicating if the current module is a getModuleFilesets returns the name of the module and whether it has a file set. | Why is this change needed? |
@@ -293,7 +293,7 @@ void ScriptApiBase::stackDump(std::ostream &o)
break;
case LUA_TNUMBER: /* numbers */ {
char buf[10];
- snprintf(buf, 10, "%lf", lua_tonumber(m_luastack, i));
+ porting::mt_snprintf(buf, 10, "%lf", lua_tonumber(m_luastack, i));
o << buf;
break;
}
| [No CFG could be retrieved] | This function is called from the lua script code. - > Set origin from table - > set origin from table - > set origin from table. | constant can be replaced with `sizeof` |
@@ -153,6 +153,7 @@ public class ClientModel implements IMessengerErrorListener {
public void setRemoteModelListener(@Nonnull final IRemoteModelListener listener) {
this.listener = Preconditions.checkNotNull(listener);
+ internalPlayerListingChanged(getServerStartup().getPlayerListing());
}
private... | [ClientModel->[getIsServerHeadlessTest->[getServerStartup],getServerStartupRemote->[getServerStartup],getHostBotChangeToAutosaveClientAction->[getMessenger],getHostBotSetMapClientAction->[getAvailableServerGames,getMessenger],getHostBotChangeGameOptionsClientAction->[getServerStartupRemote],getHostBotChangeGameToSaveGa... | Gets the properties of the remote client. | Core fix No.2 |
@@ -760,7 +760,7 @@ class QueueTest(EditorTest):
assert latest_version
name = '%s %s' % (unicode(addon.name),
latest_version.version)
- channel = ['unlisted'] if not self.listed else []
+ channel = [self.channel_name] if self.channel_name el... | [QueueTest->[setUp->[login_as_editor,login_as_senior_editor],get_queue->[get_addon_latest_version],get_expected_addons_by_names->[generate_files],generate_file->[generate_files],_test_get_queue->[get_queue],_test_results->[get_addon_latest_version]],TestAutoApprovedQueue->[test_queue_count->[login_with_permission,gener... | Test the results of the API call. | hmm.... I don't like this change Can we have channel_name as a sensible default (`listed`?) - `None` is never a valid channel - and test accordingly? |
@@ -459,7 +459,7 @@ class Plugin(CommonPluginApi):
assert self._modules is not None
return lookup_fully_qualified(fullname, self._modules)
- def report_config_data(self, id: str, path: str) -> Any:
+ def report_config_data(self, id: str, path: str, is_check: bool) -> Any:
"""Get repre... | [ChainedPlugin->[get_type_analyze_hook->[get_type_analyze_hook],get_method_signature_hook->[get_method_signature_hook],set_modules->[set_modules],get_method_hook->[get_method_hook],get_function_hook->[get_function_hook],get_attribute_hook->[get_attribute_hook],get_base_class_hook->[get_base_class_hook],report_config_da... | Lookup a module s fully qualified configuration. | Looking at the call sites maybe it is better to call this argument `context` and pass it two predefined constants like `mypy.plugin.LOAD` and `mypy.plugin.STORE`? I think this would be more user-friendly. |
@@ -106,6 +106,12 @@ class File {
return false;
}
+ if (preg_match('~[^a-zA-Z0-9_\./ ]~', $relative_path)) {
+ // Filenames may contain special characters that result in malformatted URLs
+ // and/or HMAC mismatches. We want to avoid that by encoding the path.
+ $relative_path = ':' . Base64Url::encode(... | [File->[getURL->[getDataPath,getFilenameOnFilestore,getId,exists,getToken]]] | Returns the URL of the file Normalize the URL to a normalized one. | Changed this because `\w` may match multibyte chars depending on locale |
@@ -309,11 +309,10 @@ def test_x_crop(fn, method, out_length, size, device):
@pytest.mark.parametrize('method', ["FiveCrop", "TenCrop"])
-def test_x_crop_save(method):
+def test_x_crop_save(method, tmpdir):
fn = getattr(T, method)(size=[5, ])
scripted_fn = torch.jit.script(fn)
- with get_tmp_dir() as ... | [test_crop_pad->[_test_class_op],test_convert_image_dtype->[_test_transform_vs_scripted_on_batch,_test_transform_vs_scripted],test_random_affine_degrees->[_test_random_affine_helper],_test_op->[_test_class_op,_test_functional_op],test_random_rotate->[_test_transform_vs_scripted_on_batch,_test_transform_vs_scripted],tes... | test_x_crop_save - test method for cropping image with x - crop. | Just to clarify: for these functions that directly use the `tmpdir` fixture and do not indirectly call `_test_class_op` of `_test_op`, it's nice to have `tmpdir` and not to rely on `get_tmp_dir`, so no need to revert the changes for these :) |
@@ -1654,7 +1654,7 @@ class Manager {
* @param Array $args method call arguments.
* @return an amended XMLRPC server options array.
*/
- public function jetpack_getOptions( $args ) {
+ public function jetpack_get_options( $args ) {
global $wp_xmlrpc_server;
$wp_xmlrpc_server->escape( $args );
| [Manager->[generate_secrets->[get_secret_callable],verify_secrets->[delete_secrets,get_secrets],sign_role->[get_access_token],xmlrpc_options->[is_active],jetpack_getOptions->[get_connected_user_data],is_registered->[is_active],set_min_time_limit->[get_max_execution_time],register->[api_url]]] | Get the options for the Jetpack API call Get options for a node. | Are we OK changing this public function name? |
@@ -983,7 +983,13 @@ class TaskRunner(Runner):
and value is not None
):
try:
- result = self.result.write(value, filename="output", **prefect.context)
+ result = self.result.write(
+ value,
+ filename="output",
+ ... | [TaskRunner->[run_mapped_task->[run_fn->[run]],run->[initialize_run],get_task_run_state->[run]]] | This method runs the task and traps any signals or errors or raises a exception. Check if a is present in the task s state. | I think this can cause a runtime error if you have a task input with the same name as a flow parameter, can it? |
@@ -106,8 +106,9 @@ func (fm *concreteFluxMonitor) Start() error {
var wg sync.WaitGroup
err := fm.store.Jobs(func(j *models.JobSpec) bool {
if j == nil {
+ // FIXME: This seems like an invariant violation?
err := errors.New("received nil job")
- logger.Error(err)
+ logger.Errorw("Unexpected nil job wh... | [isValidSubmission->[JobID],Stop->[Stop],consume->[setIsHibernatingStatus],processLogs->[reactivate,hibernate,isFlagLowered],SetOracleAddress->[New],pollIfEligible->[checkEligibilityAndAggregatorFunding,JobID],resetHibernationTimer->[Stop],resetIdleTimer->[Stop],setInitialTickers->[initialRoundState,resetTickers],serve... | Start starts the FluxMonitor. | I think in most places we call it simply `"err"` maybe use that here for consistency? |
@@ -38,6 +38,14 @@ class AppKernel extends Kernel
{
use MicroKernelTrait;
+ public function __construct(string $environment, bool $debug)
+ {
+ parent::__construct($environment, $debug);
+
+ // patch for behat/symfony2-extension not supporting %env(APP_ENV)%
+ $this->environment = $_S... | [AppKernel->[configureContainer->[setParameter,loadFromExtension,getEnvironment,load,getRootDir],configureRoutes->[import]]] | Registers all bundles. | why not `getenv('APP_ENV')`? |
@@ -85,7 +85,7 @@ public class ContainerStateMap {
private final ContainerAttribute<LifeCycleState> lifeCycleStateMap;
private final ContainerAttribute<String> ownerMap;
- private final ContainerAttribute<ReplicationFactor> factorMap;
+ private final ContainerAttribute<ReplicationConfig> factorMap;
private... | [ContainerStateMap->[updateContainerReplica->[contains],intersectSets->[contains],removeContainer->[contains],updateContainerInfo->[contains],removeContainerReplica->[contains],updateState->[contains]]] | This class is used to create a container state map. Add a container to the container list. | you may want to rename factorMap to replicationConfigMap ? |
@@ -435,6 +435,13 @@ Service_Participant::get_domain_participant_factory(int &argc,
}
this->monitor_.reset(this->monitor_factory_->create_sp_monitor(this));
+
+#ifdef ACE_LINUX
+ network_config_publisher_ = make_rch<LinuxNetworkConfigPublisher>(reactor_task_.interceptor());
+#endif
+ if (netwo... | [No CFG could be retrieved] | This function opens the DDS monitor and initializes it. Check if the command line arguments are set and if so set the appropriate values. | I'd rather see this tied to the choice of Discovery / Transport. Shmem applications aren't going to need to monitor network changes. |
@@ -32,7 +32,10 @@ class TestTranslation(DocumentTranslationTest):
def test_active_directory_auth(self):
token = self.generate_oauth_token()
endpoint = self.get_oauth_endpoint()
- client = DocumentTranslationClient(endpoint, token)
+ kwargs = {}
+ if os.getenv("AZURE_AUTHORIT... | [TestTranslation->[test_use_supported_and_unsupported_files->[create_target_container,_validate_translation_metadata,Document,create_source_container,result,TranslationTarget,begin_translation,DocumentTranslationInput,_validate_doc_status],test_single_input_with_kwargs->[callback->[loads,deserialize],TranslationGlossar... | test_active_directory_auth - test if the user is logged in and have access. | An alternative would be to set the credential scope as an env var in the subscription config or as an output in the arm template, that way you don't have to hardcode endpoints into the test. |
@@ -98,3 +98,9 @@ export const TOOLBOX_ALWAYS_VISIBLE = 'toolbox.alwaysVisible';
* Default: disabled (false).
*/
export const WELCOME_PAGE_ENABLED = 'welcomepage.enabled';
+
+/**
+ * Flag indicating if server URL change is allowed.
+ * Default: enabled (true)
+ */
+export const SERVER_URL_CHANGE_ALLOWED = 'server-... | [No CFG could be retrieved] | Determind if Welcomepage is enabled. | Please sort the flags alphabetically. |
@@ -45,7 +45,7 @@ using System.Runtime.InteropServices;
// to distinguish one build from another. AssemblyFileVersion is specified
// in AssemblyVersionInfo.cs so that it can be easily incremented by the
// automated build process.
-[assembly: AssemblyVersion("2.1.0.4395")]
+[assembly: AssemblyVersion("2.2.0.4207")]... | [Satellite] | Assigns the given type to the assembly. | ah I forgot to exclude this in `master` branch but I guess no harm to update the baseline since it is already 2.2 |
@@ -16,6 +16,7 @@ import (
var admissionPluginsNotUsedByKube = sets.NewString(
"AlwaysAdmit", // from kube, no need for this by default
"AlwaysDeny", // from kube, no need for this by default
+ "AlwaysPullImages", // from kube, not enabled by default. This is only applicable to some e... | [GetPlugins,Has,Difference,List,Errorf,NewString] | This package is used to add admission control to a specific node. - resources. md . | Remove the entry further down in the list. Why don't we enable it by default? I didn't because I didn't want to deal with behavior fallout. |
@@ -941,6 +941,12 @@ void sms_cart(device_slot_interface &device)
device.option_add_internal("korean_nb", SEGA8_ROM_KOREAN_NB);
}
+void sms_card(device_slot_interface &device)
+{
+ device.option_add_internal("rom", SEGA8_ROM_STD);
+ device.option_add_internal("3dadp", SEGA8_ROM_3D_ADAPTOR);
+}
+
void gg_cart(d... | [No CFG could be retrieved] | This function is called from the slot interface. It adds the options to the device slot interface. | I don't see why this option is internal - it should be directly accessible, since it isn't used to load software. |
@@ -184,7 +184,7 @@ export default class Reviews extends Component {
}}
>
{loading ? (
- <fbt desc="reviews.loadingMore">Loading More...</fbt>
+ <LoadingSpinner />
) : (
<>
... | [No CFG could be retrieved] | Renders a single . XML - >. | It may be appropriate to run the translation commands to remove these now unused string instances. |
@@ -149,7 +149,6 @@ class _SdkContainerImageLocalBuilder(SdkContainerImageBuilder):
_LOGGER.info("Building sdk container, this may take a few minutes...")
now = time.time()
subprocess.run(['docker', 'build', '.', '-t', container_image_name],
- capture_output=True,
... | [SdkContainerImageBuilder->[build_container_image->[build]]] | Invoke docker build and push if necessary. | How about `subprocess.run([ ], stdout=subprocess.PIPE)` Woud this capture stdout and print STDERR? |
@@ -17,12 +17,6 @@ namespace NServiceBus
Local = 0,
Remote = 1,
}
- public class AllAssemblies : NServiceBus.IExcludesBuilder, NServiceBus.IIncludesBuilder, System.Collections.Generic.IEnumerable<System.Reflection.Assembly>, System.Collections.IEnumerable
- {
- public static NService... | [No CFG could be retrieved] | Provides a class to handle the case where a resource is not available in the NServiceBus The base class for the class. | Shouldn't that be properly obsoleted as well? |
@@ -33,6 +33,9 @@ from tensorflow.python.ops import metrics as metrics_module
from tensorflow.python.platform import tf_logging as logging
from tensorflow.python.training import saver as saver_lib
from tensorflow.python.training import training_util
+from tensorflow.python.saved_model import signature_constants
+
+_... | [_save_first_checkpoint->[_clone_and_build_model],model_to_estimator->[_save_first_checkpoint,_create_keras_model_fn],_clone_and_build_model->[_create_ordered_io],_create_keras_model_fn->[model_fn->[_clone_and_build_model]]] | Create a list of tensors from IO dictionary based on Keras IO order. | Add new dependency to tensorflow/python/keras/BUILD. |
@@ -26,7 +26,7 @@ handler404 = 'saleor.core.views.handle_404'
non_translatable_urlpatterns = [
url(r'^dashboard/',
include((dashboard_urls, 'dashboard'), namespace='dashboard')),
- url(r'^graphql/', csrf_exempt(GraphQLView.as_view(
+ url(r'^graphql', csrf_exempt(GraphQLView.as_view(
schema... | [include,static,url,csrf_exempt,as_view,i18n_patterns] | Imports the NI - specific urls and renders the necessary views. Returns a list of urls for a list of page - level resources. | Why would you like to change that? IMHO there should be exactly one way to access an API and Saleor terminates all other resource names with a slash. |
@@ -19,16 +19,15 @@
package io.druid.segment.data;
-import java.nio.ByteBuffer;
-
import com.google.common.collect.Ordering;
-
import io.druid.collections.bitmap.BitmapFactory;
import io.druid.collections.bitmap.ConciseBitmapFactory;
import io.druid.collections.bitmap.ImmutableBitmap;
import io.druid.collecti... | [ConciseBitmapSerdeFactory->[ImmutableConciseSetObjectStrategy->[toBytes->[toBytes],compare->[compare]]]] | Creates a Serde that creates an immutable immutable coarse - grained bitmap from a managed unexpected n - bits - 1 - 1 - 1 - 0. | Or this file. |
@@ -83,10 +83,10 @@ public class ClientInfoResourceTest
}
@Test
- public void testGetDatasourceNonFullWithLargeInterval()
+ public void testGetDatasourceNonFullWithInterval()
{
- Map<String, Object> actual = resource.getDatasource(dataSource, "1975/2050", null);
- Map<String, ?> expected = ImmutableM... | [ClientInfoResourceTest->[testGetDatasourceWithConfiguredDefaultInterval->[of,assertEquals,getResourceTestHelper,getDatasource,SegmentMetadataQueryConfig],testGetDatasourceFullWithLargeInterval->[assertEquals,verify,of,getDatasource],testGetDatasourceWithDefaultInterval->[size,assertEquals,getDatasource],addSegment->[a... | Get a dataset from the server with a large interval. | any reason we are changing the interval on those tests? |
@@ -12,3 +12,7 @@ class PythonGrpcioLibrary(PythonTarget):
def __init__(self, sources=None, **kwargs):
super(PythonGrpcioLibrary, self).__init__(sources=sources, **kwargs)
+
+ @classmethod
+ def alias(cls):
+ return 'python_grpcio_library'
| [PythonGrpcioLibrary->[__init__->[super]]] | Initialize a library with a sequence of sources. | Introducing this class method and consuming it in register.py feels like it's a separate semantic change. Could you break it out into it's own small PR? |
@@ -67,7 +67,8 @@ var updateAdminBar = require( './ui/adminBar' ).update;
snippetCite: this.getDataFromInput( 'cite' ),
primaryCategory: this.getDataFromInput( 'primaryCategory' ),
searchUrl: wpseoPostScraperL10n.search_url,
- postUrl: wpseoPostScraperL10n.post_edit_url
+ postUrl: wpseoPostScraperL10n.p... | [No CFG could be retrieved] | Get the data from the input fields and store them in an analyzerData object. This function is used to get the new post slug. | I think it is better to (re)use the variable 'url' instead of calling the 'getDataFromInput' function again. |
@@ -1078,6 +1078,16 @@ public class StorageManagerImpl extends ManagerBase implements StorageManager, C
}
}
+ //destroy snapshots in destroying state in snapshot_store_ref
+ List<SnapshotDataStoreVO> ssSnapshots = _snapshotStoreDao.l... | [StorageManagerImpl->[getHypervisorType->[getHypervisorType],discoverImageStore->[getName],StorageGarbageCollector->[runInContext->[cleanupStorage]],getDataObjectSizeIncludingHypervisorSnapshotReserve->[getDataObjectSizeIncludingHypervisorSnapshotReserve],updateStoragePool->[enablePrimaryStoragePool,disablePrimaryStora... | This method is called when a VM is no longer referenced in any of the storage pools. This method is used to remove all the nodes in the cluster and all of its children. This method attempts to destroy the volume. | deleteSnapshot() is going to send an agent command to cleanup the snapshot from secondary, if there is any failure will cleanup be retried or the DB entry is simply updated? |
@@ -13,9 +13,13 @@ import UM.Settings.SettingFunction
#
# This keeps a list of extruder stacks for each machine.
class ExtruderManager(QObject):
- ## Signal to notify other components when the list of extruders changes.
+ ## Signal to notify other components when the list of extruders for a machine definit... | [ExtruderManager->[removeMachineExtruders->[getInstance],_addCurrentMachineExtruders->[addMachineExtruders,getInstance],addMachineExtruders->[getInstance],createExtruderTrain->[getInstance],getExtruderValue->[getInstance],getExtruderStack->[getInstance],getActiveExtruderStack->[getInstance],getInstanceExtruderValues->[... | Initialize the object with a base object of the base class and a dictionary of the extru. | I prefer to call signals that trigger when something changes "somethingChanged", so in this case "extruderDefinitionsChanged" or something similar. |
@@ -1605,7 +1605,7 @@ describe PublicBody, " when loading CSV files" do
describe 'with an existing body with tags' do
before do
- @body = FactoryBot.create(:public_body, :tag_string => 'first_tag second_tag')
+ @body = FactoryBot.create(:public_body, tag_string: 'first_tag second_tag')
... | [set_default_attributes->[last_edit_comment,short_name,last_edit_editor,request_email,name],import_csv_from_file,create,let,tag_string,with_tag,it,to,yield_with_args,change,last_edit_comment,get_request_percentages,each,match,length,context,get_request_totals,find_by_name,reload,with_locale,and_return,internal_admin_bo... | replaces when no tag_string is specified create with tags different tags in csv replace. | Line is too long. [83/80] |
@@ -231,7 +231,12 @@ class GraphLockRevisionTest(unittest.TestCase):
self._check_lock("PkgB/0.1@")
# If we create a new PkgA revision, for example adding info
- client.save({"conanfile.py": str(TestConanFile("PkgA", "0.1", info=True))})
+ client.save({"conanfile.py":
+ ... | [GraphLockCustomFilesTest->[test->[_check_lock]],GraphLockRevisionTest->[create_lock_test->[_check_lock],setUp->[_check_lock],export_pkg_test->[_check_lock],install_info_lock_test->[_check_lock],export_lock_test->[_check_lock]],GraphLockPythonRequiresTest->[create_test->[_check_lock],install_info_test->[_check_lock],ex... | Setup the client and client for the package. Un - lock - file. | revision shouldn't change, should it? |
@@ -699,8 +699,12 @@ class DatasetV2(tracking_base.Trackable, composite_tensor.CompositeTensor):
def prefetch(self, buffer_size):
"""Creates a `Dataset` that prefetches elements from this dataset.
- Note that if the dataset was batched using `Dataset.batch`, each element is
- a batch and this operation ... | [_OptionsDataset->[__init__->[wrapper_fn->[],_wrapper_helper->[],merge,options]],TakeDataset->[__init__->[wrapper_fn->[],_wrapper_helper->[],flat_structure]],SkipDataset->[__init__->[wrapper_fn->[],_wrapper_helper->[],flat_structure]],RangeDataset->[__init__->[wrapper_fn->[],_wrapper_helper->[],flat_structure]],from_va... | Creates a Dataset that prefetches elements from this dataset. | replace "elements of the dataset" with "elements of the input dataset". |
@@ -111,9 +111,16 @@ namespace DotNetNuke.Entities.Urls
if (request != null)
{
- if (request.UrlReferrer != null)
+ try
{
- log.LogProperties.Add(new LogDetailInfo("Referer", request.UrlReferrer.AbsoluteUri));
+ ... | [UrlRewriterUtils->[CleanExtension->[CleanExtension]]] | Log 404 page. | Can this be changed to catch the specific exception type, please? |
@@ -487,6 +487,7 @@ module.exports = function (grunt) {
]);
grunt.registerTask('build', [
+ 'newer:jscs',
'jshint:all',
'clean:dist',
'wiredep',
| [No CFG could be retrieved] | Register the deprecation tasks. | this should be `jscs` only in case of build. `newer:jscs` should be used for the watch (around line 118 for basic .js and 125 for test files). |
@@ -87,6 +87,15 @@ func CreateMovePeerOperator(desc string, cluster opt.Cluster, region *core.Regio
Build(kind)
}
+// CreateReplaceLeaderPeerOperator creates an operator that replaces an old peer with a new peer, and move leader from old store firstly.
+func CreateReplaceLeaderPeerOperator(desc string, cluster op... | [allowLeader,GetStoreId,EnableLightWeight,ZapError,SetLeader,GetStorePeer,setTargetLeaderIfNotExist,Set,Copy,Error,GetID,RemovePeer,GetStartKey,SetPeers,AddPeer,Errorf,SetExpectedRoles,Reflect,GetRole,execChangePeerV2,GetPeers,MetaPeerRole,PromoteLearner,GetEndKey,IsLearner,EncodeToString,Build,EnableForceTargetLeader,... | CreateRegionOperator creates an operator that moves a region to specified stores. step returns SplitRegion object. | move leader from old store firstly? |
@@ -98,7 +98,7 @@ namespace System.Text.Json.Nodes
/// <param name="value">
/// The object to be added to the end of the <see cref="JsonArray"/>.
/// </param>
- [RequiresUnreferencedCode(JsonSerializer.SerializationUnreferencedCodeMessage)]
+ [RequiresUnreferencedCode(JsonValu... | [JsonArray->[Add->[Add],DebugView->[GetPath],WriteTo->[WriteTo],GetPath->[Add],CreateNodes->[Create,Add]]] | Adds the given object to the list if it can be found in the JSON. | Due to trimming this was discussed as a method that we may want to remove, and require usage of the `IList<T>.Add<T>(T value)` implementation. However since that requires an extra call to `JsonValue.Create()`, it affects usability. Have there been other non-JSON areas that we've discouraged API use from in this manner ... |
@@ -58,6 +58,9 @@ class ShardReadersPool {
this.kinesis = kinesis;
this.initialCheckpoint = initialCheckpoint;
this.queueCapacityPerShard = queueCapacityPerShard;
+ this.executorService = Executors.newCachedThreadPool();
+ this.numberOfRecordsInAQueueByShard = new ConcurrentHashMap<>();
+ this.s... | [ShardReadersPool->[nextRecord->[of,poll,absent,ackRecord,warn],start->[size,build,getShardId,readLoop,values,createShardIterator,newFixedThreadPool,put,builder,submit],readLoop->[readNextBatch,error,get,warn,info,put],stop->[RuntimeException,error,awaitTermination,shutdownNow,set,warn,info],getCheckpointMark->[toList,... | Start the consumer. | Hm this is concerning - if we start with 0 shards, the queue is forever doomed to be of size 1 which is probably quite bad for performance. |
@@ -30,7 +30,7 @@ var k8sComponentVersions = map[string]map[string]string{
"aci-connector": "virtual-kubelet:latest",
ContainerMonitoringAddonName: "oms:ciprod01092019",
AzureCNINetworkMonitoringAddonName: "networkmonitor:v0.0.6",
- "cluster-autoscaler": "cluster-autosca... | [Itoa,Join,GetAllSupportedKubernetesVersions,FormatFloat,Split] | Returns a list of all supported k8s components. This function is used to convert the default values of the backoff backoff backoff backoff duration and backoff. | We were already using this cluster-autoscaler for Kubernetes 1.14.2, this just bumps it for 1.15.0-alphas (which don't have a specific CA release yet). |
@@ -1690,14 +1690,10 @@ public final class OzoneManager extends ServiceRuntimeInfoImpl
}
/**
- * Changes the owner of a volume.
- *
- * @param volume - Name of the volume.
- * @param owner - Name of the owner.
- * @throws IOException
+ * {@inheritDoc}
*/
@Override
- public void setOwner(Stri... | [OzoneManager->[listS3Buckets->[buildAuditMessageForFailure,buildAuditMessageForSuccess,checkAcls,buildAuditMap,listBuckets],completeMultipartUpload->[buildAuditMessageForFailure,buildAuditMessageForSuccess,completeMultipartUpload],getVolumeInfo->[checkAcls,getVolumeInfo],loginOMUserIfSecurityEnabled->[loginOMUser],joi... | Sets the owner of the given volume. | Just curious if this ever return false? |
@@ -42,11 +42,16 @@ import (
)
const (
- // The maximum number of records to keep for restarting processes
+ // MaxDeathRecords The maximum number of records to keep for restarting processes
MaxDeathRecords = 5
// the length of a truncated ID for use as hostname
shortLen = 12
+
+ // temp directory to copy e... | [Start->[processSessions,initializeSessions,cleanup,setup,setHostname,setLogLevel,setNetworks,reloadExtensions,setMounts]] | Creates a new object with the given name and values. New creates a new instance of the tether. | suggest you use a path in `/.tether` (a tmpfs) that's based off the volume label - that prevents any collisions and means we don't accidentally leave file system changes around if the container's killed in the middle of this operation. |
@@ -49,6 +49,11 @@ export function installAd(win) {
class AmpAd extends BaseElement {
+ /** @override */
+ getElementPriority() {
+ return 2;
+ }
+
/** @override */
renderOutsideViewport() {
// If another ad is currently loading we only load ads that are currently
| [No CFG could be retrieved] | Package functions for the base - element and adds it to the window. Checks if layout size is defined. | Please add something like `// loads ads after other content and analytics.` |
@@ -316,13 +316,6 @@ class TopicView
@group_names = result
end
- # Find the sort order for a post in the topic
- def sort_order_for_post_number(post_number)
- posts = Post.where(topic_id: @topic.id, post_number: post_number).with_deleted
- posts = filter_post_types(posts)
- posts.select(:sort_order... | [TopicView->[relative_url->[relative_url],participant_count->[participant_count],title->[title],setup_filtered_posts->[filtered_post_id,summary,has_deleted?],initialize->[preload,chunk_size,print_chunk_size],filter_posts_by_ids->[filter_post_types],image_url->[image_url],unfiltered_posts->[filter_post_types],filter_pos... | Returns a list of group names that are not part of any group in the topic. | I don't see this being used in core or in our plugins. |
@@ -12,6 +12,9 @@ module.exports = {
// Enable this once we find a way to inspect the iframe document's tree.
// '@storybook/addon-a11y',
'@storybook/addon-viewport/register',
+ '@storybook/addon-controls/register',
+ // TODO(alanorozco): Remove addon-knobs once all stories are migrated to
+ // ... | [No CFG could be retrieved] | The webpack config object for the AMP module. | super nit: can we attach this todo to a tracking issue instead of a person? it could also include tasks like updating our component how-to docs |
@@ -5568,6 +5568,9 @@ void SpellMgr::LoadDbcDataCorrections()
spellInfo->AttributesEx3 |= SPELL_ATTR3_SUPRESS_TARGET_PROCS;
});
+ ApplySpellFix({ 29069 }, [](SpellEntry* spellInfo) { spellInfo->EffectBasePoints[0] = 5000;
+ });
+
ApplySpellFix({ 66320, 67472, 67473, 67475 }, [](SpellEntry* s... | [No CFG could be retrieved] | The following functions are used to set the implicit target and radius of the possible target. Trial of the Crusader - Jaraxxus - Curse of the N. | is this weird indentation intended? |
@@ -0,0 +1,18 @@
+module Db
+ module EstablishConnection
+ class ReadReplica
+ def self.call
+ rails_env = Rails.env
+ return if rails_env.test?
+ env = Figaro.env
+ ActiveRecord::Base.establish_connection(
+ adapter: 'postgresql',
+ database: rails_env.production?... | [No CFG could be retrieved] | No Summary Found. | the two classes seem to only differ by this one line...did you consider having two methods on a single class? Like `Db::ConnectionManager.in_read_replica` and `.in_leader_node` or something? |
@@ -678,7 +678,10 @@ if ($action == "order" and $placeid != 0)
$printer = new dolReceiptPrinter($db);
}
- $headerorder = '<html><br><b>'.$langs->trans('Place').' '.$place.'<br><table width="65%"><thead><tr><th class="left">'.$langs->trans("Label").'</th><th class="right">'.$langs->trans("Qty").'</th></tr></thead... | [fetch,addPaymentToBank,update_price,create,getObjectsInCateg,fetch_object,addline,get_full_arbo,order,transcountry,getNomUrl,rollback,insert,getSellPrice,begin,sendToPrinter,load,getRemainToPay,containing,setPaymentMethods,fetch_array,loadLangs,update,setMulticurrencyCode,escape,delete,getFullName,fetch_optionals,text... | function to get the n - ary object from the database This function checks if there are any product related to the invoice and if so updates the corresponding. | To be sure to avoid sql injection, where sql is forged with a test on a parameter that is coming un url, it is better to protect sql forged with ...rowid = ".((int) $place); Can you fix this ? |
@@ -134,6 +134,10 @@ namespace Dynamo.UI.Controls
// When launching this control, always start with clear search term.
SearchTextBox.Clear();
+ Analytics.TrackEvent(
+ Dynamo.Logging.Actions.Open,
+ Dynamo.Logging.Categories.NodeAutoCompleteOperations);
+
... | [NodeAutoCompleteSearchControl->[OnMouseLeftButtonUp->[OnRequestShowNodeAutoCompleteSearch],OnInCanvasSearchKeyDown->[ExecuteSearchElement,OnRequestShowNodeAutoCompleteSearch,UpdateHighlightedItem]]] | OnNodeAutoCompleteSearchControlVisibilityChanged - NodeAutoCompleteSearchControlVisibilityChanged. | Doesn't this get called twice - once when the control becomes visible and once when it gets hidden? |
@@ -0,0 +1,5 @@
+# typed: strict
+
+class Parent::Child < PackageSpec
+ import Parent
+end
| [No CFG could be retrieved] | No Summary Found. | The issue, as I understand it, is that this `import` statement defines a constant `Parent` that is equal to the module `Parent`. But then you can't define `Parent::Child`... right? |
@@ -2362,6 +2362,9 @@ templates: ${JSON.stringify(existingTemplates, null, 2)}`;
if (options.skipFakeData) {
this.jhipsterConfig.skipFakeData = true;
}
+ if (options.withGeneratedFlag) {
+ this.jhipsterConfig.withGeneratedFlag = true;
+ }
if (options.skip... | [No CFG could be retrieved] | Load common options from stored options. Options that are not required are required by the jhipster config. | Not needed, we already doing this at `generator-base` constructor. |
@@ -12,7 +12,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# ==============================================================================
-"""Benchmarks for `tf.data.experimental.map_and_batch()`."""
+"""Benchmarks for `tf.data.experimental.map_and_bat... | [MapAndBatchBenchmark->[benchmark_map_and_batch_chaining_versus_fusing->[benchmark->[name,make_dataset],benchmark]]] | Benchmarks for performance of parallelized batching. Random number of unique elements in the batch. | I would be in favor of adding the eager support the functionality is not deprecated. What is deprecated is the way to invoke it through the public API (using `tf.data.Options` to specify which optimizations to run instead of applying the fusion manually). |
@@ -478,8 +478,14 @@ public class DirectDruidClient<T> implements QueryRunner<T>
jp = objectMapper.getFactory().createParser(future.get());
final JsonToken nextToken = jp.nextToken();
if (nextToken == JsonToken.START_OBJECT) {
- QueryInterruptedException e = jp.getCodec().rea... | [DirectDruidClient->[JsonParserIterator->[close->[close]]]] | Initialize the object. | this will be a QueryInterruptedException in a QueryInterruptedException. I think that's ok, but is it intended? |
@@ -0,0 +1,10 @@
+module DataUpdateScripts
+ class SetProperDisplayAreaForProfileFields
+ def run
+ ProfileField.where.not(attribute_name: %w[brand_color1 brand_color2]).update_all(display_area: 0)
+ ProfileField.where(attribute_name:
+ %w[currently_hacking_on currently_learning mostly_work_with av... | [No CFG could be retrieved] | No Summary Found. | Hm, I thought we had already done something like this in the past and also added display areas to `lib/data/dev_profile_fields.csv`, so if you really want to change it, please change it there too, they should be in sync, at lest for now. |
@@ -0,0 +1,16 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace System.Text.Json
+{
+ internal enum MetadataPropertyName
+ {
+ NoMetadata,
+ Values,
+ Id,
+ Ref,
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | I don't believe any of these using statements are necessary. Also copyright missing. |
@@ -163,10 +163,15 @@ public class ThriftHiveMetastoreClient
}
@Override
- public void dropTable(String databaseName, String name, boolean deleteData)
+ public void dropTableWithEnvironmentContext(String databaseName, String name, boolean deleteData, EnvironmentContext environmentContext)
... | [ThriftHiveMetastoreClient->[close->[close],get_config_value->[get_config_value],getTableWithCapabilities->[getTable]]] | Drops the table with the specified name and optionally deletes the data from the table. | can we avoid the `if` and always call `drop_table_with_environment_context` here? (otherwise we should rethink the method name) |
@@ -147,7 +147,7 @@ func (s *CreateStep) Logical() bool { return !s.replacing }
func (s *CreateStep) Apply(preview bool) (resource.Status, error) {
if !preview {
- if s.new.Custom {
+ if s.new.Custom && !s.iter.p.Refresh() {
// Invoke the Create RPC function for this provider:
prov, err :=... | [Color->[Failf],PastTense->[Failf],Apply->[Create,All,AppendStateSnapshot,Delete,URN,MarkStateSnapshot,Assert,Errorf,Done,Update],RawPrefix->[Failf],Prefix->[Color,RawPrefix],Package,Provider,Assert,Type,Plan] | Apply creates a new object in the live object state. | The more I think about Steps the more I feel like it would be a nicer model if Steps weren't responsible for their own execution (`Apply`). In my mind it would make sense for Steps to be POD objects that some other (possibly parallel) executor can apply. This would allow us to avoid all global state and callbacks from ... |
@@ -615,7 +615,7 @@ func TestPortInformation(t *testing.T) {
mockContainerInfo := &plmodels.ContainerInfo{}
mockContainerConfig := &plmodels.ContainerConfig{}
containerID := "foo"
- mockContainerConfig.ContainerID = &containerID
+ mockContainerConfig.ContainerID = containerID
mockHostConfig := &container.Host... | [IsRunning->[GetContainer,ContainerCache],StreamContainerLogs->[Sleep,Fprintf],AddContainer,Before,NewRequestNotFoundError,GetMockDataCount,Now,False,ContainerLogs,Add,NewErrorWithStatusCode,Error,SetMockDataResponse,NewAPIError,Errorf,ImageCache,NotEqual,ContainerCreate,Nil,RepositoryCache,NewVicContainer,Equal,ParseN... | TestPortInformation tests that the container logs are streamed. Config - config container id. | There are a lot of these changes where we are taking away the pointer. Can we not do these in a separate PR; preferably in an iterative manner? These kinds of changes always have the danger of introducing subtle bugs. |
@@ -219,7 +219,6 @@ urlpatterns = decorate(write, patterns('',
# URLs for a single add-on.
url('^addon/%s/' % ADDON_ID, include(detail_patterns)),
url('^app/%s/' % amo.APP_SLUG, include(app_detail_patterns)),
- url('^app/%s/submit/' % ADDON_ID, include(submit_apps_patterns)),
url('^ajax/addon/%... | [decorate,include,redirect,url,patterns,replace,join,map] | Returns a list of urls for a single add - on. Find the urls for a theme submit. | Remove this line too |
@@ -40,4 +40,9 @@ class Bison(AutotoolsPackage):
patch('pgi.patch', when='@3.0.4')
+ patch('https://raw.githubusercontent.com/macports/macports-ports/14451f57e89/devel/bison/files/secure_snprintf.patch',
+ level=0,
+ sha256='57f972940a10d448efbd3d5ba46e65979ae4eea93681a85e1d998060b356e0d2'... | [Bison->[depends_on,version,patch]] | Patch pgi. | you need to `import platform`, don't u? |
@@ -0,0 +1,7 @@
+import java.io.IOException;
+
+public class PlayerScoreException extends Exception {
+ public PlayerScoreException(IOException e) {
+ super(e);
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | This file still appears to be using tabs. |
@@ -15,6 +15,9 @@ namespace System.Security.Cryptography
public static new System.Security.Cryptography.Aes? Create(string algorithmName) { throw null; }
}
[System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")]
+ ... | [HMACSHA1->[Never],SHA384Managed->[Never],SHA1Managed->[Never],DES->[Never],SHA256Managed->[Never],Rijndael->[Never],RC2->[Never],RijndaelManaged->[Never],SHA512Managed->[Never],AesManaged->[Never]] | Creates an Aes object. Demonstrates how to use System. IDisposaGcm for a given. | I think we generally omit `maccatalyst` when there is already `ios` exclusion /cc @steveisok |
@@ -397,7 +397,7 @@ class LayerHelper(object):
act = self.kwargs.get('act', None)
if act is None:
return input_var
- if isinstance(act, basestring):
+ if isinstance(act, str):
act = {'type': act}
if 'use_cudnn' in self.kwargs and self.kwargs.get('use_... | [LayerHelper->[create_parameter->[_create_weight_normalize],append_bias_op->[create_tmp_variable,append_op,create_parameter],input_dtype->[multiple_input],_create_weight_normalize->[__reshape_op->[append_op],__norm_op->[append_op],__transpose_op->[append_op],__norm_except_dim->[__reshape_op,__transpose_op,__norm_op],__... | Append an activation to the network. | what if act is 'basestring' in py2? Would this line be silently skipped? |
@@ -79,15 +79,12 @@ public class HoodieLogFileReader implements HoodieLogFormat.Reader {
this.inputStream = new TimedFSDataInputStream(logFile.getPath(), new FSDataInputStream(
new BufferedFSInputStream((FSInputStream) ((
(FSDataInputStream) fsDataInputStream.getWrappedStream()).getWrap... | [HoodieLogFileReader->[close->[close],next->[readBlock],prev->[next,hasNext]]] | This class creates a buffer of bytes that can be read from a log file. Get the index of the first node in the sequence. | why error logging ? |
@@ -477,7 +477,7 @@ if (! empty($usemargins) && $user->rights->margins->creer)
/* JQuery for product free or predefined select */
jQuery(document).ready(function() {
- $("#prod_entry_mode_free").on( "click", function() {
+ $("#tablelines").on( "click", "#prod_entry_mode_free", function() {
setforfree();
});
... | [Create,select_type_of_lines,transnoentitiesnoconv,executeHooks,trans,load_tva,select_produits_fournisseurs,showOptionals,select_produits,load,selectUnits,select_date] | Displays a list of all calendar calendar objects that can be selected by the user. Checks if the user has input to mark a number with a percentage of free line. | Don t you think we should just replace the on usage by a click usage. $('#xxx').click(function ... It looks to be more jquery compliant. |
@@ -252,10 +252,10 @@ func (c *consulClient) WatchPrefix(prefix string, done <-chan struct{}, f func(s
})
if err != nil {
level.Error(util.Logger).Log("msg", "error getting path", "prefix", prefix, "err", err)
- backoff.wait()
+ backoff.Wait()
continue
}
- backoff.reset()
+ backoff.Reset()
/... | [Get->[Decode,Get],WatchPrefix->[wait,reset,Decode,WatchPrefix],PutBytes->[PutBytes],Encode->[Encode],Decode->[Decode],WatchKey->[wait,reset,Decode,WatchKey],CAS->[Encode,Decode,CAS]] | WatchPrefix watches the prefix for changes and calls the callback f for each key - value pair. | I wonder is `Ongoing` should check if `done` is closed, and then replace the call to `isClosed` here with a call to `Ongoing`? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.