patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -947,10 +947,8 @@ def plot_ica_components(ica, picks=None, ch_type=None, res=64,
if merge_grads:
from ..channels.layout import _merge_grad_data
for ii, data_, ax in zip(picks, data, axes):
- if ii in ica.exclude:
- ax.set_title('IC #%03d' % ii, fontsize=12, color='gray')
- ... | [_init_anim->[set_values,_make_image_mask,_check_outlines,_hide_frame,_GridData,_draw_outlines],plot_ica_components->[_make_image_mask,plot_ica_components,_check_outlines,_prepare_topo_plot,plot_topomap],plot_evoked_topomap->[_make_image_mask,_prepare_topo_plot,plot_topomap,_check_outlines],_plot_topomap_multi_cbar->[p... | Plot unmixing matrix on interpolated sensor topogrpahy. Plots a single key . Plots the components of a single ICA. Plots the topomap and colorbar for the critical components. DraggableColorbar for the nanoseconds. | Maybe `color="gray" if ii in ica.exclude else "black"` |
@@ -292,6 +292,13 @@ function AtD_should_load_on_page() {
return true;
}
+ /**
+ * Allows scripts to be loaded via AtD in admin.
+ *
+ * @since 1.2.3
+ *
+ * @param bool false Boolean to load or not load AtD scripts in admin.
+ */
return apply_filters( 'atd_load_scripts', false );
}
| [No CFG could be retrieved] | Checks if atd should load on the current page. | Suggestion: Add a description that includes a bit more detail. Something like "By default, AtD only enqueues JS on certain admin pages to reduce bloat. The filter allows additional pages to have AtD JS." |
@@ -4,11 +4,11 @@ module UserNameSuggester
GENERIC_NAMES = ['i', 'me', 'info', 'support', 'admin', 'webmaster', 'hello', 'mail', 'office', 'contact', 'team']
LAST_RESORT_USERNAME = "user"
- def self.suggest(name_or_email, allowed_username = nil)
+ def self.suggest(name_or_email)
return unless name_or_ema... | [apply_allowlist->[join],find_available_username_based_on->[nil?,to_s,username_available?,to_i,truncate,fix_username,end,hex,max_username_length,first,length,normalize_username],rightsize_username->[gsub!,size,end,begin,truncate],fix_username->[t,empty?,sanitize_username,rightsize_username],parse_name_from_email->[last... | Suggest a user name based on a name or email. | Did you change all the places where we call this method using the 2nd arg? |
@@ -60,6 +60,8 @@ const (
// maxInt is the maximum value for 'int' (system-dependent). Not in 'math'!
maxInt = int(^uint(0) >> 1)
+ // tmpPrefix is for temporary object paths that store merged shards.
+ tmpPrefix = "tmp"
)
var (
| [getTreeForOpenCommit->[scratchFilePrefix],finishOutputCommit->[checkIsAuthorizedInTransaction],upsertPutFileRecords->[scratchFilePrefix],deleteFile->[makeCommit,inspectCommit,checkIsAuthorized],listRepo->[getAccessLevel],scratchFilePrefix->[scratchCommitPrefix,checkFilePath],resolveCommitProvenance->[resolveCommit],ge... | Package names of the modules that are not in the expected package. IsPermissionError returns true if the given error is a permission error. | When / how are temporary objects cleaned up? Are they under the same GC system as the rest of the chunks? |
@@ -1045,6 +1045,17 @@ csum_chunk_align_ceiling(daos_off_t off, size_t chunksize)
return hi;
}
+daos_off_t
+csum_record_chunksize(daos_off_t default_chunksize, daos_off_t rec_size)
+{
+ D_ASSERT(rec_size > 0 && default_chunksize > 0);
+ if (default_chunksize % rec_size == 0)
+ return default_chunksize;
+ if (rec_... | [daos_csummer_free_ci->[daos_csummer_initialized],daos_csummer_get_srv_verify->[daos_csummer_initialized],daos_csummer_calc_key->[daos_csummer_get_csum_len,daos_csummer_get_type,daos_csummer_initialized],daos_csummer_get_chunksize->[daos_csummer_initialized],ci_set_null->[ci_set],csum_chunk_align_ceiling->[csum_chunk_a... | DWARS - 2068. | The first "if" branch is redundant, it can be covered by the subsequent "(default_chunksize / rec_size) * rec_size". |
@@ -214,9 +214,10 @@ func (u *Upgrade) Run(clic *cli.Context) (err error) {
}
if !u.Data.Rollback {
- err = executor.Configure(vch, vchConfig, vConfig, false)
+ err = executor.Configure(vchConfig, vConfig)
} else {
- err = executor.Rollback(vch, vchConfig, vConfig)
+ executor.Action = management.RollbackAct... | [Run->[NewDispatcher,CheckImagesFiles,Configure,Reference,Rollback,Error,Args,ValidateTarget,New,LogErrorIfAny,VCHUpdateStatus,NewVCHFromComputePath,AddDeprecatedFields,Errorf,FetchAndMigrateVCHConfig,Infof,SetVCHUpdateStatus,processParams,Logout,NewVCHFromID,Base,CollectDiagnosticLogs,AssertVersion,WithCancel,Validate... | Run executes the upgrade command upgrade - upgrade vch - config This function checks if the configuration is correct and if it is rollbacks it. | this really should have been a subcommand and not an option ... whelp... |
@@ -1478,7 +1478,9 @@ def batch_norm(input,
param_attr=None,
bias_attr=None,
data_layout='NCHW',
- name=None):
+ name=None,
+ moving_mean_name=None,
+ moving_variance_name=None):
"""
This function helps cre... | [conv2d->[_get_default_param_initializer],sequence_first_step->[sequence_pool],matmul->[__check_input],sequence_last_step->[sequence_pool],lstm_unit->[fc]] | Batch normalization layer for a single . This function is called when a network has no additional components. It is a wrapper around the. | if this `name` is still used? |
@@ -330,10 +330,16 @@ def parse_pyproject_toml(pyproject_toml: PyProjectToml) -> set[Requirement]:
# See: https://python-poetry.org/docs/pyproject/#dependencies-and-dev-dependencies
dependencies.pop("python", None)
+ groups = poetry_vals.get("group", {})
+ group_deps = {}
+
+ for group in groups.va... | [parse_single_dependency->[parse,handle_dict_attr,parse_str_version],parse_pyproject_toml->[parse_single_dependency,parse],parse_python_constraint->[conv_and,prepend,parse_str_version],PoetryRequirements->[__call__->[parse_pyproject_toml,create]],PyProjectToml->[non_pants_project_abs_path->[_non_pants_project_abs_path]... | Parse a PyProjectToml file and return a set of requirements. | Should these be `tool.poetry.dependencies`, rather than `poetry.tools`? Ditto dev deps |
@@ -1564,10 +1564,10 @@ dkey_update_begin(struct vos_io_context *ioc)
}
int
-vos_publish_scm(struct vos_container *cont, struct vos_rsrvd_scm *rsrvd_scm,
- bool publish)
+vos_publish_scm(struct vos_container *cont, void *data, bool publish)
{
- int rc = 0;
+ struct vos_rsrvd_scm *rsrvd_scm = data;
+ int rc = 0... | [No CFG could be retrieved] | vos_io_context_t ioc_cont = NULL ; Publish or cancel the NVMe block reservations. | I don't quite follow this change. |
@@ -73,3 +73,16 @@ class AttachmentScoresTest(AllenNlpTestCase):
# Neither batch element had a perfect labeled or unlabeled EM.
assert metrics["LEM"] == 0.0
assert metrics["UEM"] == 0.0
+
+ def test_attachment_scores_can_ignore_labels(self):
+ scorer = AttachmentScores(ignore_classe... | [AttachmentScoresTest->[test_perfect_scores->[get_metric,scorer],test_labeled_accuracy_is_affected_by_incorrect_heads->[get_metric,scorer],test_unlabeled_accuracy_ignores_incorrect_labels->[get_metric,scorer],setUp->[AttachmentScores,Tensor,super]]] | Test that the labeled accuracy is affected by incorrect heads. | It seems weird to score things this way. But I guess the assumption is that you'll always get these right, so we should just remove them? |
@@ -360,6 +360,15 @@ if ($projectid > 0) {
}
print '</td></tr>';
+ // Link to the vote/register page
+ print '<tr><td>'.$langs->trans("RegisterPage").'</td><td>';
+ $encodedid = dol_encode($project->id, $dolibarr_main_instance_unique_id);
+ $linkregister = $dolibarr_main_url_root.'/public/project/index.php?id='.$... | [fetch,selectMassAction,showOutputField,fetch_object,showInputField,isInt,order,setVarsFromFetchObj,getNomUrl,showCategories,editfieldval,selectarray,initHooks,getFieldList,idate,plimit,restrictedProjectArea,executeHooks,loadLangs,update,isFloat,sanitize,showCheckAddButtons,close,getProjectsAuthorizedForUser,textwithpi... | Displays an organize event Print a list of all categories and the project. | Do not use dol_encode to build the securekey (it is a reversable crtyp and we need a non reversable hash key) Use dol_hash($conf->global->EVENTORGANIZATION_SECUREKEY.'conferenceofbotth'.$project->id, 2); |
@@ -231,9 +231,15 @@ public class QuarkusTestExtension
}
T result;
ClassLoader old = Thread.currentThread().getContextClassLoader();
+ Class<?> requiredTestClass = extensionContext.getRequiredTestClass();
try {
- Thread.currentThread().setContextClassLoader(extensio... | [QuarkusTestExtension->[interceptBeforeAllMethod->[ensureStarted,isNativeTest],beforeEach->[isNativeTest],interceptTestMethod->[isNativeTest],interceptTestTemplateMethod->[isNativeTest],interceptAfterEachMethod->[isNativeTest],beforeAll->[setCCL,ensureStarted,isNativeTest],ExtensionState->[close->[close,setCCL]],afterA... | intercepts a test class constructor. | I would wrap the exception with this, not log it, so it shows up in the test failures. |
@@ -8,6 +8,9 @@ class GroupPermissionsForm(forms.ModelForm):
class Meta:
model = Group
fields = ['name', 'permissions']
+ labels = {
+ 'name': pgettext_lazy('Group name', 'Name'),
+ 'permissions': pgettext_lazy('Group permission', 'Permission')}
permissions = f... | [GroupPermissionsForm->[get_permissions,ModelMultipleChoiceField]] | Create a form to show the permissions of a group. | See other mentions of "name". |
@@ -3306,6 +3306,7 @@ func GeneratePackage(tool string, pkg *schema.Package) (map[string][]byte, error
importsAndAliases := map[string]string{}
pkg.getImports(r, importsAndAliases)
+ importsAndAliases["github.com/pulumi/pulumi/sdk/v3/go/pulumi"] = ""
buffer := &bytes.Buffer{}
pkg.genHeader(buffer,... | [outputType->[outputTypeImpl],outputTypeImpl->[resolveObjectType,outputTypeImpl,resolveResourceType,tokenToType,tokenToEnum],genEnumRegistrations->[detailsForType,tokenToEnum],genOutputTypes->[detailsForType,tokenToType,typeString,outputType],functionResultTypeName->[functionName],genResourceModule->[genHeader],argsTyp... | includes all the code that is needed to generate the . Generate code for function token. | Can you explain why this has moved? I would expect _functions_ to use it at least. (It seems like I'm wrong though.) |
@@ -14,7 +14,9 @@
* limitations under the License.
*/
+import {AmpStoryPlayer} from '../../src/amp-story-player';
import {AmpStoryPlayerManager} from '../../src/amp-story-player-manager';
+import {toArray} from '../../src/types';
describes.realWin('AmpStoryPlayer', {amp: false}, env => {
let win;
| [No CFG could be retrieved] | Creates an iframe with a link to the story player and a link to the story to show Unskip when messaging is enabled. | Can we use `manager.loadPlayers()` here too? If you need a way to retrieve the `player` instance to call `.next_()` until we can swipe, please add a TODO as well. |
@@ -47,6 +47,7 @@ import javax.jms.ConnectionFactory;
@Xml(prefix = "jmsn")
@Configurations({JmsConfig.class})
@ConnectionProviders({GenericConnectionProvider.class, ActiveMQConnectionProvider.class})
+@Operations(JmsAcknowledge.class)
@SubTypeMapping(
baseType = ConsumerType.class, subTypes = {QueueConsumer.c... | [No CFG could be retrieved] | This extension is used to provide a Mule extension for the which is used to. | old transport is already out of the distribution. Confirm with @elrodro83 if it's ok to change this to simply `jms` |
@@ -39,10 +39,10 @@
id="copy-post-url-button"
class="flex justify-between crayons-link crayons-link--block w-100 bg-transparent border-0"
data-postUrl="<%= article_url(@article) %>">
- <span class="fw-bold"><%= t("core.copy_link") %></span>
- <%= inline_svg_t... | [No CFG could be retrieved] | Displays a hidden section of the menu that shows the content of a block of content that can Displays a link with a link to the article with a link to the link to the link. | Is there a specific reason for keeping the names of the services uppercase? I'd be ok with "views.actions.share.twitter.text" |
@@ -0,0 +1,13 @@
+#nullable enable
+
+namespace Content.Shared.Preferences
+{
+ public enum CrewUniformPreference
+ {
+ Default,
+ Trek,
+ NextGen,
+ Enterprise,
+ Federation
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | Making this an enum is pretty dirty, should be a prototype. |
@@ -81,6 +81,17 @@ public class InjvmProtocolTest {
}
+ @Test
+ public void testLocalProtocolWithToken() throws Exception {
+ DemoService service = new DemoServiceImpl();
+ Invoker<?> invoker = proxy.getInvoker(service, DemoService.class, URL.valueOf("injvm://127.0.0.1/TestService?token=abc... | [InjvmProtocolTest->[testLocalProtocol->[DemoServiceImpl,assertTrue,InjvmInvoker,getName,getInvoker,assertFalse,export,isAvailable,getProxy,invoke,valueOf,add,addParameter,assertEquals,refer,getSize],after->[clear,unexport],testIsInjvmRefer->[DemoServiceImpl,assertTrue,getName,getInvoker,export,isInjvmRefer,add,addPara... | Test if the protocol is available on the local machine. This method checks if the given URL is a known protocol and if so it can be used. | pls destroy it in the final |
@@ -324,10 +324,17 @@ public class GobblinHelixJobScheduler extends JobScheduler implements StandardMe
}
@Subscribe
- public void handleDeleteJobConfigArrival(DeleteJobConfigArrivalEvent deleteJobArrival) {
+ public void handleDeleteJobConfigArrival(DeleteJobConfigArrivalEvent deleteJobArrival) throws Interru... | [GobblinHelixJobScheduler->[startUp->[startUp],scheduleJob->[scheduleJob],handleNewJobConfigArrival->[scheduleJob],NonScheduledJobRunner->[run->[runJob]],scheduleJobImmediately->[cancel->[cancel],get->[get],isDone->[isDone],isCancelled->[isCancelled]],handleUpdateJobConfigArrival->[handleNewJobConfigArrival]]] | Handle delete for job configuration arrival. | Should the default be false or true? It could be argued that the expected behavior on a job spec deletion is that running jobs should be cancelled? Are you just trying to maintain backward compatibility of this with current jobs? |
@@ -25,8 +25,8 @@ class Jetpack_SSO_Notices {
),
array( 'a' => array( 'href' => array() ) )
),
- 'https://wordpress.com/me/security/two-step',
- 'https://support.wordpress.com/security/two-step-authentication/'
+ Redirect::get_url( 'calypso-me-security-2fa' ),
+ Redirect::get_url( 'wpcom-support-... | [No CFG could be retrieved] | This function is used to display an error message when a Two - Step authentication is required to. | Should we use Calypso here? I also wonder if we should use `two-step-authentication` here as well, so it's easier to remember? |
@@ -105,8 +105,15 @@ http::client TLSTransport::getClient() {
<< server_certificate_file_;
} else {
// There is a non-default server certificate set.
+ boost::system::error_code ec;
+
+ auto status = fs::status(server_certificate_file_, ec);
options.openssl_verify_path(s... | [No CFG could be retrieved] | r Returns a TLSTransport client. Optionally though all TLS plugins should set a hostname supply an SNI. | We should include an `else` and a `LOG(WARNING)`. |
@@ -29,7 +29,7 @@ import (
testginkgo "github.com/openshift/origin/pkg/test/ginkgo"
"github.com/openshift/origin/pkg/version"
exutil "github.com/openshift/origin/test/extended/util"
- "github.com/openshift/origin/test/extended/util/cloud"
+ "github.com/openshift/origin/test/extended/util/cluster"
)
func main(... | [AsEnv->[Sprintf,Marshal,V,Enabled,Level],SelectSuite->[TestSuites,SelectSuite],Profile,InitLogs,FlushLogs,StringVar,SelectSuite,Exec,TestSuites,Now,GlobalSuite,AsEnv,SetNormalizeFunc,Setenv,SuitesString,Close,MarkHidden,HasPrefix,Exit,Set,ClearAfterSuiteNode,IntVar,WithCleanup,Stop,LongDesc,UTC,StringVarP,PreSuite,Err... | The main function of the main function. Exec execs the command and runs the command. | This rename is fine, you could also pull this out into its own PR to reduce churn in this one |
@@ -1498,9 +1498,14 @@ void NodeDefManager::resetNodeResolveState()
m_pending_resolve_callbacks.clear();
}
-void NodeDefManager::mapNodeboxConnections()
+void NodeDefManager::resolveCrossrefs()
{
for (ContentFeatures &f : m_content_features) {
+ if (f.liquid_type != LIQUID_NONE) {
+ f.liquid_alternative_flow... | [removeNode->[getId],addNameIdMapping->[set],getIdFromNrBacklog->[getId],getNodeBoxUnion->[boxVectorUnion],applyTextureOverrides->[getId],getId->[getId],getIdsFromNrBacklog->[getIds,getId],nodeResolveInternal->[clear],reserve->[reserve],updateTextures->[correctAlpha,isWorldAligned,updateTextures,readSettings], reset->[... | NodeResolveState - reset node resolve state. | why continue ? |
@@ -45,6 +45,8 @@ type NodePackageInfo struct {
ModuleToPackage map[string]string `json:"moduleToPackage,omitempty"`
// Toggle compatibility mode for a specified target.
Compatibility string `json:"compatibility,omitempty"`
+ // Disable support for unions in output types.
+ DisableUnionOutputTypes bool `json:"dis... | [ImportObjectTypeSpec->[Unmarshal],ImportPackageSpec->[Unmarshal]] | NodePackageInfo is a description for the package. returns a raw object and an error if it s not possible to find a . | Curious - Why does this need to be opt-in? What are the cases where we *do* want to emit union outputs? And perhaps knowing the answer to that will make clearer why this is a global setting vs. a per-property setting? |
@@ -924,7 +924,7 @@ class MediatedTransfer(LockedTransfer):
)
@staticmethod
- def from_event(event: 'SendMediatedTransfer') -> 'MediatedTransfer':
+ def from_event(event: 'SendMediatedTransfer2') -> 'MediatedTransfer':
transfer = event.transfer
lock = transfer.lock
balan... | [Secret->[unpack->[Secret],from_event->[Secret],__init__->[assert_envelope_values]],Ack->[unpack->[Ack]],RefundTransfer->[from_event->[Lock,RefundTransfer],unpack->[Lock,RefundTransfer]],EnvelopeMessage->[sign->[packed,sign],message_hash->[packed]],Message->[__ne__->[__eq__]],Lock->[from_bytes->[Lock],__ne__->[__eq__],... | Creates a new MediatedTransfer from a SendMediatedTransfer event. | Same here and in all the other occassions where you use the `2` versions of stuff. Shouldn't they just be now renamed to lose the `2` suffix? |
@@ -24,18 +24,9 @@ class SignupForm(BaseSignupForm):
This overrides the default error messages for the username form field
with our own strings.
- It has an additional other_email form field to handle the case of GitHub
- which may deliver a number of emails for users to choose from upon signup.
-
... | [SignupForm->[clean->[error_class,super,get,clean_email],__init__->[super],raise_duplicate_email_error->[ValidationError],clean_email->[validate_email,strip,super],CharField,BooleanField,TextInput,_],_] | Creates a signup form for a user. The email field of the user name must be a valid email address. | Removed because now it *is* required and what's left if you change that is that this is just want the parent class set already. |
@@ -37,7 +37,8 @@ typedef enum OPTION_choice {
OPT_IN, OPT_OUT, OPT_MODULE,
OPT_PROV_NAME, OPT_SECTION_NAME, OPT_MAC_NAME, OPT_MACOPT, OPT_VERIFY,
OPT_NO_LOG, OPT_CORRUPT_DESC, OPT_CORRUPT_TYPE, OPT_QUIET, OPT_CONFIG,
- OPT_NO_CONDITIONAL_ERRORS
+ OPT_NO_CONDITIONAL_ERRORS,
+ OPT_NO_SECURITY_CHE... | [CONF->[app_load_config_bio,BIO_s_mem,BIO_new,CONF_modules_load,NCONF_free,write_config_header,BIO_free,write_config_fips_section],int->[app_load_config,OPENSSL_CTX_load_config,OPENSSL_buf2hexstr,NCONF_get_string,EVP_MAC_size,memcmp,NCONF_free,print_mac,BIO_read,EVP_MAC_update,strcmp,BIO_printf,OPENSSL_hexstr2buf,EVP_M... | Configuration file configuration. Section that defines the parameters of the parent config that should be used when verifying and generating. | Please remove the stray comma here. |
@@ -0,0 +1,15 @@
+<a class="current-task-item" href="<%= protocols_my_module_path(task.id) %>">
+ <div class="current-task-breadcrumbs"><%= task.experiment.project.name %>
+ <span class="slash">/</span><%= task.experiment.name %></div>
+ <div class="task-name row-border">
+ <%= task.name %>
+ </div>
+ <div cl... | [No CFG could be retrieved] | No Summary Found. | why text here ? |
@@ -302,6 +302,15 @@ class DeviceSpecV2(object):
dev.device_index if dev.device_index is not None else self.device_index,
)
+ @staticmethod
+ def _get_valid_device_types():
+ valid_device_types = set({})
+ physical_devices = pywrap_tfe.TF_ListPluggablePhysicalDevices()
+ for device in physica... | [DeviceSpecV1->[merge_from->[_get_combined_properties],parse_from_string->[_string_to_components],__hash__->[to_string],to_string->[_components_to_string],device_index->[_as_int_or_none],device_type->[_as_device_str_or_none],task->[_as_int_or_none],job->[_as_str_or_none],replica->[_as_int_or_none]],_as_device_str_or_no... | Combine the current DeviceSpec with another DeviceSpec and return a tuple of the combined properties. Return a tuple of job replica task device_type device_index. | Can this set of valid devices be cached and re-generated only on failure? There may be quite a few physical devices, and parsing device strings happens quite frequently. |
@@ -588,13 +588,13 @@ class RemoteBASE(object):
def _download_dir(
self, from_info, to_info, name, no_progress_bar, file_mode, dir_mode
):
- file_to_infos = (
- to_info / file_to_info.relative_to(from_info)
- for file_to_info in self.walk_files(from_info)
+ from_in... | [RemoteBASE->[_check_requires->[RemoteMissingDepsError],all->[path_to_checksum,list_cache_paths],_download_dir->[walk_files],remove->[RemoteActionNotImplemented],changed_cache->[is_dir_checksum,changed_cache_file,_changed_dir_cache],_cache_is_copy->[link],load_dir_cache->[DirCacheError],symlink->[RemoteActionNotImpleme... | Download a directory and return number of download futures. | There might a significant delay here before we see pbar. May ignore this for now though. |
@@ -76,8 +76,11 @@ public class JavaSquid implements SourceCodeSearchEngine {
Iterable<CodeVisitor> measurers = Arrays.asList((CodeVisitor)measurer);
visitorsToBridge = Iterables.concat(visitorsToBridge, measurers);
}
-
- VisitorsBridge visitorsBridge = new VisitorsBridge(visitorsToBridge, sonarC... | [JavaSquid->[search->[search],scanBytecode->[scan],scanSources->[scan]]] | Creates a new instance of JavaSquid. END of class. | The test `sonarComponents != null` is repeated 4 times in a row. It can be simplified. |
@@ -24,7 +24,8 @@ namespace Dynamo.UI.Views
PreviewKeyDown += new KeyEventHandler(HandleEsc);
DataContext = dynamoViewModel;
- Title = Dynamo.Wpf.Properties.Resources.AboutWindowTitle;
+ Title = string.Format(Dynamo.Wpf.Properties.Resources.AboutWindowTitle,dynamoViewMo... | [RichTextFile->[OnFileChanged->[File,Document,ReadFile],HandleHyperlinkClick->[Start,Source,ToString,Handled],ReadFile->[ReadWrite,ContentEnd,Exists,Close,Rtf,Open,Read,Load,ContentStart],SetValue,GetValue,RequestNavigateEvent,AddHandler,Register],AboutWindow->[OnClickLink->[Start],OnPreviewMouseDown->[ignoreClose],Han... | HandleEsc - handle escape key. | Add a space after `,` everywhere. Intellisense should do it for you automatically, I wonder why it's not for you. |
@@ -189,11 +189,11 @@ var _ = Describe("Podman prune", func() {
after := podmanTest.Podman([]string{"images", "-a"})
after.WaitWithDefaultTimeout()
- Expect(none).Should(Exit(0))
- hasNoneAfter, result := none.GrepString("<none>")
+ Expect(after).Should(Exit(0))
+ hasNoneAfter, result := after.GrepString("<... | [WaitWithDefaultTimeout,GrepString,OutputToStringArray,Cleanup,Should,AddImageToRWStore,Sprintf,RunLsContainer,RunTopContainer,OutputToString,To,SeedImages,BuildImage,Podman,NumberOfPods,Exit,Setup,NumberOfContainers] | Yields the list of all images in the container that have the same name as the container It tests if all images are unused and no longer used. | I'm pretty sure this was a copy-paste bug from way back. |
@@ -25,7 +25,7 @@ def is_valid_source(src, fulls, prefixes):
a prefix in the list of valid prefix sources.
"""
- return src in fulls or any(p in src for p in prefixes)
+ return src in fulls or any(src.startswith(p) for p in prefixes)
class Command(BaseCommand):
| [is_valid_source->[any],Command->[add_arguments->[add_argument],handle->[,close_old_connections,get_stats_data,unlink,filter,join,info,enumerate,int,dict,bulk_create,exclude,values,is_valid_source,debug,len,update_inc,now,format,get_date,line,DownloadCount,CommandError,strip,values_list]],getLogger] | Return True if src is in fulls or prefixed by a prefix in prefixes. | This is an actual change because, as I understood it, the existing code was incorrect. |
@@ -12,8 +12,14 @@ UMASK_DEFAULT = 0o077
CACHE_TAG_NAME = 'CACHEDIR.TAG'
CACHE_TAG_CONTENTS = b'Signature: 8a477f597d28d172789f06886806bc55'
-DEFAULT_MAX_SEGMENT_SIZE = 5 * 1024 * 1024
-DEFAULT_SEGMENTS_PER_DIR = 10000
+# A large, but not unreasonably large segment size. Always less than 2 GiB (for legacy file syst... | [set] | Set of items in a cache. The number of errors that occurred during the operation. | hmm, is it worthwhile to go that big, by default? for remote operations on segment files over a slow connection, this can mean a huge transfer time per segment. how much would be performance worse if it was just 50MB? |
@@ -911,6 +911,12 @@ func resourceAwsAutoscalingGroupUpdate(d *schema.ResourceData, meta interface{})
opts.DefaultCooldown = aws.Int64(int64(d.Get("default_cooldown").(int)))
}
+ if d.HasChange("capacity_rebalance") {
+ if v, ok := d.GetOk("capacity_rebalance"); ok {
+ opts.CapacityRebalance = aws.Bool(v.(boo... | [StringLenBetween,Difference,GetChange,IgnoreAws,StringSlice,Merge,Set,NonRetryableError,Code,DescribeTargetHealth,DescribeLoadBalancerTargetGroups,UpdateAutoScalingGroup,Int64Value,GetOk,ParseBool,DetachLoadBalancerTargetGroups,IntAtLeast,HasChange,HasChanges,DescribeInstanceHealth,Sequence,Errorf,EnableMetricsCollect... | resourceAwsAutoscalingGroupUpdate updates the specified load balancer target group. Set max_size max_instance_lifetime health_check_type and health_check. | This should be set even if `ok==false` otherwise going from `true` to removing the attribute will leave it `true`. |
@@ -43,3 +43,13 @@ var WrapperComponentProps;
* }}
*/
var ContainWrapperComponentProps;
+
+/**
+ * @typedef {?string|!PreactDef.InnerHTML|!PreactDef.Renderable}
+ */
+var RendererFunctionResponseType;
+
+/**
+ * @typedef {function(!JsonObject):(?RendererFunctionResponseType|!Promise<?RendererFunctionResponseType>)... | [No CFG could be retrieved] | {{{ 1. | Nit: I believe `PreactDef.Renderable` already includes `string` |
@@ -19,6 +19,7 @@ import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.instanceOf;
import static org.hamcrest.MatcherAssert.assertThat;
+import com.fasterxml.jackson.databind.node.JsonNodeFactory;
import io.confluent.ksql.test.model.WindowData;
import java.util.Optional;
impor... | [RecordTest->[shouldGetSessionWindowKey->[of,WindowData,start,equalTo,end,key,window,instanceOf,assertThat,Record],shouldGetTimeWindowKey->[of,WindowData,start,equalTo,end,key,window,instanceOf,assertThat,Record],shouldGetKey->[of,equalTo,key,assertThat,Record]]] | Tests if a record has a specific key. Test if a record should be created from a window. | nit: unused import. |
@@ -25,11 +25,13 @@ import java.util.Map;
public class VersionAwareProvider<T> implements Provider<T> {
private final Version elasticsearchVersion;
+ private final String elasticsearchMajorVersion;
private final Map<Version, Provider<T>> pluginBindings;
@Inject
public VersionAwareProvider(@N... | [VersionAwareProvider->[constructElasticsearchVersion->[from,parseInt],get->[IllegalStateException,get],constructElasticsearchVersion]] | Construct elasticsearch version from string. | Wouldn't it be enough to only use `elasticsearchMajorVersion` and drop `elasticsearchVersion`? |
@@ -146,7 +146,14 @@ public class DefaultExecutorService extends AbstractExecutorService implements D
this.invoker = registry.getComponent(InterceptorChain.class);
this.factory = registry.getComponent(CommandsFactory.class);
this.marshaller = registry.getComponent(StreamingMarshaller.class, CACHE_M... | [DefaultExecutorService->[RunnableAdapter->[call->[run]],shutdownNow->[realShutdown],DistributedRunnableFuture->[isDone->[isDone],equals->[getCommand,equals],hashCode->[hashCode],get->[get],cancel->[cancel],isCancelled->[isCancelled]],submitEverywhere->[submitEverywhere],invokeLocally->[submit],selectExecutionNode->[se... | Submits a task with the given result. | What if the cache is async ? |
@@ -114,9 +114,13 @@ async function main() {
// List of contracts the listener watches events from.
const contracts = {
IdentityEvents: contractsContext.identityEvents,
- Marketplace: contractsContext.marketplaces['000'].contract,
ProxyFactory: contractsContext.ProxyFactory
}
+ // Listen to all v... | [No CFG could be retrieved] | The main function of the tracking loop. Get the for a given contract. | One thing I just realized was `key` is 3 characters long (eg '000') but the config is 2 (eg 'V00'). Not sure if that affects this. Also might need to say `Object.keys(contractsContext.marketplaces || {})` incase no marketplaces are set yet for whatever reason |
@@ -122,8 +122,11 @@ void SetFileAutoDefineList(const Rlist *auto_define_list)
AUTO_DEFINE_LIST = auto_define_list;
}
-void VerifyFileLeaf(EvalContext *ctx, char *path, struct stat *sb, Attributes attr, const Promise *pp, PromiseResult *result)
+void VerifyFileLeaf(EvalContext *ctx, char *path, struct stat *sb,... | [No CFG could be retrieved] | This is the entry point for the device boundary. check if file has any missing attributes and return it. | The FIXME alert is intentional. This function doesn't respect it's attr, argument (it overwrote it), I didn't introduce it, but felt it was important enough to add a FIXME, not just TODO. |
@@ -8,10 +8,10 @@ class DbHelper
AND (data_type LIKE 'char%' OR data_type LIKE 'text%')
ORDER BY table_name, column_name"
- def self.remap(from, to)
+ def self.remap(from, to, anchor_left = false, anchor_right = false)
connection = ActiveRecord::Base.connection.raw_connection
remappable_columns... | [DbHelper->[find->[async_exec,ntuples,raw_connection,to_a,each,map],remap->[async_exec,refresh!,raw_connection,to_a,each]]] | Removes all missing values from one column to another. | It's more Ruby-ish to use `opts = {}` when there are more than 1 optional argument. |
@@ -224,6 +224,13 @@ def _synthesize_stim_channel(events, n_samp):
return stim_channel
+def _check_version(header):
+ end_tags = ['Version 1.0', 'Version 2.0']
+ if not any([header.endswith(end_tag) for end_tag in end_tags]):
+ raise ValueError("Currently only support %r. "
+ ... | [read_raw_brainvision->[RawBrainVision],_get_vhdr_info->[_read_vmrk_events]] | Creates a list of stimulus events from a vmrk file. Channels that should be designated MISC channels. | Shouldn't we check the `startswith`, too, to be more complete? |
@@ -0,0 +1,12 @@
+# coding=utf-8
+# Copyright 2018 Pants project contributors (see CONTRIBUTORS.md).
+# Licensed under the Apache License, Version 2.0 (see LICENSE).
+
+import pycountry
+
+from pants.contrib.awslambda.python.examples.hello_lib import say_hello
+
+
+def handler(event, context):
+ usa = pycountry.countr... | [No CFG could be retrieved] | No Summary Found. | Conventionally these would go in `examples` or `testprojects` folders at `contrib/awslambda/python/{examples,testprojects}` |
@@ -132,7 +132,9 @@ public class BeamEnumerableConverter extends ConverterImpl implements Enumerable
options
.getRunner()
.getCanonicalName()
- .equals("org.apache.beam.runners.direct.DirectRunner"));
+ .equals("org.apache.beam.runners.direct.DirectRunner"),
+ ... | [BeamEnumerableConverter->[copy->[BeamEnumerableConverter],toEnumerable->[toEnumerable],run->[run],count->[run],collect->[run]]] | Collect all values from the pipeline. | Now that I think about it, you have a race between checking this count and adding to the queue. The directRunner has a minimum of 3 worker threads so it is possible to hit. I still think the simple, safe, and portable implementation is to use `Collector`, check the size of the queue outside of the pipeline, and truncat... |
@@ -1879,6 +1879,15 @@ crt_hdlr_iv_sync(crt_rpc_t *rpc_req)
D_GOTO(exit, rc = -DER_NONEXIST);
}
+ /* Check group version match */
+ grp_ver = ivns_internal->cii_grp_priv->gp_membs_ver;
+ if (grp_ver != input->ivs_grp_ver) {
+ D_ERROR("Group (%s) version mismatch. Local: %d Remote :%d\n",
+ ivns_id.ii_group_na... | [No CFG could be retrieved] | Handle the CRT_IV_SYNC event. This function is called from the main loop of the main loop of the main loop of the. | Same here, i dont think this check is needed as we are not computing parent/children anywhere in this call |
@@ -94,11 +94,18 @@ func (repo *Repository) getCommit(id SHA1) (*Commit, error) {
gogitCommit, err := repo.gogitRepo.CommitObject(id)
if err == plumbing.ErrObjectNotFound {
tagObject, err = repo.gogitRepo.TagObject(id)
+ if err == plumbing.ErrObjectNotFound {
+ return nil, ErrNotExist{
+ ID: id.String(),
+... | [GetBranchCommit->[GetCommit,GetBranchCommitID],CommitsBetweenIDs->[CommitsBetween,GetCommit],GetBranchCommitID->[GetRefCommitID],getCommitByPathWithID->[getCommit],GetTagCommit->[GetTagCommitID,GetCommit],getCommitsBefore->[commitsBefore],getCommitsBeforeLimit->[commitsBefore],GetCommit->[getCommit,ConvertToSHA1]] | getCommit returns a commit object for the given SHA1. | Why we need a blank line here? |
@@ -54,11 +54,11 @@ public class LinkDomainToLdapCmd extends BaseCmd {
@Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, required = true, description = "type of the ldap name. GROUP or OU")
private String type;
- @Parameter(name = ApiConstants.LDAP_DOMAIN, type = CommandType.STRING, require... | [LinkDomainToLdapCmd->[execute->[getFirstname,getCommandName,getEmail,setObjectName,isDisabled,setAdminId,linkDomainToLdap,toString,info,ServerApiException,setResponseObject,valueOf,getLdapDomain,debug,setResponseName,getActiveAccountByName,getUser,getAccountId,getLastname,createUserAccount,getId],getLogger,getName]] | Creates a new command which links an existing cloudstack domain to the LDAP domain. Get the domainId type and ldapDomain. | Was this a regression that was added due to LDAP related enhancements, or could this cause issue if the field is made non-mandatory? |
@@ -134,7 +134,8 @@ dbuf_stats_hash_table_data(char *buf, size_t size, void *data)
ASSERT3S(dsh->idx, >=, 0);
ASSERT3S(dsh->idx, <=, h->hash_table_mask);
- memset(buf, 0, size);
+ if (size)
+ buf[0] = 0;
mutex_enter(DBUF_HASH_MUTEX(h, dsh->idx));
for (db = h->hash_table[dsh->idx]; db != NULL; db = db->db_h... | [No CFG could be retrieved] | This function returns the number of bytes written to the hash table. region dbuf_stats_hash_table. | This seems odd; if the size is non-zero, we terminate it immediately rather than at `size - 1`? |
@@ -22,7 +22,7 @@ public class OpenApiTestCase {
private static final String DEFAULT_MEDIA_TYPE = "application/json";
- @TestHTTPResource("openapi")
+ @TestHTTPResource("q/openapi")
URL uri;
@Test
| [OpenApiTestCase->[schemaTypeFromRef->[IllegalArgumentException,getString,substring,lastIndexOf,containsKey],schemaType->[IllegalArgumentException,getString,getJsonObject,schemaTypeFromRef,containsKey],testOpenAPIJSON->[setRequestProperty,size,openConnection,createReader,getJsonObject,ByteArrayOutputStream,schemaType,B... | Test that the OpenAPI JSON response contains a single key. Tests that normal and RX annotations have same schema. Sets the keys and types of the objects in the Multi - typed objects. | This is one of the only places w/o the leading '/' ... while it may work, the inconsistency is noticable |
@@ -11,11 +11,13 @@
namespace Dunglas\ApiBundle\Hydra\Serializer;
+use Symfony\Component\Debug\Exception\FlattenException;
use Symfony\Component\Routing\RouterInterface;
use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
/**
- * Converts {@see \Exception} to a Hydra error representation.
+ * Con... | [ErrorNormalizer->[normalize->[generate,getTrace,getMessage]]] | Constructor for HydraError objects. Checks if the data is an exception. | Why removing this constant ? |
@@ -64,3 +64,9 @@ def make_executable(path):
chmod(path, S_IMODE(mode) | S_IXUSR | S_IXGRP | S_IXOTH)
else:
log.error("Cannot make path '%s' executable", path)
+
+
+def is_executable(path):
+ if isfile(path): # for now, leave out `and not islink(path)`
+ return path.endswith(('.exe', '... | [make_writable->[S_ISLNK,debug,getattr,chmod,S_ISREG,warn,S_IMODE,lchmod,S_ISDIR,lstat],make_executable->[error,trace,chmod,isfile,S_IMODE,lstat],recursive_make_writable->[walk,debug,isdir,exp_backoff_fn,from_iterable,join],getLogger] | Make a file executable if it doesn t already exist. | @mingwandroid Also slight modification to this function. It interacts with `_do_softlink()`. One thing I've learned for sure being bitten too many times by it... `os.access()` just doesn't work on Windows. |
@@ -11,8 +11,8 @@ function writeFiles() {
this.app = this.appConfigs[i];
this.template('_deployment.yml', `${appName}/${appName}-deployment.yml`);
this.template('_service.yml', `${appName}/${appName}-service.yml`);
-
- if (this.app.prodDatabaseType) {
+ ... | [No CFG could be retrieved] | Create a function to write the list of files to the console. | I think it might be better to & this with the original as we dont want to move the file when the property is undefined as well. @PierreBesson am I right or is there no way for this to be undefined? |
@@ -74,6 +74,10 @@ def build_wheels(
builder, # type: WheelBuilder
pep517_requirements, # type: List[InstallRequirement]
legacy_requirements, # type: List[InstallRequirement]
+ wheel_cache, # type: WheelCache
+ build_options, # type: List[str]
+ global_options, ... | [build_wheels->[is_wheel_installed],InstallCommand->[run->[build_wheels,get_check_binary_allowed]],site_packages_writable->[get_lib_location_guesses],decide_user_install->[site_packages_writable],warn_deprecated_install_options->[format_options]] | Build wheels for requirements depending on whether wheel is installed. | nit: type annotations aren't aligned anymore |
@@ -1436,9 +1436,11 @@ static int do_responder(OCSP_REQUEST **preq, BIO **pcbio, BIO *acbio,
*q = '\0';
/*
- * Skip "GET / HTTP..." requests often used by load-balancers
+ * Skip "GET / HTTP..." requests often used by load-balancers. Note:
+ * 'p' was incremented above to po... | [No CFG could be retrieved] | Reads the request line and returns the number of bytes read and returns 0 if no data was Reads the next NIO bio from the client and returns it. | I am a bit confused about the syntax parsing above. RFC 2616 says this: 5.1 Request-Line The Request-Line begins with a method token, followed by the Request-URI and the protocol version, and ending with CRLF. The elements are separated by SP characters. No CR or LF is allowed except in the final CRLF sequence. Request... |
@@ -64,12 +64,16 @@ class TextField(SequenceField[Dict[str, torch.Tensor]]):
def index(self, vocab: Vocabulary):
token_arrays: Dict[str, TokenList] = {}
indexer_name_to_indexed_token: Dict[str, List[str]] = {}
+ token_index_to_indexer_name: Dict[str, str] = {}
for indexer_name, in... | [TextField->[__str__->[sequence_length],count_vocab_items->[count_vocab_items],get_padding_lengths->[get_padding_lengths],empty_field->[TextField]]] | Index the field in the specified vocabulary. Get all keys which have been used for padding for each indexer and take the max if there. | There's a pylint warning for this line. |
@@ -260,12 +260,12 @@ public class FilePathUtils {
int level,
int expectLevel,
List<FileStatus> results) throws IOException {
- if (expectLevel == level && !isHiddenFile(fileStatus)) {
+ if (expectLevel == level && isHiddenFile(fileStatus)) {
results.add(fileStatus);
return;
... | [FilePathUtils->[searchPartKeyValueAndPaths->[extractPartitionKeyValues],listStatusRecursively->[listStatusRecursively],escapePathName->[needsEscaping],getFileStatusRecursively->[getFileStatusRecursively],getReadPaths->[getPartitions]]] | List the file status recursively. | why should we load hidden files? |
@@ -88,9 +88,12 @@ type StoreInfluence struct {
}
// ResourceSize returns delta size of leader/region by influence.
-func (s StoreInfluence) ResourceSize(kind core.ResourceKind) int64 {
+func (s StoreInfluence) ResourceSize(kind core.ResourceKind, EnableLeaderScheduleByCount bool) int64 {
switch kind {
case cor... | [Check->[IsFinish],IsTimeout->[IsFinish],Influence->[GetStoreInfluence],IsFinish->[String],MarshalJSON->[String],ConfVerChanged->[ConfVerChanged],TotalInfluence->[Influence],UnfinishedInfluence->[IsFinish,Influence],String->[IsFinish,String]] | ResourceSize returns the size of a resource in bytes. | Do we need to change the function name? BTW, I prefer not to pass a bool value to control the inner logic. |
@@ -29,8 +29,10 @@ class AoclSparse(CMakePackage):
values=('Debug', 'Release'))
variant('shared', default=True,
description='Build shared library')
+ variant('ilp64', default=False,
+ description='Build with ILP64 support')
- depends_on('boost')
+ depends_on('boost',... | [AoclSparse->[cmake->[basename,append,working_dir,extend,format,getmodule],build_directory->[join_path,mkdirp],check->[join_path,system,format],depends_on,conflicts,version,on_package_attributes,variant,run_after]] | Returns the directory where to build the package . | Again, does this dependency only apply to version `2.2`. |
@@ -491,6 +491,17 @@ class ArrayModel(StructModel):
return NotImplemented
+@register_default(types.NestedArray)
+class NestedArrayModel(ArrayModel):
+ def __init__(self, dmm, fe_type):
+ self._be_type = dmm.lookup(fe_type.dtype).get_data_type()
+ super(NestedArrayModel, self).__init__(dmm,... | [PrimitiveModel->[from_return->[from_data],from_argument->[from_data],as_return->[as_data],as_argument->[as_data]],DataModel->[get_return_type->[get_value_type],get_argument_type->[get_value_type],get_data_type->[get_value_type],__hash__->[_compared_fields],__eq__->[_compared_fields],__ne__->[__eq__]],StructModel->[get... | Initialize the optional model. | Intuitively, the data type of an array is an array of the element's data type, so I don't understand this one. Where is the data type necessary in this PR? |
@@ -58,7 +58,7 @@ top_htmlhead($head, $title, $disablejs, $disablehead, $arrayofjs, $arrayofcss);
$categorie = new Categorie($db);
$categories = $categorie->get_full_arbo('product');
?>
-var categories = JSON.parse( '<?php echo json_encode($categories);?>' );
+var categories = <?php echo json_encode($categories, JSO... | [trans,loadLangs,get_full_arbo,close] | Displays a list of categories. MoreCategories - This function is used to determine if there are more pages or if there are. | Note that there is an absctraction layer when json_encode is not available on php into json.lib.php with a if (! function_exists('json_encode')) ... And in this case, the second parameter is not supported, so your new code may fails. |
@@ -172,10 +172,14 @@ class MetricsTest(unittest.TestCase):
# Verify user distribution counter.
metric_results = res.metrics().query()
matcher = MetricResultMatcher(
- namespace='apache_beam.metrics.metric_test.SomeDoFn',
+ step='ApplyPardo',
+ namespace=hc.contains_string('SomeDoFn'... | [MetricsTest->[test_user_counter_using_pardo->[SomeDoFn]]] | Test that the user counter is using the Pardo DoFn. Tests that a node - level nanoseconds are in the counter and distribution. | Why is min different then the others? I would expect that the same reason this needs to be >= 0 would be the same reason as the others. |
@@ -45,6 +45,10 @@ class User < ApplicationRecord
acts_as_followable
acts_as_follower
+ has_many :source_authored_user_subscriptions, class_name: "UserSubscription", foreign_key: :author_id, inverse_of: :author, dependent: :destroy
+ has_many :subscribers, through: :source_authored_user_subscriptions, depende... | [User->[check_for_username_change->[path],send_welcome_notification->[send_welcome_notification],blocked_by?->[blocking?],auditable?->[any_admin?],blocking?->[blocking?],resave_articles->[path]]] | The editor version of the user is invalid. UserBlock has many relations. | The `UserSubscriptions` where the `User` is the `Author` of the source. |
@@ -0,0 +1,17 @@
+class DiscussionLock < ApplicationRecord
+ belongs_to :article
+ belongs_to :locking_user, class_name: "User"
+
+ before_validation :nullify_blank_notes_and_reason
+
+ validates :article_id, presence: true, uniqueness: true
+ validates :locking_user_id, presence: true
+
+ private
+
+ def nullif... | [No CFG could be retrieved] | No Summary Found. | What's the reason behind this choice? To be clear, I agree very much in principle with the idea of not having both `NULL` and empty strings. I just haven't noticed us using this particular idea elsewhere. |
@@ -2,9 +2,9 @@ using System;
using System.Runtime.InteropServices;
-#if MAC
+#if MONOMAC
using MonoMac.OpenGL;
-#elif OPENGL
+#elif WINDOWS || LINUX
using OpenTK.Graphics.OpenGL;
#endif
| [OcclusionQuery->[End->[EndQuery,SamplesPassed],Dispose->[DeleteQueries],Begin->[BeginQuery,SamplesPassed],QueryResultAvailable,graphicsDevice,GenQueries,GetQueryObjectiv,QueryResult]] | The OcclusionQuery class is used to provide a base class for all of the O. | Will this still compile for other OPENGL platforms such as Android? |
@@ -381,7 +381,7 @@ public abstract class Row implements Serializable {
this.schema = schema;
}
- public Builder addValue(Object values) {
+ public Builder addValue(@Nullable Object values) {
this.values.add(values);
return this;
}
| [Row->[getBytes->[getBytes,getValue],equals->[getValues,getSchema,equals],hashCode->[getValues,getSchema],getDouble->[getValue,getDouble],getByte->[getByte,getValue],getInt64->[getInt64,getValue],Builder->[verify->[getFieldCount,verify,equals],addArray->[addArray],verifyArray->[verify],verifyMap->[verify,getValue],buil... | Add the values. | I wonder if it would make sense to add an explicit `.addNullValue()` method instead |
@@ -456,7 +456,6 @@ public class Fork implements Closeable, Runnable, FinalState {
*/
private void commitData() throws IOException {
if (this.writer.isPresent()) {
- this.logger.info(String.format("Committing data of fork %d of task %s", this.index, this.taskId));
// Not to catch the exception t... | [Fork->[processRecords->[buildWriterIfNotPresent],commitData->[commit,updateByteMetrics],updateRecordMetrics->[updateRecordMetrics],close->[close],buildWriterIfNotPresent->[buildWriter],getFinalState->[getFinalState],updateByteMetrics->[updateByteMetrics]]] | Commits the data of the current fork. | Why this is gone? |
@@ -27,7 +27,8 @@ module CarrierWaveInitializer
provider: "AWS",
aws_access_key_id: ApplicationConfig["AWS_ID"],
aws_secret_access_key: ApplicationConfig["AWS_SECRET"],
- region: ApplicationConfig["AWS_UPLOAD_REGION"].presence || ApplicationConfig["AWS_DEFAULT_REGION"]
+ region:... | [standard_production_config->[fog_provider,storage,to_i,fog_credentials,fog_directory,fog_attributes,configure,presence],forem_cloud_config->[fog_provider,storage,asset_host,fog_credentials,fog_directory,configure,fog_public],local_storage_config->[storage,asset_host,test?,enable_processing,configure,production?],initi... | Provides a way to configure the configuration options for the production and forem configuration. | if you're adding new environment variables, setting this to a reasonable default in .env_sample is polite :) |
@@ -1486,10 +1486,12 @@ func (a *apiServer) parentJob(
if err != nil {
return nil, err
}
- if len(jobInfo.JobInfo) == 0 {
- return nil, nil
+ for _, jobInfo := range jobInfos.JobInfo {
+ if jobInfo.PipelineVersion == pipelineInfo.Version {
+ return jobInfo.Job, nil
+ }
}
- return jobInfo.JobInfo[0].Job, n... | [AddShard->[newPipelineCtx,cancelPipeline],runPipeline->[CreateJob],parentJob->[ListJob],DeleteAll->[DeleteAll],StartJob->[InspectJob,StartJob],deletePipeline->[jobPods,getPersistClient],GetLogs->[GetLogs],InspectJob->[InspectJob]] | parentJob returns the parent job of the given input. | Does it make sense to have this filtering be part of the `ListJobRequest` so that it can be done efficiently on the server? |
@@ -1073,7 +1073,7 @@ static int dw_dma_get_data_size(struct dma_chan_data *channel,
tr_dbg(&dwdma_tr, "dw_dma_get_data_size(): dma %d channel %d get data size",
channel->dma->plat_data.id, channel->index);
- irq_local_disable(flags);
+ spin_lock_irq(&channel->dma->lock, flags);
if (channel->direction ... | [int->[dw_dma_interrupt_status,DW_DSR,dw_dma_interrupt_mask,atomic_init,ARRAY_SIZE,dw_dma_stop,DW_FIFO_CHy,DW_CFG_HIGH,platform_dw_dma_set_transfer_size,dw_dma_start,DW_CFG_LOW,dw_dma_avail_data_size,DW_FIFO_CHx,dcache_writeback_region,notifier_event,DW_DMA_LLI_ADDRESS,rfree,bzero,dma_base,irq_local_enable,dw_dma_verif... | This method returns the size of the data in the specified channel. | are we allowed to take a spinlock while writing a trace in dw_dma_avail_data_size() and dw_dma_free_data_size() |
@@ -714,6 +714,7 @@ csum_test_holes(void **state)
read_csum.cs_nr = daos_recx_calc_chunks(extent, 1, chunk_size);
read_csum.cs_buf_len = read_csum.cs_len * read_csum.cs_nr;
read_csum.cs_csum = csum_read_buf;
+ read_csum.cs_type = 1;
read_from_extent(&extent_key, &extent,
| [No CFG could be retrieved] | Reads an array of 16 - bit unsigned integers from the object s extent. 64K - 16K. | please don't use number directly, please use the defined enum |
@@ -176,9 +176,8 @@ class _RemotesRegistry(_Registry):
self._add_update(remote_name, url, verify_ssl, exists_function, insert)
def rename(self, remote_name, new_remote_name):
- self._remotes = None # invalidate cached remotes
with fasteners.InterProcessLock(self._lockfile, logger=logger... | [RemoteRegistry->[remotes->[_RemotesRegistry],refs->[_ReferencesRegistry]],_ReferencesRegistry->[update->[_save,_load],set->[_save,_load],get->[get,_load],remove->[_save,_load],list->[_load]],_RemotesRegistry->[define->[_save,_load],_add_update->[exists_function,list,_save,_load],remove->[_save,_load],_upsert->[_save,_... | Rename a remote. | (Not related to this PR, but) what if ``new_remote_name`` already exists? |
@@ -116,6 +116,14 @@ public class AetherClassPathClassifier implements ClassPathClassifier {
this.dependencyResolver = dependencyResolver;
this.artifactClassificationTypeResolver = artifactClassificationTypeResolver;
+
+ try {
+ Properties properties = new Properties();
+ properties.load(Aether... | [AetherClassPathClassifier->[discoverDependency->[findDirectDependency]]] | Creates a class loader that uses the dependencies and the application class loaders to define how the container. | Extract to an utility method |
@@ -176,7 +176,7 @@ public class HiveMetaStoreBasedRegister extends HiveRegister {
* Or will create the table thru. RPC and return retVal from remote MetaStore.
*/
private boolean ensureHiveTableExistenceBeforeAlternation(String tableName, String dbName, IMetaStoreClient client,
- Table table, HiveSpec ... | [HiveMetaStoreBasedRegister->[createOrAlterTable->[call->[ensureHiveTableExistenceBeforeAlternation],ensureHiveTableExistenceBeforeAlternation],getPartitionWithCreateTime->[getPartitionWithCreateTime],addOrAlterPartition->[addOrAlterPartition],createTableIfNotExists->[createTableIfNotExists],getPartition->[getPartition... | This method is used to ensure that the table exists in the database before the alternative. | Isn't this lock a JVM-local lock? Won't we need Hive Metastore side locking to serialize updates? |
@@ -52,6 +52,17 @@ from raiden.transfer.utils import hash_balance_data
log = structlog.get_logger(__name__) # pylint: disable=invalid-name
+ParticipantDetails = Dict[
+ str,
+ typing.Union[
+ typing.TokenAmount,
+ typing.TokenAmount,
+ bool,
+ typing.BalanceHash,
+ int,
+ ... | [TokenNetwork->[settle_block_number->[detail_channel],channel_is_closed->[detail_channel],all_events_filter->[events_filter],update_transfer->[channel_is_closed],channel_is_settled->[detail_channel],_check_for_outdated_channel->[detail_channel],close->[channel_is_opened],channel_is_opened->[detail_channel],detail_parti... | Initializes the object with the given base key. | Shouldn't this kind of type-alias be in `raiden.utils.typing`? |
@@ -53,14 +53,13 @@ namespace System.Threading
return true;
}
- private static void Run()
+ private static int PumpTimerQueue() // NOTE: this method is called via reflection by test code
{
- int shortestWaitDurationMs;
List<TimerQueue> timersToFire ... | [TimerQueue->[SetTimer->[SetTimeout],Run->[SetTimeout]]] | Method to set the next timer in the scheduled timers. | This might need linker exclusions. |
@@ -897,6 +897,11 @@ public class DruidQuery
return null;
}
+ if (sorting != null && sorting.getOffsetLimit().hasLimit() && sorting.getOffsetLimit().getLimit() <= 0) {
+ // Cannot handle zero or negative limits.
+ return null;
+ }
+
final Filtration filtration = Filtration.create(filt... | [DruidQuery->[toTopNQuery->[getDimFilter,getVirtualColumns],getVirtualColumns->[getVirtualColumns],toTimeseriesQuery->[getDimFilter,getVirtualColumns],fromPartialQuery->[DruidQuery],computeGrouping->[computeHavingFilter],toGroupByQuery->[getDimFilter,getVirtualColumns],toScanQuery->[getDimFilter,getVirtualColumns]]] | To group by query. | can limit be less than 0 here because of the preconditions in `OffsetLimit`? |
@@ -274,8 +274,7 @@ void ParticleSpawner::step(float dtime, ClientEnvironment* env)
// particle if it is attached to an unloaded
// object.
if (!unloaded) {
- v3f pos = random_v3f(m_minpos, m_maxpos)
- + attached_offset;
+ v3f pos = random_v3f(m_minpos, m_maxpos);
v3f vel = random_v3f... | [updateVertices->[intToFloat,addInternalPoint,m_vertices,getPitch,getPosition,getCameraOffset,getYaw,atan2],step->[updateVertices,collisionMoveSimple,rand,addParticle,random_v3f,getActiveObject,getPosition,end,begin,updateLight,erase,v2f,v3f,stepSpawners,stepParticles],addParticle->[push_back],render->[getVideoDriver,s... | Spawns a particle at a random time. This function randomizes a set of objects that are part of a particle system. toadd - > toadd - > toadd - > toadd - > toadd. | I would prefer that the pos += attached_offset line was deleted instead, since that would make this branch consistent with the other one. Not a big deal though. |
@@ -328,7 +328,6 @@ final class UnitChooser extends JPanel {
private static final class ChooserEntry {
private final UnitCategory category;
private final ScrollableTextFieldListener hitTextFieldListener;
- private final GameData gameData;
private final boolean hasMultipleHits;
private final Li... | [UnitChooser->[selectNone->[selectNone],ChooserEntry->[size->[size],getFinalHit->[getHits],updateLeftToSelect->[setMax,getMax],getMax->[getMax],selectAll->[getMax],UnitChooserEntryIcon->[getWidth->[size],paint->[paint],getDimension->[getWidth,getHeight]]],getSelected->[getSelected],changedValue->[updateLeft,checkMatche... | Gets the selected damaged multiple hit point units. Replies the set of possible units. | This field was no longer used after removing the `GameData` parameter from the constructor. |
@@ -40,12 +40,12 @@ function ref_session_write ($id,$data) {
if($session_exists) {
$r = q("UPDATE `session`
SET `data` = '%s'
- WHERE `data` != '%s' AND `sid` = '%s'",
+ WHERE `sid` = '%s' AND `data` != '%s'",
dbesc($data), dbesc($data), dbesc($id));
$r = q("UPDATE `session`
SET `expire` ... | [No CFG could be retrieved] | write a record to the session. | Shouldn't it rather be `dbesc($data), dbesc($id), dbesc($data));` because you have changed the order of `sid` and `data` in the line above? |
@@ -74,14 +74,12 @@ pid: {pid}
def log_exception(cls, msg):
try:
pid = os.getpid()
- fatal_error_log_entry = cls._format_exception_message(msg, pid)
+ fatal_error_log_entry = cls._format_exception_message(msg, pid).encode('utf-8')
# We care more about this log than the shared log, so com... | [ExceptionSink->[log_exception->[_format_exception_message,_exceptions_log_path],_format_exception_message->[_iso_timestamp_for_now],set_destination->[ExceptionSinkError],_exceptions_log_path->[get_destination]]] | Log an exception to the exceptions log. | I don't think this will work on Py3. You're encoding it to bytes, but then writing in Unicode mode. The two must be consistent |
@@ -55,9 +55,16 @@ public class JobStateToJsonConverter {
private final StateStore<? extends JobState> jobStateStore;
private final boolean keepConfig;
- public JobStateToJsonConverter(String storeUrl, boolean keepConfig)
+ public JobStateToJsonConverter(Properties props, String storeUrl, boolean keepConfig)
... | [JobStateToJsonConverter->[main->[JobStateToJsonConverter,convertAll,convert],writeJobStates->[writeJobState],convert->[convert]]] | This class is used to convert a single job instance to a json - formatted document. Get the most recent job state of the given job. | You can use `JobConfigurationUtils.putPropertiesIntoConfiguration` for this. |
@@ -125,6 +125,18 @@ class Adios(Package):
sh = which('sh')
sh('./autogen.sh')
+ if self.get_arch() == 'ppc64le':
+ # update the config.sub/guess files
+ with working_dir("config"):
+ # get new config.guess and config.sub files
+ print 'Back... | [Adios->[install->[append,sh,validate,configure,which,make],validate->[RuntimeError],variant,depends_on,version,patch]] | Installs a new in the system. | You should be able to simplify this to `if 'target=ppc64le' in spec` and remove the `get_arch()` method |
@@ -71,6 +71,9 @@ export class ConsentStateManager {
/** @private {!Promise} */
this.hasAllPurposeConsentsPromise_ = allPurposeConsentsDeferred.promise;
+
+ /** @public {?string} */
+ this.consentPageViewID64 = once(() => getRandomString64(this.ampdoc_.win));
}
/**
| [ConsentInstance->[constructor->[assertHttpsUrl,storageForTopLevelDoc],get->[resolve,dev,constructConsentInfo,hasDirtyBit,get,remove,UNKNOWN,getStoredConsentInfo],update->[hasDirtyBit,constructConsentInfo,DISMISSED,recalculateConsentStateValue,isConsentInfoStoredValueSame],setDirtyBit->[hasDirtyBit],updateStoredValue_-... | A sequence of objects that represent a single node - level object. | 1. Don't need `once`. 2. consentPageViewId64 (lowercase `d`) |
@@ -116,7 +116,7 @@ namespace CoreNodeModels.Input
/// <returns></returns>
public override string ToString()
{
- return string.Format("Color(Alpha = {3}, Red = {0}, Green = {1}, Blue = {2})", dsColor.Alpha, dsColor.Red, dsColor.Green, dsColor.Blue);
+ return string.Forma... | [ColorPalette->[SerializeCore->[SerializeValue,SerializeCore],DeserializeCore->[DeserializeCore]]] | Get the string representation of the . | this looks wrong to me - seems these are in the wrong order, the numbers should be 0,1,2,3. |
@@ -1,6 +1,6 @@
module FeatureFlag
class << self
- delegate :disable, :enable, :enabled?, :exist?, to: Flipper
+ delegate :disable, :enable, :enabled?, :exist?, :remove, to: Flipper
def accessible?(feature_flag_name, *args)
feature_flag_name.blank? || !exist?(feature_flag_name) || enabled?(featu... | [accessible?->[enabled?,blank?,exist?],delegate] | Check if a feature flag is accessible. | need `:remove` for the new data update script. We should also make a habit of adding/removing and controlling feature flags programmatically and not via the web UI if possible, to ensure all Forems are aligned |
@@ -48,6 +48,12 @@ class AccountError(Error):
code = AccountErrorCode(description="The error code.", required=True)
+class BulkAccountError(AccountError):
+ index = graphene.Int(
+ description="Index of an input list item that caused the error."
+ )
+
+
class CheckoutError(Error):
code = Che... | [WishlistError->[WishlistErrorCode],PermissionDisplay->[PermissionEnum,String],IntRangeInput->[Int],LanguageDisplay->[LanguageCodeEnum,String],ExtensionsError->[ExtensionsErrorCode],StockError->[StockErrorCode],SeoInput->[String],Weight->[String,Float],TaxType->[String],ShippingError->[ShippingErrorCode],Error->[String... | Creates a custom error message for the given error code. Thrown when a page or payment error occurs. | Maybe we could just add the `index: Int` to the `AccountError` type? It would be nullable so it wouldn't affect mutations that currently use `AccountError` type. I think in the future we would like to even extend the base `Error` type with the `index` field as it may be useful in many other mutations to return an index... |
@@ -16,7 +16,7 @@ namespace NServiceBus.Testing
{
return repliedMessages
.Where(x => x.Message is TMessage)
- .Select(x => new RepliedMessage<TMessage>((TMessage)x.Message, x.Options));
+ .Select(x => new RepliedMessage<TMessage>((TMessage) x.Message,... | [OutgoingMessageExtensions->[TMessage->[Message],Containing->[Select,Message,Within,Options]]] | This method returns the containing of the given RepliedMessages. | I have to say I really hate this style convention of having a space here. Would anyone be opposed to changing this? |
@@ -181,3 +181,15 @@ class WIDERFace(VisionDataset):
download_and_extract_archive(url=self.ANNOTATIONS_FILE[0],
download_root=self.root,
md5=self.ANNOTATIONS_FILE[1])
+
+
+def check_integrity(self) -> bool:
+ # Allow original archiv... | [WIDERFace->[parse_test_annotations_file->[abspath,readlines,rstrip,append,expanduser,join,open],download->[print,_check_integrity,join,download_file_from_google_drive,download_and_extract_archive,extract_archive],_check_integrity->[splitext,append,copy,join,exists],__len__->[len],parse_train_val_annotations_file->[rea... | Download all files from Google drive and extract them. | That's not great, but for now `DatasetTestCase` cannot patch the `_check_integrity` method, so I had to move it as a function. What would you recommend here @pmeier? I would tend towards updating `DatasetTestCase._patch_checks()` instead, as it's a bit unfortunate to have to change some code here just so that it's comp... |
@@ -120,6 +120,8 @@ def patch_freqtradebot(mocker, config) -> None:
patch_exchange(mocker)
mocker.patch('freqtrade.freqtradebot.RPCManager._init', MagicMock())
mocker.patch('freqtrade.freqtradebot.RPCManager.send_msg', MagicMock())
+ mocker.patch('freqtrade.freqtradebot.FreqtradeBot._refresh_whitelist... | [get_patched_freqtradebot->[patch_freqtradebot],patch_freqtradebot->[patch_exchange],get_patched_worker->[patch_freqtradebot],get_patched_edge->[patch_edge],get_patched_exchange->[patch_exchange]] | Patches the FreqtradeBot to use the same API as the FreqtradeBot. | `patch_whitelist()` can be called here instead (as `patch_exchange()` is called couple of lines above) |
@@ -240,7 +240,7 @@ define([
var readOnlyAttributes;
if (defined(this.geometryInstances) && isArray(this.geometryInstances) && this.geometryInstances.length > 1) {
- readOnlyAttributes = readOnlyInstanceAttributesScratch;
+ readOnlyAttributes = ['color'];
}
... | [No CFG could be retrieved] | Constructor for GroundPrimitive. Cache optimized for the pre - vertex - shader caches. | Are you sure you want to remove the scratch? These are used for performance (and maybe memory usage here). I'm not sure how important this case is. Ask @bagnell. |
@@ -22,11 +22,16 @@ import weakref
import re
import warnings
import collections
+from distutils.version import StrictVersion
try:
# import openpyxl
import openpyxl
- from openpyxl.cell import get_column_letter
+ if StrictVersion(openpyxl.__version__) >= StrictVersion('2.4.0'):
+ # openpyxl ... | [importConditions->[indicesFromString,_assertValidVarNames],QuestHandler->[mode->[mode],simulate->[mean,mode,simulate,quantile],_checkFinished->[confInterval],importData->[next,addResponse],next->[_terminate],__init__->[getOriginPathAndFile,__init__],mean->[mean],addResponse->[calculateNextIntensity,getExp],confInterva... | A container class for keeping track of multiple bad var names in a single experiment. A function to save the specific version of an object in a file. | I like this explicit approach, makes it very clear what's going on and why. |
@@ -13,5 +13,7 @@
if (empty($os)) {
if (strstr($sysDescr, 'Cisco FX-OS')) {
$os = 'fxos';
+ } elseif (preg_match('/[0-9.]+sf.(virtual|cisco)-[0-9]+/', $sysDescr)) {
+ $os = 'fxos';
}
}
| [No CFG could be retrieved] | find the ethernet address. | this shouldn't be already in the new refactored way? |
@@ -11,14 +11,6 @@
#include "client_internal.h"
#include "task_internal.h"
-int
-daos_obj_register_class(daos_handle_t coh, daos_oclass_id_t cid,
- struct daos_oclass_attr *cattr, daos_event_t *ev)
-{
- D_ERROR("Unsupported API\n");
- return -DER_NOSYS;
-}
-
int
daos_obj_query_class(daos_handle_t coh, daos_ocla... | [daos_obj_verify->[daos_obj_open,daos_obj_close],daos_obj_layout_get->[daos_obj_open,daos_obj_close]] | if obj_register_class or obj_query_class are not supported by DOS. | this function might still be required in the future, e.g. someone wants to register something like EC(8+4) |
@@ -90,8 +90,10 @@ func (rules *ClientConfigLoadingRules) Load() (*clientcmdapi.Config, error) {
if err := mergeConfigWithFile(mapConfig, file); err != nil {
errlist = append(errlist, err)
}
- if err := ResolveLocalPaths(file, mapConfig); err != nil {
- errlist = append(errlist, err)
+ if !rules.DoNotReso... | [Load->[IsNotExist,Stat,NewAggregate,Errorf,Merge,NewConfig],IsNotExist,Dir,Join,ReadFile,JSONToYAML,DecodeInto,Errorf,Merge,NewConfig,Abs,Encode,Getenv,WriteFile,IsAbs] | Load loads the config from the specified files. | If you really want to keep the `DoNotResolvePaths` name I'd suggest a `ResolvePaths()` method for clarity. |
@@ -321,8 +321,8 @@ dfuse_cb_lookup(fuse_req_t req, struct dfuse_inode_entry *parent,
rc = dfs_lookup_rel(parent->ie_dfs->dfs_ns, parent->ie_obj, name,
O_RDONLY, &ie->ie_obj, NULL, &ie->ie_stat);
if (rc) {
- DFUSE_TRA_DEBUG(parent, "dfs_lookup() failed: (%s)",
- strerror(rc));
+ DFUSE_TRA_DEBUG(parent,... | [No CFG could be retrieved] | region FUSE INODE METHODS check_for_uns_ep - check for UnsEndpoint and reply - entry. | This one is wrong, dfs is supposed to return system error numbers. The edit to fetch_entry() in dfs.c will resolve this warning. |
@@ -29,7 +29,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
KC_EXLM, KC_AT, KC_UP, KC_LCBR, KC_RCBR, KC_PGUP, KC_7, KC_8, KC_9, KC_ASTR ,
KC_HASH, KC_LEFT, KC_DOWN, KC_RGHT, KC_DLR, KC_PGDN, KC_4, KC_5, KC_6, KC_PLUS ,
KC_LBRC, KC_RB... | [No CFG could be retrieved] | The keymaps for the layer names are defined in the section of the page. Macro for the layout of the nation Get the macro associated with a key record. | This change should be reverted. |
@@ -109,7 +109,7 @@ namespace Dynamo.PackageManager
public PackageManagerClient(DynamoModel dynamoModel)
{
this.dynamoModel = dynamoModel;
- Client = new Client(null, "http://www.dynamopackages.com");
+ Client = new Client(null, "http://107.20.146.184/");
... | [PackageManagerClient->[PackageUploadHandle->[OnRequestAuthentication],PackageManagerResult->[OnRequestAuthentication],Downvote->[OnRequestAuthentication],Upvote->[OnRequestAuthentication],OnRequestAuthentication]] | Provides a client for the Package Manager. Upvote and Downvote methods. | In general using domain lookup is a better idea. And it needs to be over SSL |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.