patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -48,7 +48,7 @@ func ParseStorageError(err error, v interface{}, noun string) error {
case storage.ErrCannotDelete:
return status.Errorf(codes.FailedPrecondition, "cannot delete server %q because it still has organizations attached", reflect.Indirect(reflect.ValueOf(v)).FieldByName("Id"))
case storage.ErrCo... | [Error,New,ValueOf,FieldByName,Errorf,Indirect] | ParseStorageError parses a storage error into a status. Error. If err is nil it. | Wondering why you need all the reflection on these? Is that used to make this more generic? |
@@ -1287,11 +1287,11 @@ d_tm_print_stats(FILE *stream, struct d_tm_stats_t *stats, int format)
return;
}
- fprintf(stream, ", min: %lu, max: %lu, mean: %lf, sample size: %lu",
- stats->dtm_min, stats->dtm_max, stats->mean,
- stats->sample_size);
+ fprintf(stream, " [min: %lu, max: %lu, avg: %.0lf",
+ stats->d... | [No CFG could be retrieved] | Prints the given node statistics to the given stream. Print the children of a node. | I assume that those changes are way the unit tests are failing. @kjacque, would you mind having a look? I checked the unit tests and couldn't find anything obvious. I am ok to revert those changes too if they don't make sense to you. |
@@ -183,6 +183,8 @@ class GlobalOptionsRegistrar(SubsystemClientMixin, Optionable):
register('--subproject-roots', type=list, advanced=True, fromfile=True, default=[],
help='Paths that correspond with build roots for any subproject that this '
'project depends on.')
+ register('... | [GlobalOptionsRegistrar->[register_options->[register_bootstrap_options]]] | Register bootstrap options. Find all packages that are available in the system. A sequence number that can be used to identify a specific configuration file. Register options for a given . Options for Visualizing and Visualizing binary tools. | This should mention the existence of the `--changed` options, and the fact that the three types are exclusive. |
@@ -113,10 +113,9 @@ func construct(ctx context.Context, req *pulumirpc.ConstructRequest, engineConn
return nil, err
}
- // Ensure all outstanding RPCs have completed before proceeding. Also, prevent any new RPCs from happening.
- pulumiCtx.waitForRPCs()
- if pulumiCtx.rpcError != nil {
- return nil, errors.Wra... | [LastIndex,GetInputDependencies,GetProject,GetParallel,ElementType,ValueOf,GetConfig,Slice,Wrap,Set,GetAliases,GetProviders,GetParent,ToURNOutput,GetDryRun,Field,MethodByName,GetUrns,New,GetProtect,GetName,Errorf,GetInputs,NumIn,Type,GetDependencies,GetStack,GetType,Wrapf,getState,UnmarshalProperties,Interface,TypeOf,G... | finds all provider resources that are referenced by the given request. rpcPropertyDeps converts the property dependencies map for the RPC and remove duplicates. | Why should we wait for (presumably locally initiated) work to finish before returning from construct? There might be interesting work waiting to be scheduled until construct returns, that might have an opportunity to start in parallel if we do not wait here. If we had reliable cross-node callbacks, would the intent her... |
@@ -80,7 +80,7 @@ function redir_init(App $a) {
}
// Doing remote auth with dfrn.
- if (local_user() && (!empty($contact['dfrn-id']) || !empty($contact['issued-id']))) {
+ if (local_user() && (!empty($contact['dfrn-id']) || !empty($contact['issued-id'])) && empty($contact['pending'])) {
$dfrn_id = $orig_i... | [No CFG could be retrieved] | This function is called when the user is connected to a new contact. Check if a contact is already authenticated This function is used to check if a contact is a connected contact. Check if contact is found. | Why the check for "empty"? |
@@ -47,8 +47,13 @@ class SvnDownloader extends VcsDownloader
throw new \RuntimeException('The .svn directory is missing from '.$path.', see http://getcomposer.org/commit-deps for more information');
}
+ $ignoreAncestryCommand = "";
+ if ((int)$this->process->execute("svn --version ... | [SvnDownloader->[getCommitLogs->[execute],execute->[execute],cleanChanges->[getLocalChanges],discardChanges->[execute]]] | Update a package in the current repository. | Will not work on windows? |
@@ -125,7 +125,7 @@ namespace System.Text.Json
/// <summary>
/// The path within the JSON where the exception was encountered.
/// </summary>
- public string Path { get; internal set; }
+ public string Path { get; internal set; } = string.Empty;
/// <summary>
... | [JsonException->[GetObjectData->[AddValue,GetObjectData],SetMessage,GetString,GetValue]] | - Gets the message that describes the current exception. | Did we consider making `Path` nullable? |
@@ -66,8 +66,16 @@ public class BatchComponents {
HtmlReport.class,
IssuesReportBuilder.class,
SourceProvider.class,
- RuleNameProvider.class
- );
+ RuleNameProvider.class,
+
+ // Tasks
+ Tasks.class,
+ ListTask.DEFINITION,
+ ListTask.class,
+ ScanTask.DEFINI... | [BatchComponents->[all->[all,newArrayList,get,addAll]]] | This method returns all components in the system. | This seems dangerous (what if I forget to put the definition?). Wouldn't it be possible to have Tasks exposing their definitions? |
@@ -20,7 +20,7 @@ def details(request):
@login_required
def orders(request):
- ctx = {'orders': request.user.orders.all()}
+ ctx = {'orders': request.user.orders.prefetch_related('groups')}
return TemplateResponse(request, "userprofile/orders.html", ctx)
| [address_edit->[validate_address_and_render],address_create->[validate_address_and_render]] | Show a list of orders. | I think `prefetch_related` on order groups is common action related to fetching the order from the database. As such it should be performed in `objects` or `objects_prefetched` manager. The sad part is reverse lookup doesn't work with custom managers. |
@@ -44,6 +44,12 @@ log = getLogger(__name__)
CONFIG_PATH = '/etc/pulp/consumer/consumer.conf'
+DISTRIBUTOR_PLUGIN_MISSING = _('\nA distributor of type [%(t)s] is referenced in a repository '
+ 'binding but is not installed and loaded. It must be installed '
+ ... | [ChildPulpBindings->[__init__->[__init__]],ChildImporter->[delete->[delete],merge->[update],update->[update]],ChildDistributor->[delete->[delete],merge->[update],update->[update]],ParentBinding->[fetch->[ConsumerSSLCredentialsBundle,ModelError],fetch_all->[ConsumerSSLCredentialsBundle,ModelError]],ChildRepository->[mer... | Get a subset dictionary. | Awkward to put in line breaks here. It's typically better to let the end client decide how it wants to display things rather than the backend making those decisions for it. |
@@ -417,14 +417,16 @@ namespace System.Linq.Expressions.Interpreter
}
[UnconditionalSuppressMessage("ReflectionAnalysis", "IL2077:UnrecognizedReflectionPattern",
- Justification = "_type is a ValueType. You can always create an instance of a ValueType.")]
+ Just... | [InitializeLocalInstruction->[Parameter->[BoxIfIndexMatches->[ParameterBox]]]] | if _type is a ValueType create an instance of it. | This pattern is repeated, did you consider adding a helper? |
@@ -903,12 +903,12 @@ uint8_t get_clsag_fork()
return HF_VERSION_CLSAG;
}
-uint64_t calculate_fee(bool use_per_byte_fee, const cryptonote::transaction &tx, size_t blob_size, uint64_t base_fee, uint64_t fee_multiplier, uint64_t fee_quantization_mask)
+uint64_t calculate_fee(bool use_per_byte_fee, const cryptonote:... | [No CFG could be retrieved] | Estimate the size of a transaction. This function decrypts the payment id from the pending tx. | If this function doesn't have any forward declaration, should it be `static`? |
@@ -126,7 +126,6 @@ def _create_allocations(
return insufficient_stock, []
-@traced_atomic_transaction()
def deallocate_stock(order_lines_data: Iterable["OrderLineData"]):
"""Deallocate stocks for given `order_lines`.
| [increase_allocations->[allocate_stocks],decrease_stock->[deallocate_stock],increase_stock->[increase_stock]] | Deallocate stocks for given order_lines. | Do we remove it because it's always called in a transaction? |
@@ -35,7 +35,7 @@ const NetworkSettings = () => {
chevron
/>
)}
- {!isDesktop && <BlueListItem title={loc.settings.tor_settings} onPress={navigateToTorSettings} testID="TorSettings" chevron />}
+ {isTorCapable && <BlueListItem title={loc.settings.tor_settings} onPress={nav... | [No CFG could be retrieved] | Displays a list of all notifications that can be capable. | i have a feeling that might crash with cryptic "cant render text outside of <Text> tag" |
@@ -37,10 +37,11 @@ class PrintItem(AbstractTemplate):
@infer_global(abs)
class Abs(ConcreteTemplate):
int_cases = [signature(ty, ty) for ty in sorted(types.signed_domain)]
+ uint_cases = [signature(ty, ty) for ty in sorted(types.unsigned_domain)]
real_cases = [signature(ty, ty) for ty in sorted(types.re... | [SetItemCPointer->[generic->[normalize_1d_index]],MinMaxBase->[generic->[_unify_minmax]],UnaryOp->[choose_result_int],typeof_index->[IndexValueType],GetItemCPointer->[generic->[normalize_1d_index]],BitwiseInvert->[choose_result_int],IndexValueModel->[__init__->[__init__]],choose_result_int->[choose_result_bitwidth],typ... | A template class for printing a single object. Enumerate all possible range types. | This change should be tested? |
@@ -204,11 +204,13 @@ public class ExternalSpillableMap<T extends Serializable, R extends Serializable
public R put(T key, R value) {
if (this.currentInMemoryMapSize < maxInMemorySizeInBytes || inMemoryMap.containsKey(key)) {
if (shouldEstimatePayloadSize && estimatedPayloadSize == 0) {
- // At fi... | [ExternalSpillableMap->[valueStream->[valueStream],size->[size],inDiskContainsKey->[containsKey],inMemoryContainsKey->[containsKey],containsValue->[containsValue],keySet->[keySet],putAll->[put],entrySet->[entrySet],values->[values,isEmpty],IteratorWrapper->[next->[next,hasNext],hasNext->[hasNext]],containsKey->[contain... | This method is called by the put method of the object. It is called by the put. | wondering how come we did not hit this issue so far. |
@@ -1913,4 +1913,8 @@ module.exports = class Exchange {
throw new NotSupported (this.id + ' ' + key + ' does not have a value in mapping')
}
}
+
+ isContract (type) {
+ return type === 'swap' || type === 'futures' || type === 'future' || type === 'delivery' || type === 'option';
+ ... | [No CFG could be retrieved] | throw an exception if the key does not have a value in the mapping. | We will need to port this to exchange.py and Exchange.php, cause base classes are not transpiled. Also, JFYI, In Py and PHP we use the snake_case notation. |
@@ -1,10 +1,10 @@
# coding: utf-8
-#-------------------------------------------------------------------------
+# -------------------------------------------------------------------------
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project roo... | [TestAzureAttestationToken->[test_create_secured_empty_token->[AttestationToken,_create_x509_certificate,_create_rsa_key,AttestationSigningKey,get_body,validate_token],test_token_expiration->[time,AttestationToken,TokenValidationOptions,raises,validate_token],test_create_unsecured_token->[AttestationToken,get_body],tes... | Creates a new object with the given name. Test for ECDS signing key creation. | nit: I don't think you need the `is False` portion here. You're not doing an assert, and the exception is raised on the `_validate_token()` method |
@@ -80,6 +80,8 @@ public abstract class AbstractMethodAnnotationPostProcessor<T extends Annotation
protected final Class<T> annotationType;
+ protected String inputChannelAttribute;
+
@SuppressWarnings("unchecked")
public AbstractMethodAnnotationPostProcessor(ListableBeanFactory beanFactory, Environment envir... | [AbstractMethodAnnotationPostProcessor->[generateHandlerBeanName->[containsBean,getShortNameAsProperty,getName],createEndpoint->[hasText,PollingConsumer,state,resolveAttribute,DirectChannel,EventDrivenConsumer,notNull,configurePollingEndpoint,registerSingleton,initializeBean,isEmpty,resolveDestination],configurePolling... | Creates a base class for Method - level annotation post - processors. This method is used to implement the abstract interface. | I prefer `getInputChannelAttribute()` rather than the subclass updating this protected field. |
@@ -0,0 +1,14 @@
+import sys
+
+if sys.version_info < (3,):
+ def _str(value):
+ if isinstance(value, unicode): # pylint: disable=undefined-variable
+ return value.encode('utf-8')
+
+ return str(value)
+else:
+ _str = str
+
+
+def _to_utc_datetime(value):
+ return value.strftime('%Y-%... | [No CFG could be retrieved] | No Summary Found. | Missing license header |
@@ -25,7 +25,7 @@ public class MetadataImplicitDynamicConfigurationTestCase extends MetadataExtens
@Test
public void resolveMetadataWithImplicitDynamicConfig() throws Exception {
- componentId = new ProcessorId(CONTENT_METADATA_WITH_KEY_ID, FIRST_PROCESSOR_INDEX);
+ location = builder().globalName(CONTENT... | [MetadataImplicitDynamicConfigurationTestCase->[resolveMetadataWithImplicitDynamicConfig->[assertFailureResult,ProcessorId,getName,getComponentDynamicMetadata,get,assertMetadataFailure]]] | Resolves metadata with implicit dynamic configuration. | Remover the constant if no longer used |
@@ -36,8 +36,8 @@ func (a *Application) externalProcess(proc *os.Process) {
}
func isWindowsProcessExited(pid int) bool {
- const desiredAccess = syscall.STANDARD_RIGHTS_READ | syscall.PROCESS_QUERY_INFORMATION | syscall.SYNCHRONIZE
- h, err := syscall.OpenProcess(desiredAccess, false, uint32(pid))
+ const desired_... | [externalProcess->[After],GetExitCodeProcess,OpenProcess] | isWindowsProcessExited returns true if the process has an exit code that is still active. | don't use underscores in Go names; const desired_access should be desiredAccess |
@@ -1026,7 +1026,11 @@ describe Assignment do
result = s.get_latest_result
result.total_mark = total_mark
result.marking_state = Result::MARKING_STATES[:complete]
- result.save
+ @assignment.rubric_criteria.each do |cri|
+ result.marks.create!(markable_id: c... | [minute,create,let,is_greater_than_or_equal_to,accepted_grouping_for,have_many,through,it,to,get_current_assignment,update_results_stats,each,marking_state,context,reload,and_return,be,to_not,match_array,to_csv,where,map,today,drop,groupings,get_latest_result,due_date,id,not_to,save,new,add_csv_group,ago,get_total_extr... | Creates a list of sections and assignments that are past due dates. where both are past due dates. | Extra empty line detected at block body end. |
@@ -111,8 +111,13 @@ class JustSpacesWordSplitter(WordSplitter):
tokens does not matter. This will never result in spaces being included as tokens.
"""
@overrides
- def split_words(self, sentence: str) -> Tuple[List[str], List[Tuple[int, int]]]:
- return sentence.split(), None
+ def split_w... | [JustSpacesWordSplitter->[split_words->[split]],NltkWordSplitter->[split_words->[lower,word_tokenize]],WordSplitter->[from_params->[by_name,assert_empty,list_available,pop_choice]],SimpleWordSplitter->[split_words->[split,append,insert,extend,len,_can_split,lower],_can_split->[lower],__init__->[replace,set]],SpacyWordS... | Splits a sentence into words and returns the first word and the last word. | another place to consider a list comprehension |
@@ -4,4 +4,4 @@
# license information.
# --------------------------------------------------------------------------
-VERSION = "12.1.3"
+VERSION = "12.2.0b1"
| [No CFG could be retrieved] | License information. | This should be a preview version. |
@@ -110,10 +110,7 @@ public class ApacheHttpAsyncClientInstrumentation implements TypeInstrumentation
@Override
public HttpRequest generateRequest() throws IOException, HttpException {
HttpRequest request = delegate.generateRequest();
- tracer()
- .getPropagators()
- .getTextMapP... | [ApacheHttpAsyncClientInstrumentation->[TraceContinuedFutureCallback->[completeDelegate->[completed],failDelegate->[failed],cancelDelegate->[cancelled]],DelegatingRequestProducer->[failed->[failed],isRepeatable->[isRepeatable],generateRequest->[generateRequest],resetRequest->[resetRequest],produceContent->[produceConte... | Override generateRequest to inject the span name and span name into the request. | This looks like an overload is missing. |
@@ -258,6 +258,10 @@ def main():
presenter.drawGraphs(frame)
frame = draw_detections(frame, objects, palette, model.labels, args.prob_threshold)
metrics.update(start_time, frame)
+
+ if video_writer.isOpened():
+ video_writer.write(frame)
+
i... | [ColorPalette->[min_distance->[dist]],main->[build_argparser,get_model,get_plugin_configs,print_raw_results,ColorPalette,draw_detections],main] | Main function for the n - node command. This function handles the n - tuple detections and the detections of the objects in the. | There is the second part of pipeline below: `# Process completed requests` which also should save frames. The same is for segmentation. |
@@ -27,6 +27,11 @@ from .base import (
class AccountRegisterInput(graphene.InputObjectType):
email = graphene.String(description="The email address of the user.", required=True)
password = graphene.String(description="Password.", required=True)
+ redirect_origin = graphene.String(
+ description="Ba... | [AccountDelete->[perform_mutation->[clean_instance]],AccountRequestDeletion->[perform_mutation->[AccountRequestDeletion]],AccountRegister->[save->[save],Arguments->[AccountRegisterInput]],AccountUpdate->[Arguments->[AccountInput]]] | Create a new user object. Input for the customer s shipping address. | Following our code-style: ```python blah=( "my" "long" "string" ) |
@@ -2247,7 +2247,11 @@ zvol_set_snapdev_sync_cb(dsl_pool_t *dp, dsl_dataset_t *ds, void *arg)
}
/*
- * Traverse all child snapshot datasets and apply snapdev appropriately.
+ * Traverse all child datasets and apply snapdev appropriately.
+ * We call dsl_prop_set_sync_impl() here to set the value only on the topleve... | [No CFG could be retrieved] | This function checks if the specified object has a valid and applies the snapdev appropriately - - - - - - - - - - - - - - - - - -. | I thought the goal here was to take the new value and to set it for all the children of the dataset. The way I read the proposed change, it will change the top-level snapdev value, but then it will traverse the children and for each child, will not change the snapdev but will 'reinforce' the current value of the snapde... |
@@ -268,12 +268,15 @@ public class Http2ConnectionHandler extends ByteToMessageDecoder implements Http
}
int prefaceRemaining = clientPrefaceString.readableBytes();
- int bytesRead = Math.min(in.readableBytes(), prefaceRemaining);
+ int bytesRead = min(in.readableBytes(... | [Http2ConnectionHandler->[BaseDecoder->[channelInactive->[connection]],close->[close],decode->[decode],checkCloseConnection->[operationComplete,isGracefulShutdownComplete],onHttpServerUpgrade->[prefaceSent],handlerRemoved0->[handlerRemoved],closeStream->[close],exceptionCaught->[exceptionCaught],channelInactive->[chann... | Reads the client preface string. | can we hexDump without creating a slice and so reduce object allocation ? |
@@ -5240,6 +5240,7 @@ Recycler::FinishConcurrentCollect(CollectionFlags flags)
#ifdef PROFILE_EXEC
Js::Phase concurrentPhase = Js::ConcurrentCollectPhase;
+ static_cast<Js::Phase>(concurrentPhase);
#endif
#if ENABLE_PARTIAL_GC
RECYCLER_PROFILE_EXEC_BEGIN2(this, Js::RecyclerPhase,
| [No CFG could be retrieved] | Provides a private method to allow a single object to be used as a reserved object for the finds the next non - zero value in the array and returns it. | What is this line for? |
@@ -18,6 +18,8 @@
*/
package org.jasig.cas.authentication;
+import com.google.common.base.Functions;
+import com.google.common.collect.Maps;
import org.jasig.cas.Message;
import org.jasig.cas.authentication.handler.support.AbstractUsernamePasswordAuthenticationHandler;
import org.jasig.cas.authentication.princi... | [LdapAuthenticationHandler->[createPrincipal->[createPrincipal]]] | Imports a single object. LDAP authentication handler that provides simple attribututiation for the ldaptive component underne. | When did Guava components become available? We can do all sorts of fun collection magic now :) |
@@ -120,7 +120,17 @@ def filter_file(source, dest, output=False):
with open(dest, 'w') as outfile:
for line in infile:
- line = line.rstrip()
+ # Only strip newline characters
+ # We still want to catch trailing whitespace warnings
+ li... | [flake8->[filter_file,flake8,changed_files,prefix_relative]] | Filter a single file through all the patterns in exemptions. | I've been wondering why trailing whitespaces have been slipping in! |
@@ -361,7 +361,7 @@ function buildExamples(watch) {
// Also update test-example-validation.js
buildExample('a4a.amp.html');
buildExample('ads.amp.html');
- buildExample('ads.with.script.amp.html');
+ buildExample('ads-legacy.amp.html');
buildExample('adsense.amp.html');
buildExample('alp.amp.html');
... | [No CFG could be retrieved] | Build the examples of a single node. This example shows a full list of all possible metadata files. | maybe the ads with script should be the canonical? we do want people to explicitly add the script tag. |
@@ -15,7 +15,7 @@ class ConanController(Controller):
"""
def attach_to(self, app):
- conan_route = '%s/:conanname/:version/:username/:channel' % self.route
+ conan_route = '%s/<conanname>/<version>/<username>/<channel>' % self.route
@app.route("/ping", method=["GET"])
def p... | [ConanController->[attach_to->[get_package_snapshot->[get_package_snapshot],search_packages->[search_packages],get_conanfile_snapshot->[get_conanfile_snapshot],get_package_upload_urls->[get_package_upload_urls],get_package_download_urls->[get_package_download_urls],remove_packages->[remove_packages],remove_conanfile->[... | Attach to the application. Get a list of all non - conan file references and their corresponding md5s Get a list of conan file references and upload urls Search for a specific node in the system. Remove conanfiles or packages from the conan file or package. | The ":var" way to specify parameters was deprecated a long time ago. Not related with the revisions feature. |
@@ -65,7 +65,7 @@ from mypy.nodes import (
from mypy.stubgenc import parse_all_signatures, find_unique_signatures, generate_stub_for_c_module
from mypy.stubutil import is_c_module, write_header
from mypy.options import Options as MypyOptions
-from mypy.types import Type, TypeStrVisitor, AnyType, CallableType, Unboun... | [get_qualified_name->[get_qualified_name],has_return_statement->[ReturnSeeker],ImportTracker->[reexport->[require_name]],main->[walk_packages,generate_stub_for_module],find_module_path_and_all->[CantImport],find_self_initializers->[SelfTraverser],walk_packages->[walk_packages],StubGenerator->[print_annotation->[Annotat... | Generate a C - module object from a given sequence of objects. Find module path and class signatures. | This line is too long. You probably should use a multi-line import. |
@@ -276,6 +276,7 @@ class Predictor(Registrable):
archive: Archive,
predictor_name: str = None,
dataset_reader_to_load: str = "validation",
+ frozen: bool = False,
) -> "Predictor":
"""
Instantiate a `Predictor` from an [`Archive`](../models/archival.md);
| [Predictor->[_batch_json_to_instances->[_json_to_instance],capture_model_internals->[add_output]]] | Instantiate a Predictor from an Archive. | Again here the default is `False`. |
@@ -301,6 +301,14 @@ class ObserverQuantizer(Quantizer):
calibration_config[name]['tracked_min_weight'] = -val
calibration_config[name]['tracked_qmin_weight'] = -127
calibration_config[name]['tracked_qmax_weight'] = 127
+ weight = module.weight
+ ... | [LsqQuantizer->[__init__->[get_bits_length],quantize_input->[quantize],quantize->[round_pass,grad_scale],quantize_weight->[quantize],export_model->[_del_simulated_attr],quantize_output->[quantize]],QAT_Quantizer->[quantize_weight->[get_bits_length,_quantize,_dequantize,update_quantization_param],quantize_input->[get_bi... | Exports quantized model weights and calibration parameters to a file. Adds tracking of the n - qubit input and output values to the calibration config. | why we need `_quantize` again? |
@@ -577,6 +577,11 @@ class ReviewBase(object):
if (self.version and
self.version.channel == amo.RELEASE_CHANNEL_UNLISTED):
review_url_kw['channel'] = 'unlisted'
+ dev_ver_url = reverse(
+ 'devhub.addons.versions',
+ args=[self.version.id])
... | [ReviewUnlisted->[process_public->[set_files,notify_email,log_action]],EditorQueueTable->[render_addon_name->[increment_item]],ReviewHelper->[set_data->[set_data]],ViewUnlistedAllListTable->[render_guid->[safe_substitute],render_authors->[safe_substitute],render_review_date->[safe_substitute],render_addon_name->[increm... | Return a dict with the context data for the next action. | this should be `args=[self.addon.id])` |
@@ -183,15 +183,15 @@ public class InstallUtil {
}
static File getConfigFile() {
- return new File(Jenkins.getActiveInstance().getRootDir(), "config.xml");
+ return new File(Jenkins.getInstance().getRootDir(), "config.xml");
}
static File getLastExecVersionFile() {
- return ... | [InstallUtil->[persistInstallStatus->[getInstallingPluginsFile],clearInstallStatus->[persistInstallStatus],getPersistedInstallStatus->[getInstallingPluginsFile],saveLastExecVersion->[saveLastExecVersion]]] | Get the config. xml file. | To be a wee bit more consistent with the (seemingly?) common pattern in the rest of the codebase, use `InstallUtil.class.getName()+"."+lastExecVersion` instead? |
@@ -1220,11 +1220,10 @@ class CI_DB_driver {
*
* This function adds backticks if appropriate based on db type
*
- * @access private
* @param mixed the item to escape
* @return mixed the item with backticks
*/
- function protect_identifiers($item, $prefix_single = FALSE)
+ protected function protect_i... | [CI_DB_driver->[list_fields->[query],list_tables->[query],field_data->[field_data,query],field_exists->[list_fields],insert_string->[escape],simple_query->[initialize],update_string->[escape],table_exists->[list_tables],_cache_init->[cache_off],_protect_identifiers->[_protect_identifiers]]] | This function is used to protect identifiers in a given item. | Must be public - that's the sole purpose of this method's existence. :) |
@@ -86,10 +86,15 @@ async def package_python_awslambda(
],
)
+ lockfile_hex_digest = None
+ if lambdex.lockfile != "<none>":
+ lockfile_request = await Get(PythonLockfileRequest, LambdexLockfileSentinel())
+ lockfile_hex_digest = lockfile_request.hex_digest
+
lambdex_request = P... | [rules->[collect_rules,UnionRule,rules],package_python_awslambda->[BuiltPackageArtifact,MultiGet,PexPlatforms,to_interpreter_version,VenvPexProcess,PexRequest,ResolvePythonAwsHandlerRequest,PexFromTargetsRequest,sorted,value_or_default,BuiltPackage,Get,warning,targets_with_sources_types,doc_url,TransitiveTargetsRequest... | Package a single missing - key lease from AWS Lambda. Get a single lease from the pex. | This magic string ended up peppered a lot of places. Would be good to have `def lockfile` convert `"<none>"` to `str | None` instead. |
@@ -868,6 +868,7 @@ namespace System.Net.Http.Functional.Tests
Http2LoopbackConnection connection2 = await server.EstablishConnectionAsync();
int streamId2 = await connection2.ReadRequestHeaderAsync();
await connection2.SendDefaultResponseAsync(streamId2);
+ ... | [HttpClientHandlerTest_Http2->[ValidAndInvalidProtocolErrorsAndBool->[ValidAndInvalidProtocolErrors],DuplexContent->[Task->[Task],WaitForStreamAsync->[Task]],Task->[Fail,EstablishConnectionAndProcessOneRequestAsync,ValidateConnection,ReadToEndOfStream,Task,WaitForStreamAsync,Complete]]] | This method is used to send a GOAWAY frame to the server and establish a new. | Similar to above: Can't we make this automatic or something? |
@@ -64,8 +64,9 @@ public class TestRepairsCommand extends AbstractShellIntegrationTest {
tablePath = basePath + File.separator + tableName;
// Create table and connect
+ System.out.println(tablePath);
new TableCommand().createTable(
- tablePath, "test_table", HoodieTableType.COPY_ON_WRITE.nam... | [TestRepairsCommand->[testOverwriteHoodieProperties->[assertTrue,getValue,toMap,toArray,toString,getKey,getProps,isSuccess,asList,File,valueOf,load,getResource,print,executeCommand,assertEquals,assertNotNull,FileInputStream,Properties,collect,getPath],init->[createTable,name],testRemoveCorruptedPendingCleanAction->[ass... | Initialize the table for the given . | Can we remove stdout print? |
@@ -31,6 +31,11 @@ RSpec.describe "UserSettings", type: :request do
expect(response.body).to include("Style Customization")
end
+ it "displays content on misc tab properly" do
+ get "/settings/misc"
+ expect(response.body).to include("Display Announcements (When browsing)")
+ e... | [send_request->[id,put],create,let,be,describe,email_addresses,ago,where,fixture_file_upload,profile_updated_at,first,it,put,identities,to,update_column,user_settings_path,sidekiq_assert_no_enqueued_jobs,before,post,sidekiq_perform_enqueued_jobs,require,official_name,sidekiq_assert_enqueued_with,count,change,include,to... | The basic actions that can be performed on a user s settings. user - > response template. | Since this is testing what renders on the _entire_ misc tab, we should probably include more expectations here (not part of your work perse, I know, but I think that would make for a better test based on the description ) |
@@ -300,7 +300,7 @@ func (l *balanceAdjacentRegionScheduler) disperseLeader(cluster opt.Cluster, bef
}
op, err := operator.CreateTransferLeaderOperator("balance-adjacent-leader", cluster, before, before.GetLeader().GetStoreId(), target.GetID(), operator.OpAdjacent)
if err != nil {
- log.Debug("fail to create tra... | [EncodeConfig->[EncodeConfig],disperseLeader->[allowBalanceLeader,GetName],process->[len,GetName],Schedule->[GetName,len,clear],dispersePeer->[allowBalancePeer,GetName],unsafeToBalance->[GetName]] | disperseLeader disperses the leader between two regions. | We don't need to change the debug level log. |
@@ -80,8 +80,9 @@ class CodersTest(unittest.TestCase):
coders.RunnerAPICoderHolder,
coders.ToBytesCoder
])
- assert not standard - cls.seen, standard - cls.seen
- assert not standard - cls.seen_nested, standard - cls.seen_nested
+ cls.seen_nested -= set([coders.ProtoCoder, CustomCoder])
... | [CodersTest->[test_nested_observables->[FakeObservableIterator],test_singleton_coder->[check_coder],test_windowed_value_coder->[decode,check_coder,encode],test_bool_coder->[check_coder],test_dill_coder->[check_coder],test_windowedvalue_coder_paneinfo->[check_coder],test_custom_coder->[CustomCoder,check_coder],test_para... | Tear down a class. | Why is this change necessary? |
@@ -134,7 +134,7 @@ public class TripleA implements IGameLoader {
frame.toFront();
});
} catch (final InterruptedException e) {
- ClientLogger.logQuietly(e);
+ Thread.currentThread().interrupt();
}
}
| [TripleA->[shutDown->[removeSoundChannel,removeDisplay,shutDown],createPlayers->[equals,IllegalStateException,get,keySet,FastAI,DoesNothingAI,TripleAPlayer,add,ProAI,WeakAI],getUnitFactory->[createUnit->[TripleAUnit],IUnitFactory],startGame->[HeadlessSoundChannel,initialize,play,HeadlessUiContext,getDelegate,addDelegat... | Start a new game. | We have a `SwingAction` library that takes care of the `InterruptedException` in this case, right? I'm noting that as it seems like this should be handled by the the invoked code. If all we do is ignore the exception and interrupt the current thread, that would be a good detail to tuck into a library call, and would re... |
@@ -42,6 +42,17 @@ func resourceAwsEMRCluster() *schema.Resource {
Optional: true,
ForceNew: true,
},
+ "additional_info": {
+ Type: schema.TypeString,
+ Optional: true,
+ Computed: true,
+ ForceNew: true,
+ ValidateFunc: validateJsonString,
+ StateFunc: func(v inte... | [StringValueSlice,GetChange,SetPartial,StringSlice,Close,StringValueMap,StringInSlice,RemoveTags,ListInstanceGroups,Partial,HasPrefix,NonRetryableError,Set,ListInstances,Code,ModifyInstanceGroups,ReadFile,GetOk,DescribeCluster,HasChange,ListBootstrapActions,Errorf,SetTerminationProtection,SetId,RetryableError,Bool,Trim... | region Private functions Check if the given resource is equivalent to the resource in the cluster. | This attribute should not be `Computed: true` - we want to know when there is drift from the API |
@@ -358,6 +358,12 @@ def dynamic_lstm(input,
dtype(str): Data type. Choices = ["float32", "float64"], default "float32".
name(str|None): A name for this layer(optional). If set None, the layer
will be named automatically.
+ h_0(Variable): The initial hidden state is an ... | [dice_loss->[reduce_sum,one_hot,reduce_mean],ctc_greedy_decoder->[topk],conv2d->[_get_default_param_initializer],sequence_first_step->[sequence_pool],matmul->[__check_input],image_resize->[_is_list_or_turple_],sequence_last_step->[sequence_pool],resize_bilinear->[image_resize],lstm_unit->[fc],image_resize_short->[image... | Dynamic LSTM layer for a single node. This function is called when a hidden state of a dynamic LSTM layer has no variable Network state of the last non - zero non - zero non - zero non - zero non Create a hidden cell - batch - gate and batch - cell - pre - act for missing. | Tell the users if not set, the default is zero. |
@@ -955,8 +955,8 @@ module FirstTimeDataGenerator
'If desired, more than 30 mg tissue can be disrupted and homogenized ' \
'at the start of the procedure (increase the volume of Buffer RLT ' \
'proportionately). Use a portion of the homogenate corresponding to no ' \
- 'more than 30 mg tissue ... | [generate_step_comment->[generate_random_time],generate_module_comment->[generate_random_time],generate_project_comment->[generate_random_time],generate_result_comment->[generate_random_time],generate_module_steps->[generate_random_time],seed_demo_data_with_id->[seed_demo_data]] | Seed demo data with missing node - node - node - node - node - node - node Generate random custom respository sample names and random custom respository rows and sample types and groups Creates a sample group and a project if the user has no sample or a sample group with Create an experiment from a base - level object. | Metrics/LineLength: Line is too long. [82/80] |
@@ -3,4 +3,4 @@
# Licensed under the MIT License. See LICENSE.txt in the project root for
# license information.
# --------------------------------------------------------------------------
-VERSION = "0.0.1"
+VERSION = "1.0.0"
| [No CFG could be retrieved] | License for the ethernet interface. | This should be a prerelease so 1.0.0b1 possibly? |
@@ -65,6 +65,8 @@ public class CompletableFutureInboundDataClient implements InboundDataClient {
@Override
public void fail(Throwable t) {
- future.completeExceptionally(t);
+ // Use obtrudeException instead of CompleteExceptionally, forcing any future calls to .get()
+ // to raise the execption, even ... | [CompletableFutureInboundDataClient->[cancel->[cancel],isDone->[isDone],complete->[complete],forBackingFuture->[CompletableFutureInboundDataClient]]] | Fails the task with the given exception. | Good catch. I did not realize that standard future behavior required this other function :-/ |
@@ -40,12 +40,14 @@ class ZipkinReporter(Reporter):
"""Reporter that implements Zipkin tracing .
"""
- def __init__(self, run_tracker, settings, endpoint):
+ def __init__(self, run_tracker, settings, endpoint, trace_id, parent_id):
super(ZipkinReporter, self).__init__(run_tracker, settings)
# We kee... | [ZipkinReporter->[__init__->[HTTPTransportHandler]]] | Initialize the ZipkinReporter. | Let's add some pydoc here to explain what these parameters all are, now that we have some that are a little less obvious :) |
@@ -335,10 +335,10 @@ class Experiment < ActiveRecord::Base
format = 'Clone %d - %s'
i = 1
- i += 1 while experiment_names.include?(format(format, i, name)[0, 50])
+ i += 1 while experiment_names.include?(format(format, i, name))
clone = Experiment.new(
- name: format(format, i, name)[0, 5... | [Experiment->[move_to_project->[deep_clone_to_project],assign_samples_to_new_downstream_modules->[assign_samples_to_new_downstream_modules],moveable_projects->[projects_with_role_above_user],generate_workflow_img_for_moved_modules->[generate_workflow_img],deep_clone_to_project->[generate_workflow_img]]] | Clone a node to a project. | What is that [0, 50] needed? It is OK to get rid of it? Do we have to truncate the name here? |
@@ -114,6 +114,16 @@ class SubmissionsController < ApplicationController
end
end
+ last_rev = @grouping.submissions
+ @last_submission = nil
+ if !last_rev.empty?
+ selected = @revisions_history.select do |rev|
+ rev[:num] == last_rev.last.revision_number
+ end
+
+ @last_s... | [SubmissionsController->[downloads_subdirectories->[downloads_subdirectories]]] | This method is called from the action_missing in the action_addition of the action finds a in the repository and returns it. | Trailing whitespace detected. |
@@ -245,10 +245,13 @@ def get_neuromag_transform(lpa, rpa, nasion):
return trans
-def transform_pts(pts, unit='mm'):
- """Transform KIT and Polhemus points to RAS coordinate system
+def transform_ALS_to_RAS(pts, unit='mm'):
+ """Transform points from a ALS to RAS a coordinate system
- This is used t... | [get_points->[transform_pts,read_hsp,append,read_elp,read_mrk,enumerate,get_neuromag_transform,dot],read_hsp->[findall,TypeError,splitext,int,len,copy,compile,open,load,array],transform_pts->[ValueError,array],read_elp->[findall,open,compile,array],read_mrk->[TypeError,splitext,loadtxt,append,unpack,seek,read,fromfile,... | Transform points in KIT and Polhemus points to RAS coordinate system. | an / in ALS (anterior, left, superior) coordinates |
@@ -144,14 +144,18 @@ class Boost(Package):
description="Augment library layout with versioned subdirs")
variant('clanglibcpp', default=False,
description='Compile with clang libc++ instead of libstdc++')
+ variant('numpy', default=False,
+ description='Build the Boost NumPy... | [Boost->[determine_bootstrap_options->[determine_toolset,bjam_python_line],install->[determine_bootstrap_options,add_buildopt_symlinks,determine_b2_options],determine_b2_options->[determine_toolset]]] | Create a new package with a specific name. Returns the url for a given version of the boost. | Does it link to this library? Should this be `type=('build', 'run')`? |
@@ -9,6 +9,7 @@ module Engine
include Tokener
def actions(entity)
+ return [] unless ability(entity)
return [] if !ability(entity) || available_tokens(entity).empty?
actions = ['place_token']
| [SpecialToken->[available_tokens->[new,owner,extra_action,type,ability],actions->[ability,teleported,empty?],active_entities->[teleported],available_hex->[id,include?,empty?,keys],teleport_complete->[ability,remove_ability,teleported],ability->[company?,used?,abilities],blocking?->[can_token_after_teleport?],round_stat... | actions returns an array of actions for the given entity. | why did you add this, it's the same as line 13 |
@@ -447,9 +447,12 @@ class EventHubClient(object):
:type offset: ~azure.eventhub.common.Offset
:param prefetch: The message prefetch count of the receiver. Default is 300.
:type prefetch: int
- :operation: An optional operation to be appended to the hostname in the source URL.
+ ... | [EventHubClient->[from_sas_token->[_build_uri],_handle_redirect->[_process_redirect_uri],from_iothub_connection_string->[_generate_sas_token,_parse_conn_str],from_connection_string->[_build_uri,_parse_conn_str],run->[_handle_redirect,_start_clients],stop->[_close_clients],get_eventhub_info->[_create_auth]]] | Adds a receiver to the client for a particular consumer group and partition. | Minor: The docstring param also applies to the `add_epoch_receiver` method below. |
@@ -279,6 +279,13 @@ class SlidingEstimator(BaseEstimator, TransformerMixin):
score = np.concatenate(score, axis=0)
return score
+ @property
+ def classes_(self):
+ if not hasattr(self.estimators_[0], 'classes_'):
+ raise AttributeError('classes_ attribute available only if '... | [_sl_transform->[transform],_gl_transform->[transform],GeneralizingEstimator->[decision_function->[_transform],score->[_check_Xy],predict_proba->[_transform],_transform->[_check_Xy,_check_method],transform->[_transform],predict->[_transform]],SlidingEstimator->[decision_function->[_transform],score->[_check_Xy],predict... | Score each estimator on each task. Aux. function to fit SlidingEstimator in parallel. | , and estimator %s does not' % (self.estimators_[0],) |
@@ -618,3 +618,8 @@ class UDPTransport(Runnable):
def set_node_network_state(self, node_address: typing.Address, node_state):
state_change = ActionChangeNodeNetworkState(node_address, node_state)
self.raiden.handle_state_change(state_change)
+
+ @property
+ def _queueids_to_queues(self) -> ... | [UDPTransport->[receive_message->[maybe_send],get_queue_for->[init_queue_for],receive_ping->[maybe_send],stop->[stop],start->[start],init_queue_for->[get_health_events],send_async->[get_queue_for]]] | Set the node network state. | this is not being used anywhere, please remove |
@@ -154,6 +154,7 @@ public final class ClientCookieDecoder extends CookieDecoder {
private int expiresEnd;
private boolean secure;
private boolean httpOnly;
+ private String sameSite;
CookieBuilder(DefaultCookie cookie, String header) {
this.cookie = cookie;
| [ClientCookieDecoder->[CookieBuilder->[computeValue->[isValueDefined],cookie->[mergeMaxAgeAndExpires],parse7->[setMaxAge]],ClientCookieDecoder]] | NAME Constructs a cookie object from a header string. Parse and store a key - value pair in a cookie. | Personally, I would go with an enum. |
@@ -63,7 +63,7 @@ def process_hud_alert(hud_alert, audible_alert):
sound1 = 1
elif audible_alert in ['beepSingle', 'chimeSingle', 'chimeDouble']:
# TODO: find a way to send single chimes
- sound2 = 1
+ sound2 = 0 #Changed by P Lee to disable disengage chime
return steer, fcw, sound1, sound2
| [CarController->[update->[ipas_state_transition,accel_hysteresis,process_hud_alert]]] | Process Hud alert. | @zeeexsixare : can you remove the changes to `carcontroller.py`? Also, can you update the README by lowering the min accel speed to zero? |
@@ -41,6 +41,6 @@ public enum ProcessingLoggingJsonMapper {
.setNodeFactory(JsonNodeFactory.withExactBigDecimals(true));
public ObjectMapper get() {
- return mapper;
+ return mapper.copy();
}
}
\ No newline at end of file
| [setNodeFactory,withExactBigDecimals] | Gets the object mapper. | Make deep-copy instead of suppress spotbug warning. |
@@ -79,6 +79,11 @@ class Opus::Types::Test::EdgeCasesTest < Critic::Unit::UnitTest
assert_raises(TypeError) do
klass.new.bar(1)
end
+
+ # Should use fast path
+ obj = klass.new
+ allocs = counting_allocations {obj.bar}
+ assert(allocs < 5)
end
it ... | [sanity,hello,counting_allocations,foo,bar,bad_return] | Creates a new object of the given type. handles alias with runtime checking. | Do you have a bound for the number of allocations done on the slow path? Mostly just curious to know what the difference between the two is. |
@@ -677,10 +677,10 @@ namespace Microsoft.Xna.Framework
internal void applyChanges(GraphicsDeviceManager manager)
{
Platform.BeginScreenDeviceChange(GraphicsDevice.PresentationParameters.IsFullScreen);
- if (GraphicsDevice.PresentationParameters.IsFullScreen)
- Platform.E... | [Game->[InitializeExistingComponents->[Initialize],OnDeactivated->[AssertNotDisposed],Log->[Log],DoUpdate->[AssertNotDisposed,Update],Components_ComponentAdded->[Initialize],DoDraw->[Draw,EndDraw,AssertNotDisposed,BeginDraw],Exit->[Exit],Platform_ApplicationViewChanged->[AssertNotDisposed],DoInitialize->[AssertNotDispo... | This method applies changes that have not been made to the device manager. | Same here, just delete the code that you feel is no longer needed. The diff history will tell us what has changed. |
@@ -50,6 +50,13 @@ public class CountBufferAggregator implements BufferAggregator
return buf.getLong(position);
}
+
+ @Override
+ public long getLong(ByteBuffer buf, int position)
+ {
+ return buf.getLong(position);
+ }
+
@Override
public void close()
{
| [CountBufferAggregator->[init->[putLong],getFloat->[getLong],get->[getLong],aggregate->[putLong,getLong]]] | Returns a float value from the buffer at the specified position. | hm, both getFloat() and getLong() call buf.getLong()? |
@@ -237,7 +237,8 @@ def _check_set(ch, projs, ch_type):
class SetChannelsMixin(object):
"""Mixin class for Raw, Evoked, Epochs."""
- def set_eeg_reference(self, ref_channels=None):
+ @verbose
+ def set_eeg_reference(self, ref_channels=None, verbose=None):
"""Rereference EEG channels to new ref... | [ContainsMixin->[__contains__->[_contains_ch_type]],_get_T1T2_mag_inds->[pick_types],UpdateChannelsMixin->[pick_types->[pick_types],_pick_drop_channels->[inst_has]],read_ch_connectivity->[_recursive_flatten],fix_mag_coil_types->[pick_types],SetChannelsMixin->[set_channel_types->[_check_set],rename_channels->[rename_cha... | Rereference EEG channels to new reference channel. | you need to update the arg list |
@@ -579,9 +579,9 @@ class TestValidateFilePath(ValidatorTestCase):
self.create_switch('addons-linter')
# This test assumes that `amo-validator` doesn't correctly
- # validate a missing id in manifest.json
+ # validate a invalid id in manifest.json
result = tasks.validate_file_... | [TestValidateFilePath->[test_amo_validator_fail_warning->[get_addon_file],test_amo_validator_fail_error->[get_addon_file],test_amo_validator_addons_linter_success->[get_addon_file],test_amo_validator_success->[get_addon_file],test_amo_validator_addons_linter_error->[get_addon_file]],TestRunAddonsLinter->[test_run_linte... | Test that addons - linter doesn t throw an error when missing id in manifest. json. | We validate IDs but don't require them. Should we at least file a bug to move this into the linter? (Or maybe it already does so) |
@@ -151,6 +151,11 @@ func kube(cmd *cobra.Command, args []string) error {
if kubeOptions.Down {
return teardown(yamlfile)
}
+ if kubeOptions.Replace {
+ if err := teardown(yamlfile); err != nil && !errorhandling.Contains(err, define.ErrNoSuchPod) {
+ return err
+ }
+ }
return playkube(yamlfile)
}
| [StringVar,ExactArgs,StringSliceVar,SetNormalizeFunc,PlayKubeDown,MarkHidden,PrintErrors,Stat,Errorf,GetContext,ParseMAC,Fprintln,RegisterFlagCompletionFunc,IPSliceVar,Fprint,NewOptionalBool,PlayKube,IsRemote,Fprintf,Println,Changed,ParseRegistryCreds,GetDefaultAuthFile,ContainerEngine,BoolVarP,Flags,BoolVar] | Setups the necessary flags for the which can be used to verify the current state Playkube plays a single pod if it is stopped. | Should this succeed if a previous podman play kube had not run? IE ignore Kube does not exists errors? |
@@ -63,5 +63,15 @@ defineSuite([
expect(HermitePolynomialApproximation.getRequiredDataPoints(1)).toEqual(2);
expect(HermitePolynomialApproximation.getRequiredDataPoints(2)).toEqual(3);
expect(HermitePolynomialApproximation.getRequiredDataPoints(3)).toEqual(4);
+ expect(HermitePolynomia... | [No CFG could be retrieved] | This method checks that the required data points are filled in with the same number of samples. | Code coverage indicates an important block missed in `HermitePolynomialApproximation.interpolateOrderZero`. |
@@ -19,6 +19,7 @@
package org.apache.hudi.metrics;
import java.io.Closeable;
+import java.io.IOException;
/**
* Interface for implementing a Reporter.
| [No CFG could be retrieved] | This abstract class is used to report a single . | would get removed. |
@@ -25,3 +25,13 @@ func (fm *FluxMonitor) ExportedRoundState() {
func (fm *FluxMonitor) ExportedRespondToNewRoundLog(log *flux_aggregator_wrapper.FluxAggregatorNewRound, broadcast log.Broadcast) {
fm.respondToNewRoundLog(*log, broadcast)
}
+
+func (fm *FluxMonitor) ExportedRespondToFlagsRaisedLog() {
+ fm.respondTo... | [ExportedProcessLogs->[processLogs],ExportedRoundState->[roundState],ExportedPollIfEligible->[pollIfEligible],ExportedRespondToNewRoundLog->[respondToNewRoundLog]] | ExportedRespondToNewRoundLog implements flux. Aggregator. ExportedRespondToNewRound. | This should use a new type otherwise it could get confusing in the future |
@@ -825,9 +825,14 @@ def _take_3d_screenshot(figure, mode='rgb', filename=None):
with warnings.catch_warnings():
warnings.filterwarnings("ignore", category=FutureWarning)
_process_events(figure.plotter)
- return figure.plotter.screenshot(
+ # FIX: https://github.com/pyvista/pyvista/... | [_sphere->[_add_mesh],_get_world_to_view_matrix->[_mat_to_array],_take_3d_screenshot->[screenshot],_set_3d_view->[_get_camera_direction,_deg2rad,reset_camera],_Renderer->[show->[show,ensure_minimum_sizes,scene],mesh->[polydata],reset_camera->[reset_camera],subplot->[_enable_aa,subplot],__init__->[build,_enable_aa,_Figu... | Take a 3D screenshot of a figure. | try/except, or not necessary here? |
@@ -262,6 +262,7 @@ const ConstraintSyntax CFG_CONTROLBODY[COMMON_CONTROL_MAX + 1] =
ConstraintSyntaxNewReal("bwlimit", CF_VALRANGE, "Limit outgoing protocol bandwidth in Bytes per second", SYNTAX_STATUS_NORMAL),
ConstraintSyntaxNewBool("cache_system_functions", "Cache the result of system functions. Default ... | [bool->[PolicyErrorNew,SeqAppend,SeqLength,isdigit,DataTypeFromString,BodyHasConstraint,CheckIdentifierNotPurelyNumerical,CheckParseVariableName,SeqAt],CommonControlFromString->[strcmp],ConstraintSyntaxNewBool,ConstraintSyntaxNewNull,PromiseTypeSyntaxNewNull,PromiseTypeSyntaxNew,ConstraintSyntaxNewOptionList,Constraint... | Constraint syntax for the given node. The syslog facility for cf - agent. | Can we set this to a predefined list to improve syntax checking, or does it need to be freeform in case OpenSSL is upgraded separately? |
@@ -48,6 +48,7 @@ var SerializedProjectUpdateDomainServices = []string{
"compliance",
"ingest",
"nodemanager",
+ "feed",
}
type ProjectUpdateStatus interface {
| [collectRunningJobStatuses->[GetUpdateDomainServicesInstance,IsRunning],IsRunning->[IsRunning],Status->[getWorkflowInstance],Stage->[IsRunning],collectProgress->[GetUpdateDomainServicesInstance,IsRunning]] | requires that the cereal package is installed Two chains of tasks that run in parallel. | Adds the event feed to one of the services that are called from authz during a project update. |
@@ -171,6 +171,16 @@ class InplaceTestBase(unittest.TestCase):
class CPUInplaceTest(InplaceTestBase):
def initParameter(self):
self.use_cuda = False
+ self.fuse_all_optimizer_ops = False
+
+
+class CUDAInplaceTestWithFuseOptimizationOps(InplaceTestBase):
+ def initParameter(self):
+ self... | [InplaceTestBase->[test_single_card_fetch_var->[is_invalid_test,get_all_vars,build_program_and_scope],test_multi_card_fetch_var->[is_invalid_test,get_all_vars,build_program_and_scope],setUp->[initParameter]]] | Initialize the parameter. | Why? There should be no difference between CPU and GPU... And you mean, we can't set this option to `True` when training on CPU? |
@@ -1235,8 +1235,6 @@ const forbiddenTermsSrcInclusive = {
'extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js',
'extensions/amp-iframe/0.1/amp-iframe.js',
'extensions/amp-script/0.1/amp-script.js',
- 'extensions/amp-sidebar/0.1/amp-sidebar.js',
- 'extensions/amp-si... | [No CFG could be retrieved] | Deprecated. Use onLayoutMeasure instead. A list of functions that can be used to filter a list of elements. | Bravo! I don't think this kind of a cleanup would've been possible (or would've ever happened) earlier. |
@@ -37,8 +37,14 @@ def raiden_testchain(testchain_provider, cli_tests_contracts_version):
matrix_server="auto",
print_step=lambda x: None,
contracts_version=cli_tests_contracts_version,
- testchain_setup=testchain_provider,
+ eth_client=testchain_provider["eth_client"],
+ ... | [testchain_provider->[EthClient,setup_testchain],raiden_testchain->[print,monotonic,setup_raiden],cli_args->[copy,replace,items,append],raiden_spawner->[spawn_raiden->[addfinalizer,copy,startswith,str,items,spawn]],fixture] | Setup the raiden testchain. | This was not used by `setup_raiden`, only added to the `result` |
@@ -98,7 +98,7 @@ public class ContainerInfo implements Comparator<ContainerInfo>,
this.pipelineID = pipelineID;
this.usedBytes = usedBytes;
this.numberOfKeys = numberOfKeys;
- this.lastUsed = Time.monotonicNow();
+ this.lastUsed = Time.now();
this.state = state;
this.stateEnterTime = sta... | [ContainerInfo->[containerID->[getContainerID],Builder->[build->[ContainerInfo]],compare->[compare,getLastUsed],compareTo->[compare]]] | Creates a new instance of ContainerInfo from the given protobuf data. This class is used to create a unique identifier for a container. | If you change the lastUsed and stateEnterTime to lnstant type, the code will be much simpler and clean as @elek suggested. |
@@ -79,7 +79,7 @@ def wrap_index(typingctx, idx, size):
zero = llvmlite.ir.Constant(idx.type, 0)
is_negative = builder.icmp_signed('<', rem, zero)
wrapped_rem = builder.add(rem, size)
- is_oversize = builder.icmp_signed('>', wrapped_rem, size)
+ is_oversize = builder.icmp_signed... | [assert_equiv->[codegen->[pairwise->[unpack_shapes],pairwise]],ArrayAnalysis->[_analyze_op_call_numpy_copy->[_analyze_numpy_array_like],_index_to_shape->[to_shape->[slice_size],_get_shape,to_shape],_analyze_op_static_getitem->[_get_shape,_index_to_shape],_define->[define],_call_assert_equiv->[insert_equiv],_analyze_op_... | Wraps a base index with a codegen function. | Can the original sample that identified this issue be included as a test please? |
@@ -253,7 +253,7 @@ function reportErrorToServer(message, filename, line, col, error) {
// due to buggy browser extensions may be helpful to notify authors.
return;
}
- const url = getErrorReportUrl(message, filename, line, col, error,
+ const url = getErrorReportUrl(error.message, filename, line, col, e... | [No CFG could be retrieved] | This function is used to report errors to the browser. The expected error is a message that is not a string. | we can also simplify this method now |
@@ -77,6 +77,7 @@ public class EditingPreferencesPane extends PreferencesPane
"When enabled, the indentation for documents not part of an RStudio project " +
"will be automatically detected."));
editingPanel.add(checkboxPref("Insert matching parens/quotes", prefs_.insertMatching()));
+ ... | [EditingPreferencesPane->[addEnabledDependency->[onValueChange->[enable,disable],disable],validate->[validate],onApply->[onApply]]] | Creates a UI for editing a single user - specified object. Displays a list of strings that can be selected by the user. | Does everything in this pane still fit (vertically)? Noticed this pane is getting very full. I ran into a problem adding a checkbox to the Code / Display pane in #7030 and had to remove some other spacing or it was slightly clipped at the bottom |
@@ -45,7 +45,10 @@ export default class PinCode extends React.Component<PropsT, StateT> {
);
const baseOverrides = {
Root: {component: StyledInputOverrideRoot},
- Input: {component: StyledInputOverrideInput},
+ Input: {
+ component: StyledInputOverrideInput,
+ props: {type: this... | [No CFG could be retrieved] | The base class for pin - code. The component that handles the keydown event of the component. | Does this need to be an override? We can pass it directly to the `Input` below. |
@@ -186,6 +186,9 @@ public class MultiHopFlowCompiler extends BaseFlowToJobSpecCompiler {
}
Instrumented.markMeter(flowCompilationSuccessFulMeter);
Instrumented.updateTimer(flowCompilationTimer, System.nanoTime() - startTime, TimeUnit.NANOSECONDS);
+
+ this.rwLock.readLock().unlock();
+
return jo... | [MultiHopFlowCompiler->[setActive->[setActive],addShutdownHook->[addShutdownHook]]] | This method compiles a flow. | Shall we put it in `finally` block ? |
@@ -62,8 +62,8 @@ public abstract class AbstractClasspath {
private final InputFile.Type fileType;
private static final Path[] STANDARD_CLASSES_DIRS = {Paths.get("target", "classes"), Paths.get("target", "test-classes")};
- protected List<File> binaries;
- protected List<File> elements;
+ protected final Lis... | [AbstractClasspath->[getGlob->[separatorsToUnix],getElements->[init],getMatchingLibraries->[getGlob,getMatchingDirs],getBinaryDirs->[init]]] | Creates a class loader that loads files from a property. check if the files in the base directory match the patterns of the libraries. | Maybe also check if this is a directory |
@@ -133,6 +133,9 @@ class BertEmbedder(TokenEmbedder):
tokens from the first sentence should have type 0 and tokens from
the second sentence should have type 1. If you don't provide this
(the default BertIndexer doesn't) then it's assumed to be all 0s.
+ mask : ``torch.Lon... | [PretrainedBertModel->[load->[from_pretrained]],BertEmbedder->[forward->[,bert_model,list,split,size,_scalar_mix,append,combine_initial_dims,split_token_type_ids,pad,cat,len,get_range_vector,stack,uncombine_initial_dims,range,split_input_ids,zeros_like],__init__->[super,ScalarMix]],PretrainedBertEmbedder->[__init__->[s... | Forward computation of the windows embedding. I ve seen the store to the store to. Reshapes the encoder and embeddings into the long sequence. Get the initial dimensions of the n - ary chunk of the sequence. | Might be helpful to specify which other parts for people building analogues to this embedder in the future. |
@@ -34,11 +34,12 @@ import Arcus
from UM.i18n import i18nCatalog
catalog = i18nCatalog("cura")
-class CuraEngineBackend(Backend):
+class CuraEngineBackend(QObject, Backend):
## Starts the back-end plug-in.
#
# This registers all the signal listeners and prepares for communication
# with the... | [CuraEngineBackend->[_onGlobalStackChanged->[_onChanged],_onSceneChanged->[pauseSlicing,continueSlicing],_onBackendQuit->[_createSocket],pauseSlicing->[close],_onSocketError->[_terminate],_onBackendConnected->[_onChanged],_onToolOperationStarted->[_terminate]]] | Initializes the object with a . Sets up the object that will be used to start slicing. Sets the _process_layers_job and _error_message attributes to None if the. | I was under the impression that for QObjects you always need to set the parent. This is what we do for every other case where we use QObject. @awhiemstra Could you chime in on this? |
@@ -141,7 +141,13 @@ class HTTPTree(BaseTree): # pylint:disable=abstract-method
return response
def exists(self, path_info, use_dvcignore=True):
- return bool(self._head(path_info.url))
+ res = self._head(path_info.url)
+ if res.status_code == 404:
+ return False
+ ... | [HTTPTree->[_upload->[request,chunks],get_file_hash->[_head],request->[_auth_method,request],_download->[request],_head->[request],exists->[_head],_auth_method->[ask_password]]] | Check if a file exists in the Dvc. | It'd be better if we could wrap this with `HttpError` of dvc's itself. |
@@ -275,8 +275,7 @@ class Grouping < ApplicationRecord
# Add a new member to base
def add_member(user,
- set_membership_status=StudentMembership::STATUSES[:accepted],
- update_permissions=true)
+ set_membership_status=StudentMembership::STATUSES[:accepted])
if us... | [Grouping->[deletable_by?->[is_valid?],update_repository_permissions->[is_valid?],has_files_in_submission?->[has_submission?],create_all_test_scripts_error_result->[create_test_script_result],revoke_repository_permissions_for_membership->[write_repo_permissions?],remove_member->[membership_status],add_tas->[assign_all_... | Adds a user to the group. | Layout/SpaceAroundEqualsInParameterDefault: Surrounding space missing in default value assignment. |
@@ -64,7 +64,11 @@ class OpenidConnectAuthorizeForm
end
def ial2_requested?
- ial == 2
+ ial == 2 && !service_provider.liveness_checking_required
+ end
+
+ def ial2_strict_requested?
+ ial == 22 || (ial == 2 && service_provider.liveness_checking_required)
end
def ialmax_requested?
| [OpenidConnectAuthorizeForm->[validate_privileges->[ialmax_requested?,ial2_service_provider?,ial2_requested?],scopes->[ialmax_requested?,ial2_requested?],check_for_unauthorized_scope->[ial2_service_provider?,verified_at_requested?,ial2_requested?]]] | Checks if the IAL2 requested is requested or not. | I honestly think it would be worth it for us to migrate away from this int column into a varchar Failing that, can we make a constant for IAL2_STRICT_INT or something? Because 22 is not intuitive to me |
@@ -5538,3 +5538,18 @@ func flattenRoute53ResolverRuleTargetIps(targetAddresses []*route53resolver.Targ
return vTargetIps
}
+
+func flattenOrganizationsOrganizationalUnits(ous []*organizations.OrganizationalUnit) []map[string]interface{} {
+ if len(ous) == 0 {
+ return nil
+ }
+ var result []map[string]interface{... | [MapList->[Map],Set->[IsNil,ValueOf],SetStringMap->[IsNil,Sprintf,ValueOf],StringValueSlice,GetChange,NewSet,BoolValue,DeepEqual,Encode,Set,Strings,Copy,Itoa,FormatBool,Int64Value,NewBufferString,GetOk,ParseBool,NewEncoder,Float64ValueMap,Errorf,Len,MustCompile,BuildJSON,Bool,WriteToString,NormalizeJsonString,ToLower,H... | vTargetIps - List of vTargetIps. | Can you please move this function to the only place its called in `aws/data_source_aws_organizations_organizational_units.go`? We are trying to lower the usage of `aws/structure.go` for future refactoring work, thanks! |
@@ -242,6 +242,10 @@ class GradientDescentTrainer(Trainer):
precision training. Must be a choice of `"O0"`, `"O1"`, `"O2"`, or `"O3"`.
See the Apex [documentation](https://nvidia.github.io/apex/amp.html#opt-levels-and-properties) for
more details. If `None`, Amp is not used. Defaults to `None... | [GradientDescentTrainer->[_validation_loss->[batch_outputs],_train_epoch->[rescale_gradients,train,batch_outputs],train->[_validation_loss,_train_epoch]]] | Initialize a single object. Initializes the variables related to a single node of the AllenNLP model. The Pytorch object is stored in self. _pytorch_model and self. | We are trying to minimize the parameters that need to be passed directly to the trainer. I'm pretty sure you don't even need this, as you can just specify a `DataLoader`. Can you make your data loader class inherit from our `DataLoader`, and register it as something? In this PR, I'd like to see only modifications to da... |
@@ -27,8 +27,11 @@ class App < Snabberb::Component
props = {
props: { id: 'app' },
style: {
- padding: '0.5rem',
+ 'background-color': @user&.dig(:settings, :bg_color),
+ color: @user&.dig(:settings, :font_color),
margin: :auto,
+ 'min-height': '98vh',
+ pa... | [App->[on_hash_change->[store_app_route,any?,store,new],js_handlers->[to_n],render->[h],render_game->[enter_game,h,dig,include?,match],render_content->[h,store,new],store_app_route->[store],needs,include],require] | Renders a . | what happens when this is nil? |
@@ -5,10 +5,13 @@ import (
"flag"
"time"
+ "github.com/prometheus/client_golang/prometheus/promauto"
+
"github.com/go-kit/kit/log"
"github.com/go-kit/kit/log/level"
"github.com/pkg/errors"
"github.com/prometheus/alertmanager/cluster/clusterpb"
+ "github.com/prometheus/client_golang/prometheus"
"github... | [starting->[WaitReady],persist->[GetFullState,WithTimeout,Position,Log,SetFullState,Debug],iteration->[persist,Log,Error],RegisterFlagsWithPrefix->[DurationVar],New,NewTimerService] | A function to import alertmanager state from object storage. AlertStore is the alert store that will be used to persist alert messages. | Should not be in separate import group (of lines). |
@@ -950,12 +950,17 @@ func (b *Boxer) compareHeadersMBV2orV3(ctx context.Context, hServer chat1.Messag
return nil
}
-func (b *Boxer) makeHeaderHash(ctx context.Context, headerSealed chat1.SignEncryptedData) (chat1.Hash, UnboxingError) {
+func (b *Boxer) makeHeaderHash(headerSealed chat1.SignEncryptedData) (chat1.H... | [unboxV1->[bodyUnsupported,headerUnsupported],assertInTest->[log],box->[preBoxCheck],attachMerkleRoot->[latestMerkleRoot],verifyMessageV1->[headerUnsupported],getSenderInfoLocal->[getUsername,getUsernameAndDevice],unversionBody->[bodyUnsupported],boxV2orV3->[makeBodyHash],CompareTlfNames->[GetMembersType],UnboxMessages... | CompareHeadersMBV2orV3 compares two MessageClientHeaders in order to see if makeHeaderHash creates a hash for a message header. | `signencrypt.NonceSize` here vs `libkb.NaclDHNonceSize`in err msg, let's just use one |
@@ -11,6 +11,7 @@ import (
"strings"
"code.gitea.io/gitea/modules/log"
+ "code.gitea.io/gitea/modules/setting"
"github.com/go-xorm/xorm"
)
| [RemoveRepository->[HasRepository,removeRepository],unitEnabled->[getUnits],GetRepositories->[getRepositories],AddRepository->[HasRepository,addRepository],addRepository->[getMembers],GetMembers->[getMembers],HasRepository->[hasRepository],getRepositories,IsOwnerTeam,getMembers,GetRepositories] | Get a list of names of all units of a team. GetMember returns true if the given team is a member of the organization. | add a new line before the "github" import |
@@ -44,6 +44,7 @@ namespace System.Tests
}
[Fact]
+ [PlatformSpecific(~TestPlatforms.Browser)] // throws pNSE
public void TargetFrameworkTest()
{
const int ExpectedExitCode = 0;
| [AppDomainTests->[IsFullyTrusted->[IsFullyTrusted],LoadBytes->[Load],ExecuteAssembly->[ExecuteAssembly],Load->[Load],ApplyPolicy->[ApplyPolicy],ShadowCopyFiles->[ShadowCopyFiles],FriendlyName->[FriendlyName],IsFinalizingForUnload->[IsFinalizingForUnload],MonitoringIsEnabled->[MonitoringIsEnabled],IsCompatibilitySwitchS... | Tests that the nagios process is running in the same process as the remote app. | This seems to be using `RemoteExecutor`. Exclude it using `[ConditionalFact(typeof(RemoteExecutor)...`? |
@@ -136,7 +136,7 @@ func (l *LocalWorkspace) GetConfig(ctx context.Context, fqsn string, key string)
if err != nil {
return val, errors.Wrapf(err, "could not get config, unable to select stack %s", fqsn)
}
- stdout, stderr, errCode, err := l.runPulumiCmdSync(ctx, "config", "get", key, "--show-secrets", "--json")... | [runPulumiCmdSync->[PulumiHome,WorkDir,GetEnvVars],SetAllConfig->[SetConfig],RefreshConfig->[GetAllConfig],RemoveAllConfig->[RemoveConfig],ListStacks->[ProjectSettings,WhoAmI],SaveStackSettings,SaveProjectSettings] | GetConfig retrieves a config value from the current workspace. | `--show-secrets` was an intentional decision here (and below). The return type of `GetConfig` is a `ConfigValue` which has: - `Value`: the plaintext context of the config - `Secret`: a boolean flag indicating secretness This allows users (who are presumably privileged) to handle secrets with the maximum flexibility pos... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.