patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -329,9 +329,8 @@ def gen_init(modules):
yield "#"
module_strs = []
for module, clz, category in sorted(modules):
- if clz == "H2OGridSearch": continue
- module_strs.append('"%s"' % clz)
- if clz == "H2OAutoML": continue
+ if clz in ["H2OGridSearch", "H2OAutoML"]:
+ ... | [gen_module->[translate_type_for_check,normalize_enum_constant,translate_type_for_doc,extend_schema_params,code_as_str,stringify],main->[gen_module,algo_to_classname,gen_init,gen_models_docs],PythonTypeTranslatorForDoc,PythonTypeTranslatorForCheck,main] | Generate code to initialize a sequence of missing missing modules. | was generating duplicates: cf. `estimators/__init__.py` below |
@@ -48,7 +48,7 @@ class IntermediateLayerGetter(nn.Module):
super(IntermediateLayerGetter, self).__init__()
orig_return_layers = return_layers
- return_layers = {k: v for k, v in return_layers.items()}
+ return_layers = {str(k): str(v) for k, v in return_layers.items()}
layers... | [IntermediateLayerGetter->[_load_from_state_dict->[state_dict,super,get,len],forward->[OrderedDict,items,module],__init__->[super,set,ValueError,items,named_children,OrderedDict,ModuleDict]]] | Initialize the intermediate layer getter. | This will need changing a few things downstream I think, so that the state_dicts are still compatible |
@@ -43,6 +43,11 @@ class Proc
*/
private $_synchronous;
+ /**
+ * @var int|null hold the exit code, we can only get this on the first process_status after exit
+ */
+ private $_exitcode = null;
+
/**
* Create and run a new process
* Most arguments match proc_open()
| [Proc->[close->[closePipes,sendInput],terminate->[closePipes],isRunning->[getStatus]]] | Creates a new object of type which is a wrapper for the proc_open function Initializes the process and starts it if it is not running. | Are these changes supposed to be in here? Seems totally different from the locking side. |
@@ -104,7 +104,10 @@ class Notification < ApplicationRecord
reactable_id: notifiable.reactable_id,
reactable: {
path: notifiable.reactable.path,
- title: notifiable.reactable.title
+ title: notifiable.reactable.title,
+ class: {
+ name: no... | [Notification->[article_data->[path,updated_at,cached_tag_list_array,title,id],update_notifications->[json_data,id,send,downcase,where,blank?,update_all,name],send_push_notifications->[publish,strip!,size,unescapeHTML],send_welcome_notification->[create,processed_html,type_of,find_by,id,user_data,find_by_id],comment_da... | send reaction notification. | This fixes the `undefined method '[]' for nil` |
@@ -0,0 +1,11 @@
+using Robust.Shared.GameObjects;
+
+namespace Content.Server.PAI
+{
+ [RegisterComponent]
+ public class PAIComponent : Component
+ {
+ public override string Name => "PAI";
+ }
+}
+
| [No CFG could be retrieved] | No Summary Found. | Should have some explanation of what a PAI is somewhere for people not familiar with SS13. |
@@ -168,6 +168,11 @@ int DH_up_ref(DH *r)
return ((i > 1) ? 1 : 0);
}
+void ossl_dh_set0_libctx(DH *d, OSSL_LIB_CTX *libctx)
+{
+ d->libctx = libctx;
+}
+
#ifndef FIPS_MODULE
int DH_set_ex_data(DH *d, int idx, void *arg)
{
| [DH_set0_key->[BN_clear_free],dh_new_ex->[dh_new_intern],DH_new_method->[dh_new_intern],DH_security_bits->[BN_security_bits,BN_num_bits],DH_set_method->[init,ENGINE_finish,finish],DH_set_ex_data->[CRYPTO_set_ex_data],DH_size->[BN_num_bytes],DH->[OPENSSL_zalloc,OPENSSL_free,init,ENGINE_init,ENGINE_get_DH,CRYPTO_new_ex_d... | if DH_set_ex_data is called at the end of the function DH_. | I'm wondering if these should also take a propq argument? More for consistency than necessity. I can't think why it would be needed but not having it if it is is bad. |
@@ -58,6 +58,12 @@ export const AsyncInputAttributes = {
NAME: 'name',
};
+export const SUBMIT_TIMEOUT_TYPE = Object.freeze({
+ REGULAR : 10000,
+ /* 5 minutes */
+ INCREASED : 300000
+});
+
/**
* Classes
*
| [No CFG could be retrieved] | Attributes that can be asserted by every async - input element. | This should probably live in amp-form.js. |
@@ -460,6 +460,7 @@ class Vocabulary(Registrable):
counter = counter or {}
tokens_to_add = tokens_to_add or {}
+ self._retained_counter = counter
# Make sure vocabulary extension is safe.
current_namespaces = {*self._token_to_index}
extension_namespaces = {*counter,... | [Vocabulary->[from_instances->[Vocabulary],extend_from_instances->[pop_max_vocab_size,_extend],_extend->[_read_pretrained_tokens,add_non_padded_namespaces],__init__->[_TokenToIndexDefaultDict,_IndexToTokenDefaultDict],__str__->[get_vocab_size],from_params->[from_instances,pop_max_vocab_size,from_files],from_files->[Voc... | Extend the Vocabulary with additional parameters. Missing key - value pairs. | Please can you set this attribute to `None` in __init__ before you use it? We broadly try to only modify attributes in methods, rather than set them. |
@@ -119,8 +119,8 @@ class EngineTest(unittest.TestCase, SchedulerTestBase):
self.assert_equal_with_printing(dedent('''
1 Exception encountered:
- Computing Select(<pants_test.engine.test_engine.B object at 0xEEEEEEEEE>, A)
- Computing Task(nested_raise(), <pants_test.engine.test_engine.B objec... | [fib->[Fib],upcast->[MyFloat],EngineTest->[test_illegal_root_selection->[B,scheduler],test_no_include_trace_error_multiple_paths_raises_executionerror->[B,scheduler],test_include_trace_error_raises_error_with_trace->[B,scheduler],test_trace_multi->[c_from_b_nested_raise->[fn_raises],a_from_c_and_d->[A],d_from_b_nested_... | This test fails if the exception is raised by the execution of the task. | This is a potentially problematic step backward. It means that we're not correctly detecting the name of the module relative to the sourceroot (although only for tests, perhaps? that's a bit odd). I suspect that it would mean that imports would break in some situations. |
@@ -562,7 +562,6 @@ func (builder *STI) Execute(command string, user string, config *api.Config) err
}()
opts.Stdin = r
- defer wg.Wait()
}
go func(reader io.Reader) {
| [Build->[Build,Exists,Infof,Cleanup,Save,Warning,Execute,Prepare,V,Info],Exists->[V,PullImage,Infof],Save->[Join,Infof,ExtractTarStream,GetImageUser,NewSaveArtifactsError,Close,V,StreamContainerIO,Mkdir,RunContainer,Info,Pipe],Execute->[UploadToContainer,Close,CloseWithError,RunContainer,Info,CreateInjectedFilesRemoval... | Execute executes a command on the container Injections can be used to upload the injections to the container This is a long lived function that will upload the sources to a tar archive and then Info - Run the container. | Normally there's a single `defer wg.Done()` at the very top of the spawned goroutine (above) |
@@ -24,3 +24,4 @@ export const VERSION = process.env.VERSION;
export const DEBUG_INFO_ENABLED = !!process.env.DEBUG_INFO_ENABLED;
export const SERVER_API_URL = process.env.SERVER_API_URL;
export const BUILD_TIMESTAMP = process.env.BUILD_TIMESTAMP;
+// export const MY_DYNAMIC_VARIABLE = window.__env.myDynamicVariable... | [No CFG could be retrieved] | export environment variables. | Instead of incorporating a change without any real integration, I think it would be good to specify external server url and debug settings in this `env.js` and remove those from the webpack build. If you generate a separate front end and backend, then, the capability to specify external url is very useful. However, I t... |
@@ -791,7 +791,8 @@ func (b *cloudBackend) RenameStack(ctx context.Context, stack backend.Stack, new
// for general use yet.
if stackID.Owner != newIdentity.Owner {
errMsg := "You cannot transfer stack ownership via a rename. If you wish to transfer ownership\n" +
- "of a stack to another organization, please ... | [GetStack->[GetStack],RenameStack->[RenameStack,ParseStackReference],ListPolicyPacks->[ListPolicyPacks],parsePolicyPackReference->[CurrentUser],CloudConsoleURL->[CloudURL],tryNextUpdate->[CloudURL],GetPolicyPack->[CloudURL,Name,parsePolicyPackReference],CancelCurrentUpdate->[GetStack],GetLatestConfiguration->[GetLatest... | RenameStack renames a stack. | Note that I believe we have all the information we need to synthesize the actual URL to send the user to. |
@@ -352,12 +352,15 @@ class InteractiveProcess:
)
-@side_effecting
@dataclass(frozen=True)
-class InteractiveRunner:
+class InteractiveRunner(SideEffecting):
_scheduler: SchedulerSession
+ # Used to disable enforcement of effects in tests.
+ _enforce_effects: bool = True
def run(self, re... | [BinaryPathRequest->[__init__->[SearchPath]],BashBinary->[SearchPath],remove_platform_information->[FallibleProcessResult],find_bash->[BinaryPathTest,BinaryPathRequest,BashBinary,from_request],get_bash->[BashBinaryRequest],fallible_to_exec_result_or_raise->[ProcessResult,ProcessExecutionFailure],InteractiveProcess->[fr... | Runs the local interactive process. | I think you don't need this check, since it's checked inside the `side_effected()` call? |
@@ -427,6 +427,7 @@ export class FakeHistory {
throw new Error('can\'t go forward');
}
this.index = newIndex;
+ this.win.eventListeners.fire({type: 'popstate'});
}
/**
| [No CFG could be retrieved] | A class that implements history for a page. A class that implements a standard un - indexed array of objects with a unique identifier for the. | `popstate` should fire on all history navigation. @dvoytenko you also seem to allow an optional `fireEvent` param for `pushState` and `replaceState`. These never actually fire so not sure what we try to test there, let me know if we should just drop them or keep them. Keeping them is not hurting but might give the impr... |
@@ -69,7 +69,7 @@ class TaskSchema(TaskMethodsMixin, VersionedSchema):
tags = fields.List(fields.String())
max_retries = fields.Integer(allow_none=True)
retry_delay = fields.TimeDelta(allow_none=True)
- timeout = fields.TimeDelta(allow_none=True)
+ timeout = fields.Integer(allow_none=True)
tri... | [TaskMethodsMixin->[create_object->[uuid4,get,str,setdefault,super],get_attribute->[getattr,super,isinstance]],TaskSchema->[FunctionReference,to_qualified_name,Integer,type,Boolean,UUID,List,String,Function,TimeDelta],ParameterSchema->[to_qualified_name,type,Boolean,UUID,JSONCompatible,List,String,Function],version] | Deserialize a matching task object. A ParameterSchema for a task s parameters. | This is actually an example of something we should create a new `VersionedSchema` for to maintain compatibility with prior versions of Prefect, but given that we are aware of all pre-0.4.0 deploys, i think it's ok for now ;) |
@@ -244,6 +244,10 @@ public abstract class AbstractMessageProcessorChain extends AbstractAnnotatedObj
this.flowConstruct = flowConstruct;
this.messageProcessorExecutionTemplate.setFlowConstruct(flowConstruct);
setFlowConstructIfNeeded(getMessageProcessorsForLifecycle(), flowConstruct);
+
+ if (flowCon... | [AbstractMessageProcessorChain->[fireNotification->[fireNotification],setFlowConstruct->[setFlowConstruct,getMessageProcessorsForLifecycle],addMessageProcessorPathElements->[getMessageProcessors,addMessageProcessorPathElements],setMessagingExceptionHandler->[setMessagingExceptionHandler],setMuleContext->[getMessageProc... | Sets the flowConstruct property. | Ideally see if there is a better place to do this? |
@@ -233,7 +233,7 @@ func TestAccAWSInstance_inEc2Classic(t *testing.T) {
})
}
-func TestAccAWSInstance_basic(t *testing.T) {
+func TestAccAWSInstance_atLeastOneOtherEbsVolume(t *testing.T) {
var v ec2.Instance
var vol *ec2.Volume
resourceName := "aws_instance.test"
| [ParallelTest,DeepEqual,PushBack,Setenv,TestCheckTypeSetElemNestedAttrs,TerminateInstances,StopInstances,TestCheckNoResourceAttr,TestCheckResourceAttrSet,RandInt,CreateVolume,New,RootModule,ComposeTestCheckFunc,Errorf,MustCompile,RandStringFromCharSet,Bool,ModifyInstanceAttribute,Join,TestMatchResourceAttr,DescribeInst... | TestAccAWSInstance_inEc2Classic tests if an instance is in the EC returns an error if the is not found. | Rename this as it is testing more than the absolute minimal configuration. |
@@ -181,6 +181,10 @@ abstract class Stats
else
{
$year=$startyear;
+ if (empty($conf->global->GRAPH_USE_FISCAL_YEAR)) {
+ $startmonth = 0;
+ }
+ if ($startmonth != 0) $year = $year - 1;
while($year <= $endyear)
{
$datay[$year] = $this->getAmountByMonth($year, $format);
| [Stats->[getNbByMonthWithPrevYear->[getNbByMonth],_getNbByYear->[free,fetch_row,query,num_rows],getAmountByMonthWithPrevYear->[getAmountByMonth],getAllByProductEntry->[getAllByProduct],_getAllByYear->[fetch_object,query,free,num_rows],_getAverageByMonth->[free,transnoentitiesnoconv,query,num_rows,fetch_row],_getAmountB... | Get amount by month with previous year get data from cache. | If $startmonth is 1 (january), we should have same resutl than if $conf->global->GRAPH_USE_FISCAL_YEAR is not set. But here we have a difference of 1 year due to next line. Can you check ? |
@@ -250,11 +250,7 @@ class NonValidatingChoiceField(forms.ChoiceField):
pass
-class ReviewAddonForm(happyforms.Form):
- addon_files = AddonFilesMultipleChoiceField(
- required=False,
- queryset=File.objects.none(), label=_lazy(u'Files:'),
- widget=forms.CheckboxSelectMultiple())
+cl... | [QueueSearchForm->[clean_application_id->[version_choices_for_app_id]],ThemeReviewForm->[save->[save]],ReviewAddonForm->[NonValidatingChoiceField,AddonFilesMultipleChoiceField]] | A ChoiceField that validates a single add - on. A boolean field that can be used to clear the admin review flag. | We don't want the file checkboxes anymore, so we don't need a different form for reviewing a new Addon (with all its files) or an update. |
@@ -68,6 +68,9 @@ func GetKubernetesEventHandlers(informerName, providerName string, announce chan
logNotObservedNamespace(newObj, eventTypes.Update)
return
}
+ if reflect.DeepEqual(oldObj, newObj) {
+ return
+ }
sendAnnouncement(eventTypes.Update, oldObj)
},
| [Msgf,ValueOf,Elem,FieldByName,String,Trace,Getenv,Debug] | getObjID returns a resource event handler that sends an announcement to the OSM. | This does remove the eventual consistency mechanism. Would be good to call it out in the PR description and code. |
@@ -138,7 +138,7 @@ namespace wallet_args
log_path = command_line::get_arg(vm, arg_log_file);
else
log_path = mlog_get_default_log_path("monero-wallet-cli.log");
- mlog_configure(log_path, false);
+ mlog_configure(log_path, log_to_console);
if (!vm["log-level"].defaulted())
{
m... | [char->[i18n_translate],main->[mlog_configure,i18n_get_language,get_arg,mlog_set_log,vm,MINFO,_CrtSetDbgFlag,command_line_parser,getenv,i18n_set_language,run,add,mlog_get_default_log_path]] | This is the main entry point for the CRT - CRT - CRT - CR This function is used to run the command line error handling. MINFO - Default log level. | I don't understand this patch based on the title. Is this the offending line? Why would `wallet-rpc` log to console, but not `wallet-cli`. Or ? |
@@ -968,7 +968,7 @@ public class KafkaIO {
// Wait for longer than normal when fetching a batch to improve chances a record is available
// when start() returns.
- nextBatch(START_NEW_RECORDS_POLL_TIMEOUT);
+ nextBatch(NEW_RECORDS_POLL_TIMEOUT);
return advance();
}
| [KafkaIO->[TypedWithoutMetadata->[apply->[apply]],KafkaWriter->[setup->[apply],teardown->[close]],UnboundedKafkaSource->[generateInitialSplits->[apply]],Write->[updateProducerProperties->[updateKafkaProperties]],TypedWrite->[apply->[apply]],TypedRead->[unwrapKafkaAndThen->[apply->[apply]],withWatermarkFn->[withWatermar... | Start reading from the latest record in the partition. Reads next record in the partition. if b = true then we can get next batch. | actually, can you remove this arg for nextBatch and use `NEW_RECORDS_POLL_TIMEOUT` diretly inside nextBatch(). |
@@ -324,7 +324,7 @@ func (l *LocalWorkspace) Stack(ctx context.Context) (*StackSummary, error) {
func (l *LocalWorkspace) CreateStack(ctx context.Context, stackName string) error {
args := []string{"stack", "init", stackName}
if l.secretsProvider != "" {
- args = append(args, fmt.Sprintf("--secrets-provider=%s", ... | [ExportStack->[SelectStack],runPulumiCmdSync->[PulumiHome,WorkDir,GetEnvVars],SetAllConfig->[SetConfig],RefreshConfig->[GetAllConfig],RemoveAllConfig->[RemoveConfig],ImportStack->[SelectStack],SaveStackSettings,SaveProjectSettings] | CreateStack creates a new stack in the workspace. | What about the SelectStack method? |
@@ -2559,7 +2559,7 @@ module Engine
def ability_right_time?(ability, time, on_phase, passive_ok, strict_time)
return true unless @round
return true if time == 'any' || ability.when?('any')
- return (on_phase == ability.on_phase) || (on_phase == 'any') if on_phase
+ return (on_phas... | [Base->[format_revenue_currency->[format_currency],process_to_action->[process_action],end_game!->[format_currency],current_entity->[current_entity],par_price_str->[format_currency],log_cost_discount->[format_currency],float_corporation->[format_currency],after_par->[format_currency,place_home_token,all_companies_with_... | Checks if the current entity is the right time for the given ability. if the task has ability_time_is_or_start? - if it. | Shouldn't it be ability.on_phase == 'any' as well then? |
@@ -111,7 +111,9 @@ public class IdentityWindowFn<T> extends NonMergingWindowFn<T, BoundedWindow> {
getClass().getCanonicalName()));
}
+ // CHECKSTYLE.OFF: MissingDeprecated
@Deprecated
+ // CHECKSTYLE.ON: MissingDeprecated
@Override
public Instant getOutputTime(Instant inputTimestamp, Boun... | [IdentityWindowFn->[assignWindows->[singleton,window],getDefaultWindowMappingFn->[getCanonicalName,UnsupportedOperationException,format],isCompatible->[getCanonicalName,UnsupportedOperationException,format],verifyCompatibility->[getCanonicalName,UnsupportedOperationException,format]]] | Get the output time of a side input window. | I actually don't think this should be deprecated. |
@@ -2232,7 +2232,7 @@ func (a *apiServer) rcPods(rcName string) ([]v1.Pod, error) {
Kind: "ListOptions",
APIVersion: "v1",
},
- LabelSelector: metav1.FormatLabelSelector(metav1.SetAsLabelSelector(labels(rcName))),
+ LabelSelector: metav1.FormatLabelSelector(metav1.SetAsLabelSelector(map[string]string... | [DeletePipeline->[ListPipeline],validateJob->[validateInput],CreatePipeline->[validatePipeline,authorizePipelineOp],InspectDatum->[getDatum,InspectJob],RestartDatum->[InspectJob],GarbageCollect->[ListPipeline],listDatum->[InspectJob],ListJobStream->[listJob],resolveCommit->[getPachClient],ListJob->[listJob],validatePip... | rcPods returns all pods in a given rc. | This is the bug fix, yea? Otherwise you'd specify the worker component and get no logs. |
@@ -96,13 +96,14 @@ final class Http2ControlFrameLimitEncoder extends DecoratingHttp2ConnectionEncod
// First notify the Http2LifecycleManager and then close the connection.
lifecycleManager.onError(ctx, true, exception);
ctx.close();
+ return null;
... | [Http2ControlFrameLimitEncoder->[writeSettingsAck->[writeSettingsAck],lifecycleManager->[lifecycleManager],writePing->[writePing],writeRstStream->[writeRstStream]]] | Handles outstanding control frames. | Did you mean to throw the `Http2Exception` here? Otherwise it's not clear why this method now `throws Http2Exception`. |
@@ -755,7 +755,7 @@ static void xtrans_markesteijn_interpolate(float *out, const float *const in,
for(int col = (left - sgcol + pad_rb_g + 2) / 3 * 3 + sgcol; col < mcol - pad_rb_g; col += 3)
{
float(*rfx)[3] = &rgb[0][row - top][col - left];
- int h = FCxtrans(row + yoff +... | [No CFG could be retrieved] | Find the green values of closer pixels. Interpolate red for blue pixels and vice versa. | @dtorop this was the only case where the increment wasn't a multiple of 6. Is it a typo or as intended? |
@@ -333,12 +333,12 @@ def prepare_managed_process(p):
# build this process
cloudlog.info("building %s" % (proc,))
try:
- subprocess.check_call(["make", "-j4"], cwd=os.path.join(BASEDIR, proc[0]))
+ subprocess.check_call(["scons", "u", "-j4", "."], cwd=os.path.join(BASEDIR, proc[0]))
except... | [main->[uninstall,manager_init,manager_thread,manager_prepare,cleanup_all_processes],manager_thread->[start_daemon_process,send_managed_process_signal,kill_managed_process,start_managed_process],kill_managed_process->[join_process],manager_prepare->[prepare_managed_process],cleanup_all_processes->[kill_managed_process]... | Prepare a managed process for execution. | @pd0wm thoughts on removing this? it hasn't done anything for several versions and fixing it will noticeably slow startup |
@@ -114,13 +114,16 @@ class CanvasController < ApplicationController
# Make sure move parameter is valid
to_move = {}
- if can_move_modules(@experiment) && update_params[:move].present?
+ if update_params[:move].present?
begin
to_move = JSON.parse(update_params[:move])
# Okay,... | [CanvasController->[load_vars->[any,render,respond_to,active_modules,html,find_by_id],edit->[render],full_zoom->[render],check_view_canvas->[can_view_experiment],update_params->[permit],check_edit_canvas->[can_edit_canvas],update->[create,is_int?,can_move_modules,any?,full_name,name,is_a?,can_archive_modules,update_can... | Updates the n - ary node based on the input parameters. Checks if the user has permission to add a and if so updates it if so. This method is called by the administration area to update the n - node node in the. | here you have the action for the module but above in core_api_controller you use a method for experiments can_read_experiment?(task.experiment) Can you make can_read_module and use it ? |
@@ -207,7 +207,7 @@ to serve all files under specified web root ({0})."""
old_umask = os.umask(0o022)
try:
- with open(validation_path, "wb") as validation_file:
+ with safe_open(validation_path, mode="wb", chmod=0o644) as validation_file:
validation_file.write... | [Authenticator->[cleanup->[_get_validation_path],_perform_single->[_get_validation_path]]] | Save validation file for a single Achall. | I see a couple changes from `open` to `safe_open` in this PR; what was your decision-making process for which ones to change and which ones to leave? |
@@ -35,6 +35,7 @@ import (
"github.com/gardener/gardener/plugin/pkg/global/deletionconfirmation"
"github.com/gardener/gardener/plugin/pkg/global/resourcereferencemanager"
shootdnshostedzone "github.com/gardener/gardener/plugin/pkg/shoot/dnshostedzone"
+ "github.com/gardener/gardener/plugin/pkg/shoot/ingressaddond... | [validate->[NewAggregate,Validate,New],complete->[Register],run->[PrepareRun,AddPostStartHook,New,Start,config,Run,Complete],config->[BuildConfigFromFlags,NewDefinitionNamer,DefaultOpenAPIConfig,New,NewSharedInformerFactory,NewForConfig,NewRecommendedConfig,Get,ApplyTo,DefaultSwaggerConfig],AddFlags,Sprintf,validate,co... | Package names of the available packages NewCommandStartGardenerAPIServer creates a new command object that can be used to start. | What about a better name, e.g. `ingressdns` or `ingressaddondns`? |
@@ -421,6 +421,8 @@ func (p *CommandLine) Parse(args []string) (cmd Command, err error) {
if err = p.cmd.ParseArgv(p.ctx); err != nil {
libkb.G.Log.Errorf("In '%s': %s", p.name, err)
cmd = &CmdSpecificHelp{CmdBaseHelp{p.ctx}, p.name}
+ } else if _, err = p.GetRunMode(); err != nil {
+ cmd = &CmdSpecificHelp{Cm... | [GetSocketFile->[GetGString],GetPidFile->[GetGString],Parse->[ParseArgv,Run],GetMerkleKIDs->[GetGString],GetUserCacheSize->[GetGInt],Run->[MakeHelpPrinter],GetGpgOptions->[GetGString],GetGpg->[GetGString],GetSecretKeyringTemplate->[GetGString],GetProofCacheSize->[GetGInt],GetDaemonPort->[GetGInt],GetTimers->[GetGString... | Parse parses the command line arguments and returns a Command. | This seems weird to duplicate code? |
@@ -30,6 +30,8 @@ namespace Content.Shared.GameObjects.Components.Chemistry
set => _maxVolume = value; // Note that the contents won't spill out if the capacity is reduced.
}
+ public Solution ContainedSolution => _containedSolution;
+
/// <summary>
/// The total vol... | [SolutionComponent->[HandleComponentState->[HandleComponentState],Shutdown->[Shutdown],ExposeData->[ExposeData],Startup->[Startup]]] | A component that represents a single system - wide object. Expose the data of an object from a serializer. | Making the solution object public means that any code can completely bypass the the SolutionComponent functions when adding or removing a reagent. This is a really bad idea, and breaks general OOP encapsulation rules. You need to design it so that outside code has to ask the SolutionComponent for info about the solutio... |
@@ -79,6 +79,17 @@ class TestTargetSetup:
__test__ = False
+def get_packages_to_cover(
+ test_target: PythonTestsAdaptor,
+ source_root_stripped_file_paths: Tuple[str, ...],
+) -> Tuple[str, ...]:
+ if hasattr(test_target, 'coverage'):
+ return tuple(sorted(set(test_target.coverage)))
+ return tuple(sorte... | [setup_pytest_for_target->[get_coveragerc_input,get_packages_to_cover,calculate_timeout_seconds,TestTargetSetup]] | Get packages to cover. | Bad rebase. This already exists. |
@@ -354,6 +354,8 @@ class Conduit(CMakePackage):
if cxxflags:
cfg.write(cmake_cache_entry("CMAKE_CXX_FLAGS", cxxflags))
fflags = ' '.join(spec.compiler_flags['fflags'])
+ if '%cce' in self.spec:
+ fflags += "-ef"
if fflags:
cfg.write(cmake_cache_ent... | [Conduit->[hostconfig->[_get_host_config_path,cmake_cache_entry]]] | This method creates a host - config file that specifies all of the options used to configure and Private functions - write cmake_cache_entry Add missing flags to cmake_cache_entry Add missing cmake cache entries to cmake config file. | This needs a space in the front. |
@@ -24,6 +24,7 @@
package hudson;
import edu.umd.cs.findbugs.annotations.NonNull;
+import hudson.security.ACLContext;
import jenkins.util.SystemProperties;
import hudson.PluginWrapper.Dependency;
import hudson.init.InitMilestone;
| [PluginManager->[createDefault->[create],doPlugins->[getDisplayName],install->[install,getPlugin],dynamicLoad->[run,dynamicLoad],getPlugin->[getPlugin,getPlugins],PluginUpdateMonitor->[ifPluginOlderThenReport->[getPlugin]],addDependencies->[addDependencies],loadDetachedPlugins->[loadPluginsFromWar],getPluginVersion->[g... | Permission is hereby granted to all copies of a Software and to permit persons to access Imports all packages from the Hudson package. | NIT: This is randomly placed within all other imports?! |
@@ -51,11 +51,11 @@ namespace NServiceBus.Transports
/// <summary>
/// A list of multicast transport operations.
/// </summary>
- public IEnumerable<MulticastTransportOperation> MulticastTransportOperations { get; }
+ public List<MulticastTransportOperation> MulticastTransportOp... | [TransportOperations->[MessageType,Add,nameof,Message,DeliveryConstraints,Destination,Name,AddressTag,Length,RequiredDispatchConsistency]] | - A list of multicast and unicast transport operations. | I think returning arrays would be nicer from an API perspective for scenarios where we know the list is "readonly" but I'm ok too with lists since this is not on the basic API and it would probably mean additional allocations. |
@@ -9,10 +9,17 @@ def add_subparser(parser: argparse._SubParsersAction) -> argparse.ArgumentParser
subparser.add_argument('--port', type=int, default=8000)
subparser.add_argument('--workers', type=int, default=1)
+ subparser.add_argument('--configfile', type=argparse.FileType('r'), default=None, help="pa... | [add_subparser->[add_parser,set_defaults,add_argument],serve->[run]] | Add a subparser to the given parser. | How do I read this setting if I name it `config-file`? |
@@ -46,7 +46,9 @@ class S3Download(Task):
- key (str): the name of the Key within this bucket to retrieve
- aws_credentials_secret (str, optional): the name of the Prefect Secret
that stores your AWS credentials; this Secret must be a JSON string
- with two keys... | [S3Upload->[__init__->[super],run->[uuid4,client,BytesIO,str,ValueError,encode,upload_fileobj,Secret],defaults_from_attrs],S3Download->[__init__->[super],run->[download_fileobj,client,BytesIO,decode,seek,read,ValueError,Secret],defaults_from_attrs]] | This method is called by the base class to retrieve a single from the S3. | Reading this closely, is it actually a "JSON string"? Or just JSON |
@@ -1 +1,8 @@
#include "helix.h"
+#include "ssd1306.h"
+
+#ifdef SSD1306OLED
+bool process_record_kb(uint16_t keycode, keyrecord_t *record) {
+ return process_record_gfx(keycode,record) && process_record_user(keycode, record);
+}
+#endif
\ No newline at end of file
| [No CFG could be retrieved] | Helix. h. | On the Helix keyboard, it looks like customary for helix.c to be empty and put the code in rev1/rev1.c, rev2/rev2.c and pico/pico.c. I think it is better to ask @MakotoKurauchi. |
@@ -57,6 +57,7 @@ class Annotations(object):
the annotations with raw data if their acquisiton is started at the
same time.
+
Notes
-----
If ``orig_time`` is None, the annotations are synced to the start of the
| [_combine_annotations->[Annotations],_read_annotations->[Annotations],_annotations_starts_stops->[_sync_onset],Annotations->[delete->[delete],append->[append]],_sync_onset->[_handle_meas_date]] | Initialize a new object. This function takes the onset duration and description and returns the corresponding time - object. | I think you add an extra line, by mistake. |
@@ -888,6 +888,7 @@ akey_fetch_single(daos_handle_t toh, const daos_epoch_range_t *epr,
goto out;
*rsize = rbund.rb_gsize;
+ ioc->ic_io_size += rbund.rb_gsize;
out:
return rc;
}
| [No CFG could be retrieved] | -DER_INPROGRESS - if the key is not found -DER_TX_RE This function is called when the bio_iov does not have a valid checksum. | you probably want to use rb_rsize, which is the local record size, and rb_gsize is the sum of the rec size from all shards of ec obj. |
@@ -74,13 +74,17 @@ public class GameEnginePropertyReader extends PropertyFileReader {
public MaxMemorySetting readMaxMemory() {
final String value = super.readProperty(GameEngineProperty.MAX_MEMORY);
- if(Strings.nullToEmpty(value).isEmpty()) {
+ if (Strings.nullToEmpty(value).isEmpty()) {
retur... | [GameEnginePropertyReader->[readLobbyPropertiesBackupFile->[readProperty],readLobbyPropertiesUrl->[readProperty,getUrlFollowingRedirects,NetworkFetchException],readEngineVersion->[readProperty,Version],getUrlFollowingRedirects->[getResponseCode,openConnection,toString,getHeaderField,URL],readMaxMemory->[readProperty,of... | read max memory setting. | Checkstyle: "Abbreviation in name 'useExperimentalUI' must contain no more than '2' consecutive capital letters." |
@@ -13,6 +13,7 @@ class UserNotifyEvent:
ORDER_PAYMENT_CONFIRMATION = "order_payment_confirmation"
ORDER_CANCELED = "order_canceled"
ORDER_REFUND_CONFIRMATION = "order_refund_confirmation"
+ SEND_GIFT_CARD = "send_gift_card"
CHOICES = [
ACCOUNT_CONFIRMATION,
| [No CFG could be retrieved] | UserNotifyEvent - Class to handle UserNotifyEvents Enumerate all Notify Events of a user. | I would rename it to something like gift_card_confirmation or something. What do you think? |
@@ -0,0 +1,18 @@
+from contextlib import contextmanager
+
+from django.db import DatabaseError, IntegrityError, transaction
+
+
+@contextmanager
+def transaction_with_commit_on_errors():
+ """Perform transaction and raise an error in any occurred."""
+ error = None
+ with transaction.atomic():
+ try:
+ ... | [No CFG could be retrieved] | No Summary Found. | `IntegrityError` is a subclass of `DatabaseError`. |
@@ -807,6 +807,10 @@ func removeStack(t *testing.T, name string) {
}
func skipIfShort(t *testing.T) {
+ _, ok := os.LookupEnv("PULUMI_ACCESS_TOKEN")
+ if !ok {
+ t.Skipf("Skipping: PULUMI_ACCESS_TOKEN is not set")
+ }
if testing.Short() {
t.Skip("Skipped in short test run")
}
| [RemoveAll,TempDir,LoadProject,RemoveStack,Settings,NewObjectValue,Error,New,Short,Skip,Chdir,GetStack,Equal,Contains,CurrentUser,Parallel,NoError,Base,NewValue,MustMakeKey,Sprintf,Background,DetectProjectPathFrom,ParseStackReference,String,Run] | skipIfShort skips if the test run is in a short state. | It's not immediately clear to me why this is right to do in `skipIfShort` - how is this check related to whether the tests are running in "short" mode? Perhaps just the name of this function needs to change to `skipIfShortOrNoPulumiAccessToken`? |
@@ -687,7 +687,10 @@ namespace ProtoCore.DSASM
/// </summary>
private void StartCollection()
{
- sweepSet = new HashSet<int>(Enumerable.Range(0, heapElements.Count));
+ // We start from a clean sweepSet
+ sweepSet.Clear();
+
+ sweepSet.UnionWith(Enu... | [StackValueComparer->[GetHashCode->[GetHashCode]],HeapElement->[ExpandByAcessingAt->[ReAllocate,RightShiftElements]],Heap->[SetRoots->[StartCollection],GC->[SingleStep],FullGC->[SetRoots,SingleStep],AllocateInternal->[AddHeapElement],StackValue->[AddString,TryGetPointer],WriteBarrierForward->[RecursiveMark,TryGetHeapEl... | Start collection. | UnionWith seems to work fine for this (concat does not work for some reason) |
@@ -512,7 +512,11 @@ public class NetscalerElement extends ExternalLoadBalancerDeviceManagerImpl impl
});
HostVO host = _hostDao.findById(lbDeviceVo.getHostId());
- _agentMgr.reconnect(host.getId());
+ try {
+ _agentMgr.reconnect(host.getId());
+ } catch (Exception e ... | [NetscalerElement->[applyLBRules->[canHandle,isBasicZoneNetwok],isServiceEnabledInZone->[findGslbProvider],getLBHealthChecks->[getLBHealthChecks],implement->[canHandle,isBasicZoneNetwok],shutdown->[canHandle],configureNetscalerLoadBalancer->[configureNetscalerLoadBalancer],getZoneGslbProviderPublicIp->[findGslbProvider... | configure the network load balancer with the specified device ID check if there is a network device that can be used to make this device dedicated This method returns list of commands that are available in the network load balancers. | Cannot you use a more specific `catch` here? |
@@ -747,12 +747,14 @@ volatile bool Temperature::raw_temps_ready = false;
TERN_(DWIN_CREALITY_LCD, DWIN_Popup_Temperature(0));
TERN_(DWIN_CREALITY_LCD_ENHANCED, DWIN_PidTuning(PID_TUNING_TIMEOUT));
TERN_(EXTENSIBLE_UI, ExtUI::onPidTuning(ExtUI::result_t::PID_TUNING_TIMEOUT));
+ TERN_(H... | [No CFG could be retrieved] | This function calculates the next watch_temp and the next watch_temp_increase time SET HOTEND - HOTEND. | Text sent to the host in this manner should be translatable. Only serial messages associated with host protocols should be hardcoded in English. |
@@ -220,6 +220,15 @@ public class DefaultLimitSpec implements LimitSpec
sortingNeeded = !query.getGranularity().equals(Granularities.ALL) && query.getContextSortByDimsFirst();
}
+ if (!sortingNeeded) {
+ Map<String, Object> timestampFieldContext = GroupByQueryHelper.findTimestampResultField(query)... | [DefaultLimitSpec->[getCacheKey->[getCacheKey],Builder->[orderBy->[orderBy],build->[DefaultLimitSpec]],equals->[equals],makeComparator->[compare->[compare]],withOffsetToLimit->[isOffset,DefaultLimitSpec],build->[isOffset,isLimited],filterColumns->[DefaultLimitSpec]]] | Build a sequence of results based on the given query. This method is used to determine the sort and limit function to use for sorting and limiting. | Why not finding the index from the query context? |
@@ -0,0 +1,6 @@
+def handle_seo_fields(data):
+ """Extract and assign seo fields to given dictionary."""
+ seo_fields = data.pop('seo_fields', None)
+ if seo_fields:
+ data['seo_title'] = seo_fields.get('seo_title')
+ data['seo_description'] = seo_fields.get('seo_description')
| [No CFG could be retrieved] | No Summary Found. | Maybe `clean_seo_fields`? I know it is not really cleaning but it's always used as part of "clean". |
@@ -185,7 +185,7 @@ def destroy_network_rules_for_nic(vm_name, vm_ip, vm_mac, vif, sec_ips):
logging.debug("Ignoring failure to delete ebtable rules for vm: " + vm_name)
def get_bridge_physdev(brname):
- physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1"... | [network_rules_for_rebooted_vm->[check_domid_changed,default_network_rules_systemvm,rewrite_rule_log_for_vm,execute,delete_rules_for_vm_in_bridge_firewall_chain],can_bridge_firewall->[execute],verify_iptables_rules_for_bridge->[execute,get_br_fw],get_vm_id->[get_libvirt_connection],get_vifs->[virshdumpxml],add_network_... | Get the bridge s physdev. Delete any nexus in the vif. | Do we know what changed in Ubuntu 20.04? As the '-o' flag should make it stable to use on the CLI |
@@ -139,7 +139,7 @@ public class TestTableSchemaEvolution extends HoodieClientTestBase {
// Create the table
HoodieTableMetaClient.initTableType(metaClient.getHadoopConf(), metaClient.getBasePath(),
HoodieTableType.MERGE_ON_READ, metaClient.getTableConfig().getTableName(),
- metaClient.getArch... | [TestTableSchemaEvolution->[checkLatestDeltaCommit->[assertTrue,filterCompletedInstants,equals],getWriteConfig->[build],generateInsertsWithSchema->[generateInserts,convertToSchema,equals],testSchemaCompatibilityBasic->[assertTrue,replace,isSchemaCompatible,assertFalse],testCopyOnWriteTable->[assertTrue,insertFirstBatch... | Test MOR table. This method is used to insert records with a devolved schema and insertBatch inserts records with Updates records in the dataset. This method checks that all records in the failedRecords list are allowed. | passing null is also something we can avoid if needed.. |
@@ -48,7 +48,7 @@ class StructuralResponseFunctionTestFactory(KratosUnittest.TestCase):
self.problem_name = parameters["problem_data"]["problem_name"].GetString()
model = KratosMultiphysics.Model()
- self.response_function = structural_response_function_factory.CreateResponseFunct... | [TestStrainEnergyResponseFunction->[test_execution->[_calculate_response_and_gradient]],TestAdjointStrainEnergyResponseFunction->[test_execution->[_calculate_response_and_gradient]],TestAdjointDisplacementResponseFunction->[test_execution->[_calculate_response_and_gradient]],TestAdjointStressResponseFunction->[test_exe... | This method initializes the object with the values and gradient of the object. | @MFusseder can you have a look if you need the backward-compatibility here? If so i can add a deprecation warning for `kratos_response_settings`. |
@@ -864,10 +864,15 @@ class ParDo(PTransformWithSideInputs):
fn, args, kwargs, si_tags_and_types, windowing = pickler.loads(
pardo_payload.do_fn.spec.payload)
if si_tags_and_types:
- raise NotImplementedError('deferred side inputs')
+ raise NotImplementedError('explicit side input data')
... | [_GroupAlsoByWindow->[from_runner_api_parameter->[_GroupAlsoByWindow]],Map->[_fn_takes_side_inputs,FlatMap],CombineValuesDoFn->[process->[merge_accumulators,create_accumulator,add_inputs,extract_output,apply]],Flatten->[get_windowing->[Windowing],from_runner_api_parameter->[Flatten]],_GroupByKeyOnly->[from_runner_api_p... | Create a ParDo object from a runner API parameter. | <!--new_thread; commit:3dfe862220afbc5e57d7ac674a329cb5e66164cf; resolved:0--> do we need to sort? |
@@ -1,4 +1,8 @@
-namespace NServiceBus.Core.Tests.Routing
+
+using NServiceBus;
+using System;
+
+namespace NServiceBus.Core.Tests.Routing
{
using System.Collections.Generic;
using System.Linq;
| [RoutingSettingsTests->[Task->[EqualTo,nameof,RetrieveRoutingTargets,That,Count,RouteToEndpoint,Endpoint,GetExecutingAssembly,GetDestinationsFor,Settings],RetrieveRoutingTargets->[SelectMany]]] | RoutingSettingsTests. Declarative services for message destination. | needs a cleanup |
@@ -143,8 +143,10 @@ func TestK8sVars(t *testing.T) {
"apiVersionManagedIdentity": "2015-08-31-preview",
"apiVersionNetwork": "2018-08-01",
"apiVersionStorage": "2018-07-01",
+ "applicationInsightsKey": "906ba2b3-f3b7-4cbe-ba9f-885d6982de43", // should be DefaultApplicat... | [SetPropertiesDefaults,GetCustomCloudIdentitySystem,Error,BoolPtr,GetPrimaryScaleSetName,Sprintf,GetSupportedKubernetesVersion,MarshalIndent,Errorf,Fatal,Diff,GetCustomCloudAuthenticationMethod] | This function returns a list of variables that can be used to configure a Kubernetes cluster. Parameters for GetAgentPool1osImage. | @devigned I can't seem to DefaultApplicationInsightsKey from the api pkg here. Is there something i need to do to refresh to version of the package that is getting imported? |
@@ -18,6 +18,7 @@ class TestResult:
status: Status
stdout: str
stderr: str
+ coverage_digest: Digest
# Prevent this class from being detected by pytest as a test class.
__test__ = False
| [TestResult->[from_fallible_execute_process_result->[TestResult]]] | Creates a TestResult object from a union of a testable target type. | This should probably be `Optional[Digest]`. Also, do you know how other languages handle coverage? Do they also generate files? I'm wondering if this change would be generalizable to something like Junit. A quick scan of how Junit, Mocha, and/or Scalatest do test coverage would be helpful. |
@@ -53,13 +53,15 @@ import org.slf4j.LoggerFactory;
import java.lang.reflect.InvocationTargetException;
import java.net.URL;
-import java.util.ArrayList;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.HashMap;
import java.util.Collections;
+import java.util.Set;
import java.util.HashSet;
i... | [StandardControllerServiceNode->[verifyCanDisable->[verifyCanDisable,getReferences],invokeDisable->[getControllerServiceImplementation],getInvocationHandler->[getInvocationHandler],verifyCanClearState->[verifyCanUpdate],enable->[run->[isActive,enable,getControllerServiceImplementation]],reload->[getBundleCoordinate,rel... | Imports the given component node. Provider - the Provider for the Service. | can you keep alphabetical order here? weird that checkstyle is passing nonetheless... |
@@ -411,7 +411,7 @@ namespace System.Net.Security
if (_framing == Framing.Unified)
{
- _framing = DetectFraming(message.Payload, message.Payload.Length);
+ _framing = DetectFraming(new Span<byte>(message.Payload, 0, message.Payload.Length));
... | [SslStream->[FinishHandshake->[SetException,FinishHandshakeRead],ReceiveBlob->[SendBlob],ForceAuthentication->[SetException],CheckEnqueueRead->[CheckOldKeyDecryptedData],ConsumeBufferedBytes->[ReturnReadBufferIfEmpty],CopyDecryptedData->[ReturnReadBufferIfEmpty],SendAuthResetSignal->[SetException],CheckEnqueueReadAsync... | Send a blob. | You defined DetectFraming to take a ReadOnlySpan... it'd be better then to construct a ReadOnlySpan rather than Span here. |
@@ -5044,7 +5044,10 @@ class PipelineOptimizer(object):
new_grad_name = name + "@MERGED"
self._rename_arg(op, name, new_grad_name)
- def _accumulate_gradients(self, block, pp_allreduce_in_optimize=False):
+ def _accumulate_gradients(self,
+ block,
+... | [MomentumOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],PipelineOptimizer->[_add_op_device_attr->[_add_op_device_attr_for_op,_get_op_device_attr],_add_sub_blocks->[_create_vars],_rename_gradient_var_name->[_is_optimize_op,_rename_arg],_add_op_device_attr_f... | Create a new name for the gradients of the parameters. backward op for the n - batch optimization. Gradient of the last non - zero node in the network. | should explain the suffix for gradname for later maintainer, we now have two many suffix for grad, immediately grad, accumulated grad, casted grad, etc |
@@ -45,8 +45,11 @@ static void recycle_fn(scheduled_fn_t* fn)
sLastUnused = fn;
}
-bool schedule_function(std::function<void(void)> fn)
+IRAM_ATTR // called from ISR
+bool schedule_function_us(mFuncT fn, uint32_t repeat_us)
{
+ InterruptLock lockAllInterruptsInThisScope;
+
scheduled_fn_t* item = get_fn... | [schedule_function->[get_fn],run_scheduled_functions->[mFunc,recycle_fn]] | recycle_fn - recycle a function that was not previously scheduled. | Remove InterruptLock from get_fn, non-recursive locks fail on this construct, and it's redundant in any case. |
@@ -271,3 +271,13 @@ void Address::print(std::ostream *s) const
else
*s << serializeString() << ":" << m_port;
}
+
+bool Address::isLocalhost() const {
+ if (isIPv6()) {
+ static const unsigned char localhost_bytes[] =
+ { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1 };
+
+ return memcmp(m_address.ipv6.sin... | [Resolve->[memset,setAddress,ResolveError,getBool,gai_strerror,getaddrinfo,freeaddrinfo],operator==->[memcmp],print->[serializeString],setAddress->[memcpy,memset,htonl],serializeString->[ntohl,itos,inet_ntop,str], memset->[memset,setAddress,setPort],isZero->[memcmp]] | Print the const nannanonon network address. | Needs either brackets for the code block below (style guidelines) or remove `else` (returns anyway). |
@@ -260,8 +260,13 @@ class DeviceFunctionTemplate(serialize.ReduceMixin):
Returns the `CompileResult`.
"""
if args not in self._compileinfos:
+ nvvm_options = {
+ 'opt': 3 if self.opt else 0,
+ 'debug': self.debug,
+ }
+
cres = ... | [CUDABackend->[__init__->[__init__]],CreateLibrary->[__init__->[__init__]],DeviceFunction->[__init__->[compile_cuda]],_Kernel->[launch->[load_symbol],_prepare_args->[_prepare_args],__init__->[compile_cuda]],compile_ptx->[compile_cuda],DeviceFunctionTemplate->[inspect_llvm->[compile],compile->[compile_cuda],inspect_ptx-... | Compile the function for the given argument types. | Whilst this replicates the `opt` behaviour in `inspect_ptx` is this now changing the default optimisation behaviour for callers of this method? Was it just being ignored before/something else would override it (direct inlining)? |
@@ -1138,8 +1138,9 @@ function elgg_http_build_url(array $parts, $html_encode = true) {
$port = isset($parts['port']) ? ":{$parts['port']}" : '';
$path = isset($parts['path']) ? "{$parts['path']}" : '';
$query = isset($parts['query']) ? "?{$parts['query']}" : '';
+ $fragment = isset($parts['fragment']) ? "#{$part... | [elgg_trigger_event->[trigger],forward->[get],elgg_dump->[dump],_elgg_shutdown_hook->[getFile,getMessage,getLine,getTraceAsString],elgg_batch_disable_callback->[disable],elgg_register_event_handler->[registerHandler],elgg_register_js->[setPath,setShim],elgg_unregister_event_handler->[unregisterHandler],_elgg_php_except... | build url from array of parts. | This is new, but I think it's not controversial. |
@@ -95,9 +95,11 @@ LANGUAGES = [
("is", "Icelandic"),
("it", "Italian"),
("ja", "Japanese"),
+ ("km", "Khmer"),
("ko", "Korean"),
("lt", "Lithuanian"),
("mn", "Mongolian"),
+ ("my", "Burmese"),
("nb", "Norwegian"),
("nl", "Dutch"),
("pl", "Polish"),
| [get_list->[strip,split],get_bool_from_env->[literal_eval,ValueError,format],get_host->[get_current],timedelta,join,config,warn,CeleryIntegration,int,init,get_list,iter_entry_points,parse,append,dirname,get_random_secret_key,__import__,setdefault,format,normpath,Config,get_currency_fraction,ImproperlyConfigured,DjangoI... | ALLOWED_CLIENT_HOSTS environment variable must be set when DEBUG = False. Returns a list of all possible names of the n - ary objects. | Are those languages supported by Django? If not, we cannot add them here as Django will crash when you try to activate them. |
@@ -1679,10 +1679,10 @@ def zeros_like(x, dtype=None, name=None):
Example:
- from tensorflow.keras import backend as K
- kvar = K.variable(np.random.random((2,3)))
- kvar_zeros = K.zeros_like(kvar)
- K.eval(kvar_zeros)
+ >>> from tensorflow.keras import backend as K
+ >>> kvar = K.variable(np.random.random... | [var->[cast],all->[cast],batch_set_value->[get_session,placeholder,dtype,get_graph],gradients->[gradients],argmin->[argmin],set_value->[get_session,placeholder,dtype,get_graph],repeat->[ndim],gather->[gather],binary_crossentropy->[_constant_to_tensor,log],resize_images->[constant,permute_dimensions,shape,int_shape],_br... | Instantiates an all - zeros variable of the same shape as another tensor. | Please instead use the ``` code block formatting syntax since these lines are not meant to be executed as part of our "doctest" suite (testable code examples in docstrings). |
@@ -94,6 +94,14 @@ class TestContainsLink(TestCase):
):
self.assertFalse(contains_symlink_up_to(target_path, base_path))
+ def test_path_object_and_str_are_valid_arg_types(self):
+ base_path = "foo"
+ target_path = os.path.join(base_path, "bar")
+ self.assertFalse(contain... | [test_get_inode->[PathInfo,get_inode],test_get_parent_dirs_up_to->[get_parent_dirs_up_to,set],TestContainsLink->[test_should_return_false_when_base_path_is_symlink->[contains_symlink_up_to,assertFalse,object,join],test_should_return_false_on_no_more_dirs_below_path->[contains_symlink_up_to,assert_called_once,assertFals... | Tests if base path is symlink. | For the record: Could also add a case for one str and one path_info, but the current one is good enough :) |
@@ -215,10 +215,15 @@ module Dependabot
def git_dependency_name(name, source)
git_source = Source.from_url(source[:url])
- if source[:ref]
+ if git_source && source[:ref]
name + "::" + git_source.provider + "::" + git_source.repo + "::" + source[:ref]
- else
+ el... | [FileParser->[get_proxied_source->[parse],lock_file_content->[parsed_file],source_type->[parse],parsed_file->[parse]]] | Returns a name for a git dependency. | SHA1 produces a 20 byte hash, and since we just need the `git_dependency_name` method to return a consistent, unique output given some inputs, it will probably work just fine here. |
@@ -17,10 +17,16 @@ from pants.engine.target import (
from pants.util.filtering import and_filters, create_filters
+class TargetGranularity(Enum):
+ all_targets = "all"
+ file_targets = "file"
+ base_targets = "base"
+
+
class FilterSubsystem(LineOriented, GoalSubsystem):
"""Filter the input targets... | [filter_targets->[filter_address_regex->[compile_regex],filter_tag_regex->[compile_regex],FilterGoal]] | Register options for a single . Create a Pattern object that matches the given regular expression. | As mentioned on the ticket, feedback on the naming of both of these concepts is welcome. "synthetic" targets are gone in v2, which might clear up the conceptual space to introduce the phrase "base". But it's possible that there is a better way to describe it. We've also referred to "file" targets as "sub" targets in so... |
@@ -74,3 +74,18 @@ export function debounce(fn, wait = 0, options = {}) {
}
};
}
+
+/**
+ * Returns the namespace for all global variables, functions, etc that we need.
+ *
+ * @returns {Object} the namespace.
+ *
+ * NOTE: After reactifying everything this should be the only place where
+ * we store eve... | [No CFG could be retrieved] | c a n c. | I'm not comfortable with `getJitsiMeetGlobalNS`, 'JitsiMeetGlobalNS', etc. I'd personally like us to have a `JitsiMeetJS` as the only global/namespace with sub-sections/namespaces for lib-jitsi-meet, app.bundle, util.js. |
@@ -300,7 +300,7 @@ public abstract class Cast<T> extends PTransform<PCollection<T>, PCollection<Row
@ProcessElement
public void process(
- @FieldAccess("filterFields") Row input, OutputReceiver<Row> r) {
+ @FieldAccess("filterFields") @E... | [Cast->[expand->[outputSchema,verifyCompatibility],Narrowing->[of->[Narrowing],apply->[apply],Fold->[accept->[path,create]],Fold],Widening->[of->[Widening],apply->[apply],Fold->[accept->[path,create]]],castValue->[castNumber,castValue,castRow],narrowing->[of],verifyCompatibility->[outputSchema,apply,validator],widening... | Expands a collection of rows into a new collection of rows where the field in the input. | Why both annotations? |
@@ -0,0 +1,13 @@
+# Copyright 2013-2020 Lawrence Livermore National Security, LLC and other
+# Spack Project Developers. See the top-level COPYRIGHT file for details.
+#
+# SPDX-License-Identifier: (Apache-2.0 OR MIT)
+
+import spack.main
+containerize = spack.main.SpackCommand('containerize')
+
+
+def test_command(con... | [No CFG could be retrieved] | No Summary Found. | This file is likely to be moved under `test/cmd` but before doing that I just wanted to show that by keeping it here we can move to a more localized scope the fixtures that are only needed to test container image generation (and avoid to put every fixture in `test/conftest.py`). Maybe it's something we could consider i... |
@@ -40,7 +40,7 @@ public class CachingCostProvider
private final Session session;
private final TypeProvider types;
- private final Map<PlanNode, PlanNodeCostEstimate> cache = new IdentityHashMap<>();
+ private final Map<PlanNode, PlanCostEstimate> cache = new IdentityHashMap<>();
public Cachin... | [CachingCostProvider->[getGroupCost->[getCumulativeCost]]] | Package private for testing purposes. Get the cost estimate of a node if it is a GroupReference. | Why not to rename to `CostEstimate`? or `SubPlanCostEstimate`? |
@@ -519,6 +519,7 @@ class SpackCommand(object):
self.parser = make_argument_parser()
self.command = self.parser.add_command(command_name)
self.command_name = command_name
+ self.log = log
def __call__(self, *argv, **kwargs):
"""Invoke this SpackCommand.
| [_profile_wrapper->[_invoke_command],SpackArgumentParser->[format_help_sections->[add_subcommand_group->[add_group],add_all_commands,index_commands,add_group,add_subcommand_group],add_command->[add_subparsers,add_parser],format_help->[format_help_sections]],print_setup_info->[shell_set],main->[_profile_wrapper,get_vers... | Create a new SpackCommand that invokes command_name when called. Get the last unknown node id. | No longer used |
@@ -81,7 +81,7 @@ feature 'LOA1 Single Sign On' do
it 'user can view and confirm personal key during sign up', :js do
allow(FeatureManagement).to receive(:prefill_otp_codes?).and_return(true)
user = create(:user, :with_phone)
- code = 'ABC1-DEF2-GHI3-JKL4'
+ code = 'ABC1-DEF2-GH13-JK14'
... | [sign_in_and_require_viewing_personal_key->[visit,env,login_as,on_next_request],enter_personal_key_words_on_modal->[fill_in],stub_personal_key->[to,instance_double,and_return],visit,email,password,create,let,to_not,feature,join,it,fill_in_credentials_and_submit,enter_personal_key_words_on_modal,friendly_name,root_url,t... | shows user the start page without accordion and requires user to view and confirm personal after session timeout. | What was the reason for changing this? |
@@ -1149,4 +1149,8 @@ public final class StorageContainerManager extends ServiceRuntimeInfoImpl
public String getClusterId() {
return getScmStorageConfig().getClusterID();
}
+
+ public HDDSLayoutVersionManager getLayoutVersionManager() {
+ return scmLayoutVersionManager;
+ }
}
| [StorageContainerManager->[getDatanodeRpcAddress->[getDatanodeRpcAddress],getRuleStatus->[getRuleStatus],stop->[unregisterMXBean,getSecurityProtocolServer,stop],createSCM->[StorageContainerManager],join->[getSecurityProtocolServer,join],getClientRpcPort->[getClientRpcAddress],start->[getSecurityProtocolServer,getDatano... | getClusterId - get the cluster id. | Nit. I don't see any usages for this yet. |
@@ -651,11 +651,11 @@ static int dai_comp_trigger_internal(struct comp_dev *dev, int cmd)
/* only start the DAI if we are not XRUN handling */
if (dd->xrun == 0) {
- /* start the DAI */
- dai_trigger(dd->dai, cmd, dev->direction);
ret = dma_start(dd->chan);
if (ret < 0)
return ret;
+ /* start... | [No CFG could be retrieved] | Internal function to trigger a component DAI or DAI DAI trigger. find the next valid start position and start the DAI. | @iuliana-prodan this is also the order ALSA uses to enable DAI and DMA, so in principle I agree with this change. Lets also hear Intel folks opinion on this as I remember they did the reverse change. |
@@ -44,9 +44,9 @@ public class CreateChannelCommand {
public static final int CHANNEL_NAME_MAX_LENGTH = 256;
public static final int CHANNEL_LABEL_MIN_LENGTH = 6;
- protected static final String CHANNEL_NAME_REGEX =
+ public static final String CHANNEL_NAME_REGEX =
"^[a-zA-Z][\\w\\d\\s\\-\\.\... | [CreateChannelCommand->[setParentChannel->[setParentChannel],create->[setAccess,setSupportPolicy,setSummary,setMaintainerPhone,setGloballySubscribable,setMaintainerName,setName,validateChannel,setLabel,setDescription,setMaintainerEmail]]] | Creates a new channel. Construct a new . | What about to remove the `CHANNEL_` prefix and keep only the variable name like `LABEL_REGEX` and `NAME_REGEX`? I see it is used as well for the project, so maybe we should keep it more abstract. I would also move the two variables to the `ValidationUtils.java` class instead, as they belong more to it and they can be r... |
@@ -1,5 +1,6 @@
/*global define*/
define([
+ './Check',
'./defaultValue',
'./defined',
'./DeveloperError',
| [No CFG could be retrieved] | A color is a color which is specified using red green blue and alpha values which range from Creates a Color instance from a cartesian object. | You can now remove `DeveloperError` from the list. |
@@ -217,6 +217,10 @@ type ProgramTestOptions struct {
// NoParallel will opt the test out of being ran in parallel.
NoParallel bool
+ // A list of commands to process before the pulumi up. Can be used for things like
+ // preparing a lambda
+ TestPreSteps map[string][]string
+
// PrePulumiCommand specifies a ca... | [testEdit->[PreviewAndUpdate,query],prepareNodeJSProject->[runYarnCommand],yarnLinkPackageDeps->[runYarnCommand],TestLifeCycleInitAndDestroy->[TestLifeCyclePrepare,TestCleanUp],TestLifeCycleDestroy->[GetStackNameWithOwner,GetDebugUpdates,runPulumiCommand],installPipPackageDeps->[runPipenvCommand],pipenvCmd->[getPipenvB... | QueryCommandlineFlags - Query the command line flags for a single target cloud. A bool with the value of the DebugUpdates property. | Any reason not to make this just a callback that can do whatever it wants? Seems to hat would be a fair bit more general purpose? Are we sure a large enough % of usecases will involve just shelling out that it makes sense to limit to that? |
@@ -167,10 +167,6 @@ describe('Filter: filter', function() {
expr = 10;
expect(filter(items, expr, comparator)).toEqual([items[2], items[3]]);
-
});
-
-
});
-
});
| [No CFG could be retrieved] | 1. 1. 2. 3. 4. 5. | removing these ones are okay, but try to keep 2 lines between each spec. |
@@ -161,7 +161,7 @@ public class AllView extends View {
for (Locale l : Locale.getAvailableLocales()) {
if (primaryView.equals(Messages._Hudson_ViewName().toString(l))) {
// bingo JENKINS-38606 detected
- LOGGER.log(Level.INFO,
+ ... | [AllView->[getItems->[getItems],doCreateItem->[doCreateItem]]] | Migrate the legacy primary AllView localized name to the new one. | This is a data migration |
@@ -1020,8 +1020,8 @@ func TestEthBroadcaster_ProcessUnstartedEthTxs_Locking(t *testing.T) {
// First one gets the lock
go func() {
- err = eb1.ProcessUnstartedEthTxs(key)
- assert.NoError(t, err)
+ err2 := eb1.ProcessUnstartedEthTxs(key)
+ assert.NoError(t, err2)
close(chFinish)
}()
| [EqualError,Value,GasPrice,NewAddress,Unlock,Hash,Exec,NewTransaction,MatchedBy,FindEthTxWithAttempts,ProcessUnstartedEthTxs,NewGomegaWithT,Now,NewStore,NewConfig,Eventually,Encode,AnythingOfType,IncrementNextNonce,Set,Row,UnixNano,Greater,ToInt,Error,Save,First,Should,ChainID,EncodeRLP,Cmp,New,To,NotNil,GetSignedTx,Le... | ethethethethethethethethethethethethethethethethetheth TestEthBroadcaster_GetNextNonce gets the next nonce for a Fixture key. | what about `txErr` instead of `err2`? |
@@ -34,7 +34,7 @@ import org.nuxeo.retention.service.RetentionManager;
/**
* @since 11.1
*/
-@Operation(id = AttachRetentionRule.ID, category = Constants.CAT_DOCUMENT, label = "Attach Retation Rule", description = "Attach the given retation rule to the input document.")
+@Operation(id = AttachRetentionRule.ID, cat... | [AttachRetentionRule->[run->[IllegalArgumentException,hasFacet,attachRule,isManual,NuxeoException,getAdapter]]] | Creates a new object which can be used to attach a retention rule to a given Attach a retention rule to the document. | Not sure about the guidelines for this kind of stuff. We are backporting something that was introduced for `11.1`. Should we keep the `@since 11.1`? @troger |
@@ -25,8 +25,8 @@ def search(request):
results = form.search(model_or_queryset=visible_products)
page = paginate_results(results, request.GET, settings.PAGINATE_BY)
else:
- page = form.no_query_found()
- query = form.cleaned_data['q']
+ page = []
+ query = form.cleaned_data.ge... | [search->[SearchForm,search,render,no_query_found,products_with_details,paginate_results,is_valid],paginate_results->[Paginator,Http404,get,page]] | Search for a single . | Shouldn't this also be a `Paginator` instance? |
@@ -63,7 +63,7 @@ func (cfg *RingConfig) RegisterFlags(f *flag.FlagSet) {
f.StringVar(&cfg.InstanceAddr, "ruler.ring.instance-addr", "", "IP address to advertise in the ring.")
f.IntVar(&cfg.InstancePort, "ruler.ring.instance-port", 0, "Port to advertise in the ring (defaults to server.grpc-listen-port).")
f.Stri... | [ToRingConfig->[DefaultValues],ToLifecyclerConfig->[Sprintf,GetInstancePort,GetInstanceAddr],RegisterFlags->[StringVar,Error,RegisterFlagsWithPrefix,Hostname,Log,DurationVar,Exit,Var,IntVar]] | RegisterFlags registers flags for ring returns a config object that can be used to configure a node in the lifec. | unrelated but a tiny typo I found while browsing. |
@@ -39,8 +39,7 @@ public class InlineJoinableFactory implements JoinableFactory
{
if (condition.canHashJoin() && dataSource instanceof InlineDataSource) {
final InlineDataSource inlineDataSource = (InlineDataSource) dataSource;
- final List<String> rightKeyColumns =
- condition.getEquiCondi... | [InlineJoinableFactory->[build->[of,canHashJoin,toList,IndexedTableJoinable,getRowsAsList,getRowSignature,empty,collect,rowAdapter]]] | Build a joinable based on the given data source and join condition. | You could probably do a similar simplification in LookupJoinMatcher (there's a part that checks that all the equikeys are the key column). |
@@ -212,9 +212,12 @@ public class RemoteExecutionTest implements Serializable {
(FnDataReceiver<? super WindowedValue<?>>) outputContents::add));
}
// The impulse example
- try (ActiveBundle<byte[]> bundle = processor.newBundle(outputReceivers)) {
+
+ try (ActiveBundle<byte[]> bundle =
+ ... | [RemoteExecutionTest->[kvBytes->[encodeToByteArray,of],testExecution->[getOutputTargetCoders,getValue,create,valueInGlobalWindow,size,fromExecutableStage,kvBytes,getRemoteInputDestination,put,accept,getProcessor,of,apply,getKey,synchronizedList,values,checkState,newBundle,toProto,entrySet,next,getProcessBundleDescripto... | Test execution. A method to assert that the output values of the target coder are in the global window. | In all your tests where you used BundleProgressHandler.unsupported(), shouldn't the try-with-resources on close invoke the BundleProgressHandler.onCompleted method and throw an UnsupportedOperationException? |
@@ -0,0 +1,17 @@
+class TimerService {
+ /**
+ * @param {function(): void} cb
+ * @param {number} [timeout]
+ */
+ delay(cb, timeout = 0) {
+ if (timeout > 0) {
+ setTimeout(cb, timeout);
+ } else {
+ // Use the async queue, because it'll run before the event queue:
+ Promise.resolve().then... | [No CFG could be retrieved] | No Summary Found. | Ditto: class vs object. |
@@ -570,11 +570,17 @@ namespace GraphLayout
/// </summary>
public HashSet<Edge> RightEdges = new HashSet<Edge>();
- public Node(Guid guid, double width, double height, double y, Graph ownerGraph)
+ /// <summary>
+ /// A list of note models which has this node as the closest node... | [Graph->[AssignLayers->[RemoveTransitiveEdges,AddToLayer],AddToLayer->[AddToLayer]]] | Relations for a node. - The y coordinate of the edge s left end. | Can we make `LinkedNotes` a private field and a `List<Note>` type? |
@@ -779,6 +779,7 @@ static btr_ops_t singv_btr_ops = {
.to_rec_free = svt_rec_free,
.to_rec_fetch = svt_rec_fetch,
.to_rec_update = svt_rec_update,
+ .to_rec_corrupt = svt_rec_corrupt,
.to_check_availability = svt_check_availability,
.to_node_alloc = svt_node_alloc,
};
| [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - Method to register a record of a specific type in the VOS BTR. vos_pool vos_pool_vos_pool. | can we not do this through rec_update for single value? It's only needed for single value, right? |
@@ -27,7 +27,7 @@ func newWalletHandler(xp rpc.Transporter, g *libkb.GlobalContext) *walletHandler
BaseHandler: NewBaseHandler(g, xp),
}
- h.Server = stellarsvc.New(g, h, remote.NewRemoteNet(g))
+ h.Server = stellarsvc.New(g, h)
return h
}
| [SecretUI->[getSecretUI],IdentifyUI->[NewRemoteIdentifyUI],NewContextified,New,NewRemoteNet] | SecretUI returns the secret UI for the given session. | Previously a new remoter was created for each local rpc server `stellarsvc.Server`. |
@@ -77,6 +77,16 @@ Rails.application.configure do
# Do not dump schema after migrations.
config.active_record.dump_schema_after_migration = false
+ # Use a different logger for distributed setups.
+ # require 'syslog/logger'
+ # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new 'app-name')
... | [new,compile,smtp_mailer_password,smtp_mailer_address,consider_all_requests_local,log_formatter,cache_classes,use,deprecation,smtp_mailer_authentication,dump_schema_after_migration,exception_notifications_to,smtp_mailer_domain,require,force_ssl,delivery_method,eager_load,blank?,smtp_mailer_port,smtp_mailer_enable_start... | Configure the Alaveteli configuration. A middleware that will send an email to the user if the exception notifications are enabled. | Line is too long. [83/80] |
@@ -83,7 +83,8 @@ final class BoundedReadEvaluatorFactory implements TransformEvaluatorFactory {
if (sourceEvaluators.putIfAbsent(transform, evaluatorQueue) == null) {
// If no queue existed in the evaluators, add an evaluator to initialize the evaluator
// factory for this transform
- B... | [BoundedReadEvaluatorFactory->[forApplication->[getTransformEvaluator],getTransformEvaluator->[poll,get,getSource,offer,putIfAbsent],BoundedReadEvaluator->[finishBundle->[getPipelineOptions,build,start,createReader,getOutput,getCurrent,getCurrentTimestamp,advance,timestampedValueInGlobalWindow,add,createRootBundle]]]] | Get the evaluator for the given transform. | We can add necessary configuration to support IDE's, but we shouldn't make negative changes to the code base. In this case, the unsafe-cast moves validation from compile-time to runtime. For this error, it appears that we can instead change the type signature for `AppliedPTransform` to `<InputT extends PInput, OutputT ... |
@@ -1630,3 +1630,17 @@ def set_index_var_of_get_setitem(stmt, new_index):
else:
raise ValueError("getitem or setitem node expected but received {}".format(
stmt))
+
+def is_namedtuple_class(c):
+ """check if c is a namedtuple class"""
+ if not isinstance(c, type):
+ retu... | [find_build_sequence->[require,get_definition],mk_loop_header->[mk_unique_var],mk_alloc->[mk_unique_var],rename_labels->[find_topo_order],gen_np_call->[get_np_ufunc_typ,mk_unique_var],set_index_var_of_get_setitem->[is_getitem,is_setitem],get_ir_of_code->[DummyPipeline],find_topo_order->[_dfs_rec->[_dfs_rec],_dfs_rec],f... | Set index var of get or setitem node. | Also has a `_make`, is this worth checking for? |
@@ -8,8 +8,8 @@
class Jetpack_Sync_Users {
static $user_roles = array();
- static function init() {
- if ( Jetpack::is_active() ) {
+ public function __construct( Connection_Manager $connection ) {
+ if ( $connection->is_active() ) {
// Kick off synchronization of user role when it changes
add_action( 's... | [No CFG could be retrieved] | Initialize the user role. | If the only thing we're using the connection for is to retrieve is_active in the constructor, why not pass that in as a boolean? Or just not load this class at all if the connection isn't active? |
@@ -1013,6 +1013,10 @@ func CheckCreateRepository(doer, u *User, name string) error {
return ErrReachLimitOfRepo{u.MaxRepoCreation}
}
+ if !doer.CanCreatePrivateRepo() {
+ return ErrReachLimitOfPrivateRepo{u.MaxPrivateRepoCreation}
+ }
+
if err := IsUsableRepoName(name); err != nil {
return err
}
| [ComposeDocumentMetas->[ComposeMetas],updateSize->[RepoPath],UpdateSize->[updateSize],Link->[FullName],getTemplateRepo->[IsGenerated],DescriptionHTML->[Error,ComposeMetas,HTMLURL],mustOwner->[getOwner,Error],APIURL->[FullName],GetReviewers->[getReviewers],UploadAvatar->[CustomAvatarPath],generateRandomAvatar->[CustomAv... | CheckCreateRepository returns clone link of repository. GetRepoInitFile returns the file path of the create repository options. | We should only be checking this if we're trying to create a private repository |
@@ -143,6 +143,7 @@ public class OmMetadataManagerImpl implements OMMetadataManager {
public static final String PREFIX_TABLE = "prefixTable";
public static final String TRANSACTION_INFO_TABLE =
"transactionInfoTable";
+ public static final String META_TABLE = "metaTable";
static final String[] ALL_T... | [OmMetadataManagerImpl->[isVolumeEmpty->[startsWith,getVolumeKey],isBucketEmpty->[startsWith,getBucketKey],initializeOmTables->[checkTableStatus],listVolumes->[startsWith,getVolumeKey],listBuckets->[startsWith,getVolumeKey,getBucketKey],loadDB->[loadDB],listKeys->[getOzoneKey,startsWith,getBucketKey],listAllVolumes->[s... | |----------------------------------------------------------------------| | Table - > Table - > Table. | Can we come up with a better name than `metaTable`? Maybe `versionTable`? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.