patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -1484,7 +1484,7 @@ def _onpick_sensor(event, fig, ax, pos, ch_names, show_names): def _close_event(event, fig): """Listen for sensor plotter close event.""" - if fig.lasso is not None: + if hasattr(fig, 'lasso') and fig.lasso is not None: fig.lasso.disconnect()
[_annotation_radio_clicked->[_get_active_radiobutton],tight_layout->[tight_layout],_handle_change_selection->[_set_radio_button],_annotate_select->[_get_active_radiobutton],_onclick_new_label->[_setup_annotation_fig,_set_annotation_radio_button],_helper_raw_resize->[_layout_figure],_mouse_click->[_plot_raw_time,_handle...
Listen for sensor plotter close event. Plots the missing nanoseconds.
Simpler as if getattr(fig, 'lasso') is not None
@@ -3909,9 +3909,11 @@ arc_evict_hdr(arc_buf_hdr_t *hdr, kmutex_t *hash_lock) */ hdr = arc_hdr_realloc(hdr, hdr_full_cache, hdr_l2only_cache); + *real_evicted += HDR_FULL_SIZE - HDR_L2ONLY_SIZE; } else { arc_change_state(arc_anon, hdr, hash_lock); arc_hdr_destroy(hdr); + *real_evicted +=...
[No CFG could be retrieved]
END of function arc_hdr_read count the number of bytes evicted from the buffer.
I think that we should keep bytes_evicted and real_evicted basically in sync. i.e. they should be tracking the same concept, just that real_evicted excludes the space referenced by ghost entries (that doesn't have any actual RAM associated with it). Therefore bytes_evicted should include the reduction in HDR size, as i...
@@ -184,7 +184,7 @@ class TrackController < ApplicationController end ) } } format.any { render :template => 'track/atom_feed',...
[TrackController->[track_set->[find_existing,url_name,authenticated?,receive_email_alerts,join,track_medium,save,tracking_user_id,id,params],atom_feed->[redirect_to,to_i,find,do_track_url,raise,track_medium],track_public_body->[redirect_to,create_track_for_public_body,nil?,url_name,new,raise,any?,find_by_url_name_with_...
This is the internal atom feed feed that displays the atom feed with a single object.
Layout/HashAlignment: Align the keys of a hash literal if they span more than one line.<br>Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
@@ -184,9 +184,12 @@ func (refresher *policyRefresher) updateEngineStore(ctx context.Context) error { switch { case vsn.Minor == api.Version_V1: // v2.1 - return refresher.engine.V2p1SetPolicies(ctx, policyMap, roleMap, ruleMap) + if err := refresher.engine.SetRules(ctx, ruleMap); err != nil { + return err + ...
[getRoleMap->[ListRoles,Infof],RefreshAsync->[Background,Warn],getPolicyMap->[ListPolicies,String,Infof],run->[C,Stop,Warn,NewTimer,Respond,Reset,Background,WithError,Info,refresh,Err,Done],getRuleMap->[Infof],refresh->[Warn,Debug,GetPolicyChangeID,WithError,updateEngineStore,WithFields],getIAMVersion->[MigrationStatus...
updateEngineStore updates the policy store in the engine store.
While it is nice to separate out the ruleMap in L192 below, this function is still being used to update both OPA cache and rules cache whenever either of them needs updating, so I fear it is still bogging down performance just as much. It is less efficient than if the two updates were done separately, as needed. (Of co...
@@ -57,8 +57,8 @@ func checkUsernameQuery(s string) (string, error) { } // Handler returns a request handler. -func Handler() *handler { - return &handler{ +func GetHandler() *Handler { + return &Handler{ Run: execRunner, FindKeybaseBinary: func() (string, error) { return findKeybaseBinary(keybaseBinary)
[Handle->[handleQuery,handleChat],handleQuery->[Environ,Run,FindKeybaseBinary,Command],handleChat->[NewReader,Environ,Run,FindKeybaseBinary,Command],Error->[Sprintf],Join,SplitN,MatchString,HasPrefix,Contains,New,HasSuffix,Errorf,Err,Scan,MustCompile,Split,Run,NewScanner,TrimSpace,Text]
checkUsernameQuery returns a function which checks if the given string is a valid username query. handleChat sends a message to a user.
FWIW I disagree with the linter warning in this case from a semantic perspective, but I assume we're not using a configurable linter so I guess the change it necessary. :/ IIRC it was something along the lines of "returning unexported concrete types which can be annoying to work with" or something silly like that, part...
@@ -61,6 +61,8 @@ import java.util.Collection; import java.util.List; import java.util.Map; +import static io.druid.query.QueryRunnerTestHelper.*; + /** */ @RunWith(Parameterized.class)
[TopNQueryRunnerTest->[testTopNWithFilter2OneDay->[of,build,TopNResultValue,DateTime,run,doubleValue,asList,assertExpectedResults],testTopNDimExtraction->[of,build,TopNResultValue,DateTime,run,asList,assertExpectedResults],testTopNWithFilter1->[of,build,TopNResultValue,DateTime,run,asList,assertExpectedResults],testTop...
Method to import all the classes that implement the TopNQueryRunner interface. Factory method for the TopNQueryRunnerFactory.
I'm against static imports. Especially when you make heavy use of Guava, there are multiple instances where things like `asList()` could be `Arrays.asList()` or it could be `Lists.asList()` or it could be `Ints.asList()` etc. Please don't use static imports.
@@ -1,7 +1,12 @@ <% if @protocolsio_general_error %> -$('#modal-import-json-protocol-preview').modal('hide'); + $('#modal-import-json-protocol-preview').modal('hide'); alert(' <%= t('my_modules.protocols.load_from_file_protocol_general_error', max: Constants::NAME_MAX_LENGTH, min: Constants::NAME_MIN_LENGTH) %...
[No CFG could be retrieved]
check if there is a file protocol with no error show modal and reload form.
Change from `success` to `warning` type of flash msg (so we get yellow flash msg).
@@ -294,6 +294,15 @@ public interface NetworkOrchestrationService { void finalizeUpdateInSequence(Network network, boolean success); + /** + * Adds hypervisor hostname to a file - hypervisor-host-name if the userdata + * service provider is ConfigDrive or VirtualRouter + * @param vm + * @par...
[No CFG could be retrieved]
Finalize update in sequence.
please remove or add description of use/reason for throwing
@@ -80,7 +80,7 @@ <div id="vomitReactionsBodyContainer" class="collapse hide" aria-labelledby="vomitReactionsHeader" data-parent="#vomitReactions"> <div class="card-body" style="overflow: scroll; max-height: 500px;"> <% @vomits.each do |reaction| %> - <% next if (reaction.reactable_type ==...
[No CFG could be retrieved]
Vomit Reactions render a hidden field with a link to the reactable path.
Seems to be the easiest way to check if a user was `banished`, but maybe this could be done with the new `BanishedUser` table as well.
@@ -506,6 +506,7 @@ GRAPHENE = { "saleor.graphql.middleware.OpentracingGrapheneMiddleware", "saleor.graphql.middleware.JWTMiddleware", "saleor.graphql.middleware.app_middleware", + "graphene_django.debug.DjangoDebugMiddleware", ], }
[get_list->[strip,split],get_bool_from_env->[literal_eval,ValueError,format],get_host->[get_current],timedelta,join,config,warn,CeleryIntegration,int,init,get_list,iter_entry_points,parse,append,dirname,get_random_secret_key,__import__,setdefault,format,normpath,Config,ImproperlyConfigured,DjangoIntegration,get,get_boo...
The maximum length of a graphql query to log in tracings. Braintree gateway plugin.
Is this related to this PR?
@@ -2462,7 +2462,8 @@ namespace System.Windows.Forms { // provide negative wrap if necessary current = (--current < 0) ? count + current : current; } - if (this is ToolStripDropDown dropDown) + + if (dropDown != null) ...
[ToolStripSplitStackDragDropHandler->[OnDragDrop->[ToString],OnDragEnter->[ToString],ShowItemDropPoint->[PaintInsertionMark],OnDragLeave->[ClearInsertionMark,ToString],OnDropItem->[ClearInsertionMark],OnDragOver->[ClearInsertionMark,ToString],GetItemInsertionIndex->[Size,ToString]],CachedItemHdcInfo->[Dispose->[DeleteC...
Get next item in the list in horizontal direction.
Merge with the nested `if`?
@@ -98,6 +98,11 @@ public class LobbyLogin { }); } + private static String playerMacIdString() { + final String mac = MacFinder.getHashedMacAddress(new byte[6]); + return mac.substring(mac.length() - 10); + } + private void showError(final String title, final String message) { JOptionPane....
[LobbyLogin->[createAccount->[showError,createAccount],login->[login],loginToServer->[login]]]
Login to server.
I think you want the no-arg overload here. This overload simply hashes the passed array, which means it will always hash the MAC `00-00-00-00-00-00`.
@@ -28,7 +28,7 @@ namespace Kratos { void CreateDummy2DNoModelPartPropertiesModelPart(ModelPart& rModelPart) { - Properties::Pointer p_elem_prop = Kratos::make_shared<Properties>(0); + Properties::Pointer p_elem_prop(0); // First we create the nodes ...
[CreateModelPart->[CreateDummy2DModelPart,CreateDummy2DNoModelPartPropertiesModelPart,CreateDummy3DModelPart,CreateModelPart]]
Create dummy 2D No ModelPart properties ModelPart.
this is not the same is it? this is now an uninitialized pointer right?
@@ -185,9 +185,9 @@ class DeployJar(Target): JvmResolveNameField, ) help = ( - "A `jar` file that contains the compiled source code along with its dependency class " - "files, where the compiled class files from all dependency JARs, along with first-party " - "class files, exist ...
[JavaSourcesGeneratorSourcesField->[tuple],rules->[collect_rules,UnionRule],generate_targets_from_java_sources->[Get,SourcesPathsRequest,generate_file_level_targets],generate_targets_from_junit_tests->[Get,SourcesPathsRequest,generate_file_level_targets],dataclass]
Returns all rules that have no target.
Is this accurate? I didn't totally follow the original.
@@ -145,6 +145,13 @@ public class ServerConfig @NotNull private List<String> allowedHttpMethods = ImmutableList.of(); + @JsonProperty + @NotNull + private List<Pattern> responseWhitelistRegex = ImmutableList.of(); + + @JsonProperty + private boolean filterResponse = false; + public int getNumThreads() ...
[ServerConfig->[getMaxScatterGatherBytes->[getBytes],getDefaultNumThreads->[getAvailableProcessors,max],hashCode->[hash],equals->[getClass,equals],of,getDefaultNumThreads,toMillis,Period,valueOf]]
Returns the number of threads that are currently running or 0 if there are no threads.
this config applies to the http servers, not queries specifically, so I think if it is going to live here it might need a name that indicates it only applies to queries, unless you imagine that at some point this setting will apply to all HTTP error responses? Alternatively, if it lived on a more query centric config o...
@@ -87,11 +87,11 @@ type FluxAggregatorRoundState struct { } type FluxAggregatorRoundData struct { - RoundID uint32 `abi:"roundId" json:"reportableRoundID"` + RoundID *big.Int `abi:"roundId" json:"reportableRoundID"` Answer *big.Int `abi:"answer" json:"latestAnswer,omitempty"` - Started...
[LatestRoundData->[Wrap,Call],SubscribeToLogs->[SubscribeToLogs,NewDecodingLogListener],RoundState->[Wrap,Call],GetOracles->[Wrap,Call],NewConnectedContract,GetV6ContractCodec,MustGetV6ContractEventID]
TimesOutAt returns the number of times out in the round state.
I ask this a lot ... but here goes again: is a pointer needed here? Is `nil` usefully distinguishable from `0` ?
@@ -40,4 +40,6 @@ type Settings struct { // load custom index manager. The config object will be the Beats root configuration. IndexManagement idxmgmt.SupportFactory ILM ilm.SupportFactory + + Processing processing.SupporterFactory }
[No CFG could be retrieved]
load custom index manager.
please align and also call `SupportFactory`
@@ -261,9 +261,9 @@ public class ForkingTaskRunner implements TaskRunner, TaskLogProvider finally { try { synchronized (tasks) { - final TaskInfo taskInfo = tasks.remove(task.getId()); - ...
[ForkingTaskRunner->[findUnusedPort->[values,getStartPort],getWorkers->[of],stop->[info,shutdown,values,destroy],getRunningTasks->[of],getPendingTasks->[of],run->[call->[create,writeValue,rethrow,start,toString,IOException,addAll,info,join,remove,stringPropertyNames,findUnusedPort,getProperty,failure,getBaseTaskDir,get...
Runs a task in the background. This method is called when a task is not running. This method is called by the task manager to prevent a process from being killed.
is there a need for a task runner work item as a concrete class? maybe its best we have it as something that should be extended
@@ -218,7 +218,8 @@ func (s *testClusterWorkerSuite) SetUpTest(c *C) { func (s *testClusterWorkerSuite) TearDownTest(c *C) { s.svr.Close() - s.client.Close() + + os.RemoveAll(s.svr.cfg.EtcdCfg.DataDir) } func (s *testClusterWorkerSuite) checkRegionPeerCount(c *C, regionKey []byte, expectCount int) *metapb.Regi...
[TestHeartbeatSplit->[askSplit,chooseRegionLeader],checkChangePeerRes->[addPeer,removePeer],SetUpTest->[getRootPath,newMockRaftStore,bootstrap],TestHeartbeatSplitAddPeer->[checkChangePeerRes,chooseRegionLeader,askSplit],TestHeartbeatChangePeer->[checkChangePeerRes,chooseRegionLeader,checkRegionPeerCount],TestReportSpli...
TearDownTest tests the state of the cluster.
Any need to clean up `WalDir` too?
@@ -12,4 +12,12 @@ class AppMailer < Devise::Mailer headers = { to: @user.email, subject: (I18n.t('mailer.invitation_to_organization.subject')) }.merge(opts) mail(headers) end -end \ No newline at end of file + + def notification(user, notification) + @user = user + @notification = notification + ...
[AppMailer->[invitation_to_organization->[merge,mail],include,helper,default]]
Sends an invitation to an organization if it exists.
I think we need to escape all HTML entities from the `notification.title`. Because it can contain stuff like `<strong>`, or `<a>`, and the subject line usually won't render that, so user will get weird stuff. We're also using `title` more like a message at the moment (it can be quite long!). Maybe it would make more se...
@@ -33,7 +33,7 @@ func formattedRuleToProto(rls []rulefmt.Rule) []*RuleDesc { Record: rls[i].Record, Alert: rls[i].Alert, - For: &f, + For: f, Labels: client.FromLabelsToLabelAdapters(labels.FromMap(rls[i].Labels)), Annotations: client.FromLabelsToLabelAdapters(labels.FromMap...
[FromMap,FromLabelsToLabelAdapters,GetAlert,GetFor,Duration,GetName,GetRules,FromLabelAdaptersToLabels,Map,GetExpr,GetRecord]
ToProto converts a formatted prometheus rulegroup to a protobuf rule group Get formatted RuleGroup for a .
Same here. You can just do `time.Duration(rls[i].For)` here.
@@ -26,7 +26,8 @@ export type OverridesT = { Close?: OverrideT<SharedStylePropsArgT>, }; -export type ElementRefT = {current: React.ElementRef<'div'> | null}; +// eslint-disable-next-line flowtype/no-weak-types +export type ElementRefT = {current: React.ElementRef<any> | null}; // Props shared by all flavors o...
[No CFG could be retrieved]
The main entry point for the component that is imported by the module. A callback that is invoked when the modal shoupe will be closed.
Was this failing flow check? I don't see a related change in the modal implementation code
@@ -469,6 +469,14 @@ func (p *Provider) getFrontendRule(i ecsInstance) string { return "Host:" + strings.ToLower(strings.Replace(i.Name, "_", "-", -1)) + "." + p.Domain } +func (p *Provider) getBasicAuth(i ecsInstance) []string { + label := i.label(types.LabelFrontendAuthBasic) + if label != "" { + return strings...
[Provide->[createClient],getLoadBalancerSticky->[label],Weight->[label],getFrontendRule->[label],Protocol->[label],EntryPoints->[label],filterInstance->[label],getLoadBalancerMethod->[label],Priority->[label],PassHostHeader->[label]]
getFrontendRule returns the frontend rule for the given ecsInstance.
Do we need/also want to check that each basic auth value adheres to the `user:hash`? I think we should answer the question with _yes_ if it would simplify reporting an error to the user somehow.
@@ -27,6 +27,13 @@ import ( // handleMessageUpdate will update the consensus state according to received message func (consensus *Consensus) handleMessageUpdate(payload []byte) { + if !consensus.Decider.AmIMemberOfCommitee() { + utils.Logger().Debug(). + Str("PublicKey", consensus.PubKey.SerializeToHexStr()). + ...
[Start->[announce,Start,handleMessageUpdate,finalizeCommits]]
handleMessageUpdate handles a message update from the FBFTLog. OnPrepared callback for all commands that need to be executed.
Move this condition under, so only "consensus.onCommitted(msg)" is executed when I am not in committee. This so the node can still catch up with blocks.
@@ -173,15 +173,7 @@ class ProtocolsController < ApplicationController if @protocol.update_keywords(params[:keywords]) format.json do log_activity(:edit_keywords_in_protocol_repository, nil, protocol: @protocol.id) - - render json: { - updated_at_label: render_to_string( -...
[ProtocolsController->[copy_to_repository->[copy_to_repository],update_keywords->[update_keywords],load_from_repository->[load_from_repository],update_parent->[update_parent],unlink->[unlink],update_from_parent->[update_from_parent]]]
update_keywords updates the node with the given name in the protocol repository.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.<br>Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
@@ -425,7 +425,7 @@ func (c *sendOptions) Check() error { return ErrInvalidAccountID } } - if len(c.Message) > 400 { + if len(c.Message) > msgchecker.PaymentTextMaxLength { return ErrMessageTooLong }
[send->[AssetNative,SendCLILocal,encodeErr,ConvertOutsideToXLM,OutsideCurrencyCode,registerIdentifyUI,ToUpper,AccountID,encodeResult,ExchangeRateLocal,PaymentDetailCLILocal],getInflation->[encodeErr,encodeResult,getInflationLocal,Convert],registerIdentifyUI->[G],balances->[encodeResult,WalletGetAccountsCLILocal,encodeE...
Check checks if the send options are valid.
cc @patrickxb for this `msgchecker.PaymentTextMaxLength=240`
@@ -74,9 +74,9 @@ namespace System.Net.Security.Tests }; // Authenticate - Task clientTask = client.AuthenticateAsClientAsync(clientOptions, default); - Task serverTask = server.AuthenticateAsServerAsync(serverOptions, default); - ...
[SslClientAuthenticationOptionsTest->[Task->[EnabledSslProtocols,Count,Tls12,RemoteCertificateValidationCallback,GetServerCertificate,CertificateRevocationCheckMode,WhenAllOrAnyFailed,GetNameInfo,AllowNoEncryption,SimpleName,EncryptionPolicy,Same,ServerCertificate,GetClientCertificate,Equal,Http2,AllowRenegotiation,Con...
Client options and server options not mutated during authentication. Create a SslServerAuthenticationOptions object which can be used to authenticate client and server.
I wish it is somehow more visible this calls wrapper since there is no AuthenticateAsClientAsync() overload taking Options and bool. It is not obvious from first look what Sio going on IMHO.
@@ -18,8 +18,12 @@ def test_init(tmp_dir, dvc): code_path = os.path.join(CmdExperimentsInit.CODE, "copy.py") script = f"python {code_path}" + capsys.readouterr() assert main(["exp", "init", script]) == 0 - assert load_yaml(tmp_dir / "dvc.yaml") == { + out, err = capsys.readouterr() + assert...
[test_init->[load_yaml,join,main,gen]]
Test initialization of a single critical environment.
I was not able to test for `assert not caplog.text` because there are false issues in Macos in CI at least. `caplog.clear()` did not help for some reason.
@@ -168,13 +168,15 @@ def download_blob_from_url( blob URL already has a SAS token or the blob is public. The value can be a SAS token string, an account shared access key, or an instance of a TokenCredentials class from azure.identity. If the URL already has a SAS token, specifying an explic...
[_download_to_stream->[download_to_stream,download_blob],download_blob_from_url->[hasattr,_download_to_stream,isfile,from_blob_url,ValueError,format,open],upload_blob_to_url->[from_blob_url,upload_blob]]
Download the contents of a blob from a given URL.
should be `:keyword int max_concurrency:`
@@ -943,6 +943,7 @@ async def create_venv_pex( pex=pex.script, python=python.script, bin=FrozenDict((bin_name, venv_script.script) for bin_name, venv_script in scripts.items()), + venv_rel_dir=venv_rel_dir.as_posix(), )
[build_pex_component->[BuildPexComponentResult,BuildPexResult,generate_pex_arg_list,pex_path_closure],create_pex->[create_pex],parse_repository_info->[iter_dist_info->[PexDistributionInfo],PexResolveInfo,iter_dist_info],rules->[rules],BuildPexResult->[create_pex->[Pex]],PexRequirements->[create_from_requirement_fields-...
Create a virtual environment with a specific a . Missing key in venv.
Folks have a habit of doing this, but `str(venv_rel_dir)` will be Windows-proof and is actually correct today too.
@@ -83,6 +83,12 @@ class StateChangeLogSQLiteBackend(StateChangeLogStorageBackend): 'FOREIGN KEY(statechange_id) REFERENCES state_changes(id)' ')' ) + cursor.execute( + 'CREATE TABLE IF NOT EXISTS state_events (' + 'identifier integer primary key, source_s...
[StateChangeLog->[get_all_state_changes->[get_all_state_changes,deserialize],last_identifier->[last_identifier],__init__->[PickleTransactionSerializer],get_transaction_by_id->[get_transaction_by_id,deserialize],snapshot->[serialize,last_identifier,write_state_snapshot],log->[serialize,write_transaction]]]
Initialize the object.
Why do we need this foreign key? I'm asking because this requires all the state_changes to be saved in the WAL and also forces a coupling among the state_change code and event code.
@@ -149,7 +149,9 @@ router.post('/verify', phoneVerifyCode, async (req, res) => { const attestation = await generateAttestation( AttestationTypes.PHONE, attestationBody, - attestationValue, + { + uniqueId: attestationValue + }, req.body.identity, req.ip )
[No CFG could be retrieved]
Generate a phone number attestation for a given phone number.
what is the value here?
@@ -226,6 +226,8 @@ module Engine MUST_BUY_TRAIN = :route # When must the company buy a train if it doesn't have one (route, never, always) + DOUBLE_SIDED_TILES = false # if true, requires @tile_groups to be set + # Default tile lay, one tile either upgrade or lay at zero cost # allows mul...
[Base->[end_game!->[format_currency],current_entity->[current_entity],log_cost_discount->[format_currency],float_corporation->[format_currency],after_par->[format_currency,all_companies_with_ability],remove_train->[remove_train],init_hexes->[abilities],place_home_token->[home_token_locations],initialize_actions->[filte...
Returns a string representation of a single object. left one column per block.
just set tile groups in all and check the emptyness of that instead of this constant
@@ -56,7 +56,10 @@ class AppScaffoldDataCommand(superdesk.Command): dest_doc[app.config['VERSION']] = 1 dest_doc['state'] = 'fetched' - send_to(dest_doc, desk_id, stage_id) + user_id = desk.get('members', [{'user': None}])[0].get('user') + ...
[AppScaffoldDataCommand->[ingest_items_for->[list,get_resource_service,generate_guid,limit,dict,append,min,len,skip,send_to,remove_unwanted,format,generate_unique_id_and_name,insert_into_versions,info,range],run->[int,get_resource_service,str,info,enumerate,ingest_items_for],Option],AppScaffoldDataCommand,command]
Ingest items for a specific desk.
Whitespace missing, flake8 will probably complain. Edit: well, it does. :)
@@ -34,14 +34,11 @@ class User < ApplicationRecord unless: ->(u) { u.test_server? } after_initialize :set_display_name, :set_time_zone - validates_format_of :type, with: /\AStudent|Admin|Ta|TestServer\z/ validates_inclusion_of :locale, in: I18n.available_locales.m...
[User->[admin?->[class],grouping_for->[assessment_id,find],is_a_reviewer?->[is_peer_review?,is_a?,nil?],authenticate->[popen,validate_custom_status_message,new,to_s,instance,log,join,close,exitstatus,match,puts,validate_file],test_server?->[class],student?->[class],authorize->[first],set_display_name->[first_name,last_...
Creates a model that can be used to create a new object. Returns a user object representing the user with the given login.
remember to make a `Human` class as well rename the `STANDARD` variable to `HUMAN`
@@ -1711,9 +1711,13 @@ function $CompileProvider($provide, $$sanitizeUriProvider) { linkNode = $compileNode[0]; if (beforeTemplateLinkNode !== beforeTemplateCompileNode) { + var oldClasses = beforeTemplateLinkNode.className; // it was cloned therefore we have ...
[No CFG could be retrieved]
The main logic for the link - node - link - node - link - node - link Link function for any node that is not bound to a template.
I'd like to make a change to safeAddClass so that I can make sure it works correctly for SVG elements and SVGAnimatedString class names. That can wait for a different PR, though.
@@ -23,12 +23,12 @@ .module('<%=angularAppName%>') .config(translationConfig); - translationConfig.$inject = ['$translateProvider', 'tmhDynamicLocaleProvider']; + translationConfig.$inject = ['$translateProvider', 'tmhDynamicLocaleProvider', 'BUILD_TIMESTAMP']; - function translationConfi...
[No CFG could be retrieved]
This function is used to configure the angular - translate module.
why not just send current time? why build time?
@@ -2048,8 +2048,9 @@ export default { } APP.settings.setDisplayName(formattedNickname); - room.setDisplayName(formattedNickname); - APP.UI.changeDisplayName(this.getMyUserId(), - formattedNickname); + if (room) { + room.setDisplayName(formattedNickname); +...
[No CFG could be retrieved]
This is a helper function to set the display name of the user in the system.
hmm the room may not be ready to broadcast the change, but shouldn't the UI event still be emitted ?
@@ -132,7 +132,9 @@ class AmpFlyingCarpet extends AMP.BaseElement { this.children_.splice(index, 1); this.totalChildren_--; if (this.totalChildren_ == 0) { - this.attemptChangeHeight(0, () => this./*OK*/collapse()); + return this.attemptChangeHeight(0).then(() => { + this./*O...
[No CFG could be retrieved]
Determines the child nodes that are visible.
Ditto: vsync. Or even `deferMutate` to avoid expensive ops during scrolling.
@@ -115,7 +115,7 @@ <% if @article.search_optimized_title_preamble.present? && !user_signed_in? %> <span class="fs-xl color-base-70 block"><%= @article.search_optimized_title_preamble %></span> <% end %> - <%= sanitize_and_decode @article.title %> + ...
[No CFG could be retrieved]
Renders the content of the n - ary article. Renders a crayon - formatted list of tags.
The reason that this is the solution is that Rails' ERB template is already sufficient at rendering given text as is, ie. no processing and already escaped. `sanitize_and_decode` was originally implemented to try to fix escaped text on the feed, which is actually handled via preact. It wasn't needed here.
@@ -448,8 +448,8 @@ func newServerCertificateTemplate(subject pkix.Name, hosts []string) (*x509.Cert SignatureAlgorithm: x509.SHA256WithRSA, - NotBefore: time.Now().Add(-1 * time.Second), - NotAfter: time.Now().Add(lifetime), + NotBefore: time.Now().UTC().Add(-1 * time.Second), + NotAfter: time...
[MakeAndWriteServerCert->[writeCertConfig],signCertificate->[Next],writeCertConfig]
NewKeyPair returns a new keypair. IPs and DNS subjectAltNames in the cert are included as DNS subjectAltNames in the.
also, this copy/pasta-ed the caLifetime into the other cert types
@@ -98,7 +98,10 @@ class ArticleHTMLGalley extends ArticleGalley { $contents = str_replace('{$' . $key . '}', $value, $contents); } - return $contents; + // Eirik Hanssen 2014-05-15: + // to make HTML Galley webpages in OJS validate, $contents will be filtered through the new getHTMLBodyContents() function ...
[ArticleHTMLGalley->[setStyleFileId->[setData],_handleOjsUrl->[getJournalFilesPath,getSiteFilesPath,getId],getStyleFile->[getData],getHTMLContents->[getIssueIdentification,getArticleId,getImageFiles,getBestGalleyId,getFileId,getOriginalFileName,getLocalizedTitle,getIssueByArticleId,readFile],getImageFiles->[getData],se...
Get the HTML content of the block that is part of the block. This function is intend to replace the contents of a block of text with the contents of This function import all files that are not in the public folder.
- "will" rather than "wil"; "its" rather than "it's" (sorry, it's genetic)
@@ -100,7 +100,12 @@ def run(argv=None): # Actually run the pipeline (all operations above are deferred). result = p.run() result.wait_until_finish() - #TODO(pabloem)(BEAM-1366) Add querying of metrics once they are queriable. + empty_lines_filter = MetricsFilter().with_name('empty_lines') + query_result = ...
[WordExtractingDoFn->[process->[inc,findall,strip,len],__init__->[super,counter]],run->[add_argument,PipelineOptions,ArgumentParser,ReadFromText,Map,parse_known_args,sum,GroupByKey,wait_until_finish,run,ParDo,WriteToText,Pipeline,view_as],getLogger,run]
Entry point for the wordcount pipeline.
space before "TODO", colon after ")"
@@ -93,6 +93,7 @@ type Repository struct { AvatarURL string `json:"avatar_url"` Internal bool `json:"internal"` MirrorInterval string `json:"mirror_interval"` + RepoTransfer *RepoTransfer `json:"repo_transfer"` } // Cr...
[Name->[ToLower,Title]]
Create a new repository with the given name. A boolean indicating whether the repository is template or not.
Why we need this?
@@ -26,6 +26,18 @@ describe Devise::TwoFactorAuthenticationSetupController, devise: true do expect(response).to redirect_to(phone_confirmation_send_path) end + + it 'tracks an event when the number is invalid' do + allow(subject).to receive(:authenticate_scope!).and_return(true) + allow(subje...
[redirect_to,context,to,create,have_actions,describe,get,sign_in,with,patch,it,require]
Controller for all the Nova Nova Nova actions.
Doesn't this fit one one line?
@@ -475,11 +475,11 @@ class SetupOptions(PipelineOptions): '--sdk_location', default='default', help= - ('Override the default GitHub location from where Dataflow SDK is ' - 'downloaded. It can be an URL, a GCS path, or a local path to an ' - 'SDK tarball. Workflow subm...
[PipelineOptions->[__getattr__->[_visible_option_list],__dir__->[_visible_option_list],__setattr__->[_visible_option_list],display_data->[get_all_options],get_all_options->[_add_argparse_args],__str__->[_visible_option_list]],GoogleCloudOptions->[validate->[view_as]],StandardOptions->[validate->[view_as]],TestOptions->...
Adds the arguments to the argparse parser. This command is used to download a single tarball from a staging area.
Couple words missing I think: [the] Beam SDK If [set to] the string
@@ -228,6 +228,11 @@ class _RTCPartner(_CoroutineHandler): self.log.debug("Set local description", description=description) await self._try_signaling(self.peer_connection.setLocalDescription(description)) + def _make_call_id(self) -> str: + timestamp = time.time() + address1, addres...
[_on_ice_connection_state_change->[reset],_on_datachannel->[set_channel_callbacks],_RTCPartner->[process_signalling->[_set_local_description,_try_signaling,schedule_task,wait_for_coroutines],initialize_signalling->[_set_local_description,_try_signaling,schedule_task,set_channel_callbacks],set_candidates->[wait_for_cand...
Set the local description of the peer.
would be nice to make sure that `_call_id` is not altered at any point in time. A cached property would probably work.
@@ -203,6 +203,17 @@ namespace Dynamo.Models EvaluationCompleted(sender, e); } + /// <summary> + /// An event triggered when all tasks in scheduler are completed. + /// </summary> + public event Action<HomeWorkspaceModel> RefreshCompleted; + public virtual ...
[DynamoModel->[OnWorkspaceAdded->[OnWorkspaceAdded],OnEvaluationCompleted->[OnRequestDispatcherBeginInvoke],OnWorkspaceRemoved->[OnWorkspaceRemoved]]]
This method is called when the evaluation is complete.
Hi @pboyer , I'm not sure if it is exactly what you want me to do... please, take a look.
@@ -1407,12 +1407,7 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic * If the volume is not in the primary storage, we do nothing here. */ protected void expungeVolumesInPrimaryStorageIfNeeded(VolumeVO volume) throws InterruptedException, ExecutionException { - ...
[VolumeApiServiceImpl->[handleVmWorkJob->[handleVmWorkJob],orchestrateExtractVolume->[orchestrateExtractVolume],doesTargetStorageSupportDiskOffering->[doesTargetStorageSupportDiskOffering],attachVolumeToVmThroughJobQueue->[VmJobVolumeOutcome],createVolumeFromSnapshot->[createVolumeFromSnapshot],migrateVolumeThroughJobQ...
ExpungeExpungeExpungeExpungeExpungeExpunge.
Minor suggestion: what about prepending `"Failed to expunge the volume " + volume + " in " + role + " data store: "` here?
@@ -111,10 +111,11 @@ class GcsIO(object): ValueError: Invalid open file mode. """ if mode == 'r' or mode == 'rb': - return GcsBufferedReader(self.client, filename, + return GcsBufferedReader(self.client, filename, mode=mode, buffer_size=read_buffer_size) ...
[GcsBufferedReader->[__exit__->[close],__init__->[parse_gcs_path]],GcsIO->[copy->[parse_gcs_path,GcsIOError],size->[parse_gcs_path],copytree->[copy,glob],glob->[parse_gcs_path],exists->[parse_gcs_path],delete->[parse_gcs_path],rename->[delete,copy]],GcsBufferedWriter->[PipeStream->[tell->[_check_open]],write->[_check_o...
Open a GCS file path for reading or writing.
what does `mode='w'` on a reader mean?
@@ -42,14 +42,13 @@ func (s *StacktraceFrame) Transform(config *pr.Config) common.MapStr { enhancer.Add(m, "module", s.Module) enhancer.Add(m, "function", s.Function) enhancer.Add(m, "vars", s.Vars) - if config != nil && config.LibraryPattern != nil && s.LibraryFrame == nil { - libraryFrame := s.isLibraryFrame(c...
[buildSourcemapId->[CleanUrlPath],updateError->[Err,updateSmap],isLibraryFrame->[MatchString],isExcludedFromGrouping->[MatchString],Transform->[NewMapStrEnhancer,isExcludedFromGrouping,Add,isLibraryFrame],applySourcemap->[buildSourcemapId,updateError,Error,Sprintf,Apply,Err,updateSmap]]
Transform returns a copy of the stack trace frame in a common. MapStr format.
i'm lost with the latest developments, but why is necessary to mutate the argument here? `Transform` shouldn't just produce a `common.MapStr`?
@@ -16,3 +16,14 @@ import { Symbol } from '../base/react'; * } */ export const DISMISS_MOBILE_APP_PROMO = Symbol('DISMISS_MOBILE_APP_PROMO'); + +/** + * Action signalling to change information about unsupported browser + * in Redux store. + * + * { + * type: SET_UNSUPPORTED_BROWSER, + * unsupportedBrowse...
[No CFG could be retrieved]
DismarisMOBILEAppPromo Export.
Use our usual wording "The type of Redux action which signals bla bla bla".
@@ -4,10 +4,13 @@ import com.google.common.collect.ImmutableList; import org.graylog2.plugin.Plugin; import org.graylog2.plugin.PluginMetaData; import org.graylog2.plugin.PluginModule; +import org.graylog2.plugin.Version; import java.util.Collection; public class Elasticsearch6Plugin implements Plugin { + p...
[Elasticsearch6Plugin->[metadata->[Elasticsearch6Metadata],modules->[ViewsESBackendModule,of,Elasticsearch6Module]]]
Returns the metadata for a specific node id.
I would suggest renaming this to `SUPPORTED_ES_VERSION`. This would especially simplify understanding other classes where this constant is referenced.
@@ -5,7 +5,9 @@ AZURE_CLI_CLIENT_ID = "04b07795-8ddb-461a-bbee-02f9e1bf7b46" - +AZURE_VSCODE_CLIENT_ID = "aebc6443-996d-45c2-90f0-388ff96faa56" +AZURE_VSCODE_TENANT_ID = "organizations" +VSCODE_CREDENTIALS_SECTION = "VS Code Azure" class KnownAuthorities: AZURE_CHINA = "login.chinacloudapi.cn"
[No CFG could be retrieved]
Retrieves a token from the Azure API. A token for the public cloud.
I think it's fine to just use the literal, it's a well-known tenant and not particular to VS Code.
@@ -49,7 +49,8 @@ public class AmazonLambdaRecorder { beanContainer = container; AmazonLambdaRecorder.objectMapper = getObjectMapper() .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false) - .configure(MapperFeature.ACCEPT_CASE_INSENSITIVE_PROPERTIES, tru...
[AmazonLambdaRecorder->[chooseHandlerClass->[setHandlerClass]]]
Sets the class of the RequestHandler to be used.
Let's go with this for now, but I think we'll want to introduce an `ObjectMapperCustomizer` to the module that takes care of all this
@@ -86,8 +86,14 @@ def generate_news(session: Session, version: str) -> None: def update_version_file(version: str, filepath: str) -> None: + with open(filepath, "r", encoding="utf-8") as f: + content = list(f) with open(filepath, "w", encoding="utf-8") as f: - f.write('__version__ = "{}"\n'....
[get_version_from_arguments->[all,isdigit,split,len],generate_news->[install,run],get_author_list->[append,add,sorted,strip,set,run,splitlines,lower],update_version_file->[open,format,write],get_next_development_version->[split,map],modified_files_in_git->[run],generate_authors->[open,join,get_author_list,write],create...
Update version file with new version.
Ideally, we'd want to have an assertion to ensure that this line was actually run (basically, set a flag and assert it at the end?).
@@ -223,9 +223,15 @@ public abstract class HttpServerTracer<REQUEST> { protected abstract String method(REQUEST request); - protected void attachSpanToRequest(Span span, REQUEST request) {} + /** Stores given context in the given request in implementation specific way. */ + protected void attachContextToReque...
[HttpServerTracer->[end->[end],extract->[extract],endExceptionally->[onError,end],getCurrentSpan->[getCurrentSpan],setStatus->[setStatus],startSpan->[startSpan],withSpan->[withSpan]]]
This abstract class is used to implement the method that is used to attach a span to a.
currently at least, this method isn't needed (the only callers use the `public` overrides directly)
@@ -0,0 +1,9 @@ +import mock +from dvc.remote.gdrive import RemoteGDrive + + +@mock.patch("dvc.remote.gdrive.RemoteGDrive.init_drive") +def test_init_drive(repo): + url = "gdrive://root/data" + gdrive = RemoteGDrive(repo, {"url": url}) + assert str(gdrive.path_info) == url
[No CFG could be retrieved]
No Summary Found.
not sure what exactly do we test here?
@@ -104,6 +104,13 @@ public class ArtifactArchiver extends Recorder implements SimpleBuildStep { @Nonnull private Boolean caseSensitive = true; + /** + * Indicate whether to flatten directories in archive and just store the files. Will cause an {@link hudson.AbortException} + * if there are dupli...
[ArtifactArchiver->[perform->[perform,listenerWarnOrError],Migrator->[onLoaded->[setFingerprint]],ListFiles->[invoke->[setCaseSensitive]]]]
The base class for the archiver. Check if the node in the tree has a possible type.
After deserialization and before first assignment it will be null, so `Nonnull` lies.
@@ -62,7 +62,7 @@ class OpenidConnectAuthorizeForm def allowed_form_action return unless sp_redirect_uri =~ %r{https?://} - SecureHeadersWhitelister.extract_domain(sp_redirect_uri) + SecureHeadersWhitelister.extract_scheme_and_domain(sp_redirect_uri) end private
[OpenidConnectAuthorizeForm->[validate_client_id->[add,t,valid?],ial->[max],success_redirect_uri->[add_params],validate_scope->[add,present?,t],validate_redirect_uri_matches_sp_redirect_uri->[blank?,valid?,add,t,start_with?],allowed_form_action->[extract_domain],parse_to_values->[compact,blank?],validate_redirect_uri->...
This method is used to determine if a user is allowed to submit a non - empty array.
Would it be easier to simply return `sp_redirect_uri` here, since it will automatically include the protocol? Is there a reason we don't want to include the full `redirect_uri` in the `form_action` directive?
@@ -64,7 +64,6 @@ public class DistributedMassIndexingViaJmxTest extends DistributedMassIndexingTe "start", new Object[]{}, new String[]{}); } - @Test(groups ="unstable") @Override public void testReindexing() throws Exception { super.testReindexing();
[DistributedMassIndexingViaJmxTest->[testReindexing->[testReindexing]]]
Rebuild indexes.
This method should be removed entirely.
@@ -145,10 +145,10 @@ public class ProductionPanel extends JPanel { final Dimension screenResolution = Toolkit.getDefaultToolkit().getScreenSize(); final int availHeight = screenResolution.height - 80; final int availWidth = screenResolution.width - 30; - final int availHeightRules = availHeight - 116...
[ProductionPanel->[show->[getProduction],Rule->[setMax->[setMax],changedValue->[calculateLimits]],calculateLimits->[setLeft],getResources->[getResources]]]
Initialize the layout for the missing node. Add the missing components to the grid.
`screenResolution`, `availHeight`, and `availWidth` should probably be moved along with these two locals.
@@ -39,7 +39,7 @@ var ( ) // Handler returns a request.Handler for managing asset requests. -func Handler(dec decoder.ReqDecoder, processor asset.Processor, cfg transform.Config, report publish.Reporter) request.Handler { +func Handler(dec decoder.ReqDecoder, sourcemapStore *sourcemap.Store, report publish.Reporter...
[SetDefault,Write,Context,Error,DefaultMonitoringMapForRegistry,Contains,Validate,Decode,SetWithError,End,RequestTime,StartSpan,NewRegistry,Dropped]
Handler returns a request. Handler that returns a response with a response with a response with a Validate - validates and decode the given data and returns the object.
This change is unrelated to the main refactoring - can you please move this to a separate PR? It's a bit subjective whether this is an improvement, and I don't want to block this PR on tangentially related changes.
@@ -685,6 +685,16 @@ class _BaseRaw(ProjMixin, ContainsMixin, PickDropChannelsMixin, and neither complex data types nor real data stored as 'double' can be loaded with the MNE command-line tools. See raw.orig_format to determine the format the original data were stored in. + ...
[_start_writing_raw->[append],get_chpi_positions->[copy,time_as_index],_check_update_montage->[append],_write_raw->[_write_raw],_BaseRaw->[notch_filter->[notch_filter],to_nitime->[copy,index_as_time],resample->[resample],__setitem__->[_parse_get_set_params],append->[_read_segment],estimate_rank->[time_as_index],apply_h...
Save raw data to a file. Integrity check for a in the file system. Missing object in the file. Raw data.
I think we should remove the doc for the old parameter ....
@@ -3574,15 +3574,15 @@ // error if no gid specified if ($gid == 0 || $name == "") - throw new BadRequestException('gid or name not specified'); + throw new HTTP\BadRequestException('gid or name not specified'); // get data of the specified group id $r = q("SELECT * FROM `group` WHERE `uid` = %d AND...
[api_oauth_access_token->[fetch_access_token,getMessage],api_oauth_request_token->[fetch_request_token,getMessage],api_friendica_notification->[getAll],api_error->[getMessage],api_friendica_notification_seen->[getByID,setSeen],api_statusnet_config->[get_hostname],api_statuses_mediap->[purify,set],api_statuses_update->[...
api_friendica_group_delete - deletes a group.
Standards: Please add braces to this conditional statement.
@@ -2,6 +2,7 @@ require 'zip' class SubmissionsController < ApplicationController include SubmissionsHelper + include ApplicationHelper helper_method :all_assignments_marked?
[SubmissionsController->[downloads_subdirectories->[downloads_subdirectories]]]
This controller is responsible for generating the necessary files for the n - node submission. Generate a revisions history with date and num.
@jeremygoh Actually, can you try without the `ApplicationHelper` as well? I seem to recall it's already included in ApplicationController.
@@ -175,12 +175,14 @@ public class TcpNetConnection extends TcpConnectionSupport { } } if (doClose) { + boolean noReadErrorOnClose = this.noReadErrorOnClose; this.closeConnection(); if (!(e instanceof SoftEndOfStreamException)) { if (e instanceof SocketTimeoutException && this.isSingleUse()) { ...
[TcpNetConnection->[close->[close],getPort->[getPort]]]
This method handles a read exception. This method is used to return true if the exception should be closed.
Not related to the issue - but maybe wrap in logger.isDebugEnabled()
@@ -19,12 +19,13 @@ public class GameDataUtils { * <strong>You should have the game data's read or write lock before calling this method</strong> */ public static GameData cloneGameData(final GameData data, final boolean copyDelegates) { - try (ByteArrayOutputStream sink = new ByteArrayOutputStream(10000)...
[GameDataUtils->[cloneGameData->[saveGame,toByteArray,logQuietly,loadGame,ByteArrayOutputStream,ByteArrayInputStream,cloneGameData],translateIntoOtherGameData->[create,RuntimeException,writeObject,toByteArray,GameObjectStreamFactory,readObject,ByteArrayOutputStream,ByteArrayInputStream,GameObjectOutputStream]]]
Clone a GameData object.
I moved this out of the try-with-resources statement because it made it _appear_ that `sink` wasn't being flushed until after we used it to initialize `source`. Obviously, there was no issue because neither `ByteArrayOutputStream` nor `ByteArrayInputStream` require an explicit flush or close. Muh consistency, I guess.
@@ -11,5 +11,9 @@ namespace Microsoft.NET.HostModel.AppHost /// </summary> public class AppHostUpdateException : Exception { + internal AppHostUpdateException(string message = null) + : base(message) + { + } } }
[No CFG could be retrieved]
Exception class for AppHostUpdateException.
Move this one up too?
@@ -84,7 +84,7 @@ public class AtomicHashMapProxy<K, V> extends AutoBatchSupport implements Atomic // When passivation is enabled, cache loader needs to attempt to load // the previous value in order to merge it if necessary, so mark atomic // hash map writes as delta writes - if (cache.getCac...
[AtomicHashMapProxy->[size->[size,getDeltaMapForRead],containsValue->[containsValue,getDeltaMapForRead],keySet->[keySet,getDeltaMapForRead],getDeltaMapForWrite->[toMap,lookupEntryFromCurrentTransaction,getDeltaMapForRead],putAll->[getDeltaMapForWrite,putAll],entrySet->[entrySet,getDeltaMapForRead],values->[values,getDe...
This class is used to create a proxy for AtomicHashMap objects. Returns the delta map for read.
so when it's either eviction or passivation then use the Flag.DELTA_WRITE flag. Doesn't it mean we always use it when there's a cacheloader involved? And if there's no cacheloader then no point in adding the Flag.SKIP_CACHE_LOAD flag, so the whole "if/else" should be replaced with "flags[1] = Flag.DELTA_WRITE" that's i...
@@ -172,12 +172,12 @@ def pow(x, y, name=None): x = paddle.to_tensor([1, 2, 3]) y = 2 res = paddle.pow(x, y) - print(res.numpy()) # [1 4 9] + print(res) # [1 4 9] # example 2: y is a Tensor y = paddle.full(shape=[1], fi...
[broadcast_shape->[broadcast_shape],multiply->[_elementwise_op_in_dygraph,_elementwise_op],tanh->[tanh],clip->[clip],inverse->[inverse,_check_input],pow->[pow],divide->[_elementwise_op_in_dygraph,_elementwise_op],log2->[log2],trace->[trace,__check_input],add_n->[sum],mm->[__check_input],increment->[increment],minimum->...
Compute the power of tensor elements. Operation that pows x to y.
The following code affects this version of paddle.pow api. This block of code is meant to Align paddlepaddle pow api's functionality and behavior with numpy.power api, but it slowdowns the speed of this api call by 90%.
@@ -761,5 +761,9 @@ FIFF.FIFFV_COIL_CTF_GRAD = 5001 # CTF axial gradiometer FIFF.FIFFV_COIL_KIT_GRAD = 6001 # KIT system axial gradiometer # MNE RealTime -FIFF.FIFF_MNE_RT_COMMAND = 3700 -FIFF.FIFF_MNE_RT_CLIENT_ID = 3701 +FIFF.FIFF_MNE_RT_COMMAND = 3700 # realtime...
[Bunch->[__init__->[__init__]],Bunch]
FIFF V COIL KIT GRAD.
indices is probably a better term than slice here
@@ -302,9 +302,10 @@ def train_parallel(avg_loss, infer_prog, optimizer, train_reader, test_reader, if iters == args.skip_batch_num: start_time = time.time() num_samples = 0 - if iters == args.iterations: + # NOTE: if use reader ops, the input data is...
[train_parallel->[test],main->[print_arguments,train,train_parallel,append_nccl2_prepare,dist_transpile,parse_args],train->[test],parse_args->[parse_args],main]
Train a single batch of data using parallel processing. Train a single .
I don't think `iters >= args.iterations / args.gpus` is appropriate. Because the model's accuracy is highly related to the new parameters that have learned, but the new parameters may be related to the times of updating parameter. So maybe we should not do that.
@@ -956,8 +956,6 @@ const EC_METHOD *EC_GF2m_simple_method(void) ec_GF2m_simple_point_clear_finish, ec_GF2m_simple_point_copy, ec_GF2m_simple_point_set_to_infinity, - 0, /* set_Jprojective_coordinates_GFp */ - 0, /* get_Jprojective_coordinates_GFp */ ec_GF2m_simple_poin...
[ec_GF2m_simple_group_get_curve->[BN_copy],ec_GF2m_simple_invert->[BN_is_zero,EC_POINT_make_affine,EC_POINT_is_at_infinity,BN_GF2m_add],ec_GF2m_simple_field_mul->[BN_GF2m_mod_mul_arr],ec_GF2m_simple_add->[EC_POINT_copy,EC_POINT_set_affine_coordinates,EC_POINT_get_affine_coordinates,BN_CTX_end,EC_POINT_is_at_infinity,BN...
EC_GF2m_simple_method - Get the GF2m_ private ec_GF2m_simple_field_mul ec_GF2.
Deprecating the public function does not necessarily imply that we have to remove the corresponding internal function pointers from the EC_METHOD. Not that I'm necessarily against it - but I'd like to understand the reasoning.
@@ -200,12 +200,14 @@ def run_app( if not parsed_eth_rpc_endpoint.scheme: eth_rpc_endpoint = f'http://{eth_rpc_endpoint}' - web3 = _setup_web3(eth_rpc_endpoint) - node_network_id, known_node_network_id = setup_network_id_or_exit(config, network_id, web3) + web3 = Web3(HTTPProvider(eth_rpc_endpo...
[run_app->[_setup_web3,_assert_sql_version,_setup_matrix]]
Run the application. Initialize a configuration object with a single node - network network ID and network - specific configuration. Initialize a client with a single node network. Create a new raiden instance.
This is the weirdest thing ever `setup_network_id_or_exit` checked that `web3.version.network` and `network_id` are equal, and returned them as a tuple, so all three values `node_network_id`,`known_node_network_id`, and `network_id` were always equal
@@ -0,0 +1,18 @@ +require "rails_helper" + +RSpec.describe "Onboardings", type: :request do + let(:user) { create(:user, saw_onboarding: false) } + + describe "GET /onboarding" do + it "redirects user if unauthenticated" do + get onboarding_url + expect(response).to redirect_to("/enter") + end + + ...
[No CFG could be retrieved]
No Summary Found.
same here, maybe bot the file and the description should be singular
@@ -1,11 +1,17 @@ class AddressProofingJob < ApplicationJob include JobHelpers::FaradayHelper + include JobHelpers::StaleJobHelper queue_as :default def perform(user_id:, issuer:, result_id:, encrypted_arguments:, trace_id:) timer = JobHelpers::Timer.new + if stale_job?(enqueued_at) + noti...
[AddressProofingJob->[address_proofer->[lexisnexis_timeout,lexisnexis_phone_finder_workflow,new,lexisnexis_request_mode,lexisnexis_username,lexisnexis_account_id,lexisnexis_base_url,lexisnexis_password,proofer_mock_fallback],perform->[call,time,to_h,new,exception,parse,decrypt,inspect,vendor_name,to_json,info,proof,tra...
Perform the necessary actions to create a new Nexis proof.
I think we should raise an exception so it triggers the failed worker alarm
@@ -202,10 +202,12 @@ public class TronNetDelegate { freshBlockId.add(blockId); logger.info("Success process block {}.", blockId.getString()); if (!backupServerStartFlag - && System.currentTimeMillis() - block.getTimeStamp() < BLOCK_PRODUCED_INTERVAL) { + && no...
[TronNetDelegate->[getSolidBlockId->[getSolidBlockId],getGenesisBlockId->[getGenesisBlockId],getSyncBeginNumber->[getSyncBeginNumber],getBlockIdByNum->[getBlockIdByNum],getHeadBlockTimeStamp->[getHeadBlockTimeStamp],contain->[containBlock],pushTransaction->[pushTransaction],containBlock->[containBlock],getBlockChainHas...
Process a block.
try add some thing inside catch since we also need the fail block process time.
@@ -131,11 +131,11 @@ namespace CoreNodeModels.Input get { return new NodeInputData() { - Id = this.GUID.ToString("N"), + Id = this.GUID, Name = this.Name, Type = NodeInputTypes.numberInput, ...
[DoubleInput->[DeserializeCore->[DeserializeCore],OneNumber->[GetValue->[GetValue]],Sequence->[GetValue->[GetValue],GetFSchemeValue->[GetValue],GetValue],SerializeCore->[SerializeCore],CountRange->[Process->[Process]],Range->[GetValue->[GetValue],GetFSchemeValue->[GetValue],Process->[_Range],GetValue],UpdateValueCore->...
A base input for double input nodes. NUMBER_FORMAT - > NumberFormat.
Why do we need to change from `string` type to double?
@@ -15,7 +15,8 @@ import ( type ( Delegate struct { - webhookJobRunner *webhookJobRunner + webhookJobRunner *webhookJobRunner + externalInitiatorManager ExternalInitiatorManager } JobRunner interface {
[spec->[RUnlock,RLock],RunJob->[CreateLogger,Errorw,spec,CombinedContext,With,ExecuteAndInsertFinishedRun],Start->[addSpec],Close->[rmSpec],addSpec->[Lock,Unlock,Errorf],rmSpec->[Lock,Unlock],New]
Package webhook import imports a dependency between the Webhook and the Webhook - based Job. addSpec registers a job with the pipeline. Runner.
You could also use `if spec.WebhookSpec.ExternalInitiatorName.Valid {`
@@ -55,7 +55,13 @@ public final class BindingsImpl implements Bindings { private final Map<SimpleString, Integer> routingNamePositions = new ConcurrentHashMap<>(); - private final Map<Long, Binding> bindingsMap = new ConcurrentHashMap<>(); + private final Map<Long, Binding> bindingsIdMap = new ConcurrentHas...
[BindingsImpl->[getNextBinding->[getNextBinding],unproposed->[unproposed],routeFromCluster->[toString,route],removeBinding->[updated],routeAndCheckNull->[routeUsingStrictOrdering,route],simpleRouting->[route],routeUsingStrictOrdering->[getNextBinding],debugBindings->[toString],updated->[updated],route->[route]]]
Imports the bindings. Sets the message load balancer type.
Why not using a primitive version of this map? We have somewhere LongConcurrentHashMap (used into the journal too)
@@ -598,10 +598,6 @@ define([ this.replacementNode = undefined; - // Restore properties set per frame to their defaults - this.distanceToCamera = 0; - this.visibilityPlaneMask = 0; - this.selected = false; this.lastSelectedFrameNumber = 0; this.lastStyleTime = ...
[No CFG could be retrieved]
Unloads the tile s content and returns the state of when the tile was first created before Determines whether the tile s bounding volume intersects the culling volume.
These aren't needed to be reset anymore since they are always updated right away in the traversal.
@@ -470,11 +470,11 @@ int elf_validate_modules(struct image *image) return 0; } -int elf_find_section(struct image *image, struct module *module, +int elf_find_section(const struct image *image, const struct module *module, const char *name) { - Elf32_Ehdr *hdr = &module->hdr; - Elf32_Shdr *section, *s; +...
[void->[elf_is_rom],elf_validate_modules->[elf_validate_section],elf_parse_module->[elf_find_section]]
Finds the image module and section in the image and checks if the image has a valid module find section in module.
This should be in rimage repo.
@@ -278,7 +278,7 @@ function $InterpolateProvider() { lastValuesCache.results[scopeId] = lastResult = compute(values); } } catch(err) { - var newErr = $interpolateMinErr('interr', "Can't interpolate: {0}\n{1}", text, + var newErr = $interpolateMinEr...
[No CFG could be retrieved]
A function to handle the case where a variable is missing in the expressions array. Start symbol for the .
since `text` got clobbered, it needed to be replaced with the original value. This could be refactored to not clobber `text`, and there may be a slight performance increase, but I think it would also be more complex code.
@@ -1165,14 +1165,14 @@ var RepositoryDatatable = (function(global) { var column = TABLE.column(li.attr('data-position')); if (column.visible()) { - self.addClass('glyphicon-eye-close'); - self.removeClass('glyphicon-eye-open'); + self.addClass('fa-eye-slash'); + self.removeC...
[No CFG could be retrieved]
Adds a dropdown list item to the list that will show the column in the table. Initialize sorting and adjusting dropdowns.
do we also need to add .fas class beside that or no?
@@ -248,6 +248,12 @@ class Site_Command extends \WP_CLI\CommandWithDBObject { * * [--porcelain] * : If set, only the site id will be output on success. + * + * + * ## EXAMPLES + * + * $ wp site create --slug=example + * Success: Site 3 created: www.example.com/example/ */ public function cre...
[Site_Command->[_empty->[_insert_default_terms,_empty_posts,_empty_taxonomies,_empty_comments]]]
Create a new blog. This function is a more efficient way to do this. It is a more efficient way to This function is called when a site creation fails. It will also update the user s primary.
@hideokamoto There's an unnecessary extra line here.
@@ -85,6 +85,11 @@ func (f *FeedService) GetFeedSummary(countCategory string, filters []string, return nil, err } + mapFilters, err = filterByProjects(ctx, mapFilters) + if err != nil { + return nil, err + } + fq := feed.FeedSummaryQuery{ CountsCategory: feed.ConvertAPIKeyToBackendKey(countCategory), Bu...
[GetFeed->[GetFeed],GetFeedSummary->[GetFeedSummary],GetActionLine->[GetActionLine]]
GetFeedSummary returns a feed summary for the given countCategory and filters.
These five lines implements the change. Over 600 lines of test for 5 lines :sweat_smile:
@@ -289,10 +289,16 @@ class RecordingManager: """ watched_pcollections = set() + watched_dataframes = set() for watching in ie.current_env().watching(): for _, val in watching: if isinstance(val, beam.pvalue.PCollection): watched_pcollections.add(val) + elif isinsta...
[RecordingManager->[record->[Recording,record_pipeline,_watch,_clear],cancel->[wait_until_finish],describe->[describe]],Recording->[_mark_all_computed->[is_done],__init__->[cache_key,ElementStream],computed->[is_computed],cancel->[cancel],uncomputed->[is_computed],is_computed->[is_computed]],ElementStream->[read->[read...
Watch any pcollections not being watched.
I think it would be preferable to use `to_pcollection(yield='pandas')` here and then just concat the raw DataFrames we collect. That would avoid issues with the imperfect mapping back to beam schemas (e.g. pandas allows duplicate column names, and to_pcollection doesn't have a good story for mapping the index)
@@ -436,6 +436,9 @@ func ImageWithMetadata(image *Image) error { if len(image.DockerImageLayers) > 0 && image.DockerImageMetadata.Size > 0 && len(image.DockerImageManifestMediaType) > 0 { glog.V(5).Infof("Image metadata already filled for %s", image.Name) + + ReorderImageLayers(image) + // don't update image...
[Exact->[NameString],String->[Exact],RegistryHostPort->[DockerClientDefaults],DaemonMinimal->[Minimal],Exact,Equal,MostSpecific]
ImageConfigMatchesImage checks if the provided image config matches the digest stored in the manifest of ImageLayers - Get ImageLayer list from manifest.
Shouldn't we update the image object in etcd if there's such a metadata change? That way, we could allow for easy mass migration if desired (let the user get all the images).
@@ -51,10 +51,10 @@ async function copyAndReplaceUrls(src, dest) { async function firebase() { if (!argv.nobuild) { await clean(); - if (argv.min) { - await dist(); + if (argv.compiled) { + await doDist({fortesting: argv.fortesting}); } else { - await build(); + await doBuild({fo...
[No CFG could be retrieved]
Creates a firebase folder and all its children. Copy local amp files from dist folder to dist folder.
nit: both of these already default to `argv.fortesting`, so providing this option may be redundant here.
@@ -30,7 +30,9 @@ raiseNotifications = raiseRecoverabilityNotifications; } - public Task<ErrorHandleResult> Invoke(ErrorContext errorContext) +#pragma warning disable IDE0060 // Remove unused parameter + public Task<ErrorHandleResult> Invoke(ErrorContext errorContext, CancellationT...
[RecoverabilityExecutor->[MoveToError->[Error,MessageId,Message,Handled,ConfigureAwait,Exception],Invoke->[ErrorQueue,Warn,MessageId,Reason,DeferMessage,RaiseImmediateRetryNotifications,recoverabilityPolicy,MoveToError,Info,Exception],DeferMessage->[Warn,MessageId,Message,Delay,Handled,ConfigureAwait,Exception],RaiseIm...
This method is invoked by the error handling thread.
Do we need a TODO to remove the pragma later?
@@ -210,7 +210,7 @@ public class AjaxConnector extends JettyHttpsConnector implements BayeuxAware void createEmbeddedServer() throws MuleException { - Connector connector = createJettyConnector(); + AbstractConnector connector = createJettyConnector(); connector.setPort(serverUrl.ge...
[AjaxConnector->[validateSslConfig->[validateSslConfig],createReceiver->[setBayeux,getBayeux],doInitialise->[doInitialise],doStart->[doStart],createJettyConnector->[createJettyConnector],getBayeux->[getBayeux]]]
Creates an embedded server.
Is this change required?
@@ -8,6 +8,18 @@ Then('I click {string} Scinote button') do |button| find('.btn', text: button).click end +Then('I click on {string} button') do |button| + find('.btn', text: button).click +end + +Given('I click on {string} class button') do |button6| + find('.btn', class: button6, match: :first).click +end + +...
[visit,fetch,create,find,have_xpath,manage,have_current_path,join,accept,should,to,have_content,click_button,click_link,set,save_screenshot,dismiss,click,find_by_id,user,sleep,update,execute_script,click_on,id,within,resize_to,within_frame,not_to,send_keys,seed_demo_data,find_by,attach_file]
JS function for handling missing node - tag names find user in root_path.
delete and change in features
@@ -143,6 +143,7 @@ class BaseStructureContext extends BaseContext implements SnippetAcceptingContex protected function createStructureTemplate($type, $name, $template) { $paths = $this->getContainer()->getParameter('sulu.content.structure.paths'); + // FIX THIS $paths = array_filter(...
[BaseStructureContext->[createStructureTemplate->[getParameter],createStructures->[setState,getNode,saveRequest,setParentUuid,setData,getIdentifier,setWebspaceKey],getContentMapper->[getService]]]
Creates a structure template for a node.
This needs to be fixed for the behat tests, will do in a subsequent PR.
@@ -103,6 +103,12 @@ class Div(Markup): The default value is ``False``, meaning contents are rendered as HTML. """) + render_as_mathtext = Bool(False, help=""" + Whether the contents should be rendered as TeX/LaTeX input. + The default value is ``False``, meaning contents are rendered as HTML. + ...
[Markup->[Dict,String],Div->[Bool],getLogger]
A Bokeh model corresponds to an HTML section of a block of text.
suggest framing this as `enable_mathtext` which "only applies when rendering HTML (that is, when `render_as_text` is False)"
@@ -511,6 +511,10 @@ func EditProjectBoard(ctx *context.Context) { board.Title = form.Title } + if form.Color != "" { + board.Color = form.Color + } + if form.Sorting != 0 { board.Sorting = form.Sorting }
[GetProjects,CanWrite,IsErrProjectBoardNotExist,ComposeMetas,ChangeProjectAssign,UpdateProjectBoard,AddParam,ProjectID,IsAdmin,Redirect,MoveIssueAcrossProjectBoards,FormInt,HTML,CanAccess,Error,IsErrIssueNotExist,Issues,NotFound,NewProject,GetProjectByID,CanRead,JSON,HasError,FormInt64,IsOrganization,Tr,ServerError,Del...
EditProjectBoard allows a project board to be updated. MoveIssueAcrossBoards move a card from one board to another in a project.
How would you delete color?
@@ -2808,6 +2808,12 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve return isQuietingDown; } + @Exported + @Nullable + public String getQuietingReason() { + return quietingReason; + } + /** * Returns true if the container initiated the te...
[Jenkins->[getUser->[get],_cleanUpShutdownTcpSlaveAgent->[add],setNumExecutors->[updateComputerList],getPlugin->[getPlugin],getCategorizedManagementLinks->[all,add],getViewActions->[getActions],getJDK->[getJDKs,get],setViews->[addView],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getStoredVersion->[get],g...
Returns true if the node isQuietingDown false if it is terminating.
IIRC Nullable does nothing but checkfornull ensures that spotbugs forces people to check for null
@@ -126,7 +126,9 @@ RSpec.describe "Api::V1::ResultsController", type: :request do included: [ { type: 'result_texts', attributes: { - text: 'Result text 1 [~tiny_mce_id:a1]' + text: 'Result text 1 <img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAIAA'\...
[sentence,create,describe,first,it,name,generate_token,to,api_v1_team_project_experiment_task_result_path,before,post,second,require,include,have_http_status,to_json,as_json,match,id,get,not_to,api_v1_team_project_experiment_task_results_path,create_list]
This method returns path to the task results for a given task. Response with correct text result.
Metrics/LineLength: Line is too long. [97/80]
@@ -0,0 +1,14 @@ +from __future__ import absolute_import +from operator import itemgetter + +import pytest + +from .base import assert_valid_url +from .map_301 import URLS as REDIRECT_URLS + +@pytest.mark.headless +@pytest.mark.nondestructive +@pytest.mark.parametrize('url', REDIRECT_URLS) +def test_redirects(url): + ...
[No CFG could be retrieved]
No Summary Found.
``itemgetter`` imported but unused
@@ -892,6 +892,7 @@ namespace Content.Shared.Hands.Components [ViewVariables] public IContainer? Container { get; set; } + // TODO: Make this a nullable EntityUid... [ViewVariables] public EntityUid HeldEntity => Container?.ContainedEntities.FirstOrDefault() ?? EntityUid.Inv...
[SharedHandsComponent->[PutEntityIntoHand->[HandsModified],TryGetSwapHandsResult->[TryGetActiveHand],TryPutHandIntoContainer->[TryGetHand],TryGetActiveHeldEntity->[GetActiveHand],TryPickupEntityToActiveHand->[TryPickupEntity],DropHeldEntityToFloor->[DropHeldEntity],RemoveHeldEntityFromHand->[HandsModified],TryDropHeldE...
The object that holds the contents of a hand. The HandsComponentState class.
easy: just merge #5634 .... oh.. more conflicts...