patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -624,12 +624,10 @@ def analyze_class_attribute_access(itype: Instance,
return mx.chk.handle_partial_var_type(t, mx.is_lvalue, symnode, mx.context)
# Find the class where method/variable was defined.
- # mypyc hack to workaround mypy misunderstanding multiple inheritance (#3603)
- ... | [analyze_none_member_access->[_analyze_member_access,builtin_type],class_callable->[copy_modified],bind_self->[copy_modified,expand,bind_self],analyze_union_member_access->[_analyze_member_access],type_object_type->[builtin_type],analyze_var->[analyze_descriptor_access,not_ready_callback],analyze_type_callable_member_a... | Analyzes the type of an attribute. Missing key - value entry for a given node. Returns the type of the object in the order they are declared. | So the hack now is that this is a variable and the binder doesn't know whether it's true or false? |
@@ -95,15 +95,15 @@ class CreateDeleteTable(object):
async def delete_from_table_client(self):
from azure.data.tables.aio import TableClient
- from azure.core.exceptions import ResourceNotFoundError
+ from azure.core.exceptions import HttpResponseError
# [START delete_from_table... | [CreateDeleteTable->[delete_from_table_client->[delete_table],delete_table->[delete_table],create_from_table_client->[create_table],create_table->[create_table]],main->[delete_from_table_client,create_table,delete_table,CreateDeleteTable,create_if_not_exists],main] | Delete a table from TableClient. | Wondering if we should just remove these exception wrappers from the sample... We technically wouldn't have been catching these before. |
@@ -1005,6 +1005,13 @@ class CI_Upload {
'%3d' // =
);
+ do
+ {
+ $old_filename = $filename;
+ $filename = str_replace($bad, '', $filename);
+ }
+ while ($old_filename !== $filename);
+
return stripslashes(str_replace($bad, '', $filename));
}
| [CI_Upload->[is_allowed_dimensions->[is_image],_prep_filename->[mimes_types]]] | Clean a file name by removing any invalid characters. | You forgot to remove str_replace() from here. :) |
@@ -568,7 +568,7 @@ namespace Microsoft.Xna.Framework
/// <returns>The length of this <see cref="Vector3"/>.</returns>
public float Length()
{
- float result = DistanceSquared(this, zero);
+ float result = this.LengthSquared();
return (float)Math.Sqrt(result... | [Vector3->[Max->[Max],GetHashCode->[GetHashCode],Length->[DistanceSquared],CatmullRom->[CatmullRom],SmoothStep->[SmoothStep],Hermite->[Hermite],Transform->[Length],Lerp->[Lerp],Barycentric->[Barycentric],Clamp->[Clamp],LerpPrecise->[LerpPrecise],TransformNormal->[Length],Normalize->[Distance,Normalize],Min->[Min],ToStr... | Length - 1 if this vector is not empty. | I say go ahead and inline the length squared calculation here. |
@@ -579,7 +579,8 @@ public class DefaultTextHeaders extends DefaultConvertibleHeaders<CharSequence,
}
private <T> CharSequence commaSeparate(CsvValueEscaper<T> escaper, T... values) {
- StringBuilder sb = new StringBuilder(values.length * DEFAULT_VALUE_SIZE);
+ final int length... | [DefaultTextHeaders->[contains->[contains],SingleHeaderValuesComposer->[objectEscaper->[escape->[convertObject]],commaSeparate->[escape],addObject->[objectEscaper],set->[set,charSequenceEscaper],addEscapedValue->[set,add],add->[charSequenceEscaper],setObject->[objectEscaper,set]],setInt->[setInt],addObject->[addObject]... | commaSeparate method for comma seperated values. | Why was `DEFAULT_VALUE_SIZE` removed? Seems like we are reducing the visibility of this "configuration" type variable. |
@@ -388,14 +388,7 @@ namespace System.IO
public override Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
{
- if (buffer == null)
- throw new ArgumentNullException(nameof(buffer), SR.ArgumentNull_Buffer);
- if (offset... | [MemoryStream->[InternalEmulateRead->[EnsureNotClosed],WriteByte->[EnsureWriteable,EnsureNotClosed,EnsureCapacity],CopyTo->[InternalEmulateRead,CopyTo],InternalReadSpan->[EnsureNotClosed],Write->[EnsureWriteable,CopyTo,Write,EnsureCapacity,EnsureNotClosed],Seek->[EnsureNotClosed],Read->[Read,EnsureNotClosed],WriteTo->[... | Reads a chunk of data from the file. If the read is successful the last read task. | `Read` already performs validation as is called later on. Do we really have to call `ValidateBufferArguments` here as well? |
@@ -80,6 +80,18 @@ def find_usecase(x, y):
return x.find(y)
+def count_usecase(x, y):
+ return x.count(y)
+
+
+def count_with_start_end_usecase(x,y,start,end):
+ return x.count(y, start, end)
+
+
+def count_with_start_only_usecase(x,y,start):
+ return x.count(y, start)
+
+
def startswith_usecase(x, y... | [TestUnicodeInTuple->[test_ascii_flag_getitem->[f],test_ascii_flag_join->[f],test_const_unicode_in_tuple->[f],test_ascii_flag_add_mul->[f],test_const_unicode_in_hetero_tuple->[f],test_ascii_flag_unbox->[f]],TestUnicode->[test_pointless_slice->[pyfunc],test_literal_xyzwith->[pyfunc],test_le->[_check_ordering_op],test_li... | Check if x starts with y. | code style: spaces after commas |
@@ -12,6 +12,9 @@ export class AmpStoryShoppingTag extends AMP.BaseElement {
/** @private {?Element} */
this.container_ = null;
+
+ /** @private @const {!./amp-story-store-service.AmpStoryStoreService} */
+ this.storeService_ = null;
}
/** @override */
| [No CFG could be retrieved] | A class that represents an AMP story shopping tag. | We can remove this extra dom. Please set `textContent` of `this.element` to keep our dom structure as simple as possible. |
@@ -1292,6 +1292,14 @@ DataReaderImpl::enable()
XTypes::TypeLookupService_rch type_lookup_service = participant->get_type_lookup_service();
type_lookup_service->add_type_objects_to_cache(*typesupport);
+ // Populate local type dependencies cache
+ XTypes::TypeIdentifierWithSizeSeq dependencies_with_si... | [No CFG could be retrieved] | This function is called when a message is received from the DDS. This function checks if the id is known and if so checks if the reader is enabled. | Could this be refactored to push more logic into TypeSupportImpl? Looks like it could be a single method call on TypeSupportImpl giving it a parameter of `type_lookup_service`. |
@@ -60,6 +60,7 @@ type hotRegionSchedulerConfig struct {
// step = max current * rank step ratio
ByteRateRankStepRatio float64 `json:"byte-rate-rank-step-ratio"`
KeyRateRankStepRatio float64 `json:"key-rate-rank-step-ratio"`
+ QPSRankStepRatio float64 `json:"qps-rank-step-ratio"`
CountRankStepRatio flo... | [EncodeConfig->[EncodeConfig],ServeHTTP->[ServeHTTP],persist->[EncodeConfig]] | initHotRegionScheduleConfig - initializes the configuration for the hot region schedule. ombieDuration returns the duration of the last time the scheduler should be running. | Is it necessary? It seems we never change these configurations. |
@@ -35,6 +35,7 @@ public final class JpaServiceRegistryDaoImpl implements ServiceRegistryDao {
@PersistenceContext
private EntityManager entityManager;
+ @Transactional(readOnly = false)
@Override
public boolean delete(final RegisteredService registeredService) {
if (this.entityManager... | [JpaServiceRegistryDaoImpl->[save->[persist,merge,getId],findServiceById->[find],load->[getResultList],delete->[remove,merge,contains]]] | Delete a managed service. | Yes, that sounds good. I've always been expected to see `@Transactional` annotation at the registry level. Though, in the `CentralAuthenticationServiceImpl` class, every annotated method generally performs a read then a write on a ticket. They were previously enclosed in the same transaction, I fear some side effects b... |
@@ -68,9 +68,7 @@ def address_checksum_and_decode(addr: str) -> Address:
if not is_checksum_address(addr):
raise InvalidChecksummedAddress("Address must be EIP55 checksummed")
- addr_bytes = decode_hex(addr)
- assert len(addr_bytes) in (20, 0)
- return Address(addr_bytes)
+ return to_canonic... | [merge_dict->[merge_dict],lpex->[pex],privatekey_to_publickey->[ishash]] | Takes a string address and turns it into binary. nagonczed and checksum. | This and below are just some drive by changes. |
@@ -122,7 +122,7 @@ class DownloadCacheTest(unittest.TestCase):
""" % http_server.port)
client.save({"conanfile.py": conanfile})
client.run("source .", assert_error=True)
- self.assertIn("ConanException: md5 signature failed", client.out)
+ self.assertIn("ConanException: All ... | [CachedDownloaderUnitTest->[test_content_first->[download],concurrent_locks_test->[download->[download]],test_basic->[download],setUp->[FakeFileDownloader]]] | Download a file from the server and check if it is cached. This method downloads a file from the server and checks if it is in the cache. | I don't like having this error message when you only provide 1 url, it makes the output a bit more confusing to the user. |
@@ -252,7 +252,7 @@ class EntityGenerator extends BaseBlueprintGenerator {
},
validateReactiveCompatibility() {
- if (this.context.reactive && !['mongodb', 'cassandra', 'couchbase', 'neo4j'].includes(this.context.databaseType)) {
+ if (this.context.reactive && !... | [No CFG could be retrieved] | Creates a shared config object for the entity generator. Missing context. | All database are now supported, the `validateReactiveCompatibility` function can be removed. |
@@ -3138,6 +3138,8 @@ int s_client_main(int argc, char **argv)
OPENSSL_free(bindstr);
OPENSSL_free(host);
OPENSSL_free(port);
+ if (thost != NULL) OPENSSL_free(thost);
+ if (tport != NULL) OPENSSL_free(tport);
X509_VERIFY_PARAM_free(vpm);
ssl_excert_free(exc);
sk_OPENSSL_STRING_free(... | [No CFG could be retrieved] | Reads the network buffer of the network alert and returns the number of bytes read. Frees all resources held by the SSL object. | Please drop the ifs, the free call checks it. |
@@ -848,13 +848,9 @@ defineSuite([
expect(stats.numberOfPendingRequests).toEqual(1);
scene.primitives.remove(tileset);
- return root.contentReadyPromise.then(function(root) {
- fail('should not resolve');
- }).otherwise(function(error) {
- ... | [No CFG could be retrieved] | This function creates a new and checks that the root is not empty and that the 15. 2. 2. 2 2. 2 2. 2. 4. | I have this here to check that the ready promise is actually rejected. Otherwise that area won't have code coverage. |
@@ -199,4 +199,12 @@ public class FlowConfigResourceLocalHandler implements FlowConfigsResourceHandle
throw new FlowConfigLoggedException(HttpStatus.S_400_BAD_REQUEST, "bad URI " + flowConfig.getTemplateUris(), e);
}
}
+
+ /**
+ * @param flowConfig flowConfig
+ * @return returns true if it is a runO... | [FlowConfigResourceLocalHandler->[updateFlowConfig->[updateFlowConfig],createFlowConfig->[createFlowConfig],deleteFlowConfig->[deleteFlowConfig]]] | Creates a FlowSpec for the given flow config. | One one is defined as not having a schedule. |
@@ -68,11 +68,11 @@ abstract class Jetpack_Sync_Module {
$items_per_page = 1000;
$page = 1;
$chunk_count = 0;
- $previous_max_id = $state ? $state : '~0';
+ $previous_interval_endpoint = $state ? $state : '~0';
$listener = Jetpack_Sync_Listener::get_instance();
// count down fr... | [Jetpack_Sync_Module->[get_objects_by_id->[get_object_by_id]]] | Enqueue all the ids as an action. end of function _id. | Can we make this aligned with the other assignments around this one after we decide what to call the thing? |
@@ -130,10 +130,10 @@ public class EmitterModule implements Module
{
final List<Binding<Emitter>> emitterBindings = injector.findBindingsByType(new TypeLiteral<Emitter>(){});
- emitter = findEmitter(emitterType, emitterBindings);
-
- if (emitter == null) {
+ if (Strings.isNullOrEmpty(emitte... | [EmitterModule->[EmitterProvider->[inject->[value,findBindingsByType,getAnnotation,findEmitter,add,ISE],get->[ISE],findEmitter->[get,getAnnotation,equals]],getServiceEmitter->[copyOf,get,registerEmitter,ServiceEmitter,getServiceName,info,getHostAndPortToUse],configure->[install,newMapBinder,getProperty,HttpEmitterModul... | Injects emitter in injector. | I'm not sure defaulting to noop if the emitter string is empty is a good idea either. |
@@ -58,7 +58,15 @@ func URLFields(u *url.URL) common.MapStr {
}
if u.Port() != "" {
- fields["port"], _ = strconv.ParseUint(u.Port(), 10, 16)
+ // Returns a uint64 believe it or not.
+ val, _ := strconv.ParseUint(u.Port(), 10, 16)
+ fields["port"] = uint16(val)
+ } else {
+ if u.Scheme == "http" {
+ fields... | [MergeEventFields,UserPassword,Port,Username,Hostname,String,Wrap,ParseUint,Password] | Fields returns a JobWrapper that adds fields to a given event. | Should we have an ending "else" to catch edge cases we were not thinking of? |
@@ -112,5 +112,8 @@ class WPSEO_Import_Settings {
$this->status->set_msg( __( 'Settings successfully imported.', 'wordpress-seo' ) );
$this->status->set_status( true );
+
+ // Reset the cached option values.
+ WPSEO_Options::$option_values = null;
}
}
| [WPSEO_Import_Settings->[import_options->[parse_option_group],parse_option_group->[import]]] | Import options from array. | I would prefer to have a method that does the `option_values` reset. |
@@ -63,10 +63,18 @@ class TestFigure:
assert p.plot_width == 100
assert p.plot_height == 120
+ p = bpf.figure(width=100, height=120)
+ assert p.width == 100
+ assert p.height == 120
+
p = bpf.figure(plot_width=100, plot_height=120)
assert p.plot_width == 100
... | [source->[ColumnDataSource,dict],Test_vbar_stack->[test_returns_renderers->[ColumnDataSource,vbar_stack,figure,len]],TestMarkers->[test_render_level->[getattr,circle,raises,func,figure],test_fill_color_input->[getattr,func,figure,isinstance],test_color_input->[getattr,func,figure,isinstance],test_mixed_inputs->[getattr... | Test if the plot width and height are the same. | Instead of duplicating those tests, you should check if `p.plot_with` and `p.width` are the same under both ways of initializing `figure()`, i.e. `assert p.width == p.plot_width == 100`, as not only it's shorter, but also states the intent of this test more clearly. |
@@ -97,6 +97,7 @@ import {debounce} from '../../../src/utils/rate-limit';
import {dev, devAssert, user} from '../../../src/log';
import {dict} from '../../../src/utils/object';
import {findIndex} from '../../../src/utils/array';
+import {getAnalyticsService} from './story-analytics';
import {getConsentPolicyState} ... | [AmpStory->[onBookendStateUpdate_->[BOOKEND_ACTIVE,setHistoryState],isBrowserSupported->[Boolean,CSS],isStandalone_->[STANDALONE],onUIStateUpdate_->[DESKTOP_PANELS,MOBILE,DESKTOP_FULLBLEED],closeOpacityMask_->[dev,toggle],initializeStoryNavigationPath_->[NAVIGATION_PATH,getHistoryState],updateBackground_->[url,computed... | Aamp - Story - specific import methods Imports all packages that are not part of the current language. | nit: merge the two imports from `./story-analytics` |
@@ -135,8 +135,7 @@ public class GoogleDataSegmentFinder implements DataSegmentFinder
throw new SegmentLoadingException(e, "IO exception");
}
catch (Exception e) {
- Throwables.propagateIfInstanceOf(e, SegmentLoadingException.class);
- Throwables.propagate(e);
+ throw Throwables.propagat... | [GoogleDataSegmentFinder->[findSegments->[getNextPageToken,equals,setLength,getLoadSpec,toFilename,info,put,propagateIfInstanceOf,getBucket,insert,SegmentLoadingException,indexZipForSegmentPath,ByteArrayInputStream,list,getItems,exists,writeValueAsBytes,execute,delete,propagate,getName,get,InputStreamContent,setPrefix,... | Find segments in the given working directory. Returns a list of segments that can be loaded. | We need to keep the `Throwables.propagateIfInstanceOf`. Removing it changes the behavior to no longer throw `SegmentLoadingException`, which introduces bugs downstream since some callers specifically try to catch that exception. |
@@ -365,3 +365,14 @@ def is_currency_supported(currency: str, gateway_id: str, manager: "PluginsManag
"""Return true if the given gateway supports given currency."""
available_gateways = manager.list_payment_gateways(currency=currency)
return any([gateway.id == gateway_id for gateway in available_gateway... | [get_already_processed_transaction_or_create_new_transaction->[get_already_processed_transaction,create_transaction]] | Return true if the given gateway supports given currency. | It looks like it returns `last_payment` for the order but we never check if the payment is valid. Not sure if this a proper way |
@@ -88,12 +88,13 @@ public class KsqlResource {
private final ActivenessRegistrar activenessRegistrar;
private final RequestValidator validator;
private final RequestHandler handler;
+ private final Supplier<ServiceContext> serviceContextFactory;
public KsqlResource(
final KsqlConfig ksqlConfig,... | [KsqlResource->[shouldSynchronize->[containsKey,contains],ensureValidPatterns->[forEach,KsqlRestException,badRequest,compile],handleKsqlStatements->[getStreamsProperties,getSqlStatement,getRawMessage,badRequest,httpWaitForCommandSequenceNumber,parse,serverErrorForStatement,validate,build,KsqlEntityList,isAcceptingState... | PUBLIC CONSTRUCTORS This class represents a resource which represents a single . Initialize the Handler. | Will this be a Supplier longer term? Seems like we want to pass in some info about the principal associated with the request. |
@@ -57,6 +57,9 @@ manifest_name = 'spack.yaml'
lockfile_name = 'spack.lock'
+txlock_name = 'txlock'
+
+
#: Name of the directory where environments store repos, logs, views
env_subdir_name = '.spack-env'
| [validate_env_name->[valid_env_name],is_env_dir->[exists],all_environment_names->[exists,_root,valid_env_name],_write_yaml->[validate],deactivate_config_scope->[config_scopes],ViewDescriptor->[from_dict->[ViewDescriptor],regenerate->[view]],root->[validate_env_name,_root],create->[validate_env_name,root,exists],exists-... | Creates a new object from a given base - number. Magic names for the environment. | needs docstring -- might consider giving it a longer name like `transaction_lock` or `filesystem_lock` or something. `txlock` differentiates it from the "lockfile" but I am not sure it's as clear. |
@@ -270,7 +270,7 @@
{
var tasks = endpoints.Select(endpoint => ExecuteWhens(endpoint, cts));
var whenAll = Task.WhenAll(tasks);
- var timeoutTask = Task.Delay(TimeSpan.FromSeconds(30));
+ var timeoutTask = Task.Delay(TimeSpan.FromSeconds(30000));
var... | [ScenarioRunner->[InitializeRunners->[CreateRoutingTable]]] | ExecuteWhens executes all the given endpoints in parallel. | I'll revert this |
@@ -114,6 +114,8 @@ function PMA_sqlQueryForm($query = true, $display_tab = false, $delimiter = ';')
. __('Your SQL query has been executed successfully') . '" />' . "\n"
.'<input type="hidden" name="prev_sql_query" value="'
. htmlspecialchars($query) . '" />' . "\n";
+
+ echo $for... | [PMA_sqlQueryFormUpload->[display]] | PMA_sqlQueryForm - Displays a form with a single missing key Displays the sqlform hidden inputs and the sql query results. </div> - >. | I will refator here later: Function A () { $html += B(); echo $html; } Function B () { $html = "<form>.."; returm $html; } |
@@ -0,0 +1,9 @@
+# -*- encoding : utf-8 -*-
+
+module NotificationMailerHelper
+ # Group an array of notifications into a hash keyed by their
+ # info_request_event's event_type string
+ def notifications_by_event_type(notifications)
+ notifications.group_by { |n| n.info_request_event.event_type }
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Looks like the commit message needs to be edited for this commit. |
@@ -311,11 +311,11 @@ class Trilinos(CMakePackage):
depends_on('swig', when='+python')
patch('umfpack_from_suitesparse.patch', when='@11.14.1:12.8.1')
- patch('xlf_seacas.patch', when='@12.10.1:%xl')
- patch('xlf_seacas.patch', when='@12.10.1:%xl_r')
+ patch('xlf_seacas.patch', when='@12.10.1:12.12... | [Trilinos->[url_for_version->[format],filter_python->[filter_file],cmake_args->[popen,macOS_version,satisfies,append,Version,dirname,extend,join],depends_on,conflicts,resource,version,patch,variant,run_after]] | Returns the URL for a given version. | Anyone know why this patch doesn't have the same version range? Since it was previously in the lower section, I have a feeling that it was a mistake. |
@@ -9,8 +9,8 @@
public partial class TestableSubscribeContext : TestableBehaviorContext, ISubscribeContext
{
/// <summary>
- /// The type of the event.
+ /// The types of the events.
/// </summary>
- public Type EventType { get; set; } = typeof(object);
+ public T... | [No CFG could be retrieved] | The type of the event. | this needs to be properly obsoleted before merging. |
@@ -331,9 +331,11 @@ static void schedule_ll_domain_clear(struct ll_schedule_data *sch,
if (count == 1) {
sch->domain->registered[cpu_get_id()] = false;
- count = atomic_sub(&sch->domain->num_clients, 1);
- if (count == 1)
- domain_clear(sch->domain);
+ if (atomic_read(&sch->domain->num_clients)) {
+ coun... | [No CFG could be retrieved] | This function is called from the scheduler code to register a new in the domain. inserts a task into the list of tasks. | What happens if num_clients changes here between reading and subtracting. @lgirdwood @plbossart what do you think ? |
@@ -10,10 +10,11 @@ class PySlepc4py(PythonPackage):
"""This package provides Python bindings for the SLEPc package.
"""
- homepage = "https://bitbucket.org/slepc/slepc4py"
- url = "https://bitbucket.org/slepc/slepc4py/get/3.10.0.tar.gz"
- git = "https://bitbucket.org/slepc/slepc4py.git"
... | [PySlepc4py->[depends_on,version]] | Creates a new object. This function is used to find all the build - specific information that can be used in a. | @s-sajid-ali might aswell add an entry for 3.11.0? |
@@ -103,10 +103,6 @@ class SiteConfig < RailsSettings::Base
type: :string,
default: proc { URL.local_image("mascot.png") },
validates: { url: true }
- field :mascot_image_description, type: :string, default: "The community mascot"
- field :mascot_footer_image_url, type: :string, validates: ... | [SiteConfig->[local?->[include?],get_default->[get_field],freeze,exists?,cache_prefix,year,proc,current,local_image,field,table_name]] | The tracking ID is the unique identifier of the Google Analytics tracking. Protected Properties for MailChimp API. | should we delete these explicitly with the data update script? |
@@ -289,6 +289,13 @@ public abstract class AbstractMavenClassLoaderModelLoader implements ClassLoader
return missingApiDependencies.stream().map(this::convertBundleDependency).collect(toSet());
}
+ private File getPom(org.mule.maven.client.api.model.BundleDependency dependency) {
+ String zipPath = depend... | [AbstractMavenClassLoaderModelLoader->[getClassLoaderModelDescriptor->[File],findMissingApiDependencies->[includeTestDependencies,add,pop,getDescriptor,isEmpty,resolveBundleDescriptorDependencies,collect,toSet,noEquivalentPresent],createLightPackageClassLoaderModel->[ofNullable,findMissingApiDependencies,resolveArtifac... | Finds missing API dependencies. | This will work on Windows, right? I mean, URI getPath would not be OS dependent, no? Check that just to make sure that is fine. |
@@ -108,7 +108,7 @@ class NavierStokesMPIEmbeddedMonolithicSolver(navier_stokes_embedded_solver.Navi
## Construct the Trilinos import model part utility
self.trilinos_model_part_importer = trilinos_import_model_part_utility.TrilinosImportModelPartUtility(self.main_model_part, self.settings)
#... | [CreateSolver->[NavierStokesMPIEmbeddedMonolithicSolver],NavierStokesMPIEmbeddedMonolithicSolver->[PrepareModelPart->[super,CreateCommunicators],AddDofs->[_IsPrintingRank,PrintInfo,super,barrier],AddVariables->[PrintInfo,super,AddNodalSolutionStepVariable,_IsPrintingRank,barrier],_ValidateSettings->[ValidateAndAssignDe... | Imports the model part of the MPI. | IMO ExecutePartitioningAndReading is a much more self-explicative name of what this method does. |
@@ -565,7 +565,7 @@ func startControllers(oc *origin.MasterConfig, kc *kubernetes.MasterConfig) erro
kc.RunNamespaceController()
kc.RunPersistentVolumeClaimBinder(binderClient)
kc.RunPersistentVolumeProvisioner(provisionerClient)
- kc.RunPersistentVolumeClaimRecycler(oc.ImageFor("recycler"), recyclerClient)
+... | [CreateCerts->[Validate],Validate->[Validate],DefaultsFromName] | Initialize the controller IsRunFromConfig - checks if the master is running a controller and if so runs it. | do we need to make sure the OpenShiftInfrastructureNamespace isn't subject to the cluster-wide default node selector? |
@@ -43,9 +43,10 @@ func NewCmdImportImage(fullName string, f *clientcmd.Factory, out io.Writer) *co
cmdutil.CheckErr(err)
},
}
- cmd.Flags().String("from", "", "A Docker image repository to import images from")
+ cmd.Flags().String("from", "", "A Docker image repository or tag to import images from")
cmd.Fla... | [Error->[Sprintf],IsZero,Stop,GetFlagString,Errorf,Watch,CheckErr,Bool,Clients,DefaultNamespace,Create,Fprintln,GetFlagBool,Fprint,ResultChan,Get,Out,Update,Everything,Describe,ImageStreams,Sprintf,UsageError,String,Parse,IsNotFound,Flags,OneTermEqualSelector] | NewCmdImportImage implements the OpenShift cli import - image command Clients returns the image id from the docker client. | Breaking CLI change. |
@@ -32,7 +32,7 @@ class Lock(object):
"""
def __init__(self, path, start=0, length=0, debug=False,
- default_timeout=None):
+ default_timeout=None, desc=''):
"""Construct a new lock on the file at ``path``.
By default, the lock applies to the whole file. ... | [Lock->[_lock->[_poll_interval_generator],release_read->[_unlock],acquire_write->[_lock],release_write->[_unlock],acquire_read->[_lock],_acquired_debug->[_debug]],LockTransaction->[__exit__->[__exit__],__enter__->[__enter__]],WriteTransaction->[_enter->[acquire_write],_exit->[release_write]],ReadTransaction->[_enter->[... | Construct a new lock on the file at path. | Can you add in the docstring below the meaning of `desc`? |
@@ -230,7 +230,7 @@ public class AmbariMetricsEmitter extends AbstractTimelineMetricsSink implements
protected static String sanitize(String namespace)
{
- Pattern DOT_OR_WHITESPACE = Pattern.compile("[\\s]+|[.]+");
- return DOT_OR_WHITESPACE.matcher(namespace).replaceAll("_");
+ Pattern dotOrWhitespac... | [AmbariMetricsEmitter->[close->[flush],emit->[emit],flush->[ConsumerRunnable]]] | Removes any trailing whitespace from the namespace. | It should rather be a constant |
@@ -383,10 +383,12 @@ public class ElasticsearchMetadata
throw new IllegalArgumentException(format("Unexpected column for table '%s$query': %s", table.getIndex(), column.getName()));
}
- return ColumnMetadata.builder()
- .setName(column.getName())
- .setType(... | [ElasticsearchMetadata->[toTrinoType->[toTrinoType],listTableColumns->[getTableMetadata],makeInternalTableMetadata->[makeInternalTableMetadata],getTableMetadata->[getTableMetadata],getColumnHandles->[makeInternalTableMetadata,getColumnHandles]]] | Gets column metadata. | is the change here testable? |
@@ -2587,6 +2587,10 @@ RtpsUdpDataLink::check_heartbeats()
void
RtpsUdpDataLink::send_relay_beacon()
{
+ // Use a pad submessage with for the beacon
+ static const ::CORBA::Octet beacon_msg[] = { 1, 0, 0, 0 };
+ static const size_t beacon_msg_size = sizeof(beacon_msg);
+
const bool no_relay = config().rtps_r... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -. | This could use the `PAD` constant and also if we move it to a common header like `BaseMessageTypes.h` it can be reused by the relay code instead of being repeated there. |
@@ -1,5 +1,5 @@
/*
-Copyright (c) 2014-2015 VMware, Inc. All Rights Reserved.
+Copyright (c) 2014-2016 VMware, Inc. All Rights Reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
| [Register->[Register,NewDatastoreFlag,StringVar,NewVirtualMachineFlag],Run->[Arg,VirtualMachine,DatastorePath,InsertIso,NArg,EditDevice,FindCdrom,Device],Process->[Process],Register] | returns a struct that represents a single . Run runs the command to insert a new device into the datastore. | @emlin Why do some files have the copyright range from 2014-2017 and some have the copyright range from 2014-2016 like this one? I'm just curious here. |
@@ -70,9 +70,6 @@ func PrintConfigCheckMsg(cfg *config.Config) {
// CheckPDVersion checks if PD needs to be upgraded.
func CheckPDVersion(opt *config.PersistOptions) {
pdVersion := versioninfo.MinSupportedVersion(versioninfo.Base)
- if versioninfo.PDReleaseVersion != "None" {
- pdVersion = versioninfo.MustParseVer... | [Commit,Warn,GetStoreId,Now,Else,CreateRevision,Wrap,Info,MustParseVersion,Compare,New,BytesToUint64,GetStartKey,MinSupportedVersion,Ctx,LessThan,Errorf,Stringer,GetResponseRange,GetPeers,GetRegion,Unix,Uint64ToBytes,GetClusterVersion,OpGet,Join,GetEndKey,GetStore,Uint32,Println,WithTimeout,If,FastGenByArgs,Sprintf,OpP... | PrintConfigCheckMsg prints the version information of the PD and the configuration checks. returns the cluster ID of the last committed transaction. | why remove this? |
@@ -106,7 +106,7 @@ func (v *versionCmd) getMeshVersion() (*remoteVersionInfo, error) {
return nil, err
}
if len(controllerPods.Items) == 0 {
- return nil, errors.Errorf("No mesh found in namespace [%s]", v.namespace)
+ return nil, errors.Errorf("No mesh found for namespace [%s]", v.namespace)
}
controll... | [proxyGetMeshVersion->[Itoa,Wrapf,CoreV1,Unmarshal,ProxyGet,Errorf,DoRaw,Pods,TODO],setKubeClientset->[RESTClientGetter,Wrap,NewForConfig,ToRESTConfig],outputVersionInfo->[Fprintf],getMeshVersion->[proxyGetMeshVersion,Errorf],setKubeClientset,Wrap,GetInfo,Namespace,outputVersionInfo,getMeshVersion,Flags,BoolVar] | getMeshVersion returns the version information of the mesh. | "No mesh found in namespace [%s]" translates to there was no osm control plane installed **in** the namespace (the default is `osm-system`) |
@@ -1192,6 +1192,14 @@ class Variable(object):
if self.persistable:
var_str = "persist " + var_str
+ from paddle.distributed.auto_parallel.context import get_default_distributed_context
+ dist_context = get_default_distributed_context()
+ var_dist_attr = dist_context.get_ten... | [is_compiled_with_rocm->[is_compiled_with_rocm],_set_expected_place->[_set_dygraph_tracer_expected_place],cuda_places->[is_compiled_with_cuda,_cuda_ids],_dygraph_place_guard->[_set_dygraph_tracer_expected_place],_get_paddle_place->[is_compiled_with_cuda,is_compiled_with_xpu],_varbase_creator->[convert_np_dtype_to_dtype... | Returns a readable version of the object. Returns a debug string describing the missing variable in the current block. | why not import at the beginning of file |
@@ -465,7 +465,7 @@ public class FlowControlHandlerTest {
channel.register();
// Reset read timeout by some message
- assertTrue(channel.writeInbound(Unpooled.EMPTY_BUFFER));
+ assertFalse(channel.writeInbound(Unpooled.EMPTY_BUFFER));
channel.flushInbound();
assertEqu... | [FlowControlHandlerTest->[testFlowToggleAutoRead->[newClient,newServer],testReentranceNotCausesNPE->[newClient,newServer],testFlowAutoReadOn->[newClient,newServer],testAutoReadingOn->[newClient,newServer],testFlowAutoReadOff->[newClient,newServer],testAutoReadingOff->[newClient,newServer]]] | Test swallowed read complete. | @carryxyh can you explain why these changes are needed ? |
@@ -107,6 +107,14 @@ namespace Microsoft.Xna.Framework
return value1;
}
+ /// <summary>
+ /// Performs vector addition on <paramref name="value1"/> and
+ /// <paramref name="value2"/>, storing the result of the
+ /// addition in <paramref name="result"/>.
+ ///... | [Vector2->[GetHashCode->[GetHashCode],Transform->[Length,Transform,Multiply],CatmullRom->[CatmullRom],SmoothStep->[SmoothStep],Hermite->[Hermite],Lerp->[Lerp],Barycentric->[Barycentric],Clamp->[Clamp],Equals->[Equals],ToString->[ToString]]] | Add two Vector2s and return the result. | This could be simpler: "The result of the vector addition." |
@@ -13,7 +13,7 @@ import (
)
const (
- busyboxImage = "docker.io/busybox"
+ diagnosticsImage = "openshift/diagnostics-deployer"
networkDiagTestPodSelector = "network-diag-pod-name"
testPodImage = "docker.io/openshift/hello-openshift"
| [ToLower,Sprintf,FromInt] | GetNetworkDiagnosticsPod returns a pod object that can be used to run a network diagnostic GetTestPod returns a pod object that can be used to mount a container with a specific. | Is this affected by imageConfig.format? If not how should this work for OSE where the images are usually 'openshift3/ose-${component}:${version}' ? |
@@ -75,9 +75,8 @@ FINGERPRINTS = {
{257: 5, 258: 8, 264: 8, 268: 8, 274: 2, 280: 8, 284: 8, 288: 7, 290: 6, 292: 8, 300: 8, 308: 8, 320: 8, 324: 8, 331: 8, 332: 8, 344: 8, 352: 8, 362: 8, 368: 8, 376: 3, 384: 8, 388: 4, 416: 7, 448: 6, 456: 4, 464: 8, 500: 8, 501: 8, 512: 8, 514: 8, 520: 8, 532: 8, 544: 8, 557: 8,... | [dbc_dict] | The 8th - bit of the number of characters that are not allowed in the number of CAR. JEEP_CHEROKEE_2019 - [ 8 - bit 8 - bit 8 - bit 8 - bit 8 - bit 8 - bit. | This isn't a superset of the current fingerprint, since 806 is now missing. |
@@ -47,7 +47,7 @@ func (i *LibpodAPI) ListContainers(call iopodman.VarlinkCall) error {
func (i *LibpodAPI) GetContainer(call iopodman.VarlinkCall, id string) error {
ctr, err := i.Runtime.LookupContainer(id)
if err != nil {
- return call.ReplyContainerNotFound(id)
+ return call.ReplyContainerNotFound(id, err.Er... | [DeleteStoppedContainers->[RemoveContainer],GetContainerStats->[GetContainerStats],RemoveContainer->[RemoveContainer]] | GetContainer returns the container with the given id. | Could you just pass in error and then everyone would not need to call Error()? |
@@ -57,12 +57,9 @@ public class LockManager<R> {
* @param fair - true to use fair lock ordering, else non-fair lock ordering.
*/
public LockManager(final Configuration conf, boolean fair) {
- final int maxPoolSize = conf.getInt(
- HddsConfigKeys.HDDS_LOCK_MAX_CONCURRENCY,
- HddsConfigKeys.HD... | [LockManager->[readLock->[acquire],readUnlock->[release],writeLock->[acquire],decrementActiveLockCount->[computeIfPresent,decrementActiveCount,returnObject,getActiveLockCount],lock->[writeLock],unlock->[writeUnlock],getLockForReleasing->[IllegalMonitorStateException,containsKey,error,get],release->[getLockForReleasing,... | Creates a LockManager instance that manages the locks on a given resource. Unlocks the read lock on a resource. | NIT: we don't need to explicitly set -1 as the default maxTotal from GenericObjectPool is -1. |
@@ -30,8 +30,7 @@ import (
const (
defaultLogTimeFormat = "2006/01/02 15:04:05"
defaultLogMaxSize = 300 // MB
- defaultLogMaxBackups = 3
- defaultLogMaxAge = 28 // days
+ defaultLogFormat = "text"
defaultLogLevel = log.InfoLevel
logDirMode = 0755
| [Fire->[Callers,FileLine,Name,Base,FuncForPC],Format->[Fprintf,Infof,Format,Sprint,Warningf,WriteByte,String,Errorf,Fatalf,Bytes,WriteString,Debugf],Write,Dir,AddHook,Stat,IsDir,Contains,New,SetFormatter,ToLower,SetOutput,Errorf,SetLevel,Trace,MkdirAll] | Deserialize a log related config in toml format. Sprint prints the given package name and the number of entries. | any benefit to disabling timestamp? |
@@ -73,6 +73,9 @@ func serverEngine(app *services.ChainlinkApplication) *gin.Engine {
v2.GET("/backup", backup.Show)
}
+ cc := ConfigController{app}
+ engine.GET("/config", cc.Show)
+
return engine
}
| [Status,Warn,ClientIP,DELETE,NewBox,GET,Now,POST,ReadFrom,Error,Format,Infow,New,BasicAuth,Bytes,Sub,NewBuffer,NoRoute,Data,Next,Recovery,StaticFS,Ext,Group,Use,NopCloser,Sprintf,PATCH,String,Open,ReadAll] | guiEngine creates a GUI engine for the chainlink - related actions NewBox returns a gin. HandlerFunc that serves a page with a header containing the box content. | I personally would version config `/v2/config` |
@@ -245,7 +245,7 @@ if ($result) {
if ($limit > 0 && $limit != $conf->liste_limit) {
$param .= '&limit='.urlencode($limit);
}
- if ($optioncss != '') {
+ if (!empty($optioncss)) {
$param .= '&optioncss='.urlencode($optioncss);
}
if ($search_code) {
| [create,formconfirm,fetch_object,jdate,lasterror,order,rollback,getLoginUrl,begin,idate,load,plimit,loadLangs,close,showFilterAndCheckAddButtons,textwithpicto,selectDate,free,query,trans,num_rows,commit] | Get the list of national - national - national - national - national This function is used to add the search parameters to the url. | Same here. Following the template htdocs/modulebuilder/template/myobject_list.php a better fix would be to initialize the $optioncss like it is into the example skeleton so adding at top of page `$optioncss = GETPOST('optioncss', 'aZ'); // Option for the css output (always '' except when 'print')` |
@@ -41,14 +41,14 @@ import org.joda.time.Instant;
/**
- * A {@link org.apache.beam.sdk.transforms.CombineFnBase.PerKeyCombineFn}
+ * A {@link org.apache.beam.sdk.transforms.CombineFnBase.GlobalCombineFn}
* with a {@link org.apache.beam.sdk.transforms.CombineWithContext.Context} for the SparkRunner.
*/
public ... | [SparkKeyedCombineFn->[apply->[apply],mergeValue->[createCombiner],extractOutput->[apply->[extractOutput]]]] | Imports the given object from the Spark library. Unlike the combineByKey function this function creates a combiner for the given windowed values. | This should be renamed. |
@@ -122,12 +122,12 @@ module.exports = {
process: function(src, NG_VERSION, strict) {
var processed = src
- .replace(/"NG_VERSION_FULL"/g, NG_VERSION.full)
- .replace(/"NG_VERSION_MAJOR"/, NG_VERSION.major)
- .replace(/"NG_VERSION_MINOR"/, NG_VERSION.minor)
- .replace(/"NG_VERSION_DOT"/, N... | [No CFG could be retrieved] | Provide a list of all the NG_VERSION files and their corresponding js and css files Private function to process a single file. | I could find this anywhere inside the codebase. It is probably not needed, but left it just in case. |
@@ -392,8 +392,14 @@ public final class PullQueryExecutor {
private static TableRows forwardTo(
final KsqlNode owner,
final ConfiguredStatement<Query> statement,
- final ServiceContext serviceContext
+ final ServiceContext serviceContext,
+ final PullQueryContext pullQueryContext
) {
... | [PullQueryExecutor->[ConfigRoutingOptions->[getLong->[getLong],getOffsetLagAllowed->[getLong],skipForwardRequest->[getForwardedFlag]],extractWhereInfo->[WhereInfo],analyze->[analyze],extractWhereClauseWindowBounds->[WindowBounds,extractWhereClauseWindowBounds],extractComparisons->[extractComparisons]]] | Forward to the given sequence of rows. | I'm worried this approach doesn't scale well for things other than `IN` queries (not to mention that it feels hacky). Instead, it probably makes sense to have a way to specify that a pull query (internally routed only) should only read from certain partitions. Otherwise, how would we handle things like range queries? I... |
@@ -112,7 +112,8 @@ class MediaDataProvider extends BaseDataProvider
array $options = [],
$limit = null,
$page = 1,
- $pageSize = null
+ $pageSize = null,
+ UserInterface $user = null
) {
if (($filters['dataSource'] ?? null) === null) {
return n... | [MediaDataProvider->[getOptions->[getValue,getCurrentRequest,get],getSerializationContext->[setGroups],resolveDatasource->[getById,getTitle,getId],__construct->[getConfiguration]]] | Resolves resource items for a given . | Is this still needed if we set the tokenStorage in the constructor? |
@@ -705,6 +705,9 @@ class DialogData(object):
'cands': self.cands,
'image_loader': self.image_loader,
}
+ if hasattr(self, '_num_examples_cache'):
+ shared['num_examples_cache'] = (self._num_examples_cache,)
+ shared['num_episodes_cache'] = (self._num_epis... | [create_task_agent_from_taskname->[_add_task_flags_to_agent_opt,get,MultiTaskTeacher],StreamDialogData->[reset->[_load],num_examples->[load_length],num_episodes->[load_length],__init__->[get],load_length->[_read_episode],get->[build_table],_data_generator->[_read_episode]],FbDialogTeacher->[__init__->[get]],DialogData-... | Returns a new object with all the data and cands shared by this object. | why do we use tuple here? |
@@ -1110,3 +1110,13 @@ GRAPPELLI_INDEX_DASHBOARD = 'admin_dashboard.CustomIndexDashboard'
DBGETTEXT_PATH = 'apps/'
DBGETTEXT_ROOT = 'translations'
+
+def get_user_url(user):
+ from sumo.urlresolvers import reverse
+ return reverse('devmo.views.profile_view', args=[user.username])
+
+ABSOLUTE_URL_OVERRIDES = {... | [JINJA_CONFIG->[MemcachedBytecodeCache,isinstance],lazy_langs->[dict,lower],lazy_language_deki_map->[dict],node,lazy,listdir,join,remove,abspath,dict,replace,%,append,dirname,sorted,tuple,items,path,_,basename,isdir,setup_loader,dumps,lower] | DETAILS - DBGETTEXT. | I assume django-badger users auth.user absolute url's? This is a nice little shim anyway. |
@@ -47,7 +47,7 @@ public class StringParameterValue extends ParameterValue {
super(name, description);
this.value = value;
}
-
+
/**
* Exposes the name/value as an environment variable.
*/
| [StringParameterValue->[hashCode->[hashCode],equals->[equals]]] | Add the missing environment variables to the environment. | Whats with the whitespace? Perhaps you should apply some trim |
@@ -93,7 +93,9 @@ public class MongoDBComponent extends DefaultComponent implements MongoDBConnect
config = getDescriptor(XP_CONNECTION, DEFAULT_CONNECTION_ID);
client = clients.get(DEFAULT_CONNECTION_ID);
}
- return MongoDBConnectionHelper.getDatabase(client, config.dbname);
+... | [MongoDBComponent->[start->[start],getDatabase->[getDatabase],stop->[stop]]] | Gets the database with the given id. | Please factor this duplicated code to a helper method. |
@@ -231,7 +231,7 @@ export class AmpAnalytics extends AMP.BaseElement {
* @return {!Promise|undefined}
* @private
*/
- onFetchRemoteConfigSuccess_() {
+ onConfigRewriteSuccess_() {
this.config_ = this.mergeConfigs_();
if (this.hasOptedOut_()) {
| [No CFG could be retrieved] | Handle successful fetching of remote config. Create an AnalyticsGroup. | 2 small things can be improved: 1. we are unnecessarily passing values via class member fields. 2. naming `onConfigRewriteSuccess_` is a bit mis-leading, since this method also gets called when config-rewriter is not enabled. Proposal: - Move `this.config_= this.mergeConfigs_()` out to `rewriteConfig_` function. Don't ... |
@@ -81,7 +81,7 @@ func (i *Image) ImageDelete(imageRef string, force, prune bool) ([]types.ImageDe
if err != nil {
switch err := err.(type) {
case *storage.DeleteImageLocked:
- return nil, fmt.Errorf("Failed to remove image (%s): ", imageRef, err.Payload.Message)
+ return nil, fmt.Errorf("Failed to remove i... | [SearchRegistryForImages->[Errorf],ImportImage->[Errorf],Commit->[Errorf],ExportImage->[Errorf],Images->[Begin,Reverse,Sort,End,GetImages,ImageCache],ImageHistory->[Errorf],TagImage->[Errorf],ImageDelete->[DeleteImage,LayerCache,Infof,Begin,UUID,RemoveImageByConfig,GetImage,Remove,End,ImageCache,Errorf,WithID,WithStore... | ImageDelete deletes an image from the image store. | maybe using %q? => "Failed to remove image %q: %s" |
@@ -779,7 +779,7 @@ namespace System.Collections.Generic
TKey d = keys[lo + i - 1];
TValue dValue = values[lo + i - 1];
- while (i <= n / 2)
+ while (i <= n >> 1)
{
int child = 2 * i;
if (child < n && comparer.Compare(keys[... | [GenericArraySortHelper->[IntroSort->[IntroSort,HeapSort,PickPivotAndPartition,InsertionSort,SwapIfGreaterWithValues,SwapIfGreater],PickPivotAndPartition->[SwapIfGreaterWithValues,Swap,SwapIfGreater],HeapSort->[Swap,DownHeap],IntrospectiveSort->[IntroSort,FloorLog2PlusOne],Sort->[IntrospectiveSort,ThrowOrIgnoreBadCompa... | DownHeap - Shifts the heap from lo to lo + i. | I'm just curious about this, is the JIT not able to transform `int / c` where c is a power of 2 into `(uint)int >> Log2(c)`? |
@@ -16,6 +16,10 @@ from raiden.transfer.state import (
from raiden.utils import pex
from raiden.utils.typing import Address, Dict
+if TYPE_CHECKING:
+ # pylint: disable=unused-import
+ from raiden.network.transport.udp.udp_transport import UDPTransport
+
log = structlog.get_logger(__name__) # pylint: disabl... | [healthcheck->[pex,debug,get_host_port,get_ping,repeat,timeout_exponential_backoff,state_from_raiden,wait,is_set,get_node_network_status,set,retry,set_node_network_state,clear,next],get_logger,namedtuple] | Create a healthcheck function that sends a periodical ping to a node. Send a Ping to a recipient. | Some files have these guys at the bottom and some at the top, I moved them up because they are imports and to try to get a consistent way of doing this |
@@ -175,6 +175,11 @@ public class HoodieCopyOnWriteTable<T extends HoodieRecordPayload> extends Hoodi
public Iterator<List<WriteStatus>> handleUpdate(String commitTime, String fileId,
Iterator<HoodieRecord<T>> recordItr) throws IOException {
+ // This is needed since sometimes some buckets are never pick... | [HoodieCopyOnWriteTable->[UpsertPartitioner->[assignInserts->[addUpdateBucket,BucketInfo,InsertBucket],addUpdateBucket->[BucketInfo],getSmallFiles->[SmallFile]],handleInsertPartition->[handleUpsertPartition],SmallFile->[toString->[toString]],BucketInfo->[toString->[toString]],getInsertPartitioner->[getUpsertPartitioner... | Updates the given records in the given file. | should this be done on insert as well? |
@@ -915,7 +915,7 @@ namespace Internal.JitInterface
// a static method would have never found an instance method.
if (originalMethod.Signature.IsStatic && (flags & CORINFO_CALLINFO_FLAGS.CORINFO_CALLINFO_CALLVIRT) != 0)
{
- throw new BadImageFormatException();
+ ... | [CorInfoImpl->[FilterNamedIntrinsicMethodAttribs->[Equals],EncodeFieldBaseOffset->[HasLayoutMetadata,IsLayoutFixedInCurrentVersionBubble,PreventRecursiveFieldInlinesOutsideVersionBubble,IsInheritanceChainLayoutFixedInCurrentVersionBubble],IsInheritanceChainLayoutFixedInCurrentVersionBubble->[IsLayoutFixedInCurrentVersi... | This is a helper method for getting the call info for a given cee call. Returns the module that will be used to transform the given node into the correct type. Try a partial resolve of a . Initialize a single object that can be used to call a method or a type. | This is not related to the fix, but it seems that we should not fail the whole build for this case, just the function compilation. |
@@ -500,14 +500,14 @@ class ChatThreadClient(object):
self,
thread_participants: List[ChatThreadParticipant],
**kwargs
- ) -> None:
+ ) -> AddChatParticipantsResult:
"""Adds thread participants to a thread. If participants already exist, no change occurs.
:param thre... | [ChatThreadClient->[__aexit__->[__aexit__],close->[close],send_typing_notification->[send_typing_notification],__aenter__->[__aenter__]]] | Adds thread participants to a thread. | We should unpackage this result type. It's currently pretty hard to use... If you could write a sample demonstrating what a customer has to do to: - Add 5 participants - Determine which 2 our of those 5 failed. - Re-attempt to add those 2 failures. From their we can figure out the best response value here. |
@@ -5,13 +5,13 @@ from django.http import HttpResponse
from django.test import RequestFactory
-from kuma.core.decorators import (block_user_agents, logout_required,
- login_required, never_cache,
- skip_in_maintenance_mode,
+from kuma.core.decorator... | [LogoutRequiredTestCase->[test_logged_in_argument->[view,eq_,get,logout_required],test_logged_in_default->[view,eq_,get,logout_required],test_logged_out_default->[AnonymousUser,get,logout_required,eq_,view],RequestFactory],PermissionRequiredTestCase->[test_logged_in_default->[permission_required,view,eq_,get],test_logg... | Simple view of a single node. | Another ``ok_`` gone! |
@@ -130,6 +130,7 @@ module.exports = class extends BaseGenerator {
defaults: false
});
+ this.availableGeneratorConfig = this.options.availableGeneratorConfig;
this.skipClient = this.configOptions.skipClient = this.options['skip-client'] || this.config.get('skipClient');
... | [No CFG could be retrieved] | Adds support for a specific configuration option which can be used to specify a database name when skipping The initialisation method for the object. | @MathieuAA I think this might be duplication of the `configOptions` param that is passed around, can you check? The purpose of `configOptions` was to pass context around when composing so please do see if you are able to use it without introducing a new param |
@@ -221,7 +221,7 @@ namespace System.Collections.Immutable
[Pure]
public bool TryGetValue(T equalValue, out T actualValue)
{
- int hashCode = _equalityComparer.GetHashCode(equalValue);
+ int hashCode = _equalityComparer.GetHashCode(equalValue!);
HashBucket b... | [ImmutableHashSet->[Clear->[Clear],UpdateRoot->[Remove],IsProperSupersetOf->[IsProperSupersetOf,Contains],Except->[Except],SymmetricExcept->[SymmetricExcept],Add->[Add],Union->[Union,WithComparer],IsSubsetOf->[IsSubsetOf,Contains],Contains->[TryGetValue,Contains],TryGetValue->[TryGetValue],IsProperSubsetOf->[IsProperSu... | TryGetValue - Try to find the value in the hash bucket. | :memo: should we remove the `[DisallowNull]` on that `GetHashCode`, or add `[DisallowNull]` here? (same question below) #Resolved |
@@ -831,7 +831,16 @@ void MapgenBasic::dustTopNodes()
}
content_t c = vm->m_data[vi].getContent();
- if (!ndef->get(c).buildable_to && c != CONTENT_IGNORE && c != biome->c_dust) {
+ NodeDrawType dtype = ndef->get(c).drawtype;
+ // Only place on walkable cubic non-liquid nodes
+ // Dust check needed due to v... | [readParams->[readParams],saoPosOverLimit->[calcMapgenEdges],lightSpread->[lightSpread],generateCaves->[generateCaves],getSpawnRangeMax->[calcMapgenEdges],spreadLight->[lightSpread],generateCaverns->[generateCaverns],updateHeightmap->[findGroundLevel],writeParams->[writeParams]] | dustTopNodes - Dust top nodes if c! = CONTENT_IGNORE and c! = CONTENT_DUST add it to. | wouldn't a negative check be way shorter here? |
@@ -427,6 +427,8 @@ func (c APIClient) CreatePipeline(
input *pps.Input,
outputBranch string,
update bool,
+ datumTimeout string,
+ jobTimeout string,
) error {
_, err := c.PpsAPIClient.CreatePipeline(
c.Ctx(),
| [DeletePipeline->[DeletePipeline],RerunPipeline->[RerunPipeline],CreatePipeline->[CreatePipeline],InspectJob->[InspectJob],InspectDatum->[InspectDatum],RestartDatum->[RestartDatum],CreatePipelineService->[CreatePipeline],GarbageCollect->[GarbageCollect],StartPipeline->[StartPipeline],InspectPipeline->[InspectPipeline],... | CreatePipeline creates a new pipeline. | These shouldn't be on the base `CreatePipeline` method. They're too rarely used to make people specify them as `0` everytime they make a pipeline. |
@@ -226,6 +226,7 @@ public class CopyDataPublisher extends DataPublisher implements UnpublishedHandl
additionalMetadata.put(SlaEventKeys.SOURCE_URI, this.state.getProp(SlaEventKeys.SOURCE_URI));
additionalMetadata.put(SlaEventKeys.DESTINATION_URI, this.state.getProp(SlaEventKeys.DESTINATION_URI));
+ addi... | [CopyDataPublisher->[getCommitSequence->[compare->[compare]]]] | Publish a fileSet from the given collection of work units. Checks if there is a copyable file in the list of work units that can be published. | Perhaps it is better to make it clear the output path is unknown instead of leaving it empty. |
@@ -84,6 +84,9 @@ def test_initiator_log_directransfer_success(
]
assert sucessful_transfers[0] == EventTransferSentSuccess(
identifier,
+ amount,
+ app1.raiden.address,
+
)
| [test_initiator_log_directransfer_success->[int,get_all_state_events,direct_transfer,EventTransferSentSuccess,isinstance],test_initiator_log_directransfer_action->[int,direct_transfer,isinstance,ActionTransferDirect,get_all_state_changes],test_target_log_directransfer_successevent->[EventTransferReceivedSuccess,int,get... | Test if the initiator log direct transfer success event is emitted. | Remove unnecessary newline here |
@@ -154,6 +154,9 @@ func exitOnError(result keybase1.InstallResult) {
os.Exit(1)
}
for _, r := range result.ComponentResults {
+ if r.ExitCode != 0 {
+ os.Exit(r.ExitCode)
+ }
if r.Status.Code != 0 {
os.Exit(2)
}
| [runInstall->[Status,CheckIfValidLocation,Sprintf,Install,G,StatusFromCode,Errorf,AutoInstallWithStatus],ParseArgv->[String,Split,Bool,Duration],Run->[GetTerminalUI,Uninstall,Printf,Fprintf,InstallAuto,G,AppBundleForPath,MarshalIndent,runInstall],GetTerminalUI,Printf,Pid,Sprintf,ListServices,SetLogForward,NewContextifi... | Run - Installs the given components. uninstall returns a command to uninstall a component. | Shouldn't we log all component failures first? Or is it assumed that only one will fail? |
@@ -349,9 +349,9 @@ class SubtitlesFinder(object):
if sickbeard.TV_DOWNLOAD_DIR and os.path.isdir(sickbeard.TV_DOWNLOAD_DIR):
for root, _, files in os.walk(sickbeard.TV_DOWNLOAD_DIR, topdown=False):
- rar_files = [x for x in files if isRarFile(x)]
+ rar_files = [fil... | [code_from_code->[from_code],enabled_service_list->[sorted_service_list],get_needed_languages->[wanted_languages],name_from_code->[from_code],download_subtitles->[needs_subtitles,get_needed_languages,enabled_service_list],needs_subtitles->[wanted_languages],SubtitlesFinder->[subtitles_download_in_pp->[needs_subtitles,w... | Download subtitles in a folder in a Post - Process folder. Download the best subtitles for each video file. This function is called when a subtitle is found in the video. It will save the. | cannot use the reserved name "file" as it is the name of a builtin. |
@@ -46,10 +46,10 @@ public class DatabaseMigrator implements ServerComponent, Startable {
private final ServerUpgradeStatus serverUpgradeStatus;
/**
- * ServerPluginRepository is used to ensure H2 schema creation is done only after copy of bundle plugins have been done
+ * ServerPluginInstaller is used to e... | [DatabaseMigrator->[createSchema->[createSchema]]] | Implementation of the database migrator. This method is called to create the schema for the . | why changing the name of the parameter (therefore confirming an issue) instead of removing the parameter? |
@@ -100,6 +100,11 @@ public class UnitImageFactory {
icons.clear();
}
+ public Image getImage(final UnitCategory unit) {
+ return getImage(unit.getType(), unit.getOwner(), (unit.getDamaged() > 0), unit.getDisabled())
+ .orElseThrow(() -> new RuntimeException("No unit image for: " + unit));
+ }
+
... | [UnitImageFactory->[getBaseImage->[getImage,getBaseImageUrl],getIcon->[getBaseImage],getBaseImageUrl->[getBaseImageUrl]]] | Get the image for a specific unit type. | I'm not sure if it's good practice to throw raw RuntimeExceptions. I'd rather throw IllegalState or IllegalArgument exception instead, but maybe that's just preference. |
@@ -341,7 +341,7 @@ func resourceAwsRoute53HealthCheckCreate(d *schema.ResourceData, meta interface{
d.SetId(aws.StringValue(resp.HealthCheck.Id))
- if err := keyvaluetags.Route53UpdateTags(conn, d.Id(), route53.TagResourceTypeHealthcheck, map[string]interface{}{}, d.Get("tags").(map[string]interface{})); err != ... | [StringLenBetween,GetChange,UniqueId,GetHealthCheck,IgnoreAws,Route53ListTags,StringInSlice,UpdateHealthCheck,Set,Code,GetOk,HasChange,HasChanges,CreateHealthCheck,Errorf,SetId,Bool,IntInSlice,Equal,IgnoreConfig,ToUpper,Id,Int64,DeleteHealthCheck,Get,ParseIP,Map,Printf,StringValue,Route53UpdateTags,Sprintf,IntAtMost,St... | This function is used to populate the cloudwatch health check object with the data from the resource read - read healthcheck config. | i _think_ here we'll need to pass in `tags.Map()` instead of `tags` since the `Route53UpdateTags` method will call `New` on the tags and result in a new `KeyValueTags` instance but without the values originally in it |
@@ -259,8 +259,18 @@ public class VirtualRoutingResource {
return new GetDomRVersionAnswer(cmd, result.getDetails(), lines[0], lines[1]);
}
+ public boolean configureHostParams(final Map<String, String> params) {
+ if (_params.get("router.aggregation.command.each.timeout") == null) {
+ ... | [VirtualRoutingResource->[connect->[connect],execute->[generateCommandCfg,applyConfigToVR],applyConfigToVR->[applyConfigToVR],applyConfig->[applyConfigToVR]]] | Executes the GetDomRVersionCmd and returns the answer. | Why do we need this check? |
@@ -34,7 +34,7 @@ const ampCliRunner = 'build-system/task-runner/amp-cli-runner.js';
* @return {Promise<void>}
*/
async function installAmpTaskRunner() {
- const npmBinDir = getStdout('npm bin --global').trim();
+ const npmBinDir = getStdout('npm bin --user').trim();
const ampBinary = path.join(npmBinDir, 'am... | [No CFG could be retrieved] | Installs the AMP task runner if it hasn t already been installed. | The task runner is intentionally installed to the global npm bin directory because the local one lives inside the repo dir, and is typically not part of the system path. Changing the install path to the second location will likely break the `amp` command during local development. Instead of changing the destination dir... |
@@ -569,7 +569,13 @@ def create_image_file(
image = create_image_or_video_tensor(size)
file = pathlib.Path(root) / name
- PIL.Image.fromarray(image.permute(2, 1, 0).numpy()).save(file, **kwargs)
+
+ # torch (num_channels x height x width) -> PIL (width x height x num_channels)
+ image = image.permu... | [DatasetTestCase->[test_smoke->[create_dataset],test_not_found_or_corrupted->[create_dataset],test_num_examples->[create_dataset],test_transforms->[create_dataset],_inject_fake_data->[UsageError,inject_fake_data],test_str_smoke->[create_dataset],_verify_required_public_class_attributes->[UsageError],create_dataset->[da... | Create an image file from random data. If callable will be called with the index of the corresponding file. If not omitted a random. | nit: you can avoid having to import `numpy` if you do the squeeze while it's a tensor |
@@ -105,6 +105,7 @@ export function installRuntimeServices(global) {
* @param {!Object<string, string>=} opt_initParams
*/
export function installAmpdocServices(ampdoc, opt_initParams) {
+ installUrlForDoc(ampdoc);
installCidService(ampdoc);
installDocumentInfoServiceForDoc(ampdoc);
installViewerServiceF... | [No CFG could be retrieved] | Imports all of the runtime - level services and ampdoc - level services. A shared version of the that can be used to adopt the frame. | Do we already do some URL parsing on startup? Wondering if this would impact initial load. |
@@ -29,6 +29,10 @@ class GitBitbucketDriver extends VcsDriver implements VcsDriverInterface
protected $branches;
protected $rootIdentifier;
protected $infoCache = array();
+ /**
+ * @var GitDriver
+ */
+ protected $gitDriver;
/**
* {@inheritDoc}
| [GitBitbucketDriver->[getRootIdentifier->[getContents,getScheme],getComposerInformation->[getContents,getScheme,read,write],getTags->[getContents,getScheme],getDist->[getScheme],supports->[writeError],getSource->[getUrl],getBranches->[getContents,getScheme],initialize->[get]]] | Initializes the configuration. | I suggest making this new property private. Private things are easier to maintain as they are not covered by any backward compatibility concern and so can change anytime we need it (while protected stuff are harder to change outside of major versions) |
@@ -63,6 +63,8 @@ struct pool_svc {
struct ds_pool *ps_pool;
};
+static bool pool_disable_evict = false;
+
static struct pool_svc *
pool_svc_obj(struct ds_rsvc *rsvc)
{
| [No CFG could be retrieved] | Package containing the server - side version of the n - ary metadata. Retrieve the pool map buffer address and the pool map version into map_buf and map_. | (style) do not initialise statics to false |
@@ -326,6 +326,14 @@ func BootstrapCluster(ctx context.Context, k8sGardenClient, k8sSeedClient kubern
return err
}
+ // HVPA feature gate
+ hvpaEnabled := gardenletfeatures.FeatureGate.Enabled(features.HVPA)
+ if !hvpaEnabled {
+ if err := common.DeleteHvpa(ctx, k8sSeedClient, v1beta1constants.GardenNamespace);... | [GetIngressFQDNDeprecated->[Sprintf],Build->[seedObjectFunc],GetIngressFQDN->[Sprintf],GetValidVolumeSize->[String,ParseQuantity,Cmp],CheckMinimumK8SVersion->[Version,CompareVersions,Errorf],WithSeedObjectFromLister->[Get],IsAlreadyExists,DeleteLoggingStack,CreateSHA1Secret,CopyApplierOptions,Status,GenerateCertificate... | returns an object that can be used to retrieve a specific version of the component. Fetches logging configuration for all components that are allowed to run. | Code duplication. What about extraction this into a function and calling it on the two places that use it? |
@@ -117,8 +117,11 @@ export class AmpDocService {
// Otherwise discover and possibly create the ampdoc.
let n = opt_node;
while (n) {
- // A custom element may already have the reference to the ampdoc.
- if (n.ampdoc_) {
+ // A custom element may already have the reference. If we are looki... | [No CFG could be retrieved] | Returns the AmpDoc object that contains the specified node. Gets the shell - shadow - doc for the given node. | This is definitely a big reason to switch fully to this mode very soon. |
@@ -0,0 +1,17 @@
+<?php
+/*
+ * LibreNMS
+ *
+ * Copyright (c) 2016 Søren Friis Rosiak <sorenrosiak@gmail.com>
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation, either version 3 of the Lice... | [No CFG could be retrieved] | No Summary Found. | Can you use the str_contains() function? It's no big deal, but I would like to convert all to use these functions. Thanks. |
@@ -59,7 +59,7 @@ const (
const (
// KubernetesDefaultRelease is the default Kubernetes release
- KubernetesDefaultRelease string = "1.10"
+ KubernetesDefaultRelease string = "1.11"
// KubernetesDefaultReleaseWindows is the default Kubernetes release
KubernetesDefaultReleaseWindows string = "1.9"
)
| [No CFG could be retrieved] | The maximum number of IP addresses in a single network. DCOSVersion1Dot8Dot8 string = 1. 8. 8. | this is almost too easy :p |
@@ -27,7 +27,6 @@ class VimeoTag < LiquidTagBase
def get_id(input)
match = input.match(REGISTRY_REGEXP)
- # binding.pry
match ? match[:video_id] : input
end
end
| [VimeoTag->[get_id->[match],render->[render],initialize->[strip_tags,get_id],freeze],register,register_tag] | Get the video id from the input string. | Oops! left this in a previous PR, taking it out now |
@@ -45,6 +45,8 @@ type NodePackageInfo struct {
ModuleToPackage map[string]string `json:"moduleToPackage,omitempty"`
// Toggle compatibility mode for a specified target.
Compatibility string `json:"compatibility,omitempty"`
+ // Disable support for unions in output types.
+ DisableUnionOutputTypes bool `json:"dis... | [ImportObjectTypeSpec->[Unmarshal],ImportPackageSpec->[Unmarshal]] | NodePackageInfo is a description for the package. returns a raw object and an error if it s not possible to find a . | Curious - Why does this need to be opt-in? What are the cases where we *do* want to emit union outputs? And perhaps knowing the answer to that will make clearer why this is a global setting vs. a per-property setting? |
@@ -550,8 +550,11 @@ public class CardBrowser extends NavigationDrawerActivity implements
@Override
public void onBackPressed() {
+
if (isDrawerOpen()) {
super.onBackPressed();
+ } else if (mInMultiSelectMode) {
+ endMultiSelectMode();
} else {
T... | [CardBrowser->[deleteNote->[getPosition,currentCardInUseByReviewer,updateList],onStop->[onStop],onResume->[onResume],onPostExecute->[getSubtitleText,updateCardInList,updateList],closeCardBrowser->[closeCardBrowser],onActivityResult->[onActivityResult],onCollectionLoaded->[onCollectionLoaded],onProgressUpdate->[updateCa... | On back pressed. | Unnecessary new line |
@@ -72,7 +72,7 @@ namespace Dynamo.ViewModels
get { return annotationModel.AnnotationText; }
set
{
- annotationModel.AnnotationText = value;
+ annotationModel.AnnotationText = value;
}
}
| [AnnotationViewModel->[AddToGroup->[AddToSelectedModels,Selection,IsSelected],CanAddToGroup->[Count],model_PropertyChanged->[RaisePropertyChanged,UpdateBoundaryFromSelection,PropertyName],UpdateFontSize->[RaiseCanExecuteUndoRedo,ExecuteCommand,Empty,ToString,GUID],Select->[ExecuteCommand,AsDynamoType,AddRange,SelectedM... | AnnotationViewModel is a base class for all of the annotations that are used by the annotation Private methods - addToGroupCommand - add to group command. | Hi @fanwgwg, please revert this file since there's no real change here. |
@@ -34,7 +34,7 @@ class RepoSyncManager(object):
Manager used to handle sync and sync query operations.
"""
@staticmethod
- def sync(repo_id, sync_config_override=None):
+ def sync(repo_id, sync_config_override=None, scheduled_call_id=None):
"""
Performs a synchronize operation on... | [_now_timestamp->[now_utc_datetime_with_tzinfo,format_iso8601_datetime],_repo_storage_dir->[get,join],RepoSyncManager->[sync_history->[list,int,limit,sort,append,parse_iso8601_datetime,len,MissingResource,get_collection,InvalidValue],queue_sync_with_auto_publish->[action_tag,apply_async_with_reservation,resource_tag],s... | Performs a synchronize operation on the given repository and returns a synchronization report. Synchronize the repository with the remote repository. | This needs `scheduled_call_id` added to the docblock. |
@@ -294,6 +294,16 @@ type MasterConfig struct {
// JenkinsPipelineConfig holds information about the default Jenkins template
// used for JenkinsPipeline build strategy.
JenkinsPipelineConfig JenkinsPipelineConfig
+
+ // AuditConfig holds information related to auditing capabilities.
+ AuditConfig AuditConfig
+}
... | [StringKeySet,NewString] | ImageConfig controls limits and behavior for importing images when a user does a bulk import of images. | Let's just call this `Enabled`. In the future we can add handler configs for the destinations (basic, files, events, etc) and keep this master flag for the on/off. |
@@ -250,12 +250,7 @@ public class Metadata
@Override
public int hashCode()
{
- int result = container.hashCode();
- result = 31 * result + Arrays.hashCode(aggregators);
- result = 31 * result + (timestampSpec != null ? timestampSpec.hashCode() : 0);
- result = 31 * result + (queryGranularity != nul... | [Metadata->[merge->[getAggregators,setQueryGranularity,setRollup,putAll,getQueryGranularity,setAggregators,getTimestampSpec,setTimestampSpec,get,isRollup,Metadata],equals->[equals],putAll->[putAll],hashCode->[hashCode],get->[get],put->[put],toString->[toString]]] | Returns a hash code for the specified missing - value object. | `equals` could be simplified too (using Objects.equals and Arrays.equals) |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.