patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -46,7 +46,16 @@ var _ = g.Describe("[Feature:Prometheus][Feature:Builds] Prometheus", func() {
defer func() { oc.AdminKubeClient().Core().Pods(ns).Delete(execPodName, metav1.NewDeleteOptions(1)) }()
g.By("verifying the oauth-proxy reports a 403 on the root URL")
- err := expectURLStatusCodeExec(ns, execP... | [KubeClient,By,WaitForOpenShiftNamespaceImageStreams,Expect,HaveOccurred,FixturePath,Delete,It,WaitForBuildResult,Args,AsAdmin,To,AdminKubeClient,Errorf,Namespace,StartBuildResult,NewDeleteOptions,Execute,NewCLI,BuildClient,BeEmpty,BeforeEach,AssertSuccess,ServiceAccounts,Builds,WaitForBuilderAccount,NotTo,Pods,Sleep,D... | requires that the OpenShift build is running and that the Prometheus API is installed. Checks if the build is running and if so waits for the build to complete. | i am acknowledging that you did not use wait.Poll but lgtm'ing anyway :) |
@@ -15,3 +15,12 @@ type FileSource interface {
Stat() (os.FileInfo, error)
Continuable() bool // can we continue processing after EOF?
}
+
+func NewFile(file *os.File, compression string) (FileSource, error) {
+
+ if config.GZipCompression == compression {
+ return newGZipFile(file)
+ } else {
+ return File{file... | [No CFG could be retrieved] | Stat - based stat implementation. | Overall I see multiple places in code with logic specific to GZip. When new compression type is supported, we'd need to modify all these places.. Is it possible to have all logic per compression type encapsulated in a single place? |
@@ -6,10 +6,7 @@ module SignUp
before_action :confirm_has_not_already_viewed_recovery_code, only: [:show]
def show
- if user_session.delete(:first_time_recovery_code_view).present?
- @show_progress_bar = true
- end
-
+ user_session.delete(:first_time_recovery_code_view)
@code = ... | [RecoveryCodesController->[confirm_has_not_already_viewed_recovery_code->[present?,redirect_to,after_sign_in_path_for],update->[redirect_to],show->[track_event,present?],before_action,include]] | This method shows the nag - time recovery code if it is present. If it is. | was this key only used to decide whether or not to show the progress bar? if so, we can just remove it entirely right? (stop setting it and stop reading it?) |
@@ -37,7 +37,8 @@ from pip.wheel import move_wheel_files
class InstallRequirement(object):
def __init__(self, req, comes_from, source_dir=None, editable=False,
- url=None, as_egg=False, update=True, prereleases=None):
+ url=None, as_egg=False, update=True, prereleases=None,
+ ... | [parse_requirements->[parse_requirements,from_line,from_editable],RequirementSet->[cleanup_files->[remove_temporary_source],install->[remove_temporary_source,rollback_uninstall,install,uninstall,values,commit_uninstall],uninstall->[values,commit_uninstall,uninstall],create_bundle->[_clean_zip_name,bundle_requirements],... | Initialize a new object with the given parameters. | Passing mutable objects as default values can lead to bugs, better to pass None and create the empty dict in the method. |
@@ -188,8 +188,7 @@ func NewMultitenantAlertmanager(cfg *MultitenantAlertmanagerConfig, cfgCfg confi
cluster.DefaultProbeInterval,
)
if err != nil {
- level.Error(util.Logger).Log("msg", "unable to initialize gossip mesh", "err", err)
- os.Exit(1)
+ return nil, errors.Wrap(err, "unable to initialize gos... | [deleteUser->[Stop],setConfig->[createTemplatesFile,transformConfig],Stop->[Stop],ServeHTTP->[ServeHTTP]] | NewInviteManager returns a new instance of the MultitenantAlertmanager. Run is a long running routine that periodically polls for new configuration updates. | This has removed the log, which is OK as far as it's logged somewhere in the parent. However, looking at `initAlertmanager()` (`modules.go`), in case `NewMultitenantAlertmanager()` returns error we do return "success" instead of the error. I think it's a bug. May you fix it, please? |
@@ -0,0 +1,9 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+internal static partial class Interop
+{
+ // Unix max paths are typically 1K or 4K UTF-8 bytes, 256 should handle the majority of paths
+ // without puttin... | [No CFG could be retrieved] | No Summary Found. | I wonder if the team has taken any measurements on this? What is typical path size? I would choose half of the maximum i.e. 512 so as to always have no more than one fallback (bufferSize *= 2). |
@@ -175,6 +175,7 @@ class TaskBase(SubsystemClientMixin, Optionable, AbstractClass):
self.context = context
self._workdir = workdir
+ self._task_name = type(self).__name__
self._cache_key_errors = set()
self._cache_factory = CacheSetup.create_cache_factory_for_task(self)
self._options_fing... | [TaskBase->[_build_invalidator->[stable_name],get_passthru_args->[supports_passthru_args,stable_name],invalidate->[_build_invalidator],implementation_version_str->[implementation_version],invoke_prepare->[_scoped_options],_options_fingerprint->[supports_passthru_args],_should_cache_target_dir->[artifact_cache_writes_en... | Subclass initialization of a task. | This should maybe/probably use `Task.stable_name`. |
@@ -208,8 +208,6 @@ namespace Dynamo.ViewModels
}
strBuilder.Append(", ");
}
-
- Analytics.LogPiiInfo("Filter-categories", strBuilder.ToString().Trim());
}
/// <summary>
| [SearchViewModel->[FocusSearch->[OnRequestFocusSearch],InsertEntry->[Dispose],DefineFullCategoryNames->[DefineFullCategoryNames],SearchAndUpdateResults->[SearchAndUpdateResults],Search->[SearchAndUpdateResults,Search],GetVisibleSearchResults->[GetVisibleSearchResults],IsSelectedChanged->[Filter],OnSearchElementClicked-... | This method filters out categories that are not selected or unselected. | When is this triggered? |
@@ -150,7 +150,9 @@ func (pack *cloudPolicyPack) Apply(ctx context.Context, op backend.ApplyOperatio
return pack.cl.ApplyPolicyPack(ctx, pack.ref.orgName, string(pack.ref.name), op.Version)
}
-func installRequiredPolicy(finalDir string, zip []byte) error {
+const npmPackageDir = "package"
+
+func installRequiredPo... | [Version->[Itoa],Install->[DownloadPolicyPack,Itoa,GetPolicyPath],Apply->[ApplyPolicyPack],String->[Sprintf],Publish->[Println,GetAnalyzerInfo,Name,PolicyAnalyzer,FromError,PublishPolicyPack,Process,Ref],RemoveAll,Printf,Dir,Wrapf,Sprintf,IgnoreError,Rename,TempDir,Base,Wrap,Unzip,MkdirAll,IsExist] | Apply applies the policy pack to the cloud. | For my own understanding, is `tarball []byte` here actually the tarball that was produced by `npm pack` or is it a zip file that contains the output of `npm pack`? |
@@ -10,9 +10,9 @@ module Api
submission = Submission.get_submission_by_grouping_id_and_assignment_id(
params[:group_id], params[:assignment_id])
- test_results = submission.test_script_results
+ test_results = submission.test_group_results
.includes(:test_results)
... | [TestResultsController->[destroy->[destroy],create->[create]]] | Returns a list of the nag with the given group and assignment. | Layout/MultilineMethodCallIndentation: Align .find with .test_group_results on line 13. |
@@ -11,9 +11,14 @@ import "strophe-caps";
import "jQuery-Impromptu";
import "autosize";
+// TODO: remove it after styles cleaning and progressbar fix
+// use new select2 plugin
+window.Select2 = require('select2');
+import 'select2-css';
import 'aui';
-import 'aui-experimental';
import 'aui-css';
+// don't overwr... | [No CFG could be retrieved] | The main function of the module. Builds and returns the room name. | It's only way to use `aui-experimental` with old `select2` plugin and new `select2` plugin. In other cases old select2 overwrites the new one It will be removed in next PR. |
@@ -58,7 +58,14 @@ func (pp PprofProfile) Transform(ctx context.Context, cfg *transform.Config) []b
valueFieldNames := make([]string, len(pp.Profile.SampleType))
for i, sampleType := range pp.Profile.SampleType {
sampleUnit := normalizeUnit(sampleType.Unit)
- valueFieldNames[i] = sampleType.Type + "." + sampleU... | [Transform->[Unix,Sprintf,Sum,New,NewV4,WriteString,Set]] | Transform transforms a profile into a slice of events. A function that can be used to identify stack traces and frames using a sequence of functions. event - event not found in the list of samples. | Convention says that the first value type is always the number of samples collected. However, for heap profiles this field is `alloc_objects.count`, which is explicitly aggregated on in fetcher.go (and passed to the pprof UI). |
@@ -1,4 +1,3 @@
-# encoding: utf-8
# This file is auto-generated from the current state of the database. Instead
# of editing this file, please use the migrations feature of Active Record to
# incrementally modify your database, and then regenerate this schema definition.
| [decimal,text,string,datetime,integer,add_index,create_table,float,boolean,define,date] | This file is automatically generated from the current state of the database. t is a table with all the necessary columns. | Please keep this line (for Ruby 1.9.3) |
@@ -70,15 +70,15 @@ public enum AtopTable
private final String name;
private final String atopLabel;
- private final List<AtopColumn> columns;
- private final Map<String, AtopColumn> columnIndex;
+ private final ImmutableList<AtopColumn> columns;
+ private final ImmutableMap<String, AtopColumn> ... | [varcharParser->[utf8Slice,writeSlice,get],baseColumnsAnd->[build,addAll,add,asList,builder],AtopColumn->[AtopColumn,getTimeZoneKey,get,getTypeSignature,requireNonNull,packDateTimeWithZone,writeLong,UnsupportedOperationException,valueOf],bigintParser->[get,writeLong,valueOf],getColumn->[get],round,toMap,writeLong,bigin... | Returns the base columns of the partition with the given additional columns. | We always interface types like `List`, not `ImmutableList`. Some code bases do use the immutable classes as types, but we do not, as we consider that an implementation detail. |
@@ -20,7 +20,7 @@ if (preg_match('/(SYS-(SW[0-9]+-)?5-CONFIG_I|VSHD-5-VSHD_SYSLOG_CONFIG_I): Confi
oxidized_node_update($hostname, $msg, $matches['user']);
} elseif (preg_match('/HWCM\/4\/CFGCHANGE/', $msg, $matches)) { //Huawei VRP devices CFGCHANGE syslog
oxidized_node_update($hostname, $msg);
-} elseif (p... | [No CFG could be retrieved] | Check if the node is running and if so update it. | Hi - The old message is still sent by other devices / versions ? if yes we should not remove it, but only add the COMMIT_PROGRESS one. - Is there a way to catch the user doing the change in the New message ? If no, then the oxidized_node_update should be updated accordingly |
@@ -110,8 +110,10 @@ def train_model(params: Params, serialization_dir: str) -> Model:
prepare_environment(params)
os.makedirs(serialization_dir, exist_ok=True)
- sys.stdout = TeeLogger(os.path.join(serialization_dir, "stdout.log"), sys.stdout) # type: ignore
- sys.stderr = TeeLogger(os.path.join(ser... | [train_model_from_file->[train_model,from_file],train_model->[Formatter,join,info,assert_empty,archive_model,ConfigurationError,FileHandler,from_params,index_instances,set,prepare_environment,makedirs,train,setLevel,pop,evaluate,read,items,TeeLogger,open,save_to_files,Dataset,deepcopy,getLogger,dump,setFormatter],train... | Trains a model on a single node in the model_params. json file. Reads all the data in the specified path and creates a new vocabulary. Returns the model if the is not empty. | Preference for one argument per line when you need to wrap arguments like this, but it's not a big deal if you prefer it this way. |
@@ -0,0 +1,12 @@
+# This migration comes from active_storage (originally 20191206030411)
+class CreateActiveStorageVariantRecords < ActiveRecord::Migration[6.0]
+ def change
+ create_table :active_storage_variant_records do |t|
+ t.belongs_to :blob, null: false, index: false
+ t.string :variation_digest, ... | [No CFG could be retrieved] | No Summary Found. | Style/PercentLiteralDelimiters: %i-literals should be delimited by ( and ).<br>Layout/SpaceInsidePercentLiteralDelimiters: Do not use spaces inside percent literal delimiters.<br>Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -892,7 +892,9 @@ type NewIssueOptions struct {
func newIssue(e *xorm.Session, doer *User, opts NewIssueOptions) (err error) {
opts.Issue.Title = strings.TrimSpace(opts.Issue.Title)
- opts.Issue.Index = opts.Repo.NextIssueIndex()
+ if opts.Issue.Index == 0 {
+ opts.Issue.Index = opts.Repo.NextIssueIndex()
+ }
... | [DiffURL->[HTMLURL],ChangeStatus->[changeStatus,APIFormat],IsTimetrackerEnabled->[loadRepo,IsTimetrackerEnabled],loadAttributes->[loadPullRequest,loadTotalTimes,loadRepo,loadLabels,IsTimetrackerEnabled,loadPoster,loadComments,loadReactions],ClearLabels->[loadPullRequest,loadRepo,APIFormat,clearLabels,loadPoster],Replac... | NewIssue returns the number of tasks in the issue content. Check if the user has already been passed to issue. AssigneeIDs if not add it. | Inserting random indexes has to update `NextIssueIndex` as well :| |
@@ -348,6 +348,7 @@ public class HiveConnectionPool extends AbstractControllerService implements Hiv
if (validationQuery != null && !validationQuery.isEmpty()) {
dataSource.setValidationQuery(validationQuery);
+ dataSource.setValidationQueryTimeout(validationQueryTimeout); // timeout ... | [HiveConnectionPool->[getConnection->[getConnection]]] | On configured. This method is called by the Kerberos authentication service to authenticate with the Kerberos server. | `DBCPConnectionPool` has a `getDataSource()` method in order to facilitate testing with mocks/stubs/delegates. It would be nice to have a unit test there and here (if possible) to exercise the timeout logic. Perhaps we can create a BasicDataSource delegate that returns mocked connections, and when a certain validation ... |
@@ -0,0 +1,9 @@
+module Events
+ class BustCacheJob < ApplicationJob
+ queue_as :events_bust_cache
+
+ def perform(cache_buster = CacheBuster.new)
+ cache_buster.bust_events
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Maybe `bust_events` since it busts the whole `/events` page? |
@@ -517,6 +517,10 @@ class VideoEntry {
this.videoLoaded()
);
listen(video.element, VideoEvents.PAUSE, () => this.videoPaused_());
+ listen(video.element, VideoEvents.PLAY, () => {
+ this.hasSeenPlayEvent_ = true;
+ analyticsEvent(this, VideoAnalyticsEvents.PLAY);
+ });
listen(vide... | [No CFG could be retrieved] | Replies the video object. Listens for events on video. element. | I asked this question offline. `play` event should be strictly before `playing` event, but can we guarantee this if the event are passed via postMessages. |
@@ -68,7 +68,7 @@ public class FailureManager {
f.fail(cluster);
} catch (Throwable t) {
LOG.info("Caught exception while inducing failure:{}", f.getName(), t);
- System.exit(-2);
+ throw new RuntimeException();
}
}
| [FailureManager->[getBoundedRandomIndex->[nextInt],start->[info,scheduleAtFixedRate],stop->[cancel,shutdown,awaitTermination,get],isFastRestart->[nextBoolean],fail->[getBoundedRandomIndex,getName,size,get,info,exit,fail],validateFailure,newInstance,getLogger,newSingleThreadScheduledExecutor,add]] | This method is called when a failure occurs. | @mukul1987 will this keep existing behavior of chaos tests? |
@@ -297,10 +297,6 @@ class BlockchainEvents:
yield decode_raiden_event_to_internal(event_listener.abi, self.chain_id, log_event)
def uninstall_all_event_listeners(self) -> None:
- for listener in self.event_listeners:
- if listener.filter.filter_id:
- listener.fi... | [get_all_netting_channel_events->[get_contract_events],BlockchainEvents->[add_event_listener->[EventListener],add_token_network_listener->[add_event_listener],add_secret_registry_listener->[add_event_listener],add_token_network_registry_listener->[add_event_listener],poll_blockchain_events->[_log_sync_progress,decode_r... | Uninstall all event listeners. | All filters used are "stateless", meaning we don't install the filter in the client. This was necessary because the clients don't persist the filters, and if the ethereum node is restarted the filter was simply gone. |
@@ -479,7 +479,7 @@ class PluginManager
* @param PluginInterface $plugin
* @param class-string<CapabilityClass> $capabilityClassName The fully qualified name of the API interface which the plugin may provide
* an implementation... | [PluginManager->[loadRepository->[registerPackage],getInstallPath->[getInstallPath],collectDependencies->[collectDependencies],getPluginCapability->[getCapabilityImplementationClassName],uninstallPackage->[deactivatePackage],getPluginCapabilities->[getPlugins,getPluginCapability]]] | Returns a class object of the given class name or null if the class name is not found Get a single object. | Why do $ctorArgs (here and below) need string keys? Seems to me like it could be `array<mixed>` simply? |
@@ -11,11 +11,11 @@
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
-// +build windows
package cmdutil
import (
+ "fmt"
"os"
"os/exec"
| [PPid,Pid,Append,FindProcess,Kill,Processes] | KillChildren kills all children of a process. processExistsWithParent returns true if the process with the given pid and ppid exists in. | Is 0 special here or do you just mean that when PID and PPID are equal to ignore them? |
@@ -363,3 +363,14 @@ def unix2dos(filepath):
def dos2unix(filepath):
_replace_with_separator(filepath, "\n")
+
+
+def dot_clean(folder):
+ files = os.listdir(folder)
+ for f in files:
+ full_name = os.path.join(folder, f)
+ if os.path.isdir(full_name):
+ dot_clean(full_name)
+ ... | [which->[verify,_get_possible_filenames],chdir->[chdir],unzip->[human_size,print_progress],patch->[PatchLogHandler->[__init__->[__init__]],PatchLogHandler],unix2dos->[_replace_with_separator],check_md5->[check_with_algorithm_sum],check_sha1->[check_with_algorithm_sum],replace_path_in_file->[normalized_text,_manage_text... | Convert a DOS file to a Unix file. | I would name it `dot_underscore_clean` |
@@ -191,12 +191,11 @@ namespace Js
{
return propertyId;
}
- JsUtil::CharacterBuffer<WCHAR> propertyStr(propertyKey->GetString(), propertyKey->GetLength());
- if (BuiltInPropertyRecords::valueOf.Equals(propertyStr))
+ if (BuiltInPropertyRecords::valueOf.Equals(property... | [No CFG could be retrieved] | Returns a property id if it is found in the script context. This method rounds up the requested property capacity and cap by max range value. | should we pass the propertyId here, I believe you have that overloaded, right? |
@@ -192,9 +192,11 @@ class PublishedArticleDAO extends ArticleDAO {
' . $this->getFetchColumns() . '
FROM published_submissions ps
JOIN submissions s ON (ps.submission_id = s.submission_id)
+ LEFT JOIN submission_settings ss ON (ss.submission_id = ps.submission_id)
' . $this->getFetchJoins() . '
... | [PublishedArticleDAO->[getPublishedArticlesInSections->[_getArticlesInSectionsCache],getPublishedArticleByBestArticleId->[getPublishedArticleByPubId,getByArticleId],getPublishedArticleByPubId->[_getPublishedArticleCache],getByArticleId->[_getPublishedArticleCache]]] | Get all published articles in a section of an issue Required section. | should here also AND MAX(ss.submission_revision) not be checked? And elsewhere? |
@@ -1584,6 +1584,15 @@ void ModelPart::SetBufferSize(ModelPart::IndexType NewBufferSize)
}
+void ModelPart::SetBufferSizeSubModelParts(ModelPart::IndexType NewBufferSize)
+{
+ for(auto& r_sub_model_part : mSubModelParts) {
+ r_sub_model_part.SetBufferSizeSubModelParts(NewBufferSize);
+ }
+
+ mBuffe... | [No CFG could be retrieved] | region ModelPart methods Print information about the object. | guys, this is NOT correct. you can change the buffer size only of the root modelpart, and the behaviour is deliberate current implementation is the following: ~~~cpp void ModelPart::SetBufferSize(ModelPart::IndexType NewBufferSize) { KRATOS_ERROR_IF(IsSubModelPart()) << "Calling the method of the sub model part " << Na... |
@@ -1994,8 +1994,14 @@ class State:
return
manager = self.manager
+
+ # Can we reuse a previously parsed AST? This avoids redundant work in daemon.
+ cached = self.id in manager.ast_cache and True
modules = manager.modules
- manager.log("Parsing %s (%s)" % (self.xpa... | [process_graph->[add_stats,trace,log],_build->[BuildSourceSet,BuildResult],write_deps_cache->[deps_to_json,getmtime,log],BuildManager->[trace->[verbosity],log_fine_grained->[verbosity,log],all_imported_modules_in_file->[correct_rel_imp,import_priority],maybe_swap_for_shadow_path->[normpath],report_file->[is_source],log... | Parse a file and run the first pass of semantic analysis. Check if a node - level is found in the tree. | Why do you need `and True`? Leftover from debugging? |
@@ -434,7 +434,7 @@ namespace DotNetNuke.Services.Upgrade.Internals
portalConfig.Description = XmlUtils.GetNodeValue(portalNode.CreateNavigator(), "description");
portalConfig.Keywords = XmlUtils.GetNodeValue(portalNode.CreateNavigator(), "keywords");
... | [InstallControllerImpl->[TestDatabaseConnection->[TestDatabaseConnection]]] | Get the install config that is available in the current environment. This function parses the node in the install template and adds it to the configuration object. This function parses the configuration nodes that are not present in the installation tree. | Please use `String#Equals(String, StringComparison)` |
@@ -25,7 +25,7 @@ class DocumentAnalysisClient(FormRecognizerClientBase):
methods based on inputs from a URL and inputs from a stream.
.. note:: DocumentAnalysisClient should be used with API versions
- v2021-09-30-preview and up. To use API versions <=v2.1, instantiate a FormRecognizerClient.
+ ... | [DocumentAnalysisClient->[begin_analyze_document->[begin_analyze_document],begin_analyze_document_from_url->[begin_analyze_document],close->[close],__exit__->[__exit__],__enter__->[__enter__]]] | A base class for analyzing a single . Check if a client is missing a key. | I think we should make this change on the rest of the clients if we make it here. |
@@ -338,11 +338,11 @@ public class JavaScriptAggregatorFactory extends AggregatorFactory
if (arg != null && arg.getClass().isArray()) {
// Context.javaToJS on an array sort of works, although it returns false for Array.isArray(...) and
// may have other issues too. Let's just ... | [JavaScriptAggregatorFactory->[getMergingFactory->[getCombiningFactory],equals->[equals],getCombiningFactory->[JavaScriptAggregatorFactory],makeAggregateCombiner->[fold->[combine]],combine->[combine],getRequiredColumns->[apply->[JavaScriptAggregatorFactory]]]] | Creates a JavaScriptAggregator which aggregates the given double values into a value that can be used to Aggregate method. | do we have a test case for this ? |
@@ -30,6 +30,16 @@ Int64Math::Mul(int64 left, int64 right, int64 *pResult)
return (left != 0 && right != 0 && (*pResult / left) != right);
#endif
}
+#else
+// FIXME: this probably needs checks for __int128 at least.
+bool
+Int64Math::Mul(int64 left, int64 right, int64 *pResult)
+{
+ __int128 result = (__int12... | [NearestInRangeTo->[Assert],Mod->[AssertMsg],Div->[AssertMsg],Mul->[_mul128]] | Checks if the polynomial of int64 left and right is not zero. | Why promote them both for the multiplication only to throw away the extra precision in a cast in the very next line? Was there a warning here you were trying to avoid? |
@@ -1 +1,11 @@
+import os
+from mypy import git
+
__version__ = '0.4.6-dev'
+
+mypy_dir = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
+if git.is_git_repo(mypy_dir) and git.have_git():
+ __version__ += '-' + git.git_revision(mypy_dir).decode('utf-8')
+ if git.is_dirty(mypy_dir):
+ __version... | [No CFG could be retrieved] | Set the version of the library. | When run from a repo, these seem to add maybe 30 msec to the mypy runtime when there is a warm cache. This looks like up to 6% slowdown, which is not terrible if most users are using a pip-installed version. However, this could be much worse on cold cache. Can you check the effect on mypy runtime when run straight afte... |
@@ -49,7 +49,7 @@ def sort_by_padding(
@DataIterator.register("bucket")
-class BucketIterator(DataIterator):
+class BucketIteratorStub(DataIterator):
"""
An iterator which by default, pads batches with respect to the maximum input lengths `per
batch`. Additionally, you can provide a list of field na... | [BucketIterator->[_create_batches->[sort_by_padding]]] | Creates an iterator which buckets the instances of the in the dataset. The padding_noise parameter is a parameter that is used to add a bit of. | Similarly, here you'd subclass both `DataIterator` and `TransformIterator`. |
@@ -225,4 +225,13 @@ public final class TransactionCoordination {
transactions.set((Transaction) isolatedTransactions.get().pop());
}
}
+
+ /**
+ * Determine is there is an active transaction associated with the current thread.
+ *
+ * @return true if there is an active transaction, false otherwis... | [TransactionCoordination->[resolveTransaction->[getTransaction],suspendCurrentTransaction->[unbindTransaction,getTransaction],clear->[clear],resumeSuspendedTransaction->[bindTransaction],TransactionCoordination]] | Restore isolated transaction. | should we add a TODO to remove the thread/tx association? |
@@ -204,6 +204,10 @@ func (d *Distributor) queryIngesterStream(ctx context.Context, replicationSet ri
result.Chunkseries = append(result.Chunkseries, resp.Chunkseries...)
result.Timeseries = append(result.Timeseries, resp.Timeseries...)
+
+ if len(result.Chunkseries) > maxSeries || len(result.Timeseries) > ... | [queryIngesterStream->[QueryStream],queryIngesters->[Query]] | queryIngesterStream sends a stream of samples from multiple ingesters. Parse any chunk series that are not in the response. | What are the implications on the returned status code? I've the feeling this may be detected as a storage error and we return a 5xx error (while it should be a 4xx) but I haven't deeply checked it. |
@@ -57,7 +57,7 @@ func RunBuildController(ctx ControllerContext) (bool, error) {
Codec: annotationCodec,
},
SourceBuildStrategy: &buildstrategy.SourceBuildStrategy{
- Image: imageTemplate.ExpandOrDie("sti-builder"),
+ Image: imageTemplate.ExpandOrDie("docker-builder"),
// TODO: this will be set to --s... | [NewBuildConfigController,OpenshiftInternalBuildClientOrDie,OpenshiftInternalSecurityClientOrDie,Secrets,Run,ClientOrDie,BuildConfigs,NewBuildOverrides,V1,KubeInternalClientOrDie,Builds,NewDefaultImageTemplate,Pods,Security,ExpandOrDie,Build,ImageStreams,Image,Core,NewBuildController,LegacyCodec,InternalVersion,NewBuil... | RunBuildConfigChangeController starts the build controller for the specified build object. Builds - BuildConfigController. | this surprises me. Why would this image change? |
@@ -48,4 +48,16 @@ public class SwingActionTest {
verify(action, times(2)).run();
});
}
+
+ @Test
+ public void testInvokeNowOrLater() {
+ final CountDownLatch latch = new CountDownLatch(1);
+ final Runnable action = () -> {
+ latch.countDown();
+ };
+
+ SwingAction.invokeNowOrLater(ac... | [SwingActionTest->[testInvokeAndWait->[invokeAndWait,run],testActionOf->[getValue,assertEquals,of,actionPerformed],testKeyReleaseListener->[keyReleaseListener,mock,accept,keyReleased]]] | Invoke an action and wait for it to complete. | This lambda can be shortened. |
@@ -57,9 +57,15 @@ func IsRootless() bool {
rootlessGIDInit := int(C.rootless_gid())
if rootlessUIDInit != 0 {
// This happens if we joined the user+mount namespace as part of
- os.Setenv("_CONTAINERS_USERNS_CONFIGURED", "done")
- os.Setenv("_CONTAINERS_ROOTLESS_UID", fmt.Sprintf("%d", rootlessUIDInit))
-... | [Value,reexec_in_user_namespace,Syscall,Readlink,Fd,Warnf,Close,Setenv,Signal,rootless_gid,LookupId,Getgid,NewFile,WriteFile,Atoi,CombinedOutput,SystemBus,int,Stat,LockOSThread,ReadFile,NewIDMappings,New,Getegid,Notify,GIDs,reexec_userns_join,Errorf,Run,LookPath,Socketpair,reexec_in_user_namespace_wait,Debugf,Wrapf,Joi... | cgo remoteclient - cgo remoteclient - cgo remoteclient - GetRootlessGID returns the GID of the user in the parent userNS if _. | This seems inconsistent with `runInUser()` where we return the `Setenv()` error. |
@@ -65,12 +65,13 @@ public interface DataFileVersionStrategy<T extends Comparable<T> & Serializable>
}
String DATA_FILE_VERSION_STRATEGY_KEY = "org.apache.gobblin.dataFileVersionStrategy";
+ String DEFAULT_DATA_FILE_VERSION_STAREGY = "modtime";
/**
* Instantiate a {@link DataFileVersionStrategy} accor... | [instantiateDataFileVersionStrategy->[ClassAliasResolver,resolveClass,getName,getString,IOException,createDataFileVersionStrategy],hasCharacteristic->[contains]] | Instantiates a DataFileVersionStrategy based on the given configuration. | can you fix the spelling of the key name? |
@@ -238,6 +238,11 @@ public class Pac4jAuthenticationEventExecutionPlanConfiguration {
cfg.setForceAuth(saml.isForceAuth());
if (StringUtils.isNotBlank(saml.getAuthnContextClassRef())) {
+ final String authContextComparisonType = StringUtils.isNotBlank(... | [Pac4jAuthenticationEventExecutionPlanConfiguration->[builtClients->[configureYahooClient,configureWordpressClient,configureFoursquareClient,configureBitbucketClient,configureCasClient,configureLinkedInClient,configureTwitterClient,configureDropboxClient,configureOAuth20Client,configureSamlClient,configureOidcClient,co... | Configure saml client. | Simply just use `EXACT`. No need to import opensaml explicitly? |
@@ -98,6 +98,18 @@ func PrintCurrentTest(t testing.TB, skip ...int) func() {
}
writerCloser.setT(&t)
return func() {
+ qs := queue.GetManager().ManagedQueues()
+ for _, q := range qs {
+ if err := q.Flush(10 * time.Second); err != nil {
+ t.Errorf("Flushing queue %s failed with error %v", q.Name, err)
+ ... | [Write->[Error,RLock,Log,RUnlock,HasPrefix],Close->[Lock,Unlock],Init->[NewWriterLogger,Unmarshal],setT->[Lock,Unlock],Fprintf,Caller,TrimSuffix,setT,Formatter,Name,NewColoredValue,Close,TrimPrefix,Register] | PrintCurrentTest prints the current test object to stdout and returns the number of bytes written to NewTestLogger creates a new instance of the TestLogger interface. | It looks like `PrintCurrentTest`'s duty no longer is to just print test data, but also provide queue cleanup.... Mmmm... Maybe we can change the function name to something like "InitTestEnv" or anything more suitable? It could have a `bool` parameter for whether it needs to init the database too (which is a pretty co... |
@@ -221,6 +221,14 @@ class Pipeline(object):
# then the transform will have to be cloned with a new label.
self.applied_labels = set() # type: Set[str]
+ # Create a context for assigning IDs to components. Ensures that any
+ # components that receive an ID during pipeline construction (for example in... | [Pipeline->[_check_replacement->[ReplacementValidator],_remove_labels_recursively->[_remove_labels_recursively],from_runner_api->[Pipeline],replace_all->[_check_replacement,_replace],_replace->[TransformUpdater->[_replace_if_needed->[_remove_labels_recursively],visit_transform->[_replace_if_needed],enter_composite_tran... | Initialize a new BeamPipeline object. Creates a new runner and sets the local_tempdir and the pipeline_dir. | There's not actually a circular dependency of classes. You could move this class in here and that would be fine. |
@@ -88,6 +88,14 @@ def _test_raw_reader(reader, test_preloading=True, **kwargs):
idx = np.where(concat_raw.annotations.description == 'BAD boundary')[0]
assert_array_almost_equal([(last_samp - first_samp) / raw.info['sfreq']],
concat_raw.annotations.onset[idx], decimal=2)
+
+ ... | [_test_raw_reader->[round,_TempDir,where,join,assert_allclose,assert_array_almost_equal,int,min,assert_equal,copy,read_raw_fif,set,concatenate_raws,append,len,slice,repr,RandomState,permutation,reader,keys,arange,isnan,save],test_time_index->[dirname,len,read_raw_fif,set,join,time_as_index],_test_concat->[load_data,rea... | Test reading writing and slicing of raw classes. Test concatenation of raw classes that allow not preloading. Reads a sequence of nanoseconds from the data. | Do we want this to raise an error? it would catch IO readers that don't set meas_id. Currently it is only raising errors when the reader doesn't set meas_id and when the tests that expect the warning messages to be a specific thing. |
@@ -59,11 +59,13 @@ public interface GroupByColumnSelectorStrategy extends ColumnSelectorStrategy
* @param selectorPlus dimension info containing the key offset, value selector, and dimension spec
* @param resultMap result map for the group by query being served
* @param key grouping key
+ * @param keyBuf... | [No CFG could be retrieved] | Process a value from a grouping key. | If this param is added to support null, the doc should be a bit more elaborate about that |
@@ -664,6 +664,10 @@ function shouldMutationForNodeListBeRerendered(nodeList) {
function shouldMutationBeRerendered(Ctor, m) {
const {type} = m;
if (type == 'attributes') {
+ // Check whether this is a templates attribute.
+ if (Ctor['usesTemplate'] && m.attributeName == 'template') {
+ return true;
+... | [No CFG could be retrieved] | Checks if a mutation record should be rerendered. | Is this supporting the case where `template` is identified as an attribute by the target template `id`? Let's also add a Storybook example for that. |
@@ -1253,7 +1253,10 @@ else
// Note public
print '<tr><td>';
- print $form->editfieldkey($form->textwithpicto($langs->trans('NotePublic'), $htmltext, 1, 'help', '', 0, 2, 'notepublic'), 'note_public', $object->note_public, $object, $user->rights->facture->creer);
+ if (($action != 'editnote_public') && $user-... | [fetch,selectMassAction,update_price,create,select_projects,form_project,setDefaultLang,formconfirm,fetch_object,jdate,lasterror,addline,printObjectLines,getAlignFlag,order,fetchObjectLinked,select_date,getLinesArray,selectyesno,setValueFrom,getNomUrl,rollback,editfieldval,setFrequencyAndUnit,begin,formAddObjectLine,in... | Show a list of calendar component elements Print a list of objects that can be edited. | The test should be included into the editfieldkey param |
@@ -40,6 +40,7 @@ func defaultIngesterTestConfig() Config {
cfg.LifecyclerConfig.ListenPort = func(i int) *int { return &i }(0)
cfg.LifecyclerConfig.Addr = "localhost"
cfg.LifecyclerConfig.ID = "localhost"
+ cfg.LifecyclerConfig.MinReadyDuration = time.Minute
return cfg
}
| [TransferChunks->[ErrorAndClose,TransferChunks],ToQueryRequest,ToWriteRequest,Error,NewOverrides,ChunksToMatrix,Poll,NewMatcher,CloseAndRecv,Time,Equal,Shutdown,NoError,Log,SampleValue,Get,GetState,Query,InjectOrgID,NewInMemoryKVClient,TimeFromUnix,Background,ToLabelPairs,DefaultValues,Sleep,TransferChunks,Push] | TestIngesterTestConfig tests the default configuration for a given user. TestIngesterRestart is a test function that restarts the test store when the number. | The call to flagext.DefaultValues should be enough, no? |
@@ -61,6 +61,7 @@ Commands
Options
-h|--help|-? Show help information
-v Show more debug information.
+ -e|--execute Execute the dropping.
-f|--force Force the update command (Even if the database structure matches)
-o|--override Override running or stall... | [DatabaseStructure->[doExecute->[getHelp,getOption,getArgument,get,out,isConnected]]] | Get help text for the command line. | Since this subcommand has a specific workflow with a unique parameter, I'd rather you create a separate console command that would be dry-run by default and suggest to use the -e flag to actually perform the destructive operations. |
@@ -61,17 +61,6 @@
<div class="usa-overlay"></div>
<%= yield(:mobile_nav) if content_for?(:mobile_nav) %>
<%= render 'shared/banner' %>
- <div aria-label="main-navigation" role="navigation">
- <% if content_for?(:nav) %>
- <%= yield(:nav) %>
- <% else %>
- <% if decorated_session.sp_name %>
- ... | [No CFG could be retrieved] | Renders a single - page window with a hidden hidden element. Renders the n - node header. | Can we maintain the indentation that existed previously? |
@@ -19,6 +19,8 @@ import (
"fmt"
"strings"
+ "github.com/texttheater/golang-levenshtein/levenshtein"
+
gardencorev1beta1 "github.com/gardener/gardener/pkg/apis/core/v1beta1"
gardencorev1beta1helper "github.com/gardener/gardener/pkg/apis/core/v1beta1/helper"
gardencoreinformers "github.com/gardener/gardener/... | [reconcileShootKey->[Infof,ScheduleShoot,SplitMetaNamespaceKey,Shoots,IsNotFound,Get,Debugf],ScheduleShoot->[NewAlreadyScheduledError,DeepCopy,Infof,Sprintf,NewFieldLogger,GardenCore,TryUpdateShoot,reportSuccessfulScheduling,reportFailedScheduling,WithField],reportSuccessfulScheduling->[reportEvent],reportFailedSchedul... | Package containing all of the components of a single sequence. This function is a part of the validation API. It is only used for the Shoot. | Please move to 3rd import block. |
@@ -161,7 +161,16 @@ class WikiTablesSemanticParser(Model):
world: List[WikiTablesWorld],
actions: List[List[ProductionRuleArray]],
example_lisp_string: List[str] = None,
- ... | [WikiTablesSemanticParser->[_get_neighbor_indices->[append,len,pad_sequence_to_length,Variable,enumerate],_get_linking_probabilities->[softmax,new,size,append,linking_scores,cat,len,stack,Variable,enumerate,range,unsqueeze],_action_history_match->[new,max,size,min,len,eq],_get_type_vector->[new,append,startswith,pad_se... | Returns the initial state of the embedding and the scores of the entity. Compute entity type embedding and question word cosine similarity. The maximum linking score over the entity s words and the question token s neighbors. | This could also just be a `ChecklistState` object, I think. |
@@ -357,7 +357,7 @@ namespace MonoGame.Tools.Pipeline
foreach (var i in Importers)
{
- if (i.FileExtensions.Contains(fileExtension))
+ if (i.FileExtensions.Contains(fileExtension.ToLowerInvariant()))
return i;
}
| [ImporterTypeDescription->[Equals->[Equals],GetHashCode->[GetHashCode]],ProcessorTypeDescription->[ProcessorPropertyCollection->[IEnumerator->[GetEnumerator],GetEnumerator->[GetEnumerator],Equals]],PipelineTypes->[ImporterTypeDescription->[Equals->[],GetHashCode->[],Equals,Contains,RemapOldNames],Load->[Contains],Proce... | Find importer by name and extension. | How do we know `FileExtensions` is always lower case? Do we force them to lowercase somewhere? |
@@ -386,7 +386,7 @@ class ConanAPIV1(object):
raise ConanException("recipe parameter cannot be used together with package")
# Install packages without settings (fixed ids or all)
conan_ref = ConanFileReference.loads(reference)
- self._manager.download(conan_ref, package, remote=rem... | [_get_conanfile_path->[_make_abs_path],ConanAPIV1->[export_alias->[export_alias],export->[_get_conanfile_path,export],install->[_get_conanfile_path,install,_make_abs_path],source->[_get_conanfile_path,_make_abs_path,source],imports_undo->[imports_undo,_make_abs_path],remove->[remove],imports->[_get_conanfile_path,_make... | Download a single package from the specified reference. | rename not related with this PR, it makes more sense for me to call it "only_recipe". |
@@ -149,7 +149,7 @@ def split_ips_by_family(ips):
def get_bridge_physdev(brname):
- physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}'" % brname)
+ physdev = execute("bridge -o link show | awk '/master %s / && !/^[0-9]+: vnet/ {print $2}' | head -1" % brname)
retu... | [network_rules_for_rebooted_vm->[check_domid_changed,default_network_rules_systemvm,rewrite_rule_log_for_vm,execute,delete_rules_for_vm_in_bridge_firewall_chain],can_bridge_firewall->[execute],get_vm_id->[get_libvirt_connection],get_vifs->[virshdumpxml],add_network_rules->[egress_chain_name,parse_network_rules,default_... | Get the bridge s physdev. check if a node in the system has a n - ary node. | Can you rewrite this to use `iproute2` or a more modern tool? |
@@ -239,7 +239,7 @@ func (d *Helper) Mv(ctx context.Context, fromPath, toPath string) error {
from := path.Join(d.RootURL, fromPath)
to := path.Join(d.RootURL, toPath)
log.Infof("Moving %s to %s", from, to)
- err := tasks.Wait(ctx, func(context.Context) (tasks.Waiter, error) {
+ err := tasks.Wait(ctx, func(contex... | [Upload->[Upload],Stat->[Stat],Download->[Download],mkRootDir->[Mkdir,IsVSAN]] | Mv moves a file from one location to another. | Why did you make this change? If you are going to change this, might as well use `object.Task` from govmomi. |
@@ -82,7 +82,9 @@ func TestV2IsAuthorized(t *testing.T) {
func TestV2ProjectsAuthorized(t *testing.T) {
ctx, engines := setup(t)
- sub, act, res, proj1, proj2 := "user:local:admin", "iam:users:create", "iam:users", "proj-1", "proj-2"
+ sub, act, res := "user:local:admin", "iam:users:create", "iam:users"
+ proj1, p... | [V2FilterAuthorizedPairs,Resource,False,V2SetPolicies,ProjectList,Itoa,Projects,Subject,V2ProjectsAuthorized,Equal,NoError,True,V2IsAuthorized,Action,Background,V2FilterAuthorizedProjects,ElementsMatch,Run,Helper] | TestV2ProjectsAuthorized tests if a project with one allow statement matches a resource. setPoliciesV2 returns empty list when store is empty returns empty list when all requested. | Please use constant so the definition is only given once per service: s/"(unassigned)"/constants.UnassignedProjectID/ |
@@ -1128,6 +1128,9 @@ namespace System.Security.Permissions
[System.AttributeUsageAttribute(System.AttributeTargets.Class | System.AttributeTargets.Method, AllowMultiple=true, Inherited=false)]
public sealed partial class PrincipalPermissionAttribute : System.Security.Permissions.CodeAccessSecurityAttribute
... | [ZoneIdentityPermissionAttribute->[Struct,Method,Class,Constructor,Assembly],DnsPermissionAttribute->[Struct,Method,Class,Constructor,Assembly],OleDbPermissionAttribute->[Struct,Method,Class,Constructor,Never,Assembly],IsolatedStorageFilePermissionAttribute->[Struct,Method,Class,Constructor,Assembly],RegistryPermission... | Create a permission that can be used to perform operations on the system. | Do we have the destination already created? We should ensure this is all in place before the first Preview this is contained in is released. |
@@ -83,7 +83,18 @@ func TestMain(t *testing.T) {
errConf.VolumeLocations = make(map[string]*url.URL)
errConf.VolumeLocations["volume-store"], _ = url.Parse("ds://store_not_exist/volumes/test")
testCreateVolumeStores(op, validator.Session, errConf, true, t)
+
+ // FIXME: (pull vic/7088) have to make another VC... | [Close,createAppliance,ListIssues,VPX,Error,UserPassword,createPool,Validate,IsVC,Errorf,ESX,NewData,Logf,Create,createBridgeNetwork,Remove,Fatalf,NewServer,createVolumeStores,Background,NewValidator,Fatal,SetLevel,Parse,deleteVolumeStoreIfForced,NewOperation] | getESXData returns the ESXData object for the given object getVMNetworkData - get VM Network data. | I think this will cause a validator failure meaning we'll never try creating the resource pool or appliance. Please confirm that you see the expected output when running the test. |
@@ -57,6 +57,10 @@ class Clang(Compiler):
# compilers.yaml
link_paths['f77'] = 'clang/gfortran'
link_paths['fc'] = 'clang/gfortran'
+ elif spack.architecture.sys_type() == 'linux-rhel7-ppc64le':
+ # This platform uses clang with IBM XL Fortran compiler
+ link_paths['f77'] = '... | [Clang->[fc_version->[default_version],f77_version->[fc_version]]] | Creates a class property for the given object. Return a string describing the flags for the C ++ version 14. | ~~Are other combinations possible there? Maybe someone installs flang?~~ ~~Put it at the end of if-else if?~~ Nevermind: I think it's not possible in the current setup. |
@@ -1301,6 +1301,12 @@ frappe.ui.form.ControlDynamicLink = frappe.ui.form.ControlLink.extend({
if(this.df.get_options) {
return this.df.get_options();
}
+ if (this.docname==null && cur_dialog!=null){ //for dialog box
+ return cur_dialog.get_value(this.df.options)
+ }
+ if (cur_frm==null){//for list page
... | [No CFG could be retrieved] | frappe. ui. form. ControlDynamicLink frappe. ui. form frappe. ui. form. ControlTextEditor. | need to check if `cur_list` is true. will fix manually |
@@ -30,8 +30,10 @@ namespace NServiceBus.Features
protected internal override void Setup(FeatureConfigurationContext context)
{
var retryPolicy = GetRetryPolicy(context.Settings);
+ var slrStorage = new SlrStatusStorage();
context.Container.RegisterSingleton(typ... | [SecondLevelRetries->[IsEnabledInConfig->[Settings,Enabled,NumberOfRetries],SecondLevelRetryPolicy->[NumberOfRetries,DefaultNumberOfRetries,DefaultTimeIncrease,TimeIncrease,settings],Setup->[RegisterSingleton,MainPipeline,b,GetRetryPolicy,InstancePerCall,ConfigureComponent,Settings,LocalAddress,Pipeline],Settings,Enabl... | Setup method. | In general we try to avoid the usage of `IBuilder` as much as possible. Since you already created the `SlrStatusStorage` you can directly pass it to the lambda of the `SecondLevelRetriesBehavior` like you do and try to pass it into the Startup task directly (I know currently not possible but we should/could come up wit... |
@@ -300,8 +300,7 @@ public class ExtensionLoader<T> {
}
}
List<T> loadedExtensions = new ArrayList<>();
- for (int i = 0; i < names.size(); i++) {
- String name = names.get(i);
+ for (String name : names) {
if (!name.startsWith(REMOVE_VALUE_PREFIX)
... | [ExtensionLoader->[getSupportedExtensionInstances->[getExtension,getSupportedExtensions],getExtension->[getExtension,getOrCreateHolder],getAdaptiveExtensionClass->[getExtensionClasses],loadDirectory->[findClassLoader,loadDirectory],createExtension->[findException],injectExtension->[getExtension],getExtensionName->[getE... | Get the list of extensions that can be activated. This method is called when the application is not loaded. | Iterator with set is lack of performance. Sometimes it will create a lot of iterator objects. |
@@ -0,0 +1,11 @@
+package github
+
+import (
+ "testing"
+
+ "github.com/openshift/origin/pkg/auth/oauth/external"
+)
+
+func TestGithub(t *testing.T) {
+ _ = external.Provider(NewProvider("", ""))
+}
| [No CFG could be retrieved] | No Summary Found. | can't you just nuke the `_ =` part? |
@@ -137,7 +137,7 @@ func main() {
coordinatorSub := flag.NewFlagSet("coordinator-subscription", flag.ExitOnError)
address := coordinatorSub.String("address", "", "coordinator address")
subID := coordinatorSub.Int64("sub", 0, "subID")
- panicErr(coordinatorSub.Parse(os.Args[2:]))
+ parseArgs(coordinatorSub, o... | [CreateSubscription,SRandomWords,Hash,SetConfig,NewVRFSingleConsumerExample,NewKeyedTransactorWithChainID,DeployVRFExternalSubOwnerExample,DeployVRFCoordinatorV2,ScalarBaseMult,LookupEnv,TransferAndCall,BalanceOf,Exit,UnmarshalPubkey,RequestRandomWords,TopUpSubscription,Dial,HexToHash,CancelSubscription,ParseInt,Bytes,... | register - key - address - address - address - uncompressed pubkey - uncompressed pubkey - address - Deploy a single key - hash to a single consumer. | should this be sub instead of pubkey? |
@@ -28,7 +28,7 @@ images per class.
"""
-import cPickle
+import pickle
import itertools
import numpy
import paddle.dataset.common
| [test100->[reader_creator],train10->[reader_creator],reader_creator->[reader->[read_batch]],train100->[reader_creator],test10->[reader_creator],convert->[test100,train10,train100,test10,convert]] | Creates a list of all CIFAR images in the n - ary object. Create a function that creates a list of tuples from the data and labels of the given file. | Mayve we should use `six.moves` since `zip` is different with `izip` in Py2 |
@@ -440,12 +440,12 @@ public class DataTypeUtils {
// final DataType elementDataType = inferDataType(valueFromMap, RecordFieldType.STRING.getDataType());
// return RecordFieldType.MAP.getMapDataType(elementDataType);
}
- if (value instanceof Object[]) {
- final Object[... | [DataTypeUtils->[inferDataType->[inferDataType],isIntegerTypeCompatible->[isNumberTypeCompatible,isIntegral],isScalarValue->[chooseDataType],convertRecordFieldtoObject->[convertRecordFieldtoObject],isFloatTypeCompatible->[isNumberTypeCompatible],toArray->[toArray],isShortTypeCompatible->[isNumberTypeCompatible,isIntegr... | Infer data type from value. Infer the data type of the missing elements. | Neat! I don't think I realized that `Class.isArray()` and `Array.getLength()` / `Array.get()` were a thing. |
@@ -3296,7 +3296,6 @@ def bincount(arr,
Raises:
`InvalidArgumentError` if negative values are provided as an input.
-
"""
name = "bincount" if name is None else name
with ops.name_scope(name):
| [reduce_max->[_ReductionDims],to_double->[cast],reduce_sum->[_ReductionDims],reciprocal_no_nan->[div_no_nan],scalar_mul_v2->[scalar_mul],tensor_equals->[equal],_ReductionDims->[range],reduce_std->[reduce_variance],reduce_all->[_may_reduce_to_scalar,_ReductionDims],accumulate_n->[add_n,_input_error],truediv->[_truediv_p... | Counts the number of occurrences of each value in an integer array. Returns the output bins for a . | Why is this line removed? |
@@ -32,6 +32,8 @@ import java.util.stream.Collectors;
*/
public final class NetUtils {
public static final Logger LOG = LoggerFactory.getLogger(NetUtils.class);
+ private static final Object EXCLUDE_NODES_LOCK = new Object();
+
private NetUtils() {
// Prevent instantiation
}
| [NetUtils->[normalize->[IllegalArgumentException,length,replaceAll,charAt],locationToDepth->[normalize,split,equals],removeOutscope->[hasNext,iterator,isEmpty,remove,startsWith,next],removeDuplicate->[hasNext,forEach,remove,toList,removeAll,iterator,isEmpty,warn,collect,startsWith,next,getAncestor],getAncestorList->[ha... | This class is used to facilitate network topology functions. Returns the network topology location string if it is a network topology location string. | I think moving `removeOutOfScope` to `NetworkTopologyImpl` and making it non-static would be more future-proof. Syncing on a static object seems risky. |
@@ -227,6 +227,10 @@
*
*/
+#ifdef M99_FREE_MEMORY_WATCHER
+ void m99_code();
+#endif
+
#ifdef SDSUPPORT
CardReader card;
#endif
| [No CFG could be retrieved] | A function to handle the various cases of the n - th gcode. This function is used to get the current command and arguments. It is used to get the. | `M99` is overloaded, but `M100` is available! |
@@ -3390,7 +3390,7 @@ class MindTouchRedirectTests(UserTestCase, WikiTestCase):
'expected': '/zh-CN/docs/XHTML'},
{'title': 'JavaScript', 'mt_locale': 'zh_cn', 'kuma_locale': 'zh-CN',
'expected': '/zh-CN/docs/JavaScript'},
- {'title': 'XHTML6', 'mt_locale': 'zh_tw', 'kuma_locale': 'z... | [DocumentSEOTests->[test_seo_title->[_make_doc],test_seo_script->[make_page_and_compare_seo]],ViewTests->[test_children_view->[_make_doc,_depth_test]],DocumentEditingTests->[test_translation_spam_ajax->[test_edit_spam_ajax],test_translation_midair_collission_ajax->[test_edit_midair_collisions],test_slug_revamp->[_creat... | Construct the urls for the document views that are needed to render the given nagios object Test for the missing namespace urls and document urls. | It was very strange that this worked! However, I see that the test was just looking at the first redirect, and matching it again the ``expected`` value ``/zh-TW/docs/XHTML6``. Only took me 15 minutes to figure that out |
@@ -213,7 +213,17 @@ public class SftpReceiverRequesterUtil
// This special InputStream closes the SftpClient when the stream is closed.
// The stream will be materialized in a Message Dispatcher or Service
// Component
- return new SftpInputStream(client, fileInputStream, fileName, co... | [SftpReceiverRequesterUtil->[retrieveFile->[retrieveFile]]] | Retrieve a file from the remote server. This method is used to create a stream of files from the temporary directories. Move the temporary file to the temporary file and return an SftpFileArchiveInputStream. | this is wrong. valueOf() will never return null. On the contrary, it will return false if the input is null. The null check you actually have to do is against the endpoint property |
@@ -308,6 +308,10 @@ public final class ScmConfigKeys {
OZONE_SCM_KEY_VALUE_CONTAINER_DELETION_CHOOSING_POLICY =
"ozone.scm.keyvalue.container.deletion-choosing.policy";
+ public static final String OZONE_SCM_PIPELINE_PER_METADATA_DISK =
+ "ozone.scm.pipeline.per.metadata.disk";
+
+ public static... | [ScmConfigKeys->[valueOf]] | The names of the parameters that are used in the SCM. region > Get pipeline creation interval. | name suggestion: OZONE_SCM_PIPELINE_PER_METADATA_VOLUME. We'd better use concept volume instead of concept disk in SCM, the former one is a logical concept, the latter is physical one, and volume is already widely used in context. |
@@ -79,7 +79,7 @@
<div class="crayons-card grid gap-6 p-6 mb-6">
<h2>Organization details</h2>
- <%= form_for @organization, html: { class: "grid gap-6" } do |f| %>
+ <%= form_for @organization, url: organization_path(params[:locale], @organization), html: { class: "grid gap-6" } do |f| %>
<%= f.hidden_fie... | [No CFG could be retrieved] | The organization secret field Displays a hidden field with a label and a profile image. | Will we need to add this to all helpers across the site? Also will it matter in non `GET` methods? |
@@ -144,6 +144,17 @@ func AddMember(ctx context.Context, g *libkb.GlobalContext, teamname, username s
if err != nil {
return keybase1.TeamAddMemberResult{}, err
}
+ existingUV, err := t.UserVersionByUID(ctx, uv.Uid)
+ if err == nil {
+ // Case where same UV (uid+seqno) already exists is covered by
+ // `t.IsMe... | [IsMember,Exists,Leave,GetUID,Members,RootAncestorName,NewHTTPArgs,ResolveFullExpressionNeedUsername,NormalizedUsername,Eq,GetError,Add,GetUsername,ChangeMembership,Post,New,MemberRole,GetNormalizedName,deleteRoot,InviteMember,Errorf,deleteSubteam,AsTeam,ResolveWithBody,TeamID,NewLoadUserArgWithContext,GetTeamLoader,Ne... | AddMember implements the AddMember interface for teams. EditMember is a helper to edit a member of a team. | more descriptive error could be `"newer version of users already exists in team the team (%v > %v)", existingUV.EldestSeqno, uv.EldestSeqno` |
@@ -185,6 +185,18 @@ void rgblight_update_dword(uint32_t dword) {
}
}
+void rgblight_update_dword_noeeprom(uint32_t dword) {
+ rgblight_config.raw = dword;
+ if (rgblight_config.enable)
+ rgblight_mode_noeeprom(rgblight_config.mode);
+ else {
+ #ifdef RGBLIGHT_ANIMATIONS
+ rgblight_timer_disable();
... | [No CFG could be retrieved] | This function initializes the RGBLight functionality. region RGBLight Functions. | would it be better if rgblight_update_dword were also changed to delegate to this function after (or before) writing the eeprom, rather than having most of the body be duplicated in both places? |
@@ -328,7 +328,9 @@ public class ManagerTest extends BlockGenerate {
.build());
chainManager.getAssetIssueStore().put(assetID.getBytes(), assetIssue);
try {
- dbManager.adjustAssetBalanceV2(accountAddress.getBytes(), assetID, -20);
+ adjustAssetBalanceV2(accountAddress.getBytes(), asset... | [ManagerTest->[setBlockReference->[setBlockReference],pushSwitchFork->[pushBlock],fork->[pushBlock],createTestBlockCapsule->[createTestBlockCapsule],pushBlockInvalidMerkelRoot->[pushBlock],pushBlock->[pushBlock],doNotSwitch->[pushBlock],pushBlockTooMuchShieldedTransactions->[pushBlock],switchBack->[pushBlock],pushBlock... | adjust asset balance. | Please use chainbaseManager instead of dbManager |
@@ -146,11 +146,14 @@ class PrefetchToDeviceTest(test_base.DatasetTestBase, parameterized.TestCase):
host_dataset = dataset_ops.Dataset.range(10)
device_dataset = host_dataset.apply(
- prefetching_ops.prefetch_to_device("/gpu:0"))
+ prefetching_ops.prefetch_to_device('/gpu:0'))
iterator... | [PrefetchToDeviceTest->[testPrefetchDictToDevice->[assertTrue,make_one_shot_iterator,device,ConfigProto,get_structure,apply,prefetch_to_device,assertEqual,evaluate,test_session,get_next,assertRaises,range,are_compatible],testPrefetchToDeviceWithReInit->[assertTrue,device,make_initializable_iterator,ConfigProto,get_stru... | Test prefetch to device GPU. | Please respect the original style for quotes in the file instead of changing it. |
@@ -10,6 +10,7 @@ module Users
delete_user_activity
user.unsubscribe_from_newsletters
EdgeCache::Bust.call("/#{user.username}")
+ Users::Suspended.create_from_user(user) if user.has_role?(:banned)
user.destroy
Rails.cache.delete("user-destroy-token-#{user.id}")
end
| [Delete->[delete_comments->[call],call->[call],delete_user_activity->[call],delete_articles->[call]]] | Returns a new user object if there is no user object with the same id. | Might want to add this `if` inside `create_from_user` and plan ahead for the `suspended` role that's coming down the pipeline in #12270 |
@@ -133,3 +133,17 @@ ReducerRegistry.register('features/base/tracks', (state = [], action) => {
return state;
}
});
+
+/**
+ * Listen for actions that mutate the no-src-data state, like the current notification id
+ */
+ReducerRegistry.register('features/base/no-src-data', (state = {}, action) => {
+ ... | [No CFG could be retrieved] | The state of the object. | This doesn't feel exactly kosher ( having two reducer states in the same file), however the alternative would be to move the no src data notification functionality to a feature of its own. I didn't know what the best approach here was so waiting for suggestions. Thanks. |
@@ -3515,9 +3515,7 @@ function img_picto($titlealt, $picto, $moreatt = '', $pictoisfullpath = false, $
'github', 'jabber', 'skype', 'twitter', 'facebook', 'linkedin', 'instagram', 'snapchat', 'youtube', 'google-plus-g', 'whatsapp',
'chevron-left', 'chevron-right', 'chevron-down', 'chevron-top', 'commercial', ... | [dol_print_url->[trans],dol_print_socialnetworks->[load,trans],img_help->[trans],dol_print_ip->[trans],getBrowserInfo->[isMobile,is,isTablet],img_error->[trans],img_action->[transnoentitiesnoconv],img_allow->[trans],get_htmloutput_mesg->[trans,load],dol_get_fiche_head->[executeHooks,trans],print_fleche_navigation->[tra... | This function creates a picto image - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - The default state of the network layer. The calendar - day interface. | Why did you remove 'supplier_invoicea', 'supplier_invoicer', 'supplier_invoiced', |
@@ -581,11 +581,15 @@ class WP_Test_Jetpack_Sync_Post extends WP_Test_Jetpack_Sync_Base {
function test_remove_sharedaddy_from_filtered_content() {
require_once JETPACK__PLUGIN_DIR . 'modules/sharedaddy/sharing-service.php';
-
+ set_current_screen( 'front' );
+ add_filter( 'sharing_show', '__return_true' );
+ ... | [WP_Test_Jetpack_Sync_Post->[test_add_post_syncs_post_data->[filter_post_content_and_add_links,post_count,assertEquals,get_post],test_filters_out_blacklisted_post_types_and_their_post_meta->[create,get_metadata,get_post,do_sync,assertFalse,assertEquals],test_sync_post_filtered_content_was_filtered->[do_sync,assertEqual... | This test removes the sharedaddy from filtered content. | this line needs some formatting |
@@ -40,8 +40,8 @@ function jetpack_social_menu_get_svg( $args = array() ) {
// Set defaults.
$defaults = array(
- 'icon' => '',
- 'fallback' => false,
+ 'icon' => '',
+ 'fallback' => false,
);
// Parse args.
| [No CFG could be retrieved] | Get the Jetpack social menu SVG markup. | It looks like you got rid of some spaces here by mistake. |
@@ -115,7 +115,7 @@ typedef struct dt_iop_atrous_data_t
const char *name()
{
- return _("equalizer");
+ return _("contrast equalizer");
}
int groups()
| [No CFG could be retrieved] | region IOP_ATROUUS_DATA_T Section 9. 1. 1 END of function init_key_accels. | What @parafin said, this is not really correct; as it is evident from the presets, the module is not limited to contrast. |
@@ -23,6 +23,8 @@ use Sulu\Component\Content\SimpleContentType;
class Link extends SimpleContentType
{
public const LINK_TYPE_EXTERNAL = 'external';
+ public const LINK_TYPE_PAGE = 'page';
+ public const LINK_TYPE_MEDIA = 'media';
/**
* @var LinkProviderPoolInterface
| [Link->[getViewData->[getValue],getContentData->[getValue,getUrl,preload,getProvider]]] | Link selection content type for linking to different providers. Get content data. | `page` and `media` are dynamic link provider types. They should not be added here as constant. As they come from a registry and more types are possible. Only the external type is a internal type which we need handle here, specially. Where was it required for you to check for this constants? |
@@ -938,11 +938,11 @@ end
# tfile = testsupporters[key]
# # Check to see if this is an update or a new file:
-# # - If 'id' exists, this is an update
+# # - If 'id' exist, this is an update
# # - If 'id' does not exist, this is a new test file
# tf_id = tfile['id']
... | [run_ant_file->[short_identifier,system,each_line,new,exists?,cd,create,id,raise,pwd,now,join,close,parse_test_output,exitstatus,t,open,l],delete_test_repo->[exists?,markus_config_automated_tests_repository,rm_rf,repo_name,join],add_parser_file_link->[new,render,link_to_function,escape_javascript,t],export_repository->... | Filter out test files that need to be created and updated Update all attributes of a single object. | Line is too long. [104/80] |
@@ -133,7 +133,7 @@ public class GroupByRowProcessor
@Override
public CloseableGrouperIterator<RowBasedKey, Row> make()
{
- final List<Closeable> closeOnFailure = Lists.newArrayList();
+ final List<Closeable> closeOnExit = Lists.newArrayList();
try {... | [GroupByRowProcessor->[process->[cleanup->[close],make->[close->[close,get],get->[get],close]]]] | Process a sequence of rows. Creates a new iterator that iterates over all rows in the sequence. Called when an exception is caught while setting up the iterator. | Why not using `Closer` for this? |
@@ -61,6 +61,12 @@ public class NativeMethodHandle extends PrimitiveHandle {
initJ9NativeCalloutDataRef(null);
}
+ /* This constructor is used via NativeInvoker for vararg methods. J9NativeCalloutDataRef is not initialized here. */
+ NativeMethodHandle(String methodName, MethodType type, LibrarySymbol symbol) th... | [NativeMethodHandle->[cloneWithNewType->[checkIfPrimitiveType,NativeMethodHandle],initJ9NativeCalloutDataRef]] | This method is called to compute the list of thunks that should be compiled. | I don't think we need to add another constructor, the caller can just can just extract the address from the LibrarySymbol |
@@ -110,7 +110,8 @@ class PackageUtil {
// Create the DataflowPackage with staging name and location.
String uniqueName = getUniqueContentName(source, hash);
- String resourcePath = IOChannelUtils.resolve(stagingPath, uniqueName);
+ String resourcePath = FileSystems.matchSingleFileSpec(staging... | [PackageUtil->[stageOnePackage->[makeWriter],stageClasspathElements->[run->[stageOnePackage],PackageUploadOrder,computePackageAttributes,stageClasspathElements],computePackageAttributes->[call->[createPackageAttributes]]]] | Creates a new PackageAttributes object with the given parameters. | I think this should be `matchNewResource`. Staging dir may not exist, for example. |
@@ -109,6 +109,8 @@ public class SparkInterpreter extends Interpreter {
.add("zeppelin.spark.maxResult",
getSystemDefault("ZEPPELIN_SPARK_MAXRESULT", "zeppelin.spark.maxResult", "1000"),
"Max number of SparkSQL result to display.")
+ .add("spark.auto.restart.sc"... | [SparkInterpreter->[getProgress->[getJobGroup],interpretInput->[toString,interpret],getSQLContext->[useHiveContext,getSparkContext],getProgressFromStage_1_0x->[getProgressFromStage_1_0x],getProgressFromStage_1_1x->[getProgressFromStage_1_1x],close->[close],cancel->[getJobGroup],open->[getDependencyResolver,getSQLContex... | Creates a spark interpreter for the given n - tuple. Creates a interpreter that can be used to run a single SQL interpreter. | If this is a zeppelin config, I think this should start with 'zeppelin', ie, zeppelin.spark.auto.restart.sc |
@@ -85,7 +85,7 @@ public final class HandlerAdapterInstrumentation extends Instrumenter.Default {
// Name the parent span based on the matching pattern
final Object parentContext = request.getAttribute(CONTEXT_ATTRIBUTE);
if (parentContext instanceof Context) {
- DECORATE.onRequest(getSpan((... | [HandlerAdapterInstrumentation->[ControllerAdvice->[nameResourceAndStartSpan->[getAttribute,getSpan,isValid,onRequest,afterStart,startSpan,currentContextWith,SpanWithScope],stopSpan->[getSpan,onError,end,beforeFinish,closeScope]],typeMatcher->[named,implementsInterface],classLoaderMatcher->[hasClassesNamed],transformer... | Name the parent span based on the given pattern and handler. | `SpringWebMvcDecorator.DECORATOR` now extends `HttpServerTracerBase`. I had to rename this method to avoid a name conflict. DECORATOR.OnRequest is now used to set span attributes and create the default span name while `DECORATE.updateSpanNameUsingPattern()` updates a span with a custom name. |
@@ -84,9 +84,9 @@ define([
*/
Color.fromCartesian4 = function(cartesian, result) {
//>>includeStart('debug', pragmas.debug);
- if (!defined(cartesian)) {
- throw new DeveloperError('cartesian is required');
- }
+
+ Check.typeOf.object('cartesian', cartesian);
+
... | [No CFG could be retrieved] | Creates a new Color instance from a given cartesian. Creates a new Color instance from the given red green blue and alpha components. | Throughout, remove any empty lines surrounding the check. |
@@ -1069,6 +1069,11 @@ func (b *Boxer) compareHeadersMBV2orV3(ctx context.Context, hServer chat1.Messag
return NewPermanentUnboxingError(NewHeaderMismatchError("EphemeralMetadata"))
}
+ // BotUID (only present in V3 and greater)
+ if version > chat1.MessageBoxedVersion_V2 && !gregor1.UIDPtrEq(hServer.BotUID, hSi... | [unboxV1->[bodyUnsupported,headerUnsupported],assertInTest->[log],box->[preBoxCheck],unboxV2orV3orV4->[detectPermanentError,validatePairwiseMAC],attachMerkleRoot->[latestMerkleRoot],makeAllPairwiseMACs->[makeHeaderHash],boxV2orV3orV4->[makeAllPairwiseMACs,makeBodyHash],unversionBody->[bodyUnsupported],getSenderInfoLoca... | CompareHeadersMBV2orV3 compares two MessageClientHeaders in order to see if Make a message header hash from a MerkleRoot. return nil if there is no orphan. | since key reader support and chat reader support are going out in the same release i didn't bump this version |
@@ -37,6 +37,13 @@ void ConnectivityPreserveModeler::GenerateModelPart(
{
KRATOS_TRY;
+ if(rOriginModelPart.IsSubModelPart() == true)
+ KRATOS_ERROR << "ConnectivityPreserveModeler expects to work on root modelparts. This is not the case for the ORIGIN model part named: " << rOriginModelPart << std::... | [DuplicateSubModelParts->[DuplicateCommunicatorData,DuplicateSubModelParts]] | This method is called to generate a model part from the source model part. | TODO: this should be a different PR |
@@ -22,6 +22,15 @@ const (
Sent = "SENT"
)
+// Errors ...
+var (
+ // ErrInvalidMsgForStakingDirective is returned if a staking message does not
+ // match the related directive
+ ErrInvalidMsgForStakingDirective = errors.New("staking message does not match directive message")
+ // ErrInvalidSender is returned... | [Value,GasPrice,Size,ShardID,Hash,StakingToMessage,AddressToBech32,Itoa,Error,ChainID,To,Type,Logger,Gas,ToShardID,Time,Hex,NewEIP155Signer,Data,Int64,Err,EncodeToString,Header,Msg,SetUint64,From,NewInt,AsMessage,Mul,Number] | GetTransaction imports a transaction from a chain. fee is the fee of the transaction. | no need to redefine these? available under core2? |
@@ -105,11 +105,11 @@ Status ATCConfigParserPlugin::setUp() {
Status ATCConfigParserPlugin::update(const std::string& source,
const ParserConfig& config) {
auto cv = config.find(kParserKey);
- if (cv == config.end()) {
- return Status(1, "No configuration for ATC (Auto Tabl... | [generate->[getMessage,getSqliteJournalMode,ok,LOG,VLOG,genTableRowsForSqliteTable,resolveFilePattern,getCode],registeredATCTables->[scanDatabaseKeys,insert,substr,size],update->[Status,getMessage,find,size,GetObject,deleteDatabaseValue,HasMember,reserve,VLOG,end,empty,getDatabaseValue,erase,push_back,make_tuple,params... | Updates the configuration of an ATC. System method for setting the table in the database and checking if the table is in the list. | I'm confused why this is returning a `Status::success()`. If the object wasn't found, or `.IsObject()` was false shouldn't this be a `::failure`? |
@@ -17,6 +17,8 @@ class RuntimeClasspathPublisher(Task):
super().register_options(register)
register('--manifest-jar-only', type=bool, default=False,
help='Only export classpath in a manifest jar.')
+ register('--internal-classpath-only', type=bool, default=True,
+ help='Only expo... | [RuntimeClasspathPublisher->[_output_folder->[replace],prepare->[require_data],register_options->[register,super],execute->[classpath,targets,safe_classpath,create_canonical_classpath,get_data,get_options,join]]] | Register options for the command line tool. | I know third party libraries is typically what binary jar dependencies are typically used for, but is there a more precise term you can use here? Perhaps `jar_library` dependencies? |
@@ -41,7 +41,7 @@ public class AggregateResults implements Serializable {
public BattleResults getBattleResultsClosestToAverage() {
double closestBattleDif = Integer.MAX_VALUE;
BattleResults closestBattle = null;
- for (final BattleResults results : m_results) {
+ for (final BattleResults results : r... | [AggregateResults->[getAverageTuvSwing->[getAverageTuvOfUnitsLeftOver],getAverageDefendingUnitsRemaining->[getBattleResultsClosestToAverage],getAverageAttackingUnitsRemaining->[getBattleResultsClosestToAverage]]] | Get the BattleResults closest to the average. | Well, that's confusing. :smile: Obviously, the compiler can figure it out, but to make it clear for a reader (and to be consistent with all the other similar for-each loops in this class), maybe just rename the loop variable to `result`? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.