patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -368,6 +368,12 @@ namespace Microsoft.Xna.Framework
public void ToggleFullScreen()
{
IsFullScreen = !IsFullScreen;
+#if WINDOWS && DIRECTX
+
+ // FIXME : FULLSCREEN
+
+ ApplyChanges();
+#endif
}
#if WINDOWS_STOREAPP
| [GraphicsDeviceManager->[Dispose->[Dispose],Initialize->[ApplyChanges]]] | Toggle full screen. | Another FIXME that needs an explanation. |
@@ -240,14 +240,6 @@ if ($_SESSION['userlevel'] < '5') {
}
}
- $peerhost = dbFetchRow('SELECT * FROM ipaddr AS A, ports AS I, devices AS D WHERE A.addr = ? AND I.port_id = A.port_id AND D.device_id = I.device_id', array($peer['bgpPeerIdentifier']));
-
- if ($peerhost) {
- ... | [No CFG could be retrieved] | Get the color of the missing header Creates a list of overlib graphs for the given national node. | `$peername` set and never used so removed as query for `$peerhost` is totally wrong (non-existent table). |
@@ -258,6 +258,9 @@ class EventData(object):
except Exception as e:
raise TypeError("Event data is not compatible with JSON type: {}".format(e))
+ def encode_message(self):
+ return self.message.encode_message()
+
class Offset(object):
"""
| [EventHubError->[__init__->[partition,decode,super,format,isinstance,_parse_error],_parse_error->[find,append,decode,isinstance,index]],_error_handler->[ErrorAction],parse_sas_token->[split,partition,lower],Offset->[selector->[,timegm,isinstance,utctimetuple]],EventData->[partition_key->[dict,MessageHeader,get],offset-... | Returns the body of the event as a JSON object. | Do we want to make this public? What's the scenario requiring this? |
@@ -222,7 +222,7 @@ def parse_conanfile(conanfile_path, python_requires):
module, filename = _parse_conanfile(conanfile_path)
try:
conanfile = _parse_module(module, filename)
- conanfile.python_requires = py_requires
+ conanfile.python_requires = {it.ref.name: it for... | [parse_conanfile->[_parse_module],ConanFileLoader->[load_consumer->[load_class,_initialize_conanfile],load_conanfile->[load_class,_initialize_conanfile],load_export->[load_class]]] | Parse a conanfile and return the module and the conanfile. | I am ok with changing it to a dict, but then, declaring multiple python-requires with the same name should raise an Exception, displaying the conflict. Please implement that check. |
@@ -86,7 +86,7 @@ catch(\UnexpectedValueException $e) {
// Do something with $event
http_response_code(200); // PHP 5.4 or greater
-$langs->load("main");
+$langs->loadLangs(array("main","other","dict","bills","companies","errors","stripe"));
$user = new User($db);
$user->fetch(5);
$user->getrights();
| [fetch,getStripeCustomerAccount,addPaymentToBank,create,add_url_line,setDefaultLang,fetch_object,getSommePaiement,addline,createFromOrder,createPaymentStripe,classifyBilled,begin,switchEntity,load,getSumCreditNotesUsed,escape,getrights,generateDocument,query,getStripeAccount,validate,trans,num_rows,set_paid,commit,getS... | Stripe Live - > Stripe Live - > Stripe Live - > Stripe Live - > Stripe Live find the national chaine. | $user->fetch(5); why userid 5 ? |
@@ -365,8 +365,8 @@ static OSSL_PARAM static_api_params[] = {
OSSL_PARAM_BN("p3", &bignumbin, sizeof(bignumbin)),
OSSL_PARAM_DEFN("p4", OSSL_PARAM_UTF8_STRING, &app_p4, sizeof(app_p4)),
OSSL_PARAM_DEFN("p5", OSSL_PARAM_UTF8_STRING, &app_p5, sizeof(app_p5)),
- /* sizeof(app_p6_init), because we know th... | [setup_tests->[OSSL_NELEM,ADD_ALL_TESTS],void->[OPENSSL_zalloc,OPENSSL_strdup,TEST_ptr,OPENSSL_free,strcpy,BN_hex2bn,BN_free,cleanup_object,TEST_true],int->[TEST_str_eq,OSSL_PARAM_get_double,init_app_variables,TEST_true,OSSL_PARAM_get_utf8_string,TEST_ptr,TEST_int_eq,cleanup_app_variables,strlen,TEST_info,OSSL_PARAM_ge... | The main function for the OSSL_PARAM array. Construct the OSSL_PARAM array from the given array of values. | Change app_p6_init to app_p6 |
@@ -698,7 +698,9 @@ angular.module('zeppelinWebApp')
scrollTargetPos = documentHeight;
}
}
- angular.element('body').scrollTo(scrollTargetPos, {axis: 'y', interrupt: true, duration:200});
+ angular.element('body').stop();
+ angular.element('body').finish();
+ angular.element('body').scr... | [No CFG could be retrieved] | scope - editor - editor END FUNCTIONS Check if time is in nanoseconds. | @Leemoonsoo avoid using `angular.element('body')` multiple times. better to have it in a `var` and reuse. |
@@ -117,7 +117,9 @@ public class AvroDataTranslator implements DataTranslator {
case STRUCT:
return convertStruct((Struct) object, schema);
-
+ case BYTES:
+ return DecimalUtil.ensureFit(
+ (BigDecimal) object, DecimalUtil.precision(schema), DecimalUtil.scale(schema));
de... | [AvroDataTranslator->[toKsqlRow->[toKsqlRow],replaceSchema->[convertStruct,replaceSchema],toConnectRow->[toConnectRow]]] | Replace schema with object. | Why don't we just use `public static BigDecimal ensureFit(final BigDecimal value, final Schema schema)`? |
@@ -155,6 +155,16 @@ func (s *StoreStatus) GetUptime() time.Duration {
return 0
}
+// GetHeartbeatInterval roughly calculates the heartbeat interval.
+// returns zero interval when there is no heartbeat arrived.
+func (s *StoreStatus) GetHeartbeatInterval() time.Duration {
+ if s.HeartbeatCount == 0 {
+ return ti... | [getLocationID->[getLabelValue],resourceScores->[leaderRatio,storageRatio],clone->[clone],resourceRatio->[leaderRatio,storageRatio]] | GetUptime returns the uptime of the store. | This doesn't look reliable. How about sending interval along with Heartbeat request from tikv-server? |
@@ -42,10 +42,10 @@ class SimpleTagger(Model):
self.tag_projection_layer = TimeDistributed(Linear(self.stacked_encoder.get_output_dim(),
self.num_classes))
- # pylint: disable=arguments-differ
def forward(self, # type: ignore
... | [SimpleTagger->[tag->[forward],from_params->[from_params]]] | Initialize the SimpleTagger with a Vocabulary and a sequence of tag - classes. A scalar loss to be optimised. | We could give models which can be `TextFieldEmbedders` a `get_embedding_representations()` method, which calls forward and contains the unpacking logic for what is needed for the representation. |
@@ -280,6 +280,16 @@ struct dc_mgmt_psr {
__rc; \
})
+static void
+put_attach_info(int npsrs, struct dc_mgmt_psr *psrs)
+{
+ int i;
+
+ for (i = 0; i < npsrs; i++)
+ D_FREE(psrs[i].uri);
+ D_FREE(psrs);
+}
+
/*
* Get the attach info (i.e., the CaRT PSRs) for name. npsrs outputs the number
* of elements ... | [No CFG could be retrieved] | Get the attach info for the given name. get the attach info for the given system. | I assume this name was chosen to be the converse of `get_attach_info()`... While the symmetry is nice, it's a little misleading. As a reader of code, I'd prefer not to have to go look at the implementation of a function to figure out what it really does. I suggest `free_psr_list()` for the "boringly descriptive" angle. |
@@ -223,12 +223,12 @@ class AzureAppConfigurationClient:
@distributed_trace
def get_configuration_setting(
self,
- key,
- label=None,
- etag="*",
- match_condition=MatchConditions.Unconditionally,
- **kwargs
- ): # type: (str, Optional[str], Optional[str], Optio... | [AzureAppConfigurationClient->[close->[close],__exit__->[__exit__],__enter__->[__enter__]]] | Gets the ConfigurationSetting object that matches the specified key label and optional match condition. Get a from the generated key. | This still seems odd to me, but if it's the expected behavior then I think we should probably update the `:rtype:` in the docstring and perhaps explain in `:return:` what case `None` could be returned |
@@ -1370,7 +1370,7 @@ class DistributeTranspiler(object):
def _get_output_map_from_op(self, varmap, op):
"""Returns a dict from op output name to the vars in varmap."""
- iomap = dict()
+ iomap = collections.OrderedDict()
for key in op.output_names:
vars = []
... | [DistributeTranspiler->[_append_pserver_ops->[_get_optimizer_input_shape,same_or_split_var],get_startup_program->[_get_splited_name_and_shape->[same_or_split_var],_get_splited_name_and_shape],_create_ufind->[_is_op_connected],_orig_varname->[_get_varname_parts],_get_optimize_pass->[_is_opt_role_op],_is_splited_grad_var... | Returns a dict from the output name to the vars in varmap. | Why we need OrderedDict here? |
@@ -670,6 +670,9 @@ class WPCOM_JSON_API_GET_Site_Endpoint extends WPCOM_JSON_API_Endpoint {
case 'anchor_podcast':
$options[ $key ] = $site->get_anchor_podcast();
break;
+ case 'is_difm_lite_in_progress':
+ $options[ $key ] = $site->is_difm_lite_in_progress();
+ break;
case 'site_inten... | [WPCOM_JSON_API_GET_Site_Endpoint->[decorate_jetpack_response->[has_blog_access,render_option_keys,has_user_access,render_response_keys]]] | Renders the options for the current page. This function is used to get all the options of a site. This filter is used to filter out the options of a site. This function returns an array of options that can be passed to the page_for_posts This function is used to get all options from a site object. | Should `is_difm_lite_in_progress` be added to the `$site_options_format` array above in that file? |
@@ -80,10 +80,12 @@ describe Deploy::Activate do
expect(s3_client).to have_received(:get_object).with(
bucket: 'login-gov.secrets.12345-us-west-1',
key: 'common/GeoIP2-City.mmdb',
+ response_target: subject.send(:geolocation_db_path),
)
expect(s3_client).to have_received(:g... | [stub_responses,new,let,to_not,describe,reset!,join,it,mkdir_p,to,before,with,require,params,change,dirname,to_json,mktmpdir,hex,receive,read,around,present?,to_timeout,context,write,proc,raise,eq,and_call_original,run,to_return,raise_error,and_return] | downloads the pwned passwords and geoIP files from s3 expects the subject to be in the geolite environment. | I don't love this, but it seems like something in the test changed to be stricter during the conversion to kwargs |
@@ -48,6 +48,16 @@ export class AmpSlides extends BaseCarousel {
/** @private {number} */
this.currentIndex_ = 0;
+
+ /** @private {?number} */
+ this.autoplayTimeoutId_ = null;
+
+ this.setupAutoplay_();
+
+ // Setup microtask to let the runtime settle.
+ // TODO: (erwinm) experiment with on... | [No CFG could be retrieved] | Package for the AmpSlides class. Private method for updating current slide. | How about setting the timer in `#setupAutoplay_`? It'll avoid setting up this timer when there's no `autoplay` attribute, and guard against non-positive values. |
@@ -234,10 +234,9 @@ namespace System.ComponentModel.Design
void IDesignerFilter.PreFilterProperties(IDictionary properties)
{
- if (Component is IPersistComponentSettings)
+ if (Component is IPersistComponentSettings && properties != null)
{
- Prope... | [ComponentDesigner->[GetService->[GetService],ShowContextMenu->[GetService,ShowContextMenu],RaiseComponentChanging->[GetService],ShadowPropertyCollection->[ShouldSerializeValue->[ShouldSerializeValue,Contains]],InheritanceAttribute->[InheritanceAttribute],Dispose->[Dispose],RaiseComponentChanged->[GetService]]] | Pre filter properties. | Can we put this magic string in some const private field? Looks like it appears 10 times in this file and 7 times in ToolStripDropDownDesigner |
@@ -605,6 +605,12 @@ ContentFeatures read_content_features(lua_State *L, int index)
// Set to true if wall_mounted used to be set to true
getboolfield(L, index, "legacy_wallmounted", f.legacy_wallmounted);
+ // Client shall immediately place this node when player digs the node.
+ // Server will update the precise... | [read_noiseparams->[getflagsfield],push_noiseparams->[push_flags_string],read_items->[read_item],read_content_features->[read_tiledef],read_json_value->[read_json_value],read_animation_definition->[getenumfield]] | This function read content features from lua This function checks if a field of a given type is defined in the Lua file. read a tiledef from lua This function is used to get the palette of a node. Protected get field values for a node This function gets the value of an unknown field from L This function gets the proper... | How do you distinguish `""` from `nil` here? |
@@ -344,6 +344,15 @@ class ModelBase(SearchMixin, SaveUpdateMixin, models.Model):
class Meta:
abstract = True
get_latest_by = 'created'
+ # This is important: Setting this to `objects` makes sure
+ # that Django is using the manager set as `objects` on this
+ # instance reath... | [SearchMixin->[index->[_get_index],search->[_get_index],unindex->[_get_index]],RawQuerySet->[__len__->[__iter__]],BaseQuerySet->[only_translations->[no_transforms],no_transforms->[pop_transforms]],SaveUpdateMixin->[update->[get_unfiltered_manager]],OnChangeMixin->[_send_changes->[_NoChangeInstance,update],save->[_send_... | Returns the absolute url path of the object. | And what would `_base_manager` or `_default_manager` be? Do they need to be defined too? |
@@ -70,6 +70,17 @@ public class ProfilerEditingTarget implements EditingTarget
server_ = server;
globalDisplay_ = globalDisplay;
pSourceWindowManager_ = pSourceWindowManager;
+ fileDialogs_ = fileDialogs;
+ fileContext_ = fileContext;
+ workbenchContext_ = workbenchContext;
+ ev... | [ProfilerEditingTarget->[getId->[getId],buildHtmlPath->[getPath],asWidget->[asWidget],getPath->[getPath],recordCurrentNavigationPosition->[getId]]] | Returns the id of the node in the document. | Could this ever be false in the constructor? |
@@ -93,6 +93,7 @@ public class SearchMetadataIT {
@ContainerMatrixTest
void testRetrievingMetadataForStoredSearchWithParameter() {
+ LOG.error("testRetrievingMetadataForStoredSearchWithParameter()");
final ValidatableResponse response = given()
.spec(requestSpec)
... | [SearchMetadataIT->[testRetrievingMetadataForStoredSearchWithParameter->[statusCode,body,contains,anEmptyMap],fixture->[getResourceAsStream],testEmptyRequest->[equalTo,body],testRetrievingMetadataForStoredSearchWithoutParameter->[statusCode,empty,body,anEmptyMap],testMinimalRequestWithoutParameter->[statusCode,empty,bo... | This test tests the response for retrieving the metadata for a stored search with a parameter. | Should we remove this logging before merging? |
@@ -351,7 +351,6 @@ func getIndentationString(indent int, op deploy.StepOp, prefix bool) string {
}
func writeWithIndent(b *bytes.Buffer, indent int, op deploy.StepOp, prefix bool, format string, a ...interface{}) {
- b.WriteString(colors.Reset)
b.WriteString(op.Color())
b.WriteString(getIndentationString(inden... | [plan->[GetPwdMain,Errorf,NewEvalSource,Assert,QName,NewPlan,NewContext],Close->[Close],printPlan->[Sprintf,Walk,New,Errorf,WriteString,Success],Walk->[Next,IgnoreError,Apply,Start,Close,Assert],IsObject,Value,IsAssets,NewBlindingDecrypter,PastTense,Old,ArrayValue,NewArchiveProperty,DiffLinesToChars,Assertf,BoolValue,D... | Prints the header of a step. printResourceProperties prints the resource properties of a node. | unnecessary. always followed by WriteString(op.Color()) and op.Color() always returns a non-empty string. |
@@ -74,6 +74,6 @@ bad_pick = 98 # channel with no evoked response
plt_times = np.linspace(0, .2, len(epochs))
plt.close('all')
-mne.viz.plot_epochs_image(epochs, [good_pick, bad_pick], sigma=0.5, vmin=-100,
- vmax=250, colorbar=True, order=order_func,
+mne.viz.plot_epochs_image(epochs, [go... | [order_func->[spectral_embedding,argsort,sqrt,sum],read_events,dict,print,data_path,len,read_raw_fif,linspace,plot_epochs_image,close,Epochs,pick_types] | Plot the epochs in a plot. | magma is inappropriate for symmetric colormaps. Please just remove passing a custom cmap |
@@ -383,6 +383,7 @@ public abstract class MiniOzoneChaosCluster extends MiniOzoneHAClusterImpl {
DefaultMetricsSystem.setMiniClusterMode(true);
initializeConfiguration();
+
if (numOfOMs > 1) {
initOMRatisConf();
}
| [MiniOzoneChaosCluster->[Builder->[initializeConfiguration->[initializeConfiguration],setNumDatanodes->[setNumDatanodes],setFailureService->[of],build->[initializeConfiguration]],fail->[getFailureMode,getClusterReady,shutdownNodes,isClusterReady,restartNodes],shutdownNodes->[restartNode,getNodeToFail,getFailedNodeID,sh... | Build a new MiniOzoneChaosCluster. | NIT: Only space change |
@@ -12,6 +12,7 @@ import (
const (
ContainerIndexerName = "container"
PodNameIndexerName = "pod_name"
+ PodUidIndexerName = "pod_uid"
IPPortIndexerName = "ip_port"
)
| [GetMetadata->[GetMetadata],GetIndexes->[GetIndexes]] | Add_kubernetes_metadata import imports and imports the given object. GetIndexes returns a list of indexes for the given pod. | const PodUidIndexerName should be PodUIDIndexerName |
@@ -3592,10 +3592,9 @@ def lstm_step_layer(input,
:type gate_act: BaseActivation
:param state_act: State Activation Type. TanhActivation is the default.
:type state_act: BaseActivation
- :param bias_attr: The bias attribute. If the parameter is set to False or an object
- whose ty... | [seq_concat_layer->[LayerOutput],out_prod_layer->[LayerOutput],img_pool_layer->[LayerOutput],multiplex_layer->[LayerOutput],cross_entropy->[LayerOutput,__cost_input__],multibox_loss_layer->[LayerOutput],gated_unit_layer->[fc_layer,dotmul_operator,mixed_layer],lstm_step_layer->[LayerOutput],clip_layer->[LayerOutput],Mix... | This function is used in lstm step layer. LSTM layer with no extra attribute. | The parameter attribute for bias. If this parameter |
@@ -1,5 +1,5 @@
module AccountRecoverable
def piv_cac_enabled_but_not_phone_enabled?
- current_user.piv_cac_enabled? && !current_user.phone_enabled?
+ current_user.piv_cac_enabled? && !current_user.phone_configuration&.mfa_enabled?
end
end
| [piv_cac_enabled_but_not_phone_enabled?->[piv_cac_enabled?,phone_enabled?]] | check if piv_cac_enabled? but not phone_enabled?. | Given that we know this logic will change for sure when we support multiple phone configurations, what do you think about encapsulating this logic inside the `SmsLoginOptionPolicy` class, or some other Policy class? That way, when the logic inevitably changes, we will only need to make a change in one place. |
@@ -88,7 +88,8 @@ public class InstallUtil {
// Edge case: used Jenkins 1 but did not save the system config page,
// the version is not persisted and returns 1.0, so try to check if
// they actually did anything
- if (!Jenkins.getInstance().getItemMap().isEmpty()) {
+ ... | [InstallUtil->[persistInstallStatus->[getInstallingPluginsFile],clearInstallStatus->[persistInstallStatus],getPersistedInstallStatus->[getInstallingPluginsFile],saveLastExecVersion->[saveLastExecVersion]]] | Get the install state. | Does this correctly handle the 2.0 case, which is a different security realm by default? |
@@ -613,7 +613,10 @@ class UpdateChannelsMixin(object):
# Create final data / info objects
data = np.concatenate(data, axis=con_axis)
- infos = [self.info] + [inst.info for inst in add_list]
+ infos_to_add = deepcopy([inst.info for inst in add_list])
+ if force_update_info is Tr... | [ContainsMixin->[__contains__->[_contains_ch_type]],_get_T1T2_mag_inds->[pick_types],UpdateChannelsMixin->[pick_types->[pick_types],_pick_drop_channels->[inst_has]],read_ch_connectivity->[_recursive_flatten],fix_mag_coil_types->[pick_types],SetChannelsMixin->[set_channel_types->[_check_set],rename_channels->[rename_cha... | Append new channels to the current object. missing - object - > missing - object - > missing - object - > missing - object. | I would pass the force_update_info param to _merge_info and do the logic in there |
@@ -75,6 +75,12 @@ public class CompositeClassLoader extends ClassLoader implements ClassLoaderLook
final ClassLoaderLookupStrategy lookupStrategy = lookupPolicy.getLookupStrategy(name);
Class<?> result;
+ /*
+ * Gather information about the exceptions in each of the contained classlo... | [CompositeClassLoader->[getResources->[getResources],loadClass->[loadClass],getResourceAsStream->[getResourceAsStream],doLoadClass->[loadClass],findLibrary->[findLibrary],getResource->[getResource]]] | loadClass - load a class. | Add link to ClassNotFoundException |
@@ -246,6 +246,7 @@ define([
* horizontalOrigin : HorizontalOrigin.CENTER,
* verticalOrigin : VerticalOrigin.CENTER,
* scale : 1.0,
+ * scaleByDistance : [5e6, 1.0, 2e7, 0.0]
* imageIndex : 0,
* color : Color.WHITE
* });
| [No CFG could be retrieved] | Creates a new billboard with the specified initial properties. Adds a Billboard to the collection. | Add comma to the end. |
@@ -59,14 +59,14 @@ namespace Microsoft.CSharp.RuntimeBinder
{
public RuntimeBinderException() { }
protected RuntimeBinderException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
- public RuntimeBinderException(string message... | [CSharpArgumentInfo->[Never],Binder->[Never],Never] | Exception that can be thrown by the compiler. | For such a large library, so little surface area :) |
@@ -18,9 +18,9 @@ class Blaspp(CMakePackage, CudaPackage):
maintainers = ['teonnik', 'Sely85', 'G-Ragghianti', 'mgates3']
version('master', branch='master')
+ version('2020.10.02', sha256='36e45bb5a8793ba5d7bc7c34fc263f91f92b0946634682937041221a6bf1a150')
version('2020.10.01', sha256='1a05dbc46caf79... | [Blaspp->[check->[join_path,make,isfile,Exception],cmake_args->[spec],variant,conflicts,depends_on,version]] | Creates a new object with the basic Linear Algebra Subroutines. Create a function that can be used to build a supported version of OpenBLAS. | Is there any reason to drop the old version? |
@@ -6,7 +6,7 @@ const content =
'Praesent condimentum ante ac ipsum aliquam, ac scelerisque velit sagittis. Ut sit amet libero scelerisque, accumsan ante vitae, hendrerit tellus. Nullam metus est, vehicula a aliquet id, lobortis in mauris.';
export default () => (
- <Accordion renderPanelContent>
+ <Accordion r... | [No CFG could be retrieved] | Renders an panel. | it's not a breaking change, but now it supports both, to have the same API as the Tab comonent |
@@ -688,6 +688,11 @@ class HeaderList(FileList):
@property
def headers(self):
+ """Stable de-duplication of the headers.
+
+ Returns:
+ list of strings: A list of header files
+ """
return self.files
@property
| [_find_non_recursive->[join_path],working_dir->[mkdirp],install->[set_install_permissions,copy_mode],traverse_tree->[traverse_tree],change_sed_delimiter->[filter_file],find_headers->[HeaderList,find],remove_dead_links->[join_path],touchp->[mkdirp,touch],install_tree->[set_install_permissions,copy_mode],fix_darwin_insta... | Returns the list of files and directories in the header list. | Not sure why it was referencing `cpp_flags` here. |
@@ -77,10 +77,10 @@ namespace System.Formats.Cbor.Tests
}
[Theory]
- [InlineData(CborConformanceLevel.Rfc7049Canonical, "9800")]
- [InlineData(CborConformanceLevel.Rfc7049Canonical, "990000")]
- [InlineData(CborConformanceLevel.Rfc7049Canonical, "9a00000000")]
- [InlineDa... | [CborReaderTests->[ReadArray_SimpleValues_HappyPath->[Equal,PositiveInfinity,PeekState,Finished,VerifyArray,HexToByteArray,NaN],EndReadArray_ImbalancedCall_ShouldThrowInvalidOperationException->[HexToByteArray,Assert,ReadEndArray],ReadArray_IncorrectDefiniteLength_ShouldThrowFormatException->[Value,ReadStartArray,Equal... | Reads array of non - canonical length using hex encoding. | I liked the previous name better |
@@ -309,6 +309,9 @@ int do_server(int *accept_sock, const char *host, const char *port,
ERR_print_errors(bio_err);
goto end;
}
+ } else {
+ (void)BIO_printf(bio_s_out, "ACCEPT\n");
+ (void)BIO_flush(bio_s_out);
}
if (accept_sock != NULL)
| [No CFG could be retrieved] | finds the network address and port of the network socket that the network socket is connected to Accept and process a single . | Side note: Since both branches of the condition do `BIO_flush`, an option would be to bring it down below... |
@@ -638,8 +638,12 @@ public final class InvokeHTTP extends AbstractProcessor {
}
// Set timeouts
- okHttpClientBuilder.connectTimeout((context.getProperty(PROP_CONNECT_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS).intValue()), TimeUnit.MILLISECONDS);
- okHttpClientBuilder.readTimeout(co... | [InvokeHTTP->[convertAttributesFromHeaders->[csv],setSslSocketFactory->[init],OverrideHostnameVerifier->[verify->[verify]]]] | Sets up the OkHttpClient builder. Add the necessary configuration to the OkHttpClientBuilder. | Can you explain why an interceptor is added here rather than passing the configured value to the builder? |
@@ -26,4 +26,15 @@ public interface LazyComponentInitializer {
*/
void initializeComponent(Location location);
+ /**
+ * Calling this method guarantees that the requested component from the configuration will be created.
+ * <p/>
+ * The requested component must exists in the configuration.
+ *
+ * ... | [No CFG could be retrieved] | Initialize the component. | weird. If the method is called createComponent, I expect it to return the component. Plus, why a List? how can this create many components? |
@@ -153,8 +153,8 @@ READ32_MEMBER(vme_hcpu30_card_device::bootvect_r)
WRITE32_MEMBER(vme_hcpu30_card_device::bootvect_w)
{
LOG("%s\n", FUNCNAME);
- m_sysram[offset % sizeof(m_sysram)] &= ~mem_mask;
- m_sysram[offset % sizeof(m_sysram)] |= (data & mem_mask);
+ m_sysram[offset >> 2] &= ~mem_mask;
+ m_sysram[offset >>... | [No CFG could be retrieved] | MCFG_DUSCC_OUT_RTSA_CB - callback for all M vme_hcpu30_card_device - vme_hcpu30_. | This should be `m_sysram[offset % ARRAY_LENGTH(m_sysram)] ...` |
@@ -49,7 +49,7 @@ import gobblin.util.TimeRangeChecker;
*
* @author Yinan Li
*/
-public class AzkabanJobLauncher extends AbstractJob {
+public class AzkabanJobLauncher extends AbstractJob implements ApplicationLauncher, JobLauncher {
private static final Logger LOG = Logger.getLogger(AzkabanJobLauncher.class... | [AzkabanJobLauncher->[cancel->[close,cancelJob],isCurrentTimeInRange->[splitToList,getProperty,size,checkArgument,isTimeInRange,forID,get,DateTime,contains,trimResults],run->[launchJob,isCurrentTimeInRange,close],create,Configuration,getenv,newJobLauncher,toString,addAll,containsKey,nullToEmpty,register,setProperty,Ema... | Creates a new instance of AzkabanJobLauncher. This method initializes the object with the configuration from the configuration file. | why does this class need to implement `JobLauncher`? When should one call `launchJob` directly instead of `run`? |
@@ -151,7 +151,7 @@
<% if @xapian_requests %>
<% if @xapian_requests.results.empty? %>
<% if @page == 1 %>
- <h2 class="foi_results" id="foi_requests">
+ <h2 class="foi_results foi_requests" id="foi_requests">
<%= @is_you ? _('Freedom of Information requests made by y... | [No CFG could be retrieved] | Return a list of all NI - related tags. This person s Freedom of Information requests. | ~~don't need it twice~~ EDIT: different words, sorry my bad! |
@@ -2806,8 +2806,8 @@ p {
public static function do_version_bump( $version, $old_version ) {
if ( ! $old_version ) { // For new sites
- // Setting up jetpack manage
- Jetpack::activate_manage();
+ // There used to be stuff here, but this function might be useful to someone
+ // in the future...
}
}
... | [Jetpack->[verify_json_api_authorization_request->[add_nonce],get_locale->[guess_locale_from_lang],admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],authenticate_jetpack->[verify_xml_rpc_signature],admin_page_load->[disconnect,unlink_user,can_display_jetpack_manage_notice],wp_rest_authenti... | This method is called when the version of the site is changed. | If we're removing the functionality, can we also remove the conditional? Should this be added to a deprecated list? |
@@ -74,13 +74,13 @@ class CollectionController extends RestController implements ClassResourceInterf
{
try {
$locale = $this->getLocale($request);
+ $depth = $request->get('depth');
+ $breadcrumb = ($request->get('breadcrumb') === 'true' ? true : false);
$co... | [CollectionController->[saveEntity->[toArray,handleView,getData,getId,getCollectionManager,save,view],getAction->[getCollectionManager,toArray,handleView,getLocale,getById,responseGetById,view],getCollectionManager->[get],getData->[getLocale,getParameter,get],putFieldsAction->[responsePersistSettings],getFieldsAction->... | Returns a single with the given id. | Isn't this what you have included the `RequestParametersTrait` for? |
@@ -93,8 +93,6 @@ class AccountAddress extends ApiWrapper
*/
public function getAddress()
{
- $adr = $this->entity->getAddress();
-
- return new AddressEntity($adr);
+ return $this->entity->getAddress();
}
}
| [AccountAddress->[setMain->[setMain],getId->[getId],setAddress->[setAddress],getAddress->[getAddress],getMain->[getMain]]] | Get the address of the node. | There exist no Api Entity of Address so I directly did return the entity here. |
@@ -67,17 +67,6 @@ public class UpdateRoleCmd extends RoleCmd {
return roleName;
}
- public RoleType getRoleType() {
- if (!Strings.isNullOrEmpty(roleType)) {
- return RoleType.fromString(roleType);
- }
- return null;
- }
-
- public String getRoleDescription() {
... | [UpdateRoleCmd->[execute->[getRoleId,getRoleName,getRoleDescription,getRoleType]]] | This method returns the name of the role. | Since roleType and roleDescription have been moved to RoleCmd class, can we not remove getRoleDescription() from this class? |
@@ -298,10 +298,13 @@ public class KsqlConfig extends AbstractConfig implements Cloneable {
)
);
- private static Optional<ResolvedConfig> resolveStreamsConfig(final String maybePrefixedKey,
- final Object value) {
+ private static Optional<Con... | [KsqlConfig->[resolveConfig->[ResolvedConfig],CompatibiltyBreakingConfigDef->[defineCurrent->[define],define->[define],defineOld->[define]],getAllConfigPropsWithSecretsObfuscated->[getKsqlConfigPropsWithSecretsObfuscated],overrideBreakingConfigsWithOriginalValues->[KsqlConfig],cloneWithPropertyOverwrite->[applyStreamsC... | Resolve streams config. | Basically this means that everything that is not a ksql config property is considered a streams property. If it is further identified as a streams or admin client property, it will have the appropriate type, else will be considered unresolved, correct? What purpose does the type serve? |
@@ -33,7 +33,15 @@ if TYPE_CHECKING:
from pants.engine.mapper import AddressFamily, AddressMapper
-class AddressSpec(ABC):
+class Spec(ABC):
+ """A specification for what Pants should operate on."""
+
+ @abstractmethod
+ def to_spec_string(self) -> str:
+ """Return the normalized string representation of t... | [AddressSpecs->[__init__->[AddressSpecsMatcher]],AddressSpec->[address_families_for_dir->[AddressFamilyResolutionError]],DescendantAddresses->[address_target_pairs_from_address_families->[AddressResolutionError,all_address_target_pairs]],AddressSpecsMatcher->[matches_target_address_pair->[_target_tag_matches,_excluded_... | Creates a new object from a base object and returns it. Implementation of matching_address_families for address specs matching at most one directory. | I wanted to originally punt on creating this until we had a need. We now have such a need :) |
@@ -829,7 +829,7 @@ public class OverlordResource
}
private Collection<? extends TaskRunnerWorkItem> securedTaskRunnerWorkItem(
- Collection<? extends TaskRunnerWorkItem> collectionToFilter,
+ Collection<? extends TaskRunnerWorkItem> collectionToFilter, String dataSource,
HttpServletRequest req... | [OverlordResource->[getCompleteTasks->[getDataSource,apply],asLeaderWith->[apply],getRunningTasksByDataSource->[getRunningTasks],killPendingSegments->[isLeader],isLeader->[isLeader],securedTaskRunnerWorkItem->[getDataSource],getRunningTasks->[apply->[getRunningTasks]],getPendingTasks->[apply->[getPendingTasks]]]] | Filters a task runner work item collection by action. | It's more Druid-y style to put the `String dataSource` on its own line. Also it should be marked `@Nullable`. |
@@ -1968,11 +1968,14 @@ public class UpdateCenter extends AbstractModelObject implements Saveable, OnMas
return;
case FAIL:
throwVerificationFailure(entry.getSha512(), job.getComputedSHA512(), file, "SHA-512");
+ break;
case NOT_COMPUTED:
... | [UpdateCenter->[getConnectionCheckJob->[getSite,getConnectionCheckJob],updateDefaultSite->[getSite],CompleteBatchJob->[run->[Running,Success,Failure],getCoreSource,setCorrelationId,Pending],getAvailables->[getAvailables],getCategorizedAvailables->[getAvailables],UpdateCenterJob->[submit->[submit]],isRestartScheduled->[... | Verify the checksums of a file using the computed checksums. | SpotBugs just does not do deep code analysis in this case, no real issues here |
@@ -391,7 +391,8 @@ class OrderCapture(BaseMutation):
try_payment_action(
order, info.context.user, payment, gateway.capture, payment, amount
)
-
+ if order.is_fully_paid():
+ handle_fully_paid_order(order)
order_captured(order, info.context.user, amount, paymen... | [clean_refund_payment->[clean_payment],OrderVoid->[perform_mutation->[OrderVoid,clean_void_payment,try_payment_action]],clean_order_capture->[clean_payment],OrderMarkAsPaid->[perform_mutation->[clean_billing_address,try_payment_action,OrderMarkAsPaid]],OrderAddNote->[Arguments->[OrderAddNoteInput],perform_mutation->[Or... | Perform a mutation on an order. | This logic should go after `order_captured` call I guess? We first capture funds, then we're able to say that the order was fully paid. It's done like that in `order_created`. |
@@ -411,6 +411,10 @@ Rails.application.routes.draw do
#### AdminPublicBody controller
scope '/admin', :as => 'admin' do
+ constraints admin_constraint do
+ mount Flipper::UI.app(AlaveteliFeatures.backend) => '/flipper'
+ end
+
resources :bodies,
:controller => 'admin_public_body' do
... | [new,redirect,filter,join,put,draw,resources,member,root,scope,constraints,post,load,include,resource,each,match,namespace,collection,get] | Provides a mapping of controllers to their respective methods. Controller for admin admin. | add a newline after this end to break up the different routes. |
@@ -50,13 +50,13 @@ class Ascent(Package, CudaPackage):
###########################################################################
variant("shared", default=True, description="Build Ascent as shared libs")
- variant('test', default=True, description='Enable Ascent unit tests')
+ variant("test", defau... | [Ascent->[install->[install],create_host_config->[cmake_cache_entry]]] | Package variants for a single - core capable lightweight in situ. Package dependencies for a given cuda cuda object. | for a follow-up: tests do not need to be a variant in Spack anymore. They are controlled via `spack install --test=root ascent`, which sets `self.run_tests` |
@@ -266,6 +266,8 @@ static void response_callback_enum(GtkDialog *dialog, gint response_id, pref_ele
g_free(text);
}
}
+
+
static void response_callback_dir(GtkDialog *dialog, gint response_id, pref_element *cur_elt)
{
if(response_id == GTK_RESPONSE_ACCEPT)
| [int->[luaA_to_type,lua_pushinteger,dt_conf_set_string,destroy_pref_element,luaA_push,dt_conf_get_bool,strdup,lua_pushcfunction,luaL_checkinteger,GTK_TOGGLE_BUTTON,dt_conf_get_float,dt_lua_gtk_wrap,lua_touserdata,lua_pop,luaL_checknumber,luaA_to,gtk_entry_new,lua_pushlightuserdata,lua_error,lua_pushstring,gtk_file_choo... | Enumerate the responses from the user. | No strong opinion here but I'll keep a single empty line. |
@@ -1435,8 +1435,8 @@ class Form
{
if (! empty($conf->multicompany->transverse_mode))
{
- $sql.= ", ".MAIN_DB_PREFIX."usergroup_user as ug";
- $sql.= " WHERE ug.fk_user = u.rowid";
+ $sql.= " LEFT JOIN ".MAIN_DB_PREFIX."usergroup_user as ug";
+ $sql.= " ON... | [Form->[form_users->[select_dolusers],textwithpicto->[textwithtooltip],select_dolusers_forevent->[select_dolusers],formSelectAccount->[textwithpicto,select_comptes],formInputReason->[selectInputReason,loadCacheInputReason],form_availability->[load_cache_availability,selectAvailabilityDelay],select_types_paiements->[loa... | Select users with dolusers finds users that are not admin and not in group Displays a list of all user - defined chains. Returns a string representation of a node - id Generate a select tag for a single node. | Why ? and missing WHERE with this ! |
@@ -430,12 +430,12 @@ class TaskRunner(Runner):
- ENDRUN: if the trigger raises an error
"""
- all_states = set() # type: Set[State]
- for upstream_state in upstream_states.values():
+ # Deep copy upstream states and expand mapped states
+ all_states = copy.deepcopy(... | [TaskRunner->[run_mapped_task->[run_fn->[run]],run->[initialize_run],get_task_run_state->[run]]] | Checks if the task s trigger function passes. | Is there a better way to do this? I was thinking that we make copies of the edges to put in the dictionary but now I can forsee how these edges will be hard to reason with (e.g. multiple copies of the "same" edge used as keys) Maybe the values should be lists of States |
@@ -46,10 +46,13 @@ class Boost(Package):
branch='develop',
submodules=True)
+ version('1.67.0', '694ae3f4f899d1a80eb7a3b31b33be73c423c1ae',
+ url='https://dl.bintray.com/boostorg/release/1.67.0/source/boost_1_67_0.tar.bz2',
+ preferred=True)
version('1.67.0.b1'... | [Boost->[determine_bootstrap_options->[determine_toolset,bjam_python_line],install->[determine_bootstrap_options,add_buildopt_symlinks,determine_b2_options],determine_b2_options->[determine_toolset]]] | Boost provides free peer - reviewed portable portable C ++ source and emphasizing This function returns a sequence number for the versions of the 1. 64. 0. | Now that `1.67.0` has been officially released, can we remove this beta version? Then we can remove `preferred=True` as well. |
@@ -681,3 +681,14 @@ def test_split_auth_from_netloc(netloc, expected):
def test_remove_auth_from_url(auth_url, expected_url):
url = remove_auth_from_url(auth_url)
assert url == expected_url
+
+
+@pytest.mark.parametrize('auth_url,expected_url', [
+ ('https://user@example.com/abc', 'https://user@example.c... | [TestUnpackArchives->[confirm_files->[mode],test_unpack_tgz->[confirm_files],test_unpack_zip->[confirm_files]],test_rmtree_retries_for_3sec->[Failer],TestTempDirectory->[test_deletes_readonly_files->[readonly_file,create_file]],test_rmtree_retries->[Failer]] | Test remove_auth_from_url. | "result" -> "actual" (or "url") to match previous tests. |
@@ -120,3 +120,7 @@ class LongitudinalMpc():
self.v_mpc = v_ego
self.a_mpc = CS.aEgo
self.prev_lead_status = False
+
+ def publish(self, pm):
+ if LOG_MPC:
+ self.send_mpc_solution(pm, self.n_its, self.duration)
| [LongitudinalMpc->[setup_mpc->[init,new,get_libmpc],send_mpc_solution->[list,new_message,send,max],__init__->[setup_mpc],update->[sec_since_boot,int,send_mpc_solution,any,max,init,isnan,min,warning,zip,run_mpc,init_with_simulation,abs]],get] | Update the state of the n - its system. Initialize the v_mpc a_mpc_future and a_mpc. | i'd just rename send_mpc_solution to publish and move the condition |
@@ -21,7 +21,7 @@
</button>
</div>
</header>
- <div class="usa-banner__content usa-accordion__content hide" id="gov-banner">
+ <div class="usa-banner__content usa-accordion__content" id="gov-banner">
<div class="grid-row grid-gap-lg">
<div class="usa-banner__guid... | [No CFG could be retrieved] | Displays a hidden banner with no pii banner. Displays a hidden hidden block of the n - node id. | Since we're removing the `.hide` class, do we need to add in `hidden=true`? Or is that handled by the new JS |
@@ -200,7 +200,8 @@ public class WebSocketClientProtocolHandler extends WebSocketProtocolHandler {
if (cp.get(WebSocketClientProtocolHandshakeHandler.class) == null) {
// Add the WebSocketClientProtocolHandshakeHandler before this one.
ctx.pipeline().addBefore(ctx.name(), WebSocketCli... | [WebSocketClientProtocolHandler->[decode->[decode]]] | Add the next NIO handler in the pipeline. | Can we just pass this in via an additional constructor parameter? No need to introduce a mutable state. |
@@ -99,10 +99,11 @@ public class TooLongLineCheck extends IssuableSubscriptionVisitor {
}
private static String removeIgnoredPatterns(String line) {
+ if (!line.matches("\\s*(?:\\*|//).*")) return line;
return line
// @see <a href="http://docs.oracle.com/javase/7/docs/technotes/tools/windows/java... | [TooLongLineCheck->[getLine->[is,line],ignoreLines->[size,get,getLine,isEmpty,add,imports],removeIgnoredPatterns->[replaceAll],nodesToVisit->[emptyList],setContext->[ignoreLines,clear,setContext,getTree,visitFile],visitFile->[size,get,addIssue,removeIgnoredPatterns,format,contains,length,getFileLines]]] | Removes ignored patterns from the given line. | At line 93 we are calling `removeIgnoredPatterns(origLine)` for all lines, without checking if `origLine.length() > maximumLineLength`, I do not expect that a lot of lines exceed maximumLineLength, we should test this before calling `removeIgnoredPatterns(origLine)`. |
@@ -157,7 +157,11 @@ final class ReadStage implements ReadStageInterface
if (\is_string($name) && strpos($name, $this->nestingSeparator)) {
// Gives a chance to relations/nested fields.
- $filters[str_replace($this->nestingSeparator, '.', $name)] = $value;
+ ... | [ReadStage->[getNormalizedFilters->[getNormalizedFilters],getSubresource->[getSubresource]]] | Normalizes the filter arguments into a single array. | Why starting at index? |
@@ -290,7 +290,7 @@ public class HoodieWriteStat implements Serializable {
return totalRollbackBlocks;
}
- public void setTotalRollbackBlocks(Long totalRollbackBlocks) {
+ public void setTotalRollbackBlocks(long totalRollbackBlocks) {
this.totalRollbackBlocks = totalRollbackBlocks;
}
| [HoodieWriteStat->[hashCode->[hashCode],equals->[equals]]] | This method is used to get the total rollback blocks. | same here, we can address this as part of some other refactoring diff |
@@ -287,7 +287,7 @@ frappe.socketio.SocketIOUploader = class SocketIOUploader {
{'name': 'System Settings'},
'use_socketio_to_upload_file',
function(d) {
- if (d.use_socketio_to_upload_file==1){
+ if (d.use_socketio_to_upload_file==0){
if (fallback) {
fallback();
return;
| [No CFG could be retrieved] | This function handles the upload of a file in the socket. This function creates a FileReader object and uploads the file to the socket. | this will always call fallback! why did you change it to false? |
@@ -2242,6 +2242,8 @@ class Command(object):
ret_code = ERROR_INVALID_CONFIGURATION
self._out.error(exc)
except ConanException as exc:
+ import traceback
+ print(traceback.format_exc())
ret_code = ERROR_GENERAL
self._out.error(exc)
... | [Command->[export->[export],info->[info],install->[install],editable->[info],source->[source],remove->[remove,info],new->[new],_print_similar->[_commands],imports->[imports],upload->[upload],copy->[copy],download->[download],run->[_warn_python_version,_print_similar,_commands,_show_help],export_pkg->[export_pkg],test->... | Entry point for executing commands dispatcher to class methods. | Double check, is this intended? |
@@ -476,7 +476,13 @@ func DeserializePropertyValue(v interface{}, dec config.Decrypter) (resource.Pro
if err != nil {
return resource.PropertyValue{}, err
}
- return resource.MakeSecret(ev), nil
+ prop := resource.MakeSecret(ev)
+ // If the decrypter is a cachingCrypter, insert the plain-... | [OperationType,IsObject,NewNullProperty,NewArrayProperty,ArrayValue,NewArchiveProperty,Mappable,Assertf,DeserializeAsset,ValueOf,Encrypter,PropertyKey,OfType,Wrap,NewNumberProperty,IsNotEmpty,NewAssetProperty,Serialize,Marshal,ParseTolerant,New,DeserializeArchive,Errorf,UpToDeploymentV2,Assert,StableKeys,DecryptValue,T... | The main function for the object - map - property - map - check. | Similar to above, can/should we move this responsibility inside the caching crypter somehow? |
@@ -142,6 +142,7 @@ namespace PythonNodeModelsWpf
private void UpdateToPython2Engine(object sender, EventArgs e)
{
pythonNodeModel.Engine = PythonEngineVersion.IronPython2;
+ pythonNodeModel.OnNodeModified();
}
/// <summary>
| [PythonNodeViewCustomization->[CustomizeView->[CustomizeView]]] | Update to Python2 engine if it is not found. | Isn't this equivalent to calling `OnNodeModified` in the setter of the `Engine` property? |
@@ -17,7 +17,15 @@ describe AssignmentsController do
'files/assignments/form_good.csv', 'text/csv')
allow(@file_good).to receive(:read).and_return(
File.read(fixture_file_upload(
- 'files/assignments/form_good.csv', 'text/csv')))
+ 'files/assignments/form_g... | [create,let,to_not,describe,fixture_file_upload,join,first,it,map,to,before,post,find_by_short_identifier,let!,with,second,to_s,strftime,read,extract_text,redirect_to,send,context,build,get,eq,head,and_return] | This controller creates a controller that handles the creation of a new object. accepts a valid file. | Layout/AlignParameters: Align the parameters of a method call if they span more than one line.<br>Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. |
@@ -491,12 +491,13 @@ class DoctestTest(unittest.TestCase):
# Inspection after modification.
's'
],
+ 'pandas.core.series.Series.resample': ['df'],
})
self.assertEqual(result.failed, 0)
def test_string_tests(self):
- PD_VERSION = tuple(int(... | [DoctestTest->[test_series_tests->[testmod,assertEqual],test_indexing_tests->[testmod,assertEqual],test_ndframe_tests->[dir,startswith,testmod,assertEqual],test_dataframe_tests->[testmod,assertEqual],test_string_tests->[int,split,assertEqual,tuple,testmod],test_top_level->[getattr,_is_top_level_function,assertEqual,sta... | Test series tests. pandas. core. series. Series. unique is a function that can be used to filter Tests that the series in the system have a unique index. Test for missing missing - partition objects. 1. | Related to `PD_VERSION`: - Should we define this in one common place? - And use a consistent way to get it, either tuple(int(... or tuple(map(... for consistency? - And is it worth keeping the patch version or not? (probably not.) |
@@ -454,8 +454,14 @@ public class VMwareGuru extends HypervisorGuruBase implements HypervisorGuru, Co
*/
private ServiceOfferingVO createServiceOfferingForVMImporting(Integer cpus, Integer memory, Integer maxCpuUsage) {
String name = "Imported-" + cpus + "-" + memory;
- ServiceOfferingVO vo =... | [VMwareGuru->[getGuestNetworkFromNetworkMorName->[createNetworkRecord],syncVMNics->[getNicMacAddressAndNetworkName],getCommandHostDelegation->[getHypervisorType],getDatacenterMO->[getVmwareDatacenter],getNetworksMapping->[getGuestNetworkFromNetworkMorName],getVM->[getTemplateId],getDestStoreMor->[checkBackingInfo],getV... | Create a ServiceOffering for VM importing. | double white spaces |
@@ -2106,7 +2106,7 @@ static void row_activated_with_event(GtkTreeView *view, GtkTreePath *path, GtkTr
* hierarchy. */
else if(event->state & GDK_SHIFT_MASK)
{
- gchar *n_text = g_strconcat(text, "%", NULL);
+ gchar *n_text = g_strconcat(text, "*", NULL);
g_free(... | [No CFG could be retrieved] | gtk_tree_model_iter_get_iter_from_tree_path This function gets the tag id by name and sets the text and position of the rule. | Ok, let's try to improve that. We have: - click (no wildchar) - ctrl-click `|%` at end - shift-click `%` at end You changed the shift-click to use `*` but the tooltip is now wrong. I propose to keep `%` at end (which is uniform with all others collection kind) and check if we end with `%` and not with `|%` in the code ... |
@@ -198,8 +198,7 @@ def test_query_events(raiden_chain, token_addresses, deposit, settle_timeout, re
events=ALL_EVENTS,
)
- channel_id = channel_identifier(app0.raiden.address, app1.raiden.address)
- assert must_have_event(
+ _event = must_have_event(
events,
{
'e... | [test_channel_new->[sleep,state_from_app,RaidenAPI,total_token_network_channels],event_dicts_are_equal->[v2,v,startswith,isinstance,items],test_secret_revealed->[sleep,sha3,payment_channel,get_token_network_identifier_by_token_address,get_channelstate,len,register_secret,channel_close,pending_mediated_transfer,wait_unt... | Test query events. raiden. channel_open raiden. channel_deposit raiden. channel_ This function returns all netting channel events. | how is this fixing it? It just removed the assertion. |
@@ -17,7 +17,7 @@ import funcsigs
import yaml
from collections import OrderedDict
from ..prune import *
-from .compress_pass import *
+from ..quantization import *
from .strategy import *
__all__ = ['ConfigFactory']
| [ConfigFactory->[_parse_config->[instance,_new_instance,_parse_config]]] | Creates a class which creates a new instance of a n - tuple. Get the object of the class with the given keys. | I don't see where is the quantization? |
@@ -184,7 +184,11 @@ public class MongoDbIO {
}
}
- private static class BoundedMongoDbSource extends BoundedSource<Document> {
+ /**
+ * A MongoDB {@link BoundedSource} reading {@link Document} from a given instance.
+ */
+ @VisibleForTesting
+ protected static class BoundedMongoDbSource extends Bou... | [MongoDbIO->[BoundedMongoDbReader->[start->[collection,database,filter,uri],close->[close]],Read->[withFilter->[build],withDatabase->[build],withUri->[build],validate->[collection,database,uri],withCollection->[build],withNumSplits->[build],populateDisplayData->[database,collection,populateDisplayData,uri,numSplits,fil... | Produces a read that has a unique identifier in the database. get the size of the . | package private instead of protected |
@@ -62,7 +62,16 @@ class CoercingEncoder(json.JSONEncoder):
else:
return self.encode(key_obj)
+ def _is_natively_encodable(self, o):
+ return isinstance(o, (type(None), bool, int, list, text_type, binary_type))
+
def default(self, o):
+ if self._is_natively_encodable(o):
+ # isinstance() ch... | [CoercingEncoder->[default->[_maybe_encode_dict_key,default],encode->[default]],Sharder->[is_in_shard->[compute_shard],compute_shard->[hash_all],__init__->[ensure_int->[InvalidShardSpec],InvalidShardSpec,ensure_int]],json_hash->[hash_all],stable_json_sha1->[json_hash]] | Recursively encode keys in a dictionary. Returns a if o is an OrderedSet otherwise returns the default value of o. | Could you also please convert the other `elif`s into `if`s? (or the alternative, but I personally prefer only using `if` before an explicit `return`) |
@@ -126,7 +126,7 @@ public class DefaultSchedulerTerminationTestCase extends BaseDefaultSchedulerTes
// Due to how threads are scheduled, the termination state of the executor may become available after the getter of the future
// returns.
- new PollingProber(100, 10).check(new JUnitLambdaProbe(() -> {
+... | [DefaultSchedulerTerminationTestCase->[isTerminated->[matchesSafely->[isTerminated]]]] | Tests that the executor is not running a task and that it s running a task waits for. | Constants for the timeout and poll frequency? |
@@ -22,6 +22,10 @@ namespace System.Reflection.Metadata
}
namespace System.Runtime.Loader
{
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("android")]
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("browser")]
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")]
+ ... | [MetadataUpdateHandlerAttribute->[All,Assembly],AssemblyLoadContext->[ContextualReflectionScope->[Never]]] | Resolve the given UnmanagedDllName to the path to the given assembly. | It's missing [UnsupportedOSPlatform("maccatalyst")] |
@@ -17,6 +17,7 @@ from __future__ import print_function
import logging
import os
import multiprocessing
+import re
import sys
import warnings
import numpy as np
| [Executor->[_run_impl->[global_scope,run,_run_parallel],_run_program->[_add_var_cache,_add_feed_fetch_ops,_add_program_cache,_get_program_cache,as_numpy,run,_add_ctx_cache,_get_strong_program_cache_key,_add_scope_cache,_get_scope_cache,_get_ctx_cache,_get_var_cache,_feed_data],_add_feed_fetch_ops->[has_feed_operators,h... | Creates a function that returns a variable object that can be used to create a new variable object Creates a scope guard for the variable. | It seems that this line is not useful. |
@@ -1617,6 +1617,13 @@ public class Macro {
return result;
}
+ static final String _bndversionHelp = "${bndversion}, returns the currently running bnd version";
+
+ public String _bndversion(String[] args) throws Exception {
+ verifyCommand(args, _bndversionHelp, null, 1, 1);
+ return About.CURRENT.toStringWit... | [Macro->[_tolower->[verifyCommand],_system->[system_internal],_length->[verifyCommand],_js->[toString,verifyCommand],_map->[verifyCommand],_min->[verifyCommand],_error->[process],_average->[toString,verifyCommand],_is->[verifyCommand],_range->[version],_rand->[verifyCommand],_sublist->[verifyCommand],_findlast->[verify... | Returns the basename of the file with the extension. | You should probably add a `verifyCommand` call here to validate the input. |
@@ -417,6 +417,9 @@ class H2OFrame(object):
if self._ex is None:
print("This H2OFrame has been removed.")
return
+ if not self._has_content():
+ print("This H2OFrame is not initialized.")
+ return
if self.nrows == 0:
print("This H2OFr... | [_getValidCols->[type],_binop->[_expr,moment],H2OFrame->[var->[_expr],sinpi->[_unop],relevel->[_expr],substring->[_expr],hist->[pop,show,hist,_expr],topNBottomN->[_expr],set_level->[_expr],tokenize->[_expr],moment->[type,_expr],cummax->[_expr],sum->[pop,_expr],gsub->[_expr],log2->[_unop],toupper->[_expr],atan->[_unop],... | Displays a snippet of the data frame. | What is the semantic different between `This H2OFrame is not initialized` and `This H2OFrame is empty.` Does the first one mean that the Frame exists but wasn't loaded from the backend? Just trying to understand all aspects. Thanks! |
@@ -277,9 +277,9 @@ class ResultsController < ApplicationController
if current_user.student?
# The Student does not have access to this file. Display an error.
if @file.submission.grouping.membership_status(current_user).nil?
- render :partial => 'shared/handle_error',
- :locals ... | [ResultsController->[update_remark_request_count->[update_remark_request_count]]] | Displays a single node in the tree that is related to a given assignment. | Align the parameters of a method call if they span more than one line.<br>Space inside } missing. |
@@ -1,6 +1,7 @@
from .caltech import Caltech101, Caltech256
from .celeba import CelebA
from .cifar import Cifar10, Cifar100
+from .coco import Coco
from .mnist import MNIST, FashionMNIST, KMNIST, EMNIST, QMNIST
from .sbd import SBD
from .voc import VOC
| [No CFG could be retrieved] | Imports all the elements of a sequence. | I really like this alphabetical order of imports, should we follow this everywhere(within the same group of imports)? |
@@ -854,6 +854,10 @@ _%>
<%_ } _%>
<%= entityInstance %>Repository.<%= saveMethod %>(<%= persistInstance %>)<%= callBlock %>;
+<%_ if (databaseTypeCouchbase) { _%>
+ TimeUnit.SECONDS.sleep(3);
+<%_ } _%>
+
// Get all the <%= entityInstance %>List
<%_ if (!reactive) { _%>
rest<%= en... | [No CFG could be retrieved] | Gets all the objects in the database. find the last unique identifier in the database. | Why do you need this for ? since queries have `REQUEST_PLUS` consistency, it should work without it. |
@@ -837,7 +837,11 @@ public class IncrementalIndex implements Iterable<Row>, Closeable
public int getId(String value)
{
- return falseIds.get(value);
+ if (value == null) {
+ value = "";
+ }
+ final Integer id = falseIds.get(value);
+ return id == null ? -1 : id;
}
... | [IncrementalIndex->[makeDimensionSelector->[lookupName->[get],getRow->[size->[size],get->[get],iterator->[apply->[],iterator]]],getMaxTime->[getMaxTimeMillis,isEmpty],close->[close],isEmpty->[get],getDimensionIndex->[get],DimDimImpl->[size->[size],getId->[get],getValue->[get],add->[size],sort->[size,sort]],makeObjectCo... | get the id of the value in the order of preference. | null values should be treated like empty string. |
@@ -480,6 +480,7 @@ public class Notebook implements NoteEventListener {
if (p.getDateFinished() != null && lastUpdatedDate.before(p.getDateFinished())) {
lastUpdatedDate = p.getDateFinished();
}
+ p.clearRuntimeInfo();
}
Map<String, List<AngularObject>> savedObjects = note.getAn... | [Notebook->[setNoteRevision->[setNoteRevision],renameFolder->[renameFolder],loadAllNotes->[loadNoteFromRepo],close->[close],getJobListByUnixTime->[getUnixTimeLastRunParagraph,reloadAllNotes,getParagraphForJobManagerItem,getAllNotes],onParagraphCreate->[onParagraphCreate],hasFolder->[hasFolder],removeNote->[removeNote],... | Load a note from the notebook repository. add the angularObject to the interpreter group. | Why we need to clear RuntimeInfo when we load note if the runtimeInfo is not stored ? |
@@ -35,10 +35,13 @@ export default class JitsiStreamBlurEffect {
* Represents a modified video MediaStream track.
*
* @class
- * @param {BodyPix} bpModel - BodyPix model.
+ * @param {Object} bpModel - Meet model.
+ * @param {Object} dimensionOptions - Segmentation dimensions.
*/
- ... | [No CFG could be retrieved] | JitsiStreamBlurEffect class. Draws the segmentation mask after the run post processing. | Let's call it `options`, since we might add more things than dimension, such as the blur factor, later on. |
@@ -163,6 +163,10 @@ class UsersController < ApplicationController
end
def onboarding_checkbox_update
+ # TODO: mstruve will remove once debugging is done
+ Rails.logger.error("onboarding_checkbox_update_params:#{params}")
+ Rails.logger.error("onboarding_checkbox_update_user_params:#{params[:user]}")
... | [UsersController->[add_org_admin->[update],remove_org_admin->[update],remove_identity->[update]]] | onboarding checkbox update - checks if user has onboarding checkbox and if not. | Anything else I should add or look at? I'm pretty perplexed right now so this seemed like a good start |
@@ -57,6 +57,12 @@ def gc(test_result=True):
pass
file_upload.delete()
+ stale_scanner_results = ScannerResult.objects.filter(
+ upload=None, version=None
+ ).order_by('id')
+ for scanner_result in stale_scanner_results:
+ scanner_result.delete()
+
def category_tota... | [category_totals->[debug,len,join,cursor,execute],gc->[days_ago->[today,timedelta],debug,chunked,filter,format,delay,delete],weekly_downloads->[list,chain,len,join,cursor,fetchall,switch_is_active,raise_if_reindex_in_progress,execute],getLogger] | Garbage collection. Missing version - node - count - 1 - 1 - 1 - 1 - 1 - 1. | unless there's custom logic in the model's `delete` method, you can just do `ScannerResult.objects.filter(upload=None, version=None).delete()` |
@@ -135,7 +135,11 @@ namespace System.Diagnostics
/// <internalonly/>
private bool Associated
{
- get { return _haveProcessId || _haveProcessHandle; }
+ get
+ {
+ CheckDisposed();
+ return _haveProcessId || _haveProcessHandle;
+ ... | [Process->[WaitForInputIdle->[WaitForInputIdle],GetProcessesByName->[GetProcessesByName],EnsureState->[ThrowIfExited,EnsureState],WaitForExit->[RaiseOnExited,WaitForExit],Start->[Start,Close],StopWatchingForExit->[Dispose],RaiseOnExited->[OnExited],ToString->[ToString],Close->[Close,Dispose],GetProcesses->[GetProcesses... | Creates a new instance of the given process. - Gets the value that was specified by the associated process when it was terminated. | This property didn't throw before. It's also private, why would we need to guard calls to it? |
@@ -440,8 +440,9 @@ export class Extensions {
scriptElement.setAttribute('custom-element', extensionId);
scriptElement.setAttribute('data-script', extensionId);
const pathStr = this.win.location.pathname;
+ const base = this.win.location.protocol + '//' + this.win.location.host;
const useCompiled... | [No CFG could be retrieved] | Determines if the missing extension script is required. Generates a link to the AMP project s version 0. 1. max. js file. | We'll need port number, too. How about passing in `window.location`, and let calculateExtensionScriptUrl figure out what it needs. |
@@ -50,10 +50,9 @@ class AddToCartForm(forms.Form):
else:
cart_line = self.cart.get_line(product_variant)
used_quantity = cart_line.quantity if cart_line else 0
- new_quantity = quantity + used_quantity
try:
self.cart.check_quantity(
- ... | [ReplaceCartLineFormSet->[save->[save]],AddToCartForm->[QuantityField]] | Add to cart form validation. | This is `AddToCartForm`. It's used on product pages. It does not replace the existing quantity nor is it meant to. |
@@ -346,6 +346,13 @@ namespace Dynamo.Manipulation
CommandExecutive.ExecuteCommand(command, UniqueId, ExtensionName);
var inputNode = WorkspaceModel.Nodes.FirstOrDefault(node => node.GUID == command.ModelGuid) as DoubleSlider;
+
+ if (inputNode != null)
+ {
+ ... | [NodeManipulator->[GetElementsFromMirrorData->[GetElementsFromMirrorData],HighlightGizmoOnRollOver->[GetGizmos],MouseMove->[CanMoveGizmo],DeleteGizmos->[Dispose,GetGizmos],MouseDown->[UpdatePosition,GetGizmos],Dispose->[DetachHandlers,Dispose],MouseUp->[GetGizmos],GenerateRenderPackages->[AssignInputNodes,UpdatePositio... | Create and connect input node. | When we create an input slider node, we need to ensure that its current value is the same as the default value of the respective input port of the existing node so that the gizmo stays at its current position and does not jump to any arbitrary default position that's determined by the new slider. |
@@ -0,0 +1,14 @@
+using DynamoWebServer.Responses;
+
+namespace DynamoWebServer
+{
+ public interface IServer
+ {
+ event MessageEventHandler ReceivedMessage;
+ event MessageEventHandler Info;
+ event MessageEventHandler Error;
+
+ void Start();
+ void SendResponse(Response res... | [No CFG could be retrieved] | No Summary Found. | Events are typically named as "MessageReceived" instead of "ReceivedMessage". |
@@ -6979,6 +6979,17 @@ class FaucetStringOfDPTest(FaucetTest):
'%s: ICMP echo request' % other_host.IP(), tcpdump_text
), 'Tunnel was not established')
+ def verify_one_broadcast(self, from_host, to_hosts):
+ self.assertGreater(len(to_hosts), 1, 'Testing only one ext host is not useful... | [FaucetUntaggedIPv6ControlPlaneFuzzTest->[test_fuzz_controller->[note]],InfluxPostHandler->[do_POST->[_log_post]],Faucet8021XFailureTest->[test_untagged->[require_lag_status->[],learn_then_down_hosts->[],port_up->[],post_test_checks,try_8021x]],Faucet8021XMABTest->[test_untagged->[require_lag_status->[],learn_then_down... | Verify ICMP packets tunnelled from src to dst. Add a host to the hosts list. | What exception are you expecting here? |
@@ -399,6 +399,9 @@ namespace Dynamo.Graph.Workspaces
var connectors = obj["Connectors"].ToObject<IEnumerable<ConnectorModel>>(serializer);
var info = new WorkspaceInfo(guid.ToString(), name, description, Dynamo.Models.RunType.Automatic);
+ //https://jira.autodesk.com/browse/QNTM-... | [NodeReadConverter->[RemapPorts->[AddToReferenceMap,setPortDataOnNewPort,Index,OutPorts,InPorts,GUID],setPortDataOnNewPort->[UseLevels,KeepListStructure,Level,UsingDefaultValue,GUID],buildMapOfLoadedAssemblies->[ContainsKey,Name,Add,GetAssemblies],ReadJson->[CreateCustomNodeInstance,Context,Count,ToObject,ToList,OutPor... | This method is overridden in order to read a JSON object. This function is used to build a workspace from a JSON object. Returns the HomeWorkspaceModel if it exists or creates a new one if it does not. | why is this necessary? - shouldn't the node workspaceInfo contain this? |
@@ -190,7 +190,7 @@ export class Resource {
/**
* Update owner element
- * @param {!AmpElement} owner
+ * @param {AmpElement|undefined} owner
*/
updateOwner(owner) {
this.owner_ = owner;
| [No CFG could be retrieved] | Provides access to the properties of a resource object. Replies the object that holds the owner of the resource. | How would this be `undefined`? |
@@ -0,0 +1,5 @@
+class SessionEncryptorErrorHandler
+ def self.call(error, _sid)
+ raise error
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | This could also be an anonymous class or a class defined in the initializer. |
@@ -71,8 +71,6 @@ public class AMQPMessagePersisterV2 extends AMQPMessagePersister {
buffer.writeInt(properties.getEncodeSize());
properties.encode(buffer.byteBuf());
}
-
- buffer.writeLong(record.getExpiration());
}
@Override
| [AMQPMessagePersisterV2->[encode->[getEncodeSize,encode],decode->[decode],getEncodeSize->[getEncodeSize],getInstance->[AMQPMessagePersisterV2]]] | Encode a message. | why did you need a new persister? you could just check if you have more bytes on the ByteBuffer. |
@@ -113,6 +113,10 @@ func NewBridgeType(info ...string) models.BridgeType {
return bt
}
+func NewIndexableBlockNumber() *models.IndexableBlockNumber {
+ return &models.IndexableBlockNumber{}
+}
+
func WebURL(unparsed string) models.WebURL {
parsed, err := url.Parse(unparsed)
mustNotErr(err)
| [EthTx,Add,Panicf,Error,Save,NewTime,NewJob,AddAttempt,StringToHash,NewString,Big,StringFrom,Unix,BytesToHash,ToLower,Read,Get,ParseJSON,BytesToAddress,Cron,Sprintf,Unmarshal,NewInt,String,Parse] | CreateTxAndAttempt creates a transaction and attempts to add a new . JSONFromFixture returns a new object of type Time with the value of the time. | So we already have a `cltest.IndexableBlockNumber(uint64)` in `cltest/cltest.go` We should chat about what goes where in our cltest files: - cltest/cltest.go - cltest/fixtures.go - cltest/mocks.go |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.