patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -2808,6 +2808,18 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve
return isQuietingDown;
}
+ /**
+ * Returns quiet down reason if it was indicated.
+ * @return
+ * Reason if it was indicated. null otherwise
+ * @since TODO
+ */
+ ... | [Jenkins->[getUser->[get],_cleanUpShutdownTcpSlaveAgent->[add],setNumExecutors->[updateComputerList],getPlugin->[getPlugin],getCategorizedManagementLinks->[all,add],getViewActions->[getActions],getJDK->[getJDKs,get],setViews->[addView],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getStoredVersion->[get],g... | Returns true if the node isQuietingDown false if it is terminating. | Wouldn't it be cleaner to use the new `quietDownReason` as the only indicator for quiet down state? E.g.: - `null`: Not quieting down - `""`: Quieting down, no reason - any other value: Quieting down, this reason (Or a proper value object with a basic, sane API) Having two independent variables seems to invite inconsis... |
@@ -429,6 +429,12 @@ public final class ActiveMQDefaultConfiguration {
// Default period to wait between configuration file checks
public static final long DEFAULT_CONFIGURATION_FILE_REFRESH_PERIOD = 5000;
+ public static final long DEFAULT_GLOBAL_MAX_SIZE = -1;
+
+ public static final int DEFAULT_MAX_DIS... | [ActiveMQDefaultConfiguration->[SimpleString]] | Returns true if the default resolve protocols are enabled. | Can this setting have some more context like DEFAULT_GLOBAL_MAX_MEMORY_USAGE |
@@ -133,4 +133,13 @@ class AlaveteliPro::InfoRequestsController < AlaveteliPro::BaseController
def info_request_params
params.require(:info_request).permit(:described_state)
end
+
+ def check_public_body_is_requestable
+ if @info_request.public_body
+ unless @info_request.public_body.is_requestable?... | [all_models_valid?->[present?,nil?,valid?],info_request_params->[permit],create->[all_models_valid?,redirect_to,send_initial_message,show_alaveteli_pro_request_path,url_title,present?,save],show_errors->[render,delete],set_public_body->[find_by_url_name],set_draft->[find],destroy_draft->[destroy],send_initial_message->... | Returns the params that are required for the info request. | Line is too long. [91/80] |
@@ -19,6 +19,13 @@ import sys, os
#sys.path.insert(0, os.path.abspath('.'))
sys.path.insert(0, os.path.abspath('./_extensions'))
+# this var should refer to where intersphinx should pull inv files from. For
+# example, this would be set to '2.6-release' for the 2.6 branches, which would
+# pull objects.inv from htt... | [insert,abspath] | This function is used to populate the basic configuration of a single non - empty object. 2. 5. 0 - > 2. 5. 0 - > 2. 5. | This is going to be a problem when we stop lock-stepping the versions for the different builders. I suggest removing the rtd_builder variable and its note. I also suggest the same in all the plugins conf.py. |
@@ -48,7 +48,7 @@ const (
kubeSystemPodsReadinessChecks = 6
sleepBetweenRetriesWhenWaitingForPodReady = 1 * time.Second
timeoutWhenWaitingForPodOutboundAccess = 1 * time.Minute
- stabilityCommandTimeout = 5 * time.Second
+ stabilityCommandTimeout = 1 * time.Secon... | [ValidateOmsAgentLogs,ParseInput,ExecuteRemote,CreatePVCFromFileDeleteIfExist,HasPrefix,GetAllByPrefix,Should,GetAll,WaitForIngress,New,CreateServiceFromFileDeleteIfExist,IsWindows,RunLinuxDeployDeleteIfExists,Bool,RequiresDocker,ValidateResources,CreateIfNotExist,PrintCommand,ReadString,ScaleDeployment,RationalizeRele... | Missing object in the system missing - master - regex = ^k8s - master -. | These are the commands that are re-using this const: - `nc -vz 8.8.8.8 53 || nc -vz 8.8.4.4 53` - `nc -vz kubernetes 443 && nc -vz kubernetes.default.svc 443 && nc -vz kubernetes.default.svc.cluster.local 443` - `nc -vz apache-pod.default.svc.cluster.local 80` - `nc -vz bbc.co.uk 80 || nc -vz google.com 443 || nc -vz m... |
@@ -163,7 +163,8 @@ public class CliMiddleManager extends ServerRunnable
}
},
new IndexingServiceFirehoseModule(),
- new IndexingServiceTaskLogsModule()
+ new IndexingServiceTaskLogsModule(),
+ new LookupModule()
);
}
}
| [CliMiddleManager->[getModules->[getWorkerNodeService->[WorkerNodeService,getIp,getCapacity,getVersion],getWorker->[getServiceScheme,getIp,getCapacity,Worker,getVersion,getHostAndPortToUse],configure->[addResource,configureTaskRunnerConfigs,createChoice,to,optionBinder,of,build,bind,get,register,toProvider,in,bindAnnou... | Provides a list of modules that are used by the DMR module. Register the worker. | #7222 introduces `LookupSerdeModule` which I think might be nicer behavior for middle manager and overlord than using `LookupModule` and configuring it not to load, but it will require this PR to wait until the other is merged. |
@@ -1,12 +1,12 @@
<?php
/**
- * @file include/forum.php
- * @brief Functions related to forum functionality *
+ * @file include/ForumManager.php
+ * @brief ForumManager class with it's methods related to forum functionality *
*/
/**
- * @brief This class handles functions related to the forum functionality
+ *... | [No CFG could be retrieved] | Get list of forums related to a user. Widget to show subcribed friendica forums. | I think it is "with its" and not "with it is" here. |
@@ -1997,7 +1997,7 @@ namespace Js
// Also, if the object's type has not changed, we need to ensure that
// the cached property string for this property, if any, does not
// specify this object's type.
- scriptContext->InvalidatePropertyStringCache(propI... | [No CFG could be retrieved] | This is a helper method that checks if an object has a non - standard type and if. | I still haven't found how to construct a test case where there's actually work to do here. Either the writable data detection bit is not set, the type was replaced with a new type, or the property string was not cached. To test that the cache was being invalidated, I temporarily removed the writable-data-only check. |
@@ -60,6 +60,13 @@ public class ListVPCOfferingsCmd extends BaseListCmd {
@Parameter(name = ApiConstants.STATE, type = CommandType.STRING, description = "list VPC offerings by state")
private String state;
+ @Parameter(name = ApiConstants.ZONE_ID,
+ type = CommandType.UUID,
+ entity... | [ListVPCOfferingsCmd->[execute->[getSupportedServices,getId,getDisplayText,getVpcOffName,getState]]] | Returns the id of the node. | again, only for a single zone, not domains? |
@@ -439,6 +439,8 @@ namespace MPMParticleGeneratorUtility
p_condition->SetValuesOnIntegrationPoints(MPC_IMPOSED_VELOCITY, { mpc_imposed_velocity }, process_info);
p_condition->SetValuesOnIntegrationPoints(MPC_ACCELERATION, { mpc_acceleration }, process_i... | [DetermineConditionIntegrationMethodAndShapeFunctionValues->[MP16ShapeFunctions,MP33ShapeFunctions],DetermineIntegrationMethodAndShapeFunctionValues->[MP16ShapeFunctions,MP33ShapeFunctions]] | GenerateMaterialPointCondition - Generate Material Point Condition This function creates all the necessary conditions for the background grid model part and creates all the necessary Checks if the current particle condition is missing or not defined. | Where do you specifically use this? |
@@ -650,6 +650,9 @@ def setup_package(pkg, dirty):
dpkg.setup_dependent_package(pkg.module, spec)
dpkg.setup_dependent_environment(spack_env, run_env, spec)
+ parent_modules = parent_class_modules(pkg.__class__)
+ for mod in parent_modules:
+ set_module_variables_for_package(pkg, mod)
... | [fork->[child_process->[setup_package]],set_module_variables_for_package->[MakeExecutable],get_rpaths->[get_rpath_deps],_make_child_error->[ChildError],parent_class_modules->[parent_class_modules],setup_package->[load_external_modules,set_module_variables_for_package,set_build_environment_variables,parent_class_modules... | Execute all environment setup routines. Load a missing - object object from modules and external modules. | 653-656 and 643-646 should be factored out into a function or integrated into `set_module_variables_for_package`. |
@@ -132,6 +132,12 @@ class Item extends BaseObject
$parent = ['origin' => false];
}
+ // "Deleting" global items just means hiding them
+ if (($item['uid'] == 0) && ($uid != 0)) {
+ dba::update('user-item', ['hidden' => true], ['iid' => $item_id, 'uid' => $uid], true);
+ return true;
+ }
+
// clean u... | [Item->[isRemoteSelf->[get_hostname],insert->[get_hostname],performLike->[get_hostname],guid->[get_hostname],addLanguageInPostopts->[detect],fixPrivatePhotos->[getType,asString,isValid,scaleDown]]] | Delete an item by ID. This function deletes a photo resource and deletes all the associated threads Delete an item from the server. | Nope, no, no no no, not at all. Method is called `Item::deleteById` and it should delete an item by id. You need to make a separate method to hide global items. |
@@ -107,6 +107,8 @@ def with_repository(fake=False, invert_fake=False, create=False, lock=True, excl
with repository:
if manifest or cache:
kwargs['manifest'], kwargs['key'] = Manifest.load(repository)
+ if args.__dict__.get('compression'):
+ ... | [main->[get_args,run,Archiver],with_repository->[decorator->[wrapper->[argument]]],Archiver->[do_prune->[print_error,write],do_mount->[print_error],do_check->[print_error],do_extract->[build_filter,print_warning,build_matcher],_list_archive->[_list_inner->[write],_list_inner,build_matcher],do_debug_get_obj->[write],run... | Decorator to specify a repository and key to lock. | that looks strange, esp. considering that you do an attribute access in the next line. |
@@ -249,11 +249,11 @@ class CI_Log {
* @param string $level The error level
* @param string $date Formatted date string
* @param string $message The log message
- * @return string Formatted log line with a new line character '\n' at the end
+ * @return string Formatted log line with a new line character '... | [CI_Log->[write_log->[_format_line,format]]] | Format a single line of log message. | No spaces around the concatenation operator please, same applies for the other file as well. |
@@ -303,6 +303,12 @@ func DefaultSpecs(serviceNames []string) []Spec {
SrcPath: "/hab/svc/ingest-service/data",
},
},
+ SyncDbsV2: []DatabaseDumpOperationV2{
+ {
+ Name: "chef_ingest_service",
+ User: "ingest",
+ },
+ },
SyncEsIndices: []ElasticsearchOperation{
{
ServiceN... | [NewExecExecutor,SliceContains] | Magic number of resources that can be read from the HAB. Options for operation that don t have any specific n - ary index. | i had a dream about this being annoying because we would have to specify the tables. i'm glad that was just a nightmare |
@@ -308,8 +308,15 @@ func (r *Runtime) setupContainer(ctx context.Context, ctr *Container) (_ *Contai
logrus.Debugf("Creating new volume %s for container", vol.Name)
+ // Get the uid/gid of the container user to create the volume
+ // with the correct uid/gid. See github.com/containers/libpod/issues/5698.
+ u... | [GetRunningContainers->[GetContainers],PruneContainers->[GetContainers,RemoveContainer],LookupContainer->[LookupContainer],evictContainer->[removeContainer,RemoveContainer],removeContainer->[RemoveContainer],HasContainer->[HasContainer],newContainer->[initContainerVariables],GetContainersByList->[LookupContainer],GetLa... | setupContainer initializes the container addContainer adds a container to the container s config Initialize the container root filesystem This function is called from the init function. It will go through named volumes and create them Add a container to the state. | This is not safe - `ctr.state.Mountpoint` is unset at this point, because the container has not been mounted. |
@@ -108,11 +108,13 @@ def mk_alloc(typemap, calltypes, lhs, size_var, dtype, scope, loc):
typ_var_assign = ir.Assign(np_typ_getattr, typ_var, loc)
alloc_call = ir.Expr.call(attr_var, [size_var, typ_var], (), loc)
if calltypes:
- calltypes[alloc_call] = typemap[attr_var.name].get_call_type(
- ... | [find_build_sequence->[require,get_definition],mk_loop_header->[mk_unique_var],mk_alloc->[mk_unique_var],find_global_value->[find_global_value,get_definition],rename_labels->[find_topo_order],resolve_func_from_module->[resolve_mod->[get_definition,resolve_mod],resolve_mod],gen_np_call->[get_np_ufunc_typ,mk_unique_var],... | generate an array allocation with np. empty and return list of nodes. Get a list of nodes where the node is missing. | This monkeypatch can be avoided by using `Signature.replace`. |
@@ -25,7 +25,6 @@ public class DiceServerEditor extends EditorPanel {
private final JTextField m_gameId = new JTextField();
private final JLabel m_toLabel = new JLabel("To:");
private final JLabel m_ccLabel = new JLabel("Cc:");
- private final JLabel m_gameIdLabel = new JLabel("Game ID:");
private final IR... | [DiceServerEditor->[getBean->[getDiceServer],setupListeners->[actionPerformed->[getDiceServer,test,PBEMDiceRoller],ActionListener,addActionListener,EditorChangedFiringDocumentListener,addDocumentListener],getDiceServer->[sendsEmail,setToAddress,setCcAddress,setGameId,getText,supportsGameId],isBeanValid->[validateTextFi... | Creates a DiceServerEditor class. Add Insets to the To and CC labels and the ccAddress fields. | Is it better to keep this label with the others? |
@@ -204,7 +204,7 @@ class Experiment:
finally:
self.stop()
- def connect_experiment(self, port: int):
+ def connect(self, port: int):
"""
Connect to an existing experiment.
| [Experiment->[get_trial_job->[_experiment_rest_get],get_job_statistics->[_experiment_rest_get],update_max_trial_number->[_update_experiment_profile],run->[start,stop],update_max_experiment_duration->[_update_experiment_profile],update_search_space->[_update_experiment_profile],start->[start],export_data->[_experiment_r... | Run the experiment. | suggest to decorate it with `@classmethod` or `@staticmethod` |
@@ -76,6 +76,7 @@ class Hwloc(AutotoolsPackage):
args.append('--enable-netloc')
args.extend(self.enable_or_disable('cairo'))
+ args.extend(self.enable_or_disable('nvml'))
args.extend(self.enable_or_disable('cuda'))
args.extend(self.enable_or_disable('libxml2'))
... | [Hwloc->[url_for_version->[up_to],configure_args->[append,enable_or_disable,extend],variant,depends_on,version]] | Configure the command line arguments for the . | available with `hwloc` 1.7+ from what I found, so should be save to add like this :) |
@@ -31,7 +31,10 @@ RequestPasswordReset = RedactedStruct.new(
end
def instructions
- I18n.t('user_mailer.email_confirmation_instructions.first_sentence.forgot_password')
+ I18n.t(
+ 'user_mailer.email_confirmation_instructions.first_sentence.forgot_password',
+ app_name: APP_NAME,
+ )
end
... | [perform->[user,user_should_receive_registration_email?,new,submit],send_reset_password_instructions->[new,deliver,track_event,deliver_now,throttled_else_increment?,set_reset_password_token],instructions->[t],user->[user],user_should_receive_registration_email?->[nil?,confirmed?],email_address_record->[find_with_email]... | Returns the label for the missing instructions. | Couple more of these in `spec/services/request_password_reset_spec.rb` which need `app_name` passed in. |
@@ -17,6 +17,14 @@
*/
package org.apache.beam.sdk.io;
+// beam-playground:
+// name: FileBasedSourceTest
+// description: Unit-test for the FileBasedSource example.
+// multifile: false
+// pipeline_options:
+// categories:
+// - IO
+
import static org.apache.beam.sdk.testing.SourceTestUtils.assertS... | [FileBasedSourceTest->[testFullyReadFilePatternFirstRecordEmpty->[TestFileBasedSource,createFileWithData,createStringDataset],testEstimatedSizeOfFilePattern->[TestFileBasedSource,createFileWithData,createStringDataset],testSplittingFailsOnEmptyFileExpansion->[TestFileBasedSource],testReadRangeFromFileWithSplitsFromStar... | Imports a single object. Imports all the elements of the array that are not in the list. | Let's remove this file, it tests Beam internals |
@@ -175,4 +175,11 @@ public class SchemaRegistryTopicSchemaSupplier implements TopicSchemaSupplier {
+ "Schema:" + schema,
cause));
}
+
+ private static String getSubject(final String topicName, final boolean isKey) {
+ final String suffix = isKey
+ ? KsqlConstants.SCHEMA_REGISTRY_KE... | [SchemaRegistryTopicSchemaSupplier->[notFound->[failure,KsqlException,lineSeparator],notCompatible->[failure,KsqlException,getMessage,lineSeparator],getValueSchema->[notFound,isPresent,get,getStatus,getSchemaBySubjectAndId,KsqlException,fromParsedSchema,getId],incorrectFormat->[failure,KsqlException,lineSeparator],from... | Checks if the schema for the given sequence number is not compatible with the given schema. | nit: I used this pattern quite a bit, maybe we should move it to a util and refactor this? (and then we can also make `SCHEMA_REGISTRY_*_SUFFIX` private and just use this method) can be done in follow-up PR |
@@ -214,7 +214,7 @@ class ICA(ContainsMixin):
self.max_pca_components = max_pca_components
self.n_pca_components = n_pca_components
self.ch_names = None
- self.random_state = random_state if random_state is not None else 42
+ self.random_state = random_state
if fit_pa... | [_find_sources->[get_score_funcs],run_ica->[fit,ICA,_detect_artifacts],get_score_funcs->[_make_xy_sfunc],ICA->[_pick_sources->[_get_fast_dot],_fit->[fit],_sources_as_evoked->[_transform_evoked],_apply_epochs->[_pre_whiten],_transform_raw->[_pre_whiten,_transform],_fit_epochs->[_reset],_transform_epochs->[_pre_whiten,_t... | Initialize ICA object. Set all the attributes of the object to reflect the max_iter . | unfortunately this one is not backward compatible :( Unless this is considered a bug... |
@@ -33,7 +33,7 @@ public abstract class ConnectionFactory {
* Starts the connection factory. A pooled factory might be create connections here.
*/
public abstract void start(ConnectionFactoryConfiguration factoryConfiguration, ClassLoader classLoader) throws
- CacheLoaderException;
+ ... | [ConnectionFactory->[getConnectionFactory->[getInstance]]] | This abstract method is called by the cache manager to start the cache. | can you put everything in the same line? |
@@ -1232,14 +1232,11 @@ class DFRN
$final_dfrn_id = '';
if ($perm) {
- if ((($perm == 'rw') && (! intval($contact['writable'])))
- || (($perm == 'r') && (intval($contact['writable'])))
+ if ((($perm == 'rw') && !intval($contact['writable']))
+ || (($perm == 'r') && intval($contact['writable']))
) ... | [DFRN->[mail->[appendChild,saveXML,createElement],itemFeed->[setAttribute,createElementNS,saveXML,appendChild],relocate->[appendChild,saveXML,createElement],fsuggest->[appendChild,saveXML,createElement],fetchauthor->[item,query,evaluate],processRelocation->[item],import->[registerNamespace,query,loadXML],transmit->[get... | Deliver a contact via Diaspora transport This function is called to parse the XML returned by dfrn_deliver and return the data This function is used to determine if a contact is a private contact or not. | This condition is superfluous. |
@@ -24,11 +24,10 @@ namespace System
throw new IndexOutOfRangeException();
}
- fixed (char* pDest = &dest._firstChar)
- fixed (char* pSrc = &src._firstChar)
- {
- wstrcpy(pDest + destPos, pSrc, src.Length);
- }
+ Buffe... | [String->[PadRight->[PadRight],SplitInternal->[Format,SplitInternal],ToUpper->[ToUpper],ToLowerInvariant->[ToLower],PadLeft->[PadLeft],Join->[Join],Replace->[Replace],ToUpperInvariant->[ToUpper],CreateTrimmedString->[InternalSubString],JoinCore->[FillStringChecked,JoinCore],Split->[SplitInternal],Concat->[Concat,FillSt... | Fill string checked. | The order of the arguments isn't the same for each of these calls. Is there a specific reason they are in a different order? Perhaps to demonstrate some priority of the arguments in different cases? |
@@ -323,12 +323,12 @@ public class AffinityGroupServiceImpl extends ManagerBase implements AffinityGro
List<String> types = new ArrayList<String>();
for (AffinityGroupProcessor processor : _affinityProcessors) {
- if (processor.isAdminControlledGroup()) {
- continue... | [AffinityGroupServiceImpl->[deleteAffinityGroup->[deleteAffinityGroup],isAdminControlledGroup->[getAffinityTypeToProcessorMap,isAdminControlledGroup],createAffinityGroup->[createAffinityGroup]]] | List all affinity group types. | Are these formatting changes needed? Are you using the CloudStack code formatter style? Or was the code not formatted properly? |
@@ -62,7 +62,7 @@ public class AttachmentsPropagationTestCase extends FunctionalTestCase implement
// return the list of attachment names
FunctionalTestComponent fc = (FunctionalTestComponent) component;
- fc.setReturnData(message.getOutboundAttachmentNames().toString());
+ fc.setRetur... | [AttachmentsPropagationTestCase->[doSetUp->[doSetUp]]] | This method is called when a single event is received. It will add a single attachment to. | this belongs in a separate PR |
@@ -218,6 +218,8 @@ public abstract class AbstractHoodieWriteClient<T extends HoodieRecordPayload, I
HoodieActiveTimeline activeTimeline = table.getActiveTimeline();
// Finalize write
finalizeWrite(table, instantTime, stats);
+ // update Metadata table
+ writeTableMetadata(table, instantTime, commi... | [AbstractHoodieWriteClient->[startCommitWithTime->[startCommitWithTime,startCommit],inlineCluster->[scheduleClustering,cluster],startCommit->[startCommit],restoreToSavepoint->[createTable],commitStats->[commit,commitStats],close->[close],scheduleTableServiceInternal->[scheduleClustering,scheduleCompaction,scheduleClean... | Commit the given table with the given commit action instant time and metadata. | so this was missing before? |
@@ -16,7 +16,7 @@ function getDate () {
function getInfoForCurrentVersion () {
var json = {}
- json.version = process.versions['atom-shell']
+ json.version = process.versions['electron']
json.date = getDate()
var names = ['node', 'v8', 'uv', 'zlib', 'openssl', 'modules', 'chrome']
| [No CFG could be retrieved] | Get info for a single object in the atom system. function to get index. js in server. | Now the key doesn't have a dash I guess this can just be `process.versions.electron` |
@@ -1763,7 +1763,10 @@ class ComplexVariable(object):
return self.real.numpy() + 1j * self.imag.numpy()
def __str__(self):
- return "REAL: " + self.real.__str__() + "IMAG: " + self.imag.__str__()
+ return "ComplexTensor[real]: %s\n%s" % (
+ self.real.name, str(self.real.value().... | [cuda_places->[is_compiled_with_cuda,_cuda_ids],ComplexVariable->[numpy->[numpy],__str__->[__str__]],_varbase_creator->[convert_np_dtype_to_dtype_],Program->[_construct_from_desc->[Program,_sync_with_cpp,Block],to_string->[type,_debug_string_,to_string],_copy_data_info_from->[type,var,num_blocks],clone->[Program,_copy_... | Returns a string representation of the object. | Better formatting single str instead of using '+' for several strings. |
@@ -45,12 +45,11 @@ DEFAULT_TRANSPORT_MATRIX_SYNC_LATENCY = 15_000
DEFAULT_MATRIX_KNOWN_SERVERS = {
Environment.PRODUCTION: (
"https://raw.githubusercontent.com/raiden-network/raiden-service-bundle"
- "/96b7df9ed93a1d73f9f4ede8db4773c0045e1c3b/known_servers"
- "/known_servers-production-v3.... | [MatrixTransportConfig->[CapabilitiesConfig],BlockchainConfig->[BlockBatchSizeConfig],RaidenConfig->[ServiceConfig,PythonApiConfig,BlockchainConfig,MediationFeeConfig,MatrixTransportConfig,CapabilitiesConfig,RestApiConfig]] | Raiden token amount 9. 4. 1. | Hm maybe this was why the whitelist reloading didn't work . |
@@ -38,7 +38,13 @@ def update_version(storage: SQLiteStorage, version: int):
)
-def get_db_version(db_filename: Path):
+def get_db_version(db_filename: Path) -> Optional[int]:
+ """Return the version value stored in the db or None."""
+
+ # Do not create an empty database
+ if not db_filename.exists()... | [_run_upgrade_func->[update_version],UpgradeManager->[run->[get_db_version,_run_upgrade_func,_copy,get_file_lock,update_version,_backup_old_db]]] | Get the version of the database. | IMO this was also a bug, because an empty db was unnecessarily created. |
@@ -101,8 +101,7 @@ void RemoteClient::GetNextBlocks (
return;
// Won't send anything if already sending
- if(m_blocks_sending.size() >= g_settings->getU16
- ("max_simultaneous_block_sends_per_client"))
+ if(m_blocks_sending.size() >= m_max_simul_sends)
{
//infostream<<"Not sending any blocks, Queue full.... | [event->[notifyEvent,UpdatePlayerList],isUserLimitReached->[getClientIDs],UpdatePlayerList->[getClientIDs]] | This method is called by the remote client to get the next blocks. v3f - V3 camera camera DEBUG - level functions - > void This function is used to find the nearest sent block in the network. This is a bit of a hack to make sure that the block is not already in the This function is called from the main loop of the netw... | Space missing after `if` and misplaced bracket. Belongs to this line end. |
@@ -412,4 +412,8 @@ public class AnsibleController {
return json(res, error(LOCAL.getMessage("ansible.entity_not_found")));
}
}
+
+ private static AnsibleManager getAnsibleManager() {
+ return new AnsibleManager(GlobalInstanceHolder.SALT_API);
+ }
}
| [AnsibleController->[schedulePlaybook->[schedulePlaybook]]] | Discover playbooks. | Should this alsible manager be a static field and be re-used? |
@@ -2,9 +2,9 @@ package org.ray.api;
import java.io.Serializable;
import java.nio.ByteBuffer;
-import java.nio.IntBuffer;
import java.util.Arrays;
import java.util.Random;
+import javax.xml.bind.DatatypeConverter;
/**
* Unique ID for task, worker, function...
| [UniqueID->[equals->[equals],copy->[UniqueID],randomId->[UniqueID],genNil->[UniqueID]]] | Produces a unique ID for a task worker function. Replies a copy of this UniqueID. | can be final |
@@ -232,7 +232,11 @@ func getScaledTiKVGroups(informer core.StoreSetInformer, healthyInstances []inst
func getScaledTiDBGroups(informer tidbInformer, healthyInstances []instance) []*Plan {
planMap := make(map[string]map[string]struct{}, len(healthyInstances))
for _, instance := range healthyInstances {
- tidb := ... | [GetLabelValue,getLabelValue,GetID,Warn,Seconds,GetStore,Uint64,GetAddress,MinUint64,String,Ceil,GetTiDB,GetStores,HasPrefix,GetState] | getScaledGroupsByComponent returns a list of groups that are scaled by the given component buildPlans builds a list of plans for the given component type. | What should we do to handle this kind of error? |
@@ -66,7 +66,7 @@ import org.springframework.util.ClassUtils;
*/
public class IntegrationGraphServer implements ApplicationContextAware, ApplicationListener<ContextRefreshedEvent> {
- private static final float GRAPH_VERSION = 1.2f;
+ private static final float GRAPH_VERSION = 1.3f;
private static MicrometerNo... | [IntegrationGraphServer->[gateways->[getBeansOfType],getBeansOfType->[getBeansOfType],NodeFactory->[polledHandlerNode->[channelToBeanName],discardingHandler->[channelToBeanName],recipientListRoutingHandler->[channelToBeanName],sourceNode->[channelToBeanName],handlerNode->[channelToBeanName],routingHandler->[channelToBe... | Creates a server object model that represents a single application context. This method is used to initialize a new instance of the class. | I wonder what have been changed in the `Graph` hierarchy to make a decision to bump the version... |
@@ -13,7 +13,7 @@ namespace System.Net
{
private static Func<Cookie, string> s_toServerStringFunc;
- [PreserveDependency("ToServerString", "System.Net.Cookie", "System.Net.Primitives")]
+ [DynamicDependency("ToServerString", "System.Net.Cookie", "System.Net.Primitives")]
public st... | [CookieExtensions->[IsRfc2965Variant->[s_getVariantFunc,CreateDelegate,Rfc2965,Assert],Cookie->[s_cloneFunc,CreateDelegate,Assert],ToServerString->[CreateDelegate,Assert,s_toServerStringFunc]],CookieCollectionExtensions->[InternalAdd->[CreateDelegate,Assert,s_internalAddFunc]]] | ToServerString - gets the server - side cookie value as a string. | Can this use typeof(Cookie)? Same below. |
@@ -9,15 +9,10 @@
* @uses $vars['class'] Additional CSS class
*/
-if (isset($vars['class'])) {
- $vars['class'] = "elgg-button {$vars['class']}";
-} else {
- $vars['class'] = "elgg-button";
-}
+$vars['class'] = (array) elgg_extract('class', $vars, []);
+$vars['class'][] = "elgg-button";
-$defaults = array(
- 't... | [No CFG could be retrieved] | Create an input button with optional class. | Would anyone pass a custom type? Perhaps just $vars['type'] and force it to button |
@@ -308,7 +308,7 @@ public class ResourceLoader implements Closeable {
return Optional.empty();
}
try {
- return Optional.of(ImageIO.read(url));
+ return Optional.ofNullable(ImageIO.read(url));
} catch (final IOException e) {
log.log(Level.SEVERE, "Image loading failed: " + imageN... | [ResourceLoader->[getMapResourceLoader->[ResourceLoader],getResourceAsStream->[getResource],loadImage->[getResource],close->[close],getCandidatePaths->[getMapDirectoryCandidates,getMapZipFileCandidates]]] | Load image from resource. | Hmm I'd suggest logging some kind of error message if `ImageIO.read` returns `null`. Otherwise map makers might not realize that an invalid image was attempted to get loaded |
@@ -31,6 +31,13 @@ import (
"github.com/elastic/go-concert/unison"
)
+// sourceStore is a store which can access resources using the Source
+// from an input.
+type sourceStore struct {
+ identifier sourceIder
+ store *store
+}
+
// store encapsulates the persistent store and the in memory state store, that
... | [Find->[Retain],Retain->[Retain],Release->[Release]] | Creates a type of object that represents a single non - negative . Checks if a resource is active for a given key and if so records the key event. | I didn't really check the code if it is possible or not. But I wonder if it would make sense to push down the `identifier` into `store` itself? This would also remove the need for `sourceStore`. e.g. would it make sense to change `store.Get` to `func (s *store) Get(s Source) (*resource)` ? |
@@ -354,7 +354,7 @@ public class InnerMetricContext extends MetricRegistry implements ReportableCont
@SuppressWarnings("unchecked")
protected synchronized <T extends ContextAwareMetric> T getOrCreate(String name,
- ContextAwareMetricFactory<T> factory) {
+ ContextAwareMetricFactory<T> factory, Object ... | [InnerMetricContext->[getTagMap->[getTagMap],removeChildrenMetrics->[remove],getTags->[getTags],remove->[remove],close->[close],removeMatching->[remove],getOrCreate->[register],toString->[getName,toString,getTagMap],register->[getName,register]]] | Gets or creates a new metric with the given name. | Similar idea, we could define a new method, same name but different types of arguments, for sliding window support. |
@@ -0,0 +1,9 @@
+#!/usr/bin/env python3
+
+# Copyright (c) Facebook, Inc. and its affiliates.
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+
+
+def build(opt):
+ pass
| [No CFG could be retrieved] | No Summary Found. | I don't think you need this file at all. |
@@ -719,11 +719,11 @@ class ConanAPIV1(object):
raise
for remote, remote_ref in references.items():
- recorder.add_recipe(str(remote), str(reference))
+ recorder.add_recipe(str(remote), reference)
if remote_ref.ordered_packages:
for package_id,... | [get_basic_requester->[get_request_timeout],_get_conanfile_path->[_make_abs_path],ConanAPIV1->[export_alias->[export_alias],export->[_get_conanfile_path],info->[_info_get_profile,_init_manager],install->[_get_conanfile_path,install,_make_abs_path,_init_manager],source->[_get_conanfile_path,_make_abs_path,_init_manager,... | Search for packages in the remote repository. | This conversion to str(remote) is a bit weird. If the recorder receives objects that want to convert to string, that make sense. But the logic should be in the recorder, in the same way it should be receiving a ``ConanFileReference`` object in ``reference`` |
@@ -384,4 +384,12 @@ class ApplicationController < ActionController::Base
client = DeviceDetector.new(request.user_agent)
client.device_type != 'desktop'
end
+
+ def override_ahoy_user
+ user_id = session[:doc_capture_user_id]
+ return unless user_id
+ user = User.find_by(id: user_id)
+ return... | [ApplicationController->[confirm_two_factor_authenticated->[user_fully_authenticated?],two_factor_enabled?->[two_factor_enabled?],after_mfa_setup_path->[after_sign_in_path_for]]] | Check if the user is a mobile device. | Do we still need this? Or anything else, other than the changes in d3b6d163f1367a57a21dfcae1b7f92bf7d4a2ca2 ? |
@@ -269,7 +269,7 @@ final class DirectoryLoaderAdaptor {
final long length = directory.fileLength(chunkCacheKey.getFileName());
final int bufferSize = chunkCacheKey.getBufferSize();
final int chunkId = chunkCacheKey.getChunkId();
- return Boolean.valueOf((chunkId * bufferSize) < (l... | [DirectoryLoaderAdaptor->[LoadVisitor->[visit->[loadIntern]],figureChunksNumber->[figureChunksNumber],ContainsKeyVisitor->[visit->[containsKeyIntern]],close->[close],loadIntern->[close],loadAllKeys->[loadSomeKeys]]] | Checks if the given chunk key is in the cache. | Since auto-boxing can be a performance pain when it happens unintentionally, we made the choice to set IDEs to flag these as a warning, hence it's preferrable to keep it as an explicit operation when we need to use the "uppercase versions" of primitives. |
@@ -269,7 +269,7 @@ public class Project extends Processor {
return;
}
- synchronized (preparedPaths) {
+ synchronized (this) {
if (preparedPaths.get()) {
// ensure output folders exist
getSrcOutput0();
| [Project->[export->[getWorkspace,toString,write,export],prepare->[isValid,toString],getOutputFile->[getTarget,getOutputFile],getName->[getName],getUnparented->[Project],getSpecification->[getRunProperties,getProjectLauncher,getRunbundles,getRunpath,add,getRunFw,toString],getValidJar->[toString,build,getValidJar],verify... | This method is called by the constructor to prepare the project. This function checks if the given directory is inside the base directory and creates the necessary directories if This routine adds the projects that are required to run the missing dependencies. | I thought we did not agree to do this and closed the issue? |
@@ -227,7 +227,7 @@ class ChannelPruningEnv:
def reset(self):
# restore env by loading the checkpoint
- self.pruner.reset(self.checkpoint)
+ self.pruner.reset_bound_model(self.checkpoint)
self.cur_ind = 0
self.strategy = [] # pruning strategy
self.d_prime_list =... | [ChannelPruningEnv->[_extract_layer_information->[new_forward],reset->[reset],_cur_reduced->[_cur_flops],_cur_flops->[_get_buffer_flops]]] | reset all the variables to 0. | Suggest testing this PR on IT. |
@@ -34,7 +34,11 @@
</thead>
<tbody v-if ="users">
<tr v-for="user in users" :key="user.id" :id="user.login">
- <td><router-link tag="a" :to="{name: '<%= jhiPrefixCapitalized %>UserView', params: {userId: user.login}}">{{user.id}}</router-link></td>
+ <td>
+ ... | [No CFG could be retrieved] | Displays a table with a table of all user - managed records. Displays a hidden list of user IDs that can be used to find a user in the system. | As far as I understand, an `a` tag is the default, so no need to `custom`ize it here. |
@@ -112,5 +112,5 @@ def get_connection_manager(**kwargs):
# type: (...) -> 'ConnectionManager'
connection_mode = kwargs.get("connection_mode", _ConnectionMode.SeparateConnection)
if connection_mode == _ConnectionMode.ShareConnection:
- return _SharedConnectionManager(**kwargs)
+ pass
r... | [get_connection_manager->[_SeparateConnectionManager,_SharedConnectionManager]] | Returns a connection manager for the given connection mode. | nit: I think we could remove those all since we always return `_SeparateConnectionManager` |
@@ -16,11 +16,11 @@
#define VISIBLE_SCREEN_WIDTH (32*8) /* Visible screen width */
// devices
-DEFINE_DEVICE_TYPE(PPU_VT03, ppu_vt03_device, "ppu_vt03", "VT03 PPU")
+DEFINE_DEVICE_TYPE(PPU_VT03, ppu_vt03_device, "ppu_vt03", "VT03 PPU (NTSC)")
+DEFINE_DEVICE_TYPE(PPU_VT03PAL, ppu_vt03pal_device, "ppu_vt03pal... | [No CFG could be retrieved] | region Private functions Color palette. | Add "m_vblank_first_scanline = VBLANK_FIRST_SCANLINE_PALC;". |
@@ -495,7 +495,7 @@ describes.realWin(
.be.ok;
service.pages_[2].visibilityState_ = VisibilityState.VISIBLE;
- service.scrollDirection_ = Direction.UP;
+ service.visibilityObserver_.scrollDirection_ = ScrollDirection.UP;
await service.hidePreviousPages_(
0 /** i... | [No CFG could be retrieved] | This function parses pages and removes them from the DOM and updates the visibility state of the page Checks that the next page placeholder is reloaded and removes the placeholder. | Ah, brings me back to the dock discussion about a `Direction` enum. Somehow, somewhere, these should be defined the same. Not important but maybe add a `TODO` to consolidate. |
@@ -153,6 +153,7 @@ func (loader KibanaLoader) statusMsg(msg string, a ...interface{}) {
if loader.msgOutputter != nil {
loader.msgOutputter(msg, a...)
} else {
- logp.Debug("dashboards", msg, a...)
+ logger := logp.NewLogger("dashboards")
+ logger.Debugf("%s %v", msg, a)
}
}
| [ImportIndexFile->[ImportIndex,Errorf,Unmarshal,ReadFile],Close->[Close],statusMsg->[msgOutputter,Debug],ImportIndex->[Wrapf,ImportJSON,Err,Wrap,Set],ImportDashboard->[ImportJSON,ReadFile,Unmarshal,Errorf,Set,Add],GetVersion,statusMsg,Enabled,String,Errorf,After,Done,NewKibanaClient] | statusMsg logs a message to the user if the messageOutputter is not nil. | maybe we want to create the logger in NewKibanaLoader? |
@@ -1812,10 +1812,12 @@ class Spec(object):
for patch in patch_list:
patches.append(patch.sha256)
if patches:
- # Special-case: keeps variant values unique but ordered.
- s.variants['patches'] = MultiValuedVariant('patches', ())
- ... | [colorize_spec->[insert_color],DependencySpec->[copy->[DependencySpec]],ConflictsInSpecError->[__init__->[format,tree]],SpecParser->[check_identifier->[format],spec->[satisfies,_dup,DependencyMap,_add_version,_set_compiler,FlagMap,_add_flag,spec_by_hash,dag_hash],version_list->[version],compiler->[version_list,_add_ver... | Concretizes a package spec to be concrete if it describes one build of a package A method to determine if a node in the spec has a duplicate of any of the dependencies Error - check for mismatched spec - package mutual references. | Is there a reason this no longer needs `dedupe`? |
@@ -0,0 +1,6 @@
+/**
+ * MultimapCache API.
+ *
+ * @public
+ */
+package org.infinispan.multimap.api;
| [No CFG could be retrieved] | No Summary Found. | Do we need the `api` package? Why `o.i.multimap` is not sufficient? Also since this is in commons, it should rather be `org.infinispan.commons.multimap[.api]`. I've seen some problems if multiple modules contain the same package. |
@@ -86,7 +86,7 @@ func maintainer(b *Builder, args []string, attributes map[string]bool, original
if len(args) != 1 {
return errExactlyOneArgument("MAINTAINER")
}
-
+ b.Author = args[0]
return nil
}
| [ReplaceAllString,SplitN,Join,Sprintf,StrSlice,Contains,Port,ToUpper,FromSlash,Errorf,MustCompile,Proto,ParseSignal,TrimSpace,IsAbs] | Adds flags and variables to the builder. add adds a new tag to the builder. | If no one uses this, what's the point? |
@@ -545,6 +545,12 @@ public class SlaveComputer extends Computer {
String slaveVersion = channel.call(new SlaveVersion());
log.println("Remoting version: " + slaveVersion);
+ VersionNumber agentVersion = new VersionNumber(slaveVersion);
+ if (agentVersion.isOlderThan(RemotingVersionInf... | [SlaveComputer->[getRetentionStrategy->[getNode,getRetentionStrategy],setNode->[setNode],getClassLoadingTime->[call],getResourceLoadingCount->[call],getNode->[getNode],grabLauncher->[getLauncher],getDelegatedLauncher->[getLauncher],taskCompleted->[taskCompleted],taskCompletedWithProblems->[taskCompletedWithProblems],ge... | Sets the slave channel. This method is called when a connection is made to a remote machine. onOnline - called when agent is connected and online. | Not sure whether we still care, but I doubt the fallback `< 1.335` will make a useful version number. |
@@ -24,12 +24,14 @@ type jobSubscriber struct {
store *store.Store
jobSubscriptions map[string]JobSubscription
jobsMutex *sync.RWMutex
+ runManager RunManager
}
// NewJobSubscriber returns a new job subscriber.
-func NewJobSubscriber(store *store.Store) JobSubscriber {
+func NewJobSubs... | [Disconnect->[Unsubscribe,Lock,Unlock],AddJob->[IsLogInitiated,addSubscription],OnNewHead->[Unscoped,ToInt,Errorf,UnscopedJobRunsWithStatus],Connect->[AddJob,Jobs,Append],RemoveJob->[Unlock,Unsubscribe,String,Lock,Errorf],Jobs->[RUnlock,RLock],addSubscription->[String,Lock,Unlock]] | Services for importing a specific . Jobs returns the list of jobs being subscribed to. | Should the runManager be a pointer for the JobSubscriber? I'm not sure we want to make copies of it. Wondering the same thing about the RunQueue that the manager holds, but don't really know how copying the `map` in there behaves. |
@@ -1218,8 +1218,11 @@ class DeferredDataFrame(DeferredDataFrameOrSeries):
merged = frame_base.DeferredFrame.wrap(
expressions.ComputedExpression(
'merge',
- lambda left, right: left.merge(
- right, left_index=True, right_index=True, **kwargs),
+ lambda le... | [_unliftable_agg->[wrapper->[groupby]],DeferredDataFrame->[nunique->[nunique],join->[_cols_as_temporary_index,join,fill_placeholders,reindex,revert],set_index->[set_index],eval->[_eval_or_query],nsmallest->[nsmallest],dot->[AsScalar],drop->[drop],rename->[rename],pop->[pop],nlargest->[nlargest],mode->[mode],dropna->[dr... | Merge two Series or Series objects. | Nit: Why two newlines, shouldn't it just be one? |
@@ -444,7 +444,8 @@ class ConstraintBuilderVisitor(TypeVisitor[List[Constraint]]):
for member in protocol.type.protocol_members:
inst = mypy.subtypes.find_member(member, instance, subtype)
temp = mypy.subtypes.find_member(member, template, subtype)
- assert inst is not None... | [ConstraintBuilderVisitor->[visit_callable_type->[infer_constraints],visit_typeddict_type->[infer_constraints],infer_against_overloaded->[infer_constraints],visit_instance->[infer_constraints],visit_tuple_type->[infer_constraints],visit_type_type->[infer_constraints],visit_overloaded->[infer_constraints],infer_constrai... | Infer constraints for situations where either template or instance is a protocol. . | I'm not familiar with this code. Do you know why it is safe to ignore it? |
@@ -143,6 +143,9 @@ public class PersistentAuditEvent implements Serializable {
@Transient
<%_ } _%>
<%_ } _%>
+ <%_ if (databaseType === 'neo4j') { _%>
+ @Transient
+ <%_ } _%>
private Map<String, String> data = new HashMap<>();
<%_ if (databaseType === 'sql') { _%>
| [No CFG could be retrieved] | private Long id ; This class is used to provide a map of data for the given object. | Right now mapping of maps is not part of SDN/RX (on purpose). So let's make it transient for now. As we plan to remove the audit feature (and neo is still in beta) I would say thats okay. |
@@ -9,6 +9,7 @@
//= require popper.js
//= require bootstrap-modal.js
//= require caret_position
+//= require diffhtml.min.js
//= require jquery.color.js
//= require jquery.fileupload.js
//= require jquery.iframe-transport.js
| [No CFG could be retrieved] | The main function for all the modules that are required to be included in the UI. | I wonder if we could include it based on the value of the site setting? |
@@ -99,7 +99,7 @@ public class GameProperties extends GameDataComponent {
if (value == null) {
return defaultValue;
}
- return (String) value;
+ return String.valueOf(value);
}
public void addEditableProperty(final IEditableProperty<?> property) {
| [GameProperties->[applyByteMapToChangeProperties->[readEditableProperties],get->[get],applyListToChangeProperties->[get],getPlayerProperty->[get],getEditableProperties->[get]]] | Get the value of a property. | This adds flexibility if we want to load an integer property as a string, otherwise we get a cast exception |
@@ -60,6 +60,17 @@ public class CreateBucketHandler extends BucketHandler {
defaultValue = "LEGACY")
private AllowedBucketLayouts allowedBucketLayout;
+ @Option(names = {"--replication", "-r"},
+ description = "Replication value. Example: 3 (for Ratis type) or 1 ( for"
+ + " standalone type).... | [CreateBucketHandler->[execute->[getVolume,toString,printf,createBucket,getVolumeName,printObjectAsJson,IllegalArgumentException,getBucket,getBucketName,getQuotaInNamespace,isEmpty,addMetadata,setQuotaInNamespace,valueOf,isNullOrEmpty,isVerbose,getQuotaInBytes,setBucketEncryptionKey,setBucketLayout,setQuotaInBytes,buil... | Creates a new bucket in a given volume. region Bucket Encryption. | Minor typo "Inthe" -> "in the". Also, I wonder we should avoid being so specific about the EC types allowed, as that may change over time, and then we will forget to change this help text. Perhaps say "In the case of EC, pass DATA-PARITY, eg 3-2, 6-3, 10-4". |
@@ -34,7 +34,8 @@ public class FakeMonitor extends BaseMonitorMBean implements FakeMonitorMBean {
}
@Override
- public LinkedHashMap<String, Object> attributes() {
- return new LinkedHashMap<>();
+ public Optional<Map<String, Object>> attributes() {
+ Map<String, Object> map = new LinkedHashMap<>();
+ ... | [No CFG could be retrieved] | Returns a copy of the attributes of this node. | you can now use `Optional.of(Collections.emptyMap())` |
@@ -163,7 +163,7 @@ func (p *Processor) GenerateParameterValues(t *api.Template) *field.Error {
if param.Generate != "" {
generator, ok := p.Generators[param.Generate]
if !ok {
- return field.NotFound(templatePath, param)
+ return field.NotFound(templatePath.Child("Generate"), param.Generate)
}
... | [SubstituteParameters->[FindAllStringSubmatch,VisitObjectStrings,Replace],GenerateParameterValues->[Invalid,Error,Index,NotFound,Child,Errorf,NewPath,Required,GenerateValue],Process->[Invalid,Error,Index,Sprintf,GenerateParameterValues,Decode,SubstituteParameters,Child,AddObjectLabels,NewPath],MustCompile,SetNamespace,... | GenerateParameterValues generates the values of all parameters in the template. | let's switch it to a field invalid error instead of a notfound error. |
@@ -250,6 +250,14 @@ export class AmpAudio extends AMP.BaseElement {
pauseHandler
);
}
+
+ /**
+ * @param {string} eventType
+ * @private
+ */
+ analyticsEvent_(eventType) {
+ triggerAnalyticsEvent(this.element, eventType);
+ }
}
AMP.extension(TAG, '0.1', AMP => {
| [No CFG could be retrieved] | Register the ethernet audio extension. | nit: Can we inline the `triggerAnalyticsEvent` function instead of creating a private method for it? It seems not worth it to create a private method for one line of code. Thanks. |
@@ -3187,8 +3187,8 @@ class DocumentTableCell(object):
kind=data.get("kind", None),
row_index=data.get("row_index", None),
column_index=data.get("column_index", None),
- row_span=data.get("row_span", None),
- column_span=data.get("column_span", None),
+ ... | [FormElement->[from_dict->[from_dict],to_dict->[to_dict]],AnalyzeResult->[from_dict->[from_dict],_from_generated->[_from_generated],to_dict->[to_dict]],FormPage->[from_dict->[from_dict],to_dict->[to_dict]],ModelOperation->[from_dict->[from_dict],_from_generated->[_from_generated],to_dict->[to_dict]],DocumentModel->[fro... | Converts a dict in the shape of a DocumentTableCell to the model itself. is. | These aren't absolutely necessary since the defaults are included in the init, but just changed as an extra layer to be sure we have the proper defaults. |
@@ -10,4 +10,5 @@ from .ems import compute_ems, EMS
from .time_gen import GeneralizationAcrossTime, TimeDecoding
from .time_frequency import TimeFrequency
from .receptive_field import ReceptiveField
+from .time_delaying_ridge import TimeDelayingRidge
from .search_light import SlidingEstimator, GeneralizingEstimator... | [No CFG could be retrieved] | Imports all the classes that are imported by this module. | why not `mne.decoding.model` instead of having its own module. That way if we want to add any custom models they can go in there? |
@@ -146,6 +146,7 @@ int BIO_get_host_ip(const char *str, unsigned char *ip)
BIOerr(BIO_F_BIO_GET_HOST_IP, BIO_R_BAD_HOSTNAME_LOOKUP);
goto err;
}
+# endif
/* cast to short because of win16 winsock definition */
if ((short)he->h_addrtype != AF_INET) {
| [No CFG could be retrieved] | get_host_ip - get the IP address of the host - - - - - - - - - - - - - - - - - -. | With that, this `#endif` needs to be moved up 4 lines. |
@@ -44,7 +44,7 @@ public class SessionHolder {
}
public static void requestInitialized(HttpServletRequest request) {
- CURRENT_SESSION.set(request.getSession(false));
+ CURRENT_SESSION.set(request.getSession());
}
public static void sessionCreated(HttpSession session) {
| [SessionHolder->[getSessionIfExists->[get],requestInitialized->[set,getSession],sessionCreated->[set],clear->[remove],getSession->[get,getSession]]] | This method is called when the request is initialized. | We do not want Weld to generally create sessions for each request. If portlet impl needs this it should start a new session itself. |
@@ -16,7 +16,7 @@ func NetworkPluginName() string {
return "redhat/openshift-ovs-subnet"
}
-func Master(osClient *osclient.Client, kClient *kclient.Client, clusterNetwork string, clusterNetworkLength uint, serviceNetwork string) {
+func Master(osClient *osclient.Client, kClient *kclient.Client, config *api.Network... | [CombinedOutput,StartMaster,New,NewKubeController,StartNode,Fatalf,NewOsdnRegistryInterface,TrimSpace,Command] | Package functions related to the n - th network plugin nannannannanf is a fatal function to panic if the node is not in the. | Don't pass a pointer to the config struct, just pass the config struct |
@@ -24,7 +24,9 @@
var mapper = new MessageMapper();
var settings = context.Settings;
var messageMetadataRegistry = settings.Get<MessageMetadataRegistry>();
- mapper.Initialize(messageMetadataRegistry.GetAllMessages().Select(m => m.MessageType));
+ mapper.Init... | [SerializationFeature->[IMessageSerializer->[serializerFactory,Item2,Configure,Merge,Item1,PreventChanges],LogFoundMessages->[DebugFormat,IsDebugEnabled,Count,Select,IsInfoEnabled,Concat],Setup->[Register,MessageType,GetAdditionalSerializers,LogFoundMessages,ToList,Select,Initialize,settings,GetMainSerializer,Configure... | Initialize the components. | i dont think this has any impact since we also register types on demand in the MessageMetadataRegistry |
@@ -152,6 +152,8 @@ public class QuarkusBuild extends QuarkusTask {
realProperties.setProperty(key, (String) value);
}
}
+ realProperties.putIfAbsent("quarkus.application.name", appArtifact.getArtifactId());
+ realProperties.putIfAbsent("quarkus.application.version",... | [QuarkusBuild->[setIgnoredEntries->[addAll],getTransformedClassesDirectory->[File,transformedClassesDirectory],buildQuarkus->[getValue,getProperties,build,lifecycle,resolveOutcome,getKey,getAppArtifact,pushOutcome,resolveAppModel,Properties,setProperty,resolveModel,startsWith,entrySet,GradleException],getWiringClassesD... | build quarkus runner. Returns the number of bytes required to encode the message. | BTW, these values most probably won't be meaningful. But we can review that later. |
@@ -3323,7 +3323,7 @@ LowererMD::GenerateFastAdd(IR::Instr * instrAdd)
}
// s1 = SUB src1, 1 -- get rid of one of the tag
- opndReg = IR::RegOpnd::New(TyInt32, this->m_func);
+ opndReg = IR::RegOpnd::New(TyMachReg, this->m_func);
instr = IR::Instr::New(Js::OpCode::SUB, opndReg, opndSrc1, IR:... | [No CFG could be retrieved] | Load src s at the top so we don t have to do it repeatedly. - - - - - - - - - - - - - - - - - -. | >TyInt32 [](start = 31, length = 7) We are doing a Int add TyInt32 is ok here. What was the purpose of making it MachReg? |
@@ -3,7 +3,9 @@
// file 'LICENSE.txt', which is part of this source code package.
using System;
+using System.Collections.Concurrent;
using System.Collections.Generic;
+using System.Threading.Tasks;
namespace Microsoft.Xna.Framework.Content.Pipeline.Graphics
{
| [GlyphPacker->[CompareGlyphSizes->[CompareTo,Character,Height,Width],BitmapContent->[Copy,Height,Max,X,Length,Count,Subrect,PositionGlyph,Sort,MakeValidTextureSize,Bitmap,Source,Y,CopyGlyphsToOutput,GuessOutputWidth,Add,Width],PositionGlyph->[Y,FindIntersectingGlyph,X,Width],FindIntersectingGlyph->[Y,Height,Width,X],Gu... | This class is used to generate a single large bitmap from a list of glyphs. Copy glyphs to output bitmap. | I don't see any new conccurent collections or tasks in this PR. Are these `using`s needed? |
@@ -135,7 +135,7 @@
}
}
- public Result Stop()
+ public Task<Result> Stop()
{
try
{
| [EndpointRunner->[Result->[ForEach,Failure,Count,GetConfiguration,MachineNameAction,GetAction,CreateSendOnly,Token,Error,Start,Wait,CustomMachineName,Givens,Create,Cleanup,IsNullOrEmpty,Dispose,GetSettings,Get,ScenarioContext,EndpointName,action,customAction,Cancel,HasNativePubSubSupport,SendOnly,Success],Name->[Endpoi... | Start the endpoint. | does it make sense to return a Task if we only use Task.FromResult? |
@@ -1434,7 +1434,10 @@ def _smooth_plot(this_time, params):
color_ave = np.mean(colors[faces], axis=1).flatten()
curv_ave = np.mean(params['curv'][faces], axis=1).flatten()
# matplotlib/matplotlib#11877
- facecolors = polyc._facecolors3d
+ if LooseVersion(matplotlib_version) < '3.3.3':
+ fac... | [_plot_mpl_stc->[_smooth_plot,_linearize_map,_separate_map,_handle_time,_process_clim],plot_vector_source_estimates->[_plot_stc],plot_source_estimates->[_plot_mpl_stc],_smooth_plot->[_set_aspect_equal],_sensor_shape->[_make_tris_fan],plot_alignment->[_fiducial_coords],plot_volume_source_estimates->[plot_and_correct->[_... | Smooth source estimate data and plot with mpl. No label for time_idx. | Now would be a good time to abandon the private attribute all together. I suggest we do `get_facecolor()` then `set_facecolor()`. It will perhaps be slower than in-place setting, but probably not a meaningful slowdown compared to the actual matplotlib 3D rendering speed. Can you see if it works? |
@@ -123,7 +123,7 @@ class BoxPlot(ChartObject):
loading the data dict.
Needed for _set_And_get method.
"""
- self.value = value
+ self.values = DataAdapter(values, force_alias=False)
self.__marker = marker
self.__outliers = outliers
sel... | [BoxPlot->[show->[check_attr,draw,get_source,get_data]]] | Initialize a new BoxPlot. object. This class is the base class for the base class. It is the base class for the. | and now the DataAdapter is on the `__init__`, we need a common place to improve conceptual understanding... |
@@ -563,3 +563,7 @@ func (r BlockReference) String() string {
func (r BlockReferenceCount) String() string {
return fmt.Sprintf("%s,%d", r.Ref.String(), r.LiveCount)
}
+
+func (sa SocialAssertion) String() string {
+ return fmt.Sprintf("%s@%s", sa.User, sa.Service)
+}
| [ToShortIDString->[ToBytes],ToMediumID->[toBytes],NotEqual->[Equal],ToShortID->[toBytes],Match->[IsNil,String],IsIn->[Equal],Exists->[IsNil],MarshalJSON->[String],Eq->[Eq],GetKeyType->[ToBytes],ToJsonw->[IsNil],String->[String],Error] | String returns a string representation of the block reference count. | Moved this here just to make it easier. |
@@ -1312,7 +1312,14 @@ class ConanAPIV1(object):
layout_abs_path = get_editable_abs_path(layout, cwd, self.app.cache.cache_folder)
if layout_abs_path:
self.app.out.success("Using layout file: %s" % layout_abs_path)
- self.app.cache.editable_packages.add(ref, target_path, layout_abs... | [_get_conanfile_path->[_make_abs_path],ConanApp->[load_remotes->[load_remotes]],get_graph_info->[ProfileData,info],ConanAPIV1->[export_alias->[export_alias,load_remotes],remote_list->[load_remotes],export->[_get_conanfile_path,_make_abs_path,load_remotes,info],info->[info,load_remotes,ProfileData,_info_args,_make_abs_p... | Add a new package to the editable list. | You can pass for both `_make_abs_path` methods `cwd` as the second argument. |
@@ -146,7 +146,7 @@ public abstract class AbstractMessageSequenceSplitter extends AbstractIntercepti
if ((!correlationSet && (enableCorrelation == CorrelationMode.IF_NOT_SET))
|| (enableCorrelation == CorrelationMode.ALWAYS))
{
- message.setCorre... | [AbstractMessageSequenceSplitter->[createMessage->[setPayload,DefaultMuleMessage],process->[isSplitRequired,processNext,splitMessageIntoSequence,processParts,aggregateResults,getInstance,isEmpty,warn],processParts->[transform->[getPayload],getMessage,setCorrelationGroupSize,size,equals,propagateRootId,getSession,setCor... | Process the parts of the message sequence. if the split expression returns a single result return it. | put an `_` in the middle to separate the original id from the suffix |
@@ -68,9 +68,9 @@ const WHITELISTED_VARIABLES = [
'FIRST_CONTENTFUL_PAINT',
'FIRST_VIEWPORT_READY',
'MAKE_BODY_VISIBLE',
+ 'HTML_ATTR',
];
-
/** Provides A4A specific variable substitution. */
export class A4AVariableSource extends VariableSource {
/**
| [No CFG could be retrieved] | Provides a variable source for A4A. This method is called to set navigation navigation data. | you will need to remove this |
@@ -43,6 +43,8 @@ namespace NServiceBus
var queueNameBase = settings.CustomLocalAddress ?? endpointName;
var purgeOnStartup = settings.PurgeOnStartup;
+ var transportInfrastructure = transportSeam.TransportInfrastructure;
+
//note: This is an old hack, we are passing ... | [ReceiveComponent->[ConfigureMessageHandlersIn->[InstancePerUnitOfWork,RegisterHandler,RegisterSingleton,Where,ConfigureComponent,messageHandlerRegistry],AddReceivers->[Create,RecoverabilityPolicy,TransactionMode,messagePumpFactory,Name,RuntimeSettings,SatelliteDefinitions,PushRuntimeSettings,ReceiveAddress,RequiredTra... | Prepare a receive configuration based on the given settings. | we could save the queue bindings here as well (or the transportSeam completely) then the parameter on line 111 wouldn't be needed anymore. Thoughts? |
@@ -19,6 +19,6 @@ if (!defined('IS_ADMIN_FLAG')) {
*/
if (!isset($_SESSION['language'])) $_SESSION['language'] = 'english';
-require(zen_get_file_directory(DIR_FS_CATALOG . DIR_WS_LANGUAGES . $_SESSION['language'], 'checkout_process.php', 'false'));
+require(zen_get_file_directory(DIR_FS_CATALOG . DIR_WS_LANGUAGES... | [No CFG could be retrieved] | Zenue nazwa konfiguracja. | The slash really should be after `$_SESSION['language']` instead of before `checkout_process.php` unless the use of a template override is purposefully necessary. All other properly formatted and operational instances of `zen_get_file_directory` present the folder path with a slash at the end rather than before the fil... |
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class CreatePublishedPages < ActiveRecord::Migration[6.0]
+ def change
+ create_table :published_pages do |t|
+ t.references :topic, null: false, index: { unique: true }
+ t.string :slug, null: false
+ t.timestamps
+ end
+
+ add_index :publishe... | [No CFG could be retrieved] | No Summary Found. | given it doesn't look like we use the id of this model maybe we could get rid of the auto increment and store the topic_id in the id column as primary_key |
@@ -36,7 +36,7 @@ export default Component.extend(UtilsMixin, {
didInsertElement() {
this._super(...arguments);
- if (!this.site.mobileView) {
+ if (!this?.site?.mobileView) {
this.element.addEventListener("mouseenter", this.handleMouseEnter);
this.element.addEventListener("focus", this.ha... | [No CFG could be retrieved] | The default select - kinetic - component implementation. View s layout - specific properties. | site is not defined in wizard |
@@ -126,6 +126,15 @@ func NewRepoContext() {
RemoveAllWithNotice("Clean up repository temporary data", filepath.Join(setting.AppDataPath, "tmp"))
}
+// RepositoryStatus defines the status of repository
+type RepositoryStatus int
+
+// all kinds of RepositoryStatus
+const (
+ RepositoryCreated RepositoryStatus = i... | [updateSize->[repoPath],UpdateSize->[updateSize],patchPath->[getOwner],Link->[FullName],DescriptionHTML->[Error,ComposeMetas,HTMLURL],mustOwner->[getOwner,Error],RepoPath->[repoPath],APIURL->[FullName],UploadAvatar->[CustomAvatarPath],generateRandomAvatar->[CustomAvatarPath],CloneLink->[cloneLink],GetAssignees->[getAss... | NewRepoContext creates a new repository context from a list of files. NumPulls int ClosingPulls int ClosingPulls int ClosingPull. | Generally _x is creating_ reads as _x is creating (some unspoken) y_. I suggest change these to: `RepositoryReady` `RepositoryInitializing` or `RepositoryInstantiating` or `BeingCreated` (Admittedly Initializing and Instantiating are both ambiguous, but these verbs are more likely to be used reflexively in their intran... |
@@ -20,7 +20,7 @@ type Plugin interface {
// - newly created build object or nil if default is to be created
// - information whether to trigger the build itself
// - eventual error.
- Extract(buildCfg *buildapi.BuildConfig, secret, path string, req *http.Request) (*buildapi.SourceRevision, bool, error)
+ Extract... | [ServeHTTP->[Error,Infof,Extract,V,Get,Instantiate],Join,Error,Errorf,Query,Get,Split,Trim] | webhook import imports a plugin from the webhook service. get a specific BuildConfig object from the buildConfigGetter. | so while this is technically "fine" it set off my spider sense that you were making the exact same changes in two files. A little investigation reveals that this file is longer actually used at runtime (though we still have test code that exercises it). Even worse, the file that replaced it (buildconfig/webhook.go) is ... |
@@ -329,6 +329,16 @@ int ModApiClient::l_take_screenshot(lua_State *L)
return 0;
}
+int ModApiClient::l_get_privilege_list(lua_State *L)
+{
+ Client *client = getClient(L);
+ lua_newtable(L);
+ for (const std::string &priv : client->getPrivilegeList()) {
+ lua_pushboolean(L, true);
+ lua_setfield(L, -2, priv.c_s... | [No CFG could be retrieved] | This function initializes the API client with functions defined in the node file system. | Can be const or not? |
@@ -52,10 +52,11 @@ class CMake(object):
return base
if operating_system == "Windows":
- if compiler == "gcc":
- return "MinGW Makefiles"
- if compiler in ["clang", "apple-clang"]:
- return "MinGW Makefiles"
+ non_msvc = True if ... | [CMake->[options_cmd_line->[append,join,as_list,upper],_generator->[ConanException,get,str],__init__->[_generator,isinstance],flags->[str,join,extend,append]]] | Returns a CMake generator string. Unix Makefiles not supported. | A bit more pythonic: ``non_msvc = (compiler != "Visual Studio")`` |
@@ -33,11 +33,7 @@ shift
srb_path="${BASH_SOURCE[0]}"
compute_md5() {
- if command -v md5sum > /dev/null; then
- md5sum "$1"
- else
- md5 -r "$1"
- fi
+ ruby -e "require 'digest'; puts Digest::MD5.hexdigest(File.read(ARGV[0]))" "$1"
}
typecheck() {
| [exec] | A total hack for the type checker. The srb - rbi script is used to run the srb - rbi script. | this is going to get slower by a bunch and i'm not in love with that since we pay the cost on EVERY invocation. Is there some other way? Can we depend on md5 and package it or something? Shelling out to ruby will basically double our `srb tc` cost |
@@ -73,7 +73,9 @@ class ReactionsController < ApplicationController
).first
# if the reaction already exists, destroy it
- if reaction
+ # NOTE: @citizen Temporarily we ingore vomit reactions, to avoid accidental
+ # unflagging. A better solution will be added in the future.
+ if reaction && cat... | [ReactionsController->[handle_existing_reaction->[destroy_reaction],rate_article->[create],clear_moderator_reactions->[destroy_reaction]]] | Creates a new count cache key based on the given key. | @rhymes @vaidehijoshi This is by no means an elegant solution, but I think I want to keep the bigger refactoring out of the scope of this PR/RFC. What do you think? |
@@ -199,12 +199,13 @@ static int EnvironmentsSanityChecks(Attributes a, const Promise *pp)
/*****************************************************************************/
-static PromiseResult VerifyEnvironments(EvalContext *ctx, Attributes a, const Promise *pp)
+static PromiseResult VerifyEnvironments(EvalContext... | [No CFG could be retrieved] | Verify that the attributes of a promise are compatible with the environment. finds the environment type of the environment. | Same question here. Also, there's a space missing before the `=`. |
@@ -382,6 +382,7 @@ function getSentinel_(iframe, opt_is3P) {
function parseIfNeeded(data) {
const shouldBeParsed = typeof data === 'string'
&& data.charAt(0) === '{';
+ let msg;
if (shouldBeParsed) {
try {
data = JSON.parse(data);
| [No CFG could be retrieved] | Provides a postMessage API for a message sent to all subscribed windows. Construct a new window - related object. | could you update the doc, seems it allows both Object and string |
@@ -81,7 +81,13 @@ final class ItemResolverFactory extends AbstractResolverFactory implements ItemR
$item = $this->itemDataProvider->getItem($resourceClass, \count($identifiers) > 1 ? \implode(';', $identifiers) : $uniqueIdentifier[0]);
}
- return $item ? $this->normalizer->no... | [ItemResolverFactory->[createItemResolver->[normalize,getIdentifiersFromResourceClass,getSubresource,getItem]]] | Creates a function that resolves a composite identifier. | Can't this be `null` if metadata hasn't been found? |
@@ -196,7 +196,7 @@ class GradeEntryForm < ApplicationRecord
updated_grades = []
# Parse the grades
- result = MarkusCSV.parse(grades_data, header_count: 2) do |row|
+ result = MarkusCsv.parse(grades_data, header_count: 2) do |row|
next unless row.any?
# grab names and totals from the fi... | [GradeEntryForm->[calculate_total_percent->[out_of_total],export_as_csv->[out_of_total]]] | Parse the grades_data and return the last node in the list of grades that have been. | Metrics/BlockLength: Block has too many lines. [26/25] |
@@ -18,6 +18,10 @@ class WebhookEventType:
ORDER_CANCELLED = "order_cancelled"
ORDER_FULFILLED = "order_fulfilled"
+ DRAFT_ORDER_CREATED = "draft_order_created"
+ DRAFT_ORDER_UPDATED = "draft_order_updated"
+ DRAFT_ORDER_DELETED = "draft_order_deleted"
+
INVOICE_REQUESTED = "invoice_requested"... | [No CFG could be retrieved] | Imports all permissions from the given object. Get a list of all order events. | You didn't add a label and permission for these webhooks See below a `DISPLAY_LABELS`, `CHOICES` and `PERMISSIONS` |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.