patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -293,7 +293,7 @@ case "$with_platform" in
AC_SUBST(XTENSA_CORE)
AC_DEFINE([CONFIG_APOLLOLAKE], [1], [Configure for Apollolake])
- AC_DEFINE([CONFIG_BOOT_LOADER], [1], [Configure Boot Loader])
+ AC_DEFINE([CONFIG_KABYLAKE], [1], [Configure for Kabylake])
AC_DEFINE([CONFIG_IRQ_MAP], [1], [Configure IRQ maps])
... | [No CFG could be retrieved] | Adds the default configuration for all non - standard non - global configuration values. Define all configuration options for the given object. | Why both CONFIG_KABYLAKE and CONFIG_APOLLOLAKE, in kconfig I made this as choice type so it won't be even possible to have both. If it's just some kind of kbl-only feature please name it CONFIG_KABYLAKE_BOOTLOADER or something like that, because by looking at name I guess it's mostly like apl platform but just kbl boot... |
@@ -206,12 +206,12 @@ module Articles
@user_following_users_ids ||= (@user&.cached_following_users_ids || [])
end
- def first_half(array)
- array[0...(array.length / 2)]
+ def first_quarter(array)
+ array[0...(array.length / 4)]
end
- def last_half(array)
- ... | [LargeForemExperimental->[more_comments_minimal_weight->[default_home_feed_and_featured_story],find_featured_story->[find_featured_story]]] | Returns an array of user_following_users_ids that are not nil. | This one change takes the top _quarter_ of results instead of _half_ and presents them in a shuffled order. It's a slight modification that should complement the one we selected for the better. |
@@ -57,6 +57,12 @@ class NailgunClientSession(NailgunProtocol):
self._maybe_start_input_reader()
else:
raise self.ProtocolError('received unexpected chunk {} -> {}'.format(chunk_type, payload))
+ except (IOError, OSError) as e:
+ # If a `Broken Pipe` is encountered during a stdio ... | [NailgunClientSession->[_process_session->[_maybe_start_input_reader,_maybe_stop_input_reader],execute->[_process_session]],NailgunClient->[execute->[execute,NailgunClientSession,try_connect,NailgunError],try_connect->[NailgunConnectionError]]] | Process the outputs of the nailgun session. | I'm guessing that you should only get `EPIPE` when dealing with `_stdout`/`_stderr` here, and never when dealing with the socket? |
@@ -143,7 +143,7 @@ function dfrn_notify_post(App $a) {
$rino = get_config('system','rino_encrypt');
$rino = intval($rino);
// use RINO1 if mcrypt isn't installed and RINO2 was selected
- if ($rino==2 and !function_exists('mcrypt_create_iv')) $rino=1;
+ if ($rino == 2 and !function_exists('mcrypt_create_iv')) $ri... | [No CFG could be retrieved] | Notify user of a change in the DCNR challenge. finds the local user who owns the given challenge and if it is a link to the This function is called when a user is blocked and a contact is found. This function is called when a user has not received any input from a user. | Standards: Please add braces to this condition and spaces around the `=`. |
@@ -18,6 +18,7 @@
-%>
import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';
+
import { errorRoute } from './layouts/error/error.route';
import { navbarRoute } from './layouts/navbar/navbar.route';
import { DEBUG_INFO_ENABLED } from 'app/app.constants';
| [No CFG could be retrieved] | Creates a new object that can be imported by JHipster. The AppRoutingModule class is a subclass of the login module that can be used to route. | Those empty lines are intentional, those are separating library and application internal imports. |
@@ -459,8 +459,9 @@ class TestInitializer(PluginTest):
},
'messaging': {
'host': None,
- 'scheme': 'tcp',
+ 'scheme': 'amqp',
'port': '5672',
+ 'transport': 'qpid',
'cacert': 'test-ca',
... | [TestAuthentication->[test_signing->[assert_called_with,load_key_bio,MemoryBuffer,assertEqual,update,Authenticator,sign,Mock],test_not_validated->[assert_called_with,load_key_bio,MemoryBuffer,update,Authenticator,assertRaises,sign,Mock],test_validated->[assert_called_with,load_key_bio,validate,MemoryBuffer,update,Authe... | Test setup plugin with mock. | Using well-known port services instead. |
@@ -1625,7 +1625,7 @@ func (d *driver) clearCommit(ctx context.Context, commit *pfs.Commit) error {
if err != nil {
return err
}
- if commitInfo.Finished != nil {
+ if commitInfo.Finishing != nil {
return errors.Errorf("cannot clear finished commit")
}
return d.commitStore.DropFileSets(ctx, commit)
| [propagateBranches->[aliasCommit],clearCommit->[inspectCommit],inspectCommitSet->[inspectCommit,inspectCommitSetImmediate],listRepo->[getPermissions],dropCommitSet->[squashCommitSetInternal,inspectCommitSetImmediate],squashCommitSet->[squashCommitSetInternal,inspectCommitSetImmediate],createBranch->[resolveCommit,alias... | clearCommit removes all file sets in a commit. | Does this error need to update to reflect the changed behavior? |
@@ -952,11 +952,16 @@ class PackageInstaller(object):
otherwise ``False``
install_package (bool): ``True`` if installing the package,
otherwise ``False``
+ keep_failures (bool): ``True`` if previous failures should be kept,
+ otherwise ``False``
... | [PackageInstaller->[_check_deps_status->[_check_db,package_id],__repr__->[__repr__],_init_queue->[_check_deps_status,package_id,_add_bootstrap_compilers],_ensure_install_ready->[package_id],install->[_init_queue,_pop_task,package_id,_cleanup_all_tasks,_print_installed_pkg,_handle_external_and_upstream,_ensure_locked,_u... | Initialize the build queue and spec state. | I don't think this debug statement is necessary. Also there are occasions when the user doesn't explicitly request the failure markings (e.g. from the PR description: when installing a spec yaml file). |
@@ -41,11 +41,12 @@ class RGenomicranges(RPackage):
url = "https://git.bioconductor.org/packages/GenomicRanges"
list_url = homepage
+ version('1.30.3', git='https://git.bioconductor.org/packages/GenomicRanges', commit='e99979054bc50ed8c0109bc54563036c1b368997')
version('1.28.6', git='https://gi... | [RGenomicranges->[depends_on,version]] | This method returns a list of all genomic ranges in the system. | I assume these dependencies are needed for all versions of `r-genomicranges`? |
@@ -151,8 +151,7 @@ public final class KinesisIO {
public Read from(String streamName, InitialPositionInStream initialPosition) {
return toBuilder()
.setStreamName(streamName)
- .setInitialPosition(
- new StartingPoint(checkNotNull(initialPosition, "initialPosition")))
+ ... | [KinesisIO->[Read->[withClientProvider->[withClientProvider,build],expand->[getInitialPosition,getMaxNumRecords,getStreamName,getClientProvider,withMaxReadTime,withMaxNumRecords,getMaxReadTime,from],BasicKinesisProvider->[get->[getCredentialsProvider]],withMaxReadTime->[build],withMaxNumRecords->[build],from->[build]]]... | Returns a read with the specified stream name and starting position. | <!--new_thread; commit:8503adbbc3a590cd0dc2939f6a45d335682a9442; resolved:0--> Does StartingPoint perform this check? |
@@ -683,6 +683,7 @@ dc_rw_cb(tse_task_t *task, void *arg)
}
rc = obj_reply_get_status(rw_args->rpc);
+ D_DEBUG(DB_IO,"rc: %d after obj_reply_get_status", rc);
/*
* orwo->orw_epoch may be set even when the status is nonzero (e.g.,
* -DER_TX_RESTART and -DER_INPROGRESS).
| [No CFG could be retrieved] | RPC for DOS object read - write END OF TRANSACTION. | (style) space required after that ',' (ctx:VxV) |
@@ -11,3 +11,4 @@ import {Link} from './styled-components.js';
//$FlowFixMe
export const StyledLink = props => <Link data-baseweb="link" {...props} />;
+StyledLink.__STYLETRON__ = Link.__STYLETRON__;
| [No CFG could be retrieved] | Create a styled link. | Thanks, I forgot about this! |
@@ -102,11 +102,11 @@ class Symfony implements ProxyClientInterface, PurgeInterface
* @param string $url URL
* @param array $headers HTTP headers
*
- * @return RequestInterface
+ * @return Request
*/
protected function createRequest($method, $url, array $headers = [])
{
- ... | [Symfony->[sendRequests->[createRequest],createRequest->[createRequest]]] | Creates a request with a . | Why don't we just use `settle` here? |
@@ -423,7 +423,7 @@ type AddLightLearner struct {
// ConfVerChanged returns true if the conf version has been changed by this step
func (al AddLightLearner) ConfVerChanged(region *core.RegionInfo) bool {
- if p := region.GetStoreLearner(al.ToStore); p != nil {
+ if p := region.GetStorePeer(al.ToStore); p != nil {
... | [Check->[IsFinish],IsTimeout->[IsFinish],Influence->[GetStoreInfluence],IsFinish->[String],MarshalJSON->[String],ConfVerChanged->[ConfVerChanged],TotalInfluence->[Influence],UnfinishedInfluence->[IsFinish,Influence],String->[IsFinish,String]] | ConfVerChanged returns true if the peer s ConfVer has changed. | It seemed to be opposite with #1732 |
@@ -422,6 +422,16 @@ func ServiceTagInputTagsField(serviceName string) string {
}
}
+// ServiceTagInputResourceTypeField determines the service tagging tags field requires a map[string]*string.
+func ServiceTagInputRequiresStringMap(serviceName string) string {
+ switch serviceName {
+ case "kinesis":
+ return "y... | [Strings,Write,Create,Execute,New,Close,Source,Parse,Fatalf,Funcs,Bytes] | ServiceTagInputIdentifierRequiresSlice determines if the service tag input identifier requires a slice. RemoveTags - This function is a function that can be used to remove tags from a resource. | Yet another permutation for the Kinesis Streams service. Listing tags returns a `[]*kinesis.Tag` but the tags input to the `AddTags` API requires a `map[string]*string`. Capture that here via another specialization. |
@@ -4,11 +4,12 @@ RSpec.describe "PageViews", type: :request do
let(:user) { create(:user, :trusted) }
let(:article) { create(:article) }
- before do
- # rubocop:disable RSpec/AnyInstance
- allow_any_instance_of(PageViewsController).to receive(:skip_page_view_update?).and_return(false)
- allow_any_ins... | [create,to,context,let,have_received,describe,before,not_to,post,receive,eq,sign_in,put,with,it,require,id,and_return] | Describe the page views missing context when not part of field test. | I tried to use `page_views_path` instead, but for two specific specs (the ones starting at lines 81 and 88 respectively) this resulted in weird errors in `sidekiq_perform_enqueued_jobs` (` NoMethodError: undefined method `url_options'`) and I really didn't feel like spending more time on debugging this right now when t... |
@@ -264,6 +264,7 @@ define([
this._maximumScreenSpaceError = defaultValue(options.maximumScreenSpaceError, 16);
this._maximumNumberOfLoadedTiles = defaultValue(options.maximumNumberOfLoadedTiles, 256);
+ this._maximumMemoryUsage = defaultValue(options.maximumMemoryUsage, 256);
this._... | [No CFG could be retrieved] | Displays a single in the same format as the one in the Cesium 3 Initialize the object with the default values. | Add this an `maximumNumberOfLoadedTiles` to the doc. |
@@ -157,10 +157,6 @@ class KeyVaultSecretTest(AsyncKeyVaultTestCase):
# delete them
for secret_name in expected.keys():
await client.delete_secret(secret_name)
- for secret_name in expected.keys():
- await self._poll_until_no_exception(
- client.get_delete... | [KeyVaultSecretTest->[test_secret_crud_operations->[_update_secret,_validate_secret_bundle,_assert_secret_attributes_equal],test_backup_restore->[_assert_secret_attributes_equal],_validate_secret_list->[_assert_secret_attributes_equal],test_list_versions->[_assert_secret_attributes_equal],test_list_deleted_secrets->[_a... | Test list deleted secrets. | So much tidier :heart_eyes_cat: |
@@ -40,6 +40,11 @@ func handleQuickVersion() bool {
return false
}
+func keybaseExit(exitCode int) {
+ logger.RestoreConsoleMode()
+ os.Exit(exitCode)
+}
+
func main() {
err := libkb.SaferDLLLoading()
| [GetRunMode,SkipOutOfDateCheck,RegisterProtocolsWithContext,TempFile,Getenv,Close,GC,WriteHeapProfile,GetAutoFork,GetForkCmd,SaveConsoleMode,Exit,GetUIDMapFullNameCacheSize,StartLoopbackServer,RegisterLogger,ParseDuration,SetupCriticalSubServices,Error,Stop,NewLogUIProtocol,Warning,GetLogClient,Init,New,NewUIDMap,GetEx... | The main function of the library. SetServices sets the services in the global scope. | it looks like the spacing is off here. did it pass `go fmt`? |
@@ -70,6 +70,8 @@ func testBuildDigest(oc *exutil.CLI, buildFixture string, buildLogLevel uint) {
logLevelArg := fmt.Sprintf("--build-loglevel=%d", buildLogLevel)
g.By("starting a test build")
br, err := exutil.StartBuildAndWait(oc, "test", logLevelArg)
+ o.Expect(err).NotTo(o.HaveOccurred())
+ br.AssertSucc... | [Context,CurrentGinkgoTestDescription,By,StartBuildAndWait,Expect,DumpDockerInfo,HaveOccurred,FixturePath,ImageClient,It,Args,DumpPodLogsStartingWith,To,AdminKubeClient,Namespace,BeNil,Equal,Execute,NewCLI,BeforeEach,ServiceAccounts,WaitForBuilderAccount,Get,NotTo,Describe,Image,Sprintf,AfterEach,Core,DumpPodStates,Gin... | testBuildDigest tests that the build has been saved to the build status. | Why is this err ignored? |
@@ -367,6 +367,7 @@ bool HTTPClient::begin(String host, uint16_t port, String uri, const uint8_t htt
*/
void HTTPClient::end(void)
{
+ _canReuse = false;
disconnect();
clear();
}
| [PUT->[PUT],connected->[connected],connect->[setTimeout,connected,connect,verify,create],POST->[POST],writeToStream->[connected,disconnect],getStream->[connected],returnError->[errorToString,connected],sendRequest->[connected,sendRequest],errorToString->[String],reset->[reset],handleHeaderResponse->[connected],beginInt... | End the HTTP client. | Even if the user calls `::end`, _client is never cleared in this code so the object will always print the debug message nastygram when you destroy the object. Suggest the simplest thing here is to set _client to NULL at this point in the code. I would also suggest setting _tcpDeprecated to NULL here as well, since that... |
@@ -32,6 +32,11 @@ func init() {
devtools.BeatDescription = "Packetbeat analyzes network traffic and sends the data to Elasticsearch."
devtools.BeatLicense = "Elastic License"
+ if devtools.Platform.GOOS == "windows" {
+ // Explicitly hold at ELv1 to satisfy Npcap licensing on Windows.
+ // Do not alter this wi... | [CustomizePackaging,Now,BuildGoDaemon,LookupEnv,PackageKibanaDashboardsFromBuildDir,TestPackages,UseElasticBeatXPackReducedPackaging,DefaultBuildArgs,CrossBuild,UseElasticBeatXPackPackaging,Since,KibanaDashboards,CrossBuildGoDaemon,OSSBeatDir,Deps,GolangCrossBuild,Config,Build,SerialDeps,Println,RegisterCheckDeps,Confi... | Initialization function for the Beat binary. Build builds the Beat binary inside of the golang - builder. | While debugging the license checking issues I found that this is not run during packaging. This means that this hold won't constrain the license note customisation though it will prevent escape of the actual installer. Is this a problem and if it is where would be the best equivalent place in the packaging code path? |
@@ -91,7 +91,7 @@ public class ChoiceParameterDefinition extends SimpleParameterDefinition {
return checkValue(new StringParameterValue(getName(), value, getDescription()));
}
- @Extension
+ @Extension @Symbol("choiceParam")
public static class DescriptorImpl extends ParameterDescriptor {
... | [ChoiceParameterDefinition->[createValue->[checkValue],DescriptorImpl->[doCheckChoices->[areValidChoices]],copyWithDefaultValue->[ChoiceParameterDefinition]]] | Creates a StringParameterValue with the specified value. | But then why no `choice` alias here? |
@@ -228,13 +228,13 @@ define([
// Interpolate!
var x = times[lastIndex].getSecondsDifference(time);
- var interpolationResult = intervalData.interpolationAlgorithm.interpolateOrderZero(x, xTable, yTable, doublesPerInterpolationValue);
+ interpolationScra... | [No CFG could be retrieved] | Builds the tables for the values and the values. This function is called when the data array is empty. | Scrach -> Scratch |
@@ -102,6 +102,8 @@ GCP_REQUIREMENTS = [
'google-apitools>=0.5.6,<1.0.0',
'proto-google-cloud-datastore-v1==0.90.0',
'googledatastore==7.0.0',
+ # GCP packages required by tests
+ 'google-cloud-bigquery>=0.22.1,<1.0.0',
]
| [get_version->[open,exec],find_packages,get_distribution,system,get_version,format,warn,cythonize,setup,StrictVersion] | However is recommended. Package hierarchy for all packages. | This is a beta product. Either pin the version or limit to `<0.23` And also create a jira for separating test gcp dependencies. |
@@ -254,6 +254,11 @@ int enc_main(int argc, char **argv)
goto opthelp;
cipher = c;
break;
+ case OPT_ITER:
+ if (!opt_int(opt_arg(), &iter))
+ goto opthelp;
+ pbkdf2 = 1;
+ break;
case OPT_NONE:
ciphe... | [No CFG could be retrieved] | read the key from the password p Reads the n - tuple from the file and returns the n - tuple. | I'm wondering whether we should have a "-pbkdf2" option that uses a default number of iterations as well? |
@@ -7478,11 +7478,7 @@ namespace ProtoCore.DSASM
return;
}
- case OpCode.DEPX:
- {
- DEPX_Handler();
- return;
- }
+
case OpCode.SETEXPUID:... | [No CFG could be retrieved] | This is a private utility method that handles all of the JMP - related functions. region Public Methods. | @zora-wang Theres one more, pls remove this: private void DEPX_Handler() |
@@ -88,7 +88,6 @@ install_requires = [
"pyparsing==2.4.7",
"typing_extensions>=3.7.4",
"fsspec>=0.8.5",
- "dvclive>=0.0.1a0",
"diskcache>=5.2.1",
]
| [build_py->[pin_version->[write,mkpath,format,join,open],run->[run,execute]],find_packages,abspath,module_from_spec,dirname,join,exec_module,spec_from_file_location,setup,open] | This function is used to find all possible versions of the module that are not available in the Package private for testing purposes. Deprecated in 1. 26. 1. | I guess this was a typo and it was meant for `tests`, right? cc @pared |
@@ -50,7 +50,8 @@ module Engine
def can_dump?(entity)
return true unless presidents_share
- (corporation.player_share_holders.reject { |k, _| k == entity }.values.max || 0) >= presidents_share.percent
+ sh = corporation.player_share_holders(corporate: true)
+ (sh.reject { |k, _| k == entity... | [ShareBundle->[price_per_share->[price_per_share],president->[owner],corporation->[corporation],owner->[owner]]] | Check if the given entity can be dumped. | this is already default true |
@@ -2056,6 +2056,7 @@ Spdp::remove_discovered_participant_i(DiscoveredParticipantIter& iter)
void
Spdp::init_bit(const DDS::Subscriber_var& bit_subscriber)
{
+ ACE_GUARD(ACE_Thread_Mutex, g, lock_);
bit_subscriber_ = bit_subscriber;
// This is here to make sure thread status gets a valid BIT Subscriber
| [No CFG could be retrieved] | DCPS - specific exception handler Checks if a participant is expected to be opendds. | Is it safe to call `enable_periodic_tasks()` while locked? Is it necessary to call `enable_periodic_tasks()` while locked? |
@@ -257,6 +257,8 @@ Discourse.Utilities = {
getUploadMarkdown: function(upload) {
if (Discourse.Utilities.isAnImage(upload.original_filename)) {
return '<img src="' + upload.url + '" width="' + upload.width + '" height="' + upload.height + '">';
+ } else if (Discourse.Utilities.isAVideo(upload.origina... | [No CFG could be retrieved] | Check if a file is in the list of authorized extensions and if so return the name of Checks if the user has authorized to upload an entity. | I don't think this works. `upload.url` is a **relative** url. |
@@ -246,8 +246,8 @@ class WindmillTimerInternals implements TimerInternals {
builder.setStateFamily(stateFamily);
}
- builder.setTimestamp(WindmillTimeUtils.harnessToWindmillTimestamp(timerData.getTimestamp()));
-
+ builder.setTimestamp(
+ WindmillTimeUtils.harnessToWindmillTimestamp(timerDat... | [WindmillTimerInternals->[withPrefix->[WindmillTimerInternals],deleteTimer->[getTimerDataKey]]] | This method is used to build a Windmill Timer from a TimerData. | I think this change is incorrect. Why was it necessary? |
@@ -1004,7 +1004,10 @@ namespace System.Text.Json
{
Debug.Assert(_arrayBufferWriter != null);
- _memory = _arrayBufferWriter.GetMemory(checked(BytesPending + sizeHint));
+ int needed = BytesPending + sizeHint;
+ JsonHelpers.ValidateInt32MaxArr... | [Utf8JsonWriter->[Flush->[Flush,CheckNotDisposed],WriteStartObject->[WriteStartObject,WriteStartEscape],WriteEndSlow->[WriteEndMinimized],WriteStartArray->[WriteStartEscape,WriteStartArray],WriteStartSlow->[WriteStartMinimized],WriteStartEscape->[WriteStartEscapeProperty,WriteStartByOptions],WriteEndIndented->[WriteEnd... | private private int _output = 0 ;. | This was changed to keep the OOM exception semantics (instead of OverflowException). There are no effective perf differences since the overhead of the new `if` statement roughly equals the extra logic in using `checked()`. Note there are other cases in STJ that also use `checked()` that could be changed like this code,... |
@@ -147,8 +147,12 @@ module Sorbet::Private
begin
tp.disable
- singleton = tp.method_id == :singleton_method_added
+ singleton = method_id_sym == :singleton_method_added
receiver = singleton ? Sorbet::Private::RealStdlib.real_singleton_class(tp.self... | [Tracer->[install_tracepoints->[on_method_added,new,on_module_created]]] | Initializes a new instance of the ClassTracePoint class_tracepoint c_call and c enable is true if there is a in the current object. | can you say why you don't want to do this whole block of code in JRuby? |
@@ -60,14 +60,14 @@ namespace System.IO
{
Debug.Assert(_endIndex > 0);
int spaceRemaining = _unprocessedBufferToBeRead.Length - _endIndex;
- if (spaceRemaining < charLen)
+ if (spaceRemaining < chars.Length)
{
... | [StdInReader->[ReadOrPeek->[ReadLineCore,Peek],ConsoleKeyInfo->[IsUnprocessedBufferEmpty,MapBufferToConsoleKey,AppendExtraBuffer,ReadStdin],AppendExtraBuffer->[IsUnprocessedBufferEmpty],MapBufferToConsoleKey->[IsUnprocessedBufferEmpty,MapBufferToConsoleKey],ReadStdin->[ReadStdin]]] | This method appends the data to the input buffer if it is not already there. | I didn't change it so as not to mix purposes in this PR, but the logic in this method is suspect, in particular around ensuring there's enough space in the buffer. |
@@ -259,7 +259,7 @@ def handle_channel_withdraw(raiden: "RaidenService", event: Event):
update_path_finding_service_from_channel_state(raiden=raiden, channel_state=channel_state)
-def handle_channel_closed(raiden: "RaidenService", event: Event):
+def create_channel_closed_state_change(chain_state: "ChainSt... | [on_blockchain_event->[handle_channel_withdraw,handle_channel_new,handle_tokennetwork_new,handle_channel_closed,handle_channel_batch_unlock,handle_channel_settled,handle_channel_new_balance,handle_secret_revealed,handle_channel_update_transfer]] | Handle a channel closed event. | Please add a return type annotation |
@@ -530,8 +530,10 @@ public class URIExtractionNamespace implements ExtractionNamespace
Preconditions.checkArgument(!Strings.isNullOrEmpty(valueFieldName), "[valueFieldName] cannot be empty");
this.keyFieldName = keyFieldName;
this.valueFieldName = valueFieldName;
+
+ // Copy jsonMapper; don't... | [URIExtractionNamespace->[TSVFlatDataParser->[toString->[toString],equals->[equals,getColumns,getKeyColumn,getValueColumn,getDelimiter],toString,DelegateParser,setFieldNames],equals->[equals,getUriPrefix,getUri,getFileRegex,getNamespaceParseSpec],hashCode->[hashCode,getUriPrefix,getFileRegex,getUri],JSONFlatDataParser-... | This class is used to convert a FlatData object into a JSON object. Checks if the object is an object of the same class as this object. | There are bugs with jsonmapper copy if I recall. So the behavior of the copy might vary with Jackson version. |
@@ -53,13 +53,17 @@ module Engine
ACTIONS
end
+ # This step should not be passed
+ # This prevents the force_next_entity! from trying
+ def pass!; end
+
def process_destination_connection(action)
action.corporations.each do |corporation|
... | [CheckConnection->[destination->[walk,empty?,max,size,home_hex,destination_hex,include?,assigned?,first],process_destination_connection->[connection_runs,destination_hex,pass!,log,each,name],auto_actions->[new,zero?,step_passed?,destination,select],freeze],require_relative] | finds a in the list of corners that can connect to its destination. | it'd be better to override operating.rb to change the behaviour to skip force next entity on check_connection. |
@@ -261,7 +261,7 @@ func Build(cfg *config.Config, masterSubnetID string, agentSubnetIDs []string, i
prop.WindowsProfile.ImageVersion == "" {
prop.WindowsProfile.WindowsPublisher = "microsoft-aks"
prop.WindowsProfile.WindowsOffer = "aks-windows"
- prop.WindowsProfile.WindowsSku = "2019-datacenter-core... | [Write->[Printf,JSONMarshal,WriteFile],HasNetworkPlugin->[Contains],HasNetworkPolicy->[Contains],HasAddon->[Bool],HasWindowsAgents->[HasWindows],GetWindowsTestImages->[GetWindowsSku,HasWindowsAgents,New,Contains],Atoi,BoolPtr,Error,ReadFile,IsKubernetesVersionGe,IsAzureStackCloud,IsWindows,Errorf,Process,Bool,LoadTrans... | Determines the properties of the agent pool that are used by the agent. This is a hack to allow the environment to have a version opinion. | Oops sorry this needs to be 2019-datacenter-core-ctrd-2103 |
@@ -116,7 +116,7 @@ func createCmd(c *cli.Context) error {
return err
}
- options, err := createConfig.GetContainerCreateOptions()
+ options, err := createConfig.GetContainerCreateOptions(runtime)
if err != nil {
return err
}
| [NewContainer,InitLabels,GetContainerCreateOptions,IsContainer,StringSlice,Port,RAMInBytes,DisableSecOpt,GetConfig,StringInSlice,IsSet,WriteFile,IsNotExist,UsernsMode,ShmDir,Error,Stat,PidMode,Args,Marshal,IsHost,Int,New,ParseIDMapping,Names,UTSMode,Errorf,Container,IpcMode,GetRuntimeWithStorageOpts,Bool,SplitN,Debug,I... | Allocate a unique identifier for the current container. parseSecurityOpt parses the cidfile and securityOpts and writes the id to the file. | nit: Is this removal intentional? It looks like unnecessary churn to me. |
@@ -232,11 +232,14 @@ export default class KeyphraseInImagesAssessment extends Assessment {
// Images, but no alt tags.
return {
score: this._config.scores.noAlt,
- resultText: i18n.sprintf(
+ resultText: sprintf(
/* Translators: %1$s and %2$s expand to links on yoast.com, %3$s expands to the anchor ... | [No CFG could be retrieved] | Images but no alt tags. | This should be a single line string. |
@@ -104,6 +104,14 @@ def train_model_from_args(args: argparse.Namespace):
# Import any additional modules needed (to register custom classes)
for package_name in args.include_package:
import_submodules(package_name)
+
+ if not args.cont and os.path.exists(args.serialization_dir):
+ raise Ex... | [datasets_from_params->[info,from_params,read,pop],train_model_from_file->[set_default_mininterval,train_model,from_file],train_model_from_args->[train_model_from_file,import_submodules],train_model->[datasets_from_params,Formatter,join,info,assert_empty,archive_model,ConfigurationError,index_with,FileHandler,from_para... | Train a model from an argparse. Namespace object. | Should I instead `logger.error` and then `sys.exit(1)`? The output would be more friendly. |
@@ -259,3 +259,17 @@ def modelzoo_path(datapath, path):
pass
return os.path.join(datapath, 'models', path[7:])
+ else:
+ # Internal path -- useful for non-public projects.
+ # Save the path to your internal model zoo in
+ # parlai_internal/.internal_zoo_path
+ zoo... | [download_from_google_drive->[_get_confirm_token],move->[move],download_models->[built,mark_done,download,remove_dir,make_dir,untar],modelzoo_path->[download]] | Returns the model zoo path for the given path. | Seems like this should be a `RuntimeError` or a `ValueError`. |
@@ -180,9 +180,15 @@ func (c *Checkpoint) persist() bool {
func (c *Checkpoint) flush() error {
tempFile := c.file + ".new"
file, err := os.Create(tempFile)
+ if os.IsNotExist(err) {
+ // Try to create directory if it does not exist.
+ if createDirErr := c.createDir(); createDirErr == nil {
+ file, err = os.Cr... | [flush->[Strings,Write,Create,Marshal,Now,UTC,Close,Errorf,Rename],persist->[flush,Err,Debug],States->[RUnlock,RLock],Shutdown->[Do,Wait],read->[IsNotExist,Unmarshal,ReadFile],run->[Reset,Stop,Unlock,NewTimer,persist,Lock,Done],read,Add,run] | flush flushes the checkpoint to disk. | maybe add Info message (at least) about directory/file being created. |
@@ -135,7 +135,7 @@ func (j JobSpec) NewRun(i Initiator) JobRun {
ID: trid,
JobRunID: jrid,
TaskSpec: task,
- Result: RunResult{CachedTaskRunID: trid, CachedJobRunID: jrid},
+ Result: RunResult{},
}
}
| [IsLogInitiated->[IsLogInitiated],InitiatorExternal->[InitiatorsFor]] | NewRun creates a new JobRun from JobSpec and Initiator. | I feel like I just reached the end of a "shaggy dog" story. I thought the whole point was to get rid of this critter. Also, isn't `RunResult{}` the default value? (Could you delete it?) |
@@ -2860,7 +2860,7 @@ public class NetworkOrchestrator extends ManagerBase implements NetworkOrchestra
s_logger.debug("Implementing the network " + network + " elements and resources as a part of network restart without cleanup");
try {
implementNetworkElementsAndResources(dest, context, ... | [NetworkOrchestrator->[reallocate->[doInTransactionWithoutResult->[cleanupNics,allocate]],prepare->[implementNetwork],setupNetwork->[setupNetwork],removeNic->[release,releaseNic,removeNic],getElementForServiceInNetwork->[getProvidersForServiceInNetwork],setRestartRequired->[setRestartRequired],releaseNic->[doInTransact... | Checks if a network element and resources are available and restarts it if so. | This fixes an issue where restarting a network without cleanup always put the network's restart required flag to true. |
@@ -107,9 +107,11 @@ describe('integration test: a4a', () => {
{name: 'ad'}
);
adResponse = {
- headers: {'AMP-Access-Control-Allow-Source-Origin': 'about:srcdoc'},
body: validCSSAmp.reserialized,
};
+ if (!adResponse.headers) {
+ adResponse.headers = {};
+ ... | [No CFG could be retrieved] | integration test for AMP A4A Mocks the AMP ad in a friendly iframe. | Will this conditional ever not be true? |
@@ -669,8 +669,13 @@ func (b *Beat) configure(settings Settings) error {
}
if maxProcs := b.Config.MaxProcs; maxProcs > 0 {
+ logp.Info("Set max procs limit: %v", maxProcs)
runtime.GOMAXPROCS(maxProcs)
}
+ if gcPercent := b.Config.GCPercent; gcPercent > 0 {
+ logp.Info("Set gc percentage to: %v", gcPercent... | [launch->[InitWithSettings,createBeater],TestConfig->[InitWithSettings,createBeater],Setup->[InitWithSettings,Setup,createBeater],indexSetupCallback->[Setup],createBeater->[BeatConfig],configure->[BeatConfig],Init->[InitWithSettings]] | configure initializes the beacon with the given settings. Initialize the beacon configuration. | Is it worth logging if the value is 100? Being that its the default. |
@@ -2343,7 +2343,7 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati
if (cpuNumber != null && (cpuNumber.intValue() <= 0 || cpuNumber.longValue() > Integer.MAX_VALUE)) {
throw new InvalidParameterValueException("Failed to create service offering " + offeri... | [ConfigurationManagerImpl->[updateConfiguration->[start,updateConfiguration],commitVlan->[doInTransaction->[createVlanAndPublicIpRange]],deletePod->[checkIfPodIsDeletable],checkPodCidrSubnets->[getCidrAddress,getCidrSize],createPod->[createPod,checkPodAttributes],editPod->[editPod,podHasAllocatedPrivateIPs,checkPodAttr... | Creates a service offering. Creates a service offering with the specified parameters. create a new service offering object. Creates a service offering. This method is called to populate the command object with all the information that is needed to create. | @ustcweizhou similar cond check applicable for `cpuNumber` and `memory` if these are mandatory params? check and update accordingly. |
@@ -321,6 +321,12 @@ export class AmpA4A extends AMP.BaseElement {
* @private {boolean}
*/
this.isCollapsed_ = false;
+
+ /**
+ * The outer most iframe loaded by this ad slot.
+ * {?HTMLIframeElement}
+ */
+ this.iframe = null;
}
/** @override */
| [AmpA4A->[constructor->[AmpAdUIHandler,AmpAdXOriginIframeHandler,dev,generateSentinel,platformFor,protectFunctionWrapper,now,SAFEFRAME,cryptoFor],renderViaNameAttrOfXOriginIframe_->[NAMEFRAME,utf8Decode,dev,user,getContextMetadata,getDefaultBootstrapBaseUrl,stringify,SAFEFRAME,reject,length],verifyCreativeSignature_->[... | Initialize a new a with the required parameters. Private methods for parsing a missing - value header. 2 is the priority of the AMP creatives. | Outer most? Not sure I know what you mean. How about instead: "Frame in which the creative renders (friendly if validated AMP, xdomain otherwise)" |
@@ -57,7 +57,7 @@ void HAL_timer_start(const uint8_t timer_num, const uint32_t frequency) {
case 3: irq_num = NVIC_TIMER3; break;
case 4: irq_num = NVIC_TIMER4; break;
case 5: irq_num = NVIC_TIMER5; break;
- #ifdef STM32_HIGH_DENSITY
+ #if ENABLED(STM32_HIGH_DENSITY)
// 6 & 7 are basic timer... | [inline->[bb_perip],HAL_timer_disable_interrupt->[DISABLE_STEPPER_DRIVER_INTERRUPT,DISABLE_TEMPERATURE_INTERRUPT],HAL_timer_enable_interrupt->[ENABLE_STEPPER_DRIVER_INTERRUPT,ENABLE_TEMPERATURE_INTERRUPT],HAL_timer_interrupt_enabled->[timer_irq_enabled],get_timer_dev->[STM32_HAVE_TIMER],HAL_timer_start->[timer_pause,ti... | Hal timer start This function is called from the timer_init function. It is called by the timer_. | may "need" || defined(STM32_XL_DENSITY) here... but timer 8 is not used in marlin |
@@ -3311,6 +3311,7 @@ abstract class CommonObject
} elseif ($objecttype == 'contact') {
$module = 'societe';
}
+ }else $classpath = "$module/class";
// Set classfile
$classfile = strtolower($subelement); $classname = ucfirst($subelement);
| [CommonObject->[updateExtraField->[call_trigger],setSaveQuery->[isArray,isDuration,isDate,isInt,isFloat],fetchLinesCommon->[getFieldList,setVarsFromFetchObj],getBannerAddress->[getFullAddress,getFullName],line_ajaxorder->[updateRangOfLine],copy_linked_contact->[add_contact],update_note_public->[update_note],insertExtra... | Fetches all objects that are linked between two objects. Method to fetch all objects that link to the given object. This function is called to parse a single object into a module. This function is exported to the ExpeditionBon class. | Are you sure there is a } here ? |
@@ -95,7 +95,7 @@ module View
def other_trains(other_corp_trains)
other_corp_trains.flat_map do |other, trains|
- trains.map do |train|
+ trains.uniq(&:name).map do |train|
input = h(
:input,
style: {
| [BuyTrains->[from_depot->[h,new,format_currency,process_action,name,price,map],render_bankruptcy->[lambda,process_action,h,new],remaining_trains->[h,size,format_currency,first,price,map],render->[round,new,min_depot_price,discountable_trains_for,any?,lambda,name,sort_by,h,is_a?,format_currency,none?,concat,process_acti... | other_trains returns a list of other correlated train n - tuples. | how about trains.group_by(&:name).map do |train, trains| "Train #{train.name} ... #{trains.size}" |
@@ -60,12 +60,16 @@ public class KafkaEmitter implements Emitter
private final ObjectMapper jsonMapper;
private final MemoryBoundLinkedBlockingQueue<String> metricQueue;
private final MemoryBoundLinkedBlockingQueue<String> alertQueue;
+ private final MemoryBoundLinkedBlockingQueue<String> requestQueue;
pri... | [KafkaEmitter->[setKafkaProducer->[getKafkaProducerConfig,getName,putAll,getBootstrapServers,Properties,getContextClassLoader,getClassLoader,put,setContextClassLoader],sendAlertToKafka->[sendToKafka,getAlertTopic],start->[info,scheduleWithFixedDelay,get],sendToKafka->[send,take,getData,warn],emit->[offer,getClusterName... | Create a class that emits metrics and alerts to Kafka. This method increments the number of lost records in the metric alert or invalid records. | I would suggest to set this mixInAnnotation in `KafkaEmitterModule`. Please check `AvroExtensionsModule` as an example. |
@@ -46,9 +46,12 @@ func (bh *blobHandler) Delete(w http.ResponseWriter, req *http.Request) {
err := bh.Registry().Blobs().Delete(bh.Digest)
if err != nil {
- bh.Errors.PushErr(fmt.Errorf("error deleting blob %q: %v", bh.Digest, err))
- w.WriteHeader(http.StatusBadRequest)
- return
+ // Ignore PathNotFoundErro... | [Delete->[WriteHeader,PushErr,Blobs,Manifests,Name,Registry,Close,Delete,Errorf,Layers,Push],GetStringValue,HandlerFunc,ParseDigest] | Delete deletes a blob from the registry. | Worth a utility function, since you do this in multiple places? |
@@ -224,6 +224,10 @@ class LocalPantsRunner(ExceptionSink.AccessGlobalExiterMixin):
def set_start_time(self, start_time):
# Launch RunTracker as early as possible (before .run() is called).
self._run_tracker = RunTracker.global_instance()
+
+ # Propagates parent_build_id to pants runs that may be called... | [LocalExiter->[exit->[exit]],LocalPantsRunner->[_run->[exit,_compute_final_exit_code,_maybe_run_v1,_update_stats,_maybe_handle_help,_maybe_run_v2],_maybe_run_v1->[create],run->[wrap_global_exiter],create->[_maybe_init_graph_session,parse_options,_maybe_init_target_roots]]] | Sets the start time of the last run of the build. | I like this approach -- and it also addresses #8309 somewhat. |
@@ -336,7 +336,8 @@ class StreamingCache(CacheManager):
val = v.SerializeToString()
else:
val = v
- f.write(self._default_pcoder.encode(val) + b'\n')
+ self.save_pcoder(coders.registry.get_coder(type(val)), *labels)
+ f.write(self.load_pcoder(*labels).encode(val) + ... | [StreamingCacheSource->[read->[_wait_until_file_exists,_emit_from_file]],StreamingCacheSink->[expand->[StreamingWriteToText]],StreamingCache->[write->[exists,write],cleanup->[exists],exists->[exists],read_multiple->[StreamingCacheSource],clear->[exists],Reader->[_event_stream_caught_up_to_target->[_min_timestamp_of],re... | Writes the given values to the cache. | Why does the coder need to be saved for each value saved to the cache? Shouldn't the coders be known before the pipeline is run? |
@@ -377,7 +377,10 @@ class TorchGeneratorAgent(TorchAgent):
print('[ Saving dot beam logs in {} ]'.format(self.beam_dot_dir))
self.build_criterion()
- self.build_model()
+ with torch.random.fork_rng(range(torch.cuda.device_count())):
+ torch.manual_se... | [TorchGeneratorAgent->[_init_cuda_buffer->[_dummy_batch],compute_loss->[_model_input],beam_search->[reorder_encoder_states,_model_input,reorder_decoder_incremental_state],_write_beam_dots->[_v2t],eval_step->[decode_forced,reorder_encoder_states,compute_loss,_write_beam_dots,_v2t,_model_input],train_step->[_init_cuda_bu... | Initialize the object with the given options. Load a single from the model. | should we make this seed configurable? or is that too dangerous... |
@@ -126,7 +126,7 @@ def encode_boxes(reference_boxes, proposals, weights):
return targets
-class BoxCoder(object):
+class BoxCoder(nn.Module):
"""
This class encodes and decodes a set of bounding boxes into
the representation used for training the regressors.
| [Matcher->[__call__->[numel,max,clone,ValueError,set_low_quality_matches_],set_low_quality_matches_->[where,max]],SSDMatcher->[__call__->[size,arange,super,max],__init__->[super]],retrieve_out_channels->[OrderedDict,train,parameters,size,eval,values,no_grad,isinstance,zeros,next,model],BalancedPositiveNegativeSampler->... | Creates a binary mask from indices of the given reference boxes and a set of sequences of the This function calculates the target and target coordinates of the proposals. | This class with its encode/decode methods does not play nice with the nn.Module's forward() approach. Not sure if we should convert it but it will allow us to drop its declarations to `__annotations__` |
@@ -97,6 +97,9 @@ export class AmpImg extends BaseElement {
this.img_,
/* opt_removeMissingAttrs */ true
);
+ if (mutations['img-sizes'] || mutations['sizes']) {
+ this.propagateSizes();
+ }
guaranteeSrcForSrcsetUnsupportedBrowsers(this.img_);
}
}
| [No CFG could be retrieved] | Replies the current width used by the automatically generated sizes attribute. The main method of the class. | If the intention is for `img-sizes` to be bindable, this will also need to be added to the list of bindable attributes for `amp-img`. Also add this attribute to the validator. |
@@ -20,9 +20,7 @@ import org.apache.hadoop.test.GenericTestUtils;
import org.junit.Assert;
import org.junit.Test;
-import java.util.concurrent.CompletableFuture;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.TimeoutException;
+import java.util.concurrent.*;
/**
* Test for Resourc... | [TestResourceLimitCache->[testResourceLimitCache->[assertTrue,isDone,assertNotNull,sleep,waitFor,get,isCompletedExceptionally,assertNull,printStackTrace,cancel,remove,supplyAsync,put]]] | Test for ResourceLimitCache. This method blocks until the lock is released. | Nit: please avoid `*` import. |
@@ -342,6 +342,7 @@ out:
return rc;
}
+
static int
io_obj_iter_test(struct io_test_args *arg, daos_epoch_range_t *epr,
vos_it_epc_expr_t expr,
| [test_args_reset->[test_args_init],void->[gen_rand_epoch,test_args_reset,gen_oid,set_iov,inc_cntr,io_test_obj_fetch],test_args_init->[gen_oid],int->[gen_rand_epoch,test_args_reset,gen_oid,set_iov,inc_cntr,io_test_obj_fetch,io_test_obj_update],setup_io->[test_args_init]] | This function is used to iterate over all records in a key. private static final int DAOS_ITER_NEXT_OFFSET = 0 ; This function is called by the iterator_dkey_dkey_dkey_d probe a vos_iter_next object. | Nit - extra new line |
@@ -190,7 +190,8 @@ public class QuarkusTestExtension
@Override
protected ClassLoader getClassLoader() {
- return temp;
+ // this has been previously ... | [QuarkusTestExtension->[doJavaStart->[close->[close],run->[close]],ExtensionState->[close->[close,setCCL]],createTestInstance->[close,doJavaStart]]] | Creates the wiring classes for the required test class. Writes a resource of the specified name and data. This method is called when a new test is created. This method is called when a shutdown task is found. | Do we still need this class? Can it just use QuarkusClassWriter? |
@@ -10,6 +10,7 @@ internal static partial class Interop
{
internal const uint LMEM_FIXED = 0x0000;
internal const uint LMEM_MOVEABLE = 0x0002;
+ internal const uint LMEM_ZEROINIT = 0x0040;
[DllImport(Libraries.Kernel32)]
internal static extern IntPtr LocalAlloc(uint uFl... | [Interop->[Kernel32->[IntPtr->[Kernel32]]]] | Local alloc and re - alloc if it is found. | Should we just make these `GeneratedDllImport` too? Since we do the extern partial forwarder for blittable functions now. |
@@ -85,11 +85,12 @@ class Docker(Storage):
image_tag: str = None,
env_vars: dict = None,
files: dict = None,
- base_url: str = None,
prefect_version: str = None,
local_image: bool = False,
ignore_healthchecks: bool = False,
secrets: List[str] = None,... | [Docker->[pull_image->[_get_client],_build_image->[build],push_image->[_get_client]]] | Initialize a new object. Initialize the object with base image and dockerfile. | Do you know if objects of type `TLSConfig` are pickeable? |
@@ -81,10 +81,12 @@ IV = make_plot('IV', 'xiv', 'yiv')
grid = GridPlot(children=[[I, II], [III, IV]], width=800)
-sess = session.HTMLFileSession("anscombe.html")
-sess.add_plot(grid)
+doc = Document( )
+doc.add(grid)
if __name__ == "__main__":
- sess.save()
- print("Wrote %s" % sess.filename)
- sess... | [make_plot->[Circle,LinearAxis,append,Line,Plot,Grid,Glyph],ColumnDataSource,Range1d,make_plot,dict,print,HTMLFileSession,linspace,DataFrame,GridPlot,save,view,add_plot] | Create a grid plot with the given children. | I don't see this as an improvement over the previous approach. Really, this should just read `doc.html("Anscombe's Quartet", INLINE).write(filename).view()`, where `.html()` returns instance of `HTML` class and `.write()` returns instance of `HTMLFile` class (each with appropriate methods). Lets take advantage OOP and ... |
@@ -15,6 +15,11 @@ class H2OAutoML(object):
:param int nfolds: Number of folds for k-fold cross-validation. Defaults to 5. Use 0 to disable cross-validation; this will also
disable Stacked Ensemble (thus decreasing the overall model performance).
+ :param bool balance_classes: Balance training data cl... | [H2OAutoML->[predict->[predict,print,_fetch,get_model],train->[remove,list,H2OValueError,dict,print,api,poll,H2OJob,assert_is_type,is_type,ValueError,set,add,_fetch],leader->[get_model],__init__->[str,print,api,assert_is_type],_get_params->[api],_fetch->[api,H2OFrame,len],leaderboard->[H2OFrame]]] | A function that automates the supervised machine learning model training process. This feature is not recommended for the specified number of models. | Docs say default is `false` but the constructor has it set to `True` |
@@ -86,6 +86,9 @@ exports.rules = [
{
filesMatching: 'extensions/**/*.js',
mustNotDependOn: 'src/service/**/*.js',
+ whitelist: [
+ 'extensions/amp-analytics/0.1/visibility-impl.js->src/service/viewer-impl.js'
+ ],
},
{
filesMatching: 'extensions/**/*.js',
| [No CFG could be retrieved] | filesMatching - > list of files that should be included in the result. | Why? This shouldn't be needed. |
@@ -160,11 +160,11 @@ function handleActivation(finalEndpoint, target) {
`Could not complete system share. Navigator unavailable. ${NAME}`
);
}
- } else if (protocol === 'sms') {
+ } else if (protocol === 'sms' || protocol === 'mailto') {
openWindowDialog(
window,
- finalEndpoin... | [No CFG could be retrieved] | Handles key presses on a window with the fully processed endpoint. This method is called when the user presses SPACE or ENTER. | I also expected this logic to be symmetrically removed from AMP's side. No? |
@@ -1354,6 +1354,7 @@ export class AmpStoryPage extends AMP.BaseElement {
}
this.switchTo_(pageId, NavigationDirection.PREVIOUS);
+ this.storeService_.dispatch(Action.TOGGLE_PAUSED, false);
}
/**
| [AmpStoryPage->[setState->[NOT_ACTIVE,BOOKEND_STATE,dev,PAUSED,PLAYING],isAutoplaySupported_->[resetIsAutoplaySupported,getMode,isAutoplaySupported],constructor->[resolve,timerFor,getAmpdoc,NOT_ACTIVE,getStoreService,mutatorForDoc,resourcesForDoc,platformFor,promise,getMediaPerformanceMetricsService,debounce,reject],em... | the previous navigation item in the list. | Nit: here and below, can you invert these two lines? Unpausing the story before the switchTo will run a bit less code and go through the usual (and better tested) code path. Not a big deal |
@@ -43,8 +43,14 @@ public class PowerOperationTask implements Runnable {
try {
service.executePowerOperation(host, powerOperation, null);
} catch (Exception e) {
- LOG.warn(String.format("Out-of-band management background task operation=%s for host id=%d failed with: %s",
- ... | [PowerOperationTask->[toString->[format,getName,getId],run->[getMessage,executePowerOperation,format,warn,getId,name],getLogger]] | This method is invoked when the background thread is running. | In general in CloudStack we try to not log the 'hostid' as it doesn't say anything. The ID can only be fetched from the DB and not from the API and thus UI. |
@@ -1052,7 +1052,8 @@ describe("basic usage", function() {
it('should call the error callback if provided on non 2xx response', function() {
$httpBackend.expect('GET', '/CreditCard/123').respond(ERROR_CODE, ERROR_RESPONSE);
- CreditCard.get({id:123}, callback, errorCB);
+ var ccs = CreditCard.ge... | [No CFG could be retrieved] | Check if the is an array. on query should add a suffix. | I certainly don't like the fact that (even if an error callback is provided) an error will be reported in the console. |
@@ -1804,6 +1804,14 @@ public /*transient*/ abstract class Computer extends Actionable implements Acces
public static final Permission CONNECT = new Permission(PERMISSIONS,"Connect", Messages._Computer_ConnectPermission_Description(), DISCONNECT, PermissionScope.COMPUTER);
public static final Permission BUILD... | [Computer->[getDescription->[getNode],getActions->[getActions],getACL->[getACL],isOnline->[isOffline],relocateOldLogs->[getName,relocateOldLogs],getMonitorData->[getName],setNode->[getNumExecutors],_doScript->[getChannel,getACL,_doScript],updateByXml->[getNode],remove->[remove],waitUntilOnline->[isOnline],waitUntilOffl... | Permission for the Computer. | Extended Read is implied by Configure, so all of this is unnecessary. |
@@ -124,11 +124,8 @@ public class FlowTestCase extends AbstractFlowConstructTestCase {
@Override
protected boolean test() throws Exception {
- // While a SedaService returns null, a Flow echos the request when there is async hand-off
- assertEquals(event.getMessage(), response.getMessage()... | [FlowTestCase->[doSetUp->[then,getArguments,doSetUp,addMessageProcessorPathElements,any,build,mock,setMessageSource,StringAppendTransformer,getSensingNullMessageProcessor,setMessageProcessors,add,Flow,ResponseMessageProcessorAdapter],testProcessOneWayEndpoint->[test->[getValue,getMessage,assertNotSame,currentThread,get... | Test if a one - way endpoint is received. | why the the change from "abc" to "abcdef?" |
@@ -282,7 +282,6 @@ function message_content(App $a)
$messages = DBA::toArray($messages_stmt);
DBA::update('mail', ['seen' => 1], ['parent-uri' => $message['parent-uri'], 'uid' => local_user()]);
- DBA::update('notify', ['seen' => 1], ['type' => Type::MAIL, 'parent' => $message['id'], 'uid' => local_user()]... | [message_post->[getCommand,t,redirect],message_init->[t,get],message_content->[getItemsPerPage,redirect,get,getQueryString,renderFull,getStart,t],render_messages->[t,tt]] | message_content - message content This function is called when a message is not sent to a user. It will also send This function is called from the administration page. It returns a string with the list of This function is called when the user is authenticated and the user is not authenticated. | Why did you remove this code? |
@@ -35,7 +35,8 @@ import java.util.concurrent.atomic.AtomicReference;
import org.junit.Test;
-public class PolicyTestCase extends MuleArtifactFunctionalTestCase {
+//TODO MULE-12760 Make this test extend MuleArtifactFunctionalTestCase
+public class PolicyTestCase extends FunctionalTestCase {
private static fi... | [PolicyTestCase->[addBuilders->[addBuilders],TestPolicyProvider->[initialise->[getPolicyFromRegistry]]]] | Returns the configuration file name. | Why is this required? |
@@ -313,6 +313,7 @@ public class DefaultMuleMessageTestCase extends AbstractMuleContextTestCase
private DefaultMuleMessage createMuleMessage()
{
+ // TODO MULE-9856 Replace with the builder
DefaultMuleMessage previousMessage = new DefaultMuleMessage("MULE_MESSAGE", DataType.STRING_DATA_TYPE,... | [DefaultMuleMessageTestCase->[testInboundPropertyNamesAddImmutable->[createMuleMessage],testOutboundPropertyNamesRemoveMmutable->[createMuleMessage],testOutboundPropertyNamesImmutable->[createMuleMessage],testInboundPropertyNamesRemoveMmutable->[createMuleMessage],copyProperty->[createMuleMessage,copyProperty],testProp... | create a MuleMessage with no test attributes. | Why not mutable in this case? |
@@ -17,8 +17,9 @@ const whiteSpaces = " \t"
// DefaultEnvVariables returns a default environment, with $PATH and $TERM set.
func DefaultEnvVariables() map[string]string {
return map[string]string{
- "PATH": "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
- "TERM": "xterm",
+ "PATH": "/usr/lo... | [Wrapf,Text,TrimSuffix,ContainsAny,Sprintf,Close,Environ,Errorf,Open,LookupEnv,HasSuffix,Scan,HasPrefix,Err,NewScanner,SplitN,TrimLeft] | Slice returns a default environment with the specified key and value. parseEnv parses the environment variables in the file and returns the environment variables and an error if. | Will tvis work,if the OCI image has explicit PATH env variable with exact this value? |
@@ -148,7 +148,7 @@ class Telegram(RPC):
elif msg['type'] == RPCMessageType.SELL_NOTIFICATION:
msg['amount'] = round(msg['amount'], 8)
- msg['profit_percent'] = round(msg['profit_percent'] * 100, 2)
+ msg['profit_percent'] = round(msg['profit_ratio'] * 100, 2)
... | [authorized_only->[wrapper->[int,exception,command_handler,get,info]],Telegram->[_count->[debug,tabulate,str,_rpc_count,_send_msg,format,items],_stop->[_send_msg,_rpc_stop,format],_reload_conf->[_rpc_reload_conf,_send_msg,format],_stopbuy->[_send_msg,format,_rpc_stopbuy],_status->[_rpc_trade_status,append,_status_table... | Send a message to the telegram channel This function sends a message to the client and checks if a node has a node with a. | Why change it on the right hand side, but not on the left? while it's passed to the message below - it's not visible to the user after it's converted to the message... |
@@ -41,8 +41,14 @@ public class ParseTemplateProcessor extends SimpleMessageProcessor {
if (location == null) {
throw new IllegalArgumentException("Location cannot be null");
}
- content = IOUtils.getResourceAsString(location, this.getClass());
-
+ content = getResourceAsString(location... | [ParseTemplateProcessor->[process->[evaluateCorrectArguments]]] | load content from location. | Is this really so wrong? You'll be using ANY if not BINARY |
@@ -139,6 +139,9 @@ function assetsForVersion (version, validatingRelease) {
'electron-api.json',
'electron.d.ts',
'hunspell_dictionaries.zip',
+ 'libc++.zip',
+ 'libcxx_headers.zip',
+ 'libcxxabi_headers.zip',
`ffmpeg-${version}-darwin-x64.zip`,
`ffmpeg-${version}-darwin-arm64.zip`,
... | [No CFG could be retrieved] | This package provides a way to zip all the possible modules that are installed on the system. This package provides a way to zip all of the possible sequence numbers. | For consistency we should probably ensure this zip is called `libcxx.zip`. But we should probably call it something more descriptive. `libcxx_objects.zip` is probably closer to the truth. Also this artifact has to be per-platform so it will be similar to the other templated files in this list `libcxx-${version}-platfor... |
@@ -514,7 +514,7 @@ module AutomatedTestsHelper
run_dir = MarkusConfigurator.markus_ate_test_run_directory
- m_logger.log("error with launching test, error: #{stderr} and status: #{status}\n src_dir: #{src_dir}\ntest_dir: #{test_dir}\nserver: #{server}\ntest_runner: #{test_runner}\nrun_dir: #{run_dir}",... | [export_repository->[export,markus_config_automated_tests_repository,exist?,rm_rf,message,repo_name,join,mkdir],create_test_repo->[short_identifier,markus_config_automated_tests_repository,exist?,join,mkdir],launch_test->[capture3,markus_ate_test_run_directory,scripts_to_run,basename,to_i,write,repository_folder,markus... | Create a new instance of the class with the given options. | Line is too long. [222/80] |
@@ -18,7 +18,9 @@
Test script for the demos.
For the tests to work, the test data directory must contain a "ILSVRC2012_img_val"
-subdirectory with the ILSVRC2012 dataset.
+subdirectory with the ILSVRC2012 dataset, a "BraTS" subdirectory with BraTS 2017
+dataset in NIFTI format and "Image_Retrieval" subdirectory wit... | [main->[option_to_args->[resolve_arg],collect_result,option_to_args,parse_args],parse_args->[parse_args],main] | Parses command line options and returns a single object representing a single object. Parse command line options for the model optimization entry point script. | This doesn't explain anything. What _is_ the image retrieval dataset? |
@@ -189,6 +189,12 @@ var interfaceConfig = {
*/
AUTO_PIN_LATEST_SCREEN_SHARE: 'remote-only'
+ /**
+ * The link to the user documentation.
+ */
+ // HELP_LINK: 'https://docs.example.com/video-meetings.html',
+
+
/**
* How many columns the tile view can expand to. The respected range... | [No CFG could be retrieved] | Displays the list of recent video objects. The main method of the application. | Why don't we have a static HTML file or something on jitsi.org by default? |
@@ -193,15 +193,12 @@ public class KafkaRecordSupplier implements RecordSupplier<Integer, Long>
private KafkaConsumer<byte[], byte[]> getKafkaConsumer()
{
+ final Map<String, Object> consumerConfigs = KafkaConsumerConfigs.getConsumerProperties();
final Properties props = new Properties();
-
- props.s... | [KafkaRecordSupplier->[poll->[poll],assign->[assign],seek->[seek],getKafkaConsumer->[addConsumerPropertiesFromConfig],close->[close],getLatestSequenceNumber->[seek,seekToLatest],getEarliestSequenceNumber->[seek,seekToEarliest]]] | Returns a KafkaConsumer instance if there is no consumer available. | This should be called after KafkaRecordSupplier.addConsumerPropertiesFromConfig |
@@ -474,6 +474,14 @@ class ConanClientConfigParser(ConfigParser, object):
except ConanException:
return None
+ @property
+ def package_install_folder(self):
+ try:
+ fix_id = self.get_item("general.package_install_folder")
+ return fix_id.lower() in ("1", "true... | [ConanClientConfigParser->[hooks->[_get_conf],logging_level->[get_item],request_timeout->[get_item],print_commands_to_output->[get_item],default_python_requires_id_mode->[get_item],cacert_path->[get_item],download_cache->[get_item],default_profile->[get_item],relax_lockfile->[get_item],storage_path->[_get_conf],retry->... | Returns True if the package has a full transitive package ID False otherwise. | I'd use a verb here, `use_package_install_folder`, I think it helps to understand the code where it is used. |
@@ -129,5 +129,6 @@ namespace NServiceBus
License license;
static ILog Logger = LogManager.GetLogger(typeof(LicenseManager));
+ static HttpClient httpClient = new HttpClient();
}
}
\ No newline at end of file
| [LicenseManager->[InitializeLicense->[HasLicenseExpired],PromptUserForLicenseIfTrialHasExpired->[HasLicenseExpired],License->[HasLicenseExpired],HasLicenseExpired->[HasLicenseExpired]]] | License Manager. | How many times do we do the call home call? Does it make sense to keep the http client statically around forever? |
@@ -91,7 +91,8 @@ class TestDeployVirtioSCSIVM(cloudstackTestCase):
cls.apiclient = testClient.getApiClient()
cls.services = cls.testClient.getParsedTestDataConfig()
- cls.hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
+ ... | [TestDeployVirtioSCSIVM->[test_06_verify_guest_lspci_again->[verifyGuestState],setUpClass->[Templates],test_02_verify_libvirt_after_restart->[verifyVirshState],test_05_change_vm_ostype_restart->[verifyVirshState],test_01_verify_libvirt->[verifyVirshState],test_04_verify_guest_lspci->[verifyGuestState],test_03_verify_li... | Set up the class variables Create a new VM. | strange place for a line break |
@@ -1023,6 +1023,13 @@ namespace System
index = ci.IndexOf(this, oldValue, startIndex, this.Length - startIndex, options, &matchLength);
if (index >= 0)
{
+ // There's the possibility that 'oldValue' has zero collation weight (empty string equivalent... | [String->[PadRight->[PadRight],SplitInternal->[Format,SplitInternal],ToUpper->[ToUpper],ToLowerInvariant->[ToLower],PadLeft->[PadLeft],Join->[Join],Replace->[Replace],ToUpperInvariant->[ToUpper],CreateTrimmedString->[InternalSubString],JoinCore->[FillStringChecked,JoinCore],Split->[SplitInternal],Concat->[Concat,FillSt... | This method is used to replace the value of a string in this string with the new value. | After seeing the customer scenario, it may be better to just return from the method without throwing. what you think? |
@@ -306,7 +306,10 @@ obj_layout_create(struct dc_object *obj, bool refresh)
int rc;
pool = dc_hdl2pool(dc_cont_hdl2pool_hdl(obj->cob_coh));
- D_ASSERT(pool != NULL);
+ if(pool == NULL) {
+ D_DEBUG(DB_PL, "Cannot find valid pool\n");
+ D_GOTO(out, rc = -DER_NO_HDL);
+ }
map = pl_map_find(pool->dp_pool, obj... | [No CFG could be retrieved] | Create a container of object from a COB or COB link. Fill object with object layout. | (style) space required before the open parenthesis '(' |
@@ -266,13 +266,8 @@ namespace Microsoft.WebAssembly.Diagnostics
private static SyntaxNode GetExpressionFromSyntaxTree(SyntaxTree syntaxTree)
{
CompilationUnitSyntax root = syntaxTree.GetCompilationUnitRoot();
- ClassDeclarationSyntax classDeclaration = root.Members.ElementAt(0... | [EvaluateExpression->[CompileAndRunTheExpression->[VisitInternal,ResolveElementAccess,ResolveMethodCalls,ResolveIdentifiers,ResolveMemberAccessExpressions],FindVariableNMethodCall->[GetTypeFullName->[ConvertJSToCSharpType],Visit->[Visit]]]] | Get the expression from the syntax tree. | replace calls to this with GetCompilationUnitRoot()? |
@@ -272,6 +272,18 @@ public class SparkInterpreter extends Interpreter {
conf.set(key, val);
}
}
+
+ //TODO(jongyoul): Move these codes into PySparkInterpreter.java
+ String zeppelinHome = getSystemDefault("ZEPPELIN_HOME", "zeppelin.home", "../");
+ File zeppelinPythonLibPath = new Fil... | [SparkInterpreter->[getProgress->[getJobGroup],interpretInput->[toString,interpret],getSQLContext->[useHiveContext,getSparkContext],getProgressFromStage_1_0x->[getProgressFromStage_1_0x],getProgressFromStage_1_1x->[getProgressFromStage_1_1x],close->[close],cancel->[getJobGroup],open->[getDependencyResolver,getSQLContex... | Create a new SparkContext with the specified configuration. if key and val are missing return a SparkContext object. | Actually, we can use pyspark with only setting these configurations. |
@@ -811,12 +811,7 @@ function admin_page_site_post(App $a) {
set_config('system','worker_dont_fork', $worker_dont_fork);
set_config('system','worker_fastlane', $worker_fastlane);
set_config('system','frontend_worker', $worker_frontend);
-
- if (($rino == 2) and !function_exists('mcrypt_create_iv')) {
- notice(t(... | [admin_page_summary->[database_name,server_info],admin_page_site_post->[set_baseurl,get_path],admin_page_site->[get_hostname,get_path],admin_page_users->[set_pager_itemspage,set_pager_total]] | This function is called when the user is redirected to the admin_site page. update all tables with data from database This function is called when the user is redirected to a page that is not a page. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Function to parse the parameters that are passed... | Standards: Can you please add a space after commas? |
@@ -81,6 +81,9 @@ public class PutFile extends AbstractProcessor {
public static final String FILE_MODIFY_DATE_ATTRIBUTE = "file.lastModifiedTime";
public static final String FILE_MODIFY_DATE_ATTR_FORMAT = "yyyy-MM-dd'T'HH:mm:ssZ";
+
+ public static final Pattern RWX_PATTERN = Pattern.compile("^([r-]... | [PutFile->[init->[add,unmodifiableList,unmodifiableSet],stringPermissions->[parseInt,append,matches,toString,compile,StringBuilder],onTrigger->[getValue,getParent,getElapsed,renameTo,SimpleDateFormat,toString,warn,setLastModified,info,toFile,setGroup,setPosixFilePermissions,setOwner,getTime,lookupPrincipalByGroupName,g... | A class that implements a put file operation. MISSING_RESOLUTION - Replace all resolutions with the same name. IGNORE_RESOLUTION. | Should we use more strict regex? Such as `^\d+$` or even `^[0-7]{3}$`? |
@@ -117,7 +117,17 @@ public class UserService {
log.debug("Created Information for User: {}", newUser);
return newUser;
}
-
+ public User createUser(User user) {
+ String encryptedPassword = passwordEncoder.encode(RandomUtil.generatePassword());
+ user.setPassword(encryptedPasswo... | [No CFG could be retrieved] | Method to update user information. Gets user with authorities by login. | I think you need to differentiate here between mongo/sql and cassandra. Cassandra requires a plain `java.util.Date` |
@@ -7,7 +7,7 @@ describe 'verify/review/new.html.slim' do
before do
user = build_stubbed(:user, :signed_up)
allow(view).to receive(:current_user).and_return(user)
- allow(view).to receive(:idv_params).and_return(
+ @idv_params = {
first_name: 'Some',
last_name: 'One',
... | [context,include,to,have_content,have_xpath,parse,describe,build_stubbed,before,have_link,generate_class_selector,t,it,require,and_return] | This example shows how to render a page with a page with a page with a page with expects the markup of the idv. messages. review. financial_info. | is it more common to use `assign(:idv_params, ...)` ? Does it matter? |
@@ -377,6 +377,14 @@ class IStrategy(ABC, HyperStrategyMixin):
# END - Intended to be overridden by strategy
###
+ def gather_informative_pairs(self) -> ListPairsWithTimeframes:
+ """
+ Internal method which gathers all informative pairs (user or automatically defined).
+ """
+ inform... | [IStrategy->[lock_pair->[lock_pair],is_pair_locked->[is_pair_locked],_analyze_ticker_internal->[analyze_ticker],should_sell->[SellCheckTuple],advise_indicators->[populate_indicators],analyze->[analyze_pair],advise_buy->[populate_buy_trend],unlock_pair->[unlock_pair],advise_sell->[populate_sell_trend],stop_loss_reached-... | Returns strategy class name. | I would propose a 2-level approach for this method. While `informative_pairs()` might return different values each time - the informative decorator won't. As such - we can store the values for the decorator-level "informative" pairs after the first call - and avoid iterating throught he whole class dict every time. Pot... |
@@ -27,6 +27,18 @@ var useHttps = argv.https != undefined;
* Starts a simple http server at the repository root
*/
function serve() {
+ // Get the serve mode
+ if (argv.compiled) {
+ process.env.SERVE_MODE = 'min';
+ util.log(util.colors.green('Serving minified js'));
+ } else if (argv.cdn) {
+ process... | [No CFG could be retrieved] | Starts a simple http server for a given Specifies alternative host and port. | Could we make this changeable at runtime? |
@@ -38,12 +38,9 @@ func newMuxer(config Config, report reporter) *http.ServeMux {
mux := http.NewServeMux()
for path, p := range processor.Registry.Processors() {
-
- handler := createHandler(p, config, report)
-
+ handler := appHandler(p, config, report)
logp.Info("Path %s added to request handler", path)
-... | [ConstantTimeCompare,Close,Inc,Info,Add,ListenAndServeTLS,Error,Marshal,Validate,New,NewServeMux,Errorf,HandleFunc,Debug,Contains,Transform,isEnabled,Shutdown,ListenAndServe,Get,Split,Err,Header,Write,NewReader,WithTimeout,Background,Processors,LimitReader,NewInt,NewRegistry,ReadAll,WriteHeader] | newMuxer returns a muxer that serves the given token. run starts the apm - server and then stops it. | This change just made me realise that we don't check the token for the `/healthcheck` handler I think? |
@@ -1,12 +1,4 @@
-using Content.Shared.Audio;
-using Robust.Server.GameObjects;
-using Robust.Shared.Audio;
using Robust.Shared.GameObjects;
-using Robust.Shared.IoC;
-using Robust.Shared.Player;
-using Robust.Shared.Prototypes;
-using Robust.Shared.Random;
-using Robust.Shared.Serialization.Manager.Attributes;
nam... | [FootstepModifierComponent->[PlayFootstep->[Play,Coordinates,_prototypeManager,Pick,PickFiles,WithVolume,IsNullOrWhiteSpace,Pvs]]] | FootstepModifierComponent is a base class for the FootstepModifierComponent. It is. | this got also modified, to try and be consistent |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.