patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -274,6 +274,17 @@ class File(OnChangeMixin, ModelBase):
else:
return self.file_path
+ @property
+ def fallback_file_path(self):
+ """Fallback path in case the file was disabled/re-enabled and not yet
+ moved - sort of the opposite to current_file_path. This should only be
... | [check_file->[unhide_disabled_file,hide_disabled_file],update_status->[update_status],File->[unhide_disabled_file->[move_file],hide_disabled_file->[move_file]],update_status_delete->[update_status],FileUpload->[add_file->[save],from_post->[add_file,FileUpload]]] | Returns the current path of the file whether or not it is guarded. | couldn't we just always try `self.file_path` and then `self.guarded_file_path`. I'm not sure this extra logic gives us much (apart from one possible attempt at loading a file from the file system which would then fail. |
@@ -98,8 +98,8 @@ class ConfigureEnvironment(object):
@property
def command_line_env(self):
- if self.os == "Linux" or self.os == "Macos" or self.os == "FreeBSD":
- if self.compiler == "gcc" or "clang" in str(self.compiler):
+ if self.os == "Linux" or self.os == "Macos" or self.os =... | [ConfigureEnvironment->[command_line_env->[_gcc_env]]] | Returns a command line environment variable for the specified compiler. Get command to set environment variables. | `"cc" == self.compiler` better than `"cc" in str(self.compiler)` Could be error prone. But I agree with @memsharded calling it sun-cc or something like that. |
@@ -1863,10 +1863,10 @@ void ServerMap::endSave()
bool ServerMap::saveBlock(MapBlock *block)
{
- return saveBlock(block, dbase);
+ return saveBlock(block, dbase, m_map_compression_level);
}
-bool ServerMap::saveBlock(MapBlock *block, MapDatabase *db)
+bool ServerMap::saveBlock(MapBlock *block, MapDatabase *db, i... | [No CFG could be retrieved] | Creates a new database object for the given block. Load a single MapBlock from a byte string. | ~~why does it need to be possible to call saveBlock with a custom compression level?~~ nvm, this is because `saveBlock(MapBlock *block)` is static |
@@ -134,10 +134,10 @@ dc_obj_verify_fetch(struct dc_obj_verify_args *dova)
dova->fetch_sgl.sg_nr_out = 1;
dova->fetch_sgl.sg_iovs = &dova->fetch_iov;
- rc = dc_obj_fetch_shard_task_create(dova->oh, dova->th,
- DIOF_TO_SPEC_SHARD, dc_obj_anchor2shard(&dova->dkey_anchor),
- &cursor->dkey, 1, iod, &dova->fetch_sgl... | [No CFG could be retrieved] | Reads the data from the DAO and populates the object fields. Check if the given dkey exists in the given list of shards. | this case still use the ptr point to stack variable, although not a real problem for now as "dc_task_schedule(task, true)" below and current tse behavior. just a note for following refine if needed. |
@@ -118,7 +118,7 @@ int WiFiUDP::available() {
if (!result) {
// yielding here will not make more data "available",
// but it will prevent the system from going into WDT reset
- optimistic_yield(1000);
+ optimistic_yield(100UL);
}
return result;
| [stopAll->[stop],write->[write],peek->[peek],stopAllExcept->[stop],beginPacket->[beginPacket],read->[read],flush->[endPacket]] | Checks if there is a free chunk of data available in the network. | (here and other spots) In #6869 you'd suggested a happy medium of `10000` us. I think it needs to be consistent here and elsewhere. The `100` that's in these spots seems like it will always fire because the delay is so small, and because they're not "yield to the OS" but instead "don't WDT" it seems like we'd benefit f... |
@@ -53,12 +53,17 @@ public abstract class AbstractWSConsumerFunctionalTestCase extends FunctionalTes
protected void doSetUpBeforeMuleContextCreation() throws Exception
{
System.setProperty(USE_TRANSPORT_FOR_URIS, Boolean.toString(useTransportForUris));
+
+ final Logger xmlLogger = Logger.getLo... | [AbstractWSConsumerFunctionalTestCase->[assertValidResponse->[assertValidResponse],assertSoapFault->[assertSoapFault]]] | Override this method to set up the necessary properties before MuleContext creation. | Use a JUnit Rule for this |
@@ -3,10 +3,10 @@ import textwrap
from jinja2 import Template
from conan.tools._check_build_profile import check_using_build_profile
+from conan.tools.apple.apple import to_apple_arch
+from conan.tools.cross_building import cross_building, get_cross_building_settings
from conan.tools.env import VirtualBuildEnv
fr... | [MesonToolchain->[_to_meson_machine->[_render,_to_meson_value],_native_content->[_render],_cross_content->[_to_meson_machine,_render],__init__->[from_build_env],generate->[_write_cross_file,_write_native_file],_to_meson_value->[_to_meson_value],_context->[_to_meson_value]]] | Load a Meson - native version of a single . Generate a cross - file template for the given . | I don't think we should ever expose all these variables to the public. they are not supposed to be assigned to the random values from the outside. they only gain limited set of the values computed from the settings as the input. |
@@ -152,7 +152,7 @@ class CompressorTestCase(TestCase):
config_list = [{'sparsity': 0.2, 'op_types': ['BatchNorm2d']}]
model.bn1.weight.data = torch.tensor(w).float()
model.bn2.weight.data = torch.tensor(-w).float()
- pruner = torch_pruner.SlimPruner(model, config_list)
+ pruner... | [CompressorTestCase->[test_torch_slim_pruner->[TorchModel],test_torch_quantizer_validation->[TorchModel],test_torch_fpgm_pruner->[TorchModel],test_torch_level_pruner->[TorchModel],test_torch_quantizer_export->[TorchModel],test_torch_taylorFOweight_pruner->[TorchModel],test_torch_QAT_quantizer->[TorchModel],test_torch_q... | Test the Torch slim pruner. Check if there is a batch norm op in the model. | `optimizer` `trainer` `criterion` is necessary for SlimPruner and user needs to give three more `None` every time? |
@@ -284,6 +284,7 @@ def make_requests_insecure():
# Disable verification in requests by replacing the 'verify'
# attribute with non-writable property that always returns `False`
requests.Session.verify = property(lambda self: False, lambda self, val: None) # type: ignore
+ urllib3.disable_warnings(In... | [No CFG could be retrieved] | Create a new instance of the class. Reads the from the server directory and writes it to the config file. | From my point of view, calling `make_requests_insecure()` is bold enough, so we don't need to disable the warning explicitely. |
@@ -130,6 +130,16 @@ public class CreateTables<DestinationT, ElementT>
dynamicDestinations,
tableDestination,
destination);
+ boolean destinationCoderSupportsClustering =
+ !(dynamicDestinations.getDestinationCoder() instanceof TableDestinationCoderV2);
+ checkArgumen... | [CreateTables->[clearCreatedTables->[clear],expand->[getSideInputs,newArrayList,withSideInputs,apply,addAll],CreateTablesFn->[getTableDestination->[getTable,stripPartitionDecorator,tryCreateTable,checkArgument,isNullOrEmpty,getProjectId,clone,withTableReference,setProjectId,getTableSpec,contains,getProject],startBundle... | Gets the table destination for the given destination. | We cannot know at compile-time whether a custom table function or DynamicDestinations instance will produce any destination with clustering enabled, so we have to check the produced destinations at runtime. This check will cause a runtime failure for StreamingInserts if a clustered destination is produced without the r... |
@@ -386,10 +386,13 @@ public class HiveSource implements Source {
/**
* Check if workunit needs to be created. Returns <code>true</code> If the
- * <code>updateTime</code> is greater than the <code>lowWatermark</code>.
+ * <code>updateTime</code> is greater than the <code>lowWatermark</code> and <code>maxL... | [HiveSource->[shouldCreateWorkunit->[shouldCreateWorkunit],getCreateTime->[getCreateTime]]] | Returns true if the given time is after the given low watermark. | Is `updateTime` here the same as the partition value (i.e. the time corresponding to the partition value YYYY-MM-DD-HH)? If this is the last time the partition was updated, then I think you might still have a problem. For example, imagine 100 days of partitions are registered today and maxLookBackTime is 5 days ago. Th... |
@@ -53,12 +53,15 @@ describe('Logging', () => {
log: logSpy,
},
setTimeout: timeoutSpy,
+ reportError: error => error,
};
+ sandbox.stub(self, 'reportError', error => error);
});
afterEach(() => {
sandbox.restore();
sandbox = null;
+ window.AMP_MODE = undefined;
... | [No CFG could be retrieved] | Package that contains the functionality of the logging and logging functions. The following methods are defined in the section below. | Is this necessary? It appears the flaky test uses the fake window object, `win`. |
@@ -227,6 +227,8 @@ namespace Content.Client.Chat.Managers
// Necessary so that we always have a channel to fall back to.
DebugTools.Assert((SelectableChannels & ChatSelectChannel.OOC) != 0, "OOC must always be available");
DebugTools.Assert((FilterableChannels & ChatChannel.OOC) ... | [ChatManager->[CreateSpeechBubble->[CreateSpeechBubble]]] | Updates the selected channels and filters based on the current state. | Does LOOC need to be a fallback? |
@@ -25,6 +25,11 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include <cstring>
#include <cerrno>
#include <fstream>
+
+#ifdef _WIN32
+#include <direct.h>
+#endif
+
#include "log.h"
#include "config.h"
#include "porting.h"
| [No CFG could be retrieved] | Creates a new object of type cseqno with all of its fields filled with values from Find the first file in the directory. | There's an ifdef win32 a few lines below where you _could_ add this. |
@@ -374,7 +374,7 @@ resource "aws_wafv2_ip_set" "ip_set" {
scope = "REGIONAL"
ip_address_version = "IPV6"
addresses = [
- "0:0:0:0:0:ffff:7f00:1/64",
+ "1111:0000:0000:0000:0000:0000:0000:0111/128",
"1234:5678:9abc:6811:0000:0000:0000:0000/64",
"2001:db8::/32"
]
| [ParallelTest,StringValue,Meta,Sprintf,TestCheckResourceAttr,RootModule,ComposeTestCheckFunc,String,Errorf,RandString,GetIPSet,MustCompile] | Test for AWS WAF v2 IPSet testAccAwsWafv2IPSetConfigMinimal returns a string that can be. | If you enter `0:0:0:0:0:ffff:7f00:1/64` in the console it reports as `0000:0000:0000:0000:0000:0000:0000:0000/64` when you refresh. Replace with a more usual IPv6 CIDR. |
@@ -91,12 +91,13 @@ public class UntilSuccessful extends AbstractOutboundRouter implements UntilSucc
}
this.untilSuccessfulStrategy.setUntilSuccessfulConfiguration(this);
- if (untilSuccessfulStrategy instanceof Initialisable) {
- ((Initialisable) untilSuccessfulStrategy).initialise();
- }
i... | [UntilSuccessful->[initialise->[initialise],start->[start],stop->[stop],route->[route]]] | Initializes the message processor. | why not call `LifecycleUtils#initializeIfNeeded()`? It has a method that receives the muleContext to set. |
@@ -55,7 +55,10 @@ public class GlobalIgnoredTypesConfigurer implements IgnoredTypesConfigurer {
// clojure
builder.ignoreClass("clojure.").ignoreClass("$fn__");
- builder.ignoreClass("io.opentelemetry.javaagent.");
+ // this is to exclude javaagent helper classes that are injected into other class lo... | [GlobalIgnoredTypesConfigurer->[configureIgnoredClassLoaders->[ignoreClassLoader,getName],configureIgnoredTypes->[ignoreClass,allowClass],configureIgnoredTasks->[ignoreTaskClass],configure->[configureIgnoredClassLoaders,configureIgnoredTypes,configureIgnoredTasks]]] | Configures the ignored types. This method is called by the builder to build a specific object in order to instrument it. | Why is this here and not in `AgentInstaller`? I don't understand by what criterium we decide between these two locations. |
@@ -3161,15 +3161,8 @@ func TestEnableAggregatedAPIs(t *testing.T) {
}
func TestCloudControllerManagerEnabled(t *testing.T) {
- // test that 1.16 defaults to false
- cs := CreateMockContainerService("testcluster", "1.16.1", 3, 2, false)
- cs.setOrchestratorDefaults(false, false)
- if cs.Properties.OrchestratorProfi... | [EqualError,PutUint32,setTelemetryProfileDefaults,DeepEqual,setLinuxProfileDefaults,Activate,NewStringResponse,Diff,HasMultipleNodes,IsManagedDisks,setOrchestratorDefaults,GetAgentVMPrefix,SetCustomCloudProfileEnvironment,BoolPtr,Error,GreaterThanOrEqualTo,RegisterResponder,New,Errorf,Float64Ptr,HasAvailabilityZones,Lo... | TestDefaultCloudProvider tests that the cloud provider is enabled. unexpected cloud provider backoff. | this test is no longer relevant |
@@ -361,11 +361,11 @@ public class JDBCInterpreter extends Interpreter {
return new InterpreterResult(Code.SUCCESS, msg.toString());
- } catch (SQLException ex) {
- logger.error("Cannot run " + sql, ex);
- return new InterpreterResult(Code.ERROR, ex.getMessage());
- } catch (ClassNotFoundExce... | [JDBCInterpreter->[completion->[getPropertyKey],getStatement->[getConnection],executeSql->[getStatement,close],getConnection->[getConnection],close->[close],cancel->[cancel],interpret->[executeSql]]] | Execute the given SQL statement and fill in the necessary information. This method closes the connection and closes the connection. | How about adding `e.getStackTrace()` if `e.getMessage() != null`? |
@@ -115,7 +115,8 @@ def test_compiler_remove(mutable_config, mock_packages):
assert spack.spec.CompilerSpec("gcc@4.5.0") not in compilers
-@pytest.mark.skipif(sys.platform == 'win32', reason="Error on Win")
+@pytest.mark.skipif(str(spack.platforms.host()) == 'windows',
+ reason="Install hang... | [test_compiler_find_mixed_suffixes->[str,get_compiler_config,join,compiler,next],test_compiler_remove->[all_compiler_specs,Bunch,CompilerSpec,compiler_remove],test_compiler_find_without_paths->[write,compiler,as_cwd,chmod,str,open],mock_compiler_dir->[set_executable,write,ensure,str,copy,join],test_compiler_add->[all_c... | Test if a compiler is available. | Is the reason "Install hangs on windows" accurate or a copy + paste error? Similar for other tests in this file |
@@ -575,9 +575,8 @@ def install_unpacked_wheel(
# Record details of all files installed
record = os.path.join(dest_info_dir, 'RECORD')
- temp_record = os.path.join(dest_info_dir, 'RECORD.pip')
with open_for_csv(record, 'r') as record_in:
- with open_for_csv(temp_record, 'w+') as record_out:
+... | [_raise_for_invalid_entrypoint->[MissingCallableSuffix],install_unpacked_wheel->[record_installed->[normpath],clobber->[record_installed],open_for_csv,message_about_scripts_not_on_PATH,sorted_outrows,clobber,get_entrypoints,PipScriptMaker,get_csv_rows_for_installed,wheel_root_is_purelib],PipScriptMaker->[make->[_raise_... | Install a specific version of a wheel from a zip file. Compile a directory and return a object. Copy the file into destfile and check if it is a missing missing entry point. This function will generate a in all sub - directories of wheeldir datadir Override the versioned entry points in the wheel and generate the cor... | Any particular reason to change `w+` to `w`? |
@@ -492,10 +492,6 @@ const serverFiles = {
file: 'package/gateway/ratelimiting/RateLimitingFilter.java',
renameTo: generator => `${generator.javaDir}gateway/ratelimiting/RateLimitingFilter.java`
},
- {
- file: 'package/gateway/... | [No CFG could be retrieved] | This file contains all the files that are needed to run the Gateway. package. json. | Warning : this filter is still need for JWT authentificationType ( however it could be better implemented by specifying the correct zuul.ignoredHeaders in application.yml ) ( For me, it is only needed for JWT : - this pull request suppresses its need with the introduction of spring-cloud-security - in the UAA case, it ... |
@@ -563,7 +563,8 @@ public class ApiSurface {
private boolean pruned(Class<?> clazz) {
return clazz.isPrimitive()
|| clazz.isArray()
- || getPrunedPattern().matcher(clazz.getName()).matches();
+ || getPrunedPattern().matcher(clazz.getName()).matches()
+ || getPrunedPattern().matche... | [ApiSurface->[pruned->[pruned],Matchers->[ClassesInSurfaceMatcher->[matchesSafely->[verifyNoAbandoned,verifyNoDisallowed],describeTo->[describeTo],verifyNoAbandoned->[apply->[describeTo]]]],ofPackage->[ofPackage],empty->[ApiSurface],pruningPattern->[pruningPattern,ApiSurface],getSdkApiSurface->[pruningPrefix],including... | Check if the given class is pruned. | <!--new_thread; commit:24015ef7b454f06db498f24e45f10fc896683c1b; resolved:0--> I think this will be unreachable if pruning a namespaces adds a pattern that ends with a wildcard, since the class name always starts with the package name. |
@@ -259,7 +259,7 @@ public class Cli implements Closeable {
private void runScript(
final SqlBaseParser.SingleStatementContext statementContext,
final String statementText
- ) throws IOException {
+ ) {
final SqlBaseParser.RunScriptContext runScriptContext =
(SqlBaseParser.RunScriptCont... | [Cli->[setProperty->[setProperty],displayWelcomeMessage->[displayWelcomeMessage],readLine->[readLine],handlePrintedTopic->[close],unsetProperty->[printKsqlResponse,unsetProperty],build->[Cli,build],streamResults->[close],close->[close]]] | This method is called when a KSQL command is executed. | This method is not needed anymore! You can also remove it from the `handleStatements` method. |
@@ -154,10 +154,14 @@ class OutputBase(object):
return self.remote.exists(self.path_info)
def changed_checksum(self):
+ cs = self.checksum
+ if cs is None:
+ self.remote.update_state_checksum(self.path_info)
+ return True
return (
- self.checksum
+... | [OutputBase->[is_dir_checksum->[is_dir_checksum],isfile->[isfile],supported->[match],move->[move,commit,save],unprotect->[unprotect],commit->[save],download->[download],changed->[status],exists->[exists],status->[changed_checksum,changed_cache],changed_cache->[changed_cache],save->[OutputAlreadyTrackedError,changed],gr... | True if the checksum of the node has changed. | why is this needed? state is updated in `get_file_checksum` and `get_dir_checksum` already. |
@@ -601,9 +601,12 @@ class TorchGeneratorAgent(TorchAgent):
"""
Evaluate a single batch of examples.
"""
- if batch.text_vec is None:
+ if batch.text_vec is None and batch.image is None:
return
- bsz = batch.text_vec.size(0)
+ if batch.text_vec is not ... | [TorchGeneratorAgent->[_init_cuda_buffer->[_dummy_batch],compute_loss->[_model_input],eval_step->[_construct_token_losses,decode_forced,reorder_encoder_states,compute_loss,_v2t,_model_input],train_step->[_init_cuda_buffer,compute_loss],_generate->[_treesearch_factory,reorder_encoder_states,_model_input,reorder_decoder_... | Evaluate a single batch of examples and return a single . Compute the missing candidate for a single batch. | So we've got this in a bunch of places now. I'm wondering if life would be easier if batch world didn't give the agents padding examples, so that `is_valid` and checks like this could be completely removed. Opinions from the team? |
@@ -300,7 +300,8 @@ def test_setup_configuration_with_arguments(mocker, default_conf, caplog) -> Non
'backtesting',
'--ticker-interval', '1m',
'--live',
- '--realistic-simulation',
+ '--enable-position-stacking',
+ '--disable-max-market-positions',
'--refresh-pai... | [test_show_info->[log_has,Configuration,patch,mock_open,dumps,Arguments,get_config],test_load_config_with_params->[Configuration,load_config,patch,get,copy,mock_open,dumps,Arguments],test_check_exchange->[deepcopy,Configuration,get,check_exchange,Namespace,raises],test_configuration_object->[hasattr],test_load_config_i... | Test setup_configuration with arguments. Checks if log has a in config. | The name is probably correct but it's getting to be painfully long, should we have a shorter alias for it also? |
@@ -149,7 +149,9 @@ public class SpannerWriteIT {
@After
public void tearDown() throws Exception {
- databaseAdminClient.dropDatabase(options.getInstanceId(), databaseName);
+ if (databaseAdminClient != null) {
+ databaseAdminClient.dropDatabase(options.getInstanceId(), databaseName);
+ }
spa... | [SpannerWriteIT->[generateDatabaseName->[getDatabaseIdPrefix],tearDown->[getInstanceId],testWrite->[getTable,getInstanceId,getProjectId],setUp->[getTable,getInstanceId]]] | Tear down the database. | It seems like the NPE is fixed with just this line, perhaps? |
@@ -2113,6 +2113,12 @@ vos_update_begin(daos_handle_t coh, daos_unit_oid_t oid, daos_epoch_t epoch,
", flags="DF_X64"\n", DP_UOID(oid), iod_nr,
dtx_is_valid_handle(dth) ? dth->dth_epoch : epoch, flags);
+ rc = vos_check_akeys(iod_nr, iods);
+ if (rc != 0) {
+ D_ERROR("Detected duplicate akeys, operation not a... | [No CFG could be retrieved] | Dth DTOs vos_handle2ioh2desc - > vos_handle2ioh dcs_csum dcs_biod dcs_csum_ic_. | What is the benefit to check the duplicated akeys before the real update? That is n^n/2 checking. In fact, we have chance to detect the duplication when do the real update. On the other hand, the two entries may have same akey but with different exts, any trouble if we allow that? |
@@ -130,6 +130,9 @@ class PythonExecutionTaskBase(ResolveRequirementsTaskBase):
extra_pex_paths = [pex.path() for pex in pexes if pex]
+ if extra_pex_paths:
+ pex_info.pex_path = ':'.join(extra_pex_paths)
+
with safe_concurrent_creation(path) as safe_path:
builder = PEXB... | [WrappedPEX->[path->[path],run->[run],cmdline->[cmdline]],PythonExecutionTaskBase->[create_pex->[WrappedPEX,extra_requirements,path]]] | Creates a new pex that merges the other pexes via PEX_PATH. Get a missing pex object. | how about using the new `PexInfo.merge_pex_path()` method here instead of the if + set? |
@@ -5,6 +5,7 @@ representing a source file. Performs only minimal semantic checks.
"""
import re
+from inspect import cleandoc
from typing import List, Tuple, Set, cast, Union, Optional
| [parse->[parse],Parser->[skip_until_break->[current,skip],skip_until_next_line->[current,skip,skip_until_break],eol->[current],parse_type_comment->[parse_error_at],parse_try_stmt->[parse_block],parse_tuple_expr->[parse_expression],parse_decorated_function_or_class->[parse_class_def],parse_conditional_expr->[parse_expre... | Construct a parse tree based on a string containing a single unique identifier. A set of all possible values of the object. | This version of the parser is doomed, we'll remove it as soon as we can use the fast parser on all platforms. Maybe you could skip changing this file and just state that your feature depends on `--fast-parser`? |
@@ -137,12 +137,14 @@ public class SparkHoodieBloomIndex<T extends HoodieRecordPayload> extends SparkH
*/
private Map<String, Long> computeComparisonsPerFileGroup(final Map<String, Long> recordsPerPartition,
final Map<String, List<BloomIndexFileInfo>> p... | [SparkHoodieBloomIndex->[findMatchingFilesForRecordKeys->[explodeRecordRDDWithFileComparisons]]] | Computes the comparisons for each file group in the partition. | Change to : `Compute all comparisons needed between records and files` |
@@ -167,7 +167,7 @@ class S3Result(Result):
Bucket=self.bucket, Key=location.format(**kwargs)
).load()
except botocore.exceptions.ClientError as exc:
- if exc.response["Error"]["Code"] == "404":
+ if exc.response["Error"]["Code"] == "NoSuchKey":
... | [S3Result->[client->[initialize_client],read->[read]]] | Checks whether the target result exists in the S3 bucket. | Are we confident this is universally the error code we'll see? E.g., are there some configurations that might return `404`s? |
@@ -30,7 +30,7 @@ BuildRequires: python36-scons >= 2.4
%else
BuildRequires: scons >= 2.4
%endif
-BuildRequires: libfabric-devel >= %{libfabric_version}
+BuildRequires: libfabric-devel = %{libfabric_version}
BuildRequires: mercury-devel = %{mercury_version}
%if (0%{?rhel} < 8) || (0%{?suse_version} > 0)
BuildRequi... | [No CFG could be retrieved] | Define global variables for the DAOS service Check if a sequence number is not already in the list of possible values. | This (`=`) is really undesirable for similar reasons as below. |
@@ -309,6 +309,9 @@ int main(int argc, char **argv)
sprintf(str_rank, "%d", hostbuf->my_rank);
sprintf(str_port, "%d", hostbuf->ofi_port);
+ /* Set CRT_L_RANK and OFI_PORT */
+ setenv("CRT_L_RANK", str_rank, true);
+ setenv("OFI_PORT", str_port, true);
exit:
if (hostbuf)
free(hostbuf);
| [main->[MPI_Init,D_GOTO,free,MPI_Comm_size,setenv,MPI_Finalize,parse_args,MPI_Comm_rank,get_self_uri,MPI_Allgather,sprintf,execve,MPI_Barrier,calloc,show_usage,generate_group_file,D_ERROR],void->[printf],int->[crt_context_destroy,D_GOTO,strerror,setenv,atoi,getopt_long,crt_finalize,printf,fprintf,strlen,crt_init,crt_se... | This is the entry point for the command line interface. This function will generate the group configuration file and then execute the application. | (style) code indent should use tabs where possible |
@@ -377,10 +377,9 @@ public interface ChannelHandler {
* that are pending.
*
* @param ctx the {@link ChannelHandlerContext} for which the flush operation is made
- * @throws Exception thrown if an error occurs
*/
@Skip
- default void flush(ChannelHandlerContext c... | [read->[read],disconnect->[disconnect],connect->[connect],write->[write],close->[close],deregister->[deregister],bind->[bind],register->[register],flush->[flush]] | flush all pending messages. | What happens now if `flush` fails? |
@@ -608,6 +608,11 @@ public final class StorageContainerManager extends ServiceRuntimeInfoImpl
}
+ // TODO: Ratis is always enabled now. In case, ratis gets disabled, this
+ // switch should be adjusted accordingly.
+ public static boolean isRatisEnabled(OzoneConfiguration conf) {
+ return true;
+ }
/*... | [StorageContainerManager->[getDatanodeRpcAddress->[getDatanodeRpcAddress],getRuleStatus->[getRuleStatus],stop->[unregisterMXBean,getSecurityProtocolServer,stop],createSCM->[StorageContainerManager,createSCM],join->[getSecurityProtocolServer,join],getClientRpcPort->[getClientRpcAddress],start->[getSecurityProtocolServer... | Initializes a certificate server based on the specified cluster ID and SCM ID. Construct a message for logging startup information about an RPC server. | There is a utility method SCMHAUtils#isSCMHAEnabled we can use this and change the default value of OZONE_SCM_HA_ENABLE_DEFAULT to true, as now ratis is default looks like. (I see there is no usage for this method) |
@@ -9,5 +9,4 @@
# regenerated.
# --------------------------------------------------------------------------
-VERSION = "1.3.0"
-
+VERSION = "2.0.0"
| [No CFG could be retrieved] | The sequence number for a managed object. | This file should be private now |
@@ -195,7 +195,7 @@ public class WindowedWordCount {
options.setBigQuerySchema(getSchema());
// DataflowExampleUtils creates the necessary input sources to simplify execution of this
// Pipeline.
- DataflowExampleUtils exampleDataflowUtils = new DataflowExampleUtils(options,
+ ExampleUtils exampleD... | [WindowedWordCount->[main->[getSchema,isUnbounded,getWindowSize,AddTimestampFn]]] | Example of how to read a single element of a file from a GCS file and write it This method runs the pipeline and waits until it finishes. | can we fix any wrapping in this file? |
@@ -357,6 +357,14 @@ class InstSource(HasPrivateTraits):
else:
return np.zeros((1, 3))
+ @cached_property
+ def _get_eeg_points(self):
+ if not self.inst or not self.eeg_dig:
+ return np.empty((0, 3))
+ dig = np.array([d['r'][:3] for d in self.eeg_dig])
+ di... | [set_fs_home->[get_fs_home],MRISubjectSource->[create_fsaverage->[get_fs_home]],SubjectSelectorPanel->[_create_fsaverage_fired->[create_fsaverage]]] | Get the rpa of the FID points. | Is this necessary? (Can `d['r'][:3]` have a shape other than `(1, 3)`?) |
@@ -1428,7 +1428,7 @@ class TypeStrVisitor(TypeVisitor[str]):
s = self.list_str(t.items)
if t.fallback and t.fallback.type:
fallback_name = t.fallback.type.fullname()
- if fallback_name != 'builtins.tuple':
+ if fallback_name not in ('builtins.tuple', 'builtins.objec... | [TypeQuery->[visit_star_type->[accept],visit_overloaded->[items],visit_type_type->[accept],query_types->[accept]],TypeList->[serialize->[serialize],deserialize->[deserialize_type,TypeList]],TypeStrVisitor->[visit_typeddict_type->[accept,items],visit_star_type->[accept],visit_instance->[name],visit_tuple_type->[accept],... | Return string representation of tuple type. | Again, do you really need this formatting change? |
@@ -77,6 +77,8 @@ public class HoodieHFileWriter<T extends HoodieRecordPayload, R extends IndexedR
this.file = HoodieWrapperFileSystem.convertToHoodiePath(file, conf);
this.fs = (HoodieWrapperFileSystem) this.file.getFileSystem(conf);
this.hfileConfig = hfileConfig;
+ this.schema = schema;
+ this.s... | [HoodieHFileWriter->[close->[write->[write],close],getBytesWritten->[getBytesWritten]]] | Creates a new HFileWriter. How to write the HAR file. | Can't this be passed from the metadata code path that actually instantiates the writer? Then we need not hardcode anything? What am I missing? |
@@ -313,8 +313,8 @@ public class GobblinYarnAppLauncher {
if (!this.config.hasPath(GobblinYarnConfigurationKeys.LOG_COPIER_DISABLE_DRIVER_COPY) ||
!this.config.getBoolean(GobblinYarnConfigurationKeys.LOG_COPIER_DISABLE_DRIVER_COPY)) {
services.add(buildLogCopier(this.config,
- new Path(this.... | [GobblinYarnAppLauncher->[handleApplicationReportArrivalEvent->[stop],stopYarnClient->[stop],handleGetApplicationReportFailureEvent->[stop],getReconnectableApplicationId->[getApplicationId],main->[run->[sendEmailOnShutdown,stop],launch,GobblinYarnAppLauncher],setupAndSubmitApplication->[getApplicationId]]] | Launches the Gobblin application. Initialize the application master and start all the services. | Looks like this is all reformatting code. |
@@ -90,7 +90,9 @@ def get_profile_path(profile_name, default_folder, cwd, exists=True):
if os.path.isabs(profile_name):
return valid_path(profile_name)
- if profile_name[:2] in ("./", ".\\"): # local
+ # relative local profile path
+ if profile_name[:2] in ("./", ".\\") or \
+ profile_na... | [_profile_parse_args->[_get_simple_and_package_tuples->[_get_tuples_list_from_extender_arg],_get_tuples_list_from_extender_arg,_get_env_values,_get_simple_and_package_tuples],read_profile->[get_profile_path],get_profile_path->[valid_path],_load_profile->[update_vars,ProfileParser,read_profile,apply_vars,get_includes],p... | Get path to a profile. | why not use `os.path.isabs` instead of our own bicycles? that will end up in many misdetected cases, e.g. in posix `..\\myfile` is valid file name |
@@ -16,7 +16,7 @@ from KratosMultiphysics.HDF5Application.core.utils import ParametersWrapper
def IsDistributed():
- return KratosMultiphysics.DataCommunicator.GetDefault().IsDistributed()
+ return KratosMultiphysics.IsDitributedRun()
def CreateOperationSettings(operation_type, user_settings):
| [IsDistributed->[GetDefault],CreateOperationSettings->[ParametersWrapper]] | Returns a dictionary of parameters for a Kratos Multiphysics core. | this should also get a ModelPart and querry the DataComm Or maybe it is not even needed to have this thin wrapper as the ModelPart also has the `IsDistributed` function |
@@ -122,7 +122,7 @@ void DistanceSmoothingProcess<TDim, TSparseSpace, TDenseSpace, TLinearSolver>::E
auto& n_nodes = rNode.GetValue(NEIGHBOUR_NODES);
for (unsigned int j = 0; j < n_nodes.size(); ++j) {
- if (!(n_nodes[j].Is(CONTACT)) || !(rNode.Is(CONTACT))){
+ ... | [No CFG could be retrieved] | This method is called from the DistanceSmoothingProcess. It finds the node in the R Private functions - functions - functions - functions - functions - functions - functions - functions - functions. | As far as I see this implies a behaviour change. Next time please try to encapsulate it in a single PR to ease keeping track of the changes. |
@@ -385,9 +385,13 @@ reset:
D_DEBUG(DB_IO, "Failed to punch object "DF_UOID": rc = %d\n",
DP_UOID(oid), rc);
- if ((rc == -DER_NONEXIST || rc == 0) &&
- vos_ts_wcheck(ts_set, epr.epr_hi, bound))
- rc = -DER_TX_RESTART;
+ if (rc == 0 || rc == -DER_NONEXIST) {
+ /** We must prevent underpunch with regular ... | [int->[dbtree_iter_empty,dbtree_iter_probe,ci_set_null,vos_ilog_check,evt_iter_delete,recx_get_flags,key_iter_match,vos_cont2hdl,vos_oi_punch,vos_ilog_punch,evt_iter_empty,D_ERROR,vos_iterate_key,dbtree_iter_fetch,evt_extent_width,key_iter_fetch_helper,VOS_TX_LOG_FAIL,singv_iter_probe_epr,recx_iter_fini,tree_is_empty,v... | vos_obj_punch punch - punch object AKEY - AKEY of AKEY DKEY - AKEY of AKEY DKEY punch an object missing - check - if - the - key - the - key - the - key -. | A bit worried... If VOS_OF_REPLAY_PC is set, we should skip all MVCC checks. Does this here implies that we are performing wcheck before for rebuild I/Os? Does it work because for rebuild I/Os, we must have bound == epoch? |
@@ -24,7 +24,9 @@ import org.apache.commons.text.StringEscapeUtils;
* An asynchronously build blob.
*
* @since 9.3
+ * @deprecated since 10.3, use the @async operation adapter instead.
*/
+@Deprecated
public class AsyncBlob extends JSONBlob {
private static final long serialVersionUID = 1L;
| [AsyncBlob->[setFilename,escapeJson]] | Creates a new object that asynchronously builds a blob from a given key. Returns true if the sequence has been completed. | Give a clue of what to do in 10.3 |
@@ -540,7 +540,7 @@ def show(obj=None, browser=None, new="tab", url=None):
controller.open("file://" + os.path.abspath(filename), new=new_param)
-def save(filename=None, resources=None, obj=None):
+def save(filename=None, resources=None, obj=None, title=None):
""" Updates the file with the data for th... | [curplot->[curdoc],load_object->[curdoc,cursession],output_server->[curdoc],output_notebook->[output_server],circle_x->[_plot_function],_axis->[curplot],push->[curdoc,cursession],_plot_function->[push,curdoc,cursession,save],circle_cross->[_plot_function],x->[_plot_function],line->[_plot_function],square_cross->[_plot_... | Saves a object to a file. | Not sure what the best parameter order here is. @damianavila @mattpap thoughts? I think either `(filename, obj, title, resources)` or `(obj, filename, title, resources)` |
@@ -431,6 +431,7 @@ function acl_lookup(App $a, $out_type = 'json') {
$sql_extra = "AND `name` LIKE '%%".dbesc($search)."%%'";
$sql_extra2 = "AND (`attag` LIKE '%%".dbesc($search)."%%' OR `name` LIKE '%%".dbesc($search)."%%' OR `nick` LIKE '%%".dbesc($search)."%%')";
} else {
+ /// @TODO Avoid these needless e... | [No CFG could be retrieved] | This function is used to perform a lookup of an ACL get the number of users who are blocked or not in the network This is a bit of a hack to work around the fact that the user can delete a get all contact objects that are not blocked get all unknow contacts Searches for items with a given name or link. | I really see it differently. I like to assign variables on the same level if possible. |
@@ -1025,9 +1025,8 @@ export class AmpA4A extends AMP.BaseElement {
checkStillCurrent();
// Failed to render via AMP creative path so fallback to non-AMP
// rendering within cross domain iframe.
- user().error(TAG, this.element.getAttribute('type'),
+ user().... | [AmpA4A->[extractSize->[user,get,Number],tryExecuteRealTimeConfig_->[user,maybeExecuteRealTimeConfig],constructor->[AmpAdUIHandler,AmpAdXOriginIframeHandler,dev,generateSentinel,getBinaryTypeNumericalCode,getBinaryType,protectFunctionWrapper,now],tearDownSlot->[dev],renderViaNameAttrOfXOriginIframe_->[NAMEFRAME,resolve... | Attempt to render a creative. | why don't we want to report these anymore? |
@@ -3237,6 +3237,10 @@ abstract class CommonObject
$targetid = (!empty($targetid) ? $targetid : $this->id);
$sourcetype = (!empty($sourcetype) ? $sourcetype : $this->element);
$targettype = (!empty($targettype) ? $targettype : $this->element);
+ if(!empty($this->module)){
+ $sourcetype=$this->module.":$s... | [CommonObject->[updateExtraField->[call_trigger],setSaveQuery->[isArray,isDuration,isDate,isInt,isFloat],fetchLinesCommon->[getFieldList,setVarsFromFetchObj],getBannerAddress->[getFullAddress,getFullName],line_ajaxorder->[updateRangOfLine],copy_linked_contact->[add_contact],update_note_public->[update_note],insertExtra... | Fetches all objects that are linked between two objects. Method to fetch all objects that link to the given object. This function is called to parse a single object into a module. This function is exported to the ExpeditionBon class. | The other part of code (for exemple field elementype in actioncomm, or defintion of language files) are using another convention name that is targettype.'"@".$this->module instead of what you suggest $this->module.":".targettype Can you try to change your code to use this other syntax. I would like to have a common way... |
@@ -453,8 +453,16 @@ define([
var outlineWidth = rectangle.outlineWidth;
var closeBottom = rectangle.closeBottom;
var closeTop = rectangle.closeTop;
+ var onTerrain = fillEnabled && !defined(height) && !defined(extrudedHeight) &&
+ isColorMaterial && GroundPrimit... | [No CFG could be retrieved] | Initializes the object with the properties of the object. Missing options. | Since this message is copied in 4 places, I would add a simple property to `oneTimeWarning` like `oneTimeWarning.geometryOutlines` with this string and use that instead. Also, we should replace this message with `Entity geometry outlines are unsupported on terrain. Outlines will be disabled. To enable outlines, disable... |
@@ -57,7 +57,9 @@ class ResourceSegmentSubscriber extends AbstractMappingSubscriber
{
$document = $event->getDocument();
$property = $this->getResourceSegmentProperty($document);
- $segment = $document->getStructure()->getProperty($property->getName())->getValue();
+
+ $locale = $th... | [ResourceSegmentSubscriber->[getResourceSegmentProperty->[getPropertyByTagName,getStructureMetadata],doPersist->[getResourceSegment,getResourceSegmentProperty,setValue,getDocument],doHydrate->[getValue,getResourceSegmentProperty,setResourceSegment,getDocument]]] | Hydrate a node in the document. | @dantleech do you have a better idea here? we should load the the url in the original locale! /cc @danrot |
@@ -2146,7 +2146,7 @@ var _ = Describe("Azure Container Cluster using the Kubernetes Orchestrator", fu
break
}
}
-
+ // TODO refactor to remove the "compute" usage so the test can be run on Azure Stack
instanceIDs := &compute.VirtualMachineScaleSetVMInstanceIDs{&[]string{instanceID}}
err ... | [ValidateOmsAgentLogs,Exec,ParseInput,CreatePVCFromFileDeleteIfExist,HasPrefix,WaitOnReadyMin,GetAll,WaitForIngress,GetAllRunningByPrefixWithRetry,New,CreateServiceFromFileDeleteIfExist,IsWindows,IsLargeVMSKU,NewAzureClientWithClientSecret,RunLinuxDeployDeleteIfExists,Bool,RequiresDocker,ValidateResources,RunDeployment... | Get vmss for the node and get the instanceID of the VM in its VMSS Wait for a pod to be ready. | We're O.K. with leaving this TODO as is? This means these tests will fail, right? |
@@ -676,7 +676,7 @@ def test_stats_on_removed_file_from_tracked_dir(tmp_dir, dvc, scm):
def test_stats_on_show_changes_does_not_show_summary(
- tmp_dir, dvc, scm, caplog
+ tmp_dir, dvc, scm, capsys
):
tmp_dir.dvc_gen(
{"dir": {"subdir": {"file": "file"}}, "other": "other"},
| [TestGitIgnoreWhenCheckout->[test->[read_ignored,commit_data_file]],TestCheckoutSingleStage->[test->[_test_checkout]],TestRemoveFilesWhenCheckout->[test->[commit_data_file]],TestCheckoutSelectiveRemove->[test->[outs_info]],TestGitIgnoreBasic->[test->[read_ignored,commit_data_file]],TestCmdCheckout->[test->[_test_checko... | Test stats on show changes does not show summary. | Fixing these tests is making me think if I should just use logger in `ui.write()`. |
@@ -1,12 +1,5 @@
<?php
-if (!$os) {
- if (strstr($sysObjectId, '.6321.1.2.2.5.3')) {
- $os = 'calix';
- }
- if (strstr($sysObjectId, '.6066.1.44')) {
- $os = 'calix';
- }
- if (strstr($sysObjectId, '.6321.1.2.3')) { // E5-1xx
- $os = 'calix';
- }
+
+if (str_contains($sysObjectId,... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - -. | This can be starts_with .1.3.6.1.4.1.6321.1.2.2.5.3 for example |
@@ -19,4 +19,8 @@ class ServiceProviderRequest < ApplicationRecord
def ial=(val)
self.loa = val
end
+
+ def ==(other)
+ to_json == other.to_json
+ end
end
| [ServiceProviderRequest->[from_uuid->[ial,new,instance_of?,loa,find_by],loa]] | set ial val. | Personally I would do like a `.to_h` comparison instead of `to_json`? But it's probably fine as-is? |
@@ -37,7 +37,12 @@ public class GreetingCacheManagerIT {
private static Asset manifest() {
String manifest = Descriptors.create(ManifestDescriptor.class)
- .attribute("Dependencies", "org.infinispan.cdi:" + Version.getModuleSlot() + " services, org.infinispan.jcache:" + Version.getModuleSlot() +... | [GreetingCacheManagerIT->[testClearGreetingCache->[assertEquals,getNumberOfEntries,clearCache,greet],manifest->[StringAsset,exportAsString],init->[assertEquals,getNumberOfEntries,clearCache],testGreetingCacheCachedValues->[getCachedValues,assertEquals,greet],deployment->[addAsWebInfResource],testGreetingCacheConfigurat... | Returns the manifest file of the current module. | This is potentially risky workaround. Should we go for Wildfly 8.2 or sort out WFLY-4250 first? |
@@ -390,9 +390,14 @@ class WikiTablesErmSemanticParser(WikiTablesSemanticParser):
action_history = state.action_history[0]
batch_index = state.batch_indices[0]
action_strings = [state.possible_actions[batch_index][i][0] for i in action_history]
- logical_form = world.get_logical_form(a... | [WikiTablesErmSemanticParser->[forward->[max,size,ChecklistStatelet,partial,sum,decode,enumerate,int,rnn_state,cpu,CoverageState,new_zeros,set,_get_initial_rnn_and_grammar_state,range,values,_compute_validation_outputs,list,append,len,zip,_agenda_coverage,_get_checklist_info],_get_vocab_index_mapping->[get_token_index,... | Get the cost of a state. | We can execute action sequences directly, which is definitely recommended here, so you don't have to go back and forth between strings. It'll make things at least a little faster. |
@@ -72,6 +72,16 @@ public class CreateCacheCommand extends BaseRpcCommand {
cacheManager.defineConfiguration(cacheNameToCreate, cacheConfig);
cacheManager.getCache(cacheNameToCreate);
+ final long startTime = System.nanoTime();
+ final long maxRunTime = TimeUnit.MILLISECONDS.toNanos(cacheConfi... | [CreateCacheCommand->[hashCode->[hashCode],setParameters->[getCommandId],equals->[equals]]] | This method is called when the task is invoked. | seems we should have this as a Log method? |
@@ -979,8 +979,11 @@ class Flow:
assert isinstance(flow_state.result, dict)
assert isinstance(flow_state.result[e.downstream_task], list)
for map_index, _ in enumerate(flow_state.result[e.downstream_task]):
+ upstream_id = str(id(e.upstream_task))
+ ... | [Flow->[copy->[copy],upstream_tasks->[edges_to],update->[add_edge,add_task],reference_tasks->[terminal_tasks],chain->[add_edge],edges_to->[all_upstream_edges],set_dependencies->[add_edge,add_task],run->[parameters,run],edges_from->[all_downstream_edges],generate_local_task_ids->[all_upstream_edges,sorted_tasks,copy,ser... | Displays a graphviz object for representing the current flow. Add a to the graph. | Now that we have `task.id` we could use that too. |
@@ -286,12 +286,12 @@ func (c *baseStore) validateQueryTimeRange(ctx context.Context, userID string, f
defer log.Span.Finish()
if *through < *from {
- return false, httpgrpc.Errorf(http.StatusBadRequest, "invalid query, through < from (%s < %s)", through, from)
+ return false, QueryError(fmt.Sprintf("invalid qu... | [Stop->[Stop],DeleteChunk->[PutOne,Get],Validate->[Validate],validateQuery->[validateQueryTimeRange],deleteChunk->[DeleteChunk,Get]] | validateQueryTimeRange validates that the given time range is within the limits for the given userID Returns a new instance of the class that will be used to create the class. | Not using `httpgrpc.Errorf()` in `validateQueryTimeRange()` changes the behaviour for `LabelValuesForMetricName()` and `LabelNamesForMetricName()` where we want to return an `httpgrpc` error. An option could be always wrapping the error there. |
@@ -40,7 +40,7 @@ class TestOneHotOp(OpTest):
out[i, x[i]] = 1.0
self.inputs = {'X': (x, x_lod)}
- self.attrs = {'depth': depth, 'dtype': int(core.VarDesc.VarType.FP32)}
+ self.attrs = {'dtype': int(core.VarDesc.VarType.FP32), 'depth': depth}
self.outputs = {'Out': (out, x... | [TestOneHotOp_exception->[test_check_output->[run->[run]]]] | Set up the object. | Why do you change the order? |
@@ -2025,7 +2025,6 @@ public class VmwareStorageProcessor implements StorageProcessor {
try {
if (workerVm != null) {
// detach volume and destroy worker vm
- workerVm.detachAllDisks();
workerVm.destroy();
... | [VmwareStorageProcessor->[copyTemplateToPrimaryStorage->[getName,copyTemplateFromSecondaryToPrimary],removeVmfsDatastore->[getHostDiscoveryMethod,removeVmfsDatastore,getHostsUsingStaticDiscovery,unmountVmfsDatastore],cloneVMFromTemplate->[createVMFullClone,createVMLinkedClone],createVolumeFromSnapshot->[restoreVolumeFr... | Backup a snapshot. This method creates a new VM and copies the snapshot to the worker. This method is called when a snapshot operation is done. It checks if the snapshot is in check if there is a snapshot in the system and if so destroy it. | @harikrishna-patnala can you check if per the new code/manager, we should detach the worker VM's disks after the backup of snapshot to secondary storage passes? cc @nvazquez @sureshanaparti |
@@ -278,9 +278,17 @@ func (consensus *Consensus) startNewView(viewID uint64, newLeaderPriKey *bls.Pri
consensus.mutex.Lock()
defer consensus.mutex.Unlock()
+ if !consensus.IsViewChangingMode() {
+ return errors.New("not in view changing mode anymore")
+ }
+
msgToSend := consensus.constructNewViewMessage(
vi... | [fallbackNextViewID->[GetViewChangingID,GetCurBlockViewID],onViewChange->[startNewView],startNewView->[SetMode],startViewChange->[SetViewChangingID,SetMode,GetViewChangingID,getNextLeaderKey,getNextViewID],ResetViewChangeState->[SetMode],getNextLeaderKey->[GetCurBlockViewID],getNextViewID->[fallbackNextViewID,GetCurBlo... | startNewView sends a new view message to the node and starts the view change. | Can we move this piece of code to the start of `onViewChange(consensus/view_change.go:317)`? |
@@ -150,14 +150,14 @@ namespace Dynamo.DocumentationBrowser
{
try
{
- var content = LoadContentFromResources(e.Link.ToString());
- if (content == null)
+ var targetcontent = LoadContentFromResources(e.Link.ToString());
+ if (... | [DocumentationBrowserViewModel->[EnsurePageHasContent->[NavigateToNoContentPage]]] | HandleLocalResource - Load content from resources. | NIT: Should be an upper case `C` like `targetContent` |
@@ -13,12 +13,12 @@ from freqtrade.constants import DEFAULT_DATAFRAME_COLUMNS
logger = logging.getLogger(__name__)
-def parse_ticker_dataframe(ticker: list, timeframe: str, pair: str, *,
- fill_missing: bool = True,
- drop_incomplete: bool = True) -> DataFrame:
+... | [ohlcv_fill_up_missing_data->[df,fillna,len,info,resample,reset_index,timeframe_to_minutes],convert_trades_format->[trades_purge,trades_store,len,trades_load,trades_get_pairs,info,get_datahandler],clean_ohlcv_dataframe->[ohlcv_fill_up_missing_data,debug,tail,groupby,drop],order_book_to_dataframe->[concat,bids_frame,ask... | Converts ticker - list to a DataFrame with a missing candle. | this namingchange gives me headaches. on one hand, it shouldn't matter as it's a internal function ... on the other hand it's useful to test something "real quick" ... and i suspect i'm not the only one importing and using this directly. |
@@ -59,4 +59,14 @@ class Profile < ApplicationRecord
def clear!
update(data: {})
end
+
+ private
+
+ def conditionally_validate_summary
+ return unless ProfileField.exists?(attribute_name: SUMMARY_ATTRIBUTE) && summary.present?
+ # Grandfather in people who had a too long summary before.
+ return ... | [Profile->[attributes!->[refresh_attributes!],refresh_attributes!]] | Clear the from the cache. | TIL about `data_was` ! |
@@ -151,7 +151,8 @@ namespace Microsoft.Extensions.Logging.Generators.Tests.TestClasses
private async Task VerifyAgainstBaselineUsingFile(string filename, string testSourceCode)
{
- string[] expectedLines = await File.ReadAllLinesAsync(Path.Combine("Baselines", filename)).ConfigureAwait(f... | [LoggerMessageGeneratorEmitterTests->[Task->[Single,CompareLines,Empty,VerifyAgainstBaselineUsingFile,ConfigureAwait,GetFiles,SourceText,True],CompareLines->[NewLine,Format,LineNumber,Count,Ordinal,Empty,Lines,ToString,Length,Equals],Mono]] | This method checks that the given file has the expected lines and that the test source code matches. | nit: can you break it to multiple lines (or tabify) so it's easier to read? |
@@ -461,9 +461,10 @@ public class Paragraph extends JobWithProgressPoller<InterpreterResult> implemen
if (interpreter == null) {
return true;
}
- Scheduler scheduler = interpreter.getScheduler();
- if (scheduler == null) {
- return true;
+ try {
+ interpreter.cancel(getInterpreterCon... | [Paragraph->[toJson->[toJson],completion->[setText,completion,getBindedInterpreter],createOrGetApplicationState->[getApplicationId],equals->[equals],setAuthenticationInfo->[getUser],setStatusToUserParagraph->[getUser],hashCode->[hashCode],jobRun->[getBindedInterpreter,info,setResult,getText,setText,getReturn,getUser,ge... | Check if the job aborts. | why can't we throw InterpreterException here? |
@@ -275,6 +275,8 @@ if ($limit > 0 && $limit != $conf->liste_limit) {
}
$param .= (GETPOST("orphelins") ? "&orphelins=1" : '');
$param .= ($search_ref ? "&search_ref=".urlencode($search_ref) : '');
+$param .= ($search_date_start ? "&search_date_start=".urlencode($search_date_start) : '');
+$param .= ($search_date_en... | [fetch,fetch_object,jdate,order,getNomUrl,initHooks,select_comptes,plimit,executeHooks,loadLangs,select_types_paiements,LibStatut,escape,close,showCheckAddButtons,showFilterAndCheckAddButtons,query,trans,num_rows,select_year,multiSelectArrayWithCheckbox] | Displays a list of national tokens. Generate a hidden input for the customer list. | We must always keep the detail of the 3 component (day, month, year) when forgin url params for search component so we should have if ($search_date_startday) { if ($search_date_startmonth) { .. |
@@ -16,7 +16,7 @@ class Test_utilsClass:
def test_importConditions(self):
standard_files = []
standard_files.append(join(fixturesPath, 'trialTypes.xlsx'))
- standard_files.append(join(fixturesPath, 'trialTypes.xls'))
+ #standard_files.append(join(fixturesPath, 'trialTypes.xls')) # x... | [Test_utilsClass->[test_importTrialTypes->[OrderedDict,join,importTrialTypes],test_import_blankColumns->[list,importConditions,conds,len,join],test_getDateStr->[strftime,localtime,getDateStr],test_bootStraps->[isinstance,bootStraps,len],test_isValidVariableName->[isValidVariableName],test_sliceFromString->[sliceFromStr... | Test import conditions. Checks if a object is valid. | I think this turned out not to be true - we misunderstood the pandas changelog to think that xls was no longer supported but actually the issue was that xlread is now only used for xls files (no longer for xlsx files) so xls is still fine |
@@ -65,6 +65,7 @@ const (
AggregatedClusterReaderRoleName = "system:openshift:aggregate-to-cluster-reader"
SelfProvisionerRoleName = "self-provisioner"
BasicUserRoleName = "basic-user"
+ BasicSCCUserRoleName = "basic-scc-user"
StatusCheckerRoleName = "cluster-status"
... | [No CFG could be retrieved] | Services related to a node Returns the names of the roles that are assigned to the system. | Will need to update the bootstrap policy test YAML: `UPDATE_BOOTSTRAP_POLICY_FIXTURE_DATA=true hack/test-go.sh pkg/cmd/server/bootstrappolicy` |
@@ -57,7 +57,7 @@ type Version struct {
// update minDBVersion accordingly
var migrations = []Migration{
- // Gitea 1.5.3 ends at v70
+ // Gitea 1.5.0 ends at v69
// v70 -> v71
NewMigration("add issue_dependencies", addIssueDependencies),
| [Migrate->[migrate],TableName,Commit,Exec,Index,ValueOf,Find,Close,Info,CreateTable,QuoteMeta,Migrate,CreateIndexes,Error,Description,CreateUniques,Dialect,Engine,Errorf,FindAllString,MustCompile,Type,TrimSpace,Indirect,ID,Join,Fprint,SetSchema,Name,ToLower,Where,Cols,Get,TableInfo,NewSession,Update,Query,ReplaceAllStr... | NewMigration creates a new migration for a single - column version. - - - - - - - - - - - - - - - - - -. | It seems these changes are unrelated? |
@@ -186,7 +186,6 @@ PERSONA_DEFAULT_PAGES = 5
# Signing
SIGNING_SERVER = env('SIGNING_SERVER')
-PRELIMINARY_SIGNING_SERVER = env('PRELIMINARY_SIGNING_SERVER')
# sandbox
PAYPAL_PAY_URL = 'https://svcs.sandbox.paypal.com/AdaptivePayments/'
| [email_url,env,list,bool,LOGGING,get_redis_settings,lazy,dict,datetime,Env,join,items,cache,read_env,lower,db] | Initialize the environment variables. Load and load a list of all ethernet - related information from the webscr file. | Uh that means we can get rid of one whole signing server ops-wise too? :heart_eyes_cat: |
@@ -1,13 +1,16 @@
# frozen_string_literal: true
class UserBadgesController < ApplicationController
+ MAX_FAVORITES = 2
+ MAX_BADGES = 96 # This was limited in PR#2360 to make it divisible by 8
+
before_action :ensure_badges_enabled
def index
params.permit [:granted_before, :offset, :username]
... | [UserBadgesController->[can_assign_badge_to_user?->[is_api?,can_grant_badges?,nil?],create->[can_assign_badge_to_user?,render,to_i,merge,is_badge_reason_valid?,grant,render_serialized,route_for,present?,t,require,id],ensure_badges_enabled->[raise,enable_badges?],is_badge_reason_valid?->[route_for],destroy->[can_assign_... | Renders a single user_idnack in the database. | no formatting change please |
@@ -52,6 +52,13 @@ trait OrderFilterTrait
'property' => $propertyName,
'type' => 'string',
'required' => false,
+ 'schema' => [
+ 'type' => 'string',
+ 'enum' => [
+ strtolower(OrderFilterInter... | [getDescription->[normalizePropertyName,getProperties,getFieldNames,isPropertyMapped],normalizeValue->[getProperties]] | Returns description of the node. | Actually, I think that we should deprecate `type` and `required`, in favor of `schema` (because JSON Schema already supports `type` and `required`). Using a JSON Schema to describe the filter is smart, and we should only support that. WDYT @teohhanhui? |
@@ -342,6 +342,17 @@ public class ExtensionMessageSource extends ExtensionComponent
}
}
+ @Override
+ protected ParameterValueResolver getParameterValueResolver() {
+ return (fieldName) -> {
+ try {
+ return source.getFieldValue(fieldName);
+ } catch (NoSuchFieldException | IllegalAccess... | [ExtensionMessageSource->[createSource->[createSource],createWorkManager->[createWorkManager],notifyExceptionAndShutDown->[shutdown],SourceRetryCallback->[doWork->[createSource,disposeSource,stopSource]],createProcessingContext->[getExecutionClassLoader->[getExecutionClassLoader]]]] | Validate the configuration of the operation. | getFieldValue() is not a responsibility that this class should have |
@@ -9,5 +9,5 @@
# regenerated.
# --------------------------------------------------------------------------
-VERSION = "0.1.0"
+VERSION = "0.2.0"
| [No CFG could be retrieved] | The managed object that was regenerated by the system. | Is there a reason we are keeping these versions started with "0"? @lmazuel is this a pattern we expect to continue seeing or should this be changed to `1.0.0b1`? |
@@ -622,16 +622,8 @@ func (d *Distributor) send(ctx context.Context, ingester ring.IngesterDesc, time
return err
}
-// ForAllIngesters runs f, in parallel, for all ingesters
-func (d *Distributor) ForAllIngesters(ctx context.Context, reallyAll bool, f func(context.Context, client.IngesterClient) (interface{}, erro... | [AllUserStats->[AllUserStats],MetricsForLabelMatchers->[ForAllIngesters,MetricsForLabelMatchers],Push->[tokenForLabels,validateSeries,tokenForMetadata,checkSample],UserStats->[ForAllIngesters,UserStats],Validate->[Validate],MetricsMetadata->[MetricsMetadata,ForAllIngesters],LabelNames->[ForAllIngesters,LabelNames],Regi... | send sends a write request to the given ingester returns a c - 16 bit integer. | What was this reallyAll branch that's being removed used for? |
@@ -66,4 +66,8 @@ class RepositoryColumn < ApplicationRecord
def importable?
Extends::REPOSITORY_IMPORTABLE_TYPES.include?(data_type.to_sym)
end
+
+ def range?
+ repository_date_time_range_value? || repository_date_range_value? || repository_time_range_value?
+ end
end
| [RepositoryColumn->[update_repository_table_states_with_new_column->[update_states_with_new_column,new],importable?->[to_sym,include?],update_repository_table_states_with_removed_column->[update_states_with_removed_column,new,index],name_like->[where],accepts_nested_attributes_for,auto_strip_attributes,belongs_to,enum,... | Checks if the repository is importable. | Why is it here? |
@@ -1,5 +1,13 @@
import sys
-from bokeh.command.bootstrap import main
+from bokeh.command.bootstrap import main as _main
-main(sys.argv)
\ No newline at end of file
+def main(args=None):
+ """The main"""
+ if args is None:
+ args = sys.argv[1:]
+
+ _main(sys.argv)
+
+if __name__ == "__main__":
+ ... | [main] | This module imports the main entry point for the bokeh - show command. | actually wait, `args` is not used at all |
@@ -135,7 +135,7 @@ public final class ClientFileSystemHelper {
final File userHome = new File(System.getProperties().getProperty("user.home"));
// the default
File rootDir;
- if (GameRunner.isMac()) {
+ if (System.getProperties().getProperty("os.name").toLowerCase().contains("mac")) {
rootD... | [ClientFileSystemHelper->[areWeOldExtraJar->[getTripleaJarWithEngineVersionStringPath],createTempFile->[createTempFile]]] | Get the user root folder. | @DanVanAtta Don't ask me why I can't use `GameRunner.isMac()` It keeps throwing Errors (not exceptions) |
@@ -176,6 +176,10 @@ class File(OnChangeMixin, ModelBase):
if validation['metadata'].get('requires_chrome'):
file_.requires_chrome = True
+ if file_.is_webextension and parsed_data.get('permissions'):
+ file_.webext_permissions_json = json.dumps(
+ parsed... | [check_file->[unhide_disabled_file,hide_disabled_file],update_status->[update_status],File->[unhide_disabled_file->[mv],hide_disabled_file->[mv]],update_status_delete->[update_status],cache_localepicker->[get_localepicker],FileValidation->[from_json->[save]],FileUpload->[add_file->[save],from_post->[add_file,FileUpload... | Create a new from an uploaded file. Annotate validation results with annotations from any previously approved file. | With a `JSONField` the `json.dumps()` would be done behind the scenes for you. |
@@ -473,6 +473,13 @@ def _get_info(fname, stim_channel, eog, misc, exclude, preload):
if np.isnan(info['lowpass']):
info['lowpass'] = info['sfreq'] / 2.
+ if info['highpass'] > info['lowpass']:
+ warn(f'Highpass cutoff frequency {info["highpass"]} is greater than '
+ f'lowpass cuto... | [_read_gdf_header->[_parse_prefilter_string,_check_dtype_byte],read_raw_bdf->[RawEDF],_get_info->[_read_header],RawEDF->[_read_segment_file->[_read_segment_file]],_read_segment_file->[_read_ch],read_raw_edf->[RawEDF],RawGDF->[_read_segment_file->[_read_segment_file]],_read_edf_header->[_edf_str_int,_parse_prefilter_str... | Extract all the information from the EDF + BDF or GDF file. This function returns a list of all nchan - nchan - ncogs that are Private function to get the maximum sample and the maximum sample length of a . | Or should we set them to `0` and `info['sfreq'] / 2` instead? I guess this amounts to the same thing (where do we equal `None` to these values?), but it would be more explicit (maybe at least in the warning message). |
@@ -54,9 +54,15 @@ public class BlockHandleImpl implements BlockHandle {
manager.pushBlock(blockCapsule);
tronNetService.broadcast(blockMessage);
} catch (Exception e) {
+ monitorMetric.getMeter(MonitorMetric.NODE_STATUS)
+ .mark();
logger.error("Handle block {} failed.", blockCa... | [BlockHandleImpl->[produce->[generateBlock,error,BlockMessage,broadcast,getString,receiveBlock,fastForward,pushBlock],getState->[equals]]] | Produce a new block from the pool. | BLOCKCHAIN_BLOCK_COUNT doesn't need to be defined as metrics |
@@ -143,7 +143,11 @@ namespace Js
{
if (JavascriptOperators::IsObject(firstArgument))
{
- if (JavascriptOperators::IsIterable(RecyclableObject::FromVar(firstArgument), scriptContext))
+ Var iterator = JavascriptOperators::GetProperty(R... | [No CFG could be retrieved] | Returns an object of type TypedArray whose contents are not null. END of function . | Is checking for undefined necessary? Seems redundant at a glance |
@@ -112,8 +112,10 @@ func filterFileSystemList(fsList []sigar.FileSystem) []sigar.FileSystem {
// GetFileSystemStat retreves stats for a single filesystem
func GetFileSystemStat(fs sigar.FileSystem) (*FSStat, error) {
stat := sigar.FileSystemUsage{}
- if err := stat.Get(fs.DirName); err != nil {
- return nil, err
... | [Round,Text,Stat,IsDir,Resolve,Put,Open,Fields,Scan,Get,NewScanner,IsAbs] | GetFileSystemStat returns a fs. FileSystem that has a relative mount point path. GetFilesystemEvent converts a stat struct into a MapStr. | I still wonder if we should log this somewhere. Maybe in the main `filesystem.go`? |
@@ -91,14 +91,7 @@ export class TestConfig {
}
skipIfPropertiesObfuscated() {
- return this.skip(function () {
- return window.__karma__.config.amp.propertiesObfuscated;
- });
- }
-
- enableIe() {
- this.skipMatchers.splice(this.skipMatchers.indexOf(this.runOnIe), 1);
- return this;
+ retu... | [No CFG could be retrieved] | Provides a list of predicate functions that determine whether to run tests on a platform. Adds a function to the list of conditions that can be met. | The inner function does not need access to the bound `this` reference, so could be either an arrow or standard function. Might roll this change back to avoid additional complication. |
@@ -27,6 +27,8 @@ module Types
field :mal_anime_id, String, null: true
field :image, Types::Objects::WorkImageType, null: true
field :satisfaction_rate, Float, null: true
+ field :ratings_count, Integer, null: false,
+ description: "評価数"
field :episodes_count, Integer, null: fals... | [WorkType->[programs->[call],image->[id,load],reviews->[call],no_episodes->[no_episodes?],episodes->[call],series_list->[where],staffs->[call],casts->[call],season_name->[upcase],syobocal_tid->[sc_tid],viewer_status_state->[status_kind,upcase],media->[upcase],reviews_count->[work_records_count],global_id_field,interfac... | The base type for an anime title missing arguments for connection_type. | Layout/AlignHash: Align the elements of a hash literal if they span more than one line. |
@@ -47,6 +47,7 @@ namespace CoreNodeModels
}
}
+ [JsonProperty("MetricConversion")]
public ConversionMetricUnit SelectedMetricConversion
{
get { return selectedMetricConversion; }
| [DynamoConvert->[SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],UpdateValueCore->[UpdateValueCore]]] | DynamoConvert class. nul l is a nul l. | The schema name is MetricValues. It can be changed if we prefer MetricConversion. (I do prefer MetricConversion, MetricValues came from Flood.) |
@@ -27,6 +27,10 @@ export const StyledList = styled<StyledPropsT>('ul', ({$theme}) => {
paddingBottom: $theme.sizing.scale300,
paddingLeft: 0,
paddingRight: 0,
+ borderTopLeftRadius: $theme.borders.popoverBorderRadius,
+ borderTopRightRadius: $theme.borders.popoverBorderRadius,
+ borderBottomRig... | [No CFG could be retrieved] | Creates a styled list of menu items. A styled list item with the menu item s . | Feels strange to tie the menu to popover props since it's only a single use case of the menu component. |
@@ -278,13 +278,15 @@ def read_source_estimate(fname, subject=None):
for f in [fname + '-rh.stc', fname + '-lh.stc']]
w_exist = [op.exists(f)
for f in [fname + '-rh.w', fname + '-lh.w']]
- h5_exist = op.exists(fname + '-stc.h5')
if all(stc_exist) and (f... | [SourceEstimate->[center_of_mass->[_center_of_mass],expand->[copy,_remove_kernel_sens_data_],__init__->[__init__],to_original_src->[SourceEstimate],in_label->[_hemilabel_stc,SourceEstimate],save->[_write_stc,_write_w],extract_label_time_course->[extract_label_time_course]],save_stc_as_volume->[save],_BaseSourceEstimate... | Read a soure estimate object from a. stc or. vol. stc file Reads a single from disk. Estimate a single time point or a single time point or a single time point or a single. | I don't think this is working correctly as ``fname`` does not seem to be used after this. Perhaps line 320 should be ``if ftype == 'h5':``? |
@@ -110,6 +110,11 @@ class DebugCommand(Command):
show_value('sys.platform', sys.platform)
show_sys_implementation()
+ show_value("REQUESTS_CA_BUNDLE", os.environ.get('REQUESTS_CA_BUNDLE'))
+ show_value("CURL_CA_BUNDLE", os.environ.get('CURL_CA_BUNDLE'))
+ show_value("pip._vendo... | [DebugCommand->[run->[show_tags,show_sys_implementation,show_value]],show_sys_implementation->[show_value]] | Show the details of a single . | @chrahunt Does this look OK to you? This doesn't include the filename we're loading from, since, well that's tricky to get from the `Configuration` object currently (we're not keeping track of which property came from where). |
@@ -41,8 +41,12 @@ class StatsSearchMixin(SearchMixin):
class CollectionCount(StatsSearchMixin, models.Model):
collection = models.ForeignKey('bandwagon.Collection')
- count = models.PositiveIntegerField()
- date = models.DateField()
+
+ # index name in database: `count`
+ count = models.PositiveInt... | [Contribution->[date->[date],mail_thankyou->[_switch_locale,ContributionError]],ThemeUpdateCount->[ThemeUpdateCountManager]] | Create a class that can be used to create a stats dictionary field. Adds a field to the stats of the missing add - ons. | Everytime you mention `in database` it should read `in dev/stage/prod database` or something, just to remove any confusion. |
@@ -264,7 +264,8 @@ class NormalInitializer(Initializer):
"dtype": int(var.dtype),
"mean": self._mean,
"std": self._std_dev,
- "seed": self._seed
+ "seed": self._seed,
+ "use_mkldnn": False
})
var.op = ... | [init_on_cpu->[force_init_on_cpu],MSRAInitializer->[__call__->[_compute_fans]],ConstantInitializer->[__call__->[force_init_on_cpu]],XavierInitializer->[__call__->[_compute_fans]]] | Add normal distribution initialization ops for a variable that needs to be initialized . | This line is intended for some other fixes? |
@@ -28,7 +28,7 @@ class PageViewsController < ApplicationController
private
def update_article_page_views
- return if Rails.env.production? && rand(8) != 1 # We don't need to update the article page views every time.
+ return if Rails.env.production? && rand(10) != 1 # We don't need to update the article ... | [PageViewsController->[create->[create],update->[create]]] | Updates the page views count if the user has not met a missing page view count. | Just a thought on making performance comparisons. Should we leave these numbers(also update_organic_page_views below) as is so that we can get a clear picture of the performance impact of removing the application controller? Otherwise, we have two variables changes and if we get a performance boost it will be hard to t... |
@@ -36,7 +36,8 @@ public class SegmentMetadataHolder
private final long isAvailable;
private final long isRealtime;
private final String segmentId;
- private final long numReplicas;
+ //segmentId -> set of servers that contain the segment
+ private final Map<String, Set<String>> segmentServerMap;
private... | [SegmentMetadataHolder->[Builder->[build->[SegmentMetadataHolder]]]] | Creates an instance of the SegmentMetadataHolder class. Returns true if the given segment is published false otherwise. | This map seems to always have just one entry, isn't it? |
@@ -54,7 +54,7 @@ describe('Controller Tests', function() {
// then
expect(MockTimeout).toHaveBeenCalledWith(jasmine.any(Function));
- expect(MockAngular.element).toHaveBeenCalledWith('[ng-model="vm.resetAccount.password"]');
+ expect(MockAngular.element).toHaveBeenCall... | [No CFG could be retrieved] | Example of how to create a controller that will reset the account. | This might be causing build failures. I dont think we need to change this |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.