patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1,6 +1,4 @@
-# -*- coding: utf-8 -*-
-
-# Copyright © 2010 Red Hat, Inc.
+# Copyright (c) 2010 Red Hat, Inc.
#
# This software is licensed to you under the GNU General Public
# License as published by the Free Software Foundation; either version
| [check_consumer_cert->[check_username_password],check_user_cert->[check_username_password],check_username_password->[_using_ldap,_check_username_password_ldap,_check_username_password_local],check_oauth->[_check_username_password_local]] | Creates a new user object from a given user object. get ldap base uri. | Why change the coding: & copyright notice? |
@@ -1033,6 +1033,14 @@ const char16* WasmBinaryReader::ReadInlineName(uint32& length, uint32& nameLengt
AssertMsg(UNREACHED, "We calculated the length before decoding, what happened ?");
ThrowDecodingError(_u("Error while decoding utf8 string"));
}
+ for (size_t i = 0; i < decodedLength; ++i)
... | [CheckBytesLeft->[ThrowDecodingError],ReadSectionHeader->[ThrowDecodingError],ReadCustomSection->[ThrowDecodingError],char16->[ThrowDecodingError],ReadFunctionHeaders->[ThrowDecodingError],SeekToFunctionBody->[ThrowDecodingError],ReadStartFunction->[ThrowDecodingError],ReadInitExpr->[ReadExpr,ThrowDecodingError],ReadTa... | Read inline name and return contents. Reads a function from the stream and adds it to the appropriate module if it is not found. | Does this work as intended (and as the error message says) with the whole range of Unicode strings? Additionally, should utf8::DecodeUnitsIntoAndNullTerminate be able to generate invalid char16s? Additionally, is this sort of twobyte-by-twobyte validation possible? The docs seem to imply no, as the official validation ... |
@@ -56,4 +56,5 @@ PYLINT_ACCEPTABLE_FAILURES = [
"azure-purview-catalog",
"azure-messaging-nspkg",
"azure-agrifood-farming",
+ "azure-eventhub"
]
| [No CFG could be retrieved] | azure - purview - catalog. | Avoid block by 'azure-eventhub' for release pipeline |
@@ -242,6 +242,7 @@ func registerFlags(td *OsmTestData) {
flag.StringVar(&td.OsmNamespace, "OsmNamespace", utils.GetEnv("K8S_NAMESPACE", defaultOsmNamespace), "OSM Namespace")
flag.BoolVar(&td.EnableNsMetricTag, "EnableMetricsTag", defaultEnableNsMetricTag, "Enable tagging Namespaces for metrics collection")
+ fl... | [Cleanup->[DeleteNs,String,GetTestNamespaceSelectorMap],GrabLogs->[RunLocal,GetTestDirPath,GetTestFilePath],CreateNs->[AreRegistryCredsPresent,GetTestNamespaceSelectorMap],InitTestData->[GetTestDirPath,ValidateStringParams],RestartOSMController->[String],RunRemote->[String],LoadOSMImagesIntoKind->[LoadImagesToKind],Get... | ValidateStringParams validates that all string parameters are set. | I'd generalize this to `linkServiceAccountsToSCC` or something like that - which would be applicable to any kind of cluster that uses SCC. |
@@ -332,8 +332,10 @@ async def create_pex(
else:
argv.extend(request.interpreter_constraints.generate_pex_arg_list())
- pex_debug = PexDebug(log_level)
- argv.extend(pex_debug.iter_pex_args())
+ argv.append("--no-emit-warnings")
+ verbosity = pex_runtime_environment.verbosity
+ if verbosi... | [create_pex->[PexDebug,Pex,generate_pex_arg_list,iter_pex_args,log],rules->[rules],two_step_create_pex->[PexRequest,PexRequirements,TwoStepPex],PexRequirements->[create_from_requirement_fields->[PexRequirements]],PexDebug->[log->[log]],PexInterpreterConstraints->[merge_constraint_sets->[and_constraints->[ParsedConstrai... | Creates a PEX with the given requirements interpreter and requirements constraints. Get a single missing - node node - check configuration. Missing key - value pex. | This is controlled separately, e.g. a dedicated option on `python_binary` targets. We don't want to unconditionally set this. |
@@ -597,7 +597,7 @@ class Openmpi(AutotoolsPackage):
'OpenMPI requires both C and Fortran compilers!'
)
- @when('@develop')
+ @when('@master')
def autoreconf(self, spec, prefix):
perl = which('perl')
perl('autogen.pl')
| [Openmpi->[setup_dependent_build_environment->[setup_run_environment],filter_rpaths->[filter_lang_rpaths],test->[_test_examples,_test_bin_ops,_test_check_versions]]] | Die without fortran. | @hppritcha For my understanding, why does this shift from `@develop` to `@master`? |
@@ -59,6 +59,13 @@ public final class SecurityUtils {
if (authentication.getPrincipal() instanceof UserDetails) {
UserDetails springSecurityUser = (UserDetails) authentication.getPrincipal();
return springSecurityUser.getUsername();
+ <%_ if (aut... | [No CFG could be retrieved] | A utility class for getting the login and JWT of the current user. Check if a user is authenticated. | Should we put "preferred_username" in a constant field or at least in local variable? |
@@ -138,9 +138,8 @@ class cloudManagementConfig(serviceCfgBase):
except:
pass
- self.syscfg.svo.stopService("cloudstack-management")
-
if self.syscfg.env.noStart == False:
+ self.syscfg.svo.stopService("cloudstack-management")
if self.syscfg.svo.enableServ... | [cloudManagementConfig->[config->[checkHostName]]] | Update the configuration of the cloudstack. Generate a key in the web keystore Remove all of the server. xml files and any of the server - nonssl. xml This is a hack to make sure that the management server is running and that we can start. | so if nostart is false (start is true ??) the service is stopped. Am I understanding this wrong? it seems like we don't want this here and not unconditionally either but only if nostart is true. |
@@ -52,6 +52,7 @@ class Topic < ActiveRecord::Base
def thumbnail_info(enqueue_if_missing: false, extra_sizes: [])
return nil unless original = image_upload
+ return nil unless original.filesize < SiteSetting.max_image_size_kb
return nil unless original.read_attribute(:width) && original.read_attribute... | [Topic->[relative_url->[relative_url],delete_topic_timer->[trash!],email_already_exists_for?->[private_message?],recover!->[recover!],invite_to_private_message->[add_small_action],url->[url],remove_allowed_group->[add_small_action],time_to_first_response_per_day->[time_to_first_response],fancy_title->[fancy_title,max_f... | Get all the info of the topic s thumbnail. | @SamSaffron, @oblakeerickson, this should be `SiteSetting.max_image_size_kb * 1024` or smth like that - `original.filesize` is in bytes |
@@ -139,7 +139,7 @@ static void init_expansion(dt_variables_params_t *params, gboolean iterate)
params->data->flags = img->flags;
- dt_image_cache_read_release(darktable.image_cache, img);
+ if(params->img == NULL) dt_image_cache_read_release(darktable.image_cache, img);
}
else if (params->data->ex... | [inline->[strlen,g_str_has_prefix],dt_variables_expand->[init_expansion,expand,cleanup_expansion],dt_variables_set_time->[localtime_r],char->[g_strndup,g_list_next,dt_opencl_is_enabled,g_path_get_dirname,sqlite3_finalize,dt_conf_get_bool,g_list_append,dt_util_glist_to_str,g_utf8_offset_to_pointer,MAX,sqlite3_step,g_asc... | Initializes the expansion. read - write access to the EXIF parameters region IImageCache. find_node. | And when is params->img released if set ? |
@@ -2001,10 +2001,14 @@ class State:
"""
if self.tree is not None:
# The file was already parsed (in __init__()).
- return
+ return True
manager = self.manager
+ if matches_exclude(
+ self.path, manager.options.exclude, manager.fsca... | [process_graph->[add_stats,trace,log],_build->[BuildSourceSet,BuildResult],write_deps_cache->[deps_to_json,getmtime,log],BuildManager->[trace->[verbosity],log_fine_grained->[verbosity,log],all_imported_modules_in_file->[correct_rel_imp,import_priority],maybe_swap_for_shadow_path->[normpath],report_file->[is_source],log... | Parse a file and run first pass of semantic analysis. Initialize a node object from a source file. | You need to change the return type from `-> None` to `-> bool`. |
@@ -12,6 +12,7 @@ namespace Content.Shared.Body.Part
{
Universal = 0,
Biological,
- Mechanical
+ Mechanical,
+ Slime
}
}
| [No CFG could be retrieved] | Enumerates the types of uncertainties. | Add a TODO somewhere here to turn this enum into prototypes, its sight pains me |
@@ -25,10 +25,6 @@ func CreateIssueComment(doer *models.User, repo *models.Repository, issue *model
if err != nil {
return nil, err
}
- err = issues.SaveIssueContentHistory(db.GetEngine(db.DefaultContext), doer.ID, issue.ID, comment.ID, timeutil.TimeStampNow(), comment.Content, true)
- if err != nil {
- return ... | [CreateComment,NotifyDeleteComment,TimeStampNow,NotifyCreateIssueComment,UpdateComment,GetEngine,NotifyUpdateComment,SaveIssueContentHistory,FindAndUpdateIssueMentions,DeleteComment] | CreateIssueComment creates a comment of type comment and updates it. IssueContentHistory deletes the issue content. | Why remove these? |
@@ -86,7 +86,7 @@ public class RemoteInterpreterManagedProcess extends RemoteInterpreterProcess
@Override
public String getHost() {
- return "localhost";
+ return host;
}
@Override
| [RemoteInterpreterManagedProcess->[start->[callback->[getHost,getPort],start],ProcessLogOutputStream->[write->[write]],stop->[stop]]] | Returns the hostname and port of the node. | this could return null then (the initial value)? |
@@ -204,6 +204,12 @@ def can_user_manage_group(user: "User", group: Group) -> bool:
return user.has_perms(permissions)
+def can_manage_service_account(user: "User", service_account: "ServiceAccount") -> bool:
+ """User can't manage service account with permission that is out of scope."""
+ permissions = ... | [get_allowed_fields_camel_case->[validation_field_to_camel_case],get_groups_which_user_can_manage->[get_user_permissions]] | Return group permissions in the format app. permission. codename. | Out of scope = ? |
@@ -113,7 +113,13 @@ class TransformVisitor(NodeVisitor[Node]):
new.is_class = node.is_class
new.is_property = node.is_property
new.original_def = node.original_def
- return new
+
+ if node in self.func_map:
+ result = self.func_map[node]
+ result.__dict__ ... | [TransformVisitor->[visit_func_def->[copy_argument],visit_member_expr->[visit_var],copy_ref->[visit_var],visit_func_expr->[copy_argument],optional_block->[block],optional_names->[duplicate_name],block->[visit_block],types->[type],names->[duplicate_name],optional_node->[node],optional_nodes->[optional_node],blocks->[blo... | Visit a FuncDef node and return a copy of it. | This is worth explaining, as this is a little unusual. In particular, this only works if the classes of the instances are identical (no subclasses)? |
@@ -92,6 +92,14 @@ public class SqlOperators {
x -> createTypeFactory().createArrayType(x.getOperandType(0), -1),
new UdafImpl<>(new ArrayAgg.ArrayAggArray()));
+ public static final SqlOperator ARRAY_CONCAT_AGG_FN =
+ createUdafOperator(
+ "array_concat_agg",
+ x ->
+ ... | [SqlOperators->[toSql->[createSqlType,toSql],createUdfOperator->[createUdfOperator],createSqlType->[createSqlType]]] | ZetaSqlFunction group by. Create UdfOperator for a single node. | You need to get the array element type from `x`. Otherwise this function will only work for integers. |
@@ -218,9 +218,11 @@ class DefaultConcretizer(object):
sys_arch = spack.spec.ArchSpec(spack.architecture.sys_type())
spec_changed = False
- if spec.architecture is None:
+ if spec.architecture is None and root_arch is None:
spec.architecture = spack.spec.ArchSpec(sys_arch)... | [DefaultConcretizer->[concretize_compiler->[_proper_compiler_style],choose_virtual_or_external->[_valid_virtuals_and_externals]]] | Concretizes the architecture of the object. | Instead of root_arch, I think this should use an idiom similar to `concretize_compiler` and search up the DAG for the nearest architecture that is set. Suppose foo depends on bar depends on baz. Then if a user specifies `foo os=be ^bar os=fe`, the baz in that spec should concretize to the front-end architecture, not th... |
@@ -31,13 +31,13 @@ import (
"github.com/stretchr/testify/assert"
)
-const pulumiOrg = "moolumi"
+const pulumiOrg = "pulumi-test"
const pName = "testproj"
func TestWorkspaceSecretsProvider(t *testing.T) {
ctx := context.Background()
sName := fmt.Sprintf("int_test%d", rangeIn(10000000, 99999999))
- fqsn := ... | [SetConfig,GetSecret,Workspace,Now,False,Setenv,GetConfig,RemoveStack,SetAllConfig,WorkDir,Up,SetEnvVar,Error,SetEnvVars,New,Export,NotNil,Errorf,Destroy,Preview,Skip,Nil,Refresh,Join,Equal,UnixNano,NewProjectRuntimeInfo,Contains,Name,Unsetenv,PackageName,Log,Get,UnsetEnvVar,Seed,Command,GetEnvVars,Sprintf,Background,S... | TestWorkspaceSecretsProvider tests the given stack with the given name and returns a stack object that The initial stack is initialized by the user. | we should use whoami or make this an envvar versus hard coding it |
@@ -149,6 +149,11 @@ public class PublishSubscribeChannel extends AbstractExecutorChannel {
getDispatcher().setApplySequence(this.applySequence);
getDispatcher().setMinSubscribers(this.minSubscribers);
}
+ else if (this.errorHandler != null) {
+ logger.warn("When 'executor' is not provided the 'errorHandl... | [PublishSubscribeChannel->[setIgnoreFailures->[setIgnoreFailures],setApplySequence->[setApplySequence],setMinSubscribers->[setMinSubscribers],onInit->[setApplySequence,onInit,setIgnoreFailures,setMinSubscribers]]] | This method is called when the channel is initialized. | Perhaps include the `componentName` in the message? |
@@ -447,7 +447,7 @@ void Ros::run(int argc, char **argv) {
ros::spinOnce();
publishClockIfNeeded();
for (unsigned int i = 0; i < mSensorList.size(); i++)
- mSensorList[i]->publishValues(mStep * mStepSize);
+ mSensorList[i]->publishValues(mStep * mRobot->getBasicTimeStep());
if (!mUseWebo... | [shutdown->[shutdown],run->[publishClockIfNeeded,launchRos]] | Main loop of the ROS master. | The `mStepSize` is configured in the `timeStepCallback` function. To preserve the functionality of the `timeStepCallback`, I would rather set default value of the `mStepSize` to `mRobot->getBasicTimeStep()` as soon as we have access to the `Robot` object. |
@@ -38,7 +38,8 @@ import {toWin} from './types';
const EMBED_PROP = '__AMP_EMBED__';
/** @const {!Array<string>} */
-const EXCLUDE_INI_LOAD = ['AMP-AD', 'AMP-ANALYTICS', 'AMP-PIXEL'];
+const EXCLUDE_INI_LOAD =
+ ['AMP-AD', 'AMP-ANALYTICS', 'AMP-PIXEL', 'AMP-AD-EXIT'];
/**
| [No CFG could be retrieved] | Imports a single unique identifier. Check if the FriendlyIframeSpec object is supported by the user. | aside: weird that these are uppercase |
@@ -26,9 +26,12 @@ import java.io.Serializable;
import java.util.List;
import java.util.Objects;
+import javax.inject.Inject;
+
import org.junit.Test;
import org.nuxeo.ecm.core.api.DocumentModel;
import org.nuxeo.ecm.core.api.VersioningOption;
+import org.nuxeo.ecm.core.test.TransactionalFeature;
import org.nux... | [TestAutoVersioning->[testInitialVersion->[assertTrue,getVersionLabel,isCheckedOut,saveDocument,createDocument,setPropertyValue,createDocumentModel,assertEquals],testManualVersioningCreateABeforeVersion->[assertTrue,size,assertFalse,putContextData,getVersionLabel,isCheckedOut,saveDocument,createDocument,getVersions,set... | Creates a new instance of the TestAutoVersioning class. Test the initial version of the document. | Do you need to keep the random bug annotation? If yes, please fill the `issue`. |
@@ -1958,6 +1958,13 @@ void Server::SendCSMRestrictionFlags(session_t peer_id)
Send(&pkt);
}
+void Server::SendPlayerSpeed(session_t peer_id, const v3f &added_vel)
+{
+ NetworkPacket pkt(TOCLIENT_PLAYER_SPEED, 0, peer_id);
+ pkt << added_vel;
+ Send(&pkt);
+}
+
s32 Server::playSound(const SimpleSoundSpec &spec,
... | [No CFG could be retrieved] | This is the main loop of the server. emerge a client - specific . | i suggest to replace fast move if this pr is merged with this implementation, it permits to servers to set fast move velocity :) |
@@ -100,6 +100,9 @@ if USE_MYPYC:
# We don't populate __file__ properly at the top level or something?
# Also I think there would be problems with how we generate version.py.
'version.py',
+
+ # Written by someone who doesn't know how to deal with mypyc
+ 'stubtest.py',
)) ... | [CustomPythonBuild->[run->[run]],find_package_data] | Find all the typeshed and typeshed packages and add them to package_data. Adds a test module to the list of modules we need to add to the test module. | Is this still necessary? |
@@ -126,6 +126,14 @@ class CarInterface(CarInterfaceBase):
tire_stiffness_factor = 0.385
ret.lateralTuning.pid.kiBP, ret.lateralTuning.pid.kpBP = [[0.], [0.]]
ret.lateralTuning.pid.kpV, ret.lateralTuning.pid.kiV = [[0.25], [0.05]]
+ elif candidate in CAR.IONIQ_EV_2020:
+ ret.lateralTuning.p... | [CarInterface->[apply->[update],update->[update]]] | Get the standard parameters for a given candidate. return values of return variables. return values of the following properties return values of parameter pBP and pBP are in the order of the last non - region CAR_SYSTEM_SYSTEM_SYSTEM_SYSTEM_SYSTEM_SYSTEM_SYSTEM_ get the counters and checksums in the messages . | Seems like almost all params are the same, just add it to the list with the other Ioniq models and set minSteerSpeed accordingly |
@@ -162,15 +162,6 @@ public class Test_System {
for (int i = 0; i < props.length; i++) {
AssertJUnit.assertTrue(props[i], System.getProperty(props[i]) != null);
}
-
- /*
- * This test should only run for Java 1.8.0 and above. For Java 1.9.0
- * and above, we do not support java.ext.dirs property.
- */
... | [Test_System->[createInstance->[Test_System],test_setSecurityManager->[MySecurityManager->[checkPermission->[checkPermission]],MySecurityManager,preloadClasses]]] | This test is used to test if the system properties are non - null. | This test should stay. Its not testing java.version, but using java.version to determine when running Java 8, in order to check java.ext.dirs, which is still valid. |
@@ -766,7 +766,8 @@ namespace Dynamo.Models
}
catch (Exception ex)
{
- Debug.WriteLine(ex.Message + " : " + ex.StackTrace);
+ Log(ex.Message);
+ Log(ex.StackTrace);
return false;
}
}
| [WorkspaceModel->[SaveAs->[OnWorkspaceSaved],Clear->[Clear,Dispose],AddNode->[OnNodeAdded,OnRequestNodeCentered],SaveInternal->[Save],ReloadModel->[Undo],Save->[SaveAs],Log->[Log],Undo->[Undo],NoteModel->[AddNote],AddNote->[OnRequestNodeCentered],DisposeNode->[OnNodeRemoved],PopulateXmlDocument->[SerializeElementResolv... | PopulateXmlDocument populates the XML document with the elements connectors and notes. Check if there is a n. Y attribute in note. | Wondering why these are changed? |
@@ -578,11 +578,10 @@ function _raiseHandUpdated({ dispatch, getState }, conference, participantId, ne
titleKey: 'notify.somebody',
title: notificationTitle,
descriptionKey: 'notify.raisedHand',
- raiseHandNotification: true,
concatText: true,
... | [No CFG could be retrieved] | Registers sounds related with the participants feature. Unregisters the ethernet sounds. | Why are we making this long? |
@@ -219,6 +219,15 @@ MiddlewareRegistry.register(store => next => action => {
});
break;
+ case SET_PAGE_RELOAD_OVERLAY_CANCELED:
+ sendEvent(
+ store,
+ CONFERENCE_TERMINATED,
+ /* data */ {
+ url: _normalizeUrl(store.getState()['feature... | [No CFG could be retrieved] | Handle a single event that has been received from the server. This function is called when the user has requested to share the screen. | We should try to pass the error that caused the reload, WDYT? |
@@ -101,6 +101,7 @@ type GlobalContext struct {
paramProofStore MerkleStore // a cache and fetcher for param proofs
externalURLStore MerkleStore // a cache and fetcher for external urls
PayloadCache *PayloadCache // cache of ChainLink payload json wrappers
+ kvRevisionCac... | [initGUILogFile->[GetClock,GetLog],GetDataDir->[GetDataDir],GetCacheDir->[GetCacheDir],BustLocalUserCache->[GetFullSelfer,GetUPAKLoader],Configure->[SetCommandLine,ConfigureLogging],Shutdown->[shutdownCachesLocked,Shutdown],ConfigReload->[ConfigureConfig],GetLogDir->[GetLogDir],GetStoredSecretServiceName->[GetStoredSec... | This is a wrapper for all of the functions that are called from the main daemon. UIs to route. | Might should clear the in-memory portion on logout |
@@ -404,7 +404,16 @@ Temporary files (client):
won't be locally cached.
Temporary files (server):
- None.
+ A non-trivial (potentially 40-50 MB) amount of data will be stored on the
+ remote temp directory for each client that connects to it. For some remotes,
+ in particular QNAP NAS systems, this ... | [No CFG could be retrieved] | This is a helper function that can be used to add additional chunks to a target repository. | does it make sense to give a specific amount here? guess it could vary widely, depending on repo size and what you do? |
@@ -144,7 +144,7 @@ class RestApiClient(object):
contents = {key: decode_text(value) for key, value in dict(contents).items()}
return ConanInfo.loads(contents[CONANINFO])
- def get_recipe(self, conan_reference, dest_folder):
+ def get_recipe(self, conan_reference, dest_folder, retrieve_sources... | [RestApiClient->[auth->[JWTAuth],_get_json->[get_exception_from_error],_remove_conanfile_files->[check_credentials],upload_files->[_file_server_capabilities],_remove_package_files->[check_credentials],remove_packages->[check_credentials],remove_conanfile->[check_credentials],download_files_to_folder->[_file_server_capa... | Gets a ConanInfo file from a package. | I really prefer a generic "skip_files=[]" and keep **rest_client** nescient about the EXPORT_SOURCES_TGZ_NAME |
@@ -38,9 +38,9 @@ public final class LobbyServerProperties {
@Nonnull
private final Integer port;
- /** URI for the http lobby server. */
+ /** The port the https lobby server is listening on. */
@Nonnull
- private final URI httpServerUri;
+ private final Integer httpsPort;
@Nullable
private fina... | [LobbyServerProperties->[getServerMessage->[emptyToNull,ofNullable],getServerErrorMessage->[emptyToNull,ofNullable]]] | The properties file for the current lobby server. | I think we had a discussion about this before. The only reason this is an Integer instead of an int is because the annotation to make it required in the builder right? Maybe I'm overanalyzing this. In any case doesn't using just int work here, because this field is final? |
@@ -647,15 +647,15 @@ public class IsmFormat {
value);
VarIntCoder.of().encode(value.getId(), outStream, context.nested());
VarLongCoder.of().encode(value.getBlockOffset(), outStream, context.nested());
- VarLongCoder.of().encode(value.getIndexOffset(), outStream, context.nested());
+ ... | [IsmFormat->[FooterCoder->[decode->[of],encode->[getIndexPosition,getBloomFilterPosition,getNumberOfKeys],FooterCoder],IsmShard->[withIndexOffset->[id,of,blockOffset],getId->[id],getIndexOffset->[indexOffset],getBlockOffset->[blockOffset]],KeyPrefixCoder->[decode->[of],getEncodedElementByteSize->[getSharedKeySize,getUn... | Encodes an IsmShard to the given stream. | this code was broken, but I think none of the coders are context-sensitive. |
@@ -50,6 +50,15 @@ export class AmpImg extends BaseElement {
/** @private {?UnlistenDef} */
this.unlistenError_ = null;
+
+ /** @private {function()} */
+ this.detectIfLightboxable_ = once(() => {
+ if (!isExperimentOn(this.win, 'amp-lightbox-gallery-detection')) {
+ return;
+ }
+ ... | [No CFG could be retrieved] | Creates an object that represents an image element which can be attached to an image element. Check if srcset exists or if it doesn t try to find the first url in src. | This may makes sense to be outside if `amp-img` since it does not belong to a single image instance (although `once` handles that). Also we want a good to exclude this in different runtimes. I think something like `installAutoLightbox()` in `runtime.js` and then calling it from `amp.js` (and not from `amp-shadow.js`, `... |
@@ -143,10 +143,11 @@ namespace DotNetNuke.Entities.Users.Social.Internal
private static void AddFriendRequestNotification(UserInfo initiatingUser, UserInfo targetUser, UserRelationship userRelationship)
{
var notificationType = NotificationsController.Instance.GetNotificationType(FriendR... | [FriendsControllerImpl->[AddFriend->[AddFriend],DeleteFriend->[DeleteFriend]]] | Add a friend request notification to the target user. | What will happen if the `Name` property is actually null? Is it worth checking and setting a fallback value? |
@@ -31,7 +31,10 @@ RequestPasswordReset = RedactedStruct.new(
end
def instructions
- I18n.t('user_mailer.email_confirmation_instructions.first_sentence.forgot_password')
+ I18n.t(
+ 'user_mailer.email_confirmation_instructions.first_sentence.forgot_password',
+ app_name: APP_NAME,
+ )
end
... | [perform->[user,user_should_receive_registration_email?,new,submit],send_reset_password_instructions->[new,deliver,track_event,deliver_now,throttled_else_increment?,set_reset_password_token],instructions->[t],user->[user],user_should_receive_registration_email?->[nil?,confirmed?],email_address_record->[find_with_email]... | Returns the label for the missing instructions. | Couple more of these in `spec/services/request_password_reset_spec.rb` which need `app_name` passed in. |
@@ -1961,7 +1961,7 @@ static GtkWidget *_combobox_new_from_list(dt_iop_module_t *module, const gchar *
dt_bauhaus_widget_set_label(combo, _("blend"), label);
gtk_widget_set_tooltip_text(combo, tooltip);
for(; *list->name; list++)
- dt_bauhaus_combobox_add_full(combo, _(list->name), DT_BAUHAUS_COMBOBOX_ALIGN... | [dt_iop_gui_init_blending->[dt_iop_gui_init_masks,dt_iop_gui_init_raster,dt_iop_gui_init_blendif,dt_iop_gui_update_blending],dt_iop_gui_update_blending->[dt_iop_gui_update_masks,dt_iop_gui_update_raster,dt_iop_gui_update_blendif]] | Create a new combobox widget from list of name - value pairs. | This one was correct and necessary I'm afraid. A few drop downs in blending are now not being translated. |
@@ -1431,10 +1431,12 @@ public class BeanGenerator extends AbstractGenerator {
DotNames.POST_CONSTRUCT,
bean.getDeployment().getIndex());
for (MethodInfo callback : postConstructCallbacks) {
- if (Modifier.isPrivate(callback.flags())) {
- ... | [BeanGenerator->[implementCreateForClassBean->[newInstanceHandle,newProviderHandles],initConstructor->[generate]]] | implementCreateForClassBean - This method is called by the generated code to create a new instance This method is used to create a handle for the interceptor. region AroundConstruct lifecycle callback interceptors Creates a new provider handle. | This only logs private members in the code. Do we want some logging for the pack-private plus package split case too? Because effectively both scenarios force us into reflection which is something we want to avoid, right? |
@@ -84,8 +84,7 @@ namespace Kratos {
break;
}
}
-
- if (found) continue;
+ if (found) return;
for (PropertiesIterator props_it = mpInlet_model_part->GetMesh(0).PropertiesBegin(); props_it != mpInlet_model_part->GetMesh(0).Properties... | [No CFG could be retrieved] | This method is called from the ExplicitSolverStrategy. It finds the highest id in the list Custom ListOfSphericParticles - > SetProperties - > SetProperties - >. | Does this return end the function? We don't want this, but move to the next particle. This might be an error! |
@@ -56,6 +56,12 @@ class Php extends BaseValidation
if (Config::get('update') && version_compare(PHP_VERSION, self::PHP_MIN_VERSION, '<')) {
$validator->warn("PHP version " . self::PHP_MIN_VERSION . " is the minimum supported version as of " . self::PHP_MIN_VERSION_DATE . ". We recommend you updat... | [Php->[validate->[checkExtensions,checkTimezone,checkSessionDirWritable,checkVersion,checkFunctions],checkExtensions->[fail,warn],checkTimezone->[fail],checkSessionDirWritable->[getUsername,result,setFix],checkVersion->[warn],checkFunctions->[fail,warn]]] | Checks if the version of the PHP is supported. | mmh ... "restart php-fpm, apache. nginx or what webserver you use.. " ? |
@@ -76,6 +76,10 @@ $menu_options['fdb'] = 'FDB Table';
$menu_options['events'] = 'Eventlog';
$menu_options['notes'] = 'Notes';
+if (dbFetchCell("SELECT COUNT(*) FROM `sensors` WHERE `device_id` = ? AND `entPhysicalIndex` = ? ", array($device['device_id'],$port['ifIndex']))) {
+ $menu_options['sensors'] = 'Hea... | [getComponents] | Print the network network network network network network network network network network network network network network network network Check if a device is available. | I think this query also needs: `entPhysicalIndex_measured = 'ports'` |
@@ -110,10 +110,5 @@ func TestExecAdmit(t *testing.T) {
t.Errorf("%s: no actions found", k)
}
- if v.shouldHaveClientAction {
- if len(v.pod.Spec.ServiceAccountName) != 0 {
- t.Errorf("%s: sa name should have been cleared: %v", k, v.pod.Spec.ServiceAccountName)
- }
- }
}
}
| [NewSimpleClientset,PrependReactor,NewAttributesRecord,Resource,Actions,Kind,DefaultWatchReactor,AddWatchReactor,Errorf,NewFake,Admit,Logf] | v. shouldHaveClientAction should have no client action. | is there a test making sure exec works if the service account had rights and the user didn't? |
@@ -1,4 +1,4 @@
-const prisma = require('.prisma/client')
+const prisma = require('.prisma/client/index')
const path = require('path')
module.exports = prisma
| [No CFG could be retrieved] | Provides a function to export a single object. | Why is this needed now? |
@@ -59,8 +59,9 @@ class GCodeWriter(MeshWriter):
Logger.log("e", "GCode Writer does not support non-text mode.")
return False
+ active_build_plate = Application.getInstance().getBuildPlateModel().activeBuildPlate
scene = Application.getInstance().getController().getScene()
- ... | [GCodeWriter->[write->[write],_serialiseSettings->[_createFlattenedContainerInstance]]] | Writes a sequence of nodes to the given stream. | Potential index out of bounds hazard here, maybe add a try/except? |
@@ -51,12 +51,14 @@ import java.util.Map;
public class Access extends BaseHandler {
protected static final Logger LOG = Logger.getLogger(Access.class);
+ private final ClusterManager clusterManager;
/**
* Constructor for Access object
+ * @param clusterManagerIn
*/
- public Access()... | [Access->[aclSystemIsBootstrapMinionServer->[aclSystemHasBootstrapEntitlement]]] | Provides a base class which can be used to access a user s role. Checks if current User is in the Role. | I expect that we will be moving all the *Manager classes used in this class to the constructor as well and will modify the needed static methods from them. Do we have a strategy here that we will follow or will it be just Adhoc like we did it here for ClusterManager? On a side note: One thing that looks odd or not so g... |
@@ -309,6 +309,8 @@ public class ConfigurationKeys {
/**
* Converter configuration properties.
*/
+ public static final String CONVERTER_AVRO_INCLUDE_SCHEMA_CREATION_TIME = "converter.avro.include.schema.creation.time";
+ public static final Boolean DEFAULT_CONVERTER_AVRO_INCLUDE_SCHEMA_CREATION_TIME = tru... | [ConfigurationKeys->[name,toString,toMillis]] | This class defines the default values for the extract configuration. region Converter - specific names. | Do we need to make it configurable ? |
@@ -23,6 +23,7 @@ let importJsonIgnoreProperties = false;
let importSet = false;
let hasDto = dto === 'mapstruct';
let isUsingMapsId = false;
+let hasRelationship = relationships.length != 0;
const uniqueEnums = {}; %><%- include imports -%>
<%_ for (idx in relationships) {
| [No CFG could be retrieved] | Creates an object that represents a single unique integer in a Cassandra database. % > Import the missing header from the Neo4J header. | use !== instead, for strict equality |
@@ -121,9 +121,10 @@ export class AmpLightboxViewer extends AMP.BaseElement {
* @param {!string} label Text of the button for a11y
* @param {!string} className Css classname
* @param {!function()} action function to call when tapped
+ * @param {opt_parent=} opt_parent parent element that append the button... | [No CFG could be retrieved] | Private methods - Builds the mask and the buttons for the given element. Opens the element referenced by elementId. | let's not add any buttons to the gallery container and keep all the buttons at same level and use css to hide/show what makes sense. |
@@ -559,11 +559,8 @@ fill_rec(daos_handle_t ih, vos_iter_entry_t *key_ent, struct dss_enum_arg *arg,
iod_size = key_ent->ie_gsize;
if (iod_size == key_ent->ie_rsize)
data_size = iod_size;
- else
- data_size = 0;
} else {
iod_size = key_ent->ie_rsize;
- data_size = iod_size * key_ent->ie_recx.... | [dss_enum_unpack->[obj_enum_iterate],int->[fill_oid,csummer_alloc_csum_info]] | This function fills in a record from a key iterator. This function is called from the DAOS_IOV_IOP end of function iov_copy copy data from one iovec to another lo = rec_epr. epr_hi ;. | you mean for ITER_RECX, always don't inline it even if it is very small? |
@@ -113,4 +113,11 @@ public class HttpConnectorMessageProcessorProvider implements ConnectorOperation
{
cachedMessageProcessors.invalidateAll();
}
+
+ @Override
+ public void stop() throws MuleException
+ {
+ cachedMessageProcessors.invalidateAll();
+ }
+
}
| [HttpConnectorMessageProcessorProvider->[supportsUrl->[useTransportForUris,getScheme,startsWith],dispose->[invalidateAll],getMessageProcessor->[DefaultMuleException,get,HttpRequestCacheKey],buildMessageProcessor->[OneWayHttpRequesterAdapter,responseTimeout,equals,build,getExchangePattern,setUrl,setOperationConfig,getUr... | Disposes of a sequence of message processors that are not associated with a sequence of messages. | If this is the same as `dispose` why have both? |
@@ -173,7 +173,7 @@ def snapshot_definition(node: Optional[SymbolNode],
signature = snapshot_type(node.type)
else:
signature = snapshot_untyped_signature(node)
- return ('Func', common, node.is_property, signature)
+ return ('Func', common, node.is_property, node.is_clas... | [SnapshotTypeVisitor->[visit_uninhabited_type->[snapshot_simple_type],visit_union_type->[snapshot_type],visit_unbound_type->[snapshot_types],visit_callable_type->[snapshot_type,snapshot_types],visit_typeddict_type->[snapshot_type],visit_instance->[snapshot_types],visit_tuple_type->[snapshot_types],visit_type_type->[sna... | Create a snapshot description of a symbol table node. Get a snapshot of a NestedNode. | `is_property` now appears twice in the list, did you mean `is_static`? Also maybe the `isinstance` above can use `FuncBase`? |
@@ -9985,7 +9985,7 @@ l2arc_dev_hdr_read(l2arc_dev_t *dev)
err = zio_wait(zio_read_phys(NULL, dev->l2ad_vdev,
VDEV_LABEL_START_SIZE, l2dhdr_asize, abd,
- ZIO_CHECKSUM_LABEL, NULL, NULL, ZIO_PRIORITY_ASYNC_READ,
+ ZIO_CHECKSUM_LABEL, NULL, NULL, ZIO_PRIORITY_SYNC_READ,
ZIO_FLAG_DONT_CACHE | ZIO_F... | [No CFG could be retrieved] | Reads the device header from the provided L2ARC device and writes it to the provided header Reads device header from the L2ARC. | This makes sense, was the use of async here merely causing a reporting issue? |
@@ -53,6 +53,7 @@ namespace ProtoFFITests
}
[Test]
+ [Category("Failing")]
public void TestDecimals()
{
String code =
| [CSFFIDataMarshalingTest->[Test_Dictionary->[ExecuteAndVerify,Format,AssemblyQualifiedName],TestIEnumerable->[ExecuteAndVerify,Format,AssemblyQualifiedName],TestIEnumerable2->[ExecuteAndVerify,Format,AssemblyQualifiedName],TestCharOutOfRangeWarning->[ExecuteAndVerify,Format,AssemblyQualifiedName],TestByteOutOfRangeWarn... | Performs a simple check of the nanoseconds in the data model. | Is there an associated defect for this? |
@@ -285,7 +285,7 @@ class MyModule < ApplicationRecord
if !final.include?(my_module)
final << my_module
end
- modules.push(*my_module.my_modules.flatten)
+ modules.push(*my_module.my_modules)
end
final
end
| [MyModule->[unassigned_samples->[not],is_one_day_prior?->[is_due_in?,day,current],archive->[x,delete_all,transaction,y,raise,destroy_all,my_module_group],uncomplete->[state,completed_on],unassigned_users->[to_s,find_by_sql],protocol->[first,count],samples_json_hot->[created_at,full_name,each,present?,t,name,l],restore-... | Get the downstream modules that have a in order. | You've already fixed that in another branch, but OK. |
@@ -22,8 +22,12 @@ type RemoteImageRuntime struct{}
// RemoteRuntime describes a wrapper runtime struct
type RemoteRuntime struct {
+ Conn *varlink.Connection
}
+//func (r *LocalRuntime) LookupContainer(idOrName string) (*Container, error) {
+// if _, err := runtime.Runtime.LookupContainer(args[0]); err != nil {... | [LoadFromArchiveReference->[NewImageFromLocal],New->[NewImageFromLocal],TagImage->[ID,TagImage],Dangling->[Names],RemoveImage->[RemoveImage]] | GetRuntime returns a local runtime with the embedded runtime embedded in it. imageInListToContainerImage returns a list of images that are in the list of images in. | Just delete these. |
@@ -1370,6 +1370,16 @@ func TestErrorWhenProjectUpdateIDNotSent(t *testing.T) {
}
func TestStartProjectUpdateWhenIDIsSent(t *testing.T) {
+ var lastEventSent *automate_event.EventMsg
+ localSuite := NewLocalSuite(t)
+ defer localSuite.GlobalTeardown()
+ localSuite.EventServiceClientMock.EXPECT().Publish(gomock.Any(... | [InsertInspecReports,InsertInspecSummaries,Error,WaitForESJobToComplete,NotNil,DeleteAllDocuments,Nil,GetAllSummaryESInSpecSummary,Equal,GetBoolValue,RefreshIndices,NoError,Sleep,GetAllReportsESInSpecReport,Sprintf,Background,GetStringValue,TimestampNow,HandleEvent,UpdateSummaryProjectsTags,ElementsMatch,Run,UpdateRepo... | TestStartProjectUpdateWhenIDIsSent creates a new automate_event. EventMsg TestTwoUpdateSameTimeFailureEvent tests if two update same time failure event is received. | Here we need to use a locally created suite because we need access to the latest Event published. |
@@ -143,10 +143,11 @@ public class InDimFilter extends AbstractOptimizableDimFilter implements Filter
// The values set can be huge. Try to avoid copying the set if possible.
// Note that we may still need to copy values to a list for caching. See getCacheKey().
- if ((NullHandling.sqlCompatible() || val... | [InDimFilter->[makeVectorMatcher->[makeMatcher],supportsSelectivityEstimation->[supportsSelectivityEstimation],optimize->[getExtractionFn],equals->[equals],rewriteRequiredColumns->[InDimFilter],shouldUseBitmapIndex->[shouldUseBitmapIndex],estimateSelectivity->[estimateSelectivity],optimizeLookup->[InDimFilter,equals],g... | Construct a new instance of the class. Get the extraction function filterTuning and cache key for a given . | Nice finding, but this can lead to incorrect result in default mode since `null` will be always added no matter whether an empty string is in `values` or not. |
@@ -474,7 +474,7 @@ public class TerritoryAttachment extends DefaultAttachment {
m_whenCapturedByGoesTo = value;
}
- public ArrayList<String> getWhenCapturedByGoesTo() {
+ private ArrayList<String> getWhenCapturedByGoesTo() {
return m_whenCapturedByGoesTo;
}
| [TerritoryAttachment->[getUnitProduction->[getUnitProduction,get],setChangeUnitOwners->[add],getWhatTerritoriesThisIsUsedInConvoysFor->[getConvoyRoute,get,add],setWhenCapturedByGoesTo->[add],setCaptureUnitOnEnteringBy->[add],getProduction->[getProduction,get],setConvoyAttached->[add],toStringForInfo->[getOriginalOwner,... | Sets the whenCapturedByGoesTo property. | With this method now private (and all other usages not using ArrayList explicitly) could we set the type to just use the List (or even Collection) interface? As long as the implementation isn't changed this shouldn't be an issue until the next incompatible release. |
@@ -337,7 +337,10 @@ function triggerResizeRequest(width, height) {
}
function triggerRenderStart() {
- nonSensitiveDataPostMessage('render-start');
+ if (!window.context.isRenderStartSent) {
+ nonSensitiveDataPostMessage('render-start');
+ window.context.isRenderStartSent = true;
+ }
}
/**
| [No CFG could be retrieved] | Registers a callback that will be called when an AMP message is received. The page visibilitychange event is dispatched to the AMP. | Does this really need to be guarded? |
@@ -402,7 +402,7 @@ func BenchmarkV2FilterAuthorizedPairsRealWorldExample(b *testing.B) {
var resp []engine.Pair
var err error
for n := 0; n < b.N; n++ {
- resp, err = s.V2FilterAuthorizedPairs(ctx, append([]string{"user:local:test@example.com"}, randomTeams(count)...), pairs, true)
+ resp, err = s.V2... | [FilterAuthorizedPairs,V2FilterAuthorizedPairs,NewObject,Resource,Now,InterfaceToValue,Close,Compile,initPartialResultV2,Error,IsAuthorized,initPartialResult,NewTerm,Subject,ParseModule,Unix,NewLogger,Failed,NoError,NewCompiler,Seed,V2IsAuthorized,Action,Println,Sprintf,Background,Unmarshal,String,Fatal,Open,NewFromObj... | BenchmarkInitPartialResultV2 is a benchmark function that initializes a partial result object with the BenchmarkInitPartialResultV2 benchmarks the initialization of partial result of the policy. | pretty sure `V2FilterAuthorizedPairs` should be dropped too. it's used for introspection on v2 only. (@msorens can you confirm?) |
@@ -161,11 +161,12 @@ namespace Content.Server.GameObjects.EntitySystems.Atmos
}
var tileData = new List<GasData>();
+ var atmosSystem = Get<AtmosphereSystem>();
for (byte i = 0; i < Atmospherics.TotalNumberOfGases; i++)
{
- var gas = Atm... | [GasTileOverlaySystem->[Shutdown->[Shutdown],Initialize->[Initialize],Update->[GetChunksInRange,TryRefreshTile,Update]]] | Try refresh tile. | I'd rather you cache this. |
@@ -356,13 +356,9 @@ def _build_multi_keys_spec(content_type, unit_keys_dicts):
missing_keys = key_fields_set.difference(keys_dict_set)
if missing_keys:
keys_errors.append(missing_keys_msg % {'a': ','.join(missing_keys), 'b': ','.join(key_fields)})
- if extra_keys or missing_keys:
... | [_build_multi_keys_spec->[_flatten_keys],ContentQueryManager->[request_content_unit_file_path->[get_root_content_dir]],_flatten_keys->[_flatten_keys]] | Build a spec document for a query on a given content type collection out of multiple content unit Missing key - value pair in the template. | I like that in addition the being more correct, this is a lot easier to understand. |
@@ -103,6 +103,7 @@ class RawBrainVision(BaseRaw):
# Get annotations from vmrk file
annots = read_annotations(mrk_fname, info['sfreq'])
self.set_annotations(annots)
+ _check_update_montage(self.info, montage, raise_missing=False)
def _read_segment_file(self, data, idx, fi, start... | [_aux_vhdr_info->[_check_hdr_version],read_raw_brainvision->[RawBrainVision],_get_vhdr_info->[_aux_vhdr_info,_str_to_meas_date],_read_annotations_brainvision->[_read_vmrk]] | Initialize a raw BrainVision object from a VHDR file. Read a chunk of raw data. | This is not yet `self.set_montage`, I thought that was the plan? |
@@ -86,7 +86,6 @@ func testLinksAsUser(userName string, t *testing.T) {
"/",
"/user/forgot_password",
"/api/swagger",
- "/api/v1/swagger",
"/issues",
"/issues?type=your_repositories&repos=[0]&sort=&state=open",
"/issues?type=assigned&repos=[0]&sort=&state=open",
| [EqualValues,Join,Sprintf,MakeRequest,RedirectURL] | TestLinksAsUser tests that the user has a link to the login page. This function is used to generate a list of all the possible paths that are available in the. | should redirect to `/api/swagger` but redirects to `//api/swagger` --> need fix |
@@ -58,12 +58,12 @@ func SendChatInviteWelcomeMessage(ctx context.Context, g *libkb.GlobalContext, t
return false
}
- inviterName, err := g.GetUPAKLoader().LookupUsername(ctx, inviter)
+ inviterName, err := g.GetUPAKLoader().LookupUsernameUPAKLite(ctx, inviter)
if err != nil {
g.Log.CDebugf(ctx, "sendChatIn... | [NewMessageSystemWithAddedtoteam,NewMessageSystemWithInviteaddedtoteam,GetUsername,Error,StartStandaloneChat,CDebugf,SendSystemChatMessages,LookupUsername,NewMessageSystemWithCreateteam,SendMsgByName,G,NewMessageBodyWithSystem,NewMessageSystemWithChangeavatar,Ctx,CWarningf,String,Errorf,GetUPAKLoader] | SendChatInviteWelcomeMessage sends a welcome message to a user in the chat system. SendTeamChatCreateMessage sends a message to a team. | how does this not use upak lite in prod? |
@@ -46,6 +46,7 @@ public class TestStorageSchemes {
assertFalse(StorageSchemes.isAppendSupported("dbfs"));
assertFalse(StorageSchemes.isAppendSupported("cos"));
assertFalse(StorageSchemes.isAppendSupported("bos"));
+ assertFalse(StorageSchemes.isAppendSupported("ks3"));
assertTrue(StorageSchemes.isA... | [TestStorageSchemes->[testStorageSchemes->[assertTrue,isAppendSupported,assertThrows,isSchemeSupported,assertFalse]]] | Checks that the scheme is supported. | the indent was off here |
@@ -434,9 +434,10 @@ class _ExecutorServiceParallelExecutor(object):
raise an exception.
"""
- def __init__(self, exception=None):
- self.finished = exception is not None
- self.exception = exception
+ def __init__(self, exc_info=(None, None, None)):
+ self.finished = exc_info[0] is not... | [_CompletionCallback->[handle_result->[handle_result]],ExecutorService->[shutdown->[shutdown],ExecutorServiceWorker->[run->[_get_task_or_none,_update_name]],__init__->[ExecutorServiceWorker]],Executor->[start->[start],await_completion->[await_completion]],_ExecutorServiceParallelExecutor->[await_completion->[shutdown],... | Initialize a sequence of sequence numbers. | What is the meaning of `exc_info[1] or exc_info[0]` ? |
@@ -213,6 +213,7 @@ function settings_post(App $a)
check_form_security_token_redirectOnErr('/settings/connectors', 'settings_connectors');
if (x($_POST, 'general-submit')) {
+ PConfig::set(local_user(), 'social', 'disable_cw', intval($_POST['disable_cw']));
PConfig::set(local_user(), 'system', 'no_intelli... | [settings_content->[get_hostname,get_path],settings_post->[discover]] | POST settings for the user Update a client s security token. This function is called when the user is not authorized to submit a new mail. Updates the mailaccount in the database. This function is called when the user is connected with the email account. | Concerning the category of the config value: Normally "system" is used for every core setting. Addon settings are using the addon name as category. |
@@ -27,8 +27,14 @@ class Mnist(torch.nn.Module):
return num_zero_filters, num_filters, float(num_zero_filters)/num_filters
def print_conv_filter_sparsity(self):
- conv1_data = self._get_conv_weight_sparsity(self.conv1)
- conv2_data = self._get_conv_weight_sparsity(self.conv2)
+ if i... | [main->[print_conv_filter_sparsity,train,test,Mnist],train->[print_conv_filter_sparsity,train],Mnist->[print_conv_filter_sparsity->[_get_conv_weight_sparsity]],main] | Print the convolution filter sparsity. | a little confused, you get sparsity from weight rather than mask? |
@@ -62,7 +62,7 @@ def assert_built(
assert sorted(result_files) == sorted(expected.values())
-def test_build_internal_pkg(rule_runner: RuleRunner) -> None:
+def test_build_internal_pkg_target(rule_runner: RuleRunner) -> None:
rule_runner.write_files(
{
"go.mod": dedent(
| [test_build_dependencies->[assert_built],test_build_external_pkg->[assert_built],test_build_internal_pkg->[assert_built]] | Test build internal pkg. | I debated if these tests should do `Get(BuildGoPackageRequest, BuildGoPackageTargetRequest)` rather than `Get(BuiltGoPackage, BuildGoPackageTargetRequest)`? This gives us more of an integration test, rather than unit test. Another option is to test both? |
@@ -217,7 +217,12 @@ def generate_c_type_stub(module: ModuleType,
if not any(issubclass(b, base) for b in bases):
bases.append(base)
if bases:
- bases_str = '(%s)' % ', '.join(base.__name__ for base in bases)
+ bases_str = '(%s)' % ', '.join(
+ strip_or_import(
+ ... | [generate_c_type_stub->[generate_c_property_stub,is_c_method,is_c_classmethod,generate_c_function_stub,is_c_property_readonly,is_c_property]] | Generate a C type stub. This function is used to generate a list of missing nodes in order to avoid duplicate nodes in. | I'd move this `)` to the previous line -- somehow for function calls (unlike list/dict displays) we like the close parenthesis right after the last argument. But the `for` clause should stay on its own line. |
@@ -191,6 +191,7 @@ public abstract class AbstractAuthorization {
@Test
public void testExecScripts() {
+ SkipJunit.skipSinceJDK(16);
InfinispanServerTestMethodRule serverTest = getServerTest();
RemoteCache cache = serverTest.hotrod().withClientConfiguration(hotRodBuilders.get(TestUser.ADMI... | [AbstractAuthorization->[testExecScripts->[getServerTest],testScriptUpload->[getServerTest]]] | Test script execution. | Don't we still need to test this functionality with 17? |
@@ -121,7 +121,14 @@ class Optimizer(Registrable):
else:
num_parameters += parameter_group.numel()
logger.info("Number of trainable parameters: %s", num_parameters)
- return Optimizer.by_name(optimizer)(parameter_groups, **params.as_dict()) # type: ignore
+
+ # By de... | [DenseSparseAdam->[step->[make_sparse,_safe_sparse_mask]]] | Create a new optimizer from a list of model parameters and a list of params. Construct a new k - node node based on the parameters. | Nit: "your "trainer.optimizer" config"?. Also, it'd be nice if this were discoverable somehow, but that's a more general problem that I'm not sure how to solve... |
@@ -53,8 +53,7 @@ public class ManualEvictionWithPassivationAndSizeBasedAndConcurrentOperationsInB
CacheLoader<Object, Object> loader = TestingUtil.getFirstLoader(cache);
assertNotNull("Key " + key + " does not exist in data container", entry);
assertEquals("Wrong value for key " + key + " in data ... | [ManualEvictionWithPassivationAndSizeBasedAndConcurrentOperationsInBackupOwnerTest->[assertNotInMemory->[assertNotNull,getValue,loadEntry,getDataContainer,get,assertNull,getFirstLoader,assertEquals],assertInMemory->[assertNotNull,getValue,loadEntry,getDataContainer,get,assertNull,getFirstLoader,assertEquals],initialize... | Checks that the given key and value are in the cache. | That is just how the test was originally. I think it was trying to guarantee that it was also guaranteeing passivation rules of the entry must be in one but not the other. |
@@ -269,7 +269,9 @@ namespace System.IO
}
else
{
+#pragma warning disable CA1416 // Validate platform compatibility, need proper handling
semaphore.Wait();
+#pragma warning restore CA1416
}
// Create the task to asynchronously do a Read... | [Stream->[BlockingEndRead->[EndRead],BlockingEndWrite->[EndWrite],WriteByte->[Write],IAsyncResult->[Read,Write],CopyTo->[CopyTo],SyncStream->[Flush->[Flush],WriteByte->[WriteByte],Write->[Write],Seek->[Seek],EndWrite->[EndWrite],Read->[Read],ReadByte->[ReadByte],Close->[Close,Dispose],Dispose->[Dispose],SetLength->[Set... | BeginReadInternal is called from the BeginRead method of the base IStream interface. if there is a semaphore task in the queue and there is no semaphore task in the queue. | Please create an issue and link it, we have to block the API or fix it |
@@ -162,6 +162,8 @@ final class DocumentationNormalizer implements NormalizerInterface
}
}
+ $pathOperation = $this->updateGetOperation($pathOperation, $mimeTypes, $subresourceOperation['collection'] ? OperationType::COLLECTION : OperationType::ITEM, $subResourceMe... | [DocumentationNormalizer->[getDefinitionSchema->[normalize],getFiltersParameters->[getType],getType->[getDefinition,getType]]] | Normalizes an object into a JSON - LD array. Compute the response document. | I'm really unsure. A subresource is a new operation, why should it inherit from another operation? |
@@ -102,6 +102,13 @@ import java.util.List;
* implement all abstract methods properly.
*/
public abstract class HttpObjectDecoder extends ByteToMessageDecoder {
+ public static final int DEFAULT_MAX_INITIAL_LINE_LENGTH = 4096;
+ public static final int DEFAULT_MAX_HEADER_SIZE = 8192;
+ public static final... | [HttpObjectDecoder->[userEventTriggered->[userEventTriggered],LineParser->[parse->[reset,parse],process->[increaseCount,process]],readHeaders->[isContentAlwaysEmpty],resetNow->[isSwitchingToNonHttp1Protocol,reset],splitHeader->[isDecodingRequest],HeaderParser->[parse->[reset]],decodeLast->[decodeLast]]] | A decoder that decodes a single object from the HTTP response. The state of the object read. | keep these fields pkg-private to reduce public API surface area? |
@@ -39,16 +39,13 @@ def compute_raw_psd(raw, tmin=0., tmax=np.inf, picks=None,
n_fft : int
The length of the tapers ie. the windows. The smaller
it is the smoother are the PSDs.
- pad_to : int | None
- The number of points to which the data segment is padded when
- performing the... | [compute_raw_psd->[max,set_xlabel,set_ylabel,std,where,info,parallel,int,log10,min,fill_between,dot,plot,parallel_func,mean,time_as_index,float,make_projector_info,logical_and,my_pwelch,array],_pwelch->[welch],_compute_psd->[psd,array],compute_epochs_psd->[int,parallel_func,array,my_psd,close,info,float,pick_types,figu... | Compute the power spectral density with average periodograms. Plots a series of the non - overlapping non - overlapping non - overlapping non - overlapping non. | docstring is not uptodate |
@@ -15,15 +15,12 @@ using Internal.Runtime.CompilerServices;
#pragma warning disable SA1121 // explicitly using type aliases instead of built-in types
#if SYSTEM_PRIVATE_CORELIB
#if TARGET_64BIT
-using nint = System.Int64;
-using nuint = System.UInt64;
+using nuint_t = System.UInt64;
#else // TARGET_64BIT
-using ni... | [No CFG could be retrieved] | Creates a new object containing the contents of a single non - zero length byte array. Get the pointer to the first invalid character in the input buffer. | These aliases didn't go away? |
@@ -4593,6 +4593,7 @@ static void apple2_cards(device_slot_interface &device)
device.option_add("uthernet", A2BUS_UTHERNET); /* A2RetroSystems Uthernet card */
device.option_add("sider2", A2BUS_SIDER2); /* Advanced Tech Systems / First Class Peripherals Sider 2 SASI card */
device.option_add("sider1", A2BUS_SIDE... | [No CFG could be retrieved] | Add options for A2BUS. - - - - - - - - - - - - - - - - - -. | Should this also be added for the IIgs and possibly other Apple 2 families? There are lists of slot options hiding all over the place for Apple II cards. |
@@ -187,7 +187,7 @@ public class LocalCommandsTest {
}
@Test
- public void shouldFailToCleanup() throws IOException {
+ public void shouldNotFailToCleanup() throws IOException {
// Given
final File dir = commandsDir.newFolder();
LocalCommands localCommands = LocalCommands.open(ksqlEngine, dir);... | [LocalCommandsTest->[shouldThrowWhenCommandLocationIsNotWritable->[getMessage,setPosixFilePermissions,open,containsString,format,assertThrows,fromString,assertThat,getAbsolutePath,toPath,newFolder],shouldWriteAppIdToCommandFile->[any,write,of,assertThat,processLocalCommandFiles,toList,size,anyMatch,equals,cleanupOrphan... | Checks if there is a missing local commands in the commands directory and if so deletes the missing. | Might want to simulate errors on calling LocalCommandFile.readRecords() which I think is what happened in practice. |
@@ -239,6 +239,8 @@ const (
LabelScheduler = "scheduler"
// LabelExtensionProjectRole is a constant for a label value for extension project roles
LabelExtensionProjectRole = "extension-project-role"
+ // LabelResourceManager is a constant for a label value for the gardener-resource-manager.
+ LabelResourceManager... | [No CFG could be retrieved] | Returns a string that represents the label key of a Garden cluster. The alert annotation for the cluster should be ignored. | Why is this here? It should be better in the `resourcemanager` package, or? |
@@ -172,6 +172,15 @@ public class AMQPConnectionContext extends ProtonInitializable implements EventH
}
}
+ public LinkCloseListener getLinkCloseListener() {
+ return linkCloseListener;
+ }
+
+ public AMQPConnectionContext setLinkCloseListener(LinkCloseListener linkCloseListener) {
+ this.l... | [AMQPConnectionContext->[checkDataReceived->[checkDataReceived],onFlow->[onFlow],runNow->[runNow],onAuthFailed->[close],onAuthInit->[close],pushBytes->[onTransport],onLocalDetach->[close],LocalSecurity->[getSecurityDomain->[getSecurityDomain],getUsername->[getSASLResult],getPassword->[getPassword,getSASLResult]],getAmq... | Checks if this connection is a bridge connection. | Does this also handle detaches with closed=false? LinkDetachListener that takes a boolean might be more widely applicable. |
@@ -704,10 +704,14 @@ func (m *FlipManager) parseMultiDie(arg string, nPlayersApprox int) (start flip.
return flip.NewStartWithBigInt(m.clock.Now(), val, nPlayersApprox), nil
}
+const shuffleSeparaters = ",，"
+
func (m *FlipManager) parseShuffle(arg string, nPlayersApprox int) (start flip.Start, metadata flipText... | [startFromText->[parseShuffle,parseMultiDie,parseSpecials,parseRange],MaybeInjectFlipMessage->[shouldIgnoreInject,getHostMessageInfo,isHostMessageInfoMsgID,updateActiveGame],injectIncomingChat->[recordConvParticipation,isStartMsgID],handleUpdate->[queueDirtyGameID,finalizeParticipants,formatError,addParticipant,addResu... | parseMultiDie parses a multi - die command line argument and returns a flip. Start object. | is there a space in there? |
@@ -433,7 +433,10 @@ class TorchGeneratorAgent(TorchAgent):
if self.use_cuda and (force or not hasattr(self, 'buffer_initialized')):
try:
loss = self.compute_loss(self._dummy_batch(batchsize, maxlen))
- loss.backward()
+ if self.fp16:
+ ... | [TorchGeneratorAgent->[_init_cuda_buffer->[_dummy_batch],compute_loss->[_model_input],beam_search->[reorder_encoder_states,_model_input,reorder_decoder_incremental_state],_write_beam_dots->[_v2t],eval_step->[decode_forced,reorder_encoder_states,compute_loss,_write_beam_dots,_v2t,_model_input],train_step->[_init_cuda_bu... | Pre - initialize CUDA buffer by doing fake forward pass. | @emilydinan what's your opinion? Is it worth building a `def backward(self, loss)` into TorchAgent so that this is abstracted? |
@@ -915,6 +915,11 @@ class GContact
intval($uid)
);
+ if (!DBA::isResult($r)) {
+ logger('Cannot find user with uid=' . $uid, LOGGER_INFO);
+ return false;
+ }
+
$location = Profile::formatLocation(
["locality" => $r[0]["locality"], "region" => $r[0]["region"], "country-name" => $r[0]["country-nam... | [No CFG could be retrieved] | Updates a user s neccessary data in the profile. This function is called by the network - level code to update the network - level configuration. | I added this block, @annando @MrPetovan @tobiasd |
@@ -37,10 +37,12 @@ trait ClassInfoTrait
*/
private function getRealClassName(string $className): string
{
+ $positionCg = strrpos($className, '\\__CG__\\');
+ $positionPm = strrpos($className, '\\__PM__\\');
+
// __CG__: Doctrine Common Marker for Proxy (ODM < 2.0 and ORM < 3.0)
... | [getObjectClass->[getRealClassName]] | Returns the real class name of a class with the special case of the base class name. | Which tool is asking to change this? It's a little less elegant and a little less fast. |
@@ -212,7 +212,9 @@ func (p *postgres) GetTeams(ctx context.Context) ([]storage.Team, error) {
var teams []storage.Team
// TODO eventually these should be ordered
rows, err := p.db.QueryContext(ctx,
- `SELECT t.id, t.name, t.description, t.projects, t.updated_at, t.created_at FROM teams t WHERE projects_match(t.... | [GetTeam->[getTeam],StoreTeam->[StoreTeamWithProjects],getTeam->[Scan,processError,Array,QueryRowContext],processError->[Debugf],RemoveUsers->[getTeam,processError,RowsAffected,Commit,WithCancel,touchTeam,BeginTx,ExecContext,Array],StoreTeamWithProjects->[Scan,processError,Array,QueryRowContext],DeleteTeam->[Scan,proce... | GetTeams returns a list of teams in the database. | Drive-by: is this still accurate? Do we have a card for it? |
@@ -161,4 +161,17 @@ public class InterpreterGroup {
public int hashCode() {
return id != null ? id.hashCode() : 0;
}
+
+ public void close() {
+ for (List<Interpreter> session : sessions.values()) {
+ for (Interpreter interpreter : session) {
+ try {
+ interpreter.close();
+ ... | [InterpreterGroup->[addInterpreterToSession->[put,get],equals->[equals],values->[values],hashCode->[hashCode],get->[get],put->[put],isEmpty->[isEmpty]]] | Returns the hashCode of this node. | would the exception stack be useful? just to LOGGER.warn( .... , e);? |
@@ -19,6 +19,15 @@ from raiden_contracts.constants import ChannelEvent
@pytest.mark.parametrize('number_of_nodes', [2])
@pytest.mark.parametrize('number_of_tokens', [1])
def test_token_addresses(raiden_network, token_addresses):
+ raise_on_failure(
+ raiden_network,
+ run_test_token_addresses,
+ ... | [test_raidenapi_channel_lifecycle->[get_channel_list,get_blockchain_events_channel,get_blockchain_events_token_network,wait_for_state_change,must_have_event,get_token_network_identifier_by_token_address,len,get_channelstate,get_status,set_total_channel_deposit,channel_close,RaidenAPI,state_from_app,raises,channel_open,... | Test that the list of token addresses is the same as the list of token addresses in the. | Hmm, that would introduce a new convention where the `test_*` functions would have this call and the `run_test_*` functions actually run the tests. I believe the better approach to go about this is to have `raise_on_failure` be a decorator function. |
@@ -37,6 +37,8 @@ public abstract class BasePublisher<T> implements Publisher<T> {
private Subscriber<? super T> subscriber;
private long demand;
private boolean cancelled;
+ private boolean sentComplete;
+ private Exception failure;
public BasePublisher(final Context ctx) {
this.ctx = Objects.requ... | [BasePublisher->[Sub->[cancel->[doCancel],request->[doRequest]],doClose->[sendComplete],checkContext->[checkContext],sendError->[checkContext],doRequest->[maybeSend,sendError],doSubscribe->[afterSubscribe,sendError]]] | Creates a base publisher for a given type of object. Close the context. | I think cancelled can be removed completely now? |
@@ -0,0 +1,16 @@
+import { htmlSafe } from "@ember/template";
+import { registerUnbound } from "discourse-common/lib/helpers";
+
+export default registerUnbound(
+ "directory-item-user-field-value",
+ function (args) {
+ // Args should include key/values { item, column }
+
+ const value =
+ args.item.user ... | [No CFG could be retrieved] | No Summary Found. | I wonder if these helpers might be better as simple components. I'm on the fence. I suspect we can try it for now. |
@@ -154,6 +154,8 @@ def matches_all(expected):
the elements of a single PCollection.
"""
def _matches(actual):
+ from hamcrest.core import assert_that as hamcrest_assert
+ from hamcrest.library.collection import contains_inanyorder
expected_list = list(expected)
hamcrest_assert(actual, co... | [assert_that->[AssertThat->[expand->[AddWindow,ReifyTimestampWindow]],AssertThat],equal_to->[_equal->[BeamAssertException]],contains_in_any_order->[InAnyOrder],is_not_empty->[_not_empty->[BeamAssertException]],equal_to_per_window->[matcher->[BeamAssertException]],is_empty->[_empty->[BeamAssertException]]] | Matcher used by assert_that to check that a list of elements or hamcrest. | Would this break users if they use assert and they are not aware that they need to pre-install hamcrest as an extra dependency? |
@@ -81,7 +81,7 @@ public class AbstractIndexCountBasedRetentionStrategyTest {
}
@Override
- protected void retain(String indexName, IndexSet indexSet) {
+ protected void retain(List indexName, IndexSet indexSet) {
}
| [AbstractIndexCountBasedRetentionStrategyTest->[shouldRetainOldestIndex->[retain],shouldRetainOldestIndices->[retain],shouldIgnoreWriteAliasWhenDeterminingRetainedIndices->[retain],shouldIgnoreReopenedIndexWhenCountingAgainstLimit->[retain],shouldIgnoreReopenedIndexWhenDeterminingRetainedIndices->[retain]]] | Sets up the index map. | Please use a generic type here. IntelliJ also should've marked this as a warning |
@@ -270,8 +270,15 @@ public class DruidSchema extends AbstractSchema
// Add missing segments back to the refresh list.
segmentsNeedingRefresh.addAll(Sets.difference(segmentsToRefresh, refreshed));
+ // remove any tables which have been completely dropped before r... | [DruidSchema->[getFunctionMultimap->[build,put,entrySet,builder],timelineInitialized->[notifyAll],start->[notifyAll,max,equals,refreshSegments,getRowSignature,isAwaitInitializationOnStart,nanoTime,addAll,warn,info,put,countDown,getSimpleName,add,emit,isGlobal,isInterrupted,getDataSource,isEmpty,getMillis,submit,buildDr... | Starts the thread that periodically refreshes the segments. Add our segments and dataSources back to the refresh list and rebuild lists. Checks if the class has been initialized. If so waits for initialization. | This looks like it's undoing a mistake in removeSegment - the datasource should never have been added to dataSourcesNeedingRebuild in the first place. IMO it'd be better to make the change there. Doing it here works, though, so I'm OK with it if you don't want to move the logic around. |
@@ -28,6 +28,14 @@ def get_ancestors_from_cache(category, context):
return category.get_ancestors()
+class TranslatedModel(object):
+
+ @classmethod
+ def get_node(cls, id, context, info):
+ node = super(TranslatedModel, cls).get_node(id, context, info)
+ return node.translated
+
+
cla... | [Query->[resolve_root->[Query]],ProductType->[resolve_availability->[ProductAvailabilityType]],CategoryType->[resolve_url->[get_ancestors_from_cache],resolve_ancestors->[get_ancestors_from_cache],resolve_products->[filter_by_price]]] | A list of all the products in a category. Get the first image of a node. | Why is this needed? |
@@ -936,6 +936,10 @@ export class AmpStory extends AMP.BaseElement {
* @private
*/
setHistoryStatePageId_(pageId) {
+ // Never save ad pages to history as they are unique to each visit.
+ if (pageId.slice(0, AD_PAGE_ID_PREFIX.length) === AD_PAGE_ID_PREFIX) {
+ return;
+ }
const history = t... | [AmpStory->[buildSystemLayer_->[element],assertAmpStoryExperiment_->[AMP_STORY_EXPERIMENT_ENABLED_TEXT,user,toggleExperiment,removeElement,textContent,appendChild,classList,AMP_STORY_WARNING_EXPERIMENT_DISABLED_TEXT,addEventListener,AMP_STORY_EXPERIMENT_ENABLE_BUTTON_LABEL],registerAndPreloadBackgroundAudio_->[upgradeB... | Set the current history state page id. | Hmm... Can we instead get page by id and check `isAd`? |
@@ -515,13 +515,6 @@ namespace Dynamo.ViewModels
return new RunCancelCommand(showErrors, cancelRun);
}
- internal static RecordableCommand DeserializeCoreFromDynamic(dynamic jsonObj)
- {
- bool ShowErrors = Convert.ToBoolean(jsonObj["ShowErrors"]);
- ... | [DynamoViewModel->[CreateCustomNodeCommand->[setProperties],CreateNoteCommand->[setProperties],MakeConnectionCommand->[setProperties],CreateNodeCommand->[setProperties],OpenFileCommand->[]]] | Deserialize a core command from an XML element. | old piece of code that is not needed anymore |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.