patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -4793,7 +4793,7 @@ ByteCodeGenerator::GetLdSlotOp(Scope *scope, int envIndex, Js::RegSlot scopeLoca
return op;
}
-void ByteCodeGenerator::EmitPropLoad(Js::RegSlot lhsLocation, Symbol *sym, IdentPtr pid, FuncInfo *funcInfo)
+void ByteCodeGenerator::EmitPropLoad(Js::RegSlot lhsLocation, Symbol *sym, IdentPtr p... | [No CFG could be retrieved] | Gets the next non - global or global slot in the closure environment. Returns a variable that can be used to create a new variable in the given scope. | Is it not possible to figure out that the scope we're loading from is the param scope and dispense with the extra flag parameter? |
@@ -138,16 +138,6 @@ module Users
permit(:password, :reset_password_token)
end
- def redirect_without_token_url(token)
- session[:reset_password_token] = token
- redirect_to url_for
- end
-
- def prevent_token_leakage
- token = validated_token_from_url
- redirect_without_tok... | [ResetPasswordsController->[update->[new],build_user->[new],edit->[new],create->[new],new->[new],prevent_token_leakage->[redirect_without_token_url]]] | user_params - user params that can be reset password. | I think you also meant to remove the `validated_token_from_url` method. |
@@ -0,0 +1,15 @@
+package gobblin.compaction.parser;
+
+import gobblin.configuration.State;
+import gobblin.dataset.Dataset;
+import lombok.AllArgsConstructor;
+
+/**
+ * A parser class which can convert a given {@link Dataset} to any object defined by user
+ */
+@AllArgsConstructor
+public abstract class CompactionPar... | [No CFG could be retrieved] | No Summary Found. | CompactionParser -> AttributesParser or AttributesExtractor? |
@@ -117,7 +117,9 @@ module PhoneConfirmationFlow
def current_otp_method
query_method = params[:otp_method]
- query_method.to_sym if
- %w(sms voice totp).include? query_method
+
+ return :sms unless %w(sms voice totp).include? query_method
+
+ query_method.to_sym
end
end
| [fallback_confirmation_link->[this_send_confirmation_code_path]] | Returns the current OTP method if it exists. | This change is needed in order for the new controller code to always receive a valid Active Job class. In a subsequent PR, ensuring this will be accomplished via a Form Object with validations that will make sure only accepted delivery methods are submitted. |
@@ -186,7 +186,7 @@ namespace System.IO
return UnixTimeToDateTimeOffset(_fileStatus.CTime, _fileStatus.CTimeNsec);
}
- internal void SetCreationTime(string path, DateTimeOffset time)
+ private void SetCreationTime_OtherUnix(string path, DateTimeOffset time)
{
... | [FileStatus->[FileAttributes->[IsReadOnly],EnsureStatInitialized->[Refresh]]] | GetCreationTime - Gets the creation time of a file or directory. | This renaming does not make sense, since this is the `Unix` file. Shouldn't the methods in the _new_ file be the ones named with the `_OtherUnix` prefix? |
@@ -172,10 +172,9 @@ func (t *UpgradeTest) Teardown(f *framework.Framework) {
func startEndpointMonitoring(ctx context.Context, m *monitor.Monitor, svc *v1.Service, r events.EventRecorder) error {
tcpIngressIP := service.GetIngressPoint(&svc.Status.LoadBalancer.Ingress[0])
svcPort := int(svc.Spec.Ports[0].Port)
-
... | [Setup->[ConfigV1,ClientConfig,ExpectNoError,WaitForLoadBalancer,AddRCAntiAffinity,By,CreatePDB,GetIngressPoint,Background,GetServiceLoadBalancerCreationTimeout,NewForConfig,CreateTCPService,Get,Run,NewTestJig,Infrastructures],Test->[ExpectNoError,LoadClientset,StartRecordingToSink,EventsV1,By,WaitForServiceDeletedWith... | Teardown cleans up all resources that are not part of the current state of the service Next is a callback that will return the next condition if there is a previous condition. | does this close the resp.Body()? |
@@ -65,7 +65,9 @@ export default class Selftest extends Component {
if (typeof navigator !== 'undefined' && navigator.product === 'ReactNative') {
const aezeed = new HDAezeedWallet();
- aezeed.setSecret('abstract rhythm weird food attract treat mosquito sight royal actor surround ride strike re... | [No CFG could be retrieved] | This is a RN - specific test. Assert strict equality of the address of the network. | that should not be changed |
@@ -88,6 +88,7 @@ public interface BattleStep extends IExecutable {
static List<BattleStep> getAll(final BattleState battleState, final BattleActions battleActions) {
return List.of(
+ new RemoveNonCombatantsBeforeAA(battleState, battleActions),
new OffensiveAaFire(battleState, battleActions),... | [getAll->[ClearBombardmentCasualties,CheckStalemateBattleEnd,RemoveGeneralSuicide,DefensiveAaFire,DefensiveFirstStrike,MarkNoMovementLeft,NavalBombardment,RemoveFirstStrikeSuicide,ClearFirstStrikeCasualties,LandParatroopers,OffensiveGeneralRetreat,of,RemoveUnprotectedUnitsGeneral,OffensiveGeneral,DefensiveSubsRetreat,R... | Get all steps in the Battle state. | It would be kinda nice to see 'removeNonCombatants' able to just do its thing and not have a variant that is pre-AA. Having the same battle step listed twice would be fine IMO (ie; this could be a `RemoveNonCombatants`), but the difference is that the object is able to compute at any given time, given a battle state, w... |
@@ -64,7 +64,7 @@ public class PostAnalysisIssueFilterTest {
context = mock(JavaFileScannerContext.class);
when(context.getFile()).thenReturn(inputFile.file());
- when(context.getFileKey()).thenReturn(inputFile.key());
+ when(context.getFileKey()).thenReturn(inputFile.file().getAbsolutePath());
}
... | [PostAnalysisIssueFilterTest->[missing_component_trigger_Exception->[expect,thenReturn,setIssueFilters,File,scanFile],issue_filter_should_set_componentKey_and_scan_every_filter->[isTrue,setIssueFilters,scanFile,isEqualTo],number_of_issue_filters->[hasSize],issue_filter_should_reject_issue_if_any_issue_filter_reject_the... | This method is called before any test. | I think instead of this change, we can simplify code in `org.sonar.java.filters.PostAnalysisIssueFilter#scanFile` to drop the usage of file and rely solely on `context.getInputFile` That way there will be no usage of `getFileKey` in the plugin |
@@ -121,10 +121,11 @@ public class BindLdapAuthenticationHandler extends AbstractLdapUsernamePasswordA
if (test != null) {
return true;
}
+ } catch (final NamingSecurityException e) {
+ log.info("Failed to authenticate user {} with error {... | [BindLdapAuthenticationHandler->[authenticateUsernamePasswordInternal->[handleNameClassPair->[add,getNameInNamespace],executeSearch->[search],getMessage,closeContext,size,warn,info,transform,composeCompleteDnToCheck,handleLdapError,getFilter,getContext,getFilterWithValues,isErrorEnabled,getUsername,isEmpty,getSearchCon... | Method which performs the actual authentication. | Minor adjustment. Shouldn't this be `return test != null`? I realize `return false;` is still required which is annoying of Java, but this would reduce 3 lines down to 1. |
@@ -145,6 +145,9 @@ module.exports = class huobipro extends Exchange {
'api-signature-not-valid': AuthenticationError, // {"status":"error","err-code":"api-signature-not-valid","err-msg":"Signature not valid: Incorrect Access key [Access key错误]","data":null}
'base-record-invalid': Orde... | [No CFG could be retrieved] | Private API for handling errors in order. A dict of all possible currencies that can be used to create a new order. | @brandsimon is there an `err-code` corresponding to this error? |
@@ -8,7 +8,9 @@ from .googlenet import *
from .mobilenet import *
from .mnasnet import *
from .shufflenetv2 import *
+from .efficientnet import *
from . import segmentation
from . import detection
from . import video
from . import quantization
+from .feature_extraction import *
| [No CFG could be retrieved] | Imports all packages that are not part of the MOBI - ENVI network. | Maybe it would be better to do instead `from . import feature_extraction`. This should appease the testing system, and also is probably better for discoverability, although users will need to query `torchvision.models.feature_extraction.build_feature_extractor` instead of `torchvision.models.build_feature_extractor`, w... |
@@ -7,8 +7,8 @@ from mypyc.namegen import (
class TestNameGen(unittest.TestCase):
def test_candidate_suffixes(self) -> None:
- assert candidate_suffixes('foo') == ['', 'foo_']
- assert candidate_suffixes('foo.bar') == ['', 'bar_', 'foo_bar_']
+ assert candidate_suffixes('foo') == ['', 'foo.... | [TestNameGen->[test_exported_name->[exported_name],test_name_generator->[NameGenerator,private_name],test_candidate_suffixes->[candidate_suffixes],test_make_module_translation_map->[make_module_translation_map]]] | Test if the candidate suffixes are the same. | Would it be useful to have an end-to-end test case that has things like triple underscores in names and possible name clashes, such as having names `C.foo` and `C___foo` in the same namespace? |
@@ -25,7 +25,7 @@
* @subpackage Devices
*/
-include_once($config['install_dir'].'/includes/common.inc.php');
+include_once($config['install_dir'].'/includes/common.php');
/**
* Add a new device group
| [No CFG could be retrieved] | Adds a new device group if it does not already exist. Edit a device group s . | This probably can be deleted since it was wrong. |
@@ -141,6 +141,14 @@ func (l TrackLookup) GetEldestKID() keybase1.KID {
return ret
}
+func (l TrackLookup) GetTrackedLinkSeqno() keybase1.Seqno {
+ ret, err := l.link.GetTrackedLinkSeqno()
+ if err != nil {
+ l.G().Log.Warning("Error in lookup of eldest KID: %s", err)
+ }
+ return ret
+}
+
func (l TrackLookup) G... | [GetTmpExpireTime->[GetTmpExpireTime],GetTrackedKeys->[GetTrackedKeys],ToDisplayMarkup->[ToDisplayString],GetCTime->[GetCTime],ToSummary->[IsRemote,GetCTime],IsRemote->[IsRemote],GetProofState->[GetProofState],GetEldestKID->[GetEldestKID],Add,GetCTime] | GetEldestKID returns the eldest KID of the link. | an omission in my diff: "lookup of seq_tail seqno" |
@@ -98,11 +98,11 @@ public abstract class HoodieFlinkTable<T extends HoodieRecordPayload>
* @return instance of {@link HoodieTableMetadataWriter}
*/
@Override
- public Option<HoodieTableMetadataWriter> getMetadataWriter() {
+ public <T extends SpecificRecordBase> Option<HoodieTableMetadataWriter> getMetada... | [HoodieFlinkTable->[create->[create],getMetadataWriter->[create]]] | Returns an Option that can be used to create a HoodieTableMetadataWriter if the. | Where does the passed in `actionMetadata` used ? |
@@ -42,6 +42,7 @@ public class IntermediateLongSupplierSerializer implements LongSupplierSerialize
private final ByteOrder order;
private final CompressedObjectStrategy.CompressionStrategy compression;
private CountingOutputStream tempOut = null;
+ private final ByteBuffer helperBuffer = ByteBuffer.allocate(L... | [IntermediateLongSupplierSerializer->[closeAndConsolidate->[closeAndConsolidate,makeDelegate],writeToChannel->[writeToChannel],makeDelegate->[size,add,open],getSerializedSize->[getSerializedSize],add->[size],close->[close,makeDelegate]]] | Produces an object that can be serialized into a Long object using the specified base name. This class is used to write a count of the elements in the array. | could be problematic if add is called from multiple threads ever |
@@ -193,7 +193,9 @@ public class OpenShiftServiceImpl implements OpenShiftService {
.withNewMetadata().addToLabels("integration", name).endMetadata()
.withNewSpec()
.addNewContainer()
- .withImage(" ").withImagePullPolicy("Always").withName(name)
+ .withI... | [OpenShiftServiceImpl->[removeBuildConfig->[delete],removeDeploymentConfig->[delete],removeImageStreams->[delete],removeSecret->[delete]]] | Creates a new deployment config with the given name and deployment data. Check if there is a spec in the future. | At some point we had an issue with an 0 length string for the image name. Not sure anynmore where. Have you verified that this works ? |
@@ -25,7 +25,10 @@ namespace Microsoft.Xna.Framework
private static readonly Vector2 unitVector = new Vector2(1f, 1f);
private static readonly Vector2 unitXVector = new Vector2(1f, 0f);
private static readonly Vector2 unitYVector = new Vector2(0f, 1f);
-
+ private static readonly Vecto... | [Vector2->[GetHashCode->[GetHashCode],Transform->[Length,Transform],CatmullRom->[CatmullRom],SmoothStep->[SmoothStep],Hermite->[Hermite],Lerp->[Lerp],Barycentric->[Barycentric],Ceiling->[Ceiling],Clamp->[Clamp],LerpPrecise->[LerpPrecise],Equals->[Equals],Round->[Round],TransformNormal->[Length],Floor->[Floor]]] | - A base class for all of the components of a 2D - vector and a Replies the Vector2 of the . | right down and up left are the same vectors? |
@@ -88,7 +88,7 @@ def send_order_confirmation(order_pk, redirect_url, user_pk=None):
order=email_data["context"]["order"],
user=None,
user_pk=user_pk,
- email_type=events.OrderEventsEmails.ORDER,
+ email_type=events.OrderEventsEmails.ORDER_CONFIRMATION,
)
| [collect_data_for_fulfillment_email->[collect_data_for_email],send_fulfillment_update->[collect_data_for_fulfillment_email],send_staff_order_confirmation->[collect_staff_order_notification_data],send_fulfillment_confirmation->[collect_data_for_fulfillment_email],send_payment_confirmation->[collect_data_for_email],send_... | Send order confirmation email. | This is change is probably correct but we need to confirm with @dominik-zeglen if this doesn't break the events UI in the dashboard. I think we use these type fields for rendering there but I'm not sure. |
@@ -82,8 +82,16 @@ public class InputRowListPlusRawValues
return inputRows;
}
+ /**
+ * This method is left here only for test cases
+ */
@Nullable
public Map<String, Object> getRawValues()
+ {
+ return CollectionUtils.isNullOrEmpty(rawValues) ? null : rawValues.get(0);
+ }
+
+ public List<Ma... | [InputRowListPlusRawValues->[of->[of,InputRowListPlusRawValues]]] | Returns the input rows raw values and parse exception. | nit: it would be better to use `Iterables.getOnlyElement(rawValues)` to make sure that you are getting the only element. |
@@ -78,6 +78,10 @@ namespace Dynamo.Updates
/// </summary>
BinaryVersion AvailableVersion { get; }
+ Version HostVersion { get; set; }
+
+ String HostName { get; set; }
+
/// <summary>
/// Returns information, where version can be updated.
/// </summary>
| [UpdateManagerConfiguration->[Save->[OnLog]],DynamoLookUp->[BinaryVersion->[GetDynamoInstallLocations]],UpdateRequest->[ReadResult->[OnLog],UpdateDataAvailable],UpdateManager->[IsDailyBuild->[GetVersionString],OnDownloadFileCompleted->[OnLog],client_DownloadProgressChanged->[OnLog],UpdateManager_PropertyChanged->[OnLog... | Exception object which describes the exception thrown during downloading or updating the given product version. Reads the request s data and parses for available versions. | We need to define a new interface IUpdateManager2 or IUpdateManagerHost or IDynamoHostApplication otherwise, it would break binary compatibility. You can try it yourself, run Dynamo Studio 1.1 with your DynamoCore. |
@@ -151,14 +151,14 @@ module Api
unless assignment.save
# Some error occurred
- render 'shared/http_status', :locals => {:code => '500', :message =>
- HttpStatusHelper::ERROR_CODE['message']['500']}, :status => 500
+ render 'shared/http_status', locals: {code: '500', message:
+ ... | [AssignmentsController->[create->[nil?,render,new,process_attributes,submission_rule,has_missing_params?,get_submission_rule,find_by_short_identifier,build_assignment_stat,save],show->[nil?,xml,render,respond_to,to_json,fields_to_render,json,to_xml,find_by_id],process_attributes->[nil?,new,post?,each,delete],update->[n... | Updates a single node in the system. The default values for the are set if the request is a POST request. These values. | Align the elements of a hash literal if they span more than one line.<br>Space inside } missing. |
@@ -174,12 +174,10 @@ public final class AttributeDefinition<T> {
private boolean immutable = false;
private boolean autoPersist = true;
private boolean global = true;
- private String xmlName;
private AttributeCopier copier = null;
private AttributeInitializer<? extends T> initi... | [AttributeDefinition->[hashCode->[hashCode],validate->[validate],equals->[equals]]] | Creates a builder for a configuration attribute. Sets the initializer for the attribute. | field `xmlName` (line above) unused. |
@@ -52,6 +52,14 @@ namespace Dynamo.Tests
ExecutionEvents.GraphPostExecution -= ExecutionEvents_GraphPostExecution;
}
+ private void DeleteJsonFilesFromTemp(string[] files)
+ {
+ foreach (var file in files)
+ {
+ File.Delete(file);
+ ... | [SerializationTests->[GetDataOfValue->[GetDataOfValue],GetLibrariesToPreload->[GetLibrariesToPreload]]] | TearDown method. | this should probably be made more tolerant, assert that the files actually exist before you try this and check if the deletion succeeds, you may not have permissions when this call is made. |
@@ -54,16 +54,11 @@ define('ENTRY_CREDIT_CARD_OWNER', 'Credit Card Owner:');
define('ENTRY_CREDIT_CARD_NUMBER', 'Credit Card Number:');
define('ENTRY_CREDIT_CARD_CVV', 'Credit Card CVV Number:');
define('ENTRY_CREDIT_CARD_EXPIRES', 'Credit Card Expires:');
-define('ENTRY_SUB_TOTAL', 'Sub-Total:');
-define('ENTRY_TAX... | [No CFG could be retrieved] | Table Header Properties XML Schema Definition. | These email texts are used when sending order status updates. |
@@ -5,8 +5,9 @@ from KratosMultiphysics.CompressiblePotentialFlowApplication import *
# Import Kratos "wrapper" for unittests
import KratosMultiphysics.KratosUnittest as KratosUnittest
-# Import the tests o test_classes to create the suits
-from generalTests import KratosCompressiblePotentialFlowGeneralTests
+# Imp... | [AssambleTestSuites->[TestLoader,addTest,KratosCompressiblePotentialFlowGeneralTests,addTests],AssambleTestSuites,runTests] | AssambleTestSuites - Creates a test suit with the specified test cases. | Unrelated to changes but this has a typo. |
@@ -202,14 +202,16 @@ func resourceAwsEMRCluster() *schema.Resource {
Required: false,
},
"ebs_config": {
- Type: schema.TypeSet,
+ Type: schema.TypeList,
Optional: true,
ForceNew: true,
+ Computed: true,
Elem: &schema.Resource{
Schema: ma... | [StringValueSlice,GetChange,SetPartial,StringSlice,Close,StringValueMap,StringInSlice,RemoveTags,ListInstanceGroups,Partial,HasPrefix,NonRetryableError,Set,ListInstances,Code,GetOkExists,ModifyInstanceGroups,ReadFile,GetOk,DescribeCluster,HasChange,ListBootstrapActions,Errorf,SetTerminationProtection,SetId,RetryableErr... | Kerberos attributes schema returns a schema. Object that can be used to validate a resource in the cluster. | Was this change intentional? If so, we should also set `MaxItems: 1` as well - otherwise we should undo this change as its not reliable to migrate a Terraform state and configuration from a multiple element `TypeSet` to `TypeList`. |
@@ -24,8 +24,9 @@ from prefect.utilities import kubernetes
@pytest.fixture(autouse=True)
def mocked_k8s_config(monkeypatch):
- k8s_config = MagicMock()
- monkeypatch.setattr("kubernetes.config", k8s_config)
+ mock = MagicMock()
+ monkeypatch.setattr("prefect.utilities.kubernetes.kube_config", mock)
+ ... | [test_k8s_agent_manage_jobs_event_logging_handles_bad_timestamps->[Event],TestK8sAgentRunConfig->[test_generate_job_spec_null_or_universal_run_config->[build_flow_run],test_generate_job_spec_service_account_name->[build_flow_run,read_default_template],test_environment_has_api_key_from_disk->[build_flow_run],test_genera... | Mock k8s config and client. | This mock was not working before because the import had already occurred. This replaces `kube_secret` in tests, roughly restoring the old behavior. |
@@ -56,6 +56,11 @@ public abstract class AbstractConfigurationChildBuilder implements Configuration
return builder.balancingStrategy(balancingStrategy);
}
+ @Override
+ public ConfigurationBuilder balancingStrategy(Supplier<FailoverRequestBalancingStrategy> balancingStrategyFactory) {
+ return bui... | [AbstractConfigurationChildBuilder->[transportFactory->[transportFactory],classLoader->[classLoader],connectionTimeout->[connectionTimeout],keySizeEstimate->[keySizeEstimate],withProperties->[withProperties],batchSize->[batchSize],valueSizeEstimate->[valueSizeEstimate],clientIntelligence->[clientIntelligence],tcpNoDela... | This method is used to configure the balancing strategy and the class loader. | Same problem here, this old, deprecated method should take FQN of old `org.infinispan.client.hotrod.impl.transport.tcp.FailoverRequestBalancingStrategy` |
@@ -61,6 +61,9 @@ module Engine
source = @depot.discarded.include?(train) ? 'The Discard' : train.owner.name
+ @game.phase.buying_train!(entity, train)
+
+ @log << delayed_log if delayed_log
@log << "#{entity.name} #{verb} a #{train.name} train for "\
"#{@game.format_curre... | [buy_train_action->[can_buy_train?,must_buy_train?],must_buy_train?->[must_buy_train?]] | buy a train action if it can buy it if it can t buy it if it. | i wonder how if this will break games |
@@ -0,0 +1,9 @@
+<?php
+/**
+ *
+ */
+
+class CKEditorImageSize {
+ public $width;
+ public $height;
+}
| [No CFG could be retrieved] | No Summary Found. | Aside: A very useful value object, but we could move the geometry calcs into it. E.g. add it to core as Elgg_Size_Rectangle and add method `->fitInto(Elgg_Size_Rectangle $boundingBox)`. This would proportionally reduce the current values and spit out a new size object. |
@@ -55,7 +55,7 @@ class Tester(unittest.TestCase):
tb = traceback.format_exc()
scriptable = False
msg = str(e) + str(tb)
- self.assertEqual(torchub_models[name], scriptable, msg)
+ self.assertEqual(scriptable, scriptable, msg)
def _test_classification_model(se... | [do_test->[_test_classification_model,_test_detection_model,_test_video_model,_test_segmentation_model],Tester->[_test_classification_model->[check_script],_test_detection_model->[check_script],_test_segmentation_model->[check_script],test_resnet_dilation->[_make_sliced_model],_test_video_model->[check_script]],get_ava... | Check if a script is able to be used. | I'm not sure this change is what you want to do? |
@@ -376,6 +376,7 @@ describes.realWin('ConsentStateManager', {amp: 1}, env => {
it('send update request on consentString change', function* () {
yield instance.update(CONSENT_ITEM_STATE.ACCEPTED, 'old');
yield macroTask();
+ yield macroTask();
expect(requestSpy).to.be.calledOnce... | [No CFG could be retrieved] | This example is to test if a user has a consent string and if it has a consent A macroTask - a function that sends update request when no change is made. | Why the second yield? |
@@ -21,6 +21,14 @@ module Api
].freeze
private_constant :LISTINGS_FOR_SERIALIZATION
+ ARTICLES_FOR_SERIALIZATION = %i[
+ id user_id organization_id collection_id
+ title description main_image published_at crossposted_at social_image
+ cached_tag_list slug path canonical_url co... | [OrganizationsController->[listings->[to_i,min,present?,order,in_category],users->[min,to_i,per],find_organization->[find_by!],show->[find_by!],private_constant,before_action,freeze]] | Returns the show object for the user if it exists. | I wonder if, instead copying `Api::V0::ArticlesController::INDEX_ATTRIBUTES_FOR_SERIALIZATION` here, we can't just refer to it in the controller, this way we make sure that the fields in both endpoints are always aligned. |
@@ -1261,7 +1261,13 @@ define([
tile.contentReadyPromise.then(function() {
removeFunction();
tileset.tileLoad.raiseEvent(tile);
- }).otherwise(removeFunction);
+ }).otherwise(function(error) {
+ removeFunction();
+ if (error instanceof RuntimeError)... | [No CFG could be retrieved] | This function checks if a tile is requested and if so requests it. If a is rejected this function will remove it from the processing queue and remove it. | Also look for `DeveloperError`. |
@@ -11,8 +11,9 @@ class Xmlf90(AutotoolsPackage):
"""xmlf90 is a suite of libraries to handle XML in Fortran."""
homepage = "https://launchpad.net/xmlf90"
- url = "https://launchpad.net/xmlf90/trunk/1.5/+download/xmlf90-1.5.2.tgz"
+ version('1.5.4', sha256='a0b1324ff224d5b5ad1127a6ad4f90979f6b1... | [Xmlf90->[fix_mk->[install,join_path],autoreconf->[which,sh],configure_args->[satisfies],run_after,depends_on,version]] | Create an instance of the national security object. | I would still keep this package-level url. It's used for `spack checksum` and `spack versions`, while `url_for_version` is only used for `spack fetch` and `spack install`. |
@@ -491,7 +491,14 @@ func (mod *modContext) genResource(res *schema.Resource) (string, error) {
}
// And add it to the dictionary.
- arg := pname
+ arg = pname
+
+ if prop.ConstValue != nil {
+ arg, err = getConstValue(prop.ConstValue)
+ if err != nil {
+ return "", err
+ }
+ }
// If this reso... | [gen->[genHeader,add],genResource->[genHeader,has,add],genFunction->[genHeader,genAwaitableType],genPropertyConversionTables->[genHeader],genInit->[genHeader],genNestedStructureBullets->[genNestedStructureBullets],genConfig->[genHeader],genHeader,genPropertyConversionTables,add,gen] | genResource generates the code for a resource Generate an initializer with arguments for all input properties. get_version - get version of a missing resource This is the base constructor that will be called when a resource is created. | Ah, guessing you made that change to avoid declaring the variables here. I'd suggest adding `var err error` after line 468 instead. |
@@ -178,9 +178,13 @@ def read_epochs_eeglab(input_fname, events=None, event_id=None, montage=None,
If None, sensor locations are (0,0,0). See the documentation of
:func:`mne.channels.read_montage` for more information.
eog : list | tuple | 'auto'
- Names or indices of channels that should ... | [RawEEGLAB->[__init__->[_check_fname,_get_info,_check_mat_struct]],EpochsEEGLAB->[__init__->[_check_fname,_get_info,_check_mat_struct]],_get_info->[_to_loc]] | This function reads a sequence of epochs from a. eeglab file. Get the epochs of a missing event. | Weird to have `empty tuple` at eog and `()` here. |
@@ -215,15 +215,9 @@ LOGGING = {
}
}
-AUTHENTICATION_BACKENDS = (
- 'saleor.registration.backends.EmailPasswordBackend',
- 'saleor.registration.backends.ExternalLoginBackend',
- 'saleor.registration.backends.TrivialBackend'
-)
-
AUTH_USER_MODEL = 'userprofile.User'
-LOGIN_URL = '/account/login'
+LOG... | [literal_eval,parse,dirname,get,getenv,config,join,normpath] | Config for the Django admin console and mail logging. Initialize the order. Payment model. | Why is it `accounts`? From the user's perspective there is only one account they're logged into. |
@@ -221,7 +221,10 @@ class Model(torch.nn.Module, Registrable):
# Load vocabulary from file
vocab_dir = os.path.join(serialization_dir, 'vocabulary')
- vocab = Vocabulary.from_files(vocab_dir)
+ if os.path.exists(vocab_dir):
+ vocab = Vocabulary.from_files(vocab_dir)
+ ... | [Model->[load->[load,from_params]],_remove_pretrained_embedding_params->[_remove_pretrained_embedding_params]] | Instantiates a model based on a specific configuration. get the n - th device from the model if it is a cuda device or cpu. | The Ensemble classes don't need a vocabulary. I don't particularly like how I'm handling this option here, but the other changes I come up with require many more changes to our APIs. Suggestions very welcome ;-) |
@@ -65,6 +65,7 @@ type Events interface {
OnResourceStepPre(step Step) (interface{}, error)
OnResourceStepPost(ctx interface{}, step Step, status resource.Status, err error) error
OnResourceOutputs(step Step) error
+ RemovePendingReplacements(res []*resource.State) error
}
// PlanPendingOperationsError is an ... | [generateURN->[Target],Execute->[Execute],generateEventURN->[generateURN],GetProvider->[GetProvider]] | TrustDependencies returns whether or not to trust the resource dependency graph. | This seems a little out-of-place on the `Events` interface. Should we instead be thinking about an `OnPlanCompleted` event or something that passes some state, including the set of resources that were pending replacement but were never replaced? |
@@ -87,6 +87,13 @@ func Details(ctx context.Context, g *libkb.GlobalContext, name string, forceRepo
if cat != keybase1.TeamInviteCategory_KEYBASE {
continue
}
+ if !invite.UserActive {
+ // Skip inactive puk-less members for now.
+ // Causes duplicate usernames in team list which we
+ // don't want.
+ ... | [MapUIDsToUsernamePackages,GetProofSet,CTimeTracer,IsOpen,ChangeMembership,Post,New,InviteMember,deleteSubteam,AsTeam,NewLoadUserArgWithContext,Time,ImplicitAdmins,OpenTeamJoinAs,IsSubteam,TeamInviteTypeFromString,Stage,Generation,FindActiveInvite,Finish,PercentForm,UserVersionByUID,IsMember,Exists,Leave,GetBool,Now,Po... | GetMaybeAdminByStringName returns a team object and an error if it can t find ImplicitAdmins returns a list of admins of the specified team. | Do we need this? Isn't the map enough to de-dupe everything? |
@@ -53,8 +53,8 @@ type Distributor struct {
type ReadRing interface {
prometheus.Collector
- Get(key uint32) (ring.IngesterDesc, error)
- GetAll() []ring.IngesterDesc
+ Get(key uint32, n int, heartbeatTimeout time.Duration) ([]ring.IngesterDesc, error)
+ GetAll(heartbeatTimeout time.Duration) []ring.IngesterDesc
... | [sendSamples->[getClientFor,Append],Collect->[Collect],Describe->[Describe],Query->[Query,getClientFor],LabelValuesForLabelName->[getClientFor,LabelValuesForLabelName]] | NewDistributor returns a new Distributor which observes the current number of objects in the A list of metrics that can be used to distribute a request to a single channel. | Another approach might be to exclude the `heartbeatTimeout` from the parameters and instead implement it as a decorator. Not sure it's a _better_ approach, mind you. |
@@ -679,6 +679,10 @@ public class KeyManagerImpl implements KeyManager {
throw new OMException("Key not found", KEY_NOT_FOUND);
}
+ if (!args.getFullLocationVersion()) {
+ slimLocationVersion(value);
+ }
+
// add block token for read.
addBlockToken4Read(value);
| [KeyManagerImpl->[completeMultipartUpload->[validateS3Bucket],createMultipartInfo->[validateS3Bucket],allocateBlockInKey->[allocateBlock],refresh->[refreshPipeline],allocateBlock->[validateBucket,allocateBlock],abortMultipartUpload->[validateS3Bucket],getAcl->[validateBucket],getFileEncryptionInfo->[getKMSProvider,gene... | Lookup a key in the bucket. | This flag is set in lookupFile, getFileStatus, readKey/readFile in RpcClient but on Server, I don't see any use of that. |
@@ -207,7 +207,7 @@ class Rule
} elseif ($targetName === 'hhvm') {
$text .= ' -> you are running this with PHP and not HHVM.';
} else {
- $text .= ' -> your PHP version ('. phpversion() .') or "config.platform.php"... | [Rule->[getPrettyString->[getPrettyString,getReason],getRequiredPackage->[getReason],__toString->[isDisabled]]] | Returns a pretty string representation of the rule. Returns a string describing the rule that should be performed if the target is missing from the system. | I would phrase it as `value in composer.json` instead of `setting`, how does that sound to you? :) |
@@ -438,5 +438,11 @@ return function(\Elgg\EventsService $events, \Elgg\HooksRegistrationService $hoo
// and the user is logged in so it can start caching
$events->registerHandler('ready', 'system', 'access_init');
+ // friends ACL events
+ $events->registerHandler('create', 'user', 'access_friends_acl_create');
... | [get_access_array->[getAccessArray],get_write_access_array->[getWriteAccessArray],get_members_of_access_collection->[getMembers],elgg_get_ignore_access->[getIgnoreAccess],get_default_access->[trigger,getPrivateSetting,getLoggedInUser],can_edit_access_collection->[canEdit],elgg_set_ignore_access->[setIgnoreAccess],remov... | Register the events that are triggered when the user is logged in. | check if `create:after` is available |
@@ -48,7 +48,10 @@ activate' from PATH. """)
def prefix_from_arg(arg, shelldict):
- if shelldict['sep'] in arg:
+ 'Returns a platform-native path'
+ # MSYS2 converts Unix paths to Windows paths with unix seps
+ # so we must check for the drive identifier too.
+ if shelldict['sep'] in arg and not re.... | [binpath_from_arg->[prefix_from_arg],main->[help,prefix_from_arg,get_path,pathlist_to_str,binpath_from_arg],main] | Returns the prefix of the environment variable. | Why not make this a proper docstring with `"""`? Nbd right now though. We can address it later. |
@@ -56,6 +56,18 @@ public class NonTxInvocationContext extends AbstractInvocationContext {
Collections.emptyMap() : lookedUpEntries);
}
+ @Override
+ public void forEachEntry(BiConsumer<Object, CacheEntry> consumer) {
+ if (lookedUpEntries != null) {
+ lookedUpEntries.forEach(... | [NonTxInvocationContext->[getLookedUpEntries->[emptyMap],putLookedUpEntry->[put],clone->[clone,putAll],addLockedKey->[makeSet,add],removeLookedUpEntry->[remove],lookupEntry->[get],getLockedKeys->[emptySet],computeCapacity,makeMap]] | Returns a map of all entries that have been looked up in this cache. | most of the places iterate over entries that are `!entry.isRemoved() && !entry.isNull()`. should we add a method that only iterates over valid entries? |
@@ -358,10 +358,12 @@ namespace Pulumi.Automation
internal static void ValidatePulumiVersion(SemVersion minVersion, SemVersion currentVersion)
{
- if (minVersion.Major < currentVersion.Major) {
+ if (minVersion.Major < currentVersion.Major)
+ {
throw... | [LocalWorkspace->[GetStackSettingsAsync->[GetStackSettingsName],CreateOrSelectStackAsync->[CreateOrSelectStackAsync],SelectStackAsync->[SelectStackAsync],CreateStackAsync->[CreateStackAsync,CreateAsync],Dispose->[Dispose],Task->[GetStackSettingsName]]] | Validate that the given Pulumi CLI version is compatible with the current version. | I think this `else` can be removed to reduce nesting, since we already return if the file does not exist |
@@ -326,7 +326,11 @@ class CI_Session_memcached_driver extends CI_Session_driver implements SessionHa
continue;
}
- if ( ! $this->_memcached->set($lock_key, time(), 300))
+ $result = ($this->_memcached->getResultCode() === Memcached::RES_NOTFOUND)
+ ? $this->_memcached->add($lock_key, time(), 300)
+ ... | [CI_Session_memcached_driver->[write->[getResultCode,_fail,_get_lock,_release_lock,replace,set,touch],close->[_release_lock,_fail,quit],_get_lock->[getResultCode,replace,set,get],_release_lock->[getResultCode,delete],read->[_get_lock,get,_fail],destroy->[_cookie_destroy,_fail,delete],open->[getServerList,setOption,addS... | Gets a lock for a given session ID. | With the method params matching ... $method = ($this->_memcached->getResultCode() === Memcached::RES_NOTFOUND) ? 'add' : 'set'; if ( ! $this->_memcached->$method($lock_key, time(), 300)) |
@@ -440,10 +440,12 @@ export class AmpForm {
*/
doXhr_(opt_extraValues) {
const isHeadOrGet = this.method_ == 'GET' || this.method_ == 'HEAD';
+ const values = this.getFormAsObject_(opt_extraValues);
+ this.renderTemplate_(values);
+
let xhrUrl, body;
if (isHeadOrGet) {
- xhrUrl = addPa... | [No CFG could be retrieved] | This method sends a request to the form s action endpoint with the given parameters. Transitions the form to the submit success state. | this will render all templates which causes unnecessary rendering of success/failure templates as well. would be nice if `renderTemplate` could take the type of target template. |
@@ -346,6 +346,7 @@ public class RemoteTaskRunner implements WorkerTaskRunner, TaskLogStreamer
return;
}
try {
+ monitorSyncHandler.shutdown();
provisioningService.close();
Closer closer = Closer.create();
| [RemoteTaskRunner->[tryAssignTask->[runPendingTasks,findWorkerRunningTask],scheduleTasksCleanupForWorker->[cancelWorkerCleanup],checkBlackListedNodes->[runPendingTasks,shouldRemoveNodeFromBlackList],shutdown->[findWorkerRunningTask],run->[findWorkerRunningTask],start->[start],getBlackListedWorkers->[getImmutableWorkerF... | Stop a if it is possible to stop this executor. | These two things must be closed using the `closer` below |
@@ -829,7 +829,7 @@ def disable_legacy_files(ids, **kw):
# that we've identified as containing legacy File instances.
files = File.objects.filter(
is_webextension=False, is_mozilla_signed_extension=False,
- version__addon=addon)
+ version__addon=a... | [theme_checksum->[make_checksum],calc_checksum->[make_checksum],rereviewqueuetheme_checksum->[make_checksum],add_static_theme_from_lwt->[_get_lwt_default_author],save_theme_reupload->[rereviewqueuetheme_checksum,save_persona_image],save_theme->[create_persona_preview_images,theme_checksum,save_persona_image],migrate_lw... | Delete legacy files from the specified add - ons. | That's called automatically because of a signal? |
@@ -41,7 +41,7 @@ public abstract class KeyGenerator implements Serializable, KeyGeneratorInterfac
private static final String STRUCT_NAME = "hoodieRowTopLevelField";
private static final String NAMESPACE = "hoodieRow";
- protected transient TypedProperties config;
+ protected TypedProperties config;
priv... | [KeyGenerator->[getRecordKey->[getRecordKey],getPartitionPath->[getPartitionPath]]] | Creates a new key generator which generates Hoodie keys from a generic record. Get the record key of interest from which the given row is requested. | This is intended to be transient so that we don't serialize config in KeyGenerator s. Lets keep it that way. Since the issue is specifically with CustomKeyGenerator we should resolve there. |
@@ -61,7 +61,9 @@ public class HttpClient {
}
String baseURI = args[0];
- String postSimple, postFile, get;
+ String postSimple;
+ String postFile;
+ String get;
if (baseURI.endsWith("/")) {
postSimple = baseURI+"formpost";
postFile = ba... | [HttpClient->[main->[equalsIgnoreCase,getMessage,NioClientSocketChannelFactory,formpostmultipart,getScheme,canRead,HttpClientPipelineFactory,getSimpleName,formpost,newCachedThreadPool,setPipelineFactory,endsWith,File,releaseExternalResources,formget,cleanAllHttpDatas,println,ClientBootstrap,getHost,DefaultHttpDataFacto... | Main method of the client. This method is called by the client to setup the factory for the resource based on the resource. | Isn't this just a matter of style ? I can not see any improvement whic his archived by this ... |
@@ -188,7 +188,7 @@ public class ReactiveStreamsConsumer extends AbstractEndpoint implements Integra
}
private static final class MessageHandlerSubscriber
- implements CoreSubscriber<Message<?>>, Disposable, Lifecycle {
+ implements CoreSubscriber<Message<?>>, Disposable, ManageableLifecycle {
private fi... | [ReactiveStreamsConsumer->[onInit->[onInit],MessageHandlerSubscriber->[start->[start],isRunning->[isRunning],stop->[stop]],getOutputChannel->[getOutputChannel],SubscriberDecorator->[hookOnSubscribe->[onSubscribe],hookOnNext->[onNext],hookOnComplete->[onComplete]]]] | Gets the input channel. On subscribe. | I'm not sure this one has to be manageable - it is just an inner one |
@@ -506,7 +506,7 @@ func (pc *Client) PatchUpdateCheckpoint(ctx context.Context, update UpdateIdenti
}
req := apitype.PatchUpdateCheckpointRequest{
- Version: 1,
+ Version: 2,
Deployment: rawDeployment,
}
| [CancelUpdate->[restCallWithOptions],GetStack->[restCall],ExportStackDeployment->[restCall],GetStackLogs->[restCall],DeleteStack->[restCall],CreateUpdate->[restCall],GetLatestConfiguration->[restCall],ImportStackDeployment->[restCall],GetPulumiAccountName->[restCall],DownloadTemplate->[apiCall],DecryptValue->[restCall]... | PatchUpdateCheckpoint issues a PATCH request to update a checkpoint. | I'll admit, it wasn't evident from reading this change why we need to rev the formats. It would seem all changes to the deployment/checkpoint structures are purely additive. |
@@ -993,6 +993,13 @@ public class ConfigurationKeys {
public static final String COMPACTION_PRIORITIZER_ALIAS = COMPACTION_PRIORITIZATION_PREFIX + "prioritizerAlias";
public static final String COMPACTION_ESTIMATOR = COMPACTION_PRIORITIZATION_PREFIX + "estimator";
+ /***
+ * Configuration properties related ... | [ConfigurationKeys->[name,toString,toMillis]] | This class defines the configuration properties of a specExecutor object. GITMONITOR_SSH_WITH_PUBLIC_KEY_ENABLED GITMONITOR. | RECOMPACTION_DIRECTORY_FORMAT to be more accurate? |
@@ -226,8 +226,17 @@ public class UsersApi {
// elsewhere in the GeoNetwork database - an exception is thrown if
// this is the case
if (dataManager.isUserMetadataOwner(userIdentifier)) {
+ MetadataRepository metadataRepository = ApplicationContextHolder.get().getBean(MetadataRepos... | [UsersApi->[getUser->[IllegalArgumentException,equals,findGroupIds,UserNotFoundEx,getUserSession,hasUserId,or,findOne,getBean,getProfile,toString,isEmpty,getUserId],checkIfAtLeastOneAdminIsEnabled->[IllegalArgumentException,findAll,size,parseInt,isNotEmpty,get,isEnabled,hasEnabled,getId,and],setUserGroups->[remove,equa... | Deletes a user by identifier. Delete a user that is also a metadata owner. | What about if the user owns for example 10000 records? Maybe can be provided in the UI error message a link to filter the metadata owned by the user instead? |
@@ -163,10 +163,9 @@ namespace System
public override void NextBytes(Span<byte> buffer)
{
- for (int i = 0; i < buffer.Length; i++)
- {
- buffer[i] = (byte)_parent.Next();
- }
+ byte[] tmpBuf = new byte[buffer.Len... | [Random->[LegacyImpl->[NextInt64->[NextInt64],Next->[Sample],NextDouble->[Sample],GetSampleForLargeRange->[InternalSample],NextBytes->[Next],NextSingle->[Sample]]]] | next bytes in the sequence. | Thank you, but this isn't a change we can take. Two reasons: 1. This was calling _parent.Next() because this overload was added after developers may have derived from Random and overridden the Next method. If we didn't call Next, we would not end up using the developer's override. 2. This is allocating a new byte[] on ... |
@@ -16,7 +16,7 @@
// Project includes
#include "includes/define.h"
#include "includes/define_python.h"
-#include "custom_utilities/process_factory_utility.h"
+#include "custom_python/process_factory_utility.h"
#include "custom_python/add_custom_strategies_to_python.h"
#include "spaces/ublas_space.h"
| [AddCustomStrategiesToPython->[,>]] | | | | | | | | | | | | | | | | | | | This file contains the list of all possible custom criteria that should be used to determine the optimal. | I think we should avoid those dependencies on python What are you using it for? |
@@ -105,7 +105,7 @@ export -f yes # use in subshells too
which match >/dev/null || {
echo "You must have 'match' installed to run these tests. Please run:" >&2
- echo " cd ${GOPATH}/src/github.com/pachyderm/pachyderm/ && go install ./src/testing/match" >&2
+ echo " go install ./src/testing/match" >&2
exit 1
}... | [WriteRune,Execute,NewReader,HasPrefix,Must,New,Environ,IsSpace,String,Parse,IndexFunc,Scan,Command,WriteString,NewScanner,Text] | Catches pipefail errors and returns a new object with the result of the test. | How would you feel about `go install github.com/pachyderm/pachyderm/src/testing/match`? It's shorter and less side-effectful than `cd ...` but still works when you're not in the top-level `pachyderm/pachyderm` dir. |
@@ -35,9 +35,10 @@ func ExtractContainerName(names []string) string {
}
return strings.Trim(output, "/")
}
+
func BuildLabelArray(labels map[string]string) []common.MapStr {
- output_labels := make([]common.MapStr, len(labels))
+ outputLabels := make([]common.MapStr, len(labels))
i := 0
var keys []string
... | [Strings,Count,Replace,Trim] | InitCurrentContainer - Init a container object from a docker APIContainers struct. | It was the naming used in dockbeat Project, where it has been decided to format the labels output . I didn't want it to be different, that's why I left it at it is. If it's not necessery. We can leave it as it's generated by docker's API. |
@@ -343,7 +343,11 @@ namespace Dynamo.Graph.Workspaces
// Make this RunSettings.RunEnabled private, introduce the new flag and remove the "executingTask" variable.
if (RunSettings.RunEnabled || executingTask)
{
- Run();
+ // Skip'... | [HomeWorkspaceModel->[Clear->[Clear],RequestRun->[RequestRun],ResetEngine->[LibraryLoaded],MarkNodesAsModifiedAndRequestRun->[RequestRun],StopPeriodicEvaluation->[OnRefreshCompleted],Run->[OnEvaluationCompleted,OnEvaluationStarted],GetExecutingNodes->[OnSetNodeDeltaState],OnPreviewGraphCompleted->[OnSetNodeDeltaState],... | Override RequestRun to provide a specific flag if the run is not available. | `skip the execution if runs have been disabled - currently this flag is only set by the Package Loader` |
@@ -221,6 +221,8 @@ namespace Dynamo.Wpf.UI.GuidedTour
if (hostUIElement != null)
popupInfo.HostUIElement = hostUIElement;
+ Canvas.SetZIndex(popupInfo.HostUIElement, 0);
+
return popupInfo;
}
| [GuidesManager->[ReadGuides->[JsonConvert,ReadToEnd,Empty],Step->[Title,Value,SetValue,StepExtraContent,TOOLTIP,IsADPAnalyticsReportingApproved,TooltipPointerDirection,WELCOME,Sequence,Width,FormattedText,Height,Name,ToString,GetProperty,GetString,StepType,SURVEY,Property],TourFinished->[GuidedTourStart,StepClosed,Clea... | Create a HostControlInfo object from the given json file. | @filipeotero do you think this line is still necessary? Since I remember that we found that the new component used for the Library(MSWebBrowser) doesn't honor the Z-Index (in general doesn't allow to have any wpf control over it) |
@@ -115,7 +115,7 @@ void k051649_device::sound_stream_update(sound_stream &stream, stream_sample_t *
int c=voice.counter;
int step = ((int64_t(m_mclock) << FREQ_BITS) / float((voice.frequency + 1) * 16 * (m_rate / 32))) + 0.5f;
- short *mix = m_mixer_buffer.get();
+ short *mix = m_mixer_buffer.begin();
... | [No CFG could be retrieved] | - device - specific functions - mixer table - mixer table region IonStream functions. | Are you sure this compiles? I would've thought you'd either need to change the type of `mix` from `short *` to `std::vector<short>::iterator` or use `&m_mixer_buffer[0]` to initialise it. |
@@ -250,7 +250,12 @@ final class SchemaFactory implements SchemaFactoryInterface
$name = $groups ? sprintf('%s-%s', $prefix, implode('_', $groups)) : $prefix;
}
- return $name;
+ return $this->encodeDefinitionName($name);
+ }
+
+ private function encodeDefinitionName(string $... | [SchemaFactory->[buildSchema->[getAttribute,isWritable,create,normalize,getDescription,getMetadata,buildDefinitionName,getTypedOperationAttribute,getFactoryOptions,isReadable,getDefinitions,buildPropertySchema,isRequired,getIri,getVersion],getMetadata->[getAttribute,isResourceClass,create,getTypedOperationAttribute,get... | Builds the definition name for a given class. Returns a sequence of objects that can be serialized into the result of a sequence of serialization operations. | Your commit didn't work for me (tested with a "shortName" set to "directory/sub-directory" - still got the error "Could not resolve reference: #/components/schemas/...", issue #1969), and I think the problem is the regular expression in that line. I changed it to `preg_replace('/[^a-zA-Z0-9.\-_]+/', '.', $name);` and t... |
@@ -188,7 +188,11 @@ func RetrieveBaseRepo(ctx *Context, repo *models.Repository) {
// ComposeGoGetImport returns go-get-import meta content.
func ComposeGoGetImport(owner, repo string) string {
- return path.Join(setting.Domain, setting.AppSubURL, url.PathEscape(owner), url.PathEscape(repo))
+ host := setting.Doma... | [CanCreateBranch->[CanCreateBranch],CanCommitToBranch->[CanEnableEditor],CanEnableEditor->[CanEnableEditor],CanCreateBranch,GetCommitsCount,BranchNameSubURL] | RetrieveBaseRepo retrieves base repository meta content. RedirectToRepo redirect to a different - named repository. | If Gitea is running behind reverse proxy this will be incorrect imho |
@@ -621,6 +621,10 @@ static int ssp_set_config_blob(struct dai *dai, struct ipc_config_dai *common_co
struct ssp_pdata *ssp = dai_get_drvdata(dai);
uint32_t ssc0, sstsa, ssrsa;
+ /* set config only once for playback or capture */
+ if (dai->sref > 1)
+ return 0;
+
ssc0 = blob->i2s_driver_config.i2s_config.ssc0... | [void->[SSCR3_RFL_VAL,dai_base,ssp_update_bits,mn_release_bclk,wait_delay,dai_dbg,spin_lock,spin_unlock,poll_for_register_delay,dai_get_drvdata,ssp_empty_rx_fifo,dai_info,ssp_pre_start,clock_ms_to_ticks,ssp_post_stop,clock_ticks_per_sample,dai_warn,mn_release_mclk,ssp_write,ssp_empty_tx_fifo,ssp_read],int->[ssp_pause,m... | Set the SSP configuration blob. - - - - - - - - - - - - - - - - - - end of method mclk_config. | A typo in commit message: s/catpure/capture |
@@ -332,7 +332,7 @@ public class OMMultiTenantManagerImpl implements OMMultiTenantManager {
inMemoryUserNameToListOfGroupsMap.put(
userPrincipal.getFullMultiTenantPrincipalID(), userGroupIDs);
- return userID;
+ return null;
} catch (Exception e) {
destroyUser(tenantName, userN... | [OMMultiTenantManagerImpl->[allowAccessBucketPolicy->[getOzonePrincipal],createVolumeAccessPolicy->[getOzonePrincipal],createUser->[getTenantInfo,createUser],allowCreateBucketPolicy->[getOzonePrincipal],allowAccessKeyPolicy->[getOzonePrincipal],destroyUser->[getTenantInfo]]] | create a user in the given tenant. | Is this intentional, or for testing? Maybe put a TODO here? |
@@ -0,0 +1,14 @@
+<?php
+//
+// Poll information of Juniper Wireless (Trapeze) devices.
+//
+if ($device['os'] == 'trapeze') {
+ list(,,,$hardware,$version,) = explode(' ', $poll_device['sysDescr']);
+ $serial = snmp_get($device, 'trpzSerialNumber.0', '-OQv', 'TRAPEZE-NETWORKS-BASIC-MIB', 'trapeze');
+ $versio... | [No CFG could be retrieved] | No Summary Found. | Could wrap these three calls into `snmp_get_multi()` to save exec time. |
@@ -357,9 +357,13 @@ chunk_get_idle(struct bio_dma_buffer *bdb, struct bio_desc *biod)
if (d_list_empty(&bdb->bdb_idle_list)) {
if (bdb->bdb_tot_cnt == bio_chk_cnt_max) {
D_CRIT("Maximum per-xstream DMA buffer isn't big "
- "enough (chk_sz:%u chk_cnt:%u iods:%u) to "
- "sustain the workload.\... | [No CFG could be retrieved] | Returns the first available chunk in the queue or NULL if there are no available blocks. Add a chunk to a bio. | probably change to DB_REBUILD for REBUILD_TYPE, since performance is less sensitive for rebuild anyway. |
@@ -10,6 +10,10 @@
#include "action_util.h"
#include "ringbuffer.hpp"
#include <string.h>
+#define SAMPLE_BATTERY
+#ifdef SAMPLE_BATTERY
+# include "analog.h"
+#endif
// These are the pin assignments for the 32u4 boards.
// You may define them to something else in your config.h
| [No CFG could be retrieved] | A class that represents a single 32 - bit configuration in a single HCI frame. The queue of key codes that can be hammered. | The ifdef here is not necessary, actually, and the define can go back where it was. |
@@ -157,7 +157,7 @@ public class MailboxConnection extends AbstractEmailConnection {
@Override
public ConnectionValidationResult validate() {
String errorMessage = "Store is not connected";
- return store.isConnected() ? success() : failure(errorMessage, DISCONNECTED, new EmailConnectionException(errorMes... | [MailboxConnection->[getFolder->[getFolder],disconnect->[closeFolder]]] | Validate if the store is connected and if not return a ConnectionValidationResult. | add a todo to replace the DISCONNECTED thingy |
@@ -110,6 +110,16 @@ type ControllerInstallationControllerConfiguration struct {
ConcurrentSyncs int
}
+// PlantConfiguration defines the configuration of the
+// PlantConfiguration controller.
+type PlantConfiguration struct {
+ // ConcurrentSyncs is the number of workers used for the controller to work on
+ // e... | [No CFG could be retrieved] | Integrity configuration of the Hibernate controller. | Not used anywhere - remove? |
@@ -69,3 +69,11 @@ SUPPORTED_PLATFORM_NORMALIZED_NAMES = {
('darwin', '16'): ('mac', '10.12'),
('darwin', '17'): ('mac', '10.13'),
}
+
+
+def get_closest_mac_host_platform_pair(darwin_version_upper_bound,
+ platform_name_map=SUPPORTED_PLATFORM_NORMALIZED_NAMES):
+ """Return... | [get_normalized_os_name->[get_os_name,normalize_os_name]] | Enumerate all possible mac addresses. | Use the `platform_name_map` parameter here. |
@@ -104,12 +104,13 @@ def create(label, plugin_name, options, description, certificates):
return database.create(notification)
-def update(notification_id, label, options, description, active, certificates):
+def update(notification_id, label, plugin_name, options, description, active, certificates):
"""
... | [update->[update],create->[create],get->[get],get_by_label->[get],delete->[delete]] | Updates an existing notification. . | Function: Changing the plugin selected required updating the `plugin_name` field as well as the options. |
@@ -127,6 +127,17 @@ class WPSEO_Recalibration_Beta implements WPSEO_WordPress_Integration {
return WPSEO_Options::get( 'recalibration_beta' );
}
+ /**
+ * Checks if the recalibration beta should use the local file.
+ *
+ * If false, the my-yoast-proxy should be used.
+ *
+ * @return bool Whether the local ... | [WPSEO_Recalibration_Beta->[register_hooks->[register_hooks],subscribe_newsletter->[has_mailinglist_subscription]]] | Check if recalibration is enabled. | The only usage for this is in the `admin/class-admin-asset-analysis-worker-location.php`. I suggest to move it to that file and makes the method non-static and protected. The reason for this is that you are introducing a public method that is only meant for the recalibration, when that beta is over we want to easily re... |
@@ -18,6 +18,7 @@
-%>
import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';
+
import { errorRoute } from './layouts/error/error.route';
import { navbarRoute } from './layouts/navbar/navbar.route';
import { DEBUG_INFO_ENABLED } from 'app/app.constants';
| [No CFG could be retrieved] | Creates a new object that can be imported by JHipster. The AppRoutingModule class is a subclass of the login module that can be used to route. | Those empty lines are intentional, those are separating library and application internal imports. |
@@ -739,14 +739,15 @@ namespace System.Net.Http.Tests
[Fact]
public void From_UseAddMethodWithInvalidValue_InvalidValueRecognized()
{
+ // values are not validated, so invalid values are accepted
headers.TryAddWithoutValidation("From", " info@example.com ,");
- ... | [HttpRequestHeadersTest->[From_UseAddMethod_AddedValueCanBeRetrievedUsingProperty->[From,TryAddWithoutValidation,Equal,Clear],IfUnmodifiedSince_ReadAndWriteProperty_ValueMatchesPriorSetValue->[Equal,Contains,Now,False,Null,IfUnmodifiedSince],Via_UseAddMethod_AddedValueCanBeRetrievedUsingProperty->[Clear,Equal,TryAddWit... | This method checks if the From header is null and if it is read and written. | But this one *can* be removed, it's calling GetParsedValues which is pointless if we don't have a parser. |
@@ -386,6 +386,7 @@ getent passwd daos_agent >/dev/null || useradd -s /sbin/nologin -r -g daos_agent
%files tests
%dir %{_prefix}/lib/daos
%{_prefix}/lib/daos/TESTING
+%exclude %{_prefix}/lib/daos/TESTING/ftest/list_tests.py
%{_bindir}/hello_drpc
%{_bindir}/*_test*
%{_bindir}/jobtest
| [No CFG could be retrieved] | Iosil DAO agent options. Package containing DAOS and DAOS test files. | Having to do this exclude here I think indicates that this PR is not meeting it's goal since this python2 tool would be installed on a source-built installation. Doesn't a parallel operation of this sort need doing with the debian/ packaging? But to be clear, the proper solution here is to prevent this file from being ... |
@@ -371,13 +371,8 @@ public class Card implements Cloneable {
/*
* Time taken to answer card, in integer MS.
*/
- public long timeTaken() {
- long total = (long) ((Utils.now() - mTimerStarted) * 1000);
- // Workaround for 1449. Ensure we don't return negative times.
- // TODO: F... | [Card->[timeTaken->[timeLimit],note->[note],isEmpty->[model],_getQA->[_getQA],clone->[clone],template->[model],q->[q],flush->[flush]]] | Returns the time taken by this timer. | In absence of an explanation of how the fix works, an alternative could be to just keep the < 0 check in there... e.g. maybe something like: `return Math.max(0, Math.min(total, timeLimit()));` |
@@ -1006,15 +1006,14 @@ def check_publish(repo_obj, dist_id, dist_inst, transfer_repo, conduit, call_con
updated__gte=the_timestamp).count()
units_removed = last_unit_removed is not None and last_unit_removed > last_published
dist_updated = d... | [sync->[get_importer_by_id,rebuild_content_unit_counts],has_all_units_downloaded->[get_mongoengine_unit_querysets],get_repo_unit_models->[get_repo_unit_type_ids],missing_unit_count->[get_mongoengine_unit_querysets],LazyUnitDownloadStep->[download_succeeded->[report],download_started->[delete,report],download_failed->[r... | Check if the publish should be skipped. Get or create a record of a specific node in the repository. Publish a single node in the distribution. | i am still trying to get the general logic here, but i think this should be set to false |
@@ -188,7 +188,7 @@ def move_order_line_to_group(line, target_group, quantity):
delivery_group=target_group, product=line.product,
product_name=line.product_name, product_sku=line.product_sku,
quantity=quantity, unit_price_net=line.unit_price_net,
- stock=line.stock,
+ ... | [recalculate_order->[save,Price,get_total,sum],cancel_order->[cancel,save,all],move_order_line_to_group->[remove_empty_groups,save,create,get],add_variant_to_delivery_group->[allocate_stock,create,display_product,add_variant_to_existing_lines,InsufficientStock,refresh_from_db,get_price_per_item,select_stockrecord],atta... | Moves given quantity of order line to given shipment group. | What is the `product_variant` variable here? I don't see where it's defined. I think you meant `line.variant`. |
@@ -7,7 +7,7 @@
import sys
-X_MS_VERSION = '2018-03-28'
+X_MS_VERSION = '2019-02-02'
# Socket timeout in seconds
DEFAULT_SOCKET_TIMEOUT = 20
| [No CFG could be retrieved] | Creates a object. | This seems to be different then it is for blobs and queues? We should probably remove this value from `_shared` if it cannot be consistent across the SDKs..... |
@@ -180,10 +180,11 @@ angular.module('zeppelinWebApp').service('websocketMsgSrv', function($rootScope,
});
},
- getEditorSetting: function(replName) {
+ getEditorSetting: function(orderId, replName) {
websocketEvents.sendNewEvent({
op: 'EDITOR_SETTING',
data: {
+ or... | [No CFG could be retrieved] | The data object for the events that are sent to the ethernet network. E t urn e t urn e t urn e t urn e t urn e t urn. | How about using `paragraphId` instead of `orderId` since it is more common term in Zeppelin? :) |
@@ -862,6 +862,7 @@ export class Viewer {
* The fragment variable should contain leading '#'
* @param {string} fragment
* @return {!Promise}
+ * TODO: move this to amp-share-tracking, and use sendMessage()
*/
updateFragment(fragment) {
dev().assert(fragment[0] == '#', 'Fragment to be updated '... | [No CFG could be retrieved] | Gets the base cid from the url or the viewer. Triggers tick and setFlushParams events for the viewer. | This method should also stay |
@@ -596,7 +596,7 @@ func (h *hashtree) DeleteFile(path string) error {
return errorf(Internal, "delete discovered orphaned file \"%s\"", path)
}
if node.DirNode == nil {
- return errorf(Internal, "node at \"%s\" is a file, but \"%s\" exists "+
+ return errorf(Internal, "file at \"%s\" is a regular-file, but \"... | [mergeNode->[mergeNode,nodetype,Get],canonicalize->[canonicalize,nodetype],removeFromMap->[removeFromMap,nodetype],putFile->[tostring,visit,nodetype],Finish->[canonicalize],PutDir->[tostring,visit,nodetype],Merge->[mergeNode,Get],DeleteFile->[removeFromMap,visit],visit->[nodetype],Get] | DeleteFile deletes a file and all its children and its parent. | Not sure if this is quite right, but something like `file at \"%s\" is a regular-file, but the \"%s\" already exists` would be even clearer |
@@ -10,13 +10,6 @@ namespace System.IO.Strategies
// this type serves some basic functionality that is common for Async and Sync Windows File Stream Strategies
internal abstract class WindowsFileStreamStrategy : FileStreamStrategy
{
- // Error codes (not HRESULTS), from winerror.h
- interna... | [WindowsFileStreamStrategy->[Flush->[Flush],Lock->[Lock],InitFromHandleImpl->[OnInitFromHandle,Seek],Init->[OnInit],Unlock->[Unlock],Dispose->[Dispose]]] | Creates a new instance of FileStreamStrategy. This is a hack to avoid the finalizer closing the handle when we throw errors. | thank you for reusing the existing error codes and removing the duplicates |
@@ -139,7 +139,7 @@ public class TextEditingTargetSpelling implements TypoSpellChecker.Context
@Override
public void invalidateAllWords()
{
- lintManager_.forceRelint();
+ lintManager_.relintAfterDelay(-1);
}
@Override
| [TextEditingTargetSpelling->[injectContextMenuHandler->[checkSpelling,addToDictIcon]]] | Invalidate all words. | We should name this special value so it's clear what calling with `-1` does. |
@@ -151,8 +151,6 @@ void *rmalloc(enum mem_zone zone, uint32_t flags, uint32_t caps, size_t bytes)
{
if (zone_is_cached(zone))
return heap_alloc_aligned_cached(&sof_heap, 0, bytes);
- else
- return heap_alloc_aligned(&sof_heap, 8, bytes);
return heap_alloc_aligned(&sof_heap_shared, 8, bytes);
}
| [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - region Private functions. | This breaks i.MX. I proposed a fix for both i.MX and Up squared - see #4477. If you agree with the fix and tests are passing, we can close this PR and merge #4477. |
@@ -7,6 +7,7 @@ import KratosMultiphysics
# Import applications
import KratosMultiphysics.StructuralMechanicsApplication as KratosSMA
import KratosMultiphysics.ConvectionDiffusionApplication as ConvDiff
+import KratosMultiphysics.ConstitutiveLawsApplication as KratosCLApp
# Importing the base class
from Krato... | [CoupledThermoMechanicalSolver->[AddDofs->[AddDofs],FinalizeSolutionStep->[FinalizeSolutionStep],ImportModelPart->[ImportModelPart],Initialize->[Initialize],Predict->[Predict],InitializeSolutionStep->[InitializeSolutionStep],GetComputingModelPart->[GetComputingModelPart],AddVariables->[AddVariables],PrepareModelPart->[... | Creates a CoupledThermoMechanicalSolver. | is this always necessary? Cannot it be used without too? |
@@ -21,6 +21,7 @@ Rails.application.config.assets.precompile += %w(my_modules/activities.js)
Rails.application.config.assets.precompile += %w(my_modules/protocols.js)
Rails.application.config.assets.precompile += %w(my_modules/protocols/protocol_status_bar.js)
Rails.application.config.assets.precompile += %w(my_modu... | [precompile,version] | Requires the precompile assets to be included in the application. Add assets to precompile. | Line is too long. [85/80] |
@@ -86,7 +86,8 @@ def report_uninitialized_resources(resource_list=None,
resource_list = shared_resources() + local_resources()
with ops.name_scope(name):
# Run all operations on CPU
- with ops.device("/cpu:0"):
+ local_device = os.environ.get("TF_LOCAL_DEVICE", "/cpu:0")
+ with ops.device(local_d... | [report_uninitialized_resources->[local_resources,shared_resources]] | Reports the names of all uninitialized resources in resource_list. | TF_LOCAL_DEVICE seems a generic name. It may collide with some existing users. Is it possible to find a more specific name, something like 'TF_DEVICE_REPORT_UNINITIALIZED'. Could you please also give us info about whether you have run this and got problem solved? |
@@ -500,11 +500,12 @@ func (u *CachedUPAKLoader) LoadKeyV2(ctx context.Context, uid keybase1.UID, kid
ret, key = upak.FindKID(kid)
if key != nil {
u.G().VDL.CLogf(ctx, VLog0, "- found kid in UPAK: %v", *ret)
- break
+ return ret, key, linkMap, nil
}
ret = nil
}
- return ret, key, linkMap, nil
+
+ ... | [LoadUserPlusKeys->[Load],ListFollowedUIDs->[Load],CheckKIDForUID->[loadWithInfo],loadWithInfo->[getCachedUPAK,putUPAKToCache],LookupUsernameAndDevice->[lookupUsernameAndDeviceWithInfo],PutUserToCache->[putUPAKToCache],Load->[loadWithInfo],lookupUsernameAndDeviceWithInfo->[loadWithInfo],LoadDeviceKey->[extractDeviceKey... | LoadKeyV2 loads a user s key and returns a userPlusKeysV2 object removeMemCache removes the n - ary cache from the disk and the UPAK cache. | can this just be `nil, nil, nil, NotFoundError{}` ? Always tricky to return data and an error, best to avoid it. |
@@ -4,6 +4,11 @@ module LambdaCallback
dcs = DocumentCaptureSession.find_by(result_id: result_id_parameter)
if dcs
+ analytics.track_event(
+ Analytics::LAMBDA_RESULT_ADDRESS_PROOF_RESULT,
+ result: address_result_parameter,
+ )
+
dcs.store_proofing_result(addres... | [AddressProofResultController->[result_id_parameter->[require],create->[to_h,track_exception_in_result,find_by,head,store_proofing_result,notice_error],track_exception_in_result->[nil?,notify_exception,notice_error],address_result_parameter->[permit],config_auth_token->[address_proof_result_lambda_token]]] | create a new missing result_id. | are we trying to log the whole result? or just the result ID? |
@@ -19,7 +19,7 @@ debug = SpackCommand('debug')
@pytest.mark.db
-def test_create_db_tarball(tmpdir, database):
+def test_create_db_tarball(tmpdir, database, mock_store):
with tmpdir.as_cwd():
debug('create-db-tarball')
| [test_report->[debug,python_version,get_version,get,str,Arch,platform],test_create_db_tarball->[query,debug,dag_hash,which,as_cwd,startswith,tar,getcwd,exists,next,listdir],SpackCommand] | Test create - db - tarball. | what about these changes necessitates the `mock_store` fixture? |
@@ -1641,6 +1641,11 @@ namespace Dynamo.Controls
collapsedSidebar.Visibility = Visibility.Visible;
}
+ private void onSettingsSubMenuOpened(object sender, RoutedEventArgs e)
+ {
+ this.ChangeScaleFactorMenu.IsEnabled = !dynamoViewModel.ShowStartPage;
+ }
+
... | [DynamoView->[DynamoView_Unloaded->[UnsubscribeNodeViewCustomizationEvents],DynamoViewModelRequestShowPackageManagerSearch->[DisplayTermsOfUseForAcceptance],Log->[Log],WindowClosing->[PerformShutdownSequenceOnViewModel],WorkspaceTabs_SizeChanged->[ToggleWorkspaceTabVisibility],WindowClosed->[PerformShutdownSequenceOnVi... | LibraryClicked event handler. | We follow the convention that all method names whether private, internal or public follow `CamelCase` so change this to `OnSettingsSubmenuOpened` |
@@ -510,7 +510,7 @@ public abstract class Proc {
/**
* An instance of {@link Proc}, which has an internal workaround for JENKINS-23271.
* It presumes that the instance of the object is guaranteed to be used after the {@link Proc#join()} call.
- * See <a href="https://jenkins-ci.org/issue/23271">JENKIN... | [Proc->[RemoteProc->[join->[isAlive,kill],kill->[isAlive]],joinWithTimeout->[run->[kill],join],LocalProc->[calcName->[join],join->[join,isAlive],environment->[environment],kill->[join]]]] | Replies an empty marker which is a superset of the object that is not part of the. | FWIW `jenkins.io/issue/` is the redirect URL for links to JENKINS Jira issues. Unless it's been deprecated, maybe it would make sense to extend its use? (Or perhaps it's time to abandon it entirely.) |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.