instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
netty/netty/5175_5192 | netty/netty | netty/netty/5175 | netty/netty/5192 | [
"timestamp(timedelta=22.0, similarity=0.876440567581754)"
] | 4d2e91a10dd6b2b3a1ec25a26e2f64d9c4212fe9 | e3cd7aacd7b1ad23b806310b40f6b3b4420297db | [
"At the moment not through this interface. What type of socket channel are you dealing with as there is likely a way to do it using an implementation of this interface.\n",
"NioSocketChannel, EpollSocketChannel or OioSocketChannel\n",
"I see you want it all ... stand by for a PR.\n",
"Fixed by https://github.... | [
"@normanmaurer - making `isInputShutdown()` abstract and removing this method is an API change ... i can be more strict with the API but this will change will only be for 4.1, and its OIO... let me know if you think I should spend more effort here to preserve the API\n",
"this is also an API change, but IMO was \... | 2016-04-30T02:37:08Z | [
"feature"
] | SocketChannel.shutdownInput()? | Is there a way to shutdownInput? I see that there is SocketChannel.shutdownOutput(), but no shutdownInput().
| [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannel.java",
"transport-udt/src/main/java/io/netty/channel/udt/nio/NioUdtByteConnectorChannel.java",
"transport/src/main/java/io/netty/channel/nio/AbstractNi... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannel.java",
"transport-udt/src/main/java/io/netty/channel/udt/nio/NioUdtByteConnectorChannel.java",
"transport/src/main/java/io/netty/channel/nio/AbstractNi... | [
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketShutdownOutputByPeerTest.java",
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketShutdownOutputBySelfTest.java"
] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java
index bc22b37370e..8cdbba542ef 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStre... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketShutdownOutputByPeerTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketShutdownOutputByPeerTest.java
new file mode 100644
index 00000000000..5a7bdc1b93f
--- /dev/null
+++ b/transport-native-epoll/src/test... | val | train | 2016-05-10T09:04:52 | 2016-04-25T23:24:06Z | vrozov | val |
netty/netty/5173_5195 | netty/netty | netty/netty/5173 | netty/netty/5195 | [
"timestamp(timedelta=18.0, similarity=0.8524211396772581)"
] | cf07f984b16d95719a9ece8c39ed6c11d8c57829 | 7e748e06e26e95320cc16b8092f4df01c8e79ab3 | [
"It only checks the fingerprint. It does not traverse the certificate chain at all. Theoretically, there's a chance where an attacker can forge a certificate with identical fingerprint, although it's not going to be very easy.\n\nI agree that it needs better documentation though. Would you be interested in sending ... | [
"@CodingFabian maybe add a `<a href=\"\"...>` for `Man-in-the-middle` \n",
"be consistent ... either use Man or man .\n",
"`This {@link TrustManagerFactory} will` -> `This {@link TrustManagerFactory} will <strong>only</strong>`\n"
] | 2016-05-02T13:27:58Z | [
"cleanup",
"documentation"
] | FingerprintTrustManagerFactory javadoc note cryptic | the javadoc says:
"Never use this {@link TrustManagerFactory} in production unless you are sure exactly what you are doing with it."
I was actually sure that in order to prevent MITM attacks, I want to pin the serverside certificates to a list of well known fingerprints. I do not want to accept other certificates.
S... | [
"handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java b/handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java
index c4563a99dde..79e434655a9 100644
--- a/handler/src/main/java/io/netty/handler/ssl/util/FingerprintTrustManagerFactory.java
+++ b/han... | null | test | train | 2016-05-01T20:30:13 | 2016-04-25T07:17:18Z | CodingFabian | val |
netty/netty/5157_5203 | netty/netty | netty/netty/5157 | netty/netty/5203 | [
"timestamp(timedelta=4.0, similarity=0.8883271627404382)"
] | a974fff07d9c3c5ff08d3f120f629abe618e2ab6 | 5f27ef240ad8007068d719ec1c4f1426280197e8 | [
"@Zpetkov the 5.x branch has been deprecated and is no longer supported. However, the issue also exists in 4.1. I ll take care of this.\n",
"Fixed by https://github.com/netty/netty/pull/5203\n"
] | [] | 2016-05-04T02:32:53Z | [
"defect"
] | JsonObjectDecoder does not handle escaped backslash | I've noticed the JsonObjectDecoder checks end of value string by looking at the previous char and if its the escape char \ then it's not the end of string if the current char is double quote. This is not correct.
Let's send the json object with key "key" and value "something\" , it is serialized as this:
{"key":"some... | [
"codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java"
] | [
"codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java"
] | [
"codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java b/codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java
index b791e410370..a34334b6c0e 100644
--- a/codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java
+++ b/codec/src/main/java/io/netty/handler/codec... | diff --git a/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java
index 08ece60917b..083b4eb1d43 100644
--- a/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java
+++ b/codec/src/test/java/io/netty/h... | train | train | 2016-05-03T08:41:30 | 2016-04-17T13:22:45Z | Zpetkov | val |
netty/netty/5199_5204 | netty/netty | netty/netty/5199 | netty/netty/5204 | [
"timestamp(timedelta=3.0, similarity=0.9025616792679517)"
] | f2ed3e6ce8039d142e4c047fcc9cf09409105243 | 4c13c85c398a92ee5080667243fc24c663956096 | [
"I've added this to the checklist in #3667. What you've proposed sounds good.\n\nGOAWAY and RST_STREAM can simply be ignored since the channel will closed automatically (they are propagated for additional information to those that want it; HTTP/1 doesn't want it). Stream ID should always be null on a child channel ... | [
"+1\n",
"fix formating \n",
"fix formating\n",
"I think we should retain as late as possible to mimize the risk of leak data in case of exceptions.\n",
"fix formating. \n",
"see above\n",
"Add `.` on EOL.\n",
"also assert the return value of all write calls (also in other tests).\n",
"also call chan... | 2016-05-04T07:04:45Z | [] | http/2 message => http/1.1 message adapter for the new http/2 api | ## problem
http/2 and http/1.1 have similar protocols, and it's useful to be able to implement a single server against a single interface. There's an injection from http/1.1 messages to http/2 ones, so it makes sense to make folks program against http/1.1 and upgrade them under the hood.
## proposed solution
a `Mess... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapter.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerDowngrader.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapter.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ServerDowngraderTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerDowngrader.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerDowngrader.java
new file mode 100644
index 00000000000..189e2cd52c2
--- /dev/null
+++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ServerDow... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ServerDowngraderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ServerDowngraderTest.java
new file mode 100644
index 00000000000..e7ca6702e73
--- /dev/null
+++ b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2S... | test | train | 2016-05-09T19:33:40 | 2016-05-03T00:44:33Z | mosesn | val |
netty/netty/5171_5210 | netty/netty | netty/netty/5171 | netty/netty/5210 | [
"timestamp(timedelta=22.0, similarity=0.8452019802756294)"
] | ce1ae0eb8bfec1fc77a2c1c67b34ac1ea1eb327c | bd939a18bb01ac284e3c089ac52689968702b651 | [
"@wanganran - Thanks for reporting.\n\n@trustin - Looks like this was introduced in https://github.com/netty/netty/commit/ada61d4985571f5406ea6158b02755d51392ebff . Can you take care?\n",
"will take care\n",
"I think NioDatagramChannel should report an error: https://github.com/netty/netty/blob/4.1/transport/sr... | [] | 2016-05-04T17:32:11Z | [
"defect"
] | NioDatagramChannel can only run under JDK 7+ | Hi,
My Netty version is 4.0.35.Final. I found that `io.netty.channel.socket.nio.NioDatagramChannelConfig` imports `java.nio.channels.NetworkChannel` which is new in JDK 7.
This will cause `NioDatagramChannel` unusable in Android where its Dalvik VM is under Java 1.6. A temporary solution is using `OioDatagramChannel`... | [
"transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannelConfig.java"
] | [
"transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannelConfig.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannelConfig.java b/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannelConfig.java
index 21b9e375c5c..5d1c9f84c3e 100644
--- a/transport/src/main/java/io/netty/channel/socket/nio/NioDatagramChannelConfig.java
+++ b/transport... | null | train | train | 2016-05-04T14:04:39 | 2016-04-22T12:25:40Z | wanganran | val |
netty/netty/5216_5219 | netty/netty | netty/netty/5216 | netty/netty/5219 | [
"timestamp(timedelta=61.0, similarity=0.9070950966957434)"
] | a96874aad4c8c22258a1a77dd86b6f5d161291bb | 4ca6a0c1e106d444650dc9eded4977603cb8af2d | [
"@nayato you are right... let me fix it.\n",
"Fixed https://github.com/netty/netty/pull/5219\n"
] | [] | 2016-05-06T19:42:14Z | [
"defect"
] | wrong huge deallocation counting in PoolArena.free | right now there's `deallocationsHuge.decrement();`
should be `deallocationsHuge.increment();`
| [
"buffer/src/main/java/io/netty/buffer/PoolArena.java"
] | [
"buffer/src/main/java/io/netty/buffer/PoolArena.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/PoolArena.java b/buffer/src/main/java/io/netty/buffer/PoolArena.java
index 1df94e493c3..e667d936c05 100644
--- a/buffer/src/main/java/io/netty/buffer/PoolArena.java
+++ b/buffer/src/main/java/io/netty/buffer/PoolArena.java
@@ -254,7 +254,7 @@ void free(PoolChunk<T> chun... | null | train | train | 2016-05-06T08:04:10 | 2016-05-05T18:44:21Z | nayato | val |
netty/netty/2422_5231 | netty/netty | netty/netty/2422 | netty/netty/5231 | [
"timestamp(timedelta=11.0, similarity=0.8916239172691428)"
] | d580245afc77f11e4b82a7f3320f5619b555c2ec | c9e337d7ad03b5913e5a2b6788729d0d9c7fa157 | [
"That's a good point. If a user specifies a promise when registering, a user doesn't really need to specify a channel because an event loop can get the channel from the specified promise. Let me fix this in 4.1.\n",
"@colalife @trustin makes sense\n",
"really encourage me，btw，i see it implements from EventLoo... | [] | 2016-05-10T01:52:54Z | [
"defect"
] | not sure about SingleThreadEventLoop.register(Channel, ChannelPromise) | hi all,
a little confused that why not this method change to register(ChannelPromise) since the channel is a param in DefaultChannelPromise's constructor...(will the promise change channel? ) ,not sure, thanks
source code:
@Override
public ChannelFuture register(Channel channel) {
return register(chan... | [
"transport/src/main/java/io/netty/channel/EventLoopGroup.java",
"transport/src/main/java/io/netty/channel/MultithreadEventLoopGroup.java",
"transport/src/main/java/io/netty/channel/SingleThreadEventLoop.java",
"transport/src/main/java/io/netty/channel/ThreadPerChannelEventLoop.java",
"transport/src/main/jav... | [
"transport/src/main/java/io/netty/channel/EventLoopGroup.java",
"transport/src/main/java/io/netty/channel/MultithreadEventLoopGroup.java",
"transport/src/main/java/io/netty/channel/SingleThreadEventLoop.java",
"transport/src/main/java/io/netty/channel/ThreadPerChannelEventLoop.java",
"transport/src/main/jav... | [
"transport/src/test/java/io/netty/bootstrap/BootstrapTest.java",
"transport/src/test/java/io/netty/channel/SingleThreadEventLoopTest.java",
"transport/src/test/java/io/netty/channel/ThreadPerChannelEventLoopGroupTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/EventLoopGroup.java b/transport/src/main/java/io/netty/channel/EventLoopGroup.java
index e2bf7c2c0af..3e390e82230 100644
--- a/transport/src/main/java/io/netty/channel/EventLoopGroup.java
+++ b/transport/src/main/java/io/netty/channel/EventLoopGroup.java
@@ -35,9 +3... | diff --git a/transport/src/test/java/io/netty/bootstrap/BootstrapTest.java b/transport/src/test/java/io/netty/bootstrap/BootstrapTest.java
index 53a15004ed8..cba71b3e4a1 100644
--- a/transport/src/test/java/io/netty/bootstrap/BootstrapTest.java
+++ b/transport/src/test/java/io/netty/bootstrap/BootstrapTest.java
@@ -275... | val | train | 2016-05-09T23:16:30 | 2014-04-24T09:08:16Z | colalife | val |
netty/netty/5174_5243 | netty/netty | netty/netty/5174 | netty/netty/5243 | [
"timestamp(timedelta=23.0, similarity=0.890638655932035)"
] | 2b340df452d5ec282b7cefd15f887f31604b9425 | 1823abe2920bad29aae3c5ac67114a2321557287 | [
"the underlying storage is currently exposed by `options` and `attr` and there is synchronization that must be applied when dealing with these collections. I'm guessing they are not exposed so the storage can be directly exposed (no copy etc...) and its assumed users of the interface \"play nice\" with synchronizat... | [
" Remove usage of generic wildcard type. [](https://garage.netty.io/sonarqube/coding_rules#rule_key=squid%3AS1452)\n",
... | 2016-05-13T05:27:55Z | [
"improvement",
"feature"
] | Expose Bootstrap getter methods and add some additional ones | The `Bootstrap` class (applies also to `AbstractBootstrap` and `ServerBootstrap`) has a few package private getter methods and some things such as `#attr()` and `#options()` aren't exposed at all. I'd argue there should be public getter methods for all of them.
Background: Our application is written in Java but we use... | [
"transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java",
"transport/src/main/java/io/netty/bootstrap/Bootstrap.java",
"transport/src/main/java/io/netty/bootstrap/ServerBootstrap.java"
] | [
"transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java",
"transport/src/main/java/io/netty/bootstrap/AbstractBootstrapConfig.java",
"transport/src/main/java/io/netty/bootstrap/Bootstrap.java",
"transport/src/main/java/io/netty/bootstrap/BootstrapConfig.java",
"transport/src/main/java/io/netty/bo... | [] | diff --git a/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java b/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
index a10c0d0fc94..7559dd3ba59 100644
--- a/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
+++ b/transport/src/main/java/io/netty/bootstrap/AbstractBootst... | null | train | train | 2016-05-18T09:11:49 | 2016-04-25T15:15:23Z | rkapsi | val |
netty/netty/5223_5251 | netty/netty | netty/netty/5223 | netty/netty/5251 | [
"timestamp(timedelta=16.0, similarity=0.8965582301594414)"
] | 15711d938dd7311b54b744a9ef98e0e6bacf32d3 | d2ee422f765c72350c5f158ca234900c55804d43 | [
"@nayato there is no good reason... let me fix it.\n",
"Fixed by https://github.com/netty/netty/pull/5251\n"
] | [] | 2016-05-13T05:57:12Z | [
"cleanup"
] | question on DefaultChannelPipeline.executorSafe - why indirection? | Is there a particular reason to access channel-assigned executor like so `channel.unsafe().invoker().executor()` vs `channel.eventLoop()`?
| [
"transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java"
] | [
"transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java b/transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java
index 5e56a974069..85696240a55 100644
--- a/transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java
+++ b/transport/src/main/java/io/netty/channel/Default... | null | train | train | 2016-05-11T09:03:53 | 2016-05-07T02:02:19Z | nayato | val |
netty/netty/3127_5255 | netty/netty | netty/netty/3127 | netty/netty/5255 | [
"timestamp(timedelta=24.0, similarity=0.8564786573284091)"
] | 30bb3094c16f8c3bf0f570f34f62a4a098cdb9b6 | f660a863d30452dd024d18e7ca0c7f7f4c477314 | [
"@Underbalanced we love contributions ;)\n",
"I will read up on the how to contribute as well as your code, I am pretty new to using proper design patterns. Started back in April with java. Though I have learned enough to write a Craftbukkit like server tool for another game, I skipped some important fundamentals... | [
"that match -> that are matched by\n\n.. because it's not a channel that matches a matcher?\n"
] | 2016-05-13T07:06:06Z | [
"feature"
] | voidPromise() - ChannelGroups | I think it would be useful to optionally voidPromises for Channel Groups.
| [
"transport/src/main/java/io/netty/channel/group/ChannelGroup.java",
"transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java"
] | [
"transport/src/main/java/io/netty/channel/group/ChannelGroup.java",
"transport/src/main/java/io/netty/channel/group/DefaultChannelGroup.java",
"transport/src/main/java/io/netty/channel/group/VoidChannelGroupFuture.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/group/ChannelGroup.java b/transport/src/main/java/io/netty/channel/group/ChannelGroup.java
index c66022e1d08..f24325b1cc9 100644
--- a/transport/src/main/java/io/netty/channel/group/ChannelGroup.java
+++ b/transport/src/main/java/io/netty/channel/group/ChannelGroup.... | null | test | train | 2016-05-13T08:51:44 | 2014-11-11T13:14:48Z | Mr00Anderson | val |
netty/netty/4200_5265 | netty/netty | netty/netty/4200 | netty/netty/5265 | [
"timestamp(timedelta=18.0, similarity=0.9098434823812074)"
] | f44f3e7926f1676315ae86d0f18bdd9b95681d9f | eb6331aca950945aeb087832bcea70b6b69f835d | [
"Fixed by https://github.com/netty/netty/pull/5265\n"
] | [
"use `new LinkedHashSet<...>(domanNamePatterns.length)`\n",
"Also ensure this is read-only ?\n",
"Added the length hint. Is there any `Map.Entry` implementation in netty?\n",
"> Also ensure this is read-only ?\n\nDone.\n"
] | 2016-05-17T05:53:53Z | [
"improvement",
"feature"
] | Allow retrieving the domain match lists in DomainNameMapping | Currently, there's no way to retrieve the list of all domain name patterns and their mapped values. It would be very useful when you have to build another `DomainNameMapping` (or an arbitrary `Mapping`) based on that list. e.g.
``` java
DomainNameMapping<SslContext> mapping = ...;
MyNameMapping<MyService> newMapping =... | [
"common/src/main/java/io/netty/util/DomainMappingBuilder.java",
"common/src/main/java/io/netty/util/DomainNameMapping.java"
] | [
"common/src/main/java/io/netty/util/DomainMappingBuilder.java",
"common/src/main/java/io/netty/util/DomainNameMapping.java"
] | [
"common/src/test/java/io/netty/util/DomainNameMappingTest.java"
] | diff --git a/common/src/main/java/io/netty/util/DomainMappingBuilder.java b/common/src/main/java/io/netty/util/DomainMappingBuilder.java
index 0cdb9712b7d..4d497456710 100644
--- a/common/src/main/java/io/netty/util/DomainMappingBuilder.java
+++ b/common/src/main/java/io/netty/util/DomainMappingBuilder.java
@@ -16,6 +1... | diff --git a/common/src/test/java/io/netty/util/DomainNameMappingTest.java b/common/src/test/java/io/netty/util/DomainNameMappingTest.java
index bd369e93018..606d6fca68d 100644
--- a/common/src/test/java/io/netty/util/DomainNameMappingTest.java
+++ b/common/src/test/java/io/netty/util/DomainNameMappingTest.java
@@ -16,... | train | train | 2016-05-17T07:43:46 | 2015-09-07T14:53:02Z | trustin | val |
netty/netty/5179_5267 | netty/netty | netty/netty/5179 | netty/netty/5267 | [
"timestamp(timedelta=28.0, similarity=0.9338759135638064)"
] | 3a9f47216143082bdfba62e8940160856767d672 | 77ef634bd7eedcfd77de3aa755f0d19430181314 | [
"This is the patch I wrote for [Armeria](https://github.com/line/armeria):\n\nhttps://github.com/line/armeria/pull/155/files\n\nAs shown in the PR above, we could write a decorating `NameResolver` that works for all `NameResolver` implementations. However, I'm not sure what the name of that class would be. Any sugg... | [
" Take the required action to fix the issue indicated by this comment. [](https://garage.netty.io/sonarqube/coding_rule... | 2016-05-17T11:01:32Z | [
"defect"
] | DNS name resolution queries should not be sent while the same query is in progress already. | When you attempt to make a lot of connection attempts to the same target host at the same time and our DNS resolver does not have a record for it in the cache, the DNS resolver will send as many DNS queries as the number of connection attempts.
As a result, DNS server will reject or drop the requests, making the name ... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/InflightNameResolver.java"
] | [] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java
index 4fb88c44d8d..1f666076c74 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java
+++ b/resolver-dns/src/main... | null | test | train | 2016-05-17T11:16:13 | 2016-04-27T03:44:37Z | trustin | val |
netty/netty/5175_5269 | netty/netty | netty/netty/5175 | netty/netty/5269 | [
"timestamp(timedelta=45.0, similarity=0.876440567581754)"
] | 1cb706ac932bab732257e02fc095d91ff7ed3788 | 36f8d74cf9adb83d51ee8ef6755632333b977e8e | [
"At the moment not through this interface. What type of socket channel are you dealing with as there is likely a way to do it using an implementation of this interface.\n",
"NioSocketChannel, EpollSocketChannel or OioSocketChannel\n",
"I see you want it all ... stand by for a PR.\n",
"Fixed by https://github.... | [] | 2016-05-17T20:57:13Z | [
"feature"
] | SocketChannel.shutdownInput()? | Is there a way to shutdownInput? I see that there is SocketChannel.shutdownOutput(), but no shutdownInput().
| [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannel.java",
"transport-udt/src/main/java/io/netty/channel/udt/nio/NioUdtByteConnectorChannel.java",
"transport/src/main/java/io/netty/channel/nio/AbstractNi... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java",
"transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannel.java",
"transport-udt/src/main/java/io/netty/channel/udt/nio/NioUdtByteConnectorChannel.java",
"transport/src/main/java/io/netty/channel/nio/AbstractNi... | [
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketShutdownOutputByPeerTest.java",
"transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketShutdownOutputBySelfTest.java"
] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java
index bc22b37370e..8cdbba542ef 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStre... | diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketShutdownOutputByPeerTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollSocketShutdownOutputByPeerTest.java
new file mode 100644
index 00000000000..5a7bdc1b93f
--- /dev/null
+++ b/transport-native-epoll/src/test... | train | train | 2016-05-17T22:42:16 | 2016-04-25T23:24:06Z | vrozov | val |
netty/netty/4211_5270 | netty/netty | netty/netty/4211 | netty/netty/5270 | [
"timestamp(timedelta=28.0, similarity=0.8719758372520758)"
] | 1cb706ac932bab732257e02fc095d91ff7ed3788 | a44783ab3084df6f91f6008148bd1901883a1121 | [
"Note that those `Submitter`s are just `int` wrappers, so I think the leak is more of an annoying warning than a severe issue.\n",
"Also the Netty `ForkJoinPool` is just a copy of the OpenJDK FJP. So maybe a simple up date to the latest OpenJDK version would resolve this.\n",
"@buchgr I wonder if it's actually ... | [] | 2016-05-18T02:06:41Z | [
"defect"
] | [ForkJoinPool] Thread Local Leak detected | The Atmosphere Framework bundles the [ForkJoinPool](https://github.com/netty/netty/blob/master/common/src/main/java/io/netty/util/internal/chmv8/ForkJoinPool.java) implementation of Netty. It seems there is a Thread Local leak as reported [here](https://github.com/Atmosphere/atmosphere/issues/2048)
``` java
SEVERE: Th... | [
"common/src/main/java/io/netty/util/internal/chmv8/ForkJoinPool.java"
] | [
"common/src/main/java/io/netty/util/internal/chmv8/ForkJoinPool.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/chmv8/ForkJoinPool.java b/common/src/main/java/io/netty/util/internal/chmv8/ForkJoinPool.java
index bfe4e9d269d..24bded99e5b 100644
--- a/common/src/main/java/io/netty/util/internal/chmv8/ForkJoinPool.java
+++ b/common/src/main/java/io/netty/util/internal/chmv8/F... | null | train | train | 2016-05-17T22:42:16 | 2015-09-14T15:55:42Z | jfarcand | val |
netty/netty/5320_5321 | netty/netty | netty/netty/5320 | netty/netty/5321 | [
"timestamp(timedelta=22.0, similarity=0.9284216160032346)"
] | 48ed70c1aa13a1d9b0a03d617edd1772f6aba314 | 240dd96dde8aabca777da51178caea73faa1e871 | [
"PR https://github.com/netty/netty/pull/5321\n",
"Fixed by https://github.com/netty/netty/pull/5321\n"
] | [
"Please define a static byte[] and reuse everytime. Something like:\n\nprivate static final byte[] ID = new byte[] {'n', 'e', 't', 't', 'y'};\n"
] | 2016-05-28T09:02:54Z | [
"defect"
] | OpensslEngine throws "session id context uninitialized" when used with client authentication | I use netty to implement a webserver. With JDK ssl provider all work well but with open ssl provider i see the following errors when connection is made from a firefox browser and client authentication (mutual ssl) is requested. Without client authentication the error does not occur.
<pre>
javax.net.ssl.SSLHandshakeExc... | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java
index 156843eb63c..f069eaa4927 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/OpenS... | null | train | train | 2016-05-28T08:02:07 | 2016-05-28T08:19:03Z | floragunn | val |
netty/netty/5119_5326 | netty/netty | netty/netty/5119 | netty/netty/5326 | [
"timestamp(timedelta=18.0, similarity=0.9191116549719136)"
] | db6b72da199f80c64d19d2d9bb1dfeec281dfd50 | 283720ca33294b3bd04783835ce7c1b68a2481e2 | [
"@MilosFabian we love PRs.. so maybe you can provide one as I don't have any good OSGI knowledge :(\n",
"Alright, I will work on it :) \n",
"Thanks ❤️!\n\n> Am 12.04.2016 um 09:33 schrieb MilosFabian notifications@github.com:\n> \n> Alright, I will work on it :)\n> \n> —\n> You are receiving this because you co... | [] | 2016-05-30T17:34:17Z | [
"defect"
] | netty-transport-native-epoll-*-linux-x86_64.jar is not OSGi bundle | Hello,
basically, reopening https://github.com/netty/netty/issues/3781
I am working on OpenDaylight project and we would like use netty-transport-native-epoll due to the TCP MD5 signature support. Currently we are using Netty version 4.0.33.Final and bumping to 4.0.36.Final right now.
Unfortunately, netty-transport-nat... | [
"common/pom.xml",
"transport-native-epoll/pom.xml"
] | [
"common/pom.xml",
"transport-native-epoll/pom.xml"
] | [] | diff --git a/common/pom.xml b/common/pom.xml
index 6385c932854..d0b99399e5b 100644
--- a/common/pom.xml
+++ b/common/pom.xml
@@ -138,6 +138,27 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifac... | null | train | train | 2016-05-30T15:10:15 | 2016-04-11T09:52:20Z | MilosFabian | val |
netty/netty/5280_5332 | netty/netty | netty/netty/5280 | netty/netty/5332 | [
"timestamp(timedelta=2632.0, similarity=0.9519604256868078)"
] | f6ad9df8acfad15e2a0986d9d2c91730f138163d | bc4b2b343e24baa5442e0410dbfadee054a40c82 | [
"@maseev I think you should try latest 4.1 branch and see how it behaves as we now also pool Slices if you use the PooledByteBufAllocator here.\n",
"@maseev maybe you want to send a PR which implements an \"optimised\" `LengthFieldBasedFrameDecoder` and `FixedLengthFrameDecoder` ?\n",
"I don't think your handle... | [
"Maybe the check can be moved to some constructor?\n",
"No need to assign writeIndex here I guess?\n",
"Maybe I am missing something, but I assume a decoder like this one may throw every frame decoded to out via buffer.retainSlice(), etc. I could not quite follow the point here, even after reading the tests. Co... | 2016-05-31T15:38:40Z | [] | Feature request: Optimized versions of LengthFieldBasedFrameDecoder and FixedLengthFrameDecoder | ##
| [] | [
"codec/src/main/java/io/netty/handler/codec/BulkFixedLengthFrameDecoder.java",
"codec/src/main/java/io/netty/handler/codec/BulkFrameDecoder.java",
"codec/src/main/java/io/netty/handler/codec/BulkLengthFieldBasedFrameDecoder.java"
] | [
"codec/src/test/java/io/netty/handler/codec/BulkFixedLengthFrameDecoderTest.java",
"codec/src/test/java/io/netty/handler/codec/BulkLengthFieldBasedFrameDecoderTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/BulkFixedLengthFrameDecoder.java b/codec/src/main/java/io/netty/handler/codec/BulkFixedLengthFrameDecoder.java
new file mode 100644
index 00000000000..4c3cfb8866d
--- /dev/null
+++ b/codec/src/main/java/io/netty/handler/codec/BulkFixedLengthFrameDecoder.java
@@ -0... | diff --git a/codec/src/test/java/io/netty/handler/codec/BulkFixedLengthFrameDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/BulkFixedLengthFrameDecoderTest.java
new file mode 100644
index 00000000000..d6ba85f2066
--- /dev/null
+++ b/codec/src/test/java/io/netty/handler/codec/BulkFixedLengthFrameDecoderTes... | train | train | 2016-06-02T18:22:47 | 2016-05-20T09:05:21Z | maseev | val |
netty/netty/5307_5349 | netty/netty | netty/netty/5307 | netty/netty/5349 | [
"timestamp(timedelta=14.0, similarity=0.8851513607779111)"
] | b461c9d54c40b79403d21aa6980ae4c4abcb3283 | b9d399d19c82946043601f5acff0bb6980e4ed2f | [
"@nmittler @ejona86 - WDYT?\n",
"@Scottmitch Yeah I think that seems reasonable. I suspect we'll want to set some sort of timeout on how long we wait for all of the streams to close before sending a `hard` `GOAWAY` and just closing the connection. Having all of this \"pluggable\" in some way might be handy.\n",
... | [
"Should the comment above be moved this this `else`?\n",
"Maybe add a comment here to describe what you're doing?\n",
"I will clarify the comments.\n",
"I will clarify the comments.\n"
] | 2016-06-03T19:39:10Z | [
"improvement"
] | Http2ConnectionHandler always sends GO_AWAY when channel is closed | If the channel is active `Http2ConnectionHandler` will always send a GO_AWAY when the channel is closed. This may be unnecessary, and even confusing to the remote peer, if the local peer is attempting to do a [graceful shutdown](https://tools.ietf.org/html/rfc7540#section-6.8). For example if the local peer manually se... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
index 3ba341eb456..b5c19d7078d 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2ConnectionHandler.java
+++ b/codec-... | null | test | train | 2016-06-06T11:04:56 | 2016-05-26T02:02:16Z | Scottmitch | val |
netty/netty/5374_5377 | netty/netty | netty/netty/5374 | netty/netty/5377 | [
"timestamp(timedelta=13.0, similarity=0.9126192891211647)"
] | c3abb9146e47b1c8de5a26b7ae5076845fc80c28 | 41f4c1a3df531908fa273f7de3361f4380b1a77a | [
"@rkapsi - Would you be interested in submitting a PR?\n",
"@Scottmitch On it...\n\n... but `io.netty.util.collection.*` seem to be missing on the 4.1 branch?!\n",
"@rkapsi its generated ... run mvn clean compile in the common module\n",
"@normanmaurer thanks!\n",
"Fixed by https://github.com/netty/netty/pu... | [
"Pass a `ByteBufAllocator` as a parameter and use it to allocate this buffer. We can use `UnpooledByteBufAllocator.DEFAULT` by default but at least this gives control over allocations done in this method.\n",
"Pass a `ByteBufAllocator` as a parameter and use it to allocate this buffer. We can use `UnpooledByteBuf... | 2016-06-08T22:39:46Z | [
"improvement",
"feature"
] | Let OpenSslContext take pre-encoded pkcs#8 private key/cert bytes | Netty 4.1.1-SNAPSHOT
It would be great if it was possible to pass pre-encoded pkcs#8 private key and certificate bytes into OpenSslContext and skip some of the stuff that is happening in OpenSslContext's `toBIO(...)` methods (namely the Base64 encoding and appending of the "---- BEGIN/END ----" markers).
| [
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/SslUtils.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java",
"handler/src/main/java/io/netty/handler/ssl/PemEncoded.java",
"handler/src/main/java/io/netty/handler/ssl/PemPrivateKey.java",
"handler/src/main/java/io/netty/handler/ssl/PemValue.java",
"handler/src/main/java/io/netty/handler/ssl/PemX509Cert... | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java
index 446560492fd..67de79d4320 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/OpenSslContext.java
@@ ... | null | train | train | 2016-06-10T13:19:45 | 2016-06-08T18:58:21Z | rkapsi | val |
netty/netty/5351_5379 | netty/netty | netty/netty/5351 | netty/netty/5379 | [
"timestamp(timedelta=22.0, similarity=0.8790954761111075)"
] | 783567420fd8109f172b5ab3f299ef750bac8805 | 2cd48502d0c9c6fd7a48f59029cfd888d413898b | [
"Splitted the proposal to new issue: https://github.com/netty/netty/issues/5352\n",
"@mickare - Thanks for bringing this to our attention. The javadocs should be updated. Let me take care.\n"
] | [] | 2016-06-08T22:47:52Z | [
"documentation"
] | [4.1] Futures removeListener: JavaDoc and implementation are inconsistent - duplicate listeners | #### Netty version: 4.1.0.CR7
#### Context:
I encountered an inconsistency between the JavaDoc description and implementation of the [Future](http://netty.io/4.1/api/io/netty/util/concurrent/Future.html).
I want to add multiple times (e.g. x 1000) the same close listener to a channel but I don't want this listener to ... | [
"common/src/main/java/io/netty/util/concurrent/Future.java"
] | [
"common/src/main/java/io/netty/util/concurrent/Future.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/concurrent/Future.java b/common/src/main/java/io/netty/util/concurrent/Future.java
index 8ddb860e149..16ffa722813 100644
--- a/common/src/main/java/io/netty/util/concurrent/Future.java
+++ b/common/src/main/java/io/netty/util/concurrent/Future.java
@@ -63,7 +63,7 @@ publi... | null | train | train | 2016-06-08T21:23:19 | 2016-06-04T19:40:56Z | mickare | val |
netty/netty/5387_5388 | netty/netty | netty/netty/5387 | netty/netty/5388 | [
"timestamp(timedelta=299.0, similarity=0.868294864826654)"
] | a7496ed83df3cf13c24fa9b5ce9494914fcd07ec | b27edba263edb6ba1cdf8945957aa1ae302a9477 | [
"@slandelle you are right... let me fix.\n",
"Awesome, thanks!\nI can provide a PR if you want, but I first wanted to be sure it was a bug and not intended behavior.\n",
"@slandelle a pr would be awesome! Please also add a test that we catch when `ChannelFactory.newChannel(...)` throws and notify the promise.\n... | [
"Please create the exception before the bootstrap and just throw it. This way you can use `assertSame(...)` below to check if the same exception. This is more robust compared to check for the message.\n",
"remove empty line\n",
"See below.\n",
"See above.\n"
] | 2016-06-13T13:11:38Z | [
"defect"
] | AbstractBootstrap#initAndRegister crash doesn't notify promise | `initAndRegister` can possibly crash, eg:
```
java.net.SocketException: Too many open files
at sun.nio.ch.Net.socket0(Native Method)
at sun.nio.ch.Net.socket(Net.java:411)
at sun.nio.ch.Net.socket(Net.java:404)
at sun.nio.ch.SocketChannelImpl.<init>(SocketChannelImpl.java:105)
at sun.nio.ch.Selecto... | [
"transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java"
] | [
"transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java"
] | [
"transport/src/test/java/io/netty/bootstrap/BootstrapTest.java"
] | diff --git a/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java b/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
index 519446c9e67..8513f20cb4c 100644
--- a/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
+++ b/transport/src/main/java/io/netty/bootstrap/AbstractBootst... | diff --git a/transport/src/test/java/io/netty/bootstrap/BootstrapTest.java b/transport/src/test/java/io/netty/bootstrap/BootstrapTest.java
index 81292f7cc5d..db00b984144 100644
--- a/transport/src/test/java/io/netty/bootstrap/BootstrapTest.java
+++ b/transport/src/test/java/io/netty/bootstrap/BootstrapTest.java
@@ -69,... | train | train | 2016-06-13T14:13:40 | 2016-06-13T11:48:13Z | slandelle | val |
netty/netty/5382_5405 | netty/netty | netty/netty/5382 | netty/netty/5405 | [
"timestamp(timedelta=73.0, similarity=0.882209135474392)"
] | 5e86325a8cb3bbe78440662290980c597c1a2d67 | 468799eb925b9b019d192093cf4577d0d766eed4 | [
"@mrokitka wow there are still people using HTTP/1.0 ? You are right we are currently only support it with HTTP/1.1, not sure if we will ever support HTTP/1.0. But at least we should \"skip\" HTTP/1.0 messages. Let me come up with a PR for this\n",
"@normanmaurer - I've run into this since we're using Squid as a ... | [] | 2016-06-16T19:56:41Z | [
"defect"
] | HttpContentCompressor/HttpContentEncoder should not set chunked transfer-encoding for HTTP 1.0 | Netty version: 4.1.0.Final
Context:
When using HttpContentCompressor and the HttpResponse is protocol version 1.0, HttpContentEncoder.encode() should not set the transfer-encoding header to chunked. Chunked transfer-encoding is not valid for HTTP 1.0 - this causes ERR_CONTENT_DECODING_FAILED errors in chrome and simi... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpContentEncoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
index a20a3fd7897..ec1856673c1 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
+++ b/codec-http/src/main/java... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentEncoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentEncoderTest.java
index dd774267564..660df3406e5 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentEncoderTest.java
+++ b/codec-http/s... | val | train | 2016-06-15T18:51:58 | 2016-06-10T02:21:46Z | mrokitka | val |
netty/netty/5386_5410 | netty/netty | netty/netty/5386 | netty/netty/5410 | [
"timestamp(timedelta=12.0, similarity=0.9073717107325305)"
] | 5e86325a8cb3bbe78440662290980c597c1a2d67 | 567bc3b6288c7dca90110d63cddd693f15827181 | [
"@vietj so what ? I think there is not much we can do without doing some crazy jni stuff :(\n",
"now in Vert.x we simply resolve localhost to `127.0.0.1` on Windows. Perhaps doing the same would make sense in Netty too.\n",
"Yeah maybe… and logging a warning. Let me do this.\n\n> On 13 Jun 2016, at 11:49, Julie... | [] | 2016-06-16T20:09:00Z | [
"defect"
] | io.netty.resolver.dns.DnsNameResolver does not resolve localhost on Windows | On Windows localhost is not in hosts file and the DNS server does not resolve this address either, i.e it is handled by the Windows API. So using a `Bootstrap` (among others) with the resolver based on `DnsNameResolver` will not resolve localhost.
http://serverfault.com/questions/4689/windows-7-localhost-name-resoluti... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java"
] | [] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
index 576a47229e6..a2d8101f812 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
+++ b/resolver-dns/src/main/java/io/netty/resolver/... | null | train | train | 2016-06-15T18:51:58 | 2016-06-13T09:27:20Z | vietj | val |
netty/netty/5391_5413 | netty/netty | netty/netty/5391 | netty/netty/5413 | [
"timestamp(timedelta=11.0, similarity=0.9507042869265819)"
] | 5e86325a8cb3bbe78440662290980c597c1a2d67 | a3a56f4335217310bb8b53d541851bd1933c2fc2 | [
"will check...\n\n@vietj thanks for reporting!\n",
"it made my day epic :-)\n",
"DNS epic day\n",
"lol\n",
"Fixed by https://github.com/netty/netty/pull/5413\n"
] | [
"Why need to create this `decodeName0` method? Is it for providing a hook method to allow people to change the behavior?\n",
"Yes\n\n> Am 16.06.2016 um 22:38 schrieb Xiaoyan Lin notifications@github.com:\n> \n> In codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java:\n> \n> > @@ -106,7 ... | 2016-06-16T20:13:04Z | [
"defect"
] | DnsNameResolver does not resolve property A+CNAME answer | The current DnsNameResolver fails to resolve an A+CNAME answer. For example:
```
dig moose.rmq.cloudamqp.com
...
;; ANSWER SECTION:
moose.rmq.cloudamqp.com. 1800 IN CNAME ec2-54-152-221-139.compute-1.amazonaws.com.
ec2-54-152-221-139.compute-1.amazonaws.com. 583612 IN A 54.152.221.139
...
```
The resolver const... | [
"codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java"
] | [
"codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java"
] | [] | diff --git a/codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java b/codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java
index d630413c843..3cafb477f35 100644
--- a/codec-dns/src/main/java/io/netty/handler/codec/dns/DefaultDnsRecordDecoder.java
+++ b/codec-dns/src/m... | null | test | train | 2016-06-15T18:51:58 | 2016-06-13T18:32:04Z | vietj | val |
netty/netty/5375_5418 | netty/netty | netty/netty/5375 | netty/netty/5418 | [
"timestamp(timedelta=3.0, similarity=0.8565223779274694)"
] | 9687d77b5ab1ca6b3bfd57dab8b71b796ad45b52 | 16bf3e5e2129e72aabdb382514e96f856512d4b7 | [
"Thanks for reporting @npordash! Are you in a situation where `listener.onDataRead` is called multiple times in `DelegatingDecompressorFrameListener`, and you are trying to call `consumeBytes(..)` for data which was not returned by previous calls to `Http2FrameListener.onDataRead`?\n",
"> I tested this with both ... | [
"nit: spelling on the method name ... should be `...Bytes`\n",
"Is this condition ever possible? I think it only would be if padding were `< 0`, which will never happen. Suggest either getting rid of this condition or moving it somewhere more clear.\n",
"Same comment as below.\n",
"Don't we also have to rem... | 2016-06-16T20:18:24Z | [
"defect"
] | DelegatingDecompressorFrameListener doesn't support deferral of processed bytes | `Http2FrameListener.onDataRead` states that reporting of processed bytes to the local flow controller can be deferred by returning something less than `data + padding` and then later doing something equivalent to `connection().local().flowController().consumeBytes(Http2Stream, int)`.
This works fine until you start us... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDecompressorFrameListener.java
index 50439c9fe7a..78ef230c62f 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DelegatingDeco... | null | val | train | 2016-06-20T14:23:47 | 2016-06-08T20:15:56Z | npordash | val |
netty/netty/5402_5419 | netty/netty | netty/netty/5402 | netty/netty/5419 | [
"timestamp(timedelta=22.0, similarity=0.9334949369019993)"
] | ee0897a1d9d80119990964834d62f906f800afb8 | 8abd03214e34f657c6cf6b460294103f155c1d99 | [
"@caillette yet that sounds not right... let me come up with a fix quickly.\n",
"Fixed https://github.com/netty/netty/pull/5419\n"
] | [
"`HttpScheme.HTTPS.port()`\n",
"consider using `HttpScheme` here\n",
"nit: you could just do `return originValue + ':' + wsPort;`\n",
"nit: HttpScheme also provides the `https` portion with `HttpScheme.name()`.\n"
] | 2016-06-16T20:20:40Z | [
"defect"
] | sec-websocket-origin should mention HTTPS | I'm using Netty WebSockets with HTTPS. When performing the handshake, the header field `sec-websocket-origin` is set to a value starting with `http://`, which looks weird.
There is nothing about `sec-websocket-origin` in the RFC.
The string `http` is set inconditionnally in `io.netty.handler.codec.http.websocketx.WebS... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/... | [
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java",
"codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07.java",
"codec-http/... | [
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker08Test.java",
"codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker13Test.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker.java
index 4f88bc7cbad..f91e4c7be0d 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSock... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker07Test.java
index 168a2458d17..91963102fde 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/websoc... | train | train | 2016-06-20T07:43:06 | 2016-06-16T17:34:16Z | caillette | val |
netty/netty/5431_5437 | netty/netty | netty/netty/5431 | netty/netty/5437 | [
"timestamp(timedelta=14.0, similarity=0.908510300263825)"
] | b4d4c0034d6f9e5e5884cc70e625d9f2655008bd | 12e416bbca7dd753731403fb5db879d7f056ea3c | [
"@trustin PTAL\n\n> Am 20.06.2016 um 16:09 schrieb Franck Chevassu notifications@github.com:\n> \n> [ netty-4.1.1.Final ]\n> \n> There seem to be a couple of things in HttpProxyHandler that do not comply with RFC 2817 (Upgrading to TLS Within HTTP/1.1)\n> \n> The HTTP version required to support the CONNECT method ... | [] | 2016-06-22T12:39:59Z | [
"defect"
] | Incorrect protocol version & "host" header in HttpProxyHandler | [ netty-4.1.1.Final ]
There seem to be a couple of things in HttpProxyHandler that do not comply with [RFC 2817](http://www.faqs.org/rfcs/rfc2817.html) (Upgrading to TLS Within HTTP/1.1)
- The HTTP version required to support the CONNECT method is 1.1,
whereas Netty's HttpProxyHandler class specifies a 1.0 version ... | [
"handler-proxy/src/main/java/io/netty/handler/proxy/HttpProxyHandler.java"
] | [
"handler-proxy/src/main/java/io/netty/handler/proxy/HttpProxyHandler.java"
] | [] | diff --git a/handler-proxy/src/main/java/io/netty/handler/proxy/HttpProxyHandler.java b/handler-proxy/src/main/java/io/netty/handler/proxy/HttpProxyHandler.java
index 376b319c02a..53d6fbb823d 100644
--- a/handler-proxy/src/main/java/io/netty/handler/proxy/HttpProxyHandler.java
+++ b/handler-proxy/src/main/java/io/netty... | null | train | train | 2016-06-22T14:26:05 | 2016-06-20T14:09:27Z | fchevassu | val |
netty/netty/5436_5446 | netty/netty | netty/netty/5436 | netty/netty/5446 | [
"timestamp(timedelta=41.0, similarity=1.0000000000000002)"
] | 2562ef7cbebe5eb4345cdde6323aeb0113c3f86c | 9a057aee7e63a3d0e5fdebb1b4526b1d6f63d661 | [
"`HpackUtil.equals` currently implements an equality comparison which \"doesn't leak timing information\" [1]. @jpinner - can you provide some motivation for why this type of comparison is necessary in this specific case?\n\n[1] https://github.com/twitter/hpack/commit/84e3438ae60efad587c7058c87b04064d7d6a536#diff-d... | [
"@Scottmitch could you not just use the methods in PlatformDependent0 ?\n",
"can you clarify which method you are suggesting I use? `PlatformDependent0` doesn't have a equals which accepts a `CharSequence`.\n",
"I ran benchmarks comparing some equals functions, and found that it is significantly faster to use a... | 2016-06-22T23:25:49Z | [
"improvement"
] | HpackUtil.equals performance improvement | PR https://github.com/netty/netty/pull/5355 modified interfaces to reduce GC related to the HPACK code. However this came with an anticipated performance regression related to `HpackUtil.equals` due to `AsciiString`'s increase cost of `charAt(..)`. We should mitigate this performance regression.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/HeaderField.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/HpackUtil.java",
"codec-http2/src/main/java/io/netty/handler/co... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/HeaderField.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/HpackUtil.java",
"codec-http2/src/main/java/io/netty/handler/co... | [
"common/src/test/java/io/netty/util/internal/PlatformDependentTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java
index abc2948a451..ba0aa01bc28 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java
+++ b/codec-... | diff --git a/common/src/test/java/io/netty/util/internal/PlatformDependentTest.java b/common/src/test/java/io/netty/util/internal/PlatformDependentTest.java
index b31e36c0086..53ea6a846f6 100644
--- a/common/src/test/java/io/netty/util/internal/PlatformDependentTest.java
+++ b/common/src/test/java/io/netty/util/interna... | val | train | 2016-06-27T13:43:06 | 2016-06-22T06:26:23Z | Scottmitch | val |
netty/netty/5434_5448 | netty/netty | netty/netty/5434 | netty/netty/5448 | [
"timestamp(timedelta=5.0, similarity=0.8870567172644754)"
] | 731f52fdf73852a8fc597b1f08ed86b63caee375 | 863413fdb35b160b2020f27678c450555c250568 | [
"We also need to audit outbound path.\n",
"cc: @Scottmitch, @normanmaurer, @nmittler \n",
"@ejona86 should I take this?\n",
"@buchgr, please do.\n\nThis will also need to be updated:\nhttps://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2DataFrame.java#L72\... | [
"Either keep the return value int or don't cast to short?\n",
"You might comment that the +1 is due to the pad length, which comes before most of the payload whereas the padding itself comes after.\n",
"Probably should add a bit of javadoc to make it clear how it is different from `padding`. The implementation ... | 2016-06-23T12:38:25Z | [
"defect"
] | http2: Off-by-one accounting with flow control and padding | Per [the spec](http://httpwg.org/specs/rfc7540.html#DATA):
> The entire DATA frame payload is included in flow control, including the Pad Length and Padding fields if present.
However, it seems the pad length isn't being accounted for.
https://github.com/netty/netty/blob/netty-4.1.1.Final/codec-http2/src/main/java/io... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2DataFrame.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java",
"codec-http2/src/main/java/io/netty/handler/codec/h... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2DataFrame.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameReader.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2FrameWriter.java",
"codec-http2/src/main/java/io/netty/handler/codec/h... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2DataFrame.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2DataFrame.java
index 84c99e86fd0..fe879c98e23 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2DataFrame.java
+++ b/codec-htt... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java
index 99f285d9194..3e771b459d4 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameRoundtripTest.java
+++ b/cod... | val | train | 2016-06-24T17:08:30 | 2016-06-21T15:51:54Z | ejona86 | val |
netty/netty/5054_5451 | netty/netty | netty/netty/5054 | netty/netty/5451 | [
"timestamp(timedelta=23.0, similarity=0.9354724155765581)"
] | c9f963dc8e75d9abb89750807ec6627b40f7aada | 3ccdb6f1095056e8b59c2092e3bde6e86df76f07 | [
"checking...\n",
"Verified that the issue not exists in 4.x. Looking into 3.10.x now.\n",
"Hi @normanmaurer I would like to know if there are any plans to fix this soon as I would like to see 3.10.6.Final released as soon as it is humanly possible.\n",
"I had no time yet... If you want help submit a PR 👍\n\n... | [
"This is a copy & paste from `4.0` branch, I noticed it preferred direct access vs `for-each byte` which creates an iterator.\n",
"This is the actual bug fix, to not return true when `mask == -1` which is also a copy & paste from `4.0` branch.\n"
] | 2016-06-25T14:05:38Z | [
"defect"
] | IpV4Subnet.contains() always returns true for single-address subnets (3.10.4) | I may have this wrong (since I'm fairly new to network programming) but my understanding is that a /32 CIDR block represents a single IP address, so I would expect an IpV4Subnet instance with this range to only match that exact IP - but, for example
new IpV4Subnet("1.1.1.1/32").contains("10.0.16.64")
both return true... | [
"src/main/java/org/jboss/netty/handler/ipfilter/IpV4Subnet.java"
] | [
"src/main/java/org/jboss/netty/handler/ipfilter/IpV4Subnet.java"
] | [] | diff --git a/src/main/java/org/jboss/netty/handler/ipfilter/IpV4Subnet.java b/src/main/java/org/jboss/netty/handler/ipfilter/IpV4Subnet.java
index 09dfdf2bb25..51d30964c04 100644
--- a/src/main/java/org/jboss/netty/handler/ipfilter/IpV4Subnet.java
+++ b/src/main/java/org/jboss/netty/handler/ipfilter/IpV4Subnet.java
@@ ... | null | val | train | 2016-03-07T16:15:14 | 2016-03-29T23:19:55Z | ashleymercer | val |
netty/netty/5457_5461 | netty/netty | netty/netty/5457 | netty/netty/5461 | [
"timestamp(timedelta=13.0, similarity=0.948771872386056)"
] | 5e649850898889a8d2f1e526db610a8fca19c1ff | a34c77c29e9eff8ab5bf22c6fdce0b2bdcde06f7 | [
"@vietj +1 ... Want to provide a pr?\n",
"will do soon @normanmaurer \n",
"@vietj thanks a lot!\n",
"I'm seing an issue in tests because the channel is not yet initialized on registration, i.e the code:\n\n```\n b.handler(new ChannelInitializer<DatagramChannel>() {\n @Override\n p... | [
"woups\n",
"@vietj make the constructor package private\n"
] | 2016-06-28T10:14:57Z | [
"defect"
] | DnsNameResolver should not bind locally | Netty version: 4.1.1.Final (and master)
Context:
Dns resolution failures when using the `DnsNameResolver` and the JVM is not authorized to bind datagram channels.
Steps to reproduce:
Use the `DnsNameResolver` with an environment that does not allow to bind datagram channels.
The current `DnsNameResolver` binds local... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsQueryContext.java"
] | [] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java
index 26f99905e47..27f7d2ab011 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java
+++ b/resolver-dns/src/main... | null | val | train | 2016-06-28T09:34:01 | 2016-06-27T23:52:46Z | vietj | val |
netty/netty/5357_5466 | netty/netty | netty/netty/5357 | netty/netty/5466 | [
"timestamp(timedelta=19.0, similarity=0.9095846852576694)"
] | 804e058e27e16e346b565ce4490f6177574e267d | 1fabea9975fc92e603ae9aa0973c7bd2853ade7b | [
"For `hash(CharSequence)`, it's a bit dangerous to use `hashCode()`. In `CharSequence`'s Javadoc:\n\n> This interface does not refine the general contracts of the equals and hashCode methods. The result of comparing two objects that implement CharSequence is therefore, in general, undefined.\n",
"@ejona86 - Great... | [] | 2016-06-29T01:16:12Z | [] | HPACK Encoder.java data structure improvements | Encoder.java's data structure looks very similar to the data structure used in `DefaultHeaders`. We should investigate making some of the same improvements in Encoder.java as were made in `DefaultHeaders`:
- The underlying array should be a power of 2. Then we can use a mask `&` operation to index into the array.
- The... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java",
"codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java",
"common/src/main/java/io/netty/util/AsciiString.java",
"microbench/src/main/java/io/netty/microbench/http2/internal/hpack/EncoderBenchmark.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java",
"codec/src/main/java/io/netty/handler/codec/DefaultHeaders.java",
"common/src/main/java/io/netty/util/AsciiString.java",
"microbench/src/main/java/io/netty/microbench/http2/internal/hpack/EncoderBenchmark.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/internal/hpack/TestCase.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java
index ba0aa01bc28..4051dc37046 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/internal/hpack/TestCase.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/internal/hpack/TestCase.java
index f4cb467ea98..6e33536cefe 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/internal/hpack/TestCase.java
+++ b/cod... | train | train | 2016-06-28T15:39:42 | 2016-06-06T17:47:42Z | Scottmitch | val |
netty/netty/5514_5527 | netty/netty | netty/netty/5514 | netty/netty/5527 | [
"timestamp(timedelta=38.0, similarity=0.8489490830934392)"
] | 196540ca1da50465f899cfd6887d49a69e43269d | 9bcea87aa5943ca013eeb61319d293c40f33e307 | [
"yes the equals implementation does seem suspect ... @veebs wdyt?\n",
"Fixed by https://github.com/netty/netty/pull/5527\n"
] | [
"nit: kill line\n",
"do we have any context for how this was intended to be used? It seems strange to compare the length, but not compare the actual content. If we don't do this consider just making this method `return upload1.getName().compareToIgnoreCase(upload2.getName());`\n",
"@Scottmitch no context here..... | 2016-07-13T04:33:47Z | [
"defect"
] | MemoryFileUpload & DiskFileUpload NOT equals itself | test code:
```
@Test
public final void testMemoryFileUploadEquals() {
final MemoryFileUpload f1 =
new MemoryFileUpload("m1", "m1", "application/json", null, null, 100);
assertEquals(f1, f1);
}
@Test
public final void testDiskFileUploadEquals() {
final DiskFileUpload f2 =
new Dis... | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskFileUpload.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/MemoryFileUpload.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskFileUpload.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/FileUploadUtil.java",
"codec-http/src/main/java/io/netty/handler/codec/http/multipart/MemoryFileUpload.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/multipart/DiskFileUploadTest.java",
"codec-http/src/test/java/io/netty/handler/codec/http/multipart/MemoryFileUploadTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskFileUpload.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskFileUpload.java
index 1932004dd6b..8c253b43d23 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/DiskFileUpload.java
+++ b/codec-... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/DiskFileUploadTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/DiskFileUploadTest.java
new file mode 100644
index 00000000000..fa5661e379d
--- /dev/null
+++ b/codec-http/src/test/java/io/netty/handler/codec/http/multip... | train | train | 2016-07-13T21:33:16 | 2016-07-08T11:09:40Z | isdom | val |
netty/netty/5530_5537 | netty/netty | netty/netty/5530 | netty/netty/5537 | [
"timestamp(timedelta=158290.0, similarity=0.8964804195974887)"
] | 047f6aed289219e7461b4c6bbcbb6c88d7082b06 | 211da398f01de335416017c9e21c37deaa622bf4 | [
"@olix0r nope... A PR would be awesome :)\n",
"@olix0r actually @Scottmitch made a good point. Can you wrap the code into a try / catch block and fail the promise on error ?\n"
] | [
"@buchgr should we remove the `exceptionCaught(...)` here ? I think if we propagate to the promise we should not also call `exceptionCaught(...)`. Also @nmittler @Scottmitch WDYT ?\n"
] | 2016-07-14T15:19:09Z | [] | codec-http2: Http2FrameCodec never satisfies promise on Http2WindowUpdateFrame | I noticed that when Http2WindowUpdateFrame is written to Http2FrameCodec, the write [promise is never satisfied](https://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java#L144). Is this intentional? If not, I'm happy to submit a fix.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java
index 23769cfc9a9..b9cd604063a 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java
+++ b/codec-http2/src/main/java/i... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java
index e404e396f08..c8fabd3004e 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java
+++ b/codec-http2/src... | train | train | 2016-07-15T09:09:13 | 2016-07-13T17:06:15Z | olix0r | val |
netty/netty/5539_5545 | netty/netty | netty/netty/5539 | netty/netty/5545 | [
"timestamp(timedelta=19.0, similarity=0.8874743946475105)"
] | 2ce1d29d4deb30ca60dc94e0db25047ea2a639d8 | 6d20b61454ac24c0df4d98627c08de7a79c5caf6 | [
"BTW, I have tried the 4.1.3.Final-SNAPSHOT version, it came out the same error too.\n",
"@xsir let us know... I have not much knowledge in terms of osgi.\n",
"I have figured it out finally. The root cause is: the `netty-tcnative` library is loaded by a ClassLoader that is fully independent of its bundle ClassL... | [
"does this need to be public? can this just be `private static` and live in `NativeLibraryLoader`?\n",
"can we do the reflection initialization parts bits statically when initializing `NativeLibraryLoader`?\n",
"Hi, @Scottmitch ! That was a good idea. But, the helper class's duty is to delegate the calling to S... | 2016-07-15T17:29:24Z | [
"defect"
] | Tcnative init failed with org.apache.tomcat.jni.Library.version(I)I in OSGi | I am working a OSGi project with netty-tcnative + TLS and encounter a java.lang.UnsatisfiedLinkError in OpenSsl initialization.
Here is the log:
java.lang.UnsatisfiedLinkError: org.apache.tomcat.jni.Library.version(I)I
at org.apache.tomcat.jni.Library.version(Native Method)
at org.apache.tomcat.jni.Library.in... | [
"common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java"
] | [
"common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java",
"common/src/main/java/io/netty/util/internal/NativeLibraryUtil.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java b/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java
index 2f5a00836bb..9a1ba33cb2e 100644
--- a/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java
+++ b/common/src/main/java/io/netty/util/internal/Nati... | null | train | train | 2016-07-22T09:14:54 | 2016-07-14T17:47:54Z | xsir | val |
netty/netty/5553_5557 | netty/netty | netty/netty/5553 | netty/netty/5557 | [
"timestamp(timedelta=11.0, similarity=0.968899664563478)"
] | e00b797936a02fea1c43b04ba23a3400e5b3f639 | b9f73461ea8d1d92a91124eb27fbf6b3ab5e6ae4 | [
"@rkapsi good catch! Let me come up with a fix\n",
"@rkapsi PTAL https://github.com/netty/netty/pull/5557\n",
"Fixed by https://github.com/netty/netty/pull/5557\n"
] | [] | 2016-07-20T03:54:47Z | [
"defect"
] | SimpleChannelPool#notifyConnect() may leak Channels | Hey,
I just stumbled onto this one. The `SimpleChannelPool#notifyConnect()` method will leak Channels if the user cancelled the Promise.
``` java
private static void notifyConnect(ChannelFuture future, Promise<Channel> promise) {
if (future.isSuccess()) {
// This will leak the Channel if the Prom... | [
"transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java"
] | [
"transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java b/transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java
index 85767f32c6c..9fcf0d8d6f0 100644
--- a/transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java
+++ b/transport/src/main/java/io/netty/channel/pool/Si... | null | test | train | 2016-07-19T18:51:25 | 2016-07-19T18:26:02Z | rkapsi | val |
netty/netty/5565_5567 | netty/netty | netty/netty/5565 | netty/netty/5567 | [
"timestamp(timedelta=20.0, similarity=0.8538622961285909)"
] | 9151739577b9270ee8ae50cbda705942c927e8ff | 24095a0d628b3e3daa01970c1727b2fbc5e1a163 | [
"I added a PR for this: #5567 \n",
"Fixed by https://github.com/netty/netty/pull/5567\n"
] | [] | 2016-07-22T00:39:35Z | [
"defect"
] | OpenSslServerContext NullPointEexception when using a KeyManagerFactory | Support for using a KeyManagerFactory with OpenSSL was added by [PR 5493](https://github.com/netty/netty/pull/5439). However, there are a couple lingering `checkNotNull()` [assertions](https://github.com/netty/netty/blob/4.1/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java#L352) that cause a NullPoi... | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java
index 9db007a7d6b..4986388d07a 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSslServerContext.java
+++ b/handler/src/main/java/io/netty/handler/ssl/OpenS... | null | val | train | 2016-07-21T11:39:56 | 2016-07-21T22:21:53Z | JackOfMostTrades | val |
netty/netty/5570_5571 | netty/netty | netty/netty/5570 | netty/netty/5571 | [
"timestamp(timedelta=17.0, similarity=0.9533093199440464)"
] | 94d7557dead5e7780769d44bbb4aa7530149ca34 | afec40bf610c84fe9cd71cb81bf336b39cedfaab | [
"Fixed by https://github.com/netty/netty/pull/5571\n"
] | [
"Shouldnt this stay outside of the rose block?\n",
"I don't understand what you mean.\n",
"Outside of the else block.... Thanks to autocorrect\n",
"no, it's the same behavior than in the foreach loop that returns immediately after calling internalResolve.\n",
"got it.\n",
"call resolver.close() at the end... | 2016-07-23T07:58:40Z | [
"defect"
] | Allow ndots=0 in DnsNameResolver and search domains | Motivation:
The `ndots = 0` is a valid value for ndots, it means that when using a non dotted name, the resolution should first try using a search and if it fails then use subdomains. Currently it is not allowed.
Docker compose uses this when wiring up containers as names have usually no dots inside.. An example of d... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java"
] | [
"resolver-dns/src/test/java/io/netty/resolver/dns/SearchDomainTest.java"
] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
index 6f2e4192d76..b6148ddc89b 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java
+++ b/resolver-dns/src/main/java/io/netty/resolver/... | diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/SearchDomainTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/SearchDomainTest.java
index c3e677b4c9a..da89173848c 100644
--- a/resolver-dns/src/test/java/io/netty/resolver/dns/SearchDomainTest.java
+++ b/resolver-dns/src/test/java/io/netty/resolv... | val | train | 2016-07-22T20:42:05 | 2016-07-22T18:20:41Z | vietj | val |
netty/netty/5590_5591 | netty/netty | netty/netty/5590 | netty/netty/5591 | [
"timestamp(timedelta=63.0, similarity=0.8996140167226422)"
] | cebf255951a257068bbcab4781d4c6085e3289bd | ee1cae0e6f6acc21dfbee998737b28652238731a | [] | [] | 2016-07-27T05:28:25Z | [] | QueryStringDecoder#path should decode the path info | Netty version: 4.1.3.Final, 4.0.39.Final
For example, given "foo%20bar", it should return "foo bar", not "foo%20bar".
| [
"codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/QueryStringDecoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java
index fdffb2e217e..b4996267788 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java
+++ b/codec-http/src/main/java... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/QueryStringDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/QueryStringDecoderTest.java
index 49b069f6dba..caee98a0806 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/QueryStringDecoderTest.java
+++ b/codec-http/s... | train | train | 2016-07-27T07:11:47 | 2016-07-27T05:18:31Z | ngocdaothanh | val |
netty/netty/5601_5603 | netty/netty | netty/netty/5601 | netty/netty/5603 | [
"timestamp(timedelta=385.0, similarity=0.8761801680318148)"
] | 82b617dfe9d28b6361006e6e9943fc83248aa7dd | d513dc8e17ceaefab509df22faa88e7a69663379 | [] | [] | 2016-07-29T21:20:48Z | [
"defect"
] | Consider adding findNextPositivePowerOfTwo which does bound checks | See:
https://github.com/netty/netty/pull/5594#discussion_r72509427
| [
"buffer/src/main/java/io/netty/buffer/PoolThreadCache.java",
"common/src/main/java/io/netty/util/Recycler.java",
"common/src/main/java/io/netty/util/ResourceLeakDetector.java",
"common/src/main/java/io/netty/util/internal/MathUtil.java",
"common/src/main/templates/io/netty/util/collection/KObjectHashMap.tem... | [
"buffer/src/main/java/io/netty/buffer/PoolThreadCache.java",
"common/src/main/java/io/netty/util/Recycler.java",
"common/src/main/java/io/netty/util/ResourceLeakDetector.java",
"common/src/main/java/io/netty/util/internal/MathUtil.java",
"common/src/main/templates/io/netty/util/collection/KObjectHashMap.tem... | [] | diff --git a/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java b/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
index fb044c851a2..0caa6f1efc7 100644
--- a/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
+++ b/buffer/src/main/java/io/netty/buffer/PoolThreadCache.java
@@ -369,7 +369,7 @@ pri... | null | train | train | 2016-07-29T20:16:44 | 2016-07-29T14:06:23Z | normanmaurer | val |
netty/netty/5597_5605 | netty/netty | netty/netty/5597 | netty/netty/5605 | [
"timestamp(timedelta=50.0, similarity=0.8688967097123617)"
] | 82b617dfe9d28b6361006e6e9943fc83248aa7dd | a0c809b7c1c501b1f0c6aa2f3430995ddb798477 | [
"Thanks will check\n",
"thanks for reporting @tkaitchuck !\n",
"Fixed by https://github.com/netty/netty/pull/5605\n"
] | [] | 2016-07-30T06:22:41Z | [
"defect"
] | Unpooled tries to double release empty buffer | See:
https://github.com/netty/netty/blob/4.1/buffer/src/main/java/io/netty/buffer/Unpooled.java#L316
In unpooled when an empty buffer is at the start of the list of several to be wrapped, it first detects the empty buffer. Then without removing it from the list it passes the whole list to the CompositeByteBuf construct... | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java",
"buffer/src/main/java/io/netty/buffer/Unpooled.java"
] | [
"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java",
"buffer/src/main/java/io/netty/buffer/Unpooled.java"
] | [
"buffer/src/test/java/io/netty/buffer/UnpooledTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
index 05ceb4adfff..8cd285e2bc8 100644
--- a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java
@@ -65,6 +65,11 @@ ... | diff --git a/buffer/src/test/java/io/netty/buffer/UnpooledTest.java b/buffer/src/test/java/io/netty/buffer/UnpooledTest.java
index d0dfc1ed292..5abf700267f 100644
--- a/buffer/src/test/java/io/netty/buffer/UnpooledTest.java
+++ b/buffer/src/test/java/io/netty/buffer/UnpooledTest.java
@@ -628,4 +628,22 @@ public void sk... | train | train | 2016-07-29T20:16:44 | 2016-07-29T00:28:35Z | tkaitchuck | val |
netty/netty/5602_5608 | netty/netty | netty/netty/5602 | netty/netty/5608 | [
"timestamp(timedelta=134149.0, similarity=1.0000000000000002)"
] | e85d43739819e6408c3a4a4e2f9e71bcf6905a2e | 8803b0d89ab929e1178a9844147154ba50d5cf3d | [
"To show the issue in vert.x the following unit test should show the error message when running it inside the current master of eclipse/vert.x\n\nhttps://gist.github.com/alexlehm/d4d4ffdf95c97c78dff7ba91de1b0d09\n\nStarting test: UnknownHostExceptionTest#testResolveExceptionHostname \njava.net.UnknownHostException:... | [] | 2016-07-31T01:27:21Z | [
"defect"
] | UnknownHostException mentions hostname with search domain added | Netty version: 4.1.4.Final
Context:
While testing the dns resolution of vert.x I found the cosmetic issue that the exception for UnknownHost mentions the hostname with the last attempted search domain appended, which is kind of confusing. I would prefer to see the original hostname supplied to the method in the except... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java"
] | [
"resolver-dns/src/test/java/io/netty/resolver/dns/SearchDomainTest.java"
] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java
index 08ba335a6ad..3579e0644ec 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java
+++ b/resolver-dns/src/main/ja... | diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/SearchDomainTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/SearchDomainTest.java
index da89173848c..77c652ff79f 100644
--- a/resolver-dns/src/test/java/io/netty/resolver/dns/SearchDomainTest.java
+++ b/resolver-dns/src/test/java/io/netty/resolv... | test | train | 2016-07-30T21:16:44 | 2016-07-29T20:48:28Z | alexlehm | val |
netty/netty/5615_5625 | netty/netty | netty/netty/5615 | netty/netty/5625 | [
"timestamp(timedelta=75.0, similarity=0.8588913995068724)"
] | 0b086a9625cd2e8219711e04579466a43d4a4e99 | afefcde34b269208463dab8116dc6bc9e683bda6 | [
"I agree, I prefer `SLF4J-API` and `Logback`\n",
"it is causing any harm? maybe we can just mark it as deprecated, comment it will be removed in future releases, and recommend using an alternative (e.g. slf4j).\n",
"> it is causing any harm?\n\nNo harm. It is very outdated and not used within netty. Deprecation... | [] | 2016-08-03T20:32:05Z | [
"cleanup"
] | Proposal : remove commons logging classes | Remove `CommonsLogger` and `CommonsLoggerFactory` classes.
Commons-logging project is not updated for 2 years already. I propose to remove it also from netty too.
Let me know If I can submit PR.
| [
"common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java",
"common/src/main/java/io/netty/util/internal/logging/CommonsLoggerFactory.java"
] | [
"common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java",
"common/src/main/java/io/netty/util/internal/logging/CommonsLoggerFactory.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java b/common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java
index 1068005e893..110f0f1cf92 100644
--- a/common/src/main/java/io/netty/util/internal/logging/CommonsLogger.java
+++ b/common/src/main/java/io/netty/util/interna... | null | train | train | 2016-08-03T22:15:40 | 2016-08-01T12:28:58Z | doom369 | val |
netty/netty/4204_5638 | netty/netty | netty/netty/4204 | netty/netty/5638 | [
"timestamp(timedelta=20.0, similarity=0.9641005524722586)"
] | df5cb48e08122c861e71a1bc6da9e554250f9633 | 5a3acfa319fd9d515880d2af6bf29e6178aea21a | [
"Do you want to provide a pr to fix it?\n",
"I'm on company time - I'll ask (+day of turnaround).\n\nSupposing that I get an OK to fix/re test.\nDo you want to:\n- have the DefaultSctpServerChannelConfig brought to match DefaultSctpChannelConfig (where the static import is `import static io.netty.channel.sctp.Sct... | [
"nit: newline\n",
"fixed\n"
] | 2016-08-04T19:15:38Z | [
"defect"
] | Broken support of SCTP_INIT_MAXSTREAMS in *SctpServerChannel | Netty version: 4.0.12.Final (but the suspected code is the same in the current 4.0 branch).
The SCTP_INIT_MAXSTREAMS property is ignored on NioSctpServerChannel (and judging by the source on OioSctpServerChannel too).
JUnit test to reproduce:
``` java
import com.sun.nio.sctp.SctpServerChannel;
import com.sun.nio.sct... | [
"transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java",
"transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpServerChannelConfig.java"
] | [
"transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java",
"transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpServerChannelConfig.java"
] | [
"transport-sctp/src/main/test/io/netty/channel/sctp/SctpLimitStreamsTest.java",
"transport-sctp/src/main/test/io/netty/channel/sctp/nio/NioSctpLimitStreamsTest.java",
"transport-sctp/src/main/test/io/netty/channel/sctp/oio/OioSctpLimitStreamsTest.java"
] | diff --git a/transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java b/transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java
index 932e09ca3a9..6b284992e81 100644
--- a/transport-sctp/src/main/java/io/netty/channel/sctp/DefaultSctpChannelConfig.java
+++ b/transport-sc... | diff --git a/transport-sctp/src/main/test/io/netty/channel/sctp/SctpLimitStreamsTest.java b/transport-sctp/src/main/test/io/netty/channel/sctp/SctpLimitStreamsTest.java
new file mode 100644
index 00000000000..3d5abf4c344
--- /dev/null
+++ b/transport-sctp/src/main/test/io/netty/channel/sctp/SctpLimitStreamsTest.java
@@... | train | train | 2016-08-05T07:17:01 | 2015-09-09T15:06:29Z | LukasWysocki | val |
netty/netty/5657_5659 | netty/netty | netty/netty/5657 | netty/netty/5659 | [
"timestamp(timedelta=2.0, similarity=0.9480561467821279)"
] | e44c562932ed4310a6915b58b1d8dcb5e964c6f8 | 5ef9732de29c0ecd560da057bf2bef2d9a72416f | [
"@trustin so you will look into it ?\n",
"Yes\n",
"Ok cool thx\n\n> Am 09.08.2016 um 16:22 schrieb Trustin Lee notifications@github.com:\n> \n> Yes\n> \n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n",
"I believe a vert.x user obs... | [
" Make this array \"private\". [](https://garage.netty.io/sonarqube/coding_rules#rule_key=squid%3AS1873)\n",
"F... | 2016-08-10T02:58:49Z | [
"defect"
] | Disable IPv6 address lookups when -Djava.net.preferIPv4Stack=true | According to [the Oracle documentation](http://docs.oracle.com/javase/8/docs/technotes/guides/net/ipv6_guide/):
> java.net.preferIPv4Stack (default: false)
>
> If IPv6 is available on the operating system, the underlying native socket will be an IPv6 socket. This allows Java applications to connect to, and accept con... | [
"common/src/main/java/io/netty/util/NetUtil.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java"
] | [
"common/src/main/java/io/netty/util/NetUtil.java",
"resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/NetUtil.java b/common/src/main/java/io/netty/util/NetUtil.java
index 5ac18a353a0..b990d0e9889 100644
--- a/common/src/main/java/io/netty/util/NetUtil.java
+++ b/common/src/main/java/io/netty/util/NetUtil.java
@@ -118,16 +118,24 @@ public final class NetUtil {
private... | null | val | train | 2016-08-08T19:19:09 | 2016-08-09T10:29:16Z | trustin | val |
netty/netty/5631_5676 | netty/netty | netty/netty/5631 | netty/netty/5676 | [
"timestamp(timedelta=53920.0, similarity=0.9559465783424206)"
] | cf71e5bae22b9a0d6954c2d18963c4059a23b6eb | 10115e650359376e53ac1c795a34bbc64b51f140 | [
"thanks for reporting @Spikhalskiy ! will look soon\n",
"@Spikhalskiy - do you get any requests of type 100? also do you get any requests that exceed the maximum content length? are you able to reproduce the conditions that cause the leak?\n",
"> do you get any requests of type 100?\n\nYes, we have some % of re... | [
"This rework doesn't make too much sense because this invocation will always fall to code\n\n```\n private void AbstractChannelHandlerContext#invokeChannelInactive() {\n if (invokeHandler()) {\n try {\n ((ChannelInboundHandler) handler()).channelInactive(this);\n } cat... | 2016-08-10T19:33:20Z | [] | HttpObjectAggregator could possibly leak in some conditions | Hi,
I am getting messages about buffer leaks in netty server very rarely, like once in 4-6 hours. And it looks like from advanced logging info that HttpObjectAggregator could not release buffer sometimes. My assumption - it could be related to closing idle connection while HttpObjectAggregator has something cached ins... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java
index bebe52a3995..2a530bbe8fb 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java
+++ b/codec-http/src/mai... | null | test | train | 2016-09-14T02:16:02 | 2016-08-04T15:01:51Z | Spikhalskiy | val |
netty/netty/5701_5725 | netty/netty | netty/netty/5701 | netty/netty/5725 | [
"timestamp(timedelta=959.0, similarity=0.841766743990749)"
] | 0a3e6999c186e0426d5b7c816458a72ad16a0f07 | efe72d44297416038c5530bac02bbfb8c607ae50 | [
"ups... let me fix it.\n",
"thanks for reporting @ferrybig !\n",
"Fixed by https://github.com/netty/netty/pull/5725\n"
] | [] | 2016-08-22T05:44:19Z | [
"cleanup"
] | git conflict markers in public javadoc | The following file contains git conflict markers: https://github.com/netty/netty/blob/4.0/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java#L107
These conflict markers are visible in the public javadoc for the hashcode and hexdump methods:
https://netty.io/4.0/api/io/netty/buffer/ByteBufUtil.html
| [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
index f405d496cf1..1ff9efb5faa 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
@@ -103,8 +103,6 @@ public static Strin... | null | test | train | 2016-08-18T21:04:10 | 2016-08-15T13:27:32Z | ferrybig | val |
netty/netty/5720_5730 | netty/netty | netty/netty/5720 | netty/netty/5730 | [
"timestamp(timedelta=35.0, similarity=0.93808538678266)"
] | 9bc3e56647e4794178a721f2d06128a4ca868b79 | 98ab322e42928a092be68ab3ab2e3a7db7dc3154 | [
"@gustavonalle which version exactly ?\n",
"@normanmaurer we are on 4.1.0.CR7\n",
"Csn you try 4.1.4.Final as well?\n\n> Am 19.08.2016 um 12:25 schrieb Gustavo Fernandes notifications@github.com:\n> \n> @normanmaurer we are on 4.1.0.CR7\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to ... | [] | 2016-08-22T05:51:01Z | [
"defect"
] | Static initializers can cause deadlock | We observed the following deadlock in our test suite:
```
"TestNG-1" #14 prio=5 os_prio=0 tid=0x00007f2a1c70e000 nid=0x6f95 in Object.wait() [0x00007f29fdaf7000]
java.lang.Thread.State: RUNNABLE
at io.netty.util.internal.SystemPropertyUtil.<clinit>(SystemPropertyUtil.java:38)
at io.netty.channel.epo... | [
"common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java"
] | [
"common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java b/common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java
index fb1594bcaec..f8c6a539d45 100644
--- a/common/src/main/java/io/netty/util/internal/ThreadLocalRandom.java
+++ b/common/src/main/java/io/netty/util/internal/ThreadLoca... | null | val | train | 2016-08-18T21:03:39 | 2016-08-19T10:21:39Z | gustavocoding | val |
netty/netty/5718_5732 | netty/netty | netty/netty/5718 | netty/netty/5732 | [
"timestamp(timedelta=7555.0, similarity=0.9075777944986547)"
] | 4accd300e55b9f234ef5f460a7f4243bb19178e5 | 48b3c32f43fca36e7b02e8463e6ef21d9e4b6100 | [
"@adityakishore so you basically say both should return 1. Right ?\n",
"@adityakishore ups -1 I mean :)\n",
"Let me fix this.\n",
"Yes, both should return -1 if we want to retain the memcmp/strcmp behavior.\n\nFor that, both buffer should be compared as BIG_ENDIAN if we still want to retain the performance op... | [
"nit: remove space before `=`\n",
"if you change `uintCount` to something like `aEnd` you could get rid of `i` and a decrement on every iteration.\n\n``` java\nfor (;aIndex < aEnd; aIndex += 4, bIndex +=4) {\n..\n}\n```\n",
"consider removing `va` and `vb` for the following ... trade an aritmatic operation for ... | 2016-08-22T05:53:01Z | [
"defect"
] | Result of ByteBufUtil.compare(ByteBuf a, ByteBuf b) is dependent on ByteOrder of supplied ByteBufs | This should be similar to memcmp() or strcmp() as described in the java-doc.
This is because the [ByteBufUtil.compare(ByteBuf, ByteBuf)](https://github.com/netty/netty/blob/4.1/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java#L226) compare the `ByteBuf`s as integers and not raw bytes.
```
Sample Code
========
... | [
"buffer/src/main/java/io/netty/buffer/ByteBuf.java",
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBuf.java",
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBuf.java b/buffer/src/main/java/io/netty/buffer/ByteBuf.java
index e72fb21f34c..f51caabd627 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBuf.java
@@ -2332,7 +2332,7 @@ public abstract class ByteBuf imp... | diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
index 47bca1f5ebd..f4e6b90c799 100644
--- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
+++ b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
@@ -31,... | test | train | 2016-08-24T15:58:02 | 2016-08-19T07:17:10Z | adityakishore | val |
netty/netty/5736_5737 | netty/netty | netty/netty/5736 | netty/netty/5737 | [
"timestamp(timedelta=2141.0, similarity=0.9192202716298955)"
] | 9bc3e56647e4794178a721f2d06128a4ca868b79 | 972ecf2e3c7094a3ebfd3bba3a208e514680e964 | [
"Yep, looks like a bug to me. The issue lays in `io.netty.handler.codec.http.cookie.DefaultCookie#equals` implementation that compares names with `equalsIgnoreCase`.\n\nWould you like to contribute a fix?\n",
"yes, I'd like\n",
"https://github.com/netty/netty/pull/5737\n",
"Can be closed, as of #5737\n"
] | [
"I know the spec doesn't say anything here, but it feels very weird to me that domain would be case sensitive. After all, it's more or less the host name of the server that originally set the cookie. And host names are definitively case insensitive. I would vote to keep case insensitivity here.\n",
"same as above... | 2016-08-22T16:39:24Z | [
"defect"
] | Why cookie name is case-insensitive | I fall in such situation when HTTP-server (implemented with Netty) receives two cookies: `session_id` and `Session_id`. But after parsing such header only one cookie is returned from method `decode`.
Example:
``` java
Set<Cookie> cookies = ServerCookieDecoder.STRICT.decode("session_id=a; Session_id=b");
for (Cookie ... | [
"codec-http/src/main/java/io/netty/handler/codec/http/cookie/DefaultCookie.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/cookie/DefaultCookie.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/cookie/ServerCookieDecoderTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cookie/DefaultCookie.java b/codec-http/src/main/java/io/netty/handler/codec/http/cookie/DefaultCookie.java
index fb98555bb85..17fe5c43688 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/cookie/DefaultCookie.java
+++ b/codec-http/src/mai... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/cookie/ServerCookieDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/cookie/ServerCookieDecoderTest.java
index d0c07646a55..fe9df5ec300 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/cookie/ServerCookieDecoderTest... | test | train | 2016-08-18T21:03:39 | 2016-08-22T16:02:09Z | jamel | val |
netty/netty/5678_5749 | netty/netty | netty/netty/5678 | netty/netty/5749 | [
"timestamp(timedelta=1555.0, similarity=0.8681263283293253)"
] | 4accd300e55b9f234ef5f460a7f4243bb19178e5 | 25e3c91c618da6574c66af1b1277235e6068c564 | [
"thanks for reporting @rkapsi ! let me come up with a PR.\n",
"Thanks @Scottmitch and @rkapsi \n"
] | [
"Maybe even fire a custom `SniHandlerException(hostname, context, cause)` to give the user every possible opportunity not to lose track of the SslContext.\n",
" Remove this unused method parameter \"hostname\".... | 2016-08-25T12:51:32Z | [
"defect"
] | SniHandler#replaceHandler() may leak (reference counted) SslContexts | The SniHandler#select()/AsyncMapper#map() methods execute asynchronously and by the time the returned Future completes the client is possibly no longer connected.
The #selection field will be set but probably after #channelInactive() (i.e. can't really do anything with it) and the #replace() call on the ChannelPipelin... | [
"handler/src/main/java/io/netty/handler/ssl/SniHandler.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/SniHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/SniHandler.java b/handler/src/main/java/io/netty/handler/ssl/SniHandler.java
index 7fc70d1258a..6b404d3763c 100644
--- a/handler/src/main/java/io/netty/handler/ssl/SniHandler.java
+++ b/handler/src/main/java/io/netty/handler/ssl/SniHandler.java
@@ -303,8 +303,24 @... | null | train | train | 2016-08-24T15:58:02 | 2016-08-10T22:40:39Z | rkapsi | val |
netty/netty/5763_5782 | netty/netty | netty/netty/5763 | netty/netty/5782 | [
"timestamp(timedelta=21.0, similarity=0.902178681582907)"
] | 3051df8961273fb39fe282a46c7f76124b39112f | 89ee71e131f0ffdd999d544d95f58591e8b8ad05 | [
"@rkapsi oversight... let me fix it.\n",
"Fixed by https://github.com/netty/netty/pull/5782\n"
] | [] | 2016-08-31T20:02:59Z | [] | DefaultEventLoopGroup doesn't expose ctor variant that accepts custom Executor | The `DefaultEventLoopGroup` class extends `MultithreadEventExecutorGroup` but doesn't expose the ctor variants that accept a custom Executor like `NioEventLoopGroup` and `EpollEventLoopGroup` do.
Is that on purpose or just an oversight?
| [
"transport/src/main/java/io/netty/channel/DefaultEventLoopGroup.java"
] | [
"transport/src/main/java/io/netty/channel/DefaultEventLoopGroup.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/DefaultEventLoopGroup.java b/transport/src/main/java/io/netty/channel/DefaultEventLoopGroup.java
index 6e8ba13452f..ee5eeea6418 100644
--- a/transport/src/main/java/io/netty/channel/DefaultEventLoopGroup.java
+++ b/transport/src/main/java/io/netty/channel/DefaultEve... | null | test | train | 2016-08-31T14:01:05 | 2016-08-29T22:16:55Z | rkapsi | val |
netty/netty/5773_5783 | netty/netty | netty/netty/5773 | netty/netty/5783 | [
"timestamp(timedelta=14.0, similarity=0.8610196742337676)"
] | 3051df8961273fb39fe282a46c7f76124b39112f | a17eebbcdc597795803b640d50f3e5489e267b7c | [
"Will have a look\n\n> Am 30.08.2016 um 18:22 schrieb Nick Pordash notifications@github.com:\n> \n> After updating from 4.1.4.Final to 4.1.5.Final I have failing tests because of the following:\n> \n> java.lang.IndexOutOfBoundsException: index: 21, length: 1 (expected: range(0, 21))\n> at io.netty.buffer.Abstra... | [] | 2016-08-31T20:03:58Z | [
"defect"
] | IndexOutOfBoundsException from CompositeByteBuf.forEachByteDesc | After updating from 4.1.4.Final to 4.1.5.Final I have failing tests because of the following:
``` java
java.lang.IndexOutOfBoundsException: index: 21, length: 1 (expected: range(0, 21))
at io.netty.buffer.AbstractByteBuf.checkIndex0(AbstractByteBuf.java:1359)
at io.netty.buffer.AbstractByteBuf.checkIndex(Abstr... | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java"
] | [
"buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java",
"buffer/src/test/java/io/netty/buffer/SlicedByteBufTest.java",
"buffer/src/test/java/io/netty/buffer/WrappedUnpooledUnsafeByteBufTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
index 3b9d2b1137f..5c8c837b024 100644
--- a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java
@@ -1274,7 +1274,7 @@ p... | diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
index f4e6b90c799..53ec4b11560 100644
--- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
+++ b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
@@ -320... | test | train | 2016-08-31T14:01:05 | 2016-08-30T16:22:13Z | npordash | val |
netty/netty/5712_5791 | netty/netty | netty/netty/5712 | netty/netty/5791 | [
"timestamp(timedelta=12.0, similarity=0.8946751578239116)"
] | 30fe2e868fcc99d24046e505f9406067ba6e9d07 | 5ef068cd8d627b808a691b46f919075d38a14645 | [
"/cc @fredericBregier \n",
"Let me take care\n",
"@normanmaurer Sorry to be late again (very busy those last 9 months). I look at your commit, fine for me.\n",
"Fixed by https://github.com/netty/netty/pull/5791\n",
"Thanks guys! I could've sent you a poll request but wasn't sure if this is the right design.... | [] | 2016-09-02T16:55:22Z | [
"improvement"
] | Allow clients to override userDefinedWritabilityIndex from AbstractTrafficShapingHandler | Hello,
AbstractTrafficShapingHandler has a package-private method called "userDefinedWritabilityIndex()". If I create two sub-classes of ChannelTrafficShapingHandler (one for throttling on bandwidth and the other for throttling on message size), I cannot make them independent from each other in terms of writability, ... | [
"handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java",
"handler/src/main/java/io/netty/handler/traffic/GlobalChannelTrafficShapingHandler.java"
] | [
"handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java",
"handler/src/main/java/io/netty/handler/traffic/GlobalChannelTrafficShapingHandler.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java b/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java
index 9cff40f0cef..fb4cdce3e22 100644
--- a/handler/src/main/java/io/netty/handler/traffic/AbstractTrafficShapingHandler.java
+++ b/handler/s... | null | train | train | 2016-09-01T08:55:02 | 2016-08-16T22:09:22Z | jqmichael | val |
netty/netty/5762_5798 | netty/netty | netty/netty/5762 | netty/netty/5798 | [
"timestamp(timedelta=15.0, similarity=0.9568037118728966)"
] | 67d3a78123fa3faa85c1a150bd4ee69425079b3d | 512a6e6cc3eea548514d81662a84c2404ff2f007 | [
"@buchgr will look into it.\n",
"Should be fixed by https://github.com/netty/netty/pull/5798\n",
"Fixed by https://github.com/netty/netty/pull/5798\n"
] | [
"This will first cast `capacity` to int, then do the division. I think you need to wrap the division with parantheses?\n",
"doh! right... \n",
"This cast doesn't seem safe, for `maxHeaderTableSize` gt `MAX_INT`?\n",
"@buchgr why ? Shouldn't it just be converted to a signed int ?\n",
"@normanmaurer what if ... | 2016-09-07T04:53:12Z | [
"defect"
] | HTTP/2: SETTINGS_HEADER_TABLE_SIZE should be an unsigned int | The HTTP/2 spec demands that the max value for `SETTINGS_HEADER_TABLE_SIZE` should be an unsigned 32-bit integer. However, it seems that some [limitations in HPACK](https://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java#L90) prevent us from supporting that.
h... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec/ht... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersEncoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java",
"codec-http2/src/main/java/io/netty/handler/codec/ht... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2SettingsTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java
index 037cd9c9038..a20ecda44ca 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java
... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2SettingsTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2SettingsTest.java
index cb33ca136e0..514d53e8770 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2SettingsTest.java
+++ b/codec-http2/src/test/... | train | train | 2016-09-09T07:57:41 | 2016-08-29T16:10:30Z | buchgr | val |
netty/netty/5800_5825 | netty/netty | netty/netty/5800 | netty/netty/5825 | [
"timestamp(timedelta=24.0, similarity=0.8764989131870482)"
] | 0b5e75a614ca29810c7ef1b695c0ca962ec7b004 | 5273802db25aed721a06c2bc6273575df022b749 | [
"@akurilov let me fix this.\n",
"also FYI Netty 5.x has been discontinued.\n",
"Fixed by https://github.com/netty/netty/pull/5825\n"
] | [
"src.limit() -> limit\n",
"Can you add a comment why you explicitly use `Unpooled` here instead of just using `alloc`?\n",
"on line 402 ... can you change `region.transfered()` -> `region.transferred()` while you are here?\n",
"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/imag... | 2016-09-15T16:20:52Z | [
"defect"
] | Epoll transport doesn't work with custom FileRegion implementation | - Netty version: 4.1.5.Final, 5.0.0.Alpha2
- Tried to use custom FileRegion implementation with epoll transport
- Expected: any FileRegion DMA implementation works with epoll transport as with NIO transport
- Observerd: epoll transport expects only the particular DefaultFileRegion implementation:
```
java.lang.Unsuppo... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java"
] | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java"
] | [
"testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java"
] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java
index f18e4c74303..78507d70e28 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStre... | diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java
index 4a44c62171c..6b7ad3ca0e5 100644
--- a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketFileRegionTest.java
+++... | train | train | 2016-09-15T19:27:29 | 2016-09-07T09:02:51Z | akurilov | val |
netty/netty/5821_5844 | netty/netty | netty/netty/5821 | netty/netty/5844 | [
"timestamp(timedelta=70.0, similarity=0.9335052059039113)"
] | 9b6cbf8ab1b3cd651e9ad6ef19af21605f270dac | 516dab90085198035ae3e1ffd63d12b03d2a2208 | [
"@henrik-lindqvist maybe you can provide a PR ?\n",
"or provide a link to an RFC or specification which describes expected behavior and an input which doesn't produce the expected output.\n",
"NetUtil.bytesToIpAddress(new byte[] { 83, -1, -20, 16 }, 0, 4) returns \"0.255.255.16\" not \"83.255.236.16\" as expect... | [
"shouldnt this be 16 ?\n",
"I think 15 should be correct. `\"000.000.000.000\".length() == 15`\n",
"doh... right\n"
] | 2016-09-21T20:36:23Z | [
"defect"
] | NetUtil.bytesToIpAddress broken for IPv4 | For textual IPv4 representation the method incorrectly performs bit shifts on the array bytes.
4.1.5.Final
| [
"codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/Socks5AddressDecoder.java",
"common/src/main/java/io/netty/util/NetUtil.java"
] | [
"codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/Socks5AddressDecoder.java",
"common/src/main/java/io/netty/util/NetUtil.java"
] | [
"codec-socks/src/test/java/io/netty/handler/codec/socksx/v5/Socks5CommandRequestDecoderTest.java",
"codec-socks/src/test/java/io/netty/handler/codec/socksx/v5/Socks5CommandResponseDecoderTest.java",
"common/src/test/java/io/netty/util/NetUtilTest.java"
] | diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/Socks5AddressDecoder.java b/codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/Socks5AddressDecoder.java
index 83b15c42f1c..bc37469edb7 100644
--- a/codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/Socks5AddressDecoder.java
+++ b/... | diff --git a/codec-socks/src/test/java/io/netty/handler/codec/socksx/v5/Socks5CommandRequestDecoderTest.java b/codec-socks/src/test/java/io/netty/handler/codec/socksx/v5/Socks5CommandRequestDecoderTest.java
index 8b0478a4b15..728ee1eb7a1 100755
--- a/codec-socks/src/test/java/io/netty/handler/codec/socksx/v5/Socks5Comm... | train | train | 2016-09-22T08:15:27 | 2016-09-14T01:31:07Z | henrik-lindqvist | val |
netty/netty/5831_5846 | netty/netty | netty/netty/5831 | netty/netty/5846 | [
"timestamp(timedelta=30.0, similarity=0.8635042964389493)"
] | 4639d56596f5dd023bcb515d3d9e3f16cbc3217e | 3a5c8029863b004a9b62af3542d4b445175d71f9 | [
"@bryce-anderson interested to provide a PR + unit test ?\n",
"@normanmaurer Do you mean PR to fix or PR to demonstrate? I'm happy to provide a PR either way, I just want to be clear on what PR we want. 😄\n\nIf we are talking about a fix, the easy solution is to adopt the netty3 behavior of resetting the encoder... | [
"move inner `if` to this level to make an `} else if { ... } else { ... }`\n",
"done\n",
"Could we define an overridable protected method in `HttpObjectEncoder` rather than duplicating HEAD check in `encode*Content()` methods? That way, `HttpObjectEncoder` could keep `encode*Content()` private. i.e.\n\n``` java... | 2016-09-21T22:05:12Z | [
"defect"
] | HttpServerCodec annot encode a respons e to HEAD request with a 'content-encoding: chunked' header | Netty versions: 4.x
### Context
It is valid to send a response to a HEAD request that contains a `transfer-encoding: chunked` header, but there is no way to do this using the netty4 `HttpServerCodec`.
### Root of the problem
The root cause is that the netty4 `HttpObjectEncoder` will [transition to the state](https://... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerCodec.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerCodec.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpServerCodecTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java
index dba6f01de2e..10794983fdc 100755
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java
+++ b/codec-http/src/main/java/io... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerCodecTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerCodecTest.java
index 345e9e821fc..30878198947 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerCodecTest.java
+++ b/codec-http/src/test/j... | test | train | 2016-12-08T19:51:42 | 2016-09-16T16:31:49Z | bryce-anderson | val |
netty/netty/5862_5876 | netty/netty | netty/netty/5862 | netty/netty/5876 | [
"timestamp(timedelta=15.0, similarity=0.9115880020539914)"
] | 149916d052180dd2b0e0e98598f349454ea200ba | 8a2b91153bb11413e6383a251a5cc0e4b67ce425 | [
"Let me fix it\n",
"Fixes by https://github.com/netty/netty/pull/5876\n"
] | [] | 2016-09-29T06:21:12Z | [
"defect"
] | Http2EventAdapter's onUnknownFrame() is missing throws Http2Exception | `Http2EventAdapter` implements the `Http2FrameListener` interface but implements the `#onUnknownFrame(...)` method without the interface's `throws Http2Exception`.
... causing compiler errors down the road if you're trying to implement a delegate or something like that.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2EventAdapter.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2EventAdapter.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2EventAdapter.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2EventAdapter.java
index 3f5665a40eb..b51e083f150 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2EventAdapter.java
+++ b/codec-http2/src/main/... | null | train | train | 2016-09-24T21:33:04 | 2016-09-25T19:09:09Z | rkapsi | val |
netty/netty/5861_5877 | netty/netty | netty/netty/5861 | netty/netty/5877 | [
"timestamp(timedelta=18.0, similarity=0.9318689056094328)"
] | 149916d052180dd2b0e0e98598f349454ea200ba | d1381b687fab6f5d3020be4b12392b174a2eacbb | [
"@ewie sounds like a bug... let me fix it.\n",
"@ewie should be fixed by https://github.com/netty/netty/pull/5877\n",
"Fixed by https://github.com/netty/netty/pull/5877\n"
] | [] | 2016-09-29T06:22:14Z | [
"defect"
] | HttpUtil.getContentLength(HttpMessage, long) throws unexpected NumberFormatException | The Javadocs of `HttpUtil.getContentLength(HttpMessage, long)` and its `int` overload state that the provided default value is returned if the Content-Length value is not a number. `NumberFormatException` is thrown instead [1] causing the method to behave like `HttpUtil.getContentLength(HttpMessage)` where the exceptio... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java
index 0d9433c698b..4d165088e67 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpUtil.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/http/H... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java
index 1e9615ce8f5..93478d645d0 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpUtilTest.java
+++ b/codec-http/src/test/java/io/netty/handler/... | val | train | 2016-09-24T21:33:04 | 2016-09-25T15:20:00Z | ewie | val |
netty/netty/5933_5939 | netty/netty | netty/netty/5933 | netty/netty/5939 | [
"timestamp(timedelta=62.0, similarity=0.8592571639964799)"
] | 9cfa4675548e368f3c905c0df31d18912d43cf08 | cb7a5c9fd552997ecb3ffd9be859c18f79601d1c | [
"Adding some new details. Turns out we only need to issue one read to trigger the handshake (no matter how many messages it takes to complete for HTTP and SOCKS5) given that [`ProxyHandler.readComplete()`](https://github.com/netty/netty/blob/4.1/handler-proxy/src/main/java/io/netty/handler/proxy/ProxyHandler.java#L... | [
"ThreadLocalRandom.current().nextBoolean()\n",
"Thanks @normanmaurer! Just updated the branch.\n"
] | 2016-10-24T18:01:45Z | [
"defect"
] | ProxyHandler stalls the proxy handshake when auto-read=false | We're (Finagle) using the N4 tooling around proxies and just discovered a bug in [`ProxyHandler`](https://github.com/netty/netty/blob/4.1/handler-proxy/src/main/java/io/netty/handler/proxy/ProxyHandler.java). When auto-read is disabled (our default) a connection established with the proxy server goes into a stall state... | [
"handler-proxy/src/main/java/io/netty/handler/proxy/ProxyHandler.java"
] | [
"handler-proxy/src/main/java/io/netty/handler/proxy/ProxyHandler.java"
] | [
"handler-proxy/src/test/java/io/netty/handler/proxy/ProxyHandlerTest.java"
] | diff --git a/handler-proxy/src/main/java/io/netty/handler/proxy/ProxyHandler.java b/handler-proxy/src/main/java/io/netty/handler/proxy/ProxyHandler.java
index 8d5b80b0aad..756de090a0a 100644
--- a/handler-proxy/src/main/java/io/netty/handler/proxy/ProxyHandler.java
+++ b/handler-proxy/src/main/java/io/netty/handler/pro... | diff --git a/handler-proxy/src/test/java/io/netty/handler/proxy/ProxyHandlerTest.java b/handler-proxy/src/test/java/io/netty/handler/proxy/ProxyHandlerTest.java
index 1c5cb5ec06a..697b57bfe41 100644
--- a/handler-proxy/src/test/java/io/netty/handler/proxy/ProxyHandlerTest.java
+++ b/handler-proxy/src/test/java/io/netty... | train | train | 2016-10-24T18:23:56 | 2016-10-21T20:40:06Z | vkostyukov | val |
netty/netty/5954_5956 | netty/netty | netty/netty/5954 | netty/netty/5956 | [
"timestamp(timedelta=4.0, similarity=0.87246764186294)"
] | b2379e62f4ae50b55bce7c43e5bd008cf9aacfd1 | d1d6ddeb9e51a00ff3ae146040500244991cef70 | [
"Fixed by https://github.com/netty/netty/pull/5956\n"
] | [
"@mosesn please add missing `@Override`\n",
"private final static\n",
"private final static\n",
"private final static\n",
"@mosesn please add missing `@Override`\n",
"assert return value\n",
"assert return value\n",
"assert return value\n",
"assert return value\n",
"ensure you call `channel.finish... | 2016-10-31T03:55:18Z | [
"improvement"
] | HttpClientUpgradeHandler waits for the fully buffered stream | The HttpClientUpgradeHandler should only need the headers to decide whether to upgrade or not, but it waits for the entire response. This means that servers that respond with infinite streams will never know that their clients are only buffering the response.
We should instead change it to only buffer once it has d... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java
index ca4651023e5..235dbb1b5d8 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java
+++ b/codec-... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java
new file mode 100644
index 00000000000..905556acc7a
--- /dev/null
+++ b/codec-http/src/test/java/io/netty/handler/codec/http/HttpCl... | test | train | 2016-10-30T08:32:49 | 2016-10-31T02:25:00Z | mosesn | val |
netty/netty/5945_5966 | netty/netty | netty/netty/5945 | netty/netty/5966 | [
"timestamp(timedelta=98856.0, similarity=0.9859878293651412)"
] | b2379e62f4ae50b55bce7c43e5bd008cf9aacfd1 | 112c011df7c4bd36d6387e4a217095d06d5ac21b | [
"Maybe want to provide a PR with a fix?\n\n> Am 26.10.2016 um 21:25 schrieb ichaki5748 notifications@github.com:\n> \n> netty 4.1.6\n> \n> io.netty.handler.ssl.ReferenceCountedOpenSslEngine.OpenSslSession#initPeerCerts\n> \n> final byte[] clientCert;\n> ...\n> int len = clientCert.length + 1; // <------ BUG: raw ce... | [] | 2016-10-31T21:45:48Z | [
"defect"
] | OpenSslSession#initPeerCerts creates too long almost empty arrays | netty 4.1.6
io.netty.handler.ssl.ReferenceCountedOpenSslEngine.OpenSslSession#initPeerCerts
```
final byte[] clientCert;
...
int len = clientCert.length + 1; // <------ BUG: raw certificate byte array size is used
peerCerts = new Certificate[len];
x509PeerCerts = new X509Certificate[len];
```
But should probably b... | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslJavaxX509Certificate.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslX509Certificate.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/OpenSslJavaxX509Certificate.java",
"handler/src/main/java/io/netty/handler/ssl/OpenSslX509Certificate.java"
] | [] | diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslJavaxX509Certificate.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslJavaxX509Certificate.java
index da10dedf0c1..ad4447f34b7 100644
--- a/handler/src/main/java/io/netty/handler/ssl/OpenSslJavaxX509Certificate.java
+++ b/handler/src/main/java/io/ne... | null | train | train | 2016-10-30T08:32:49 | 2016-10-26T13:25:01Z | ichaki5748 | val |
netty/netty/5945_5967 | netty/netty | netty/netty/5945 | netty/netty/5967 | [
"timestamp(timedelta=12.0, similarity=0.9859878293651412)"
] | 42fba015ce82ab4ab30e547c888db82fe74094e9 | 9d6548b72d9f2a416ba694ff894524c43526a9f8 | [
"Maybe want to provide a PR with a fix?\n\n> Am 26.10.2016 um 21:25 schrieb ichaki5748 notifications@github.com:\n> \n> netty 4.1.6\n> \n> io.netty.handler.ssl.ReferenceCountedOpenSslEngine.OpenSslSession#initPeerCerts\n> \n> final byte[] clientCert;\n> ...\n> int len = clientCert.length + 1; // <------ BUG: raw ce... | [
"@ichaki5748 can you make this method static\n",
"please make static\n",
"sure\n",
" Consider using varargs for methods or constructors which take an array the last parameter. [![rule](https://raw.githubuse... | 2016-10-31T22:26:12Z | [
"defect"
] | OpenSslSession#initPeerCerts creates too long almost empty arrays | netty 4.1.6
io.netty.handler.ssl.ReferenceCountedOpenSslEngine.OpenSslSession#initPeerCerts
```
final byte[] clientCert;
...
int len = clientCert.length + 1; // <------ BUG: raw certificate byte array size is used
peerCerts = new Certificate[len];
x509PeerCerts = new X509Certificate[len];
```
But should probably b... | [
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java b/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java
index 382f8606fc6..fce7410bb4d 100644
--- a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java
+++ b/handler/src/main/java... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java b/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java
index 32f9c9345ae..b565b3da09d 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java
@@ -53,... | val | train | 2016-11-02T08:14:48 | 2016-10-26T13:25:01Z | ichaki5748 | val |
netty/netty/5982_5983 | netty/netty | netty/netty/5982 | netty/netty/5983 | [
"timestamp(timedelta=20.0, similarity=0.9229476379369648)"
] | 5eebe9a06c6873e797b5f8c847086c35ae990ef5 | f15732d2ab965aa1955ffeaf0c60cd6da2be5130 | [
"Fixed by https://github.com/netty/netty/pull/5983\n"
] | [
"just make this one listener which always close after logging the error ? No need to have to listeners and at worst have both call close. After this I will merge.\n\n@bryce-anderson thanks!\n",
"Done. Let me know if I misunderstood your comment. 😄 \n",
"@bryce-anderson remove empty line and we are good :)\n",
... | 2016-11-04T21:33:59Z | [
"defect"
] | HttpObjectAggregator closes the http/1.x connection without a 'Connection: close' header | Netty version: 4.1.6.Final
The [HttpObjectAggregator](https://github.com/netty/netty/blob/eb7f751ba519cbcab47d640cd18757f09d077b55/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java) will take it upon itself to return a 413 response when the message has too large of body [here](https://gi... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpObjectAggregatorTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java
index 908ac8d12b4..4e8455236cf 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectAggregator.java
+++ b/codec-http/src/mai... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpObjectAggregatorTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpObjectAggregatorTest.java
index ca4a5f3afa9..69464acf6aa 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpObjectAggregatorTest.java
+++ b/codec-... | train | train | 2016-11-04T15:47:02 | 2016-11-04T18:56:33Z | bryce-anderson | val |
netty/netty/5987_5988 | netty/netty | netty/netty/5987 | netty/netty/5988 | [
"timestamp(timedelta=34.0, similarity=0.909561793045737)"
] | 5eebe9a06c6873e797b5f8c847086c35ae990ef5 | 34357e91b2813454fa376e8dffaa26b6cede0052 | [
"One of the fields in PlatformDependent references PlatformDependent0 directly without being guarded by hasUnsafe.\n",
"Is the issue you don't want to see the warning message, or is this causing a functional issue?\n\n@johnou - which field do you think is an issue?\n",
"@johnou - your commit https://github.com/... | [] | 2016-11-07T21:59:54Z | [
"defect"
] | Unable to initialize PlatformDependent0 due to lack of sun.misc.Unsafe in classpath | When trying to use [Vertx](http://vertx.io) in OSGi, I bumped into the following error. Initially I got:
```[FelixStartLevel] DEBUG io.netty.util.internal.logging.InternalLoggerFactory - Using SLF4J as the default logging framework
[FelixStartLevel] DEBUG io.netty.util.ResourceLeakDetector - -Dio.netty.leakDetection... | [
"common/src/main/java/io/netty/util/internal/PlatformDependent.java"
] | [
"common/src/main/java/io/netty/util/internal/PlatformDependent.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/PlatformDependent.java b/common/src/main/java/io/netty/util/internal/PlatformDependent.java
index 81348a06b67..320a63819e3 100644
--- a/common/src/main/java/io/netty/util/internal/PlatformDependent.java
+++ b/common/src/main/java/io/netty/util/internal/PlatformDe... | null | train | train | 2016-11-04T15:47:02 | 2016-11-07T21:25:49Z | jellenelis | val |
netty/netty/5947_5991 | netty/netty | netty/netty/5947 | netty/netty/5991 | [
"timestamp(timedelta=40.0, similarity=0.8763541037290001)"
] | 895a92cb2208906e0cabba21063e604c10c4d5ae | e43a9d32e4b8b70648b46a94a1c409defbcdb61f | [
"@nhnFreespirit so just to ensure I understand you right you suggest that we should for example allow to pass it in into the constructor ?\n",
"Yeah, having it in a constructor of Http2Codec would solve my issues nicely.\n\nWhen constructing an http/2 client, it is possible to specify non default initial setting... | [] | 2016-11-08T18:35:08Z | [
"improvement"
] | Make it possible to specify initial settings for Http2Codec | Currently, when instantiating an Http2Codec, there does not appear to be any way of specifying non default initial settings.
| [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Codec.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Codec.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Codec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Codec.java
index a61428d96d8..6a6ee39cc36 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Codec.java
+++ b/codec-http2/src/main/java/io/netty/handler... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java
index 260227690ca..d798d22eff4 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2FrameCodecTest.java
+++ b/codec-http2/src... | train | train | 2016-11-08T17:08:17 | 2016-10-27T00:49:34Z | nhnFreespirit | val |
netty/netty/5975_5995 | netty/netty | netty/netty/5975 | netty/netty/5995 | [
"timestamp(timedelta=31.0, similarity=0.8573709676194836)"
] | 3f20b8adee1d86285acc508308c07d67b36c1fc6 | f5ea111ae850b4430873b8e09f4b33975a18c176 | [
"Related? https://github.com/netty/netty/pull/4254\n",
"Yes, seems so. Thanks for the pointer.\n",
"@jrudolph would be possible to submit a small unit test that works with JDK SSLEngine and fails with the OpenSslEngine ?\n",
"@normanmaurer yes, will try to build one, shouldn't be too hard.\n",
"Thanks a lot... | [
"@normanmaurer Have you verified that doing this each time will not impact performance? SslHandler would cache the packetLength so that it wouldn't recalculate it each time. I suspect it's not an issue.\n",
"Is it correct to use a constant here or should we get this value from the session? Or does the session alw... | 2016-11-09T18:28:20Z | [
"defect"
] | Openssl-based SSLEngine differs slightly in unwrap behavior | We are experimenting with netty's openssl based SSLEngines as an alternative to the JDK one ([for our effort](https://github.com/akka/akka-http/tree/jr/http2-on-netty-openssl) to produce an HTTP/2 implementation for akka-http). We use
netty-tcnative-boringssl-static, version 1.1.33.Fork23. Thanks for providing that! ... | [
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java",
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java",
"handler/src/main/java/io/netty/handler/ssl/SslUtils.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java",
"handler/src/main/java/io/netty/handler/ssl/SslHandler.java",
"handler/src/main/java/io/netty/handler/ssl/SslUtils.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java b/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java
index fce7410bb4d..76cc0dda9b8 100644
--- a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java
+++ b/handler/src/main/java... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java b/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java
index b565b3da09d..8f1cbee3f00 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java
@@ -678... | test | train | 2016-11-09T10:58:35 | 2016-11-03T09:39:43Z | jrudolph | val |
netty/netty/6037_6059 | netty/netty | netty/netty/6037 | netty/netty/6059 | [
"timestamp(timedelta=13.0, similarity=0.8963185923985323)"
] | ba95c401a7cf8c7923fce660e16c8ba567d62f30 | 9b6f0c7a94b9a2beec2074d0fee2bdcfb502411b | [
"Sounds ok to me... @Scottmitch ?\n",
"sgtm",
"@derbylock could you provide a PR ?",
"Fixed by https://github.com/netty/netty/pull/6059"
] | [] | 2016-11-23T11:16:41Z | [] | Make FixedChannelPool non final | We use **FixedChannelPool** in our project. But we have some problems adopting it to our needs. For example, we want to override methods **_pollChannel_** and **_offerChannel_** for monitoring purposes. We want to monitor count of channel objects in the pool. But it is difficult because **FixedChannelPool** is final. ... | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java"
] | [
"transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java"
] | [] | diff --git a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java b/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
index cefedee89fb..8c69dc7b0da 100644
--- a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java
+++ b/transport/src/main/java/io/netty/channel/pool/Fixed... | null | train | train | 2016-11-23T00:17:05 | 2016-11-18T14:57:22Z | derbylock | val |
netty/netty/6061_6078 | netty/netty | netty/netty/6061 | netty/netty/6078 | [
"timestamp(timedelta=20.0, similarity=0.8506734955420215)"
] | ea0ddc0ea2cd11071bb960c7ff1aeade7bc1c1cb | 08f4d7c07db31970ca18a27b8f926b24681e496b | [
"Will check later today\n\n> Am 25.11.2016 um 04:45 schrieb byeongguk.gim <notifications@github.com>:\n> \n> Netty version: 4.1.0.Final\n> \n> Context: I found bug on EpollServerDomainSocketChannel class. Its isActive() method always return false. It is required to set isActive = true in doBind() operation. (same a... | [] | 2016-12-01T06:46:25Z | [
"defect"
] | EpollServerDomainSocketChannel.isActive() return false after bind operation succeed | Netty version: 4.1.0.Final
Context: I found bug on EpollServerDomainSocketChannel class. Its isActive() method always return false. It is required to set isActive = true in doBind() operation like EpollServerSocketChannel.
Steps to reproduce:
1. Use EpollServerDomainSocketChannel class to server bootstrap's chan... | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerDomainSocketChannel.java"
] | [
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerDomainSocketChannel.java"
] | [] | diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerDomainSocketChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServerDomainSocketChannel.java
index 958d85a4240..c533d24ea1c 100644
--- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollServ... | null | train | train | 2016-12-01T06:54:51 | 2016-11-25T03:45:25Z | thywhite | val |
netty/netty/6074_6097 | netty/netty | netty/netty/6074 | netty/netty/6097 | [
"timestamp(timedelta=20.0, similarity=0.8803081878243956)"
] | 002c99e751ec24e80236a310bd46e0098bdb636d | 4b0f1020c2d6e8b55aac468113c9a48e1e499781 | [
"@maseev - I had not heard about this ... but this sounds great thanks!"
] | [
"typo ihttp -> http",
"Why not copy direct from http://netty.io/wiki/writing-a-commit-message.html? (I think the sentences under each header help a lot when thinking of what to write).",
"I'm currently experimenting with the format. Markdown looks nice in UIs that support it and helps visually separate differen... | 2016-12-02T22:47:19Z | [
"documentation"
] | Consider using an issue template | I've noticed that despite the fact there are the [guidelines for contributing](https://github.com/netty/netty/blob/4.1/CONTRIBUTING.md), people still keep creating issues that contain so little information that is sometimes absolutely impossible to do anything without asking additional questions like:
- What Netty's... | [] | [
".github/CONTRIBUTING.md",
".github/ISSUE_TEMPLATE.md",
".github/PULL_REQUEST_TEMPLATE.md"
] | [] | diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
new file mode 100644
index 00000000000..81c2ceabb93
--- /dev/null
+++ b/.github/CONTRIBUTING.md
@@ -0,0 +1,1 @@
+Please review the [guidelines for contributing](http://netty.io/wiki/developer-guide.html) for this repository.
diff --git a/.github/ISSUE_TEMPL... | null | train | train | 2016-12-06T05:51:05 | 2016-11-30T22:16:01Z | maseev | val |
netty/netty/6132_6147 | netty/netty | netty/netty/6132 | netty/netty/6147 | [
"timestamp(timedelta=126.0, similarity=0.8475656572580857)"
] | 3f82b53bae4120eaf452269f204595b78353ec2b | 82f548e9a9a8d61a4c9844b518619b333aa6a80c | [
"@jo-kin - Thanks for reporting. Stand by for a PR.",
"Thanx a lot.\r\nDeeply impressed by speed and thoroughness. Will report how it works for me soon.\r\nWishing you a very Happy Christmas and New Year 2017. "
] | [
"@Scottmitch just remove the `@return` as it is the same as what is stated already ? ",
"@Scottmitch `:-]` looks nice and friendly ;)",
"sure"
] | 2016-12-20T00:43:40Z | [
"defect"
] | Wrong regular expression to check MACAdresses in DefaultChannelId | Using Netty on a Java-VM running on IBM z/OS it occurs, that creating a unique channel-id leads to problems.
It seems to me, that this process bases at least on the MAC-Address of networking hardware. On IBM z/OS this information is not available with the usual JAVA-methods in NetworkInterface. Netty logs always a w... | [
"common/src/main/java/io/netty/util/internal/MacAddressUtil.java",
"transport/src/main/java/io/netty/channel/DefaultChannelId.java"
] | [
"common/src/main/java/io/netty/util/internal/MacAddressUtil.java",
"transport/src/main/java/io/netty/channel/DefaultChannelId.java"
] | [
"common/src/test/java/io/netty/util/internal/MacAddressUtilTest.java"
] | diff --git a/common/src/main/java/io/netty/util/internal/MacAddressUtil.java b/common/src/main/java/io/netty/util/internal/MacAddressUtil.java
index 858368d6dd9..49559b175e2 100644
--- a/common/src/main/java/io/netty/util/internal/MacAddressUtil.java
+++ b/common/src/main/java/io/netty/util/internal/MacAddressUtil.java... | diff --git a/common/src/test/java/io/netty/util/internal/MacAddressUtilTest.java b/common/src/test/java/io/netty/util/internal/MacAddressUtilTest.java
new file mode 100644
index 00000000000..84d4e1229c7
--- /dev/null
+++ b/common/src/test/java/io/netty/util/internal/MacAddressUtilTest.java
@@ -0,0 +1,99 @@
+/*
+ * Copy... | train | train | 2016-12-20T21:59:00 | 2016-12-14T13:40:40Z | jo-kin | val |
netty/netty/6150_6160 | netty/netty | netty/netty/6150 | netty/netty/6160 | [
"timestamp(timedelta=59.0, similarity=0.9681198608469817)"
] | 56ddc47f23611f6e1c8009caf0b67f535a41802c | 3b9887c549d0ecf40176e2ea412946b8957630f1 | [
"Whether this is a bug or missing feature is open to interpretation ... however if we do want to provide this functionality I don't think we should change the existing default behavior for `IdleStateHandler` for backwards compatibility reasons.\r\n\r\n`ChannelOutboundBuffer` may be able to provide the tools we need... | [
"maybe not when this method is currently called but it is possible the `ChannelOutboundBuffer` may be `null` (e.g. channel is closed) .. consider protecting against this or adding a comment as to why it isn't necessary.",
"protect against `buf == null`.",
"nit: put on previous line?",
"consider just setting t... | 2016-12-28T16:37:25Z | [] | Detecting actual Channels idleness vs. slowness | I don't know if you'd consider it a missing feature or a bug but there appears to be no effective way of measuring write idleness. The natural choice is to use Netty's own `IdleStateHandler` but it may not work as expected for `write()`. For the sake of simplicity I'm providing a HTTP example but we encountered it with... | [
"handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java"
] | [
"handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java"
] | [
"handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java b/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
index 3d2acd11650..6d6229c0e64 100644
--- a/handler/src/main/java/io/netty/handler/timeout/IdleStateHandler.java
+++ b/handler/src/main/java/io/netty/handler/timeout/I... | diff --git a/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java b/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java
new file mode 100644
index 00000000000..f7e1c42153e
--- /dev/null
+++ b/handler/src/test/java/io/netty/handler/timeout/IdleStateHandlerTest.java
@@ -0,0 +1,395... | test | train | 2016-12-30T21:00:21 | 2016-12-20T23:27:27Z | rkapsi | val |
netty/netty/6167_6189 | netty/netty | netty/netty/6167 | netty/netty/6189 | [
"timestamp(timedelta=24.0, similarity=0.894930691689767)"
] | eb5dc4bcedc7503738e19ee8635f4df58f7062a2 | f224ac2668d960900218441b29616f4d01225eff | [
"@markdascher I think this is fixed in 4.1.7.Final-SNAPSHOT (current 4.1 branch). Can you please test and let us know ?",
"Wow, wasn't expecting an answer so fast. 👍\r\n\r\nI just downloaded [netty-all-4.1.7.Final-20161230.120821-77.jar](https://oss.sonatype.org/content/repositories/snapshots/io/netty/netty-all... | [
"nit: revert to be consistent with other switch cases (and make merging easier :) )",
"futher -> further\r\n\r\nor just `UNWRAP/WRAP are not expected after this point`",
"fixed",
"fixed"
] | 2017-01-10T07:21:46Z | [
"defect"
] | OpenSslEngine doesn't respond to close_notify | ### Expected behavior
When a Netty server receives a TLS close_notify, it should respond with a close_notify.
### Actual behavior
Netty's [OpenSslEngine](https://github.com/netty/netty/blob/netty-4.1.6.Final/handler/src/main/java/io/netty/handler/ssl/OpenSslEngine.java) (actually [ReferenceCountedOpenSslEngine... | [
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java b/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java
index 5594f3a4e66..23c666796ff 100644
--- a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java
+++ b/handler/src/main/java... | diff --git a/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java b/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java
index 98d629206b9..140d95829f2 100644
--- a/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java
+++ b/handler/src/test/java/io/netty/handler/ssl/SSLEngineTest.java
@@ -121... | train | train | 2017-01-12T07:51:37 | 2016-12-30T18:08:38Z | markdascher | val |
netty/netty/6152_6195 | netty/netty | netty/netty/6152 | netty/netty/6195 | [
"timestamp(timedelta=12.0, similarity=0.8699828685304778)"
] | d771526f8cfe262914ef40f0613e1e4b9e3a3aca | 2d1970219a4a740da5e27c3acd97a80e0d3a36a9 | [
"@ZuluForce maybe you can come up with a PR that fixes the issue for you ?",
"We should consider using [toAddressString](https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/NetUtil.java#L948) for the address portion which follows the RFC 5952 formatting (last time I checked java didn't). We... | [
"I wonder if it would should be more explicit about the string concatenation operations used here. For example it seems unlikely JIT will be able to combine all of these conditional concatenation operations into a single `StringBuilder`. Can we create a single `StringBuilder` and manually do the `append` calls (e.g... | 2017-01-10T13:22:07Z | [
"defect"
] | HttpProxyHandler incorrectly formats IPv6 host and port in CONNECT request | ### Expected behavior
The HttpProxyHandler is expected to be capable of issuing a valid CONNECT request for a tunneled connection to an IPv6 host. In this case we are passing an IPv6 address (eg fd00:c0de:42::c:293a:5736) rather than a host name.
### Actual behavior
The HttpProxyHandler does not properly concatena... | [
"common/src/main/java/io/netty/util/NetUtil.java",
"handler-proxy/src/main/java/io/netty/handler/proxy/HttpProxyHandler.java"
] | [
"common/src/main/java/io/netty/util/NetUtil.java",
"handler-proxy/src/main/java/io/netty/handler/proxy/HttpProxyHandler.java"
] | [
"common/src/test/java/io/netty/util/NetUtilTest.java",
"handler-proxy/src/test/java/io/netty/handler/proxy/HttpProxyHandlerTest.java"
] | diff --git a/common/src/main/java/io/netty/util/NetUtil.java b/common/src/main/java/io/netty/util/NetUtil.java
index a645cd70d63..a442ff4ce9b 100644
--- a/common/src/main/java/io/netty/util/NetUtil.java
+++ b/common/src/main/java/io/netty/util/NetUtil.java
@@ -25,6 +25,7 @@
import java.net.Inet4Address;
import java.n... | diff --git a/common/src/test/java/io/netty/util/NetUtilTest.java b/common/src/test/java/io/netty/util/NetUtilTest.java
index aa04b2a4c04..09afacca357 100644
--- a/common/src/test/java/io/netty/util/NetUtilTest.java
+++ b/common/src/test/java/io/netty/util/NetUtilTest.java
@@ -18,6 +18,7 @@
import org.junit.Test;
im... | val | train | 2017-01-11T21:23:45 | 2016-12-21T19:47:24Z | ZuluForce | val |
netty/netty/6169_6198 | netty/netty | netty/netty/6169 | netty/netty/6198 | [
"timestamp(timedelta=30.0, similarity=0.8704484361788252)"
] | 2368f238ad75935f68221f35330934c4ee734ee8 | 44c7fe73c0047de0188062697144b7525f5159bd | [
"Thanks for reporting @rkapsi ... standby for a PR."
] | [] | 2017-01-10T19:29:10Z | [
"defect"
] | ByteBuf#compareTo() "violates its general contract" | ### Expected behavior
`ByteBuf` implements the Comparable interface but it appears to not work correctly.
### Actual behavior
The following exception occurs:
```java
Exception in thread "main" java.lang.IllegalArgumentException: Comparison method violates its general contract!
at java.util.ComparableTimS... | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/main/java/io/netty/buffer/ByteBufUtil.java"
] | [
"buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
index 79403c61be1..1ddcab5ab0e 100644
--- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
+++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java
@@ -246,7 +246,7 @@ public static int c... | diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
index 35613786b1f..720894df296 100644
--- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
+++ b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java
@@ -38,... | val | train | 2017-01-10T13:49:52 | 2017-01-02T19:22:45Z | rkapsi | val |
netty/netty/6209_6229 | netty/netty | netty/netty/6209 | netty/netty/6229 | [
"timestamp(timedelta=57946.0, similarity=0.8625178401546824)"
] | c590e3bd63c43e9c1104ce2ab3a5307f14bee960 | 51e1e35a380612d9e87741ba9df9ed53fac86864 | [
"@Scottmitch @nmittler can you take a look ?",
"I've been helping @exell-christopher with debugging this.\r\n\r\nOur current understanding is that there really is no safe way to recover from an exception thrown in the Decoder except for tearing down the connection as the index tables in client and server can have... | [] | 2017-01-17T23:55:51Z | [
"defect"
] | HTTP/2 HPACK decoder oversized header handling causes client/server Dynamic Table inconsistencies | ### Problem Description
When a client sends oversized headers that causes the decoder to exceed the MAX_HEADER_LIST_SIZE setting, the decoder stops processing headers, and throws a HeaderListSizeException which causes a 431, and a RST_STREAM. If the incoming request had additional headers after the header that caused ... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Decoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/HuffmanEncoder.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Decoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Encoder.java",
"codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/HuffmanEncoder.java",
"microbench/src/main/java/io/netty/microbench... | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/internal/hpack/DecoderTest.java",
"codec-http2/src/test/java/io/netty/handler/codec/http2/internal/hpack/EncoderTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Decoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Decoder.java
index 509069fb87a..aea195cca00 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/internal/hpack/Decoder.java
+++ b/codec-... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/internal/hpack/DecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/internal/hpack/DecoderTest.java
index db282044026..76c070d91e4 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/internal/hpack/DecoderTest.java
... | train | train | 2017-01-18T08:02:15 | 2017-01-12T18:20:35Z | exell-christopher | val |
netty/netty/6192_6235 | netty/netty | netty/netty/6192 | netty/netty/6235 | [
"timestamp(timedelta=83.0, similarity=0.8546401581537069)"
] | c590e3bd63c43e9c1104ce2ab3a5307f14bee960 | 3e64b7393d27273b75fac2ebebf10ec5481716bf | [
"@wangyuntao we warn in `ServerBootstrap` and `Bootstrap`. The rest is up to the user when the methods return false.",
"@normanmaurer , I checked the code and found that [Bootstrap](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/bootstrap/Bootstrap.java#L272) has warn logs, but [ServerBo... | [
"May be need rethrow or catch Exception instead of Throwable?",
"@fenik17 I just moved the code around that was there before tho... @Scottmitch @nmittler @trustin WDYT ?",
"fine for this PR. We will look at `Throwable` in a more broad sense for https://github.com/netty/netty/issues/6096",
"@Scottmitch +1 :)"... | 2017-01-18T07:19:01Z | [
"defect"
] | Add some warn log about unknown channel option? | Should add some WARN log [at this point](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/DefaultChannelConfig.java#L109) ? like [this one](https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/bootstrap/ServerBootstrap.java#L242) ? | [
"transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java",
"transport/src/main/java/io/netty/bootstrap/Bootstrap.java",
"transport/src/main/java/io/netty/bootstrap/ServerBootstrap.java"
] | [
"transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java",
"transport/src/main/java/io/netty/bootstrap/Bootstrap.java",
"transport/src/main/java/io/netty/bootstrap/ServerBootstrap.java"
] | [] | diff --git a/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java b/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
index d6d0e3efde7..8140ebf9d68 100644
--- a/transport/src/main/java/io/netty/bootstrap/AbstractBootstrap.java
+++ b/transport/src/main/java/io/netty/bootstrap/AbstractBootst... | null | test | train | 2017-01-18T08:02:15 | 2017-01-10T07:40:59Z | ytcoode | val |
netty/netty/6264_6267 | netty/netty | netty/netty/6264 | netty/netty/6267 | [
"timestamp(timedelta=658.0, similarity=0.9354032902362656)"
] | 7a39afd031accea9ee38653afbd58eb1c466deda | d171f82f96f2893eeb93fed0abb0cdbc6cc48e9b | [
"please submit a PR if you this this is an improvement. I don't see `wakeup` taken into account.",
"@Scottmitch Thank you for your advice, here is the PR #6267 "
] | [
"This is a change in behavior, are you sure this is desired? Previously the state was changed to shutdown before the thread was started, now we unconditionally start the thread before attempting shutdown. Perhaps now the thread will be allowed to process jobs that it previously wouldn't have been allowed to.",
"@... | 2017-01-24T03:11:00Z | [] | Code suggestion about shutdownGracefully | Here's the current [code](https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java#L557), and the following is a code snippet:
```java
boolean inEventLoop = inEventLoop();
boolean wakeup;
int oldState;
for (;;) {
if (isShuttingDown()) {
re... | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java"
] | [
"common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
index e90358cffd0..22be86b9b0f 100644
--- a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java
+++ b/common/src/main/java/io/... | null | train | train | 2017-01-27T23:37:10 | 2017-01-23T04:36:15Z | ytcoode | val |
netty/netty/6282_6288 | netty/netty | netty/netty/6282 | netty/netty/6288 | [
"timestamp(timedelta=267.0, similarity=0.8924097440792926)"
] | e13da218e9509058d99ba2ec9b60bbf46d6d67ce | 270aa1293a7bd73501248983ff4d87b4d201036a | [
"@isdom this is because of the caches... when you deallocate the buffers they will first end up in ThreadLocal caches. Only after these removed from the caches they are really deallocated. You can disable the caches to see it.",
"@normanmaurer but I have already disable ThreadLocal caches by set JVM flag: \r\n``... | [
"@isdom I would prefer if we not need to acquire the `synchronized(this)` two times when we increment for normal allocations. Can you please refactor to ensure we not do ?",
"OK",
"@normanmaurer Could you give me some advice for my commit: [acquire the synchronized(this) once when we increment for normal alloca... | 2017-01-27T08:38:44Z | [
"defect"
] | Incorrect allocations value for PoolArena (tiny / small / normal) | I found some PoolArena allocations value was incorrect, more specifically is:
long numTinyAllocations();
long numSmallAllocations();
long numNormalAllocations();
and
long numNormalDeallocations();
When I alloc Pooled ByteBuf & and release all these Bufs,
### Expected behavior
PoolAr... | [
"buffer/src/main/java/io/netty/buffer/PoolArena.java"
] | [
"buffer/src/main/java/io/netty/buffer/PoolArena.java"
] | [
"buffer/src/test/java/io/netty/buffer/PoolArenaTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/PoolArena.java b/buffer/src/main/java/io/netty/buffer/PoolArena.java
index 0b87a96f8df..2faeb09be1f 100644
--- a/buffer/src/main/java/io/netty/buffer/PoolArena.java
+++ b/buffer/src/main/java/io/netty/buffer/PoolArena.java
@@ -201,16 +201,14 @@ private void allocate(Poo... | diff --git a/buffer/src/test/java/io/netty/buffer/PoolArenaTest.java b/buffer/src/test/java/io/netty/buffer/PoolArenaTest.java
index f5acd2b4f22..f27c41ca3ef 100644
--- a/buffer/src/test/java/io/netty/buffer/PoolArenaTest.java
+++ b/buffer/src/test/java/io/netty/buffer/PoolArenaTest.java
@@ -32,4 +32,49 @@ public void ... | train | train | 2017-01-27T08:26:17 | 2017-01-26T16:14:10Z | isdom | val |
netty/netty/5951_6295 | netty/netty | netty/netty/5951 | netty/netty/6295 | [
"timestamp(timedelta=234.0, similarity=0.8622783563886524)"
] | d3581b575eea6c9cc2ab6f7ee7db9be965660fc7 | 7f1c51ee9d82f9df86e50158adfa50a891434801 | [
"@nitsanw can you explain what the `advantages` of the new impl is ?\n",
"IIUC Netty originally had an unbounded linked queue here. It then moved to using Chunked which is bounded and just set a very very high boundary on max size. Unbounded should offer a slightly faster and simpler resize logic, and a more accu... | [
"I plan to open an issue for these but wanted to discuss first.",
"@nitsanw - FYI. I didn't use `MpscLinkedQueue` in this PR for GC concerns. I have not done any evaluation ... we can do this as a followup PR if necessary. I did want to upgrade to the latest version of JCTools though.",
"+1",
"+1",
"@Scottm... | 2017-01-30T18:45:55Z | [
"feature"
] | Upgrade to JCTools v2.0, use the Unbounded MPSC to replace Chunked | [
"common/src/main/java/io/netty/util/internal/PlatformDependent.java",
"pom.xml",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueEventLoop.java",
"transport/src/main/java/io/netty/channel/nio/NioEventLoop... | [
"common/src/main/java/io/netty/util/internal/PlatformDependent.java",
"pom.xml",
"transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java",
"transport-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueEventLoop.java",
"transport/src/main/java/io/netty/channel/nio/NioEventLoop... | [] | diff --git a/common/src/main/java/io/netty/util/internal/PlatformDependent.java b/common/src/main/java/io/netty/util/internal/PlatformDependent.java
index 2fd3c985a94..e56ba5817cc 100644
--- a/common/src/main/java/io/netty/util/internal/PlatformDependent.java
+++ b/common/src/main/java/io/netty/util/internal/PlatformDe... | null | test | train | 2017-07-06T02:14:27 | 2016-10-28T10:45:59Z | nitsanw | val | |
netty/netty/6328_6340 | netty/netty | netty/netty/6328 | netty/netty/6340 | [
"timestamp(timedelta=12.0, similarity=0.8957507968918899)"
] | d06990f43458e9ac7cea803269e83d072ada61f6 | 526e19f51e12167e28b85ac899617dc2486e2b8e | [
"I can provide a PR.\r\n\r\nThe question is: \"can we use CharSequence all the way down, meaning having CorsConfig::exposedHeaders and CorsConfig:: allowedRequestHeaders return `Set<CharSequence>` instead of `Set<String>`?\".",
"> can we use CharSequence all the way down, meaning having CorsConfig::exposedHeaders... | [] | 2017-02-09T20:49:50Z | [] | CorsConfigBuilder exposeHeaders and allowedRequestHeaders should accept CharSequence | ### Expected behavior
In Netty 4.1, `HttpHeaderNames` constants are `AsciiString`s. It should be possible to directly pass those constants to `CorsConfigBuilder` methods such as `exposeHeaders`, `allowedRequestHeaders`.
### Actual behavior
Those methods take `String`, so one has to convert and call `toString` ... | [
"codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java"
] | [] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java b/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java
index 93d76ae82dc..3285581af77 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsConfigBuilder.java
+++ b/codec-http/s... | null | train | train | 2017-02-09T18:50:55 | 2017-02-07T16:23:43Z | slandelle | val |
netty/netty/6333_6352 | netty/netty | netty/netty/6333 | netty/netty/6352 | [
"timestamp(timedelta=4617.0, similarity=0.8719420871899115)"
] | fe522fb18e829226ffcc4cdb92fe4b98e2664d08 | 205004d9d1bb77ee105f3785af9caf72eae59286 | [
"@errandir `CombinedChannelDuplexHandler` implementation can't be `@Sharable` as it contains state. Let me ensure we throw an exception if someone tries to make a sub-class of `CombinedChannelDuplexHandler ` `@Sharable`.\r\n\r\nThanks for reporting",
"@normanmaurer There is real lack of such exception and even `C... | [] | 2017-02-13T18:34:26Z | [
"defect"
] | @Sharable CombinedChannelDuplexHandler usage problems | Netty version: 4.1.8.Final
@Sharable CombinedChannelDuplexHandler implementation shares ChannelHandlerContext among different connections. Problem could be reproduced with [this code](https://gist.github.com/errandir/af45f3559421e3d12ace556af3e4999b) _(compile and run with netty-all-4.1.8.Final.jar in classpath)_. O... | [
"codec/src/main/java/io/netty/handler/codec/ByteToMessageCodec.java",
"codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java",
"codec/src/main/java/io/netty/handler/codec/CodecUtil.java",
"transport/src/main/java/io/netty/channel/ChannelHandlerAdapter.java",
"transport/src/main/java/io/netty/... | [
"codec/src/main/java/io/netty/handler/codec/ByteToMessageCodec.java",
"codec/src/main/java/io/netty/handler/codec/ByteToMessageDecoder.java",
"transport/src/main/java/io/netty/channel/ChannelHandlerAdapter.java",
"transport/src/main/java/io/netty/channel/CombinedChannelDuplexHandler.java"
] | [
"transport/src/test/java/io/netty/channel/CombinedChannelDuplexHandlerTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/ByteToMessageCodec.java b/codec/src/main/java/io/netty/handler/codec/ByteToMessageCodec.java
index c7c61f7cef2..7dd80f5d433 100644
--- a/codec/src/main/java/io/netty/handler/codec/ByteToMessageCodec.java
+++ b/codec/src/main/java/io/netty/handler/codec/ByteToMessa... | diff --git a/transport/src/test/java/io/netty/channel/CombinedChannelDuplexHandlerTest.java b/transport/src/test/java/io/netty/channel/CombinedChannelDuplexHandlerTest.java
index 27f9b8d11c2..f697e0b50f4 100644
--- a/transport/src/test/java/io/netty/channel/CombinedChannelDuplexHandlerTest.java
+++ b/transport/src/test... | train | train | 2017-02-11T14:09:15 | 2017-02-08T14:36:02Z | errandir | val |
netty/netty/6345_6356 | netty/netty | netty/netty/6345 | netty/netty/6356 | [
"timestamp(timedelta=18.0, similarity=1.0000000000000002)"
] | 34ea09e5524fa9da4f482822bf7b1a16ef69731f | 11a0c2b6b6c2193f58176d80e41fca2c255e38b3 | [
"@mp911de thanks for reporting... let me fix this",
"Started working on a fix... should have a PR soon",
"Fixed by https://github.com/netty/netty/pull/6356"
] | [
"@normanmaurer +1 ... can't hurt"
] | 2017-02-13T18:45:29Z | [
"defect"
] | Initialization of PlatformDependent0 fails on Java 9 | Initialization of `PlatformDependent0` fails on Java 9 in static initializer when calling `setAccessible(true)`.
```
Field field = Buffer.class.getDeclaredField("address");
field.setAccessible(true);
```
### Expected behavior
Initialization should not fail without `--add-opens=java.base/java.nio=ALL-UNNAMED... | [
"common/src/main/java/io/netty/util/internal/PlatformDependent0.java",
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.java"
] | [
"common/src/main/java/io/netty/util/internal/PlatformDependent0.java",
"common/src/main/java/io/netty/util/internal/ReflectionUtil.java",
"transport/src/main/java/io/netty/channel/nio/NioEventLoop.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/internal/PlatformDependent0.java b/common/src/main/java/io/netty/util/internal/PlatformDependent0.java
index cbfd8ed4253..6abdb0035f8 100644
--- a/common/src/main/java/io/netty/util/internal/PlatformDependent0.java
+++ b/common/src/main/java/io/netty/util/internal/Platfor... | null | train | train | 2017-02-14T08:17:33 | 2017-02-10T19:26:38Z | mp911de | val |
netty/netty/6336_6363 | netty/netty | netty/netty/6336 | netty/netty/6363 | [
"timestamp(timedelta=18.0, similarity=0.9015923944025254)"
] | 54c9ecf682eeafaaf7c826903c60f1c783b84dea | eb5abdfe9b691469fc0b747d61621390bfcaa9d2 | [
"any idea what the parameter values are `static String toJava(String openSslCipherSuite, String protocol)`?",
"Will find out tomorrow morning. ",
"@rkapsi - Just realized you pushed your code so I can do it my self too :)\r\n\r\n```\r\nopenSslCipherSuite: \"(NONE)\"\r\nprotocol: \"TLS\"\r\n```"
] | [] | 2017-02-13T20:04:35Z | [
"defect"
] | NPE in CipherSuiteConverter.toJava(CipherSuiteConverter.java:281) | Providing repro shortly but it's triggered by an Unit Test for the OCSP Stapling PR.
Basically... OpenSSL (native) is calling my OCSP callback (java) which throws for the sake of the test an Exception. Instead of bubbling up the Exceptions it's running into an unhandled (?) NPE and my purposely thrown Exception gets... | [
"handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java"
] | [
"handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java"
] | [
"handler/src/test/java/io/netty/handler/ssl/CipherSuiteConverterTest.java"
] | diff --git a/handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java b/handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java
index a3afeda3fe4..1737ad1e1d5 100644
--- a/handler/src/main/java/io/netty/handler/ssl/CipherSuiteConverter.java
+++ b/handler/src/main/java/io/netty/handler/ssl/Ciphe... | diff --git a/handler/src/test/java/io/netty/handler/ssl/CipherSuiteConverterTest.java b/handler/src/test/java/io/netty/handler/ssl/CipherSuiteConverterTest.java
index 92e1aad49c6..11c6f2d2295 100644
--- a/handler/src/test/java/io/netty/handler/ssl/CipherSuiteConverterTest.java
+++ b/handler/src/test/java/io/netty/handl... | test | train | 2017-02-13T20:54:09 | 2017-02-08T21:53:39Z | rkapsi | val |
netty/netty/6384_6389 | netty/netty | netty/netty/6384 | netty/netty/6389 | [
"timestamp(timedelta=63.0, similarity=0.9471868767507539)"
] | 847359fd36c28fa360090459d1243a9603e47786 | 032443fee09770fbc78a2acba7848b2a583babd0 | [
"(derived from a bug report by a customer, not sure how they ended up having no network interfaces, also not sure if its relevant to use netty if you do not have network interfaces :))",
"@CodingFabian let me fix this",
"Fixed by https://github.com/netty/netty/issues/6389"
] | [
"remove?",
"+1",
" Remove this unused import 'java.util.Collections'. [](https://garage.netty.io/sonarqube/coding_r... | 2017-02-15T18:58:07Z | [] | NetworkInterface.getNetworkInterfaces() can return null | To my suprise NetworkInterface.getNetworkInterfaces() can return null:
```
public static Enumeration<NetworkInterface> getNetworkInterfaces()
throws SocketException {
final NetworkInterface[] netifs = getAll();
// specified to return null if no network interfaces
if (netifs =... | [
"common/src/main/java/io/netty/util/NetUtil.java",
"common/src/main/java/io/netty/util/internal/MacAddressUtil.java"
] | [
"common/src/main/java/io/netty/util/NetUtil.java",
"common/src/main/java/io/netty/util/internal/MacAddressUtil.java"
] | [] | diff --git a/common/src/main/java/io/netty/util/NetUtil.java b/common/src/main/java/io/netty/util/NetUtil.java
index 97570fa165d..88d4cdd015c 100644
--- a/common/src/main/java/io/netty/util/NetUtil.java
+++ b/common/src/main/java/io/netty/util/NetUtil.java
@@ -163,11 +163,14 @@ public final class NetUtil {
// ... | null | val | train | 2017-02-15T19:20:06 | 2017-02-15T16:52:15Z | CodingFabian | val |
netty/netty/5458_6392 | netty/netty | netty/netty/5458 | netty/netty/6392 | [
"timestamp(timedelta=85041.0, similarity=0.8428685248890636)"
] | 1843b318850ac7a3990c13b1d275e0e37491301e | 32cdfd7b323b4a23e30d83b2079d292fc779c797 | [
"@CodingFabian I will fix this.\n",
"@CodingFabian seems like there is no way to fix this as we still need to support java6 :(\n",
"Huh? Cant you keep the current if else and just wrap with an if else that checks version and if >=8 delegates to the JDK Version? You might need an indirection to avoid classloadi... | [] | 2017-02-16T07:31:27Z | [
"improvement"
] | PlatformDependent doesn't prefer JDK8 LongAdder | I am running Netty on Java 8.
```
/**
* Creates a new fastest {@link LongCounter} implementaion for the current platform.
*/
public static LongCounter newLongCounter() {
if (HAS_UNSAFE) {
return new LongAdderV8();
} else {
return new AtomicLongCounter();
... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 28334609c54..76062141540 100644
--- a/pom.xml
+++ b/pom.xml
@@ -596,9 +596,9 @@
<configuration>
<rules>
<requireJavaVersion>
- <!-- Enforce JDK 1.7+ for compilation. -->
+ <!-- Enforce JDK 1.8+ for compil... | null | test | train | 2017-02-16T07:59:31 | 2016-06-28T05:57:50Z | CodingFabian | val |
netty/netty/6205_6404 | netty/netty | netty/netty/6205 | netty/netty/6404 | [
"timestamp(timedelta=153941.0, similarity=0.8771457455701042)"
] | 0623c6c5334bf43299e835cfcf86bfda19e2d4ce | 8093c8fbf3beb852ffdbf77e5e73da038e371cba | [
"thanks for reporting!",
"This can be closed as these are now merged: \r\n\r\n#6433\r\n#6404"
] | [
"Can't this be simplified to the following:\r\n\r\n```java\r\ninBuff = (value & 0xff0000) | (value & 0xff00) | (value & 0xff);\r\n```",
"```java\r\ninBuff = (value & 0xff00) << 8 | (value & 0xff) << 8;\r\n```",
"```java\r\ninBuff = (value & 0xff00) << 8 | (value & 0xff0000) >>> 8 | (value & 0xff000000) >>> 24;\... | 2017-02-17T16:32:12Z | [] | Investigate performance of Base64 | `Base64.encode(...)` / `Base64.decode(...)` is quite slow as it acts on byte-level. We may want to look into optimise this.
See also:
https://github.com/netty/netty/pull/6145#issuecomment-271899281 | [
"codec/src/main/java/io/netty/handler/codec/base64/Base64.java"
] | [
"codec/src/main/java/io/netty/handler/codec/base64/Base64.java"
] | [
"codec/src/test/java/io/netty/handler/codec/base64/Base64Test.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/base64/Base64.java b/codec/src/main/java/io/netty/handler/codec/base64/Base64.java
index dc3f1aff801..770940854bd 100644
--- a/codec/src/main/java/io/netty/handler/codec/base64/Base64.java
+++ b/codec/src/main/java/io/netty/handler/codec/base64/Base64.java
@@ -21,... | diff --git a/codec/src/test/java/io/netty/handler/codec/base64/Base64Test.java b/codec/src/test/java/io/netty/handler/codec/base64/Base64Test.java
index 6b8622ac24a..4be23a8d864 100644
--- a/codec/src/test/java/io/netty/handler/codec/base64/Base64Test.java
+++ b/codec/src/test/java/io/netty/handler/codec/base64/Base64T... | val | train | 2017-02-22T07:31:07 | 2017-01-11T20:11:41Z | normanmaurer | val |
netty/netty/5994_6412 | netty/netty | netty/netty/5994 | netty/netty/6412 | [
"timestamp(timedelta=18.0, similarity=0.8557552059067816)"
] | d0a3877535814153306f8f934e2120204cd22fd7 | 7ca913908733cd05ac2056821ae1f12468849a45 | [
"@flozano not sure what you are asking for... isnt it enough for you to import netty-all ?\n",
"@normanmaurer \n\n> isnt it enough for you to import netty-all ?\n\nNo. netty-all is not a bom.\nhttp://howtodoinjava.com/maven/maven-bom-bill-of-materials-dependency/\nhttp://stackoverflow.com/questions/38496022/maven... | [
"@johnou Can you open another PR for this change as its not related ? ",
"kill line",
"kill line",
"kill line"
] | 2017-02-19T10:42:51Z | [] | Bill Of Materials (BOM) pom | Many projects these days have a bill of materials (BOM) project that just allows to import all the managed dependencies for a project with a single entry in dependencyManagement.
It would be great to have such BOM in netty. | [
"pom.xml"
] | [
"bom/pom.xml",
"pom.xml"
] | [] | diff --git a/bom/pom.xml b/bom/pom.xml
new file mode 100644
index 00000000000..20d935d3bc5
--- /dev/null
+++ b/bom/pom.xml
@@ -0,0 +1,153 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Copyright 2017 The Netty Project
+ ~
+ ~ The Netty Project licenses this file to you under the Apache License,
+ ~ version 2.... | null | train | train | 2017-02-19T13:41:11 | 2016-11-09T12:52:34Z | flozano | val |
netty/netty/6436_6440 | netty/netty | netty/netty/6436 | netty/netty/6440 | [
"timestamp(timedelta=22.0, similarity=0.8538178156079667)"
] | 7d08b4fc357e12ee2487e87d8fdcbeee1152e5a0 | 4d3104dc4b0b82847298d0b6be9abb9afb489628 | [
"Good catch let me fix it\n\n> Am 23.02.2017 um 02:54 schrieb Max Gortman <notifications@github.com>:\n> \n> Expected behavior\n> \n> .alloc() returns allocator that buffer originated from. Backed by following behavior:\n> allocator field is reset on deallocate().\n> allocator field is set properly in initUnpooled(... | [] | 2017-02-23T10:01:20Z | [
"defect"
] | Unpooled buffer acquired from pooled allocator may have .alloc() returning null | ### Expected behavior
- .alloc() returns allocator that buffer originated from. Backed by following behavior:
- `allocator` field is reset on `deallocate()`.
- `allocator` field is set properly in `initUnpooled()`
### Actual behavior
`.alloc()` returns null if buffer is initialized through `initUnpooled()` and w... | [
"buffer/src/main/java/io/netty/buffer/PooledByteBuf.java"
] | [
"buffer/src/main/java/io/netty/buffer/PooledByteBuf.java"
] | [
"buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java"
] | diff --git a/buffer/src/main/java/io/netty/buffer/PooledByteBuf.java b/buffer/src/main/java/io/netty/buffer/PooledByteBuf.java
index aac5f531cfa..56a4be38723 100644
--- a/buffer/src/main/java/io/netty/buffer/PooledByteBuf.java
+++ b/buffer/src/main/java/io/netty/buffer/PooledByteBuf.java
@@ -43,30 +43,26 @@ protected P... | diff --git a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java b/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java
index 695d99095be..12c76098729 100644
--- a/buffer/src/test/java/io/netty/buffer/PooledByteBufAllocatorTest.java
+++ b/buffer/src/test/java/io/netty/buffer/PooledByteB... | train | train | 2017-02-23T07:54:42 | 2017-02-23T01:54:56Z | nayato | val |
netty/netty/6452_6502 | netty/netty | netty/netty/6452 | netty/netty/6502 | [
"timestamp(timedelta=44.0, similarity=0.8964428327377687)"
] | 2b8c8e0805e343f7c06d4fb81d958aed357ecc6a | 1d11301e101d7b06c638f1c4ca7f2e1193b78535 | [] | [
"better make `length != 1` as first condition bcz it has lower cost.\r\n\r\nUPD: Although may be not. One-char params is not very likely..\r\nsorry for noise.",
"IMHO, make sense add comment that if the `value` don't contain non-OWS chars, it returns `length`, but not `-1`.",
"If `quoted==true`, can we incremen... | 2017-03-07T02:19:09Z | [] | CombinedHttpHeaders does not trim optional white space between comma separated values | ### Expected behavior
The updated HTTP/1.x RFC allows for header values to be CSV and separated by `OWS` [1]. `CombinedHttpHeaders` should remove this `OWS` on insertion.
[1] https://tools.ietf.org/html/rfc7230#section-7
### Actual behavior
`CombinedHttpHeaders` doesn't account for the `OWS` and returns it back... | [
"codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaders.java",
"common/src/main/java/io/netty/util/internal/StringUtil.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java",
"codec-http/src/main/java/io/netty/handler/codec/http/HttpHeaders.java",
"common/src/main/java/io/netty/util/internal/StringUtil.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java",
"common/src/test/java/io/netty/util/internal/StringUtilTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java b/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java
index 79c5fda97a0..d3c0ac72664 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/CombinedHttpHeaders.java
+++ b/codec-http/src/main/j... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java
index 6ec9bfaf36a..258208f4625 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/CombinedHttpHeadersTest.java
+++ b/codec-htt... | train | train | 2017-03-10T07:46:17 | 2017-02-24T19:04:54Z | Scottmitch | val |
netty/netty/6516_6517 | netty/netty | netty/netty/6516 | netty/netty/6517 | [
"timestamp(timedelta=107232.0, similarity=0.8969268022128343)"
] | 3ad3356892e841b5e2cd7f6e87882fdf3fa2e68d | b6a7476a16b10a0a21d1056181351ab7f14537fd | [
"And confirmed, that adding the same names but with SSL works. I am going to open a PR, then we can discuss if this is the right thing to do :)",
"Hmm it seems that the JSSE spec wants to treat the \"TLS\" and \"SSL\" prefix as interchangeable [1].\r\n\r\n> The names mentioned in the TLS RFCs prefixed with TLS_ a... | [
"@CodingFabian nit: On OpenJDK and Oracle JDK ?",
"Well i consider Oracle JDK to be OpenJDK, but I happily will adjust to your preferred wording.\r\nBut the TLS_ names work correctly on Azul Zulu, so we should add that, or say OpenJDK based JVMs?",
"OpenJDK based sounds good",
"I think its better to just say... | 2017-03-08T18:57:25Z | [] | IBM J9 uses slightly different cipher names -> HTTP2.0 connection fails | While investigating https://github.com/netty/netty/issues/6437, i found an interesting problem:
```
SslHandshakeCompletionEvent(javax.net.ssl.SSLHandshakeException: No appropriate protocol, may be no appropriate cipher suite specified or protocols are deactivated)
```
It turns out that netty qants the following h... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java
index 2ddd16f63ce..e0450fba58e 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java
+++ b/codec-http2/src/main/... | null | train | train | 2017-03-08T20:07:58 | 2017-03-08T18:27:58Z | CodingFabian | val |
netty/netty/6507_6518 | netty/netty | netty/netty/6507 | netty/netty/6518 | [
"timestamp(timedelta=13.0, similarity=1.0000000000000002)"
] | 2993760e9261f046db88a0e8ccf9edf4e9b0acad | 4c3ae9433ca17a6fedd7b6a4f4d813c5810c1f01 | [
"@meshcow will have a look soon",
"@meshcow PTAL https://github.com/netty/netty/pull/6518 ",
"looks good now!",
"Fixed by https://github.com/netty/netty/pull/6518"
] | [] | 2017-03-08T20:07:05Z | [
"defect"
] | UnorderedThreadPoolEventExecutor consumes 100% CPU when idle | ### Expected behavior
0% CPU consumption when idle
### Actual behavior
almost 100% CPU consumption when idle
### Steps to reproduce
After a submitted task has been successfully executed, all the available cores get busy with doing some stuff.
```java
import io.netty.util.concurrent.UnorderedThreadPoolEventExecut... | [
"common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java"
] | [
"common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java"
] | [
"common/src/test/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutorTest.java"
] | diff --git a/common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java
index 5d073debec3..4ed94da5375 100644
--- a/common/src/main/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutor.java
+++ b/com... | diff --git a/common/src/test/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutorTest.java b/common/src/test/java/io/netty/util/concurrent/UnorderedThreadPoolEventExecutorTest.java
new file mode 100644
index 00000000000..d96db3fcb07
--- /dev/null
+++ b/common/src/test/java/io/netty/util/concurrent/UnorderedTh... | train | train | 2017-03-09T07:48:37 | 2017-03-07T11:54:59Z | meshcow | val |
netty/netty/6520_6521 | netty/netty | netty/netty/6520 | netty/netty/6521 | [
"timestamp(timedelta=7.0, similarity=0.905203241220413)"
] | f49bf4b201389bbeeb61991981945adcbe38db3c | 98bd130e2dae0a71993cba76c655cfa9b903afa2 | [
"Reproduction:\r\n\r\nI've used it to confirm (1) above resolves the problem (move `encoder.writeSettingsAck` earlier). In this reproduction, the client is sending a large message and misbehaves.\r\n\r\n```patch\r\ndiff --git a/example/src/main/java/io/netty/example/http2/helloworld/client/Http2Client.java b/exampl... | [
"This doesn't actually check \"before settings are used\" in the general sense. It only tests `INITIAL_WINDOW_SIZE` handling. Maybe `testSettingsAckIsSentBeforeUsingFlowControl`?\r\n\r\nI say that because if the default flow controller avoids calling `writePendingBytes();` from `initialWindowSize(int)`, this test p... | 2017-03-09T02:58:35Z | [
"defect"
] | http2: Compatibility issue: SETTINGS ACK may be reordered | ### Expected behavior
When receiving a SETTINGS frame, the ACK would be sent before any frames that make use of the new settings.
For example, say MAX_CONCURRENT_STREAMS=0 initially. When receiving a SETTINGS with MAX_CONCURRENT_STREAMS=1, the SETTINGS(ACK=true) would be sent before a HEADERS for a new stream. Si... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDecoder.java
index 333937113e2..ef643fafadc 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionDeco... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest.java
index cb70ec6225a..f5de427b4a8 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2ConnectionRoundtripTest... | train | train | 2017-03-09T02:09:17 | 2017-03-09T00:09:52Z | ejona86 | val |
netty/netty/6551_6552 | netty/netty | netty/netty/6551 | netty/netty/6552 | [
"timestamp(timedelta=1.0, similarity=0.8946069731133737)"
] | 9c1a1916962354f1e69fe43107219c25a86e6cef | c8cf45faab998dd2a922826fad20e900f01c49a2 | [
"@vkostyukov this is a bug... Please open a PR FTW :)",
"Thanks @normanmaurer! I'm on it!",
"Fixed by https://github.com/netty/netty/pull/6552"
] | [] | 2017-03-20T20:19:43Z | [
"defect"
] | Http2StreamChannel doesn't inherit config of the parent channel | # Problem
As you probably aware, Finagle is a bit special when it comes to Netty 4 usage. For example, we neither use pooling nor prefer direct buffers at the moment. We're getting close to the pooled/direct utopia, but we're not there yet.
That said, Finagle's HTTP/2 pipelines are unpooled and yet we've discover... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java"
] | [
"codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java"
] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java
index e03abd2165d..83d9eb5ce7c 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java
+++ b/codec-http2/src... | diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
index 95e57a5e24a..c17c1970da0 100644
--- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java
+++ b/cod... | test | train | 2017-03-19T16:17:29 | 2017-03-17T21:28:30Z | vkostyukov | val |
netty/netty/6549_6587 | netty/netty | netty/netty/6549 | netty/netty/6587 | [
"timestamp(timedelta=199.0, similarity=0.8867371246394287)"
] | ef21d5f4caf904e9035e6e8ffec503e554cb6d61 | 56a9f604b64396c0eb4127a7eb65d769f04c4072 | [
"see https://github.com/netty/netty/pull/6587"
] | [] | 2017-03-30T23:09:49Z | [
"defect"
] | HttpServerKeepAliveHandler closes connection on 204 response | ### Expected behavior
Netty Http Server responds 204 without body, maintaining the connection open.
### Actual behavior
`HttpServerKeepAliveHandler` closes the connection unless the response is `Informational` or has `Content-Length` set, but 204 responses are not Informational but should not carry a `Content-... | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java"
] | [
"codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java"
] | [
"codec-http/src/test/java/io/netty/handler/codec/http/HttpServerKeepAliveHandlerTest.java"
] | diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java
index 1930c0ec804..c6305a5e2a2 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java
+++ b/... | diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerKeepAliveHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerKeepAliveHandlerTest.java
index 29087891fe7..bcd64bebad0 100644
--- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerKeepAliveHandlerTest... | train | train | 2017-03-30T20:52:03 | 2017-03-16T17:47:30Z | sschepens | val |
netty/netty/6579_6589 | netty/netty | netty/netty/6579 | netty/netty/6589 | [
"timestamp(timedelta=0.0, similarity=0.8901193503397146)",
"keyword_pr_to_issue"
] | ef21d5f4caf904e9035e6e8ffec503e554cb6d61 | f4c635d30b23be6ce51866704c178232e98015e7 | [
"@nmittler @ejona86 can we get around this without exposing it again ? ",
"I'll defer to @ejona86 and @carl-mastrangelo ",
"I just chatted with @carl-mastrangelo offline and this is blocking them from migrating to 4.1.9.Final. Easiest thing would be to just expose it.\r\n\r\n@Scottmitch any objections?",
"FY... | [
"if we make it public again can we at least make it final ?",
"Yup - done. I wasn't sure at first whether gRPC needed to extend but it looks like it doesn't.",
"having this be public can be dangerous as indicated in the comments. Can this stay package private?"
] | 2017-03-31T00:25:40Z | [] | Expose the hpack decoder | Hello,
grpc is using the hpack decoder in [GrpcHttp2HeadersDecoder](https://github.com/grpc/grpc-java/blob/master/netty/src/main/java/io/grpc/netty/GrpcHttp2HeadersDecoder.java) and in netty 4.1.9.Final its visibility has been [changed to private](https://github.com/zer0se7en/netty/pull/2/commits/f9001b9fc07a71a9d6e... | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java"
] | [
"codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java"
] | [] | diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
index dad2c6fc1d8..e4d5c5f0d4d 100644
--- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java
+++ b/codec-http2/src/main/java/io/netty/h... | null | train | train | 2017-03-30T20:52:03 | 2017-03-28T23:10:17Z | guillaumecle | val |
netty/netty/6347_6590 | netty/netty | netty/netty/6347 | netty/netty/6590 | [
"timestamp(timedelta=18.0, similarity=0.8480042062936383)"
] | 38b054c65cc655bb4966517abeb32c1246c5c7e3 | 8dcf9257976eb59ff4b6a1e3392d61c460cb97aa | [
"Somewhat related with Java 9 without these options I get\r\n\r\n```\r\njava.lang.NullPointerException\r\n\tat io.netty.resolver.dns.DnsNameResolver.<init>(DnsNameResolver.java:250)\r\n\tat io.netty.resolver.dns.DnsNameResolverBuilder.build(DnsNameResolverBuilder.java:347)\r\n\tat com.baulsupp.oksocial.network.Nett... | [
"How about: `Skipping a malformed nameserver URI: {}` ?",
"done",
"Not possible as the constructor expects a `Hashtable` 👎 ",
"nope...",
" Extract this nested try block into a separate method. [![rule](h... | 2017-03-31T06:09:13Z | [
"improvement"
] | DnsNameResolver uses public dns servers in java 9 | I realise this is known, but it seems broken enough to deserve a tracking issue.
### Expected behavior
Should use system dns servers
### Actual behavior
Logs a warning "Default DNS servers: [/8.8.8.8:53, /8.8.4.4:53] (Google Public DNS as a fallback)"
Then uses the google servers.
n.b. It logs the warn... | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStreamProvider.java"
] | [
"resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStreamProvider.java"
] | [] | diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStreamProvider.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStreamProvider.java
index 505ecfb4ae2..b7c5bd719fa 100644
--- a/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsServerAddressStrea... | null | test | train | 2017-04-19T07:26:26 | 2017-02-11T10:52:37Z | yschimke | val |
netty/netty/6583_6604 | netty/netty | netty/netty/6583 | netty/netty/6604 | [
"timestamp(timedelta=12.0, similarity=0.8510605653766261)"
] | 155983f1a1384b2dc31a637da50bf7ecd3622927 | 9bff295cff30bb3fb8bd9a91f738ac705cbfac23 | [
"@vkostyukov yes this is a bug. Can you please submit a pr ?",
"@vkostyukov maybe let me also think about if we can fix this in a more generic way so it \"just works\" for all handlers.",
"@vkostyukov so yes just do a PR for now. I may be able to come up with a more general solution but not sure yet and it may ... | [
"please fix formatting ",
"use `Unpooled.copiedBuffer(..., CharsetUtil.US_ASCII);`",
"fix formatting",
"use `embedded.readInbound()` and so train the read messages. Also assert its what you expect and ensure you release everything",
"private final",
"nit: `Unpooled.copiedBuffer(string, CharsetUtil.US_ASCI... | 2017-04-05T00:26:24Z | [
"defect"
] | MessageAggregator doesn't manage read flow (auto-read is disabled) | ### Expected behavior
This was discovered in Finagle's [HTTP proxy support handler](https://github.com/twitter/finagle/blob/develop/finagle-netty4/src/main/scala/com/twitter/finagle/netty4/proxy/HttpProxyConnectHandler.scala#L103-L106).
Calling `ctx.read()` (when auto-read is disabled) in any handler placed right... | [
"codec/src/main/java/io/netty/handler/codec/MessageAggregator.java"
] | [
"codec/src/main/java/io/netty/handler/codec/MessageAggregator.java"
] | [
"codec/src/test/java/io/netty/handler/codec/MessageAggregatorTest.java"
] | diff --git a/codec/src/main/java/io/netty/handler/codec/MessageAggregator.java b/codec/src/main/java/io/netty/handler/codec/MessageAggregator.java
index 38e5bd7575a..2bede688bd0 100644
--- a/codec/src/main/java/io/netty/handler/codec/MessageAggregator.java
+++ b/codec/src/main/java/io/netty/handler/codec/MessageAggrega... | diff --git a/codec/src/test/java/io/netty/handler/codec/MessageAggregatorTest.java b/codec/src/test/java/io/netty/handler/codec/MessageAggregatorTest.java
new file mode 100644
index 00000000000..d3c4f5f6c97
--- /dev/null
+++ b/codec/src/test/java/io/netty/handler/codec/MessageAggregatorTest.java
@@ -0,0 +1,94 @@
+/*
+ ... | test | train | 2017-04-07T03:09:58 | 2017-03-30T00:06:03Z | vkostyukov | val |
netty/netty/6622_6634 | netty/netty | netty/netty/6622 | netty/netty/6634 | [
"timestamp(timedelta=20.0, similarity=0.9067023002115264)"
] | 38b054c65cc655bb4966517abeb32c1246c5c7e3 | 4c4b55019b50d0866004807f4ade3cf15a81d107 | [
"```patch\r\n\r\nFrom 7beda8e105e05eb3b3c7e0c6b2f99a069370137f Mon Sep 17 00:00:00 2001\r\nDate: Tue, 11 Apr 2017 17:34:36 +0200\r\nSubject: [PATCH] Fix encoder exceptions being discarded when writing with a VoidPromise.\r\n\r\nMotivation:\r\n\r\nAccording to documentation of Channel#voidPromise(), if encoding of t... | [
"How about moving `promise instanceof VoidChannelPromise` into `PromiseNotificationUtil`?"
] | 2017-04-18T05:54:28Z | [
"defect"
] | VoidChannelPromise eats exceptions... | ### Expected behavior
```
voidPromise
ChannelPromise voidPromise()
Return a special ChannelPromise which can be reused for different operations.
It's only supported to use it for write(Object, ChannelPromise).
Be aware that the returned ChannelPromise will not support most operations and should only be used i... | [
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java"
] | [
"transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java",
"transport/src/main/java/io/netty/channel/ChannelOutboundBuffer.java"
] | [
"transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java"
] | diff --git a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java b/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
index 55e596f7f6b..796bddf0fff 100644
--- a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
+++ b/transport/src/main/java/io/... | diff --git a/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java b/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java
index 4f745e439cf..39f6752b2da 100644
--- a/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java
+++ b/transport/src/test/java/io/netty/cha... | test | train | 2017-04-19T07:26:26 | 2017-04-11T15:18:20Z | ninja- | val |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.