data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | When building device trees for the RK3576 based boards, DTC shows the
following complaint:
rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"
The first patch updates 'reg-names' property in rockchip,vdec binding to
allow providi... | {
"author": "Cristian Ciocaltea <cristian.ciocaltea@collabora.com>",
"date": "Thu, 26 Feb 2026 12:46:52 +0200",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | When building device trees for the RK3576 based boards, DTC shows the
following complaint:
rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"
Provide the register blocks using the 'link,function,cache' listing,
which follows the... | {
"author": "Cristian Ciocaltea <cristian.ciocaltea@collabora.com>",
"date": "Thu, 26 Feb 2026 12:46:54 +0200",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | Provide the register blocks for RK3588 vdec0 & vdec1 nodes using the
'link,function,cache' listing, which follows the address-based ordering
and, implicitly, ensures the unit address points to the first register
range.
This aligns with a similar fix for RK3576 where DTC complained about the
bus address format.
Signed... | {
"author": "Cristian Ciocaltea <cristian.ciocaltea@collabora.com>",
"date": "Thu, 26 Feb 2026 12:46:55 +0200",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | On Thu, Feb 26, 2026 at 12:46:53PM +0200, Cristian Ciocaltea wrote:
I don't understand this commit message or rationale for an ABI break.
Changing the unit address seems like a "free" fix to your problem,
especially when reg-names is not a required property that you can rely
on. Actually, there may be a bug in the dri... | {
"author": "Conor Dooley <conor@kernel.org>",
"date": "Thu, 26 Feb 2026 18:43:31 +0000",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | Le jeudi 26 février 2026 à 18:43 +0000, Conor Dooley a écrit :
If the bindings had been held instead of released early, the order would be what
is done in this patch for sure, and no one would have complained. These binding
have never been used by anyone so far, and what you are asking is to create a
DTS that deviate ... | {
"author": "Nicolas Dufresne <nicolas.dufresne@collabora.com>",
"date": "Thu, 26 Feb 2026 14:45:11 -0500",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | On Thu, Feb 26, 2026 at 02:45:11PM -0500, Nicolas Dufresne wrote:
20:35:32 conor /stuff/linux$ rg "rk3576-vdec"
arch/arm64/boot/dts/rockchip/rk3576.dtsi
1283: compatible = "rockchip,rk3576-vdec";
20:35:34 conor /stuff/linux$ rg rk3588-vdec
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
1357: compatible = "rockchi... | {
"author": "Conor Dooley <conor@kernel.org>",
"date": "Thu, 26 Feb 2026 20:59:08 +0000",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | Le jeudi 26 février 2026 à 20:59 +0000, Conor Dooley a écrit :
Right, let me add some context. rk3576.dtsi/rk3588-base.dtsi became a user of
the binding in 7.0-rc1, which is a pre-release. In fact, I initially thought the
bindings was merged at the same time, which Krzysztof highlighted as my mistake.
And the driver m... | {
"author": "Nicolas Dufresne <nicolas.dufresne@collabora.com>",
"date": "Thu, 26 Feb 2026 16:56:30 -0500",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | On Thu, Feb 26, 2026 at 04:56:30PM -0500, Nicolas Dufresne wrote:
Busy reading path of exile patch notes, so sniping this comment only...
This is a bug, not a supposition, and it's that snippet from the
driver that prompted my comment.. That code requires that if
->has_single_reg_region is set that the dts provides r... | {
"author": "Conor Dooley <conor@kernel.org>",
"date": "Thu, 26 Feb 2026 22:15:49 +0000",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | Le jeudi 26 février 2026 à 22:15 +0000, Conor Dooley a écrit :
Got it, to me nothing in the binding is intentional, just a big lack of
understanding what the syntax meant. So if we agree to make the binding enforce
having names for rk3576-vdec and rk3588-vdec (and keep RK33 and older the same),
It would make me more h... | {
"author": "Nicolas Dufresne <nicolas.dufresne@collabora.com>",
"date": "Thu, 26 Feb 2026 17:41:20 -0500",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | On Thu, Feb 26, 2026 at 10:15:49PM +0000, Conor Dooley wrote:
No, the opposite. With has_single_reg_region you take first entry and
ignore names.
Best regards,
Krzysztof | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 08:38:13 +0100",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | On Thu, Feb 26, 2026 at 06:43:31PM +0000, Conor Dooley wrote:
The description is indeed wrong. The binding properly describes new
hardware layout. They just don't like it.
Hardware has three separate address spaces and EXACT three correct
separate address spaces are described the binding.
There is "if" at the bott... | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 08:39:55 +0100",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | On Thu, Feb 26, 2026 at 12:46:53PM +0200, Cristian Ciocaltea wrote:
As you shown me last time with excerpt of address spaces from
datasheet/manual, the binding correctly describes the hardware and above
sentence is not true.
Imprecise wording. "start of the main or primary register range"
(if you have 0x1000 with o... | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 08:46:39 +0100",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | On Fri, Feb 27, 2026 at 08:38:13AM +0100, Krzysztof Kozlowski wrote:
Right, that's of course what I meant, I just a word ;) | {
"author": "Conor Dooley <conor@kernel.org>",
"date": "Fri, 27 Feb 2026 09:09:48 +0000",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | Hi Krzysztof, Conor,
On 2/27/26 9:46 AM, Krzysztof Kozlowski wrote:
Thanks for the additional feedback!
If I'm not mistaken (please correct me), the only remaining (hard)
blocker for the series would be to improve this commit message.
How about the following:
With the introduction of the RK3588 SoC, and RK3576... | {
"author": "Cristian Ciocaltea <cristian.ciocaltea@collabora.com>",
"date": "Fri, 27 Feb 2026 13:37:17 +0200",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | On 27/02/2026 12:37, Cristian Ciocaltea wrote:
Yes, it's fine. My comments were actually not blocking, I just wanted to
wait if discussion with Conor resolves somehow.
But for me anyway:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 14:03:30 +0100",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | With the introduction of the RK3588 SoC, and RK3576 afterwards, two more
register blocks have been provided for the video decoder unit.
However, the binding does not properly describe the new hardware layout,
as it breaks the convention expecting the unit address to indicate the
start of the first register range, i.e.... | null | null | null | [PATCH v4 1/3] media: dt-bindings: rockchip,vdec: Add alternative
reg-names order for RK35{76,88} | On Fri, Feb 27, 2026 at 01:37:17PM +0200, Cristian Ciocaltea wrote:
No, you also need to fix the problem I pointed out about reg-names being
optional on the devices you're relying on reg-names for. The new commit
message I am happy with, provided you also add the information Nicolas
provided about the impact on users. | {
"author": "Conor Dooley <conor@kernel.org>",
"date": "Fri, 27 Feb 2026 17:13:58 +0000",
"is_openbsd": false,
"thread_id": "20260226-vdec-reg-order-rk3576-v4-0-b8d72dc75250@collabora.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | The MPAMSM_EL1 register determines the MPAM configuration for an SMCU. Add
the register definition.
Tested-by: Gavin Shan <gshan@redhat.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter Newman <peternewman@google.com>
Tested-by: Zeng Heng <zengheng4@huawei.com>
Reviewed-by: Shaopeng Tan <tan.... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:40 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | When kvm enables or disables MPAM traps to EL2 it clears all other bits in
MPAM2_EL2. Notably, it clears the partition ids (PARTIDs) and performance
monitoring groups (PMGs). Avoid changing these bits in anticipation of
adding support for MPAM in the kernel. Otherwise, on a VHE system with the
host running at EL2 wher... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:41 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | The MPAMSM_EL1 controls the MPAM labeling for an SMCU, Streaming Mode
Compute Unit. As there is on MPAM support in kvm, make sure MPAMSM_EL1
accesses trigger an UNDEF.
Tested-by: Gavin Shan <gshan@redhat.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter Newman <peternewman@google.com>
Tested-... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:42 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
MPAM allows traffic in the SoC to be labeled by the OS, these labels are
used to apply policy in caches and bandwidth regulators, and to monitor
traffic in the SoC. The label is made up of a PARTID and PMG value. The x86
equivalent calls these CLOSID and RMID, but they don't map... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:43 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | In anticipation of MPAM being useful remove the CONFIG_EXPERT restriction.
Tested-by: Zeng Heng <zengheng4@huawei.com>
Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Ben Horgan <ben.h... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:45 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
Now that the MPAM system registers are expected to have values that change,
reprogram them based on the previous value when a CPU is brought online.
Previously MPAM's 'default PARTID' of 0 was always used for MPAM in
kernel-space as this is the PARTID that hardware guarantees t... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:44 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
Requestors need to populate the MPAM fields for any traffic they send on
the interconnect. For the CPUs these values are taken from the
corresponding MPAMy_ELx register. Each requestor may have a limit on the
largest PARTID or PMG value that can be used. The MPAM driver has to
d... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:46 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
The MPAM system registers will be lost if the CPU is reset during PSCI's
CPU_SUSPEND.
Add a PM notifier to restore them.
mpam_thread_switch(current) can't be used as this won't make any changes if
the in-memory copy says the register already has the correct value. In
reality t... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:47 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | The MPAMSM_EL1 sets the MPAM labels, PMG and PARTID, for loads and stores
generated by a shared SMCU. Disable the traps so the kernel can use it and
set it to the same configuration as the per-EL cpu MPAM configuration.
If an SMCU is not shared with other cpus then it is implementation
defined whether the configuratio... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:48 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
Care must be taken when modifying the PARTID and PMG of a task in any
per-task structure as writing these values may race with the task being
scheduled in, and reading the modified values.
Add helpers to set the task properties, and the CPU default value. These
use WRITE_ONCE(... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:49 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | On nVHE systems whether or not MPAM is enabled, EL2 continues to use
partid-0 for hypercalls, even when the host may have configured its kernel
threads to use a different partid. 0 may have been assigned to another
task. Copy the EL1 MPAM register to EL2. This ensures hypercalls use the
same partid as the kernel thread... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:51 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
While we trap the guest's attempts to read/write the MPAM control
registers, the hardware continues to use them. Guest-EL0 uses KVM's
user-space's configuration, as the value is left in the register, and
guest-EL1 uses either the host kernel's configuration, or in the case of
VH... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:50 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
Systems with MPAM support may have a variety of control types at any point
of their system layout. We can only expose certain types of control, and
only if they exist at particular locations.
Start with the well-known caches. These have to be depth 2 or 3 and support
MPAM's cac... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:53 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
We already have a helper for resetting an mpam class and component. Hook
it up to resctrl_arch_reset_all_ctrls() and the domain offline path.
Tested-by: Gavin Shan <gshan@redhat.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter Newman <peternewman@goo... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:54 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
resctrl has its own data structures to describe its resources. We can't use
these directly as we play tricks with the 'MBA' resource, picking the MPAM
controls or monitors that best apply. We may export the same component as
both L3 and MBA.
Add mpam_resctrl_res[] as the array ... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:52 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
Implement resctrl_arch_get_config() by testing the live configuration for a
CPOR bitmap. For any other configuration type return the default.
Tested-by: Gavin Shan <gshan@redhat.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter Newman <peternewman@goog... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:55 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
arm64 provides helpers for changing a task's and a cpu's mpam partid/pmg
values.
These are used to back a number of resctrl_arch_ functions. Connect them
up.
Tested-by: Gavin Shan <gshan@redhat.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter Newman ... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:57 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
resctrl has two helpers for updating the configuration.
resctrl_arch_update_one() updates a single value, and is used by the
software-controller to apply feedback to the bandwidth controls, it has to
be called on one of the CPUs in the resctrl:domain.
resctrl_arch_update_domain... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:56 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
Intel RDT's CDP feature allows the cache to use a different control value
depending on whether the accesses was for instruction fetch or a data
access. MPAM's equivalent feature is the other way up: the CPU assigns a
different partid label to traffic depending on whether it was ... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:58 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: Dave Martin <Dave.Martin@arm.com>
MPAM uses a fixed-point formats for some hardware controls. Resctrl
provides the bandwidth controls as a percentage. Add helpers to convert
between these.
Ensure bwa_wd is at most 16 to make it clear higher values have no meaning.
Tested-by: Gavin Shan <gshan@redhat.com>
Test... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:56:59 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: Dave Martin <Dave.Martin@arm.com>
resctrl specifies the format of the control schemes, and these don't match
the hardware.
Some of the conversions are a bit hairy - add some kunit tests.
Tested-by: Gavin Shan <gshan@redhat.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter Newman <pete... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:00 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | As MPAM's pmg are scoped by partid and RDT's rmid are global the
rescrl mapping to an index needs to differ.
Add some tests for the MPAM rmid mapping.
Tested-by: Gavin Shan <gshan@redhat.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter Newman <peternewman@google.com>
Tested-by: Zeng Heng <z... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:02 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | In order to calculate the rmid realloc threshold the size of the cache
needs to be known. Cache domains will also be named after the cache id. So
that this information can be extracted from cacheinfo we need to wait for
it to be ready. The cacheinfo information is populated in device_initcall()
so we wait for that.
Te... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:03 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | Because MPAM's pmg aren't identical to RDT's rmid, resctrl handles some
data structures by index. This allows x86 to map indexes to RMID, and MPAM
to map them to partid-and-pmg.
Add the helpers to do this.
Tested-by: Gavin Shan <gshan@redhat.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter ... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:01 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
resctrl supports 'MB', as a percentage throttling of traffic from the
L3. This is the control that mba_sc uses, so ideally the class chosen
should be as close as possible to the counters used for mbm_total. If
there is a single L3 and the topology of the memory matches then the
... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:04 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | Add the boilerplate that tells resctrl about the mpam monitors that are
available. resctrl expects all (non-telemetry) monitors to be on the L3 and
so advertise them there and invent an L3 resctrl resource if required. The
L3 cache itself has to exist as the cache ids are used as the domain
ids.
Bring the resctrl moni... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:05 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
resctrl exposes a counter via a file named llc_occupancy. This isn't really
a counter as its value goes up and down, this is a snapshot of the cache
storage usage monitor.
Add some picking code which will only find an L3. The resctrl counter
file is called llc_occupancy but we ... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:06 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
resctrl has two types of counters, NUMA-local and global. MPAM can only
count global either using MSC at the L3 cache or in the memory controllers.
When global and local equate to the same thing continue just to call it
global.
Because the class or component backing the event m... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:07 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
When there are enough monitors, the resctrl mbm local and total files can
be exposed. These need all the monitors that resctrl may use to be
allocated up front.
Add helpers to do this.
If a different candidate class is discovered, the old array should be
free'd and the allocat... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:08 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
When resctrl wants to read a domain's 'QOS_L3_OCCUP', it needs to allocate
a monitor on the corresponding resource. Monitors are allocated by class
instead of component.
If there are enough MBM monitors, they will be pre-allocated and
free-running.
Add helpers to allocate a CS... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:09 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
resctrl uses resctrl_arch_rmid_read() to read counters. CDP emulation means
the counter may need reading in three different ways. The same goes for
reset.
The helpers behind the resctrl_arch_ functions will be re-used for the ABMC
equivalent functions.
Add the rounding helper ... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:10 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
resctrl's limbo code needs to be told when the data left in a cache is
small enough for the partid+pmg value to be re-allocated.
x86 uses the cache size divided by the number of rmid users the cache may
have. Do the same, but for the smallest cache, and with the number of
parti... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:11 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
A few resctrl features and hooks need to be provided, but aren't needed or
supported on MPAM platforms.
resctrl has individual hooks to separately enable and disable the
closid/partid and rmid/pmg context switching code. For MPAM this is all the
same thing, as the value in stru... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:12 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
Enough MPAM support is present to enable ARCH_HAS_CPU_RESCTRL. Let it
rip^Wlink!
ARCH_HAS_CPU_RESCTRL indicates resctrl can be enabled. It is enabled by the
arch code simply because it has 'arch' in its name.
This removes ARM_CPU_RESCTRL as a mimic of X86_CPU_RESCTRL. While ... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:13 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
Now that MPAM links against resctrl, call resctrl_init() to register the
filesystem and setup resctrl's structures.
Tested-by: Gavin Shan <gshan@redhat.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Tested-by: Peter Newman <peternewman@google.com>
Tested-by: Zeng He... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:14 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: Shanker Donthineni <sdonthineni@nvidia.com>
The MPAM specification includes the MPAMF_IIDR, which serves to uniquely
identify the MSC implementation through a combination of implementer
details, product ID, variant, and revision. Certain hardware issues/errata
can be resolved using software workarounds.
Introdu... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:15 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: Shanker Donthineni <sdonthineni@nvidia.com>
The MPAM bandwidth partitioning controls will not be correctly configured,
and hardware will retain default configuration register values, meaning
generally that bandwidth will remain unprovisioned.
To address the issue, follow the below steps after updating the MBW_M... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:16 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: Shanker Donthineni <sdonthineni@nvidia.com>
In the T241 implementation of memory-bandwidth partitioning, in the absence
of contention for bandwidth, the minimum bandwidth setting can affect the
amount of achieved bandwidth. Specifically, the achieved bandwidth in the
absence of contention can settle to any value... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:17 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: Shanker Donthineni <sdonthineni@nvidia.com>
The registers MSMON_MBWU_L and MSMON_MBWU return the number of requests
rather than the number of bytes transferred.
Bandwidth resource monitoring is performed at the last level cache, where
each request arrive in 64Byte granularity. The current implementation
returns... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:18 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | From: James Morse <james.morse@arm.com>
CMN-650 is afflicted with an erratum where the CSU NRDY bit never clears.
This tells us the monitor never finishes scanning the cache. The erratum
document says to wait the maximum time, then ignore the field.
Add a flag to indicate whether this is the final attempt to read the... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:19 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | MPAM (Memory Partitioning and Monitoring) is now exposed to user-space via
resctrl. Add some documentation so the user knows what features to expect.
Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Signed-off-by: James Morse <james.morse@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-b... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Tue, 24 Feb 2026 17:57:20 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | On 2026/2/25 1:56, Ben Horgan wrote:
[...]
@ -245,6 +338,14 @@ u32 resctrl_arch_get_config(struct rdt_resource *r,
struct rdt_ctrl_domain *d,
Yes, I have observed that this issue had already been addressed in
resctrl_arch_get_config() before the mpam_resctrl_glue_v4 release.
Fix for resctrl_arch_update_one() has ... | {
"author": "Zeng Heng <zengheng4@huawei.com>",
"date": "Wed, 25 Feb 2026 14:25:44 +0800",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | On Tue, 24 Feb 2026 17:57:20 +0000
Ben Horgan <ben.horgan@arm.com> wrote:
LGTM
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> | {
"author": "Jonathan Cameron <jonathan.cameron@huawei.com>",
"date": "Wed, 25 Feb 2026 11:01:04 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | On Tue, 24 Feb 2026 17:56:54 +0000
Ben Horgan <ben.horgan@arm.com> wrote:
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> | {
"author": "Jonathan Cameron <jonathan.cameron@huawei.com>",
"date": "Wed, 25 Feb 2026 11:03:00 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | On Tue, 24 Feb 2026 17:57:05 +0000
Ben Horgan <ben.horgan@arm.com> wrote:
Just one trivial comment on short line wrap. I'm not that fussed though so
I don't mind if you only tidy that up if doing a v6.
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
...
Trivial but that's an oddly short wrap. Should... | {
"author": "Jonathan Cameron <jonathan.cameron@huawei.com>",
"date": "Wed, 25 Feb 2026 11:14:01 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | On 2/24/26 17:56, Ben Horgan wrote:
There is a small build conflict with resctrl abmc precursors, [1]. The
last patch of that series applies on top of this series and if the abmc
precursors go first that patch should go with this series to fix the
build. Alternatively, if it's obvious ahead of time it can be squashed
... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Wed, 25 Feb 2026 21:10:08 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | Hi Ben,
On 2026/2/25 1:56, Ben Horgan wrote:
I have completed retesting based on glue v5. The latest boot logs are
provided below:
# dmesg | grep -i mpam
[ 0.000000] ACPI: MPAM 0x000000007FF34018 003024 (v01 HISI HIP12
00000000 HISI 20151124)
[ 0.000000] Kernel command line:
BOOT_IMAGE=/vmlinuz-7.0.0-rc1... | {
"author": "Zeng Heng <zengheng4@huawei.com>",
"date": "Thu, 26 Feb 2026 15:34:26 +0800",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | Hi Zeng,
On 2/26/26 03:47, Zeng Heng wrote:
Thanks for reporting this bug. It looks to be because resctrl_arch_mon_capable() is telling us if
there is any mon capable resource when really what we want to know is if this resource is mon capable.
The pattern occurs in a few places. Does this diff help?
diff --git a/dr... | {
"author": "Ben Horgan <ben.horgan@arm.com>",
"date": "Thu, 26 Feb 2026 10:26:25 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | Hi Ben,
On 2026/2/26 18:26, Ben Horgan wrote:
I've adapted to the changes and local verification passes also.
Yes, using r->alloc_capable and r->mon_capable here is indeed more
accurate and appropriate. I should have noticed this when reviewing
resctrl_arch_alloc_capable() and resctrl_arch_mon_capable().
Reviewed-... | {
"author": "Zeng Heng <zengheng4@huawei.com>",
"date": "Fri, 27 Feb 2026 11:01:54 +0800",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The main change in this version of the mpam missing pieces series is to
update the cdp emulation to match the resctrl interface. L2 and L3
resources can now enable cdp separately. Cdp can't be hidden correctly for
memory bandwidth allocation, as max per partid can't be emulated with more
partids, and so we hide this co... | null | null | null | [PATCH v5 00/41] arm_mpam: Add KVM/arm64 and resctrl glue code | On Wed, Feb 25, 2026 at 09:10:08PM +0000, Ben Horgan wrote:
Typically we resolve these by having the first three patches in the
above series on a stable branch (could be tip as it touches x86) and we
can base the 41 patches here on top, together with the last one from the
abmc series.
Alternatively, happy to take the... | {
"author": "Catalin Marinas <catalin.marinas@arm.com>",
"date": "Fri, 27 Feb 2026 17:04:01 +0000",
"is_openbsd": false,
"thread_id": "aaHOgZFWnjMHNirr@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | Hi all,
The kernel enabled '-fms-extensions' in commit c4781dc3d1cf ("Kbuild:
enable -fms-extensions") in 6.19 to gain access to a Microsoft
(originally Plan 9) extension around including a tagged structure/union
anonymously in an other structure/union. Since then, Clang 23.0.0
(current main) has added a flag to enabl... | null | null | null | [PATCH 0/2] kbuild: Switch from '-fms-extensions' to
'-fms-anonymous-structs' when available | Introduce CC_FLAGS_DIALECT to make it easier to update the various
places in the tree that rely on the GNU C standard and Microsoft
extensions flags atomically. All remaining uses of '-std=gnu11' and
'-fms-extensions' are in the tools directory (which has its own build
system) and other standalone Makefiles. This will ... | {
"author": "Nathan Chancellor <nathan@kernel.org>",
"date": "Mon, 23 Feb 2026 12:10:28 -0700",
"is_openbsd": false,
"thread_id": "aaHIEQPiAbd7DGlW@derry.ads.avm.de.mbox.gz"
} |
lkml_critique | linux-arm-kernel | Hi all,
The kernel enabled '-fms-extensions' in commit c4781dc3d1cf ("Kbuild:
enable -fms-extensions") in 6.19 to gain access to a Microsoft
(originally Plan 9) extension around including a tagged structure/union
anonymously in an other structure/union. Since then, Clang 23.0.0
(current main) has added a flag to enabl... | null | null | null | [PATCH 0/2] kbuild: Switch from '-fms-extensions' to
'-fms-anonymous-structs' when available | Clang recently added '-fms-anonymous-structs' [1] to specifically enable
the Microsoft tagged anonymous structure / union extension, for which
the kernel added '-fms-extensions' in commit c4781dc3d1cf ("Kbuild:
enable -fms-extensions"). Switch to this more narrow option if it is
available, which would have helped avoid... | {
"author": "Nathan Chancellor <nathan@kernel.org>",
"date": "Mon, 23 Feb 2026 12:10:29 -0700",
"is_openbsd": false,
"thread_id": "aaHIEQPiAbd7DGlW@derry.ads.avm.de.mbox.gz"
} |
lkml_critique | linux-arm-kernel | Hi all,
The kernel enabled '-fms-extensions' in commit c4781dc3d1cf ("Kbuild:
enable -fms-extensions") in 6.19 to gain access to a Microsoft
(originally Plan 9) extension around including a tagged structure/union
anonymously in an other structure/union. Since then, Clang 23.0.0
(current main) has added a flag to enabl... | null | null | null | [PATCH 0/2] kbuild: Switch from '-fms-extensions' to
'-fms-anonymous-structs' when available | On 2/23/26 20:38, Ard Biesheuvel wrote:
For the series:
Acked-by: Helge Deller <deller@gmx.de> # parisc
Thanks!
Helge | {
"author": "Helge Deller <deller@gmx.de>",
"date": "Mon, 23 Feb 2026 22:13:10 +0100",
"is_openbsd": false,
"thread_id": "aaHIEQPiAbd7DGlW@derry.ads.avm.de.mbox.gz"
} |
lkml_critique | linux-arm-kernel | Hi all,
The kernel enabled '-fms-extensions' in commit c4781dc3d1cf ("Kbuild:
enable -fms-extensions") in 6.19 to gain access to a Microsoft
(originally Plan 9) extension around including a tagged structure/union
anonymously in an other structure/union. Since then, Clang 23.0.0
(current main) has added a flag to enabl... | null | null | null | [PATCH 0/2] kbuild: Switch from '-fms-extensions' to
'-fms-anonymous-structs' when available | On Mon, Feb 23, 2026 at 12:10:29PM -0700, Nathan Chancellor wrote:
Series looks good to me. One style question, why go the round-trip with
Kconfig instead of doing it all with a fallback in the Makefile:
CC_FLAGS_DIALECT += $(call cc-option,-fms-anonymous-structs,-fms-extensions)
--
Kees Cook | {
"author": "Kees Cook <kees@kernel.org>",
"date": "Mon, 23 Feb 2026 14:33:35 -0800",
"is_openbsd": false,
"thread_id": "aaHIEQPiAbd7DGlW@derry.ads.avm.de.mbox.gz"
} |
lkml_critique | linux-arm-kernel | Hi all,
The kernel enabled '-fms-extensions' in commit c4781dc3d1cf ("Kbuild:
enable -fms-extensions") in 6.19 to gain access to a Microsoft
(originally Plan 9) extension around including a tagged structure/union
anonymously in an other structure/union. Since then, Clang 23.0.0
(current main) has added a flag to enabl... | null | null | null | [PATCH 0/2] kbuild: Switch from '-fms-extensions' to
'-fms-anonymous-structs' when available | On Mon, Feb 23, 2026 at 02:33:35PM -0800, Kees Cook wrote:
I might be misunderstanding how Kbuild works but
arch/$(SRCARCH)/Makefile may have logic for selecting CROSS_COMPILE,
which can impact the selection of $(CC), so I cannot use cc-option prior
to its inclusion but I need CC_FLAGS_DIALECT to be included before
ar... | {
"author": "Nathan Chancellor <nathan@kernel.org>",
"date": "Mon, 23 Feb 2026 15:53:11 -0700",
"is_openbsd": false,
"thread_id": "aaHIEQPiAbd7DGlW@derry.ads.avm.de.mbox.gz"
} |
lkml_critique | linux-arm-kernel | Hi all,
The kernel enabled '-fms-extensions' in commit c4781dc3d1cf ("Kbuild:
enable -fms-extensions") in 6.19 to gain access to a Microsoft
(originally Plan 9) extension around including a tagged structure/union
anonymously in an other structure/union. Since then, Clang 23.0.0
(current main) has added a flag to enabl... | null | null | null | [PATCH 0/2] kbuild: Switch from '-fms-extensions' to
'-fms-anonymous-structs' when available | On Mon, Feb 23, 2026 at 03:53:11PM -0700, Nathan Chancellor wrote:
Will Kconfig see a different CC than Makefile? Regardless, I trust your
judgement here! I actually rather prefer having it exposed via Kconfig.
:)
Reviewed-by: Kees Cook <kees@kernel.org>
-Kees
--
Kees Cook | {
"author": "Kees Cook <kees@kernel.org>",
"date": "Mon, 23 Feb 2026 15:02:32 -0800",
"is_openbsd": false,
"thread_id": "aaHIEQPiAbd7DGlW@derry.ads.avm.de.mbox.gz"
} |
lkml_critique | linux-arm-kernel | Hi all,
The kernel enabled '-fms-extensions' in commit c4781dc3d1cf ("Kbuild:
enable -fms-extensions") in 6.19 to gain access to a Microsoft
(originally Plan 9) extension around including a tagged structure/union
anonymously in an other structure/union. Since then, Clang 23.0.0
(current main) has added a flag to enabl... | null | null | null | [PATCH 0/2] kbuild: Switch from '-fms-extensions' to
'-fms-anonymous-structs' when available | On Mon, Feb 23, 2026 at 03:02:32PM -0800, Kees Cook wrote:
It shouldn't, as arch/$(SRCARCH)/Makefile is included before invoking
Kconfig; if the compiler changes, Kconfig will run again before
building.
Thanks!
Nathan | {
"author": "Nathan Chancellor <nathan@kernel.org>",
"date": "Tue, 24 Feb 2026 13:55:29 -0700",
"is_openbsd": false,
"thread_id": "aaHIEQPiAbd7DGlW@derry.ads.avm.de.mbox.gz"
} |
lkml_critique | linux-arm-kernel | Hi all,
The kernel enabled '-fms-extensions' in commit c4781dc3d1cf ("Kbuild:
enable -fms-extensions") in 6.19 to gain access to a Microsoft
(originally Plan 9) extension around including a tagged structure/union
anonymously in an other structure/union. Since then, Clang 23.0.0
(current main) has added a flag to enabl... | null | null | null | [PATCH 0/2] kbuild: Switch from '-fms-extensions' to
'-fms-anonymous-structs' when available | On Mon, Feb 23, 2026 at 12:10:28PM -0700, Nathan Chancellor wrote:
Reviewed-by: Nicolas Schier <nsc@kernel.org> | {
"author": "Nicolas Schier <nsc@kernel.org>",
"date": "Fri, 27 Feb 2026 17:36:33 +0100",
"is_openbsd": false,
"thread_id": "aaHIEQPiAbd7DGlW@derry.ads.avm.de.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The DT‑binding patch adds platform‑specific compatibles for the
CTCU device, and the following Qualcomm platforms are included:
Kaanapali
Pakala(sm8750)
Hamoa(x1e80100)
Glymur
Since the base Coresight DT patches for the Kaanapali and Glymur
platforms have not yet been applied, I created DT patches only
for the Pakala ... | null | null | null | [PATCH v3 0/3] Enable CTCU and ETR devices for multiple QCOM
platforms | Document the platforms that fallback to using the qcom,sa8775p-ctcu
compatible for probing.
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
---
Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-... | {
"author": "Jie Gan <jie.gan@oss.qualcomm.com>",
"date": "Wed, 04 Feb 2026 10:22:01 +0800",
"is_openbsd": false,
"thread_id": "38fc2905-aa89-4b9d-8ad0-c289642899f0@oss.qualcomm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The DT‑binding patch adds platform‑specific compatibles for the
CTCU device, and the following Qualcomm platforms are included:
Kaanapali
Pakala(sm8750)
Hamoa(x1e80100)
Glymur
Since the base Coresight DT patches for the Kaanapali and Glymur
platforms have not yet been applied, I created DT patches only
for the Pakala ... | null | null | null | [PATCH v3 0/3] Enable CTCU and ETR devices for multiple QCOM
platforms | Embedded Trace Router(ETR) is working as a DDR memory sink to collect
tracing data from source device.
The CTCU serves as the control unit for the ETR device, managing its
behavior to determine how trace data is collected.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Jie Gan <jie.gan@oss... | {
"author": "Jie Gan <jie.gan@oss.qualcomm.com>",
"date": "Wed, 04 Feb 2026 10:22:02 +0800",
"is_openbsd": false,
"thread_id": "38fc2905-aa89-4b9d-8ad0-c289642899f0@oss.qualcomm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The DT‑binding patch adds platform‑specific compatibles for the
CTCU device, and the following Qualcomm platforms are included:
Kaanapali
Pakala(sm8750)
Hamoa(x1e80100)
Glymur
Since the base Coresight DT patches for the Kaanapali and Glymur
platforms have not yet been applied, I created DT patches only
for the Pakala ... | null | null | null | [PATCH v3 0/3] Enable CTCU and ETR devices for multiple QCOM
platforms | Embedded Trace Router(ETR) is working as a DDR memory sink to collect
tracing data from source device and the CTCU device serves as the
control unit for the ETR device.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8750.dts... | {
"author": "Jie Gan <jie.gan@oss.qualcomm.com>",
"date": "Wed, 04 Feb 2026 10:22:03 +0800",
"is_openbsd": false,
"thread_id": "38fc2905-aa89-4b9d-8ad0-c289642899f0@oss.qualcomm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The DT‑binding patch adds platform‑specific compatibles for the
CTCU device, and the following Qualcomm platforms are included:
Kaanapali
Pakala(sm8750)
Hamoa(x1e80100)
Glymur
Since the base Coresight DT patches for the Kaanapali and Glymur
platforms have not yet been applied, I created DT patches only
for the Pakala ... | null | null | null | [PATCH v3 0/3] Enable CTCU and ETR devices for multiple QCOM
platforms | On Wed, Feb 04, 2026 at 10:22:01AM +0800, Jie Gan wrote:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Thu, 5 Feb 2026 12:50:56 +0100",
"is_openbsd": false,
"thread_id": "38fc2905-aa89-4b9d-8ad0-c289642899f0@oss.qualcomm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The DT‑binding patch adds platform‑specific compatibles for the
CTCU device, and the following Qualcomm platforms are included:
Kaanapali
Pakala(sm8750)
Hamoa(x1e80100)
Glymur
Since the base Coresight DT patches for the Kaanapali and Glymur
platforms have not yet been applied, I created DT patches only
for the Pakala ... | null | null | null | [PATCH v3 0/3] Enable CTCU and ETR devices for multiple QCOM
platforms | Hello,
On 04/02/2026 02:22, Jie Gan wrote:
Given this is predominantly DTS changes, and there is very low chances
of a conflict with the binding yaml change, I would recommend this to go
via soc or the qcom platform tree.
For the series:
Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> | {
"author": "Suzuki K Poulose <suzuki.poulose@arm.com>",
"date": "Fri, 27 Feb 2026 10:10:50 +0000",
"is_openbsd": false,
"thread_id": "38fc2905-aa89-4b9d-8ad0-c289642899f0@oss.qualcomm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | bcm2835_reset_status() has a misplaced parenthesis on every PM_READ()
call. Since PM_READ(reg) expands to readl(power->base + (reg)), the
expression:
PM_READ(PM_GRAFX & PM_V3DRSTN)
computes the bitwise AND of the register offset PM_GRAFX with the
bitmask PM_V3DRSTN before using the result as a register offset, re... | null | null | null | [PATCH] pmdomain: bcm: bcm2835-power: Fix broken reset status read | Hi Maíra,
Am 12.02.26 um 15:49 schrieb Maíra Canal:
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Nice catch
I'm fine with the patch.
Best regards | {
"author": "Stefan Wahren <wahrenst@gmx.net>",
"date": "Thu, 12 Feb 2026 20:06:05 +0100",
"is_openbsd": false,
"thread_id": "CAPDyKFpT6m4N9AWSMO2VKm1M3n22Ye9+i-t7QT-JtTtB6kfuFA@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | bcm2835_reset_status() has a misplaced parenthesis on every PM_READ()
call. Since PM_READ(reg) expands to readl(power->base + (reg)), the
expression:
PM_READ(PM_GRAFX & PM_V3DRSTN)
computes the bitwise AND of the register offset PM_GRAFX with the
bitmask PM_V3DRSTN before using the result as a register offset, re... | null | null | null | [PATCH] pmdomain: bcm: bcm2835-power: Fix broken reset status read | On 2/12/26 06:49, Maíra Canal wrote:
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian | {
"author": "Florian Fainelli <florian.fainelli@broadcom.com>",
"date": "Thu, 12 Feb 2026 11:11:43 -0800",
"is_openbsd": false,
"thread_id": "CAPDyKFpT6m4N9AWSMO2VKm1M3n22Ye9+i-t7QT-JtTtB6kfuFA@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | bcm2835_reset_status() has a misplaced parenthesis on every PM_READ()
call. Since PM_READ(reg) expands to readl(power->base + (reg)), the
expression:
PM_READ(PM_GRAFX & PM_V3DRSTN)
computes the bitwise AND of the register offset PM_GRAFX with the
bitmask PM_V3DRSTN before using the result as a register offset, re... | null | null | null | [PATCH] pmdomain: bcm: bcm2835-power: Fix broken reset status read | Hi Ulf,
Friendly ping on this patch. Could you take a look at it when you get a
chance? Florian and Stefan already reviewed it a couple of weeks ago and
it would be great to have it picked.
Best regards,
- Maíra
On 12/02/26 11:49, Maíra Canal wrote: | {
"author": "=?UTF-8?Q?Ma=C3=ADra_Canal?= <mcanal@igalia.com>",
"date": "Wed, 25 Feb 2026 11:11:29 -0300",
"is_openbsd": false,
"thread_id": "CAPDyKFpT6m4N9AWSMO2VKm1M3n22Ye9+i-t7QT-JtTtB6kfuFA@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | bcm2835_reset_status() has a misplaced parenthesis on every PM_READ()
call. Since PM_READ(reg) expands to readl(power->base + (reg)), the
expression:
PM_READ(PM_GRAFX & PM_V3DRSTN)
computes the bitwise AND of the register offset PM_GRAFX with the
bitmask PM_V3DRSTN before using the result as a register offset, re... | null | null | null | [PATCH] pmdomain: bcm: bcm2835-power: Fix broken reset status read | On Thu, 12 Feb 2026 at 16:02, Maíra Canal <mcanal@igalia.com> wrote:
Applied fixes and added a stable tag, thanks!
Kind regards
Uffe | {
"author": "Ulf Hansson <ulf.hansson@linaro.org>",
"date": "Fri, 27 Feb 2026 18:11:34 +0100",
"is_openbsd": false,
"thread_id": "CAPDyKFpT6m4N9AWSMO2VKm1M3n22Ye9+i-t7QT-JtTtB6kfuFA@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The CPU power management issue in the CTI driver was first observed in
series [1]; this series resolves that issue. It fixes bugs and removes
CPU PM operations from the CoreSight CTI driver, the goal is to use the
CoreSight core layer as the central place for CPU power management.
Removing CPU PM from CTI driver can a... | null | null | null | [PATCH v2 0/8] coresight: cti: Miscellaneous fixes and CPU PM
cleanup | The spinlock is acquired sometimes with IRQs disabled and sometimes
without. This leads to inconsistent semantics: the lock can be either
HARDIRQ-safe or HARDIRQ-unsafe, which may trigger lockdep complaints.
Make spinlock usage consistent by acquiring it with disabling IRQs. It
is possible for sysfs knobs to acquire... | {
"author": "Leo Yan <leo.yan@arm.com>",
"date": "Thu, 26 Feb 2026 09:23:49 +0000",
"is_openbsd": false,
"thread_id": "20260226-arm_coresight_cti_refactor_v1-v2-0-b30fada3cfec@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The CPU power management issue in the CTI driver was first observed in
series [1]; this series resolves that issue. It fixes bugs and removes
CPU PM operations from the CoreSight CTI driver, the goal is to use the
CoreSight core layer as the central place for CPU power management.
Removing CPU PM from CTI driver can a... | null | null | null | [PATCH v2 0/8] coresight: cti: Miscellaneous fixes and CPU PM
cleanup | Introduce cti_read_single_reg() as an interface for reading registers
with unlocking the CS lock. Consolidate register read in sysfs
interfaces using this new helper.
Fixes: b5213376c240 ("coresight: cti: Add sysfs access to program function registers")
Fixes: 1a556ca6cc24 ("coresight: cti: Add sysfs coresight mgmt r... | {
"author": "Leo Yan <leo.yan@arm.com>",
"date": "Thu, 26 Feb 2026 09:23:50 +0000",
"is_openbsd": false,
"thread_id": "20260226-arm_coresight_cti_refactor_v1-v2-0-b30fada3cfec@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The CPU power management issue in the CTI driver was first observed in
series [1]; this series resolves that issue. It fixes bugs and removes
CPU PM operations from the CoreSight CTI driver, the goal is to use the
CoreSight core layer as the central place for CPU power management.
Removing CPU PM from CTI driver can a... | null | null | null | [PATCH v2 0/8] coresight: cti: Miscellaneous fixes and CPU PM
cleanup | According to the Arm ARM (DDI 0487 L.b), ASICCTL is implemented only
when CTIDEVID.EXTMUXNUM is non-zero.
Based on CTIDEVID.EXTMUXNUM, add a flag 'asicctl_impl' to indicate
whether the register is implemented, and access ASICCTL conditionally
based on the flag.
Allow the sysfs node to be visible only when the registe... | {
"author": "Leo Yan <leo.yan@arm.com>",
"date": "Thu, 26 Feb 2026 09:23:51 +0000",
"is_openbsd": false,
"thread_id": "20260226-arm_coresight_cti_refactor_v1-v2-0-b30fada3cfec@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The CPU power management issue in the CTI driver was first observed in
series [1]; this series resolves that issue. It fixes bugs and removes
CPU PM operations from the CoreSight CTI driver, the goal is to use the
CoreSight core layer as the central place for CPU power management.
Removing CPU PM from CTI driver can a... | null | null | null | [PATCH v2 0/8] coresight: cti: Miscellaneous fixes and CPU PM
cleanup | According Arm ARM, the CTI ASICCTL register:
"It is IMPLEMENTATION DEFINED whether ASICCTL is implemented in the
Core power domain or in the Debug power domain."
This is the only CTI register that may reside in the core power domain.
However, it has been confirmed that Arm designed CTIs place ASICCTL in
the debu... | {
"author": "Leo Yan <leo.yan@arm.com>",
"date": "Thu, 26 Feb 2026 09:23:52 +0000",
"is_openbsd": false,
"thread_id": "20260226-arm_coresight_cti_refactor_v1-v2-0-b30fada3cfec@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The CPU power management issue in the CTI driver was first observed in
series [1]; this series resolves that issue. It fixes bugs and removes
CPU PM operations from the CoreSight CTI driver, the goal is to use the
CoreSight core layer as the central place for CPU power management.
Removing CPU PM from CTI driver can a... | null | null | null | [PATCH v2 0/8] coresight: cti: Miscellaneous fixes and CPU PM
cleanup | Rename cti_active() to cti_is_active() to clarify that it checks whether
the CTI device is active.
Reviewed-by: Mike Leach <mike.leach@arm.com>
Signed-off-by: Leo Yan <leo.yan@arm.com>
---
drivers/hwtracing/coresight/coresight-cti-core.c | 8 ++++----
drivers/hwtracing/coresight/coresight-cti-sysfs.c | 14 +++++++--... | {
"author": "Leo Yan <leo.yan@arm.com>",
"date": "Thu, 26 Feb 2026 09:23:53 +0000",
"is_openbsd": false,
"thread_id": "20260226-arm_coresight_cti_refactor_v1-v2-0-b30fada3cfec@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The CPU power management issue in the CTI driver was first observed in
series [1]; this series resolves that issue. It fixes bugs and removes
CPU PM operations from the CoreSight CTI driver, the goal is to use the
CoreSight core layer as the central place for CPU power management.
Removing CPU PM from CTI driver can a... | null | null | null | [PATCH v2 0/8] coresight: cti: Miscellaneous fixes and CPU PM
cleanup | The enable_req_count field already tracks whether the CTI device is
enabled. A non-zero value indicates that the device is active, the
hw_enabled flag is redundant if so.
Remove hw_enabled and update cti_is_active() to check enable_req_count.
Replace open-coded enable_req_count checks with cti_is_active().
Reviewed-... | {
"author": "Leo Yan <leo.yan@arm.com>",
"date": "Thu, 26 Feb 2026 09:23:55 +0000",
"is_openbsd": false,
"thread_id": "20260226-arm_coresight_cti_refactor_v1-v2-0-b30fada3cfec@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The CPU power management issue in the CTI driver was first observed in
series [1]; this series resolves that issue. It fixes bugs and removes
CPU PM operations from the CoreSight CTI driver, the goal is to use the
CoreSight core layer as the central place for CPU power management.
Removing CPU PM from CTI driver can a... | null | null | null | [PATCH v2 0/8] coresight: cti: Miscellaneous fixes and CPU PM
cleanup | Return an error when the offset is negative.
Signed-off-by: Leo Yan <leo.yan@arm.com>
---
drivers/hwtracing/coresight/coresight-cti-sysfs.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs... | {
"author": "Leo Yan <leo.yan@arm.com>",
"date": "Thu, 26 Feb 2026 09:23:56 +0000",
"is_openbsd": false,
"thread_id": "20260226-arm_coresight_cti_refactor_v1-v2-0-b30fada3cfec@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The CPU power management issue in the CTI driver was first observed in
series [1]; this series resolves that issue. It fixes bugs and removes
CPU PM operations from the CoreSight CTI driver, the goal is to use the
CoreSight core layer as the central place for CPU power management.
Removing CPU PM from CTI driver can a... | null | null | null | [PATCH v2 0/8] coresight: cti: Miscellaneous fixes and CPU PM
cleanup | Since the CPU PM code has been removed from the CTI driver and the device
is enabled via runtime PM, pm_runtime_active() can be used to check
whether the device is powered.
As a result, the hw_powered flag is redundant, remove it.
Reviewed-by: Mike Leach <mike.leach@arm.com>
Signed-off-by: Leo Yan <leo.yan@arm.com>
-... | {
"author": "Leo Yan <leo.yan@arm.com>",
"date": "Thu, 26 Feb 2026 09:23:54 +0000",
"is_openbsd": false,
"thread_id": "20260226-arm_coresight_cti_refactor_v1-v2-0-b30fada3cfec@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | The CPU power management issue in the CTI driver was first observed in
series [1]; this series resolves that issue. It fixes bugs and removes
CPU PM operations from the CoreSight CTI driver, the goal is to use the
CoreSight core layer as the central place for CPU power management.
Removing CPU PM from CTI driver can a... | null | null | null | [PATCH v2 0/8] coresight: cti: Miscellaneous fixes and CPU PM
cleanup | Hi Leo,
On 2/26/26 09:23, Leo Yan wrote:
Given that at this point the code is only called via macro, which
hardcodes the offsets. don't think the check will ever return the error.
But in case usage changes in future this is safe. so..
Reviewed-by: Mike Leach <mike.leach@Arm.com> | {
"author": "Mike Leach <mike.leach@arm.com>",
"date": "Fri, 27 Feb 2026 11:34:15 +0000",
"is_openbsd": false,
"thread_id": "20260226-arm_coresight_cti_refactor_v1-v2-0-b30fada3cfec@arm.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The stmmac driver contains similar pattern for processing queue-based
arrays, ie. interrupt lines, etc. Factor out the for loop and provide
a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
drivers/net/ethe... | null | null | null | [PATCH v7 1/5] net: stmmac: Use helper macro for loop over
queue-based arrays | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
Read IRQ resources for all rx/tx channels, to allow Multi-IRQ mode
for platform glue drivers.
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
.../net/ethernet/stmicro/stmmac/stmmac_platform.c | 46 ++... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:07 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The stmmac driver contains similar pattern for processing queue-based
arrays, ie. interrupt lines, etc. Factor out the for loop and provide
a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
drivers/net/ethe... | null | null | null | [PATCH v7 1/5] net: stmmac: Use helper macro for loop over
queue-based arrays | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
Based on previous changes in platform driver, the vendor
glue driver can enable Multi-IRQ mode, if needed.
To get enabled Multi-IRQ mode for dwmac-s32, the driver checks:
1) property of 'snps,mtl-xx-config' subnode
defines 'snps,xx-queues-to-use' bigger then... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:10 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The stmmac driver contains similar pattern for processing queue-based
arrays, ie. interrupt lines, etc. Factor out the for loop and provide
a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
drivers/net/ethe... | null | null | null | [PATCH v7 1/5] net: stmmac: Use helper macro for loop over
queue-based arrays | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The GMAC Ethernet controller found on S32G2/S32G3 and S32R45
contains up to 5 RX and 5 TX channels.
It can operate in two interrupt modes:
1) Sharing IRQ mode: only MAC IRQ line is used
for all channels.
2) Multiple IRQ mode: every channel uses two IRQ lin... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:08 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The stmmac driver contains similar pattern for processing queue-based
arrays, ie. interrupt lines, etc. Factor out the for loop and provide
a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
drivers/net/ethe... | null | null | null | [PATCH v7 1/5] net: stmmac: Use helper macro for loop over
queue-based arrays | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The DWMAC IP on NXP S32G/R SoCs has connected queue-based IRQ lines,
set them to allow using Multi-IRQ mode.
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:09 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The stmmac driver contains similar pattern for processing queue-based
arrays, ie. interrupt lines, etc. Factor out the for loop and provide
a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
drivers/net/ethe... | null | null | null | [PATCH v7 1/5] net: stmmac: Use helper macro for loop over
queue-based arrays | The stmmac core supports two interrupt modes, controlled by the
flag STMMAC_FLAG_MULTI_MSI_EN:
- When the flag is set, the driver uses multi-channel IRQ mode (Multi-IRQ).
- Otherwise, a single IRQ line is requested (aka MAC-IRQ):
static int stmmac_request_irq(struct net_device *dev)
{
/* Request the IRQ lines... | {
"author": "Jan Petrous via B4 Relay <devnull+jan.petrous.oss.nxp.com@kernel.org>",
"date": "Thu, 26 Feb 2026 09:54:05 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The stmmac driver contains similar pattern for processing queue-based
arrays, ie. interrupt lines, etc. Factor out the for loop and provide
a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
drivers/net/ethe... | null | null | null | [PATCH v7 1/5] net: stmmac: Use helper macro for loop over
queue-based arrays | On Thu, Feb 26, 2026 at 09:54:07AM +0100, Jan Petrous via B4 Relay wrote:
You've missed that there are two separate definitions for tx and rx
queues - while they are currently the same number, code shouldn't
make that assumption.
I'm not happy with this method of combining the two loops.
Maybe instead:
static int ... | {
"author": "\"Russell King (Oracle)\" <linux@armlinux.org.uk>",
"date": "Thu, 26 Feb 2026 19:10:22 +0000",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
The stmmac driver contains similar pattern for processing queue-based
arrays, ie. interrupt lines, etc. Factor out the for loop and provide
a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
---
drivers/net/ethe... | null | null | null | [PATCH v7 1/5] net: stmmac: Use helper macro for loop over
queue-based arrays | On Thu, Feb 26, 2026 at 07:10:22PM +0000, Russell King (Oracle) wrote:
Oh, yes. My fault. Next time I shall review my code better.
Agree, your code looks better. Applied in v8 :) Thanks.
BTW, I would prefer to use sizeof() instead of constant for array size,
but this is the style used in stmmac, so I reuse the same... | {
"author": "Jan Petrous <jan.petrous@oss.nxp.com>",
"date": "Fri, 27 Feb 2026 13:27:43 +0100",
"is_openbsd": false,
"thread_id": "20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com.mbox.gz"
} |
lkml_critique | linux-arm-kernel | It's been another year of discussing the object life-time problems at
conferences. I2C is one of the offenders and its problems are more
complex than those of some other subsystems. It seems the revocable[1]
API may make its way into the kernel this year but even with it in
place, I2C won't be able to use it as there's... | null | null | null | [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific
printk helpers | On Fri, Feb 27, 2026 at 04:42:09PM +0100, Bartosz Golaszewski wrote:
It's not weird at all, this is the standard way to handle this. We have
these things called reference counts for a reason.
Drivers are responsible for dropping *their* reference, it doesn't mean
that the resource is necessarily freed immediately ... | {
"author": "Johan Hovold <johan@kernel.org>",
"date": "Fri, 27 Feb 2026 17:40:29 +0100",
"is_openbsd": false,
"thread_id": "aaHI_VavZugXjVoL@hovoldconsulting.com.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.