instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
PostHog__posthog-3464@3da5ab7 | PostHog/posthog | Python | 3,464 | Earlier IP anonymization | ## Changes
- Under "Project" replace the checkbox "Anonymize client IP data" with "Discard client IP data", which better reflects what this checkbox does. "Anonymize" could also mean e.g. removing 8 random bits.
- Actually hides the IP before the task queues and plugins if the option is flipped, instead of just not... | 2021-02-24T22:29:56Z | Respect `team.anonymize_ips` earlier in the pipeline and hide IPs from plugins
We store the IP address of the user calling `posthog.capture` inside the `$ip` property. If this property exists, we use it. If not, we take the IP from the request and put it in the property.
When the event passes through plugins, we pas... | Somewhat related to this I had a user yesterday who wanted to be able to not capture IPs at all, whereas if they don't set an IP themselves (like `0.0.0.0`) we end up setting it for them if they want it or not.
If `team.anonymize_ips` is set, we also shouldn't capture IPs. Is that not the case?
Ah right - I guess the s... | [
{
"body": "We store the IP address of the user calling `posthog.capture` inside the `$ip` property. If this property exists, we use it. If not, we take the IP from the request and put it in the property.\r\n\r\nWhen the event passes through plugins, we pass along the request's IP, all the way until ingestion. I... | 4e8ccbc2b6b619a10cc8baa3d1e118ce7aec96ad | {
"head_commit": "3da5ab7626598fa2d4c589f369f8968936721410",
"head_commit_message": "flip it around",
"patch_to_review": "diff --git a/ee/clickhouse/process_event.py b/ee/clickhouse/process_event.py\nindex 77449e9623586..5d3fe5e00e72a 100644\n--- a/ee/clickhouse/process_event.py\n+++ b/ee/clickhouse/process_event... | [
{
"diff_hunk": "@@ -20,7 +20,7 @@ export function IPCapture() {\n marginLeft: '10px',\n }}\n >\n- Anonymize client IP data\n+ Do not save client IP data",
"line": null,
"original_line": 23,
"original_start_line": null,
... | 776e68522ded13a35c8f06dd1ac056a0ebc81ab1 | diff --git a/ee/clickhouse/process_event.py b/ee/clickhouse/process_event.py
index 77449e9623586..5d3fe5e00e72a 100644
--- a/ee/clickhouse/process_event.py
+++ b/ee/clickhouse/process_event.py
@@ -32,7 +32,7 @@
def _capture_ee(
event_uuid: UUID,
person_uuid: UUID,
- ip: str,
+ ip: Optional[str],
s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PostHog__posthog-3619@e1071b5 | PostHog/posthog | Python | 3,619 | Explain premium feature in upgrade modal | ## Changes
An enhancement of the upgrade modal. Resolves #3148.
<img width="538" alt="Screen Shot 2021-03-10 at 15 57 23" src="https://user-images.githubusercontent.com/4550621/110653709-cb077e00-81bd-11eb-87a0-c97fb2efa427.png">
<img width="541" alt="Screen Shot 2021-03-10 at 15 57 16" src="https://user-images.... | 2021-03-10T15:30:12Z | Explain benefits of the paid feature in the upgrade modal
## Is your feature request related to a problem?
Currently the upgrade modal says what the feature is, but it doesn't explain how beneficial it is (e.g. that multiple projects allow you to track multiple product within one organization).
## Describe the so... | For what is worth, I think this will be less important with usage-based pricing as the incentive to upgrade will be a lot more straightforward. You upgrade to get more than the 10k event limit (you only have to pay for what you use), and you get a bunch of premium features (which will be more than just multiple project... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nCurrently the upgrade modal says what the feature is, but it doesn't explain how beneficial it is (e.g. that multiple projects allow you to track multiple product within one organization).\r\n\r\n## Describe the solution you'd like\r\n\r\nMake i... | ac5fa0686bc9e176b547540cda3eef95059a6172 | {
"head_commit": "e1071b53d20be183603489dce8f5ab39505cbf47",
"head_commit_message": "Fix typing",
"patch_to_review": "diff --git a/frontend/src/layout/navigation/TopNavigation.tsx b/frontend/src/layout/navigation/TopNavigation.tsx\nindex f9f017ca79fff..38eed64d0deb4 100644\n--- a/frontend/src/layout/navigation/To... | [
{
"diff_hunk": "@@ -249,8 +251,8 @@ export const sceneLogic = kea<sceneLogicType>({\n return mapping\n },\n listeners: ({ values, actions }) => ({\n- showUpgradeModal: ({ featureName }) => {\n- posthog.capture('upgrade modal shown', { featureName })\n+ showUpgradeModal: ... | 979eb0f771ca50ddb63b5acce1b3ac665fa7c354 | diff --git a/frontend/src/layout/navigation/TopNavigation.tsx b/frontend/src/layout/navigation/TopNavigation.tsx
index cd713a228d4c6..133778abcd605 100644
--- a/frontend/src/layout/navigation/TopNavigation.tsx
+++ b/frontend/src/layout/navigation/TopNavigation.tsx
@@ -164,6 +164,7 @@ export function TopNavigation(): JS... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-2970@d6e745e | PostHog/posthog | Python | 2,970 | Support plugins installed from GitLab | ## Changes
- Adds support for downloading ZIP files from various GitLab URLs
- Closes #2940
- **Does not** yet add support for private repos (#2941)
## Checklist
- [ ] All querysets/queries filter by Organization, by Team, and by User
- [ ] Django backend tests
- [ ] Jest frontend tests
- [ ] Cypress end-... | 2021-01-18T13:18:46Z | GitLab Plugins
## Is your feature request related to a problem?
You can currently install plugins from Github and NPM sources, but not GitLab
## Describe the solution you'd like
Copy a GitLab URL to install a plugin
## Describe alternatives you've considered
Using the plugin source editor.
## Addition... | Yes, we have on prem instance of GitLab and would like to install the plugins from it so this would be most welcome! :) | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nYou can currently install plugins from Github and NPM sources, but not GitLab\r\n\r\n## Describe the solution you'd like\r\n\r\nCopy a GitLab URL to install a plugin\r\n\r\n## Describe alternatives you've considered\r\n\r\nUsing the plugin sourc... | e3256e3ef0ac795ce93ed3e1bdafb60fcb9a7eb2 | {
"head_commit": "d6e745e518f9cf01df60ff8a8abe202808ed12a6",
"head_commit_message": "support gitlab urls",
"patch_to_review": "diff --git a/posthog/plugins/test/mock.py b/posthog/plugins/test/mock.py\nindex d3cdb4828f9e6..41fddc4017c08 100644\n--- a/posthog/plugins/test/mock.py\n+++ b/posthog/plugins/test/mock.py... | [
{
"diff_hunk": "@@ -75,6 +109,12 @@ def download_plugin_archive(url: str, tag: Optional[str] = None):\n url = \"https://github.com/{user}/{repo}/archive/{tag}.zip\".format(\n user=parsed_url[\"user\"], repo=parsed_url[\"repo\"], tag=tag or parsed_url[\"tag\"]\n )\n+ elif parsed_ur... | 4ddb3e298c0f130aaee79ede47034d53936c6651 | diff --git a/posthog/plugins/test/mock.py b/posthog/plugins/test/mock.py
index d3cdb4828f9e6..41fddc4017c08 100644
--- a/posthog/plugins/test/mock.py
+++ b/posthog/plugins/test/mock.py
@@ -4,6 +4,7 @@
from .plugin_archives import (
HELLO_WORLD_PLUGIN_GITHUB_ATTACHMENT_ZIP,
HELLO_WORLD_PLUGIN_GITHUB_ZIP,
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-3482@6d136c1 | PostHog/posthog | Python | 3,482 | Plugin log entries | ## Changes
This is ~~a proposed~~ the accepted and awaiting complete implementation in this PR (and a complimentary one in https://github.com/PostHog/plugin-server) data model to resolve PostHog/plugin-server#72.
The unit of plugin logging is a single plugin log entry (`PluginLogEntry` model for Postgres and a sche... | 2021-02-25T13:51:10Z | Stream console.log output somewhere
To improve the dev experience, running `console.log` (and `.info`, etc) inside the plugin should send this information somewhere.
First thoughts:
- Do ``console.log = (...args) => (posthog.capture(`${pluginName} console.log`, { args })``? Too easy to endlessly loop...
- Somethin... | TBH Kafka or ClickHouse would be best (in practice just Kafka would do)… But that's EE only.
The problem we're trying to solve is twofold:
1) A lot of noise in the server logs from random plugins that adds little value
2) It might be useful to see the console logs in the interface, to check how your plugin is doing (... | [
{
"body": "To improve the dev experience, running `console.log` (and `.info`, etc) inside the plugin should send this information somewhere.\r\n\r\nFirst thoughts:\r\n- Do ``console.log = (...args) => (posthog.capture(`${pluginName} console.log`, { args })``? Too easy to endlessly loop...\r\n- Something on `plu... | a52a9e460cdc5082471e65487a7ed40d2f0755da | {
"head_commit": "6d136c17c1e28c23a477dae92604fe860d65a204",
"head_commit_message": "Add migration",
"patch_to_review": "diff --git a/ee/clickhouse/migrations/0008_plugin_log_entries.py b/ee/clickhouse/migrations/0008_plugin_log_entries.py\nnew file mode 100644\nindex 0000000000000..0fb4b39cf61d1\n--- /dev/null\n... | [
{
"diff_hunk": "@@ -64,3 +67,21 @@ class Meta:\n plugin_config: models.ForeignKey = models.ForeignKey(\"PluginConfig\", on_delete=models.CASCADE)\n key: models.CharField = models.CharField(max_length=200)\n value: models.TextField = models.TextField(blank=True, null=True)\n+\n+\n+class PluginLogEntr... | 9fd7052f213dbd0a57e1bcba4bd7235c8a84822a | diff --git a/ee/clickhouse/migrations/0008_plugin_log_entries.py b/ee/clickhouse/migrations/0008_plugin_log_entries.py
new file mode 100644
index 0000000000000..0fb4b39cf61d1
--- /dev/null
+++ b/ee/clickhouse/migrations/0008_plugin_log_entries.py
@@ -0,0 +1,13 @@
+from infi.clickhouse_orm import migrations
+
+from ee.c... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} |
PostHog__posthog-1202@e52642b | PostHog/posthog | Python | 1,202 | Add people breakdown on retention | ## Changes
- adds ability to click and breakdown who is retaining
Todo:
- [ ] order by people who go through flow
- [ ] paginate
- [ ] add people tests
## Checklist
- [ ] All querysets/queries filter by Team (if applicable)
- [ ] Backend tests (if applicable)
- [ ] Cypress E2E tests (if applicable)
| 2020-07-13T20:10:54Z | Surface People on Retention
**Is your feature request related to a problem? Please describe.**
I want to be able to see who's being retained
**Describe the solution you'd like**
When I click on a square in the retention table, I want to see the people who have been retained
**Describe alternatives you've consi... | oh yeah huh my retention on app errors out too
1. #1234
2. #1230
3. #1214 (merged)
breakdown people onclick: #1202
@timgl All the above are implemented but theyll have several merge conflicts so whenever you get the chance, I'd suggest we review and merge one at a time in an agreed order so i can fix the me... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nI want to be able to see who's being retained\r\n\r\n**Describe the solution you'd like**\r\nWhen I click on a square in the retention table, I want to see the people who have been retained\r\n\r\n**Describe alternatives you've con... | 742912f2f1439d9656b7031fa0a8da8b88ce6512 | {
"head_commit": "e52642b903abd3a813bd331e904a395be66daef5",
"head_commit_message": "add message for no users",
"patch_to_review": "diff --git a/frontend/src/scenes/retention/RetentionTable.js b/frontend/src/scenes/retention/RetentionTable.js\nindex fa7ad7f2ea0cd..14cc1d90495ee 100644\n--- a/frontend/src/scenes/r... | [
{
"diff_hunk": "@@ -46,7 +54,107 @@ export function RetentionTable({ logic }) {\n dataSource={retention.data}\n columns={columns}\n loading={retentionLoading}\n+ onRow={(_, rowIndex) => {\n+ return {\n+ onCl... | bc1abad62171e27b195ffa85c51ca38c786721fa | diff --git a/frontend/src/scenes/retention/RetentionTable.js b/frontend/src/scenes/retention/RetentionTable.js
index fa7ad7f2ea0cd..318b526fe42a1 100644
--- a/frontend/src/scenes/retention/RetentionTable.js
+++ b/frontend/src/scenes/retention/RetentionTable.js
@@ -1,10 +1,15 @@
-import React from 'react'
-import { useV... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-1683@2674ce3 | PostHog/posthog | Python | 1,683 | Send a weekly instance status report (resolves #1509) | ## Changes
This adds a weekly (sent to us each Monday) status report regarding each PostHog instance as a whole, including event ingestion metadata. | 2020-09-18T15:04:04Z | Capture metadata on ingested events @ self-hosted
Currently we have no way to track event ingestion behavior for self-hosted users (e.g. how many events are being processed on an instance per month?, what's the type of events being processed?, what are the sources of the events?, is auto-capture on?, ....) | [
{
"body": "Currently we have no way to track event ingestion behavior for self-hosted users (e.g. how many events are being processed on an instance per month?, what's the type of events being processed?, what are the sources of the events?, is auto-capture on?, ....)",
"number": 1509,
"title": "Capture... | 0268e88f4fbf93acf48343ad7e2c3f672d4d3ba8 | {
"head_commit": "2674ce386e8b2e5cbc1b584f831e120b7166714b",
"head_commit_message": "Fix at last",
"patch_to_review": "diff --git a/posthog/apps.py b/posthog/apps.py\nindex 73b771bebdea6..e25d827f2362a 100644\n--- a/posthog/apps.py\n+++ b/posthog/apps.py\n@@ -1,11 +1,11 @@\n-import hashlib\n import os\n-import uu... | [
{
"diff_hunk": "@@ -48,6 +47,9 @@ def setup_periodic_tasks(sender, **kwargs):\n sender.add_periodic_task(\n crontab(day_of_week=\"mon,fri\"), update_event_partitions.s(), # check twice a week\n )\n+ sender.add_periodic_task(\n+ 10, status_report.s(),",
"line": null,
"original_... | 022622fd170bf24cf8f6e2ed0910a3ec43f0b448 | diff --git a/posthog/api/action.py b/posthog/api/action.py
index bc9d669cfe58e..1c53459cf593d 100644
--- a/posthog/api/action.py
+++ b/posthog/api/action.py
@@ -37,6 +37,7 @@
from rest_hooks.signals import raw_hook_event
from posthog.api.user import UserSerializer
+from posthog.auth import PersonalAPIKeyAuthenticat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
PostHog__posthog-1475@77392b5 | PostHog/posthog | Python | 1,475 | Disable Link Sharing | ## Changes
Fix #1465
*Please describe.*
This adds a switch to allow the user to disable link sharing on the frontend
## Checklist
- [x] Add backend endpoint to disable link sharing
- [x] Update frontend to hide link sharing when link sharing param is set to None
| 2020-08-20T14:09:36Z | Allow disabling of sharing link in settings
## Is your feature request related to a problem?
I want to be able to disable the sharing link for extra security
## Describe the solution you'd like
A toggle to disable the sharing link in the sharing modal
## Describe alternatives you've considered
-
## Ad... | A slightly friendlier solution may be just a "Regenerate invite" button, which'd replace the team's current `signup_token` with a new one (possibly less work to implement on the frontend too).
On the backend, this would be best as an `@action(methods=["POST"], detail=False)` on an `/api/team/` endpoint. The endpoint it... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nI want to be able to disable the sharing link for extra security\r\n\r\n## Describe the solution you'd like\r\n\r\nA toggle to disable the sharing link in the sharing modal\r\n\r\n## Describe alternatives you've considered\r\n\r\n-\r\n\r\n## Add... | 140b9109265c2fe00a6cc276cc87e0f4e292b64e | {
"head_commit": "77392b55e4aa5eaa4f0909a076c9ddf84ca76fdb",
"head_commit_message": "Remove unused import and stray comment",
"patch_to_review": "diff --git a/frontend/src/lib/components/TeamInvitation.js b/frontend/src/lib/components/TeamInvitation.js\nindex 5d66e656f631e..2bed7d617f298 100644\n--- a/frontend/sr... | [
{
"diff_hunk": "@@ -12,16 +13,29 @@ export function TeamInvitationLink({ user }) {\n }\n \n export function TeamInvitationContent({ user }) {\n- return (\n- <div>\n- <p>\n- <TeamInvitationLink user={user} />\n- </p>\n- Invite teammates with the link abov... | e43a79ecfeff8a82b0401432a495c91984118e28 | diff --git a/frontend/src/lib/components/CopyToClipboard.js b/frontend/src/lib/components/CopyToClipboard.js
index 98f60b65b5541..ca8b7bf5f55f2 100644
--- a/frontend/src/lib/components/CopyToClipboard.js
+++ b/frontend/src/lib/components/CopyToClipboard.js
@@ -3,7 +3,7 @@ import { toast } from 'react-toastify'
import ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-1170@f9d5e2d | PostHog/posthog | Python | 1,170 | Closes #1059: Async processing of Event -> Action mapping | Closes #1059
- Add Env Var `ASYNC_EVENT_ACTION_MAPPING` for deactivating inline Event Action lookups to prevent gnarly query generation resulting in Postgres OOM
- Setup a Celery Beat task to do Action -> Event mapping every minute on all Actions (we may want to tune this or set this as the env var parameter)
Alr... | 2020-07-08T18:35:24Z | Adding actions causes Postgres out of memory with partitions
**Describe the bug**
Report from OpenRent that adding a simple $autocapture action causes Postgres to run out of memory. I think this has something to do with the fact that they've got things partitioned.
**To Reproduce**
1. TBD
2.
3.
**Expected... | @timgl Will I be looking into this tomorrow? Do we have a repro case? :)
The issue from what I've seen and been able to reproduce is:
- An instance that is [partitioned](https://posthog.com/docs/deployment/scaling-posthog)
- Has high-ish volume, somewhere around 3 RPS
- Has an action defined. This seems to happen wi... | [
{
"body": "**Describe the bug**\r\n\r\nReport from OpenRent that adding a simple $autocapture action causes Postgres to run out of memory. I think this has something to do with the fact that they've got things partitioned.\r\n\r\n**To Reproduce**\r\n1. TBD\r\n2. \r\n3. \r\n\r\n**Expected behavior**\r\n\r\nIt sh... | 2f3c3d810b2352513f9310a131c79a4b5f812db2 | {
"head_commit": "f9d5e2de1aa6e4bae576e4e6ff5834f6ab3343ae",
"head_commit_message": "add ACTION_EVENT_MAPPING_INTERVAL_MINUTES as env var",
"patch_to_review": "diff --git a/latest_migrations.manifest b/latest_migrations.manifest\nindex b7e6ef3b08904..4da1564b3869a 100644\n--- a/latest_migrations.manifest\n+++ b/l... | [
{
"diff_hunk": "@@ -42,6 +43,15 @@ def setup_periodic_tasks(sender, **kwargs):\n sender.add_periodic_task(15 * 60, calculate_cohort.s(), name=\"debug\")\n sender.add_periodic_task(600, check_cached_items.s(), name=\"check dashboard items\")\n \n+ action_event_mapping_interval_minutes = settings.ACTIO... | 98cbf1d281e23012a9a885b3068cd401f9501aa1 | diff --git a/latest_migrations.manifest b/latest_migrations.manifest
index b7e6ef3b08904..69dd00ae359cd 100644
--- a/latest_migrations.manifest
+++ b/latest_migrations.manifest
@@ -1,6 +1,6 @@
admin: 0003_logentry_add_action_flag_choices
auth: 0011_update_proxy_permissions
contenttypes: 0002_remove_content_type_name... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
PostHog__posthog-443@83217bc | PostHog/posthog | Python | 443 | #167 Add change user password form | Fixes #167
## Description
Included a change password form in the setup scene.
- When password submission is successful the user is redirected to the login page after 2 seconds. A successful toast is displayed.
- When the password submission fails an error toast is displayed.
## Screenshot
If need to do this now, you can
- Go to your app on Heroku
- Click "More" in the top right
- Click "run console"
- Enter `python manage.py changepassword [your email]`
- Change your password
Let me know if that worked
Thanks f... | [
{
"body": "Installed on heroku this morning. Set a haphazard password since I was just checking it out.\r\n\r\nAfter setting it up a bit, I realized there doesn't seem to be a way to reset or change the password.\r\n",
"number": 167,
"title": "Need ability to change password"
}
] | 36e520491346155f6193e3096e1caed15b6510fa | {
"head_commit": "83217bc4aea129fc31214d2e6fae375b58310416",
"head_commit_message": "Fix lint errors",
"patch_to_review": "diff --git a/frontend/src/scenes/setup/ChangePassword.js b/frontend/src/scenes/setup/ChangePassword.js\nnew file mode 100644\nindex 0000000000000..dd472b52ee007\n--- /dev/null\n+++ b/frontend... | [
{
"diff_hunk": "@@ -0,0 +1,72 @@\n+import React, { Component } from 'react'\n+import { toast } from 'react-toastify'\n+import api from '../../lib/api'\n+\n+export class ChangePassword extends Component {\n+ constructor(props) {\n+ super(props)\n+ this.state = {\n+ oldPassword: '',\n+... | 1370995de24e819d35ef1d81abdd5fd0a596cc41 | diff --git a/frontend/src/scenes/setup/ChangePassword.js b/frontend/src/scenes/setup/ChangePassword.js
new file mode 100644
index 0000000000000..c819f47a17779
--- /dev/null
+++ b/frontend/src/scenes/setup/ChangePassword.js
@@ -0,0 +1,68 @@
+import React, { Component } from 'react'
+import { toast } from 'react-toastify... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PrefectHQ__prefect-12257@8f5eceb | PrefectHQ/prefect | Python | 12,257 | Fix support for legacy schedule in `build_from_flow` | The recent changes for enhanced scheduling broke the way the legacy `schedule` parameter worked for `build_from_flow`. This ensures that the legacy field is able to add and remove schedules, but in the case that both `schedule` and `schedules` are provided `schedules` will be the source of truth.
Closes #12255
#... | 2024-03-12T16:35:27Z | "schedule" not recognised in Deployment.build_from_flow
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that this issue is related to Prefect and n... | [
{
"body": "### First check\r\n\r\n- [X] I added a descriptive title to this issue.\r\n- [X] I used the GitHub search to find a similar issue and didn't find it.\r\n- [X] I searched the Prefect documentation for this issue.\r\n- [X] I checked that this issue is related to Prefect and not one of its dependencies.... | 71721cef7c624e7d429ec90f8b545f9e5bdd2849 | {
"head_commit": "8f5eceb60a059ff6452d0f58cf85824f5a84a610",
"head_commit_message": "Fix support for legacy schedule in `build_from_flow`",
"patch_to_review": "diff --git a/src/prefect/deployments/deployments.py b/src/prefect/deployments/deployments.py\nindex 80718aa83b73..a90696605ae0 100644\n--- a/src/prefect/d... | [
{
"diff_hunk": "@@ -28,6 +29,11 @@ def normalize_to_minimal_deployment_schedules(\n normalized.append(create_minimal_deployment_schedule(**obj))\n elif isinstance(obj, MinimalDeploymentSchedule):\n normalized.append(obj)\n+ elif isinstance(obj, get_args(SER... | 9ed453219451ef64b9b4d133566930a1493edc37 | diff --git a/src/prefect/deployments/deployments.py b/src/prefect/deployments/deployments.py
index 80718aa83b73..a90696605ae0 100644
--- a/src/prefect/deployments/deployments.py
+++ b/src/prefect/deployments/deployments.py
@@ -38,6 +38,7 @@
from prefect.context import FlowRunContext, PrefectObjectRegistry, TaskRunCont... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
PrefectHQ__prefect-12334@bbe10f0 | PrefectHQ/prefect | Python | 12,334 | fix(cli): prompt user confirmation for pausing work queue in default work pool |
<!--
Thanks for opening a pull request to Prefect! We've got a few requests to help us review contributions:
- Make sure that your title neatly summarizes the proposed changes.
- Provide a short overview of the change and the value it adds.
- Share an example to help us understand the change in user experience... | 2024-03-17T15:16:03Z | Pausing a work queue via CLI without specifying work pool will pause `default-agent-pool `
### First check
- [X] I added a descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Prefect documentation for this issue.
- [X] I checked that thi... | [
{
"body": "### First check\r\n\r\n- [X] I added a descriptive title to this issue.\r\n- [X] I used the GitHub search to find a similar issue and didn't find it.\r\n- [X] I searched the Prefect documentation for this issue.\r\n- [X] I checked that this issue is related to Prefect and not one of its dependencies.... | e57a63085c0cf1ac3c2a09fb39c2511488d825e9 | {
"head_commit": "bbe10f00f7f4bc75825fae920bbaa8b6e10c15d0",
"head_commit_message": "fix(cli): prompt user confirmation for pausing work queue in default work pool\n\nSigned-off-by: hainenber <dotronghai96@gmail.com>",
"patch_to_review": "diff --git a/src/prefect/cli/work_queue.py b/src/prefect/cli/work_queue.py\... | [
{
"diff_hunk": "@@ -263,6 +263,17 @@ async def pause(\n \"\"\"\n Pause a work queue.\n \"\"\"\n+\n+ # If work pool name is not specified,\n+ # Get confirmation from user that they're OK to pause the work queue\n+ # in the default work pool.\n+ if not pool:\n+ pause_workqueue_in_de... | be0bb37f39dc4e79d65772b10e24cdd89a6b89d3 | diff --git a/src/prefect/cli/work_queue.py b/src/prefect/cli/work_queue.py
index bb66012c2def..ba81bc18f070 100644
--- a/src/prefect/cli/work_queue.py
+++ b/src/prefect/cli/work_queue.py
@@ -263,6 +263,12 @@ async def pause(
"""
Pause a work queue.
"""
+
+ if not pool and not typer.confirm(
+ f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
RasaHQ__rasa-8652@c802872 | RasaHQ/rasa | Python | 8,652 | Improve response selector defaults when transformer is enabled | **Proposed changes**:
- Raise warnings when `number_of_transformer_layers > 0` is used with a ResponseSelector but:
- `transformer_size` is not specified or is set to a non-positive value
- `hidden_layers_sizes` is not specified or is set such that the hidden layers are not disabled (we recommend disabling hidd... | 2021-05-11T13:30:20Z | ResponseSelector training fails with use_text_as_label and simple pipeline
**Rasa version**: `main` (2.3.1)
**Rasa SDK version** (if used & relevant):
**Rasa X version** (if used & relevant):
**Python version**: 3.8.5
**Operating system** (windows, osx, ...): MacOS 10.15.6
**Issue**: NLU training fails w... | missing intent in `domain.yml`
```
greet/hi
greet/bye
```
@Dustyposa in this case `greet` is a retrieval intent, so it's enough to list `greet` in the domain file, without enumerating all the variations with different response keys (in these case the keys being `hi` and `bye`).
@samsucik
in your `config.yml`, not... | [
{
"body": "**Rasa version**: `main` (2.3.1)\r\n\r\n**Rasa SDK version** (if used & relevant):\r\n\r\n**Rasa X version** (if used & relevant):\r\n\r\n**Python version**: 3.8.5\r\n\r\n**Operating system** (windows, osx, ...): MacOS 10.15.6\r\n\r\n**Issue**: NLU training fails when I have a `ResponseSelector` that... | 2b3695411e1b04c3a71929f9481c6c9e658f896b | {
"head_commit": "c8028729eb7b0d50482eba64f5f3bd42e59ca845",
"head_commit_message": "Update the changelog entry.",
"patch_to_review": "diff --git a/changelog/8046.bugfix.md b/changelog/8046.bugfix.md\nnew file mode 100644\nindex 000000000000..5ed67841f4c4\n--- /dev/null\n+++ b/changelog/8046.bugfix.md\n@@ -0,0 +1... | [
{
"diff_hunk": "@@ -308,9 +311,88 @@ def _load_selector_params(self, config: Dict[Text, Any]) -> None:\n self.retrieval_intent = config[RETRIEVAL_INTENT]\n self.use_text_as_label = config[USE_TEXT_AS_LABEL]\n \n+ def _warn_about_transformer_and_hidden_layers_enabled(\n+ self, selector_... | 4a239b006a9ad93c53388a9b67ae0f48d602bcd3 | diff --git a/changelog/8046.bugfix.md b/changelog/8046.bugfix.md
new file mode 100644
index 000000000000..28676bb3173e
--- /dev/null
+++ b/changelog/8046.bugfix.md
@@ -0,0 +1,3 @@
+`ResponseSelector` can now be trained with the transformer enabled (i.e. when a positive
+`number_of_transformer_layers` is provided) even ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ManimCommunity__manim-1502@33f2024 | ManimCommunity/manim | Python | 1,502 | Added ``center`` parameter to :class:`~.Sphere` and ``point`` parameter to :class:`~.Dot3D` | <!--
Thanks for your contribution to ManimCommunity!
Before filling in the details, ensure:
- Your local changes are up-to-date with ManimCommunity/manim
- The title of your PR gives a descriptive summary to end-users. Some examples:
- Fixed last animations not running to completion
- Added gradient sup... | 2021-05-12T15:53:03Z | `Dot3D` should have a coordinate parameter
## Enhancement proposal
`Dot3D` should mirror the functionality of `Dot` and have a parameter to specify its coordinates. I think the best way to do this is to add a kwarg to `Sphere` that would also change its position, and then pass in the coordinate from `Dot3D` to the sup... | Was thinking the same thing a while ago, seems like a good idea to me. | [
{
"body": "## Enhancement proposal\r\n`Dot3D` should mirror the functionality of `Dot` and have a parameter to specify its coordinates. I think the best way to do this is to add a kwarg to `Sphere` that would also change its position, and then pass in the coordinate from `Dot3D` to the superclass init method.\r... | 8750cd33e9c5075d87cecea0286e9b6a0bb66cd2 | {
"head_commit": "33f2024d4e1989eeb058ec73416e62af12c81ccf",
"head_commit_message": "feat: Added coordinate parameter to Sphere and Dot3D",
"patch_to_review": "diff --git a/manim/mobject/three_dimensions.py b/manim/mobject/three_dimensions.py\nindex cb478131ab..719697f2f9 100644\n--- a/manim/mobject/three_dimensi... | [
{
"diff_hunk": "@@ -183,14 +187,14 @@ def construct(self):\n self.set_camera_orientation(phi=75*DEGREES, theta=-45*DEGREES)\n \n axes = ThreeDAxes()\n- dot_1 = Dot3D(color=RED).move_to(axes.coords_to_point(0, 0, 1))\n- dot_2 = Dot3D(radius=0.1, color... | 3f81f7181f2ce82394a93c11668874d0c605eadf | diff --git a/manim/mobject/three_dimensions.py b/manim/mobject/three_dimensions.py
index cb478131ab..d00f3cc6ad 100644
--- a/manim/mobject/three_dimensions.py
+++ b/manim/mobject/three_dimensions.py
@@ -135,6 +135,7 @@ def set_fill_by_checkerboard(self, *colors, opacity=None):
class Sphere(ParametricSurface):
def... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
OpenMined__PySyft-5384@95518ab | OpenMined/PySyft | Python | 5,384 | fix#5365 skip rewrapping iter | ## Description
Fix #5365
`__iter__` gets wrapped multiple times due to
https://github.com/OpenMined/PySyft/blob/261869e50852a24b2d76f3b44a5819050acd9eb8/src/syft/ast/klass.py#L338-L342
Fix: skip re-wrapping if already wrapped
## Checklist
- [x] I have followed the [Contribution Guidelines](https://github.c... | 2021-03-28T09:02:55Z | Improving Dict Iterator creation
## Description
Currently, if you trace it, we are making 4 remote `__len__` requests when creating a Dict/OrderedDict remote iterator. Ideally, we should stick to one. The same goes for any Iterator that is being created from Dict (`.values()`, `.items()`, etc).
Snippet to reproduce... | This is caused due to the `__iter__` being wrapped multiple times by:
https://github.com/OpenMined/PySyft/blob/261869e50852a24b2d76f3b44a5819050acd9eb8/src/syft/ast/klass.py#L338-L342
For `OrderedDict`: (`items`, `values`, `keys`) return an `Iterator`, hence the `__iter__` gets wrapped thrice.
I believe the w... | [
{
"body": "## Description\r\nCurrently, if you trace it, we are making 4 remote `__len__` requests when creating a Dict/OrderedDict remote iterator. Ideally, we should stick to one. The same goes for any Iterator that is being created from Dict (`.values()`, `.items()`, etc).\r\n\r\nSnippet to reproduce:\r\n```... | 4a62fd51efbde38ce807bad59e2eb81d00703026 | {
"head_commit": "95518ab81169a66b8992b0a37287e45f1520abac",
"head_commit_message": "str qualname fix",
"patch_to_review": "diff --git a/src/syft/ast/klass.py b/src/syft/ast/klass.py\nindex b5fe1103120..79936093aef 100644\n--- a/src/syft/ast/klass.py\n+++ b/src/syft/ast/klass.py\n@@ -232,6 +232,11 @@ def __iter__... | [
{
"diff_hunk": "@@ -232,6 +232,11 @@ def __iter__(self: Any) -> Iterable:\n \n attr_name = \"__iter__\"\n iter_target = attrs[attr_name]\n+\n+ # skip if __iter__ has already been wrapped\n+ if \"__qual_name__\" in dir(iter_target) and \"wrap_iter\" in iter_target.__qualname__:",
"line": null,
... | 572df900f38f3436e86b0badafcb75abcf8ba4d6 | diff --git a/src/syft/ast/klass.py b/src/syft/ast/klass.py
index 152accf2ec8..a5b13163fae 100644
--- a/src/syft/ast/klass.py
+++ b/src/syft/ast/klass.py
@@ -232,6 +232,12 @@ def __iter__(self: Any) -> Iterable:
attr_name = "__iter__"
iter_target = attrs[attr_name]
+
+ # skip if __iter__ has already been ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Performance Optimizations"
} |
OpenMined__PySyft-5385@0af54a4 | OpenMined/PySyft | Python | 5,385 | load multiple libs in one call | ## Description
Fix #5344
Enable loading multiple libraries in a single `syft.load` call.
## How has this been tested?
`tests/syft/api/load_lib_test.py`
## Checklist
- [x] I have followed the [Contribution Guidelines](https://github.com/OpenMined/.github/blob/master/CONTRIBUTING.md) and [Code of Conduct](https... | 2021-03-28T17:28:56Z | Add ability to load multiple libs in one call
## Description
`sy.load()` should accept any valid sequence of strings, variadic args, a list, tuple or set of strings like:
```
sy.load("pydp", "opacus")
sy.load(["pydp", "opacus"])
sy.load(("pydp", "opacus"))
sy.load({"pydp", "opacus"})
```
## Definition of Done... | [
{
"body": "## Description\r\n`sy.load()` should accept any valid sequence of strings, variadic args, a list, tuple or set of strings like:\r\n```\r\nsy.load(\"pydp\", \"opacus\")\r\nsy.load([\"pydp\", \"opacus\"])\r\nsy.load((\"pydp\", \"opacus\"))\r\nsy.load({\"pydp\", \"opacus\"})\r\n```\r\n\r\n## Definition ... | 98cedf8ac02a4ecbfce3b3124f478297b09818c2 | {
"head_commit": "0af54a467bb37abc907685308976f9ffa53eccef",
"head_commit_message": "python linting",
"patch_to_review": "diff --git a/src/syft/lib/__init__.py b/src/syft/lib/__init__.py\nindex b0ce1f86fe5..73214cb7d6a 100644\n--- a/src/syft/lib/__init__.py\n+++ b/src/syft/lib/__init__.py\n@@ -5,7 +5,10 @@\n from... | [
{
"diff_hunk": "@@ -142,20 +145,26 @@ def _load_lib(*, lib: str, options: TypeDict[str, TypeAny] = {}) -> None:\n _regenerate_unions(lib_ast=lib_ast, client=client)\n \n \n-def load(lib: str, options: TypeDict[str, TypeAny] = {}) -> None:\n+def load(\n+ *libs: TypeUnion[TypeList, TypeTuple, TypeS... | bc9cbf0c876f597ccbea2b3b9b4febfacb7011a3 | diff --git a/src/syft/lib/__init__.py b/src/syft/lib/__init__.py
index b0ce1f86fe5..eda4e97ce78 100644
--- a/src/syft/lib/__init__.py
+++ b/src/syft/lib/__init__.py
@@ -5,7 +5,11 @@
from typing import Any
from typing import Any as TypeAny
from typing import Dict as TypeDict
+from typing import Iterable
+from typing ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-10055@6e69804 | RasaHQ/rasa | Python | 10,055 | Remove `Domain.slots_for_entities` usage in `DialogueStateTracker.update()` | **Proposed changes**:
- Closes #9744
**Status (please check what you already did)**:
- [x] added some tests for the functionality
- [ ] updated the documentation
- [ ] updated the changelog (please check [changelog](https://github.com/RasaHQ/rasa/tree/main/changelog) for instructions)
- [X] reformat files usin... | 2021-11-02T10:56:39Z | 3.0 slot mappings: revisit `Domain.slots_for_entities()` method and its usage
**Overview of the Problem**:
- In rasa 2.0, `Domain.slots_for_entities()` method used to return a list of `SlotSet` events for slots with the same entity name which had auto-fill enabled.
- In 3.0, auto-fill has been removed and the method... | [
{
"body": "**Overview of the Problem**:\r\n- In rasa 2.0, `Domain.slots_for_entities()` method used to return a list of `SlotSet` events for slots with the same entity name which had auto-fill enabled. \r\n- In 3.0, auto-fill has been removed and the method was adapted slightly to set any slots if matching enti... | 343f6e37f2ae49234987123c6bb2f59c1adf78fd | {
"head_commit": "6e698040093b7827812d47e6d1230006cfafb30d",
"head_commit_message": "fix for testing e2e stories of bot with slots",
"patch_to_review": "diff --git a/data/test_e2ebot/domain.yml b/data/test_e2ebot/domain.yml\nindex 0208aeb1354e..87b1f8590470 100644\n--- a/data/test_e2ebot/domain.yml\n+++ b/data/te... | [
{
"diff_hunk": "@@ -601,6 +601,12 @@ async def _get_e2e_entity_evaluation_result(\n prediction: PolicyPrediction,\n ) -> Optional[EntityEvaluationResult]:\n previous_event = tracker.events[-1]\n+\n+ if isinstance(previous_event, SlotSet):\n+ # UserUttered events with entities can be followed b... | 96ec6725fb3cd129e05a8477025638f46da40654 | diff --git a/data/test_e2ebot/domain.yml b/data/test_e2ebot/domain.yml
index 0208aeb1354e..87b1f8590470 100644
--- a/data/test_e2ebot/domain.yml
+++ b/data/test_e2ebot/domain.yml
@@ -8,6 +8,20 @@ entities:
- name
- mood
+slots:
+ name:
+ type: text
+ influence_conversation: false
+ mappings:
+ - type... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
ManimCommunity__manim-817@a457022 | ManimCommunity/manim | Python | 817 | Removed temporary partial movie file in scenefilewriter | <!---
Thanks for contributing to manim!
**Please ensure that your pull request works with the latest version of manim from this repository.**
You should also include:
1. The motivation for making this change (or link the relevant issues)
2. How you tested the new behavior (e.g. a minimal working example, befo... | 2020-12-03T00:27:26Z | Removing temp ffmpeg's temp-files
Before partial movie files are generated by ffmpeg, scenefilewriter creates temp partial movie file and then move them and rename them with their definitive name (which is the hash of the animation).
Why ? Why not rendering directly partial movie files?
I think we should, if there... | No objection here.
Is this still open? If it is, I would like to look into it.
@farahash yes! Please feel free to discuss here or open a PR.
@farahash and to assign yourself on this issue if you work on it ;)
@huguesdevimeux it doesn't seem like I can do that myself. Do I need to be added as a collaborator to the repo... | [
{
"body": "Before partial movie files are generated by ffmpeg, scenefilewriter creates temp partial movie file and then move them and rename them with their definitive name (which is the hash of the animation). \r\nWhy ? Why not rendering directly partial movie files? \r\nI think we should, if there is no objec... | 9d7d640db636073f14d5f30c25ac0cfaa994ec71 | {
"head_commit": "a4570225a37e4fdfdbb8e7ba2a8560aeed12621e",
"head_commit_message": "Added entry to changelog",
"patch_to_review": "diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst\nindex 1be4bcc07d..59353eb06a 100644\n--- a/docs/source/changelog.rst\n+++ b/docs/source/changelog.rst\n@@ -207,3 +... | [
{
"diff_hunk": "@@ -207,3 +207,4 @@ Other Changes\n #. Rename package from manimlib to manim\n #. Move all imports to :code:`__init__`, so :code:`from manim import *` replaces :code:`from manimlib.imports import *`\n #. Global dir variable handling has been removed. Instead :code:`initialize_directories`, if ne... | b90b792bc7193ff1577ae2806c5c644ff72d45a6 | diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst
index 1be4bcc07d..03cdcfba76 100644
--- a/docs/source/changelog.rst
+++ b/docs/source/changelog.rst
@@ -26,6 +26,10 @@ Bugfixes
- There is nothing here yet, check back later.
+Other Changes
+=============
+
+#. Removed temp partial movie file from ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
ManimCommunity__manim-760@721d148 | ManimCommunity/manim | Python | 760 | Add Cutout to geometry - fix VMobject().force_direction() | ## List of Changes
Added a class that allows for making shapes with an arbitrary number of cutouts. See the example in the documentation.
Also fixed a really sneaky bug in VMobject().force_direction().
## Motivation
The code is trivial yet the resulting class is very useful for a whole number of applications.
... | 2020-11-22T20:17:12Z | Shapes with cutouts
Another feature request I'll write down here to take care of eventually myself, probably after `ArcPolygon`. While I was working on the Hadwiger-Nelson problem I created the highly complex class `ExclusionZone`, and while I was worrying that their appearance of a roughly annulus shaped zone with a c... | [
{
"body": "Another feature request I'll write down here to take care of eventually myself, probably after `ArcPolygon`. While I was working on the Hadwiger-Nelson problem I created the highly complex class `ExclusionZone`, and while I was worrying that their appearance of a roughly annulus shaped zone with a ce... | 81032432e161967691ee49a08ef3dc79742cec20 | {
"head_commit": "721d1481dafb89822c0282879e77068ec1e7bc9c",
"head_commit_message": "Add Cutout to geometry - fix VMobject().force_direction()",
"patch_to_review": "diff --git a/manim/mobject/geometry.py b/manim/mobject/geometry.py\nindex 3d43adc472..3441593043 100644\n--- a/manim/mobject/geometry.py\n+++ b/manim... | [
{
"diff_hunk": "@@ -1390,3 +1391,42 @@ def __init__(self, **kwargs):\n class ArrowSquareFilledTip(ArrowFilledTip, ArrowSquareTip):\n r\"\"\"Square arrow tip with filled tip.\"\"\"\n pass\n+\n+\n+class Cutout(VMobject):\n+ \"\"\"A shape with smaller cutouts.\n+\n+ Parameters\n+ ----------\n+ ... | 602aff93b99c5744ffd21eb1e9099ea12416d717 | diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst
index 00edd68475..5bbb6374ea 100644
--- a/docs/source/changelog.rst
+++ b/docs/source/changelog.rst
@@ -46,6 +46,10 @@ Mobjects, Scenes, and Animations
#. Ensure that the axes for graphs (:class:`GraphScene`) always intersect (:pr:`580`).
#. Now Mobje... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
RasaHQ__rasa-7797@3d69847 | RasaHQ/rasa | Python | 7,797 | Separate docs-tests from CI workflow | **Proposed changes**:
- [X] Separate `docs-tests` job from CI workflow.
`docs-tests` now becomes a single workflow such that we can re-run it if it is failed
- [x] Let CI workflow wait for `docs-tests` workflow
**Status (please check what you already did)**:
- [ ] added some tests for the functionality
- [ ] u... | 2021-01-25T13:02:58Z | Documentation checks - retry if a link is not reachable
One of the checks in the Publish Documentation workflow checks if links in the docs are still reachable, but sometimes it happens that one of the links didn't respond on time, in such a scenario the workflow will finish with failure.
Things to improve:
- inc... | I looked [publish documentation workflow](https://github.com/RasaHQ/rasa/blob/master/.github/workflows/documentation.yml). Not sure about which check is reaching links. @tczekajlo Do you have an idea?
> I looked [publish documentation workflow](https://github.com/RasaHQ/rasa/blob/master/.github/workflows/documentation... | [
{
"body": "One of the checks in the Publish Documentation workflow checks if links in the docs are still reachable, but sometimes it happens that one of the links didn't respond on time, in such a scenario the workflow will finish with failure. \r\n\r\nThings to improve:\r\n- increase the timeout for connection... | 2ed20f6239e181788df98159c7470122887b83af | {
"head_commit": "3d69847326a0614b79e732ee6832591ea5f5d936",
"head_commit_message": "Merge branch 'main' into separate-workflow-for-docs-tests",
"patch_to_review": "diff --git a/.github/workflows/ci-docs-tests.yml b/.github/workflows/ci-docs-tests.yml\nnew file mode 100644\nindex 000000000000..c1e0572e10c0\n--- /... | [
{
"diff_hunk": "@@ -47,72 +53,28 @@ jobs:\n token: ${{ secrets.GITHUB_TOKEN }}\n filters: .github/change_filters.yml\n \n- documentation:\n- name: Test Documentation\n+\n+ wait_for_docs_tests:\n+ # Looks for doc test workflows and waits for it to complete successfully\n+ # Runs on... | 2b4257cdf6fdd0d9b0e5b394ee640bf9f3517852 | diff --git a/.github/workflows/ci-docs-tests.yml b/.github/workflows/ci-docs-tests.yml
new file mode 100644
index 000000000000..c35ccd9bdf12
--- /dev/null
+++ b/.github/workflows/ci-docs-tests.yml
@@ -0,0 +1,84 @@
+name: Docs Tests
+on:
+ push:
+ branches:
+ - main
+ tags:
+ - '*'
+ pull_request:
+ typ... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
OpenMined__PySyft-5452@2b1416a | OpenMined/PySyft | Python | 5,452 | Adding range support to PyPrimitive | ## Description
fixes #5391
Adds support for `range` object as `PyPrimitive`
## Affected Dependencies
None
## How has this been tested?
Added serde tests and integrated cpython range tests
## Checklist
- [x] I have followed the [Contribution Guidelines](https://github.com/OpenMined/.github/blob/master/CON... | 2021-04-07T16:35:43Z | Add support for ranges
## Description
We don't have support for `range` objects. We would like to add ranges in our primitive supported types.
Definition of DONE:
- [ ] Add some serde tests
- [ ] Make sure Ranges works on other types like Tensor or Pandas
- [ ] Add to `primitive_factory`
## Additional Context... | @tudorcebere I will create a WIP PR, would like to have in-progress feedback. | [
{
"body": "## Description\r\nWe don't have support for `range` objects. We would like to add ranges in our primitive supported types.\r\n\r\nDefinition of DONE:\r\n- [ ] Add some serde tests\r\n- [ ] Make sure Ranges works on other types like Tensor or Pandas\r\n- [ ] Add to `primitive_factory`\r\n\r\n## Additi... | 63994d8276011e20536b96ba836b31c817671087 | {
"head_commit": "2b1416aa7b974ca923b195d99ea53724f017d3b0",
"head_commit_message": "Created range proto and boiler plate in range.py",
"patch_to_review": "diff --git a/proto/lib/python/range.proto b/proto/lib/python/range.proto\nnew file mode 100644\nindex 00000000000..715eeaf2e5c\n--- /dev/null\n+++ b/proto/lib... | [
{
"diff_hunk": "@@ -0,0 +1,14 @@\n+syntax = \"proto3\";\n+\n+package syft.lib.python;\n+import \"proto/core/common/common_object.proto\";\n+\n+message Range {\n+ int64 start = 1;\n+ int64 stop = 2;\n+ int64 step = 3;\n+ bool has_start = 4;",
"line": null,
"original_line": 10,
"original_start_lin... | 76aafdf796c44bea32deb207559ed62e8853d655 | diff --git a/proto/lib/python/range.proto b/proto/lib/python/range.proto
new file mode 100644
index 00000000000..c9b324f6495
--- /dev/null
+++ b/proto/lib/python/range.proto
@@ -0,0 +1,11 @@
+syntax = "proto3";
+
+package syft.lib.python;
+import "proto/core/common/common_object.proto";
+
+message Range {
+ int64 star... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
PostHog__posthog-15345@b104baf | PostHog/posthog | Python | 15,345 | feat: Recording player UX improvements | ## Problem
Closes https://github.com/PostHog/posthog/issues/13392
Part of the Notebooks work...
The current playlist / player view is somewhat responsive but ends up with the "inspector" area always getting flowed beneath the recording which leads to difficult UI challenges currently solved with sticky hacks a... | 2023-05-03T09:51:29Z | Convert Recordings list to infinite scrollers
## Is your feature request related to a problem?
Currently we have pagination on our recordings lists allowing you to paginate through results in batches of 20. This has some flaws however:
1. We cannot guarantee that the next page is the correct offset as we offset by ... | [
{
"body": "## Is your feature request related to a problem?\r\n\r\nCurrently we have pagination on our recordings lists allowing you to paginate through results in batches of 20. This has some flaws however:\r\n1. We cannot guarantee that the next page is the correct offset as we offset by number, not time. Thi... | 7df9fb9d6bd4713406bb677c8753b6d4315e7b08 | {
"head_commit": "b104baf57d1dad3cb5a006f0df1791319a03a2ed",
"head_commit_message": "Fix",
"patch_to_review": "diff --git a/frontend/src/layout/navigation-3000/Navigation.tsx b/frontend/src/layout/navigation-3000/Navigation.tsx\nindex 70df3c7313ddc..25a1cb33aa18d 100644\n--- a/frontend/src/layout/navigation-3000/... | [
{
"diff_hunk": "@@ -40,21 +40,67 @@ export function PlayerMetaLinks(): JSX.Element {\n })\n }\n \n+ const commonProps: Partial<LemonButtonProps> = {\n+ fullWidth: false,\n+ size: 'small',\n+ }\n+\n+ const showText = false\n+\n+ // return (",
"line": null,
"original_... | c7d488f194ab3c94dd61cb94806a245c8733dc71 | diff --git a/frontend/__snapshots__/scenes-app-dashboards--list.png b/frontend/__snapshots__/scenes-app-dashboards--list.png
index 6d63de7234e3b..017019e39e8fe 100644
Binary files a/frontend/__snapshots__/scenes-app-dashboards--list.png and b/frontend/__snapshots__/scenes-app-dashboards--list.png differ
diff --git a/fr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
ManimCommunity__manim-304@3649cae | ManimCommunity/manim | Python | 304 | Check for add in VGroup | <!---
Thanks for contributing to manim!
**Please ensure that your pull request works with the latest version of manim from this repository.**
You should also include:
1. The motivation for making this change (or link the relevant issues)
2. How you tested the new behavior (e.g. a minimal working example, befo... | 2020-08-15T22:11:37Z | VGroup only checks input when creating, not when adding
This is good:
```python
>>> from manim import VGroup, Mobject
>>> g = VGroup(Mobject())
Exception: All submobjects must be of type VMobject
```
This is bad:
```python
>>> g = VGroup()
>>> g.add(Mobject())
<manim.mobject.types.vectorized_mobject.VGroup... | [
{
"body": "This is good: \r\n```python\r\n>>> from manim import VGroup, Mobject\r\n>>> g = VGroup(Mobject())\r\nException: All submobjects must be of type VMobject\r\n```\r\n\r\nThis is bad:\r\n```python\r\n>>> g = VGroup()\r\n>>> g.add(Mobject())\r\n<manim.mobject.types.vectorized_mobject.VGroup at 0x7f907b899... | 5a578b4a13024e86163b1cb6f297985c0cf7b2be | {
"head_commit": "3649cae5314926be0fffdfe419e75ed9b44100ca",
"head_commit_message": "!fixup black vectorized_mobject",
"patch_to_review": "diff --git a/manim/mobject/types/vectorized_mobject.py b/manim/mobject/types/vectorized_mobject.py\nindex 805c230009..c7129aab73 100644\n--- a/manim/mobject/types/vectorized_m... | [
{
"diff_hunk": "@@ -846,11 +846,30 @@ def get_subcurve(self, a, b):\n \n class VGroup(VMobject):\n def __init__(self, *vmobjects, **kwargs):\n- if not all([isinstance(m, VMobject) for m in vmobjects]):\n- raise Exception(\"All submobjects must be of type VMobject\")\n VMobject.__in... | 0f6fff408b3e253de0f5c68d31212d8e5786e7ba | diff --git a/manim/mobject/types/vectorized_mobject.py b/manim/mobject/types/vectorized_mobject.py
index 805c230009..129c4b294a 100644
--- a/manim/mobject/types/vectorized_mobject.py
+++ b/manim/mobject/types/vectorized_mobject.py
@@ -846,11 +846,30 @@ def get_subcurve(self, a, b):
class VGroup(VMobject):
def _... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
aio-libs__aiohttp-10764@004a872 | aio-libs/aiohttp | Python | 10,764 | Fix WebSocket reader with fragmented masked messages | Fix WebSocket reader with fragmented masked messages
We didn't have proper coverage for these cases. Add mask and large payload coverage for the reported cases since they would come through as 0 instead of the correct size.
fixes #10763
regressed in #10747
| 2025-04-21T05:46:19Z | When the client sends a relatively large bytes data packet to the server, the server will receive zero length message.
### Describe the bug
If the client sends a 20M bytes message, the server will receive zero length message.
The 3.11.16 version works fine.
### To Reproduce
1. Start a WebSocket server, when a reque... | Thanks for the report. I'll take a look in the morning when I get up
20022767 byte message
confirmed the reproducer. yanked 3.11.17
Will fix it in the morning. I have a good idea whats wrong | [
{
"body": "### Describe the bug\n\nIf the client sends a 20M bytes message, the server will receive zero length message.\n\nThe 3.11.16 version works fine.\n\n### To Reproduce\n\n1. Start a WebSocket server, when a request is received, create a WebSocket object \"ws = web.WebSocketResponse(max_msg_size = 0)\"\n... | d8847995b517af8a1b52d2dd6c2e1eec77f17ba9 | {
"head_commit": "004a8725de9db6f6eadbdf2daa5df0941b4d3d0a",
"head_commit_message": "lint",
"patch_to_review": "diff --git a/CHANGES/10764.bugfix.rst b/CHANGES/10764.bugfix.rst\nnew file mode 100644\nindex 00000000000..43a34295353\n--- /dev/null\n+++ b/CHANGES/10764.bugfix.rst\n@@ -0,0 +1,3 @@\n+Fixed reading fra... | [
{
"diff_hunk": "@@ -458,8 +458,7 @@ def _feed_data(self, data: bytes) -> None:\n self._payload_fragments.append(data_cstr[f_start_pos:f_end_pos])\n if self._has_mask:\n assert self._frame_mask is not None\n- payload_bytearray... | 23beaa1f4ea20f62d05dbd5b8946febe067341fd | diff --git a/CHANGES/10764.bugfix.rst b/CHANGES/10764.bugfix.rst
new file mode 100644
index 00000000000..04cd71cd190
--- /dev/null
+++ b/CHANGES/10764.bugfix.rst
@@ -0,0 +1,3 @@
+Fixed reading fragmented WebSocket messages when the payload was masked -- by :user:`bdraco`.
+
+The problem first appeared in 3.11.17
diff -... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
PostHog__posthog-10187@dde81ff | PostHog/posthog | Python | 10,187 | feat(apps): Make `setupPlugin` errors `RetryError`-only and send "fatal app error" email | ## Changes
Resolves #6850 by sending an email whenever a ~~plugin~~ app is disabled by the system due to a VM initialization error (usually in `setupPlugin`). Also makes it so that only `RetryError` result in `setupPlugin` being retried. Both of these are part of the https://github.com/PostHog/posthog/issues/8829#i... | 2022-06-07T19:32:34Z | Send an alert when a plugin gets autodisabled
Currently when a plugin errors, it gets autodisabled. This is however completely silent and easy to miss. The result can be degraded data quality or a hole in data in case of export plugins – something to be fixed ASAP.
A PagerDuty integration could come in useful here, ... | [
{
"body": "Currently when a plugin errors, it gets autodisabled. This is however completely silent and easy to miss. The result can be degraded data quality or a hole in data in case of export plugins – something to be fixed ASAP.\r\n\r\nA PagerDuty integration could come in useful here, allowing an alert to be... | 6d2f388d2f444eab6bc9b2d149be2f1ac75d1ac0 | {
"head_commit": "dde81ffe2bc527793470ac32d4d03b80fc728b8f",
"head_commit_message": "Update comment to be accurate",
"patch_to_review": "diff --git a/plugin-server/src/config/constants.ts b/plugin-server/src/config/constants.ts\nindex 18cf4e66e2339..6b932bf3cdd3a 100644\n--- a/plugin-server/src/config/constants.t... | [
{
"diff_hunk": "@@ -0,0 +1,26 @@\n+{% extends \"email/base_transactional.html\" %} {% load posthog_assets %} {% load posthog_filters %}\n+{% block heading %}Fatal app error{% endblock %}\n+{% block section %}\n+<!-- prettier-ignore -->\n+<p>\n+ {% if is_system_error %}\n+ A system error has prevented ... | 9c4863ed037e2cf8e835c4c97fadc4dd318a80f8 | diff --git a/plugin-server/src/config/constants.ts b/plugin-server/src/config/constants.ts
index 18cf4e66e2339..6b932bf3cdd3a 100644
--- a/plugin-server/src/config/constants.ts
+++ b/plugin-server/src/config/constants.ts
@@ -1,7 +1,7 @@
import { logLevel } from 'kafkajs'
export const ONE_HOUR = 60 * 60 * 1000
-
+ex... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
aio-libs__aiohttp-10300@54440fe | aio-libs/aiohttp | Python | 10,300 | Use kwargs in aiohttp.client.request | ## What do these changes do?
Make `aiohttp.client.request` use kwargs to let it accept parameters defined in `_RequestOptions` like `ssl`.
## Are there changes in behavior for the user?
## Is it a substantial burden for the maintainers to support this?
## Related issue number
Fixes #10077
## Checklis... | 2025-01-06T12:42:19Z | aiohttp.request() got an unexpected keyword argument 'ssl'
### Is your feature request related to a problem?
I want to use `aiohttp.request()` function with a `ssl=False` argument.
### Describe the solution you'd like
Add `ssl` argument for `aiohttp.request()` function.
### Describe alternatives you've considered
... | If someone wants to create a PR to switch that function to using kwargs, same as the client method (https://github.com/aio-libs/aiohttp/blob/1fa237ffc9e7aa70cbabb68ab64d6fe03255cbc0/aiohttp/client.py#L398-L407), then that'll fix these missing parameters in future. | [
{
"body": "### Is your feature request related to a problem?\n\nI want to use `aiohttp.request()` function with a `ssl=False` argument.\n\n### Describe the solution you'd like\n\nAdd `ssl` argument for `aiohttp.request()` function.\n\n### Describe alternatives you've considered\n\nNo.\n\n### Related component\n... | 3d3fba23cf543f7185658f52097f21093bf64c7c | {
"head_commit": "54440fe002f5a7ed88e8f5c98e766a37cdcdbb3d",
"head_commit_message": "add changelog",
"patch_to_review": "diff --git a/CHANGES/10300.feature.rst b/CHANGES/10300.feature.rst\nnew file mode 100644\nindex 00000000000..31d5e6ff154\n--- /dev/null\n+++ b/CHANGES/10300.feature.rst\n@@ -0,0 +1,2 @@\n+Updat... | [
{
"diff_hunk": "@@ -1375,104 +1375,75 @@ async def __aexit__(\n await self._session.close()\n \n \n-def request(\n- method: str,\n- url: StrOrURL,\n- *,\n- params: Query = None,\n- data: Any = None,\n- json: Any = None,\n- headers: Optional[LooseHeaders] = None,\n- skip_auto_head... | 5fc22cc3504d9c370b2c2204c23a0cb9be40d83e | diff --git a/CHANGES/10300.feature.rst b/CHANGES/10300.feature.rst
new file mode 100644
index 00000000000..3632c3d41a7
--- /dev/null
+++ b/CHANGES/10300.feature.rst
@@ -0,0 +1,2 @@
+Update :py:func:`~aiohttp.request` to make it accept ``_RequestOptions`` kwargs.
+-- by :user:`Cycloctane`.
diff --git a/aiohttp/client.py... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
agno-agi__agno-3056@2673bde | agno-agi/agno | Python | 3,056 | [Fix] Fix issues in Workflows when loading sessions with new default memory | ## Summary
Fix issues in Workflows when loading sessions with new default memory
Fixes #3046
## Type of change
- [x] Bug fix
- [ ] New feature
- [ ] Breaking change
- [ ] Improvement
- [ ] Model update
- [ ] Other:
---
## Checklist
- [ ] Code complies with style guidelines
- [ ] Ran format/v... | 2025-05-02T12:43:35Z | [Bug]
# Description
Running a workflow from a previous version of agno fails on new version. It seems workflow session_ids cannot be re-used after upgrading. I'm not sure if this is intended to be supported behavior
## Steps to Reproduce
1. Run a workflow with an agno version < 1.4 (before the new memories were implem... | [
{
"body": "# Description\nRunning a workflow from a previous version of agno fails on new version. It seems workflow session_ids cannot be re-used after upgrading. I'm not sure if this is intended to be supported behavior\n\n## Steps to Reproduce\n1. Run a workflow with an agno version < 1.4 (before the new mem... | c42993770e6d217037167d0ac08fd3e01294063c | {
"head_commit": "2673bdec4d86ff496fca42a9fb91303fcad31fe5",
"head_commit_message": "Update",
"patch_to_review": "diff --git a/cookbook/workflows/team_workflow.py b/cookbook/workflows/team_workflow.py\nindex e7f6152ad3..8ed3c7f65e 100644\n--- a/cookbook/workflows/team_workflow.py\n+++ b/cookbook/workflows/team_wo... | [
{
"diff_hunk": "@@ -2057,10 +2057,11 @@ def add_tools_to_model(\n func.tool_hooks = self.tool_hooks\n _functions_for_model[func.name] = func\n _tools_for_model.append({\"type\": \"function\", \"function\": func.t... | 4b074636c8c3ff9b06a5d21705fc9dce2bcc8aea | diff --git a/cookbook/workflows/team_workflow.py b/cookbook/workflows/team_workflow.py
index e7f6152ad3..8ed3c7f65e 100644
--- a/cookbook/workflows/team_workflow.py
+++ b/cookbook/workflows/team_workflow.py
@@ -3,6 +3,7 @@
from agno.agent import Agent, RunResponse
from agno.models.openai import OpenAIChat
+from agn... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
autogluon__autogluon-5078@3a41425 | autogluon/autogluon | Python | 5,078 | [timeseries] Add cutoff support in evaluate and leaderboard | *Issue #, if available:* fixes #4356
*Description of changes:* This PR adds support for `cutoff` in `TimeSeriesPredictor.evaluate` and `TimeSeriesPredictor.leaderboard`.
TODOs:
- [x] Add support in `leaderboard`
- [x] Add tests
- [x] Update docstrings
By submitting this pull request, I confirm that yo... | 2025-04-22T14:17:36Z | [timeseries] Allow choosing custom cutoff in `evaluate` and `leaderboard`
## Description
Currently, methods like `evaluate()` and `leaderboard()` always use the last `prediction_length` time steps of each time series as the test. If users want to perform some more sophisticated evaluation, they need to define complex ... | [
{
"body": "## Description\r\nCurrently, methods like `evaluate()` and `leaderboard()` always use the last `prediction_length` time steps of each time series as the test. If users want to perform some more sophisticated evaluation, they need to define complex splitting logic outside of the predictor. We can simp... | 4e7c1aae32b9e6d24bdf0dd86cc03d754f5cc44e | {
"head_commit": "3a41425001925a9f6f1a82957161333785631323",
"head_commit_message": "Only modify predictor",
"patch_to_review": "diff --git a/timeseries/src/autogluon/timeseries/predictor.py b/timeseries/src/autogluon/timeseries/predictor.py\nindex 7e1404f9980..b2ddbccadfa 100644\n--- a/timeseries/src/autogluon/t... | [
{
"diff_hunk": "@@ -844,6 +861,7 @@ def predict(\n def evaluate(\n self,\n data: Union[TimeSeriesDataFrame, pd.DataFrame, Path, str],\n+ cutoff: Optional[int] = None,",
"line": null,
"original_line": 864,
"original_start_line": null,
"path": "timeseries/src/autogluon/t... | 21cfe57cafac65afea4f405cd3b84ff7e784b021 | diff --git a/timeseries/src/autogluon/timeseries/predictor.py b/timeseries/src/autogluon/timeseries/predictor.py
index 7e1404f9980..14671e5e451 100644
--- a/timeseries/src/autogluon/timeseries/predictor.py
+++ b/timeseries/src/autogluon/timeseries/predictor.py
@@ -305,15 +305,32 @@ def _check_and_prepare_data_frame(
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
aio-libs__aiohttp-9029@23ce54f | aio-libs/aiohttp | Python | 9,029 | Fix SSLContext creation in the TCPConnector with multiple loops | Creation of the SSLContexts did not account for multiple event loops in different threads.
Creation is now done at import time to ensure it does not block the event loop.
fixes #9020
| 2024-09-05T15:38:05Z | Incorrect re-use future in _make_or_get_ssl_context
### Describe the bug
I meet following error:
```
RuntimeError: Task <Task pending name='Task-2' coro=<async_connect() running at <ipython-input-1-ba65b5596d34>:18>> got Future <Future pending> attached to a different loop
```
After going through the code, it se... | Thats definitely going to be a problem.
This one might be a bit tricky to fix.
It would be very helpful to get to a solution quicker if you could provide an xfail test for this case.
Generally, you shouldn't have multiple loops, which is probably why nobody else has noticed the issue so far.
But, I agree this loo... | [
{
"body": "### Describe the bug\r\n\r\nI meet following error:\r\n```\r\nRuntimeError: Task <Task pending name='Task-2' coro=<async_connect() running at <ipython-input-1-ba65b5596d34>:18>> got Future <Future pending> attached to a different loop\r\n```\r\nAfter going through the code, it seems the bug is caused... | e8d8e285df058426a2743802accfe1bc4318caa9 | {
"head_commit": "23ce54f3eb398dded3272d98717b0bcc73cb5527",
"head_commit_message": "make sure test passes with http and not https",
"patch_to_review": "diff --git a/tests/test_connector.py b/tests/test_connector.py\nindex d66bc214ed2..2873645be6b 100644\n--- a/tests/test_connector.py\n+++ b/tests/test_connector.... | [
{
"diff_hunk": "@@ -9,13 +9,15 @@\n import sys\n import uuid\n from collections import deque\n+from concurrent.futures import ThreadPoolExecutor, as_completed",
"line": null,
"original_line": 12,
"original_start_line": null,
"path": "tests/test_connector.py",
"start_line": null,
"text": ... | bd44036db2123857fe50971afabb00e531e745a7 | diff --git a/aiohttp/connector.py b/aiohttp/connector.py
index 261cd28e12b..ffaaa653022 100644
--- a/aiohttp/connector.py
+++ b/aiohttp/connector.py
@@ -51,14 +51,7 @@
)
from .client_proto import ResponseHandler
from .client_reqrep import SSL_ALLOWED_TYPES, ClientRequest, Fingerprint
-from .helpers import (
- _SE... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
aio-libs__aiohttp-8947@b2a184e | aio-libs/aiohttp | Python | 8,947 | Add aiohttp.tracing.TraceRequestHeadersSentParams into the top level file. | <!-- Thank you for your contribution! -->
## What do these changes do?
Add aiohttp.tracing.TraceRequestHeadersSentParams into the top level file
<!-- Please give a short brief about these changes. -->
## Are there changes in behavior for the user?
Typehints change from aiohttp.tracing.TraceRequestHeadersSent... | 2024-08-30T18:16:26Z | on_request_headers_sent params type was never imported into the top-level file.
### Describe the bug
aiohttp.tracing.TraceRequestHeadersSentParams exists in aiohttp/tracing.py, but wasn't imported into \__main_\_.py like the other param types.
### To Reproduce
# file: main.py
import aiohttp
from types import Simpl... | As you've already identified the solution, it'd be great if you could just put the fix in a PR.
> As you've already identified the solution, it'd be great if you could just put the fix in a PR.
If you've said this 4 minutes earlier I'd be able to 😅
Rest assured I'll get on a pc in ~30 minutes and make one. | [
{
"body": "### Describe the bug\n\naiohttp.tracing.TraceRequestHeadersSentParams exists in aiohttp/tracing.py, but wasn't imported into \\__main_\\_.py like the other param types.\n\n### To Reproduce\n\n# file: main.py\r\nimport aiohttp\r\nfrom types import SimpleNamespace\r\n\r\ntrace_config = aiohttp.TraceCon... | 76a00d1ed405c87cf33c66f91d410c95e57c0312 | {
"head_commit": "b2a184ebfe2d1765d2921fe6779d10c8f67fe6af",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/aiohttp/__init__.py b/aiohttp/__init__.py\nindex 43025000315..7a9faa8b44d 100644\n--- a/ai... | [
{
"diff_hunk": "@@ -216,7 +217,7 @@\n \"TraceRequestChunkSentParams\",\n \"TraceRequestEndParams\",\n \"TraceRequestExceptionParams\",\n- \"TraceRequestRedirectParams\",\n+ \"TraceRequestHeadersSentParams\" \"TraceRequestRedirectParams\",",
"line": null,
"original_line": 220,
"orig... | 925e9cf95d876fafd63c23c75104b9b45d451084 | diff --git a/CHANGES/8947.misc.rst b/CHANGES/8947.misc.rst
new file mode 100644
index 00000000000..277ba915c50
--- /dev/null
+++ b/CHANGES/8947.misc.rst
@@ -0,0 +1 @@
+Exported ``aiohttp.TraceRequestHeadersSentParams`` -- by :user:`Hadock-is-ok`.
diff --git a/aiohttp/__init__.py b/aiohttp/__init__.py
index 43025000315.... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
agno-agi__agno-2450@5f9504e | agno-agi/agno | Python | 2,450 | show_tool_calls in seperate block | ## Description
- **Summary of changes**: `show_tool_calls` in seperate blocks instead of in the Response block
- **Related issues**: Mention if this PR fixes or is connected to any issues.
- **Motivation and context**: Explain the reason for the changes and the problem they solve.
- **Environment or dependencies*... | 2025-03-18T21:42:52Z | [Bug]Failed to load resource: the server responded with a status of 404 ()
# Description
**Failed to load resource: the server responded with a status of 404 ()**
## Steps to Reproduce
just run demo AI Finance Agent Team with Web Access
## Agent Configuration (if applicable)
Provide relevant agent configuration.
##... | [
{
"body": "# Description\n**Failed to load resource: the server responded with a status of 404 ()**\n\n## Steps to Reproduce\njust run demo AI Finance Agent Team with Web Access\n\n## Agent Configuration (if applicable)\nProvide relevant agent configuration.\n\n## Expected Behavior\nWhat did you expect to happ... | fb96b99efaf759c85d4e21ea5ffadcf0d2665242 | {
"head_commit": "5f9504ef49bb639f3d3a14bb509ca9818c717727",
"head_commit_message": "fix formatting",
"patch_to_review": "diff --git a/libs/agno/agno/agent/agent.py b/libs/agno/agno/agent/agent.py\nindex 22bd6de1a0..5663b9860b 100644\n--- a/libs/agno/agno/agent/agent.py\n+++ b/libs/agno/agno/agent/agent.py\n@@ -6... | [
{
"diff_hunk": "@@ -990,21 +990,22 @@ def _show_tool_calls(self, function_calls_to_run: List[FunctionCall], model_resp\n \"\"\"\n Show tool calls in the model response.\n \"\"\"\n+ # Only add to content for regular text responses\n if len(function_calls_to_run) == 1:\n ... | da69709d1abcb5a735865ec01e19f8dac137c59d | diff --git a/cookbook/examples/apps/vision_ai/app.py b/cookbook/examples/apps/vision_ai/app.py
index a8062dac89..14d509b812 100644
--- a/cookbook/examples/apps/vision_ai/app.py
+++ b/cookbook/examples/apps/vision_ai/app.py
@@ -11,7 +11,6 @@
from agno.utils.log import logger
from dotenv import load_dotenv
from prompt... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
agno-agi__agno-2102@53d1a77 | agno-agi/agno | Python | 2,102 | Update lancedb and gemini embedder | ## Description
This makes a small update to Lance DB and update GeminiEmbedder to using the latest Gemini SDK
Fixes #1865
---
## Type of change
Please check the options that are relevant:
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functional... | 2025-02-13T09:19:05Z | ValueError: Vector column vector has variable length vectors Set on_bad_vectors='drop' to remove them, or set on_bad_vectors='fill' and fill_value=<value> to replace them.
Code:
```
txt_path = "/media/ahamad/ontent_large_pdf"
# # html_paths = get_sds_paths(pdf_dir, extn=".html")
# chunking_strategy=SemanticChunking(... | @AhmadShaik can you please confirm with me if you are using Phidata or Agno? If Phidata then what version are you using right now? If Agno then can you please share the complete code with imports as well?
Got the same error using phidata 2.7.10 and Python 3.12.
Code:
```
from phi.agent import Agent
from phi.embedder.o... | [
{
"body": "Code:\n\n```\ntxt_path = \"/media/ahamad/ontent_large_pdf\"\n# # html_paths = get_sds_paths(pdf_dir, extn=\".html\") \n# chunking_strategy=SemanticChunking()\n\n# vector_db=PgVector(\n# table_name=\"autozone_documents\",\n# db_url=\"postgresql+psycopg://ai:ai@localhost:5432/ai\",\n# embe... | 8df14ad340f63b6c31c15974dfd8c5ed20a41751 | {
"head_commit": "53d1a77c882091b721c2d139ca7b520a43b55f69",
"head_commit_message": "Merge",
"patch_to_review": "diff --git a/cookbook/agent_concepts/knowledge/vector_dbs/lance_db.py b/cookbook/agent_concepts/knowledge/vector_dbs/lance_db.py\nindex ae0486db61..4291b00b1b 100644\n--- a/cookbook/agent_concepts/know... | [
{
"diff_hunk": "@@ -17,7 +17,7 @@\n vector_db=vector_db,\n )\n \n-knowledge_base.load(recreate=False) # Comment out after first run\n+knowledge_base.load(recreate=True) # Comment out after first run",
"line": null,
"original_line": 20,
"original_start_line": null,
"path": "cookbook/agent_c... | 9141d3eb53a01acd5feef137cacd692ff6f28c45 | diff --git a/cookbook/agent_concepts/knowledge/vector_dbs/lance_db.py b/cookbook/agent_concepts/knowledge/vector_dbs/lance_db.py
index ae0486db61..78a1cfc437 100644
--- a/cookbook/agent_concepts/knowledge/vector_dbs/lance_db.py
+++ b/cookbook/agent_concepts/knowledge/vector_dbs/lance_db.py
@@ -8,7 +8,7 @@
# By default... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
aio-libs__aiohttp-8632@ad51c59 | aio-libs/aiohttp | Python | 8,632 | Fix connecting to npipe://, tcp://, and unix:// urls | <!-- Thank you for your contribution! -->
## What do these changes do?
Fixes a regression in 3.10.x connecting to `npipe://`, `tcp://`, and `unix://` urls
A future PR should remove `allowed_protocol_schema_set` in `BaseConnector` as its only there for backwards compat
## Are there changes in behavior for th... | 2024-08-07T14:05:03Z | Error while trying to use unix socket, when `aiohttp`>=3.10
## Long story short
<!-- Please describe your problem and why the fix is important. -->
* Expected behaviour: Communicating via unix socket should work.
* Actual behaviour: Error. Its traceback:
```
Traceback (most recent call last):
File "/tmp/aio... | Likely similar to https://github.com/aio-libs/aiohttp/pull/8482
+1
I actually didn't realise the client can make unix socket requests.
Looking at the connectors, there is UnixConnector and also NamedPipeConnector. It is also possible to create custom connectors...
Maybe we need the connector to define what a vali... | [
{
"body": "## Long story short\r\n\r\n<!-- Please describe your problem and why the fix is important. -->\r\n\r\n* Expected behaviour: Communicating via unix socket should work.\r\n* Actual behaviour: Error. Its traceback:\r\n```\r\nTraceback (most recent call last):\r\n File \"/tmp/aiodocker_fail/example.py\"... | e0ff5246e1d29b7710ab1a2bbc972b48169f1c05 | {
"head_commit": "ad51c597961a6d08dc6d22fbf4106655456d9321",
"head_commit_message": "Update aiohttp/client.py",
"patch_to_review": "diff --git a/CHANGES/8632.bugfix.rst b/CHANGES/8632.bugfix.rst\nnew file mode 100644\nindex 00000000000..c6da81d7ab3\n--- /dev/null\n+++ b/CHANGES/8632.bugfix.rst\n@@ -0,0 +1 @@\n+Fi... | [
{
"diff_hunk": "@@ -791,6 +812,11 @@ def _close_immediately(self) -> List[\"asyncio.Future[None]\"]:\n ev.cancel()\n return super()._close_immediately()\n \n+ @cached_property\n+ def allowed_protocol_schema_set(self) -> FrozenSet[str]:\n+ \"\"\"Return allowed protocol schema set... | 3bbf44879967db38c5e16d0c4e391eb1523c8e32 | diff --git a/CHANGES/8632.bugfix.rst b/CHANGES/8632.bugfix.rst
new file mode 100644
index 00000000000..c6da81d7ab3
--- /dev/null
+++ b/CHANGES/8632.bugfix.rst
@@ -0,0 +1 @@
+Fixed connecting to ``npipe://``, ``tcp://``, and ``unix://`` urls -- by :user:`bdraco`.
diff --git a/aiohttp/client.py b/aiohttp/client.py
index ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
aio-libs__aiohttp-8482@be8f71e | aio-libs/aiohttp | Python | 8,482 | Fix incorrect rejection of ws:// and wss:// urls | This is because libraries like discord.py needs to use a wss type of url to make a socket to an api service, and it cannot be done outside of aiohttp as it can block the async event loop which can result in undefined behavior.
Test will arrive soon.
<!-- Thank you for your contribution! -->
## What do these ch... | 2024-07-04T23:00:48Z | 3.10.0 and 4.0.0 incorrectly reject wss:// urls
### Describe the bug
In discord.py a single wss:// type url is needed to create a websocket using aiohttp to discord's api. This both allows for new and resumed connections.
```
Traceback (most recent call last):
File "client.py", line 664, in connect
File "a... | Hi @AraHaan
Thanks for reporting this issue.
Would you be able to open a PR to an [xfail test](https://docs.pytest.org/en/stable/how-to/skipping.html#xfail-mark-test-functions-as-expected-to-fail) to show this issue?
I already found the fix as well. Changing line 180 in client.py to add ``"wss"`` before the ``""... | [
{
"body": "### Describe the bug\r\n\r\nIn discord.py a single wss:// type url is needed to create a websocket using aiohttp to discord's api. This both allows for new and resumed connections.\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"client.py\", line 664, in connect\r\n File \"asyncio\\task... | fbc11c670307ae29464289a538e3d525f5c07f78 | {
"head_commit": "be8f71ea87d580a7b139401933adeb739395992a",
"head_commit_message": "lint",
"patch_to_review": "diff --git a/CHANGES/8481.bugfix.rst b/CHANGES/8481.bugfix.rst\nnew file mode 100644\nindex 00000000000..b185780174e\n--- /dev/null\n+++ b/CHANGES/8481.bugfix.rst\n@@ -0,0 +1,2 @@\n+Fixed the incorrect ... | [
{
"diff_hunk": "@@ -467,6 +467,60 @@ async def create_connection(req, traces, timeout):\n c.__del__()\n \n \n+@pytest.mark.parametrize(\"protocol\", [\"http\", \"https\", \"ws\", \"wss\"])\n+async def test_ws_connect_allowed_protocols(\n+ create_session: Any,\n+ create_mocked_conn: Any,\n+ prot... | b16e5ae10382f0c388f919f5febb2c2d54180df2 | diff --git a/CHANGES/8481.bugfix.rst b/CHANGES/8481.bugfix.rst
new file mode 100644
index 00000000000..b185780174e
--- /dev/null
+++ b/CHANGES/8481.bugfix.rst
@@ -0,0 +1,2 @@
+Fixed the incorrect rejection of ``ws://`` and ``wss://`` urls
+-- by :user:` AraHaan`.
diff --git a/aiohttp/client.py b/aiohttp/client.py
index... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
agno-agi__agno-1976@8e7d600 | agno-agi/agno | Python | 1,976 | Stateless models | ## Description
- Make the models stateless
- [Notes here](https://www.notion.so/Models-refactor-18d733793ba280a99069d7104f9813a3?pvs=4)
Fixes: #2054
---
## Type of change
Please check the options that are relevant:
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaki... | 2025-02-01T23:54:11Z | [Bug]
# Description
Re-using a model across multiple agents, each with different a `response_model` causes the first agent's `response_model` to persist to the following agents.
## Steps to Reproduce
```python
from agno.agent import Agent
from pydantic import BaseModel
model_client = OpenAIChat(id="gpt-4o")
class Ag... | [
{
"body": "# Description\nRe-using a model across multiple agents, each with different a `response_model` causes the first agent's `response_model` to persist to the following agents.\n\n## Steps to Reproduce\n```python\nfrom agno.agent import Agent\nfrom pydantic import BaseModel\n\nmodel_client = OpenAIChat(i... | e6435d8b52aacf2ade74d62360b880fb50410b95 | {
"head_commit": "8e7d6003e9cb5ac5471a18a6d5752e23fdc7dc21",
"head_commit_message": "Use SessionMetrics",
"patch_to_review": "diff --git a/cookbook/agent_concepts/other/agent_metrics.py b/cookbook/agent_concepts/other/agent_metrics.py\nindex 69cda42ea7..185e95fa36 100644\n--- a/cookbook/agent_concepts/other/agent... | [
{
"diff_hunk": "@@ -238,60 +204,6 @@ def _get_function_calls_to_run(\n function_calls_to_run.append(_function_call)\n return function_calls_to_run\n \n- def add_tool(",
"line": 244,
"original_line": 244,
"original_start_line": null,
"path": "libs/agno/agno/models/base.... | 84bd7e3973f3f0d4f9e2627d3b6d4713dc3b73e1 | diff --git a/.gitignore b/.gitignore
index 2d2c8deb1c..08fc755d2d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -15,6 +15,7 @@
# Machine specific
.idea
.vscode
+*.code-workspace
# Ignore .env files
.env
diff --git a/agno.code-workspace b/agno.code-workspace
deleted file mode 100644
index 1e3fd025ca..0000000000
---... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
aio-libs__aiohttp-8463@c8368cf | aio-libs/aiohttp | Python | 8,463 | Add full request typing signatures for session HTTP methods | <!-- Thank you for your contribution! -->
## What do these changes do?
Improve the request typing by using 3.11's new `Unpack` operator to properly type the kwargs that live on each HTTP method. Using `typing_extensions`, this is supported on older versions of Python as well.
To do this, I did add `typing-ext... | 2024-06-15T17:49:32Z | ClientSession post and get methods doesn't have full signature
🐣 **Is your feature request related to a problem? Please describe.**
It seems inconvenient that you don't know the signature of a method when using it. If you are coming from different libraries, like request or maybe you've used the aiohttp Client some t... | If anybody would like to work on this, we can now use `Unpack` with mypy 1.7:
https://docs.python.org/3/library/typing.html#typing.Unpack
This will allow us to specify all the kwarg types in one place and have them used for all the methods needed. | [
{
"body": "🐣 **Is your feature request related to a problem? Please describe.**\r\nIt seems inconvenient that you don't know the signature of a method when using it. If you are coming from different libraries, like request or maybe you've used the aiohttp Client some time ago, you kinda know that there is prob... | 8504b719b9d78f4dcf112445ff7d4cd429466afd | {
"head_commit": "c8368cf59d672febb7f88b2b017a1997c28491ef",
"head_commit_message": "Avoid overloading",
"patch_to_review": "diff --git a/CHANGES/8463.misc.rst b/CHANGES/8463.misc.rst\nnew file mode 100644\nindex 00000000000..1d42136ebd7\n--- /dev/null\n+++ b/CHANGES/8463.misc.rst\n@@ -0,0 +1 @@\n+Added a 3.11-sp... | [
{
"diff_hunk": "@@ -986,61 +1016,112 @@ def _prepare_headers(self, headers: Optional[LooseHeaders]) -> \"CIMultiDict[str]\n added_names.add(key)\n return result\n \n- def get(\n- self, url: StrOrURL, *, allow_redirects: bool = True, **kwargs: Any\n- ) -> \"_RequestContex... | 703e89f3ed0cc31f3aeadac46ead0e294c46d107 | diff --git a/CHANGES/8463.misc.rst b/CHANGES/8463.misc.rst
new file mode 100644
index 00000000000..1d42136ebd7
--- /dev/null
+++ b/CHANGES/8463.misc.rst
@@ -0,0 +1 @@
+Added a 3.11-specific overloads to ``ClientSession`` -- by :user:`max-muoto`.
diff --git a/aiohttp/client.py b/aiohttp/client.py
index 7a4db0db476..4c0... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
aio-libs__aiohttp-8456@06b7287 | aio-libs/aiohttp | Python | 8,456 | Add ClientConnectorDNSError for differentiating DNS errors from others | ## What do these changes do?
Adds a ClientConnectorError that's specific to DNS resolution errors. See #8455
## Are there changes in behavior for the user?
Existing usages should still keep working the same as before since this extends from ClientConnectorError.
Users can now catch ClientConnectorDNSError if ... | 2024-06-11T19:10:22Z | Separate exception for DNS errors
### Is your feature request related to a problem?
Currently the aiohttp client raises a `ClientConnectorError` when DNS resolution fails and there's no clean way to differentiate this `ClientConnectorError` from ones that happen at other points of the connection.
### Describe the sol... | [
{
"body": "### Is your feature request related to a problem?\n\nCurrently the aiohttp client raises a `ClientConnectorError` when DNS resolution fails and there's no clean way to differentiate this `ClientConnectorError` from ones that happen at other points of the connection.\n\n### Describe the solution you'd... | 216e082807d02fafaacca57fc883c86826b126d3 | {
"head_commit": "06b7287a25dbfd16200ad77e05ceb751ccfd79a9",
"head_commit_message": "Update CONTRIBUTORS.txt",
"patch_to_review": "diff --git a/CHANGES/8455.feature.rst b/CHANGES/8455.feature.rst\nnew file mode 100644\nindex 00000000000..fa2e41ff132\n--- /dev/null\n+++ b/CHANGES/8455.feature.rst\n@@ -0,0 +1 @@\n+... | [
{
"diff_hunk": "@@ -3315,6 +3315,23 @@ async def test_aiohttp_request_ctx_manager_not_found() -> None:\n assert False, \"never executed\" # pragma: no cover\n \n \n+async def test_aiohttp_request_ctx_manager_not_found_exception_is_dns_specific() -> (\n+ None\n+):\n+ # The error raised should ... | 8d309c0a62da89faa40b660f0cb6c0970b518216 | diff --git a/CHANGES/8455.feature.rst b/CHANGES/8455.feature.rst
new file mode 100644
index 00000000000..267e5243afa
--- /dev/null
+++ b/CHANGES/8455.feature.rst
@@ -0,0 +1 @@
+Added :exc:`aiohttp.ClientConnectorDNSError` for differentiating DNS resolution errors from other connector errors -- by :user:`mstojcevich`.
d... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
autogluon__autogluon-1504@d438c60 | autogluon/autogluon | Python | 1,504 | Validate unique indices for various API | *Issue #, if available:*
https://github.com/awslabs/autogluon/issues/1418
*Description of changes:*
Raise exception if duplicate index found in the data. Previously this check was done only for `fit`, added this check to other APIs
By submitting this pull request, I confirm that you can use, modify, copy, and r... | 2022-01-20T21:48:25Z | Error on feature_importance
Hi.
I use the latest version of the library. I trained the model.
When I try to call the feature_importance method like this I get the result and everything is ok (87527 - number of rows).
`my_model.feature_importance(data=testset, subsample_size=87527, num_shuffle_sets=30)`
When I try... | Hello! The same with me. I fit a model with 'XGB', 'CAT', 'RF', 'XT', 'FASTAI' as hyperparameters. When try to get feature_importance() I receive the same:
`ValueError: Found input variables with inconsistent numbers of samples: [28087, 1000]`
feature_importance() work only if I set subsample_size=None which mean... | [
{
"body": "Hi.\r\nI use the latest version of the library. I trained the model.\r\nWhen I try to call the feature_importance method like this I get the result and everything is ok (87527 - number of rows).\r\n`my_model.feature_importance(data=testset, subsample_size=87527, num_shuffle_sets=30)`\r\n\r\nWhen I tr... | 6738ea04ac3ee0ee2daa0d7caf0e16e5ed67f966 | {
"head_commit": "d438c60029be51e1bf448cf9a0d0a923e19b524b",
"head_commit_message": "remove unnecessary checks",
"patch_to_review": "diff --git a/tabular/src/autogluon/tabular/predictor/predictor.py b/tabular/src/autogluon/tabular/predictor/predictor.py\nindex d4678bfa37fe..a6e8dc4da325 100644\n--- a/tabular/src/... | [
{
"diff_hunk": "@@ -1861,9 +1863,7 @@ def feature_importance(self, data=None, model=None, features=None, feature_stage\n if (data is None) and (not self._trainer.is_data_saved):\n raise AssertionError(\n 'No data was provided and there is no cached data to load for feature im... | 7e0922cae1f37f28bd333d790d0fcbd874654db9 | diff --git a/tabular/src/autogluon/tabular/predictor/predictor.py b/tabular/src/autogluon/tabular/predictor/predictor.py
index d4678bfa37fe..6f226fe902d6 100644
--- a/tabular/src/autogluon/tabular/predictor/predictor.py
+++ b/tabular/src/autogluon/tabular/predictor/predictor.py
@@ -1228,6 +1228,8 @@ def fit_pseudolabel... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
autogluon__autogluon-2493@4c765ea | autogluon/autogluon | Python | 2,493 | [CI] Split multimodal tutorial build into multiple usecases | *Issue #, if available:*
[Issue-2428](https://github.com/autogluon/autogluon/issues/2428)
*Description of changes:*
Split multimodal tutorial build into multiple use cases so that they can run in parallel
Sample [run](https://github.com/tonyhoo/ci-test/actions/runs/3571586899) after split in forked repo
By... | 2022-11-29T06:20:08Z | [Post 0.6] Speed up AutoMM tutorial build
Currently as of v0.6 release, AutoMM tutorials take >90 minutes to run, accounting for ~75% of the wall-clock time of the CI. This is too long and makes development cumbersome.
It should be shorted to ideally wall-clock 30 minutes, and 45 minutes at most. | Can we separate the tutorial build pipeline to build tutorial for each folder under "multimodal"?
- [text_prediction](https://github.com/awslabs/autogluon/tree/master/docs/tutorials/multimodal/text_prediction)
- [object_detection](https://github.com/awslabs/autogluon/tree/master/docs/tutorials/multimodal/object_det... | [
{
"body": "Currently as of v0.6 release, AutoMM tutorials take >90 minutes to run, accounting for ~75% of the wall-clock time of the CI. This is too long and makes development cumbersome.\r\n\r\nIt should be shorted to ideally wall-clock 30 minutes, and 45 minutes at most.\r\n",
"number": 2428,
"title":... | 8ffb6d81bb8a4c457b78d55df7708536fa1b8567 | {
"head_commit": "4c765eaf191798aaf872a12750de0e5069251b3c",
"head_commit_message": "added index.rst on the root folder level when sub folder build enabled",
"patch_to_review": "diff --git a/.github/workflow_scripts/build_doc.sh b/.github/workflow_scripts/build_doc.sh\nindex b203c086af98..7935493a25b5 100644\n---... | [
{
"diff_hunk": "@@ -379,7 +462,7 @@ jobs:\n job-name: AutoGluon-BuildTimeseries\n command: chmod +x ./.github/workflow_scripts/build_timeseries_tutorial.sh && ./.github/workflow_scripts/build_timeseries_tutorial.sh '${{ env.BRANCH }}' '${{ env.GIT_REPO }}' '${{ env.SHORT_SHA }}' '${{ env.PR_... | 276767dfadd512994198e68967e9db67b4cb1fb4 | diff --git a/.github/workflow_scripts/build_doc.sh b/.github/workflow_scripts/build_doc.sh
index b203c086af98..7935493a25b5 100644
--- a/.github/workflow_scripts/build_doc.sh
+++ b/.github/workflow_scripts/build_doc.sh
@@ -4,6 +4,7 @@ function build_doc {
GIT_REPO="$3"
COMMIT_SHA="$4"
PR_NUMBER="$5" # F... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
autogluon__autogluon-1511@e5d6836 | autogluon/autogluon | Python | 1,511 | Various HPO Cleanup / Fixes | *Issue #, if available:*
#1031
*Description of changes:*
This PR introduces numerous code cleanup / quality of life improvements and major bug fixes to HPO logic.
- **Major Bug Fix**: HPO with bagging did not work correctly. In fact, the hyperparameters found during HPO were completely ignored for all fold mo... | 2022-01-24T03:32:42Z | Confusing error message: HPO on Random Forest
Hi,
When tuning RF with the following:
```
rf_options = {
'max_depth': ag.space.Int(5, 15),
}
```
I get the following error:
```
Hyperparameter tuning model: RandomForest_BAG_L1 ...
Warning: Exception caused RandomForest_BAG_L1 to fail duri... | Ah, good catch!
HPO is currently disabled for RF/XT/KNN models as most users are better off tuning the other model types (GBM, CAT, XGB, NN). Tuning RF/XT/KNN has a major risk of taking up many GB or TB of disk space. It seems the error message users get when trying to do HPO on them is not clear however, so this is... | [
{
"body": "Hi,\r\n\r\nWhen tuning RF with the following:\r\n\r\n```\r\n rf_options = {\r\n 'max_depth': ag.space.Int(5, 15),\r\n }\r\n```\r\n\r\nI get the following error:\r\n\r\n```\r\nHyperparameter tuning model: RandomForest_BAG_L1 ...\r\nWarning: Exception caused RandomForest_BAG_L1 to fail dur... | ec47129c2118f64733da82b45af6d6211d16c3ab | {
"head_commit": "e5d6836b55e81e7b9005aabea68835bd80316e2b",
"head_commit_message": "Cleaned HPO code of Vision models, removed default 'max_reward' limit",
"patch_to_review": "diff --git a/core/src/autogluon/core/models/abstract/abstract_model.py b/core/src/autogluon/core/models/abstract/abstract_model.py\nindex... | [
{
"diff_hunk": "@@ -147,31 +147,48 @@ def run(self, **kwargs):\n self.training_history = OrderedDict()\n self.config_history = OrderedDict()\n \n- trial_run_times = []\n+ failure_count = 0\n+ trial_count = 0\n+ trial_run_times = 0\n+ min_failure_threshold = 5\n... | 5c7c6bfc6f33b2ead6f64ffe26feb7e03e144dbd | diff --git a/core/src/autogluon/core/models/abstract/abstract_model.py b/core/src/autogluon/core/models/abstract/abstract_model.py
index af789dde2e75..e190887e1e74 100644
--- a/core/src/autogluon/core/models/abstract/abstract_model.py
+++ b/core/src/autogluon/core/models/abstract/abstract_model.py
@@ -18,11 +18,11 @@
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
autogluon__autogluon-1486@f6ca51d | autogluon/autogluon | Python | 1,486 | Clarify that eval_metric has moved from fit() to Predictor() (#1483) | *Issue #, if available:*
1483
*Description of changes:*
Clarify that eval_metric has moved from fit() to Predictor()
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| 2022-01-13T23:12:04Z | eval_metric applies to TabularPredictor() but logging and documentation says it's on fit()
This is the correct way to specify an eval_metric, on the TabularPredictor constructor:
```
predictor = TabularPredictor(label='label', eval_metric='root_mean_squared_error')
predictor.fit(dftrain)
```
But the documentation ... | You can assign this to me if you want, I will attack it at the weekend.
Good catch! eval_metric used to be in fit but was changed to init in v0.1. | [
{
"body": "This is the correct way to specify an eval_metric, on the TabularPredictor constructor:\r\n```\r\npredictor = TabularPredictor(label='label', eval_metric='root_mean_squared_error')\r\npredictor.fit(dftrain)\r\n```\r\nBut the documentation says to add it to the `fit()` call. This is both within the c... | c547550bd53b016199149326fa4989932d1f2bb0 | {
"head_commit": "f6ca51d9dab9a236faaee0ae5570c503587db325",
"head_commit_message": "Clarify that eval_metric has moved from fit() to Predictor() (#1483)",
"patch_to_review": "diff --git a/core/src/autogluon/core/trainer/abstract_trainer.py b/core/src/autogluon/core/trainer/abstract_trainer.py\nindex 22b114d7b1c7... | [
{
"diff_hunk": "@@ -1,6 +1,6 @@\n \"\"\" Example script for predicting columns of tables, demonstrating more advanced usage of fit().\n Note that all settings demonstrated here are just chosen for demonstration purposes (to minimize runtime), and do not represent wise choices to use in practice.\n- To ma... | f7e580ccd72bda8e4f1b7b9effe10b1fdb17534e | diff --git a/core/src/autogluon/core/trainer/abstract_trainer.py b/core/src/autogluon/core/trainer/abstract_trainer.py
index 22b114d7b1c7..1299f0ba4178 100644
--- a/core/src/autogluon/core/trainer/abstract_trainer.py
+++ b/core/src/autogluon/core/trainer/abstract_trainer.py
@@ -60,7 +60,7 @@ def __init__(self, path: st... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
autogluon__autogluon-1476@a57a7ea | autogluon/autogluon | Python | 1,476 | Add basic feature engineering documentation | *Issue #, if available:*
1456
*Description of changes:*
Add one card to tabular documentation on feature engineering. Mostly lists what AutoGluon does by default with a worked example. Basics on how to add your own, and a pointer to the detailed python script in examples/tabular (already written by innixma).
... | 2022-01-10T22:42:38Z | Documentation of feature engineering
Add documentation (initially just for the TabularPredictor) explaining what feature engineering AutoGluon does for the user by default:
- what is the universe of types each column can be
- how do we infer types per column
- for each type, what further feature engineering is don... | @Innixma please assign this to me.
I have a question as I work on this documentation:
- can I create hyperlinks to the source from the markdown? E.g. .. I think core/utils/utils.py might be "../../../core/src/autogluon/core/utils/utils.py". This is necessary to point people to implementation that they can't access d... | [
{
"body": "Add documentation (initially just for the TabularPredictor) explaining what feature engineering AutoGluon does for the user by default:\r\n\r\n- what is the universe of types each column can be\r\n- how do we infer types per column\r\n- for each type, what further feature engineering is done (e.g. ng... | 5776169558a18118f3daaca4addbce1a25e7eab2 | {
"head_commit": "a57a7eaca47c999ff5ca7a880473bb0736c3a8c9",
"head_commit_message": "Add basic feature engineering documentation",
"patch_to_review": "diff --git a/docs/tutorials/tabular_prediction/index.rst b/docs/tutorials/tabular_prediction/index.rst\nindex 760c5ee850fd..ae96e4db7e85 100644\n--- a/docs/tutoria... | [
{
"diff_hunk": "@@ -0,0 +1,184 @@\n+\n+:label:`sec_feature_engineering`\n+\n+### Introduction ###\n+\n+Feature engineering involves taking raw tabular data and \n+\n+1. converting it into a format ready for the machine learning model to read\n+2. trying to enhance some columns ('features' in ML jargon) to give ... | af29a5e07fed3a01f82d1154fd604551e7f5a170 | diff --git a/docs/tutorials/tabular_prediction/index.rst b/docs/tutorials/tabular_prediction/index.rst
index 760c5ee850fd..ae96e4db7e85 100644
--- a/docs/tutorials/tabular_prediction/index.rst
+++ b/docs/tutorials/tabular_prediction/index.rst
@@ -54,6 +54,12 @@ For standard datasets that are represented as tables (stor... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
autogluon__autogluon-1475@19e4397 | autogluon/autogluon | Python | 1,475 | Fix string dtype | *Issue #, if available:*
https://github.com/awslabs/autogluon/issues/957
*Description of changes:*
The issue was caused by numpy not able to recognize pandas new string dtype while autogluon inferring problem type. String dtype should be categorized as MULTICLASS
By submitting this pull request, I confirm that ... | 2022-01-10T21:21:43Z | minor issue with StringDtype dtype columns
There is minor issue with pandas dataframe with columns of pd.StringDtype dtype. If the label column is StringDtype, and the problem type is multiclass classification, AG fails. If one of the feature columns is of StringDtype, AG issues a warning, but manages to finish traini... | [
{
"body": "There is minor issue with pandas dataframe with columns of pd.StringDtype dtype. If the label column is StringDtype, and the problem type is multiclass classification, AG fails. If one of the feature columns is of StringDtype, AG issues a warning, but manages to finish training.\r\n\r\nHere is a toy... | 5776169558a18118f3daaca4addbce1a25e7eab2 | {
"head_commit": "19e43970e949f536c4d74787ccad930f8ea856cf",
"head_commit_message": "change return type",
"patch_to_review": "diff --git a/common/src/autogluon/common/features/infer_types.py b/common/src/autogluon/common/features/infer_types.py\nindex b0d3d568d2dd..4a1da03fc106 100644\n--- a/common/src/autogluon/... | [
{
"diff_hunk": "@@ -110,7 +110,10 @@ def _fit(self, X: DataFrame, X_val: DataFrame = None, X_unlabeled: DataFrame = N\n def general_data_processing(self, X: DataFrame, X_val: DataFrame, X_unlabeled: DataFrame, holdout_frac: float, num_bag_folds: int):\n \"\"\" General data processing steps used for ... | d6ad8b8938627bad8fdf0ba99f227c65812dd685 | diff --git a/common/src/autogluon/common/features/infer_types.py b/common/src/autogluon/common/features/infer_types.py
index b0d3d568d2dd..4a1da03fc106 100644
--- a/common/src/autogluon/common/features/infer_types.py
+++ b/common/src/autogluon/common/features/infer_types.py
@@ -18,6 +18,8 @@ def get_type_family_raw(dty... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
aio-libs__aiohttp-7829@75bc97b | aio-libs/aiohttp | Python | 7,829 | Index resources in the UrlDispatcher to avoid linear search for most cases | <!-- Thank you for your contribution! -->
## What do these changes do?
The time complexity of the UrlDispatcher on a hit averaged `O(n)`
The UrlDispatcher now keeps an index of all resources and will attempt to avoid doing a linear search to resolve. On a hit the performance should be nearly `O(url_parts)` on... | 2023-11-12T23:16:04Z | UrlDispatcher improvements
### Describe the bug
The UrlDispatcher currently has to do a linear search to dispatch urls which has an average time complexity of `O(n)`. This means that urls that are registered first can be found faster than urls that are registered later.
### To Reproduce
Results
```
% pyt... | [
{
"body": "### Describe the bug\r\n\r\nThe UrlDispatcher currently has to do a linear search to dispatch urls which has an average time complexity of `O(n)`. This means that urls that are registered first can be found faster than urls that are registered later. \r\n\r\n\r\n### To Reproduce\r\n\r\nResults\r\n``... | c0377bf80e72134ad7bf29aa847f0301fbdb130f | {
"head_commit": "75bc97b8ef3e6006e0c17f2212501ff893e3301d",
"head_commit_message": "copy to both places so they do not miss it",
"patch_to_review": "diff --git a/CHANGES/7829.misc b/CHANGES/7829.misc\nnew file mode 100644\nindex 00000000000..7b98989a89e\n--- /dev/null\n+++ b/CHANGES/7829.misc\n@@ -0,0 +1 @@\n+In... | [
{
"diff_hunk": "@@ -979,12 +986,39 @@ def __init__(self) -> None:\n super().__init__()\n self._resources: List[AbstractResource] = []\n self._named_resources: Dict[str, AbstractResource] = {}\n+ self._resource_index: dict[str, list[AbstractResource]] = {}\n+ self._matched_s... | 162a9eaeae094eecbbcc38941c37e55c76e019dd | diff --git a/CHANGES/7829.misc b/CHANGES/7829.misc
new file mode 100644
index 00000000000..9eb060f4713
--- /dev/null
+++ b/CHANGES/7829.misc
@@ -0,0 +1,3 @@
+Improved URL handler resolution time by indexing resources in the UrlDispatcher.
+For applications with a large number of handlers, this should increase performan... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
aio-libs__aiohttp-7556@7fcdcf0 | aio-libs/aiohttp | Python | 7,556 | Only install async-timeout for Python < 3.11 | ## What do these changes do?
Replace `async-timeout` with `asyncio.timeout` for Python 3.11+.
Overall the change isn't as clean as I would have liked it to be. That's mostly a result of the name conflict with `timeout`. I'm open for suggestions on how to improve it.
## Are there changes in behavior for the user?... | 2023-08-25T22:17:05Z | Switch to asyncio.timeout()
We should look at whether it is easy to start using `asyncio.timeout()` in Python 3.11+ and drop the async-timeout dependency on newer Python releases.
We could always make changes to async-timeout if it is not trivial to switch between them. | [
{
"body": "We should look at whether it is easy to start using `asyncio.timeout()` in Python 3.11+ and drop the async-timeout dependency on newer Python releases.\r\n\r\nWe could always make changes to async-timeout if it is not trivial to switch between them.",
"number": 7502,
"title": "Switch to async... | cf97e5b0a20de31aeb51684add61b7dad4e92375 | {
"head_commit": "7fcdcf0b4db8357c28b1793df58f940e189af5cd",
"head_commit_message": "Only install async-timeout for Python < 3.11",
"patch_to_review": "diff --git a/CHANGES/7502.feature b/CHANGES/7502.feature\nnew file mode 100644\nindex 00000000000..2ab8c0987f0\n--- /dev/null\n+++ b/CHANGES/7502.feature\n@@ -0,0... | [
{
"diff_hunk": "@@ -50,17 +50,22 @@\n from urllib.parse import quote\n from urllib.request import getproxies, proxy_bypass\n \n-import async_timeout\n from multidict import CIMultiDict, MultiDict, MultiDictProxy\n from yarl import URL\n \n from . import hdrs\n from .log import client_logger\n from .typedefs imp... | 11d65841a497e4de93917fd83de71e772859f253 | diff --git a/CHANGES/7502.feature b/CHANGES/7502.feature
new file mode 100644
index 00000000000..2ab8c0987f0
--- /dev/null
+++ b/CHANGES/7502.feature
@@ -0,0 +1 @@
+Only install async-timeout for Python < 3.11.
diff --git a/aiohttp/client_ws.py b/aiohttp/client_ws.py
index 3e25c045967..0a010fa7920 100644
--- a/aiohttp/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
autogluon__autogluon-1105@5f3483d | autogluon/autogluon | Python | 1,105 | [Tabular] Added use_bag_holdout functionality | *Issue #, if available:*
*Description of changes:*
- Added use_bag_holdout option to allow bagging/stacking with a holdout set. (This is not equivalent to blending)
- Greatly improved handling of rare classes in various situations + bug fixes to rare class duplication logic.
Before merging:
- [x] Add unit ... | 2021-05-11T22:35:32Z | Stacking with evaluation set
I'm working with patient data collected for a few years.
The last year of the data is used as a test set and the year before is kept for validation.
According to the documentation, it is not possible to enable stacking and use a validation set. If stacking is enabled, the validation se... | Thanks for the feature request! This is a good feature to have. AutoGluon does not currently support specifying a custom validation set for stacking as we use out-of-fold predictions. However, if you have co-variate shift in your data, this can result in heavy overfitting and worse results then if the validation set wa... | [
{
"body": "I'm working with patient data collected for a few years. \r\nThe last year of the data is used as a test set and the year before is kept for validation.\r\n\r\nAccording to the documentation, it is not possible to enable stacking and use a validation set. If stacking is enabled, the validation set is... | 2fe325097e591677a6f8f1406d571016fa8fea3a | {
"head_commit": "5f3483d24357f61f33320729d822a38790f21e4c",
"head_commit_message": "minor fix",
"patch_to_review": "diff --git a/core/src/autogluon/core/models/__init__.py b/core/src/autogluon/core/models/__init__.py\nindex 2f05c4ae40c2..9e74d0e3c994 100644\n--- a/core/src/autogluon/core/models/__init__.py\n+++ ... | [
{
"diff_hunk": "@@ -240,13 +259,21 @@ def augment_rare_classes(X, label, threshold):\n new_df = new_df.append(clss_df.copy())\n aug_df = aug_df.append(new_df.copy())\n \n+ # Ensure new samples generated via augmentation have unique indices\n+ aug_df = aug_df.reset_index(drop=True)\n+ ... | 3db20da04f1226e7b41b9393bf83d4d8b9c9eeed | diff --git a/core/src/autogluon/core/models/__init__.py b/core/src/autogluon/core/models/__init__.py
index 2f05c4ae40c2..9e74d0e3c994 100644
--- a/core/src/autogluon/core/models/__init__.py
+++ b/core/src/autogluon/core/models/__init__.py
@@ -1,5 +1,5 @@
from .abstract.abstract_model import AbstractModel
-from .greedy... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
autogluon__autogluon-1098@6b498b8 | autogluon/autogluon | Python | 1,098 | Tabular: Added time_limit=None warning | *Issue #, if available:*
#1096
*Description of changes:*
- Added warning when time_limit=None and data is large.
- Hid NumExpr log statement caused by pandas.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| 2021-05-06T20:31:54Z | Training with `presets='best_quality'` takes too long
The following code takes ~2h on a cpu machine, which is reasonable.
```
!kaggle competitions download california-house-prices
!unzip california-house-prices.zip
from autogluon.tabular import TabularDataset, TabularPredictor
import numpy as np
label = '... | In general, `best_quality` will take ~20x longer than default, so if default takes 2 hours, `best_quality` will take 40 hours.
Currently it is somewhat difficult to get an estimate of total training time remaining, and this will be especially true for more diverse ensembles. I think a practical first step would be t... | [
{
"body": "The following code takes ~2h on a cpu machine, which is reasonable. \r\n\r\n```\r\n!kaggle competitions download california-house-prices\r\n!unzip california-house-prices.zip\r\n\r\nfrom autogluon.tabular import TabularDataset, TabularPredictor\r\nimport numpy as np \r\n\r\nlabel = 'Sold Price'\r\nla... | f20c084ec9c732f7be446a0bacb840ed5520d328 | {
"head_commit": "6b498b8f98eea1744794792bf7fc26f95204d40d",
"head_commit_message": "removed print statement",
"patch_to_review": "diff --git a/core/src/autogluon/core/utils/utils.py b/core/src/autogluon/core/utils/utils.py\nindex 21df4a0c96f1..d58f71c750e4 100644\n--- a/core/src/autogluon/core/utils/utils.py\n++... | [
{
"diff_hunk": "@@ -690,6 +690,13 @@ def fit(self,\n ag_args_ensemble = {}\n ag_args_ensemble['save_bag_folds'] = kwargs['_save_bag_folds']\n \n+ if time_limit is None:\n+ mb_mem_usage_train_data = get_approximate_df_mem_usage(train_data, sample_ratio=0.2).sum() / 1... | 7ed526890ee44f9f0642425997d10a4c6b19f002 | diff --git a/core/src/autogluon/core/utils/utils.py b/core/src/autogluon/core/utils/utils.py
index 21df4a0c96f1..22980a2397f9 100644
--- a/core/src/autogluon/core/utils/utils.py
+++ b/core/src/autogluon/core/utils/utils.py
@@ -8,6 +8,7 @@
import sys
from typing import Callable
from datetime import datetime
+from fun... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
aio-libs__aiohttp-7319@3317f3e | aio-libs/aiohttp | Python | 7,319 | Refactor WSMessage to use tagged unions | This reworks WSMessage to be a union of dataclasses which can provide much better type safety using tagged unions (on the `type` attribute).
I need to go over a couple of details (like what should be exported and from where, imports are a little messy currently). But, my main question before I finish it off, is whet... | 2023-06-10T14:25:02Z | websocket: message.json() fails with a TypeError when the message exceeds the size limit
### Describe the bug
When a websocket message exceeds the size limit, calling message.json() raises a TypeError instead of an informative exception
### To Reproduce
Send a large websocket message to an aiohttp server.
... | OK, I've been working through a PR to try and make this more type safe.
2 options we can do. First is to raise the exception from `.json()`, but I'm not sure how much sense this makes, and it would still fail on other message types (e.g. CLOSE has an int, which would still produce a TypeError). This would not affect... | [
{
"body": "### Describe the bug\r\n\r\nWhen a websocket message exceeds the size limit, calling message.json() raises a TypeError instead of an informative exception\r\n\r\n\r\n### To Reproduce\r\n\r\nSend a large websocket message to an aiohttp server.\r\n\r\nIn the handler, calling message.json() raises TypeE... | 7982b599b9b1ffa09acd5dfe43c3dfed74eae098 | {
"head_commit": "3317f3efeb4af82e2e766fdca5211739de558abd",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/aiohttp/__init__.py b/aiohttp/__init__.py\nindex dc11fefc949..a0e7cfd1462 100644\n--- a/ai... | [
{
"diff_hunk": "@@ -9,7 +9,8 @@\n from pytest_mock import MockerFixture\n \n from aiohttp import WSMsgType, web\n-from aiohttp.http import WS_CLOSED_MESSAGE, WSMessage\n+from aiohttp.http import WSMessageType",
"line": null,
"original_line": 12,
"original_start_line": null,
"path": "tests/test_w... | e701955d4551151c689df63c6961f6131daeba0b | diff --git a/CHANGES/7319.breaking.rst b/CHANGES/7319.breaking.rst
new file mode 120000
index 00000000000..e48278a8e2c
--- /dev/null
+++ b/CHANGES/7319.breaking.rst
@@ -0,0 +1 @@
+7319.feature.rst
\ No newline at end of file
diff --git a/CHANGES/7319.feature.rst b/CHANGES/7319.feature.rst
new file mode 100644
index 000... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
aio-libs__aiohttp-6340@2b6a22f | aio-libs/aiohttp | Python | 6,340 | Add an argument to override request body size | <!-- Thank you for your contribution! -->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
A new argument `client_max_size` was added to `BaseRequest.clone` method to allow overriding the request body size.
## Are there changes in behavior for the user?
<!-- Outline any ... | 2021-11-23T17:53:38Z | Customising the maximum size of request payload
🐣 **Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
I would like to explicitly limit the maximum size of an incoming json body for a POST request.
... | @mykola-mokhnach there's a way to change the maximum size of request payload when initializing `web.Application`:
`web.Application(client_max_size=1024 ** 2)`, the specified size will be used for all requests.
Thanks @anesabml My feature request is about customizing it for a single route rather than for the whole weba... | [
{
"body": "🐣 **Is your feature request related to a problem? Please describe.**\r\n<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->\r\n\r\nI would like to explicitly limit the maximum size of an incoming json body for a POST request. \r\n\r\n\r\n💡 **Describ... | 3daa9d1fda7c5018669879a09cf9dd3c33920fb7 | {
"head_commit": "2b6a22f9032d23a4a994be434494796d7a08b38a",
"head_commit_message": "Fix mypy issue",
"patch_to_review": "diff --git a/CHANGES/5704.feature b/CHANGES/5704.feature\nnew file mode 100644\nindex 00000000000..51d5d0ee1e6\n--- /dev/null\n+++ b/CHANGES/5704.feature\n@@ -0,0 +1 @@\n+A new argument `clien... | [
{
"diff_hunk": "@@ -0,0 +1 @@\n+A new argument `client_max_size` was added to `BaseRequest.clone` method to allow overriding the request body size -- :user:`anesabml`.",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "CHANGES/5704.feature",
"start_line": null,
"te... | ad3611cd9f7a288f045208c81e69a43f55e786c6 | diff --git a/CHANGES/5704.feature b/CHANGES/5704.feature
new file mode 100644
index 00000000000..6f9951bc993
--- /dev/null
+++ b/CHANGES/5704.feature
@@ -0,0 +1 @@
+A new argument ``client_max_size`` was added to ``BaseRequest.clone`` method to allow overriding the request body size -- :user:`anesabml`.
diff --git a/ai... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
autogluon__autogluon-470@0a849f8 | autogluon/autogluon | Python | 470 | Unify scheduler creation in different tasks. Basic fix to FIFOSchedul… | …er, HyperbandScheduler
*Issue #, if available:*
*Description of changes:*
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
| 2020-05-16T12:43:47Z | For HyperbandScheduler, epoch must start with 1, not with 0
I noted a mistake in the docstrings, and maybe also in the tabular code.
When time_attr = 'epoch' in HyperbandScheduler, the values coming from the reporter are assumed to start with 1 and run up to max_t. Instead, the examples make them start at 0 and run ... | [
{
"body": "I noted a mistake in the docstrings, and maybe also in the tabular code.\r\n\r\nWhen time_attr = 'epoch' in HyperbandScheduler, the values coming from the reporter are assumed to start with 1 and run up to max_t. Instead, the examples make them start at 0 and run up to max_t-1.\r\n\r\nIn other words,... | 6a98883d4bac6e94fd308bb4ff8c2641c22aa107 | {
"head_commit": "0a849f8271558701c0c61ba3d41a817da6eb1266",
"head_commit_message": "Addressed jwmueller comments:\n- epochs removed in tabular_prediction, changed compile_scheduler_options\n- improved comments and tutorial text",
"patch_to_review": "diff --git a/autogluon/scheduler/fifo.py b/autogluon/scheduler/... | [
{
"diff_hunk": "@@ -59,13 +59,33 @@ def load(output_directory, verbosity=2):\n \n @staticmethod\n @unpack(set_presets)\n- def fit(train_data, label, tuning_data=None, time_limits=None, output_directory=None, presets=None,\n- problem_type=None, eval_metric=None, stopping_metric=None,\n- ... | f7195ae06cb711449edc8d375a33228c45540c9c | diff --git a/autogluon/scheduler/fifo.py b/autogluon/scheduler/fifo.py
index e3ef40a9efc5..7b29ddbc8b04 100644
--- a/autogluon/scheduler/fifo.py
+++ b/autogluon/scheduler/fifo.py
@@ -30,40 +30,40 @@ class FIFOScheduler(TaskScheduler):
Parameters
----------
- train_fn: callable
+ train_fn : callable
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
aio-libs__aiohttp-5249@dad4c02 | aio-libs/aiohttp | Python | 5,249 | Cookie jar delete specific cookie | <!-- Thank you for your contribution! -->
## What do these changes do?
Add a predicate to AbstractCookieJar.clear
Add AbstractCookieJar.clear_domain method
## Are there changes in behavior for the user?
Yes
## Related issue number
Fixes #4942
## Checklist
- [x] I think the code is well written... | 2020-11-16T12:18:35Z | Method to delete a specific set of cookies
Currently if one wants to delete some cookies, the way to do it is not really obvious:
```python
new_cookies = []
for c in session.cookie_jar:
if check(c):
c['max-age'] = -1
new_cookies.append((c.key, c))
session.cookie_jar.update_cookies(new_c... | Hi @Lonami there is `clear` method in https://github.com/aio-libs/aiohttp/blob/master/aiohttp/cookiejar.py#L71 . Is this something you missed? You can directly call `session.cookie_jar.clear()` .
I don't recall if I saw it, but that seems to delete *all* the cookies of the session. I was looking for something that del... | [
{
"body": "Currently if one wants to delete some cookies, the way to do it is not really obvious:\r\n\r\n```python\r\nnew_cookies = []\r\n\r\nfor c in session.cookie_jar:\r\n if check(c):\r\n c['max-age'] = -1\r\n new_cookies.append((c.key, c))\r\n\r\nsession.cookie_jar.update_cookies(new_cooki... | e18c47f8a7801a70daf9728c6aaf30fe15b5078b | {
"head_commit": "dad4c02f5327187056ae3533bbd4e8bd4e542bff",
"head_commit_message": "Update 4942.feature",
"patch_to_review": "diff --git a/CHANGES/4942.feature b/CHANGES/4942.feature\nnew file mode 100644\nindex 00000000000..b64c4ddd088\n--- /dev/null\n+++ b/CHANGES/4942.feature\n@@ -0,0 +1,2 @@\n+Add predicate ... | [
{
"diff_hunk": "@@ -145,6 +145,22 @@ Abstract Cookie Jar\n :return: :class:`http.cookies.SimpleCookie` with filtered\n cookies for given URL.\n \n+ .. method:: clear(predicate=None)\n+\n+ Removes all cookies from the jar if the predicate is ``None``. Otherwise remove only those :class:`~ht... | f628c7087270cbcca144938b06737ee91ea82636 | diff --git a/CHANGES/4942.feature b/CHANGES/4942.feature
new file mode 100644
index 00000000000..b64c4ddd088
--- /dev/null
+++ b/CHANGES/4942.feature
@@ -0,0 +1,2 @@
+Add predicate to ``AbstractCookieJar.clear``.
+Add ``AbstractCookieJar.clear_domain`` to clean all domain and subdomains cookies only.
diff --git a/aioht... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
autogluon__autogluon-37@5a7251c | autogluon/autogluon | Python | 37 | BasePredictor skeleton outlined | TODOs needed to get predictor object working with this BasePredictor object:
- Base Task should implement @classmethod load(output_directory) method which restores a Predictor object from file (previously saved using Predictor.save(output_directory)). task.load(output_directory) can simply: return Predictor.load... | 2019-10-17T05:13:32Z | Predictor Object for AutoGluon Fit API
Issue tracker for discussion with @jwmueller @cgraywang today.
`results` returned by `fit` may not be a good way to saving state and handling multiple experiments.
We decide to make a `Predictor` object which contains the following method:
```python
save()
load()
predi... | I think this object should also support a `fit_summary()` method which returns something like the current `Results` object, with more informative/comprehensive instance-variable names as described here:
https://github.com/awslabs/autogluon/issues/32
Also I'd make sure all `task.fit()` calls automatically call `sa... | [
{
"body": "Issue tracker for discussion with @jwmueller @cgraywang today.\r\n\r\n`results` returned by `fit` may not be a good way to saving state and handling multiple experiments.\r\n\r\nWe decide to make a `Predictor` object which contains the following method:\r\n\r\n```python\r\nsave()\r\nload()\r\npredict... | 7795b9c956c24ff85904700482aa96e3eafea38e | {
"head_commit": "5a7251c808ec7ce0e222c0ca5db2d3c6ea435786",
"head_commit_message": "added plotting functions to summarize fit() process",
"patch_to_review": "diff --git a/autogluon/task/base/base_predictor.py b/autogluon/task/base/base_predictor.py\nnew file mode 100644\nindex 000000000000..c9e74abf1a5e\n--- /de... | [
{
"diff_hunk": "@@ -0,0 +1,180 @@\n+\"\"\" TODOs needed to get predictor object working for any task:\n+\n+ - Base Task should implement @classmethod load(output_directory) method which restores a Predictor object from file (previously saved using Predictor.save(output_directory)). task.load(output_directory... | f3ce0c218e30c0ad079857d262030ec823f16921 | diff --git a/autogluon/task/base/base_predictor.py b/autogluon/task/base/base_predictor.py
new file mode 100644
index 000000000000..0afad625e2cc
--- /dev/null
+++ b/autogluon/task/base/base_predictor.py
@@ -0,0 +1,182 @@
+""" TODOs needed to get predictor object working for any task:
+
+ - Base Task should implement... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
aio-libs__aiohttp-4615@62b445d | aio-libs/aiohttp | Python | 4,615 | Support registering OPTIONS HTTP method handlers via RouteTableDef | <!-- Thank you for your contribution! -->
## What do these changes do?
Allows to register Options method handlers for resources. Currently it gives an `AttributeError: 'RouteTableDef' object has no attribute 'options'`
<!-- Please give a short brief about these changes. -->
## Are there changes in behavior ... | 2020-03-08T16:10:44Z | RouteTableDef can't register OPTIONS request handlers
🐞 **Describe the bug**
Currently it gives an AttributeError: 'RouteTableDef' object has no attribute 'options'
💡 **To Reproduce**
```py
@route.options('/path')
def opts(request):
...
```
💡 **Expected behavior**
It should register decorated funct... | [
{
"body": "🐞 **Describe the bug**\r\nCurrently it gives an AttributeError: 'RouteTableDef' object has no attribute 'options'\r\n\r\n💡 **To Reproduce**\r\n\r\n```py\r\n@route.options('/path')\r\ndef opts(request):\r\n ...\r\n```\r\n\r\n💡 **Expected behavior**\r\nIt should register decorated function as the ... | 84c8ca7dc95e71e7016fb05b25bb9257def3838d | {
"head_commit": "62b445de397ddf1fb8a402ea114ae965bb90fbd7",
"head_commit_message": "web_routedef: Allow RouteTableDef to register options method handlers\n\nFixes https://github.com/aio-libs/aiohttp/issues/4663",
"patch_to_review": "diff --git a/CHANGES/4663.bugfix b/CHANGES/4663.bugfix\nnew file mode 100644\nin... | [
{
"diff_hunk": "@@ -0,0 +1 @@\n+Allows to register Options method handlers for resources.",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "CHANGES/4663.bugfix",
"start_line": null,
"text": "@user1:\n```suggestion\r\nSupport registering OPTIONS HTTP method handler... | c95423d052149a9dcbdc33ef063530254cb508b1 | diff --git a/CHANGES/4663.bugfix b/CHANGES/4663.bugfix
new file mode 100644
index 00000000000..c2d8fb5a6b4
--- /dev/null
+++ b/CHANGES/4663.bugfix
@@ -0,0 +1 @@
+Support registering OPTIONS HTTP method handlers via RouteTableDef.
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
index d5d53170e9c..22e08d68f0f 100644
---... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
aio-libs__aiohttp-4240@f4021e3 | aio-libs/aiohttp | Python | 4,240 | Added properties of default ClientSession params to ClientSession class | ## What do these changes do?
Added properties of default ClientSession params to ClientSession class so it is available for introspection now
## Are there changes in behavior for the user?
Users can now see which default parameters were initialized with ClientSession
## Related issue number
This commit f... | 2019-10-19T21:59:26Z | Expose ClientSession defaults such as headers and auth for introspection
## Long story short
Too many attributes of ClientSession are private without an explicit need to. The following constructor arguments can never be accessed after creating a session:
- `headers`
- `skip_auto_headers`
- `auth`
- `json_seria... | PR for providing properties for them is welcome, except `request_class`, `response_class`, and `ws_response_class`.
These three arguments will be removed soon.
What was the reason to hide them on first place? Perhaps exporting the API is not too cool. I have never needed that by making sessions persistent in one pl... | [
{
"body": "## Long story short\r\n\r\nToo many attributes of ClientSession are private without an explicit need to. The following constructor arguments can never be accessed after creating a session:\r\n\r\n- `headers`\r\n- `skip_auto_headers`\r\n- `auth`\r\n- `json_serialize`\r\n- ~`request_class`~\r\n- ~`resp... | 3cf4104a80fa9ac0eb8513c44fff94444a082c15 | {
"head_commit": "f4021e31f311e34dd7f71b8abc82e6b99f0d81d8",
"head_commit_message": "dix mypy",
"patch_to_review": "diff --git a/CHANGES/3882.feature b/CHANGES/3882.feature\nnew file mode 100644\nindex 00000000000..0337fcdcd33\n--- /dev/null\n+++ b/CHANGES/3882.feature\n@@ -0,0 +1 @@\n+Added properties of default... | [
{
"diff_hunk": "@@ -918,6 +919,60 @@ def timeout(self) -> Union[object, ClientTimeout]:\n \"\"\"Timeout for the session.\"\"\"\n return self._timeout\n \n+ @property\n+ def default_headers(self) -> 'CIMultiDict[str]':",
"line": null,
"original_line": 923,
"original_start_line":... | 1dfd24358d07bdf8831d1419b168c02e5d2b1667 | diff --git a/CHANGES/3882.feature b/CHANGES/3882.feature
new file mode 100644
index 00000000000..0337fcdcd33
--- /dev/null
+++ b/CHANGES/3882.feature
@@ -0,0 +1 @@
+Added properties of default ClientSession params to ClientSession class so it is available for introspection
diff --git a/aiohttp/client.py b/aiohttp/clien... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
aio-libs__aiohttp-3860@7c799d6 | aio-libs/aiohttp | Python | 3,860 | Make access log use local time with timezone | <!-- Thank you for your contribution! -->
## What do these changes do?
change access log use localtime and timezone instead all uctime
## Are there changes in behavior for the user?
show localtime instead utctime if turn on access log
## Related issue number
Fixes #3853
## Checklist
- [x] I thin... | 2019-06-21T04:25:22Z | web access log show utc time instead local time with timezone.
## Long story short
in web_.log.py:
```
def _format_t(request: BaseRequest,
response: StreamResponse,
time: float) -> str:
now = datetime.datetime.utcnow()
start_time = now - datetime.timedelta(... | UTC time is intentional.
It's nice to make it customizable. I see it being useful during the development in particular.
@NewUserHa feel free to research improving this and send a PR.
nginx's access.log is `[16/Jun/2019:15:25:04 +0800]`
what about `making _format_t` to obey OS or python's timezone info? I doubt ad... | [
{
"body": "## Long story short\r\nin web_.log.py:\r\n```\r\n def _format_t(request: BaseRequest,\r\n response: StreamResponse,\r\n time: float) -> str:\r\n now = datetime.datetime.utcnow()\r\n start_time = now - datetime.timedelta(seconds=time)\r\n retur... | 4273c7fd2b7e1f7adb2d2a57434a0c23c75f8645 | {
"head_commit": "7c799d6374c5a9f13f9890e1f834c337308cf189",
"head_commit_message": "Update web_log.py",
"patch_to_review": "diff --git a/aiohttp/web_log.py b/aiohttp/web_log.py\nindex a1a4576b401..20fa95fbd45 100644\n--- a/aiohttp/web_log.py\n+++ b/aiohttp/web_log.py\n@@ -3,6 +3,7 @@\n import logging\n import os... | [
{
"diff_hunk": "@@ -3,6 +3,7 @@\n import logging\n import os\n import re\n+import time as _time",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "aiohttp/web_log.py",
"start_line": null,
"text": "@user1:\nI don't think that you need to use an alias here. Please fo... | c5f66e6c2ca37c36c70efa1c9b0c2d23d0bd2cef | diff --git a/aiohttp/web_log.py b/aiohttp/web_log.py
index a1a4576b401..0f18a2b41b8 100644
--- a/aiohttp/web_log.py
+++ b/aiohttp/web_log.py
@@ -4,6 +4,7 @@
import os
import re
from collections import namedtuple
+from time import timezone
from typing import Callable, Dict, Iterable, List, Tuple # noqa
from .abc... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
borgbackup__borg-7714@a661da1 | borgbackup/borg | Python | 7,714 | Docs: Rewrite `borg check` docs | The current `borg check` docs have a very tech-centered focus. Some rather important bits for users are just small notes in subordinate clauses and the docs didn't really focus on what the user needs to know and what he's supposed to do (see e.g. #7578). Therefore I rewrote the docs. It appears like a rewrite from scra... | 2023-07-05T16:56:16Z | Restore zero'd chunks (`borg check --repair`) by the next `borg create`
/kind enhancement
Borg currently repairs broken repos (e.g. due to failing hardware) by zero'ing missing or otherwise damaged chunks (`borg check --repair`). This is fine because it makes an otherwise broken repo usable again at the cost of loos... | Borg already can heal lost chunks, all you need is to run `borg check --repair` again **after** the `borg create` that added back the missing chunks.
Awesome! :heart: I've just tested this and it indeed works. Borg amazes me again and again. Thanks Thomas! :+1:
I just checked the man page again and now that I know i... | [
{
"body": "/kind enhancement\r\n\r\nBorg currently repairs broken repos (e.g. due to failing hardware) by zero'ing missing or otherwise damaged chunks (`borg check --repair`). This is fine because it makes an otherwise broken repo usable again at the cost of loosing some data. The data is irrecoverably lost. In... | 4dfce1cca485ae478c650b7128297d0fde56bbfb | {
"head_commit": "a661da13ee24ec0a69cf6f24356f127363263c2c",
"head_commit_message": "Docs: Improve explanation of `borg check --max-duration`'s side effects",
"patch_to_review": "diff --git a/src/borg/archiver/check_cmd.py b/src/borg/archiver/check_cmd.py\nindex e63e865298..5a349535b8 100644\n--- a/src/borg/archi... | [
{
"diff_hunk": "@@ -71,78 +71,118 @@ def build_parser_check(self, subparsers, common_parser, mid_common_parser):\n \n check_epilog = process_epilog(\n \"\"\"\n- The check command verifies the consistency of a repository and the corresponding archives.\n+ The check command verif... | 2647673dc848396a026b9a543248551af3982fc8 | diff --git a/src/borg/archiver/check_cmd.py b/src/borg/archiver/check_cmd.py
index e63e865298..52563fc560 100644
--- a/src/borg/archiver/check_cmd.py
+++ b/src/borg/archiver/check_cmd.py
@@ -71,78 +71,118 @@ def build_parser_check(self, subparsers, common_parser, mid_common_parser):
check_epilog = process_ep... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
borgbackup__borg-7609@4a7a5b2 | borgbackup/borg | Python | 7,609 | Add function to clear empty directories at end of compact process. | Compact moves data to new segments, and then removes the old segments. When enough segments are moved, directories holding the now cleared segments may thus become empty.
With this commit any empty directories are cleared after segments compacting. Fixes #6823
| 2023-05-27T12:40:00Z | empty folders in repo_dir/data/ are not automatically removed
## Have you checked borgbackup docs, FAQ, and open Github issues?
Yes
## Is this a BUG / ISSUE report or a QUESTION?
QUESTION
## System information. For client/server mode post info for both machines.
#### Your borg version (borg -V).
1.2.0
##... | i don't think the empty folders are needed, so if they bother you, you can delete them.
maybe avoid running borg in parallel while you manually delete stuff in the repo - and be careful.
BTW:
- 1.2.1 is out
- only run `borg compact --cleanup-commits` once after upgrading from 1.1, you should not always run it w... | [
{
"body": "## Have you checked borgbackup docs, FAQ, and open Github issues?\r\nYes\r\n\r\n## Is this a BUG / ISSUE report or a QUESTION?\r\nQUESTION\r\n\r\n## System information. For client/server mode post info for both machines.\r\n\r\n#### Your borg version (borg -V).\r\n1.2.0\r\n\r\n#### Operating system (... | 00e19d047dd2f7e2fb23f7b03e657d78f5623508 | {
"head_commit": "4a7a5b2253c71917805c1f2987f4916aa29e4519",
"head_commit_message": "Add function to clear empty directories at end of compact process.\n\nCompact moves data to new segments, and then removes the old segments.\nWhen enough segments are moved, directories holding the now cleared segments\nmay thus be... | [
{
"diff_hunk": "@@ -1554,6 +1555,21 @@ def delete_segment(self, segment):\n except FileNotFoundError:\n pass\n \n+ def clear_empty_dirs(self):\n+ \"\"\"Delete empty segment dirs, i.e those with no segment files.\"\"\"\n+ data_dir = os.path.join(self.path, \"data\")\n+ ... | 6ae23bc0d7525f644cee0b88a86aa0954fc8a496 | diff --git a/src/borg/repository.py b/src/borg/repository.py
index 94df223a9b..c2340d401a 100644
--- a/src/borg/repository.py
+++ b/src/borg/repository.py
@@ -907,6 +907,7 @@ def complete_xfer(intermediate=True):
pi.show()
pi.finish()
complete_xfer(intermediate=False)
+ self.io.cle... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
borgbackup__borg-6556@0850a7c | borgbackup/borg | Python | 6,556 | Move the key derivation code from helpers.Passphrase to crypto.FlexiKey | Closes #6449
- [x] pbkdf2
- [x] argon2
@ThomasWaldmann, is this what you had in mind? If so, I'll migrate argon2 the same way. | 2022-04-10T02:37:28Z | move kdf code
`borg.helpers.passphrase` module has a `Passphrase.kdf` method.
- that's crypto code, so it should rather be below `borg.crypto` package
- all the other code there is just rather simple input / output / env var processing
@hexagonrecursion ^^^
(master branch only) | [
{
"body": "`borg.helpers.passphrase` module has a `Passphrase.kdf` method.\r\n\r\n- that's crypto code, so it should rather be below `borg.crypto` package\r\n- all the other code there is just rather simple input / output / env var processing\r\n\r\n@hexagonrecursion ^^^\r\n\r\n(master branch only)",
"numbe... | eba6d5cd1c4237b45273b4496ebbbd4e64783179 | {
"head_commit": "0850a7c2952187fdf17ee5a8bf4f957fc66726da",
"head_commit_message": "Passphrase.kdf -> FlexiKey.pbkdf2",
"patch_to_review": "diff --git a/src/borg/archiver.py b/src/borg/archiver.py\nindex 318a8f20ef..54215799d8 100644\n--- a/src/borg/archiver.py\n+++ b/src/borg/archiver.py\n@@ -46,7 +46,7 @@\n ... | [
{
"diff_hunk": "@@ -626,7 +626,7 @@ def chunkit(chunker_name, *args, **kwargs):\n print(\"KDFs (slow is GOOD, use argon2!) ===============================\")\n count = 5\n for spec, func in [\n- (\"pbkdf2\", lambda: Passphrase('mypassphrase').kdf(b'salt'*8, PBKDF2_ITERATIONS, ... | 0c29faddec85173a6753da33dac1b35a7bd5bddd | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 318a8f20ef..d2a7456210 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -46,7 +46,7 @@
from .constants import * # NOQA
from .compress import CompressionSpec
from .crypto.key import key_creator, key_argument_names, tam_required... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
borgbackup__borg-6297@16b001f | borgbackup/borg | Python | 6,297 | docs: explain the difference between a path that ends with or without a slash | Resolves #6258: explains the difference between a path that ends with or without a slash.
In the doc I specifically mentioned the difference when used as an exclusion pattern, because if I'm not mistaken there's no difference for inclusion patterns (`some/path/` and `some/path` would result in the same backup set). ... | 2022-02-14T13:39:04Z | Always getting "Permission denied" on a folder that has been excluded
## Have you checked borgbackup docs, FAQ, and open Github issues?
Yes
## Is this a BUG / ISSUE report or a QUESTION?
BUG
## System information. For client/server mode post info for both machines.
#### borg 1.1.17
#### macOS 11.5.2
... | Can you try to remove the trailing slash?
Also, if you use patterns, always be careful about the kind of patterns and what's the default kind, see `borg help patterns`.
Yes thank you, removing the trailing slash fixed it! Would that be considered a bug, or is it working as expected? (although in any case it's a bit con... | [
{
"body": "## Have you checked borgbackup docs, FAQ, and open Github issues?\r\n\r\nYes\r\n\r\n## Is this a BUG / ISSUE report or a QUESTION?\r\n\r\nBUG\r\n\r\n## System information. For client/server mode post info for both machines.\r\n\r\n#### borg 1.1.17\r\n\r\n#### macOS 11.5.2\r\n\r\n## Describe the probl... | 0cebe62264452b3aaf4649046645265332b4f141 | {
"head_commit": "16b001f08ba175996684c438fac68a453ad76a90",
"head_commit_message": "docs: explain the difference between a path that ends with or without a slash",
"patch_to_review": "diff --git a/src/borg/archiver.py b/src/borg/archiver.py\nindex 7a87702bfe..26a7ece801 100644\n--- a/src/borg/archiver.py\n+++ b/... | [
{
"diff_hunk": "@@ -2234,6 +2234,11 @@ def do_break_lock(self, args, repository):\n /path/to/repo /home/user`` will store all files as\n `home/user/.../file.ext`.\n \n+ A folder exclusion pattern can end either with or without a slash ('/').",
"line": null,
"original_line": 2237,
... | 33d5368d1b7080afa4819cf303dfa8f8ffe2f47d | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 7a87702bfe..a2b80a9a15 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -2234,6 +2234,11 @@ def do_break_lock(self, args, repository):
/path/to/repo /home/user`` will store all files as
`home/user/.../file.ext`.
+ A... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
borgbackup__borg-6023@a9f748a | borgbackup/borg | Python | 6,023 | do not show archive name in error msgs referring to repository | Fixes [issue](https://github.com/borgbackup/borg/issues/6014) where the error message would display the archive when the Respository does not exist by removing the archive name from the error string when `Repository.DoesNotExist`
is raised. | 2021-10-27T17:28:11Z | borg create: bad error msg when repo not found
borg 1.1.16 on debian bullseye:
```
Repository ssh://borg@backup:22/mnt/backup/server::server-home-2021-10-16T23:50:01 does not exist.
```
Guess the backup disk was not mounted at that moment, so the repo at that path was not found.
It's a bit bad though that th... | @ThomasWaldmann Can I work on this issue?
@sw9719 sure, just create a PR. | [
{
"body": "borg 1.1.16 on debian bullseye:\r\n\r\n```\r\nRepository ssh://borg@backup:22/mnt/backup/server::server-home-2021-10-16T23:50:01 does not exist.\r\n```\r\n\r\nGuess the backup disk was not mounted at that moment, so the repo at that path was not found.\r\n\r\nIt's a bit bad though that the error mess... | 9b6adc1cd68dbc468016e6c5e76cf47870186de4 | {
"head_commit": "a9f748a476d496aa502f679a213a666c16f06ab0",
"head_commit_message": "Added method in Location class to remove archive name",
"patch_to_review": "diff --git a/src/borg/archiver.py b/src/borg/archiver.py\nindex 60081f7615..daae7e782f 100644\n--- a/src/borg/archiver.py\n+++ b/src/borg/archiver.py\n@@... | [
{
"diff_hunk": "@@ -492,6 +492,10 @@ def with_timestamp(self, timestamp):\n 'utcnow': DatetimeWrapper(timestamp),\n })\n \n+ def omit_archive(self):\n+ #self.orig = self.orig.split(\"::\")[0]\n+ return self",
"line": null,
"original_line": 497,
"original_start_li... | 6c860b1c80eb39abaca2ce2252a6d8e2e329e701 | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 60081f7615..daae7e782f 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -158,7 +158,7 @@ def wrapper(self, args, **kwargs):
if argument(args, fake) ^ invert_fake:
return method(self, args, repository=None, **kwar... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
borgbackup__borg-6482@ec11905 | borgbackup/borg | Python | 6,482 | Simplify Libs Setup | My first take on refactoring the setup script. What I did:
- Move some metadata to `setup.cfg` and only keep actual code in `setup.py`
- Common function `lib_ext_kwargs` to discover all libs
Open issues:
- There was a special condition for openssl for win32, but not the other libs. Is this leftover code or will... | 2022-03-23T11:37:56Z | simplify libs setup
in master branch, we recently got rid of most of the code in `setup_*.py`.
guess we now could put all the remaining code into a `setup_libs.py` or maybe after a little refactoring and deduplication of code maybe even directly into `setup.py`. | Can I work on this? Already doing some packaging, which is related.
Would also suggest to move some meta-data type stuff to `setup.cfg` and only keep actual code in `setup.py`. E.g. the classifiers: https://github.com/borgbackup/borg/blob/master/setup.py#L250
This would currently conflict with the already started cr... | [
{
"body": "in master branch, we recently got rid of most of the code in `setup_*.py`.\r\n\r\nguess we now could put all the remaining code into a `setup_libs.py` or maybe after a little refactoring and deduplication of code maybe even directly into `setup.py`.",
"number": 6392,
"title": "simplify libs s... | 89f192edb210376aea49aeaa6dd97a0dc71cd428 | {
"head_commit": "ec11905f1193686b326f989ece5bd0964d0ce4e1",
"head_commit_message": "Add src path to setup.cfg",
"patch_to_review": "diff --git a/setup.cfg b/setup.cfg\nindex d762793fab..8b8929fe7f 100644\n--- a/setup.cfg\n+++ b/setup.cfg\n@@ -1,3 +1,74 @@\n+[metadata]\n+name = borgbackup\n+author = The Borg Coll... | [
{
"diff_hunk": "@@ -165,6 +113,16 @@ def run(self):\n 'clean2': Clean,\n }\n \n+\n+# How the build process finds the system libs:\n+#\n+# 1. if BORG_LIBXXX_PREFIX is set, it will use headers and libs from there.",
"line": null,
"original_line": 119,
"original_start_line": null,
"path": "setu... | 710d76e5c2d0437faec842a5585126feb689a819 | diff --git a/setup.cfg b/setup.cfg
index d762793fab..16886a7e2b 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -1,3 +1,73 @@
+[metadata]
+name = borgbackup
+author = The Borg Collective (see AUTHORS file)
+description = Deduplicated, encrypted, authenticated and compressed backups
+url = https://github.com/borgbackup/borg
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
borgbackup__borg-5503@61cc102 | borgbackup/borg | Python | 5,503 | Add a --list switch to borg delete | Also add some documentation on this.
Fixes #5116. | 2020-11-13T10:49:38Z | Inconsistent switch to display changes during 'dry-run' operation
There are two operations I use, so far, to destructively modify a repository:
_delete_ and _recreate_
They allow wildcards, patterns, etc. Obviously this is a dangerous operation and therefore the '--dry-run' switch exists for both to check your wor... | There may be other operations that have --dry-run options. I would suggest (asserting that nobody does a --dry-run without wanting to see what will happen) that '--list' is available consistently in all such circumstances.
I'm using 1.1.11
maybe one should do a global review about consistency relating to this.
Also w... | [
{
"body": "There are two operations I use, so far, to destructively modify a repository:\r\n_delete_ and _recreate_\r\n\r\nThey allow wildcards, patterns, etc. Obviously this is a dangerous operation and therefore the '--dry-run' switch exists for both to check your work before execution.\r\n\r\nI have found a... | 72ac474e65fbc15782b3686a716ff2b29a3cba14 | {
"head_commit": "61cc10246a0039b3fedcd464955f383bb3de20e3",
"head_commit_message": "Add a --list switch to borg delete\n\nAlso add some documentation on this.\n\nFixes #5116",
"patch_to_review": "diff --git a/docs/usage/delete.rst b/docs/usage/delete.rst\nindex 02fe0a04ae..8d566ef70e 100644\n--- a/docs/usage/del... | [
{
"diff_hunk": "@@ -1252,8 +1259,12 @@ def _delete_repository(self, args, repository):\n if not keep_security_info:\n SecurityManager.destroy(repository)\n else:\n- logger.info(\"Would delete repository.\")\n- logger.info(\"Would %s s... | 3035b253807135926723262469b10c24fb09e473 | diff --git a/docs/usage/delete.rst b/docs/usage/delete.rst
index 02fe0a04ae..7bd50b5ddf 100644
--- a/docs/usage/delete.rst
+++ b/docs/usage/delete.rst
@@ -16,7 +16,7 @@ Examples
$ borg delete --glob-archives '*-2012-*' /path/to/repo
# see what would be deleted if delete was run without --dry-run
- $ borg... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
borgbackup__borg-5029@812e1d9 | borgbackup/borg | Python | 5,029 | [DOCS] #4941 – FAQ Borg config dir | fixes #4941 | 2020-03-14T16:29:32Z | How important is $HOME/.config/borg?
I've been reading the docs and issues over and over and it isn't clear to me how important the `$HOME/.config/borg` folder is. I'm getting the impression that analogous to duplicacy's per-repo `config` file, that the `$HOME/.config/borg` folder needs to be backed up independently as... | I am currently working on this. | [
{
"body": "I've been reading the docs and issues over and over and it isn't clear to me how important the `$HOME/.config/borg` folder is. I'm getting the impression that analogous to duplicacy's per-repo `config` file, that the `$HOME/.config/borg` folder needs to be backed up independently as it contains state... | c140dc995f684a8dd386b10149c610b7a4cd6e5f | {
"head_commit": "812e1d9109fcbe3dfe3cf70a23e54b96b2e91bd7",
"head_commit_message": "[DOCS] #4941 – How important is Borg config?\n\nAdd link to cache internals.",
"patch_to_review": "diff --git a/docs/faq.rst b/docs/faq.rst\nindex 4940695875..21881f3c9c 100644\n--- a/docs/faq.rst\n+++ b/docs/faq.rst\n@@ -353,6 +... | [
{
"diff_hunk": "@@ -353,6 +353,28 @@ to change them.\n Security\n ########\n \n+.. _home_config_borg:\n+\n+How important is the $HOME/.config/borg directory?\n+--------------------------------------------------\n+\n+The Borg config directory has content that you should take care of:\n+\n+``security`` subdirecto... | bcff8a1abd4c96d42fe1beca58974bfa0d6dd947 | diff --git a/docs/faq.rst b/docs/faq.rst
index 4940695875..07bb11a3e9 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -353,6 +353,28 @@ to change them.
Security
########
+.. _home_config_borg:
+
+How important is the $HOME/.config/borg directory?
+--------------------------------------------------
+
+The Borg confi... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
borgbackup__borg-5288@45f7c01 | borgbackup/borg | Python | 5,288 | Add ssh-agent pull backup method to doc | [DOCS] Add ssh-agent pull mode
Closes #5287 . | 2020-08-07T12:35:58Z | Document how to use ssh-agent pull mode
When trying to implement borg in our infrastructure I found out that there is no documentation for using borg in pull mode with ssh-agent for forwarding of the authentication information from server to client. From my point of view this method is more convenient than using socat ... | [
{
"body": "When trying to implement borg in our infrastructure I found out that there is no documentation for using borg in pull mode with ssh-agent for forwarding of the authentication information from server to client. From my point of view this method is more convenient than using socat because it have less ... | 47446f204380e67a7045a5b507e08bae33cf02b3 | {
"head_commit": "45f7c01e377517790728a75048b7da3fc30b4b90",
"head_commit_message": "Add ssh-agent pull backup method to doc",
"patch_to_review": "diff --git a/docs/deployment/pull-backup.rst b/docs/deployment/pull-backup.rst\nindex f4c67f8ea0..48cee60c32 100644\n--- a/docs/deployment/pull-backup.rst\n+++ b/docs/... | [
{
"diff_hunk": "@@ -301,3 +301,66 @@ a backup may be the following command::\n \n This command also automatically removes the socket file after the ``borg\n create`` command is done.\n+\n+ssh-agent\n+=========\n+\n+In this scenario *borg-server* initiate SSH connection to *borg-client* with forwarding of the au... | 1953447489f5d83a0b5b0193d6b3c8b231a35c36 | diff --git a/docs/deployment/pull-backup.rst b/docs/deployment/pull-backup.rst
index f4c67f8ea0..e738b59bac 100644
--- a/docs/deployment/pull-backup.rst
+++ b/docs/deployment/pull-backup.rst
@@ -301,3 +301,108 @@ a backup may be the following command::
This command also automatically removes the socket file after th... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
borgbackup__borg-4285@07da4cb | borgbackup/borg | Python | 4,285 | add warnings on repository copies to avoid future problem like #4272 | fixes #3933. | 2019-01-30T15:06:32Z | docs/faq: copying a repo?
check docs and faq whether we have some words about copying a repo (which should NOT be done usually, at least not if the goal is to update the original as well as the copy using borg).
problems:
- aes ctr reuse (crypto not secure any more)
- cache confusion due to duplicate repo id
we... | for unencrypted repos, copies can be made, but you need to change the repo id in the repo config after copying to a new unique value.
To clarify for me:
- if I am just making a copy / backup of a repo (move to a new USB drive / server) so long as I only ever write to one of them in the future then all is good. Can rea... | [
{
"body": "check docs and faq whether we have some words about copying a repo (which should NOT be done usually, at least not if the goal is to update the original as well as the copy using borg).\r\n\r\nproblems:\r\n- aes ctr reuse (crypto not secure any more)\r\n- cache confusion due to duplicate repo id\r\n\... | c6cb1dc28b61ffeb55b85801bf7b2007ddef77ed | {
"head_commit": "07da4cb16b1dddc1cf2c2b8fa58b13e5fb08799f",
"head_commit_message": "add warnings on repository copies to avoid future problem like #4272",
"patch_to_review": "diff --git a/docs/faq.rst b/docs/faq.rst\nindex bd2662dbb2..aa6f94d56f 100644\n--- a/docs/faq.rst\n+++ b/docs/faq.rst\n@@ -26,12 +26,15 @@... | [
{
"diff_hunk": "@@ -26,12 +26,15 @@ or deleting archives, which may make *simultaneous* backups fail.\n Can I copy or synchronize my repo to another location?\n ------------------------------------------------------\n \n-Yes, you could just copy all the files. Make sure you do that while no\n-backup is running.... | 56ed42a404b1a7a477c25530d2444ddbe8c09f4c | diff --git a/docs/faq.rst b/docs/faq.rst
index bd2662dbb2..910c7d357f 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -26,28 +26,52 @@ or deleting archives, which may make *simultaneous* backups fail.
Can I copy or synchronize my repo to another location?
------------------------------------------------------
-Yes,... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
borgbackup__borg-4794@710adf7 | borgbackup/borg | Python | 4,794 | Doc/4532 faq retain original paths | fixes #4532 | 2019-10-19T21:21:40Z | borg backup and btrfs
This is Fedora 30 Beta and borg is version 1.1.9
When I do a backup of a `btrfs` file system I first do a readonly snapshot, then back up the readonly snapshot.
Example
```
btrfs sub snap -r /home /.snapshots/home
borg create -v -stats /mnt/borg_repos::home.20190428 /.snapshots/home
btr... | ```
cd /.snapshots
borg create -v -stats /mnt/borg_repos::home.20190428 home
```
alternatively: do it as before and strip away the `.snapshots` at extraction time, see `borg extract --help`.
TODO: check FAQ and docs whether this is already covered. if not, a PR for this is welcome!
`cd /.snapshots` aso is a pos... | [
{
"body": "This is Fedora 30 Beta and borg is version 1.1.9\r\n\r\nWhen I do a backup of a `btrfs` file system I first do a readonly snapshot, then back up the readonly snapshot.\r\n\r\nExample\r\n```\r\nbtrfs sub snap -r /home /.snapshots/home\r\nborg create -v -stats /mnt/borg_repos::home.20190428 /.snapshots... | 59ea5bc4d6f89cdbb2a28a1b89854a00b75cb4d5 | {
"head_commit": "710adf744105aa356e17b097613439c73a3da1cc",
"head_commit_message": "[DOC] #4532 - More general FAQ for backup and retain original paths\n\nUse correct list syntax.\nfixes #4532",
"patch_to_review": "diff --git a/docs/faq.rst b/docs/faq.rst\nindex 0788c21c52..5c08a5beb8 100644\n--- a/docs/faq.rst\... | [
{
"diff_hunk": "@@ -702,6 +702,23 @@ Now Borg will be bandwidth limited. Nice thing about pv is that you can change r\n .. _pipeviewer: http://www.ivarch.com/programs/pv.shtml\n \n \n+How can I avoid unwanted base directories getting stored into archives?\n+------------------------------------------------------... | f4767c37b7a2efc1008784862b189374d4e93849 | diff --git a/docs/faq.rst b/docs/faq.rst
index 0788c21c52..d898015e7b 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -702,6 +702,23 @@ Now Borg will be bandwidth limited. Nice thing about pv is that you can change r
.. _pipeviewer: http://www.ivarch.com/programs/pv.shtml
+How can I avoid unwanted base directories... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
borgbackup__borg-4779@dd92695 | borgbackup/borg | Python | 4,779 | Fixes the man pages creation | The issue https://github.com/borgbackup/borg/issues/4471 solution
created many commands for borgfs which shouldn't exist in addition to
creating issue https://github.com/borgbackup/borg/issues/4752.
Fixes https://github.com/borgbackup/borg/issues/4752 . | 2019-10-09T13:01:12Z | master: python setup.py build_man is broken
somehow it doesn't process `borgfs` correctly:
```
$ python setup.py build_man
Detected OpenSSL [via pkg-config]
Using bundled BLAKE2
Detected and preferring liblz4 [via pkg-config]
Using bundled ZSTD
Using bundled xxhash
running build_man
building man pages (in do... | Because of that, the related man pages will be missing in 1.2.0a7.
Hum,
I'm interested by this one.
However I'm not sure if it is just a matter of creating the good files for the borgfs commands, or some python code in the setup_docs.py file (which reads the files) in order to create them automatically.
The goal is t... | [
{
"body": "somehow it doesn't process `borgfs` correctly:\r\n\r\n```\r\n$ python setup.py build_man\r\nDetected OpenSSL [via pkg-config]\r\nUsing bundled BLAKE2\r\nDetected and preferring liblz4 [via pkg-config]\r\nUsing bundled ZSTD\r\nUsing bundled xxhash\r\nrunning build_man\r\nbuilding man pages (in docs/ma... | 73ab1f1da630e471b4449182c6845bb22a4b1ee5 | {
"head_commit": "dd92695a047bb785b34b97ffd921c33673df7237",
"head_commit_message": "Fixes the man pages creation\n\nThe issue https://github.com/borgbackup/borg/issues/4471 solution\ncreated many commands for borgfs which shouldn't exist in addition to\ncreating issue https://github.com/borgbackup/borg/issues/4752... | [
{
"diff_hunk": "@@ -2604,6 +2604,22 @@ def define_archive_filters_group(subparser, *, sort_by=True, first_last=True):\n group.add_argument('--last', metavar='N', dest='last', default=0, type=positive_int_validator,\n help='consider last N archives after other f... | 1d9b4d01594878db70cdaf4071de71fd29e4136c | diff --git a/src/borg/archiver.py b/src/borg/archiver.py
index 8650a55301..8a49306b1b 100644
--- a/src/borg/archiver.py
+++ b/src/borg/archiver.py
@@ -2604,6 +2604,22 @@ def define_archive_filters_group(subparser, *, sort_by=True, first_last=True):
group.add_argument('--last', metavar='N', dest='last',... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
borgbackup__borg-3313@308644e | borgbackup/borg | Python | 3,313 | include item birthtime in archive (where available) | This adds birth times (macOS creation date) to the archive, to resolve #3272. I'm new to this codebase so I expect there will be things I messed up. I took a wild guess that adding keys to `Item` was OK and that a new (post-1.1) `int` field didn't need a `bigint` wrapper. | 2017-11-11T05:17:16Z | macOS creation dates are not preserved
## Description
macOS creation dates are not preserved.
## Environment
* macOS 10.12.6
* Borg git @ d1d55904
## Steps to replicate
1. Prepare a file that has a known creation date and last modified date
```
mkdir test; cd test
mkdir src; cd src
touch dated-file
... | This is about stat_result.st_birthtime which is specific for macOS (and some BSDs?) and not yet supported by borg.
Hmm, while it might be easy to get that value: how does one set it? (via API, not command line or GUI)
I'm going to fool around with maybe adding this, unless you think it's a waste of my time. | [
{
"body": "## Description\r\n\r\nmacOS creation dates are not preserved.\r\n\r\n## Environment\r\n\r\n* macOS 10.12.6\r\n* Borg git @ d1d55904\r\n\r\n## Steps to replicate\r\n\r\n1. Prepare a file that has a known creation date and last modified date\r\n```\r\nmkdir test; cd test\r\nmkdir src; cd src\r\ntouch d... | 46d0f3e81df65214400164ef5be98767fd39ad18 | {
"head_commit": "308644e34690f7d4a01128ab4bfb7993d15da5bc",
"head_commit_message": "include item birthtime in archive (where available)",
"patch_to_review": "diff --git a/src/borg/archive.py b/src/borg/archive.py\nindex e04731e8fc..9950850582 100644\n--- a/src/borg/archive.py\n+++ b/src/borg/archive.py\n@@ -683,... | [
{
"diff_hunk": "@@ -2,7 +2,7 @@\n ITEM_KEYS = frozenset(['path', 'source', 'rdev', 'chunks', 'chunks_healthy', 'hardlink_master',\n 'mode', 'user', 'group', 'uid', 'gid', 'mtime', 'atime', 'ctime', 'size',\n 'xattrs', 'bsdflags', 'acl_nfs4', 'acl_access', 'acl_defau... | 39ac02143b919e144ab28b7dad9baa64d240b8bf | diff --git a/src/borg/archive.py b/src/borg/archive.py
index e04731e8fc..d7d0ac6a50 100644
--- a/src/borg/archive.py
+++ b/src/borg/archive.py
@@ -683,6 +683,18 @@ def restore_attrs(self, path, item, symlink=False, fd=None):
else:
# old archives only had mtime in item metadata
atime =... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
borgbackup__borg-2924@6f94949 | borgbackup/borg | Python | 2,924 | migrate locks to child PID when daemonize is used | fixes #2923
the pid change due to daemonize didn't work well with the stale lock detection (as the initial/parent process was gone). thus we better transfer the locks to the new pid.
this is only needed for client-side (local) repos because the daemonize happens there.
remote repos are locked by borg serve and ... | 2017-08-07T02:40:58Z | lock.roster left behind after umount in 1.1.0 rc1
I have been testing v1.1.0 rc1 and found the following issue:
Before doing a backup I check if a backup is neccessary by mounting the repo and comparing the latest archive with the source.
Then the repo is unmounted.
At the beginning of the next backup I get a messag... | ```
$ borg -V
borg 1.1.0rc1
$ borg mount repo mnt
$ ls mnt
1 2 new testing
$ borg umount mnt
$ ls -l repo
total 668
-rw------- 1 tw tw 209 Jul 21 22:57 config
drwx------ 3 tw tw 4096 Jul 21 22:57 data
-rw------- 1 tw tw 64 Aug 6 02:09 hints.17
-rw------- 1 tw tw 656458 Aug 6 02:09 index.17
-r... | [
{
"body": "I have been testing v1.1.0 rc1 and found the following issue:\r\nBefore doing a backup I check if a backup is neccessary by mounting the repo and comparing the latest archive with the source.\r\nThen the repo is unmounted.\r\nAt the beginning of the next backup I get a message that lock.roster files ... | 72c8ec258355802beccdca6f1805731349783eeb | {
"head_commit": "6f94949a36607f977bdb8ac835e98647896e4b7a",
"head_commit_message": "migrate locks to child PID when daemonize is used\n\nalso:\n\nincrease platform api version due to change in get_process_id behaviour.",
"patch_to_review": "diff --git a/src/borg/fuse.py b/src/borg/fuse.py\nindex 7868eb3782..129e... | [
{
"diff_hunk": "@@ -202,6 +202,16 @@ def break_lock(self):\n os.unlink(os.path.join(self.path, name))\n os.rmdir(self.path)\n \n+ def migrate_lock(self, old_id, new_id):\n+ \"\"\"migrate the lock ownership from old_id to new_id\"\"\"\n+ if self.id == old_id:",
"l... | 5bad764637ece004cccce6273d5028b97148c9dc | diff --git a/src/borg/fuse.py b/src/borg/fuse.py
index 7868eb3782..129e3b20b7 100644
--- a/src/borg/fuse.py
+++ b/src/borg/fuse.py
@@ -22,6 +22,7 @@
from .helpers import daemonize, hardlinkable, signal_handler, format_file_size
from .item import Item
from .lrucache import LRUCache
+from .remote import RemoteReposito... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-85269@a9dbf17 | ansible/ansible | Python | 85,269 | Add SELinux Context as a return value for `module:stat` | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add an option `get_selinux_context` to `stat` module, with default value `False` . If it is specified as `True`, the values of `selinux_context` will be added to the return result. resolve #85217
<!--- Add "Fixes #1234" or ... | 2025-06-05T03:16:37Z | stat: Add selinux context as a return value
### Summary
I wanted to use the stat module to check the selinux context of a directory before running restorecon, but I just saw that stat does not output such information currently. I didn't find any other module that could output the selinux context of a file, and using a... | Files identified in the description:
* [`lib/ansible/modules/stat.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/stat.py)
If these files are incorrect, please update the `component name` section of the description or use the [component](https://github.com/ansible/ansibotmini#commands) bot comm... | [
{
"body": "### Summary\n\nI wanted to use the stat module to check the selinux context of a directory before running restorecon, but I just saw that stat does not output such information currently. I didn't find any other module that could output the selinux context of a file, and using a separate task to regis... | 1c06c46cc14324df35ac4f39a45fb3ccd602195d | {
"head_commit": "a9dbf1783c01d224de027efa85ccfd74c55f31bb",
"head_commit_message": "detail description and add negetive test case.",
"patch_to_review": "diff --git a/changelogs/fragments/85217-stat-add-selinux-context.yml b/changelogs/fragments/85217-stat-add-selinux-context.yml\nnew file mode 100644\nindex 0000... | [
{
"diff_hunk": "@@ -44,6 +44,14 @@\n version_added: \"2.3\"\n get_checksum:\n version_added: \"1.8\"\n+ get_selinux_context:\n+ description:\n+ - Get file SELinux context in a list [ user, role, type, range ], \n+ - and will get [None, None, None, None] if it is not possible to retrieve ... | 3c61338fc5a26e1e8a548d21ba40d9e906757593 | diff --git a/changelogs/fragments/85217-stat-add-selinux-context.yml b/changelogs/fragments/85217-stat-add-selinux-context.yml
new file mode 100644
index 00000000000000..44e32a5d90fbbb
--- /dev/null
+++ b/changelogs/fragments/85217-stat-add-selinux-context.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - stat module - add SELi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-85251@ea51372 | ansible/ansible | Python | 85,251 | wait_for module - document self match avoidance | When using static string to search system log, avoid matching self execution logged by Ansible by default.
fixes #85244
<!--- Describe the change below, including rationale -->
<!--- Add "Fixes #1234" if there is a corresponding issue -->
##### ISSUE TYPE
- Docs Pull Request
| 2025-06-03T15:49:26Z | wait_for wrongly detects pattern due to self-logging
### Summary
When using the `wait_for` module with the `search_regex` option to monitor log files (e.g., `/var/log/messages`), the module may falsely detect the pattern as matched due to Ansible itself writing the `search_regex` string into the same log file. This ca... | Files identified in the description:
* [`lib/ansible/modules/dnf.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/dnf.py)
* [`lib/ansible/plugins/action/dnf.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/action/dnf.py)
If these files are incorrect, please update the `comp... | [
{
"body": "### Summary\n\nWhen using the `wait_for` module with the `search_regex` option to monitor log files (e.g., `/var/log/messages`), the module may falsely detect the pattern as matched due to Ansible itself writing the `search_regex` string into the same log file. This causes `wait_for` to succeed befor... | d7c4d0119f1b8783355a507efe791826ace85d56 | {
"head_commit": "ea5137266c48356c76f894acb3d5b63acab31f3a",
"head_commit_message": "wait_for module - document self match avoidance\n\nWhen using static string to search system log, avoid matching self execution\nlogged by Ansible by default.",
"patch_to_review": "diff --git a/lib/ansible/modules/wait_for.py b/l... | [
{
"diff_hunk": "@@ -76,6 +76,7 @@\n description:\n - Can be used to match a string in either a file or a socket connection.\n - Defaults to a multiline regex.\n+ - When inspecting a system log file and a static string, remember that Ansible by default logs it's own actions there, see notes ... | 30dc899e89424d0386cb380d67f673b99423b768 | diff --git a/lib/ansible/modules/wait_for.py b/lib/ansible/modules/wait_for.py
index 49bc7cde63c9c3..723bd684b5bc55 100644
--- a/lib/ansible/modules/wait_for.py
+++ b/lib/ansible/modules/wait_for.py
@@ -76,6 +76,8 @@
description:
- Can be used to match a string in either a file or a socket connection.
... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
axolotl-ai-cloud__axolotl-1461@a99936c | axolotl-ai-cloud/axolotl | Python | 1,461 | Added pip install ninja to accelerate installation of flash-attn | # Description
In the Quickstart section, it is required to install flash-attn
Without ninja , installing flash-attn takes more than 2hrs on 64cores
## Motivation and Context
The Quickstart section is expected to get started quickly. however the installation of flash-attn takes a long time
fixes #1460
## ... | 2024-03-30T07:11:07Z | Added installation of ninja to Quickstart
### What piece of documentation is affected?
The Quickstart section in README.md
### What part(s) of the article would you like to see updated?
the Quickstart section of the README.md
pip3 install ninja is required before
pip3 install -e '.[flash-attn,deepspeed]'
ni... | [
{
"body": "### What piece of documentation is affected?\n\nThe Quickstart section in README.md \n\n### What part(s) of the article would you like to see updated?\n\nthe Quickstart section of the README.md\r\n\r\npip3 install ninja is required before \r\npip3 install -e '.[flash-attn,deepspeed]'\r\n\r\nninja hel... | 89134f2143cd3325802813eb97cd05c783932201 | {
"head_commit": "a99936c9b952370c84d142f1c2e21b4508d14b94",
"head_commit_message": "Added pip install ninja to accelerate installation of flash-attn",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 027c476c3b..3e9722b173 100644\n--- a/README.md\n+++ b/README.md\n@@ -109,6 +109,7 @@ git clone https... | [
{
"diff_hunk": "@@ -109,6 +109,7 @@ git clone https://github.com/OpenAccess-AI-Collective/axolotl\n cd axolotl\n \n pip3 install packaging\n+pip3 install ninja",
"line": null,
"original_line": 112,
"original_start_line": 111,
"path": "README.md",
"start_line": null,
"text": "@user1:\n```... | fbe4a11fea93a16208a48f6e50ba5f1fc890bf57 | diff --git a/README.md b/README.md
index 027c476c3b..ca0828490d 100644
--- a/README.md
+++ b/README.md
@@ -108,7 +108,7 @@ Get started with Axolotl in just a few steps! This quickstart guide will walk yo
git clone https://github.com/OpenAccess-AI-Collective/axolotl
cd axolotl
-pip3 install packaging
+pip3 install p... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
ansible__ansible-84209@95d069f | ansible/ansible | Python | 84,209 | test: Update regex for required and default in FieldAttributes | ##### SUMMARY
Fixes: #61460
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
##### ISSUE TYPE
- Bugfix Pull Request
| 2024-10-30T19:36:48Z | False positive on required-and-default-attributes sanity test
##### SUMMARY
The required-and-default-attributes sanity test is somehow giving a false positive on a FieldAttribute that only specifies `default`.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
required-and-default-attributes sanity test
###... | Files identified in the description:
* [`test/sanity/code-smell/required-and-default-attributes.py`](https://github.com/ansible/ansible/blob/devel/test/sanity/code-smell/required-and-default-attributes.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!compone... | [
{
"body": "##### SUMMARY\r\nThe required-and-default-attributes sanity test is somehow giving a false positive on a FieldAttribute that only specifies `default`.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nrequired-and-default-attributes sanity test\r\n\r\n##### ANSIBLE VERSION\r\n2.9... | c734ac2125f502dcbef2af46b1aba201f850ad05 | {
"head_commit": "95d069f0df32008c73ca0b1c813f834f16eb1e20",
"head_commit_message": "Review requests\n\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>",
"patch_to_review": "diff --git a/changelogs/fragments/required-and-default.yml b/changelogs/fragments/required-and-default.yml\nnew file mode 100644\ninde... | [
{
"diff_hunk": "@@ -0,0 +1,3 @@\n+---\n+bugfixes:\n+ - tests - update regex for detecting default and required values in FieldAttributes (https://github.com/ansible/ansible/issues/61460).",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": "changelogs/fragments/required-and... | 7cd4b0e8af33b1ee87859ac6ed4b0e45c8183475 | diff --git a/test/sanity/code-smell/required-and-default-attributes.py b/test/sanity/code-smell/required-and-default-attributes.py
index 900829dce7409e..7b1c89f9b8bcca 100644
--- a/test/sanity/code-smell/required-and-default-attributes.py
+++ b/test/sanity/code-smell/required-and-default-attributes.py
@@ -1,19 +1,25 @@... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-84597@066dcc5 | ansible/ansible | Python | 84,597 | debug: hide loop variables while using var | ##### SUMMARY
Fixes: #65856
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
##### ISSUE TYPE
- Bugfix Pull Request
| 2025-01-23T16:30:34Z | Debug verbosity not working as expected
##### SUMMARY
The `debug` module is too noisy, and doesnt output only what is being requested. And the `verbosity` property isnt working as expected.
The `debug` module is outputting more than is being asked.
When I set `verbosity: 3` and do not use `-v` / `-vv` / `-vvv` ... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
The `verbosi... | [
{
"body": "##### SUMMARY\r\nThe `debug` module is too noisy, and doesnt output only what is being requested. And the `verbosity` property isnt working as expected.\r\n\r\nThe `debug` module is outputting more than is being asked. \r\n\r\nWhen I set `verbosity: 3` and do not use `-v` / `-vv` / `-vvv` etc on the ... | 03d6209862730daaf131226443cdb98189b911aa | {
"head_commit": "066dcc5bb5ab769a5ae2daceed6ca0e0bd2fe318",
"head_commit_message": "debug: hide loop variables while using var\n\nFixes: #65856\n\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>",
"patch_to_review": "diff --git a/changelogs/fragments/hide-loop-vars-debug-vars.yml b/changelogs/fragments/hid... | [
{
"diff_hunk": "@@ -432,6 +432,9 @@ def _clean_results(self, result, task_name):\n # 'var' value as field, so eliminate others and what is left should be varname\n for hidme in self._hide_in_debug:\n result.pop(hidme, None)\n+ for control_var in... | def92b6082a39f241f04b2529cba3781bc24301b | diff --git a/changelogs/fragments/hide-loop-vars-debug-vars.yml b/changelogs/fragments/hide-loop-vars-debug-vars.yml
new file mode 100644
index 00000000000000..975ab2f75abd49
--- /dev/null
+++ b/changelogs/fragments/hide-loop-vars-debug-vars.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+ - debug - hide loop vars in debug var d... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-84149@e80e6fe | ansible/ansible | Python | 84,149 | Add --flush-cache for ad-hoc commands | ##### SUMMARY
Added --flush-cache for ad-hoc commands
Fixes: #83749
##### ISSUE TYPE
- Feature Pull Request
##### ADDITIONAL INFORMATION
<!--- Include additional information to help people understand the change here -->
<!--- A step-by-step reproduction of the problem is helpful if there is no related ... | 2024-10-20T14:21:56Z | Option to flush or ignore inventory cache for ad-hoc commands
### Summary
I would like an option like the ansible-playbook option `--flush-caches` for the `ansible` command.
I use the redis caching plugin to cache my (netbox) inventory. When I use ad-hoc commands to quickly test & perform one-off actions I would li... | like?
`ANSIBLE_INVENTORY_CACHE_CONNECTION="" ansible-playbook ...` but you just want it to be a switch?
We are trying to avoid the proliferation of switches and recommend using the env or ansible vars.
Files identified in the description:
None
If these files are incorrect, please update the `component name` sect... | [
{
"body": "### Summary\n\nI would like an option like the ansible-playbook option `--flush-caches` for the `ansible` command.\r\n\r\nI use the redis caching plugin to cache my (netbox) inventory. When I use ad-hoc commands to quickly test & perform one-off actions I would like the option to expire my cache imme... | 1e6ffc1d02559a26def6c9c3b07baf27032865a2 | {
"head_commit": "e80e6fe33a89d51bcd1226c8075b0b87bcc9df9c",
"head_commit_message": "add --flush-cache option for the ansible command",
"patch_to_review": "diff --git a/changelogs/fragments/84149-add-flush-cache-for-adhoc-commands.yml b/changelogs/fragments/84149-add-flush-cache-for-adhoc-commands.yml\nnew file m... | [
{
"diff_hunk": "@@ -558,6 +558,10 @@ def run(self):\n \n hosts = self.get_host_list(self.inventory, context.CLIARGS['subset'], self.pattern)\n \n+ # flush fact cache if requested\n+ if context.CLIARGS['flush_cache']:\n+ self._flush_cache(self.inventory, self.variable_manager)\n+... | a5edba8ade64dd420fd9c6bb3d04605f3fbc45a4 | diff --git a/changelogs/fragments/84149-add-flush-cache-for-adhoc-commands.yml b/changelogs/fragments/84149-add-flush-cache-for-adhoc-commands.yml
new file mode 100644
index 00000000000000..9f407a9a0da6ad
--- /dev/null
+++ b/changelogs/fragments/84149-add-flush-cache-for-adhoc-commands.yml
@@ -0,0 +1,2 @@
+minor_change... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-83547@891a73b | ansible/ansible | Python | 83,547 | apt: Report change when package is removed | ##### SUMMARY
While upgrade process removes a package, module should
report changed=True instead of changed=False
Fixes: #46314
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
##### ISSUE TYPE
- Bugfix Pull Request
| 2024-07-08T21:58:26Z | Using apt module, something changes but changed remains false and the change seems undetected
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automati... | Files identified in the description:
* [lib/ansible/modules/packaging/os/apt.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/packaging/os/apt.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot ... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nWhen using the apt module against mul... | 33565f377476ccd92643f6f32be814a00efb340d | {
"head_commit": "891a73b3dda052366b68f6c918f003d867a233ef",
"head_commit_message": "Fixed ubuntu 2204 test again\n\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>",
"patch_to_review": "diff --git a/changelogs/fragments/46314.yml b/changelogs/fragments/46314.yml\nnew file mode 100644\nindex 00000000000000.... | [
{
"diff_hunk": "@@ -0,0 +1,71 @@\n+# https://github.com/ansible/ansible/issues/46314\n+- block:\n+ - name: Remove upgrades from the equation\n+ apt:\n+ upgrade: true\n+ state: present\n+ update_cache: true\n+\n+ - name: Install foobar, installs foo as a dependency\n+ apt:\n+... | 4c63fd8dbcacb62f68013e02253f5d382be101ff | diff --git a/changelogs/fragments/46314.yml b/changelogs/fragments/46314.yml
new file mode 100644
index 00000000000000..9958061e8f61c0
--- /dev/null
+++ b/changelogs/fragments/46314.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+ - apt - report changed=True when some packages are being removed (https://github.com/ansible/ansibl... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-83499@cb38ca2 | ansible/ansible | Python | 83,499 | Fix tb for when env var contains % | ##### SUMMARY
By constructing the string utilizing f-string only.
Fixes #83498
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pu... | 2024-06-27T13:25:22Z | [2.17][command] Failure in environment construction due to special characters in variable
### Summary
On Ansible-Core 2.17 we came across a failing task that uses the `command` module. The task has an environment set that is constructed from a variable. One of the env variables to be set contained a `%D` which turned ... | Files identified in the description:
* [`lib/ansible/modules/command.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/command.py)
* [`lib/ansible/plugins/action/command.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/action/command.py)
If these files are incorrect, please ... | [
{
"body": "### Summary\n\nOn Ansible-Core 2.17 we came across a failing task that uses the `command` module. The task has an environment set that is constructed from a variable. One of the env variables to be set contained a `%D` which turned out to be the problem.\r\nThe task has worked fine on Ansible-Core 2.... | 0ee6e39615033d8eb451eca0a8d22407a1ded987 | {
"head_commit": "cb38ca2d0a70fa8132aeb3a4912b13eb4f6e86b6",
"head_commit_message": "Fix tb for when env var contains %\n\nBy constructing the string utilizing f-string only.\n\nFixes #83498",
"patch_to_review": "diff --git a/changelogs/fragments/83498-command-tb-env.yml b/changelogs/fragments/83498-command-tb-en... | [
{
"diff_hunk": "@@ -211,7 +211,7 @@ def build_module_command(self, env_string, shebang, cmd, arg_path=None):\n arg_path,\n ]\n \n- return f'{env_string}%s' % self.join(cps for cp in cmd_parts if cp and (cps := cp.strip()))\n+ return f'{env_string}{self.join(cps for cp in cmd_pa... | 9ecbef2921264ee5293d904010de214ad69698a8 | diff --git a/changelogs/fragments/83498-command-tb-env.yml b/changelogs/fragments/83498-command-tb-env.yml
new file mode 100644
index 00000000000000..b28ad18114adbd
--- /dev/null
+++ b/changelogs/fragments/83498-command-tb-env.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Fix a traceback when an environment variable contains cer... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-83508@69a226d | ansible/ansible | Python | 83,508 | Add mount_facts module | ##### SUMMARY
Add a module to gather mount information, including devices that don't look like paths (which are excluded by default fact gathering). Renamed to `mount_facts` for less typing, since the module is more generic now.
Fixes #24644
Marked as draft until I've added:
* [x] Tests
* [x] Changelog
##... | 2024-07-01T14:22:54Z | setup module: mounts not starting with / are not listed in ansible_mounts fact
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##... | `ansible_mounts` also leaves out stuff like VirtualBox shared folder mounts for the same reason as described above. Definitely seems like a bug.
cc @david_obrien
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
This issue is also affecting versio... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | f00e3d7762091a3427ade2df7812d551491c4528 | {
"head_commit": "69a226d990215e188c93ae673d92f1cb6705bdad",
"head_commit_message": "Prefer first mount from first source and reorder the default sources\nto dynamic, static so the current mount still wins.\n\nAdd toggle \"include_aggregate_mounts\" for return aggregate_mounts in\naddition to mount_points.\n\nWhen ... | [
{
"diff_hunk": "@@ -0,0 +1,637 @@\n+# -*- coding: utf-8 -*-\n+# Copyright (c) 2024 Ansible Project\n+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\n+\n+from __future__ import annotations\n+\n+\n+DOCUMENTATION = \"\"\"\n+---\n+module: mount_facts\n+version_added: 2.... | 62cfd730698f8a426cf3608c1d49519f19abe1c7 | diff --git a/changelogs/fragments/83508_mount_facts.yml b/changelogs/fragments/83508_mount_facts.yml
new file mode 100644
index 00000000000000..baa7e592b18fae
--- /dev/null
+++ b/changelogs/fragments/83508_mount_facts.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - Add a new mount_facts module to support gathering information... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-82854@dafa3c8 | ansible/ansible | Python | 82,854 | Allow "role_name : " prefix for notifying handler listen topics | ##### SUMMARY
Allow notifying handler listen topics more similarly to handler names.
This handler:
```yaml
- name: handler name
debug:
listen: topic1
```
can be now be notified using `topic1`, `role : topic1` if the handler is in a standalone or collection role, and `ns.col.role : topic1` if the role is... | 2024-03-19T17:49:48Z | Cannot locate handlers in different role when using 'listen:' instead of handler name
### Summary
I have two handlers with unique names, and a `listen:` statement for both with the same name, so I can call on both with a single statement. They are part of a "configure" role. When I run my "install" role, which imports... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the [component](https://github.com/ansible/ansibotmini#commands) bot command.
<!--- boilerplate: components_banner ---> | [
{
"body": "### Summary\n\nI have two handlers with unique names, and a `listen:` statement for both with the same name, so I can call on both with a single statement. They are part of a \"configure\" role. When I run my \"install\" role, which imports the \"configure\" role as a task, I can call on \"configure\... | 56fa630e479989ed65618a5d8b9decbac85834b4 | {
"head_commit": "dafa3c84dee5e6ee48f7eef8ce6031ccdea53917",
"head_commit_message": "Allow role name prefix for handler task listen topics\n\nFor example,\n\n- name: handler name\n debug:\n listen: topic1\n\ncan be notified using `topic1`, `role : topic1` if the handler is in a\nstandalone or collection role, and... | [
{
"diff_hunk": "@@ -113,6 +114,20 @@\n - \"notify_listen_ran_4_3 is defined\"\n - \"notify_listen_in_role_4 is defined\"\n - \"notify_listen_from_role_4 is defined\"\n+ - name: test notifying handlers using the role name prefix\n+ command: /bin/true",
"line": null,
... | 34ea2cb1b44c020362130218a2b9c06efd21fe33 | diff --git a/changelogs/fragments/fix-role-name-handler-prefix-listen.yml b/changelogs/fragments/fix-role-name-handler-prefix-listen.yml
new file mode 100644
index 00000000000000..c065585cc155c2
--- /dev/null
+++ b/changelogs/fragments/fix-role-name-handler-prefix-listen.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - 'Fix notifyi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-82723@9925ede | ansible/ansible | Python | 82,723 | ansible-test - Add work-around for pytest>=8 errors | ##### SUMMARY
Resolves https://github.com/ansible/ansible/issues/82713
Adding the `--confcutdir` option to the `pytest` invocation prevents pytest >= 8 from searching for `conftest.py` in unwanted locations, such as all directories under `/home`. This can occur when running ansible-test from an install, where it ... | 2024-02-21T04:01:23Z | ansible-test unit tests fail with pytest>=8
### Summary
When running ansible-test unit tests with pytest>=8 it fails with the following trace. Pinning pytest<8 in requirements.txt fixes the issue.
```
________________________ ERROR collecting test session _________________________
tests/output/.tmp/delegation/pyt... | Files identified in the description:
* [`bin/ansible-test`](https://github.com/ansible/ansible/blob/devel/bin/ansible-test)
If these files are incorrect, please update the `component name` section of the description or use the [component](https://github.com/ansible/ansibotmini#commands) bot command.
<!--- boilerplat... | [
{
"body": "### Summary\r\n\r\nWhen running ansible-test unit tests with pytest>=8 it fails with the following trace. Pinning pytest<8 in requirements.txt fixes the issue.\r\n```\r\n________________________ ERROR collecting test session _________________________\r\ntests/output/.tmp/delegation/python3.9/lib/pyth... | 386edc666ec2a053b4d576fc4b2deeb46fe492b8 | {
"head_commit": "9925ede0854e372ee7c92b31d9499719cc3d16e0",
"head_commit_message": "ansible-test - Add work-around for pytest>=8 errors",
"patch_to_review": "diff --git a/changelogs/fragments/ansible-test-pytest-8.yml b/changelogs/fragments/ansible-test-pytest-8.yml\nnew file mode 100644\nindex 00000000000000..b... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+minor_changes:\n+ - ansible-test - Add a work-around for permission denied errors when using pytest >= 8 on multi-user systems with an installed version of ansible-test.",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragme... | a5453e4c759af901a47b60b97303e0a905cc8446 | diff --git a/changelogs/fragments/ansible-test-pytest-8.yml b/changelogs/fragments/ansible-test-pytest-8.yml
new file mode 100644
index 00000000000000..de863194c38fd5
--- /dev/null
+++ b/changelogs/fragments/ansible-test-pytest-8.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - ansible-test - Add a work-around for permission d... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} |
ansible__ansible-82543@dd45344 | ansible/ansible | Python | 82,543 | Deprecate support for the v2 galaxy API | ##### SUMMARY
Deprecate support for the v2 galaxy API. Fixes #81781
##### ISSUE TYPE
- Bugfix Pull Request
##### ADDITIONAL INFORMATION
The v2 API is being removed in https://github.com/pulp/pulp_ansible/pull/1701
GalaxyNG and the new community galaxy do not include the v2 API.
The plan is likely t... | 2024-01-15T16:50:00Z | Deprecate and remove Galaxy v2 API support
### Summary
With the migration of galaxy.ansible.com to GalaxyNG, the v2 API should no longer be used anywhere. OG Galaxy was the only supported server that implemented the v2 API, and with it being decommissioned, it's probably best to remove it from our code.
I recomm... | Files identified in the description:
* [`bin/ansible-galaxy`](https://github.com/ansible/ansible/blob/devel/bin/ansible-galaxy)
If these files are incorrect, please update the `component name` section of the description or use the [component](https://github.com/ansible/ansibotmini#ansibotmini) bot command.
<!--- boi... | [
{
"body": "### Summary\r\n\r\nWith the migration of galaxy.ansible.com to GalaxyNG, the v2 API should no longer be used anywhere. OG Galaxy was the only supported server that implemented the v2 API, and with it being decommissioned, it's probably best to remove it from our code.\r\n\r\nI recommend deprecating ... | bf9509bf33b2675d73f4abe72bebb91815d284f5 | {
"head_commit": "dd4534425d21213b1e1733631c73414840018ebe",
"head_commit_message": "clog frag",
"patch_to_review": "diff --git a/changelogs/fragments/deprecate-v2-galaxy-api.yml b/changelogs/fragments/deprecate-v2-galaxy-api.yml\nnew file mode 100644\nindex 00000000000000..a0513da5063a01\n--- /dev/null\n+++ b/ch... | [
{
"diff_hunk": "@@ -133,6 +133,15 @@ def wrapped(self, *args, **kwargs):\n % (method.__name__, \", \".join(versions), \", \".join(available_versions),\n self.name, self.api_server))\n \n+ # Warn only when we know we are talking ... | e0317497ed882d3be10448adf566190a42d4c96b | diff --git a/changelogs/fragments/deprecate-v2-galaxy-api.yml b/changelogs/fragments/deprecate-v2-galaxy-api.yml
new file mode 100644
index 00000000000000..a0513da5063a01
--- /dev/null
+++ b/changelogs/fragments/deprecate-v2-galaxy-api.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- ansible-galaxy - Deprecate use of the Galaxy v2 AP... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-82273@5b413e5 | ansible/ansible | Python | 82,273 | fix loading vars_plugins in roles | ##### SUMMARY
Fixes #82239
Adding a new role dir to the plugin loader clears the plugin loader cache, but the variable `cached_vars_plugin_order` in ansible.vars.plugins is never reset, preventing new plugins from being found.
Remove cache in the middle and use the vars plugin loader cache as the load-order. T... | 2023-11-22T21:34:42Z | Ansible 2.16 cannot load a vars plugin from role anymore
### Summary
More specifically, I am using gekmihesg.openwrt to manage a number of OpenWRT routers (which do not have python support) using distro version(s) of ansible.
With upgrade to Fedora 39, I got ansible-core 2.16.0~rc1, release 1.fc39 which I suppose i... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the [component](https://github.com/ansible/ansibotmini#ansibotmini) bot command.
<!--- boilerplate: components_banner --->
> Moving on to poetry install ansible instead, I not... | [
{
"body": "### Summary\n\nMore specifically, I am using gekmihesg.openwrt to manage a number of OpenWRT routers (which do not have python support) using distro version(s) of ansible.\r\n\r\nWith upgrade to Fedora 39, I got ansible-core 2.16.0~rc1, release 1.fc39 which I suppose is something very close to the cu... | 6b9f49b6c54ae8e42d8aec92cda7f5e8933be7ac | {
"head_commit": "5b413e565bafb42f9ab4c5626ac33adf66c86785",
"head_commit_message": "remove extra exception handling",
"patch_to_review": "diff --git a/changelogs/fragments/fix-vars-plugins-in-roles.yml b/changelogs/fragments/fix-vars-plugins-in-roles.yml\nnew file mode 100644\nindex 00000000000000..b64d586b9ef5f... | [
{
"diff_hunk": "@@ -13,7 +13,7 @@\n import sys\n import warnings\n \n-from collections import defaultdict, namedtuple\n+from collections import defaultdict, namedtuple, OrderedDict",
"line": null,
"original_line": 16,
"original_start_line": null,
"path": "lib/ansible/plugins/loader.py",
"sta... | 3711be852b1829e0e9575ec886f9cdbfe14589d8 | diff --git a/changelogs/fragments/fix-vars-plugins-in-roles.yml b/changelogs/fragments/fix-vars-plugins-in-roles.yml
new file mode 100644
index 00000000000000..b64d586b9ef5ff
--- /dev/null
+++ b/changelogs/fragments/fix-vars-plugins-in-roles.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Fix loading vars_plugins in roles (https:/... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-82173@65a5020 | ansible/ansible | Python | 82,173 | git: Check if version is populated or not | ##### SUMMARY
Before usage check if the git version is populated or not.
Fixes: #72321
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
##### ISSUE TYPE
- Test Pull Request | 2023-11-08T15:21:19Z | ansible-pull git module fails when HOME is not set
##### SUMMARY
ansible-pull git module fails when HOME is not set. It will produce the error shown in `ACTUAL RESULTS` when eg. run as a LaunchDaemon on macOS. But will perform fine when run as a LaunchDaemon when explicitly setting HOME to eg "/var/root"
##### ISSU... | Files identified in the description:
* [`lib/ansible/modules/git.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/git.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/... | [
{
"body": "##### SUMMARY\r\nansible-pull git module fails when HOME is not set. It will produce the error shown in `ACTUAL RESULTS` when eg. run as a LaunchDaemon on macOS. But will perform fine when run as a LaunchDaemon when explicitly setting HOME to eg \"/var/root\"\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r... | 2816922cd6f081d76a0425333cabf0f52f7b06a6 | {
"head_commit": "65a5020d1aa770feda5524e6a3a25658577a7655",
"head_commit_message": "git: Check if version is populated or not\n\nBefore usage check if the git version is populated or not.\n\nFixes: #72321\n\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>",
"patch_to_review": "diff --git a/changelogs/fragm... | [
{
"diff_hunk": "@@ -669,6 +669,8 @@ def get_diff(module, git_path, dest, repo, remote, depth, bare, before, after):\n elif before != after:\n # Ensure we have the object we are referring to during git diff !\n git_version_used = git_version(git_path, module)\n+ if git_version_used is ... | dc3495de9496622299fdfe4c4fbd38016e2feceb | diff --git a/changelogs/fragments/72321_git.yml b/changelogs/fragments/72321_git.yml
new file mode 100644
index 00000000000000..8ba0ca7558ccfb
--- /dev/null
+++ b/changelogs/fragments/72321_git.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+- git - check if git version is available or not before using it for comparison (https://... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-82498@c5e950c | ansible/ansible | Python | 82,498 | ansible-config dedupe ini plugin entries | fixes #82481
##### ISSUE TYPE
- Bugfix Pull Request
| 2024-01-08T16:03:36Z | ansible-config init -t all generate many multiple duplicate option
### Summary
I use `ansible-config init -t all` to gernerate ansible.cfg
there have many duplicate option inside
### Issue Type
Bug Report
### Component Name
pip
### Ansible Version
```console
$ ansible --version
ansible [core 2.16.2]
confi... | Files identified in the description:
* [`lib/ansible/modules/pip.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/pip.py)
If these files are incorrect, please update the `component name` section of the description or use the [component](https://github.com/ansible/ansibotmini#commands) bot comman... | [
{
"body": "### Summary\n\nI use `ansible-config init -t all` to gernerate ansible.cfg\r\n\r\nthere have many duplicate option inside\n\n### Issue Type\n\nBug Report\n\n### Component Name\n\npip\n\n### Ansible Version\n\n```console\n$ ansible --version\r\nansible [core 2.16.2]\r\n config file = None\r\n config... | caa86cc4dfc3d1825158396bb2e5017b35131fa3 | {
"head_commit": "c5e950c2e81581c8d91ec51d22e5fb8ba19f8a48",
"head_commit_message": "ansible-config dedupe ini plugin entries\n\n added test for ini file integrity, also ensuring no dupes",
"patch_to_review": "diff --git a/changelogs/fragments/dedupe_config_init.yml b/changelogs/fragments/dedupe_config_init.yml\n... | [
{
"diff_hunk": "@@ -89,6 +89,7 @@ lib/ansible/plugins/inventory/advanced_host_list.py pylint:arguments-renamed\n lib/ansible/plugins/inventory/host_list.py pylint:arguments-renamed\n lib/ansible/utils/collection_loader/_collection_finder.py pylint:deprecated-class\n lib/ansible/utils/collection_loader/_collecti... | f879d6c00ebc366b36197f49703d43b315de1830 | diff --git a/changelogs/fragments/dedupe_config_init.yml b/changelogs/fragments/dedupe_config_init.yml
new file mode 100644
index 00000000000000..16306fc13fad5d
--- /dev/null
+++ b/changelogs/fragments/dedupe_config_init.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - ansible-config init will now dedupe ini entries from plugins.
d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-82012@a28d503 | ansible/ansible | Python | 82,012 | Fix additional spelling errors in builtin modules | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #81808
Multiple additional spelling error corrections to those listed in the Issue documentation.
##### ISSUE TYPE
<!--- Pick one ... | 2023-10-18T17:50:19Z | Fix spelling errors in builtin modules
### Summary
This is a hacktoberfest issue.
Fix the following spelling errors:
- [x] lib/ansible/plugins/connection/winrm.py:151: bewteen ==> between
- [x] lib/ansible/plugins/connection/winrm.py:152: alligns ==> aligns
- [x] lib/ansible/modules/apt.py:209: excutable ==>... | ooph.. .I don't have rights to add labels - can someone add `hacktoberfest` to this issue pls?
These are not misspellings (https://docs.python.org/3/library/stat.html#stat.S_IWOTH)
```
lib/ansible/modules/stat_module.py:2346: woth ==> worth
lib/ansible/modules/stat_module.py:2348: woth ==> worth
lib/ansible/modul... | [
{
"body": "### Summary\r\n\r\nThis is a hacktoberfest issue.\r\n\r\nFix the following spelling errors:\r\n\r\n- [x] lib/ansible/plugins/connection/winrm.py:151: bewteen ==> between\r\n- [x] lib/ansible/plugins/connection/winrm.py:152: alligns ==> aligns\r\n- [x] lib/ansible/modules/apt.py:209: excutable ==> exe... | 74f6e6a134fa4fe57a80c6c0748772ac13182f1b | {
"head_commit": "a28d5030f19d2402ed9af90b705f3bd17cfa023d",
"head_commit_message": "Undo spell error corrections in test files",
"patch_to_review": "diff --git a/lib/ansible/module_utils/powershell/Ansible.ModuleUtils.WebRequest.psm1 b/lib/ansible/module_utils/powershell/Ansible.ModuleUtils.WebRequest.psm1\ninde... | [
{
"diff_hunk": "@@ -1417,7 +1417,7 @@ def _load_plugin_filter():\n display.warning(u'The plugin filter file, {0} does not exist.'\n u' Skipping.'.format(filter_cfg))\n \n- # Specialcase the stat module as Ansible can run very few things if stat is rejected\n+ # Spec... | 89be31eaaf6fe6c7f4086b44bfa82094041a5779 | diff --git a/lib/ansible/module_utils/powershell/Ansible.ModuleUtils.WebRequest.psm1 b/lib/ansible/module_utils/powershell/Ansible.ModuleUtils.WebRequest.psm1
index b59ba72f23f811..29e5be1673e42e 100644
--- a/lib/ansible/module_utils/powershell/Ansible.ModuleUtils.WebRequest.psm1
+++ b/lib/ansible/module_utils/powershe... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-81711@3a70b16 | ansible/ansible | Python | 81,711 | remote log info | fixes #81710
Includes the value of the `ansible_target_log_info` var in all module invocations (also globally settable on the control node via the `ANSIBLE_TARGET_LOG_INFO` envvar). Python and Powershell Ansible modules will include this value in syslog/event log messages they write.
An AWX/Controller job templa... | 2023-09-18T18:35:05Z | Configurable sampling/transfer of control-side task context metadata to targets
### Summary
We're often asked how to include arbitrary control-side contextual metadata with task invocations, and to include that metadata in target-side task log messages. e.g.: sending an AWX/Controller Job ID to the target hosts on eac... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the [component](https://github.com/ansible/ansibotmini#ansibotmini) bot command.
<!--- boilerplate: components_banner --->
~see #55623~ wrong one .. had same with logging tty ... | [
{
"body": "### Summary\n\nWe're often asked how to include arbitrary control-side contextual metadata with task invocations, and to include that metadata in target-side task log messages. e.g.: sending an AWX/Controller Job ID to the target hosts on each module invocation that occurred from that job, and loggin... | 598a9307d7f79e4c7839b2d6ff7ef650ba6dd377 | {
"head_commit": "3a70b1670fb3c57bafd6eef456d024ceb9bfed6b",
"head_commit_message": "fixed due to fb",
"patch_to_review": "diff --git a/changelogs/fragments/log_id.yml b/changelogs/fragments/log_id.yml\nnew file mode 100644\nindex 00000000000000..3233bf796c48ee\n--- /dev/null\n+++ b/changelogs/fragments/log_id.ym... | [
{
"diff_hunk": "@@ -375,8 +379,18 @@ public void LogEvent(string message, EventLogEntryType logEntryType = EventLogEn\n }\n }\n if (sanitise)\n+ {\n message = (string)RemoveNoLogValues(message, noLogValues);\n- message = String.Format... | e3e94aa7f248c398fa137d72a99165f001626376 | diff --git a/changelogs/fragments/log_id.yml b/changelogs/fragments/log_id.yml
new file mode 100644
index 00000000000000..3233bf796c48ee
--- /dev/null
+++ b/changelogs/fragments/log_id.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - added configuration item ``TARGET_LOG_INFO`` that allows the user/author to add an information... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-81600@ff6fd06 | ansible/ansible | Python | 81,600 | test: remove ansible-examples.git repo | ##### SUMMARY
* To speed up git tests remove reference to ansible-examples.git
Fixes: #81327
##### ISSUE TYPE
- Test Pull Request | 2023-08-30T15:58:18Z | `git` integration test uses excessive network bandwidth
### Summary
The `git` integration test clones the `ansible-examples` repo (which has grown to > 50MB) numerous times from its Github source, and none of the tests appear to be getting additional benefit from the repeated internet access. This test should be rewri... | Files identified in the description:
* [`lib/ansible/modules/git.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/git.py)
* [`test`](https://github.com/ansible/ansible/blob/devel/test)
If these files are incorrect, please update the `component name` section of the description or use the [compone... | [
{
"body": "### Summary\n\nThe `git` integration test clones the `ansible-examples` repo (which has grown to > 50MB) numerous times from its Github source, and none of the tests appear to be getting additional benefit from the repeated internet access. This test should be rewritten in one or two steps to:\r\n\r\... | 65a96daaf40920c9fa1c8da10203f6a1cbe91ac7 | {
"head_commit": "ff6fd06c37eedda47afc7d65fbcf1d79522077c9",
"head_commit_message": "Make CI green\n\nSigned-off-by: Ansible Test Runner <noreply@example.com>",
"patch_to_review": "diff --git a/test/integration/targets/git/tasks/setup-local-repos.yml b/test/integration/targets/git/tasks/setup-local-repos.yml\nind... | [
{
"diff_hunk": "@@ -70,11 +70,11 @@\n # Same as the previous test, but this time we specify which ref\n # contains the SHA1\n - name: SPECIFIC-REVISION | update to revision by specifying the refspec\n- git:\n- repo: https://github.com/ansible/ansible-examples.git\n+ git: &git_ref_spec\n+ repo: \"{{ repo... | a7b57e5fc25e2b7da9a4722e8aa140aa8da00499 | diff --git a/test/integration/targets/git/tasks/setup-local-repos.yml b/test/integration/targets/git/tasks/setup-local-repos.yml
index 4626f1028bf74a..3723f4dda4cbf7 100644
--- a/test/integration/targets/git/tasks/setup-local-repos.yml
+++ b/test/integration/targets/git/tasks/setup-local-repos.yml
@@ -56,6 +56,16 @@
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Performance Optimizations"
} |
ansible__ansible-81473@a3fed8b | ansible/ansible | Python | 81,473 | Add documentation for systemd reload | ##### SUMMARY
Add documentation for systemd behavior when trying to reload a stopped service.
Fixes #80896
##### ISSUE TYPE
- Docs Pull Request
##### ADDITIONAL INFORMATION
| 2023-08-09T04:03:13Z | Systemd module with "state: reloaded" restarts service if service is stopped
### Summary
When reloading a service via Ansible systemd module, if the service is stopped, Ansible restarts it.
If I try to manually reload a service that is stopped I get this result :
```
root@testvm:~# systemctl reload haproxy.... | Files identified in the description:
* [`lib/ansible/modules/systemd.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/systemd.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://git... | [
{
"body": "### Summary\r\n\r\nWhen reloading a service via Ansible systemd module, if the service is stopped, Ansible restarts it. \r\n\r\nIf I try to manually reload a service that is stopped I get this result : \r\n\r\n```\r\nroot@testvm:~# systemctl reload haproxy.service\r\nhaproxy.service is not active, ca... | fa5fe8a7db51cc5ff62689780db5296821708a19 | {
"head_commit": "a3fed8b0e230e9052fb24aa0986c4f8b8e5aacac",
"head_commit_message": "Remove trailing whitespace",
"patch_to_review": "diff --git a/lib/ansible/modules/systemd_service.py b/lib/ansible/modules/systemd_service.py\nindex 47ff3cf6ddb328..6f4cf61f21f9c4 100644\n--- a/lib/ansible/modules/systemd_service... | [
{
"diff_hunk": "@@ -26,7 +26,8 @@\n state:\n description:\n - V(started)/V(stopped) are idempotent actions that will not run commands unless necessary.\n- V(restarted) will always bounce the unit. V(reloaded) will always reload.\n+ V(restarted) will always bounc... | aec64249e9689718d4435c2b977bde322d204402 | diff --git a/lib/ansible/modules/systemd_service.py b/lib/ansible/modules/systemd_service.py
index 47ff3cf6ddb328..1abfaaed53f115 100644
--- a/lib/ansible/modules/systemd_service.py
+++ b/lib/ansible/modules/systemd_service.py
@@ -26,7 +26,8 @@
state:
description:
- V(started)/V(stopped) are ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-81406@2f2bd3f | ansible/ansible | Python | 81,406 | dpkg_selections: Check if package exists before selection operation | ##### SUMMARY
Fixes: #81404
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
changelogs/fragments/dpkg_selections.yml
lib/ansible/modules/dpkg_selections.py
test/integration/targets/dpkg_selections/tasks/dpkg_selections.yaml
| 2023-08-02T16:27:41Z | Module ansible.builtin.dpkg_selections not idempotent.
### Summary
The module `ansible.builtin.dpkg_selections` keeps on changing with the same arguments.
### Issue Type
Bug Report
### Component Name
dpkg_selections
### Ansible Version
```console
$ ansible --version
ansible [core 2.15.1]
config file = None
... | Files identified in the description:
* [`lib/ansible/modules/dpkg_selections.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/dpkg_selections.py)
If these files are incorrect, please update the `component name` section of the description or use the [component](https://github.com/mkrizek/ansibotm... | [
{
"body": "### Summary\n\nThe module `ansible.builtin.dpkg_selections` keeps on changing with the same arguments.\n\n### Issue Type\n\nBug Report\n\n### Component Name\n\ndpkg_selections\n\n### Ansible Version\n\n```console\n$ ansible --version\r\nansible [core 2.15.1]\r\n config file = None\r\n configured mo... | b9daa6891fbcce5a84dfdf06a221190b33d8e1b8 | {
"head_commit": "2f2bd3fcd3ab9bdc95049a558cfbfb9cb6c73491",
"head_commit_message": "Make CI happy\n\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>",
"patch_to_review": "diff --git a/changelogs/fragments/dpkg_selections.yml b/changelogs/fragments/dpkg_selections.yml\nnew file mode 100644\nindex 0000000000... | [
{
"diff_hunk": "@@ -0,0 +1,3 @@\n+---\n+bugfixes:\n+- dpkg_selections - check if the package exists before preforming the selection operation (https://github.com/ansible/ansible/issues/81404).",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": "changelogs/fragments/dpkg_sel... | 3a5bfb1e36b77cbcc59cbc33d8214cf95d44ba4c | diff --git a/changelogs/fragments/dpkg_selections.yml b/changelogs/fragments/dpkg_selections.yml
new file mode 100644
index 00000000000000..5a4008cabcb3e8
--- /dev/null
+++ b/changelogs/fragments/dpkg_selections.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+- dpkg_selections - check if the package exists before performing the s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-80995@0b08e30 | ansible/ansible | Python | 80,995 | Fix ansible.builtin.include_vars - depth | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Changed vars.py, so it starts from depth 1 as root, as suggested by @sivel
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #80987
##### ISSUE TYPE
<!--- Pick one below and delete the rest... | 2023-06-07T21:16:54Z | ansible.builtin.include_vars - depth doesn't work as described
### Summary
Not all var files which are located in the specified depth of a "dir" are included.
### Issue Type
Bug Report
### Component Name
ansible.builtin.include_vars
### Ansible Version
```console
$ ansible --version
ansible [core... | Files identified in the description:
* [`lib/ansible/modules/include_vars.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/include_vars.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](h... | [
{
"body": "### Summary\r\n\r\nNot all var files which are located in the specified depth of a \"dir\" are included.\r\n\r\n### Issue Type\r\n\r\nBug Report\r\n\r\n### Component Name\r\n\r\nansible.builtin.include_vars\r\n\r\n### Ansible Version\r\n\r\n```console\r\n$ ansible --version\r\nansible [core 2.14.6]\r... | 4aa109897fec936f11ab0799336a07bb5b93111b | {
"head_commit": "0b08e305201f8ddf09acee24df0b8c36aebd3028",
"head_commit_message": "Adding changelog fragment and tests",
"patch_to_review": "diff --git a/changelogs/fragments/80995-include-all-var-files.yml b/changelogs/fragments/80995-include-all-var-files.yml\nnew file mode 100644\nindex 00000000000000..1847f... | [
{
"diff_hunk": "@@ -4,3 +4,21 @@ set -eux\n \n ansible testhost -i ../../inventory -m include_vars -a 'dir/inc.yml' \"$@\"\n ansible testhost -i ../../inventory -m include_vars -a 'dir=dir' \"$@\"\n+\n+ansible-playbook playbook.yml>output.txt",
"line": null,
"original_line": 8,
"original_start_line"... | ab06082a2796a9e7a7ce6dce026996919c22a3c9 | diff --git a/changelogs/fragments/80995-include-all-var-files.yml b/changelogs/fragments/80995-include-all-var-files.yml
new file mode 100644
index 00000000000000..f1ac72b8970b89
--- /dev/null
+++ b/changelogs/fragments/80995-include-all-var-files.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- include_vars - fix calculating ``depth... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-80958@8b49ee5 | ansible/ansible | Python | 80,958 | Update user module documentation to include MacOS password change behavior | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
[User Module] Include MacOS password change behaviour in documentation
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes https://github.com/ansible/ansible/issues/80884
##### ISSUE TYPE
<!---... | 2023-06-02T15:16:48Z | Add an user in macOS with idempotent
### Summary
User module is not idempotent when update_password: always parameter set in the playbook for macOS
Result is always showing changed if use already present and no changes in the password .
### Issue Type
Bug Report
### Component Name
user
### Ansible Versi... | Files identified in the description:
* [`lib/ansible/modules/user.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/user.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.co... | [
{
"body": "### Summary\n\nUser module is not idempotent when update_password: always parameter set in the playbook for macOS \r\n\r\nResult is always showing changed if use already present and no changes in the password . \r\n\r\n\n\n### Issue Type\n\nBug Report\n\n### Component Name\n\nuser\n\n### Ansible Vers... | 660f1726c814e9d7502cdb7ba046ee8ad9014e63 | {
"head_commit": "8b49ee53240c01d3aafdbdcad9929b545f81203d",
"head_commit_message": "Update user module documentation to include MacOS password change behavior",
"patch_to_review": "diff --git a/lib/ansible/modules/user.py b/lib/ansible/modules/user.py\nindex dc2a2f6de5b091..5dcf985ba8bdbc 100644\n--- a/lib/ansib... | [
{
"diff_hunk": "@@ -93,6 +93,8 @@\n - To create an account with a locked/disabled password on Linux systems, set this to C('!') or C('*').\n - To create an account with a locked/disabled password on OpenBSD, set this to C('*************').\n - B(OS X/macOS:) Enter the clearte... | 3930dc7003a485b6200efc4ae5b797529630eeee | diff --git a/lib/ansible/modules/user.py b/lib/ansible/modules/user.py
index dc2a2f6de5b091..07c256d141c32f 100644
--- a/lib/ansible/modules/user.py
+++ b/lib/ansible/modules/user.py
@@ -93,6 +93,9 @@
- To create an account with a locked/disabled password on Linux systems, set this to C('!') or C('*').
... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-81178@c431afb | ansible/ansible | Python | 81,178 | first_found lookup, let lookup handle templating errors | Avoids case in which TE was not sending valid and templatable entries to the lookup The lookup already handles the case TE was attempting to itself, so no need for this code anymore.
fixes #70772
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Wri... | 2023-07-05T14:25:06Z | with_first_found fails to find a file if an undefined variable is used in the list since ansible 2.9
##### SUMMARY
<!--- Explain the problem briefly below -->
with_first_found fails "No file was found when using first_found. ..." even if a file matches search conditions, when an undefined variable is used in files pa... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
Files identif... | [
{
"body": "##### SUMMARY\r\n<!--- Explain the problem briefly below -->\r\nwith_first_found fails \"No file was found when using first_found. ...\" even if a file matches search conditions, when an undefined variable is used in files parameter.\r\nThis is started after I've upgraded from ansible 2.8 to 2.9, so ... | 73dde45f0f7fc87ccaa849e9de69d88120be7d2f | {
"head_commit": "c431afbccc6e05201d026872f3a9ac82e539de97",
"head_commit_message": "restore first_found fail for lookup terms",
"patch_to_review": "diff --git a/changelogs/fragments/first_found_template_fix.yml b/changelogs/fragments/first_found_template_fix.yml\nnew file mode 100644\nindex 00000000000000..70fe6... | [
{
"diff_hunk": "@@ -224,14 +224,11 @@ def _get_loop_items(self):\n items = None\n if self._task.loop_with:\n if self._task.loop_with in self._shared_loader_obj.lookup_loader:\n- fail = True\n- if self._task.loop_with == 'first_found':\n- ... | 4e096aa03210c39d1ac71b979fc55154abfc4910 | diff --git a/changelogs/fragments/first_found_template_fix.yml b/changelogs/fragments/first_found_template_fix.yml
new file mode 100644
index 00000000000000..70fe6b58628e1c
--- /dev/null
+++ b/changelogs/fragments/first_found_template_fix.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - first_found lookup now gets 'untemplated' loo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-80898@f47348f | ansible/ansible | Python | 80,898 | Register handlers immediately if currently iterating handlers | ##### SUMMARY
This fixes the issue where handlers notifying other handlers are not properly run because the notification is not registered unless another flush_handlers occurs. Instead, if the current host state is iterating handlers we immediately register the handler to be run so the notification is not lost.
Fix... | 2023-05-26T15:37:33Z | Problem with handlers notifying another handlers
### Summary
The ansible-core 2.15 ignores handlers notified by another handlers when are more than one case.
With the ansible-core 2.14, all cases of handlers notified by another handlers are runned.
### Issue Type
Bug Report
### Component Name
notify
... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/devel/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
I can verify t... | [
{
"body": "### Summary\r\n\r\nThe ansible-core 2.15 ignores handlers notified by another handlers when are more than one case.\r\n\r\nWith the ansible-core 2.14, all cases of handlers notified by another handlers are runned.\r\n\r\n### Issue Type\r\n\r\nBug Report\r\n\r\n### Component Name\r\n\r\nnotify\r\n\r\... | 5e550b608632251e2e919d1d85644a901f0233af | {
"head_commit": "f47348fe0df43b453620f9eb8da27769f39c3aa3",
"head_commit_message": "Adding test case for 80880\n\nTest case is based on reproducer given in #80880, with some minor\nadjustments and assertions.",
"patch_to_review": "diff --git a/lib/ansible/plugins/strategy/__init__.py b/lib/ansible/plugins/strate... | [
{
"diff_hunk": "@@ -653,19 +653,27 @@ def _process_pending_results(self, iterator, one_pass=False, max_passes=None):\n # handlers are actually flushed so the last defined handlers are exexcuted,\n # otherwise depending on the setting either error or warn\n ... | 9f284972155db54b0feef93cb394167c5a9209ab | diff --git a/changelogs/fragments/80880-register-handlers-immediately-if-iterating-handlers.yml b/changelogs/fragments/80880-register-handlers-immediately-if-iterating-handlers.yml
new file mode 100644
index 00000000000000..bc8d9de8bbe356
--- /dev/null
+++ b/changelogs/fragments/80880-register-handlers-immediately-if-i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-80570@33489d2 | ansible/ansible | Python | 80,570 | note in systemd that systemctl can change behaviour due to diff order… | … of operations
fixes #80533
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
modules/systemd_service | 2023-04-19T15:04:42Z | systemd module result is different than calling systemctl to stop and disable
### Summary
when i use ansible systemd module, but the result is different between using systemd module and not using systemd module.
```
- name: using systemd module
systemd:
name: my.service
state: stopped
... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/devel/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
@kimhongji: Gr... | [
{
"body": "### Summary\r\n\r\nwhen i use ansible systemd module, but the result is different between using systemd module and not using systemd module. \r\n\r\n\r\n```\r\n - name: using systemd module\r\n systemd:\r\n name: my.service\r\n state: stopped\r\n enabled: no\r\n```\r\n\r\n```\r\n- n... | 7b505715885cdf9ec8908125f399b12085c1b49c | {
"head_commit": "33489d224746cf1217fad04509c98db249727df9",
"head_commit_message": "note in systemd that systemctl can change behaviour due to diff order of operations",
"patch_to_review": "diff --git a/lib/ansible/modules/systemd_service.py b/lib/ansible/modules/systemd_service.py\nindex bad29bba67a917..1fa4aa9... | [
{
"diff_hunk": "@@ -90,6 +90,8 @@\n - Before 2.4 you always required C(name).\n - Globs are not supported in name, i.e C(postgres*.service).\n - The service names might vary by specific OS/distribution\n+ - The order of execution when having mulitple properties is to first enable/disable, then ma... | cedb1b6300606f40be0f3e69507510c7ee97e8a9 | diff --git a/lib/ansible/modules/systemd_service.py b/lib/ansible/modules/systemd_service.py
index bad29bba67a917..d142f865b58e7d 100644
--- a/lib/ansible/modules/systemd_service.py
+++ b/lib/ansible/modules/systemd_service.py
@@ -90,6 +90,8 @@
- Before 2.4 you always required C(name).
- Globs are not support... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-80112@e787745 | ansible/ansible | Python | 80,112 | documents approaches to octal modes better | ##### SUMMARY
Closes #78715.
The old documentation suggested prepending a `0` to signal octal values for `mode`. This approach fails in loops, possibly elsewhere.
This PR changes the documentation to recommend quoting octal values for `mode`, while noting that the initial 0 works in some cases (to help folks loo... | 2023-02-28T17:14:21Z | ansible.builtin.file: incorrect permissions being set when looping
### Summary
Setting file permissions for a list of files like this
```
my_items:
- path: dir1
mode: 0770
- ... further entries ..
```
using `ansible.builtin.file` results in incorrect permissions. For details see steps to reproduce ... | Files identified in the description:
* [`lib/ansible/modules/file.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/file.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.co... | [
{
"body": "### Summary\r\n\r\nSetting file permissions for a list of files like this\r\n```\r\nmy_items:\r\n - path: dir1\r\n mode: 0770\r\n - ... further entries ..\r\n```\r\n\r\nusing `ansible.builtin.file` results in incorrect permissions. For details see steps to reproduce below. \r\n\r\n### Issue Type... | 67bafafbc0d61751d2ec10b0aeccb6b01482a074 | {
"head_commit": "e7877459e9eb3f87772c91ef48f9f8b40c2c37c6",
"head_commit_message": "documents approaches to octal modes better",
"patch_to_review": "diff --git a/lib/ansible/plugins/doc_fragments/files.py b/lib/ansible/plugins/doc_fragments/files.py\nindex b87fd11d10257f..53b3b49385e0c6 100644\n--- a/lib/ansible... | [
{
"diff_hunk": "@@ -18,10 +18,11 @@ class ModuleDocFragment(object):\n description:\n - The permissions the resulting filesystem object should have.\n - For those used to I(/usr/bin/chmod) remember that modes are actually octal numbers.\n- You must either add a leading zero so that Ansible's YA... | 784a57e4ec5171b252aea3717b60ddbb1a0eaded | diff --git a/lib/ansible/plugins/doc_fragments/files.py b/lib/ansible/plugins/doc_fragments/files.py
index b87fd11d10257f..8e4f242fdda5b1 100644
--- a/lib/ansible/plugins/doc_fragments/files.py
+++ b/lib/ansible/plugins/doc_fragments/files.py
@@ -18,10 +18,11 @@ class ModuleDocFragment(object):
description:
-... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-80257@095e682 | ansible/ansible | Python | 80,257 | iptables chain creation does not populate with a rule |
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
iptables chain creation does not populate with a rule by default. Behaves more like the iptables command line tool.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
fixes #80256
##### ISSUE T... | 2023-03-18T14:34:04Z | iptables chain create does not behave like command
### Summary
When adding a new chain with the iptables module, there is a default rule created. This is different behavior from the iptables command.
I expect the iptables ansible module to behave the same as the command: `iptables -N TESTCHAIN`
### Issue Type
Bu... | Files identified in the description:
* [`lib/ansible/modules/iptables.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/iptables.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://g... | [
{
"body": "### Summary\n\nWhen adding a new chain with the iptables module, there is a default rule created. This is different behavior from the iptables command.\r\n\r\nI expect the iptables ansible module to behave the same as the command: `iptables -N TESTCHAIN`\n\n### Issue Type\n\nBug Report\n\n### Compon... | 1491ec8019b064374145dace41b1320e04fb494b | {
"head_commit": "095e682506338cbed6357afb56f48d6587e3cf10",
"head_commit_message": "Add changelog fragment",
"patch_to_review": "diff --git a/changelogs/fragments/80257-iptables-chain-creation-does-not-populate-a-rule.yml b/changelogs/fragments/80257-iptables-chain-creation-does-not-populate-a-rule.yml\nnew file... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+bugfixes:\n+ - iptables - fix iptables chain creation so it behaves like the command line utility (https://github.com/ansible/ansible/issues/80256).",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/80257-iptables-ch... | 6d9b464a80106f45c9a3a398a9a089407119666b | diff --git a/changelogs/fragments/80257-iptables-chain-creation-does-not-populate-a-rule.yml b/changelogs/fragments/80257-iptables-chain-creation-does-not-populate-a-rule.yml
new file mode 100644
index 00000000000000..a449d5c2231962
--- /dev/null
+++ b/changelogs/fragments/80257-iptables-chain-creation-does-not-populat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-80022@0399079 | ansible/ansible | Python | 80,022 | ansible-test - Show Python version before install | ##### SUMMARY
Always indicate the Python version being used before installing requirements.
Resolves https://github.com/ansible/ansible/issues/72855
##### ISSUE TYPE
Bugfix Pull Request
##### COMPONENT NAME
ansible-test
| 2023-02-17T00:59:27Z | ansible-test fails to mention which interpreter as soon it picks one
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMAR... | Files identified in the description:
* [`bin/ansible-test`](https://github.com/ansible/ansible/blob/devel/bin/ansible-test)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nansible-test fails to mention which i... | f841c2803a1e36bb6f392c466d36b669f9243464 | {
"head_commit": "0399079e62020193aefa8b1ea8fcc0f64384a2bc",
"head_commit_message": "ansible-test - Show Python version before install\n\nAlways indicate the Python version being used before installing requirements.",
"patch_to_review": "diff --git a/changelogs/fragments/ansible-test-requirements-message.yml b/ch... | [
{
"diff_hunk": "@@ -265,6 +266,20 @@ def run_pip(\n connection = connection or LocalConnection(args)\n script = prepare_pip_script(commands)\n \n+ if isinstance(args, IntegrationConfig):\n+ # Integration tests can involve two hosts (controller and target).\n+ # The connection type can b... | a0635ee9f0929ab5ceae3900dd286a81db647f4c | diff --git a/changelogs/fragments/ansible-test-requirements-message.yml b/changelogs/fragments/ansible-test-requirements-message.yml
new file mode 100644
index 00000000000000..864567be6a674c
--- /dev/null
+++ b/changelogs/fragments/ansible-test-requirements-message.yml
@@ -0,0 +1,3 @@
+bugfixes:
+ - ansible-test - Alw... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-79808@0a3c3dc | ansible/ansible | Python | 79,808 | fix installing collections from git repos that contain MANIFEST.json | ##### SUMMARY
Fixes #79796
As of 595413d11346b6f26bb3d9df2d8e05f2747508a3, collections in git repos can contain a galaxy.yml or MANIFEST.json (just like non-git repo directories).
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
ansible-galaxy collect... | 2023-01-24T16:26:13Z | 2.14 Issue with installing custom collections
### Summary
In 2.14+ we are getting errors when installing our local collections
Multiple versions of 2.13 (including 2.13.7) were tested against those same collections without any errors.
v2.14.0 Release notes do not include anything that I can see would have made break... | Files identified in the description:
* `lib/ansible/galaxy`
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/devel/ISSUE_HELP.md)
<!--- boilerplate: components_banner -... | [
{
"body": "### Summary\n\nIn 2.14+ we are getting errors when installing our local collections\r\nMultiple versions of 2.13 (including 2.13.7) were tested against those same collections without any errors.\r\nv2.14.0 Release notes do not include anything that I can see would have made breaking changes to ansibl... | 52d3d39ffcd797bb3167ab038148db815493d2a7 | {
"head_commit": "0a3c3dcee9823ce9a163e9ad64dbda5fe8ce9959",
"head_commit_message": "add null 'manifest' key to metadata for git repo collections containing MANIFEST.json\n\nchangelog",
"patch_to_review": "diff --git a/changelogs/fragments/ansible-galaxy-install-git-src-manifest.yml b/changelogs/fragments/ansible... | [
{
"diff_hunk": "@@ -1626,6 +1626,7 @@ def install_src(collection, b_collection_path, b_collection_output_path, artifac\n if 'build_ignore' not in collection_meta: # installed collection, not src\n # FIXME: optimize this? use a different process? copy instead of build?\n collection_meta['bui... | 25241bb391b33a39885076a11f28e6a667b965bb | diff --git a/changelogs/fragments/ansible-galaxy-install-git-src-manifest.yml b/changelogs/fragments/ansible-galaxy-install-git-src-manifest.yml
new file mode 100644
index 00000000000000..684d978eef3634
--- /dev/null
+++ b/changelogs/fragments/ansible-galaxy-install-git-src-manifest.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-79596@64f00ca | ansible/ansible | Python | 79,596 | ansible-inventory, add --limit option | fixes #77580
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Feature Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
ansible-inventory | 2022-12-14T17:29:53Z | filter the output of ansible-inventory --list
### Summary
`ansible-inventory --graph` can be specified with a group though, the output is not a JSON format so that we cannot parse the output easily.
It would be helpful for us if the `ansible-inventory --list` could accept the group name.
### Issue Type
Fe... | Files identified in the description:
* `lib/ansible/inventory`
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/devel/ISSUE_HELP.md)
<!--- boilerplate: components_banne... | [
{
"body": "### Summary\r\n\r\n`ansible-inventory --graph` can be specified with a group though, the output is not a JSON format so that we cannot parse the output easily.\r\n\r\nIt would be helpful for us if the `ansible-inventory --list` could accept the group name.\r\n\r\n\r\n### Issue Type\r\n\r\nFeature Ide... | 75b60b17ee1ff18ded04cf07b71e4ee32e673a0b | {
"head_commit": "64f00ca37e2fa62692df1c74f5f647d448be529d",
"head_commit_message": "i swear there as an ignore_errors there already!!?!?!?",
"patch_to_review": "diff --git a/changelogs/fragments/ainv_limit.yml b/changelogs/fragments/ainv_limit.yml\nnew file mode 100644\nindex 00000000000000..feb27fcfaf1d9a\n--- ... | [
{
"diff_hunk": "@@ -145,3 +145,14 @@\n loop_control:\n loop_var: toml_package\n when: toml_package is not contains 'tomllib' or (toml_package is contains 'tomllib' and ansible_facts.python.version_info >= [3, 11])\n+\n+- name: check that limit removes host\n+ command: ansible-inventory -i '{{ role_path... | d2b28d2ac3abe780c7086215c000ebbf8afcbdf9 | diff --git a/changelogs/fragments/ainv_limit.yml b/changelogs/fragments/ainv_limit.yml
new file mode 100644
index 00000000000000..feb27fcfaf1d9a
--- /dev/null
+++ b/changelogs/fragments/ainv_limit.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - ansible-inventory now supports the limit command line options.
diff --git a/lib/an... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-79182@c37a272 | ansible/ansible | Python | 79,182 | documentation fix for file module 78988 | ##### SUMMARY
Fixes #78988
##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
file module
lib/ansible/modules/file.py
##### ADDITIONAL INFORMATION
This is for documentation change requested in issue (78988)
| 2022-10-21T06:55:30Z | File module changes mode of src when state is link
### Summary
The file module is supposed to only affect `dest:`, but in cases where `state: link` and a `mode:` is supplied, the mode of `src:` — if it exists — is changed.
One could argue whether documenting the current behavior is sufficient vs. whether it's bette... | Files identified in the description:
* [`lib/ansible/modules/file.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/file.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.co... | [
{
"body": "### Summary\n\nThe file module is supposed to only affect `dest:`, but in cases where `state: link` and a `mode:` is supplied, the mode of `src:` — if it exists — is changed.\r\n\r\nOne could argue whether documenting the current behavior is sufficient vs. whether it's better to \"fix\" the file modu... | bcdc2286e853240372b241fd2a178c66f3bc494c | {
"head_commit": "c37a27284beb3dbc53c9ba3296ea45aa309d5706",
"head_commit_message": "correcting mssing semi-colon",
"patch_to_review": "diff --git a/lib/ansible/modules/file.py b/lib/ansible/modules/file.py\nindex 55489bcda503cf..0eb8ba0a8a0c6b 100644\n--- a/lib/ansible/modules/file.py\n+++ b/lib/ansible/modules/... | [
{
"diff_hunk": "@@ -15,7 +15,7 @@\n short_description: Manage files and file properties\n extends_documentation_fragment: [files, action_common_attributes]\n description:\n-- Set attributes of files, symlinks or directories.\n+- Set attributes of files, symlinks, their targets, or directories.",
"line": nul... | a2c4f46cbfa206d40a7ecdeae5dc46aded21ae96 | diff --git a/lib/ansible/modules/file.py b/lib/ansible/modules/file.py
index 55489bcda503cf..150ff6414d5011 100644
--- a/lib/ansible/modules/file.py
+++ b/lib/ansible/modules/file.py
@@ -15,7 +15,7 @@
short_description: Manage files and file properties
extends_documentation_fragment: [files, action_common_attributes]... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-79049@83224b8 | ansible/ansible | Python | 79,049 | Ensure that we do not squash keywords in validate | ##### SUMMARY
Ensure that we do not squash keywords in validate. Fixes #79021
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/playbook/base.py
##### ADDITIONAL INFORMATION
<!--- Include additional information to help people understand the change here -->
<!--- A step-by-step reprod... | 2022-10-05T17:18:35Z | become not applied on roles
### Summary
Become is not applied on roles when playbook has `become: true` set.
### Issue Type
Bug Report
### Component Name
become
### Ansible Version
```console
$ ansible --version
ansible [core 2.14.0b2]
config file = /home/twouters/.ansible.cfg
configured module search... | Files identified in the description:
* `lib/ansible/playbook/become.py`
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/devel/ISSUE_HELP.md)
<!--- boilerplate: compone... | [
{
"body": "### Summary\n\nBecome is not applied on roles when playbook has `become: true` set.\r\n\r\n\n\n### Issue Type\n\nBug Report\n\n### Component Name\n\nbecome\n\n### Ansible Version\n\n```console\n$ ansible --version\r\nansible [core 2.14.0b2]\r\n config file = /home/twouters/.ansible.cfg\r\n configur... | 680bf029b1c2430fab6988bc6cd8138d2d06a023 | {
"head_commit": "83224b825465c2a895bbb4e9f1ebcc11e8eacc2a",
"head_commit_message": "ci_complete",
"patch_to_review": "diff --git a/changelogs/fragments/79021-dont-squash-in-validate.yml b/changelogs/fragments/79021-dont-squash-in-validate.yml\nnew file mode 100644\nindex 00000000000000..52a1e30e03cb51\n--- /dev/... | [
{
"diff_hunk": "@@ -298,8 +298,10 @@ def _get_parent_attribute(self, attr, omit=False):\n '''\n Generic logic to get the attribute or parent attribute for a block value.\n '''\n- extend = self.fattributes.get(attr).extend\n- prepend = self.fattributes.get(attr).prepend\n+ ... | 892e238703fcd4c26cc1561841edf68695e53445 | diff --git a/changelogs/fragments/79021-dont-squash-in-validate.yml b/changelogs/fragments/79021-dont-squash-in-validate.yml
new file mode 100644
index 00000000000000..52a1e30e03cb51
--- /dev/null
+++ b/changelogs/fragments/79021-dont-squash-in-validate.yml
@@ -0,0 +1,3 @@
+bugfixes:
+- keyword inheritance - Ensure tha... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.