instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
ansible__ansible-53323@cd11b9d | ansible/ansible | Python | 53,323 | Remove dependency to psycopg2 with dump/restore | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
'dump' and 'restore' state only need pg_dump and pg_restore. These tools
don't use psycopg2 so this change tries to avoid the use of it in these
cases.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue ... | 2019-03-05T13:16:30Z | postgresql_db dump requires psycopg2
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bug Report
##### COMPONENT NAME
<!---
Name of the modul... | Files identified in the description:
* [lib/ansible/modules/database/postgresql/postgresql_db.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/database/postgresql/postgresql_db.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` ... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!---\r\nName of the m... | 7fef7136e76bd9c1546807ab5df06d071540db9c | {
"head_commit": "cd11b9d6165e4a9dc344b7f527443640b4a63ed9",
"head_commit_message": "Fix YAML syntax",
"patch_to_review": "diff --git a/changelogs/fragments/53323-no-psycopg2-for-dump-and-restore.yaml b/changelogs/fragments/53323-no-psycopg2-for-dump-and-restore.yaml\nnew file mode 100644\nindex 00000000000000..c... | [
{
"diff_hunk": "@@ -83,6 +83,8 @@\n type: str\n default: postgres\n version_added: \"2.5\"\n+notes:\n+- State C(dump) and C(restore) don't require I(psycopg2) since version 2.7.9.",
"line": null,
"original_line": 87,
"original_start_line": null,
"path": "lib/ansible/modules/database/... | f4204aa69c7e3429b83b3d5d7d5f7ee07f29407e | diff --git a/changelogs/fragments/53323-no-psycopg2-for-dump-and-restore.yaml b/changelogs/fragments/53323-no-psycopg2-for-dump-and-restore.yaml
new file mode 100644
index 00000000000000..c7e35f17073d89
--- /dev/null
+++ b/changelogs/fragments/53323-no-psycopg2-for-dump-and-restore.yaml
@@ -0,0 +1,8 @@
+bugfixes:
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-53445@95003ae | ansible/ansible | Python | 53,445 | Fix for "AttributeError: 'module' object has no attribute 'cursors'" (#49191) | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #49191.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short na... | 2019-03-07T09:30:14Z | Module ProxySQL - Backend_servers error
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
Using the proxysql_backend... | Hi @matt-horwood-mayden, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
* [lib/ansible/modules/database/proxysql/proxysql_backend_servers.py](https://github.com... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nUsing the proxysql_backend_servers mo... | ce9fc9b9120d692f674b693c68d63a2f3732f627 | {
"head_commit": "95003aee51fea2d88b7b408ef9f0bc7a97822ee9",
"head_commit_message": "Adding changelog fragment for issue #49191 and the following PR.",
"patch_to_review": "diff --git a/changelogs/fragments/49191-module_utils_mysql-unexpected-keyword-argument-cursorclass.yml b/changelogs/fragments/49191-module_uti... | [
{
"diff_hunk": "@@ -34,7 +34,7 @@\n _mysql_cursor_param = 'cursor'\n except ImportError:\n try:\n- import MySQLdb as mysql_driver\n+ import MySQLdb as mysql_driver, MySQLdb.cursors",
"line": null,
"original_line": 37,
"original_start_line": null,
"path": "lib/ansible/module... | 65e2e05b1402d1d7e573cad4fbc737ddad21a489 | diff --git a/changelogs/fragments/49191-module_utils_mysql-unexpected-keyword-argument-cursorclass.yml b/changelogs/fragments/49191-module_utils_mysql-unexpected-keyword-argument-cursorclass.yml
new file mode 100644
index 00000000000000..01139d4f39d9a3
--- /dev/null
+++ b/changelogs/fragments/49191-module_utils_mysql-u... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-53109@24cf9bb | ansible/ansible | Python | 53,109 | ios_logging: fix idempotence errors | ##### SUMMARY
Fixes #53226
Fixes #53227
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
ios_logging
| 2019-02-28T12:02:22Z | ios_logging: the module performs the configuration, even if not required (destination 'host')
##### SUMMARY
The module performs the configuration 'host' destination, even if not required.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
ios_logging
##### ANSIBLE VERSION
```
ansible 2.8.0.dev0
config ... | Files identified in the description:
* [lib/ansible/modules/network/ios/ios_logging.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/ios/ios_logging.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "##### SUMMARY\r\nThe module performs the configuration 'host' destination, even if not required.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nios_logging\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.8.0.dev0\r\n config file = /home/administrator/ansible/playbooks/ios_lo... | 4d3a6123d5b84ed8cdaba4e945e6f1d55c35c4b4 | {
"head_commit": "24cf9bbea60aab6deba3648532de7e279780e3ce",
"head_commit_message": "ios_logging: fixes #53227",
"patch_to_review": "diff --git a/lib/ansible/modules/network/ios/ios_logging.py b/lib/ansible/modules/network/ios/ios_logging.py\nindex 16211dcc11680d..ad19833c6a68ca 100644\n--- a/lib/ansible/modules/... | [
{
"diff_hunk": "@@ -274,6 +274,8 @@ def map_config_to_obj(module):\n data = get_config(module, flags=['| include logging'])\n \n for line in data.split('\\n'):\n+ if line.startswith(\"no \"): # 'no logging console' or similar",
"line": null,
"original_line": 277,
"original_start_line... | d11841574dbb2f28163844b92bec7e39a5a4c83b | diff --git a/lib/ansible/modules/network/ios/ios_logging.py b/lib/ansible/modules/network/ios/ios_logging.py
index 16211dcc11680d..8c1d59a4d4d560 100644
--- a/lib/ansible/modules/network/ios/ios_logging.py
+++ b/lib/ansible/modules/network/ios/ios_logging.py
@@ -274,7 +274,7 @@ def map_config_to_obj(module):
data ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-53072@9b7777b | ansible/ansible | Python | 53,072 | properly convert inputs to handle bytes/unicode | fixes #52186
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
inventory/nmap | 2019-02-27T17:40:38Z | nmap inventory plugin python3 cannot use a string pattern on a bytes-like object
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
... | Files identified in the description:
* [lib/ansible/plugins/inventory/nmap.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/inventory/nmap.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nWhen trying to use nmap dynamic inven... | fe2b159106827c22a7980911798e7faa9287fc39 | {
"head_commit": "9b7777b1e48cc4f1fec0b1dc5429fbeb7e0cb234",
"head_commit_message": "properly convert inputs to handle bytes/unicode\n\n fixes #52186",
"patch_to_review": "diff --git a/changelogs/fragments/nmap_bytes_fix.yml b/changelogs/fragments/nmap_bytes_fix.yml\nnew file mode 100644\nindex 00000000000000..5... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+bugfixes:\n+ - convert input into text to ensure valid comparissons in nmap inventory plugin",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/nmap_bytes_fix.yml",
"start_line": null,
"text": "@user1:\n```s... | 1de74a29ac609549cdee97a2f472e17d84ab370e | diff --git a/changelogs/fragments/nmap_bytes_fix.yml b/changelogs/fragments/nmap_bytes_fix.yml
new file mode 100644
index 00000000000000..309fc1cb153933
--- /dev/null
+++ b/changelogs/fragments/nmap_bytes_fix.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - convert input into text to ensure valid comparisons in nmap inventory plu... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-53006@2f6cfea | ansible/ansible | Python | 53,006 | Fix junos terminal regex for cluster srx devices |
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #50726
* Modify junos terminal regex to match for
string `{primary:node0}` which is also part of the
prompt.
* Modify network_cli connection plugin to ignore
multiple prompt matched lines.
<!--- HI... | 2019-02-26T17:56:07Z | Extraneous data in junos_command output with SRX cluster
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Exp... | Files identified in the description:
* [lib/ansible/modules/network/junos/junos_command.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/junos/junos_command.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 80cc6417fa2577c8920b00d9c871b52015bdbed3 | {
"head_commit": "2f6cfea7fc6c72b8ddcf545359d5c61e5978bf32",
"head_commit_message": "Fix junos terminal regex for cluster srx devices\n\nFixes #50726\n\n* Modify junos terminal regex to match for\n string `{primary:node0}` which is also part of the\n prompt.\n* Modify network_cli connection plugin to ignore\n... | [
{
"diff_hunk": "@@ -539,9 +539,15 @@ def _sanitize(self, resp, command=None):\n '''\n cleaned = []\n for line in resp.splitlines():\n- if (command and line.strip() == command.strip()) or self._matched_prompt.strip() in line:\n+ if command and line.strip() == command... | 0f16815448e4458c97df9b9af8f18bad8d194c58 | diff --git a/lib/ansible/plugins/connection/network_cli.py b/lib/ansible/plugins/connection/network_cli.py
index 93e6f749394e6e..94db7a9d25c998 100644
--- a/lib/ansible/plugins/connection/network_cli.py
+++ b/lib/ansible/plugins/connection/network_cli.py
@@ -539,9 +539,14 @@ def _sanitize(self, resp, command=None):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-52985@b3c8374 | ansible/ansible | Python | 52,985 | postgresql_db - fix 40424 issue | ##### SUMMARY
fix https://github.com/ansible/ansible/issues/40424
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### ADDITIONAL INFORMATION
It's related to pg_dump bug that I found - it return rc 0 if there are errors related with pg_hba.conf file.
```
-bash-4.2$ /usr/... | 2019-02-26T11:56:35Z | Module postgresql_db (state: dump) exits with 0 return code even if dump error occured
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add... | Files identified in the description:
* [lib/ansible/modules/database/postgresql/postgresql_db.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/database/postgresql/postgresql_db.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` ... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 84cc5202dbfd95bacbc1a061e150cd585a7891aa | {
"head_commit": "b3c83745b409435674e2807e2f490fa9f127c8b6",
"head_commit_message": "40424_postgresql_db_fix: fix fedora29 rhel8 errors",
"patch_to_review": "diff --git a/changelogs/fragments/40424_postgresql_db_not_failed_when_dump_err.yml b/changelogs/fragments/40424_postgresql_db_not_failed_when_dump_err.yml\n... | [
{
"diff_hunk": "@@ -495,6 +495,10 @@ def main():\n rc, stdout, stderr, cmd = method(module, target, target_opts, db, **kw)\n if rc != 0:\n module.fail_json(msg=stderr, stdout=stdout, rc=rc, cmd=cmd)\n+\n+ elif stderr and ('FATAL' in str(stderr) ... | d6dabbbc5e7f846ff607a108b5fc5d0e13702390 | diff --git a/changelogs/fragments/40424_postgresql_db_not_failed_when_dump_err.yml b/changelogs/fragments/40424_postgresql_db_not_failed_when_dump_err.yml
new file mode 100644
index 00000000000000..9be407bf4ea2ad
--- /dev/null
+++ b/changelogs/fragments/40424_postgresql_db_not_failed_when_dump_err.yml
@@ -0,0 +1,2 @@
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-52307@8512653 | ansible/ansible | Python | 52,307 | add boto3_tag_list_to_ansible_dict to ec2_vpc_peering_facts.py, and parameter checking to ec2_vpc_peer.py | ##### SUMMARY
1) Alter ec2_vpc_peering_facts.py to use boto3_tag_list_to_ansible_dict so tag names don't get altered unexpectedly from the camel_dict_to_snake_dict function that gets used.
I just took code from modules/cloud/amazon/ec2_instance_facts.py and put it in ec2_vpc_peering_facts.py.
Fixes #52305
2)... | 2019-02-15T05:45:32Z | Alter ec2_vpc_peering_facts.py to use boto3_tag_list_to_ansible_dict
##### SUMMARY
Alter ec2_vpc_peering_facts.py to use boto3_tag_list_to_ansible_dict so tag names don't get altered unexpectedly from the camel_dict_to_snake_dict function that gets used.
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
mod... | Files identified in the description:
* [lib/ansible/modules/cloud/amazon/ec2_vpc_peering_facts.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/ec2_vpc_peering_facts.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component... | [
{
"body": "##### SUMMARY\r\nAlter ec2_vpc_peering_facts.py to use boto3_tag_list_to_ansible_dict so tag names don't get altered unexpectedly from the camel_dict_to_snake_dict function that gets used.\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\r\nmodules/cloud/amazon/ec2_vpc_peering_fa... | de118734e959b7d2c62890e2c6a0b3bca0add320 | {
"head_commit": "85126534a0750dba9c8deca33256702aa2bcc333",
"head_commit_message": "Add parameter checking to ec2_vpc_peer and give helpful error message",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/ec2_vpc_peer.py b/lib/ansible/modules/cloud/amazon/ec2_vpc_peer.py\nindex 58fabe6c3a0f81..c... | [
{
"diff_hunk": "@@ -416,11 +419,20 @@ def main():\n module.fail_json(msg=\"Can't authorize connection - \" + str(e))\n \n if state == 'present':\n+ if not vpc_id and not peer_vpc_id:",
"line": null,
"original_line": 422,
"original_start_line": null,
"path": "lib/ansible/module... | e0ef4396a7b7eda71978084342ba6c38bf1f3a30 | diff --git a/changelogs/fragments/ec2_vpc_peer_parameter_checking.yaml b/changelogs/fragments/ec2_vpc_peer_parameter_checking.yaml
new file mode 100644
index 00000000000000..83ae91795beffe
--- /dev/null
+++ b/changelogs/fragments/ec2_vpc_peer_parameter_checking.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+ - Added parameter c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-51364@64f5b49 | ansible/ansible | Python | 51,364 | Don't fail if exos can't configure cli columns |
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #51363
Some exos versions don't have ```configure cli columns``` command, don't fail in this case
##### ISSUE TYPE
<!--- Pick one be... | 2019-01-26T14:11:41Z | Network_cli error "unable to set terminal parameters" for EXOS devices
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMM... | Files identified in the description:
* [lib/ansible/plugins/connection/network_cli.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/network_cli.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click h... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nConnection module ```network_cli``` a... | d2eb7a6cc17d08bfd9083b2be04cc41fae36e413 | {
"head_commit": "64f5b496787cb498fae94d595a40ee24bd33cc6f",
"head_commit_message": "Don't fail if exos can't configure cli columns\n\nSigned-off-by: Misha Komarovskiy <zombah@gmail.com>",
"patch_to_review": "diff --git a/lib/ansible/plugins/terminal/exos.py b/lib/ansible/plugins/terminal/exos.py\nindex 6c17e467b... | [
{
"diff_hunk": "@@ -49,7 +52,11 @@ class TerminalModule(TerminalBase):\n \n def on_open_shell(self):\n try:\n- for cmd in (b'disable clipaging', b'configure cli columns 256'):\n- self._exec_cli_command(cmd)\n+ self._exec_cli_command(b'disable clipaging')\n ... | 69036f2234149991de9038e6dcd4228ebf4bac94 | diff --git a/lib/ansible/plugins/terminal/exos.py b/lib/ansible/plugins/terminal/exos.py
index 6c17e467bfa7cb..33de9fc5ee3f0b 100644
--- a/lib/ansible/plugins/terminal/exos.py
+++ b/lib/ansible/plugins/terminal/exos.py
@@ -49,7 +49,11 @@ class TerminalModule(TerminalBase):
def on_open_shell(self):
try:
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-51415@fb988f5 | ansible/ansible | Python | 51,415 | meraki_admin - Add documentation for tags and network access | ##### SUMMARY
Documentation now lists examples for the tags and network dictionary structure.
Fixes #42686
##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
meraki_admin | 2019-01-29T05:05:53Z | meraki_admin - Add examples for networks and tags
##### SUMMARY
The `meraki_admin` module accepts `tags` and `networks` parameters but they aren't well documented. It should
* State they need to be passed as dicts
* Provide examples
##### ISSUE TYPE
- Documentation Report
##### COMPONENT NAME
meraki_admin... | Files identified in the description:
* [lib/ansible/modules/network/meraki/meraki_admin.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/meraki/meraki_admin.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.... | [
{
"body": "##### SUMMARY\r\nThe `meraki_admin` module accepts `tags` and `networks` parameters but they aren't well documented. It should\r\n\r\n* State they need to be passed as dicts\r\n* Provide examples\r\n\r\n##### ISSUE TYPE\r\n - Documentation Report\r\n\r\n##### COMPONENT NAME\r\nmeraki_admin\r\n\r\n###... | 15303b05efea234eb348871244b8094c9c63d939 | {
"head_commit": "fb988f547604f88f45ca271ccc9189e7ece89fe1",
"head_commit_message": "Remove whitespace",
"patch_to_review": "diff --git a/lib/ansible/modules/network/meraki/meraki_admin.py b/lib/ansible/modules/network/meraki/meraki_admin.py\nindex 832bbcd95e63dc..e8bef103e9a3e9 100644\n--- a/lib/ansible/modules/... | [
{
"diff_hunk": "@@ -117,6 +119,28 @@\n org_name: YourOrg\n state: absent\n email: jane@doe.com\n+\n+- name: Create a new administrator with full access to a tag\n+ meraki_admin:\n+ auth_key: abc12345\n+ org_name: YourOrg\n+ state: present\n+ name: Jane Doe\n+ orgAccess: read-only\n+ ... | 6a52024ce04eb05f6250815cbe634cb062a0bba8 | diff --git a/lib/ansible/modules/network/meraki/meraki_admin.py b/lib/ansible/modules/network/meraki/meraki_admin.py
index 832bbcd95e63dc..72379d7487f079 100644
--- a/lib/ansible/modules/network/meraki/meraki_admin.py
+++ b/lib/ansible/modules/network/meraki/meraki_admin.py
@@ -39,10 +39,29 @@
- Tags the admin... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-52032@8bfa1a5 | ansible/ansible | Python | 52,032 | adding quiet option to assert (ansible#27124) | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Adds quiet boolean option to assert.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
HINT: Fixes #27124
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Feature Pull Request
##... | 2019-02-11T15:59:05Z | Assert module should not always be verbose
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
assert module
##### ANSIBLE VERSION
```
ansible 2.3.1.0
config file = <redacted>/ansible.cfg
configured module search path = Default w/o overrides
python version = 2.7.12+ (default, Sep 17 2016, 12:08:02) [... | Hrm, this was added explicitly in #17654, but removing it still seems to display the failure message fine on both default and minimal stdout plugins. Not sure why we'd always want to display the success output- @tima, can you shed any light?
If what bothers you is 'changed' and other fields aside from message, we can... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nassert module\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.3.1.0\r\n config file = <redacted>/ansible.cfg\r\n configured module search path = Default w/o overrides\r\n python version = 2.7.12+ (default, Sep 17 2016, 12:08:02) [GC... | 63c22f6eb0630858b02b1c4eb7982bdd42b7d493 | {
"head_commit": "8bfa1a5434d952c2ecb86d634ad4dc8fd07f3fb7",
"head_commit_message": "fixing CI complaints",
"patch_to_review": "diff --git a/changelogs/fragments/52032-add_quiet_option_to_assert.yml b/changelogs/fragments/52032-add_quiet_option_to_assert.yml\nnew file mode 100644\nindex 00000000000000..e640aea5e6... | [
{
"diff_hunk": "@@ -22,8 +22,8 @@ run_test() {\n > >(set +x; tee \"${OUTFILE}.${testname}.stdout\"); } \\\n 2> >(set +x; tee \"${OUTFILE}.${testname}.stderr\" >&2) 0</dev/null\n # clean up Python 2 vs 3 differences\n- sed -i 's/[[:blank:]]*$//' \"${OUTFILE}.${testname}.stdout\"\n- sed -i 's/[... | 1fb6d92b7aa6355f18ef2f7fbfbb5f03b2ab0788 | diff --git a/changelogs/fragments/52032-add_quiet_option_to_assert.yml b/changelogs/fragments/52032-add_quiet_option_to_assert.yml
new file mode 100644
index 00000000000000..e640aea5e69d8f
--- /dev/null
+++ b/changelogs/fragments/52032-add_quiet_option_to_assert.yml
@@ -0,0 +1,3 @@
+minor_changes:
+ - assert - added `... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-51342@373257e | ansible/ansible | Python | 51,342 | toggle for stripping empty shell/command output | fixes #45367
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Feature Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
shell/command | 2019-01-25T20:08:27Z | Empty lines are stripped from the command module's output.
##### SUMMARY
The command module strips trailing newlines from the output.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
command
##### ANSIBLE VERSION
```paste below
ansible 2.6.3
config file = /etc/ansible/ansible.cfg
configured module... | Files identified in the description:
* [lib/ansible/modules/commands/command.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/commands/command.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot ... | [
{
"body": "##### SUMMARY\r\nThe command module strips trailing newlines from the output.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\ncommand\r\n\r\n##### ANSIBLE VERSION\r\n```paste below\r\nansible 2.6.3\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search path =... | 315434f676a76aaf5638cb8c9d265dc75a5ef401 | {
"head_commit": "373257e4c25e5e0a33f20a9e29d6288307cb510b",
"head_commit_message": "toggle for stripping empty shell/command output\n\n fixes #45367",
"patch_to_review": "diff --git a/changelogs/fragments/no_strippers.yml b/changelogs/fragments/no_strippers.yml\nnew file mode 100644\nindex 00000000000000..5160c... | [
{
"diff_hunk": "@@ -69,6 +69,12 @@\n description:\n - If set to C(yes), append a newline to stdin data.\n version_added: \"2.8\"\n+ strip_empty_ends:\n+ description:\n+ - Strim empty lines from the end of stdout/stderr in result.",
"line": null,
"original_line": 74,
"original_... | 0185288ec056a46eb1b397a8e08a1c300f929508 | diff --git a/changelogs/fragments/no_strippers.yml b/changelogs/fragments/no_strippers.yml
new file mode 100644
index 00000000000000..5160c535be3e1b
--- /dev/null
+++ b/changelogs/fragments/no_strippers.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - add option to shell/command to control stripping of empty lines at end of ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-51311@ac194d0 | ansible/ansible | Python | 51,311 | fix pacman package state detection | ##### SUMMARY
Fixes #51265
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
pacman
##### ADDITIONAL INFORMATION
This is a fix to correctly detect a package's installation status as being absent when it is not installed but another package provides it. | 2019-01-25T01:03:27Z | pacman module `state: absent` verification failure when package name is provided by another
On ansible 2.7.6 I've done:
```
- name: remove test
pacman:
name: linux-gpib
state: absent
```
the linux-gpib package is not installed on the system, however linux-gpib-dkms is installed which provides linux-gpi... | @greyltc: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.
Here are the items we could not find in your description:
- issue type
- ansible version
- component name
Please set the description of this issue with this ... | [
{
"body": "On ansible 2.7.6 I've done:\r\n```\r\n- name: remove test\r\n pacman:\r\n name: linux-gpib\r\n state: absent\r\n```\r\nthe linux-gpib package is not installed on the system, however linux-gpib-dkms is installed which provides linux-gpib\r\n```\r\nfatal: [127.0.0.1]: FAILED! => {\"changed\": fa... | 4732728e40beaff2338d0bdb9c01e9662d59f063 | {
"head_commit": "ac194d0ed517de475be76d3928698f1279a25061",
"head_commit_message": "fix pep8 issues",
"patch_to_review": "diff --git a/lib/ansible/modules/packaging/os/pacman.py b/lib/ansible/modules/packaging/os/pacman.py\nindex 7dd6db74d6e856..7526b98cc9e726 100644\n--- a/lib/ansible/modules/packaging/os/pacma... | [
{
"diff_hunk": "@@ -176,6 +176,15 @@ def get_version(pacman_output):\n return None\n \n \n+def get_name(pacman_output):\n+ \"\"\"Take pacman -Qi or pacman -Si output and get the package name\"\"\"\n+ lines = pacman_output.split('\\n')\n+ for line in lines:\n+ if 'Name' in line:",
"line":... | 79de35f60f6dc33441fe78012d27cd78c0a0098b | diff --git a/lib/ansible/modules/packaging/os/pacman.py b/lib/ansible/modules/packaging/os/pacman.py
index 7dd6db74d6e856..cdd652013fc7d3 100644
--- a/lib/ansible/modules/packaging/os/pacman.py
+++ b/lib/ansible/modules/packaging/os/pacman.py
@@ -171,11 +171,20 @@ def get_version(pacman_output):
"""Take pacman -Qi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-51194@789f691 | ansible/ansible | Python | 51,194 | Reboot - add parameter for paths to search for shutdown command | ##### SUMMARY
When [`molly-guard`](https://en.wiktionary.org/wiki/molly-guard) is installed, the normal `shutdown` command is moved to `/lib/molly-guard/`. Add a parameter to allow the default search paths to be overridden.
Fixes #51190
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Feature... | 2019-01-22T22:19:26Z | [reboot] Ansible hangs on molly-guard prompt if molly-guard is installed on target host.
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically... | Files identified in the description:
* [lib/ansible/modules/system/reboot.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/reboot.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 6a06e9f485ddc1e03800a11fe7c0030dee5c2878 | {
"head_commit": "789f6910a9f072f9d6532955980d5bf6311beb9d",
"head_commit_message": "Address feedback",
"patch_to_review": "diff --git a/changelogs/fragments/reboot-add-search-paths-parameter.yaml b/changelogs/fragments/reboot-add-search-paths-parameter.yaml\nnew file mode 100644\nindex 00000000000000..aab697c6dc... | [
{
"diff_hunk": "@@ -142,10 +143,15 @@ def get_shutdown_command(self, task_vars, distribution):\n if not isinstance(search_paths, list):\n raise AnsibleError(\"'search_paths' must be a string or list, got {0}: {1}\".format(type(search_paths), search_paths))\n \n- # If we did get a list... | 3771b722b8c6ea52c486405d59ebf1378ad16185 | diff --git a/changelogs/fragments/reboot-add-search-paths-parameter.yaml b/changelogs/fragments/reboot-add-search-paths-parameter.yaml
new file mode 100644
index 00000000000000..aab697c6dcde8b
--- /dev/null
+++ b/changelogs/fragments/reboot-add-search-paths-parameter.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+ - 'reboot - ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-51024@e48cbeb | ansible/ansible | Python | 51,024 | Ovirt vm state running wait false | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Now when you put vm wait=false and state running it will change the wait until the vm is runnnig and then resets the wait again to original val.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fix... | 2019-01-17T15:01:11Z | ovirt_vm fails to create a VM when running=true and wait=false on RHHI-V.
##### SUMMARY
ovirt_vm fails to create a VM when running=true and wait=false on RHHI-V.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
ovirt_vm
##### ANSIBLE VERSION
```
[dieter@localhost test]$ ansible --version
ansible 2.7.2
... | Files identified in the description:
* [lib/ansible/modules/cloud/ovirt/ovirt_vm.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/ovirt/ovirt_vm.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here ... | [
{
"body": "##### SUMMARY\r\novirt_vm fails to create a VM when running=true and wait=false on RHHI-V.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\novirt_vm\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n[dieter@localhost test]$ ansible --version\r\nansible 2.7.2\r\n config file = /home/dieter... | c6d404cbe9f77ea0d247ed5f86449410c6c6e6a2 | {
"head_commit": "e48cbeb5616c8ddf9d740c1e10b52d3e16d3b7a2",
"head_commit_message": "add seting vm wait before creating module",
"patch_to_review": "diff --git a/lib/ansible/module_utils/ovirt.py b/lib/ansible/module_utils/ovirt.py\nindex 19653bbbee779e..cc74e92ce61742 100644\n--- a/lib/ansible/module_utils/ovirt... | [
{
"diff_hunk": "@@ -2075,11 +2075,17 @@ def main():\n auth = module.params.pop('auth')\n connection = create_connection(auth)\n vms_service = connection.system_service().vms_service()\n+\n+ if not module.params['wait'] and state=='running':",
"line": null,
"original_line":... | 77d388e0e5ac5cad4554ee24ea3e500cb4643880 | diff --git a/lib/ansible/module_utils/ovirt.py b/lib/ansible/module_utils/ovirt.py
index 19653bbbee779e..762e19fe33551a 100644
--- a/lib/ansible/module_utils/ovirt.py
+++ b/lib/ansible/module_utils/ovirt.py
@@ -527,6 +527,7 @@ def create(
fail_condition=lambda e: False,
search_params=None,
up... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-51104@f0d6d6d | ansible/ansible | Python | 51,104 | Added support for user-specified log file in win_package | ##### SUMMARY
Users often want the ability to refer back to installer logs long after a deployment is done. This feature provides an optional parameter to win_package to facilitate specifying a log path. Default/existing behaviour for log path is unchanged.
Fixes #38353
##### ISSUE TYPE
- Feature Pull Request
... | 2019-01-19T20:37:10Z | Feature: log_path variable for win_package and keep log output on success
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
Always add information AFTER of these html comments.
-->
##### ISSUE TYPE
- Feature Idea
... | Just for context: Some admins at work like to keep installation logs around as artifacts just-in-case. I understand this can be done by other means (e.g. `win_shell`, `win_command`, etc...) but it seems to be this could be added to `win_package` and benefit others. It's sad to have to replicate `win_package` functional... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\nAlways add information AFTER of these html comments.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\n<!---\r\nIns... | 6c96f29699f2de40db4a7ff39bd09b6cc9066bf9 | {
"head_commit": "f0d6d6dc34b641d329c92b237e684cb9b61c674b",
"head_commit_message": "Added support for user-specified log file in win_package - feature (#38353)",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_package.ps1 b/lib/ansible/modules/windows/win_package.ps1\nindex bc8f54c512a4b4..2256c... | [
{
"diff_hunk": "@@ -130,6 +130,12 @@\n type: bool\n default: yes\n version_added: '2.4'\n+ log_path:\n+ description:\n+ - Full path of log file.\n+ - This file will be kept regardless of overall success or failure",
"line": null,
"original_line": 136,
"original_start_line": nul... | 9ff53eca97082059a3e42fa69b00071ccd8ee759 | diff --git a/lib/ansible/modules/windows/win_package.ps1 b/lib/ansible/modules/windows/win_package.ps1
index bc8f54c512a4b4..0f5aea7d67d4f2 100644
--- a/lib/ansible/modules/windows/win_package.ps1
+++ b/lib/ansible/modules/windows/win_package.ps1
@@ -25,6 +25,7 @@ $validate_certs = Get-AnsibleParam -obj $params -name "... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-51000@a6df594 | ansible/ansible | Python | 51,000 | reboot - Fix connection timeout reset | ##### SUMMARY
The current logic to reset the connection timeout is not correct as it won't run if the original connection timeout (connection plugin) was never set. This PR changes the logic to compare the previous value with the current value instead to detect if there were any changes.
Fixes https://github.com/an... | 2019-01-16T22:25:21Z | win_update: FATAL ERROR DURING FILE TRANSFER if Windows boot takes a long time
##### SUMMARY
win_update: FATAL ERROR DURING FILE TRANSFER if Windows boot takes a long time after update. This message appears when Windows rebooted and apply latest changes, WinRM accessible, but not working.
##### ISSUE TYPE
- Bug Re... | Hi @specator, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description ... | [
{
"body": "##### SUMMARY\r\nwin_update: FATAL ERROR DURING FILE TRANSFER if Windows boot takes a long time after update. This message appears when Windows rebooted and apply latest changes, WinRM accessible, but not working.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nwin_updates\r\n\... | 0f846f39ca28e4e0155f349debecc5af5d695907 | {
"head_commit": "a6df594c601ad1fe1d84a0a31514de4b7b03826f",
"head_commit_message": "reboot - Fix connection timeout reset",
"patch_to_review": "diff --git a/changelogs/fragments/reboot-conn-timeout-reset.yaml b/changelogs/fragments/reboot-conn-timeout-reset.yaml\nnew file mode 100644\nindex 00000000000000..c6427... | [
{
"diff_hunk": "@@ -305,7 +304,13 @@ def validate_reboot(self, distribution, original_connection_timeout=None, action\n distribution=distribution,\n action_kwargs=action_kwargs)\n \n- if connect_timeout and original_connection_timeout:\n+ # Get the connect_t... | 01cf365e96fc73483042afbe9291f77e5ca6ce8a | diff --git a/changelogs/fragments/reboot-conn-timeout-reset.yaml b/changelogs/fragments/reboot-conn-timeout-reset.yaml
new file mode 100644
index 00000000000000..c6427111debfb5
--- /dev/null
+++ b/changelogs/fragments/reboot-conn-timeout-reset.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+- reboot - Fix bug where the connection tim... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-50776@06db718 | ansible/ansible | Python | 50,776 | Catch sshpass authentication errors and don't retry multiple times to prevent account lockout | ##### SUMMARY
When using the `ssh` connection plugin with an invalid password, `sshpass` returns error code 5 for invalid/incorrect password. The `ssh` connection plugin currently only raises `AnsibleConnectionFailure` for error 255, which causes the host to not be marked as unreachable and the attempt loop in `task... | 2019-01-10T17:58:55Z | add configurable password_retries to prevent account lockout
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
If a user mistyp... | `sshpass` returns error code 5 when invalid/incorrect password is entered. Currently we only check for 255 in the ssh connection plugin. We could handle error code 5 differently, and allow customization via a config setting.
Hi @gamuniz, thank you for submitting this issue!
[click here for bot help](https://github.com... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nIf a user mistypes a password for a user/pass ss... | 47467814236bc79bea724044215254eb164c9084 | {
"head_commit": "06db7183c2171f4d4b01f7d76c14f7676850ec82",
"head_commit_message": "Catch SSH authentication errors and don't retry multiple times to prevent account lock out\n\nSigned-off-by: Sam Doran <sdoran@redhat.com>",
"patch_to_review": "diff --git a/lib/ansible/plugins/connection/ssh.py b/lib/ansible/plu... | [
{
"diff_hunk": "@@ -307,6 +307,57 @@ class AnsibleControlPersistBrokenPipeError(AnsibleError):\n pass\n \n \n+class AnsiblePasswordAuthenticationFailure(AnsibleError):\n+ pass\n+\n+\n+def _handle_error(remaining_retries, command, return_tuple, no_log, host, display=display):\n+\n+ # sshpass errors\n+ ... | abba0c68dc4427e29c4e7e776e51e532eda8e02b | diff --git a/changelogs/fragments/ssh_connection_invalid_password.yaml b/changelogs/fragments/ssh_connection_invalid_password.yaml
new file mode 100644
index 00000000000000..c04fa0679bc621
--- /dev/null
+++ b/changelogs/fragments/ssh_connection_invalid_password.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - ssh connection - do n... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-50578@5d4ed3b | ansible/ansible | Python | 50,578 | Add state option to git_config module | State present/absent option works like set/unset option for 'git config'.
##### SUMMARY
Adding a state option to git_config module. State can be 'present' or 'absent'.
Works like 'git config' when 'present' and like 'git config --unset' when 'absent'.
Fixes #28567
##### ISSUE TYPE
- Feature Pull Request
... | 2019-01-05T17:56:22Z | git_config module has no way to remove config settings
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Idea
##### COMPONENT NAME
<!... | cc @djmattyg007
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
I completely agree! Unfortunately I won't have time to create a patch anytime soon, but I'll happily review any pull requests that are put forward.
I've opened pull request #28861 t... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the ... | fc6d85e4cf29464dcd82a9c84bb617699bd5fecd | {
"head_commit": "5d4ed3be663029929fd5af638cb3e8ee4ee85db5",
"head_commit_message": "Add state option to git_config module\n\nState present/absent option works like --set/--unset option for 'git config'.",
"patch_to_review": "diff --git a/lib/ansible/modules/source_control/git_config.py b/lib/ansible/modules/sour... | [
{
"diff_hunk": "@@ -212,13 +230,19 @@ def main():\n k, v = value.split('=', 1)\n config_values[k] = v\n module.exit_json(changed=False, msg='', config_values=config_values)\n- elif not new_value:\n+ elif not new_value and not unset:\n module.exit_json(changed=False,... | 0147160914ace123c66c17f2b8e401c2328fcd17 | diff --git a/lib/ansible/modules/source_control/git_config.py b/lib/ansible/modules/source_control/git_config.py
index 620a885b60a11c..da8fd8697b025a 100644
--- a/lib/ansible/modules/source_control/git_config.py
+++ b/lib/ansible/modules/source_control/git_config.py
@@ -51,6 +51,14 @@
also specify the repo par... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-50590@f00596a | ansible/ansible | Python | 50,590 | VMware: add new module vmware_guest_video | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add a new module named "vmware_guest_video" to manage virtual machines's video card settings.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #49372
##### ISSUE TYPE
<!--- Pick one below and ... | 2019-01-07T04:16:37Z | VMware new module request vmware_guest_video
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
We want to modify the video rela... | Hi @Tomorrow9, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nWe want to modify the video related configuratio... | 3e2e67c677bcb537027a955b0d38da81de09e5cf | {
"head_commit": "f00596a2748aa46311aa6462831b586f357d03fb",
"head_commit_message": "modify doc issue",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/vmware/vmware_guest_video.py b/lib/ansible/modules/cloud/vmware/vmware_guest_video.py\nnew file mode 100644\nindex 00000000000000..714527b050b1a6\n--- ... | [
{
"diff_hunk": "@@ -0,0 +1,325 @@\n+#!/usr/bin/python\n+# -*- coding: utf-8 -*-\n+# Copyright: (c) 2018, Ansible Project\n+# Copyright: (c) 2018, Diane Wang <dianew@vmware.com>\n+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\n+\n+from __future__ import absolute... | f9adfa071e16f58bd8312712b8905e3f8a496298 | diff --git a/lib/ansible/modules/cloud/vmware/vmware_guest_video.py b/lib/ansible/modules/cloud/vmware/vmware_guest_video.py
new file mode 100644
index 00000000000000..5a1a602aff62b1
--- /dev/null
+++ b/lib/ansible/modules/cloud/vmware/vmware_guest_video.py
@@ -0,0 +1,326 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-50499@5091ba4 | ansible/ansible | Python | 50,499 | docker_network IPAM test / general docker test cleanup | ##### SUMMARY
The test had to be deactivated (in #50477) since it caused a lot of spurious failures; see also [here](https://github.com/ansible/ansible/pull/50354#issuecomment-450489875).
Fixes #50527, fixes #50478.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
docker_network
| 2019-01-03T15:45:39Z | Unstable integration test docker_network
##### SUMMARY
The integration test `docker_network` is set to unstable as it sometimes fails.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
docker_network
##### ANSIBLE VERSION
```paste below
devel
```
##### CONFIGURATION
N/A
##### OS / ENVIRONMENT
N/... | Files identified in the description:
* [lib/ansible/modules/cloud/docker/docker_network.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/docker/docker_network.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.... | [
{
"body": "##### SUMMARY\r\nThe integration test `docker_network` is set to unstable as it sometimes fails.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\ndocker_network\r\n\r\n##### ANSIBLE VERSION\r\n```paste below\r\ndevel\r\n```\r\n\r\n##### CONFIGURATION\r\nN/A\r\n\r\n##### OS / ENV... | 9693a552864e2b3cd25f5e999bcfd461913b02ff | {
"head_commit": "5091ba45844454371cf19aaa499e602e4bef2bde",
"head_commit_message": "Basic cleanup of docker daemon.",
"patch_to_review": "diff --git a/test/integration/targets/docker_network/aliases b/test/integration/targets/docker_network/aliases\nindex 8bff534556ab79..80f0500dfffd11 100644\n--- a/test/integra... | [
{
"diff_hunk": "@@ -30,8 +35,52 @@\n ignore_errors: yes\n \n - set_fact:\n+ docker_cli_version: \"{{ (docker_cli_version_stdout.stdout | default('0.0')) or '0.0' }}\"\n docker_api_version: \"{{ docker_api_version_stdout.stdout or '0.0' }}\"\n docker_py_version: \"{{ docker_py_ve... | cd42537b55ba25b8577fb307f9c9b2e10e57982c | diff --git a/test/integration/targets/docker_network/aliases b/test/integration/targets/docker_network/aliases
index 8bff534556ab79..80f0500dfffd11 100644
--- a/test/integration/targets/docker_network/aliases
+++ b/test/integration/targets/docker_network/aliases
@@ -3,4 +3,3 @@ skip/osx
skip/freebsd
destructive
skip... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-50448@e7f21dd | ansible/ansible | Python | 50,448 | Add auth_timeout parameter when supported by paramiko | Paramiko 2.2 introduces the auth_timeout parameter. This will set the
parameter to the same value of the timeout parameter to prevent
"Authentication timeout" errors.
##### SUMMARY
If the paramiko version installed is at least 2.2 include the auth_timeout parameter to the connect method with the same value used f... | 2019-01-02T13:47:08Z | Paramiko ignores timeout setting
##### SUMMARY
`timeout` in ansible.cfg appears to be ignored when using paramiko.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
paramiko_ssh
##### ANSIBLE VERSION
```
ansible 2.5.5
config file = /home/user/workspace/git/ansible/ansible.cfg
configured modu... | Files identified in the description:
* [lib/ansible/plugins/connection/paramiko_ssh.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/paramiko_ssh.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "##### SUMMARY\r\n`timeout` in ansible.cfg appears to be ignored when using paramiko.\r\n\r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n\r\n##### COMPONENT NAME\r\nparamiko_ssh\r\n\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.5.5\r\n config file = /home/user/workspace/git/ansible/ansible.cfg\r\... | b5162c7a473dc8402f81dabe542f856af77b3b88 | {
"head_commit": "e7f21dd1af2429a09c698e0fc5914e1656cd48a3",
"head_commit_message": "Add auth_timeout parameter when supported\n\nParamiko 2.2 introduces the auth_timeout parameter. This will set the\nparameter to the same value of the timeout parameter to prevent\n\"Authentication timeout\" errors.",
"patch_to_r... | [
{
"diff_hunk": "@@ -337,17 +338,32 @@ def _connect_uncached(self):\n if self._play_context.private_key_file:\n key_filename = os.path.expanduser(self._play_context.private_key_file)\n \n- ssh.connect(\n- self._play_context.remote_addr.lower(),\n- ... | 7679a92db74801dd8f404abb2d9cd2c973e9d8cf | diff --git a/changelogs/fragments/50448-paramiko_ssh_add_auth_timeout.yaml b/changelogs/fragments/50448-paramiko_ssh_add_auth_timeout.yaml
new file mode 100644
index 00000000000000..464d8882c697e2
--- /dev/null
+++ b/changelogs/fragments/50448-paramiko_ssh_add_auth_timeout.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - paramiko_... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-49979@da57c19 | ansible/ansible | Python | 49,979 | ec2_vpc_nacl fails when the VPC is configured with IPv6 | ##### SUMMARY
The ec2_vpc_nacl module always fails when an AWS VPC is configured with an IPv6 subnet. When a user executes an ec2_vpc_nacl task, an error message occurs and the following error message is displayed:
"msg": "An error occurred (InvalidParameterValue) when calling the DeleteNetworkAclEntry operation: ... | 2018-12-16T01:57:12Z | ec2_vpc_nacl failes on update
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these html comments.
Otherw... | Files identified in the description:
* [lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[c... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | d4ee599fe9cd88315d129e036fb034111bfc2272 | {
"head_commit": "da57c19f34b7dfe3e81becac6db7d5d198834118",
"head_commit_message": "Simplify logic to skip default deny-all rules",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py b/lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py\nindex d0473d9f4c0c9b..e71ec934ca8462 100644\n--... | [
{
"diff_hunk": "@@ -236,10 +225,10 @@ def nacls_changed(nacl, client, module):\n nacl_id = nacl['NetworkAcls'][0]['NetworkAclId']\n nacl = describe_network_acl(client, module)\n entries = nacl['NetworkAcls'][0]['Entries']\n- tmp_egress = [entry for entry in entries if entry['Egress'] is True and ... | 15195af53042119101e3f137c2d4a472afaf2e88 | diff --git a/lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py b/lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py
index d0473d9f4c0c9b..e707c7735371c6 100644
--- a/lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py
+++ b/lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py
@@ -154,17 +154,6 @@
from ansible.module_utils.ec2 i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-49873@10ef1a3 | ansible/ansible | Python | 49,873 | Issue/38837 | Signed-off-by: Anas Badaha <anasb@mellanox.com>
##### SUMMARY
Fixes #38837
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/modules/network/onyx/onyx_bgp.py
test/units/modules/network/onyx/test_onyx_bgp.py
##### ADDITIONAL INFORMATION
... | 2018-12-13T10:01:30Z | onyx_bgp - Support purge option to not delete existing bgp neighbors
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
Always add information AFTER of these html comments.
-->
##### ISSUE TYPE
<!--- Pick one below an... | Files identified in the description:
* [lib/ansible/modules/network/onyx/onyx_bgp.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/onyx/onyx_bgp.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click her... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\nAlways add information AFTER of these html comments.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Feature ... | 69988cfca01acd17e6a0a532933628a30c162c40 | {
"head_commit": "10ef1a3e7d56c74cb40fc0b887499f4bbab01b40",
"head_commit_message": "Fix Failures in Shippable\n\nSigned-off-by: Anas Badaha <anasb@mellanox.com>",
"patch_to_review": "diff --git a/lib/ansible/modules/network/onyx/onyx_bgp.py b/lib/ansible/modules/network/onyx/onyx_bgp.py\nindex eb3a19326acebc..34... | [
{
"diff_hunk": "@@ -49,9 +49,9 @@\n - BGP state.\n default: present\n choices: ['present', 'absent']\n- neighbors_purge:\n+ purge:\n description:\n- - will Purge all neighbors when it is True.\n+ - will remove all neighbors when it is True.\n type: bool\n default: false\n \... | 1d835070237adc12e743caa0fe0b855b8d506879 | diff --git a/lib/ansible/modules/network/onyx/onyx_bgp.py b/lib/ansible/modules/network/onyx/onyx_bgp.py
index eb3a19326acebc..00c0b3351a3eb1 100644
--- a/lib/ansible/modules/network/onyx/onyx_bgp.py
+++ b/lib/ansible/modules/network/onyx/onyx_bgp.py
@@ -49,6 +49,12 @@
- BGP state.
default: present
cho... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-49833@09ba1b4 | ansible/ansible | Python | 49,833 | Allow tags to be templated from a variable | ##### SUMMARY
Allow tags to be templated from a variable. Fixes #49825
The problem that we run into here, is that when we call `_extend_value` from `Task._get_parent_attribute`, we turn `'{{ foo }}'` into `['{{ foo }}']`.
Later when `{{foo}}` is templated, that becomes `[['foo', 'bar']]`
Basically, I get arou... | 2018-12-12T17:46:02Z | Using a variable list for tags parameter results in an unhashable type: 'list' exception
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner ---> | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | b422c59ada632b5905b9fc06b8fb37ed299f3979 | {
"head_commit": "09ba1b43b1da4024a0cdb4738755634dbd6ed7ea",
"head_commit_message": "Allow tags to be templated from a variable. Fixes #49825",
"patch_to_review": "diff --git a/changelogs/fragments/tags-var.yaml b/changelogs/fragments/tags-var.yaml\nnew file mode 100644\nindex 00000000000000..40c581cd723748\n--- ... | [
{
"diff_hunk": "@@ -32,21 +30,6 @@ class Taggable:\n untagged = frozenset(['untagged'])\n _tags = FieldAttribute(isa='list', default=list, listof=(string_types, int), extend=True)\n \n- def __init__(self):\n- super(Taggable, self).__init__()\n-\n- def _load_tags(self, attr, ds):\n- i... | fd1819163949f760bd86e6cf2ce8449b394bd192 | diff --git a/changelogs/fragments/tags-var.yaml b/changelogs/fragments/tags-var.yaml
new file mode 100644
index 00000000000000..40c581cd723748
--- /dev/null
+++ b/changelogs/fragments/tags-var.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+- tags - allow tags to be specified by a variable (https://github.com/ansible/ansible/issues/4... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-49923@387430c | ansible/ansible | Python | 49,923 | Change net_* default behaviour on missing module | Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
##### SUMMARY
- Fixes #35869
- This changes the behaviour of net_* modules.
- Instead of depending on `fail_on_missing_module`, this fix will cause the task to fail by default if the respective implementation module is not present.
##### ISSUE TYPE
... | 2018-12-14T05:33:43Z | net_ping on vyos does not work
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
net_ping
##### ANSIBLE VERSION
```
ansible 2.5.0
config file = /home/vagrant/.ansible.cfg
configured module search path = [u'/home/vagrant/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible pytho... | Files identified in the description:
* [lib/ansible/modules/network/system/net_ping.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/system/net_ping.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nnet_ping\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.5.0\r\n config file = /home/vagrant/.ansible.cfg\r\n configured module search path = [u'/home/vagrant/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n ans... | fb8b59fcc65a75508ba802dc4798596982e7e6e5 | {
"head_commit": "387430cd7d97689e3aec51dba6e11701f5532eb1",
"head_commit_message": "Fix net_base default behaviour\n\nSigned-off-by: NilashishC <nilashishchakraborty8@gmail.com>",
"patch_to_review": "diff --git a/lib/ansible/plugins/action/net_base.py b/lib/ansible/plugins/action/net_base.py\nindex be8f8d438e3b9... | [
{
"diff_hunk": "@@ -107,18 +107,12 @@ def run(self, tmp=None, task_vars=None):\n display.vvvv('wrong context, sending exit to device', self._play_context.remote_addr)\n conn.send_command('exit')\n \n- if 'fail_on_missing_module' not in self._task.args:\n- self._... | 84060213bd913335c797cb4268704dd26ee1d657 | diff --git a/lib/ansible/plugins/action/net_base.py b/lib/ansible/plugins/action/net_base.py
index be8f8d438e3b97..8f174eb611117b 100644
--- a/lib/ansible/plugins/action/net_base.py
+++ b/lib/ansible/plugins/action/net_base.py
@@ -108,7 +108,7 @@ def run(self, tmp=None, task_vars=None):
conn.send_comma... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-49921@5a25b89 | ansible/ansible | Python | 49,921 | Make the timeout decorator raise an exception out of the function's scope | ##### SUMMARY
Make the timeout decorator properly raise an exception outside of the function's scope
signal handlers which raise exceptions will never work well because the
exception can be raised anywhere in the called code. This leads to
exception race conditions where the exceptions could end up being
ha... | 2018-12-14T04:49:57Z | Timer expired after 10 seconds when gather facts
##### SUMMARY
Timer expired after 10 seconds when gather facts on some hosts.
```
fatal: [kso-nlape1vp-rano-009]: FAILED! => {"changed": false, "cmd": "/usr/bin/udevadm info --query property --name /dev/sda1", "msg": "Timer expired after 10 seconds", "rc": 257}
```... | For the record, I don't have any issues with Ansible version 2.5.7.
I can confirm, I see this exact same issue sporadically. This only occurs on certain hosts, not the entire set.
Interesting traceback... Looks like the SIGALRM handler from facts.timeout is raising the TimeoutError when the `try/except TimeoutError` is... | [
{
"body": "##### SUMMARY\r\nTimer expired after 10 seconds when gather facts on some hosts.\r\n\r\n```\r\nfatal: [kso-nlape1vp-rano-009]: FAILED! => {\"changed\": false, \"cmd\": \"/usr/bin/udevadm info --query property --name /dev/sda1\", \"msg\": \"Timer expired after 10 seconds\", \"rc\": 257}\r\n```\r\n\r\n... | d29f647f094c177b30067eed08e370a8cd25332c | {
"head_commit": "5a25b89c2d412e5f1c2a1ec3b7bfc2b932341ce1",
"head_commit_message": "Make the timeout decorator properly raise an exception outside of the function's scope\n\nsignal handlers which raise exceptions will never work well because the\nexception can be raised anywhere in the called code. This leads to\... | [
{
"diff_hunk": "@@ -25,29 +26,30 @@\n DEFAULT_GATHER_TIMEOUT = 10\n \n \n-class TimeoutError(Exception):\n- pass\n+try:\n+ # On Python 3, reuse the TimeoutError\n+ class TimeoutError(TimeoutError):\n+ pass\n+except NameError:\n+ # On Python 2, there unfortunately isn't a better base class to ... | cb1c62cf572ac37cc6905b4f2a7bffd6e9530bb9 | diff --git a/lib/ansible/module_utils/basic.py b/lib/ansible/module_utils/basic.py
index 01c90d54f632b8..c5f9a819bef7b3 100644
--- a/lib/ansible/module_utils/basic.py
+++ b/lib/ansible/module_utils/basic.py
@@ -2605,7 +2605,7 @@ def _restore_signal_handlers(self):
def run_command(self, args, check_rc=False, clos... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-48999@ad84545 | ansible/ansible | Python | 48,999 | Meraki scenario guide - describe how to merge new data with old data | ##### SUMMARY
Ansible and Ansible's Meraki modules don't allow for merging and splitting data. This PR describes how to do this.
Fixes #48944
##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
meraki scenario guide | 2018-11-21T19:48:57Z | Meraki scenario guide should show how to merge data
##### SUMMARY
Meraki Ansible modules don't do a lot of backend work around merging existing data with new data. This puts the burden on the playbook to gather existing data and reconcile the data structure proposed by the playbook against the existing production conf... | Hi @kbreit, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
* [lib/ansible/module_utils/network/meraki/meraki.py](https://github.com/ansible/ansible/blob/devel/l... | [
{
"body": "##### SUMMARY\r\nMeraki Ansible modules don't do a lot of backend work around merging existing data with new data. This puts the burden on the playbook to gather existing data and reconcile the data structure proposed by the playbook against the existing production configuration. The scenario guide s... | 75407d3e439653ef4b103c383d653df32b081821 | {
"head_commit": "ad84545d116c496cc5abf999e956acd46f57abeb",
"head_commit_message": "Described how to merge new data with old data",
"patch_to_review": "diff --git a/docs/docsite/rst/scenario_guides/guide_meraki.rst b/docs/docsite/rst/scenario_guides/guide_meraki.rst\nindex e37c68c3b22235..50cc45c3453858 100644\n... | [
{
"diff_hunk": "@@ -108,22 +108,83 @@ Meraki and its related Ansible modules return most information in the form of a\n \n .. code-block:: json\n \n-\t[\n-\t\t{\n-\t\t\t\"orgAccess\": \"full\", \n-\t\t\t\"name\": \"John Doe\",\n-\t\t\t\"tags\": [],\n-\t\t\t\"networks\": [],\n-\t\t\t\"email\": \"john@doe.com\",\... | 3329ce23ef312549b24e3cb5834099d3570405ed | diff --git a/docs/docsite/rst/scenario_guides/guide_meraki.rst b/docs/docsite/rst/scenario_guides/guide_meraki.rst
index e37c68c3b22235..94c5b161b35e8e 100644
--- a/docs/docsite/rst/scenario_guides/guide_meraki.rst
+++ b/docs/docsite/rst/scenario_guides/guide_meraki.rst
@@ -37,58 +37,58 @@ Meraki modules provide a user... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-49319@45e10cc | ansible/ansible | Python | 49,319 | Support for pids_limit parameter in docker_container module | ##### SUMMARY
This add pids_limit parameter support in docker_container module
Fixes #43337
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
docker_container
##### ADDITIONAL INFORMATION
Set pids limit as,
```paste below
- name: Run container with limiting pids
docker_container:
... | 2018-11-29T17:58:58Z | support for pids_limit parameter in docker_container module
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE... | Files identified in the description:
* [lib/ansible/modules/cloud/docker/docker_container.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/docker/docker_container.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot comm... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | fc71cde7d3f5393e402bee7e8e4f6fc7d22afdad | {
"head_commit": "45e10cc0a0efe870fdc86aaeee0514ecb58878b8",
"head_commit_message": "Add changelog for pids_limit parameter\n\nSigned-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>",
"patch_to_review": "diff --git a/changelogs/fragments/49319-docker_container-pids_limit.yaml b/changelogs/fragments/49319-docker_c... | [
{
"diff_hunk": "@@ -1690,6 +1698,7 @@ def __init__(self, container, parameters):\n self.parameters_map['device_write_bps'] = 'device_write_bps'\n self.parameters_map['device_read_iops'] = 'device_read_iops'\n self.parameters_map['device_write_iops'] = 'device_write_iops'\n+ self.p... | d21bcc15d39753d34812ef178f2cf85c62bf73e3 | diff --git a/changelogs/fragments/49319-docker_container-pids_limit.yaml b/changelogs/fragments/49319-docker_container-pids_limit.yaml
new file mode 100644
index 00000000000000..545dac12e4c3f1
--- /dev/null
+++ b/changelogs/fragments/49319-docker_container-pids_limit.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+- "docker_cont... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-49298@ef7ba60 | ansible/ansible | Python | 49,298 | ovirt add sync_networks | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
add ovirt synch networks
when you have unsynchronized network and you need to sync them
you can got this issue from changing VLAN or MTU...
https://www.ovirt.org/documentation/how-to/networking/setupnetworks-syncnetworks/... | 2018-11-29T13:13:28Z | Synchronize hosts before modifying networks
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these html com... | Files identified in the description:
* [lib/ansible/modules/cloud/ovirt/ovirt_host_networks.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/ovirt/ovirt_host_networks.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot ... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | bbab4c1b496f3b9fa07b7121adebbbe0cc8772b6 | {
"head_commit": "ef7ba6031ece553084507dbe13a4b6189af87224",
"head_commit_message": "ovirt sync networks update docs",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py b/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py\nindex 49681fcba47adf..007e140aaa50b2 100644\n--- a/... | [
{
"diff_hunk": "@@ -362,8 +379,14 @@ def main():\n nics_service = host_service.nics_service()\n nic = search_by_name(nics_service, nic_name)\n \n+ if module.params[\"sync_networks\"] and not module.check_mode:",
"line": null,
"original_line": 382,
"original_start_line": null,
... | 979f1ad63dcad4f179c4d7002a1a9009a7133a4b | diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py b/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py
index 49681fcba47adf..500ed85946420e 100644
--- a/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_host_network.py
@@ -76,6 +76,12 @@
descr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-48971@8b8fb59 | ansible/ansible | Python | 48,971 | meraki_network - Add support for disableRemoteStatusPage | ##### SUMMARY
- New feature in the Meraki API
- Yes, it's a double negative, I may fix at some point
Fixes #48965
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
meraki_network | 2018-11-21T02:38:22Z | meraki_network - Specify disableMyMerakiCom and disableRemoteStatusPage at creation
##### SUMMARY
Meraki's API now supports creating networks while specifying the parameters in the subject line. The API should be able to support these parameters.
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
meraki_netw... | Hi @kbreit, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
* [lib/ansible/modules/network/meraki/meraki_network.py](https://github.com/ansible/ansible/blob/deve... | [
{
"body": "##### SUMMARY\r\nMeraki's API now supports creating networks while specifying the parameters in the subject line. The API should be able to support these parameters.\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\r\nmeraki_network",
"number": 48965,
"title": "meraki_net... | 24a46deef58d9b21ce4e3dcce3b142e5dd70d722 | {
"head_commit": "8b8fb59d1850f08ec61d08a9039ff305ea02921f",
"head_commit_message": "Update deprecation version",
"patch_to_review": "diff --git a/changelogs/fragments/48971-meraki_network-enable-status-pages.yml b/changelogs/fragments/48971-meraki_network-enable-status-pages.yml\nnew file mode 100644\nindex 0000... | [
{
"diff_hunk": "@@ -265,8 +291,20 @@ def main():\n payload['tags'] = construct_tags(meraki.params['tags'])\n if meraki.params['timezone']:\n payload['timeZone'] = meraki.params['timezone']\n- if meraki.params['disable_my_meraki'] is not None:\n+ if meraki.params['en... | 5b6efd9e2d49b6d423ec62116d123d2a47081a3e | diff --git a/changelogs/fragments/48971-meraki_network-enable-status-pages.yml b/changelogs/fragments/48971-meraki_network-enable-status-pages.yml
new file mode 100644
index 00000000000000..c6e54780526c9e
--- /dev/null
+++ b/changelogs/fragments/48971-meraki_network-enable-status-pages.yml
@@ -0,0 +1,2 @@
+minor_change... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-48761@5477972 | ansible/ansible | Python | 48,761 | Fix win_nssm credentials quoting | ##### SUMMARY
Fixes https://github.com/ansible/ansible/issues/48728
The problem is with the escaping of the `$password` variable with single quotes (introduced by PR #26228) which worked in <=2.7.0 when `Invoke-Expression` was being used to invoke nssm. With 2.7.1, nssm is being invoked differently and the escapi... | 2018-11-16T01:54:23Z | Error starting service using win_nssm with user and password parameters and password contains special characters
##### SUMMARY
When running `win_nssm` module with parameters `user` and `password` and the password contains special characters (we have a number of special characters such as `#` `$` `%`) the service will ... | Hi @shrabok-surge, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
* [lib/ansible/modules/windows/win_nssm.py](https://github.com/ansible/ansible/blob/devel/lib/... | [
{
"body": "##### SUMMARY\r\nWhen running `win_nssm` module with parameters `user` and `password` and the password contains special characters (we have a number of special characters such as `#` `$` `%`) the service will fail to start with `The service did not start due to a logon failure`.\r\n\r\nThe issue did ... | 0fecc84c9f0e828b2478093e340ac1ff6a13f123 | {
"head_commit": "547797276e65649543fe7480ed6f49a44c33d078",
"head_commit_message": "Fix win_nssm credentials quoting\n\nFix credential quoting for win_nssm after changes to the way nssm command is invoked in Ansible 2.7.1.",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_nssm.ps1 b/lib/ansible/... | [
{
"diff_hunk": "@@ -403,7 +403,7 @@ Function Nssm-Update-Credentials\n }\n \n If ($nssm_result.stdout.split(\"`n`r\")[0] -ne $fullUser) {\n- $cmd = \"set \"\"$name\"\" ObjectName $fullUser '$password'\"\n+ $cmd = \"set \"\"$name\"\" ObjectName $fullUser \"\"... | 6f8e755a2f584a95b42549cb76be3034934faee7 | diff --git a/changelogs/fragments/48728-win_nssm-credential-quoting.yml b/changelogs/fragments/48728-win_nssm-credential-quoting.yml
new file mode 100644
index 00000000000000..1579ca9afcd129
--- /dev/null
+++ b/changelogs/fragments/48728-win_nssm-credential-quoting.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - "win_nssm - Switch... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-48717@6ea22b1 | ansible/ansible | Python | 48,717 | Changes to redfish-based parameters | Corrected redfish parameters to their Schematic counterparts
##### SUMMARY
Changes all playbook related variables to counterparts related to their Redfish terminology as best as possible, in order to maintain a similar vocabulary between the playbooks and Redfish. In the event of conflicting terms, prefix with app... | 2018-11-15T12:35:51Z | Make the Redfish input parameters consistent with the Redfish property names
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
####... | Files identified in the description:
* [lib/ansible/modules/remote_management/redfish/redfish_command.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/remote_management/redfish/redfish_command.py)
* [lib/ansible/modules/remote_management/redfish/redfish_config.py](https://github.com/ansible/ansible... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | c66e16097fe6ca1c87b4b4704b68bd8e6f2a8173 | {
"head_commit": "6ea22b17e1be8ead509d126b32998d40c943a39b",
"head_commit_message": "Updated doc information with \"version_added\"",
"patch_to_review": "diff --git a/lib/ansible/modules/remote_management/redfish/redfish_command.py b/lib/ansible/modules/remote_management/redfish/redfish_command.py\nindex 6508d5e9... | [
{
"diff_hunk": "@@ -177,15 +182,15 @@ def main():\n command_list = module.params['command']\n \n # admin credentials used for authentication\n- creds = {'user': module.params['user'],\n+ creds = {'username': module.params['username'],",
"line": null,
"original_line": 185,
"original_sta... | e64719fe999fd6d13fe44101c63affe5a3c6bf78 | diff --git a/lib/ansible/modules/remote_management/redfish/redfish_command.py b/lib/ansible/modules/remote_management/redfish/redfish_command.py
index 6508d5e9948de1..39581e26bb0564 100644
--- a/lib/ansible/modules/remote_management/redfish/redfish_command.py
+++ b/lib/ansible/modules/remote_management/redfish/redfish_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
ansible__ansible-47333@387e583 | ansible/ansible | Python | 47,333 | Add threading to slack notification module | ##### SUMMARY
Fixes #21266. Adds the ability to reply to a thread in a slack message. This follows the slack API documentation for threading from here: https://api.slack.com/docs/message-threading
In addition, the module had no unit tests so I added a few. Its definitley not 100% coverage, but some is better than n... | 2018-10-19T04:08:01Z | Support for message threading
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Idea
##### COMPONENT NAME
<!--- Name of the module/pl... | cc @ramondelafuente
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the ... | c0546b41331c6928e0d118be2711a382b6a9fefd | {
"head_commit": "387e58365df1bcd256577c660949d1360e03fa52",
"head_commit_message": "Fix sanity check",
"patch_to_review": "diff --git a/lib/ansible/modules/notification/slack.py b/lib/ansible/modules/notification/slack.py\nindex 9c7c2f160c050f..068ce6094bb08c 100644\n--- a/lib/ansible/modules/notification/slack.... | [
{
"diff_hunk": "@@ -55,6 +55,10 @@\n channel:\n description:\n - Channel to send the message to. If absent, the message goes to the channel selected for the I(token).\n+ thread_ts:",
"line": null,
"original_line": 58,
"original_start_line": null,
"path": "lib/ansible/modules/notific... | f3eb53c32c1549fb527ed5bf3994acfac3748f8a | diff --git a/lib/ansible/modules/notification/slack.py b/lib/ansible/modules/notification/slack.py
index 9c7c2f160c050f..7bf4026540e7d7 100644
--- a/lib/ansible/modules/notification/slack.py
+++ b/lib/ansible/modules/notification/slack.py
@@ -55,6 +55,10 @@
channel:
description:
- Channel to send the mes... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-47243@ba52781 | ansible/ansible | Python | 47,243 | Don't use the task for a cache, return a special cache var | ##### SUMMARY
This PR addresses an issue where looping over a hostvar, with a templated `delegate_to` would create a loop cache on the task for the last host in the loop. Fixes #47207
The original problem that was being solved was the following:
```
- command: whoami
delegate_to: "{{ item }}"
with_ran... | 2018-10-17T20:20:20Z | 'with_dict' not working correctly when used in combination with a variable as input for 'delegate_to'
##### SUMMARY
While using a variable as input to 'delegate_to' in combination with
'with_dict' a dictionary configured in host_vars of host A is also
used for host B.
##### ISSUE TYPE
- Bug Report
##### COMPO... | Hi @christian-simmen, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
* [lib/ansible/playbook/task.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/... | [
{
"body": "##### SUMMARY\r\nWhile using a variable as input to 'delegate_to' in combination with\r\n'with_dict' a dictionary configured in host_vars of host A is also\r\nused for host B.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\ndelegate_to\r\nwith_dict\r\n\r\n##### ANSIBLE VERSION\... | ae5aeb9a67c65490b6e93ddae63c6ef2aa575f24 | {
"head_commit": "ba52781a79b0679a65a19c216bd15446fad91aa0",
"head_commit_message": "Add changelog fragment",
"patch_to_review": "diff --git a/changelogs/fragments/delegate_to_loop_hostvars.yaml b/changelogs/fragments/delegate_to_loop_hostvars.yaml\nnew file mode 100644\nindex 00000000000000..26680f3ae5e77e\n--- ... | [
{
"diff_hunk": "@@ -210,7 +211,12 @@ def _get_loop_items(self):\n \n templar = Templar(loader=self._loader, shared_loader_obj=self._shared_loader_obj, variables=self._job_vars)\n items = None\n- if self._task.loop_with:\n+ loop_cache = self._job_vars.get('_ansible_loop_cache')\n+ ... | 08d4d0d27ee1ffb4b7e75e9749b7b8929ead9fcd | diff --git a/changelogs/fragments/delegate_to_loop_hostvars.yaml b/changelogs/fragments/delegate_to_loop_hostvars.yaml
new file mode 100644
index 00000000000000..26680f3ae5e77e
--- /dev/null
+++ b/changelogs/fragments/delegate_to_loop_hostvars.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+- delegate_to - When templating ``delegate_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-47328@c71fd8e | ansible/ansible | Python | 47,328 | Add to k8s_raw docs re: vault-encrypted files | I didn't read the examples far enough and maybe would not have tried all the examples so I ended up creating https://github.com/ansible/ansible/issues/47259 and learned that definition key with lookup works well and we agreed the docs should say something. :)
+label: docsite_pr
##### SUMMARY
<!--- Describe the c... | 2018-10-19T02:42:33Z | k8s_raw cannot handle Ansible Vault encrypted files
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain ... | Hi @r4j4h, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
* [lib/ansible/modules/clustering/k8s/_k8s_raw.py](https://github.com/ansible/ansible/blob/devel/lib/a... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | bfc3ca1da1fd70961582f498b094959c39e3ab40 | {
"head_commit": "c71fd8ec3e3c0d07914cbcb06cc6d56a0063968c",
"head_commit_message": "Remove trailing whitespace",
"patch_to_review": "diff --git a/lib/ansible/modules/clustering/k8s/k8s.py b/lib/ansible/modules/clustering/k8s/k8s.py\nindex 999d8ba0a15294..1829ce93fb3644 100644\n--- a/lib/ansible/modules/clusterin... | [
{
"diff_hunk": "@@ -116,7 +116,9 @@\n state: present\n src: /testing/deployment.yml\n \n-- name: Read definition file from the Ansible controller file system\n+- name: >-\n+ Read definition file from the Ansible controller file system\n+ or by reading the definition from a file encrypted with Ansi... | 99cb7d19381cd849941fc20097cb76bcf4e5d888 | diff --git a/lib/ansible/modules/clustering/k8s/k8s.py b/lib/ansible/modules/clustering/k8s/k8s.py
index 999d8ba0a15294..6c4616a27f3a6c 100644
--- a/lib/ansible/modules/clustering/k8s/k8s.py
+++ b/lib/ansible/modules/clustering/k8s/k8s.py
@@ -28,7 +28,7 @@
description:
- Use the OpenShift Python client to perform C... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-47185@df0d9b4 | ansible/ansible | Python | 47,185 | add old usages to network cluster | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
add old usages to network cluster
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #35286
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPON... | 2018-10-17T09:29:06Z | ovirt_networks: management network modification fails, API complains about unsetting management property
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest... | Files identified in the description:
* [lib/ansible/modules/cloud/ovirt/ovirt_networks.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/ovirt/ovirt_networks.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!---\r\nName of the ... | dd46f953f6c88bc159c532b17e9b5c7e34f216bc | {
"head_commit": "df0d9b4534e88002f5fb48097ed3ba9b287a8906",
"head_commit_message": "set default value to old usages",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_network.py b/lib/ansible/modules/cloud/ovirt/ovirt_network.py\nindex aed2f8ace41333..59a1e9158cccd0 100644\n--- a/lib/ansibl... | [
{
"diff_hunk": "@@ -213,18 +214,23 @@ def __init__(self, network_id, cluster_network, *args, **kwargs):\n super(ClusterNetworksModule, self).__init__(*args, **kwargs)\n self._network_id = network_id\n self._cluster_network = cluster_network\n+ self._old_usages = []\n+ self.... | b1eff1a948076166eaa259557aeb3b7bc6d16d3e | diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_network.py b/lib/ansible/modules/cloud/ovirt/ovirt_network.py
index aed2f8ace41333..647f9e4d637aff 100644
--- a/lib/ansible/modules/cloud/ovirt/ovirt_network.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_network.py
@@ -146,6 +146,7 @@
search_by_name,
get_id_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-47121@16aa2f5 | ansible/ansible | Python | 47,121 | Add porting guide note about inline vars on import/include_tasks | ##### SUMMARY
Add porting guide note about inline vars on import/include_tasks. Fixes #47102
##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
docs/docsite/rst/porting_guides/porting_guide_2.7.rst
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes -->
```paste be... | 2018-10-16T14:45:44Z | 2.7 breaks include_tasks with variables
##### SUMMARY
After upgrading to Ansible 2.7, our scripts stopped working. Looks like the behaviour of include_tasks was broken.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
include_tasks
##### ANSIBLE VERSION
```
2.7
```
##### OS / ENVIRONMENT
Mac OS Hig... | There appears to be no mention of this breakage in the changelog, and the documentation doesn't include any examples for this. Can someone provide me the up to date syntax please?
Ok, found this closed issue: https://github.com/ansible/ansible/issues/47071#issuecomment-429938205
So this works now:
```yaml
tasks:... | [
{
"body": "##### SUMMARY\r\nAfter upgrading to Ansible 2.7, our scripts stopped working. Looks like the behaviour of include_tasks was broken.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\ninclude_tasks\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n2.7\r\n```\r\n\r\n##### OS / ENVIRONMENT\r\nM... | 1ec71e503e56e0d6820d43eddd66e0f7ec8ff479 | {
"head_commit": "16aa2f55749926983f3f540fc075b1b253a238eb",
"head_commit_message": "Add porting guide note about inline vars. Fixes #47102",
"patch_to_review": "diff --git a/docs/docsite/rst/porting_guides/porting_guide_2.7.rst b/docs/docsite/rst/porting_guides/porting_guide_2.7.rst\nindex 6070419b3312b4..335dc1... | [
{
"diff_hunk": "@@ -71,6 +71,25 @@ In Ansible 2.7 a new module argument named ``public`` was added to the ``include\n \n There is an important difference in the way that ``include_role`` (dynamic) will expose the role's variables, as opposed to ``import_role`` (static). ``import_role`` is a pre-processor, and t... | d25e485d5f724b7a9bedd49b11c0e46b1f5e20cc | diff --git a/docs/docsite/rst/porting_guides/porting_guide_2.7.rst b/docs/docsite/rst/porting_guides/porting_guide_2.7.rst
index 6070419b3312b4..a4a6e36c20dcd0 100644
--- a/docs/docsite/rst/porting_guides/porting_guide_2.7.rst
+++ b/docs/docsite/rst/porting_guides/porting_guide_2.7.rst
@@ -71,6 +71,25 @@ In Ansible 2.7... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-47004@bcb8e4d | ansible/ansible | Python | 47,004 | Fix prompt mismatch issue for ios | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #40884 #44463 #46082
~~* Check if the last matched prompt in the response~~
~~is the same as that of the current prompt. This will ensure
any misinterpreted prompt that is matched in between response is ignored.... | 2018-10-13T12:47:44Z | ios_config traceback on some devices
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these html comments.
... | Files identified in the description:
* [lib/ansible/modules/network/ios/ios_config.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/ios/ios_config.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click h... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 3feb6c9e0fba8a521c7c0948b6eb89822cdef2cd | {
"head_commit": "bcb8e4d7fe77ad17b7fa40ea9ea4a7b7ca93d86a",
"head_commit_message": "Update to make buffer timeout float",
"patch_to_review": "diff --git a/lib/ansible/plugins/connection/network_cli.py b/lib/ansible/plugins/connection/network_cli.py\nindex c27c9ad73cbc48..e7ab2f445572c9 100644\n--- a/lib/ansible/... | [
{
"diff_hunk": "@@ -342,15 +363,34 @@ def receive(self, command=None, prompts=None, answer=None, newline=True, prompt_\n '''\n Handles receiving of output from command\n '''\n- recv = BytesIO()\n- handled = False\n-\n self._matched_prompt = None\n self._matc... | b45406ff80bbf278623f8b311c5e70d15f57f0c6 | diff --git a/docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst b/docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst
index a68f00e9c7190e..3d734cd8512bc2 100644
--- a/docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst
+++ b/docs/docsite/rst/network/user_guide/net... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
beetbox__beets-5570@e9a77ca | beetbox/beets | Python | 5,570 | Fix sorting on missing non-string fields | ## Description
Fixes #5512. When sorting on a field, if the field is missing from some items and it has a type, use the type's `null` value. Otherwise, continue to fall back to an empty string, as I don't think there's much to be done in that case.
The new test `test_int_field_present_in_some_items` fails without... | 2024-12-29T16:09:01Z | mpdstats: Error when querying `play_count` with a sort order
<!--
Describe your problem, feature request, or discussion topic here.
Please fill out this and the "Setup" section below and remember to include
enough detail so that other people can reproduce the problem.
-->
### Error when sorting certain mpdstat... | This is happening because values for these fields are expected to be numeric, however beets fails handling **empty** values which appear as empty strings. This needs fixing for sure.
Meanwhile, try filtering for non-empty values in your query:
```diff
-$ beet -vv list play_count+
+$ beet -vv list play_count+ pl... | [
{
"body": "<!--\r\nDescribe your problem, feature request, or discussion topic here.\r\n\r\nPlease fill out this and the \"Setup\" section below and remember to include\r\nenough detail so that other people can reproduce the problem.\r\n-->\r\n\r\n### Error when sorting certain mpdstats queries\r\n\r\nRunning t... | fdd365f88df4645e4a8dbd86deb175c6cb4b91b4 | {
"head_commit": "e9a77cac72168d4aa791e454885c5315dca09c3a",
"head_commit_message": "format",
"patch_to_review": "diff --git a/beets/dbcore/query.py b/beets/dbcore/query.py\nindex da621a767a..5af1cc417b 100644\n--- a/beets/dbcore/query.py\n+++ b/beets/dbcore/query.py\n@@ -985,7 +985,7 @@ class FieldSort(Sort):\n ... | [
{
"diff_hunk": "@@ -514,6 +519,24 @@ def test_field_present_in_some_items(self):\n # items without field last\n assert [i.id for i in results_desc] == [ids[2], ids[1], ids[0], ids[3]]\n \n+ def test_int_field_present_in_some_items(self):\n+ \"\"\"Test ordering by a field not present on... | c9afb8664bb399c35915707289e97f75d24fb228 | diff --git a/beets/dbcore/query.py b/beets/dbcore/query.py
index da621a767a..866162c4ad 100644
--- a/beets/dbcore/query.py
+++ b/beets/dbcore/query.py
@@ -985,7 +985,7 @@ class FieldSort(Sort):
def __init__(
self,
- field,
+ field: str,
ascending: bool = True,
case_insens... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-46445@4abaf91 | ansible/ansible | Python | 46,445 | added jinja2 example | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Added simple example of using jinja2 template for src parameter
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Closes https://github.com/ansible/ansible/issues/44461
##### ISSUE TYPE
<!--- Pick on... | 2018-10-03T18:36:18Z | add example for jinja2 template for eos_config module
##### SUMMARY
There is no example with jinja2 for Arista
Add an example like this->
```yaml
- name: render jinja template onto Arista switch
eos_config:
src: eos_template.j2
```
##### ISSUE TYPE
- Documentation Report
##### COMPONENT NAME
N/A... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner ---> | [
{
"body": "##### SUMMARY\r\nThere is no example with jinja2 for Arista\r\n\r\nAdd an example like this->\r\n\r\n```yaml\r\n- name: render jinja template onto Arista switch\r\n eos_config:\r\n src: eos_template.j2\r\n```\r\n##### ISSUE TYPE\r\n - Documentation Report\r\n\r\n##### COMPONENT NAME\r\nN/A\r\n\r\... | bd849e8fb4f1a49daa80de2b7ea2eedf82137532 | {
"head_commit": "4abaf91d8ea3fd3adda3319415ecdbec44047cf5",
"head_commit_message": "added jinja2 example",
"patch_to_review": "diff --git a/docs/docsite/rst/dev_guide/testing/sanity/index.rst.new b/docs/docsite/rst/dev_guide/testing/sanity/index.rst.new\nnew file mode 100644\nindex 00000000000000..c23afdc463daec... | [
{
"diff_hunk": "@@ -0,0 +1,46 @@\n+Sanity Tests",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "docs/docsite/rst/dev_guide/testing/sanity/index.rst.new",
"start_line": null,
"text": "@user1:\nAdded accidently? \n\n@author:\ngrrr... still not sure why that file k... | 0fa0f2f33498b6082708efc2bf0ad40d736be5a6 | diff --git a/lib/ansible/modules/network/eos/eos_config.py b/lib/ansible/modules/network/eos/eos_config.py
index 53d7ab10802ecf..b84c749197c2ab 100644
--- a/lib/ansible/modules/network/eos/eos_config.py
+++ b/lib/ansible/modules/network/eos/eos_config.py
@@ -228,6 +228,11 @@
eos_config:
src: eos.cfg
+- name: ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-45997@7685795 | ansible/ansible | Python | 45,997 | Fixes #45983: Add gluster_heal_facts module for Gluster storage. | This module will add support to extract self-heal status of a cluster
and return the number of files that are still in progress for the
healing process to complete.
Signed-off-by: Devyani Kota <dkota@redhat.com>
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes ... | 2018-09-21T18:34:37Z | storage: Add gluster_heal_facts module to extract cluster heal status.
##### SUMMARY
This module will add support to extract self-heal status of a cluster and
return the number of files that are still in progress for the healing process
to complete.
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
Gather... | Files identified in the description:
* [lib/ansible/modules/storage/glusterfs/__init__.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/storage/glusterfs/__init__.py)
* [lib/ansible/parsing/utils/yaml.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/parsing/utils/yaml.py)
If these fil... | [
{
"body": "##### SUMMARY\r\nThis module will add support to extract self-heal status of a cluster and\r\nreturn the number of files that are still in progress for the healing process\r\nto complete.\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\r\nGather heal status of a cluster.\r\nstor... | 8498889ef643d4332ebb19a1a6a811be80aa48c6 | {
"head_commit": "7685795ad48936dec6fe930de64fbcedf104c4bd",
"head_commit_message": "Updates #45983: Add support for rebalance_status for Gluster storage.\n\nAdded support to extract rebalance status of a cluster and return the\nnumber of files that are still in progress for the rebalance process\nto complete.\n\nS... | [
{
"diff_hunk": "@@ -0,0 +1,183 @@\n+#!/usr/bin/python\n+# -*- coding: utf-8 -*-\n+#\n+# Copyright (c) 2016 Red Hat, Inc.\n+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\n+\n+from __future__ import absolute_import, division, print_function\n+__metaclass__ = type\n+\... | 80cf8f178ee1014fae36fc976e37c65b67dda493 | diff --git a/lib/ansible/modules/storage/glusterfs/gluster_heal_facts.py b/lib/ansible/modules/storage/glusterfs/gluster_heal_facts.py
new file mode 100644
index 00000000000000..0f3be996ff6a46
--- /dev/null
+++ b/lib/ansible/modules/storage/glusterfs/gluster_heal_facts.py
@@ -0,0 +1,195 @@
+#!/usr/bin/python
+# -*- cod... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-45708@6b56220 | ansible/ansible | Python | 45,708 | win_updates: Add post search category matching to support product matching | ##### SUMMARY
Resolves #45476. Please see this issue for further details and motivation.
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
win_updates
##### ANSIBLE VERSION
```
ansible 2.8.0.dev0
config file = /root/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/mod... | 2018-09-17T03:24:01Z | win_updates post search categories (restrict which products to update)
##### SUMMARY
It is currently not possible to restrict the products that get updated with Windows using the current win_updates module. This prevents updating only the OS but not other Microsoft products using this module.
##### ISSUE TYPE
- Fe... | If there's interest I'm happy to provide a PR.
cc @dagwieers @jborean93 @jhawkesworth @nitzmahone
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
I'm not against this, we may need to have a broader discussion around the interface to specify thes... | [
{
"body": "##### SUMMARY\r\nIt is currently not possible to restrict the products that get updated with Windows using the current win_updates module. This prevents updating only the OS but not other Microsoft products using this module.\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\r\nwi... | 66f03827d68868fa1d7c007451bbb1423942e679 | {
"head_commit": "6b56220d655540a0aab85c29225f5fa76d790180",
"head_commit_message": "win_updates: Documentation fix-up",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_updates.ps1 b/lib/ansible/modules/windows/win_updates.ps1\nindex cd4ca990b9c59e..72c5efc8e40210 100644\n--- a/lib/ansible/module... | [
{
"diff_hunk": "@@ -60,6 +61,7 @@ $update_script_block = {\n Function Start-Updates {\n Param(\n $category_guids,\n+ [string[]]$post_categories=@(),",
"line": null,
"original_line": 64,
"original_start_line": null,
"path": "lib/ansible/modules/windows/win_updat... | 3e370e40304b5807fcc2a5f172c26974c1bd7742 | diff --git a/changelogs/fragments/win_updates-post-categories.yaml b/changelogs/fragments/win_updates-post-categories.yaml
new file mode 100644
index 00000000000000..526d801cfdf3fd
--- /dev/null
+++ b/changelogs/fragments/win_updates-post-categories.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+- win_updates - Reworked filteri... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-45359@8cf4731 | ansible/ansible | Python | 45,359 | handle yum and dnf lockfiles - fixes #44120 | Signed-off-by: Adam Miller <admiller@redhat.com>
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
handle yum and dnf lockfiles
Fixes #44120
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete ... | 2018-09-07T17:17:01Z | Make Yum module handle yum locks without hanging.
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these ht... | Situation can be reproduced by running yum in another terminal or by creating a lock file.
```
echo 1 > /var/run/yum.pid
```
Lock is there for a reason, I'm pretty sure that it's unsafe to automagically remove it.
We're not going to remove it, we're going to detect the lock and fail the module accordingly.
prototy... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 7a61763fba4accbee97b97f7651826eeea9fbc7d | {
"head_commit": "8cf47310a60ab289d7f8765faf64d1e1bbe3981a",
"head_commit_message": "handle yum and dnf lockfiles - fixes #44120\n\nSigned-off-by: Adam Miller <admiller@redhat.com>",
"patch_to_review": "diff --git a/lib/ansible/module_utils/yumdnf.py b/lib/ansible/module_utils/yumdnf.py\nindex aa3e0138a67781..732... | [
{
"diff_hunk": "@@ -92,6 +98,20 @@ def __init__(self, module):\n self.enablerepo = self.listify_comma_sep_strings_in_list(self.enablerepo)\n self.exclude = self.listify_comma_sep_strings_in_list(self.exclude)\n \n+ # This should really be redefined by both the yum and dnf module but a\n+ ... | 03229a60aa752a5496967fde876894a9f0bc5e8d | diff --git a/lib/ansible/module_utils/yumdnf.py b/lib/ansible/module_utils/yumdnf.py
index aa3e0138a67781..eed3ebf21bacad 100644
--- a/lib/ansible/module_utils/yumdnf.py
+++ b/lib/ansible/module_utils/yumdnf.py
@@ -10,6 +10,8 @@
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.tx... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-45551@50bccef | ansible/ansible | Python | 45,551 | Ovirt delete snapshots after x days | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #41500
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
- Feature Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -... | 2018-09-12T09:56:18Z | Allow for ovirt_snapshots to be deleted based on date differences
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (O... | Files identified in the description:
* [lib/ansible/modules/cloud/ovirt/ovirt_snapshots.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/ovirt/ovirt_snapshots.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 73c8041ec048751e37d8f64c67323e5972975a3d | {
"head_commit": "50bccefa8f947c4a8a655099e2c18d6a59531120",
"head_commit_message": "put remove logic to function",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py b/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py\nindex e988c3e820f8bc..6b84ea5cbac324 100644\n--- a/lib/ansible... | [
{
"diff_hunk": "@@ -222,6 +236,23 @@ def restore_snapshot(module, vm_service, snapshots_service):\n }\n \n \n+def remove_old_snapshosts(module, snapshots_service):\n+ from datetime import datetime\n+ import time\n+ deleted_snapshot = []\n+ changed = False\n+ date_now = datetime.now()\n+ fo... | dce943ea18f3f278dd2db769bcf661a53ca37b56 | diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py b/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py
index e988c3e820f8bc..917e04ebd3373b 100644
--- a/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py
@@ -59,6 +59,11 @@
- "restore_memory... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-45334@bb25a33 | ansible/ansible | Python | 45,334 | win_exec: refactor PS exec runner | ##### SUMMARY
This is a bib refactor of the Windows exec runner to add the following features;
* Split out the actual PowerShell to separate files instead of embedding them inside Python, adds more features like static analysis and test mapping
* ~~Added C# modules, still a basic implementation and requires furthe... | 2018-09-07T06:51:19Z | Improve Windows module exception output
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Idea
##### COMPONENT NAME
Windows modules
##### ANSIBLE VERSION
v2.4
##### SUMMARY
So if a Windows module raises an exception, the output is hard to read because it is encapsulated inside of a... | I think things would be improved if the \r\n could be interpretted as new-lines. However skippy seems to be wanting to output something that mostly looks like json.
I use a tweaked version of the minimal callback plugin which improves things (its tweaked because minimal doesn't display task names, without which I am ... | [
{
"body": "##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\nWindows modules\r\n\r\n##### ANSIBLE VERSION\r\nv2.4\r\n\r\n##### SUMMARY\r\nSo if a Windows module raises an exception, the output is hard to read because it is encapsulated inside of ... | 8498b58ad57414c8d1ed269f80cd7f1ac6f6fc5a | {
"head_commit": "bb25a33f83821a3c5bd3d3911c0e531f363c6561",
"head_commit_message": "removed C# module support to focus on just error msg improvement",
"patch_to_review": "diff --git a/MANIFEST.in b/MANIFEST.in\nindex ffc7cf0a14afed..27a901b6db3758 100644\n--- a/MANIFEST.in\n+++ b/MANIFEST.in\n@@ -6,6 +6,8 @@ inc... | [
{
"diff_hunk": "@@ -0,0 +1,82 @@\n+\"\"\"Analyze C# import statements.\"\"\"\n+\n+from __future__ import absolute_import, print_function\n+\n+import os\n+import re\n+\n+from lib.util import (\n+ display,\n+)\n+\n+\n+def get_csharp_module_utils_imports(powershell_targets, csharp_targets):\n+ \"\"\"Return a... | e08f4eebc6ae96ee50888b431980cb6c717f7651 | diff --git a/MANIFEST.in b/MANIFEST.in
index ffc7cf0a14afed..27a901b6db3758 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -6,6 +6,8 @@ include requirements.txt
include .coveragerc
include examples/hosts
include examples/ansible.cfg
+recursive-include lib/ansible/executor/powershell *
+recursive-include lib/ansible/m... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
beetbox__beets-5480@c49de7a | beetbox/beets | Python | 5,480 | Improve ListenBrainz error handling and simplify playlist handling | ## Description
Fixes #5459
## To Do
- [X] Changelog. (Add an entry to `docs/changelog.rst` to the bottom of one of the lists near the top of the document.)
- [ ] Tests. (Very much encouraged but not strictly required.)
| 2024-10-25T14:53:38Z | Listenbrainz broken - AttributeError
Listenbrainz is currently broken. I get this error:
```bash
Traceback (most recent call last):
File "/home/arsaboo/.local/bin/beet", line 8, in <module>
sys.exit(main())
^^^^^^
File "/home/arsaboo/.local/lib/python3.12/site-packages/beets/ui/__init__.py"... | [
{
"body": "Listenbrainz is currently broken. I get this error:\r\n\r\n```bash\r\nTraceback (most recent call last):\r\n File \"/home/arsaboo/.local/bin/beet\", line 8, in <module>\r\n sys.exit(main())\r\n ^^^^^^\r\n File \"/home/arsaboo/.local/lib/python3.12/site-packages/beets/ui/__init__.py\"... | fa10dcf11add0afd3b4b22af29f8d504e7ef8a0a | {
"head_commit": "c49de7afe6a37d4d0372d3c3e33799d11dc7b69a",
"head_commit_message": "Update changelog.rst",
"patch_to_review": "diff --git a/beetsplug/listenbrainz.py b/beetsplug/listenbrainz.py\nindex 4855481f86..d1efd2275e 100644\n--- a/beetsplug/listenbrainz.py\n+++ b/beetsplug/listenbrainz.py\n@@ -116,13 +116... | [
{
"diff_hunk": "@@ -199,17 +181,21 @@ def get_tracks_from_playlist(self, playlist):\n \"\"\"This function returns a list of tracks in the playlist.\"\"\"\n tracks = []\n for track in playlist.get(\"playlist\").get(\"track\"):\n- tracks.append(\n- {\n- ... | b9c6ee208eff45f9a4285160585540a7ee89e4e8 | diff --git a/beetsplug/listenbrainz.py b/beetsplug/listenbrainz.py
index 4855481f86..1e29127937 100644
--- a/beetsplug/listenbrainz.py
+++ b/beetsplug/listenbrainz.py
@@ -148,9 +148,6 @@ def get_playlists_createdfor(self, username):
return self._make_request(url)
def get_listenbrainz_playlists(self):
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-44951@91cfd5c | ansible/ansible | Python | 44,951 | Ovirt add rename functionality | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Now you can rename most of ovirt components. When you pass components ID then you can change name.
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you sho... | 2018-08-31T08:32:29Z | ovirt module: Rename ovirt management network
##### SUMMARY
During the deployment on ovirt Hosted-Engine via ansible I need to rename the network from the default name (ovirtmgmt) to something else. Currently there is no way to do it on the ovirt-ansible modules.
This RFE is crucial for Hosted-engine to support o... | Files identified in the description:
* [lib/ansible/modules/cloud/ovirt/ovirt_affinity_group.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/ovirt/ovirt_affinity_group.py)
* [lib/ansible/modules/cloud/ovirt/ovirt_affinity_label.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/mo... | [
{
"body": "##### SUMMARY\r\n\r\nDuring the deployment on ovirt Hosted-Engine via ansible I need to rename the network from the default name (ovirtmgmt) to something else. Currently there is no way to do it on the ovirt-ansible modules.\r\n\r\nThis RFE is crucial for Hosted-engine to support other management net... | c2fa0d2c4bc4c0d2229775c5394c026091e595cc | {
"head_commit": "91cfd5c7d99c3dd4bf7e42646ca24c859d077800",
"head_commit_message": "update pep8 syntax",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_cluster.py b/lib/ansible/modules/cloud/ovirt/ovirt_cluster.py\nindex 54e1dc99dec737..9f7b743e4ca91d 100644\n--- a/lib/ansible/modules/clo... | [
{
"diff_hunk": "@@ -97,6 +101,11 @@\n - ovirt_vmpool:\n state: absent\n name: myvmpool\n+\n+# Change Pool Name\n+- ovirt_vmpool:\n+ id: 00000000-0000-0000-0000-000000000000\n+ name: \"new disk name\"",
"line": null,
"original_line": 108,
"original_start_line": null,
"path": "lib/an... | 3c7b5870665f0de87fd3c441d33a856c1fe5f8e3 | diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_cluster.py b/lib/ansible/modules/cloud/ovirt/ovirt_cluster.py
index 54e1dc99dec737..1570c3d7d0510b 100644
--- a/lib/ansible/modules/cloud/ovirt/ovirt_cluster.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_cluster.py
@@ -18,6 +18,10 @@
description:
- "Module to ma... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-44660@665bef2 | ansible/ansible | Python | 44,660 | [Junos] Fix bug of setting user password | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Add user encrypted_password option.
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.-->
Fixes #32683
####... | 2018-08-24T19:19:27Z | junos_user missing 'configured_password' parameter
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
The junos_user module is missing the 'configured_password' parameter. Without this parameter, passwords cannot be... | cc @Qalthos @ganeshrn @privateip
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\nThe junos_user module is missing the 'configured_password' parameter. Without this parameter, passwords cannot be configured for the user... | ee1b899b1864fe2eb16f762f648678fab06e557e | {
"head_commit": "665bef2645f55cd00bfb6e129320c028dc019404",
"head_commit_message": "Add readme for Junos user encrypted_password",
"patch_to_review": "diff --git a/lib/ansible/modules/network/junos/junos_user.py b/lib/ansible/modules/network/junos/junos_user.py\nindex cdca5dc5dc2112..d481b29bb510f3 100644\n--- a... | [
{
"diff_hunk": "@@ -57,6 +57,11 @@\n - The C(sshkey) argument defines the public SSH key to be configured\n for the user account on the remote system. This argument must\n be a valid SSH key\n+ encrypted_password:\n+ description:\n+ - The C(encrypted_password) argument set alread... | 77f36b5943bea9b5be62408d7d34501dcc45a60f | diff --git a/lib/ansible/modules/network/junos/junos_user.py b/lib/ansible/modules/network/junos/junos_user.py
index cdca5dc5dc2112..3a17bfe4a3ed6e 100644
--- a/lib/ansible/modules/network/junos/junos_user.py
+++ b/lib/ansible/modules/network/junos/junos_user.py
@@ -57,6 +57,11 @@
- The C(sshkey) argument define... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
beetbox__beets-5447@f243fbc | beetbox/beets | Python | 5,447 | Reworked #4709 after latest release | ## Description
Fixes #4709 SQL use of Double Quoted Strings.
Replacing #5236
- [X] Changelog. (Add an entry to `docs/changelog.rst` to the bottom of one of the lists near the top of the document.)
| 2024-09-28T21:33:23Z | Avoid using double-quoted string literals in SQL queries
### Problem
With a default beets installation (via pkg or ports) on FreeBSD (13.1), any action requiring interaction with the SQLite database will cause beets to crash.
This is due to Double-quoted String Literals being disabled by default in the 3.41.0,1 v... | Wow; thank you for pointing this out! This looks very serious. For a little more background on the issue, the SQLite docs discuss the syntax compatibility problem:
https://www.sqlite.org/quirks.html#double_quoted_string_literals_are_accepted
Unfortunately, it is going to be tricky in general to track down where we ... | [
{
"body": "### Problem\r\n\r\nWith a default beets installation (via pkg or ports) on FreeBSD (13.1), any action requiring interaction with the SQLite database will cause beets to crash.\r\n\r\nThis is due to Double-quoted String Literals being disabled by default in the 3.41.0,1 version of SQLite - enabling DQ... | 1a59368dbfea5bf4bcab5fdb95e4201fe072d4d5 | {
"head_commit": "f243fbc6814e016a93a8fb96defd4d9f56114239",
"head_commit_message": "Reworked #4709 after latest release",
"patch_to_review": "diff --git a/beets/dbcore/query.py b/beets/dbcore/query.py\nindex f8cf7fe4c2..5088b1e776 100644\n--- a/beets/dbcore/query.py\n+++ b/beets/dbcore/query.py\n@@ -1040,8 +1040... | [
{
"diff_hunk": "@@ -40,6 +40,8 @@ Bug fixes:\n issues in the future.\n :bug:`5289`\n * :doc:`plugins/discogs`: Fix the ``TypeError`` when there is no description.\n+* Fix double-quoted string literals in SQL queries",
"line": null,
"original_line": 43,
"original_start_line": null,
"path": "d... | 9a9f4a183c3086f8b4eb33dcc509f7464a32db81 | diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
index b9593741c5..ee4edbdcb7 100644
--- a/CONTRIBUTING.rst
+++ b/CONTRIBUTING.rst
@@ -237,7 +237,7 @@ There are a few coding conventions we use in beets:
.. code-block:: python
with g.lib.transaction() as tx:
- rows = tx.query('SELECT DISTINCT "... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-44142@fd7b1b1 | ansible/ansible | Python | 44,142 | Set defaults from params after loading files, allowing params to override |
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
I think this should give parameters to the module priority over incluster/kubeconfig-based authentication.
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; b... | 2018-08-14T20:32:19Z | k8s verify_ssl=no still verifies certificate.
##### COMPONENT NAME
k8s
##### ANSIBLE VERSION
2.6
##### ACTUAL RESULTS
With ansible 2.6 and kubernetes host that is using invalid ssl with
```
k8s:
host: "{{ api_host }}"
state: "present"
verify_ssl: no
api_key: "{{ api_key }}"
r... | @sahkaa Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.
Here are the items we could not find in your description:
- ansible version
- component name
Please set the description of this issue with this template:
http... | [
{
"body": "\r\n##### COMPONENT NAME\r\nk8s\r\n\r\n##### ANSIBLE VERSION\r\n\r\n2.6\r\n\r\n##### ACTUAL RESULTS\r\n\r\n\r\nWith ansible 2.6 and kubernetes host that is using invalid ssl with\r\n```\r\nk8s:\r\n host: \"{{ api_host }}\"\r\n state: \"present\"\r\n verify_ssl: no\r\n api_key: \"{{ api_ke... | 6b81c365330c55824902e5148deefed9a7340e1b | {
"head_commit": "fd7b1b14ce737f2b673aeff57d86faf97747e547",
"head_commit_message": "Set defaults from params after loading files, allowing params to override",
"patch_to_review": "diff --git a/lib/ansible/module_utils/k8s/common.py b/lib/ansible/module_utils/k8s/common.py\nindex edb8fa3aab424b..2954c66fb0edcf 10... | [
{
"diff_hunk": "@@ -139,46 +139,37 @@ def get_api_client(self, **auth_params):\n auth_params = auth_params or getattr(self, 'params', {})\n auth = copy.deepcopy(auth_params)\n \n- configuration = kubernetes.client.Configuration()\n+ # Pull authorization settings from environment va... | 28e6b4297f929d6ba9c32d7a0ae3e55a9d61fa71 | diff --git a/lib/ansible/module_utils/k8s/common.py b/lib/ansible/module_utils/k8s/common.py
index edb8fa3aab424b..e05725a02da896 100644
--- a/lib/ansible/module_utils/k8s/common.py
+++ b/lib/ansible/module_utils/k8s/common.py
@@ -139,57 +139,39 @@ def get_api_client(self, **auth_params):
auth_params = auth_pa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-43805@3b77652 | ansible/ansible | Python | 43,805 | nxos_vlan refactor to support non structured output | Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
fixes https://github.com/ansible/ansible/issues/43481
fixes https://github.com/ansible/ansible/issues/40705
fixes https://github.com/ansible/ansible/issues/40236
fixes http... | 2018-08-08T04:40:55Z | nxos_vlan mode issue on N5k
<!---
nxos_vlan mode fabricpath issue on n5k
--->
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.
Do not include extra details here, e.g. "vyos_command" not "the network module vyos_command" or ... | Files identified in the description:
* [lib/ansible/modules/network/nxos/nxos_vlan.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_vlan.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click h... | [
{
"body": "<!---\r\nnxos_vlan mode fabricpath issue on n5k\r\n--->\r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Insert, BELOW THIS COMMENT, the name of the module, plugin, task or feature.\r\nDo not include extra details here, e.g. \"vyos_command\" not \"the network module vyos_... | 77bff99f3c54d4720c7cb4228b1f520d5aa9a765 | {
"head_commit": "3b776527035c5afdef45b632483fa5509e586095",
"head_commit_message": "address review comment\n\nSigned-off-by: Trishna Guha <trishnaguha17@gmail.com>",
"patch_to_review": "diff --git a/lib/ansible/module_utils/network/nxos/nxos.py b/lib/ansible/module_utils/network/nxos/nxos.py\nindex 50f8b2fbb113c... | [
{
"diff_hunk": "@@ -158,6 +158,28 @@ def run_commands(self, commands, check_rc=True):\n except ConnectionError as exc:\n self._module.fail_json(msg=to_text(exc))\n \n+ def cli_run_commands(self, commands, check_rc=True):\n+ \"\"\"\n+ Fallback to text command if JSON command ... | 2b882a6e91edfc4f4591b52d418442c96746df11 | diff --git a/lib/ansible/module_utils/network/nxos/nxos.py b/lib/ansible/module_utils/network/nxos/nxos.py
index 50f8b2fbb113c8..1b25113971464b 100644
--- a/lib/ansible/module_utils/network/nxos/nxos.py
+++ b/lib/ansible/module_utils/network/nxos/nxos.py
@@ -154,7 +154,18 @@ def run_commands(self, commands, check_rc=Tr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
beetbox__beets-4984@39fd14c | beetbox/beets | Python | 4,984 | Improve Deezer error handling | ## Description
Fixes #4983
## To Do
<!--
- If you believe one of below checkpoints is not required for the change you
are submitting, cross it out and check the box nonetheless to let us know.
For example: - [x] ~Changelog~
- Regarding the changelog, often it makes sense to add your entry only once
... | 2023-11-01T22:06:36Z | Deezer plugin hangs and errors out instead of gracefully handling timeout errors
Deezer plugin often errors out with a timeout (after waiting for a long time). See the trace below:
```bash
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 382, in _make_reque... | [
{
"body": "Deezer plugin often errors out with a timeout (after waiting for a long time). See the trace below:\r\n\r\n```bash\r\nTraceback (most recent call last):\r\n File \"/usr/lib/python3/dist-packages/urllib3/connectionpool.py\", line 382, in _make_request\r\n self._validate_conn(conn)\r\n File \"/usr... | 85268ad061d3990881fb2569c0ab890d6ddf7efd | {
"head_commit": "39fd14cec7e8f0903b83b5db6df7a1527be9702f",
"head_commit_message": "Update changelog.rst",
"patch_to_review": "diff --git a/beetsplug/deezer.py b/beetsplug/deezer.py\nindex 4c70d841ec..55ee233588 100644\n--- a/beetsplug/deezer.py\n+++ b/beetsplug/deezer.py\n@@ -75,13 +75,12 @@ def album_for_id(se... | [
{
"diff_hunk": "@@ -75,13 +75,12 @@ def album_for_id(self, album_id):\n deezer_id = self._get_id(\"album\", album_id, self.id_regex)\n if deezer_id is None:\n return None\n-\n- album_data = requests.get(self.album_url + deezer_id).json()\n- if \"error\" in album_data:\n... | df2d6ae7538d28192ff486314f3c8b2ff0e183ce | diff --git a/beetsplug/deezer.py b/beetsplug/deezer.py
index 4c70d841ec..a2e16f59f2 100644
--- a/beetsplug/deezer.py
+++ b/beetsplug/deezer.py
@@ -63,6 +63,19 @@ def func(lib, opts, args):
return [deezer_update_cmd]
+ def fetch_data(self, url):
+ try:
+ response = requests.get(url, tim... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-43565@f356912 | ansible/ansible | Python | 43,565 | elb_target_facts Fixes #39780 | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.-->
Fixes #39780
Adds an 'elb_target_facts' module whic... | 2018-08-01T19:21:57Z | Find the list of all the AWS ALB target groups in which instance is registered
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add informa... | Files identified in the description:
* [lib/ansible/modules/cloud/amazon/elb_target.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/elb_target.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 09ae1ec308d919f88e63280a507da624cd8f93d6 | {
"head_commit": "f356912b9ca94c03450454d428c554439aca2ec1",
"head_commit_message": "removing extra space",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/elb_target_facts.py b/lib/ansible/modules/cloud/amazon/elb_target_facts.py\nnew file mode 100644\nindex 00000000000000..7cc8ea4b7b4655\n--- ... | [
{
"diff_hunk": "@@ -0,0 +1,437 @@\n+#!/usr/bin/python\n+# Copyright: (c) 2018, Yaakov Kuperman <ykuperman@gmail.com>\n+# GNU General Public License v3.0+ # (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\n+from __future__ import absolute_import, division, print_function\n+\n+ANSIBLE_METADATA = {\"meta... | 75f49716494f56dcc1a84bee2bac7a101bfff89f | diff --git a/lib/ansible/modules/cloud/amazon/elb_target_facts.py b/lib/ansible/modules/cloud/amazon/elb_target_facts.py
new file mode 100644
index 00000000000000..ad162fee31e2c6
--- /dev/null
+++ b/lib/ansible/modules/cloud/amazon/elb_target_facts.py
@@ -0,0 +1,434 @@
+#!/usr/bin/python
+# Copyright: (c) 2018, Yaakov ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
beetbox__beets-4735@8bac744 | beetbox/beets | Python | 4,735 | Fix data_source not updated on re-import and refactor `reimport_metadata` | ## Description
- Fixes #4726
- Refactors preserving of flexible attributes in the importer's `reimport_metadata()` method.
- New logging message when flexible attributes are excluded from the preserving process and _actually_ set to a new value.
- Reformats all existing logging messages and streamline their look... | 2023-03-28T08:34:35Z | Re-imports don't update `data_source` flex attr
### Problem
When importing an album or a singleton that was previously imported already, the `data_source` flexible attribute is not updated. It stays as **initially imported**.
### Setup
* OS: ---
* Python version: ---
* beets version: 1.6.1 dev-latest
* Tu... | Even album re-import does not update `data_source`.
>
Thanks for testing and clarifying. I was actually assuming that this is also the case but I wasn't sure yet. So, many thanks, that is very helpful! :-)
I'm pretty sure the problem is located here:
https://github.com/beetbox/beets/blob/4194914e94077f673cf92... | [
{
"body": "### Problem\r\n\r\nWhen importing an album or a singleton that was previously imported already, the `data_source` flexible attribute is not updated. It stays as **initially imported**.\r\n\r\n\r\n### Setup\r\n\r\n* OS: ---\r\n* Python version: ---\r\n* beets version: 1.6.1 dev-latest\r\n* Turning off... | d05c34ec4e9d8fa9e34706ac2279b7315b36e1e0 | {
"head_commit": "8bac74480c6d0ffd57175808f0e52f187ce9342e",
"head_commit_message": "Helper function for reimport flex attr preserving\n\nFlexible attribute keys listed in REIMPORT_FRESH_FIELDS_* are now removed from\nthe original LazyConvertDict in a separate function which is used for both\nalbum and item level f... | [
{
"diff_hunk": "@@ -811,55 +811,74 @@ def reimport_metadata(self, lib):\n \"\"\"For reimports, preserves metadata for reimported items and\n albums.\n \"\"\"\n+ # Album and item flex attrs that should not be preserved on reimports.\n+ dont_preserve_album_flex = ['data_sourc... | 9f71e42c8091ee90c86da1272cf629e8f2b9c69d | diff --git a/beets/importer.py b/beets/importer.py
index 96d1f17dfc..601f8246ff 100644
--- a/beets/importer.py
+++ b/beets/importer.py
@@ -50,6 +50,11 @@
SINGLE_ARTIST_THRESH = 0.25
PROGRESS_KEY = 'tagprogress'
HISTORY_KEY = 'taghistory'
+# Album and item flexble attrbutes that should not be preserved on reimports.
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-43295@f6bddcd | ansible/ansible | Python | 43,295 | Fix baud rate and nxos_logging default case idempotency bug | ##### SUMMARY
- Fixes #43072
- Added regex in nxos terminal plugin to detect baud rate error messages while configuring console logging with level > 2
- Added more code to detect monitor and console logging configurations with default levels, that doesn't show up in running-config
- Added integration tests for the... | 2018-07-26T05:47:16Z | nxos_logging not idempotent
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these html comments.
Otherwis... | Files identified in the description:
* [lib/ansible/modules/network/nxos/nxos_logging.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_logging.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[c... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 5e44189a361c8fd4cbb0d48666c91a51d2158cb1 | {
"head_commit": "f6bddcd7b27e875c5610235bf237c33ac283ed32",
"head_commit_message": "Fix Shippable errors",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_logging.py b/lib/ansible/modules/network/nxos/nxos_logging.py\nindex 1c805c45fd7124..6db04815cd8dda 100644\n--- a/lib/ansible/modules/n... | [
{
"diff_hunk": "@@ -286,6 +285,30 @@ def map_config_to_obj(module):\n 'dest_level': parse_dest_level(line, dest, parse_name(line, dest)),\n 'facility_level': parse_facility_level(line, facility)})\n \n+ cmd_1 = [{'command': 'show logging | section enabled | sec... | 2fab9e2b44f529d45bdadfd76bc9c20be2eff9cb | diff --git a/lib/ansible/modules/network/nxos/nxos_logging.py b/lib/ansible/modules/network/nxos/nxos_logging.py
index 1c805c45fd7124..c4d6165bae9bc7 100644
--- a/lib/ansible/modules/network/nxos/nxos_logging.py
+++ b/lib/ansible/modules/network/nxos/nxos_logging.py
@@ -114,8 +114,7 @@
import re
-
-from ansible.mo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-43335@7b6c7b2 | ansible/ansible | Python | 43,335 | Add enable_ip_forwarding option to azure_rm_networkinterface; Fixes #43276 | ##### SUMMARY
Add `enable_ip_forwarding` to `azure_rm_networkinterface`
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
azure_rm_networkinterface
##### ANSIBLE VERSION
```
2.7
```
##### ADDITIONAL INFORMATION
Fixes #43276
| 2018-07-26T22:53:43Z | ansible_rm_networkinterface should support IP forwarding
##### SUMMARY
`ansible_rm_networkinterface` should support IP forwarding. Especially important when deploying NVA VM's (i.e Palo Alto, F5 etc.)
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
ansible_rm_networkinterface
##### ANSIBLE VERSION
``... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner ---> | [
{
"body": "##### SUMMARY\r\n`ansible_rm_networkinterface` should support IP forwarding. Especially important when deploying NVA VM's (i.e Palo Alto, F5 etc.)\r\n\r\n##### ISSUE TYPE\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\nansible_rm_networkinterface\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n2.6\r\n```\r\... | 7ea909418e56f20fe27650fa1d4144d9668c9efe | {
"head_commit": "7b6c7b2a20362c47a2eaa05778b02820e50604b2",
"head_commit_message": "auth to auto",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py b/lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py\nindex fc66972974f386..331672ad5263d2 100644\n--- a/lib/a... | [
{
"diff_hunk": "@@ -1,29 +1,34 @@\n - name: Prepare random number\n set_fact:\n rpfx: \"{{ resource_group | hash('md5') | truncate(7, True, '') }}{{ 1000 | random }}\"\n+ auth_source: auto",
"line": null,
"original_line": 4,
"original_start_line": null,
"path": "test/integration/targets... | 0a81763e23ab066a998b32d597a628d4c28c12dc | diff --git a/lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py b/lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py
index fc66972974f386..331672ad5263d2 100644
--- a/lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py
+++ b/lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py
@@ -1... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-43306@95a1979 | ansible/ansible | Python | 43,306 | Fix referenced before assignment in role requirements | ##### SUMMARY
If the SCM provider is missing during role require, `run_scm_cmd()` throws an uncaught Unbound exception error:
```
ERROR! Unexpected Exception, this is probably a bug: local variable 'stdout' referenced before assignment
the full traceback was:
Traceback (most recent call last):
File "/usr/bi... | 2018-07-26T12:48:51Z | Misleading error from ansible-galaxy if 'git' is missing
##### SUMMARY
When using ansible galaxy with a missing git binary, the error message is very misleading:
```
ERROR! Unexpected Exception, this is probably a bug: local variable 'stdout' referenced before assignment
```
##### ISSUE TYPE
- Bug Report
... | [
{
"body": "##### SUMMARY\r\n\r\nWhen using ansible galaxy with a missing git binary, the error message is very misleading:\r\n\r\n```\r\nERROR! Unexpected Exception, this is probably a bug: local variable 'stdout' referenced before assignment\r\n``` \r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONE... | 7a35e2f8c1f7e9463944f66ff4f7a095176b0809 | {
"head_commit": "95a1979c88fa18b9983d66222e1afce804baee8a",
"head_commit_message": "Fix referenced before assignment in role requirements",
"patch_to_review": "diff --git a/lib/ansible/playbook/role/requirement.py b/lib/ansible/playbook/role/requirement.py\nindex f41bf8968ff584..862e4f00da15cc 100644\n--- a/lib/... | [
{
"diff_hunk": "@@ -189,6 +189,8 @@ def scm_archive_role(src, scm='git', name=None, version='HEAD', keep_scm_meta=Fa\n \n def run_scm_cmd(cmd, tempdir):\n try:\n+ stdout = None\n+ stderr = None",
"line": null,
"original_line": 193,
"original_start_li... | 2e65d29711431af1a1979324043f8e8fbe125ba2 | diff --git a/lib/ansible/playbook/role/requirement.py b/lib/ansible/playbook/role/requirement.py
index f41bf8968ff584..5e298c75d6a7df 100644
--- a/lib/ansible/playbook/role/requirement.py
+++ b/lib/ansible/playbook/role/requirement.py
@@ -189,6 +189,8 @@ def scm_archive_role(src, scm='git', name=None, version='HEAD', k... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-43127@0f49244 | ansible/ansible | Python | 43,127 | Detect failed sysvinit module | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
The rationale for this change was to close #42957
- This checks the stderr instead of the rc to detect whether the
sysvinit module was successful or not, as even when failing, the
rc would be 0.
- It immediatly became ob... | 2018-07-22T10:33:54Z | Service module reports changed when actually failed
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these ... | Files identified in the description:
* [lib/ansible/modules/system/service.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/service.py)
* [lib/ansible/modules/system/sysvinit.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/sysvinit.py)
If these files are inaccur... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | a9b077f763747f44ba692f2adbdf36ac59150b58 | {
"head_commit": "0f49244c8be4f6699a7af3447be4c993066f3b16",
"head_commit_message": "Detect failed sysvinit module\n\n- This checks the stderr instead of the rc to detect whether the\n sysvinit module was successful or not, as even when failing, the\n rc would be 0.\n- It immediatly became obvious that the debug ... | [
{
"diff_hunk": "@@ -310,8 +310,8 @@ def runme(doit):\n (rc, out, err) = module.run_command(cmd)\n # FIXME: ERRORS\n \n- if rc != 0:\n- module.fail_json(msg=\"Failed to %s service: %s\" % (action, name))\n+ if err != \"\":\n+ module.... | f225c5908f84adeb79253e3e2cbe87ee4c882523 | diff --git a/lib/ansible/modules/system/sysvinit.py b/lib/ansible/modules/system/sysvinit.py
index c39e2866ec1c1a..a5067838c80b61 100644
--- a/lib/ansible/modules/system/sysvinit.py
+++ b/lib/ansible/modules/system/sysvinit.py
@@ -311,7 +311,7 @@ def runme(doit):
# FIXME: ERRORS
if rc != 0:
... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-43113@1fb8f2a | ansible/ansible | Python | 43,113 | elb_application_lb purge rules option | ##### SUMMARY
Adds the ability to leave existing rules in place on an ELB.
Fixes #43109
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
elb_application_lb
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes below -->
```
ansible 2.7.0.dev0 (detached HEA... | 2018-07-20T21:27:17Z | elb_application_lb cannot append rules only create/replace
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE)... | Files identified in the description:
* [lib/ansible/modules/cloud/amazon/elb_application_lb.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/elb_application_lb.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot ... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | bb35973e37f4bd2b9f1e92e212af584326304f9a | {
"head_commit": "1fb8f2a036d318c17cb47e80e6914795718412f7",
"head_commit_message": "Expand purge_rules documentation",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/elb_application_lb.py b/lib/ansible/modules/cloud/amazon/elb_application_lb.py\nindex 3985e9c70b5f64..e8d983e3907eff 100644\n---... | [
{
"diff_hunk": "@@ -119,6 +119,12 @@\n description:\n - The time in seconds to use in conjunction with I(wait).\n version_added: 2.6\n+ purge_rules:\n+ description:\n+ - Keeps the existing load balancer rules in place. Will modify and add, but will not delete.",
"line": null,
"ori... | 45d6c21c1d8adb881978bd9b88f4fb4342d7fe2f | diff --git a/lib/ansible/modules/cloud/amazon/elb_application_lb.py b/lib/ansible/modules/cloud/amazon/elb_application_lb.py
index 3985e9c70b5f64..f4edeb65f9af20 100644
--- a/lib/ansible/modules/cloud/amazon/elb_application_lb.py
+++ b/lib/ansible/modules/cloud/amazon/elb_application_lb.py
@@ -119,6 +119,12 @@
des... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-43078@d7d2bc5 | ansible/ansible | Python | 43,078 | Raise exception if command timeout is triggered |
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #43076
If persistent connection timeout is triggered, riase
exception which will be send over socket to module code
instead of silently shutting down the socket.
<!--- If you are fixing an existing issue, please incl... | 2018-07-20T10:48:17Z | ios_command return empty output if persistent socket timeout is triggered
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information... | Files identified in the description:
* [bin/ansible-connection](https://github.com/ansible/ansible/blob/devel/bin/ansible-connection)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/a... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 0718a53b075eb563c22e9214f0e45d6b4d7a7e11 | {
"head_commit": "d7d2bc5b7a5fdb0a917bb8e03e3d2eb1431de53e",
"head_commit_message": "Fix review comment",
"patch_to_review": "diff --git a/bin/ansible-connection b/bin/ansible-connection\nindex f77e3f2fe6f0be..8c9375cdc3fbb4 100755\n--- a/bin/ansible-connection\n+++ b/bin/ansible-connection\n@@ -16,6 +16,7 @@ imp... | [
{
"diff_hunk": "@@ -136,22 +139,28 @@ class ConnectionProcess(object):\n self.exception = traceback.format_exc()\n \n finally:\n- # when done, close the connection properly and cleanup\n- # the socket file so it can be recreated\n+ # allow time for any ex... | de122079fc151ea7e9b0443e5a48166915cd5e29 | diff --git a/bin/ansible-connection b/bin/ansible-connection
index f77e3f2fe6f0be..aa5d1fc6f95b65 100755
--- a/bin/ansible-connection
+++ b/bin/ansible-connection
@@ -16,6 +16,7 @@ import os
import signal
import socket
import sys
+import time
import traceback
import errno
import json
@@ -136,22 +137,28 @@ class C... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
beetbox__beets-4719@2e2a3bf | beetbox/beets | Python | 4,719 | Added option to embedart using an image URL [small PR] | ## Description
Fixes [#83](https://github.com/beetbox/beets/issues/831)
Added another option `-u` to provide an image URL. The plugin can now download the image, check if it is valid, and then embed the picture as cover art.
## To Do
- [x] Documentation. (If you've add a new command-line flag, for example,... | 2023-03-18T23:37:30Z | FetchArt / EmbedArt - fetch art from specific url
if not found or if set in options prompt for a url from where to get the album art
.. so that we dont have to download it and use the `[-f IMAGE]` option :) | Thanks for the suggestion! In the mean time, have you considered a simple shell script that just downloads a file with `curl` and then invokes `beet embedart`? Something as simple as:
```
#!/bin/sh
curl -o temp.jpg $1
beet embedart -f temp.jpg $2
rm temp.jpg
```
could work.
thanks!
i guess i'm stuck on windows, but ... | [
{
"body": "if not found or if set in options prompt for a url from where to get the album art\n\n.. so that we dont have to download it and use the `[-f IMAGE]` option :)\n",
"number": 831,
"title": "FetchArt / EmbedArt - fetch art from specific url"
}
] | 6e38ba68f8c6fda9f4d9f9aca9f23e2a187ab4f1 | {
"head_commit": "2e2a3bf2239e8b073e5541c752b08779b7014f01",
"head_commit_message": "Add additional error handling",
"patch_to_review": "diff --git a/beetsplug/embedart.py b/beetsplug/embedart.py\nindex 6db46f8c17..5df9f2e5a4 100644\n--- a/beetsplug/embedart.py\n+++ b/beetsplug/embedart.py\n@@ -15,14 +15,15 @@\n ... | [
{
"diff_hunk": "@@ -107,13 +110,38 @@ def embed_func(lib, opts, args):\n art.embed_item(self._log, item, imagepath, maxwidth,\n None, compare_threshold, ifempty,\n quality=quality)\n+ elif opts.url:\n+ ... | 56adba719b81329424be9d9177badc798f6ec203 | diff --git a/beetsplug/embedart.py b/beetsplug/embedart.py
index 6db46f8c17..48580a844d 100644
--- a/beetsplug/embedart.py
+++ b/beetsplug/embedart.py
@@ -15,14 +15,16 @@
"""Allows beets to embed album art into file metadata."""
import os.path
+import tempfile
+from mimetypes import guess_extension
+import reques... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
beetbox__beets-4387@74e5498 | beetbox/beets | Python | 4,387 | feat(import): Add support for reading skipped paths from logfile | ## Description
Fixes #4379.
## To Do
- [X] Documentation. (If you've add a new command-line flag, for example, find the appropriate page under `docs/` to describe it.)
- [X] Changelog. (Add an entry to `docs/changelog.rst` near the top of the document.)
- [X] Test. (Encouraged but not strictly required.) | 2022-06-26T17:36:49Z | Allow importing from logfile
When importing large collections, it makes sense to do the automated import first, then do the manual part afterwards:
$ beet import -l skipped.log -q /path/to/library
It would be great if it was possible to continue the import using the logfile instead of a directory:
$ be... | My current workaround:
```
$ grep -v "^import" missing.log | sed "s/^[a-z-]\+ //" | python <(cat << EOF
import sys
import os.path
for line in sys.stdin:
print(os.path.commonpath(line.rstrip("\n").split("; ")))
EOF
) | xargs -d $'\n' beet import
```
I use a sricpt sh for that:
```
date=$(date '+%Y%m%... | [
{
"body": "When importing large collections, it makes sense to do the automated import first, then do the manual part afterwards:\r\n\r\n $ beet import -l skipped.log -q /path/to/library\r\n\r\nIt would be great if it was possible to continue the import using the logfile instead of a directory:\r\n\r\n $ ... | fd65e12c8faa217311182103df0fd1401952486b | {
"head_commit": "74e549838cfda733d6f3be12db3829afbe1255ea",
"head_commit_message": "feat(import): Add support for reading skipped paths from logfile\n\nFixes #4379.",
"patch_to_review": "diff --git a/beets/ui/commands.py b/beets/ui/commands.py\nindex 3a33740133..b0921728dd 100755\n--- a/beets/ui/commands.py\n+++... | [
{
"diff_hunk": "@@ -79,6 +79,26 @@ def _do_query(lib, query, album, also_items=True):\n return items, albums\n \n \n+def _paths_from_logfile(path):\n+ \"\"\"Parse the logfile and yield skipped paths to pass to the `import`\n+ command.\n+ \"\"\"\n+ with open(path, mode=\"r\", encoding=\"utf-8\") ... | cfc34826a20203240e1bc8f2ba0cee328dfe18df | diff --git a/beets/ui/commands.py b/beets/ui/commands.py
index 3a33740133..cbdd8e3bfb 100755
--- a/beets/ui/commands.py
+++ b/beets/ui/commands.py
@@ -79,6 +79,43 @@ def _do_query(lib, query, album, also_items=True):
return items, albums
+def _paths_from_logfile(path):
+ """Parse the logfile and yield skipp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-42218@fa4316a | ansible/ansible | Python | 42,218 | Add additional puppet options | Add support for puppet options --debug, --verbose, --summary,
and extend logdest to support logging to stdout and syslog at
the same time.
Fixes #37986
##### SUMMARY
Add support for additional puppet output options; --debug, --verbose, --summary.
Also extends 'logdest' to support multiple log destinations a... | 2018-07-02T22:25:11Z | The puppet module should support a parameter to enable --debug mode during the puppet run
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
Always add information AFTER of these html comments.
-->
##### ISSUE TYPE
<!... | Files identified in the description:
* [lib/ansible/modules/system/puppet.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/puppet.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\nAlways add information AFTER of these html comments.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n\r\n - Feat... | 9539284010eb4bc7e50a30751de2b978c8db5675 | {
"head_commit": "fa4316ace3ebc8335180acd60fe7d9eda6b51f19",
"head_commit_message": "Fix silly yaml error",
"patch_to_review": "diff --git a/changelogs/fragments/puppet_debugging_options.yaml b/changelogs/fragments/puppet_debugging_options.yaml\nnew file mode 100644\nindex 00000000000000..588063aff9e2b0\n--- /dev... | [
{
"diff_hunk": "@@ -0,0 +1,4 @@\n+---\n+features:",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/puppet_debugging_options.yaml",
"start_line": null,
"text": "@user1:\nUse `minor_changes`."
}
] | f865a8f7cfa04fe68ce7972bc688f0cc7e09ffd6 | diff --git a/changelogs/fragments/puppet_debugging_options.yaml b/changelogs/fragments/puppet_debugging_options.yaml
new file mode 100644
index 00000000000000..6aab6c54337ab9
--- /dev/null
+++ b/changelogs/fragments/puppet_debugging_options.yaml
@@ -0,0 +1,5 @@
+---
+minor_changes:
+ - puppet - Add support for --debug... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-42456@b29e00e | ansible/ansible | Python | 42,456 | Add ssl support to consul_kv lookup | ##### SUMMARY
Added the params scheme, cert and verify to the consul_kv lookup module
Fixes #40877
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
lookup/consul_kv
##### ANSIBLE VERSION
```
ansible 2.5.3 (stable-2.5 9d8d1de182) last updated 2018/05/22 09:25:46 (GMT +200)
config file = /mnt... | 2018-07-07T08:27:18Z | ssl support for lookup consul_kv
##### SUMMARY
The lookup plugin consul_kv does not support to change the scheme to https not to send a cert with the request nor to skip cert verifiaction if that is desired
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
lookup/consul_kv
##### ANSIBLE VERSION
```
an... | Files identified in the description:
* [lib/ansible/modules/clustering/consul_kv.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/clustering/consul_kv.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here ... | [
{
"body": "##### SUMMARY\r\nThe lookup plugin consul_kv does not support to change the scheme to https not to send a cert with the request nor to skip cert verifiaction if that is desired\r\n\r\n##### ISSUE TYPE\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\nlookup/consul_kv\r\n\r\n##### ANSIBLE VERSION\r\n`... | 52fe9aaf04a132d5de4c6226af786e94ed62ec02 | {
"head_commit": "b29e00e3037e7dba8585015633b8be273b494c6d",
"head_commit_message": "implemented lookup_consul_kv",
"patch_to_review": "diff --git a/lib/ansible/plugins/lookup/consul_kv.py b/lib/ansible/plugins/lookup/consul_kv.py\nindex 8d6edc234216a7..0652464e36927f 100644\n--- a/lib/ansible/plugins/lookup/cons... | [
{
"diff_hunk": "@@ -33,9 +34,34 @@\n - The target to connect to, must be a resolvable address.\n env:\n - name: ANSIBLE_CONSUL_URL\n+ ini:\n+ - section: lookup_consul\n+ key: host\n port:\n description: The port of the target host to connect ... | 48db1e9bbcd534378c2417a3834ffba6872fdec5 | diff --git a/lib/ansible/plugins/lookup/consul_kv.py b/lib/ansible/plugins/lookup/consul_kv.py
index 8d6edc234216a7..a80a735fdc535c 100644
--- a/lib/ansible/plugins/lookup/consul_kv.py
+++ b/lib/ansible/plugins/lookup/consul_kv.py
@@ -2,12 +2,13 @@
# (c) 2017 Ansible Project
# GNU General Public License v3.0+ (see CO... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-42149@68417b9 | ansible/ansible | Python | 42,149 | VMware Module - vmware_guest_move | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Module to Move VMs between Folders in VCenter Fixes #39165 Continues #42059. Sorry for the Error
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should st... | 2018-06-30T10:14:48Z | vmware_guest option to move an existing vm to a different folder
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
Always add information AFTER of these html comments. -->
##### ISSUE TYPE
<!--- Pick one below and del... | Files identified in the description:
* [lib/ansible/modules/cloud/vmware/vmware_guest.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/vmware/vmware_guest.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[c... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\nAlways add information AFTER of these html comments. -->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Feature Ide... | fb55038d7516149aecd9a617572437b8c2c13f50 | {
"head_commit": "68417b9cdbb529aa033b14d0cc1777a5127c1220",
"head_commit_message": "Fixing Comments under Integration Tests",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/vmware/vmware_guest_move.py b/lib/ansible/modules/cloud/vmware/vmware_guest_move.py\nnew file mode 100644\nindex 00000000000000.... | [
{
"diff_hunk": "@@ -0,0 +1,3 @@\n+posix/ci/cloud/group1/vcenter",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "test/integration/targets/vmware_guest_move/aliases",
"start_line": null,
"text": "@user1:\nmake this group4 and remove smoketest\n\n@author:\nDone Tha... | ceccb5a13861fefe0d24df62dded27a5b29c543c | diff --git a/lib/ansible/modules/cloud/vmware/vmware_guest_move.py b/lib/ansible/modules/cloud/vmware/vmware_guest_move.py
new file mode 100644
index 00000000000000..24fe2d916b577c
--- /dev/null
+++ b/lib/ansible/modules/cloud/vmware/vmware_guest_move.py
@@ -0,0 +1,218 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-42145@12c0d66 | ansible/ansible | Python | 42,145 | meraki_config_template - Check for HTTP status code | ##### SUMMARY
- All requests now check returned status code
- Fail if status code isn’t what is expected
Fixes #41282
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
meraki_config_template
##### ANSIBLE VERSION
```
ansible 2.7.0.dev0 (meraki/2.7-http-code 88764165ad) last updated 2018/06/... | 2018-06-30T01:18:06Z | Meraki modules should analyze HTTP response code for detailed success
##### SUMMARY
Meraki's API returns a HTTP code and sometimes it varies depending on the endpoint and method. The module utility looks for HTTP status codes greater than 300 for errors, but 2xx codes aren't reviewed by the module.
##### ISSUE TYPE... | Files identified in the description:
* [lib/ansible/module_utils/network/meraki/__init__.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/network/meraki/__init__.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot comman... | [
{
"body": "##### SUMMARY\r\nMeraki's API returns a HTTP code and sometimes it varies depending on the endpoint and method. The module utility looks for HTTP status codes greater than 300 for errors, but 2xx codes aren't reviewed by the module.\r\n\r\n##### ISSUE TYPE\r\n - Bug report\r\n\r\n##### COMPONENT NAME... | fb55038d7516149aecd9a617572437b8c2c13f50 | {
"head_commit": "12c0d66e80acacdf984a4cd8260d62666e199549",
"head_commit_message": "Fix blank line error",
"patch_to_review": "diff --git a/lib/ansible/modules/network/meraki/meraki_config_template.py b/lib/ansible/modules/network/meraki/meraki_config_template.py\nindex cc47dc74e012f7..3083d92eb2da20 100644\n---... | [
{
"diff_hunk": "@@ -126,7 +132,11 @@ def bind(meraki, org_name, net_name, name, data):\n if meraki.params['auto_bind']:\n payload['autoBind'] = meraki.params['auto_bind']\n meraki.result['changed'] = True\n- return meraki.request(path, method='POST', payload=json.dumps(payload... | cbc43135abcc6de049ac9f61cfc09cb98afab049 | diff --git a/lib/ansible/modules/network/meraki/meraki_config_template.py b/lib/ansible/modules/network/meraki/meraki_config_template.py
index cc47dc74e012f7..8d4a58abe87790 100644
--- a/lib/ansible/modules/network/meraki/meraki_config_template.py
+++ b/lib/ansible/modules/network/meraki/meraki_config_template.py
@@ -8... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-41959@6c670b4 | ansible/ansible | Python | 41,959 | ovirt add remote_vv_file | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.-->
Fixes #41251
##### ISSUE TYPE
<!--- Pick one below an... | 2018-06-26T11:55:14Z | Alow the ovirt_vms module to create ticket for the VM console
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSI... | Files identified in the description:
* [lib/ansible/modules/cloud/ovirt/ovirt_vms.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/ovirt/ovirt_vms.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click her... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 401c45384e053f369a4a0f8ee63393b32b495c37 | {
"head_commit": "6c670b44a846fd6f840c8bd27bba9a633ea01ec7",
"head_commit_message": "correct line width in docs",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_vms.py b/lib/ansible/modules/cloud/ovirt/ovirt_vms.py\nindex dfdc49c989b916..c3ec3413ad0769 100644\n--- a/lib/ansible/modules/clo... | [
{
"diff_hunk": "@@ -494,6 +494,11 @@\n - \"C(user_migratable) - Allow manual migration only.\"\n - \"If no value is passed, default value is set by oVirt/RHV engine.\"\n version_added: \"2.5\"\n+ ticket:\n+ description:\n+ - \"If I(true), in addition return I... | 85d39e9fff643be3c533f1ff27a68e0cd08a0387 | diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_vms.py b/lib/ansible/modules/cloud/ovirt/ovirt_vms.py
index dfdc49c989b916..441ea07c3b0c74 100644
--- a/lib/ansible/modules/cloud/ovirt/ovirt_vms.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_vms.py
@@ -494,6 +494,11 @@
- "C(user_migratable) - Allow manua... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-42144@03813a0 | ansible/ansible | Python | 42,144 | Meraki modules - Added support for checking HTTP response codes | ##### SUMMARY
- All request calls now check for response code before responding
- If the response code isn't what it should be, it fails or returns nothing
- Breaking this into multiple PRs to make backporting easier
- Using status property in Meraki module utility which has the code
- Partially fixes #41282
##... | 2018-06-30T00:38:41Z | Meraki modules should analyze HTTP response code for detailed success
##### SUMMARY
Meraki's API returns a HTTP code and sometimes it varies depending on the endpoint and method. The module utility looks for HTTP status codes greater than 300 for errors, but 2xx codes aren't reviewed by the module.
##### ISSUE TYPE... | Files identified in the description:
* [lib/ansible/module_utils/network/meraki/__init__.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/network/meraki/__init__.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot comman... | [
{
"body": "##### SUMMARY\r\nMeraki's API returns a HTTP code and sometimes it varies depending on the endpoint and method. The module utility looks for HTTP status codes greater than 300 for errors, but 2xx codes aren't reviewed by the module.\r\n\r\n##### ISSUE TYPE\r\n - Bug report\r\n\r\n##### COMPONENT NAME... | fb55038d7516149aecd9a617572437b8c2c13f50 | {
"head_commit": "03813a0d78412ab75df582118d4fb185d9742a45",
"head_commit_message": "Added support for checking HTTP response codes\n- All request calls now check for response code before responding\n- If the response code isn't what it should be, it fails or returns nothing\n- Breaking this into multiple PRs to ma... | [
{
"diff_hunk": "@@ -195,7 +199,10 @@ def get_nets(self, org_name=None, org_id=None):\n org_id = self.get_org_id(org_name)\n path = self.construct_path('get_all', org_id=org_id, function='network')\n r = self.request(path, method='GET')\n- return r\n+ if self.status == 2... | e0c021a92f5cf1392f56744e6e0817eea36c0a58 | diff --git a/lib/ansible/module_utils/network/meraki/meraki.py b/lib/ansible/module_utils/network/meraki/meraki.py
index d86f668a6b6c33..40e83b698d52c2 100644
--- a/lib/ansible/module_utils/network/meraki/meraki.py
+++ b/lib/ansible/module_utils/network/meraki/meraki.py
@@ -150,7 +150,10 @@ def is_update_required(self,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-41854@5e918bf | ansible/ansible | Python | 41,854 | Add backup feature to user module | ##### SUMMARY
Add feature to backup shadow file only on platforms where the module modifies the shadow file directly, which are currently SunOS variants.
Fixes #40696
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Pull Request
##### COMPONENT NAME
`user.py`
##### ANSIBLE VE... | 2018-06-22T18:47:14Z | user module should backup shadow to shadow-
##### SUMMARY
Tools that modify `/etc/shadow` (useradd, groupadd etc) all make a backup at `/etc/shadow-`. Ansible should also do the same. Thoughts?
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
user
##### ANSIBLE VERSION
```
ansible 2.5.3
config fil... | Files identified in the description:
* [lib/ansible/modules/system/user.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/user.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](http... | [
{
"body": "##### SUMMARY\r\nTools that modify `/etc/shadow` (useradd, groupadd etc) all make a backup at `/etc/shadow-`. Ansible should also do the same. Thoughts?\r\n\r\n##### ISSUE TYPE\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\nuser\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.5.3\r\n config file... | dd932c9acebe7a0bb72ee7abe830e2fd0b4717e4 | {
"head_commit": "5e918bfd396b1cf4fae7df393d4bcba0743ba232",
"head_commit_message": "Update docs on backup feature",
"patch_to_review": "diff --git a/lib/ansible/modules/system/user.py b/lib/ansible/modules/system/user.py\nindex 94b3d685e823f9..82bf993a9d2a9e 100644\n--- a/lib/ansible/modules/system/user.py\n+++ ... | [
{
"diff_hunk": "@@ -194,6 +194,14 @@\n type: bool\n default: 'no'\n version_added: \"2.4\"\n+ backup:",
"line": null,
"original_line": 197,
"original_start_line": null,
"path": "lib/ansible/modules/system/user.py",
"start_line": null,
"text": "@user1:\ni would ... | e6f79344ed7c4ee4ce1c0addf904d15a6fc60a47 | diff --git a/changelogs/fragments/user-module-backup-shadow.yaml b/changelogs/fragments/user-module-backup-shadow.yaml
new file mode 100644
index 00000000000000..c8e556493d5f79
--- /dev/null
+++ b/changelogs/fragments/user-module-backup-shadow.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+ - user - backup shadow file on platf... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
beetbox__beets-4119@3aed99f | beetbox/beets | Python | 4,119 | Add documentation for `path_sep_replace` | ## Description
Fixes https://github.com/beetbox/beets/issues/323 (probably).
This PR adds documentation for `path_sep_replace` configuration option, which is not yet present in the official docs.
## To Do
- [x] Documentation. (If you've add a new command-line flag, for example, find the appropriate page und... | 2021-10-22T20:47:03Z | Document or remove path_sep_replace config value
I struggled for quite a while to not have slashes replaced with underscores (I use a comma for readability). Based on the documentation of the configuration (which is otherwise quite thorough, thanks!), I tried replacing the regex in the replace configuration value. Only... | You're right: we should document this better. I've been surprised by the number of people who have gone looking for this setting.
There are two reasons that the setting is currently separate: (a) so we can use `os.path` to determine what the platform's path separators are in a hypothetical universe where there's somet... | [
{
"body": "I struggled for quite a while to not have slashes replaced with underscores (I use a comma for readability). Based on the documentation of the configuration (which is otherwise quite thorough, thanks!), I tried replacing the regex in the replace configuration value. Only after digging at the code did... | b116eb5456d1849489257329b53a4fc588e45c07 | {
"head_commit": "3aed99f051eae1d5b127f285b65d77b781d4ac80",
"head_commit_message": "Update config.rst\n\nThis PR adds documentation for `path_sep_replace` configuration option, which is not yet present in the official docs.",
"patch_to_review": "diff --git a/docs/reference/config.rst b/docs/reference/config.rst\... | [
{
"diff_hunk": "@@ -151,6 +151,19 @@ replaced as they don't match the typewriter quote (``\"``). To also strip these\n special characters, you can either add them to the replacement list or use the\n :ref:`asciify-paths` configuration option below.\n \n+.. _path-sep-replace:\n+\n+path_sep_replace\n+~~~~~~~~~~~~... | 638b1e740a7e91da077345981e1a7dc6b2548b64 | diff --git a/docs/reference/config.rst b/docs/reference/config.rst
index f041be6250..642216c8f7 100644
--- a/docs/reference/config.rst
+++ b/docs/reference/config.rst
@@ -151,6 +151,25 @@ replaced as they don't match the typewriter quote (``"``). To also strip these
special characters, you can either add them to the r... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-41849@08ea4e9 | ansible/ansible | Python | 41,849 | Add execution_role_arn parameter | ##### SUMMARY
Fargate support requires containers to have the executionRoleArn defined. This PR adds that parameter.
Fixes #41848
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
ecs_taskdefinition
##### ANSIBLE VERSION
```
ansible 2.7.0.dev0 (devel 46dbb3e1e8) last updated 2018/06/22 10:32:41... | 2018-06-22T17:43:57Z | ecs_taskdefinition does not support execution_role_arn
##### SUMMARY
Deploying fargate containers requires the containers to have a execution role arn assigned. esc_taskdefinition does not currently support this parameter.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
ecs_taskdefinition
##### ANSIBLE ... | Files identified in the description:
* [lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot ... | [
{
"body": "##### SUMMARY\r\nDeploying fargate containers requires the containers to have a execution role arn assigned. esc_taskdefinition does not currently support this parameter.\r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\necs_taskdefinition\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n... | 46dbb3e1e8ebd69012ff59be152906cff143d18f | {
"head_commit": "08ea4e969841a617e3934a6ea40497aadba37d79",
"head_commit_message": "Add test for execution role parameter",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py b/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py\nindex ac336fce816254..37aacf681a3ac0 100644... | [
{
"diff_hunk": "@@ -541,6 +541,23 @@\n # ============================================================\n # Begin tests for Fargate\n \n+ - name: ensure AmazonECSTaskExecutionRolePolicy exists\n+ iam_role:\n+ name: ecsTaskExecutionRole\n+ assume_role_policy_document: \"{{ lookup('fil... | e500efdac1cb68febe3d6ec609e4b26b2fe26ef6 | diff --git a/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py b/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py
index ac336fce816254..37aacf681a3ac0 100644
--- a/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py
+++ b/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py
@@ -69,6 +69,11 @@
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-41809@103bd20 | ansible/ansible | Python | 41,809 | fix nxos_gir issues | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
fixes #41807
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.-->
##### ISSUE TYPE
<!--- Pick one below and... | 2018-06-21T18:26:35Z | nxos_gir issues
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these html comments.
Otherwise it may end... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 07738cc84807bdf4c1b4e911a36eab22b8825b1d | {
"head_commit": "103bd20281a4367553f378fe9b89edcd873cfca8",
"head_commit_message": "fix nxos_gir issues",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_gir.py b/lib/ansible/modules/network/nxos/nxos_gir.py\nindex 3fa4d639c6680f..7ee9d4d3b35270 100644\n--- a/lib/ansible/modules/network/nx... | [
{
"diff_hunk": "@@ -161,14 +166,7 @@\n \n def execute_show_command(command, module, command_type='cli_show_ascii'):\n cmds = [command]\n- device_info = get_capabilities(module)\n- network_api = device_info.get('network_api', 'nxapi')\n-\n- if network_api == 'cliconf':\n- body = run_commands(... | 69df174f2635426da55694445c1c5772dd991d01 | diff --git a/lib/ansible/modules/network/nxos/nxos_gir.py b/lib/ansible/modules/network/nxos/nxos_gir.py
index 3fa4d639c6680f..414343ab617bd8 100644
--- a/lib/ansible/modules/network/nxos/nxos_gir.py
+++ b/lib/ansible/modules/network/nxos/nxos_gir.py
@@ -74,9 +74,14 @@
system_mode_maintenance_on_reload_reset_reaso... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-41426@f729467 | ansible/ansible | Python | 41,426 | ensure copy action plugin returns an invocation in result | Signed-off-by: Adam Miller <admiller@redhat.com>
##### SUMMARY
Fixes #18232
Previously the action plugin for copy, which runs operations on the
control host to orchestrate executing both local actions on the
control host and remote actions on the remote host, is not returning
invocation dict in the result d... | 2018-06-11T21:02:36Z | Callback only reports module_name for copy when force argument is set to no
##### Issue Type:
- Bug Report
##### Ansible Version:
```
ansible 2.1.2.0
config file = ansible.cfg
configured module search path = None
```
##### Ansible Configuration:
```
[defaults]
hostfile = ./hosts
callback_plugins... | I can reproduce the behavior on 2.3:
(with an extra pprint.pprint(results) thrown in callback)
```
[fedora-23:callback_copy_18232 (master %)]$ ANSIBLE_CONFIG=ansible.cfg ansible-playbook -v test.yml
Using ansible.cfg as config file
[WARNING]: provided hosts list is empty, only localhost is available
PLAY [test an... | [
{
"body": "##### Issue Type:\r\n- Bug Report\r\n##### Ansible Version:\r\n\r\n```\r\nansible 2.1.2.0\r\n config file = ansible.cfg\r\n configured module search path = None\r\n```\r\n##### Ansible Configuration:\r\n\r\n```\r\n[defaults]\r\nhostfile = ./hosts\r\ncallback_plugins = ./callback_plugins\r\ncall... | 9a4ad89ec5771f22bfd59e746377f207762e470a | {
"head_commit": "f729467d3030d7257dc393ce5ebc53483b9d5707",
"head_commit_message": "ensure copy action plugin returns an invocation in result\n\nFixes #18232\n\nPreviously the action plugin for copy, which runs operations on the\ncontrol host to orchestrate executing both local actions on the\ncontrol host and rem... | [
{
"diff_hunk": "@@ -208,6 +208,13 @@ class ActionModule(ActionBase):\n \n TRANSFERS_FILES = True\n \n+ def _ensure_invocation(self, result):\n+ if result.get('failed', False) and self._play_context.no_log:\n+ result['invocation'] = \"CENSORED: no_log is set\"\n+ elif not result.h... | 6168bd4c0d18cc8ec82374c0ee618cfdeac4fb9c | diff --git a/lib/ansible/plugins/action/copy.py b/lib/ansible/plugins/action/copy.py
index b0502bfff448cc..13007d3e75323a 100644
--- a/lib/ansible/plugins/action/copy.py
+++ b/lib/ansible/plugins/action/copy.py
@@ -208,6 +208,21 @@ class ActionModule(ActionBase):
TRANSFERS_FILES = True
+ def _ensure_invocat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-41270@5c2c7a6 | ansible/ansible | Python | 41,270 | fix reload smu issue | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #41268
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.-->
##### ISSUE TYPE
<!--- Pick one below and... | 2018-06-07T18:10:27Z | nxos_rpm does not properly work for reload patches
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these h... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 4ca23cb147f1f72c2a2045d3a763e50fd6ab491b | {
"head_commit": "5c2c7a686da4094f379b3b61cfa8d0aa674a52b6",
"head_commit_message": "fix reload smu issue",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_rpm.py b/lib/ansible/modules/network/nxos/nxos_rpm.py\nindex fc8e49985bb018..16999ccecf084d 100644\n--- a/lib/ansible/modules/network/n... | [
{
"diff_hunk": "@@ -92,4 +92,62 @@\n \n when: sdk_run\n \n+- block:\n+ - name: Install reload smu RPM\n+ nxos_rpm: &trsmurpm\n+ pkg: \"nxos.CSCve91311-n9k_ALL-1.0.0-7.0.3.I6.1.lib32_n9000.rpm\"\n+ register: result\n+\n+ - assert: *true1\n+\n+ - name: Wait for device to come back up\n+ wait_fo... | e4f9c47082bca511310de3c2f6984db82c12a783 | diff --git a/lib/ansible/modules/network/nxos/nxos_rpm.py b/lib/ansible/modules/network/nxos/nxos_rpm.py
index fc8e49985bb018..16999ccecf084d 100644
--- a/lib/ansible/modules/network/nxos/nxos_rpm.py
+++ b/lib/ansible/modules/network/nxos/nxos_rpm.py
@@ -37,6 +37,8 @@
- For patches, the minimum platform version ne... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
beetbox__beets-3863@f3e7edb | beetbox/beets | Python | 3,863 | Add trackdisambig from musicbrainz. | fixes beetbox/beets#1904
## Description
Fixes #1904.
(...)
## To Do
- [x] Documentation. (If you've add a new command-line flag, for example, find the appropriate page under `docs/` to describe it.)
- [x] Changelog. (Add an entry to `docs/changelog.rst` near the top of the document.)
- [x] Tests. (Enco... | 2021-02-27T20:05:59Z | Fetch MusicBrainz track disambiguation field
I download a lot of singletons, and I use the track disambiguation notes frequently. I saw that Beets has a way to note the **album** disambig, but not the **track** disambig. Can this be inserted into a future release? This way, my beets.yaml config could look something lik... | Yes, sounds like a very reasonable addition. | [
{
"body": "I download a lot of singletons, and I use the track disambiguation notes frequently. I saw that Beets has a way to note the **album** disambig, but not the **track** disambig. Can this be inserted into a future release? This way, my beets.yaml config could look something like this:\n\n`paths:\n de... | 5b6dff34a16d1c0a666877e375c7b30c5104187c | {
"head_commit": "f3e7edb21ed0c710768908ab8f514b6067aaf5f2",
"head_commit_message": "Attempt to address the comments from sampsyo\n\nUndoes the changes to autotag/hooks.py\n\nIf trackdisambig is not set to None at some point in time, the\ntest case for a non-existent trackdisambig fails. as such, try\nto get the di... | [
{
"diff_hunk": "@@ -223,6 +223,8 @@ def track_info(recording, index=None, medium=None, medium_index=None,\n if recording.get('length'):\n info.length = int(recording['length']) / (1000.0)\n \n+ info.trackdisambig = recording.get('disambiguation', None)",
"line": null,
"original_line": 226... | ce78f75ce9d2461b145b0190c32b8281a5bd250c | diff --git a/beets/autotag/mb.py b/beets/autotag/mb.py
index 03ea5b3825..3ca5463c2f 100644
--- a/beets/autotag/mb.py
+++ b/beets/autotag/mb.py
@@ -223,6 +223,8 @@ def track_info(recording, index=None, medium=None, medium_index=None,
if recording.get('length'):
info.length = int(recording['length']) / (100... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-41004@5dfe91e | ansible/ansible | Python | 41,004 | Fix test-module failing to validate args | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
The test-module pass a wrong argument _ansible_tmp cause the validation failed.
Change the argument _ansible_tmp to _ansible_tmpdir to fix this.
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commi... | 2018-06-01T13:31:50Z | hacking/test-module adds an unexpected "_ansible_tmp" parameter
##### SUMMARY
It looks like `hacking/test-module` adds an unexpected `_ansible_tmp` parameter during execution.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
homebrew_cask
##### ANSIBLE VERSION
```
± ansible --version
ansible 2.7.0dev0... | Files identified in the description:
* [lib/ansible/modules/packaging/os/homebrew_cask.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/packaging/os/homebrew_cask.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
... | [
{
"body": "##### SUMMARY\r\nIt looks like `hacking/test-module` adds an unexpected `_ansible_tmp` parameter during execution.\r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nhomebrew_cask\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n± ansible --version\r\nansible 2.7.0dev0 (homebrew_cask_sudo_... | 5228b939fe0ec30e67a475c62c17aadd96886ecc | {
"head_commit": "5dfe91ee13832fe52b032b93759bf93ea193c785",
"head_commit_message": "Fix the file doesn't access bug in freebsd\n\nPrior to this change, test-module will raise \"No such file\" error since freebsd doesn't have /usr/bin/python.",
"patch_to_review": "diff --git a/hacking/test-module b/hacking/test-m... | [
{
"diff_hunk": "@@ -21,3 +21,7 @@ echo \"rc was $APB_RC (must be non-zero)\"\n echo \"ensure playbook output shows assert/fail works (True)\"\n echo \"$PB_OUT\" | grep -F \"fail works (True)\" || exit 1\n echo \"$PB_OUT\" | grep -F \"assert works (True)\" || exit 1\n+\n+# ensure test-module script works well\n+... | 87bc467548fbbfeda36d77d3fd101c5bdce81092 | diff --git a/hacking/test-module b/hacking/test-module
index c07d973fe12138..c56b8b72166626 100755
--- a/hacking/test-module
+++ b/hacking/test-module
@@ -125,7 +125,7 @@ def boilerplate_module(modfile, args, interpreters, check, destfile):
# default selinux fs list is pass in as _ansible_selinux_special_fs arg
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-40985@007fdde | ansible/ansible | Python | 40,985 | validate vars_files entries are string_type or list | Signed-off-by: Adam Miller <admiller@redhat.com>
##### SUMMARY
Validate `vars_files` entries to ensure they are of the correct type and display an useful error message otherwise.
Fixes #17594
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bugfix Pull Request
##### COMPONENT NAME
... | 2018-05-31T21:52:21Z | Parsing error results in ERROR! Unexpected Exception: 0
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
parsing/quoting.py
##### ANSIBLE VERSION
```
ansible 2.1.1.0
config file = /home/lmadsen/src/github/leifmadsen/ansible-cira/ansible.cfg
configured module search path = Default w/o overrides
```
##### CONFIGU... | +1
Ansible version: ansible 2.3.0.0
> 2017-05-16 16:49:35,593 p=2435 u=root | META: ran handlers
> 2017-05-16 16:49:35,594 p=2435 u=root | META: ran handlers
> 2017-05-16 16:49:35,601 p=2435 u=root | ERROR! Unexpected Exception: 0
> 2017-05-16 16:49:35,603 p=2435 u=root | the full traceback was:
>
> ... | [
{
"body": "##### ISSUE TYPE\n- Bug Report\n##### COMPONENT NAME\n\nparsing/quoting.py\n##### ANSIBLE VERSION\n\n```\nansible 2.1.1.0\n config file = /home/lmadsen/src/github/leifmadsen/ansible-cira/ansible.cfg\n configured module search path = Default w/o overrides\n```\n##### CONFIGURATION\n\n```\n[defaults]... | 0cecc08886e72e4f7fbcb715ada52833ecc40b9c | {
"head_commit": "007fdde3afba9715092b5f5673acc722c31642ea",
"head_commit_message": "validate vars_files entries are string_type or list\n\nFixes #17594\n\nSigned-off-by: Adam Miller <admiller@redhat.com>",
"patch_to_review": "diff --git a/lib/ansible/vars/manager.py b/lib/ansible/vars/manager.py\nindex 6aa3cd639... | [
{
"diff_hunk": "@@ -340,6 +340,12 @@ def plugins_by_groups():\n try:\n for vars_file in vars_file_list:\n vars_file = templar.template(vars_file)\n+ if not (isinstance(vars_file, string_types) or isinstance(vars_f... | 2db17bb12be6a3ffca8326e8533041a3120d1ffa | diff --git a/lib/ansible/vars/manager.py b/lib/ansible/vars/manager.py
index 6aa3cd6397cd5b..923c10dafd29d2 100644
--- a/lib/ansible/vars/manager.py
+++ b/lib/ansible/vars/manager.py
@@ -22,7 +22,7 @@
import os
import sys
-from collections import defaultdict, MutableMapping
+from collections import defaultdict, Mut... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-40820@a95e735 | ansible/ansible | Python | 40,820 | Do not gather mem facts if command invalid |
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
In some firmwares, 'show memory statistics' fail, thus
do not populate mem if we got a failure after running that command.
Fixes #39576
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit m... | 2018-05-29T11:12:55Z | Ansible 2.5 - ios_facts fails when running in IOS-XE 3850 switch
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
ios-facts
##### ANSIBLE VERSION
ansible 2.5.0
ansible 2.5.0
config file = /home/mfisher/.ansible.cfg
configured module search path = [u'/home/mfisher/.ansible/plugins/modules', u'/usr/sha... | Files identified in the description:
* [lib/ansible/modules/network/ios/ios_facts.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/ios/ios_facts.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click her... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nios-facts\r\n\r\n##### ANSIBLE VERSION\r\nansible 2.5.0\r\nansible 2.5.0\r\n config file = /home/mfisher/.ansible.cfg\r\n configured module search path = [u'/home/mfisher/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules... | cb636eb5223fc85c6f33309407d0ca76e86aeb4a | {
"head_commit": "a95e735269a76bc2ca32ecf80802bee9ed878eee",
"head_commit_message": "Do not gather mem facts if command invalid\n\nIn some firmwares, 'show memory statistics' fail, thus\ndo not populate mem if we got a failure after running that command.",
"patch_to_review": "diff --git a/lib/ansible/modules/netw... | [
{
"diff_hunk": "@@ -227,7 +227,7 @@ def populate(self):\n self.facts['filesystems'] = self.parse_filesystems(data)\n \n data = self.responses[1]\n- if data:\n+ if data and not 'Invalid input detected' in data:",
"line": null,
"original_line": 230,
"original_start_li... | 2770a5b54075e2d40c6b8e050dddb084d4d9c90c | diff --git a/lib/ansible/modules/network/ios/ios_facts.py b/lib/ansible/modules/network/ios/ios_facts.py
index a6016453809bff..78e6f0ff9f33fb 100644
--- a/lib/ansible/modules/network/ios/ios_facts.py
+++ b/lib/ansible/modules/network/ios/ios_facts.py
@@ -228,12 +228,15 @@ def populate(self):
data = self.resp... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-40592@0846132 | ansible/ansible | Python | 40,592 | nxos_file_copy network_cli and httpapi fix | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
fixes https://github.com/ansible/ansible/issues/40013#issuecomment-391129484
- Pass play_context host, user, password to the module code.
- Remove provider
<!--- If you are fixing an existing issue, please include "Fixes #nnn... | 2018-05-23T09:19:00Z | Intermittent Issue: Unable to copy large image files using nxos_file_copy module
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
nxos_file_copy
##### ANSIBLE VERSION
```
ansible 2.6.0 (rel260/nxos_upgrade 7bb4da05b6) last updated 2018/05/11 09:14:42 (GMT -400)
config file = /etc/ansible/ansible.cfg
... | **NOTE:** The permissions issue is misleading. Even if I set the permissions to 777 the file copy will fail.
cc @GGabriele @jedelman8 @privateip @rahushen @rcarrillocruz @trishnaguha
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
Additional Da... | [
{
"body": "\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nnxos_file_copy\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.6.0 (rel260/nxos_upgrade 7bb4da05b6) last updated 2018/05/11 09:14:42 (GMT -400)\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search path = [u'/ro... | 3e2a4ee8bab8bb0b8aa30f03acf9b25919077f10 | {
"head_commit": "0846132f353d3545f1e7b39e2c0fcef716635e06",
"head_commit_message": "blacklist nxapi\n\nSigned-off-by: Trishna Guha <trishnaguha17@gmail.com>",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_file_copy.py b/lib/ansible/modules/network/nxos/nxos_file_copy.py\nindex 435968e46f... | [
{
"diff_hunk": "@@ -43,8 +43,18 @@ def run(self, tmp=None, task_vars=None):\n \n socket_path = None\n \n+ if self._task.action == 'nxos_file_copy':\n+ if self._play_context.connection == 'network_cli':",
"line": null,
"original_line": 47,
"original_start_line": null,
"p... | 9d90d840bee8c18dab6b9b4a65d8ca4ade7ef5a7 | diff --git a/lib/ansible/modules/network/nxos/nxos_file_copy.py b/lib/ansible/modules/network/nxos/nxos_file_copy.py
index 435968e46f28b0..dd55757a379cd5 100644
--- a/lib/ansible/modules/network/nxos/nxos_file_copy.py
+++ b/lib/ansible/modules/network/nxos/nxos_file_copy.py
@@ -28,7 +28,8 @@
short_description: Copy a ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
beetbox__beets-3700@d18ca5e | beetbox/beets | Python | 3,700 | Delete after convert | ## Description
Fixes #2947.
- [x] Documentation.
- [x] Changelog.
This PR builds upon the abandoned https://github.com/beetbox/beets/pull/3394 and implements the comment in that PR, namely, the ability to enable this functionality explicitly via a `delete_originals` option. | 2020-07-30T19:23:35Z | convert: In `auto` mode, respect `import.move` by deleting old files
The relevant parts of my config:
```
import:
move: yes
plugins: convert
convert:
auto: yes
max_bitrate: 192
format: mp3
```
If the imported mp3 file has a bitrate under 192 it gets moved unconverted as desired.
If it's h... | Interesting point! This does seem wrong. For consistency, would you want transcoded files to have their originals deleted—so that the importer always appears to “move” the files?
Absolutely! You could add an plugin option to ignore the global flag but otherwise it should definitely prioritize the global import settings... | [
{
"body": "The relevant parts of my config:\r\n```\r\nimport:\r\n move: yes\r\n\r\nplugins: convert\r\n\r\nconvert:\r\n auto: yes\r\n max_bitrate: 192\r\n format: mp3\r\n```\r\nIf the imported mp3 file has a bitrate under 192 it gets moved unconverted as desired.\r\nIf it's higher than that the old ... | 20713a2ac3149b8f84dd8810364a9707bf5fa30f | {
"head_commit": "d18ca5e3b5f50af70b304db4da3e16f9d7896b84",
"head_commit_message": "Added delete_originals option to remove source files after transcode",
"patch_to_review": "diff --git a/beetsplug/convert.py b/beetsplug/convert.py\nindex e7ac4f3ac3..ca9747cb55 100644\n--- a/beetsplug/convert.py\n+++ b/beetsplug... | [
{
"diff_hunk": "@@ -532,11 +534,15 @@ def convert_on_import(self, lib, item):\n \n # Change the newly-imported database entry to point to the\n # converted file.\n+ source_path = item.path\n item.path = dest\n item.write()\n item.read() # L... | 0cf924f7bc7d5c95a551ddc42d40aaecbe0bf22f | diff --git a/beetsplug/convert.py b/beetsplug/convert.py
index e7ac4f3ac3..70363f6eb3 100644
--- a/beetsplug/convert.py
+++ b/beetsplug/convert.py
@@ -148,6 +148,7 @@ def __init__(self):
u'never_convert_lossy_files': False,
u'copy_album_art': False,
u'album_art_maxwidth': 0,
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-40314@4237165 | ansible/ansible | Python | 40,314 | nxos_interface: Disable switchport for loopback/svi | ##### SUMMARY
Fixes #38559
This PR fixes a regression introduced in v2.5 that if you have an interface type of "loopback" or "svi", and have "mode" set, causes the module to thrown an exception because a switchport command is issued to an interface that does not support it.
We probably want to fix this by testin... | 2018-05-17T10:54:30Z | nxos_interface: Invalid command at '^' marker
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
nxos_interface
##### ANSIBLE VERSION
v2.5+
##### CONFIGURATION
```
ANSIBLE_PIPELINING(/home/dwieers/backend/ansible.cfg) = True
DEFAULT_CALLBACK_WHITELIST(/home/dwieers/backend/ansible.cfg) = ['mail']
DEFAU... | Files identified in the description:
* [lib/ansible/modules/network/nxos/nxos_interface.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_interface.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nnxos_interface\r\n\r\n##### ANSIBLE VERSION\r\nv2.5+\r\n\r\n##### CONFIGURATION\r\n```\r\nANSIBLE_PIPELINING(/home/dwieers/backend/ansible.cfg) = True\r\nDEFAULT_CALLBACK_WHITELIST(/home/dwieers/backend/ansible.cfg) = ['mail']\r\nDEFAUL... | 4c0ceaea3dde9949db34abf72ed1a665cc49e813 | {
"head_commit": "4237165c75509dba2f9efb69e1a1c9f14e5d7a77",
"head_commit_message": "nxos_interface: Disable switchport for loopback/svi",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_interface.py b/lib/ansible/modules/network/nxos/nxos_interface.py\nindex ca471d9553ace2..079698613796c0 ... | [
{
"diff_hunk": "@@ -484,10 +473,12 @@ def map_obj_to_commands(updates, module):\n \n else:\n commands.append(interface)\n- if mode == 'layer2':\n- commands.append('switchport')\n- elif mode == 'layer3':\n- commands.a... | 3a3f470b2254fff1046430d970936669eb53c300 | diff --git a/lib/ansible/modules/network/nxos/nxos_interface.py b/lib/ansible/modules/network/nxos/nxos_interface.py
index ca471d9553ace2..8af09428ac9876 100644
--- a/lib/ansible/modules/network/nxos/nxos_interface.py
+++ b/lib/ansible/modules/network/nxos/nxos_interface.py
@@ -1,20 +1,7 @@
#!/usr/bin/python
-#
-# Thi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-40179@2f8077c | ansible/ansible | Python | 40,179 | Add scope parameter to systemd | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
This change changes the user: paramater into a state: paramater with the following choices:
- system
- user
- global
with system being the default. The system scope is the default scope. The user scope matches with the old use... | 2018-05-15T16:46:20Z | Add global parameter to the systemd module
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
Always add information AFTER of these html comments.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- ... | Files identified in the description:
* [lib/ansible/modules/system/systemd.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/systemd.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\nAlways add information AFTER of these html comments.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Feature ... | 07d6daf787b81ae66951485ea92aff302a91fda5 | {
"head_commit": "2f8077c64224bf40bbe521e2377f34136c61a191",
"head_commit_message": "Added version_added field for new option",
"patch_to_review": "diff --git a/lib/ansible/modules/system/systemd.py b/lib/ansible/modules/system/systemd.py\nindex 6217752cbe0f15..96d2e6c1f1b4be 100644\n--- a/lib/ansible/modules/sys... | [
{
"diff_hunk": "@@ -48,12 +48,13 @@\n type: bool\n default: 'no'\n aliases: [ daemon-reload ]\n- user:\n+ scope:",
"line": null,
"original_line": 51,
"original_start_line": null,
"path": "lib/ansible/modules/system/systemd.py",
"start_line": null,
"text": "@... | a609d66b07d02de3bf529fc912c776eaa399f4d8 | diff --git a/lib/ansible/modules/system/systemd.py b/lib/ansible/modules/system/systemd.py
index 6217752cbe0f15..b1c54d11379de7 100644
--- a/lib/ansible/modules/system/systemd.py
+++ b/lib/ansible/modules/system/systemd.py
@@ -51,9 +51,16 @@
user:
description:
- run systemctl talking to the s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-39963@85a7d65 | ansible/ansible | Python | 39,963 | Fix for Azure loadbalancer tags. | It was possible to add tags to an Azure loadbalancer, but the tags were never set in Azure.
This patch fixes that.
##### SUMMARY
It was possible to add tags to an Azure loadbalancer in a playbook, but the tags were never set in Azure. This patch fixes that.
fixes #39896
##### ISSUE TYPE
- Bugfix Pull Requ... | 2018-05-10T15:46:04Z | azure_rm_loadbalancer does not set tags
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
azure_rm_loadbalancer
##### ANSIBLE VERSION
```
ansible 2.6.0
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
... | Files identified in the description:
* [lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` ... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nazure_rm_loadbalancer \r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.6.0\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n ... | 5f7c7becde1a7d4754bfbb8f97a7f76576768403 | {
"head_commit": "85a7d65ab80dac965d8fc8f6a7055c76db406c83",
"head_commit_message": "azure_rm_loadbalancer_facts requires rg\n\nGetting facts of all loadbalancers via azure_rm_loadbalancer_facts requires a resource group.\nThis fix adds the rg as parameter to the list() call.",
"patch_to_review": "diff --git a/li... | [
{
"diff_hunk": "@@ -44,6 +44,7 @@\n resource_group:\n description:\n - The resource group to search for the desired load balancer\n+ required: true",
"line": null,
"original_line": 47,
"original_start_line": null,
"path": "lib/ansible/modules/cloud/azure/azure_rm_l... | ae414e45b8be04b2a302bbb1e721c98a89c354f8 | diff --git a/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py b/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py
index 8eb43542731e69..8b2ebebd856684 100755
--- a/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py
+++ b/lib/ansible/modules/cloud/azure/azure_rm_loadbalancer.py
@@ -610,6 +610,7 @@ d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-39853@eac31c7 | ansible/ansible | Python | 39,853 | icinga2_feature: fix module in check_mode | ##### SUMMARY
Fixes: #39830
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/modules/monitoring/icinga2_feature.py
test/units/modules/monitoring/test_icinga2_feature.py
##### ANSIBLE VERSION
<!--- Paste verbatim output from "... | 2018-05-08T10:14:11Z | Module `icinga2_feature` broken in `check_mode`
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
icinga2_feature
##### ANSIBLE VERSION
```
ansible 2.4.4.0
config file = /home/ansible/ansible/ansible.cfg
configured module search path = [u'/home/ansible/.ansible/plugins/modules', u'/usr/share/ansible/p... | Files identified in the description:
* [lib/ansible/modules/monitoring/icinga2_feature.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/monitoring/icinga2_feature.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nicinga2_feature\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.4.4.0\r\n config file = /home/ansible/ansible/ansible.cfg\r\n configured module search path = [u'/home/ansible/.ansible/plugins/modules', u'/usr/share/ansible/plugins/mo... | a5b808511395487f2c9679c11c27bdb1250c08d0 | {
"head_commit": "eac31c71874874c7beb22e2ffabf99c90f131028",
"head_commit_message": "icinga2_feature: fix module in check_mode\n\nFixes: #39830\n\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>",
"patch_to_review": "diff --git a/lib/ansible/modules/monitoring/icinga2_feature.py b/lib/ansible/modules/monito... | [
{
"diff_hunk": "@@ -21,49 +25,57 @@\n \n short_description: Manage Icinga2 feature\n description:\n- - Enable or disable an Icinga2 feature\n+ - This module can be used to enable or disable an Icinga2 feature.\n version_added: \"2.3\"\n author: \"Loic Blot (@nerzhul)\"\n options:\n name:\n- des... | 3ab5235f5f377ea4e45f6f6dcb0da2c288ff97da | diff --git a/lib/ansible/modules/monitoring/icinga2_feature.py b/lib/ansible/modules/monitoring/icinga2_feature.py
index c85af1b1088071..aad8f00ebaef92 100644
--- a/lib/ansible/modules/monitoring/icinga2_feature.py
+++ b/lib/ansible/modules/monitoring/icinga2_feature.py
@@ -1,18 +1,22 @@
#!/usr/bin/python
# -*- codin... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
beetbox__beets-3226@b08db06 | beetbox/beets | Python | 3,226 | Add loadext plugin | This is a rough draft at the moment of what a `loadext` plugin could look like for loading SQLite extensions. This plugin can be used to fix #3160 by allowing users to load the ICU plugin like so;
```
loadext:
- libicu
```
Note that this will require the user to compile their own copy of `ext/icu` from SQLit... | 2019-04-20T00:54:19Z | String queries should be case-insensitive even for non-ASCII characters
### Problem
When searching for metadata written in English or, in other words, in latin script, `beet ls` performs case-insensitive search, which is very nice. With non-latin scripts (I've checked with cyrillic, since it is the only one in which... | Sounds good! See also #2626 for some prior discussion.
I think the the solutions has two parts: first, the user of beets should have the ICU extension for SQLite on their machine (at least for Linux systems, where system SQLite libraries are usually used). This seems to be quite obscure, unfortunately - it seems that t... | [
{
"body": "### Problem\r\n\r\nWhen searching for metadata written in English or, in other words, in latin script, `beet ls` performs case-insensitive search, which is very nice. With non-latin scripts (I've checked with cyrillic, since it is the only one in which I have tracks and which has the case concept), ... | 063e4f259bf5a9ab089acd348b3c8f88fea29731 | {
"head_commit": "b08db06c05435e23734d316cff8cd4778264426f",
"head_commit_message": "Add load_extension method for loading SQLite extensions",
"patch_to_review": "diff --git a/beets/dbcore/db.py b/beets/dbcore/db.py\nindex 43c0445727..97a4a7ce31 100755\n--- a/beets/dbcore/db.py\n+++ b/beets/dbcore/db.py\n@@ -850,... | [
{
"diff_hunk": "@@ -0,0 +1,53 @@\n+Load Extension Plugin\n+=====================\n+\n+Beets uses an SQLite database to store and query library information, which\n+has support for extensions to extend its functionality.\n+\n+One of the primary uses of this within beets is with the `\"ICU\" extension`_,\n+which ... | f5f9aed641eff8702d6b72323b1680a6140650a1 | diff --git a/beets/dbcore/db.py b/beets/dbcore/db.py
index 43c0445727..97a4a7ce31 100755
--- a/beets/dbcore/db.py
+++ b/beets/dbcore/db.py
@@ -850,16 +850,21 @@ class Database(object):
"""A container for Model objects that wraps an SQLite database as
the backend.
"""
+
_models = ()
"""The Model... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-39673@f4280f5 | ansible/ansible | Python | 39,673 | Handling of configurations blocks with end-* at the end of the block | ##### SUMMARY
Fixes #39351
Few commands like route-policy and prefix-set have end-policy/end-set at the end of the block
e.g.
prefix-set ebpg_filter
192.168.0.0/16 ge 17 le 30
end-set
here current parser logic sets parent for line '192.168.0.0/16 ge 17 le 30' as 'prefix-set ebpg_filter'. It
also marks ... | 2018-05-03T12:33:36Z | iosxr_config crash on NCS5508 6.2.3
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these html comments.
... | Files identified in the description:
* [lib/ansible/modules/network/iosxr/iosxr_config.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/iosxr/iosxr_config.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 1885883a8809de2e4416e159b3bb18aa20f2c91e | {
"head_commit": "f4280f5014d83573875019c65eec4793bcf8a273",
"head_commit_message": "fix trailing parents not included in difference",
"patch_to_review": "diff --git a/lib/ansible/module_utils/network/common/config.py b/lib/ansible/module_utils/network/common/config.py\nindex 23b4df6a85ff1b..09e912203496b7 100644... | [
{
"diff_hunk": "@@ -290,6 +290,9 @@ def _diff_line(self, other):\n for item in self.items:\n if item not in other:\n updates.append(item)\n+ # special trailing parents need to be included in diff\n+ elif item.line == 'end-policy' or item.line == 'end-set... | 3d6ebb6b184735cfdefc5d74fa358cc78a6d3695 | diff --git a/lib/ansible/modules/network/iosxr/iosxr_config.py b/lib/ansible/modules/network/iosxr/iosxr_config.py
index 6f05c4c2232132..9cdea3083c7dd8 100644
--- a/lib/ansible/modules/network/iosxr/iosxr_config.py
+++ b/lib/ansible/modules/network/iosxr/iosxr_config.py
@@ -176,6 +176,8 @@
type: string
sample: /p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-39642@6b16187 | ansible/ansible | Python | 39,642 | Fix for nxos_snmp_host issues | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
fixes #39641
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.-->
##### ISSUE TYPE
<!--- Pick one below and... | 2018-05-02T21:51:12Z | nxos_snmp_host issues
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these html comments.
Otherwise it m... | Files identified in the description:
* [lib/ansible/modules/network/nxos/nxos_snmp_host.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_snmp_host.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | b6aa1320333366fafa3cdebbc838a9a682838fe3 | {
"head_commit": "6b1618747552cb21e3f7e1933373d5001aaec670",
"head_commit_message": "fix shippable",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_snmp_host.py b/lib/ansible/modules/network/nxos/nxos_snmp_host.py\nindex a87b52bb4210b1..652a498a4825da 100644\n--- a/lib/ansible/modules/netw... | [
{
"diff_hunk": "@@ -1197,6 +1197,7 @@ lib/ansible/modules/network/nxos/nxos_pim_interface.py E326\n lib/ansible/modules/network/nxos/nxos_pim_rp_address.py E326\n lib/ansible/modules/network/nxos/nxos_reboot.py E325\n lib/ansible/modules/network/nxos/nxos_smu.py E324\n+lib/ansible/modules/network/nxos/nxos_snmp... | c9387104f2dc7f6314b75fc991f3cd98919a63db | diff --git a/lib/ansible/modules/network/nxos/nxos_snmp_host.py b/lib/ansible/modules/network/nxos/nxos_snmp_host.py
index a87b52bb4210b1..acbbd65088b532 100644
--- a/lib/ansible/modules/network/nxos/nxos_snmp_host.py
+++ b/lib/ansible/modules/network/nxos/nxos_snmp_host.py
@@ -42,9 +42,8 @@
required: true
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
beetbox__beets-3043@760bdd5 | beetbox/beets | Python | 3,043 | Make `%aunique` work with `-f/--format` options. | This should fix #3042. Let's see if Travis gives the thumbs up... | 2018-09-27T09:28:47Z | %aunique fails when listing albums
### Problem
```
$ beet ls -a -f '$albumartist - $album%aunique{}'
Weezer - Make Believe<no such field 'album_id'>
Weezer - Maladroit<no such field 'album_id'>
Weezer - Pinkerton<no such field 'album_id'>
Weezer - Raditude<no such field 'album_id'>
Weezer - Weezer<no such fiel... | Sounds great! This seems like a nice, straightforward addition. | [
{
"body": "### Problem\r\n\r\n```\r\n$ beet ls -a -f '$albumartist - $album%aunique{}'\r\nWeezer - Make Believe<no such field 'album_id'>\r\nWeezer - Maladroit<no such field 'album_id'>\r\nWeezer - Pinkerton<no such field 'album_id'>\r\nWeezer - Raditude<no such field 'album_id'>\r\nWeezer - Weezer<no such fiel... | 3b78d933cf46d5cad8f90ea6cdf38ada9e10846f | {
"head_commit": "760bdd54204230f8ccc2e5d1434d52699d600bad",
"head_commit_message": "Add a reference to the bug.",
"patch_to_review": "diff --git a/beets/library.py b/beets/library.py\nindex d0571ed3a3..c911bbaa51 100644\n--- a/beets/library.py\n+++ b/beets/library.py\n@@ -1395,6 +1395,8 @@ def get_album(self, it... | [
{
"diff_hunk": "@@ -1395,6 +1395,8 @@ def get_album(self, item_or_id):\n \"\"\"\n if isinstance(item_or_id, int):\n album_id = item_or_id\n+ elif isinstance(item_or_id, Album):\n+ album_id = item_or_id.id",
"line": null,
"original_line": 1399,
"original_... | b347908af7182368694a778505f40bd892ec4616 | diff --git a/beets/library.py b/beets/library.py
index d0571ed3a3..bbb6452fe3 100644
--- a/beets/library.py
+++ b/beets/library.py
@@ -1506,9 +1506,16 @@ def tmpl_aunique(self, keys=None, disam=None, bracket=None):
# Fast paths: no album, no item or library, or memoized value.
if not self.item or not ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-38957@e495ee3 | ansible/ansible | Python | 38,957 | Add retry to ec2_metadata_facts query | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
<!--- If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.-->
In the fetch step for the EC2 metadata, add a retry in ca... | 2018-04-18T15:28:17Z | ec2_metadata_facts returns keyError
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
ec2_metadata_facts
##### ANSIBLE VERSION
```
ansible 2.5.0
config file = /home/jwitkowski/throtle-ansible/ansible.cfg
configured module search path = [u'/home/jwitkowski/.ansible/plugins/modules', u'/usr/share/ansibl... | Files identified in the description:
* [lib/ansible/modules/cloud/amazon/ec2_metadata_facts.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/ec2_metadata_facts.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot ... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nec2_metadata_facts\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.5.0\r\n config file = /home/jwitkowski/throtle-ansible/ansible.cfg\r\n configured module search path = [u'/home/jwitkowski/.ansible/plugins/modules', u'/usr/share/ans... | a833281e228a5038f8c57bd67055e3c619ce1ce5 | {
"head_commit": "e495ee342e80e22fe7d9cac4949d0b038166ad1d",
"head_commit_message": "Add retry to ec2_metadata_facts query",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/ec2_metadata_facts.py b/lib/ansible/modules/cloud/amazon/ec2_metadata_facts.py\nindex 4594058d9d8a1d..02c9600b98a13e 100644... | [
{
"diff_hunk": "@@ -445,7 +446,16 @@ def __init__(self, module, ec2_metadata_uri=None, ec2_sshdata_uri=None, ec2_user\n self._prefix = 'ansible_ec2_%s'\n \n def _fetch(self, url):\n- (response, info) = fetch_url(self.module, url, force=True)\n+ response, info = fetch_url(self.module, u... | 42a743b6f99414c5b3e21344d4f71e59cd65901f | diff --git a/lib/ansible/modules/cloud/amazon/ec2_metadata_facts.py b/lib/ansible/modules/cloud/amazon/ec2_metadata_facts.py
index 4594058d9d8a1d..d2ae6deb5119e3 100644
--- a/lib/ansible/modules/cloud/amazon/ec2_metadata_facts.py
+++ b/lib/ansible/modules/cloud/amazon/ec2_metadata_facts.py
@@ -420,6 +420,7 @@
import j... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-38752@4e92fb0 | ansible/ansible | Python | 38,752 | fix nxos_igmp_interface issues | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #38750 and #38753
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
##### ISSUE TYPE
<!--- Pick ... | 2018-04-13T16:33:00Z | nxos_igmp_interface issues
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
Always add information AFTER of these html comments.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bug Report
##... | Files identified in the description:
* [lib/ansible/modules/network/nxos/nxos_igmp_interface.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_igmp_interface.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bo... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\nAlways add information AFTER of these html comments.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Repo... | 53a3b8b602610dbf4428ea532a097dc467fcf181 | {
"head_commit": "4e92fb05fd69b1c4060047e9e23fae371da32162",
"head_commit_message": "add an example for oif_ps",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex 9673479ffb9526..d17786d20d8930 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -10,6 +10,9 @@ Ansible Changes By Release\n ### Maj... | [
{
"diff_hunk": "@@ -442,12 +457,12 @@ def get_igmp_interface_defaults():\n return default\n \n \n-def config_default_igmp_interface(existing, delta, found_both, found_prefix):\n+def config_default_igmp_interface(existing, delta):\n commands = []\n proposed = get_igmp_interface_defaults()\n delta... | f7e332240058598c249baac7b124699609b93788 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9673479ffb9526..2ec384455c7ace 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,8 @@ Ansible Changes By Release
### Major Changes
### Deprecations (to be removed in 2.10)
+* In the `nxos_igmp_interface` module, `oif_prefix` and `oif_source` properties are depr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-38643@7d9f7e8 | ansible/ansible | Python | 38,643 | Fixes some NIC problems: create without nsg, support loadbalancer | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #37917
Fixes #37734
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
##### ISSUE TYPE
<!--- ... | 2018-04-12T00:51:27Z | Add network interface to Load Balancer Backend pool in azure_rm_networkinterface
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
azure_rm_networkinterface
##### ANSIBLE VERSION
```
ansible --version
ansible 2.4.3.0
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/home/dg... | Files identified in the description:
* [lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/azure/azure_rm_networkinterface.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!com... | [
{
"body": "##### ISSUE TYPE\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\nazure_rm_networkinterface\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible --version\r\nansible 2.4.3.0\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search path = [u'/home/dgermain/.ansible/plugins/modules', u'/usr... | d1cd6ee56d492deef40f6f2f178832a1815730a5 | {
"head_commit": "7d9f7e8f8a2e5f92855b622ed93ea1d254e6fec0",
"head_commit_message": "add sample",
"patch_to_review": "diff --git a/lib/ansible/module_utils/azure_rm_common.py b/lib/ansible/module_utils/azure_rm_common.py\nindex c9b058412d1fbe..cc959af5df6f62 100644\n--- a/lib/ansible/module_utils/azure_rm_common.... | [
{
"diff_hunk": "@@ -122,19 +164,26 @@\n public_ip_allocation_method: Static\n - name: ipconfig1\n public_ip_name: testnic003\n+ load_balancer_backend_address_pools:\n+ - \"{{ lb.state.backend_address_pools[0].id }}\"\n+ - name: backendaddrpool1\n+ ... | 38c3634e9344d79b4acbb1a738af86abd2c63f08 | diff --git a/lib/ansible/module_utils/azure_rm_common.py b/lib/ansible/module_utils/azure_rm_common.py
index c9b058412d1fbe..cc959af5df6f62 100644
--- a/lib/ansible/module_utils/azure_rm_common.py
+++ b/lib/ansible/module_utils/azure_rm_common.py
@@ -128,7 +128,7 @@
from enum import Enum
from msrestazure.azur... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-37751@5259abf | ansible/ansible | Python | 37,751 | apt: mark installed packages manual | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes https://github.com/ansible/ansible/issues/28907
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
... | 2018-03-21T20:25:24Z | apt module does not mark installed packages as manually installed.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
apt
##### ANSIBLE VERSION
```
$ ansible --version
ansible 2.2.1.0
config file =
configured module search path = Default w/o overrides
$ ansible-playbook --version
ansible-playbook 2... | cc @mgwilliams
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
I have the same problem with ansible 2.4 on debian 9. Every package should be set to manually installed. This works for packages that are installed via ansible that weren't installed... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\napt\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n$ ansible --version\r\nansible 2.2.1.0\r\n config file = \r\n configured module search path = Default w/o overrides\r\n$ ansible-playbook --version\r\nansible-playbook 2.2.1.0\r\n config fil... | 8c819dd9cb5e97e62aba3623a7dc416017f862b4 | {
"head_commit": "5259abf103c39370f6f13943335144b891ed28ee",
"head_commit_message": "apt: mark installed packages manual",
"patch_to_review": "diff --git a/lib/ansible/modules/packaging/os/apt.py b/lib/ansible/modules/packaging/os/apt.py\nindex 7452dd6e7849da..80274180360fb6 100644\n--- a/lib/ansible/modules/pack... | [
{
"diff_hunk": "@@ -545,9 +547,22 @@ def install(m, pkgspec, cache, upgrade=False, default_release=None,\n if rc:\n status = False\n data = dict(msg=\"'%s' failed: %s\" % (cmd, err), stdout=out, stderr=err, rc=rc)\n- return (status, data)\n else:\n- return (True... | 529972d568213b49ea8e6ead110de90725750cfc | diff --git a/lib/ansible/modules/packaging/os/apt.py b/lib/ansible/modules/packaging/os/apt.py
index 7452dd6e7849da..93972ce048165d 100644
--- a/lib/ansible/modules/packaging/os/apt.py
+++ b/lib/ansible/modules/packaging/os/apt.py
@@ -275,6 +275,7 @@
APTITUDE_ZERO = "\n0 packages upgraded, 0 newly installed"
APT_LIST... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-37570@9785d6e | ansible/ansible | Python | 37,570 | aci_l3out: Add initial ACI l3Out implementation | ##### SUMMARY
Implementation of ACI L3Out module
Tested on 3.1(1i)
This fixes #37457
##### ISSUE TYPE
- New Module Pull Request
##### COMPONENT NAME
aci_l3out
##### ANSIBLE VERSION
```
ansible 2.4.3.0
config file = None
configured module search path = ['/Users/rdavyden/.ansible/plugins/modul... | 2018-03-18T10:53:22Z | Need module for L3Out configuration (basic + adding external EPGs)
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Feature Idea
##### COMPON... | Files identified in the description:
* [lib/ansible/modules/network/aci/aci_aep.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/aci/aci_aep.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here fo... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Feature Idea\r\n\r\n\r\n##### COMPONENT NAME\r\n<!---\r\naci_aep... | d30554bc90f36d7f7835bd21fe5c5b86169b5432 | {
"head_commit": "9785d6e1d33daa93fbb637cbc59b0e6c66328e09",
"head_commit_message": "fix sanity for version_added = 2.6",
"patch_to_review": "diff --git a/lib/ansible/modules/network/aci/aci_l3out.py b/lib/ansible/modules/network/aci/aci_l3out.py\nnew file mode 100644\nindex 00000000000000..488f6667a7085d\n--- /d... | [
{
"diff_hunk": "@@ -0,0 +1,314 @@\n+#!/usr/bin/python\n+# -*- coding: utf-8 -*-\n+\n+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\n+\n+from __future__ import absolute_import, division, print_function\n+__metaclass__ = type\n+\n+ANSIBLE_METADATA = {'metadata_versio... | f5db9aebd4514fd324dbf50171a365b6b9449ca7 | diff --git a/lib/ansible/modules/network/aci/aci_l3out.py b/lib/ansible/modules/network/aci/aci_l3out.py
new file mode 100644
index 00000000000000..d3146e855e60b1
--- /dev/null
+++ b/lib/ansible/modules/network/aci/aci_l3out.py
@@ -0,0 +1,331 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+
+# GNU General Public Licens... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-36996@4b45ffc | ansible/ansible | Python | 36,996 | Add function for initializing modules and providers | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #36994
Added function for force initializing modules and providers
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
th... | 2018-03-05T10:08:57Z | Missing force_init function in module
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bug Report
##### COMPONENT NAME
<!---
Name of the modu... | Files identified in the description:
* [lib/ansible/modules/cloud/misc/terraform.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/misc/terraform.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here ... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!---\r\nName of the m... | 4021194532dde444e34e8a33f254d91ef4e25be3 | {
"head_commit": "4b45ffcd9924f3f6c31d42fc313fcba36cc66b97",
"head_commit_message": "Remove Terraform error from `ignore.txt`",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/misc/terraform.py b/lib/ansible/modules/cloud/misc/terraform.py\nindex dd0fcdd33e2815..5a03ae3fece312 100644\n--- a/lib/ansible... | [
{
"diff_hunk": "@@ -209,6 +218,8 @@ def main():\n else:\n command = [module.get_bin_path('terraform')]\n \n+ init_plugins(command[0], project_path)",
"line": null,
"original_line": 221,
"original_start_line": null,
"path": "lib/ansible/modules/cloud/misc/terraform.py",
"start_... | 0f2e693901a862f2ae1210470d0585a87b9d78b5 | diff --git a/lib/ansible/modules/cloud/misc/terraform.py b/lib/ansible/modules/cloud/misc/terraform.py
index dd0fcdd33e2815..802f7f2a8b4485 100644
--- a/lib/ansible/modules/cloud/misc/terraform.py
+++ b/lib/ansible/modules/cloud/misc/terraform.py
@@ -79,8 +79,9 @@
- To avoid duplicating infra, if a state file ca... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-36719@610c325 | ansible/ansible | Python | 36,719 | timezone module: allow suse linux as target | ##### SUMMARY
SUSE Linux uses `/etc/sysconfig/clock` for timezone config like CentOS do, but it's format is differnt: the key is `TIMEZONE` rather than `ZONE`.
To make this module work for SUSE, I added a `if` statement to decide appropriate key.
Note: this is reported in and will fixes #36237
Oh, and actua... | 2018-02-26T09:56:13Z | module timezone doesnt work with SLES11SP4
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
timezone module
##### ANSIBLE VERSION
```
ansible 2.4.3.0
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']... | Files identified in the description:
* [lib/ansible/modules/system/timezone.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/timezone.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot he... | [
{
"body": "##### ISSUE TYPE\r\n\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n\r\ntimezone module\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```\r\nansible 2.4.3.0\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules... | 54e9096950084be2a2e1b3c0dbd447a1a881f31e | {
"head_commit": "610c32508616dc2a2171acbd1e3a2d889e9c672c",
"head_commit_message": "timezone module: allow suse linux as target",
"patch_to_review": "diff --git a/lib/ansible/modules/system/timezone.py b/lib/ansible/modules/system/timezone.py\nindex 315bc516814c5d..07ed59c44b2fa2 100644\n--- a/lib/ansible/module... | [
{
"diff_hunk": "@@ -353,8 +353,20 @@ def __init__(self, module):\n # self.allow_no_file['name'] = False <- this is default behavior\n self.conf_files['name'] = '/etc/sysconfig/clock'\n self.conf_files['hwclock'] = '/etc/sysconfig/clock'\n- self.regexps['name'] = ... | 0d5f2accbcdb48cf22f071236f7ad17d9c25cd0e | diff --git a/lib/ansible/modules/system/timezone.py b/lib/ansible/modules/system/timezone.py
index 315bc516814c5d..f7d6ea555f8890 100644
--- a/lib/ansible/modules/system/timezone.py
+++ b/lib/ansible/modules/system/timezone.py
@@ -344,7 +344,7 @@ def __init__(self, module):
self.regexps['name'] = re.compil... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-36879@64c7fb2 | ansible/ansible | Python | 36,879 | Add variables and variable_file in terraform module | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #36837
Added variables and variable_file options for validate command.
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what... | 2018-02-28T18:08:08Z | Terraform module doesn't use variables dictionary
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
- terraform
##### ANSIBLE VERSION
```
ansible 2.5.0b1
```
##### CONFIGURATION
Just main.yml
##### OS / ENVIRONMENT
WSL, Ubuntu 16.04.3 LTS
##### SUMMARY
I want to try terraform module from ansibl... | Files identified in the description:
* [lib/ansible/modules/cloud/misc/terraform.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/misc/terraform.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here ... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n- terraform\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.5.0b1\r\n```\r\n\r\n##### CONFIGURATION\r\nJust main.yml\r\n\r\n##### OS / ENVIRONMENT\r\nWSL, Ubuntu 16.04.3 LTS\r\n\r\n##### SUMMARY\r\nI want to try terraform module from a... | 629278464f56f435629098a425edd850ad115b11 | {
"head_commit": "64c7fb26a25b39f04c87bb53b0d5be863cb8066a",
"head_commit_message": "Fixes #36837\n\nAdded terraform variables for validate command",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/misc/terraform.py b/lib/ansible/modules/cloud/misc/terraform.py\nindex cfc26dfd18d761..3ccfac6cb5698d 100... | [
{
"diff_hunk": "@@ -209,7 +209,16 @@ def main():\n else:\n command = [module.get_bin_path('terraform')]\n \n- preflight_validation(command[0], project_path)\n+ variables_args = []\n+ for k, v in variables.items():\n+ variables_args.extend([\n+ '-var',\n+ '{0}={1... | f1a979e27b15d6e6a1f6b9ebd8ea83ebd486bf61 | diff --git a/lib/ansible/modules/cloud/misc/terraform.py b/lib/ansible/modules/cloud/misc/terraform.py
index cfc26dfd18d761..dd0fcdd33e2815 100644
--- a/lib/ansible/modules/cloud/misc/terraform.py
+++ b/lib/ansible/modules/cloud/misc/terraform.py
@@ -136,13 +136,13 @@
module = None
-def preflight_validation(bin_pa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-36494@c514aeb | ansible/ansible | Python | 36,494 | nxos_vrf fix | Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes https://github.com/ansible/ansible/issues/36461
Also the module doesn't work when existing definition/property of vrf is attempted to be modified. The PR fixes that.
... | 2018-02-21T09:54:15Z | nxos_vrf error when using vni option
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bug Report
##### COMPONENT NAME
<!---
Name of the modul... | Files identified in the description:
* [lib/ansible/modules/network/nxos/nxos_vrf.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_vrf.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click her... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!---\r\nName of the m... | 52f20574729147e78f488ab8cf35621ca6907869 | {
"head_commit": "c514aeb7c898b7cb37e6e830e4a309c0aa79eaab",
"head_commit_message": "nxos_vrf fix\n\nSigned-off-by: Trishna Guha <trishnaguha17@gmail.com>",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_vrf.py b/lib/ansible/modules/network/nxos/nxos_vrf.py\nindex 291819453b6ab2..504a84c47... | [
{
"diff_hunk": "@@ -242,21 +242,21 @@ def map_obj_to_commands(updates, module):\n elif state == 'present':\n if not obj_in_have:\n commands.append('vrf context {0}'.format(name))\n- if rd and rd != '':\n- commands.append('rd {0}'.format(rd))\... | 00b40af43b27b076cf1d74c51b4f8e0b34f4aa8b | diff --git a/lib/ansible/modules/network/nxos/nxos_vrf.py b/lib/ansible/modules/network/nxos/nxos_vrf.py
index 291819453b6ab2..59a458e2e64e68 100644
--- a/lib/ansible/modules/network/nxos/nxos_vrf.py
+++ b/lib/ansible/modules/network/nxos/nxos_vrf.py
@@ -224,12 +224,12 @@ def map_obj_to_commands(updates, module):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-36147@483c4bd | ansible/ansible | Python | 36,147 | fix nxos_bgp_af issues | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes #36146
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
##### ISSUE TYPE
<!--- Pick one below a... | 2018-02-13T23:22:16Z | nxos_bgp_af issues
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bug Report
##### COMPONENT NAME
<!---
Name of the module, plugin, task or... | Files identified in the description:
* [lib/ansible/modules/network/nxos/nxos_bgp_af.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_bgp_af.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[cli... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!---\r\nName of the m... | dc902a50223e334cc87a1014534f1fb13eb58fc1 | {
"head_commit": "483c4bd21fe0ae3cb68d815fc68305fa428fbfa1",
"head_commit_message": "shippable fix",
"patch_to_review": "diff --git a/lib/ansible/modules/network/nxos/nxos_bgp_af.py b/lib/ansible/modules/network/nxos/nxos_bgp_af.py\nindex 1327fe5f4d5ee7..a19c1d1a7444c7 100644\n--- a/lib/ansible/modules/network/nx... | [
{
"diff_hunk": "@@ -141,6 +323,12 @@\n provider: \"{{ connection }}\"\n ignore_errors: yes\n \n+ # Some platforms will timeout if the\n+ # 'no nv overlay evpn' command is sent\n+ # too quickly followin bgp disablement.",
"line": null,
"original_line": 328,
"original_start_line": null,
... | cdfb6d1e59445335490d7aba6f08c46eb2830406 | diff --git a/lib/ansible/modules/network/nxos/nxos_bgp_af.py b/lib/ansible/modules/network/nxos/nxos_bgp_af.py
index 1327fe5f4d5ee7..d055274a443a97 100644
--- a/lib/ansible/modules/network/nxos/nxos_bgp_af.py
+++ b/lib/ansible/modules/network/nxos/nxos_bgp_af.py
@@ -337,42 +337,15 @@ def get_value(arg, config, module):... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-36128@0eaa42e | ansible/ansible | Python | 36,128 | facts: fix device uuid's on el6 | ##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Fixes https://github.com/ansible/ansible/issues/36077
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
commit message and your description; but you should still explain what
the change does.
-->
... | 2018-02-13T16:41:58Z | RHEL 6 Mount Facts Display "N/A" for UUID
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and devel branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bug Report
##### COMPONENT NAME
setup
##### ANSI... | Files identified in the description:
* [lib/ansible/modules/system/setup.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/setup.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](ht... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and devel branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nsetup\r\n\r\n##### ANS... | 8743b20c8ea9ebce21ad7f1b7c613c9cc521dbd5 | {
"head_commit": "0eaa42eb3979a1dc4378f479a4152e2f4c6b7873",
"head_commit_message": "Fix unit tests",
"patch_to_review": "diff --git a/lib/ansible/module_utils/facts/hardware/linux.py b/lib/ansible/module_utils/facts/hardware/linux.py\nindex e781419d98fdfd..274d3f623ae6a3 100644\n--- a/lib/ansible/module_utils/fa... | [
{
"diff_hunk": "@@ -372,6 +372,25 @@ def _lsblk_uuid(self):\n \n return uuids\n \n+ def _udevadm_uuid(self, device):\n+ # fallback for versions of lsblk <= 2.23 that don't have --paths, see _run_lsblk() above\n+ uuid = 'N/A'\n+\n+ udevadm_path = self.module.get_bin_path('udevadm'... | 3de1488b559535fa31f751cb00a91c3181117c39 | diff --git a/lib/ansible/module_utils/facts/hardware/linux.py b/lib/ansible/module_utils/facts/hardware/linux.py
index e781419d98fdfd..b758d11bf72062 100644
--- a/lib/ansible/module_utils/facts/hardware/linux.py
+++ b/lib/ansible/module_utils/facts/hardware/linux.py
@@ -372,6 +372,31 @@ def _lsblk_uuid(self):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-35830@23fb873 | ansible/ansible | Python | 35,830 | openssl_csr: Improved documentation on subject_alt_name possible values | ##### SUMMARY
openssl_csr: Improved documentation on subject_alt_name possible values
##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
* openssl_csr
##### ANSIBLE VERSION
* devel
##### ADDITIONAL INFORMATION
* N/A
Fixes: https://github.com/ansible/ansible/issues/35550 | 2018-02-07T10:09:29Z | OpenSSL.crypto.Error: [('X509 V3 routines', 'v2i_GENERAL_NAME_ex', 'missing value'), ('X509 V3 routines', 'X509V3_EXT_nconf', 'error in extension')]
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
openssl_csr
##### ANSIBLE VERSION
Latest unstable version:
```
ansible 2.5.0 (devel 9001a8794f) last upda... | Files identified in the description:
* [lib/ansible/modules/crypto/openssl_csr.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/crypto/openssl_csr.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for ... | [
{
"body": "##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\n\r\nopenssl_csr\r\n\r\n##### ANSIBLE VERSION\r\n\r\nLatest unstable version:\r\n```\r\nansible 2.5.0 (devel 9001a8794f) last updated 2018/01/31 14:40:56 (GMT +200)\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search... | e2c0865800141bece7984764c1fe0776a0450976 | {
"head_commit": "23fb873c117fea8da30979793bfcbbecd00f799f",
"head_commit_message": "openssl_csr: Improved documentation on subject_alt_name possible values",
"patch_to_review": "diff --git a/lib/ansible/modules/crypto/openssl_csr.py b/lib/ansible/modules/crypto/openssl_csr.py\nindex 3a37080a098d22..8aa0e75d587bd... | [
{
"diff_hunk": "@@ -107,6 +107,8 @@\n description:\n - SAN extension to attach to the certificate signing request\n - This can either be a 'comma separated string' or a YAML list.\n+ - Values should be prefixed by their options. (ie. email, URI, DNS, RID, IP, dirName, ... | c44ff4c8ad899a1ac2c0ad65bd7d2cce5fc4a6af | diff --git a/lib/ansible/modules/crypto/openssl_csr.py b/lib/ansible/modules/crypto/openssl_csr.py
index 3a37080a098d22..ecb7b52d2a3012 100644
--- a/lib/ansible/modules/crypto/openssl_csr.py
+++ b/lib/ansible/modules/crypto/openssl_csr.py
@@ -107,6 +107,9 @@
description:
- SAN extension to attach ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.