instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
getsentry__sentry-73262@76304d0 | getsentry/sentry | Python | 73,262 | ref(settings-metrics): Update descriptions | ### Goal
Update copies present on the metric's settings page.
**Before:**
**After:**
 Page Description: Metrics are numerical values extracted from span attributes that can help you track anything about your environment over time. To learn more, read the docs.
- Table Title: Span-based Metrics
- Button Label: "Add Extraction Rule" > "Add Metric"
- ... | [
{
"body": "- Metrics (Settings) Page Description: Metrics are numerical values extracted from span attributes that can help you track anything about your environment over time. To learn more, read the docs.\r\n- Table Title: Span-based Metrics\r\n- Button Label: \"Add Extraction Rule\" > \"Add Metric\"\r\n- Old... | 0f3ec5f3fb24f594fab43b55201dfdff907e04e9 | {
"head_commit": "76304d0ac9e679bd2d2f4f14e43c530cab0a26f6",
"head_commit_message": "ref(settings-metrics): Update descriptions",
"patch_to_review": "diff --git a/static/app/routes.tsx b/static/app/routes.tsx\nindex 46161b95054328..5f76ad686dc2cf 100644\n--- a/static/app/routes.tsx\n+++ b/static/app/routes.tsx\n@... | [
{
"diff_hunk": "@@ -156,9 +161,9 @@ export function MetricsExtractionRuleForm({isEdit, project, onSubmit, ...props}:\n }}\n />\n <FormField\n- label={t('Filters')}\n+ label={t('Queries')}\n help={t(\n- 'Define filters for spans. The ... | 591fcd878a40517844691aefe91f4bb98c2a2c7e | diff --git a/static/app/routes.tsx b/static/app/routes.tsx
index 46161b95054328..5f76ad686dc2cf 100644
--- a/static/app/routes.tsx
+++ b/static/app/routes.tsx
@@ -532,12 +532,13 @@ function buildRoutes() {
component={make(() => import('sentry/views/settings/projectPerformance'))}
/>
<Route path="... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
getsentry__sentry-73239@4060eaa | getsentry/sentry | Python | 73,239 | feat(<DraggableTabs>): Add new draggable tabs component to storybook | **Note:** This PR merges into the `msun/draggableTabsComponent`, not `master`. The `msun/draggableTabsComponent` branch contains the `components/draggableTabs` directory with with the files from `components/tabs` (except for the test file). This is so that the diff for this PR is easier to read and more intuitive – it ... | 2024-06-24T22:32:00Z | Custom Views: MVP for dnd tabs component
Drag and drop tabs must be implemented to support custom views. This ticket tracks the progress of creating the basic drag and drop tab component that will eventually be used to for custom views.
MVP features include:
- [ ] Unstyled tabs that can be dragged with the cursor... | [
{
"body": "Drag and drop tabs must be implemented to support custom views. This ticket tracks the progress of creating the basic drag and drop tab component that will eventually be used to for custom views. \r\n\r\nMVP features include:\r\n- [ ] Unstyled tabs that can be dragged with the cursor \r\n- [ ] Unstyl... | d05c55014f628ef263ff1fcce28cf9512d3e5efc | {
"head_commit": "4060eaac3942393cfa053f1998e56424e0e4a401",
"head_commit_message": "Make drop indicator a vertical line",
"patch_to_review": "diff --git a/static/app/components/draggableTabs/draggableTab.tsx b/static/app/components/draggableTabs/draggableTab.tsx\nindex 9f5cd4bfdf1c7b..640c8c5fcb7a28 100644\n--- ... | [
{
"diff_hunk": "@@ -73,28 +112,80 @@ function BaseTab(\n [to, orientation]\n );\n \n+ const {dropProps, isDropTarget} = useDroppableItem(\n+ {\n+ target: {type: 'item', key: item.key, dropPosition: 'on'},\n+ },\n+ dropState,\n+ ref\n+ );\n+\n+ function Draggable({children}) {\n+ con... | 112c5c1e339b89165e52f295a64a2c936e62c378 | diff --git a/static/app/components/draggableTabs/draggableTab.tsx b/static/app/components/draggableTabs/draggableTab.tsx
index 9f5cd4bfdf1c7b..b536be5f145662 100644
--- a/static/app/components/draggableTabs/draggableTab.tsx
+++ b/static/app/components/draggableTabs/draggableTab.tsx
@@ -1,19 +1,24 @@
-import {forwardRef... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getmoto__moto-8365@776b2c0 | getmoto/moto | Python | 8,365 | KMS: get_public_key now works with alias (name and arn) | Fixes #8364
The error provided was coming from the function `_validate_cmk_id()` which obviously raises an error when used with an alias, and if I understood correctly especially since `describe_key()` is using ` any_id_to_key_id()`.
Tests are passing and none seem to be broken. | 2024-12-05T09:33:28Z | KMS get_public_key fails with alias
Hi,
The following test, trying to use `get_public_key` with an alias is failing:
```python
import boto3
from moto import mock_aws
@mock_aws
def test():
kms = boto3.client("kms", region_name="eu-west-1")
key = kms.create_key(
KeyUsage="SIGN_VERIFY",
... | [
{
"body": "Hi, \r\n\r\nThe following test, trying to use `get_public_key` with an alias is failing:\r\n\r\n```python\r\nimport boto3\r\nfrom moto import mock_aws\r\n\r\n@mock_aws\r\ndef test():\r\n kms = boto3.client(\"kms\", region_name=\"eu-west-1\")\r\n key = kms.create_key(\r\n KeyUsage=\"SIGN_... | 549d4e2c5c565dadfdcf86d435aecf451c253cf9 | {
"head_commit": "776b2c0914a03bafd6e7d92143ba4252bba042cf",
"head_commit_message": "fix(kms): get_public_key now works with alias (name and arn)\n\nSigned-off-by: Mehdi Bechiri <cebidhem@pm.me>",
"patch_to_review": "diff --git a/moto/kms/responses.py b/moto/kms/responses.py\nindex b68ec20b08c7..7f5b9b674004 1006... | [
{
"diff_hunk": "@@ -1692,6 +1692,36 @@ def test_get_public_key():\n assert \"EncryptionAlgorithms\" not in public_key_response\n \n \n+@mock_aws\n+def test_get_public_key_with_alias():\n+ client = boto3.client(\"kms\", region_name=\"eu-west-1\")\n+ key = client.create_key(KeyUsage=\"SIGN_VERIFY\", Key... | 8501a0b07f758e3daecd9019398a5a14e7d74c48 | diff --git a/moto/kms/responses.py b/moto/kms/responses.py
index b68ec20b08c7..7f5b9b674004 100644
--- a/moto/kms/responses.py
+++ b/moto/kms/responses.py
@@ -707,7 +707,6 @@ def get_public_key(self) -> str:
key_id = self._get_param("KeyId")
self._validate_key_id(key_id)
- self._validate_cmk_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-71985@9da5547 | getsentry/sentry | Python | 71,985 | fix(dashboards): hide add widget card behind feature flag | - closes: #71641
| 2024-06-04T09:32:30Z | Remove "add widget" on team plans
Custom dashboards are a Business plan feature only. On Free you don’t see any dashboards, but on Team you have a default dashboard visible. The “Add Widget” card currently appears on Team plans, but results in errors.
Example: [redacted as requested by customer] | [
{
"body": "Custom dashboards are a Business plan feature only. On Free you don’t see any dashboards, but on Team you have a default dashboard visible. The “Add Widget” card currently appears on Team plans, but results in errors.\r\n\r\nExample: [redacted as requested by customer]",
"number": 71641,
"tit... | 31febcb0621e24bc75fd71aeb5d17fd912ef432d | {
"head_commit": "9da5547ebf3fcb5331b1cbf0c070324dbcbe8674",
"head_commit_message": "fix(dashboards): hide add widget card behind feature flag",
"patch_to_review": "diff --git a/static/app/views/dashboards/addWidget.tsx b/static/app/views/dashboards/addWidget.tsx\nindex 9c6b68fc4ebc91..a8217e0d13e9eb 100644\n--- ... | [
{
"diff_hunk": "@@ -43,44 +44,46 @@ function AddWidget({onAddWidget}: Props) {\n const organization = useOrganization();\n \n return (\n- <WidgetWrapper\n- key=\"add\"\n- ref={setNodeRef}\n- displayType={DisplayType.BIG_NUMBER}\n- layoutId={ADD_WIDGET_BUTTON_DRAG_ID}\n- style={{o... | 164b477a681b9ca6514e75b92f85b2300b3ba27c | diff --git a/static/app/views/dashboards/addWidget.tsx b/static/app/views/dashboards/addWidget.tsx
index 9c6b68fc4ebc91..095ac521e78c42 100644
--- a/static/app/views/dashboards/addWidget.tsx
+++ b/static/app/views/dashboards/addWidget.tsx
@@ -2,6 +2,7 @@ import {useCallback, useMemo} from 'react';
import {useSortable}... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-71931@3610f33 | getsentry/sentry | Python | 71,931 | ref(custom-views): Update tasks to delete custom views upon org or member deletion | This PR updates the Organization deletion task to make custom views a child of organization, thus deleting any custom views in the org upon org deletion. It also adds a new task for Organization members, and makes custom views a child of org members as well. | 2024-06-03T19:01:28Z | Custom Views: Delete member views upon removal
Since we have changed the database schema of a view to use `organization_id` and `user_id` instead of `org_member_id`, removing a member of an organization will not cascade delete their views, so we will need to do it manually. Eventually we may need to update this logic t... | [
{
"body": "Since we have changed the database schema of a view to use `organization_id` and `user_id` instead of `org_member_id`, removing a member of an organization will not cascade delete their views, so we will need to do it manually. Eventually we may need to update this logic to only delete non-organizati... | bf7e284a410b2e0832130ca1a18ea4e6cb05a36d | {
"head_commit": "3610f33b557a6a67a01af9992fabe76ff6cbd3d9",
"head_commit_message": "Added to org deletion tests, created new organizationmember deletion test",
"patch_to_review": "diff --git a/src/sentry/deletions/__init__.py b/src/sentry/deletions/__init__.py\nindex 9148230eeeee16..07fee3073f7d53 100644\n--- a/... | [
{
"diff_hunk": "@@ -0,0 +1,10 @@\n+from sentry.models.groupsearchview import GroupSearchView\n+\n+from ..base import ModelDeletionTask, ModelRelation\n+\n+\n+class OrganizationMemberDeletionTask(ModelDeletionTask):\n+ def get_child_relations(self, instance):\n+ relations = [ModelRelation(GroupSearchVi... | 6f532fab59eb8be32b827168a45229574e0a799d | diff --git a/src/sentry/deletions/__init__.py b/src/sentry/deletions/__init__.py
index 9148230eeeee16..07fee3073f7d53 100644
--- a/src/sentry/deletions/__init__.py
+++ b/src/sentry/deletions/__init__.py
@@ -139,6 +139,7 @@ def load_defaults():
default_manager.register(
models.OrganizationIntegration, defa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-71942@a4f03f3 | getsentry/sentry | Python | 71,942 | feat(custom-views): add custom views get endpoint | This endpoint creates the `GET` `organizations/<org_id_or_slug>/group-search-views/` Endpoint along with some tests. This endpoint will be responsible for fetching a user's custom views within an organization.
⚠️ This PR is dependent on #71731 being ~~merged~~ run in production, and this branch will need to be reb... | 2024-06-03T20:42:57Z | Custom Views: Create GET Endpoint
Create `GET` `<ORG_ID_OR_SLUG>/user-views/` endpoint
This endpoint will be responsible for retrieving an org member's custom tabs from the database. This endpoint will also need to be responsible for returning the default views if an org member has no custom views. It will also ne... | [
{
"body": "Create `GET` `<ORG_ID_OR_SLUG>/user-views/` endpoint \r\n\r\nThis endpoint will be responsible for retrieving an org member's custom tabs from the database. This endpoint will also need to be responsible for returning the default views if an org member has no custom views. It will also need to be gat... | 3f9d8460d6cfbdb862426abdbe32e138dc2ea0af | {
"head_commit": "a4f03f3251a177ce649379ae9c9f8e1d89c68dde",
"head_commit_message": "Return default view if user has none",
"patch_to_review": "diff --git a/src/sentry/api/serializers/models/groupsearchview.py b/src/sentry/api/serializers/models/groupsearchview.py\nnew file mode 100644\nindex 00000000000000..ccec... | [
{
"diff_hunk": "@@ -0,0 +1,68 @@\n+from rest_framework import status\n+from rest_framework.request import Request\n+from rest_framework.response import Response\n+\n+from sentry import features\n+from sentry.api.api_owners import ApiOwner\n+from sentry.api.api_publish_status import ApiPublishStatus\n+from sentr... | 94d7a723bf03e4d842525cea58b58f8aaca2528b | diff --git a/src/sentry/api/serializers/models/groupsearchview.py b/src/sentry/api/serializers/models/groupsearchview.py
new file mode 100644
index 00000000000000..ff97c11e9ac784
--- /dev/null
+++ b/src/sentry/api/serializers/models/groupsearchview.py
@@ -0,0 +1,29 @@
+from typing import TypedDict
+
+from sentry.api.se... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-71731@d3e9289 | getsentry/sentry | Python | 71,731 | migration(custom-views): Backfill groupsearchviews with pinned/default views from savedsearches | Implements #71593
This PR migrates any users' default searches to the new `groupsearchview` table. This is necessary because users' default searches will eventually become the default view in the custom views project.
The logic is as follows:
1. Get all saved searches where `visibility="owner_pinned"`. These ... | 2024-05-29T22:55:04Z | Custom Views: Backfill custom views with previously pinned tabs as defaults
We will need to migrate existing pinned searches from the `sentry_savedsearches` table (where `visibility="owner_pinned"`) as default views (`position=0`) in the new custom views table.
This means that for every entry in `sentry_savedsearch... | [
{
"body": "We will need to migrate existing pinned searches from the `sentry_savedsearches` table (where `visibility=\"owner_pinned\"`) as default views (`position=0`) in the new custom views table. \r\n\r\nThis means that for every entry in `sentry_savedsearches` where `visibility=\"owner_pinned\"`, we will ne... | 50db0f3f394faff44597318eddb80f2a8b644ecb | {
"head_commit": "d3e92893e14f249c22460bfce2a331a97a0fbc84",
"head_commit_message": "Resolve migration conflict",
"patch_to_review": "diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt\nindex 878fce2ddb68e3..d4edd94ce44073 100644\n--- a/migrations_lockfile.txt\n+++ b/migrations_lockfile.txt\n@@ -9,5 +... | [
{
"diff_hunk": "@@ -0,0 +1,68 @@\n+# Generated by Django 5.0.6 on 2024-06-03 17:27\n+\n+from django.db import migrations\n+from django.db.backends.base.schema import BaseDatabaseSchemaEditor\n+from django.db.migrations.state import StateApps\n+\n+from sentry.models.savedsearch import SortOptions",
"line": n... | e69c0a063ea47a205d5a35bc40f9dfaad912058c | diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt
index 878fce2ddb68e3..d4edd94ce44073 100644
--- a/migrations_lockfile.txt
+++ b/migrations_lockfile.txt
@@ -9,5 +9,5 @@ feedback: 0004_index_together
hybridcloud: 0016_add_control_cacheversion
nodestore: 0002_nodestore_no_dictfield
replays: 0004_index_to... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-71711@d1652c4 | getsentry/sentry | Python | 71,711 | ref(pinned-searches): Save new/updated default searches to new `groupsearchview` table | This PR augments the `.../pinned-searches` endpoint. This endpoint previously saved a new pinned (default) search to only the `sentry_savedsearches` table with `visibility="owner_pinned"`. This PR adds new logic to also save a new or updated default to the upcoming custom views table (`sentry_issueuserviews`). This is ... | 2024-05-29T20:41:13Z | Custom Views: Augment the `organizations/.../pinned-searches/` endpoint to save to/update new custom views database
We will need to update the `organizations/.../pinned-searches/` endpoint to also save and update entries in the new database for custom views. This is because pinned searches are being replaced by custom ... | [
{
"body": "We will need to update the `organizations/.../pinned-searches/` endpoint to also save and update entries in the new database for custom views. This is because pinned searches are being replaced by custom views, so before we migrate existing pinned searches to the custom views database, we will need t... | baaf8456ddb2402c5a898511777ed5cc45e79a01 | {
"head_commit": "d1652c43676873f507af91b3c2f198bf6e2a58f4",
"head_commit_message": "Update tests",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/organization_pinned_searches.py b/src/sentry/api/endpoints/organization_pinned_searches.py\nindex 637d6f9273e909..11d2b981579349 100644\n--- a/src/sentry/ap... | [
{
"diff_hunk": "@@ -52,6 +53,17 @@ def put(self, request: Request, organization) -> Response:\n visibility=Visibility.OWNER_PINNED,\n values={\"query\": result[\"query\"], \"sort\": result[\"sort\"]},\n )\n+\n+ GroupSearchView.objects.create_or_update(\n+ organi... | 621206aee5c3a46b3fc7efee6a88751cc4f88df3 | diff --git a/src/sentry/api/endpoints/organization_pinned_searches.py b/src/sentry/api/endpoints/organization_pinned_searches.py
index 637d6f9273e909..1e4e0a3b6712bd 100644
--- a/src/sentry/api/endpoints/organization_pinned_searches.py
+++ b/src/sentry/api/endpoints/organization_pinned_searches.py
@@ -7,6 +7,7 @@
from... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getmoto__moto-7424@2eb5ecb | getmoto/moto | Python | 7,424 | EC2: SG rule tagging | Closes https://github.com/getmoto/moto/issues/7408 | 2024-03-05T07:30:02Z | EC2: security group rule bad behaviours
First Issue:
I have create an sg rule like that:
```
response = ec2_client.authorize_security_group_ingress(
GroupId=group_id,
IpPermissions=[
{
'IpProtocol': rule['ip_protocol'],
'... | @bblommers I can take a look | [
{
"body": "First Issue:\r\n\r\nI have create an sg rule like that:\r\n\r\n```\r\nresponse = ec2_client.authorize_security_group_ingress(\r\n GroupId=group_id,\r\n IpPermissions=[\r\n {\r\n 'IpProtocol': rule['ip_protocol'],\r\n 'F... | 274fdae6420b06507769a05c74f53f2c9527dff1 | {
"head_commit": "2eb5ecb1e4f3b3defe84ea1ef299d36a01b3fc92",
"head_commit_message": "chore: run ci",
"patch_to_review": "diff --git a/moto/ec2/models/core.py b/moto/ec2/models/core.py\nindex 0ecc94dcf930..581e44dd3fcd 100644\n--- a/moto/ec2/models/core.py\n+++ b/moto/ec2/models/core.py\n@@ -41,3 +41,10 @@ def get... | [
{
"diff_hunk": "@@ -121,22 +131,23 @@ def _process_rules_from_querystring(self) -> Any:\n prefix_list_ids,\n ) = parse_sg_attributes_from_dict(ip_permission)\n \n- yield (\n- group_name_or_id,\n- ip_protocol,\n- from_port,\n- ... | c2392ef535614cb31bc646a002d6713f14cd8759 | diff --git a/moto/ec2/models/core.py b/moto/ec2/models/core.py
index 0ecc94dcf930..581e44dd3fcd 100644
--- a/moto/ec2/models/core.py
+++ b/moto/ec2/models/core.py
@@ -41,3 +41,10 @@ def get_filter_value(
return value
raise FilterNotImplementedError(filter_name, method_name)
+
+ def match_tags... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-7156@ef1e427 | getmoto/moto | Python | 7,156 | LakeFormation: extend permissions catalog functionality | Implementation for issue https://github.com/getmoto/moto/issues/7150 | 2023-12-22T14:29:20Z | lake formation does not correctly handle permissions on already known principal-resource-pairs
## Missing feature
When granting permissions on the same principal-resource-pairs that are already used in lake formation the expected behavior is that when listing the respective permissions a single `PrincipalResourcePermi... | I am already working on a fix for this - will open a PR soon. | [
{
"body": "## Missing feature\r\nWhen granting permissions on the same principal-resource-pairs that are already used in lake formation the expected behavior is that when listing the respective permissions a single `PrincipalResourcePermissions` with all respective permissions is returned independent of when an... | f730d592299c50cb71cba4f5c9d91c512d4cc738 | {
"head_commit": "ef1e42755fddb299f11b7147fb503336642287b0",
"head_commit_message": "extend permissions catalog functionality to more accurately mimic aws behaviour",
"patch_to_review": "diff --git a/moto/lakeformation/models.py b/moto/lakeformation/models.py\nindex 1c8c79893e90..f2aaea170c9e 100644\n--- a/moto/l... | [
{
"diff_hunk": "@@ -27,6 +30,113 @@ def to_dict(self) -> Dict[str, Any]:\n }\n \n \n+class Permission:\n+ def __init__(\n+ self,\n+ principal: Dict[str, str],\n+ resource: Dict[str, Any],\n+ permissions: List[str],\n+ permissions_with_grant_options: List[str],\n+ ... | 52dd40ab7a577397d41a914db55710586d32498a | diff --git a/moto/lakeformation/models.py b/moto/lakeformation/models.py
index 1c8c79893e90..6ea737812040 100644
--- a/moto/lakeformation/models.py
+++ b/moto/lakeformation/models.py
@@ -1,6 +1,9 @@
+from __future__ import annotations
+
+import json
from collections import defaultdict
from enum import Enum
-from typi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-7143@ddb3300 | getmoto/moto | Python | 7,143 | Speed up exception handling by re-using Environments | Address https://github.com/getmoto/moto/issues/7142
By taking advantage of the caching logic in [Environment](https://jinja.palletsprojects.com/en/3.1.x/api/#jinja2.Environment) | 2023-12-19T00:56:36Z | Slow s3 exception raising due to usage pattern of jinja2
```python
import time
from moto.s3.exceptions import MissingBucket
start = time.time()
for _ in range(1000):
try:
raise MissingBucket(bucket="foo")
except MissingBucket:
pass
print(round(time.time() - start, 2))
```
with... | [
{
"body": "```python\r\nimport time\r\n\r\nfrom moto.s3.exceptions import MissingBucket\r\n\r\nstart = time.time()\r\nfor _ in range(1000):\r\n try:\r\n raise MissingBucket(bucket=\"foo\")\r\n except MissingBucket:\r\n pass\r\n\r\nprint(round(time.time() - start, 2))\r\n```\r\n\r\nwith moto... | 34a0c20d036240a3bdf5ec03221bc629427e2315 | {
"head_commit": "ddb3300ff3535a61d02371dc04087755d1d86bb4",
"head_commit_message": "Speed up exception handling by re-using Environments\n\nAddress https://github.com/getmoto/moto/issues/7142",
"patch_to_review": "diff --git a/moto/cloudfront/exceptions.py b/moto/cloudfront/exceptions.py\nindex 584d999e4d7a..65c... | [
{
"diff_hunk": "@@ -63,8 +64,7 @@ def __init__(\n self.message = message\n \n if template in self.templates.keys():\n- env = Environment(loader=DictLoader(self.templates))\n- self.description: str = env.get_template(template).render(\n+ self.description: str = se... | 97db050f03758b0512bcea058d67ade470b07390 | diff --git a/moto/cloudfront/exceptions.py b/moto/cloudfront/exceptions.py
index 584d999e4d7a..b8e7f634d92d 100644
--- a/moto/cloudfront/exceptions.py
+++ b/moto/cloudfront/exceptions.py
@@ -15,10 +15,11 @@
class CloudFrontException(RESTError):
code = 400
+ extended_templates = {"cferror": EXCEPTION_RESPONSE... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
getmoto__moto-7317@00baa90 | getmoto/moto | Python | 7,317 | Support tags in Glue create_database | This PR resolves #7316.
I believe that some other taggable Glue resources are affected by the same problem. So if this PR goes into the right direction, I might add tagging-support for those resources as well. | 2024-02-06T11:56:34Z | glue.create_database does not create tags
The AWS API allows to specify resource tags when creating a Glue database. However, moto will ignore those tags and not tag the database. As a demonstration, the following test fails:
```
from moto import mock_aws
import boto3
@mock_aws
def test_glue():
database_nam... | [
{
"body": "The AWS API allows to specify resource tags when creating a Glue database. However, moto will ignore those tags and not tag the database. As a demonstration, the following test fails:\r\n```\r\nfrom moto import mock_aws\r\nimport boto3\r\n\r\n@mock_aws\r\ndef test_glue():\r\n database_name = \"tes... | 652eabda5170e772742d4a68234a26fa8765e6a9 | {
"head_commit": "00baa90a9d07fedf1f8bcc1bbf5dc228b6887ecf",
"head_commit_message": "Support tags in Glue create_database",
"patch_to_review": "diff --git a/moto/glue/models.py b/moto/glue/models.py\nindex 4a8c076c1b09..ba864ec1c984 100644\n--- a/moto/glue/models.py\n+++ b/moto/glue/models.py\n@@ -123,7 +123,10 @... | [
{
"diff_hunk": "@@ -132,6 +135,11 @@ def create_database(\n database_name, database_input, catalog_id=self.account_id\n )\n self.databases[database_name] = database\n+ if tags:",
"line": null,
"original_line": 138,
"original_start_line": null,
"path": "moto/glu... | 73629be1feca71ff84e05b01ab0492d69aa7ae08 | diff --git a/moto/glue/models.py b/moto/glue/models.py
index 4a8c076c1b09..362726a4b9e5 100644
--- a/moto/glue/models.py
+++ b/moto/glue/models.py
@@ -123,7 +123,10 @@ def default_vpc_endpoint_service(
)
def create_database(
- self, database_name: str, database_input: Dict[str, Any]
+ self... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getmoto__moto-6926@85480ae | getmoto/moto | Python | 6,926 | S3: s3 access point reads / writes reach destination bucket | Resolves https://github.com/getmoto/moto/issues/6912 | 2023-10-18T09:00:45Z | s3.get_object() raises NoSuchBucket when using mocked Access Point alias or ARN
I'm trying to test an application that uses several S3 Access Points to access a common bucket and I want to verify it can do so correctly. I'm mocking both `s3control` and `s3` in my test configuration and using an S3ControlClient to creat... | Hi @mrburrito, this doesn't seem to be supported yet in Moto - marking it as an enhancement.
@bblommers let me take a look | [
{
"body": "I'm trying to test an application that uses several S3 Access Points to access a common bucket and I want to verify it can do so correctly. I'm mocking both `s3control` and `s3` in my test configuration and using an S3ControlClient to create the access points for my bucket.\r\n\r\nWhen I try to read ... | a1f261189e7c1520bc00099886e20a1c4f2870db | {
"head_commit": "85480aeded0847f54e3ce3ec36b67d4d9d19ccba",
"head_commit_message": "feat: access points read and write thru access points",
"patch_to_review": "diff --git a/moto/s3/models.py b/moto/s3/models.py\nindex 05899720501f..15a161d185be 100644\n--- a/moto/s3/models.py\n+++ b/moto/s3/models.py\n@@ -1762,6... | [
{
"diff_hunk": "@@ -1762,6 +1762,20 @@ def get_bucket(self, bucket_name: str) -> FakeBucket:\n account_id = s3_backends.bucket_accounts[bucket_name]\n return s3_backends[account_id][\"global\"].get_bucket(bucket_name)\n \n+ # when access point is used the url that's passed is of f... | 7f68699f9e27e81bd9c0e0a5978672f962605357 | diff --git a/moto/s3/responses.py b/moto/s3/responses.py
index d8f0d286c58d..907bdce54d89 100644
--- a/moto/s3/responses.py
+++ b/moto/s3/responses.py
@@ -173,6 +173,10 @@ def get_safe_path(self, part: str) -> str:
else:
return unquote(part)
+ @property
+ def is_access_point(self) -> bool:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-6289@3ff5d65 | getmoto/moto | Python | 6,289 | ECS: allow ecs service to transition to arbitrary running task count | Closes https://github.com/getmoto/moto/issues/6283 | 2023-05-06T19:27:54Z | ECS services never seem to transition into running state
Using Moto 4.1.8. When creating a service in a cluster, I can't seem to figure out how, or if, there's any way to get the services to transition to a running state. I have the following code for fixtures:
```python
@pytest.fixture
def ecs(credentials):
wi... | @davido-nw with ☝️ PR you will be able to use a new env var `MOTO_ECS_SERVICE_RUNNING` to set a number of running tasks, after the service is created. If you want to test the `runningCount` going up or down, then you will need to flip that env var accordingly.
The PR will need to be reviewed by a maintainer but the... | [
{
"body": "Using Moto 4.1.8. When creating a service in a cluster, I can't seem to figure out how, or if, there's any way to get the services to transition to a running state. I have the following code for fixtures:\r\n```python\r\n@pytest.fixture\r\ndef ecs(credentials):\r\n with moto.mock_ecs():\r\n ... | 763b582cf23bd916200388d7a9071e9b48c49e14 | {
"head_commit": "3ff5d65aa09a86c02ec44b32ac0700a2fed4a53b",
"head_commit_message": "tests: skip new test, the required env var would break other tests",
"patch_to_review": "diff --git a/moto/ecs/models.py b/moto/ecs/models.py\nindex b89bd8a7c483..aada41a0dd37 100644\n--- a/moto/ecs/models.py\n+++ b/moto/ecs/mode... | [
{
"diff_hunk": "@@ -507,14 +516,31 @@ def __init__(\n self.cluster_arn = cluster.arn\n self.name = service_name\n self.status = \"ACTIVE\"\n- self.running_count = 0\n self.task_definition = task_definition.arn if task_definition else None\n self.desired_count = des... | bee519493180d2964a224f26b842e18686b9bd99 | diff --git a/moto/ecs/models.py b/moto/ecs/models.py
index b89bd8a7c483..6e230c9b9086 100644
--- a/moto/ecs/models.py
+++ b/moto/ecs/models.py
@@ -2,6 +2,7 @@
from copy import copy
from datetime import datetime, timezone
from typing import Any, Dict, Iterator, List, Optional, Tuple
+from os import getenv
from mot... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-77427@327c30a | home-assistant/core | Python | 77,427 | Add bluetooth api to get the count of connectable and non-connectable scanners | ~~TODO:~~
- [x] dev docs https://github.com/home-assistant/developers.home-assistant/pull/1452
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link ... | 2022-08-28T01:11:25Z | bluetooth.async_get_scanner() returns broken scanner (not None) if bluetooth integration discovered but not configured
### The problem
I am trying to adapt my custom integration with the new bluetooth component.
In the config_flow, I have a step to scan for available devices.
I was trying to ensure that if the b... | [bluetooth documentation](https://www.home-assistant.io/integrations/bluetooth)
[bluetooth source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/bluetooth)
<sub><sup>(message by IssueLinks)</sup></sub>
Hey there @bdraco, mind taking a look at this issue as it has been labeled with an integrat... | [
{
"body": "### The problem\r\n\r\nI am trying to adapt my custom integration with the new bluetooth component.\r\nIn the config_flow, I have a step to scan for available devices.\r\n\r\nI was trying to ensure that if the bluetooth integration is enabled, then my custom integration would use HAbleakscanner, but ... | 01c200e11d4609381cd124d06fc7d2c1390ec06c | {
"head_commit": "327c30ab8567f846f6f5b2a15bcade866a806e6a",
"head_commit_message": "Add bluetooth api to get the count of connectable and non-connectable scanners\n\ncloses #76281",
"patch_to_review": "diff --git a/homeassistant/components/bluetooth/__init__.py b/homeassistant/components/bluetooth/__init__.py\ni... | [
{
"diff_hunk": "@@ -153,6 +153,12 @@ def supports_passive_scan(self) -> bool:\n \"\"\"Return if passive scan is supported.\"\"\"\n return any(adapter[ADAPTER_PASSIVE_SCAN] for adapter in self._adapters.values())\n \n+ def async_scanner_count(self, connectable: bool = True) -> int:\n+ \... | 1e5de18ee5fb428578e0cf265e2c5ca1127ee3da | diff --git a/homeassistant/components/bluetooth/__init__.py b/homeassistant/components/bluetooth/__init__.py
index 632635f7dbcd42..8ba3a503a30257 100644
--- a/homeassistant/components/bluetooth/__init__.py
+++ b/homeassistant/components/bluetooth/__init__.py
@@ -60,6 +60,7 @@
"async_rediscover_address",
"asyn... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-6287@7f98a8a | getmoto/moto | Python | 6,287 | S3: Do not unquote the key two times on multipart upload complete | Current implementation unquotes key two times, firstly in `self.backend.put_object` and then in `self.backend.put_object_acl` -> `self.get_object`. To fix this issue I have exposed `key_is_clean` in `put_object_acl` and set it to `True`. | 2023-05-05T09:40:46Z | Motoserver multipart upload failure
There is the code I am running to save the file using multipart upload:
```
import boto3
from boto3.s3.transfer import TransferConfig
s3 = boto3.client('s3')
s3.create_bucket(Bucket='test')
s3.upload_fileobj(
io.BytesIO(b'123'),
'test',
'ns/id=A%20B/9d985da51... | [
{
"body": "There is the code I am running to save the file using multipart upload:\r\n\r\n```\r\nimport boto3\r\nfrom boto3.s3.transfer import TransferConfig\r\n\r\ns3 = boto3.client('s3')\r\ns3.create_bucket(Bucket='test')\r\ns3.upload_fileobj(\r\n io.BytesIO(b'123'),\r\n 'test',\r\n 'ns/id=A%20B/9d98... | 763b582cf23bd916200388d7a9071e9b48c49e14 | {
"head_commit": "7f98a8a09ac615fd00ae0fd20b700481afe93f3f",
"head_commit_message": "Do not unquote the key two times on multipart upload complete",
"patch_to_review": "diff --git a/moto/s3/models.py b/moto/s3/models.py\nindex e6365dabf46f..930d7625697e 100644\n--- a/moto/s3/models.py\n+++ b/moto/s3/models.py\n@@... | [
{
"diff_hunk": "@@ -148,6 +148,47 @@ def test_multipart_upload():\n response[\"Body\"].read().should.equal(part1 + part2)\n \n \n+@mock_s3\n+@reduced_min_part_size\n+def test_multipart_upload_with_encoded_char():",
"line": null,
"original_line": 153,
"original_start_line": null,
"path": "tes... | 9e4298a99c1e44e139a2082d45a860b90ab59321 | diff --git a/moto/s3/models.py b/moto/s3/models.py
index e6365dabf46f..930d7625697e 100644
--- a/moto/s3/models.py
+++ b/moto/s3/models.py
@@ -1888,9 +1888,13 @@ def put_object(
return new_key
def put_object_acl(
- self, bucket_name: str, key_name: str, acl: Optional[FakeAcl]
+ self,
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getmoto__moto-7406@26efd90 | getmoto/moto | Python | 7,406 | Feature: Route53Domains | Adding support for Route53Domains endpoints
This PR is a work in progress
| 2024-02-28T20:19:10Z | Feature Request: Route53Domains
Hello! I've recently started using Moto in a personal project of mine and it has really eased my development with AWS!
In my project I am using the Route53Domains service and was wondering if there are any plans on adding support for it? Would you be interested for me to try and open... | Hi @NeevCohen, welcome to Moto!
PR's are always welcome. We have some documentation here that should get you started:
http://docs.getmoto.org/en/latest/docs/contributing/index.html
Feel free to let us know if you run into any issues though.
Out of interest, which methods/features would you like to mock?
@bbl... | [
{
"body": "Hello! I've recently started using Moto in a personal project of mine and it has really eased my development with AWS! \r\n\r\nIn my project I am using the Route53Domains service and was wondering if there are any plans on adding support for it? Would you be interested for me to try and open a PR for... | 131b78c82c9f48159584babea7002664b25adc3d | {
"head_commit": "26efd90c7e34f78a7c4b41a2053fcc2fd2cfb52e",
"head_commit_message": "Apply formatting",
"patch_to_review": "diff --git a/moto/backend_index.py b/moto/backend_index.py\nindex c413f928852b..5e0d4455b81e 100644\n--- a/moto/backend_index.py\n+++ b/moto/backend_index.py\n@@ -142,6 +142,10 @@\n ... | [
{
"diff_hunk": "@@ -0,0 +1,1044 @@\n+import re\n+from datetime import datetime, timedelta, timezone\n+from ipaddress import ip_address\n+from typing import Dict, List\n+\n+from moto.core.common_models import BaseModel\n+from moto.moto_api._internal import MotoRandom",
"line": null,
"original_line": 7,
... | 3b09865f0cc1bbeaea97e23b177694a42509c48e | diff --git a/moto/backend_index.py b/moto/backend_index.py
index c413f928852b..5e0d4455b81e 100644
--- a/moto/backend_index.py
+++ b/moto/backend_index.py
@@ -142,6 +142,10 @@
"route53resolver",
re.compile("https?://route53resolver\\.(.+)\\.amazonaws\\.com"),
),
+ (
+ "route53domains",
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getmoto__moto-6184@0520326 | getmoto/moto | Python | 6,184 | SQS: Improve deduplication logic | Dedupe according to logic in https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_SendMessage.html
and
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/using-messagededuplicationid-property.html
Closes https://github.com/getmoto/moto/issues/1438 | 2023-04-07T15:12:56Z | Fifo messages aren't deduped
Anaconda-IPython
`sys.version[:5] == '2.7.6'`
`boto3.__version__ == '1.5.17'`
`moto.__version__ == (u'1.2.0',)`
## Reproduce
```python
import boto3
from moto import mock_sqs
@mock_sqs
def dedupe_fifo():
sqs = boto3.resource('sqs', region_name='us-west-2')
queue = sqs.... | Possibly related, when I retrieve messages from a mocked FIFO queue, the `MessageGroupId` is not present.
Thanks for opening. Marking this as a feature request.
Also encountered this so just wanted to +1
@bblommers let me take a look at this
nvm, looks like it's already been tackled https://github.com/getmoto/moto/blob... | [
{
"body": "Anaconda-IPython\r\n`sys.version[:5] == '2.7.6'`\r\n`boto3.__version__ == '1.5.17'`\r\n`moto.__version__ == (u'1.2.0',)`\r\n\r\n## Reproduce\r\n```python\r\nimport boto3\r\nfrom moto import mock_sqs\r\n\r\n@mock_sqs\r\ndef dedupe_fifo():\r\n sqs = boto3.resource('sqs', region_name='us-west-2')\r\n... | dc460a325839bc6797084a54afc297a2c9d87e63 | {
"head_commit": "0520326626ab796e0dd7953a0bf6ac85f96a6d8b",
"head_commit_message": "tests: fix stray test",
"patch_to_review": "diff --git a/moto/sqs/models.py b/moto/sqs/models.py\nindex ee93e1f48fb7..b7fa5c7eef4f 100644\n--- a/moto/sqs/models.py\n+++ b/moto/sqs/models.py\n@@ -525,17 +525,22 @@ def messages(sel... | [
{
"diff_hunk": "@@ -758,6 +763,24 @@ def send_message(\n \n queue = self.get_queue(queue_name)\n \n+ if (",
"line": null,
"original_line": 766,
"original_start_line": null,
"path": "moto/sqs/models.py",
"start_line": null,
"text": "@user1:\nJust a nitpick - I think these t... | 3d56f0e960eb571f4beafd424433e0746e6b6ffa | diff --git a/moto/sqs/models.py b/moto/sqs/models.py
index ee93e1f48fb7..b4939e9d7c78 100644
--- a/moto/sqs/models.py
+++ b/moto/sqs/models.py
@@ -525,17 +525,22 @@ def messages(self):
]
def add_message(self, message):
- if (
- self.fifo_queue
- and self.attributes.get("Cont... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-6038@40d4417 | getmoto/moto | Python | 6,038 | fix:params not sorted properly when tags are present | Attempt to fix #6033
This is my first time trying to contribute, so please be indulgent :)
| 2023-03-08T19:14:09Z | Error with autoscaling group
Hello,
I use moto_server with command `moto_server -p4566`
When trying to create an autoscaling group with Terraform, I get the following trace error :
```
127.0.0.1 - - [08/Mar/2023 08:24:52] "POST / HTTP/1.1" 500 -
Error on request:
Traceback (most recent call last):
File "C... | Thanks for raising this and sharing the TF code @kevinvalleau - marking it as a bug.
The problem is related to the tags. When I don't provide any tags, it works.
I managed to investigate a little :
debug _get_params line 653 core/responses.py :
```
Here are the received params :
{}
odict_items([('Action', ['Cre... | [
{
"body": "Hello, \r\n\r\nI use moto_server with command `moto_server -p4566`\r\n\r\nWhen trying to create an autoscaling group with Terraform, I get the following trace error :\r\n```\r\n127.0.0.1 - - [08/Mar/2023 08:24:52] \"POST / HTTP/1.1\" 500 -\r\nError on request:\r\nTraceback (most recent call last):\r\... | 2b00b050de83917573f7fdabc54d99af8035ca90 | {
"head_commit": "40d4417c88e44d1fe3f98203adb3ee4859d75fbf",
"head_commit_message": "fix:params not sorted properly - reformatting core/utils.py",
"patch_to_review": "diff --git a/moto/core/responses.py b/moto/core/responses.py\nindex 04897ca858f7..8fc794261b3a 100644\n--- a/moto/core/responses.py\n+++ b/moto/cor... | [
{
"diff_hunk": "@@ -307,3 +307,15 @@ def extract_region_from_aws_authorization(string: str) -> Optional[str]:\n if region == auth:\n return None\n return region\n+\n+\n+def params_sort_function(item: tuple[str, Any]) -> tuple[str, Any]:",
"line": null,
"original_line": 312,
"original... | 4323ca3e3193f961b26c60840db203ae348ee66b | diff --git a/moto/core/responses.py b/moto/core/responses.py
index 04897ca858f7..8fc794261b3a 100644
--- a/moto/core/responses.py
+++ b/moto/core/responses.py
@@ -12,7 +12,11 @@
from moto import settings
from moto.core.common_types import TYPE_RESPONSE, TYPE_IF_NONE
from moto.core.exceptions import DryRunClientError... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-5607@39ae29a | getmoto/moto | Python | 5,607 | fix(describe_trails): trail not multiregion case | From https://github.com/spulec/moto/issues/5604 we have realised that there is a missing condition when listing the trails from `describe_trail`.
If we don't include the condition:
```
if trail.is_multi_region or trail.region_name == backend.region_name:
```
Single multiregion trails will be shown in another reg... | 2022-10-26T12:20:09Z | Cloudtrail describe_trails returning wrong info
Hi,
I'am trying to mock trail creation and describing those trails, and I realise that something is wrong when describing the trails.
When you create a single region trail for example with:
`aws cloudtrail create-trail --name "single-region-trail-test" --s3-bucket-... | Trying to debug launching the example script for the region `eu-west-3` it seems that when initialising that when the backends are being initialised here:
https://github.com/spulec/moto/blob/master/moto/cloudtrail/models.py#L320
It creates a single backend for each found trail and the passed region
![Screenshot... | [
{
"body": "Hi,\r\n\r\nI'am trying to mock trail creation and describing those trails, and I realise that something is wrong when describing the trails.\r\nWhen you create a single region trail for example with:\r\n\r\n`aws cloudtrail create-trail --name \"single-region-trail-test\" --s3-bucket-name \"test\" --n... | a49222fc15c9fe97d543183f961ffa45cbe8d95b | {
"head_commit": "39ae29af54d1593ee675c6dad8bffa59b5577c5e",
"head_commit_message": "fix(tests): describe_trail fixed tests",
"patch_to_review": "diff --git a/moto/cloudtrail/models.py b/moto/cloudtrail/models.py\nindex aa604f6e5702..7be9b3a42a04 100644\n--- a/moto/cloudtrail/models.py\n+++ b/moto/cloudtrail/mode... | [
{
"diff_hunk": "@@ -318,7 +318,12 @@ def describe_trails(self, include_shadow_trails):\n if include_shadow_trails:\n current_account = cloudtrail_backends[self.account_id]\n for backend in current_account.values():\n- all_trails.extend(backend.trails.values())\n+ ... | 807fb00008c703a752ee926454d833ef5a1ad66f | diff --git a/moto/cloudtrail/models.py b/moto/cloudtrail/models.py
index aa604f6e5702..ca7fe89161b2 100644
--- a/moto/cloudtrail/models.py
+++ b/moto/cloudtrail/models.py
@@ -318,7 +318,9 @@ def describe_trails(self, include_shadow_trails):
if include_shadow_trails:
current_account = cloudtrail_ba... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-5703@d62071e | getmoto/moto | Python | 5,703 | added code to resolve issue #5372 | Dear sir,
I have written code to resolve the issue number #5372. I have made following changes for the same:
1. models.py file (moto/moto/sqs/models.py):
Line number 47: Micro defined as MAXIMUM_MESSAGE_DELAY = 900
Line number 808: In send_message function, I have put condition to check if delay_seconds is g... | 2022-11-23T06:04:12Z | SQS allows sending of messages with delays of longer than 15 minutes
# Versions
`moto`: 3.1.16
`boto3`: 1.21.46
# Code
```
response = boto3.client('sqs').send_message_batch(
QueueUrl='the-queue-url,
Entries=[
{
'Id': '1'
'MessageBody': 'foo',
'DelaySeco... | Thanks for raising this @paulmdavies - marking it as an enhancement to add this validation.
I want to work on this issue. I found it interesting and I think I can fix this. It would be great if I get the approval from the owner.
PR's are always welcome, @RahiBhensdadia! There is a guide here with some tips that may be ... | [
{
"body": "# Versions\r\n\r\n`moto`: 3.1.16\r\n`boto3`: 1.21.46\r\n\r\n# Code\r\n```\r\nresponse = boto3.client('sqs').send_message_batch(\r\n QueueUrl='the-queue-url,\r\n Entries=[\r\n {\r\n 'Id': '1'\r\n 'MessageBody': 'foo',\r\n 'DelaySeconds': 180\r\n },\... | ff1f420689ba77a162a826e070a83604484add63 | {
"head_commit": "d62071e8ef0cdaf056f9c50b3f092f9026219421",
"head_commit_message": "added code to resolve issue #5372",
"patch_to_review": "diff --git a/moto/sqs/models.py b/moto/sqs/models.py\nindex 0d4f93cc14cc..dcdde561bd7f 100644\n--- a/moto/sqs/models.py\n+++ b/moto/sqs/models.py\n@@ -44,6 +44,8 @@\n MAXIMU... | [
{
"diff_hunk": "@@ -3115,3 +3115,44 @@ def test_message_has_windows_return():\n messages = queue.receive_messages()\n messages.should.have.length_of(1)\n messages[0].body.should.match(message)\n+\n+\n+@mock_sqs\n+def test_message_delay_is_more_than_15_minutes():\n+ client = boto3.client(\"sqs\", ... | 224ff2659e0741584149674e6032c3e0b0096841 | diff --git a/moto/sqs/models.py b/moto/sqs/models.py
index 0d4f93cc14cc..8f27193cba66 100644
--- a/moto/sqs/models.py
+++ b/moto/sqs/models.py
@@ -44,6 +44,8 @@
MAXIMUM_MESSAGE_SIZE_ATTR_LOWER_BOUND = 1024
MAXIMUM_MESSAGE_SIZE_ATTR_UPPER_BOUND = MAXIMUM_MESSAGE_LENGTH
+MAXIMUM_MESSAGE_DELAY = 900
+
TRANSPORT_TYPE_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-76231@91ca268 | home-assistant/core | Python | 76,231 | Fix Life360 recovery from server errors | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2022-08-04T15:05:21Z | Life360 Entities go unavailable until reload of integration
### The problem
I’m running 2022.7.7, but I’ve had this issue with all 2022.7 builds.
Periodically if the internet flakes out, or perhaps an issue with life360 cloud, the entities for my people goes unavailable and they show as away in HA. If I ‘reload’ th... | I still need to reproduce this behavior on a test system, but I believe what is happening is, after it is able to get good data from the server it still has the previous data, and since it is the same (in this particular case where the device probably isn't moving), it is not bothering to update the state. What it need... | [
{
"body": "### The problem\n\nI’m running 2022.7.7, but I’ve had this issue with all 2022.7 builds.\r\n\r\nPeriodically if the internet flakes out, or perhaps an issue with life360 cloud, the entities for my people goes unavailable and they show as away in HA. If I ‘reload’ the integration they immediately reco... | ff255feddae0879a923854ba91a25689f0461353 | {
"head_commit": "91ca2687c6805924ba8f74cd77137c60a7ddb1f3",
"head_commit_message": "Fix Life360 recovery from server errors",
"patch_to_review": "diff --git a/homeassistant/components/life360/device_tracker.py b/homeassistant/components/life360/device_tracker.py\nindex ebb179beba20fa..8228c2e7b108a0 100644\n--- ... | [
{
"diff_hunk": "@@ -120,16 +120,16 @@ def _options(self) -> Mapping[str, Any]:\n @callback\n def _handle_coordinator_update(self) -> None:\n \"\"\"Handle updated data from the coordinator.\"\"\"\n- # Get a shortcut to this member's data. Can't guarantee it's the same dict every\n- ... | 57c2108d4a478329e28b449deb6e732e476ea591 | diff --git a/homeassistant/components/life360/coordinator.py b/homeassistant/components/life360/coordinator.py
index 05eecd43cdc0c9..ed774bba8ca039 100644
--- a/homeassistant/components/life360/coordinator.py
+++ b/homeassistant/components/life360/coordinator.py
@@ -91,9 +91,11 @@ class Life360Data:
members: dict[... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-5575@de52d03 | getmoto/moto | Python | 5,575 | Initial implementation of list_invalidations() for cloudfront. | Fixes #5574 | 2022-10-17T17:18:09Z | Implement CloudFront list_invalidations
**How to reproduce the issue**
Call `list_invalidations()` on the `cloudfront` client.
**What I expected to happen**
Get a list of invalidations for the specified CloudFront distribution.
**What actually happens**
```moto/core/botocore_stubber.py:60: TypeError: can... | [
{
"body": "**How to reproduce the issue**\r\n\r\nCall `list_invalidations()` on the `cloudfront` client.\r\n\r\n**What I expected to happen**\r\n\r\nGet a list of invalidations for the specified CloudFront distribution.\r\n\r\n**What actually happens**\r\n\r\n```moto/core/botocore_stubber.py:60: TypeError: cann... | 43a3fecbd2db57bfa99e832aef30c5055b703040 | {
"head_commit": "de52d038c34cf7e6605620b92d67f1afb2b434d3",
"head_commit_message": "Initial implementation of list_invalidations() for cloudfront.",
"patch_to_review": "diff --git a/moto/cloudfront/models.py b/moto/cloudfront/models.py\nindex cd92eec1078b..dd2a805b6305 100644\n--- a/moto/cloudfront/models.py\n++... | [
{
"diff_hunk": "@@ -104,6 +106,17 @@ def create_invalidation(self):\n \n return 200, {\"Location\": invalidation.location}, response\n \n+ def list_invalidations(self):\n+ dist_id = self.path.split(\"/\")[-2]\n+ marker = None\n+ max_items = None\n+\n+ invalidations = self.... | c13ac4ef410a952b354066462638bb06e4fdf4fa | diff --git a/moto/cloudfront/models.py b/moto/cloudfront/models.py
index cd92eec1078b..9b8d13ab0a48 100644
--- a/moto/cloudfront/models.py
+++ b/moto/cloudfront/models.py
@@ -234,6 +234,7 @@ class CloudFrontBackend(BaseBackend):
def __init__(self, region_name, account_id):
super().__init__(region_name, ac... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-68689@ad53ad6 | getsentry/sentry | Python | 68,689 | fix(replays): default mask/block setting in project creation should be true | fixes https://github.com/getsentry/sentry/issues/68688
for project creation, pass in a default `replayOptions` param since one isn't set:
<img width="1266" alt="SCR-20240411-hwpk" src="https://github.com/getsentry/sentry/assets/56095982/e0272c8a-ad00-4a6c-84ad-c35baea3491a">
| 2024-04-11T12:27:27Z | default mask/block setting for replay in project creation should be true
Hey team, when we create a new JS project and are presented with the code to paste into our app, we have masking turned off for the replay integration. However, in the docs this option is set to true (and the default value for this option is true ... | [
{
"body": "Hey team, when we create a new JS project and are presented with the code to paste into our app, we have masking turned off for the replay integration. However, in the docs this option is set to true (and the default value for this option is true as well). We received feedback from a customer about t... | d7faf43d665a3b952f55af3a141ec95129b8280d | {
"head_commit": "ad53ad6d72f591d045a7eb4da918fcef83cc14ce",
"head_commit_message": "fix(replays): default mask/block setting in project creation should be true",
"patch_to_review": "diff --git a/static/app/gettingStartedDocs/javascript/javascript.tsx b/static/app/gettingStartedDocs/javascript/javascript.tsx\nind... | [
{
"diff_hunk": "@@ -46,7 +46,7 @@ ${getFeedbackConfigOptions(params.feedbackOptions)}}),`\n }${\n params.isReplaySelected\n ? `\n- Sentry.replayIntegration(${getReplayConfigOptions(params.replayOptions)}),`\n+ Sentry.replayIntegration(${getReplayConfigOptions(params.replayOptions ?? {b... | 180c4ab4d6ec568aa37b237590dc9edea7b209d8 | diff --git a/static/app/components/onboarding/gettingStartedDoc/onboardingLayout.tsx b/static/app/components/onboarding/gettingStartedDoc/onboardingLayout.tsx
index 14ea8b62637cfe..9e138d04334167 100644
--- a/static/app/components/onboarding/gettingStartedDoc/onboardingLayout.tsx
+++ b/static/app/components/onboarding/... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
getmoto__moto-5531@53b12df | getmoto/moto | Python | 5,531 | Prettify responses | Prettify responses from moto. I monkey patch jinja render to avoid adding the same piece of code manually in each place where template is rendered.
- [x] make monkey patch to prettify responses
- [x] add documentation
- [x] add test
Please note that AWS returns pretiffied responses
Solution to https://github... | 2022-10-04T16:49:38Z | Option for prettified responses
Moto is returning responses in form of single line xml strings. For debugging purposes it would be useful to have an option to have prettified responses.
Please note that when logging terraform logs for with TF_LOG=True and selected TF_LOG_PATH, AWS returns prettified responses. I di... | [
{
"body": "Moto is returning responses in form of single line xml strings. For debugging purposes it would be useful to have an option to have prettified responses. \r\n\r\nPlease note that when logging terraform logs for with TF_LOG=True and selected TF_LOG_PATH, AWS returns prettified responses. I did not inv... | 26412e1c3f640d7c000b5e264852c42c10241d43 | {
"head_commit": "53b12df85a4ea48cdd2ea0f1838e63473c56f9b0",
"head_commit_message": "Merge branch 'master' into prettify-responses",
"patch_to_review": "diff --git a/docs/docs/configuration/index.rst b/docs/docs/configuration/index.rst\nindex b98154f69103..c275b1875d23 100644\n--- a/docs/docs/configuration/index.... | [
{
"diff_hunk": "@@ -18,6 +18,7 @@\n from typing import Dict, List, Union, Any, Optional\n from urllib.parse import parse_qs, parse_qsl, urlparse\n from werkzeug.exceptions import HTTPException\n+import moto.prettify_jinja_render # noqa # pylint: disable=unused-import",
"line": null,
"original_line": 21... | 934210b843aa3a98e8039e859d738dc848f3ca6c | diff --git a/docs/docs/configuration/index.rst b/docs/docs/configuration/index.rst
index b98154f69103..fc9f5d04f7a0 100644
--- a/docs/docs/configuration/index.rst
+++ b/docs/docs/configuration/index.rst
@@ -12,6 +12,7 @@ Moto has a variety of ways to configure the mock behaviour.
environment_variables
recorder/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getmoto__moto-5480@5a7a099 | getmoto/moto | Python | 5,480 | Fix error listing tags for rds db subnet group | Suggested solution to https://github.com/spulec/moto/issues/5479 | 2022-09-16T12:15:11Z | When trying to create the subnet group get error: Error listing tags for RDS DB Subnet Group
**Repro steps:**
1. Start moto server.
2. Prepare terraform file that will create rds db subnet group.
3. Run terraform init; terraform apply
**Description:**
When attempting to create a subnet group terraform errors o... | PR with proposed solution https://github.com/spulec/moto/pull/5480 | [
{
"body": "**Repro steps:**\r\n\r\n1. Start moto server.\r\n2. Prepare terraform file that will create rds db subnet group.\r\n3. Run terraform init; terraform apply\r\n\r\n**Description:**\r\nWhen attempting to create a subnet group terraform errors out with error: \"Error listing tags for RDS DB Subnet Group:... | cba304afcb11af91576ceb70e4e20ec30741d552 | {
"head_commit": "5a7a0996aa475bdb6747c06fce4e07db82b0447d",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/moto/rds/models.py b/moto/rds/models.py\nindex 7ce5ef605f85..938770f962a5 100644\n--- a/moto/rds/models.py\n+++ b/moto/rds/models.py\n@@ -1145,13 +1145,19 @@ def delete(self, account_i... | [
{
"diff_hunk": "@@ -1485,8 +1492,12 @@ def authorize_security_group(self, security_group_name, cidr_ip):\n security_group.authorize_cidr(cidr_ip)\n return security_group\n \n- def create_subnet_group(self, subnet_name, description, subnets, tags):\n- subnet_group = SubnetGroup(subnet_n... | af33d730eff0c3108607370289baea3eb998db5e | diff --git a/moto/rds/models.py b/moto/rds/models.py
index 7ce5ef605f85..7683407a61f5 100644
--- a/moto/rds/models.py
+++ b/moto/rds/models.py
@@ -1145,13 +1145,19 @@ def delete(self, account_id, region_name):
class SubnetGroup(CloudFormationModel):
- def __init__(self, subnet_name, description, subnets, tags):... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-5521@4e28b40 | getmoto/moto | Python | 5,521 | Improve DDB transaction validation | Solution for https://github.com/spulec/moto/issues/5496 | 2022-10-03T16:22:35Z | Dynamodb mock, missing validation for transactions (transact_write_items)
Hello,
creating transaction with conflicting operations seem to pass locally with dynamodb_mock. For example creating Add and Delete operation of the same item will fail on the stack but pass locally.
Code to reproduce.
```
#!/usr/bin/env... | Thanks for raising this @LukaK - marking it as an enhancement to add this validation.
If you want to implement this yourself, PR's are always welcome! | [
{
"body": "Hello,\r\ncreating transaction with conflicting operations seem to pass locally with dynamodb_mock. For example creating Add and Delete operation of the same item will fail on the stack but pass locally.\r\n\r\n\r\nCode to reproduce.\r\n```\r\n#!/usr/bin/env python\r\nimport boto3\r\nimport pytest\r\... | f89b52680b97b4d76e95f38702dd9cbbc22b8d7d | {
"head_commit": "4e28b40a9cc6b286399701d50ad8f464ab92356d",
"head_commit_message": "refactor: check double transactions in single dict",
"patch_to_review": "diff --git a/moto/dynamodb/exceptions.py b/moto/dynamodb/exceptions.py\nindex 973a4721f79f..9f572764fb65 100644\n--- a/moto/dynamodb/exceptions.py\n+++ b/mo... | [
{
"diff_hunk": "@@ -761,3 +761,42 @@ def test_query_begins_with_without_brackets():\n 'Invalid KeyConditionExpression: Syntax error; token: \"sk\"'\n )\n err[\"Code\"].should.equal(\"ValidationException\")\n+\n+\n+@mock_dynamodb\n+def test_transact_write_items_multiple_operations_fail():\n+\n+ ... | 601d7633da70ffeb02fdb0059843e1288cbc90b3 | diff --git a/moto/dynamodb/exceptions.py b/moto/dynamodb/exceptions.py
index 973a4721f79f..9f572764fb65 100644
--- a/moto/dynamodb/exceptions.py
+++ b/moto/dynamodb/exceptions.py
@@ -323,3 +323,12 @@ class InvalidConversion(JsonRESTError):
def __init__(self):
er = "SerializationException"
super()... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-67802@99acaf5 | getsentry/sentry | Python | 67,802 | ref(replays): tags is default tab for mobile replays | For mobile replays, all tabs except Tags are disabled, with a tooltip saying coming soon:
<img width="709" alt="SCR-20240327-jyko-2" src="https://github.com/getsentry/sentry/assets/56095982/711797bf-59a9-4010-9602-f87ca58105c6">
Attempting to route to some other `t_main` will result in the tags tab being shown by... | 2024-03-27T17:59:14Z | [Replay Details] Make "Tags" tab default for mobile replays
We do not plan on having any additional functionality to the initial alpha release of mobile replays (aside from the playback), but we will have tags available, so let's show that tab by default. The other tabs should be disabled with a tooltip on hover explai... | [
{
"body": "We do not plan on having any additional functionality to the initial alpha release of mobile replays (aside from the playback), but we will have tags available, so let's show that tab by default. The other tabs should be disabled with a tooltip on hover explaining why.",
"number": 67692,
"tit... | 97fb58d5a8d64fb9f905ad79dc330bc9258d1754 | {
"head_commit": "99acaf568be57a9b757f44d9fece97b5b01629a8",
"head_commit_message": "add and fix tests",
"patch_to_review": "diff --git a/static/app/components/links/listLink.tsx b/static/app/components/links/listLink.tsx\nindex 56733641b39606..86049fed7ce4fa 100644\n--- a/static/app/components/links/listLink.tsx... | [
{
"diff_hunk": "@@ -50,9 +56,11 @@ function ListLink({\n className={classNames({[activeClassName]: active}, className)}\n disabled={disabled}\n >\n- <RouterLink {...props} onlyActiveOnIndex={index} to={disabled ? '' : target}>\n- {children}\n- </RouterLink>\n+ <Tooltip titl... | 9597c2397d51480dba373cc0062e2432d9f02746 | diff --git a/static/app/components/links/listLink.tsx b/static/app/components/links/listLink.tsx
index 56733641b39606..e28c35c4e962f9 100644
--- a/static/app/components/links/listLink.tsx
+++ b/static/app/components/links/listLink.tsx
@@ -65,12 +65,16 @@ const StyledLi = styled('li', {
${p =>
p.disabled &&
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-67657@2679dac | getsentry/sentry | Python | 67,657 | ref(replay): only preload mobile replay videos when needed | - Optimize loading of videos for mobile replays
- This PR modifies the `_videos` array by converting it into a dictionary that maps segment index to the video element. This makes it easier to only load videos when requested, rather than preloading them all at once.
- Also fixes a bug where `currentIndex` was consiste... | 2024-03-25T22:18:42Z | [Replay Details] Performance optimizations for not pre-loading all videos
For the mobile replay player, we currently eagerly load all videos for the replay. This means we can potentially be loading ~720 videos at once, which is not ideal. Instead we want to intelligently load videos that are right before and right afte... | [
{
"body": "For the mobile replay player, we currently eagerly load all videos for the replay. This means we can potentially be loading ~720 videos at once, which is not ideal. Instead we want to intelligently load videos that are right before and right after the current time in the player. Since our \"go back\"... | 8ac74352694af33add65799bb481a99a287ef10d | {
"head_commit": "2679dacef2fe33f666e49be9f62183795879fba1",
"head_commit_message": "add tests",
"patch_to_review": "diff --git a/static/app/components/replays/videoReplayer.spec.tsx b/static/app/components/replays/videoReplayer.spec.tsx\nindex 9834e04a9f5745..175119f97040d2 100644\n--- a/static/app/components/re... | [
{
"diff_hunk": "@@ -116,6 +142,86 @@ describe('VideoReplayer - no starting gap', () => {\n // @ts-expect-error private\n expect(inst.getVideo(inst._currentIndex)?.currentTime).toEqual(5);\n });\n+\n+ it('initially only loads videos from 0 to BUFFER', async () => {\n+ const root = document.createEl... | 0c1c4f18cb34762c64eed3670408d69bbf0ba3e8 | diff --git a/static/app/components/replays/videoReplayer.spec.tsx b/static/app/components/replays/videoReplayer.spec.tsx
index 9834e04a9f5745..cc8c8bd735ea40 100644
--- a/static/app/components/replays/videoReplayer.spec.tsx
+++ b/static/app/components/replays/videoReplayer.spec.tsx
@@ -49,6 +49,32 @@ describe('VideoRep... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
getsentry__sentry-67774@081fa0c | getsentry/sentry | Python | 67,774 | feat(use-case): Add visibility modifiers to use cases and use internal MRI parser | This PR adds the concept of visibility to use cases. The rationale behind this PR is that we are seeing an increase in the number of use cases added to the generic metrics platform and we want to differentiate between use cases that are meant to be surfaced directly in the product or just internally to power features o... | 2024-03-27T08:28:12Z | Formalize visibility of use case ids
We have been adding new use case ids to the `UseCaseID` mapping and such use cases are some user facing and some internal only. We would like to explore a system to define the visibility of use case ids.
For example, if we want `UseCaseID.Profiles` to be private we should have an e... | [
{
"body": "We have been adding new use case ids to the `UseCaseID` mapping and such use cases are some user facing and some internal only. We would like to explore a system to define the visibility of use case ids.\n\nFor example, if we want `UseCaseID.Profiles` to be private we should have an easy way to defin... | be1b61a13d15360eca3671ad64109634dca7e2c0 | {
"head_commit": "081fa0c2aa5fc73de013b47fa6d6c399027186e0",
"head_commit_message": "feat(ddm): Allow access to public use case ids and private only in admin",
"patch_to_review": "diff --git a/tests/sentry/api/endpoints/test_organization_metrics.py b/tests/sentry/api/endpoints/test_organization_metrics.py\nindex ... | [
{
"diff_hunk": "@@ -1,14 +1,19 @@\n from __future__ import annotations\n \n-import re\n from collections.abc import Mapping\n from enum import Enum\n \n from sentry_kafka_schemas.codecs import ValidationError\n \n from sentry.sentry_metrics.configuration import UseCaseKey\n+from sentry.snuba.metrics import pars... | b671ac3f9f8033c6d6b65d6d7193a87692096e5f | diff --git a/src/sentry/search/events/builder/metrics.py b/src/sentry/search/events/builder/metrics.py
index 24401f293340a7..44b5e5abfbd525 100644
--- a/src/sentry/search/events/builder/metrics.py
+++ b/src/sentry/search/events/builder/metrics.py
@@ -52,7 +52,7 @@
WhereType,
)
from sentry.sentry_metrics import i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getmoto__moto-5152@555e802 | getmoto/moto | Python | 5,152 | Add keypair validation | proposed fix for https://github.com/spulec/moto/issues/5151 | 2022-05-20T15:11:52Z | No keypair validation on run instance
**Repro steps:**
1. Start moto server.
2. Prepare terraform file that will contain an instance with declared key_name that is not assigned to any existing aws_key_pair
3. Run terraform init; terraform apply
**Description:**
When attempting to create an instance with key_name... | [
{
"body": "**Repro steps:**\r\n1. Start moto server.\r\n2. Prepare terraform file that will contain an instance with declared key_name that is not assigned to any existing aws_key_pair\r\n3. Run terraform init; terraform apply\r\n\r\n**Description:**\r\nWhen attempting to create an instance with key_name that i... | 84b466daee644901994b41640ec7e09fa1d6792d | {
"head_commit": "555e802777bc2b261571e4ccbbcd71a7fe32f113",
"head_commit_message": "add-keypair validation on add instances",
"patch_to_review": "diff --git a/moto/ec2/models/instances.py b/moto/ec2/models/instances.py\nindex dcc578d88767..5c9263be7e0d 100644\n--- a/moto/ec2/models/instances.py\n+++ b/moto/ec2/m... | [
{
"diff_hunk": "@@ -550,6 +550,8 @@ def get_instance(self, instance_id):\n def add_instances(self, image_id, count, user_data, security_group_names, **kwargs):\n location_type = \"availability-zone\" if kwargs.get(\"placement\") else \"region\"\n default_region = \"us-east-1\"\n+ desc... | b8d4c22839db6fde90109efa33bf2cafd431fdd5 | diff --git a/moto/ec2/models/instances.py b/moto/ec2/models/instances.py
index dcc578d88767..3f9de1cc1898 100644
--- a/moto/ec2/models/instances.py
+++ b/moto/ec2/models/instances.py
@@ -550,6 +550,8 @@ def get_instance(self, instance_id):
def add_instances(self, image_id, count, user_data, security_group_names, *... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getmoto__moto-5132@0b123e3 | getmoto/moto | Python | 5,132 | Add instance type validation on add instance method | Fix to https://github.com/spulec/moto/issues/5131 | 2022-05-13T16:46:30Z | EC2 Instance Type Validation
Steps To Reproduce
1. Launch an EC2 instance with an invalid instance type such as t3.nano.
`
client.run_instances(InstanceType="t3.nano", ImageId="ami-00000000", MaxCount=1, MinCount=1, )
`
2. Run Describe Instances and see that the instance is launched with an invalid instance ... | fix for #1695
Thanks for opening; setting this as a feature request for instance type validation.
@spulec Thanks! I have opened PR on this here #1696
PR with proposed solution https://github.com/spulec/moto/pull/5132 | [
{
"body": "\r\nSteps To Reproduce\r\n\r\n1. Launch an EC2 instance with an invalid instance type such as t3.nano.\r\n`\r\nclient.run_instances(InstanceType=\"t3.nano\", ImageId=\"ami-00000000\", MaxCount=1, MinCount=1, )\r\n`\r\n\r\n2. Run Describe Instances and see that the instance is launched with an invalid... | 6ae0aa52728311158c4556ac38caffc717af21dc | {
"head_commit": "0b123e397592e247f67d4ca71f7d83f22073f41a",
"head_commit_message": "Merge branch 'master' into Add-instance-type-validation-on-add-instance-method",
"patch_to_review": "diff --git a/moto/autoscaling/models.py b/moto/autoscaling/models.py\nindex a252fc531374..296adb4271e8 100644\n--- a/moto/autosc... | [
{
"diff_hunk": "@@ -551,6 +558,24 @@ def add_instances(self, image_id, count, user_data, security_group_names, **kwar\n }\n if kwargs[\"placement\"] not in valid_availability_zones:\n raise AvailabilityZoneNotFromRegionError(kwargs[\"placement\"])\n+ match_filters ... | f633652dfb9bae290c186b88d96db9f0aef9d52f | diff --git a/moto/autoscaling/models.py b/moto/autoscaling/models.py
index a252fc531374..296adb4271e8 100644
--- a/moto/autoscaling/models.py
+++ b/moto/autoscaling/models.py
@@ -633,6 +633,7 @@ def replace_autoscaling_group_instances(self, count_needed, propagated_tags):
tags={"instance": propagated_tags}... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-74418@6945b13 | home-assistant/core | Python | 74,418 | Avoid importing MQTT into core for ServiceInfo dataclass | ## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
Which ever integration triggered the fi... | 2022-07-04T15:05:01Z | Multiple "is taking over 10 seconds" warnings after updating to 2022.6.7
### The problem
The following warnings appeared in my log after the update to b 2022.6.7.
Nothing else changed and everything seems to be working fine.
```
Setup of update platform hassio is taking over 10 seconds.
21:33:23 – (WARNING) Up... | the same here:
```
2022-06-22 21:29:57 WARNING (MainThread) [homeassistant.components.binary_sensor] Setup of binary_sensor platform hassio is taking over 10 seconds.
2022-06-22 21:29:57 WARNING (MainThread) [homeassistant.components.update] Setup of update platform hassio is taking over 10 seconds.
2022-06-22 21... | [
{
"body": "### The problem\n\nThe following warnings appeared in my log after the update to b 2022.6.7.\r\nNothing else changed and everything seems to be working fine.\r\n\r\n\r\n```\r\nSetup of update platform hassio is taking over 10 seconds.\r\n21:33:23 – (WARNING) Update\r\n\r\nSetup of binary_sensor platf... | a31dde9cb427104f1b22fb12d3013baf20a1dc76 | {
"head_commit": "6945b134c14ff375384f797212fcbc788eca5ca0",
"head_commit_message": "fix conflict correctly",
"patch_to_review": "diff --git a/homeassistant/components/mqtt/__init__.py b/homeassistant/components/mqtt/__init__.py\nindex 906923138b9ca..394e4af3e2ee3 100644\n--- a/homeassistant/components/mqtt/__ini... | [
{
"diff_hunk": "@@ -15,8 +15,12 @@\n if TYPE_CHECKING:\n import asyncio\n \n- from homeassistant.components import mqtt\n+ from homeassistant.components.bluetooh import BluetoothServiceInfo",
"line": null,
"original_line": 18,
"original_start_line": null,
"path": "homeassistant/helpers... | 3cd2f3662218aac1b311fdda11bea5aee249c1cb | diff --git a/homeassistant/components/mqtt/__init__.py b/homeassistant/components/mqtt/__init__.py
index 906923138b9ca..394e4af3e2ee3 100644
--- a/homeassistant/components/mqtt/__init__.py
+++ b/homeassistant/components/mqtt/__init__.py
@@ -3,8 +3,6 @@
import asyncio
from collections.abc import Callable
-from datac... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
home-assistant__core-74971@1ea51c2 | home-assistant/core | Python | 74,971 | JSON serialize NamedTuple subclasses with aiohttp |
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or resolves a feature request, be sure to link to that issue in the
additional information section.
-->
JSON serialize NamedTuple subclasse... | 2022-07-11T10:24:34Z | Type is not JSON serializable: RGBColor
### The problem
I use an automation/script to randomly select a color for an RBG light strip using `color_name` for a `light.turn_on` service. This worked find until I updated to 2022.07.x.
What's weird is that the same service call works fine in the service call tab of th... | [
{
"body": "### The problem\r\n\r\nI use an automation/script to randomly select a color for an RBG light strip using `color_name` for a `light.turn_on` service. This worked find until I updated to 2022.07.x.\r\n\r\nWhat's weird is that the same service call works fine in the service call tab of the frontend. ... | 28a34a1f8975a41241060c5fffef4b9a7618a3cc | {
"head_commit": "1ea51c280c651b017429cd70a4136bd1459c141e",
"head_commit_message": "order matters",
"patch_to_review": "diff --git a/homeassistant/helpers/json.py b/homeassistant/helpers/json.py\nindex 74a2f542910f4..3181558092d5b 100644\n--- a/homeassistant/helpers/json.py\n+++ b/homeassistant/helpers/json.py\n... | [
{
"diff_hunk": "@@ -41,6 +41,8 @@ def json_encoder_default(obj: Any) -> Any:\n return obj.as_dict()\n if isinstance(obj, Path):\n return obj.as_posix()\n+ if isinstance(obj, NamedTuple):\n+ return tuple(obj)",
"line": null,
"original_line": 45,
"original_start_line": nu... | 4bf9c486cee706270c92753887b8f9557f292ec1 | diff --git a/homeassistant/helpers/aiohttp_client.py b/homeassistant/helpers/aiohttp_client.py
index 2e56698db41e5..2ef96091d152c 100644
--- a/homeassistant/helpers/aiohttp_client.py
+++ b/homeassistant/helpers/aiohttp_client.py
@@ -14,7 +14,6 @@
from aiohttp.hdrs import CONTENT_TYPE, USER_AGENT
from aiohttp.web_exce... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
getmoto__moto-4555@e921393 | getmoto/moto | Python | 4,555 | Search cognito identities from iot moto backend | Search cognito identities from iot core moto backend | 2021-11-10T12:14:44Z | Search cognito ids while IoT Core attach policy
Hello,
I am trying to test iot `attach_policy` with cognito identity instead of iot core certificate but it raises an exception.
Doing a research I have found that during attach_policy uses the next method in order to found the target:
```
def _get_principal(self, p... | Hi @acapagarcia! You can import other service backends, and access all data stored in that service.
For performance reasons, the import should happen as late as possible.
So for this usecase, you can use:
```
def _get_principal(self, principal_arn):
"""
raise ResourceNotFoundException
"... | [
{
"body": "Hello,\r\n\r\nI am trying to test iot `attach_policy` with cognito identity instead of iot core certificate but it raises an exception.\r\nDoing a research I have found that during attach_policy uses the next method in order to found the target:\r\n```\r\ndef _get_principal(self, principal_arn):\r\n ... | dfb380d887dee0a8f40ba50b6ef6cb99e62a0f84 | {
"head_commit": "e921393302ee4033a60765cea66b4418a1444149",
"head_commit_message": "Black on test iot file",
"patch_to_review": "diff --git a/moto/cognitoidentity/models.py b/moto/cognitoidentity/models.py\nindex 291133381a4b..70a0ebea1665 100644\n--- a/moto/cognitoidentity/models.py\n+++ b/moto/cognitoidentity/... | [
{
"diff_hunk": "@@ -911,9 +911,17 @@ def _get_principal(self, principal_arn):\n raise ResourceNotFoundException()\n principal = certs[0]\n return principal\n- else:\n- # TODO: search for cognito_ids\n- pass\n+ from moto.cognitoidentity ... | 82f9917b7f38248ae1a008222ed2394fdbc4409b | diff --git a/moto/cognitoidentity/models.py b/moto/cognitoidentity/models.py
index 291133381a4b..70a0ebea1665 100644
--- a/moto/cognitoidentity/models.py
+++ b/moto/cognitoidentity/models.py
@@ -54,6 +54,7 @@ def __init__(self, region):
super(CognitoIdentityBackend, self).__init__()
self.region = regi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getmoto__moto-4786@65d8cfb | getmoto/moto | Python | 4,786 | moto/route53 does not correctly handle private hosted zones #4785 | models.py:
- Route53Backend.create_hosted_zone now receive vpcid, vpcregion
- Passes into FakeZone.__init___
responses.py:
- Class Route53 now handles the existence of a VPC key in the returned "HOSTEDZONECONFIG
- Cleaned up Route53.list_or_create_hostzone_response() for better readability
- If a CreateHostedZo... | 2022-01-22T23:55:28Z | moto/route53 does not correctly handle private hosted zones
moto/route53 does not correctly handle private hosted zones with `create_hosted_zone()` such that when calling `list_hosted_zones()` or `get_hosted_zone()` with a specific zone ID, the associated VPC information is not available.
Further, calling `create_ho... | I've attempted to fix the above here: https://github.com/spulec/moto/pull/4786 | [
{
"body": "moto/route53 does not correctly handle private hosted zones with `create_hosted_zone()` such that when calling `list_hosted_zones()` or `get_hosted_zone()` with a specific zone ID, the associated VPC information is not available.\r\n\r\nFurther, calling `create_hosted_zone()` and requesting a private... | 010d525de0ef9060a137d745e601f5beae95b7b7 | {
"head_commit": "65d8cfb8f673f0e40c6bd4961e9d61d5d2a32a53",
"head_commit_message": "Remove unused vars",
"patch_to_review": "diff --git a/moto/route53/models.py b/moto/route53/models.py\nindex 52c6620ad1f0..a0cd35e7287e 100644\n--- a/moto/route53/models.py\n+++ b/moto/route53/models.py\n@@ -212,11 +212,17 @@ def... | [
{
"diff_hunk": "@@ -390,6 +403,21 @@ def test_hosted_zone_private_zone_preserved_boto3():\n len(hosted_zones[\"HostedZones\"]).should.equal(1)\n hosted_zones[\"HostedZones\"][0][\"Config\"][\"PrivateZone\"].should.equal(True)\n \n+ # create_hosted_zone statements with PrivateZone=True,\n+ # but w... | 3dcf459a0521f0f3197734ebbad3a89f6057d1dd | diff --git a/moto/route53/exceptions.py b/moto/route53/exceptions.py
index cb2456b360b7..1a765cb2e94f 100644
--- a/moto/route53/exceptions.py
+++ b/moto/route53/exceptions.py
@@ -33,6 +33,17 @@ def __init__(self):
super().__init__("InvalidPaginationToken", message)
+class InvalidVPCId(Route53ClientError):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-4425@f23fdd8 | getmoto/moto | Python | 4,425 | cloudformation: fix get_template_summary() related error |
fixes #4424 | 2021-10-17T11:21:22Z | cloudformation: `get_template_summary()` fails for stacks created using `create_change_set()`
cloudformation call `get_template_summary()` fails for stacks created using `create_change_set()`. Can be reproduced by
```py
dummy = {
"AWSTemplateFormatVersion": "2010-09-09",
"Description": "Stack... | [
{
"body": "cloudformation call `get_template_summary()` fails for stacks created using `create_change_set()`. Can be reproduced by\r\n```py\r\n\r\n dummy = {\r\n \"AWSTemplateFormatVersion\": \"2010-09-09\",\r\n \"Description\": \"Stack 3\",\r\n \"Resources\": {\r\n \"VPC\": ... | a23e507abf9b53bbcc084b8640ae41e97446bda6 | {
"head_commit": "f23fdd8cf0602d48b5526637942581ada2ec9f54",
"head_commit_message": "fix(cloudformation): bugfix for #4424",
"patch_to_review": "diff --git a/moto/cloudformation/exceptions.py b/moto/cloudformation/exceptions.py\nindex 10669ca56de9..83faec78e5c7 100644\n--- a/moto/cloudformation/exceptions.py\n+++... | [
{
"diff_hunk": "@@ -745,24 +745,27 @@ def execute_change_set(self, change_set_name, stack_name=None):\n if change_set is None:\n raise ValidationError(stack_name)\n \n+ stack = self.stacks[change_set.stack_id]\n+ assert stack is change_set.stack",
"line": null,
"origina... | b84b2c769e598877bde3ffb98ba963f30c32f833 | diff --git a/moto/cloudformation/exceptions.py b/moto/cloudformation/exceptions.py
index 10669ca56de9..83faec78e5c7 100644
--- a/moto/cloudformation/exceptions.py
+++ b/moto/cloudformation/exceptions.py
@@ -11,7 +11,7 @@ class UnformattedGetAttTemplateException(Exception):
class ValidationError(BadRequest):
- d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getmoto__moto-4437@5fd0127 | getmoto/moto | Python | 4,437 | Route53 query-logging-config APIs | Addition of the Route53 APIs:
- `create_query_logging_config`
- `get_query_logging_config`
- `list_query_logging_config`
- `delete_query_logging_config`
Note: `create_query_logging_config()` does not create a log stream for an edge location. That's supposed to happen the first time that the edge location res... | 2021-10-19T01:24:31Z | paginate decorator requiring parameters that are not required
Note: What I'm trying to do is internal to moto and not a typical scenario, so it's a low priority issue.
I have the following code that I was planning to use in a new Route53 API implementation:
```
from moto.logs import logs_backends # pyl... | Makes sense @kbalk
#4437 | [
{
"body": "Note: What I'm trying to do is internal to moto and not a typical scenario, so it's a low priority issue.\r\n\r\nI have the following code that I was planning to use in a new Route53 API implementation:\r\n\r\n```\r\n from moto.logs import logs_backends # pylint: disable=import-outside-tople... | 9a55ed717f8bf3725446dedb59909e6af064ecc6 | {
"head_commit": "5fd01274f89e81e19c3c9b40a88a36f644f35edf",
"head_commit_message": "Add logic, test for InvalidPaginationToken",
"patch_to_review": "diff --git a/IMPLEMENTATION_COVERAGE.md b/IMPLEMENTATION_COVERAGE.md\nindex 76b5cdabc042..7f48252aa1a6 100644\n--- a/IMPLEMENTATION_COVERAGE.md\n+++ b/IMPLEMENTATIO... | [
{
"diff_hunk": "@@ -206,20 +216,109 @@ def get_change(self, request, full_url, headers):\n parsed_url = urlparse(full_url)\n change_id = parsed_url.path.rstrip(\"/\").rsplit(\"/\", 1)[1]\n template = Template(GET_CHANGE_RESPONSE)\n- return 200, headers, template.re... | a1759ba2c5cfb0c1589d6bb78e2c34accd1a2cd8 | diff --git a/IMPLEMENTATION_COVERAGE.md b/IMPLEMENTATION_COVERAGE.md
index 76b5cdabc042..7f48252aa1a6 100644
--- a/IMPLEMENTATION_COVERAGE.md
+++ b/IMPLEMENTATION_COVERAGE.md
@@ -3506,7 +3506,7 @@
- [X] create_health_check
- [X] create_hosted_zone
- [ ] create_key_signing_key
-- [ ] create_query_logging_config
+- [X... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-4402@c526f32 | getmoto/moto | Python | 4,402 | Fixed a bug where calling batch_write_item with non-existing tables names would not raise ResourceNotFoundException | Resolves #4347
Added a basic unit tests for this function as a separate commit. I'm not really sure how would you like them to look like, so please feel free to throw some suggestions or discard them entirely. | 2021-10-12T21:29:25Z | mock_dynamodb2 does not raise ResourceNotFoundError in call to boto3.client("dynamodb").batch_write_item() with an inexistent table
## Description
Specifying a DynamoDB table that does not exist in the `boto3.client("dynamodb").batch_write_item()` or `boto3.resource("dynamodb").batch_write_item()` functions is expec... | Potentially related to #4344. | [
{
"body": "## Description\r\n\r\nSpecifying a DynamoDB table that does not exist in the `boto3.client(\"dynamodb\").batch_write_item()` or `boto3.resource(\"dynamodb\").batch_write_item()` functions is expected to raise a `ResourceNotFoundError`. When using `mock_dynamodb2`, no exception is raised.\r\n\r\n## St... | 198f2696b92444c05d06dab9ac5379b4a767aa95 | {
"head_commit": "c526f32e211192d81e8c9575b4db860741dec139",
"head_commit_message": "Added simple test for dynamodb2 batch_write_item (#4347)",
"patch_to_review": "diff --git a/moto/dynamodb2/responses.py b/moto/dynamodb2/responses.py\nindex 884a7ea71961..14f4ad3af385 100644\n--- a/moto/dynamodb2/responses.py\n++... | [
{
"diff_hunk": "@@ -5920,3 +5920,58 @@ def test_update_non_existing_item_raises_error_and_does_not_contain_item_afterwa\n err.value.response[\"Error\"][\"Code\"].should.equal(\"ValidationException\")\n \n conn.scan(TableName=name)[\"Items\"].should.have.length_of(0)\n+\n+\n+@mock_dynamodb2\n+def test_ba... | e954c611377d89f2bc75a35b105e49d3501a1b0f | diff --git a/moto/dynamodb2/responses.py b/moto/dynamodb2/responses.py
index 884a7ea71961..14f4ad3af385 100644
--- a/moto/dynamodb2/responses.py
+++ b/moto/dynamodb2/responses.py
@@ -379,7 +379,12 @@ def batch_write_item(self):
request = list(table_request.values())[0]
if request_type ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-4366@819dc31 | getmoto/moto | Python | 4,366 | Update CONTRIBUTING.md | Fixes #4275
@kbalk Some improvements to the Contributing document, following your suggestions. Hopefully this makes onboarding easier for new contributors. Let me know what you think. | 2021-10-01T21:58:10Z | Possible additions to CONTRIBUTING.md
Some suggestions for `CONTRIBUTING.md` to help contributors to moto:
- Promote the use of TaggingService.
- Describe how to run in test server mode and the environment variable `TEST_SERVER_MODE`. You can work it out by looking at the github workflow file, but it might be nice... | Hey @kbalk, thanks for pointing this out - user feedback is always useful.
>
> If an exception is raised that isn't defined in an exceptions.py file and a unit test attempts to check that scenario, the test will fail when run in server mode.
To turn this into a more general rule:
Always verify exceptions by us... | [
{
"body": "Some suggestions for `CONTRIBUTING.md` to help contributors to moto:\r\n\r\n- Promote the use of TaggingService.\r\n- Describe how to run in test server mode and the environment variable `TEST_SERVER_MODE`. You can work it out by looking at the github workflow file, but it might be nice to spell out... | e6b18bcb92ccff183c6987a1404c9a96bc07ba5c | {
"head_commit": "819dc3131a2ef20349ee4c4f06d23cd7208d45fe",
"head_commit_message": "Update CONTRIBUTING.md",
"patch_to_review": "diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md\nindex 93b58a21d8c4..19a74608b0ef 100644\n--- a/CONTRIBUTING.md\n+++ b/CONTRIBUTING.md\n@@ -1,3 +1,13 @@\n+- [Contributing code](#contrib... | [
{
"diff_hunk": "@@ -11,14 +21,39 @@ You should be able to run `make init` to install the dependencies and then `make\n \n ## Linting\n \n-Run `make lint` or `black --check moto tests` to verify whether your code confirms to the guidelines.\n-\n-## Getting to grips with the codebase\n+Ensure that the correct ver... | 617bdf77301cd1d671d79c2cfd816f4f374f5753 | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 93b58a21d8c4..13f77a382bb7 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -1,3 +1,15 @@
+# Table of Contents
+
+- [Contributing code](#contributing-code)
+ * [Running the tests locally](#running-the-tests-locally)
+ * [Linting](#linting)
+ * [General notes]... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
getmoto__moto-4375@684b8b7 | getmoto/moto | Python | 4,375 | dynamodb2 - updated error message when UpdateItem with ConditionalExpression fails | Resolves #4352 | 2021-10-06T21:43:32Z | Incorrect and misleading error message while performing conditional UpdateItem operation on nonexistent item in dynamodb2
Calling `update_item` on `Table` object obtained from `boto3.resource('dynamodb')` with an optional `ConditionalExpression` throws an exception with very misleading error message. The message differ... | Thanks for raising this @k0mmsussert0d - you're right, we should return the correct error message. Marking it as a bug. | [
{
"body": "Calling `update_item` on `Table` object obtained from `boto3.resource('dynamodb')` with an optional `ConditionalExpression` throws an exception with very misleading error message. The message differs from the one actually returned by the real API.\r\n\r\n```python\r\nimport boto3\r\nfrom moto import ... | a17d17ec6e7208f8f14b6c3794c8f689758870df | {
"head_commit": "684b8b77503638e9bea03b445aebfc00d361ab37",
"head_commit_message": "Added test case checking if ConditionalCheckFailedException is thrown on attempt to perform UpdateItem on non-existent item (#4352)",
"patch_to_review": "diff --git a/moto/dynamodb2/responses.py b/moto/dynamodb2/responses.py\nind... | [
{
"diff_hunk": "@@ -2887,6 +2887,16 @@ def test_condition_expressions():\n ExpressionAttributeNames={\"#existing\": \"existing\", \"#match\": \"match\"},\n )\n \n+ with pytest.raises(client.exceptions.ConditionalCheckFailedException):",
"line": null,
"original_line": 2890,
"or... | 807fa6de8f7d09364d2084b93c3ccbb0cdc73fff | diff --git a/moto/dynamodb2/responses.py b/moto/dynamodb2/responses.py
index 486c000e5bab..2ceeb2f9f44f 100644
--- a/moto/dynamodb2/responses.py
+++ b/moto/dynamodb2/responses.py
@@ -855,9 +855,7 @@ def update_item(self):
return self.error(er, mve.exception_msg)
except ValueError:
er ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-65203@f549673 | getsentry/sentry | Python | 65,203 | ref(weekly report): Prevent resending emails | Build up the user context per organization first, then send emails.
Closes https://github.com/getsentry/sentry/issues/55476 | 2024-02-15T00:11:35Z | Prevent resending weekly report emails
We recently had an error in the weekly report task. Since it has retries enabled it would get halfway through sending them and re-attempt the entire org.
Some possible solutions:
- Build the user context as a step and send them in a followup step so no emails are sent until all t... | [
{
"body": "We recently had an error in the weekly report task. Since it has retries enabled it would get halfway through sending them and re-attempt the entire org.\n\nSome possible solutions:\n- Build the user context as a step and send them in a followup step so no emails are sent until all the contexts have ... | 9e90557e6fc0c255bd3fb353fdb5ea17a6f5b507 | {
"head_commit": "f5496739bb1ef3ddfb6dec9d1999eb2698305f00",
"head_commit_message": "nit these were bugging me",
"patch_to_review": "diff --git a/src/sentry/tasks/weekly_reports.py b/src/sentry/tasks/weekly_reports.py\nindex 6b9555bf131cbf..388e721a571607 100644\n--- a/src/sentry/tasks/weekly_reports.py\n+++ b/sr... | [
{
"diff_hunk": "@@ -945,16 +960,21 @@ def issue_summary():\n }\n \n \n-def send_email(ctx, user_id, dry_run=False, email_override=None):\n- template_ctx = render_template_context(ctx, user_id)\n- if not template_ctx:\n- logger.debug(\n- \"Skipping report for %s to <User: %s>, no qual... | 515e750c0fe85744de503fccaedeb99884b843a0 | diff --git a/src/sentry/tasks/weekly_reports.py b/src/sentry/tasks/weekly_reports.py
index 6b9555bf131cbf..37fc802bae7940 100644
--- a/src/sentry/tasks/weekly_reports.py
+++ b/src/sentry/tasks/weekly_reports.py
@@ -3,8 +3,10 @@
import heapq
import logging
import uuid
+from collections.abc import Mapping
from dateti... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-64939@b802073 | getsentry/sentry | Python | 64,939 | feat(dashboards): ddm chart intervals | - closes #61029
Note: Consolidating chart intervals cross-dataset is not easily achievable across different datasets, this PR aims to align metric widget intervals with other dashboard widgets.
<img width="1212" alt="image" src="https://github.com/getsentry/sentry/assets/86684834/8e7a9f71-202e-41cb-8ed4-19b2ad31... | 2024-02-09T10:02:33Z | Consolidate chart intervals
As part of this ticket, we did an audit of the most common timeframes and optimized for a consistent number of buckets, consistent charts across datasets/products, and developer readability. Here are the desired results:
| Timeframe | Interval |
| ------------- | ------------- |
| 1h | 10... | [
{
"body": "As part of this ticket, we did an audit of the most common timeframes and optimized for a consistent number of buckets, consistent charts across datasets/products, and developer readability. Here are the desired results:\n\n| Timeframe | Interval |\n| ------------- | ------------- |\n| 1h | 10s/1m ... | 33c040450f5200b98301b4d86f7475c30042ef82 | {
"head_commit": "b802073b9019bb59bfd5e296378550400b109d8d",
"head_commit_message": "fix bar charts",
"patch_to_review": "diff --git a/static/app/types/metrics.tsx b/static/app/types/metrics.tsx\nindex 0d710b098f6e75..e4d77d07836613 100644\n--- a/static/app/types/metrics.tsx\n+++ b/static/app/types/metrics.tsx\n@... | [
{
"diff_hunk": "@@ -136,44 +137,49 @@ function sanitizeQuery(query?: string) {\n return query?.trim();\n }\n \n-const ddmHighFidelityLadder = new GranularityLadder([\n- [SIXTY_DAYS, '1d'],\n- [THIRTY_DAYS, '2h'],\n- [TWO_WEEKS, '1h'],\n- [ONE_WEEK, '30m'],\n- [TWENTY_FOUR_HOURS, '5m'],\n- [ONE_HOUR, '1m... | 58f08a4d5cbb47f97fddd22b60fc3d35741c8dcc | diff --git a/static/app/types/metrics.tsx b/static/app/types/metrics.tsx
index 0d710b098f6e75..136003efca53b7 100644
--- a/static/app/types/metrics.tsx
+++ b/static/app/types/metrics.tsx
@@ -31,7 +31,7 @@ export type MetricsApiRequestMetric = {
query?: string;
};
-export type MetricsApiRequestQuery = MetricsApiRe... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
getsentry__sentry-75737@50c0852 | getsentry/sentry | Python | 75,737 | chore(projects): Increase project slug limit from 50 -> 100 | Increase project slug limit from 50 -> 100. There are no FE changes needed b/c we don't validate length on frontend, but show the error received from the failed POST request.
<img width="679" alt="Screenshot 2024-08-07 at 10 59 23 AM" src="https://github.com/user-attachments/assets/72c21448-6e09-4474-94fb-882d4a370e0b... | 2024-08-07T17:19:50Z | Project slug length limit
### Problem Statement
Hey 👋
Is there any opportunity to change max size of project's slug field?
This request is based on UX, 50 chars is not quite enough.
By project convention, used in our company, some project's names can be longer than 50 chars, so we face char limit in "slug" field.... | Assigning to @getsentry/support for [routing](https://open.sentry.io/triage/#2-route) ⏲️
Routing to @getsentry/product-owners-settings-projects for [triage](https://develop.sentry.dev/processing-tickets/#3-triage) ⏲️
> By project convention, used in our company, some project's names can be longer than 50 chars, so we f... | [
{
"body": "### Problem Statement\n\nHey 👋 \r\nIs there any opportunity to change max size of project's slug field?\r\nThis request is based on UX, 50 chars is not quite enough.\r\nBy project convention, used in our company, some project's names can be longer than 50 chars, so we face char limit in \"slug\" fie... | 1b2078a8a8e37545ea539567e1aff3d4d9579e39 | {
"head_commit": "50c08528ad98f04324ac9d28bc8a515e1ae43d55",
"head_commit_message": "chore(projects): Increase project slug limit from 50 -> 100",
"patch_to_review": "diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt\nindex 7bfad071c772e2..449f066d8a0ac0 100644\n--- a/migrations_lockfile.txt\n+++ b/m... | [
{
"diff_hunk": "@@ -0,0 +1,34 @@\n+# Generated by Django 5.0.7 on 2024-08-07 17:15\n+\n+from django.db import migrations\n+\n+import sentry.db.models.fields.slug\n+from sentry.new_migrations.migrations import CheckedMigration\n+\n+\n+class Migration(CheckedMigration):\n+ # This flag is used to mark that a mi... | 311b2c4b8d74830a58c9720c2469b908bbc744a4 | diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt
index 77523d6ec01735..38c7df916d9b03 100644
--- a/migrations_lockfile.txt
+++ b/migrations_lockfile.txt
@@ -10,7 +10,7 @@ hybridcloud: 0016_add_control_cacheversion
nodestore: 0002_nodestore_no_dictfield
remote_subscriptions: 0003_drop_remote_subscription... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
getmoto__moto-3702@3317a31 | getmoto/moto | Python | 3,702 | Support Podman for mocking Lambda | Podman supports all Docker APIs used in moto since version 3.0. Note
that Podman requires pulling the image before creating a container
using a fully-qualified image name (e.g., "docker.io/library/busybox"
instead of "busybox").
Test plan:
$ podman system service -t 0
$ DOCKER_HOST="unix://$XDG_RUNTIME_DIR/podm... | 2021-02-17T06:14:06Z | [feature] allow lambda to run with podman as an alternative to docker
* allows you to containers not as root
* cgroups v2
* better support on centos8/fedora OSs
should be an alternative, and not a replacement, as docker is more widespread than podman | Hi @yuvalif, thanks for raising this. Hadn't heard of Podman before.
Is there a specific use case for Lambdas where Podman would give a noticable improvement? From what I can read, it would behave exactly the same in our limited use case. (I.e., run t he container, execute some python code and return the result.)
t... | [
{
"body": "* allows you to containers not as root\r\n* cgroups v2\r\n* better support on centos8/fedora OSs\r\n\r\nshould be an alternative, and not a replacement, as docker is more widespread than podman",
"number": 3276,
"title": "[feature] allow lambda to run with podman as an alternative to docker"
... | afdab66218c1fd34e645622cb4504023db4a65c1 | {
"head_commit": "3317a31568d30ae26c7308f328783f518c3c0619",
"head_commit_message": "Python 2 compatibility",
"patch_to_review": "diff --git a/moto/awslambda/models.py b/moto/awslambda/models.py\nindex b6c941cd7d3c..95af5d19a950 100644\n--- a/moto/awslambda/models.py\n+++ b/moto/awslambda/models.py\n@@ -131,6 +13... | [
{
"diff_hunk": "@@ -31,3 +31,17 @@ def replace_adapter_send(*args, **kwargs):\n \n self.docker_client.api.get_adapter = replace_adapter_send\n return self.__docker_client\n+\n+\n+def parse_image_name(image_name):\n+ # podman does not support short container image name out of box - try... | 32fa70cb87b815942aa8906cd5bde76b9b60e222 | diff --git a/moto/awslambda/models.py b/moto/awslambda/models.py
index b6c941cd7d3c..bfc9052c40f5 100644
--- a/moto/awslambda/models.py
+++ b/moto/awslambda/models.py
@@ -51,7 +51,7 @@
from moto.dynamodb2 import dynamodb_backends2
from moto.dynamodbstreams import dynamodbstreams_backends
from moto.core import ACCOUN... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getmoto__moto-3700@234637f | getmoto/moto | Python | 3,700 | Fix: DynamoDB:GetItem throws wrong error when table doesn't exist | Closes #3695 | 2021-02-17T01:02:16Z | Mocked DynamoDB throws wrong error when table doesn't exist
## Impact
I am unable to use moto to accurately test code that detects when a DynamoDB table is not replicated in the current region
## Reproduce
```python
from moto import mock_dynamodb2
import boto3
@mock_dynamodb2
def repro():
client = bot... | Thanks for raising this @max-reify. Doesn't look like we're explicitly checking for this scenario yet, so marking it as an enhancement | [
{
"body": "## Impact\r\n\r\nI am unable to use moto to accurately test code that detects when a DynamoDB table is not replicated in the current region\r\n\r\n## Reproduce\r\n\r\n```python\r\nfrom moto import mock_dynamodb2\r\nimport boto3\r\n\r\n@mock_dynamodb2\r\ndef repro():\r\n client = boto3.client('dynamo... | afdab66218c1fd34e645622cb4504023db4a65c1 | {
"head_commit": "234637f3ecf0be966fb1d2e2fd66f1d0e8dabd0c",
"head_commit_message": "Fix: DynamoDB:GetItem throws wrong error when table doesn't exist",
"patch_to_review": "diff --git a/moto/dynamodb2/responses.py b/moto/dynamodb2/responses.py\nindex fe1a463d63c6..cc86a9d7578b 100644\n--- a/moto/dynamodb2/respons... | [
{
"diff_hunk": "@@ -359,9 +359,14 @@ def get_item(self):\n \n try:\n item = self.dynamodb_backend.get_item(name, key, projection_expression)\n- except ValueError:\n- er = \"com.amazon.coral.validate#ValidationException\"\n- return self.error(er, \"Validation Exce... | 410f4c2c49f940644041b4313cb32edec50e4a4d | diff --git a/moto/dynamodb2/responses.py b/moto/dynamodb2/responses.py
index fe1a463d63c6..5958a38c93cc 100644
--- a/moto/dynamodb2/responses.py
+++ b/moto/dynamodb2/responses.py
@@ -349,6 +349,12 @@ def batch_write_item(self):
def get_item(self):
name = self.body["TableName"]
+ table = self.dyna... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
home-assistant__core-71731@1f77b17 | home-assistant/core | Python | 71,731 | Bump plugwise to v0.18.2 | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
... | 2022-05-12T11:58:12Z | [BUG]: Stretch: Circle+ is missing
### Describe the bug.
As reported by user Ollem, the Circle+ is not shown in HA.
### What version of Home Assistant Core has the issue?
2022.4
### What was the last working version of Home Assistant Core?
Unknown
### What type of installation are you running?
Home Assistant Cor... | Fixed via https://github.com/plugwise/python-plugwise/pull/184
Same problem here.
I have installed 0.22.3 and still the Cirlce+ is missing.
The Circle+ is visible in Stretch available.
@willsmarthome Please test plugwise-beta v0.22.4b0, that version should work.
@bouwew, after installing: plugwise-beta v0.22.4b0 pr... | [
{
"body": "### Describe the bug.\n\nAs reported by user Ollem, the Circle+ is not shown in HA.\n\n### What version of Home Assistant Core has the issue?\n\n2022.4\n\n### What was the last working version of Home Assistant Core?\n\nUnknown\n\n### What type of installation are you running?\n\nHome Assistant Core\... | 39313057c4f8384cc44bc95a8262a49c986777c1 | {
"head_commit": "1f77b1756f247c0ce71518f81f1180f1dccec804",
"head_commit_message": "Presets no longer present, get preset_modes instead",
"patch_to_review": "diff --git a/homeassistant/components/plugwise/climate.py b/homeassistant/components/plugwise/climate.py\nindex 91a56d09ee56e2..09f5181090c8b1 100644\n--- ... | [
{
"diff_hunk": "@@ -42,17 +42,17 @@ def __init__(\n configuration_url=configuration_url,\n identifiers={(DOMAIN, device_id)},\n connections=connections,\n- manufacturer=data.get(\"vendor\"),\n- model=data.get(\"model\"),\n+ manufacturer=data.g... | 9e5eb6807f04488b7b4d6af45e815dafc54e5b16 | diff --git a/homeassistant/components/plugwise/climate.py b/homeassistant/components/plugwise/climate.py
index 91a56d09ee56e2..09f5181090c8b1 100644
--- a/homeassistant/components/plugwise/climate.py
+++ b/homeassistant/components/plugwise/climate.py
@@ -31,7 +31,7 @@ async def async_setup_entry(
async_add_entitie... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-2982@ca7f7ee | getmoto/moto | Python | 2,982 | Add CloudWatch logs subscription filters | Adds also log event transmission to specified destinations. At the moment only AWS Lambda is implemented. I had to move the `lambda_backends` import to the function level, because circular dependency issues.
I hope I correctly connected CloudWatch Logs with Lambda, if not please some feedback on which parts should b... | 2020-05-10T21:45:29Z | Feature: Logs: put_subscription_filter
moto version: v1.3.14
I try to deploy a lambda with log group and permissions and a dynamoDb table to moto with terraform.
I get 2 errors:
`NotImplementedError: The put_subscription_filter action has not been implemented`
and
`AttributeError: 'DynamoHandler' object has ... | DynamoDB:describe_continuous_backups is now part of moto >= 1.3.15.dev840 | [
{
"body": "moto version: v1.3.14\r\n\r\nI try to deploy a lambda with log group and permissions and a dynamoDb table to moto with terraform.\r\n\r\nI get 2 errors:\r\n\r\n`NotImplementedError: The put_subscription_filter action has not been implemented`\r\nand\r\n`AttributeError: 'DynamoHandler' object has no a... | a2f5c41372f7bbad0f3bb075eb94b5fa5792c2f6 | {
"head_commit": "ca7f7ee20e237ee67299d5598ede3fca94027849",
"head_commit_message": "Add logs.delete_subscription_filter",
"patch_to_review": "diff --git a/moto/awslambda/models.py b/moto/awslambda/models.py\nindex 589a790ae7c6..4761c6b698e3 100644\n--- a/moto/awslambda/models.py\n+++ b/moto/awslambda/models.py\n... | [
{
"diff_hunk": "@@ -983,6 +985,28 @@ def send_dynamodb_items(self, function_arn, items, source):\n func = self._lambdas.get_arn(function_arn)\n return func.invoke(json.dumps(event), {}, {})\n \n+ def send_log_event(\n+ self, function_arn, filter_name, log_group_name, log_stream_name, l... | 4e8f93f5f4bee3a4d043a5942715409ec5eee98d | diff --git a/moto/awslambda/models.py b/moto/awslambda/models.py
index 589a790ae7c6..7641ce067dff 100644
--- a/moto/awslambda/models.py
+++ b/moto/awslambda/models.py
@@ -5,6 +5,8 @@
from collections import defaultdict
import copy
import datetime
+from gzip import GzipFile
+
import docker
import docker.errors
imp... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-11206@25eab22 | huggingface/diffusers | Python | 11,206 | [Training] Better image interpolation in training scripts | # What does this PR do?
As discussed [here](https://github.com/huggingface/diffusers/issues/6397), this PR will add LANCZOS as a default interpolation mode for the image resizing in the training scripts and if the users prefers can choose BILINEAR.
I'll add this to the most popular recent ones and leave the rest ... | 2025-04-04T10:05:34Z | Add a section about how training data resizing might affect the quality of the end models
Have been chatting with @bghira on our Discord forum about the negative effects of not carefully resizing the training data.
@bghira noticed that the way we resize the images in our training examples can introduce unwanted art... | This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.
Please note that issues that do not follow the [contributing guidelines](https://github.com/huggingface/diffusers/blob/main/CONTRIBUTING.md) are likely ... | [
{
"body": "Have been chatting with @bghira on our Discord forum about the negative effects of not carefully resizing the training data. \r\n\r\n@bghira noticed that the way we resize the images in our training examples can introduce unwanted artifacts in the samples generated by the end fine-tuned model. In sho... | fbf61f465b7756bd3d01a272ea994741c3cfcf8c | {
"head_commit": "25eab22b617c3139d137076d4ad6ce99ae0a0cf6",
"head_commit_message": "initial",
"patch_to_review": "diff --git a/examples/dreambooth/train_dreambooth_lora_sdxl.py b/examples/dreambooth/train_dreambooth_lora_sdxl.py\nindex f0d993ad9bbc..aa63c96f1764 100644\n--- a/examples/dreambooth/train_dreambooth... | [
{
"diff_hunk": "@@ -790,7 +797,12 @@ def __init__(\n self.original_sizes = []\n self.crop_top_lefts = []\n self.pixel_values = []\n- train_resize = transforms.Resize(size, interpolation=transforms.InterpolationMode.BILINEAR)\n+\n+ if args.image_interpolation_mode == \"bilin... | 715c7e5136f7c509fefce16bcd16c0825f5d113a | diff --git a/examples/dreambooth/train_dreambooth_lora_sdxl.py b/examples/dreambooth/train_dreambooth_lora_sdxl.py
index f0d993ad9bbc..735d48b83400 100644
--- a/examples/dreambooth/train_dreambooth_lora_sdxl.py
+++ b/examples/dreambooth/train_dreambooth_lora_sdxl.py
@@ -669,6 +669,16 @@ def parse_args(input_args=None):... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
home-assistant__core-74508@811330d | home-assistant/core | Python | 74,508 | Fix invalid enocean unique_id | ## Breaking change
This is not a breaking change
## Proposed change
Fix of Issue #73031 second channel is no longer displayed on enocean switches with 2 channels
## Type of change
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] Ne... | 2022-07-06T12:54:17Z | second channel is no longer displayed on enocean switches with 2 channels
### The problem
since the update to 22.06, the second channel is no longer displayed on enocean switches with 2 channels.
I think the channel no. must be integrated in the unique id.
### What version of Home Assistant Core has the issue?
2022... | [enocean documentation](https://www.home-assistant.io/integrations/enocean)
[enocean source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/enocean)
<sub><sup>(message by IssueLinks)</sup></sub>
Hey there @bdurrer, mind taking a look at this issue as it has been labeled with an integration (`e... | [
{
"body": "### The problem\n\nsince the update to 22.06, the second channel is no longer displayed on enocean switches with 2 channels.\r\nI think the channel no. must be integrated in the unique id.\n\n### What version of Home Assistant Core has the issue?\n\n2022.06\n\n### What was the last working version of... | 687ac91947d2a17b730c6b520e378a5815ba8e98 | {
"head_commit": "811330d07b1f579459078fefbf501fc4497815e3",
"head_commit_message": "Migration of old unique id to new unique id",
"patch_to_review": "diff --git a/homeassistant/components/enocean/switch.py b/homeassistant/components/enocean/switch.py\nindex a53f691df19847..3989b9d131c142 100644\n--- a/homeassist... | [
{
"diff_hunk": "@@ -25,6 +27,26 @@\n )\n \n \n+def generate_unique_id(dev_id: list[int], channel: int) -> str:\n+ \"\"\"Generate a valid unique id.\"\"\"\n+ return f\"{combine_hex(dev_id)}{channel}\"\n+\n+\n+def _migrate_to_new_unique_id(hass: HomeAssistant, dev_id, channel) -> None:\n+ \"\"\"Migrate o... | 7cb370e46173ddbcf977913e771a20b1351320f1 | diff --git a/homeassistant/components/enocean/switch.py b/homeassistant/components/enocean/switch.py
index a53f691df19847..5edd2bb6155792 100644
--- a/homeassistant/components/enocean/switch.py
+++ b/homeassistant/components/enocean/switch.py
@@ -5,12 +5,14 @@
import voluptuous as vol
from homeassistant.components.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-64685@d081042 | getsentry/sentry | Python | 64,685 | ref(similarity-embedding): Add analytics for similar issue diff | Any time a user clicks on a diff on any of the issues in the Similar issues tab, we should log the following in an analytic event:
- Project and Org ids
- Issue ids for both issues
- Error messages for both issues
- Stacktraces for both issues
- transactions for both issues
closes https://github.com/getsentry... | 2024-02-06T19:27:58Z | Add analytics to similar issues diff
- Any time a user clicks on a diff on any of the issues in the Similar issues tab, we should log the following in an analytic event
- Project and Org ids
- Issue ids for both issues
- Error messages for both issues
- Stacktraces for both issues
- transactions for... | [
{
"body": "- Any time a user clicks on a diff on any of the issues in the Similar issues tab, we should log the following in an analytic event\n - Project and Org ids\n - Issue ids for both issues\n - Error messages for both issues\n - Stacktraces for both issues\n - transactions for both issues"... | b9adc3b9a1d126079c58afbb98aa921060cc4f28 | {
"head_commit": "d081042b71255c15fdf31c03398694e523569da9",
"head_commit_message": "ref(similarity-embedding): Add analytics for similar issue diff",
"patch_to_review": "diff --git a/static/app/components/issueDiff/index.spec.tsx b/static/app/components/issueDiff/index.spec.tsx\nindex e2b7c1cf64a958..e3c9bef4297... | [
{
"diff_hunk": "@@ -89,7 +132,16 @@ class IssueDiff extends Component<Props, State> {\n const event = await api.requestPromise(\n `/projects/${orgId}/${project.slug}/events/${paramEventId}/`\n );\n- return getStacktraceBody(event);\n+ return event;\n+ };\n+\n+ getTransaction = (tags: any[]... | 9d4614db2357d68d8b018cbd626861358d7387b4 | diff --git a/static/app/components/issueDiff/index.spec.tsx b/static/app/components/issueDiff/index.spec.tsx
index e2b7c1cf64a958..e3c9bef4297862 100644
--- a/static/app/components/issueDiff/index.spec.tsx
+++ b/static/app/components/issueDiff/index.spec.tsx
@@ -1,17 +1,21 @@
import {Entries123Base, Entries123Target} ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getmoto__moto-2962@e114eb9 | getmoto/moto | Python | 2,962 | Implement parentGroup, namePrefixFilter and recursive for list_thing_groups() | Closes #2961 | 2020-05-05T22:10:54Z | iot list_thing_groups is incomplete
Current implementation of list_thing_groups doesn't take into account any function inputs. These are the inputs listed in boto3.
```
response = client.list_thing_groups(
nextToken='string',
maxResults=123,
parentGroup='string',
namePrefixFilter='string',
re... | This is the output for a tree of groups in boto3, using `parentGroup=DeleteMePlease`:
```
{
"thingGroups": [
{
"groupName": "DeleteMePlease_sub_1",
},
{
"groupName": "DeleteMePlease_sub_2",
},
{
"groupName": "DeleteMePlease_sub_3... | [
{
"body": "Current implementation of list_thing_groups doesn't take into account any function inputs. These are the inputs listed in boto3.\r\n```\r\nresponse = client.list_thing_groups(\r\n nextToken='string',\r\n maxResults=123,\r\n parentGroup='string',\r\n namePrefixFilter='string',\r\n recur... | 323877c15de6efaaa098efd282b65729fa78d3eb | {
"head_commit": "e114eb9383e84099951ffad49af4d172d12863b1",
"head_commit_message": "Added test test_list_thing_groups()",
"patch_to_review": "diff --git a/moto/iot/models.py b/moto/iot/models.py\nindex 2e9979bda203..5b74b353cb21 100644\n--- a/moto/iot/models.py\n+++ b/moto/iot/models.py\n@@ -857,8 +857,30 @@ def... | [
{
"diff_hunk": "@@ -756,6 +756,140 @@ def test_delete_principal_thing():\n client.delete_certificate(certificateId=cert_id)\n \n \n+@mock_iot\n+def test_list_thing_groups():\n+ client = boto3.client(\"iot\", region_name=\"ap-northeast-1\")\n+ group_name_1a = \"my-group-name-1a\"\n+ group_name_1b = ... | 8bfc7ed76056c35528e306da383b3e0a1c270978 | diff --git a/moto/iot/models.py b/moto/iot/models.py
index 2e9979bda203..5b74b353cb21 100644
--- a/moto/iot/models.py
+++ b/moto/iot/models.py
@@ -857,8 +857,30 @@ def delete_thing_group(self, thing_group_name, expected_version):
del self.thing_groups[thing_group.arn]
def list_thing_groups(self, parent_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getmoto__moto-2949@2e0d3e1 | getmoto/moto | Python | 2,949 | Add support for BlockDeviceMappings argument | This PR adds a parser for BlockDeviceMappings argument that passed to `ec2_client.run_instances`
Fixes: https://github.com/spulec/moto/issues/418 | 2020-05-02T18:00:19Z | Add support for 'block_device-map' on instance creation
Currently on instance creation, only a "ghost" default block map is added, even if the 'block_device_map' argument is provided to 'run_instances'.
It would be good to have this default block device added to the EBSBackend instance, and better to respect the 'bloc... | Thanks for opening. This would be a great addition. Unfortunately, that is not a feature I currently use so it won't likely be high on my personal todo list. If someone else gets some time, a pull request would gladly be accepted.
Hi @spulec, just before starting to work on this one I want to make sure that duplicate ... | [
{
"body": "Currently on instance creation, only a \"ghost\" default block map is added, even if the 'block_device_map' argument is provided to 'run_instances'.\n\nIt would be good to have this default block device added to the EBSBackend instance, and better to respect the 'block_device_map' argument (adding to... | 9e7803dc3601427b8f195f715f07a76a23216749 | {
"head_commit": "2e0d3e1dadba90174e5faae555a77a335cbbbc7d",
"head_commit_message": "Add support for BlockDeviceMappings argument upon run_instances execution",
"patch_to_review": "diff --git a/moto/ec2/models.py b/moto/ec2/models.py\nindex e94d2877c990..6bc0e70329c7 100644\n--- a/moto/ec2/models.py\n+++ b/moto/e... | [
{
"diff_hunk": "@@ -891,8 +893,24 @@ def add_instances(self, image_id, count, user_data, security_group_names, **kwar\n new_instance.add_tags(instance_tags)\n if \"block_device_mappings\" in kwargs:\n for block_device in kwargs[\"block_device_mappings\"]:\n+ ... | af5da2e241535d89a8fef420856a68cb24c04cf6 | diff --git a/moto/ec2/models.py b/moto/ec2/models.py
index e94d2877c990..bab4636af731 100644
--- a/moto/ec2/models.py
+++ b/moto/ec2/models.py
@@ -560,8 +560,10 @@ def __del__(self):
# worst case we'll get IP address exaustion... rarely
pass
- def add_block_device(self, size, device_path)... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getmoto__moto-2709@8b3c2b6 | getmoto/moto | Python | 2,709 | throw ValidationError on non existing stack | Fixes #2708 | 2020-01-29T23:29:00Z | list_stack_resources throws NoneType when stack does not exist
```
2020-01-29T17:14:15:DEBUG:localstack.services.cloudformation.cloudformation_listener: Error response from CloudFormation (500) POST /: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>500 Internal Server Error</title>
<h1>Internal Serve... | [
{
"body": "```\r\n2020-01-29T17:14:15:DEBUG:localstack.services.cloudformation.cloudformation_listener: Error response from CloudFormation (500) POST /: <!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 3.2 Final//EN\">\r\n<title>500 Internal Server Error</title>\r\n<h1>Internal Server Error</h1>\r\n<p>The server encoun... | b6aeae0f2d6b479e1bcf1a6d839d668c822c2569 | {
"head_commit": "8b3c2b66544d82b91472fe3ad792ce5c18b773d3",
"head_commit_message": "fix test",
"patch_to_review": "diff --git a/moto/cloudformation/models.py b/moto/cloudformation/models.py\nindex 0ae5d1ae4170..c05783fb4242 100644\n--- a/moto/cloudformation/models.py\n+++ b/moto/cloudformation/models.py\n@@ -677... | [
{
"diff_hunk": "@@ -677,6 +677,8 @@ def update_stack(self, name, template, role_arn=None, parameters=None, tags=None\n \n def list_stack_resources(self, stack_name_or_id):\n stack = self.get_stack(stack_name_or_id)\n+ if stack is None:\n+ return []",
"line": null,
"original... | 800e5ab7d2e25970515b9612f6e998d9434e76d4 | diff --git a/moto/cloudformation/models.py b/moto/cloudformation/models.py
index 0ae5d1ae4170..b32d63b32496 100644
--- a/moto/cloudformation/models.py
+++ b/moto/cloudformation/models.py
@@ -677,6 +677,8 @@ def update_stack(self, name, template, role_arn=None, parameters=None, tags=None
def list_stack_resources(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
home-assistant__core-71288@e5d0b2a | home-assistant/core | Python | 71,288 | Handle empty zeroconf properties in devolo_home_network | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2022-05-04T12:18:56Z | Error doing job: Task exception was never retrieved / devolo_home_network
### The problem
HA 2022.4 is showing an error related to devolo home network even no devolo integration has been configured:
```
Logger: homeassistant
Source: components/devolo_home_network/config_flow.py:81
First occurred: 2:02:48 PM (1 o... | [devolo_home_network documentation](https://www.home-assistant.io/integrations/devolo_home_network)
[devolo_home_network source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/devolo_home_network)
<sub><sup>(message by IssueLinks)</sup></sub>
Hey there @2fake, @shutgun, mind taking a look at t... | [
{
"body": "### The problem\n\nHA 2022.4 is showing an error related to devolo home network even no devolo integration has been configured:\r\n\r\n```\r\nLogger: homeassistant\r\nSource: components/devolo_home_network/config_flow.py:81\r\nFirst occurred: 2:02:48 PM (1 occurrences)\r\nLast logged: 2:02:48 PM\r\n\... | 6eef3c16f2ed74e3ec1f89a51d88a1ba5c01c6ff | {
"head_commit": "e5d0b2a6995ced6e1a049ba0f68ca785e8d3c45b",
"head_commit_message": "Handle empty zeroconf properties in devolo_home_network",
"patch_to_review": "diff --git a/homeassistant/components/devolo_home_network/config_flow.py b/homeassistant/components/devolo_home_network/config_flow.py\nindex c96126f43... | [
{
"diff_hunk": "@@ -78,6 +78,12 @@ async def async_step_zeroconf(\n self, discovery_info: zeroconf.ZeroconfServiceInfo\n ) -> FlowResult:\n \"\"\"Handle zeroconf discovery.\"\"\"\n+ if (\n+ \"MT\" not in discovery_info.properties",
"line": null,
"original_line": 82,... | 6e6fb4f9fdef6cb31ff312d761b6dbfc98f0264b | diff --git a/homeassistant/components/devolo_home_network/manifest.json b/homeassistant/components/devolo_home_network/manifest.json
index a514606a322250..445a383ea146a4 100644
--- a/homeassistant/components/devolo_home_network/manifest.json
+++ b/homeassistant/components/devolo_home_network/manifest.json
@@ -4,7 +4,9 ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
huggingface__diffusers-11115@1161bcb | huggingface/diffusers | Python | 11,115 | AutoModel | # What does this PR do?
Fixes #10059
## Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
| 2025-03-19T08:22:07Z | [core] introduce `AutoModel`
Now that we have quite a few model classes (and transformer model classes), I wonder if it makes sense to have an AutoModel class. Oftentimes, users initialize the model separately and pass it to a `DiffusionPipeline`:
```py
transformer = "..."
pipeline = DiffusionPipeline.from_pretrai... | [
{
"body": "Now that we have quite a few model classes (and transformer model classes), I wonder if it makes sense to have an AutoModel class. Oftentimes, users initialize the model separately and pass it to a `DiffusionPipeline`:\r\n\r\n```py\r\ntransformer = \"...\"\r\npipeline = DiffusionPipeline.from_pretrai... | 9ee3dd38626624e063a738b220d81ab6df271fdc | {
"head_commit": "1161bcb33ab8bfc70a513ca464d5df00fb15f975",
"head_commit_message": "Merge branch 'main' into auto-model",
"patch_to_review": "diff --git a/src/diffusers/__init__.py b/src/diffusers/__init__.py\nindex 9304c34b4e01..2670caa2a830 100644\n--- a/src/diffusers/__init__.py\n+++ b/src/diffusers/__init__.... | [
{
"diff_hunk": "@@ -0,0 +1,311 @@\n+# Copyright 2025 The HuggingFace Team. All rights reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache... | 531275ba937406a08bebba1584f98acc8143a08c | diff --git a/src/diffusers/__init__.py b/src/diffusers/__init__.py
index 9304c34b4e01..3c7e8654d223 100644
--- a/src/diffusers/__init__.py
+++ b/src/diffusers/__init__.py
@@ -155,6 +155,7 @@
"AutoencoderKLWan",
"AutoencoderOobleck",
"AutoencoderTiny",
+ "AutoModel",
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
home-assistant__core-70964@82d4f73 | home-assistant/core | Python | 70,964 | Add unique_id attribute to Alpha2Climate entity | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
... | 2022-04-28T06:15:16Z | integration: moehlenhoff_alpha2 unique_id area missing
### The problem
The entities created by the:"integration: moehlenhoff_alpha2" are missing an unique id, I cannot assign them to an area
### What version of Home Assistant Core has the issue?
Home Assistant 2022.4.6
### What was the last working version of Home ... | Hey there @j-a-n, mind taking a look at this issue as it has been labeled with an integration (`moehlenhoff_alpha2`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L629) for? Thanks!
<sub><sup>(message by CodeOwnersMention)</sup></sub>
---
[moehlenhoff_alpha2 documentation... | [
{
"body": "### The problem\n\nThe entities created by the:\"integration: moehlenhoff_alpha2\" are missing an unique id, I cannot assign them to an area\n\n### What version of Home Assistant Core has the issue?\n\nHome Assistant 2022.4.6\n\n### What was the last working version of Home Assistant Core?\n\n_No res... | e6da1d73183d5fc6686718649a1524ab552661b0 | {
"head_commit": "82d4f73fbf40dfed51fc8b480d1192827c94b201",
"head_commit_message": "Use heat_area_id directly",
"patch_to_review": "diff --git a/homeassistant/components/moehlenhoff_alpha2/climate.py b/homeassistant/components/moehlenhoff_alpha2/climate.py\nindex 71be199b622a5..9707591f74a01 100644\n--- a/homeas... | [
{
"diff_hunk": "@@ -50,6 +50,7 @@ def __init__(self, coordinator: Alpha2BaseCoordinator, heat_area_id: str) -> Non\n \"\"\"Initialize Alpha2 ClimateEntity.\"\"\"\n super().__init__(coordinator)\n self.heat_area_id = heat_area_id\n+ self._attr_unique_id = f\"{heat_area_id}:climate\... | 10317dae1862eadfc86c8044346633a5df974891 | diff --git a/homeassistant/components/moehlenhoff_alpha2/climate.py b/homeassistant/components/moehlenhoff_alpha2/climate.py
index 71be199b622a5b..225735293ca4d8 100644
--- a/homeassistant/components/moehlenhoff_alpha2/climate.py
+++ b/homeassistant/components/moehlenhoff_alpha2/climate.py
@@ -50,6 +50,7 @@ def __init_... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-2488@05dc97b | getmoto/moto | Python | 2,488 | Add sqs error handling | I had to rewrite `sqs.send_message_batch` a bit to be able to handle most errors.
Also fixes #1799
Over time I will also check other functions in the SQS implementation and update the coverage file while doing so.
| 2019-10-17T20:46:54Z | Moto should raise an error when SQS send_message_batch pass an empty entries
When doing `client.send_message_batch(QueueUrl=queue_url, Entries=[])`, boto will raise an error.
```
Traceback (most recent call last):
File "<stdin>", line 3, in <module>
File "/Library/Frameworks/Python.framework/Versions/3.6/lib/... | Thanks; setting as a feature request. | [
{
"body": "When doing `client.send_message_batch(QueueUrl=queue_url, Entries=[])`, boto will raise an error.\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 3, in <module>\r\n File \"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/botocore/client.py\",... | 36a8a4ad00a6983ec6afc8bb6f77afa2a035389b | {
"head_commit": "05dc97b468cdfbb05686966444e2ed9c4dff4e3d",
"head_commit_message": "Update implementation coverage",
"patch_to_review": "diff --git a/IMPLEMENTATION_COVERAGE.md b/IMPLEMENTATION_COVERAGE.md\nindex 57f169b8ab01..060f9f7a7ddd 100644\n--- a/IMPLEMENTATION_COVERAGE.md\n+++ b/IMPLEMENTATION_COVERAGE.m... | [
{
"diff_hunk": "@@ -397,6 +439,20 @@ def tag_queue(self):\n queue_name = self._get_queue_name()\n tags = self._get_map_prefix('Tag', key_end='.Key', value_end='.Value')\n \n+ try:\n+ self.sqs_backend.get_queue(queue_name)\n+ except QueueDoesNotExist as e:",
"line": n... | ed1c799bdcd2c6bd11d8a679014cbd21d0d36a12 | diff --git a/IMPLEMENTATION_COVERAGE.md b/IMPLEMENTATION_COVERAGE.md
index 57f169b8ab01..060f9f7a7ddd 100644
--- a/IMPLEMENTATION_COVERAGE.md
+++ b/IMPLEMENTATION_COVERAGE.md
@@ -5902,7 +5902,7 @@
- [x] untag_resource
## sqs
-65% implemented
+75% implemented
- [X] add_permission
- [X] change_message_visibility
-... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getmoto__moto-2547@ad23b65 | getmoto/moto | Python | 2,547 | AWS Lambda: Add Role validation when creating functions | Fixes #2546
Adds three validation steps for the IAM role when creating a Lambda function:
- Does the role follow the appropriate regex
- Does the role have the current account ID?
- Does the role exist? | 2019-11-07T17:13:18Z | AWS Lambda - Missing validation for roles when creating functions
When creating a Lambda function, there is no validation whether the role passed in actually exists/is valid.
Every test is set up like this:
```
conn.create_function(
....
Role="test-iam-role",
....
```
, circumventing the role-behavi... | [
{
"body": "When creating a Lambda function, there is no validation whether the role passed in actually exists/is valid.\r\nEvery test is set up like this:\r\n```\r\nconn.create_function(\r\n ....\r\n Role=\"test-iam-role\",\r\n ....\r\n```\r\n, circumventing the role-behaviour entirely.\r\n\r\nPR to ad... | 502957f1f9560cb6dff75271e6812498f4ff7bba | {
"head_commit": "ad23b6578430c2d690f12da0f4d87744e46beadb",
"head_commit_message": "Implement CloudFormations IAMRole::GetArn",
"patch_to_review": "diff --git a/moto/awslambda/models.py b/moto/awslambda/models.py\nindex a58582599339..2f00fa94e5ba 100644\n--- a/moto/awslambda/models.py\n+++ b/moto/awslambda/model... | [
{
"diff_hunk": "@@ -667,6 +669,28 @@ def put_function(self, fn):\n :param fn: Function\n :type fn: LambdaFunction\n \"\"\"\n+ pattern = r\"arn:(aws[a-zA-Z-]*)?:iam::(\\d{12}):role/?[a-zA-Z_0-9+=,.@\\-_/]+\"\n+ valid_role = re.match(pattern, fn.role)\n+ if valid_role:... | 8362179f70c5553b81c8c8cc60bc687238bb8db9 | diff --git a/moto/awslambda/exceptions.py b/moto/awslambda/exceptions.py
new file mode 100644
index 000000000000..1a82977c336f
--- /dev/null
+++ b/moto/awslambda/exceptions.py
@@ -0,0 +1,31 @@
+from botocore.client import ClientError
+
+
+class LambdaClientError(ClientError):
+ def __init__(self, error, message):
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getmoto__moto-1344@e1a3676 | getmoto/moto | Python | 1,344 | Lambda improvements | Fixes #1338
Completely revamped how lambdas are stored, now we have lambda publishing working and aliasing should be trivial to add, attempted to spam `weakref` everywhere but I have a feeling my debugger was messing with the refs so theres more boilerplate code that I would of expected.
Done the majority of thi... | 2017-11-16T00:12:21Z | lambda doesn't support get function by name and version
When calling the get_function API and specifying the version in the qualifier parameter, the call throws a ClientError('An error occurred (404) when calling the GetFunction operation: ')
function_data = client.get_function(FunctionName="my_func", Qualifier="$L... | You mind providing a simple test case?
```
import unittest
import boto3
import zipfile
import io
from moto import mock_lambda
def _process_lambda(func_str):
zip_output = io.BytesIO()
zip_file = zipfile.ZipFile(zip_output, 'w', zipfile.ZIP_DEFLATED)
zip_file.writestr('lambda_function.py', func_s... | [
{
"body": "When calling the get_function API and specifying the version in the qualifier parameter, the call throws a ClientError('An error occurred (404) when calling the GetFunction operation: ') \r\n\r\nfunction_data = client.get_function(FunctionName=\"my_func\", Qualifier=\"$LATEST\") \r\n\r\n\r\nLooking ... | cdb7305dac6f9089236539133f6c8eab1ec9dd55 | {
"head_commit": "e1a3676859a9bc7995036e21896b491a12900ec7",
"head_commit_message": "Fixes",
"patch_to_review": "diff --git a/moto/awslambda/models.py b/moto/awslambda/models.py\nindex 6306acd5c5bf..d3657dc7774e 100644\n--- a/moto/awslambda/models.py\n+++ b/moto/awslambda/models.py\n@@ -2,6 +2,7 @@\n \n import ba... | [
{
"diff_hunk": "@@ -515,23 +636,31 @@ def send_message(self, function_name, message):\n ]\n \n }\n- self._functions[function_name].invoke(json.dumps(event), {}, {})\n+ self._functions[function_name][-1].invoke(json.dumps(event), {}, {})\n pass\n \n def list_tags(sel... | a94cfd272d4b12cb817122220e505bb8b0123330 | diff --git a/moto/awslambda/models.py b/moto/awslambda/models.py
index 6306acd5c5bf..6f31a2611213 100644
--- a/moto/awslambda/models.py
+++ b/moto/awslambda/models.py
@@ -2,6 +2,7 @@
import base64
from collections import defaultdict
+import copy
import datetime
import docker.errors
import hashlib
@@ -17,18 +18,2... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-63630@6bc9bb5 | getsentry/sentry | Python | 63,630 | ref(slack): Add suggested assignees | Adds suggested assignees as a context block to the new Slack issue alerts. Closes #62901
| 2024-01-22T22:53:24Z | Display issue assignee if available, suggested assignees if not
Add the issue assignee to issue alerts if available, or show the suggested assignees (if available). If there are no suggested assignees, just show "unassigned". Render the user's email / team name rather than doing `@colleen` for example, so as to not not... | [
{
"body": "Add the issue assignee to issue alerts if available, or show the suggested assignees (if available). If there are no suggested assignees, just show \"unassigned\". Render the user's email / team name rather than doing `@colleen` for example, so as to not notify multiple suggested assignees in Slack."... | b0877ea839d3b2298b5331f2d73ce557be8c6a23 | {
"head_commit": "6bc9bb500ddfc05e76b2840987ad1d8aede264d7",
"head_commit_message": "remove duplicate func from merge",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/group_details.py b/src/sentry/api/endpoints/group_details.py\nindex 085ec1ba82dece..14b80c46e49601 100644\n--- a/src/sentry/api/endpoint... | [
{
"diff_hunk": "@@ -409,6 +424,121 @@ def test_build_group_attachment_issue_alert_block_kit(self):\n for section in ret[\"blocks\"]:\n assert section[\"type\"] != \"actions\"\n \n+ @with_feature(\"organizations:slack-block-kit\")\n+ @with_feature(\"organizations:streamline-targeting-co... | f6d3e8c89ecf8e1726e0a71687abc88231b94351 | diff --git a/src/sentry/integrations/slack/message_builder/issues.py b/src/sentry/integrations/slack/message_builder/issues.py
index 1cc354561f6eae..fd3176aad5d433 100644
--- a/src/sentry/integrations/slack/message_builder/issues.py
+++ b/src/sentry/integrations/slack/message_builder/issues.py
@@ -1,5 +1,6 @@
from __f... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__diffusers-10746@154f34d | huggingface/diffusers | Python | 10,746 | Extend Support for callback_on_step_end for AuraFlow and LuminaText2Img Pipelines | # What does this PR do?
I have extended the `callback_on_step_end` parameter to AuraFlow and LuminaText2Img Pipelines. Please let me know if any further corrections are needed and I will make the necessary changes.
Fixes #10672
## Before submitting
- [x] Did you read the [contributor guideline](https://githu... | 2025-02-07T19:13:55Z | Please support callback_on_step_end for following pipelines
**Is your feature request related to a problem? Please describe.**
Missing callback_on_step_end in these pipeline takes away the capability to show the progress in UI
**Describe the solution you'd like.**
Please support callback_on_step_end
**Describe altern... | hi @nitinmukesh
yes indeed! would you like to open a PR for this?
I wish. unfortunately I am just a Claude/ChatGPT developer so difficult for me to contribute in a big and complex project like this.
I am creating a basic WebUI for Windows / Low VRAM users who find Comfy difficult to use (including me)
https://githu... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\nMissing callback_on_step_end in these pipeline takes away the capability to show the progress in UI\n\n**Describe the solution you'd like.**\nPlease support callback_on_step_end\n\n**Describe alternatives you've considered.**\nN.A.\n... | d90cd3621dc9aea168ec928ff3aa9b977eb49c20 | {
"head_commit": "154f34d7dbf89bdf3aa1ae23ee0230f1269a3556",
"head_commit_message": "Apply suggestions from code review-2\n\nCo-authored-by: hlky <hlky@hlky.ac>",
"patch_to_review": "diff --git a/src/diffusers/pipelines/aura_flow/pipeline_aura_flow.py b/src/diffusers/pipelines/aura_flow/pipeline_aura_flow.py\nind... | [
{
"diff_hunk": "@@ -644,6 +658,8 @@ def __call__(\n max_sequence_length: int = 256,\n scaling_watershed: Optional[float] = 1.0,\n proportional_attn: Optional[bool] = True,\n+ callback_on_step_end: Optional[Callable[[int, int, Dict], None]] = None,",
"line": null,
"original... | 3546916ff06bdcca2da2d1670b18411ef1d082f9 | diff --git a/src/diffusers/pipelines/aura_flow/pipeline_aura_flow.py b/src/diffusers/pipelines/aura_flow/pipeline_aura_flow.py
index a3677e6a5a39..ea60e66d2db9 100644
--- a/src/diffusers/pipelines/aura_flow/pipeline_aura_flow.py
+++ b/src/diffusers/pipelines/aura_flow/pipeline_aura_flow.py
@@ -12,11 +12,12 @@
# See th... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-63529@288a4ee | getsentry/sentry | Python | 63,529 | feat(feedback): Poll for new feedbacks, and show a message so people can load them in | This PR adds code that polls in the background, every 30second when the feedback page is open, to see if there are newer feedbacks available.
Polling disables itself once it discovers that one new item is available (we're not asking for a count of new things).
Polling won't start if the user picks an absolute date... | 2024-01-19T20:40:56Z | [User Feedback] There should be a button/way to refresh the list of feedbacks when the page has been open for a while
Like a button to refresh the list, and/or a background fetch that looks for new data, the reveals an alert at the top of the list: "new data arrived, click to load". That kind of thing. | [
{
"body": "Like a button to refresh the list, and/or a background fetch that looks for new data, the reveals an alert at the top of the list: \"new data arrived, click to load\". That kind of thing.",
"number": 61474,
"title": "[User Feedback] There should be a button/way to refresh the list of feedback... | 124637be727def243e5d87eaa502cbd99ca47a1e | {
"head_commit": "288a4eea35db3571275c24de09d7f681d82d91cf",
"head_commit_message": "rm all AlertLink changes",
"patch_to_review": "diff --git a/static/app/components/feedback/list/feedbackListHeader.tsx b/static/app/components/feedback/list/feedbackListHeader.tsx\nindex d76b4544f15720..906341ceae42ce 100644\n---... | [
{
"diff_hunk": "@@ -0,0 +1,31 @@\n+import {useEffect, useState} from 'react';\n+\n+import {ApiQueryKey, useApiQuery} from 'sentry/utils/queryClient';\n+\n+interface Props {\n+ listPrefetchQueryKey: ApiQueryKey | undefined;\n+}\n+\n+const POLLING_INTERVAL_MS = 10 * 1000;",
"line": null,
"original_line":... | 3fa6fd9c957047b6135702c5ac2fd06d9584a060 | diff --git a/static/app/components/feedback/list/feedbackListHeader.tsx b/static/app/components/feedback/list/feedbackListHeader.tsx
index d76b4544f15720..906341ceae42ce 100644
--- a/static/app/components/feedback/list/feedbackListHeader.tsx
+++ b/static/app/components/feedback/list/feedbackListHeader.tsx
@@ -1,11 +1,1... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-63484@20fc523 | getsentry/sentry | Python | 63,484 | ref(replay): Extract the ReplaySection to its own file and update logic | The logic inside the ternary's was getting a little difficult to follow. So I broke it out into it's own file with return statements to make it easier to read.
The basic text output looks like this when rendered "No replay captured" in this case:
@billyvg
> it's a bit jarring to have Linked Replay section appear after a few seconds -- we should probably always show the header and give it a loading state (as well as all the other states)... | Routing to @getsentry/product-owners-user-feedback for [triage](https://develop.sentry.dev/processing-tickets/#3-triage) ⏲️ | [
{
"body": "@billyvg \r\n\r\n> it's a bit jarring to have Linked Replay section appear after a few seconds -- we should probably always show the header and give it a loading state (as well as all the other states) instead of having it appear only if there is a linked replay",
"number": 61426,
"title": "[... | 88850793e9c962dbba01d77d335b27ebf41fb224 | {
"head_commit": "20fc5238874f98888832aa4831a790ce4db74b8a",
"head_commit_message": "ref(replay): Extract the ReplaySection to its own file and update logic",
"patch_to_review": "diff --git a/static/app/components/feedback/feedbackItem/feedbackItem.tsx b/static/app/components/feedback/feedbackItem/feedbackItem.ts... | [
{
"diff_hunk": "@@ -0,0 +1,52 @@\n+import {Fragment} from 'react';\n+\n+import ErrorBoundary from 'sentry/components/errorBoundary';\n+import ReplayInlineCTAPanel from 'sentry/components/feedback/feedbackItem/replayInlineCTAPanel';\n+import ReplaySection from 'sentry/components/feedback/feedbackItem/replaySecti... | 1aeb947e2546773f2b98b4eacfb095030aa087c7 | diff --git a/static/app/components/events/eventReplay/replayPreview.tsx b/static/app/components/events/eventReplay/replayPreview.tsx
index 5ec889bf0bd09b..f4f7d29b1b45ea 100644
--- a/static/app/components/events/eventReplay/replayPreview.tsx
+++ b/static/app/components/events/eventReplay/replayPreview.tsx
@@ -3,17 +3,1... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
home-assistant__core-70256@93b88a5 | home-assistant/core | Python | 70,256 | Screenlogic config: Filter unexpected host names | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug
or... | 2022-04-18T23:32:00Z | ScreenLogic Integration Fails to Load
### The problem
Under Integrations, I am attempting to add Pentair ScreenLogic from the UI. It starts to process but then errors out with “Config flow could not be loaded: undefined”. When I check the logs, I see the following error.
File "/usr/local/lib/python3.9/site-pack... | @bdraco - would you mind taking a look at this. You seemed to fix a similar issue the other day.
[screenlogic documentation](https://www.home-assistant.io/integrations/screenlogic)
[screenlogic source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/screenlogic)
<sub><sup>(message by IssueLink... | [
{
"body": "### The problem\n\nUnder Integrations, I am attempting to add Pentair ScreenLogic from the UI. It starts to process but then errors out with “Config flow could not be loaded: undefined”. When I check the logs, I see the following error.\r\n\r\n File \"/usr/local/lib/python3.9/site-packages/aiohttp... | e70c8fa35984de5e7c65aef176e6f0b01c40bfd0 | {
"head_commit": "93b88a5fd841205a9bb024ea43ec0f85671bcd51",
"head_commit_message": "Check for \"Pentair:\" and poll for mac",
"patch_to_review": "diff --git a/homeassistant/components/screenlogic/config_flow.py b/homeassistant/components/screenlogic/config_flow.py\nindex 260317dca11900..e34597c3ae9334 100644\n--... | [
{
"diff_hunk": "@@ -35,17 +35,22 @@ async def async_discover_gateways_by_unique_id(hass):\n return discovered_gateways\n \n for host in hosts:\n- mac = _extract_mac_from_name(host[SL_GATEWAY_NAME])\n- discovered_gateways[mac] = host\n+ if host[SL_GATEWAY_NAME].startswith(\"Penta... | c1eb756a4c44804b7d75c6445bbff3c4fefa6eb8 | diff --git a/homeassistant/components/screenlogic/config_flow.py b/homeassistant/components/screenlogic/config_flow.py
index 260317dca1190..1aeedfb421de2 100644
--- a/homeassistant/components/screenlogic/config_flow.py
+++ b/homeassistant/components/screenlogic/config_flow.py
@@ -35,8 +35,9 @@ async def async_discover_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__diffusers-10363@d62d3c8 | huggingface/diffusers | Python | 10,363 | IP-Adapter support for `StableDiffusion3ControlNetPipeline` | # What does this PR do?
Inherit from `SD3IPAdapterMixin` to allow image prompting.
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent ... | 2024-12-23T16:53:42Z | Does StableDiffusion3 have an image2image pipeline with ControlNet?
I want to use `ControlNet` with `StableDiffusion3`, providing a prompt, an original image, and a control image as inputs. However, I found that the `StableDiffusion3ControlNetPipeline` only supports prompts and control images as inputs. The `StableDiff... | Image prompting via IP Adapters is being integrated into SD3.5 pipelines in #9966, and should also come to `StableDiffusion3ControlNetImg2ImgPipeline` when merged (PR in progress) | [
{
"body": "I want to use `ControlNet` with `StableDiffusion3`, providing a prompt, an original image, and a control image as inputs. However, I found that the `StableDiffusion3ControlNetPipeline` only supports prompts and control images as inputs. The `StableDiffusionControlNetImg2ImgPipeline` allows for provid... | 91008aabc4b8dbd96a356ab6f457f3bd84b10e8b | {
"head_commit": "d62d3c860a2da86811de83e938fc9e8bfbcdbb24",
"head_commit_message": "Merge branch 'main' into sd3-controlnet-ipadapter",
"patch_to_review": "diff --git a/src/diffusers/pipelines/controlnet_sd3/pipeline_stable_diffusion_3_controlnet.py b/src/diffusers/pipelines/controlnet_sd3/pipeline_stable_diffus... | [
{
"diff_hunk": "@@ -727,6 +739,83 @@ def num_timesteps(self):\n def interrupt(self):\n return self._interrupt\n \n+ # Copied from diffusers.pipelines.stable_diffusion_3.pipeline_stable_diffusion_3.StableDiffusion3Pipeline.encode_image\n+ def encode_image(self, image: PipelineImageInput, device... | 61f12beb4b2f36d9650bce7821ed19ddb3e5f123 | diff --git a/src/diffusers/pipelines/controlnet_sd3/pipeline_stable_diffusion_3_controlnet.py b/src/diffusers/pipelines/controlnet_sd3/pipeline_stable_diffusion_3_controlnet.py
index 1de7ba424d54..4e135f9391dd 100644
--- a/src/diffusers/pipelines/controlnet_sd3/pipeline_stable_diffusion_3_controlnet.py
+++ b/src/diffus... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-64142@d63e6a9 | getsentry/sentry | Python | 64,142 | feat(ddm): Hide blocked metrics of projects | This PR adds new logic to automatically remove `projects` from a query, if the metric(s) in that query are blocked for at least one of the supplied projects.
The new logic works in the following way:
1. Before execution, an efficient internal representation of blocked metrics for projects is loaded from project set... | 2024-01-30T08:10:44Z | Hide projects when querying a metric that is blocked for those projects
We would like to add some logic to the `metrics/api` that removes project ids of the projects that have a certain metric blocked. The idea is that we don't want to return the data of project `x` if metric `y` for `x` is blocked. | [
{
"body": "We would like to add some logic to the `metrics/api` that removes project ids of the projects that have a certain metric blocked. The idea is that we don't want to return the data of project `x` if metric `y` for `x` is blocked.",
"number": 64059,
"title": "Hide projects when querying a metri... | 1f687b72bf714e6a8aa9033a7d80b3a7e7401a98 | {
"head_commit": "d63e6a9757ae5f52c8155c54dedbc5c088621a11",
"head_commit_message": "Add metric",
"patch_to_review": "diff --git a/src/sentry/sentry_metrics/querying/data/api.py b/src/sentry/sentry_metrics/querying/data/api.py\nindex 2f2d3bb049b364..346e0beac8a711 100644\n--- a/src/sentry/sentry_metrics/querying/... | [
{
"diff_hunk": "@@ -179,6 +187,34 @@ def add_group_filters(\n ),\n )\n \n+ def merge_with_blocked_projects(",
"line": null,
"original_line": 190,
"original_start_line": null,
"path": "src/sentry/sentry_metrics/querying/data/execution.py",
"start_line": null,
"text"... | 1a3ac38da1f9377dc75d17da099089a754f8c4d6 | diff --git a/src/sentry/sentry_metrics/querying/data/api.py b/src/sentry/sentry_metrics/querying/data/api.py
index 1ad1d9fbee0fe6..fc1229e644902d 100644
--- a/src/sentry/sentry_metrics/querying/data/api.py
+++ b/src/sentry/sentry_metrics/querying/data/api.py
@@ -38,7 +38,7 @@ def run_metrics_query(
)
# We p... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
home-assistant__core-69134@2f44443 | home-assistant/core | Python | 69,134 | Drop upnp options flow | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
The Options flow is removed!
## Proposed change
<!--
Describe the big picture of your changes here to communicate to the
maintainers why we sh... | 2022-04-02T14:30:58Z | UPnP integration issue since 2022.3.8
### The problem
The UPnP won't load the connection with my router (TP-Link Archer C80). Router config is the same and I just re-checked, UPnP is enabled.
### What version of Home Assistant Core has the issue?
core-2022.3.8
### What was the last working version of Home Assistant... | Hey there @stevenlooman, @ehendrix23, mind taking a look at this issue as it has been labeled with an integration (`upnp`) you are listed as a [code owner](https://github.com/home-assistant/core/blob/dev/CODEOWNERS#L1081) for? Thanks!
<sub><sup>(message by CodeOwnersMention)</sup></sub>
---
[upnp documentation](https... | [
{
"body": "### The problem\n\nThe UPnP won't load the connection with my router (TP-Link Archer C80). Router config is the same and I just re-checked, UPnP is enabled.\n\n### What version of Home Assistant Core has the issue?\n\ncore-2022.3.8\n\n### What was the last working version of Home Assistant Core?\n\n_... | 507643741376ab522df8d1c1294b40b9f56995a6 | {
"head_commit": "2f44443de30ac1814685b346ccf9bc00bb184fb3",
"head_commit_message": "Don't try to update the coordinator when it is not there",
"patch_to_review": "diff --git a/homeassistant/components/upnp/config_flow.py b/homeassistant/components/upnp/config_flow.py\nindex e339c69d5d8b8..346fa50972fac 100644\n-... | [
{
"diff_hunk": "@@ -294,14 +294,22 @@ def __init__(self, config_entry: config_entries.ConfigEntry) -> None:\n \n async def async_step_init(self, user_input: Mapping = None) -> FlowResult:\n \"\"\"Manage the options.\"\"\"\n+ LOGGER.debug(\n+ \"UpnpOptionsFlowHandler.async_step_init... | 07e5dd7519992ae1e157c427797bdda38ccb0604 | diff --git a/homeassistant/components/upnp/__init__.py b/homeassistant/components/upnp/__init__.py
index e15c90c7079b9..f4aa6137fefd0 100644
--- a/homeassistant/components/upnp/__init__.py
+++ b/homeassistant/components/upnp/__init__.py
@@ -31,7 +31,6 @@
from .const import (
CONF_LOCAL_IP,
CONFIG_ENTRY_HOSTN... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-63616@cae8e2f | getsentry/sentry | Python | 63,616 | feat(inbound-filters): Update settings page to show new legacy browser filters | this pr updates the inbound filters settings page to show the new legacy browser filters. Showing the new filters will be controlled by feature flag.
There are a few scenarios covered in this update. If the feature flag is off, then only the old filters will be shown. If the flag is on, the new filters will be show... | 2024-01-22T19:44:23Z | Update settings page to show new filters
Update the settings page to show the new filters. This will be rolled out gradually. users with existing filters will be shown the new filter as being on and will still be able to turn off the filter. | [
{
"body": "Update the settings page to show the new filters. This will be rolled out gradually. users with existing filters will be shown the new filter as being on and will still be able to turn off the filter.",
"number": 63057,
"title": "Update settings page to show new filters"
}
] | 48a309a8b5828ce3f5fa12a9d43cb0e66e77b0f0 | {
"head_commit": "cae8e2fe1252dfe26ff9601e2dad8145f258c717",
"head_commit_message": "fix test",
"patch_to_review": "diff --git a/static/app/views/settings/project/projectFilters/index.spec.tsx b/static/app/views/settings/project/projectFilters/index.spec.tsx\nindex 4af37962f14098..6abc2246029f6d 100644\n--- a/sta... | [
{
"diff_hunk": "@@ -189,48 +259,65 @@ class LegacyBrowserFilterRow extends Component<RowProps, RowState> {\n return (\n <div>\n {!disabled && (\n- <BulkFilter>\n- <BulkFilterLabel>{t('Filter')}:</BulkFilterLabel>\n- <ButtonBar gap={1}>\n- <Button\n- ... | c49f42be46fe850801660b9cbaebd641285f7130 | diff --git a/static/app/views/settings/project/projectFilters/index.spec.tsx b/static/app/views/settings/project/projectFilters/index.spec.tsx
index 4af37962f14098..6abc2246029f6d 100644
--- a/static/app/views/settings/project/projectFilters/index.spec.tsx
+++ b/static/app/views/settings/project/projectFilters/index.sp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
hummingbot__hummingbot-4889@d8a242a | hummingbot/hummingbot | Python | 4,889 | Fix/mexc modify python connector | Python-only implementation. Refer to Ndax.
Usage of NetworkMockingAssistant and aioresponses module for unit testing. Refer to Ndax unit tests.
Single websocket connection for public websocket channels. Refer to NdaxAPIOrderBookDataSource.listen_for_order_book_diffs or
CryptoComAPIOrderBookDataSource
Shared aiohttp... | 2021-12-09T06:47:14Z | Implement changes to MEXC connector
Before the December release, MEXC connector should be updated to conform with the standards of integrating a new connector into our codebase.
The following changes needs to be made by the MEXC team:
1. Python-only implementation. Refer to Ndax.
2. Usage of `NetworkMockingAssis... | [
{
"body": "Before the December release, MEXC connector should be updated to conform with the standards of integrating a new connector into our codebase.\r\n\r\nThe following changes needs to be made by the MEXC team:\r\n\r\n1. Python-only implementation. Refer to Ndax.\r\n2. Usage of `NetworkMockingAssistant` a... | e127fa59d2b8cf095bfb79ac7dabdad78c02dfc7 | {
"head_commit": "d8a242a309800370e2cdddf26ca9545de5e46af9",
"head_commit_message": "check f-string flake8 error",
"patch_to_review": "diff --git a/hummingbot/connector/exchange/mexc/constants.py b/hummingbot/connector/exchange/mexc/constants.py\ndeleted file mode 100644\nindex 32ace8e84d0..00000000000\n--- a/hum... | [
{
"diff_hunk": "@@ -0,0 +1,1171 @@\n+import asyncio\n+import time\n+import pandas as pd\n+\n+import ujson\n+from decimal import Decimal\n+from typing import Any, Dict, List\n+from unittest import TestCase\n+from unittest.mock import AsyncMock, PropertyMock, patch\n+\n+from hummingbot.connector.exchange.mexc.mex... | b22ab74b1f6d38bd714d5c5a9b6456e52cf9c175 | diff --git a/hummingbot/connector/exchange/mexc/constants.py b/hummingbot/connector/exchange/mexc/constants.py
deleted file mode 100644
index 32ace8e84d0..00000000000
--- a/hummingbot/connector/exchange/mexc/constants.py
+++ /dev/null
@@ -1,21 +0,0 @@
-
-# URLs
-
-MEXC_BASE_URL = "https://www.mexc.com"
-
-MEXC_SYMBOL_U... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-62928@2dad4a5 | getsentry/sentry | Python | 62,928 | feat(ddm): Change ddm to a metric explorer experience | Move query builder controls to top of page.
Add identification symbols to queries.
<img width="1710" alt="Screenshot 2024-01-10 at 17 08 02" src="https://github.com/getsentry/sentry/assets/7033940/a45437a9-0e22-4f31-9df8-a7899784c576">
- closes https://github.com/getsentry/sentry/issues/62735
- closes https://g... | 2024-01-10T16:08:40Z | Have just one full-width widget and move controls (Metric, Op, Group, Filter) out of it and put them under page filters on one line, with an option to add another query (which would add a second chart).
Leave the display dropdown in the chart next to the three dots or move it inside the three dots.
Consider differe... | [
{
"body": "",
"number": 62735,
"title": "Have just one full-width widget and move controls (Metric, Op, Group, Filter) out of it and put them under page filters on one line, with an option to add another query (which would add a second chart)."
},
{
"body": "",
"number": 62736,
"title": ... | 1cae3d7f043b5637dcc41fbd3c334c4665ff5a11 | {
"head_commit": "2dad4a5f4795f40899b063abc1638a3cd5428f61",
"head_commit_message": "fix(tests): Add missing mock response",
"patch_to_review": "diff --git a/static/app/utils/metrics/index.tsx b/static/app/utils/metrics/index.tsx\nindex e2828adb5cc43a..255096ed7c4f09 100644\n--- a/static/app/utils/metrics/index.t... | [
{
"diff_hunk": "@@ -0,0 +1,39 @@\n+import styled from '@emotion/styled';\n+\n+const indexToChar = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';\n+\n+export const getQuerySymbol = (index: number) => {\n+ let result = '';\n+ let i = index;\n+ do {\n+ result = indexToChar[i % indexToChar.length] + result;\n+ i = Math.flo... | 8c6941123ed94556f756092ae9a6f10adbc3a1fb | diff --git a/static/app/utils/metrics/index.tsx b/static/app/utils/metrics/index.tsx
index e2828adb5cc43a..255096ed7c4f09 100644
--- a/static/app/utils/metrics/index.tsx
+++ b/static/app/utils/metrics/index.tsx
@@ -66,7 +66,30 @@ export enum MetricDisplayType {
TABLE = 'table',
}
-export const defaultMetricDispla... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
home-assistant__core-69030@8785dda | home-assistant/core | Python | 69,030 | Fix network starting with no configured IPv4 addresses | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Proposed change
A previous fix for a bug that happens when no IPv4 addresses are available on the system added an explicit error when this happens. However, Home Assist... | 2022-03-31T19:59:37Z | Fails to start on ipv6 only host
### The problem
Homeassistant is being run as a container on kubernetes w/ an ipv6 only network stack. The http server startup is failing due to not having any ipv4 addresses. This is seen on first startup, with no custom configurations or integrations enabled.
### What version of Hom... | [http documentation](https://www.home-assistant.io/integrations/http)
[http source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/http)
<sub><sup>(message by IssueLinks)</sup></sub>
Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (`h... | [
{
"body": "### The problem\n\nHomeassistant is being run as a container on kubernetes w/ an ipv6 only network stack. The http server startup is failing due to not having any ipv4 addresses. This is seen on first startup, with no custom configurations or integrations enabled.\n\n### What version of Home Assistan... | c79b361927525744881703e808ef03d0869e454e | {
"head_commit": "8785dda87f04ff19f15ead91493fac37145648e2",
"head_commit_message": "network: fix starting with no configured IPv4 addresses\n\nA previous fix for a bug that happens when no IPv4 addresses are available\non the system added an explicit error when this happens. However, Home\nAssistant can run just f... | [
{
"diff_hunk": "@@ -27,6 +27,21 @@ def _mock_socket(sockname):\n return mock_socket\n \n \n+def _mock_cond_socket(sockname):\n+ class CondMockSock(MagicMock):\n+ def connect(self, addr):\n+ \"\"\"Mock connect that stores addr.\"\"\"\n+ self._addr = addr[0]\n+\n+ def ge... | 5f8f94f3c512922174fe43eae2c8dae1650ac2b1 | diff --git a/homeassistant/components/network/__init__.py b/homeassistant/components/network/__init__.py
index 8c1a0020cfb4ff..1ad975e1d85d02 100644
--- a/homeassistant/components/network/__init__.py
+++ b/homeassistant/components/network/__init__.py
@@ -6,11 +6,16 @@
from homeassistant.core import HomeAssistant, ca... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__diffusers-10189@803e33f | huggingface/diffusers | Python | 10,189 | Check correct model type is passed to `from_pretrained` | # What does this PR do?
Example
```python
from diffusers import DiffusionPipeline
from transformers import T5EncoderModel
import torch
repo_id = "black-forest-labs/FLUX.1-dev"
text_encoder_2 = T5EncoderModel.from_pretrained(repo_id, subfolder="text_encoder_2")
pipe = DiffusionPipeline.from_pretrained(
... | 2024-12-11T10:22:17Z | [pipelines] add better checking when a wrong model is passed when initializing a pipeline
With this code:
```py
from diffusers import DiffusionPipeline
from transformers import T5EncoderModel
import torch
repo_id = "black-forest-labs/FLUX.1-dev"
text_encoder_2 = T5EncoderModel.from_pretrained(repo_id, subf... | @sayakpaul
1. adding a `validate_pipeline()` method in pipeline loading class if not validated throw simple yet understandable errors like these not sure how good these are:
```
`ValueError: Mismatched model type for component 'text_encoder_2'.
Expected types: ['T5EncoderModel'], but got: 'T5Model'
```
Ensure the co... | [
{
"body": "With this code:\r\n\r\n```py\r\nfrom diffusers import DiffusionPipeline \r\nfrom transformers import T5EncoderModel \r\nimport torch \r\n\r\nrepo_id = \"black-forest-labs/FLUX.1-dev\"\r\ntext_encoder_2 = T5EncoderModel.from_pretrained(repo_id, subfolder=\"text_encoder_2\")\r\npipe = DiffusionPipeline... | f35a38725b4d263330a591dc7bdb54b002b96675 | {
"head_commit": "803e33f22e574bd5a226aafb7bd75dcf5b1c3950",
"head_commit_message": "add LCMScheduler",
"patch_to_review": "diff --git a/src/diffusers/pipelines/kandinsky2_2/pipeline_kandinsky2_2.py b/src/diffusers/pipelines/kandinsky2_2/pipeline_kandinsky2_2.py\nindex 471db61556f5..c912344bd609 100644\n--- a/src... | [
{
"diff_hunk": "@@ -1802,6 +1802,17 @@ def test_pipe_same_device_id_offload(self):\n sd.maybe_free_model_hooks()\n assert sd._offload_gpu_id == 5\n \n+ def test_wrong_model(self):\n+ tokenizer = CLIPTokenizer.from_pretrained(\"hf-internal-testing/tiny-random-clip\")\n+ with self... | e19356315177883ab53fcadaf73c98683857a0df | diff --git a/src/diffusers/pipelines/pipeline_utils.py b/src/diffusers/pipelines/pipeline_utils.py
index a504184ea2f2..c505c5a262a3 100644
--- a/src/diffusers/pipelines/pipeline_utils.py
+++ b/src/diffusers/pipelines/pipeline_utils.py
@@ -13,6 +13,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-9571@0317c0d | huggingface/diffusers | Python | 9,571 | flux controlnet control_guidance_start and control_guidance_end implement | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2024-10-02T17:25:28Z | [Flux Controlnet] Add control_guidance_start and control_guidance_end
It'd be nice to have `control_guidance_start` and `control_guidance_start` parameters added to flux Controlnet and Controlnet Inpainting pipelines.
I'm currently making experiments with Flux Controlnet Inpainting but the results are poor even with... | cc @asomoza
Flux doesn't have the behavior of the the other models because we have the distilled version of the model, so this is just my speculation but, for the other inpainting/tile controlnets, you must have the `control_guidance_end` to `1.0` or you'll get a different image at the end which defeats the purpose of... | [
{
"body": "It'd be nice to have `control_guidance_start` and `control_guidance_start` parameters added to flux Controlnet and Controlnet Inpainting pipelines.\r\n\r\nI'm currently making experiments with Flux Controlnet Inpainting but the results are poor even with a `controlnet_conditioning_scale` set to 0.6. ... | e16fd93d0a40156c1f49fde07f6f2eb438983927 | {
"head_commit": "0317c0d1ca74bfd677428467ce4e5be643818dcf",
"head_commit_message": "Merge branch 'main' into feature/flux_control_guidance",
"patch_to_review": "diff --git a/src/diffusers/pipelines/flux/pipeline_flux_controlnet.py b/src/diffusers/pipelines/flux/pipeline_flux_controlnet.py\nindex 6c072c482020..2c... | [
{
"diff_hunk": "@@ -856,12 +880,19 @@ def __call__(\n guidance = torch.tensor([guidance_scale], device=device) if use_guidance else None\n guidance = guidance.expand(latents.shape[0]) if guidance is not None else None\n \n+ if isinstance(controlnet_keep[i], list):\... | 44aef100eeacdb868e06d290fa61e1f005f1a48f | diff --git a/src/diffusers/pipelines/flux/pipeline_flux_controlnet.py b/src/diffusers/pipelines/flux/pipeline_flux_controlnet.py
index 6c072c482020..a301f6742c05 100644
--- a/src/diffusers/pipelines/flux/pipeline_flux_controlnet.py
+++ b/src/diffusers/pipelines/flux/pipeline_flux_controlnet.py
@@ -72,7 +72,9 @@
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-10166@b024b74 | huggingface/diffusers | Python | 10,166 | update StableDiffusion3Img2ImgPipeline.add image size validation | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2024-12-10T03:11:36Z | In the StableDiffusion3Img2ImgPipeline, the height dimension of latents is odd, which may cause a mismatch with the height dimension of noise_pred.
### Describe the bug
In the `StableDiffusion3Img2ImgPipeline`, the height dimension of latents is odd, which may cause a mismatch with the height dimension of noise_pred... | 
I eventually added a check for the evenness of the height and width dimensions of the latents. If they are odd, I adjust them to the largest even number within the range. I'm not sure if this method is advisable.
cc @sayakpaul ... | [
{
"body": "### Describe the bug\r\n\r\nIn the `StableDiffusion3Img2ImgPipeline`, the height dimension of latents is odd, which may cause a mismatch with the height dimension of noise_pred.\r\n\r\nDuring the process of using the `StableDiffusion3Img2ImgPipeline`, I input an image of shape (1, 3, 856, 1088). Afte... | 96c376a5ff201a31d676091a59a011c8c29d095b | {
"head_commit": "b024b74ebad8efa00ac1b1fb7274240cbc75e20b",
"head_commit_message": "make style",
"patch_to_review": "diff --git a/src/diffusers/pipelines/stable_diffusion_3/pipeline_stable_diffusion_3_img2img.py b/src/diffusers/pipelines/stable_diffusion_3/pipeline_stable_diffusion_3_img2img.py\nindex c91b4ee80e... | [
{
"diff_hunk": "@@ -890,7 +910,7 @@ def __call__(\n pooled_prompt_embeds = torch.cat([negative_pooled_prompt_embeds, pooled_prompt_embeds], dim=0)\n \n # 3. Preprocess image\n- image = self.image_processor.preprocess(image)\n+ image = self.image_processor.preprocess(image, heig... | 861345d36e586651cdad47d01a5f2d3d41e4f7ac | diff --git a/src/diffusers/pipelines/pag/pipeline_pag_sd_3_img2img.py b/src/diffusers/pipelines/pag/pipeline_pag_sd_3_img2img.py
index 01d29867dea3..24e31fa4cfc7 100644
--- a/src/diffusers/pipelines/pag/pipeline_pag_sd_3_img2img.py
+++ b/src/diffusers/pipelines/pag/pipeline_pag_sd_3_img2img.py
@@ -549,6 +549,8 @@ def c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__diffusers-9918@a91feec | huggingface/diffusers | Python | 9,918 | Add server example | # What does this PR do?
This is a followup to [9848](https://github.com/huggingface/diffusers/pull/9848). The aim of this is to serve as a fix for several issues around concurrent, multithreaded usage of diffusers:
Fixes #3672, #5749, #9833, #7851, #4920, #2916
## Before submitting
- [ ] This PR fixes a typ... | 2024-11-13T03:08:59Z | Concurrent Thread Failure in Image Inference: StableDiffusionPipeline
### Describe the bug
When I attempt to concurrently initiate two threads for image inference in one pipe, the process fails and the following information is displayed as logs during the inference. I intend to submit a pull request for thread-safet... | Hey @Fantast416,
I have not yet tested SD with threads. Can you verify that the inference call works without threading to begin with?
> Hey @Fantast416,
>
> I have not yet tested SD with threads. Can you verify that the inference call works without threading to begin with?
Yes, I have verified it. if you remo... | [
{
"body": "### Describe the bug\r\n\r\nWhen I attempt to concurrently initiate two threads for image inference in one pipe, the process fails and the following information is displayed as logs during the inference. I intend to submit a pull request for thread-safety in one inference pipe if anyone else need.\r\... | 1dbd26fa23291b54cbf0db98fa0d76976029f38c | {
"head_commit": "a91feecd5b21de4795f275bffed9d3d5c63476a8",
"head_commit_message": "Add fixes after local testing.",
"patch_to_review": "diff --git a/examples/server/README.md b/examples/server/README.md\nnew file mode 100644\nindex 000000000000..1bfdf2050f15\n--- /dev/null\n+++ b/examples/server/README.md\n@@ -... | [
{
"diff_hunk": "@@ -0,0 +1,35 @@\n+\n+## OpenAI Compatible `/v1/images/generations` Server\n+\n+This is a concurrent, multithreaded solution for running a server that can generate images using the `diffusers` library. This examples uses the Stable Diffusion 3 pipeline, but you can use any pipeline that you woul... | 31711a72c3dee005ef5481399b893f3a26af6455 | diff --git a/docs/source/en/_toctree.yml b/docs/source/en/_toctree.yml
index de6cd2981b96..2faabfec30ce 100644
--- a/docs/source/en/_toctree.yml
+++ b/docs/source/en/_toctree.yml
@@ -55,6 +55,8 @@
- sections:
- local: using-diffusers/overview_techniques
title: Overview
+ - local: using-diffusers/create_a_serv... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
huggingface__diffusers-9194@403e083 | huggingface/diffusers | Python | 9,194 | [IP Adapter] Fix object has no attribute with image encoder | # What does this PR do?
IP Adapter FaceID model don't need the image encoder so it's not loaded and the image encoder its used to get the clip size for the Kolors version, this produces an error with FaceID models. This PR sets back the default 224 size for these models.
IMO it would be better to not load the `fe... | 2024-08-16T06:19:49Z | IP Adapter is not working with SDXL when using `image_encoder_folder=None` after Kolors update
### Describe the bug
When loading IP Adapter into SDXL Text2Image pipeline with `image_encoder_folder=None`, I encounter the following error:
```
clip_image_size = self.image_encoder.config.image_size
AttributeError: 'Non... | [The related docs page](https://huggingface.co/docs/diffusers/main/en/using-diffusers/loading_adapters#ip-adapter-face-id-models) says plus versions need to be passed `image_encoder`.
@tolgacangoz this is not the case. Please read https://huggingface.co/docs/diffusers/main/en/using-diffusers/ip_adapter#face-model
@detk... | [
{
"body": "### Describe the bug\n\nWhen loading IP Adapter into SDXL Text2Image pipeline with `image_encoder_folder=None`, I encounter the following error:\r\n```\r\nclip_image_size = self.image_encoder.config.image_size\r\nAttributeError: 'NoneType' object has no attribute 'config'\r\n```\r\n\r\nAs I can see f... | e780c05cc3e7816dca976622ef03bc734c486866 | {
"head_commit": "403e08326bcd4070be7c0bc5d95c7e0b5439a14d",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/src/diffusers/loaders/ip_adapter.py b/src/diffusers/loaders/ip_adapter.py\nindex 44c8c0a5181c..855b7765bd3e 100644\n--- a/src/diffusers/loaders/ip_adapter.py\n+++ b/src/diffusers/loaders/ip_... | [
{
"diff_hunk": "@@ -222,7 +222,7 @@ def load_ip_adapter(\n \n # create feature extractor if it has not been registered to the pipeline yet\n if hasattr(self, \"feature_extractor\") and getattr(self, \"feature_extractor\", None) is None:\n- clip_image_size = self.image_enco... | dc1f258b09604d0a75b5ae0adb7e3c3c85acdd7d | diff --git a/src/diffusers/loaders/ip_adapter.py b/src/diffusers/loaders/ip_adapter.py
index 44c8c0a5181c..f2433081018e 100644
--- a/src/diffusers/loaders/ip_adapter.py
+++ b/src/diffusers/loaders/ip_adapter.py
@@ -222,7 +222,11 @@ def load_ip_adapter(
# create feature extractor if it has not been regist... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-61873@bbdb10c | getsentry/sentry | Python | 61,873 | feat(replays): Emit has hydration error analytic | fixes #61847
| 2023-12-15T21:10:25Z | Add a hydration breadcrumb presence analytic event
We're trying to find examples of replays that were viewed and would've had the hydration breadcrumb.
ACs:
When they do not have the feature hydration modal feature flag, emit an analytic event if the hydration error breadcrumb is present in the replay. | [
{
"body": "We're trying to find examples of replays that were viewed and would've had the hydration breadcrumb.\r\n\r\nACs:\r\nWhen they do not have the feature hydration modal feature flag, emit an analytic event if the hydration error breadcrumb is present in the replay.",
"number": 61847,
"title": "A... | 9fc83f3d47563c14e13b605e107e9d960ed5aa85 | {
"head_commit": "bbdb10c4ac430856dff6844140477e59ec826a78",
"head_commit_message": "feat(replays): Emit has hydration error analytic\n\nfixes #61847",
"patch_to_review": "diff --git a/static/app/utils/analytics/replayAnalyticsEvents.tsx b/static/app/utils/analytics/replayAnalyticsEvents.tsx\nindex 0ee053572b1219... | [
{
"diff_hunk": "@@ -45,6 +45,23 @@ function useLogReplayDataLoaded({fetchError, fetching, projectSlug, replay}: Pro\n finished_at_delta: replay.timestampDeltas.finishedAtDelta,\n replay_id: replayRecord.id,\n });\n+\n+ // TODO(session-replay-show-hydration-errors): remove this analytic on GA\... | 734a0de3d050e1ae58be87ee3990acb48540a965 | diff --git a/static/app/utils/analytics/replayAnalyticsEvents.tsx b/static/app/utils/analytics/replayAnalyticsEvents.tsx
index 0ee053572b1219..c2e5e072d50c7f 100644
--- a/static/app/utils/analytics/replayAnalyticsEvents.tsx
+++ b/static/app/utils/analytics/replayAnalyticsEvents.tsx
@@ -17,6 +17,10 @@ export type Replay... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
huggingface__transformers-38630@2a6f9a2 | huggingface/transformers | Python | 38,630 | [docs] ViTPose | Updates model card for ViTPose and fixes #36773 | 2025-06-06T00:16:50Z | Inconsistent Documentation for `dataset_index` Requirement Across ViTPose Models
### System Info
## Description
There's confusion regarding the `dataset_index` parameter requirement across the ViTPose model family. The documentation only mentions this requirement for **some** of the models, initially when the model ... | cc @nielsrogge for ViTPose
Pinging @qubvel here.
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.
Please note that issues that do not follow the [contributing guidelines](https://github.com/huggingfac... | [
{
"body": "### System Info\n\n## Description\n\nThere's confusion regarding the `dataset_index` parameter requirement across the ViTPose model family. The documentation only mentions this requirement for **some** of the models, initially when the model was released it was only for the `usyd-community/vitpose-pl... | 757c26fb40cbeeef3a1288219503acd23febd034 | {
"head_commit": "2a6f9a2b91ca085ba665d5ed3d0044791cbca324",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/docs/source/en/model_doc/vitpose.md b/docs/source/en/model_doc/vitpose.md\nindex 7a417cc21382..b951c34c0a85 100644\n--- a/docs/source/en/model_doc/vitpose.md\n+++ b/docs/source/en/model_doc/... | [
{
"diff_hunk": "@@ -10,134 +10,67 @@ an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express o\n specific language governing permissions and limitations under the License.\n -->\n \n-# ViTPose\n-\n-<div class=\"flex flex-wrap space-x-1\">\n-<img alt=\"PyTorch\" src=\"https://img.shields... | ad9e293de442d93c8caaf7b969820239f731507c | diff --git a/docs/source/en/model_doc/vitpose.md b/docs/source/en/model_doc/vitpose.md
index 7a417cc21382..f9ed72659344 100644
--- a/docs/source/en/model_doc/vitpose.md
+++ b/docs/source/en/model_doc/vitpose.md
@@ -10,52 +10,39 @@ an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express o
specifi... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
hummingbot__hummingbot-4464@703ad62 | hummingbot/hummingbot | Python | 4,464 | Update hummingbot integration to gateway-v2 and use nonces in hummingbot to gateway-v2 transactions | 2021-10-14T09:27:35Z | Use nonces on Hummingbot for creating Ethereum transactions
## Why
After the nonce manager has been implemented and integrated to gateway v2, we need Hummingbot to provide the nonce on creating new transactions to allow the two-token approval workflow to work correctly.
## What
* Add logic on Hummingbot side to quer... | [
{
"body": "## Why\n\nAfter the nonce manager has been implemented and integrated to gateway v2, we need Hummingbot to provide the nonce on creating new transactions to allow the two-token approval workflow to work correctly.\n\n## What\n\n* Add logic on Hummingbot side to query and provide the `nonce` parameter... | c0feb084b85dfdebf4eb3e6ba71ad42ac3b7c0eb | {
"head_commit": "703ad6214d4153f6fba3be52e65c73d592deff3c",
"head_commit_message": "Remove unnecessary logs",
"patch_to_review": "diff --git a/gateway/src/app.ts b/gateway/src/app.ts\nindex 2c2f744c038..ae65932b4b8 100644\n--- a/gateway/src/app.ts\n+++ b/gateway/src/app.ts\n@@ -23,7 +23,7 @@ app.use('/eth/uniswa... | [
{
"diff_hunk": "@@ -89,7 +89,7 @@ export const validateAmount: Validator = mkValidator(\n export const validateNonce: Validator = mkValidator(\n 'nonce',\n invalidNonceError,\n- (val) => typeof val === 'number' && val > -1,\n+ (val) => typeof val === 'number' && val >= 0,",
"line": null,
"original... | 94763500716864b545f737dc0cdde71bb0c3e9c5 | diff --git a/gateway/src/app.ts b/gateway/src/app.ts
index 2c2f744c038..ae65932b4b8 100644
--- a/gateway/src/app.ts
+++ b/gateway/src/app.ts
@@ -23,7 +23,7 @@ app.use('/eth/uniswap', UniswapRoutes.router);
// a simple route to test that the server is running
app.get('/', (_req: Request, res: Response) => {
- res.s... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | ||
huggingface__transformers-38818@552ceb3 | huggingface/transformers | Python | 38,818 | [Feature] Support `is_split_into_words` in the `TokenClassificationPipeline`. | # What does this PR do?
Fixes #30757
This PR solves the problem that when using an already tokenized input in the `TokenClassificationPipeline` by adding a `tokenizer_parameter` called `is_split_into_words`. I think we will need the aggregation code because some tokenizers are subword tokenizers, I have solved the ... | 2025-06-13T17:42:37Z | TokenClassificationPipeline support is_split_into_words tokeniser parameter
### Feature request
The TokenClassificationPipeline currently sets a hardcoded tokeniser config within it sanitiser method. This prevents users from passing their own config to the tokeniser.
It would be good to support some user input for... | cc @ArthurZucker @Rocketknight1
This makes sense to me, but I'm not super-familiar with that pipeline. I'd support a PR to allow some options to be passed through to the tokenizer, though, since that shouldn't have any backward compatibility issues!
Hello @swtb3, @amyeroberts, @Rocketknight1, @ArthurZucker,
I just ... | [
{
"body": "### Feature request\n\nThe TokenClassificationPipeline currently sets a hardcoded tokeniser config within it sanitiser method. This prevents users from passing their own config to the tokeniser. \r\n\r\nIt would be good to support some user input for tokeniser config. Especially for is_split_into_wor... | 2166b6b4ff09f6dd3867ab982f262f66482aa968 | {
"head_commit": "552ceb390696e1c2cb227ea354b39ab09bce7660",
"head_commit_message": "removing unimportant lines",
"patch_to_review": "diff --git a/src/transformers/pipelines/token_classification.py b/src/transformers/pipelines/token_classification.py\nindex e976ee9b1874..e69c02726a4b 100644\n--- a/src/transformer... | [
{
"diff_hunk": "@@ -251,23 +257,62 @@ def __call__(\n exists if the offsets are available within the tokenizer\n \"\"\"\n \n- _inputs, offset_mapping = self._args_parser(inputs, **kwargs)\n+ _inputs, is_split_into_words, offset_mapping = self._args_parser(inputs, **kwargs)\n+... | fb913a6fe0229659c3025e0f7c63430cdaf71da7 | diff --git a/src/transformers/pipelines/token_classification.py b/src/transformers/pipelines/token_classification.py
index e976ee9b1874..2a2a6bbe1092 100644
--- a/src/transformers/pipelines/token_classification.py
+++ b/src/transformers/pipelines/token_classification.py
@@ -30,6 +30,9 @@ class TokenClassificationArgume... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
home-assistant__core-66949@1707d54 | home-assistant/core | Python | 66,949 | Implement measurement sensor for Sensibo | <!--
You are amazing! Thanks for contributing to our project!
Please, DO NOT DELETE ANY TEXT from this template! (unless instructed).
-->
## Breaking change
<!--
If your PR contains a breaking change for existing users, it is important
to tell them what breaks, how to make it work again and why we did th... | 2022-02-20T15:51:17Z | Sensibo Air + RoomSensor as a primary sensor
### The problem
The Sensibo integration currently does not consider the RoomSensor (MotionSensor) being configured as the primary temperature/humidity sensor. Temperature and humidity values reported in the climate module/ thermostat are coming from the main Sensibo Air uni... | [sensibo documentation](https://www.home-assistant.io/integrations/sensibo)
[sensibo source](https://github.com/home-assistant/core/tree/dev/homeassistant/components/sensibo)
<sub><sup>(message by IssueLinks)</sup></sub>
Hey there @andrey-git, @gjohansson-st, mind taking a look at this issue as it has been labeled with... | [
{
"body": "### The problem\n\nThe Sensibo integration currently does not consider the RoomSensor (MotionSensor) being configured as the primary temperature/humidity sensor. Temperature and humidity values reported in the climate module/ thermostat are coming from the main Sensibo Air unit.\r\n\r\nThe values for... | 848406091527363cc548b91b534727b9d6af2418 | {
"head_commit": "1707d54f9784f9e86925c045583caf545262a02e",
"head_commit_message": "Fixes from review",
"patch_to_review": "diff --git a/homeassistant/components/sensibo/coordinator.py b/homeassistant/components/sensibo/coordinator.py\nindex 926232ef159bc4..f49c58d678ca4f 100644\n--- a/homeassistant/components/s... | [
{
"diff_hunk": "@@ -98,6 +98,30 @@ async def _async_update_data(self) -> dict[str, dict[str, Any]]:\n calibration_temp = dev[\"sensorsCalibration\"].get(\"temperature\", 0.0)\n calibration_hum = dev[\"sensorsCalibration\"].get(\"humidity\", 0.0)\n \n+ # Sky plus supports funct... | 539d3c5ddd948146571f1ee1677d4f286dc05ea1 | diff --git a/homeassistant/components/sensibo/coordinator.py b/homeassistant/components/sensibo/coordinator.py
index 926232ef159bc..a5d2d97899942 100644
--- a/homeassistant/components/sensibo/coordinator.py
+++ b/homeassistant/components/sensibo/coordinator.py
@@ -1,6 +1,7 @@
"""DataUpdateCoordinator for the Sensibo i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
hummingbot__hummingbot-4310@c64d130 | hummingbot/hummingbot | Python | 4,310 | Feat/gateway v2 route validators | Validate all request bodies before performing the route controller. | 2021-09-28T11:32:23Z | Add route request validators
Before running the control logic we should validate that the parameters are correct. While typescript does let you declare that expected types of the request, this doesn't actually prevent ill formed requests from entering the control logic, which might lead to unexpected errors. The valida... | [
{
"body": "Before running the control logic we should validate that the parameters are correct. While typescript does let you declare that expected types of the request, this doesn't actually prevent ill formed requests from entering the control logic, which might lead to unexpected errors. The validators shoul... | 8fa8e703b82b6b82d6b4b22625f4bb591c913fb9 | {
"head_commit": "c64d130e6e02e07c787c7aaa5f6cd81078e78e07",
"head_commit_message": "Refactor the validation code",
"patch_to_review": "diff --git a/gateway/src/chains/ethereum/ethereum.requests.ts b/gateway/src/chains/ethereum/ethereum.requests.ts\nnew file mode 100644\nindex 00000000000..cb57a52eb48\n--- /dev/n... | [
{
"diff_hunk": "@@ -0,0 +1,149 @@\n+import {\n+ isNaturalNumberString,\n+ missingParameter,\n+ throwErrorsIfExist,\n+ validate,\n+} from '../../services/validators';\n+\n+import {\n+ EthereumNonceRequest,\n+ EthereumAllowancesRequest,\n+ EthereumBalanceRequest,\n+ EthereumApproveRequest,\n+ EthereumPol... | 6e1b66fa348e91211a1daa6e027f1876de5cf8a1 | diff --git a/gateway/src/chains/ethereum/ethereum.requests.ts b/gateway/src/chains/ethereum/ethereum.requests.ts
new file mode 100644
index 00000000000..cb57a52eb48
--- /dev/null
+++ b/gateway/src/chains/ethereum/ethereum.requests.ts
@@ -0,0 +1,26 @@
+export interface EthereumNonceRequest {
+ privateKey: string; // th... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__diffusers-8947@e38c554 | huggingface/diffusers | Python | 8,947 | StableDiffusionLatentUpscalePipeline - positive/negative prompt embeds support | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2024-07-23T17:37:43Z | StableDiffusionLatentUpscalePipeline - positive/negative prompt embeds support
I'm trying to deploy the smallest possible SD inpainting model. My production deployment only needs unet+vae+ipadapter weights with prompt and ip adapter image embeds pre-generated. Works well!
Now I wanted to try latent upscaler from dif... | would be very nice indeed!
would you be willing to open a PR? if not we can ask the community to see if anyone else wants to help :)
@yiyixuxu sorry, I don't have capacity for a PR right now (unfamiliar with the codebase, assuming that testing would also take a while).
@yiyixuxu LatentUpscaler use two text embeds `h... | [
{
"body": "I'm trying to deploy the smallest possible SD inpainting model. My production deployment only needs unet+vae+ipadapter weights with prompt and ip adapter image embeds pre-generated. Works well!\r\n\r\nNow I wanted to try latent upscaler from diffusers and realized it currently doesn't support pre-gen... | 98930ee131b996c65cbbf48d8af363a98b21492c | {
"head_commit": "e38c554fbfb63a1790e0c0022a8f4506c0fefcc3",
"head_commit_message": "modify existing tests",
"patch_to_review": "diff --git a/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_latent_upscale.py b/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_latent_upscale.py\... | [
{
"diff_hunk": "@@ -173,11 +173,51 @@ def test_inference(self):\n \n self.assertEqual(image.shape, (1, 256, 256, 3))\n expected_slice = np.array(\n- [0.47222412, 0.41921633, 0.44717434, 0.46874192, 0.42588258, 0.46150726, 0.4677534, 0.45583832, 0.48579055]\n+ [0.3970313, 0.... | 964f6cd85632ff81f6d5f6592c388e06c63b88b7 | diff --git a/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_latent_upscale.py b/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_latent_upscale.py
index 4d033133e5ec..ffe02ae679e5 100644
--- a/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_latent_upscale.py
+++ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__transformers-38232@b920f50 | huggingface/transformers | Python | 38,232 | [Whisper] handle deprecation of `forced_decoder_ids` | # What does this PR do?
Fixes #37172
`forced_decoder_ids`, an old `whisper` flag, was deprecated in favor of the more explicit `task` and `language` flags (#28687). However, we need to handle it for BC: the original checkpoints have them.
This PR does a few deprecation-related changes, in an attempt to move us... | 2025-05-20T14:20:54Z | Since 4.50.0, saving and loading a Whisper model causes an error
### System Info
- `transformers` version: 4.50.3
- Platform: macOS-14.6.1-arm64-arm-64bit
- Python version: 3.12.9
### Who can help?
@eustlb @gante
### Information
- [x] The official example scripts
- [ ] My own modified scripts
### Tasks
- [x] A... | I have a (partial) solution for this issue. I have a fine-tuned whisper model and run into this issue after loading the fine-tuned checkpoint for another task. Here is my solution:
```python
if hasattr(model.config, 'forced_decoder_ids'):
model.config.forced_decoder_ids = None
if hasattr(model, 'generation_... | [
{
"body": "### System Info\n\n\n- `transformers` version: 4.50.3\n- Platform: macOS-14.6.1-arm64-arm-64bit\n- Python version: 3.12.9\n\n\n### Who can help?\n\n@eustlb @gante\n\n### Information\n\n- [x] The official example scripts\n- [ ] My own modified scripts\n\n### Tasks\n\n- [x] An officially supported task... | b591d925bed9235d158a9ff569c5ac1f4c619157 | {
"head_commit": "b920f5019d0af0e5049715478b71851b99144994",
"head_commit_message": "add deprecation message",
"patch_to_review": "diff --git a/docs/source/en/model_doc/whisper.md b/docs/source/en/model_doc/whisper.md\nindex 3aa6e5c3018e..4bb51d0ce804 100644\n--- a/docs/source/en/model_doc/whisper.md\n+++ b/docs/... | [
{
"diff_hunk": "@@ -1392,59 +1394,64 @@ def language_to_id(language: str) -> int:\n )\n if language_token not in generation_config.lang_to_id:\n raise ValueError(\n- f\"{language_token} is not supported by this specific model as it is not in the `ge... | 7fd9a2f1070a672bf012818511996590e6ee0b67 | diff --git a/docs/source/en/model_doc/whisper.md b/docs/source/en/model_doc/whisper.md
index 3aa6e5c3018e..4bb51d0ce804 100644
--- a/docs/source/en/model_doc/whisper.md
+++ b/docs/source/en/model_doc/whisper.md
@@ -95,7 +95,7 @@ transcription[0]
## Notes
-- Whisper relies on [`~GenerationMixin.generate`] for infer... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
hummingbot__hummingbot-4265@669a35a | hummingbot/hummingbot | Python | 4,265 | cleanup/Remove legacy throttler | **Before submitting this PR, please make sure**:
- [X] Your code builds clean without any errors or warnings
- [X] You are using approved title ("feat/", "fix/", "docs/", "refactor/")
**A description of the changes proposed in the pull request**:
Removes the remaining legacy throttler and its associated test ca... | 2021-09-24T04:41:56Z | Remove the remaining API Throttlers from the code base
## Description
Remove all remaining unused code related to API throttles from the code base
## Details
After refactoring the existing connectors that make use of the old API Throttlers to the consolidated, clean up the code base.
The remaining files are everyth... | [
{
"body": "## Description\n\nRemove all remaining unused code related to API throttles from the code base\n\n## Details\n\nAfter refactoring the existing connectors that make use of the old API Throttlers to the consolidated, clean up the code base.\n\nThe remaining files are everything left inside the `/hummin... | 0cdf27b1be28eeeddc32c13d466a161a396b7e79 | {
"head_commit": "669a35a943329bb4beae41d67077ab278c32f507",
"head_commit_message": "(fix) Fixes one of the new test cases.",
"patch_to_review": "diff --git a/hummingbot/connector/exchange/binance/binance_exchange.pyx b/hummingbot/connector/exchange/binance/binance_exchange.pyx\nindex 32faf96d9be..e50429d5d58 100... | [
{
"diff_hunk": "@@ -79,7 +79,9 @@ def has_trade_id(self) -> bool:\n return self.type == OrderBookMessageType.TRADE\n \n def __eq__(self, other: \"OrderBookMessage\") -> bool:\n- if self.has_update_id and other.has_update_id:\n+ if self.type != other.type:\n+ return False\n+ ... | 9513f66ea8804a0bd659c82e307cc6c2767a60fe | diff --git a/hummingbot/connector/exchange/binance/binance_exchange.pyx b/hummingbot/connector/exchange/binance/binance_exchange.pyx
index 32faf96d9be..e50429d5d58 100755
--- a/hummingbot/connector/exchange/binance/binance_exchange.pyx
+++ b/hummingbot/connector/exchange/binance/binance_exchange.pyx
@@ -26,7 +26,6 @@ f... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
huggingface__transformers-38103@cb5a04c | huggingface/transformers | Python | 38,103 | Fix incorrect batching audio index calculation for Phi-4-Multimodal | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2025-05-13T13:06:05Z | [Bug] Phi-4-multimodal audio processor failed to process multiple audios with close length
### System Info
None
### Who can help?
@zucchini-nlp @eustlb
### Information
- [x] The official example scripts
- [ ] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as ... | Hi @zucchini-nlp @eustlb,
I’d like to tackle the audio‐processor bug in Phi-4-MM (PR-70) where batching same-length audio raises a tensor-shape error in _torch_extract_fbank_features. I’ve reproduced the issue locally and traced it to mismatched mask/frame dimensions when padding variable-length inputs.
May I submit ... | [
{
"body": "### System Info\n\nNone\n\n### Who can help?\n\n@zucchini-nlp @eustlb\n\n### Information\n\n- [x] The official example scripts\n- [ ] My own modified scripts\n\n### Tasks\n\n- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)\n- [ ] My own task or dataset (give deta... | 9f0402bc4db85f24626b5e6cb8b766244e2abc48 | {
"head_commit": "cb5a04c7e716f16e79208642fc994f44b1ae7a7a",
"head_commit_message": "Merge branch 'main' into fix-phi4mm-audio",
"patch_to_review": "diff --git a/src/transformers/models/phi4_multimodal/feature_extraction_phi4_multimodal.py b/src/transformers/models/phi4_multimodal/feature_extraction_phi4_multimod... | [
{
"diff_hunk": "@@ -300,7 +300,7 @@ def _torch_extract_fbank_features(\n to_mask_batch_idxs = torch.arange(batch_size)[audio_lengths != audio_lengths.max()]\n if to_mask_batch_idxs.numel() > 0:\n batch_idxs_down = (audio_lengths[to_mask_batch_idxs] - self.win_length) // s... | 729ab4183c89da1f39eb6cba576253ee80e0af9d | diff --git a/src/transformers/models/phi4_multimodal/feature_extraction_phi4_multimodal.py b/src/transformers/models/phi4_multimodal/feature_extraction_phi4_multimodal.py
index 6f1a19fab65e..df2559e531a9 100644
--- a/src/transformers/models/phi4_multimodal/feature_extraction_phi4_multimodal.py
+++ b/src/transformers/mo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-61238@c2d2140 | getsentry/sentry | Python | 61,238 | feat(ddm): include measurements in metric dropdown | - closes #61025
- refactors `useMetricsMeta`
- adds icons in context menu
<img width="1054" alt="image" src="https://github.com/getsentry/sentry/assets/86684834/c7d4f17f-636d-42e7-947a-bfe8ef0ceb89">
| 2023-12-06T11:28:26Z | Show selected transactions/ metrics in DDM
On top of custom metrics, we'd like to show selected metrics from the transactions namespace in DDM.
The ones we've been discussing:
- transaction.duration
- measurements (both default ones and custom ones)
When plotting transaction.duration and known measurements, we need to... | [
{
"body": "On top of custom metrics, we'd like to show selected metrics from the transactions namespace in DDM.\nThe ones we've been discussing:\n- transaction.duration\n- measurements (both default ones and custom ones)\n\nWhen plotting transaction.duration and known measurements, we need to redirect to the co... | 756ce0c78746499fa36cae7e2c2199eff7371639 | {
"head_commit": "c2d2140fee2ac0c786d7c387f861a7e5a56dfbb7",
"head_commit_message": "formatting",
"patch_to_review": "diff --git a/static/app/utils/metrics/index.tsx b/static/app/utils/metrics/index.tsx\nindex 7852c85bae078e..e19a8f7cbbc3ef 100644\n--- a/static/app/utils/metrics/index.tsx\n+++ b/static/app/utils/... | [
{
"diff_hunk": "@@ -119,6 +111,35 @@ function getAlertInterval(metricsQuery, period: TimePeriod) {\n return toInterval(TimeWindow.ONE_HOUR);\n }\n \n+export function getAlertFormPath({\n+ organizationSlug,\n+ interval,\n+ statsPeriod,\n+ environment,\n+ project,\n+ aggregate,\n+ query,\n+}) {\n+ retur... | 1177d95c340e9e4c95964878da135a9ec32d24db | diff --git a/static/app/utils/metrics/index.tsx b/static/app/utils/metrics/index.tsx
index c4ff398c8e3b2d..b252fd752844c9 100644
--- a/static/app/utils/metrics/index.tsx
+++ b/static/app/utils/metrics/index.tsx
@@ -28,6 +28,7 @@ import {
UseCase,
} from 'sentry/types/metrics';
import {defined, formatBytesBase2, fo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-60848@eb83447 | getsentry/sentry | Python | 60,848 | feat(relocation): Add throttling | closes https://github.com/getsentry/sentry/issues/60694 | 2023-11-30T00:21:18Z | Throttling for relocations
### Problem Statement
the broad goal here is to have global throttles for each of `small` (<10MB), `medium` (>=10MB && <100MB), and `large` (>100MB) relocation uploads. These should respectively be controlled by 3 new options: `relocation:daily-limit-small`, `relocation:daily-limit-medium`, ... | Routing to @getsentry/product-owners-org-relocation for [triage](https://develop.sentry.dev/processing-tickets/#3-triage) ⏲️
CC @hubertdeng123 | [
{
"body": "### Problem Statement\n\nthe broad goal here is to have global throttles for each of `small` (<10MB), `medium` (>=10MB && <100MB), and `large` (>100MB) relocation uploads. These should respectively be controlled by 3 new options: `relocation:daily-limit-small`, `relocation:daily-limit-medium`, and `r... | 2413371070e100302e0070b9843a763f8cdc3191 | {
"head_commit": "eb834475e6b8a28e3f51108390f74283e40d3551",
"head_commit_message": "add line breaks back",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/relocations/index.py b/src/sentry/api/endpoints/relocations/index.py\nindex 1da3d64314a2b2..33bef6dc9b6226 100644\n--- a/src/sentry/api/endpoints/re... | [
{
"diff_hunk": "@@ -83,8 +116,12 @@ def post(self, request: Request) -> Response:\n ).exists():\n return Response({\"detail\": ERR_DUPLICATE_RELOCATION}, status=409)\n \n- # TODO(getsentry/team-ospo#216): check import size, and maybe throttle based on that\n- # information.\n+ ... | 26f763280c46af5f902b6681d39bbb67b357203d | diff --git a/src/sentry/api/endpoints/relocations/index.py b/src/sentry/api/endpoints/relocations/index.py
index 1da3d64314a2b2..df9ebdc863ef27 100644
--- a/src/sentry/api/endpoints/relocations/index.py
+++ b/src/sentry/api/endpoints/relocations/index.py
@@ -1,6 +1,9 @@
import logging
+from datetime import timedelta
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-8600@6f011c5 | huggingface/diffusers | Python | 8,600 | Update train_dreambooth_lora_sd3.py | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2024-06-17T07:49:50Z | UnboundLocalError: tokenizer_one referenced before assignment in train_dreambooth_lora_sd3.py
### Describe the bug
I encountered an issue when trying to run train_dreambooth_lora_sd3.py. The script throws an UnboundLocalError because tokenizer_one is referenced before it is assigned. This prevents the training process... | the same error | [
{
"body": "### Describe the bug\n\nI encountered an issue when trying to run train_dreambooth_lora_sd3.py. The script throws an UnboundLocalError because tokenizer_one is referenced before it is assigned. This prevents the training process from starting.\n\n### Reproduction\n\nClone the repository.\r\nSet up th... | 25d7bb3ea65bb6f79056252584e24eb545c5eb18 | {
"head_commit": "6f011c57e2ff06b12a6e88a0158d08606f923383",
"head_commit_message": "Update train_dreambooth_lora_sd3.py",
"patch_to_review": "diff --git a/examples/dreambooth/train_dreambooth_lora_sd3.py b/examples/dreambooth/train_dreambooth_lora_sd3.py\nindex 8f831b50d07c..142dbcc4a2e0 100644\n--- a/examples/d... | [
{
"diff_hunk": "@@ -1317,7 +1317,7 @@ def compute_text_embeddings(prompt, text_encoders, tokenizers):\n if not train_dataset.custom_instance_prompts:\n del tokenizers, text_encoders\n # Explicitly delete the objects as well, otherwise only the lists are deleted and the original references re... | 9d60fd294eb359b8bcd3549ecebbf192eef5323c | diff --git a/examples/dreambooth/train_dreambooth_lora_sd3.py b/examples/dreambooth/train_dreambooth_lora_sd3.py
index 5da947ca3aa3..6006e544614d 100644
--- a/examples/dreambooth/train_dreambooth_lora_sd3.py
+++ b/examples/dreambooth/train_dreambooth_lora_sd3.py
@@ -1344,7 +1344,6 @@ def compute_text_embeddings(prompt,... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
huggingface__diffusers-8679@7f2659d | huggingface/diffusers | Python | 8,679 | [Community pipeline] SD3 Differential Diffusion Img2Img Pipeline | # What does this PR do?
Add the differential diffusion SD3 community pipeline.
Needs https://github.com/huggingface/diffusers/pull/8678 to work
Fixes #8577
How to test:
### Gradient
```python
import torch
from diffusers import FlowMatchEulerDiscreteScheduler
from diffusers.utils import load_image
... | 2024-06-24T08:23:56Z | Differential Diffusion with SD3
**Is your feature request related to a problem? Please describe.**
One might wish to soft inpaint or edit pictures with differential diffusion with SD3.
**Describe the solution you'd like.**
I believe we can port diff-diff to SD3, by adding a new pipeline for it.
**Describe alter... | I did a quick test to see if it worked in comfyui with diff-diff, I can't really tell if it works or not because I don't see the really good results I got with SDXL and diffusers. Maybe I'm doing something wrong with comfyui.
|source|without|with|
|---|---|---|
|![ComfyUI_00225_](https://github.com/huggingface/dif... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nOne might wish to soft inpaint or edit pictures with differential diffusion with SD3.\r\n\r\n**Describe the solution you'd like.**\r\nI believe we can port diff-diff to SD3, by adding a new pipeline for it.\r\n\r\n**Describe altern... | a216b0bb7fbf713e348edb030e865c2703965bd2 | {
"head_commit": "7f2659def6f9f78af4e26972f8ab78f6ae79fe7f",
"head_commit_message": "new pipeline",
"patch_to_review": "diff --git a/examples/community/pipeline_stable_diffusion_3_differential_img2img.py b/examples/community/pipeline_stable_diffusion_3_differential_img2img.py\nnew file mode 100644\nindex 00000000... | [
{
"diff_hunk": "@@ -0,0 +1,979 @@\n+# Copyright 2024 Stability AI and The HuggingFace Team. All rights reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# ... | 01e25815311dc0c779935ace0d42c9965dd361c1 | diff --git a/examples/community/pipeline_stable_diffusion_3_differential_img2img.py b/examples/community/pipeline_stable_diffusion_3_differential_img2img.py
new file mode 100644
index 000000000000..8cee5ecbc141
--- /dev/null
+++ b/examples/community/pipeline_stable_diffusion_3_differential_img2img.py
@@ -0,0 +1,981 @@
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
hummingbot__hummingbot-4013@cc85ce4 | hummingbot/hummingbot | Python | 4,013 | Refactor/hummingbot uniswap interaction | 2021-08-27T10:55:00Z | Integrate uniswap from gateway-v2 into hummingbot client
@mifeng has already made a branch of hummingbot that has gateway-v2. Now we need to update the uniswap connector so it works with the v2 version. The finished result will be merged into the gateway-v2 branch. This will not be merged into development until it is b... | Branch: https://github.com/coinalpha/hummingbot/tree/feat/gateway-v2
We can treat this as done as soon as Hummingbot is able to approve tokens and make a valid trade with the amm-arb strategy with Uniswap v2 on Kovan. | [
{
"body": "@mifeng has already made a branch of hummingbot that has gateway-v2. Now we need to update the uniswap connector so it works with the v2 version. The finished result will be merged into the gateway-v2 branch. This will not be merged into development until it is better tested and gateway-v2 supports a... | 3be8693101b0a2236ab928fa23b6448f01a4c026 | {
"head_commit": "cc85ce4e92165e720e8bb3961e356e285efa2952",
"head_commit_message": "delete unnecessary logs",
"patch_to_review": "diff --git a/gateway/conf/gateway-config-example.yml b/gateway/conf/gateway-config-example.yml\nindex f8e084f16c1..ce89eaadc5f 100644\n--- a/gateway/conf/gateway-config-example.yml\n+... | [
{
"diff_hunk": "@@ -29,6 +29,40 @@ export const bigNumberWithDecimalToStr = (n: BigNumber, d: number): string => {\n .join('');\n };\n \n+export const stringWithDecimalToBigNumber = (\n+ numberStr: string,\n+ d: number\n+): BigNumber => {\n+ const leftAndRight = numberStr.split('.');\n+\n+ if (leftAndRi... | ae557fe235cfe58bc692d7e459ab13830e017913 | diff --git a/gateway/conf/gateway-config-example.yml b/gateway/conf/gateway-config-example.yml
index 2de9d8f9a56..09e1db1b64c 100644
--- a/gateway/conf/gateway-config-example.yml
+++ b/gateway/conf/gateway-config-example.yml
@@ -26,6 +26,6 @@ ETH_GAS_STATION_REFRESH_TIME: 60
ETH_MANUAL_GAS_PRICE: 100
# Uniswap
-UNI... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__transformers-37613@af3f6ec | huggingface/transformers | Python | 37,613 | Fixes #37219 : RecurrentGemma crashes for inputs longer than sliding window length | ### Fix: Long-context bug in RecurrentGemma generation (#37219)
This PR resolves a shape mismatch error during generation with long prompts in `RecurrentGemma`, caused by the `attention_mask` not being cropped to the model’s sliding attention window.
The model expects a fixed-size attention window (`attention_win... | 2025-04-18T13:07:31Z | RecurrentGemma crashes during inference for inputs longer than sliding window width
### System Info
**System Info:**
- `transformers` version: 4.50.3
- Platform: Linux-6.8.0-52-generic-x86_64-with-glibc2.35
- Python version: 3.10.16
- Huggingface_hub version: 0.30.1
- Safetensors version: 0.5.3
- Accelerate version: 1... | Hi @assafbk, can you use [git bisect](https://git-scm.com/docs/git-bisect) to identify the commit where this bug appeared? It'll help a lot in identifying the cause and assigning the right person to fix it!
RecurrentGemma generation was functional until commit 295a90cb40468ddd607577448e674348cff55adc (v4.46.0), which i... | [
{
"body": "### System Info\n\n**System Info:**\n- `transformers` version: 4.50.3\n- Platform: Linux-6.8.0-52-generic-x86_64-with-glibc2.35\n- Python version: 3.10.16\n- Huggingface_hub version: 0.30.1\n- Safetensors version: 0.5.3\n- Accelerate version: 1.6.0\n- Accelerate config: not found\n- DeepSpeed vers... | fee1190601b5d04ec6d3f7f58fd22788d7f3236d | {
"head_commit": "af3f6ec404c2ce441c9eaed09ea5238d3de21635",
"head_commit_message": "fix ruff",
"patch_to_review": "diff --git a/src/transformers/models/recurrent_gemma/modeling_recurrent_gemma.py b/src/transformers/models/recurrent_gemma/modeling_recurrent_gemma.py\nindex 2e2afdbc015a..fcf2402ec9b1 100644\n--- a... | [
{
"diff_hunk": "@@ -349,18 +349,14 @@ def test_model_2b_8bit(self):\n \n @require_read_token\n def test_long_context(self):\n- input_text = [\n- '<bos><s>Marseille, France (CNN)The French prosecutor leading an investigation into the crash of Germanwings Flight 9525 insisted Wednesday t... | bb92b91a48dc168992e20ce7d5c34ac1150702e5 | diff --git a/src/transformers/models/recurrent_gemma/modeling_recurrent_gemma.py b/src/transformers/models/recurrent_gemma/modeling_recurrent_gemma.py
index 2e2afdbc015a..fcf2402ec9b1 100644
--- a/src/transformers/models/recurrent_gemma/modeling_recurrent_gemma.py
+++ b/src/transformers/models/recurrent_gemma/modeling_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
hummingbot__hummingbot-3794@7a09848 | hummingbot/hummingbot | Python | 3,794 | Feat/ndax config parameters | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")
**A description of the changes proposed in the pull request**:
Added configuration parameters to establish the connection with N... | 2021-07-26T20:31:17Z | Add NDAX parameters and configurations to the client
Add required parameters and configuration entries to make NDAX connector available and usable from the client.
### Definition of Done
- NDAX connector is included in connectors table
- NDAX connector can be created and all its parameters specified: user id, user na... | [
{
"body": "Add required parameters and configuration entries to make NDAX connector available and usable from the client.\n\n### Definition of Done\n\n- NDAX connector is included in connectors table\n- NDAX connector can be created and all its parameters specified: user id, user name, API key, API secret\n- Th... | eaf45727d17b6eede28308bb19374bcbb27ca05c | {
"head_commit": "7a09848a67db9016ab0655095e4013cb9977aa1b",
"head_commit_message": "Fix tests that create NdaxExchange instances with the old parameter names",
"patch_to_review": "diff --git a/hummingbot/connector/exchange/ndax/ndax_exchange.py b/hummingbot/connector/exchange/ndax/ndax_exchange.py\nindex 6c7ac41... | [
{
"diff_hunk": "@@ -75,7 +75,7 @@ def convert_diff_message_to_order_book_row(message: OrderBookMessage) -> Tuple[L\n KEYS = {\n \"probit_api_key\":\n ConfigVar(key=\"probit_api_key\",\n- prompt=\"Enter your ProBit Client ID >>> \",\n+ prompt=\"Enter your ProBit API ... | 29b5edbad2c64385bf0e9d711a976d55acedd2dc | diff --git a/hummingbot/connector/exchange/ndax/ndax_auth.py b/hummingbot/connector/exchange/ndax/ndax_auth.py
index 3b40f1883e5..b93f9310daf 100644
--- a/hummingbot/connector/exchange/ndax/ndax_auth.py
+++ b/hummingbot/connector/exchange/ndax/ndax_auth.py
@@ -10,19 +10,19 @@ class NdaxAuth():
Auth class required ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-59892@48bdca3 | getsentry/sentry | Python | 59,892 | feat(metrics) Handle Investigation rules limit reached in UI | This PR handles investigation rules limit reached errors by displaying a
specific message to the user indicating that the maximum number of allowed
rules has been reached.
resolves https://github.com/getsentry/sentry/issues/59681 | 2023-11-14T10:22:24Z | Stop users from creating more than 50 investigation rules per project
Users should not be able to create more than 50 investigation rules that apply to a project.
Need to figure out the user experience for limiting this.
We could simply disable the rule creation if adding another rule would cause any project to g... | Let's display the Get Samples button, and if they press it and would go over 50 rules per project, the frontend will display the red toast notification (bottom right) saying "We are already getting samples for maximum amount of concurrent queries". - wording in progress | [
{
"body": "Users should not be able to create more than 50 investigation rules that apply to a project.\r\n\r\nNeed to figure out the user experience for limiting this.\r\n\r\nWe could simply disable the rule creation if adding another rule would cause any project to go over the limit.\r\nThis would be quite co... | fba4d07362f2585752994c25962d92bca07ef998 | {
"head_commit": "48bdca30fcbc78d21c66042f347b0d07db805559",
"head_commit_message": "Display different message for investigation limit reached error",
"patch_to_review": "diff --git a/static/app/components/dynamicSampling/investigationRule.spec.tsx b/static/app/components/dynamicSampling/investigationRule.spec.ts... | [
{
"diff_hunk": "@@ -256,6 +256,37 @@ describe('InvestigationRule', function () {\n await tick();\n expect(createRule).toHaveBeenCalledTimes(1);\n // we should show some error that the rule could not be created\n- expect(addErrorMessage).toHaveBeenCalledTimes(1);\n+ expect(addErrorMessage).toHa... | eb9cecc200538704c6ecbd9b41a8827351d1ec62 | diff --git a/static/app/components/dynamicSampling/investigationRule.spec.tsx b/static/app/components/dynamicSampling/investigationRule.spec.tsx
index 0892eef3997424..28c0e8b584db33 100644
--- a/static/app/components/dynamicSampling/investigationRule.spec.tsx
+++ b/static/app/components/dynamicSampling/investigationRul... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
hummingbot__hummingbot-3619@6facce4 | hummingbot/hummingbot | Python | 3,619 | Refactor/ Perpetual Trading base class | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")
**A description of the changes proposed in the pull request**:
- Add Perpetual Trading base class (to replace DerivativeBase cla... | 2021-06-22T05:50:49Z | Create new PerpetualTrading base class
**Description**
Create a new connector base class PerpetualTrading based on hummingbot/connector/derivative_base.py. This new base class is to define what perpetual trading is (like an interface). Perpetual connectors will need to implement this class as well as ConnectorBase or ... | [
{
"body": "**Description**\r\nCreate a new connector base class PerpetualTrading based on hummingbot/connector/derivative_base.py. This new base class is to define what perpetual trading is (like an interface). Perpetual connectors will need to implement this class as well as ConnectorBase or ExchangeBase (mult... | eead73462b73aa80ce0de3e53245f24a9393fd58 | {
"head_commit": "6facce49f769ae0743f8c2e53f8e1c4b7eb1c883",
"head_commit_message": "(refactor) add perpetual trading base class and unit test",
"patch_to_review": "diff --git a/hummingbot/connector/perpetual_trading.py b/hummingbot/connector/perpetual_trading.py\nnew file mode 100644\nindex 00000000000..2b7f0d37... | [
{
"diff_hunk": "@@ -0,0 +1,83 @@\n+from decimal import Decimal\n+from typing import Dict, List\n+from hummingbot.core.event.events import PositionMode, FundingInfo\n+from hummingbot.connector.derivative.position import Position\n+\n+\n+NaN = float(\"nan\")\n+s_decimal_NaN = Decimal(\"nan\")\n+s_decimal_0 = Deci... | d11c73d96adb84f416c30ed60d7c7d75cf0201ee | diff --git a/hummingbot/connector/perpetual_trading.py b/hummingbot/connector/perpetual_trading.py
new file mode 100644
index 00000000000..371f9e70a8d
--- /dev/null
+++ b/hummingbot/connector/perpetual_trading.py
@@ -0,0 +1,104 @@
+from decimal import Decimal
+from typing import Dict, List, Optional
+from hummingbot.co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
huggingface__diffusers-6808@15c08a1 | huggingface/diffusers | Python | 6,808 | [Contributor Experience] Fix test collection on MPS | # What does this PR do?
Fixes test collection on MPS.
Fixes #6807
## Before submitting
- [x] Did you read the [contributor guideline](https://github.com/huggingface/diffusers/blob/main/CONTRIBUTING.md)?
- [x] Did you read our [philosophy doc](https://github.com/huggingface/diffusers/blob/main/PHILOSOPHY.md... | 2024-02-01T09:59:08Z | [Contributor Experience] Test Collection fails on MPS
### Describe the bug
On MPS, the test collection fails. Therefore not all tests are shown e.g. in VS Code, which makes the contributor experience more tedious.
Currently, 4515-4486 = 29 tests are missed.
---
The error is caused because in `utls/testing_uti... | [
{
"body": "### Describe the bug\n\nOn MPS, the test collection fails. Therefore not all tests are shown e.g. in VS Code, which makes the contributor experience more tedious.\r\n\r\nCurrently, 4515-4486 = 29 tests are missed.\r\n\r\n---\r\n\r\nThe error is caused because in `utls/testing_utils.py` the variable `... | ec9840a5db98cd181f7239a482ec8e6d1e35fd23 | {
"head_commit": "15c08a18b8b04e65c5d87660b9136ee5b9c54aed",
"head_commit_message": "Update testing_utils.py",
"patch_to_review": "diff --git a/src/diffusers/utils/testing_utils.py b/src/diffusers/utils/testing_utils.py\nindex 86e31eb688cd..87551d1ceb60 100644\n--- a/src/diffusers/utils/testing_utils.py\n+++ b/sr... | [
{
"diff_hunk": "@@ -860,7 +860,7 @@ def _is_torch_fp64_available(device):\n return True\n \n except Exception as e:\n- if device.type == \"cuda\":",
"line": null,
"original_line": 863,
"original_start_line": null,
"path": "src/diffusers/utils/testing_utils.py",
"start_line... | 1630bac667282facebc3e58232cb16974493f7d6 | diff --git a/src/diffusers/utils/testing_utils.py b/src/diffusers/utils/testing_utils.py
index 86e31eb688cd..edbf6f31a833 100644
--- a/src/diffusers/utils/testing_utils.py
+++ b/src/diffusers/utils/testing_utils.py
@@ -854,6 +854,8 @@ def _is_torch_fp64_available(device):
import torch
+ device = torch.devic... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-62336@9b5756f | getsentry/sentry | Python | 62,336 | ref(similarity-embeddings): Modify existing similarity UI | Change the existing similarity UI in the following ways:
- Convert Exception & Message UI to numbers (i.e. remove the bars UI)
- Remove color legend
- Remove the hover experience on “Exception” and “Message”
- Remove the button to show issues below the threshold, we’ll just show everything
with flag:
<img width... | 2023-12-27T19:15:53Z | Change existing similarity UI to use numbers
Change the existing similarity UI in the following ways:
- Convert Exception & Message UI to numbers (i.e. remove the bars UI)
- Remove color legend
- Remove the hover experience on “Exception” and “Message”
- Remove the button to show issues below the threshold, we’ll just... | [
{
"body": "Change the existing similarity UI in the following ways:\n\n- Convert Exception & Message UI to numbers (i.e. remove the bars UI)\n- Remove color legend\n- Remove the hover experience on “Exception” and “Message”\n- Remove the button to show issues below the threshold, we’ll just show everything",
... | 6ebeaa3e9f20ee38375251b50185c95adf8aa4b4 | {
"head_commit": "9b5756fa73c328068ea010ff3b1ae9a3d8e20e81",
"head_commit_message": "fix: Use useOrganization for feature check",
"patch_to_review": "diff --git a/static/app/views/issueDetails/groupSimilarIssues/index.spec.tsx b/static/app/views/issueDetails/groupSimilarIssues/index.spec.tsx\nindex 50ee5df6ad35da... | [
{
"diff_hunk": "@@ -47,18 +51,36 @@ describe('Issues Similar View', function () {\n \n const router = RouterFixture();\n \n+ function mockOrganization(props?: {features: string[]}) {\n+ const features = props?.features ?? [];\n+ jest.mocked(useOrganization).mockReturnValue(Organization({features}));\n+... | 8e9f0cc4ff3d9f2020ef6efdad008fbecc8d458e | diff --git a/static/app/views/issueDetails/groupSimilarIssues/index.spec.tsx b/static/app/views/issueDetails/groupSimilarIssues/index.spec.tsx
index 2d7000ca3f210b..a7f3d152b98727 100644
--- a/static/app/views/issueDetails/groupSimilarIssues/index.spec.tsx
+++ b/static/app/views/issueDetails/groupSimilarIssues/index.sp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
hummingbot__hummingbot-3656@db1f91d | hummingbot/hummingbot | Python | 3,656 | feat/ Implement an `APIThrottler` that accommodates the various Rate Limit types | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")
**A description of the changes proposed in the pull request**:
Implement a new `APIThrottler` class to handle all rate limit i... | 2021-06-30T03:09:36Z | Implement `APIThrottler` class
**Initial Investigation**
- There are several ways Rate Limits are being implemented by the various exchanges.
1. Weighted Requests, where each user is assigned a fix rate limit and each method is assigned a weight. This is used by Binance. Where certain API endpoints has a higher wei... | [
{
"body": "**Initial Investigation**\n- There are several ways Rate Limits are being implemented by the various exchanges. \n\n 1. Weighted Requests, where each user is assigned a fix rate limit and each method is assigned a weight. This is used by Binance. Where certain API endpoints has a higher weight depen... | 471de7fa86884e75c9c0fedcf9e02f69d1752fa7 | {
"head_commit": "db1f91d87aed1749959f7996342e7f4ac524b849",
"head_commit_message": "(feat) refactor APIThrottler class into a base class",
"patch_to_review": "diff --git a/hummingbot/connector/exchange/crypto_com/crypto_com_constants.py b/hummingbot/connector/exchange/crypto_com/crypto_com_constants.py\nindex 7e... | [
{
"diff_hunk": "@@ -0,0 +1,44 @@\n+from typing import Deque, List\n+\n+from hummingbot.core.api_throttler.api_request_context_base import APIRequestContextBase\n+from hummingbot.core.api_throttler.api_throttler_base import APIThrottlerBase\n+from hummingbot.core.api_throttler.data_types import (\n+ RateLimit... | bf8805ff26835d8d6a863212a035742b85568152 | diff --git a/hummingbot/connector/exchange/crypto_com/crypto_com_constants.py b/hummingbot/connector/exchange/crypto_com/crypto_com_constants.py
index 7e871e40200..f62a0b513fe 100644
--- a/hummingbot/connector/exchange/crypto_com/crypto_com_constants.py
+++ b/hummingbot/connector/exchange/crypto_com/crypto_com_constant... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__diffusers-6751@97fa1ca | huggingface/diffusers | Python | 6,751 | Fix mixed precision fine-tuning for text-to-image-lora-sdxl example. | # What does this PR do?
Fixes https://github.com/huggingface/diffusers/issues/6442
Part of https://github.com/huggingface/diffusers/issues/6552
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guide... | 2024-01-29T15:20:38Z | ValueError: Attempting to unscale FP16 gradients.
I am trying to resume training a lora in sdxl but when I try to resume it gives an error `ValueError: Attempting to unscale FP16 gradients.`
It works the first time but when I resume training it gives me that error
```
!accelerate launch --mixed_precision="fp16"... | You'll need to cast the torch.float16 to torch.float32 for trainable parameters.
Refer to this code block: https://github.com/huggingface/diffusers/blob/main/examples/text_to_image/train_text_to_image_lora_sdxl.py#L632-L641
Excuse me, what should I do then?
Should have been fixed by: https://github.com/huggingface/... | [
{
"body": "I am trying to resume training a lora in sdxl but when I try to resume it gives an error `ValueError: Attempting to unscale FP16 gradients.`\r\nIt works the first time but when I resume training it gives me that error\r\n\r\n\r\n```\r\n!accelerate launch --mixed_precision=\"fp16\" /content/train_tex... | acd1962769715cebee1bb8e87075db4e78490070 | {
"head_commit": "97fa1cac4e0e613780b5d9a5bf79ba688a78794a",
"head_commit_message": "Fix mixed precision fine-tuning for text-to-image-lora-sdxl example.",
"patch_to_review": "diff --git a/examples/text_to_image/train_text_to_image_lora_sdxl.py b/examples/text_to_image/train_text_to_image_lora_sdxl.py\nindex 24e1... | [
{
"diff_hunk": "@@ -693,18 +690,34 @@ def load_model_hook(models, input_dir):\n else:\n raise ValueError(f\"unexpected save model: {model.__class__}\")\n \n- lora_state_dict, network_alphas = LoraLoaderMixin.lora_state_dict(input_dir)\n- LoraLoaderMixin.load_lora_into_u... | 83fbca1fec14f1048bacf17e9c03feb02d31c104 | diff --git a/examples/text_to_image/train_text_to_image_lora_sdxl.py b/examples/text_to_image/train_text_to_image_lora_sdxl.py
index 24e182c895d4..78a412f1818f 100644
--- a/examples/text_to_image/train_text_to_image_lora_sdxl.py
+++ b/examples/text_to_image/train_text_to_image_lora_sdxl.py
@@ -35,7 +35,7 @@
from datas... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.