instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
hummingbot__hummingbot-3447@d4d3edb | hummingbot/hummingbot | Python | 3,447 | Refactor/ Add init_params fn to strategies | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")
**A description of the changes proposed in the pull request**:
- Add init_params to assign strategy parameters to be called afte... | 2021-05-26T08:04:10Z | Expose argument details and values for all strategies
**Feature Suggestion**
Expose two things for each strategy class:
- `classmethod` `argument_details` that contains details of all arguments (as we cannot introspect cython class `__init__`)
- `property` `argument_values` that contains a dictionary mapping all the... | Related clubhouse stories
https://app.clubhouse.io/coinalpha/story/14279/add-required-methods-to-single-market-hummingbot-strategies-for-grid-search
https://app.clubhouse.io/coinalpha/story/15065/add-required-methods-to-remaining-hummingbot-strategies-for-grid-search
I had a discussion with @kmcgowan2000 on this, her... | [
{
"body": "**Feature Suggestion**\r\nExpose two things for each strategy class:\r\n- `classmethod` `argument_details` that contains details of all arguments (as we cannot introspect cython class `__init__`)\r\n- `property` `argument_values` that contains a dictionary mapping all the argument names to their curr... | 7f0e6b3448d64f1ebca62dd2ba42a7180419757e | {
"head_commit": "d4d3edb5472f99010695d2fdc52021d7bb442f42",
"head_commit_message": "(refactor) add start unit tests",
"patch_to_review": "diff --git a/hummingbot/client/command/config_command.py b/hummingbot/client/command/config_command.py\nindex d852b96b1e8..02188b1ad54 100644\n--- a/hummingbot/client/command/... | [
{
"diff_hunk": "@@ -6,44 +6,42 @@ channels:\n dependencies:\n - _libgcc_mutex=0.1=conda_forge\n - _openmp_mutex=4.5=0_gnu\n- - blas=1.0=openblas\n- - blosc=1.16.3=hd408876_0\n- - bzip2=1.0.8=h7b6447c_0\n- - ca-certificates=2020.1.1=0\n- - certifi=2019.11.28=py38_0\n+ - blas=1.1\n+ - blosc=1.21.0\n+ ... | ff741a77103c1e6c64baf4e95ae3fe86f33ee629 | diff --git a/hummingbot/client/command/config_command.py b/hummingbot/client/command/config_command.py
index 80bfdb16934..b2e92618eee 100644
--- a/hummingbot/client/command/config_command.py
+++ b/hummingbot/client/command/config_command.py
@@ -20,6 +20,7 @@
from hummingbot.client.config.security import Security
from... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-6438@39364c5 | huggingface/diffusers | Python | 6,438 | Update installation.md | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2024-01-03T13:45:00Z | pip install --upgrade diffusers[torch] fails with Python 3.12 on Windows 11
### Describe the bug
`pip install --upgrade diffusers[torch]` with Python 3.12 results in a failed installation, with one the (many) errors being:
`ERROR: Could not find a version that satisfies the requirement torch (from versions: none)... | Hi @sayakpaul @patrickvonplaten, I would like to try this issue. Thanks
@Bhavay-2001 feel free to give it try! thank you
Hi @yiyixuxu since i am new to open source, could you please suggest how can I begin solving. Thanks
Probably could just put a small note in the Installation section of the README.
Something alon... | [
{
"body": "### Describe the bug\n\n`pip install --upgrade diffusers[torch]` with Python 3.12 results in a failed installation, with one the (many) errors being: \r\n\r\n`ERROR: Could not find a version that satisfies the requirement torch (from versions: none)`\r\n\r\nWorkaround: \r\nUse Python 3.11.\r\n\r\nNo... | 774f5c45817805546ae5eb914c175d4fe72dcfe9 | {
"head_commit": "39364c5bfb3c91f9de3441bd58225eccb311be94",
"head_commit_message": "Update installation.md",
"patch_to_review": "diff --git a/docs/source/en/installation.md b/docs/source/en/installation.md\nindex 3bf1d46fd0c7..c1146570e668 100644\n--- a/docs/source/en/installation.md\n+++ b/docs/source/en/instal... | [
{
"diff_hunk": "@@ -41,6 +41,7 @@ You should also install 🤗 Transformers because 🤗 Diffusers relies on its m\n <pt>\n ```bash\n pip install diffusers[\"torch\"] transformers\n+Note - PyTorch doesn't support Python 3.12 on Windows. Please use Python 3.11 instead.",
"line": null,
"original_line": 44,
... | 3f4e24221d114158dc55be53b58ff539d88a8e4c | diff --git a/docs/source/en/installation.md b/docs/source/en/installation.md
index 3bf1d46fd0c7..8e0eddd17598 100644
--- a/docs/source/en/installation.md
+++ b/docs/source/en/installation.md
@@ -37,8 +37,10 @@ source .env/bin/activate
You should also install 🤗 Transformers because 🤗 Diffusers relies on its models:... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
hummingbot__hummingbot-2709@4b8aa61 | hummingbot/hummingbot | Python | 2,709 | Feat / add position management for perpetual strategy | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")
**After creating this PR, please make sure:**
- [x] You link the related GitHub issue or ticket
**A description of the chan... | 2020-12-10T15:00:34Z | [Feature] Derivatives position profit taking feature
**Feature Suggestion**
A feature to be able to define a take-profit % value for derivatives would be nice.
**Impact**
// A succinct description of **why you want the _desired behavior_** specified above.
This could make market making more profitable on perpet... | [
{
"body": "**Feature Suggestion**\r\nA feature to be able to define a take-profit % value for derivatives would be nice.\r\n\r\n**Impact**\r\n// A succinct description of **why you want the _desired behavior_** specified above.\r\n\r\nThis could make market making more profitable on perpetual contracts. Current... | 57a2b388e89fbee35331fe60facbebf00bedb7d2 | {
"head_commit": "4b8aa6155dfd3e8f69dc9cab399ffe26ef3489de",
"head_commit_message": "Merge branch 'feat/position_management_for_perpetual_strategy' of https://github.com/CoinAlpha/hummingbot into feat/position_management_for_perpetual_strategy",
"patch_to_review": "diff --git a/hummingbot/client/command/create_co... | [
{
"diff_hunk": "@@ -186,6 +190,55 @@ def derivative_on_validated(value: str):\n type_str=\"decimal\",\n validator=validate_order_amount,\n prompt_on_new=True),\n+ \"position_management\":\n+ ConfigVar(key=\"position_management\",\n+ ... | bc577bd37e855529367ac7e0041e00a1729f4dfe | diff --git a/hummingbot/client/command/create_command.py b/hummingbot/client/command/create_command.py
index 012d1440ef0..f769751d2d5 100644
--- a/hummingbot/client/command/create_command.py
+++ b/hummingbot/client/command/create_command.py
@@ -58,7 +58,7 @@ async def prompt_for_configuration(self, # type: HummingbotA... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-58293@0a3de26 | getsentry/sentry | Python | 58,293 | feat(issue-platform): Add STATUS_CHANGE payload and support RESOLVED statuses | Adds a new payload_type, STATUS_CHANGE, to the issue platform and sets it up to support the RESOLVED status. We add validation to ensure the provided (status, substatus) pair is valid before updating the group status, activity, and group history.
Fixes https://github.com/getsentry/sentry/issues/58034
FIxes https:/... | 2023-10-17T21:12:42Z | Add a new payload type to the Issue Platform API
The issue platform API should be extended to support a `status_update` payload type in addition to `occurrence`.
The `status_update` message format is as follows:
* `fingerprint`: uniquely identifier for the occurrence
* `new_status`: status string, one of { `resol... | [
{
"body": "The issue platform API should be extended to support a `status_update` payload type in addition to `occurrence`. \r\n\r\nThe `status_update` message format is as follows:\r\n* `fingerprint`: uniquely identifier for the occurrence\r\n* `new_status`: status string, one of { `resolved` | `archived` | `u... | 3889396ece04fc61e247a05a8ad0e94be1414da4 | {
"head_commit": "0a3de26823d7a4dbf2be7ab0091de9899e56bab1",
"head_commit_message": "Address PR comments",
"patch_to_review": "diff --git a/src/sentry/issues/occurrence_status_change.py b/src/sentry/issues/occurrence_status_change.py\nnew file mode 100644\nindex 00000000000000..d2a45999984214\n--- /dev/null\n+++ ... | [
{
"diff_hunk": "@@ -0,0 +1,58 @@\n+from __future__ import annotations\n+\n+import logging\n+from dataclasses import dataclass\n+from typing import Sequence\n+\n+from sentry.models.group import Group, GroupStatus\n+from sentry.types.activity import ActivityType\n+\n+logger = logging.getLogger(__name__)\n+\n+\n+@... | 0acde4a846cde33866522178dfba29742ba493a3 | diff --git a/src/sentry/data/samples/generic-event-profiling.json b/src/sentry/data/samples/generic-event-profiling.json
index 7e6332693d0a1f..6a30f156bc1816 100644
--- a/src/sentry/data/samples/generic-event-profiling.json
+++ b/src/sentry/data/samples/generic-event-profiling.json
@@ -1,381 +1,374 @@
{
- "detectio... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__transformers-37972@3de7505 | huggingface/transformers | Python | 37,972 | New cache tests and modular Hybrid Cache | ## What does this PR do?
1. Refactor out the cache update logic for static and sliding window attention mechanisms.
Extracts the core update logic into two new utility functions: `_static_cache_update_logic` and `_sliding_cache_update_logic`. This way, there is only one implementation for StaticCache, SlidingWindow... | 2025-05-06T09:59:39Z | Wrong KV cache update for sliding-window attention (SWA) layers when total sequence length reaches window size
### System Info
```text
- `transformers` version: 4.51.2
- Platform: Linux-6.8.0-1021-aws-x86_64-with-glibc2.35
- Python version: 3.12.8
- Huggingface_hub version: 0.30.2
- Safetensors version: 0.5.3
- Accele... | cc @gante
I may have unintentionally fixed this issue while writing sanity-check tests for all caches: https://github.com/huggingface/transformers/pull/37873
(@manueldeprada your tests will still be useful here, to prevent regressions)
The PR should definitely fix the bug and prevent any regression. thanks a lot @pli... | [
{
"body": "### System Info\n\n```text\n- `transformers` version: 4.51.2\n- Platform: Linux-6.8.0-1021-aws-x86_64-with-glibc2.35\n- Python version: 3.12.8\n- Huggingface_hub version: 0.30.2\n- Safetensors version: 0.5.3\n- Accelerate version: 1.5.2\n- Accelerate config: not found\n- DeepSpeed version: not ins... | 183fb3637cae5e3161c969981a20d4da2e12b617 | {
"head_commit": "3de75053b4598b82d2ed9637218be6ff3d1cda73",
"head_commit_message": "Update src/transformers/cache_utils.py\n\nCo-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>",
"patch_to_review": "diff --git a/src/transformers/cache_utils.py b/src/transformers/cache_utils.py\nindex 85a09f0... | [
{
"diff_hunk": "@@ -916,10 +901,167 @@ def test_hybrid_cache_prompt_longer_than_max_cache_len(self):\n layer_idx=0,\n cache_kwargs={\"cache_position\": cache_position, \"sliding_window\": self.window_size},\n )\n- stored_keys, stored_values = self._extract_both_caches(hybr... | d719ef43f3132515d10a19ae2415720488f579db | diff --git a/src/transformers/cache_utils.py b/src/transformers/cache_utils.py
index 40737bb69adf..d24edd390c26 100644
--- a/src/transformers/cache_utils.py
+++ b/src/transformers/cache_utils.py
@@ -21,6 +21,104 @@
logger = logging.get_logger(__name__)
+# Utility functions for static/sliding cache update logic
+de... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-58644@6ebe331 | getsentry/sentry | Python | 58,644 | Julia/discord supported channels | Adding support for threads and giving specific error messages with failure.
<img height="300" alt="Screenshot 2023-10-25 at 4 14 44 PM" src="https://github.com/getsentry/sentry/assets/22582037/ad52ff1d-b26d-4a21-b291-2b73cdf3d1cf">
<img height="300" alt="Screenshot 2023-10-25 at 4 14 33 PM" src="https://github.co... | 2023-10-23T19:55:01Z | Support notifications for different channel types in Discord
- Discord Forums need higher permissions and will say that message is sent when it does not send
- When permissions fail, maybe link to docs of all the necessary permissions for different use cases
```[tasklist]
### Tasks
- [ ] Update docs
``` | [
{
"body": "- Discord Forums need higher permissions and will say that message is sent when it does not send\n- When permissions fail, maybe link to docs of all the necessary permissions for different use cases\n```[tasklist]\n### Tasks\n- [ ] Update docs\n```\n",
"number": 58536,
"title": "Support notif... | 7ed4c4caab87f0224df94ec89e93162e2f8bdb2f | {
"head_commit": "6ebe3311e7c6c1427fbe7d1ab09ae6cf5d894b4f",
"head_commit_message": "Add type to mock response",
"patch_to_review": "diff --git a/src/sentry/incidents/logic.py b/src/sentry/incidents/logic.py\nindex bc5dcda3aae39c..7616d3eebd6411 100644\n--- a/src/sentry/incidents/logic.py\n+++ b/src/sentry/incide... | [
{
"diff_hunk": "@@ -18,6 +18,12 @@ class DiscordClient(IntegrationProxyClient):\n integration_name: str = \"discord\"\n base_url: str = \"https://discord.com/api/v10\"\n \n+ # https://discord.com/developers/docs/resources/channel#channel-object-channel-types\n+ GUILD_TEXT = 0",
"line": null,
... | 999a16f429d6fcfa0cc3c12a0de11669a391a497 | diff --git a/src/sentry/incidents/logic.py b/src/sentry/incidents/logic.py
index 4b7957899e5d0c..3e3ced8eb0b1f9 100644
--- a/src/sentry/incidents/logic.py
+++ b/src/sentry/incidents/logic.py
@@ -1352,11 +1352,8 @@ def get_alert_rule_trigger_action_discord_channel_id(
integration_id=integration.id,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
huggingface__diffusers-5854@c9215c1 | huggingface/diffusers | Python | 5,854 | [docs] MusicLDM | Fixes #5835 to use a compatible checkpoint | 2023-11-17T22:58:37Z | Using pretrained MusicLDM pipeline
### Describe the bug
Hello, in diffusers docs, MusicLDM is used as follow:
```python
from diffusers import MusicLDMPipeline
import torch
import scipy
repo_id = "cvssp/audioldm-s-full-v2"
pipe = MusicLDMPipeline.from_pretrained(repo_id, torch_dtype=torch.float16)
pipe = pipe.... | [
{
"body": "### Describe the bug\n\nHello, in diffusers docs, MusicLDM is used as follow:\r\n```python\r\nfrom diffusers import MusicLDMPipeline\r\nimport torch\r\nimport scipy\r\n\r\nrepo_id = \"cvssp/audioldm-s-full-v2\"\r\npipe = MusicLDMPipeline.from_pretrained(repo_id, torch_dtype=torch.float16)\r\npipe = p... | 4e54dfe985293df9e6e86828d7a2763d076879f5 | {
"head_commit": "c9215c173aa0ecf34c6415dbda0eed89bb92f68b",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/src/diffusers/pipelines/musicldm/pipeline_musicldm.py b/src/diffusers/pipelines/musicldm/pipeline_musicldm.py\nindex 9e6b6fea13e5..3a499674ec3e 100644\n--- a/src/diffusers/pipelines/musicldm... | [
{
"diff_hunk": "@@ -51,7 +51,7 @@\n >>> import torch\n >>> import scipy\n \n- >>> repo_id = \"cvssp/audioldm-s-full-v2\"\n+ >>> repo_id = \"sanchit-gandhi/musicldm-full\"",
"line": null,
"original_line": 54,
"original_start_line": null,
"path": "src/diffusers/pipeli... | aaed706038933f47c8db4921590c994749f29d0f | diff --git a/src/diffusers/pipelines/musicldm/pipeline_musicldm.py b/src/diffusers/pipelines/musicldm/pipeline_musicldm.py
index 9e6b6fea13e5..68af3925fa02 100644
--- a/src/diffusers/pipelines/musicldm/pipeline_musicldm.py
+++ b/src/diffusers/pipelines/musicldm/pipeline_musicldm.py
@@ -51,7 +51,7 @@
>>> import... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} | |
huggingface__transformers-38466@b393a94 | huggingface/transformers | Python | 38,466 | Fix HQQ model param device transfer issue | # What does this PR do?
Fixes #36254
And this PR makes it possible to infer bnb-4bit Flux with hqq-4bit quantized T5 model in the diffusers pipeline.
I uploaded models to [HighCWu/FLUX.1-dev-bnb-hqq-4bit](https://huggingface.co/HighCWu/FLUX.1-dev-bnb-hqq-4bit).
I use hqq-4bit to quantize T5. It seems to qua... | 2025-05-29T07:54:17Z | Is T5 model supported with HQQ quantization ? (AttributeError: 'HQQLinear' object has no attribute 'weight')
### System Info
- `transformers` version: 4.48.2
- Platform: Linux-6.8.0-52-generic-x86_64-with-glibc2.35
- Python version: 3.11.11
- Huggingface_hub version: 0.28.1
- Safetensors version: 0.5.2
- Accelerate ve... | cc @SunMarc @MekkCyber for quantization
Just mentioning that this conversion was done before (not sure how) https://huggingface.co/HighCWu/FLUX.1-dev-4bit/tree/main/text_encoder_2
Linking this issue here: https://github.com/mobiusml/hqq/issues/150
The suggested [method](https://github.com/mobiusml/hqq/issues/150#issue... | [
{
"body": "### System Info\n\n- `transformers` version: 4.48.2\n- Platform: Linux-6.8.0-52-generic-x86_64-with-glibc2.35\n- Python version: 3.11.11\n- Huggingface_hub version: 0.28.1\n- Safetensors version: 0.5.2\n- Accelerate version: 1.3.0\n- Accelerate config: \t- compute_environment: LOCAL_MACHINE\n\t- dist... | 9300728665aaeb0ebf4db99f9d9fbce916b4a183 | {
"head_commit": "b393a94073af1e7b4f881dd5d61f10225419f9fb",
"head_commit_message": "Merge branch 'main' into hqq-compat-with-diffusers",
"patch_to_review": "diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py\nindex 480e6f3f3f32..83a09a864baf 100644\n--- a/src/transformers/modeli... | [
{
"diff_hunk": "@@ -3921,7 +3934,25 @@ def to(self, *args, **kwargs):\n break\n \n if getattr(self, \"quantization_method\", None) == QuantizationMethod.HQQ:\n- raise ValueError(\"`.to` is not supported for HQQ-quantized models.\")\n+ from hqq.core.quantize impo... | 496af21c3d53fa31f78aad0b141653ee42ad71d1 | diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py
index a0f5180ac8b1..bb3e6ed5c3a4 100644
--- a/src/transformers/modeling_utils.py
+++ b/src/transformers/modeling_utils.py
@@ -3897,7 +3897,20 @@ def get_memory_footprint(self, return_buffers=True):
@wraps(torch.nn.Module.cuda)
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
huggingface__diffusers-5697@f441b9f | huggingface/diffusers | Python | 5,697 | [Bugfix] fix error of peft lora when xformers enabled | # What does this PR do?
Fixes #5504
Related PR: https://github.com/huggingface/diffusers/pull/5506
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/diffuse... | 2023-11-08T09:14:48Z | PEFT LoRA not working with xformers.
### Describe the bug
PEFT LoRA not working with xformers.
### Reproduction
```python
from diffusers import DiffusionPipeline
import torch
pipe = DiffusionPipeline.from_pretrained("./models/checkpoint/stable-diffusion-xl-base-1.0", torch_dtype=torch.float16)
pipe.load_lora_w... | I think maybe can add this code to fix this issue.
```
class XFormersAttnProcessor:
# ...
args = () if USE_PEFT_BACKEND else (scale,)
# ...
query = attn.to_q(hidden_states, *args)
```
I have create a pull request to fix this problems. @younesbelkada @sayakpaul
https://github.c... | [
{
"body": "### Describe the bug\n\nPEFT LoRA not working with xformers.\n\n### Reproduction\n\n```python\r\nfrom diffusers import DiffusionPipeline\r\nimport torch\r\n\r\npipe = DiffusionPipeline.from_pretrained(\"./models/checkpoint/stable-diffusion-xl-base-1.0\", torch_dtype=torch.float16)\r\npipe.load_lora_w... | 65ef7a0c5c594b4f84092e328fbdd73183613b30 | {
"head_commit": "f441b9f1917fea2595715ce85e6eff15fdf0421a",
"head_commit_message": "bugfix peft lor",
"patch_to_review": "diff --git a/src/diffusers/models/attention_processor.py b/src/diffusers/models/attention_processor.py\nindex e1ae2c1c064b..44d04370694f 100644\n--- a/src/diffusers/models/attention_processor... | [
{
"diff_hunk": "@@ -1207,12 +1215,8 @@ def __call__(\n elif attn.norm_cross:\n encoder_hidden_states = attn.norm_encoder_hidden_states(encoder_hidden_states)\n \n- key = (\n- attn.to_k(encoder_hidden_states, scale=scale) if not USE_PEFT_BACKEND else attn.to_k(encoder_hidden... | c25e3bc77c96d65ea025c946741dd6b6731d13e8 | diff --git a/src/diffusers/models/attention_processor.py b/src/diffusers/models/attention_processor.py
index 7fb524110ea1..1234dbd2d5ce 100644
--- a/src/diffusers/models/attention_processor.py
+++ b/src/diffusers/models/attention_processor.py
@@ -879,6 +879,9 @@ def __call__(
scale: float = 1.0,
) -> torc... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-57953@a242641 | getsentry/sentry | Python | 57,953 | feat(participants): Unsubscribe participants when reassigned and unassigned | When an issue is unassigned or reassigned, we should remove them from being a participant and notify them that the issue was assigned to someone else (unless it was unassigned, then they are notified that it was unassigned aka assigned to nobody).
Closes #57719 | 2023-10-11T23:39:51Z | [BE] Unsubscribe previous group assignees
If a user or team was assigned an issue they become participants, but if the issue is unassigned or re-assigned to another user or team, we do not remove the subscription for the previous assignees. We should remove previous assignees _but_ ensure they receive a workflow notifi... | [
{
"body": "If a user or team was assigned an issue they become participants, but if the issue is unassigned or re-assigned to another user or team, we do not remove the subscription for the previous assignees. We should remove previous assignees _but_ ensure they receive a workflow notification that they are un... | ecea4292c3b30f289d5f27092f48ee88914d3ee3 | {
"head_commit": "a242641aebc3a8400b160fd87d127bcc67aa71a7",
"head_commit_message": "add notification tests",
"patch_to_review": "diff --git a/src/sentry/api/helpers/group_index/update.py b/src/sentry/api/helpers/group_index/update.py\nindex de6bcde9fa15a2..b2459f52f8dac5 100644\n--- a/src/sentry/api/helpers/grou... | [
{
"diff_hunk": "@@ -836,6 +836,9 @@ def handle_assigned_to(\n )\n if assigned_actor:\n for group in group_list:\n+ if features.has(\"organizations:participants-purge\", group.organization):\n+ GroupAssignee.objects.deassign(group, acting_user)",
"line": null,
"o... | 1f828585271589cfbd6bc96b564aefb71d6813c8 | diff --git a/src/sentry/api/helpers/group_index/update.py b/src/sentry/api/helpers/group_index/update.py
index de6bcde9fa15a2..facee6357d792e 100644
--- a/src/sentry/api/helpers/group_index/update.py
+++ b/src/sentry/api/helpers/group_index/update.py
@@ -838,6 +838,9 @@ def handle_assigned_to(
for group in gro... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-58301@f7aafdf | getsentry/sentry | Python | 58,301 | feat(issue-platform): Add logic to set status to ignored for issue platform issues | Sets up the issue platform API support the IGNORED (or archived) status. We add validation to ensure the provided (status, substatus) pair is valid before updating the group status, activity, and group history.
The expectation for the UNTIL_ESCALATING and UNTIL_CONDITION_MET substatuses is that the caller will handl... | 2023-10-17T22:40:21Z | Support updating occurrence status to `Archived` via API
Payload:
```
payload_type: "status_update",
status_update: {
fingerprint: <>
new_status: "archived"
new_substatus: "forever" | "until_escalating" | "until_condition_met"
```
Expectations:
- [ ] The occurrence with the given fingerprint has the st... | [
{
"body": "Payload:\r\n```\r\npayload_type: \"status_update\",\r\nstatus_update: {\r\n fingerprint: <>\r\n new_status: \"archived\"\r\n new_substatus: \"forever\" | \"until_escalating\" | \"until_condition_met\"\r\n```\r\n\r\nExpectations:\r\n- [ ] The occurrence with the given fingerprint has the status Arc... | a1a9452abbeeab17481e97e0c8926c26ae007d16 | {
"head_commit": "f7aafdfd4600d55ecf6221769212f1d79c1a5bab",
"head_commit_message": "Fix test conditions",
"patch_to_review": "diff --git a/src/sentry/event_manager.py b/src/sentry/event_manager.py\nindex 4eb8b2c7fc71a1..b25cc3b56014ce 100644\n--- a/src/sentry/event_manager.py\n+++ b/src/sentry/event_manager.py\n... | [
{
"diff_hunk": "@@ -75,127 +77,167 @@ def test_with_status_change(self):\n },\n project_id=self.project.id,\n )\n- group = event.group\n- assert group\n- group_hash = GroupHash.objects.filter(group=group, project=self.project).first()\n- initial_status... | b8053abfbbfd9dd5168870ebf824f976c1676bd0 | diff --git a/src/sentry/issues/occurrence_status_change.py b/src/sentry/issues/occurrence_status_change.py
new file mode 100644
index 00000000000000..ef6510302f3d7a
--- /dev/null
+++ b/src/sentry/issues/occurrence_status_change.py
@@ -0,0 +1,73 @@
+from __future__ import annotations
+
+import logging
+from dataclasses ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
hummingbot__hummingbot-2513@3956cf3 | hummingbot/hummingbot | Python | 2,513 | feat / Add inventory cost price type | Closes: #2314
**Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")
**After creating this PR, please make sure:**
- [x] You link the related GitHub issue or ticket
**A description of th... | 2020-10-26T07:53:58Z | [Feature] Pure Market Maker strategy using the inventory cost as mid price for new orders
**Feature Suggestion**
Implement a simpler and less-risk strategy that considers the average inventory buying cost as the reference for new orders.
Every time a bid type order is filled, the bot updates a new variable called `... | @phbrgnomo is there a typo in section "When a ask order is filled:", should be
`inventory_cost = inventory_cost - (order_amount * ask_price)` ?
It's interesting how this simple strategy behaves when profits are realized: with every profit trade inventory cost is decreased, which means that upper bound for buy orders... | [
{
"body": "**Feature Suggestion**\r\nImplement a simpler and less-risk strategy that considers the average inventory buying cost as the reference for new orders.\r\n\r\nEvery time a bid type order is filled, the bot updates a new variable called `inventory_price`, which will store the volume-weighted average pr... | 1a1b17facda45411b6dbd71bbd0fabab5016ebd7 | {
"head_commit": "3956cf3f584c4c7b708ed5e558382885113d4df6",
"head_commit_message": "(fix) Add default value for inventory_price\n\nIt's ok to set default because it doesn't set the default in database.\nSo, it doesn't affect anything",
"patch_to_review": "diff --git a/hummingbot/client/command/config_command.py ... | [
{
"diff_hunk": "@@ -0,0 +1,68 @@\n+from decimal import Decimal, InvalidOperation\n+\n+from hummingbot.core.event.events import OrderFilledEvent, TradeType\n+from hummingbot.exceptions import NoPrice\n+from hummingbot.model.inventory_cost import InventoryCost\n+from hummingbot.model.sql_connection_manager import... | e6eea01a47fead8cbdaa9c3e5aa1a4055f4dc4d6 | diff --git a/hummingbot/client/command/config_command.py b/hummingbot/client/command/config_command.py
index b5da7a80bcb..05d56d54d52 100644
--- a/hummingbot/client/command/config_command.py
+++ b/hummingbot/client/command/config_command.py
@@ -6,12 +6,13 @@
from decimal import Decimal
import pandas as pd
from os.pa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-57951@3ed3d99 | getsentry/sentry | Python | 57,951 | feat(issue-stream): Add "unhandled" as collapsable parameter | this pr adds in "unhandled" as a collapsable parameter for the issues stream request. right now, the issue stream request has to wait for the unhandled stats to be found, which slows things down. to get around this, we will collapse "unhandled" and make a separate request to find the "unhandled" information , similar t... | 2023-10-11T23:18:10Z | Update `OrganizationGroupIndexEndpoint` to handle "unhandled" as collapse
We need to add in the ability to collapse "unhandled" to the `OrganizationGroupIndexEndpoint`. From there, we need to use that collapsed parameter and pass it down to `get_attrs` and prevent `get_group_snuba_stats` from being called. | [
{
"body": "We need to add in the ability to collapse \"unhandled\" to the `OrganizationGroupIndexEndpoint`. From there, we need to use that collapsed parameter and pass it down to `get_attrs` and prevent `get_group_snuba_stats` from being called. ",
"number": 57844,
"title": "Update `OrganizationGroupIn... | 40655eb75a659b0c6785e238b024bc51166ad1ab | {
"head_commit": "3ed3d998dfbbad135fb9855fafed5748df09b589",
"head_commit_message": "add collapse for unhandled",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/organization_group_index.py b/src/sentry/api/endpoints/organization_group_index.py\nindex 1c7e4e81e052ed..327dea1cdbe91e 100644\n--- a/src/sen... | [
{
"diff_hunk": "@@ -289,7 +289,9 @@ def get_attrs(\n ):\n merge_list_dictionaries(annotations_by_group_id, annotations_by_group)\n \n- snuba_stats = self._get_group_snuba_stats(item_list, seen_stats)\n+ snuba_stats = {}\n+ if not self._collapse(\"unhandled\"):\n+ ... | 6ebc60c70da3357e18d74e5dc144d72562cd3c79 | diff --git a/src/sentry/api/endpoints/organization_group_index.py b/src/sentry/api/endpoints/organization_group_index.py
index 1c7e4e81e052ed..327dea1cdbe91e 100644
--- a/src/sentry/api/endpoints/organization_group_index.py
+++ b/src/sentry/api/endpoints/organization_group_index.py
@@ -228,7 +228,7 @@ def get(self, req... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-59962@cd1b51b | getsentry/sentry | Python | 59,962 | Fix(Redirection on deleting monitor): fixed redirection on deleting monitor |
Fixes: #59723
When the filter is applied on crons page (monitor listing page) - then prevUrl gets added to URL. which helps in redirection to the correct URL when the monitor is deleted by user.
<!-- Describe your PR here. -->
<!--
Sentry employees and contractors can delete or ignore the following.
... | 2023-11-15T05:32:43Z | Crons: Deleting a monitor removes the project selection
If you have a project selected, and go to your monitor details page and delete a monitor, the page is redirected back to the monitors list however the project selection is cleared.
Expected behavior: the project selection should not be cleared. | Routing to @getsentry/product-owners-crons for [triage](https://develop.sentry.dev/processing-tickets/#3-triage) ⏲️
Hi,
Is it open?
Can i try resolving this?
Hey @Shubhdeep12, thanks for the interest! You are more than welcome to try and resolve it. Please make sure to read our [CONTRIBUTING.md](https://github.com/ge... | [
{
"body": "If you have a project selected, and go to your monitor details page and delete a monitor, the page is redirected back to the monitors list however the project selection is cleared.\n\nExpected behavior: the project selection should not be cleared.",
"number": 59723,
"title": "Crons: Deleting ... | 62ef714de2259a3c574a14b6c65da0a11dfc8053 | {
"head_commit": "cd1b51bc1913b4862719084d0396c0b781afebfd",
"head_commit_message": "fixed redirection on deleting monitor",
"patch_to_review": "diff --git a/static/app/views/monitors/components/monitorHeaderActions.tsx b/static/app/views/monitors/components/monitorHeaderActions.tsx\nindex 43f3ee029924d4..9a9cbbe... | [
{
"diff_hunk": "@@ -22,11 +23,19 @@ type Props = {\n \n function MonitorHeaderActions({monitor, orgId, onUpdate}: Props) {\n const api = useApi();\n+ const router = useRouter();\n+\n const {selection} = usePageFilters();\n \n const handleDelete = async () => {\n await deleteMonitor(api, orgId, monito... | 21647755f619e75ad91581d2aadd84132ea482fc | diff --git a/static/app/views/monitors/components/cronsLandingPanel.tsx b/static/app/views/monitors/components/cronsLandingPanel.tsx
index 5c6c8cc64ec1a0..32357bf9404802 100644
--- a/static/app/views/monitors/components/cronsLandingPanel.tsx
+++ b/static/app/views/monitors/components/cronsLandingPanel.tsx
@@ -13,6 +13,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-57874@e7d10fa | getsentry/sentry | Python | 57,874 | feat(participants): Remove some comment participants | When a user and/or team are mentioned in a comment, they will no longer be subscribed to the issue. Also, if a user deletes their only comment on an issue, they will be unsubscribed from the issue (unless they were initially subscribed for some other reason like being assigned, bookmarking, explicitly subscribing, etc)... | 2023-10-10T23:09:08Z | [BE] Unsubscribe commenters/mentioned users and teams
Users and teams who are mentioned in a comment should no longer be automatically subscribed to be a participant.
When a user deletes their own comment and their subscription reason was commenting, they should be unsubscribed. | [
{
"body": "Users and teams who are mentioned in a comment should no longer be automatically subscribed to be a participant.\n\nWhen a user deletes their own comment and their subscription reason was commenting, they should be unsubscribed.",
"number": 57720,
"title": "[BE] Unsubscribe commenters/mention... | 3c6bdaafdf16f5945c84fd46acce628f1b052fd6 | {
"head_commit": "e7d10fa5bb9a9f562f8eacf6e07e7b63c3ab8dfb",
"head_commit_message": "add reason to filter",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/group_notes.py b/src/sentry/api/endpoints/group_notes.py\nindex bdbe9887a1096f..8dfb3e79f29eba 100644\n--- a/src/sentry/api/endpoints/group_notes.py... | [
{
"diff_hunk": "@@ -29,11 +32,19 @@ def delete(self, request: Request, group, note_id) -> Response:\n if not request.user.is_authenticated:\n raise PermissionDenied(detail=\"Key doesn't have permission to delete Note\")\n \n- try:\n- note = Activity.objects.get(\n- ... | 8acbf63a67b81a39eca73042ecdc266c0b992e3e | diff --git a/src/sentry/api/endpoints/group_notes.py b/src/sentry/api/endpoints/group_notes.py
index bdbe9887a1096f..8dfb3e79f29eba 100644
--- a/src/sentry/api/endpoints/group_notes.py
+++ b/src/sentry/api/endpoints/group_notes.py
@@ -70,24 +70,29 @@ def post(self, request: Request, group) -> Response:
GroupSu... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-57805@bb432e9 | getsentry/sentry | Python | 57,805 | feat(feedback): Add github feedback components | Add pre-styled components to ask users for feedback on GitHub.
Add `GithubFeedbackButton`
Add `GithubFeedbackTooltip`
<img width="214" alt="Screenshot 2023-10-10 at 13 12 28" src="https://github.com/getsentry/sentry/assets/7033940/556ed17c-19f5-440b-b465-adae5d51bb37">
<img width="248" alt="Screenshot 2023-10-10... | 2023-10-10T11:11:59Z | GitHub Feedback Component
Let's do a PoC of a feedback component that enables you to give feedback in a public way (github discussion).
We likely want two components:
- Button
- button with GitHub icon
- accepts discussion URL as a prop
- is `ExternalLink`
- accepts buttonProps so that consumers can modify it ... | [
{
"body": "Let's do a PoC of a feedback component that enables you to give feedback in a public way (github discussion).\n\nWe likely want two components:\n- Button\n - button with GitHub icon\n - accepts discussion URL as a prop\n - is `ExternalLink`\n - accepts buttonProps so that consumers can modify it ... | 4937e8fd815d4fca646c845020e6c6a619bf0a46 | {
"head_commit": "bb432e968bba39483368c385e897ef30f929ba64",
"head_commit_message": "feat(feedback): Add github feedback components",
"patch_to_review": "diff --git a/static/app/components/githubFeedbackButton.spec.tsx b/static/app/components/githubFeedbackButton.spec.tsx\nnew file mode 100644\nindex 000000000000... | [
{
"diff_hunk": "@@ -0,0 +1,16 @@\n+import {LinkButton, LinkButtonProps} from 'sentry/components/button';\n+import {Tooltip} from 'sentry/components/tooltip';\n+import {IconGithub} from 'sentry/icons';\n+import {t} from 'sentry/locale';\n+\n+type GithubFeedbackButtonProps = LinkButtonProps & {href: string};\n+\n... | ac2b3e236e32d416c1a5d5f20d22f52c0f97446a | diff --git a/static/app/components/githubFeedbackButton.spec.tsx b/static/app/components/githubFeedbackButton.spec.tsx
new file mode 100644
index 00000000000000..9e8afd2c4fd5fa
--- /dev/null
+++ b/static/app/components/githubFeedbackButton.spec.tsx
@@ -0,0 +1,46 @@
+import {render, screen, userEvent} from 'sentry-test/... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
hummingbot__hummingbot-2187@42ccf37 | hummingbot/hummingbot | Python | 2,187 | Fix / balance limit to account for orders filled | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/", etc)
**Optional**:
- Related Github issue: #1443 Fixes #2145
- Related Clubhouse Story:
**A description of the changes pro... | 2020-08-08T13:33:58Z | [Feature] Allow limiting the amount of assets HB can access in an exchange/wallet
**Feature Suggestion**
There should be an ability to limit the amount of assets HB can access/use in an exchange or wallet. The asset symbol and the limit size in asset units should be configurable.
**Impact**
It can be a good securi... | The closes function that I could think of is Hummingbot feature called [kill-switch](https://docs.hummingbot.io/utilities/kill-switch/). Automatically stops the bot when it reaches a certain performance threshold, which can be either positive or negative.
But this could be a good new feature.
I like this feature. Sh... | [
{
"body": "**Feature Suggestion**\r\nThere should be an ability to limit the amount of assets HB can access/use in an exchange or wallet. The asset symbol and the limit size in asset units should be configurable.\r\n\r\n**Impact**\r\nIt can be a good security measure to avoid unexpected and undesirable losses. ... | 8bb5cd8733d1f3de92c587d02104b4200d78c721 | {
"head_commit": "42ccf37776dc59534d3555ca0e54b9d0382e3ac4",
"head_commit_message": "(fix) no update on avaliable balance, when get account for order filled balance",
"patch_to_review": "diff --git a/hummingbot/market/bamboo_relay/bamboo_relay_market.pyx b/hummingbot/market/bamboo_relay/bamboo_relay_market.pyx\ni... | [
{
"diff_hunk": "@@ -217,12 +227,34 @@ cdef class MarketBase(NetworkIterator):\n \"\"\"\n return self._account_balances.get(currency, s_decimal_0)\n \n+ def available_balance_limit_applied(self, currency: str, limit: Decimal) -> Decimal:\n+ \"\"\"\n+ Apply budget limit on an avai... | e375b2ae9a47d7b54433a8f55d5da9ad33cb2867 | diff --git a/hummingbot/client/command/balance_command.py b/hummingbot/client/command/balance_command.py
index 4c54b1897d8..898b1a25d04 100644
--- a/hummingbot/client/command/balance_command.py
+++ b/hummingbot/client/command/balance_command.py
@@ -3,11 +3,7 @@
)
from hummingbot.user.user_balances import UserBalances... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-5435@7edad66 | huggingface/diffusers | Python | 5,435 | Make T2I-Adapter downscale padding match the UNet | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2023-10-17T23:30:46Z | Make T2I-Adapter downscale padding match the UNet
# Background
T2I-Adapter models produce residual maps that must match the corresponding UNet hidden state dimensions at each downscaling level. This works as expected when the T2I-Adapter's input image is evenly divisible by the T2I-Adapter's `total_downscale_factor`... | Cc @MC-E here as well.
@sayakpaul @yiyixuxu can we try to look into this ourselves and try to solve it?
Sorry for getting to this a bit late.
Excellent thread here @RyanJDick! Thanks for detailing about the problem!
From my side:
* It's definitely worth fixing! And then it would be interesting to see the im... | [
{
"body": "# Background\r\n\r\nT2I-Adapter models produce residual maps that must match the corresponding UNet hidden state dimensions at each downscaling level. This works as expected when the T2I-Adapter's input image is evenly divisible by the T2I-Adapter's `total_downscale_factor`.\r\n\r\nFor example, a `Fu... | e5168588864d72a4dca37e90318c6b11da0eaaf1 | {
"head_commit": "7edad66c5826bc14cae081ae1a9695b985291785",
"head_commit_message": "Update the T2I-Adapter down blocks to better match the padding behavior of the UNet.",
"patch_to_review": "diff --git a/src/diffusers/models/adapter.py b/src/diffusers/models/adapter.py\nindex 64d64d07bf77..6e1918334f13 100644\n-... | [
{
"diff_hunk": "@@ -186,8 +220,10 @@ def test_stable_diffusion_adapter_default_case(self):\n image = sd_pipe(**inputs).images\n image_slice = image[0, -3:, -3:, -1]\n \n- assert image.shape == (1, 64, 64, 3)\n- expected_slice = np.array([0.4858, 0.5500, 0.4278, 0.4669, 0.6184, 0.43... | 2a99be92ad7f8d935f360ef33a77fc78d6087b26 | diff --git a/src/diffusers/models/adapter.py b/src/diffusers/models/adapter.py
index 64d64d07bf77..388915e7c02d 100644
--- a/src/diffusers/models/adapter.py
+++ b/src/diffusers/models/adapter.py
@@ -20,7 +20,6 @@
from ..configuration_utils import ConfigMixin, register_to_config
from ..utils import logging
from .mode... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
hummingbot__hummingbot-2254@801f298 | hummingbot/hummingbot | Python | 2,254 | feat / Make more params configurable on the fly | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/", etc)
**Optional**:
- Related Github issue: #1716
- Related Clubhouse Story:
**A description of the changes proposed in th... | 2020-08-25T17:58:14Z | Make more params configurable on the fly
In the PMM strategy, all parameters that do not entail changing markets should be configurable on the fly. I think they should take into effect at the next tick if possible
The key ones include:
- `order_amount`
- `order_levels`
- `order_level_spread`
- `filled_order_del... | if there are so many key options to configure in the future, possible to allow user to add it as a separate strategy file. similar to this feature request: https://github.com/CoinAlpha/hummingbot/issues/1968 | [
{
"body": "In the PMM strategy, all parameters that do not entail changing markets should be configurable on the fly. I think they should take into effect at the next tick if possible \r\n\r\nThe key ones include:\r\n- `order_amount`\r\n- `order_levels`\r\n- `order_level_spread`\r\n- `filled_order_delay\r\n- `i... | eaf766da108372fedff3f43e0512acd70ca57441 | {
"head_commit": "801f29874bbf201ee2576bdcbcc6f47770be0346",
"head_commit_message": "(feat) Make more params configurable on the fly",
"patch_to_review": "diff --git a/hummingbot/client/command/config_command.py b/hummingbot/client/command/config_command.py\nindex 6daca2fe7f2..fab116ba06a 100644\n--- a/hummingbot... | [
{
"diff_hunk": "@@ -606,6 +606,9 @@ cdef class PureMarketMakingStrategy(StrategyBase):\n MarketBase market = self._market_info.market\n list buys = []\n list sells = []\n+ # It is necessary to point buy and sell levels to order_levels in order to make the configurable ... | d16aa46542727314970ef36be62c256f4bca7665 | diff --git a/hummingbot/client/command/config_command.py b/hummingbot/client/command/config_command.py
index 6daca2fe7f2..fab116ba06a 100644
--- a/hummingbot/client/command/config_command.py
+++ b/hummingbot/client/command/config_command.py
@@ -28,7 +28,8 @@
from hummingbot.client.hummingbot_application import Hum... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-4982@85ae421 | huggingface/diffusers | Python | 4,982 | Remove logger.info statement from Unet2DCondition code to ensure torch compile reliably succeeds | # What does this PR do?
Fixes #3933 | 2023-09-11T17:52:04Z | Graph compile breaks due to logging.info
### Describe the bug
When building a unet via `torch.compile(pipeline.unet)`, I receive an error.
### Reproduction
1. Load SD 2.1 `ptx0/pseudo-flex-base`
2. Compile the unet
3. See that the error prevents continuance
4. Remove the logging.info line from the module
5. Comp... | Hey @bghira,
I can't really reproduce the error. The following works for me on `torch==2.0.1`:
```py
from diffusers import StableDiffusionPipeline
import torch
path = "ptx0/pseudo-flex-base"
pipe = StableDiffusionPipeline.from_pretrained(path, torch_dtype=torch.float16)
pipe.unet = torch.compile(pipe.une... | [
{
"body": "### Describe the bug\n\nWhen building a unet via `torch.compile(pipeline.unet)`, I receive an error.\n\n### Reproduction\n\n1. Load SD 2.1 `ptx0/pseudo-flex-base`\r\n2. Compile the unet\r\n3. See that the error prevents continuance\r\n4. Remove the logging.info line from the module\r\n5. Compile work... | d82157b3ce7884308eaa9f19b7362f53505c9824 | {
"head_commit": "85ae4219c939aae35a1910d1fdc6000b6a7517bd",
"head_commit_message": "Convert logging statement to a comment for future archaeologists",
"patch_to_review": "diff --git a/src/diffusers/models/unet_2d_condition.py b/src/diffusers/models/unet_2d_condition.py\nindex d695d182fa37..0a362406f2a2 100644\n-... | [
{
"diff_hunk": "@@ -784,7 +784,7 @@ def forward(\n upsample_size = None\n \n if any(s % default_overall_up_factor != 0 for s in sample.shape[-2:]):\n- logger.info(\"Forward upsample size to force interpolation output size.\")\n+ \"\"\"Forward upsample size to force interpol... | 5401e816f6d32b77f1e289568b68cab18f210678 | diff --git a/src/diffusers/models/unet_2d_condition.py b/src/diffusers/models/unet_2d_condition.py
index d695d182fa37..60b66a7fdf04 100644
--- a/src/diffusers/models/unet_2d_condition.py
+++ b/src/diffusers/models/unet_2d_condition.py
@@ -784,7 +784,7 @@ def forward(
upsample_size = None
if any(s % ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-56555@d75437d | getsentry/sentry | Python | 56,555 | fix(platforms): Streamline php-symfony platform name | * Streamline naming / types to use `php-symfony` where possible
* This fixes a bug where the wrong (generic) cron onboarding was shown for symfony.
Closes https://github.com/getsentry/sentry/issues/55974 | 2023-09-20T12:39:29Z | Cleanup naming miss-match between php-symfony and php-symfony2
Sometimes we use `php-symfony2` as this is the name in the sentry docs.
However, the platform in the sentry codebase is actually called `php-symfony`.
Since we moved the getting-started docs to sentry, we can clean up this missmatch and helper functions th... | [
{
"body": "Sometimes we use `php-symfony2` as this is the name in the sentry docs.\nHowever, the platform in the sentry codebase is actually called `php-symfony`.\n\nSince we moved the getting-started docs to sentry, we can clean up this missmatch and helper functions that convert the platform name.",
"numb... | ac2be2efb2f778dbd568191bfb6c6bb70665b2bb | {
"head_commit": "d75437dab4bac1f0ca04435bb09121a7619f6517",
"head_commit_message": "fix(platforms): Streamline php-szmfony platform name",
"patch_to_review": "diff --git a/static/app/components/onboarding/productSelection.tsx b/static/app/components/onboarding/productSelection.tsx\nindex 66f5e547d2835c..f93c4321... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "static/app/components/profiling/ProfilingOnboarding/util.ts",
"start_line": null,
"text": "@author:\nAfter updating `static/app/utils/profiling/platforms.tsx` ts complained about the typing in h... | a071d6af7926765f95f0df71849a91c1f22a4e97 | diff --git a/static/app/components/onboarding/productSelection.tsx b/static/app/components/onboarding/productSelection.tsx
index 66f5e547d2835c..e9566badcf036b 100644
--- a/static/app/components/onboarding/productSelection.tsx
+++ b/static/app/components/onboarding/productSelection.tsx
@@ -119,11 +119,7 @@ export const... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
hummingbot__hummingbot-2122@f4b6c16 | hummingbot/hummingbot | Python | 2,122 | feat/ implement balance limit command | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/", etc)
**Optional**:
- Related Github issue:
#1443
- Related Clubhouse Story:
https://app.clubhouse.io/coinalpha/story/9682/im... | 2020-07-29T00:50:37Z | [Feature] Allow limiting the amount of assets HB can access in an exchange/wallet
**Feature Suggestion**
There should be an ability to limit the amount of assets HB can access/use in an exchange or wallet. The asset symbol and the limit size in asset units should be configurable.
**Impact**
It can be a good securi... | The closes function that I could think of is Hummingbot feature called [kill-switch](https://docs.hummingbot.io/utilities/kill-switch/). Automatically stops the bot when it reaches a certain performance threshold, which can be either positive or negative.
But this could be a good new feature.
I like this feature. Sh... | [
{
"body": "**Feature Suggestion**\r\nThere should be an ability to limit the amount of assets HB can access/use in an exchange or wallet. The asset symbol and the limit size in asset units should be configurable.\r\n\r\n**Impact**\r\nIt can be a good security measure to avoid unexpected and undesirable losses. ... | e913e33217e01d1c0555716f827c7e4d7cf7be8d | {
"head_commit": "f4b6c16fdfcf30d30e7c25040de3c37801350407",
"head_commit_message": "Merge branch 'development' into feat/limit-asset-access",
"patch_to_review": "diff --git a/hummingbot/client/command/balance_command.py b/hummingbot/client/command/balance_command.py\nindex 0de9a2b419f..efe2441efd8 100644\n--- a/... | [
{
"diff_hunk": "@@ -391,4 +391,10 @@ def validate_script_file_path(file_path: str) -> Optional[bool]:\n type_str=\"str\",\n required_if=lambda: global_config_map[\"script_enabled\"].value,\n validator=validate_script_file_path),\n+ \"balance_asset_limit\"... | 3c0827924eae4d5746a6a2146665539662847005 | diff --git a/hummingbot/client/command/balance_command.py b/hummingbot/client/command/balance_command.py
index 0de9a2b419f..51a7a1d19a8 100644
--- a/hummingbot/client/command/balance_command.py
+++ b/hummingbot/client/command/balance_command.py
@@ -1,24 +1,88 @@
+from hummingbot.client.settings import (
+ GLOBAL_CON... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
hummingbot__hummingbot-2133@591c904 | hummingbot/hummingbot | Python | 2,133 | Feat / deprecate market order type | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/", etc)
- [x] Deprecate MARKER OrderType in all CEXs connectors
- [x] Modify PMM and ARB to work with recent changes
- [ ] Modify XMM ... | 2020-07-30T19:00:21Z | [Feature] Deprecate Market Order Type
**Feature Suggestion**
Simply put, there is no use for Market order type in automated trading system.
Limit order will cover most cases, if you want your order to be filled immediately, simply set the price which will likely be filled.
Using market order type has following dis... | [
{
"body": "**Feature Suggestion**\r\nSimply put, there is no use for Market order type in automated trading system.\r\nLimit order will cover most cases, if you want your order to be filled immediately, simply set the price which will likely be filled.\r\n\r\nUsing market order type has following disadvantages:... | 388b96e78e4194f3a20bb758a73e967fe364f89c | {
"head_commit": "591c90466b93687ff3f3af6e95f25fd960d1aece",
"head_commit_message": "(fix) correct Jenkins error related to mock testing",
"patch_to_review": "diff --git a/documentation/docs/developers/tutorial/perform-trade.md b/documentation/docs/developers/tutorial/perform-trade.md\nindex 3cfcc181b54..e5e25fd5... | [
{
"diff_hunk": "@@ -45,7 +45,7 @@ def to_pandas(cls, trades: List):\n trade.trading_pair,\n trade.price,\n trade.amount,\n- \"market\" if trade.order_type is OrderType.MARKET else \"limit\",\n+ \"limit\" if trade.order_type is OrderTy... | 366849edc71bf436c339511e95e0f7f237704786 | diff --git a/documentation/docs/developers/tutorial/perform-trade.md b/documentation/docs/developers/tutorial/perform-trade.md
index 3cfcc181b54..e5e25fd5a12 100644
--- a/documentation/docs/developers/tutorial/perform-trade.md
+++ b/documentation/docs/developers/tutorial/perform-trade.md
@@ -30,7 +30,7 @@ The OrderTrac... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
hummingbot__hummingbot-1995@36e5784 | hummingbot/hummingbot | Python | 1,995 | fix/reduced infura consumption with websocket connection | **Before submitting this PR, please make sure**:
- [ ] Your code builds clean without any errors or warnings
- [ ] You are using approved title ("feat/", "fix/", "docs/", "refactor/", etc)
**A description of the changes proposed in the pull request**:
Reduced infura consumption below 100,000 per day limit wit... | 2020-07-06T19:57:21Z | [Research] Assess Infura usage when using Hummingbot on DEXs
Due to recent changes in rate limits by Infura, user report that Hummingbot clients running PMM with basic settings now hit the daily 100k limit in approx 21 hours.
Assess how severe this issue is by running various bot configurations for 1 hour each and a... | For Infura's free "Core" account, they restrict the number of Requests/Day to 100,000. Otherwise, you have to pay at least $50/month.
We are therefore restricted to about 4,166 requests per hour. After some testing with our PMM strategy on Radar Relay, our client calls Infura ranging from 4000 - 6000 times per hou... | [
{
"body": "Due to recent changes in rate limits by Infura, user report that Hummingbot clients running PMM with basic settings now hit the daily 100k limit in approx 21 hours.\r\n\r\nAssess how severe this issue is by running various bot configurations for 1 hour each and assessing how many Infura calls are mad... | b6ae6d8bb2839249d67ef34cba160d81dabfc4c7 | {
"head_commit": "36e57840ceb50ab77a6365ff29bafbd662c5481b",
"head_commit_message": "Merge branch 'development' into bug/fix_infura_consumption",
"patch_to_review": "diff --git a/hummingbot/client/command/connect_command.py b/hummingbot/client/command/connect_command.py\nindex b60e48d3e24..3d62e4da357 100644\n---... | [
{
"diff_hunk": "@@ -0,0 +1,169 @@\n+import websockets\n+from web3 import Web3\n+from web3.exceptions import BlockNotFound\n+from websockets.exceptions import ConnectionClosedOK\n+import logging\n+import ujson\n+import asyncio\n+\n+from hexbytes import HexBytes\n+from web3.datastructures import AttributeDict\n+f... | a1329e35b24da1823e75ddcaabcf81c1f7028e3b | diff --git a/hummingbot/client/command/connect_command.py b/hummingbot/client/command/connect_command.py
index b60e48d3e24..3d62e4da357 100644
--- a/hummingbot/client/command/connect_command.py
+++ b/hummingbot/client/command/connect_command.py
@@ -142,6 +142,7 @@ async def connect_ethereum(self, # type: HummingbotApp... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
hummingbot__hummingbot-2099@2cb4a12 | hummingbot/hummingbot | Python | 2,099 | feat / continually export trades to CSV file | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/", etc)
**Optional**:
- Related Github issue:
- Related Clubhouse Story: [ch7715]
**A description of the changes proposed in ... | 2020-07-24T01:37:04Z | Continuously save trades to CSV file
**Feature Suggestion**
// A succinct description of **how you want to achieve the desired behavior**.
// If you have looked at the code and know exactly what code changes are needed then please _consider submitting a pull request_ instead.
1) Scheduled auto Trade Data export
2) ... | @sweetpotatoz as a workaround, I can show you how to get trade data from the local database.
@dennisocana can you describe the workaround briefly here?
@mifeng the trades are saved in the database in the `.sqlite` file inside the `/data` folder. I provided instructions how to access this file even if Hummingbot is inst... | [
{
"body": "**Feature Suggestion**\r\n// A succinct description of **how you want to achieve the desired behavior**.\r\n// If you have looked at the code and know exactly what code changes are needed then please _consider submitting a pull request_ instead.\r\n1) Scheduled auto Trade Data export\r\n2) Capable of... | 79bab9aee107564dc6c03a633a6c86ede9f864cc | {
"head_commit": "2cb4a12102d2e02637293746b8122abf60d9c112",
"head_commit_message": "(feat) continually export trades to CSV file",
"patch_to_review": "diff --git a/hummingbot/market/markets_recorder.py b/hummingbot/market/markets_recorder.py\nindex 0439e590010..9cfa3e6fba8 100644\n--- a/hummingbot/market/markets... | [
{
"diff_hunk": "@@ -15,6 +16,7 @@\n Union\n )\n \n+from hummingbot.client.settings import CONF_FILE_PATH",
"line": null,
"original_line": 19,
"original_start_line": null,
"path": "hummingbot/market/markets_recorder.py",
"start_line": null,
"text": "@user1:\nWould this save the file i... | 3cc2f08b8ce347a9ac65dd834b84f11fdc202803 | diff --git a/hummingbot/market/markets_recorder.py b/hummingbot/market/markets_recorder.py
index 0439e590010..618a1eb1c9c 100644
--- a/hummingbot/market/markets_recorder.py
+++ b/hummingbot/market/markets_recorder.py
@@ -1,5 +1,7 @@
#!/usr/bin/env python
+import os.path
+import pandas as pd
import asyncio
from sql... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
hummingbot__hummingbot-2080@0eb0a6a | hummingbot/hummingbot | Python | 2,080 | Feat / add LIMIT_MAKER order type to all cex connectors | **Before submitting this PR, please make sure**:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/", etc)
- [x] Update all existing CEXs to support LIMIT_MAKER where possible
- [x] Update developer manual document, so new connectors ... | 2020-07-20T17:15:01Z | [Feature] Add LIMIT_MAKER order type support to all market connectors
**Feature Suggestion**
LIMIT_MAKER order is a limit order which will be rejected (by the exchange) if they would immediately match and trade as a taker. We have implemented this order type for Binance, I think we should cover all existing exchanges ... | We should add `supported_order_types()` function to the `market_base` (return a list of order_type) class which each connector will need to implement, so that any object that uses the market class knows what are available. e.g. in PMM strategy first check if LIMIT_MAKER is supported by the connector, if not use LIMIT o... | [
{
"body": "**Feature Suggestion**\r\nLIMIT_MAKER order is a limit order which will be rejected (by the exchange) if they would immediately match and trade as a taker. We have implemented this order type for Binance, I think we should cover all existing exchanges which support this type of order. \r\n\r\nTasks:\... | 81aab65331649b0b94da5e2ebb665f8e952e6141 | {
"head_commit": "0eb0a6ada803225b703111a886719deb806d2b12",
"head_commit_message": "(cleanup) raise NotImplementedError for supported_order_types in market_base",
"patch_to_review": "diff --git a/documentation/docs/developers/connectors/tutorial.md b/documentation/docs/developers/connectors/tutorial.md\nindex a8... | [
{
"diff_hunk": "@@ -194,6 +194,9 @@ cdef class MarketBase(NetworkIterator):\n order_size_quantum = self.c_get_order_size_quantum(trading_pair, amount)\n return (amount // order_size_quantum) * order_size_quantum\n \n+ def supported_order_types(self):\n+ raise NotImplementedError",
... | 752fb4cb040c094a56ed7027e7b54a5b8f799f00 | diff --git a/documentation/docs/developers/connectors/tutorial.md b/documentation/docs/developers/connectors/tutorial.md
index 1ab02cfd4ef..a85559c7e26 100644
--- a/documentation/docs/developers/connectors/tutorial.md
+++ b/documentation/docs/developers/connectors/tutorial.md
@@ -202,8 +202,8 @@ Variable(s)<div style="... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-4270@aba9f87 | huggingface/diffusers | Python | 4,270 | auto type conversion | Default value of `control_guidance_start` and `control_guidance_end` in `StableDiffusionControlNetPipeline.check_inputs` function causes `TypeError: object of type 'float' has no len()`
Proposed fix:
Convert `control_guidance_start` and `control_guidance_end` to type list if float
# What does this PR do?
Fix... | 2023-07-25T19:15:18Z | Default args in `StableDiffusionControlNetPipeline.check_inputs` causes TypeError
### Describe the bug
Default value of `control_guidance_start` and `control_guidance_end` in `StableDiffusionControlNetPipeline.check_inputs` function causes `TypeError: object of type 'float' has no len()`
### Reproduction
```
from d... | Does this error only happen when manually calling `check_inputs` or also generally when the pipeline is called?
I see this error when running the community `stable_diffusion_controlnet_reference` pipeline. It might be the only pipeline that calls `StableDiffusionControlNetPipeline.check_inputs` based on my quick search... | [
{
"body": "### Describe the bug\n\nDefault value of `control_guidance_start` and `control_guidance_end` in `StableDiffusionControlNetPipeline.check_inputs` function causes `TypeError: object of type 'float' has no len()`\n\n### Reproduction\n\n```\r\nfrom diffusers import (\r\n StableDiffusionControlNetPipeli... | 161449d51ae24f9b0f4935e8574bbe55c59fe0a4 | {
"head_commit": "aba9f8733e0defd22d9f21245431183703482f06",
"head_commit_message": "Update src/diffusers/pipelines/controlnet/pipeline_controlnet.py",
"patch_to_review": "diff --git a/src/diffusers/pipelines/controlnet/pipeline_controlnet.py b/src/diffusers/pipelines/controlnet/pipeline_controlnet.py\nindex 42d2... | [
{
"diff_hunk": "@@ -554,6 +554,12 @@ def check_inputs(\n else:\n assert False\n \n+ if isinstance(control_guidance_start, float):\n+ control_guidance_start = [control_guidance_start]\n+ \n+ if isinstance(control_guidance_end, float):",
"line": null,
... | 0976542b5067ca248b5106bb02330ca68f7dff8c | diff --git a/src/diffusers/pipelines/controlnet/pipeline_controlnet.py b/src/diffusers/pipelines/controlnet/pipeline_controlnet.py
index 42d2d14c44c5..8804cb5ab7ee 100644
--- a/src/diffusers/pipelines/controlnet/pipeline_controlnet.py
+++ b/src/diffusers/pipelines/controlnet/pipeline_controlnet.py
@@ -554,6 +554,12 @@ ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
huggingface__diffusers-4015@c63a53a | huggingface/diffusers | Python | 4,015 | [SDXL] Partial diffusion support for Text2Img and Img2Img Pipelines | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2023-07-10T04:57:09Z | [SD-XL] Enhanced inference control
## Feature Request: Enhanced Control of the Inference Process in SDXL Pipeline
We are seeking to enhance the control over the denoising process within the SDXL pipeline. The objective is to better handle the generation and refinement of images through fine-tuning of noise application... | cc @patrickvonplaten @sayakpaul
Seems like interesting additions! Thanks for being so detailed. Do you have some results for us to take a look at with these changes?
Hello, I am Sytan, the creator of said workflow. I have been working with Comfy himself to make an optimized SDXL workflow that is not only faster than ... | [
{
"body": "## Feature Request: Enhanced Control of the Inference Process in SDXL Pipeline\r\nWe are seeking to enhance the control over the denoising process within the SDXL pipeline. The objective is to better handle the generation and refinement of images through fine-tuning of noise application and control o... | b9feed87958c27074b0618cc543696c05f58e2c9 | {
"head_commit": "c63a53afd93d869b72c040d3bf7f3e9ae4776940",
"head_commit_message": "diffusers#4003 Do not add noise during img2img when we have a defined first timestep",
"patch_to_review": "diff --git a/src/diffusers/pipelines/stable_diffusion_xl/pipeline_stable_diffusion_xl.py b/src/diffusers/pipelines/stable_... | [
{
"diff_hunk": "@@ -579,6 +580,9 @@ def __call__(\n num_inference_steps (`int`, *optional*, defaults to 50):\n The number of denoising steps. More denoising steps usually lead to a higher quality image at the\n expense of slower inference.\n+ max_inference_... | 3a75d211fe27f4313349bb3fd550fcbcc93b9114 | diff --git a/docs/source/en/api/pipelines/stable_diffusion/stable_diffusion_xl.mdx b/docs/source/en/api/pipelines/stable_diffusion/stable_diffusion_xl.mdx
index 6df873edab00..1c5ea390a49f 100644
--- a/docs/source/en/api/pipelines/stable_diffusion/stable_diffusion_xl.mdx
+++ b/docs/source/en/api/pipelines/stable_diffusi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
hummingbot__hummingbot-1736@8d4dc10 | hummingbot/hummingbot | Python | 1,736 | Feat/pmm price bands | **Before submitting this PR, please make sure**:
- [X] Your code builds clean without any errors or warnings
- [X] You are using approved title ("feat/", "fix/", "docs/", "refactor/", etc)
**Optional**:
- Related Github issue: #1713
- Related Clubhouse Story:
**A description of the changes proposed in the... | 2020-05-13T12:14:34Z | New PMM parameter: price bands
* Add 2 new parameters: `price_ceiling` and `price_floor`
* Set them at -1 by default, which means they are not used
* If the price is within the band set by `floor_price` and `ceiling_price`, run the bot as normal
* If price goes above `price_ceiling`, only place sell orders
* If pr... | Hey @mifeng, I've been pocking around in the repo the last couple of days and I'd like to take a crack at a contribution with this if it's up for grabs.
@petioptrv Wow that would be great!
Note that we are big on unit tests, so if you're working on this feature, please add a test for it in https://github.com/CoinAl... | [
{
"body": "* Add 2 new parameters: `price_ceiling` and `price_floor`\r\n* Set them at -1 by default, which means they are not used\r\n* If the price is within the band set by `floor_price` and `ceiling_price`, run the bot as normal\r\n* If price goes above `price_ceiling`, only place sell orders\r\n* If price f... | 1188e189760826026559597a337d66391d2b4851 | {
"head_commit": "8d4dc10c0e61432b32039e5f271a68c7b35eded2",
"head_commit_message": "Merge branch 'development' into feat/pmm-price-bands",
"patch_to_review": "diff --git a/hummingbot/strategy/pure_market_making/pure_market_making_config_map.py b/hummingbot/strategy/pure_market_making/pure_market_making_config_ma... | [
{
"diff_hunk": "@@ -132,6 +132,20 @@ def exchange_on_validated(value: str):\n type_str=\"decimal\",\n validator=validate_order_amount,\n prompt_on_new=True),\n+ \"price_ceiling\":\n+ ConfigVar(key=\"price_ceiling\",\n+ prompt=\"Ent... | 21eeac58671fb9552e8ee2b311bf9986117e880b | diff --git a/hummingbot/strategy/pure_market_making/pure_market_making_config_map.py b/hummingbot/strategy/pure_market_making/pure_market_making_config_map.py
index b7c37cfeb9d..90a55981f6e 100644
--- a/hummingbot/strategy/pure_market_making/pure_market_making_config_map.py
+++ b/hummingbot/strategy/pure_market_making/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-56207@db8f77a | getsentry/sentry | Python | 56,207 | feat(rule): Create NeglectedAlert table | Create a new `NeglectedAlert` table to store data about rules that haven't been clicked on in X period of time to schedule them for a migration that will disable the rule.
Spec [here](https://www.notion.so/sentry/Disable-Neglected-Alerts-500e904502944d8e963fcd8a693e38bd) for more context.
Closes #56190 | 2023-09-13T19:42:07Z | [BE] Write a migration to create the new `NeglectedAlert` table
- Make a new table `NeglectedAlert`
- `rule_id` nullable False
- `org_id`
- `disable_date` will be “now” (when the script is run) + 14 days nullable False
- `opted_out` boolean so when we re-run we don’t grab the same alert default Fals... | [
{
"body": "- Make a new table `NeglectedAlert`\r\n - `rule_id` nullable False\r\n - `org_id`\r\n - `disable_date` will be “now” (when the script is run) + 14 days nullable False\r\n - `opted_out` boolean so when we re-run we don’t grab the same alert default False\r\n - `has_sent_initial_email` b... | 58b6dc3cbf2638578bc41d289c9e9859091da4f7 | {
"head_commit": "db8f77ac6cce2e08ec6ff39978bcb5ac28cb7879",
"head_commit_message": "add org id, make model name singular, add to a test",
"patch_to_review": "diff --git a/fixtures/backup/model_dependencies/detailed.json b/fixtures/backup/model_dependencies/detailed.json\nindex d464f821d230a0..d8394b4df50dfc 1006... | [
{
"diff_hunk": "@@ -130,3 +131,19 @@ class RuleActivity(Model):\n class Meta:\n app_label = \"sentry\"\n db_table = \"sentry_ruleactivity\"\n+\n+\n+def in_fourteen_days():",
"line": null,
"original_line": 136,
"original_start_line": null,
"path": "src/sentry/models/rule.py",
... | 72fb315956cbcbd37dbc45d824332d00b58a8c28 | diff --git a/fixtures/backup/model_dependencies/detailed.json b/fixtures/backup/model_dependencies/detailed.json
index d464f821d230a0..6364fee7ea1668 100644
--- a/fixtures/backup/model_dependencies/detailed.json
+++ b/fixtures/backup/model_dependencies/detailed.json
@@ -1802,6 +1802,23 @@
"Region"
]
},
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
huggingface__diffusers-3994@cc4a0d4 | huggingface/diffusers | Python | 3,994 | feat: add `act_fn` param to `OutValueFunctionBlock` | # What does this PR do?
<!--
Congratulations! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution.
Then, please replace this w... | 2023-07-07T13:07:05Z | Update UNet1D Tests to not use Mish
**Is your feature request related to a problem? Please describe.**
Currently the `UNet1DTests` heavily rely on mish because they were based on a re-implementation of a model. This is not needed generally, so it would be good to add another 1d model just for tests so we can delete a ... | Hi @natolambert, wondering if I could take up this issue. And do we essentially want _some_ 1D model that can run without requiring mish? Thanks!
Yeah @thehimalayanleo that's exactly right. It's preferable that it has an application, but not needed.
The RL tests can stay as is, it's just that a lot of the `UNet1D` t... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nCurrently the `UNet1DTests` heavily rely on mish because they were based on a re-implementation of a model. This is not needed generally, so it would be good to add another 1d model just for tests so we can delete a lot of the test... | ed2a3584ab2ee59676eb95c884ba2d7bb831f41d | {
"head_commit": "cc4a0d47ba5b70fe344efd0af0e60bca78a095f6",
"head_commit_message": "Merge branch 'main' into saurav/unet1d-mish-fix",
"patch_to_review": "diff --git a/src/diffusers/models/unet_1d_blocks.py b/src/diffusers/models/unet_1d_blocks.py\nindex 3c04bffeeacc..60237bd41edd 100644\n--- a/src/diffusers/mode... | [
{
"diff_hunk": "@@ -235,12 +235,12 @@ def forward(self, hidden_states, temb=None):\n \n \n class OutValueFunctionBlock(nn.Module):\n- def __init__(self, fc_dim, embed_dim):\n+ def __init__(self, fc_dim, embed_dim, act_fn):",
"line": null,
"original_line": 238,
"original_start_line": null,
... | 63db8aa5cb4f2849a0c630373944b096337372f6 | diff --git a/src/diffusers/models/unet_1d_blocks.py b/src/diffusers/models/unet_1d_blocks.py
index 3c04bffeeacc..84ae48e0f8c4 100644
--- a/src/diffusers/models/unet_1d_blocks.py
+++ b/src/diffusers/models/unet_1d_blocks.py
@@ -235,12 +235,12 @@ def forward(self, hidden_states, temb=None):
class OutValueFunctionBlo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
huggingface__diffusers-3832@17d08c0 | huggingface/diffusers | Python | 3,832 | Support for manual CLIP loading in StableDiffusionPipeline - txt2img. | # What does this PR do?
Fixes #3822
This pull request introduces a feature that enhances the loading mechanism of the **`CLIP` model** when used in conjunction with `StableDiffusionPipeline.from_ckpt()`. This PR affects **only the `txt2img`** part of the mentioned pipeline. Users now have the flexibility to manual... | 2023-06-20T14:58:30Z | StableDiffusionPipeline() and CLIP "cooperation"
Hello!
First of all, amazing work, guys! Absolutely love the whole `transformers`, `diffusers` and others for its simplicity! ❤️
I would suggest an improvement to a `StableDiffusionPipeline()` function to allow for portable & offline execution on any machine if the ... | Hey @WadRex,
Very much agree, it would be better to not **force load** the `openai/clip-vit-large-patch14` checkpoint. Think ideally we should actually convert the text encoder completely from the checkpoint file to be sure we have 1-to-1 the same weights. Currently I'm not sure I'll find time to handle this though.... | [
{
"body": "Hello!\r\nFirst of all, amazing work, guys! Absolutely love the whole `transformers`, `diffusers` and others for its simplicity! ❤️ \r\n\r\nI would suggest an improvement to a `StableDiffusionPipeline()` function to allow for portable & offline execution on any machine if the required files are alrea... | fc6acb6b97e93d58cb22b5fee52d884d77ce84d8 | {
"head_commit": "17d08c0ae914d1ce627ffef1d5ca625b1d627d88",
"head_commit_message": "Support for manual CLIP loading in StableDiffusionPipeline - txt2img.",
"patch_to_review": "diff --git a/src/diffusers/loaders.py b/src/diffusers/loaders.py\nindex 5cddb7690e52..1e18c99ddd98 100644\n--- a/src/diffusers/loaders.py... | [
{
"diff_hunk": "@@ -1022,7 +1022,9 @@ def download_from_original_stable_diffusion_ckpt(\n controlnet: Optional[bool] = None,\n load_safety_checker: bool = True,\n pipeline_class: DiffusionPipeline = None,\n- local_files_only=False,\n+ local_files_only = False,\n+ clip_text_model = None,\n+ ... | 9028a8ce15990fcc5a19d3134f0b5c559ebdf330 | diff --git a/src/diffusers/loaders.py b/src/diffusers/loaders.py
index ab1ac7d8bbdf..1bdd33fa80cb 100644
--- a/src/diffusers/loaders.py
+++ b/src/diffusers/loaders.py
@@ -1339,6 +1339,17 @@ def from_ckpt(cls, pretrained_model_link_or_path, **kwargs):
"ddim"]`.
load_safety_checker (`bool`, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-56000@4d6ea7c | getsentry/sentry | Python | 56,000 | feat(alerts): on demand support for apdex | Adds support for apdex alerts with arbitrary thresholds
Requires: https://github.com/getsentry/sentry/pull/55999
Closes: https://github.com/getsentry/sentry/issues/55767
Also fixes an issue where an alert info box was not shown after dismissal | 2023-09-11T15:25:53Z | Support Apdex thresholds
**Problem**: If a user configures an alert based on Apdex where a threshold is different than the one configured in the Project Settings, this should be an on-demand metric.
```[tasklist]
### Tasks
- [ ] FE
- [ ] Extraction
- [ ] Querying
``` | [
{
"body": "**Problem**: If a user configures an alert based on Apdex where a threshold is different than the one configured in the Project Settings, this should be an on-demand metric.\n```[tasklist]\n### Tasks\n- [ ] FE\n- [ ] Extraction\n- [ ] Querying\n```\n",
"number": 55767,
"title": "Support Apdex... | 855ce2b80b6c91ae527875416424e681327539d6 | {
"head_commit": "4d6ea7caaa66313d88c59997ad2f1d69e7344f32",
"head_commit_message": "Merge branch 'master' into ogi/ref/on-demand-apdex-fe",
"patch_to_review": "diff --git a/static/app/components/alerts/onDemandMetricAlert.tsx b/static/app/components/alerts/onDemandMetricAlert.tsx\nindex cef4cd5e7ef56b..3a401c385... | [
{
"diff_hunk": "@@ -227,7 +227,7 @@ export default function MetricDetailsBody({\n <Layout.Side>\n <MetricDetailsSidebar\n rule={rule}\n- isOnDemandMetricAlert={isOnDemandMetricAlert(dataset, query)}\n+ isOnDemandMetricAlert={isOnDemandMetricAlert(dataset, aggr... | 0ff5a09f20a1ce4bba832f92edbf501cd10c3e36 | diff --git a/static/app/components/alerts/onDemandMetricAlert.tsx b/static/app/components/alerts/onDemandMetricAlert.tsx
index cef4cd5e7ef56b..3a401c385f66d0 100644
--- a/static/app/components/alerts/onDemandMetricAlert.tsx
+++ b/static/app/components/alerts/onDemandMetricAlert.tsx
@@ -47,7 +47,7 @@ export function OnD... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-55999@cabfb7a | getsentry/sentry | Python | 55,999 | feat(alerts): treat every apdex as on demand | Changes on demand check and considers every apdex alert as an on-demand alert.
Closes: https://github.com/getsentry/sentry/issues/55767
| 2023-09-11T15:25:32Z | Support Apdex thresholds
**Problem**: If a user configures an alert based on Apdex where a threshold is different than the one configured in the Project Settings, this should be an on-demand metric.
```[tasklist]
### Tasks
- [ ] FE
- [ ] Extraction
- [ ] Querying
``` | [
{
"body": "**Problem**: If a user configures an alert based on Apdex where a threshold is different than the one configured in the Project Settings, this should be an on-demand metric.\n```[tasklist]\n### Tasks\n- [ ] FE\n- [ ] Extraction\n- [ ] Querying\n```\n",
"number": 55767,
"title": "Support Apdex... | 855ce2b80b6c91ae527875416424e681327539d6 | {
"head_commit": "cabfb7ac956f3d1203465e3f7410da532997a355",
"head_commit_message": "Merge branch 'master' into ogi/feat/on-demand-apdex-be",
"patch_to_review": "diff --git a/src/sentry/snuba/metrics/extraction.py b/src/sentry/snuba/metrics/extraction.py\nindex efd6d204e2e420..99295c587f5520 100644\n--- a/src/sen... | [
{
"diff_hunk": "@@ -751,7 +760,7 @@ def _process_query(self) -> RuleCondition:\n parsed_query = self._parse_query(self.query)\n # An on demand metric must have at least a condition, otherwise we can just use a classic metric.\n if parsed_query is None or len(parsed_query.conditions) == 0... | d2e8a0360502008a83054e8182f37b24828556c4 | diff --git a/src/sentry/snuba/metrics/extraction.py b/src/sentry/snuba/metrics/extraction.py
index efd6d204e2e420..e59b9a2c192d3d 100644
--- a/src/sentry/snuba/metrics/extraction.py
+++ b/src/sentry/snuba/metrics/extraction.py
@@ -153,7 +153,7 @@
"browser.name",
"os.name",
"geo.country_code",
- # Thes... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-55479@2f390ed | getsentry/sentry | Python | 55,479 | feat(alerts): Emit `alert.sent` analytic on incidents | fixes #54417 | 2023-08-30T18:52:29Z | Add notification_uuid to IncidentActivity
Add a notification_uuid column to IncidentActivity.
Passed as notification_uuid as a query parameter in URLs
AC:
- Each time we make an entry of IncidentActivity, we should generate and save an `notification_uuid` which is the UUID for the notification sent. Since each Inc... | [
{
"body": "Add a notification_uuid column to IncidentActivity.\r\nPassed as notification_uuid as a query parameter in URLs\r\n\r\nAC:\r\n- Each time we make an entry of IncidentActivity, we should generate and save an `notification_uuid` which is the UUID for the notification sent. Since each IncidentActivity m... | 747bc23c4eb9c653d6606599fd07fb317d4b4506 | {
"head_commit": "2f390ed7807fd79ee6c7f141451052e69be9bd69",
"head_commit_message": "test analytics are fired",
"patch_to_review": "diff --git a/src/sentry/analytics/events/__init__.py b/src/sentry/analytics/events/__init__.py\nindex b059eb52c36966..ecba52dceba6ad 100644\n--- a/src/sentry/analytics/events/__init_... | [
{
"diff_hunk": "@@ -0,0 +1,22 @@\n+from sentry import analytics\n+\n+\n+class AlertSentEvent(analytics.Event):\n+ type = \"alert.sent\"\n+\n+ attributes = (\n+ analytics.Attribute(\"organization_id\"),\n+ analytics.Attribute(\"project_id\", required=False),",
"line": null,
"original_... | b01cbfcd7631e45d4d76901d1a1f6d792d000cfb | diff --git a/src/sentry/analytics/events/__init__.py b/src/sentry/analytics/events/__init__.py
index b059eb52c36966..ecba52dceba6ad 100644
--- a/src/sentry/analytics/events/__init__.py
+++ b/src/sentry/analytics/events/__init__.py
@@ -2,6 +2,7 @@
from .alert_created import * # noqa: F401,F403
from .alert_edited impo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__diffusers-3146@69e000d | huggingface/diffusers | Python | 3,146 | [docs] Clarify training args | Fixes #3038 to clarify what the `pretrained_model_name_or_path` argument expects during training. | 2023-04-18T15:12:12Z | Expand documentation for LORA with locally stored models
**Description of LORA fine tuning does not cover all the bases**
I am fairly new to Stable Diffusion, but have some experience using other ML projects, so in general, configuring a dataset and fine tuning is not an issue, however, I run into a block here trying ... | Hey @nicemicro,
Yes I agree we should try to improve our docs here. Maybe @sayakpaul you could take this in one go next week once you have some time to adapt the LoRA training script :-)
I think it's unrelated to LoRA but related to mentioning the expectation of what `pretrained_model_name_or_path` should be in ge... | [
{
"body": "**Description of LORA fine tuning does not cover all the bases**\r\nI am fairly new to Stable Diffusion, but have some experience using other ML projects, so in general, configuring a dataset and fine tuning is not an issue, however, I run into a block here trying to finetune LORA on a local model, a... | 9c856118c72dca9cae194648492b4284a254386c | {
"head_commit": "69e000d2bcaa84f63da63191431b97298c851a36",
"head_commit_message": "clarify training arg",
"patch_to_review": "diff --git a/docs/source/en/training/controlnet.mdx b/docs/source/en/training/controlnet.mdx\nindex 7a5454107b83..94e3d969b80a 100644\n--- a/docs/source/en/training/controlnet.mdx\n+++ b... | [
{
"diff_hunk": "@@ -60,7 +60,9 @@ DreamBooth finetuning is very sensitive to hyperparameters and easy to overfit.\n \n <frameworkcontent>\n <pt>\n-Let's try DreamBooth with a [few images of a dog](https://drive.google.com/drive/folders/1BO_dyz-p65qhBRRMRA4TbZ8qW4rB99JZ); download and save them to a directory an... | 4c1904c498bd8fbc6f2a03be8a6194a18509df41 | diff --git a/docs/source/en/training/controlnet.mdx b/docs/source/en/training/controlnet.mdx
index 7a5454107b83..94e3d969b80a 100644
--- a/docs/source/en/training/controlnet.mdx
+++ b/docs/source/en/training/controlnet.mdx
@@ -74,6 +74,7 @@ wget https://huggingface.co/datasets/huggingface/documentation-images/resolve/m... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
getsentry__sentry-56785@a6471d6 | getsentry/sentry | Python | 56,785 | feat(api): Publish `OrganizationAlertRuleIndexEndpoint` | This PR publishes the `GET` and `POST` endpoints.
Closes #56676
~~❗ Blocked by #55956~~
~~❗ Blocked by https://github.com/getsentry/sentry-docs/pull/8027~~
~~❗ Blocked by https://github.com/getsentry/sentry-docs/pull/8127~~
# List Metric Alert Rules
![localhost_3000_api_alerts_create-a-metric-alert-rule-fo... | 2023-09-22T23:08:43Z | Publish `OrganizationAlertRuleIndexEndpoint`
We need to publish the GET and POST endpoints at `src/sentry/incidents/endpoints/organization_alert_rule_index.py` to allow users to get a list of metric alert rules for an organization, as well as create them via API request.
❗ Currently on hold until Metric Alert Rule t... | [
{
"body": "We need to publish the GET and POST endpoints at `src/sentry/incidents/endpoints/organization_alert_rule_index.py` to allow users to get a list of metric alert rules for an organization, as well as create them via API request.\r\n\r\n❗ Currently on hold until Metric Alert Rule types are documented.",... | c53628aa04b02309dff56446cbf10b0806fa009f | {
"head_commit": "a6471d6e5844d81a8e1427e0ace9e7a92ce358d9",
"head_commit_message": "pr feedback changes + change api category",
"patch_to_review": "diff --git a/src/sentry/api/serializers/models/alert_rule.py b/src/sentry/api/serializers/models/alert_rule.py\nindex 617b4a506d82b3..fdd41c5b83e3e9 100644\n--- a/sr... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "src/sentry/api/serializers/models/alert_rule.py",
"start_line": null,
"text": "@user1:\nPlease remove `sentry.api.serializers.models.alert_rule` from `pyproject.toml` or the typing changes won't... | d2e5211318dc8d5c5bb8c1f3785b583b3f962c5b | diff --git a/src/sentry/api/serializers/models/alert_rule.py b/src/sentry/api/serializers/models/alert_rule.py
index 6b774094bd19b8..5a81d49aa6d26f 100644
--- a/src/sentry/api/serializers/models/alert_rule.py
+++ b/src/sentry/api/serializers/models/alert_rule.py
@@ -1,9 +1,12 @@
from __future__ import annotations
f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-56075@94f5fdc | getsentry/sentry | Python | 56,075 | feat(metrics) Create Investigation bias creation endpoint | This PR creates an endpoint that allows creating rules from a random query.
The idea being that a user can create a rule that will exist for a limited time
that will collect transactions with some custom conditions.
Resolves https://github.com/getsentry/sentry/issues/55679 | 2023-09-12T10:30:38Z | Endpoint - Create rule from query
This is going to create a rule and save it in redis with expiration time of 1 hour.
If we can't create a rule for this specific query, let the frontend know that we can't do it and why.
# Details
#### URL
`POST /api/0/organizations/<org_slug>/dynamic-sampling/custom-rules`
#### Requ... | [
{
"body": "This is going to create a rule and save it in redis with expiration time of 1 hour.\n\nIf we can't create a rule for this specific query, let the frontend know that we can't do it and why.\n\n# Details\n\n#### URL\n`POST /api/0/organizations/<org_slug>/dynamic-sampling/custom-rules`\n#### Request bod... | 120b6316655ad17fa5a9a4542c195f463212a745 | {
"head_commit": "94f5fdc9ad3f53bf1d846362a999a075593e9ea5",
"head_commit_message": "add import/export model test.",
"patch_to_review": "diff --git a/fixtures/backup/model_dependencies/detailed.json b/fixtures/backup/model_dependencies/detailed.json\nindex 7770ad00b63062..55987e7b480c19 100644\n--- a/fixtures/bac... | [
{
"diff_hunk": "@@ -0,0 +1,258 @@\n+import hashlib\n+from datetime import datetime, timedelta\n+from typing import Any, Mapping, Optional, Sequence\n+\n+from django.db import connections, models, router, transaction\n+from django.db.models import Q\n+from django.utils import timezone\n+\n+from sentry.backup.sco... | e1f81ccc075b1b95a177c337ea4a5211d6cbeff1 | diff --git a/fixtures/backup/model_dependencies/detailed.json b/fixtures/backup/model_dependencies/detailed.json
index d230a998930506..6f25fc19aed61f 100644
--- a/fixtures/backup/model_dependencies/detailed.json
+++ b/fixtures/backup/model_dependencies/detailed.json
@@ -609,6 +609,36 @@
"Region"
]
},
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-55844@64fbc96 | getsentry/sentry | Python | 55,844 | Wizard only onboarding | ~Remix~, SvelteKit, and Nextjs
Someone can validate if these changes, by someone I mean a real developer :D
SvelteKit: local
<img width="1204" alt="image" src="https://github.com/getsentry/sentry/assets/47563310/6f6f8abb-b439-4f64-ab38-328fa8ed25f4">
NextJs: local
<img width="1203" alt="image" src="https://g... | 2023-09-07T13:18:53Z | Remove manual setup snippets from Next, Remix and Sveltekit getting started pages
### Problem Statement
Currently, we show both, wizard and manual setup in the getting started docs. This is potentially confusing for users as they might think they need to add additional code as to what the wizard already set up.
#... | [
{
"body": "### Problem Statement\r\n\r\nCurrently, we show both, wizard and manual setup in the getting started docs. This is potentially confusing for users as they might think they need to add additional code as to what the wizard already set up.\r\n\r\n### Solution Brainstorm\r\n\r\nRemove the manual usage c... | 3c1bc551645cafd86cad32953fb557df249d2d37 | {
"head_commit": "64fbc965f4e30a9d33e04434832348404dfc60e9",
"head_commit_message": "Wizard only onboarding\n\nRemix, SvelteKit, and Nextjs\n\nSomeone can validate if these changes, by someone I mean a real developer :D",
"patch_to_review": "diff --git a/static/app/gettingStartedDocs/javascript/nextjs.spec.tsx b/... | [
{
"diff_hunk": "@@ -59,31 +31,42 @@ export const steps = ({\n type: StepType.CONFIGURE,\n description: (\n <Fragment>\n- {t('The Sentry wizard will automatically patch your application:')}\n+ {t(\n+ 'The Sentry wizard will automatically patch your application to configure th... | 2833663bc83c9cef0f581958b4932ecf8a403de5 | diff --git a/static/app/gettingStartedDocs/javascript/nextjs.spec.tsx b/static/app/gettingStartedDocs/javascript/nextjs.spec.tsx
index b02c62b6a0747e..4a37459c7ca2d5 100644
--- a/static/app/gettingStartedDocs/javascript/nextjs.spec.tsx
+++ b/static/app/gettingStartedDocs/javascript/nextjs.spec.tsx
@@ -1,21 +1,12 @@
im... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} | |
huggingface__diffusers-2009@f090898 | huggingface/diffusers | Python | 2,009 | add load textual inversion embeddings to stable diffusion | Should close https://github.com/huggingface/diffusers/issues/1985 | 2023-01-16T14:18:06Z | Please create simple way to load new embeddings on Stable Diffusion Pipeline
**Is your feature request related to a problem? Please describe.**
It is frustrating to load Textual Inversion embeddings on SD pipelines, adds bloat to the code. It would be good if we could just `pipeline.load_embeddings` and add new embedd... | Hey @piEsposito,
Yes I think this makes sense! Also related is LoRA: https://github.com/huggingface/diffusers/pull/1884, since there we also need to load just part of the weights.
Intuitively I think the cleanest API here would be to have a "`TextualInversionLoaderMixin`" class that implements a
```py
load_t... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nIt is frustrating to load Textual Inversion embeddings on SD pipelines, adds bloat to the code. It would be good if we could just `pipeline.load_embeddings` and add new embeddings ad-hoc to the pipeline.\r\n\r\n**Describe the solut... | 3be489182ef2a1170d425327a7cb69dff460b461 | {
"head_commit": "f0908989b855d29ae264c1a9ca17056f76b01c5e",
"head_commit_message": "remove bogus",
"patch_to_review": "diff --git a/src/diffusers/__init__.py b/src/diffusers/__init__.py\nindex a1e736671be7..b2554dd9cf35 100644\n--- a/src/diffusers/__init__.py\n+++ b/src/diffusers/__init__.py\n@@ -32,6 +32,7 @@\n... | [
{
"diff_hunk": "@@ -292,5 +289,397 @@ def save_function(weights, filename):\n \n # Save the model\n save_function(state_dict, os.path.join(save_directory, weight_name))\n-\n logger.info(f\"Model weights saved in {os.path.join(save_directory, weight_name)}\")\n+\n+\n+class TextualInversio... | b9f53cbf54907d6499f191eceadd91d2f8e0bfc6 | diff --git a/src/diffusers/__init__.py b/src/diffusers/__init__.py
index 25ca322351d3..bba8d4084636 100644
--- a/src/diffusers/__init__.py
+++ b/src/diffusers/__init__.py
@@ -109,6 +109,7 @@
except OptionalDependencyNotAvailable:
from .utils.dummy_torch_and_transformers_objects import * # noqa F403
else:
+ f... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-792@90385bb | huggingface/diffusers | Python | 792 | support bf16 for stable diffusion | Currently stable diffusion (or diffusers in general) doesn't work with `bf16` as nearest upsampling in torch is not supported in `bf16`.
Minimal code to reproduce:
```python
import torch
import torch.nn.functional as F
image = torch.randn(1, 4, 32, 32).to(device="cuda", dtype=torch.bfloat16)
out = F.inter... | 2022-10-10T10:38:14Z | BF16 doesn't work with dreambooth
### Describe the bug
Using bf16 with the dreambooth script throw an exception
### Reproduction
_No response_
### Logs
```shell
RuntimeError: "upsample_nearest2d_out_frame" not implemented for 'BFloat16'
```
### System Info
- `diffusers` version: 0.4.0.dev0
- Platform: Linux-5.... | Interesting! @patil-suraj should we maybe add a "if-else" statement for this?
Hi! Thanks for the issue, I've opened a draft PR to address this #792. Also think this issue should be filed in pytorch as the torch upsample op is not supported in `bf16`. Minimal code to reproduce.
```python
import torch
import torch... | [
{
"body": "### Describe the bug\n\nUsing bf16 with the dreambooth script throw an exception\n\n### Reproduction\n\n_No response_\n\n### Logs\n\n```shell\nRuntimeError: \"upsample_nearest2d_out_frame\" not implemented for 'BFloat16'\n```\n\n\n### System Info\n\n- `diffusers` version: 0.4.0.dev0\r\n- Platform: Li... | f3983d16eed57e46742d217363d8913bef7f748d | {
"head_commit": "90385bbd59f9011f2b12b71ec436df8a9ea50a98",
"head_commit_message": "fix typo",
"patch_to_review": "diff --git a/src/diffusers/models/resnet.py b/src/diffusers/models/resnet.py\nindex b9718e67f279..5b1f88e5416e 100644\n--- a/src/diffusers/models/resnet.py\n+++ b/src/diffusers/models/resnet.py\n@@ ... | [
{
"diff_hunk": "@@ -36,8 +36,16 @@ def forward(self, clip_input, images):\n pooled_output = self.vision_model(clip_input)[1] # pooled_output\n image_embeds = self.visual_projection(pooled_output)\n \n- special_cos_dist = cosine_distance(image_embeds, self.special_care_embeds).cpu().numpy... | 880f9f9ae1bf27a4b16e34f7194f515f9d99575e | diff --git a/src/diffusers/models/resnet.py b/src/diffusers/models/resnet.py
index b9718e67f279..68a5341d513f 100644
--- a/src/diffusers/models/resnet.py
+++ b/src/diffusers/models/resnet.py
@@ -40,6 +40,13 @@ def forward(self, hidden_states, output_size=None):
if self.use_conv_transpose:
return s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
huggingface__diffusers-1096@7db319b | huggingface/diffusers | Python | 1,096 | Flax: avoid recompilation when params change | Fixes #1015 | 2022-11-01T16:13:09Z | JAX / Flax: avoid recompilation on params change: guidance scale, size, number of steps
This is required to improve the demo(s), we currently have the sliders disabled.
Some users are also requesting it in discord and the forums. Our demo notebook is very fast on TPU hardware but users can't quickly explore differen... | Please make a script that can convert original stable diffusion to flax 🚀
and please make an auto-converter if someone publishes it like this https://huggingface.co/nitrosocke/modern-disney-diffusion it will automatically convert to all different models 🤖🧨
Hey @camenduru it should be as easy as doing:
```python... | [
{
"body": "This is required to improve the demo(s), we currently have the sliders disabled.\r\n\r\nSome users are also requesting it in discord and the forums. Our demo notebook is very fast on TPU hardware but users can't quickly explore different parameters.",
"number": 1015,
"title": "JAX / Flax: avo... | 9e1102990ae91b776b95baabd788e1662d63aa49 | {
"head_commit": "7db319bdae4023bbd6c7a7ca3d16abd873dcdbd0",
"head_commit_message": "Merge remote-tracking branch 'origin/main' into flax-no-recompile",
"patch_to_review": "diff --git a/src/diffusers/pipelines/stable_diffusion/pipeline_flax_stable_diffusion.py b/src/diffusers/pipelines/stable_diffusion/pipeline_f... | [
{
"diff_hunk": "@@ -260,13 +259,7 @@ def loop_body(step, args):\n \n # scale the initial noise by the standard deviation required by the scheduler\n latents = latents * self.scheduler.init_noise_sigma\n-\n- if debug:\n- # run with python for loop\n- for i in range(nu... | b55a8a19d3f897b4cdea2f2ddced5bdbf4c93eb8 | diff --git a/src/diffusers/pipelines/stable_diffusion/pipeline_flax_stable_diffusion.py b/src/diffusers/pipelines/stable_diffusion/pipeline_flax_stable_diffusion.py
index 23148dcfe2e3..912a4381d032 100644
--- a/src/diffusers/pipelines/stable_diffusion/pipeline_flax_stable_diffusion.py
+++ b/src/diffusers/pipelines/stab... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
huggingface__diffusers-3076@ebaa4ff | huggingface/diffusers | Python | 3,076 | [deepspeed] partial ZeRO-3 support | Fixes: https://github.com/huggingface/diffusers/issues/1865
Here is what's happening here:
When Deepspeed ZeRO-3 is used in `examples/text_to_image/train_text_to_image.py` the 3 models (`text_encoder`, `vae`, `unet`) get partitioned with `zero.Init` but only `unet` gets `accelerate.prepare` so Deepspeed doesn't k... | 2023-04-12T18:43:49Z | using zero stage3 finetune sd2, dimension error occurs
### Describe the bug
An error is reported when using deepspeed's zero stage3 finetune diffusers/examples/text_to_image/train_text_to_image.py script. My machine's GPU is 4*2080ti, and because a single GPU cannot accommodate all SD2 parameters, the deepspeed zero... | cc @patil-suraj @williamberman @pcuenca
I don't really know much about deepspeed maybe @williamberman knows more here.
As far as I have tried, the script works well with stage 2, using CPU offloading which should help fit the model on 2080ti.
I don't know off the top of my head. Someone opened an issue with the sa... | [
{
"body": "### Describe the bug\r\n\r\nAn error is reported when using deepspeed's zero stage3 finetune diffusers/examples/text_to_image/train_text_to_image.py script. My machine's GPU is 4*2080ti, and because a single GPU cannot accommodate all SD2 parameters, the deepspeed zero stage3 strategy must be used.\r... | e0b56d2b189330afed74e984a3309e3877450d42 | {
"head_commit": "ebaa4ffd43d7f85ab51ec694c152544705059a33",
"head_commit_message": "cleanup",
"patch_to_review": "diff --git a/examples/text_to_image/train_text_to_image.py b/examples/text_to_image/train_text_to_image.py\nindex 4bbf4706f01c..de9196157818 100644\n--- a/examples/text_to_image/train_text_to_image.p... | [
{
"diff_hunk": "@@ -461,10 +461,43 @@ def main():\n tokenizer = CLIPTokenizer.from_pretrained(\n args.pretrained_model_name_or_path, subfolder=\"tokenizer\", revision=args.revision\n )\n- text_encoder = CLIPTextModel.from_pretrained(\n- args.pretrained_model_name_or_path, subfolder=\"t... | 2278a98e4f4b3b85e9998ca9369f4cf48b18f5a2 | diff --git a/examples/text_to_image/train_text_to_image.py b/examples/text_to_image/train_text_to_image.py
index f9592e5adca3..1a6f4cde27ab 100644
--- a/examples/text_to_image/train_text_to_image.py
+++ b/examples/text_to_image/train_text_to_image.py
@@ -29,6 +29,7 @@
import transformers
from accelerate import Accele... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
frappe__frappe-32256@291ef29 | frappe/frappe | Python | 32,256 | feat: publish comment from desk | Comments made from the portal or on a blog post get the _Published_ property. However, there was no way to create public comments from the desk, that would be visible to portal or website users. This PR introduces a menu option to change comment publicity.
https://github.com/user-attachments/assets/9968d7cf-868e-4f6... | 2025-04-22T19:09:26Z | Users comments are not appear in customer portal
There is no option to choose comment visibility for user and make it visible for customers in website view. By default comment doctype sets published property to 0.
Would be cool to add published toggle or checkbox to easily share certain comments with customers. | [
{
"body": "There is no option to choose comment visibility for user and make it visible for customers in website view. By default comment doctype sets published property to 0. \n\nWould be cool to add published toggle or checkbox to easily share certain comments with customers.\n\n",
"number": 32257,
"t... | 3cd9b577e25e5f44cf9f94e88e73dd5c2429fef3 | {
"head_commit": "291ef2910b53d0f0f97ad80cced56a9d8dfbd8a6",
"head_commit_message": "fix: clarify confirmation message",
"patch_to_review": "diff --git a/frappe/desk/form/load.py b/frappe/desk/form/load.py\nindex 83f1d5c0bf88..0005974417a7 100644\n--- a/frappe/desk/form/load.py\n+++ b/frappe/desk/form/load.py\n@@... | [
{
"diff_hunk": "@@ -730,6 +732,31 @@ class FormTimeline extends BaseTimeline {\n \t\t});\n \t}\n \n+\tupdate_comment_publicity(comment_name, publish) {\n+\t\tlet message;\n+\t\tif (publish) {\n+\t\t\tmessage = __(\n+\t\t\t\t\"Would you like to publish this comment? This means it will become visible to website/p... | 430bdef05a8b7da62c09d50dcc741b480caf285a | diff --git a/frappe/desk/form/load.py b/frappe/desk/form/load.py
index 83f1d5c0bf88..0005974417a7 100644
--- a/frappe/desk/form/load.py
+++ b/frappe/desk/form/load.py
@@ -149,7 +149,7 @@ def add_comments(doc, docinfo):
comments = frappe.get_all(
"Comment",
- fields=["name", "creation", "content", "owner", "comm... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-54297@21cbd89 | getsentry/sentry | Python | 54,297 | feat(most-helpful-event): Add frontend piece for popup guide | Closes https://github.com/getsentry/sentry/issues/53915
<img width="403" alt="Screenshot 2023-08-07 at 12 21 00 PM" src="https://github.com/getsentry/sentry/assets/22582037/a3dd53c0-80bd-46ac-9fa8-0f8843371c08">
| 2023-08-07T17:04:17Z | Recommended UI: Add guide tooltip
To draw more attention to our new event default, we should add a guide tooltip. It should have the following text/options:
**Body**: “Rather than the latest event, we now default to an event with the most context (replays, traces, and profiles). You can easily switch between events or... | [
{
"body": "To draw more attention to our new event default, we should add a guide tooltip. It should have the following text/options:\n\n**Body**: “Rather than the latest event, we now default to an event with the most context (replays, traces, and profiles). You can easily switch between events or configure yo... | fa7711f2c88dee7538c649d43012285b1fa1b32d | {
"head_commit": "21cbd894d1c1bff66c004514d4255d7b98045355",
"head_commit_message": "Update text",
"patch_to_review": "diff --git a/static/app/components/assistant/getGuidesContent.tsx b/static/app/components/assistant/getGuidesContent.tsx\nindex 445ab364227fb7..c8cd6d22543b09 100644\n--- a/static/app/components/... | [
{
"diff_hunk": "@@ -418,11 +419,13 @@ export function GroupEventCarousel({event, group, projectSlug}: GroupEventCarous\n {!isHelpfulEventUiEnabled && 'JSON'}\n </Button>\n )}\n- <EventNavigationDropdown\n- isDisabled={!hasPreviousEvent && !hasNextEvent}\n- ... | cafd266f68b0b0c881da1fd6a7187116949fa881 | diff --git a/static/app/components/assistant/getGuidesContent.tsx b/static/app/components/assistant/getGuidesContent.tsx
index 445ab364227fb7..ae9551f5ec9635 100644
--- a/static/app/components/assistant/getGuidesContent.tsx
+++ b/static/app/components/assistant/getGuidesContent.tsx
@@ -273,6 +273,24 @@ export default f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
huggingface__diffusers-355@12f6670 | huggingface/diffusers | Python | 355 | Inference support for `mps` device | This addresses the issues identified when assessing inference on Apple Silicon, see https://github.com/huggingface/diffusers/issues/292#issuecomment-1236112207 for details.
### Current status
- Stable Diffusion pipeline works.
- Results in CPU / MPU are reproducible when using the same seeds. Generators do not w... | 2022-09-04T20:14:31Z | Add inference support for `mps` device (Apple Silicon)
There is a lot of community interest in running diffusers on Apple Silicon. A first step could be to introduce support for the `mps` device, which currently requires PyTorch nightly builds. Another step down the line could be to convert to Core ML and optimize to m... | If it is of any help with this issue, here are some community-implemented or contributed Silicon compatibility with Stable Diffusion:
Using `diffusers`
PR to this repo: https://github.com/huggingface/diffusers/pull/278/
Guide by wandb: https://wandb.ai/morgan/stable-diffusion/reports/Running-Stable-Diffusion-on-a... | [
{
"body": "There is a lot of community interest in running diffusers on Apple Silicon. A first step could be to introduce support for the `mps` device, which currently requires PyTorch nightly builds. Another step down the line could be to convert to Core ML and optimize to make sure that the use of the ANE (Ne... | 7a1229fa291ad893896ea1969d342f4a9ffed7f7 | {
"head_commit": "12f66700fa7116e24b3bbe42ec6b51b2dc6d7c12",
"head_commit_message": "Do not use float64 when using LDMScheduler.\n\nFixes #358.",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 28e1be164bb5..918b787ef500 100644\n--- a/README.md\n+++ b/README.md\n@@ -39,6 +39,10 @@ pip install --upgr... | [
{
"diff_hunk": "@@ -585,6 +585,37 @@ def num_parameters(self, only_trainable: bool = False, exclude_embeddings: bool\n else:\n return sum(p.numel() for p in self.parameters() if p.requires_grad or not only_trainable)\n \n+ def _mps_warmup_inputs(self, batch_size=None) -> Optional[Tuple]:\... | 2e524575f12918069d64910c457e5c4f22d5883a | diff --git a/README.md b/README.md
index 6fc017959591..47b30f9e9272 100644
--- a/README.md
+++ b/README.md
@@ -39,6 +39,10 @@ pip install --upgrade diffusers # should install diffusers 0.2.4
conda install -c conda-forge diffusers
```
+**Apple Silicon (M1/M2) support**
+
+Please, refer to [the documentation](https:... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
huggingface__diffusers-361@973eb23 | huggingface/diffusers | Python | 361 | add accelerate to load models with smaller memory footprint | Closes #281 | 2022-09-05T15:05:40Z | Optimize model loading by natively using Accelerate, please.
**Is your feature request related to a problem? Please describe.**
Loading pretrained models, for example `UNet2DConditionModel` peaks at 8GB when loading a pretrained one, while it takes a lot less memory when it is fully loaded to the GPU. That is happens ... | Hey @piEsposito, happy to look into that in the coming week! If you have a code snippet that works for you, feel free to include it here as a reference :hugs:
@muellerzr @patrickvonplaten wdyt? We can either do this, or bring the low-RAM loading code from transformers
cc @sgugger so it's on your radar since next we... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nLoading pretrained models, for example `UNet2DConditionModel` peaks at 8GB when loading a pretrained one, while it takes a lot less memory when it is fully loaded to the GPU. That is happens likely because there are some redundanci... | 4ff4d4db1273d0f813814337a35918212497f18c | {
"head_commit": "973eb23c92d6ed0543072fd05aeceffcd54ae81b",
"head_commit_message": "Merge branch 'main' of github.com:huggingface/diffusers into main",
"patch_to_review": "diff --git a/setup.py b/setup.py\nindex fffb8f26f09b..a3fb11e23c46 100644\n--- a/setup.py\n+++ b/setup.py\n@@ -97,6 +97,7 @@\n \"tensorbo... | [
{
"diff_hunk": "@@ -153,11 +154,17 @@ def from_config(cls, pretrained_model_name_or_path: Union[str, os.PathLike], ret\n </Tip>\n \n \"\"\"\n- config_dict = cls.get_config_dict(pretrained_model_name_or_path=pretrained_model_name_or_path, **kwargs)\n-\n- init_dict, unused_kwargs = c... | 25e07d8d120a6ff360c30260e23d6f2828821bef | diff --git a/setup.py b/setup.py
index affb2e06fc56..f51e044e9628 100644
--- a/setup.py
+++ b/setup.py
@@ -104,6 +104,7 @@
"torch>=1.4",
"torchvision",
"transformers>=4.21.0",
+ "accelerate>=0.12.0"
]
# this is a lookup table with items like:
diff --git a/src/diffusers/modeling_utils.py b/src/diff... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
getsentry__sentry-53785@b28d0dc | getsentry/sentry | Python | 53,785 | feat(discord): Implement issue alerts | Sorry for big diff 🥲, did some refactoring and wrote a bunch of tests | 2023-07-28T17:26:14Z | Implement Discord issue alerts
This is where we register our Discord issue alert notification handler. See how Slack and msteams handle this.
This is working if we can register Discord and send an issue alert message to Discord.
Keep in mind we need to gracefully handle the case where the integration is broken.
... | This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it `Status: Backlog` or `Status: In Progress`, I will leave it alone ... forever!
----
"A weed is but an unloved flower." ― _Ella Wheeler Wilcox_ 🥀 | [
{
"body": "This is where we register our Discord issue alert notification handler. See how Slack and msteams handle this.\r\n\r\nThis is working if we can register Discord and send an issue alert message to Discord.\r\n\r\nKeep in mind we need to gracefully handle the case where the integration is broken.\r\n\r... | cc6e75f118a8cac5f2818043f19cfbad9faecf4b | {
"head_commit": "b28d0dc8e7d5f27d7b1e1602cdc82cb9a58cd5c6",
"head_commit_message": "Use warning instead of warn",
"patch_to_review": "diff --git a/src/sentry/api/helpers/group_index/update.py b/src/sentry/api/helpers/group_index/update.py\nindex c406f1416f3d95..0ebd570785e073 100644\n--- a/src/sentry/api/helpers... | [
{
"diff_hunk": "@@ -139,9 +143,29 @@ def build_footer(\n footer = f\"{group.qualified_short_id}\"\n if rules:\n rule_url = build_rule_url(rules[0], group, project)\n- footer += f\" via {url_format.format(text=rules[0].label, url=rule_url)}\"\n+ # If this notification is triggered v... | 5ee1bed19b7b29db24f9f8e27bc964cc7ee41fd8 | diff --git a/src/sentry/api/helpers/group_index/update.py b/src/sentry/api/helpers/group_index/update.py
index c406f1416f3d95..0ebd570785e073 100644
--- a/src/sentry/api/helpers/group_index/update.py
+++ b/src/sentry/api/helpers/group_index/update.py
@@ -173,7 +173,7 @@ def get_current_release_version_of_group(
def ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
frappe__frappe-32607@d90034f | frappe/frappe | Python | 32,607 | feat: configurable timeline date format | feat: make timeline date format configurable via settings
This feature introduces a system-wide setting that allows administrators to define the date format displayed in timeline views. It supports better customization, enabling formats like DD-MM-YYYY or MM/DD/YYYY etc.. to match regional preferences.
The timeli... | 2025-05-20T15:20:37Z | Configurable Timeline Date Format
Allow users to choose how dates are displayed in timelines — either as relative time (e.g., "2 weeks ago") or exact date/time (e.g., "12 Apr 2025, 3:45 PM").
Users should be able to select their preferred format in settings. | is anyone working on this | [
{
"body": "Allow users to choose how dates are displayed in timelines — either as relative time (e.g., \"2 weeks ago\") or exact date/time (e.g., \"12 Apr 2025, 3:45 PM\").\nUsers should be able to select their preferred format in settings.",
"number": 32498,
"title": "Configurable Timeline Date Format"... | 1b9d642089764ebb8579d8ffa4a4516c2e51731f | {
"head_commit": "d90034f10eada5bfecdbedd0273b6d68ea1e139a",
"head_commit_message": "feat: Add user-configurable setting with system fallback",
"patch_to_review": "diff --git a/frappe/core/doctype/system_settings/system_settings.json b/frappe/core/doctype/system_settings/system_settings.json\nindex 6c38d7f302a7..... | [
{
"diff_hunk": "@@ -138,7 +138,14 @@ class BaseTimeline {\n \t\tlet timeline_content = timeline_item.find(\".timeline-content\");\n \t\ttimeline_content.append(item.content);\n \t\tif (!item.hide_timestamp && !item.is_card) {\n-\t\t\ttimeline_content.append(`<span> · ${comment_when(item.creation)}</span>`);\n+\... | 9720dd814109581976bbe792b0d8870a0200b5e2 | diff --git a/frappe/core/doctype/system_settings/system_settings.json b/frappe/core/doctype/system_settings/system_settings.json
index 68640b518d55..992564b43eee 100644
--- a/frappe/core/doctype/system_settings/system_settings.json
+++ b/frappe/core/doctype/system_settings/system_settings.json
@@ -25,6 +25,7 @@
"flo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-53402@7da266f | getsentry/sentry | Python | 53,402 | feat(discord): Implement Discord identity linking/unlinking | Create Discord Identity provider. Identity for installing user will be created on integration installation by completing the OAuth2 flow to get this user's ID. After this, other Discord users will be able to link their identities through the /link command, and unlink through the /unlink command. No OAuth2 flow is neede... | 2023-07-23T23:14:39Z | Implement Discord identity linking and unlinking via slash command
- [x] Add commands to `IntegrationProvider.setup()`
- [x] Implement handler (see `Identity` model and how Slack does this)
- [x] Make sure handler is called when we receive the relevant events at our interactions endpoint | This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it `Status: Backlog` or `Status: In Progress`, I will leave it alone ... forever!
----
"A weed is but an unloved flower." ― _Ella Wheeler Wilcox_ 🥀 | [
{
"body": "- [x] Add commands to `IntegrationProvider.setup()`\r\n- [x] Implement handler (see `Identity` model and how Slack does this)\r\n- [x] Make sure handler is called when we receive the relevant events at our interactions endpoint",
"number": 50894,
"title": "Implement Discord identity linking a... | 68c18a3fab71f843cc9a5a1b48dd8c8d140c478d | {
"head_commit": "7da266f1b4ce3eb978466e8177722f9e9474d98c",
"head_commit_message": "Merge branch 'master' into spalmurray/discord-identity-linking",
"patch_to_review": "diff --git a/src/sentry/identity/__init__.py b/src/sentry/identity/__init__.py\nindex cd7533cbeebc8a..10f0d19a9adafe 100644\n--- a/src/sentry/id... | [
{
"diff_hunk": "@@ -108,40 +110,85 @@ def __init__(self) -> None:\n self.application_id = options.get(\"discord.application-id\")\n self.public_key = options.get(\"discord.public-key\")\n self.bot_token = options.get(\"discord.bot-token\")\n+ self.client_secret = options.get(\"dis... | 83b2bf28cfc28a559181427070fa6b0d26b456d9 | diff --git a/src/sentry/identity/__init__.py b/src/sentry/identity/__init__.py
index cd7533cbeebc8a..10f0d19a9adafe 100644
--- a/src/sentry/identity/__init__.py
+++ b/src/sentry/identity/__init__.py
@@ -1,5 +1,6 @@
from .base import * # NOQA
from .bitbucket import * # NOQA
+from .discord import * # NOQA
from .git... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-53055@0adcc8e | getsentry/sentry | Python | 53,055 | fix(metrics): on demand metric deduplication | Closes [Fix duplicated metric data on query_hash collision](https://github.com/getsentry/sentry/issues/52957) | 2023-07-18T11:45:43Z | Fix duplicated metric data on query_hash collision
Sentry should not send more than one query spec per project using the same `query_hash` tag value.
## Details
To collect unique metrics for every alert or dashboard widget, Sentry computes a query hash from the selected field and filters. This hash is supposed to... | [
{
"body": "Sentry should not send more than one query spec per project using the same `query_hash` tag value.\r\n\r\n## Details\r\n\r\nTo collect unique metrics for every alert or dashboard widget, Sentry computes a query hash from the selected field and filters. This hash is supposed to be unique to the query.... | 6faec71915477d06377dba2e7c14cdd67c7ae7e3 | {
"head_commit": "0adcc8ec35c8e4d435328a1382668812bee66cc7",
"head_commit_message": "type fix",
"patch_to_review": "diff --git a/src/sentry/relay/config/metric_extraction.py b/src/sentry/relay/config/metric_extraction.py\nindex 66bd3a4161dae2..9ad96bdce1917b 100644\n--- a/src/sentry/relay/config/metric_extraction... | [
{
"diff_hunk": "@@ -76,7 +73,20 @@ def get_metric_extraction_config(project: Project) -> Optional[MetricExtractionC\n }\n \n \n-def convert_query_to_metric(snuba_query: SnubaQuery) -> Optional[MetricSpec]:\n+def get_metric_specs(alert_rules: Sequence[AlertRule]) -> List[MetricSpec]:",
"line": null,
... | 9b68655386947da12fb2b199166133d0323ffb17 | diff --git a/src/sentry/relay/config/metric_extraction.py b/src/sentry/relay/config/metric_extraction.py
index 66bd3a4161dae2..85efeb70489724 100644
--- a/src/sentry/relay/config/metric_extraction.py
+++ b/src/sentry/relay/config/metric_extraction.py
@@ -1,6 +1,6 @@
import logging
from dataclasses import dataclass
-f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-52974@d96e37a | getsentry/sentry | Python | 52,974 | ref(event_manager): Fix typing issues for event_manager | We want to make a lot of changes to event_manager and we need to have backend typing in place for the upcoming work.
Fixes https://github.com/getsentry/sentry/issues/52877 | 2023-07-17T12:52:38Z | Add typing for event_manager
Currently, we're not checking backend types for it. We're planning to improve the performance of the save_event code, thus, we should add typing before we keep making more changes.
After removing it from `pyproject.toml` we get the following:
```
make backend-typing
--> Running Python... | [
{
"body": "Currently, we're not checking backend types for it. We're planning to improve the performance of the save_event code, thus, we should add typing before we keep making more changes.\r\n\r\nAfter removing it from `pyproject.toml` we get the following:\r\n```\r\nmake backend-typing\r\n--> Running Python... | a05bfaf6ca602674c8c8880f363b0a1ab793d24d | {
"head_commit": "d96e37a6934b1a663fc3d63d857e8cfbcf2e40c7",
"head_commit_message": "Implicit import",
"patch_to_review": "diff --git a/pyproject.toml b/pyproject.toml\nindex d8f99472ec0357..6b08fc5df7236b 100644\n--- a/pyproject.toml\n+++ b/pyproject.toml\n@@ -442,7 +442,6 @@ module = [\n \"sentry.discover.e... | [
{
"diff_hunk": "@@ -2155,7 +2139,7 @@ def save_attachment(\n type=attachment.type,\n headers={\"Content-Type\": attachment.content_type},\n )\n- file.putfile(BytesIO(data), blob_size=settings.SENTRY_ATTACHMENT_BLOB_SIZE)\n+ file.putfile(BytesIO(data), blob_size=settings.SENTRY_ATTACHME... | 8d6f431304d0a322e350072328f9ff8c93bc0659 | diff --git a/pyproject.toml b/pyproject.toml
index d8f99472ec0357..6b08fc5df7236b 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -442,7 +442,6 @@ module = [
"sentry.discover.endpoints.discover_key_transactions",
"sentry.discover.endpoints.serializers",
"sentry.discover.tasks",
- "sentry.event_man... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
frappe__frappe-24777@c606454 | frappe/frappe | Python | 24,777 | fix: console import progress off-by-one | Existing behavior
```
Importing 4 records : [==================================================] 125%
```
New behavior
```
Importing (Insert) for doctype Note: 4 records: [========================================] 100%
```
Fixes off-by-one error and adds DocType and import type indicators to... | 2024-02-06T04:05:25Z | Console import progress off-by-one
## Description of the issue
Data import utility displays incorrect progress in console mode due to off-by-one error since `frappe.publish_realtime()` takes 1-indexed progress while `update_progress_bar()` takes 0-indexed.
## Steps to reproduce the issue
Import any import file a... | [
{
"body": "## Description of the issue\r\nData import utility displays incorrect progress in console mode due to off-by-one error since `frappe.publish_realtime()` takes 1-indexed progress while `update_progress_bar()` takes 0-indexed.\r\n\r\n\r\n## Steps to reproduce the issue\r\nImport any import file as is i... | 1b8e9c3502b702178f777cf2e5c253ccec573e2e | {
"head_commit": "c6064546127750d7f259357a6178ae4e7d7945b4",
"head_commit_message": "fix: improve progress message",
"patch_to_review": "diff --git a/frappe/core/doctype/data_import/importer.py b/frappe/core/doctype/data_import/importer.py\nindex c83d60ea8b66..b0e2eeec150a 100644\n--- a/frappe/core/doctype/data_i... | [
{
"diff_hunk": "@@ -149,8 +149,8 @@ def import_data(self):\n \n \t\t\t\t\tif self.console:\n \t\t\t\t\t\tupdate_progress_bar(\n-\t\t\t\t\t\t\tf\"Importing {total_payload_count} records\",\n-\t\t\t\t\t\t\tcurrent_index,\n+\t\t\t\t\t\t\tf\"Importing ({self.import_type.split()[0]}) for doctype {self.doctype}: {tot... | ebb1505b2c4d1defed7d757946b7e511c1691f30 | diff --git a/frappe/core/doctype/data_import/importer.py b/frappe/core/doctype/data_import/importer.py
index c83d60ea8b66..a4d25074a1ba 100644
--- a/frappe/core/doctype/data_import/importer.py
+++ b/frappe/core/doctype/data_import/importer.py
@@ -149,8 +149,8 @@ def import_data(self):
if self.console:
up... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-52253@6bc7f2b | getsentry/sentry | Python | 52,253 | feat(framework-suggestion-modal): Add Java and its frameworks to the modal | closes https://github.com/getsentry/sentry/issues/50224
**Preview:**
https://github.com/getsentry/sentry/assets/29228205/a3b93422-825c-4ac8-ab30-765916249da6
| 2023-07-05T11:45:51Z | Java Modal for Project Selection
### Problem Statement
When Creating a Java project users might miss that they should use a framework specific SDK. Today they are sent on a generic flow
### Solution Brainstorm
Add the modal framework selection window same as Node, Python, and JS Browser
### Product Area
Projects | Assigning to @getsentry/support for [routing](https://open.sentry.io/triage/#2-route), due by **<time datetime=2023-06-03T00:00:00.000Z>Friday, June 2nd at 5:00 pm</time> (sfo)**. ⏲️
@smeubank could you please add the list of frameworks in the order we should display them in the modal? Thank you!
> @smeubank could you ... | [
{
"body": "### Problem Statement\n\nWhen Creating a Java project users might miss that they should use a framework specific SDK. Today they are sent on a generic flow\n\n### Solution Brainstorm\n\nAdd the modal framework selection window same as Node, Python, and JS Browser\n\n### Product Area\n\nProjects",
... | 25a729f9d7d30b67d3193418f7e31c6d72d527e9 | {
"head_commit": "6bc7f2beb672c92ca81ffee84a6f6b18884603a3",
"head_commit_message": "feat(framework-suggestion-modal): Add java and its frameworks to the modal",
"patch_to_review": "diff --git a/static/app/components/onboarding/frameworkSuggestionModal.tsx b/static/app/components/onboarding/frameworkSuggestionMod... | [
{
"diff_hunk": "@@ -56,25 +58,39 @@ const topNodeFrameworks = [\n 'node-koa',\n ];\n \n+const topJavaFrameworks = [\n+ 'java-spring-boot',\n+ 'java-spring',\n+ 'java-logback',\n+ 'java-log4j2',\n+ 'java',",
"line": null,
"original_line": 66,
"original_start_line": null,
"path": "static/ap... | 2eda18b4c7b7dae847e253c3a09893364b7f8571 | diff --git a/static/app/components/onboarding/frameworkSuggestionModal.tsx b/static/app/components/onboarding/frameworkSuggestionModal.tsx
index 053e373a6b3023..291d68483527b2 100644
--- a/static/app/components/onboarding/frameworkSuggestionModal.tsx
+++ b/static/app/components/onboarding/frameworkSuggestionModal.tsx
@... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
frappe__frappe-22700@e72b03a | frappe/frappe | Python | 22,700 | fix(UX): send out a system notification when email sending + retries fail | Resolves #21196
The notification looks like this
Clicking on it will take you to the email queue page so you can investigate further
![image](https://github.com/frappe/frappe/assets/10119037/36c07a8d-98f3-49a4-b05... | 2023-10-11T08:17:36Z | Send system notification for unsent email
Only way to find out that email I sent failed is to go to that document timeline again and see the status. This is impractical.
We can just send a system notification for unsent email after all retries are completed. | [
{
"body": "Only way to find out that email I sent failed is to go to that document timeline again and see the status. This is impractical. \r\n\r\n\r\nWe can just send a system notification for unsent email after all retries are completed. ",
"number": 21196,
"title": "Send system notification for unsen... | c6f7c1f709298ee7f961ebd3d679155451a31b39 | {
"head_commit": "e72b03adafd8c955f3ec06bc393902b6148b020d",
"head_commit_message": "refactor: handle notification failure",
"patch_to_review": "diff --git a/frappe/email/doctype/email_queue/email_queue.py b/frappe/email/doctype/email_queue/email_queue.py\nindex 2dccd65b4e2b..5a4ac1ad7081 100644\n--- a/frappe/ema... | [
{
"diff_hunk": "@@ -39,3 +40,38 @@ def test_email_queue_deletion_based_on_modified_date(self):\n \n \t\tself.assertTrue(frappe.db.exists(\"Email Queue\", new_record.name))\n \t\tself.assertTrue(frappe.db.exists(\"Email Queue Recipient\", {\"parent\": new_record.name}))\n+\n+\tdef test_failed_email_notification(... | 41d524c9a0a4c9faee507e11064175740d698cef | diff --git a/frappe/email/doctype/email_queue/email_queue.py b/frappe/email/doctype/email_queue/email_queue.py
index 2dccd65b4e2b..5a4ac1ad7081 100644
--- a/frappe/email/doctype/email_queue/email_queue.py
+++ b/frappe/email/doctype/email_queue/email_queue.py
@@ -6,11 +6,12 @@
import traceback
from contextlib import s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
frappe__frappe-23064@2742746 | frappe/frappe | Python | 23,064 | perf(GlobalSearch): bulk insert queued items | Fixes #14660
Global search queue items are popped and inserted into the `__global_search`
table. This used to happen individually.
This PR bulk inserts them in chunks of 10,000. | 2023-11-02T07:47:13Z | sync_global_search should do bulk insert
I'm in the process of importing the data from our current system into ERPNext, which includes 60,000+ items. I am having to do these 5000 lines at a time because of the timeout limit, but I have also noticed that `frappe.utils.global_search.sync_global_search` seems to be called... | While this is improved and the original problem you have mentioned is gone; it still does one insert at a time 😄 Maybe this can be further optimized to do bulk insert!
https://github.com/frappe/frappe/blob/3a34bfc52035b2ff23091d827d8f41a8c7f49f30/frappe/utils/global_search.py#L355-L357 | [
{
"body": "I'm in the process of importing the data from our current system into ERPNext, which includes 60,000+ items. I am having to do these 5000 lines at a time because of the timeout limit, but I have also noticed that `frappe.utils.global_search.sync_global_search` seems to be called for every single new ... | c648d3424bbe3e19b076b426574dee4ef451fe3a | {
"head_commit": "2742746cedfdcddb03a8858763583d8114efe480",
"head_commit_message": "perf(GlobalSearch): bulk insert queued items\n\nFixes #14660",
"patch_to_review": "diff --git a/frappe/utils/global_search.py b/frappe/utils/global_search.py\nindex d310e1e8d56f..9626d4aa1581 100644\n--- a/frappe/utils/global_sea... | [
{
"diff_hunk": "@@ -373,11 +373,42 @@ def sync_global_search():\n \t:param flags:\n \t:return:\n \t\"\"\"\n-\twhile frappe.cache.llen(\"global_search_queue\") > 0:\n-\t\t# rpop to follow FIFO\n-\t\t# Last one should override all previous contents of same document\n-\t\tvalue = json.loads(frappe.cache.rpop(\"glo... | 8c74d542d5e7a9214296f66c36fb97db6901d2c2 | diff --git a/frappe/utils/global_search.py b/frappe/utils/global_search.py
index d310e1e8d56f..a695ad08c713 100644
--- a/frappe/utils/global_search.py
+++ b/frappe/utils/global_search.py
@@ -11,6 +11,7 @@
from frappe.model.base_document import get_controller
from frappe.utils import cint, strip_html_tags
from frappe... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
frappe__frappe-22486@2f35f5c | frappe/frappe | Python | 22,486 | chore: handle invalid connections conf for internal links | Fixes #22481 | 2023-09-20T10:39:24Z | TypeError: 'NoneType' object is not iterable
Getting this everywhere inside desk.
```
Traceback (most recent call last):
File "apps/frappe/frappe/app.py", line 108, in application
response = frappe.api.handle()
File "apps/frappe/frappe/api.py", line 53, in handle
return _RESTAPIHandler(call, doctype, ... | @anandbaburajan any idea why this could be happening? IG if the child table specified in link doesn't actually exist, i.e. bad configuration?
related https://github.com/frappe/frappe/pull/21722
@ankush yep. | [
{
"body": "Getting this everywhere inside desk.\r\n```\r\nTraceback (most recent call last):\r\n File \"apps/frappe/frappe/app.py\", line 108, in application\r\n response = frappe.api.handle()\r\n File \"apps/frappe/frappe/api.py\", line 53, in handle\r\n return _RESTAPIHandler(call, doctype, name).get_... | 67376e26d42e9e8fd3b162254df934e0232e3d3c | {
"head_commit": "2f35f5c1f81cdd54d7759f1be58194362c094116",
"head_commit_message": "chore: handle invalid connections conf for internal links",
"patch_to_review": "diff --git a/frappe/desk/notifications.py b/frappe/desk/notifications.py\nindex f0470566ac84..f4eaee64c3ea 100644\n--- a/frappe/desk/notifications.py... | [
{
"diff_hunk": "@@ -311,8 +311,8 @@ def get_internal_links(doc, link, link_doctype):\n \telif isinstance(link, list):\n \t\t# get internal links in child documents\n \t\ttable_fieldname, link_fieldname = link\n-\t\tfor row in doc.get(table_fieldname):\n-\t\t\tvalue = row.get(link_fieldname)\n+\t\tfor row in doc... | 67a978f8925129796260b443d7cb871be458e6c1 | diff --git a/frappe/desk/notifications.py b/frappe/desk/notifications.py
index f0470566ac84..4c728bdee99f 100644
--- a/frappe/desk/notifications.py
+++ b/frappe/desk/notifications.py
@@ -311,7 +311,7 @@ def get_internal_links(doc, link, link_doctype):
elif isinstance(link, list):
# get internal links in child docu... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-52949@95aae83 | getsentry/sentry | Python | 52,949 | feat(discord): Remove Discord bot during uninstall flow | We will deal with how to handle broken integrations later on, when we are actually trying to use the integration! | 2023-07-16T04:39:09Z | Implement Discord integration uninstall flow
Discord has an API that will allow us to automatically remove the bot from the relevant server when the integration is removed on our end.
If the bot is removed from a server directly, there is no way for us to know this. Instead we will need to look out for problem respo... | [
{
"body": "Discord has an API that will allow us to automatically remove the bot from the relevant server when the integration is removed on our end.\r\n\r\nIf the bot is removed from a server directly, there is no way for us to know this. Instead we will need to look out for problem response codes (401, 403, 4... | 7aa790cc772dc2c005079fbe3abc9fb50d184031 | {
"head_commit": "95aae83c89b0c63376198c430262309f5ee3ff0a",
"head_commit_message": "Merge branch 'master' into spalmurray/discord-uninstall",
"patch_to_review": "diff --git a/src/sentry/integrations/discord/client.py b/src/sentry/integrations/discord/client.py\nindex c85164f7213327..ddf59324714772 100644\n--- a/... | [
{
"diff_hunk": "@@ -39,7 +39,37 @@\n \n \n class DiscordIntegration(IntegrationInstallation):\n- pass\n+ def get_client(self) -> DiscordClient:\n+ org_integration_id = self.org_integration.id if self.org_integration else None\n+\n+ return DiscordClient(\n+ integration_id=self.mode... | 887388ee8eaeb0978072d18b39092e7cbafe638c | diff --git a/src/sentry/integrations/discord/client.py b/src/sentry/integrations/discord/client.py
index c85164f7213327..5bd53d5cca93e8 100644
--- a/src/sentry/integrations/discord/client.py
+++ b/src/sentry/integrations/discord/client.py
@@ -15,7 +15,10 @@ class DiscordClient(IntegrationProxyClient):
base_url: st... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-52059@ca89b75 | getsentry/sentry | Python | 52,059 | feat(escalating-issues): Use bulk updates/creates | ## Objective:
Bulk update Groups to reduce load in Postgres | 2023-07-01T01:10:28Z | Auto-state transition cron updates
## Objective:
Currently we are running this cron job every 6 hours for 1000 orgs. It takes ~1h to work through the regular batches
Assuming that scales roughly linearly, increasing that 50x would mean we'd be scheduling 50h of work every 6h, and we can't simply scale up workers as the... | [
{
"body": "## Objective:\nCurrently we are running this cron job every 6 hours for 1000 orgs. It takes ~1h to work through the regular batches\nAssuming that scales roughly linearly, increasing that 50x would mean we'd be scheduling 50h of work every 6h, and we can't simply scale up workers as the load is too h... | feb57ec91212ed3cb3f7710d714f81caafc7f12b | {
"head_commit": "ca89b75b56eb6d205f28ba51b066df468cffc8ca",
"head_commit_message": "ignore type error",
"patch_to_review": "diff --git a/src/sentry/conf/server.py b/src/sentry/conf/server.py\nindex 30387996542570..eb5c91b924e364 100644\n--- a/src/sentry/conf/server.py\n+++ b/src/sentry/conf/server.py\n@@ -764,6 ... | [
{
"diff_hunk": "@@ -104,6 +108,29 @@ def remove_group_from_inbox(group, action=None, user=None, referrer=None):\n pass\n \n \n+def bulk_remove_groups_from_inbox(groups, action=None, user=None, referrer=None):\n+ try:\n+ group_inbox = GroupInbox.objects.filter(group__in=groups)\n+ group_... | 6c31465c38ac69ccec990b7d556aa2406581fde1 | diff --git a/src/sentry/conf/server.py b/src/sentry/conf/server.py
index 30387996542570..eb5c91b924e364 100644
--- a/src/sentry/conf/server.py
+++ b/src/sentry/conf/server.py
@@ -764,6 +764,10 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
),
]
+CELERY_ISSUE_STATES_QUEUE = Queue(
+ "auto_transition_issue_stat... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
frappe__frappe-20528@34615f0 | frappe/frappe | Python | 20,528 | fix: virtual fields in child tables not displaying | fixes #20526
backport version-14-hotfix
| 2023-03-30T13:49:25Z | Virtual fields display broken in child tables
## Description of the issue
Virtual fields content is not displayed anymore in child grids.
The cell remains blank instead of showing the virtual field result.
## Context information (for bug reports)
**Output of `bench version`**
```
frappe 14.30.0
```
(custo... | Bug introduced with PR #20244 | [
{
"body": "## Description of the issue\r\n\r\nVirtual fields content is not displayed anymore in child grids.\r\nThe cell remains blank instead of showing the virtual field result.\r\n\r\n## Context information (for bug reports)\r\n\r\n**Output of `bench version`**\r\n```\r\nfrappe 14.30.0\r\n```\r\n(custom app... | 32724a8eb77c09e6fd370b4b87b3c4792dc27668 | {
"head_commit": "34615f0b2491666f2239b0678b3172fc43705080",
"head_commit_message": "fix: virtual fields in child tables",
"patch_to_review": "diff --git a/frappe/model/base_document.py b/frappe/model/base_document.py\nindex 93fddcf68639..5bb034f5df3c 100644\n--- a/frappe/model/base_document.py\n+++ b/frappe/mode... | [
{
"diff_hunk": "@@ -304,7 +304,10 @@ def get_valid_dict(\n \t\tself, sanitize=True, convert_dates_to_str=False, ignore_nulls=False, ignore_virtual=False\n \t) -> dict:\n \t\td = _dict()\n-\t\tpermitted_fields = get_permitted_fields(doctype=self.doctype)\n+\t\tif parent_doc := getattr(self, \"parent_doc\", None)... | 8f5ef4cbcf94e40fc1b5fc40b7ad8e024fe01c59 | diff --git a/frappe/model/base_document.py b/frappe/model/base_document.py
index 93fddcf68639..811ba5894ca3 100644
--- a/frappe/model/base_document.py
+++ b/frappe/model/base_document.py
@@ -304,7 +304,9 @@ def get_valid_dict(
self, sanitize=True, convert_dates_to_str=False, ignore_nulls=False, ignore_virtual=False
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
frappe__frappe-19025@aaa5a18 | frappe/frappe | Python | 19,025 | fix(UX): Make fetch_from read_only if fetch_is_empty is not set | Fixes: https://github.com/frappe/frappe/issues/17457 | 2022-11-28T09:13:23Z | "Fetch from" UX
Very often users setup "fetch from" and then forget about it OR someone else notices weird behavior of "setting some field and seeing it get erased"
Probable solution:
- Disable user input on "fetch from" fields where "fetch only if empty" is not checked.
- Some icon to indicate that field will be ... | @shariquerik can you please look into this? | [
{
"body": "Very often users setup \"fetch from\" and then forget about it OR someone else notices weird behavior of \"setting some field and seeing it get erased\"\r\n\r\nProbable solution:\r\n- Disable user input on \"fetch from\" fields where \"fetch only if empty\" is not checked.\r\n- Some icon to indicate ... | 6062d812a16f5e6e7e2e63b9cc1be99585d105ab | {
"head_commit": "aaa5a1816426e4ab403e028172590b1ab40646b4",
"head_commit_message": "fix(UX): Make fetch_from read_only if fetch_is_empty is not set",
"patch_to_review": "diff --git a/frappe/public/js/frappe/form/controls/base_input.js b/frappe/public/js/frappe/form/controls/base_input.js\nindex 62f1c51f6797..8c7... | [
{
"diff_hunk": "@@ -101,6 +103,16 @@ frappe.ui.form.ControlInput = class ControlInput extends frappe.ui.form.Control\n \t\t\t\t\t}\n \t\t\t\t}\n \t\t\t\tme.$input && me.$input.prop(\"disabled\", true);\n+\n+\t\t\t\tif (is_fetch_from_read_only) {\n+\t\t\t\t\t$(me.disp_area).attr(\n+\t\t\t\t\t\t\"title\",\n+\t\t\... | edb0fdf109f9ef15ee6db4e486f5091de726d1d9 | diff --git a/frappe/public/js/frappe/form/controls/base_input.js b/frappe/public/js/frappe/form/controls/base_input.js
index 62f1c51f6797..43fb4f54dc43 100644
--- a/frappe/public/js/frappe/form/controls/base_input.js
+++ b/frappe/public/js/frappe/form/controls/base_input.js
@@ -83,7 +83,9 @@ frappe.ui.form.ControlInput... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-53476@18f4de6 | getsentry/sentry | Python | 53,476 | ref: Allow auto-assignment after manual assignment if called from API | Allow auto-assignment after manual assignment if called from force auto-assignment API (see https://github.com/getsentry/getsentry/pull/11401)
closes https://github.com/getsentry/sentry/issues/52318 | 2023-07-24T22:37:17Z | Create an API which will force run auto-assignment
We built a feature which prevents auto-assignment of an issue which was manually assigned. This is to prevent us from incorrectly auto-assigning an issue when it has been determined that there is a better assignee. This however can lead to an issue where if issues we... | https://github.com/getsentry/sentry/blob/master/src/sentry/models/projectownership.py#L292-L294
This query checks if a user manually overrode the assignment. Wrap a flag around this for the API and skip this check to force the auto-assignment. | [
{
"body": "We built a feature which prevents auto-assignment of an issue which was manually assigned. This is to prevent us from incorrectly auto-assigning an issue when it has been determined that there is a better assignee. This however can lead to an issue where if issues were accidentally assigned in bulk... | 9693c08ca46c8457688b04aed2480f95ad851548 | {
"head_commit": "18f4de6cd6141a90c2f9e7f8ae8d9702482d5028",
"head_commit_message": "Revert \"feat: Make API public\"\n\nThis reverts commit 7cc5753c6efca04548cc19d22483edc2e4ab101f.",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/organization_force_auto_assignment.py b/src/sentry/api/endpoints/organi... | [
{
"diff_hunk": "@@ -0,0 +1,47 @@\n+from rest_framework.request import Request\n+from rest_framework.response import Response\n+\n+from sentry import ratelimits as ratelimiter\n+from sentry.api.base import region_silo_endpoint\n+from sentry.api.bases.organization import OrganizationEndpoint\n+from sentry.api.ser... | 8e93c6c3fc7a73d18a2734e8fe28efab65d2ad83 | diff --git a/src/sentry/models/groupassignee.py b/src/sentry/models/groupassignee.py
index 9b24c89135bc59..dfaa63e5e637dd 100644
--- a/src/sentry/models/groupassignee.py
+++ b/src/sentry/models/groupassignee.py
@@ -38,6 +38,7 @@ def assign(
acting_user: User | None = None,
create_only: bool = False,
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-51539@5d2112e | getsentry/sentry | Python | 51,539 | ref(rules): Bucket max rules into slow and fast | Allow for 100 "slow" rules (these are more expensive to process) and 200 "fast" issue alert rules per project.
Closes #51422 | 2023-06-23T19:51:18Z | Ability to exceed 100 alert issues per project
### Problem Statement
For multiple teams sharing a project, the total number of alerts per project can easily exceed the 100 alert limit.
### Solution Brainstorm
Differentiating and having a higher limit for the rules that are not as resource intensive, for example ... | Assigning to @getsentry/support for [routing](https://open.sentry.io/triage/#2-route), due by **<time datetime=2023-06-22T23:56:28.695Z>Thursday, June 22nd at 4:56 pm</time> (sfo)**. ⏲️
Routing to @getsentry/product-owners-alerts for [triage](https://develop.sentry.dev/processing-tickets/#3-triage), due by **<time date... | [
{
"body": "### Problem Statement\n\nFor multiple teams sharing a project, the total number of alerts per project can easily exceed the 100 alert limit. \r\n\n\n### Solution Brainstorm\n\nDifferentiating and having a higher limit for the rules that are not as resource intensive, for example alert rules that que... | 4976c31987f79c85f757fdfa4a74e7db8c1733a5 | {
"head_commit": "5d2112e1adb941611057283c91274bbb5f162695",
"head_commit_message": "ref(rules): Bucket max rules into slow and fast",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/project_rules.py b/src/sentry/api/endpoints/project_rules.py\nindex f472bf44667c45..8fde1df6763afe 100644\n--- a/src/sent... | [
{
"diff_hunk": "@@ -3374,7 +3374,8 @@ def build_cdc_postgres_init_db_volume(settings: Any) -> dict[str, dict[str, str]\n # determines if we enable analytics or not\n ENABLE_ANALYTICS = False\n \n-MAX_ISSUE_ALERTS_PER_PROJECT = 100\n+MAX_SLOW_CONDITION_ALERTS = 100\n+MAX_FAST_CONDITION_ALERTS = 200",
"line":... | 5f2381d0ec6bfe710ee14fb9d9ff141c7c2e4f94 | diff --git a/src/sentry/api/endpoints/project_rules.py b/src/sentry/api/endpoints/project_rules.py
index f472bf44667c45..507b27ed5b94a5 100644
--- a/src/sentry/api/endpoints/project_rules.py
+++ b/src/sentry/api/endpoints/project_rules.py
@@ -12,6 +12,7 @@
from sentry.mediators import project_rules
from sentry.models... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
frappe__frappe-17461@34b1ea5 | frappe/frappe | Python | 17,461 | perf: Re-use SMTP session while sending bulk emails | ## Use case:
Send newsletter emails to 20k recipients.
### Before:
"Send Now" functionality of newsletter used to timeout from frontend. It used to take more than **15mins** just to queue emails when tried from backend console. Now to actually send all the 20k emails it used take around **5.7hrs** 🕔.
> Rough e... | 2022-07-11T09:26:09Z | Newsletter issues
## Description of the issue
- [ ] Schedule feature on Newsletter is not working. Emails do not get sent at the scheduled time.
- [x] The unsubscribe feature is not working. If I click on unsubscribe in the newsletter, it asks me to select email groups to unsubscribe from but it doesn't really unsu... | > 2. Unsubscribe feature is not working. If I click on unsubscribe in newsletter, it asks me to select email groups to unsubscribe from but it doesn't really unsubscribe in desk.
Fix: https://github.com/frappe/frappe/pull/16756
@palkanp The problems described are too vague and require a lot of maintainer time to int... | [
{
"body": "## Description of the issue\r\n\r\n- [ ] Schedule feature on Newsletter is not working. Emails do not get sent at the scheduled time.\r\n- [x] The unsubscribe feature is not working. If I click on unsubscribe in the newsletter, it asks me to select email groups to unsubscribe from but it doesn't real... | a9fd5f50017491de4a8576364c20a3ac2d77f3ea | {
"head_commit": "34b1ea57f9b76286af2d19542b7d811e2dfc6bf0",
"head_commit_message": "fix: Show \"Queued\" status on newsletter\n\nShow \"Queued\" status on newsletter if emails are queued and \"email sending\" is not yet started.",
"patch_to_review": "diff --git a/frappe/email/doctype/email_group_member/email_gro... | [
{
"diff_hunk": "@@ -58,7 +58,8 @@\n \"in_list_view\": 1,\n \"in_standard_filter\": 1,\n \"label\": \"Status\",\n- \"options\": \"\\nNot Sent\\nSending\\nSent\\nError\\nExpired\"\n+ \"options\": \"\\nNot Sent\\nSending\\nSent\\nError\\nExpired\",\n+ \"search_index\": 1",
"line": null,
"ori... | 6bcef3781ea157cb628e44aee24f7e16e7c0820c | diff --git a/frappe/email/doctype/email_group_member/email_group_member.json b/frappe/email/doctype/email_group_member/email_group_member.json
index b3b87c6211b2..0e32135b72fe 100644
--- a/frappe/email/doctype/email_group_member/email_group_member.json
+++ b/frappe/email/doctype/email_group_member/email_group_member.js... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
frappe__frappe-17276@f6b2aa7 | frappe/frappe | Python | 17,276 | feat(translations-cli): Fetch translations for a particular app | get-untranslated/update-translations string for particular app #17268 (feature request)
Alternative
For some APP:
bench get-untranslated --app myappname [lang] [/some/path]
bench update-translations --app myappname [lang] [/some/path]
For complete System:
bench get-untranslated [lang] [/some/path]
bench updat... | 2022-06-22T15:14:06Z | get-untranslated/update-translations string for particular app
**Solution**
I developed an alternative for command **bench get-untranslated [lang] [/some/path]** and **bench update-translations [lang] [/some/path]** that allowed get and update translations for particular app and not complete system, if the user want... | [
{
"body": "**Solution**\r\nI developed an alternative for command **bench get-untranslated [lang] [/some/path]** and **bench update-translations [lang] [/some/path]** that allowed get and update translations for particular app and not complete system, if the user wants.\r\n\r\n**Alternative**\r\n**For some APP... | 1297b25ecf08d89736fc7f04e82d07aa97f68690 | {
"head_commit": "f6b2aa781ac005d3f40c3c7ff665dc4de8d26c27",
"head_commit_message": "translataions for particular app\n\n get-untranslated/update-translations string for particular app #17268 (feature request)",
"patch_to_review": "diff --git a/frappe/translate.py b/frappe/translate.py\nindex eb26124ba8a4..a87ed8... | [
{
"diff_hunk": "@@ -808,19 +808,25 @@ def write_csv_file(path, app_messages, lang_dict):\n \t\t\t\tw.writerow([message, translated_string, context])\n \n \n-def get_untranslated(lang, untranslated_file, get_all=False):\n+def get_untranslated(lang, untranslated_file, get_all=False, app='all'):",
"line": null... | dce7760ad7edeb9567263b0df1fb206bac076e2e | diff --git a/frappe/commands/translate.py b/frappe/commands/translate.py
index 0b14e03002c9..69970d8d97df 100644
--- a/frappe/commands/translate.py
+++ b/frappe/commands/translate.py
@@ -48,11 +48,12 @@ def new_language(context, lang_code, app):
@click.command("get-untranslated")
+@click.option("--app", default="_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-51574@a2f037a | getsentry/sentry | Python | 51,574 | feat(discord): Implement Discord integration installation | - Build upon the `DiscordIntegrationProvider` to allow for installing the Discord bot from the integration details page
- Implement the beginnings of `DiscordClient` in order to fetch guild name at install time (extending `IntegrationProxyClient` and not `ApiClient` | 2023-06-25T19:45:56Z | Create initial Discord API client structure
Should exist in `integrations/discord/client.py` and should extend `ApiClient`. See `msteams` client for reference.
This initial client implementation should be able to do some basic request to the Discord API using our credentials.
Implement Discord integration installat... | [
{
"body": "Should exist in `integrations/discord/client.py` and should extend `ApiClient`. See `msteams` client for reference.\r\n\r\nThis initial client implementation should be able to do some basic request to the Discord API using our credentials.",
"number": 50861,
"title": "Create initial Discord A... | a37d0ce7c29bae3a46a3fc34d31e4f6f59164d2e | {
"head_commit": "a2f037a8cf34a81908d9cf83da42a993519049ea",
"head_commit_message": "Add utils module with logger definition",
"patch_to_review": "diff --git a/src/sentry/integrations/discord/client.py b/src/sentry/integrations/discord/client.py\nnew file mode 100644\nindex 00000000000000..0502bb4df25f8e\n--- /de... | [
{
"diff_hunk": "@@ -0,0 +1,166 @@\n+import responses\n+from django.test import override_settings\n+\n+from sentry import options\n+from sentry.integrations.discord.client import DiscordClient\n+from sentry.shared_integrations.exceptions import IntegrationError\n+from sentry.silo.base import SiloMode\n+from sent... | 00e6d220509aeaf8764b5cd87ac41d5ce6c1bfa7 | diff --git a/src/sentry/integrations/discord/client.py b/src/sentry/integrations/discord/client.py
new file mode 100644
index 00000000000000..c85164f7213327
--- /dev/null
+++ b/src/sentry/integrations/discord/client.py
@@ -0,0 +1,45 @@
+from __future__ import annotations
+
+from requests import PreparedRequest
+
+from ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-51791@cf8eece | getsentry/sentry | Python | 51,791 | feat(indexer): Add bulk_reverse_resolve to avoid N+1 db queries. | This PR adds functionality for bulk conversion between indexes and strings in the String indexer .
fixes: https://github.com/getsentry/sentry/issues/51786 | 2023-06-28T13:07:46Z | Add `bulk_reverse_resolve` to StringIndexer implementation
### Problem Statement
When retrieving data from Snuba we need to convert back from indexes to strings, for this we use `StringIndexer.reverse_resolve`.
Since we are doing this for every row we end up doing another query for each result row ( excluding cached ... | [
{
"body": "### Problem Statement\n\nWhen retrieving data from Snuba we need to convert back from indexes to strings, for this we use `StringIndexer.reverse_resolve`. \nSince we are doing this for every row we end up doing another query for each result row ( excluding cached results).\nThis is unreasonable and c... | 2c31ee009b44964f78b9e7e8282e602b7ef849b0 | {
"head_commit": "cf8eece90dcf91e5f5aab3a13023de4a46103c47",
"head_commit_message": "initial implementation of bulk_reverse_resolve",
"patch_to_review": "diff --git a/src/sentry/sentry_metrics/indexer/__init__.py b/src/sentry/sentry_metrics/indexer/__init__.py\nindex 56e7298564c65b..a5fc956e93e31d 100644\n--- a/s... | [
{
"diff_hunk": "@@ -409,6 +409,27 @@ def reverse_resolve(self, use_case_id: UseCaseID, org_id: int, id: int) -> Optio\n string: str = obj.string\n return string\n \n+ def bulk_reverse_resolve(\n+ self, use_case_id: UseCaseID, org_id: int, ids: Collection[int]\n+ ) -> List[Optional[s... | 7b45bda9b9539b457f2b2af2c98cf8f10b2894fa | diff --git a/src/sentry/sentry_metrics/indexer/__init__.py b/src/sentry/sentry_metrics/indexer/__init__.py
index 56e7298564c65b..a5fc956e93e31d 100644
--- a/src/sentry/sentry_metrics/indexer/__init__.py
+++ b/src/sentry/sentry_metrics/indexer/__init__.py
@@ -19,3 +19,4 @@
resolve = StringIndexer().resolve
rev... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
frappe__frappe-16877@e78a251 | frappe/frappe | Python | 16,877 | feat!: Added support for IS in frappe qb | Fixes #16869
Using https://github.com/dickerschutz/frappe/commit/53148c3f90487dde8537733d16961947d5363885
<!-- no-docs --> | 2022-05-11T08:38:35Z | bug: "is" query operator no longer working
Just checked out the latest version of the develop branch. Every doctype throws an error if i try to filter by "is" "set"/"not set"
See traceback
### App Versions
```
{
"dickerschutz": "0.0.1",
"erpnext": "14.0.0-dev",
"frappe": "14.0.0-dev"
}
```
### Route
`... | Fix can be found here https://github.com/dickerschutz/frappe/commit/53148c3f90487dde8537733d16961947d5363885
Can't make a pull request. I need to order my commits per feature in a new fork in order to make descent pull requests here. | [
{
"body": "Just checked out the latest version of the develop branch. Every doctype throws an error if i try to filter by \"is\" \"set\"/\"not set\"\r\n\r\nSee traceback\r\n\r\n### App Versions\r\n```\r\n{\r\n\t\"dickerschutz\": \"0.0.1\",\r\n\t\"erpnext\": \"14.0.0-dev\",\r\n\t\"frappe\": \"14.0.0-dev\"\r\n}\r... | fea45bf34183ce01c8a689e0c33326daac26faf1 | {
"head_commit": "e78a2513b80c4431d8ee4df9aae1304f2d16dbea",
"head_commit_message": "test: updated tests",
"patch_to_review": "diff --git a/frappe/database/query.py b/frappe/database/query.py\nindex f7393bfa54f3..701286c9894c 100644\n--- a/frappe/database/query.py\n+++ b/frappe/database/query.py\n@@ -85,6 +85,11 ... | [
{
"diff_hunk": "@@ -85,6 +85,11 @@ def func_between(key: Field, value: Union[List, Tuple]) -> frappe.qb:\n \treturn key[slice(*value)]\n \n \n+def func_is(key, value):\n+\t\"Wrapper for IS\"\n+\treturn key.isnotnull() if value.lower() == \"set\" else key.isnull()",
"line": null,
"original_line": 90,
... | 3296898b4864d977cfb9b4bbdb5a68ca64cbb4c5 | diff --git a/frappe/database/query.py b/frappe/database/query.py
index f7393bfa54f3..b107759af0ca 100644
--- a/frappe/database/query.py
+++ b/frappe/database/query.py
@@ -85,6 +85,11 @@ def func_between(key: Field, value: Union[List, Tuple]) -> frappe.qb:
return key[slice(*value)]
+def func_is(key, value):
+ "Wra... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
frappe__frappe-17059@9cf2125 | frappe/frappe | Python | 17,059 | feat(UI): Add beforeunload Listener for 'Leave Site' Dialog to dirty forms | This closes #17058
When the tab of an unsaved document form is closed, a "Leave Site" Dialog is triggered.
The Dialog will not be triggered when the Bench is in developer mode
For performance reasons, the Listener for the Dialog is only added when dirty() is called on the frame and removed when the frame is refr... | 2022-06-02T09:28:30Z | Leave Site Dialog for dirty/unsaved Forms
**The Problem**
When a user forgets to save a modified document and closes the Tab, then the changes are lost
**The Solution**
Closing a Tab with unsaved changes triggers a warning via the beforeunload event listener.
Ideally this would probably be configurable on a per-u... | [
{
"body": "**The Problem**\r\nWhen a user forgets to save a modified document and closes the Tab, then the changes are lost\r\n\r\n**The Solution**\r\nClosing a Tab with unsaved changes triggers a warning via the beforeunload event listener.\r\nIdeally this would probably be configurable on a per-user basis or ... | 9137a597ebed0fb81f39405deb54b49dce1bce11 | {
"head_commit": "9cf2125d075f647a7fc28b07aa2e91f715ff567c",
"head_commit_message": "Feat(UI): Add beforeunload Listener for 'Leave Site' Dialog to dirty forms",
"patch_to_review": "diff --git a/frappe/public/js/frappe/form/form.js b/frappe/public/js/frappe/form/form.js\nindex a997287a52f4..7b3bdb9d7a57 100644\n-... | [
{
"diff_hunk": "@@ -421,6 +422,17 @@ frappe.ui.form.Form = class FrappeForm {\n \t\t}\n \t}\n \n+\n+\t// Adds un beforeunload Listener to trigger a \"Leave Site\" Dialog, when a dirty (unsaved) form is closed\n+\tset_dirty_listener() {\n+\t\taddEventListener('beforeunload', (event) => {\n+\t\t\tif (cur_frm.is_d... | e1ce3364eacc1fd0c3ce6dd0ca2ff43cd771144c | diff --git a/frappe/public/js/frappe/form/form.js b/frappe/public/js/frappe/form/form.js
index a997287a52f4..0d4f9a89bc04 100644
--- a/frappe/public/js/frappe/form/form.js
+++ b/frappe/public/js/frappe/form/form.js
@@ -39,6 +39,12 @@ frappe.ui.form.Form = class FrappeForm {
this.parent = parent;
this.doctype_layo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
frappe__frappe-15918@e21275f | frappe/frappe | Python | 15,918 | feat: Allow all users to customize reports of type Report Builder | Resolves #15074
Continuation of #15494
This PR allows a report of type Report Builder to be created / edited / deleted by any user. This is accomplished without changing permissions for the Report DocType, since this PR only allows non-standard reports of type Report Builder to be saved. They can then be edited / d... | 2022-02-09T06:54:18Z | Allow all users to save customized reports
### User story
If a user can see a report (type: Report Builder), he can add or remove columns and filters to customize his view. Consequently he should also be able to save this current view for future use.
### Situation
At the moment, only users with role "Report Manage... | https://github.com/frappe/frappe/pull/15494 is a good start.
Further recommendations:
- Save button should be visible only if User is Report's owner or Report Manager.
- A button to delete a report will be visible in Report View based on following conditions:
- Report is of type Report Builder
- User is ow... | [
{
"body": "### User story\r\nIf a user can see a report (type: Report Builder), he can add or remove columns and filters to customize his view. Consequently he should also be able to save this current view for future use.\r\n\r\n### Situation\r\nAt the moment, only users with role \"Report Manager\" can save cu... | ec5dd7995789ab470fdb1b44217d6fec5b5223db | {
"head_commit": "e21275f06034a5843085c7373dd7015d66153c7d",
"head_commit_message": "style: add missing semicolon",
"patch_to_review": "diff --git a/frappe/core/doctype/report/test_report.py b/frappe/core/doctype/report/test_report.py\nindex 36e3b09254ac..5a22304f321a 100644\n--- a/frappe/core/doctype/report/test... | [
{
"diff_hunk": "@@ -262,22 +262,62 @@ def compress(data, args=None):\n \t}\n \n @frappe.whitelist()\n-def save_report():\n-\t\"\"\"save report\"\"\"\n-\n-\tdata = frappe.local.form_dict\n-\tif frappe.db.exists('Report', data['name']):\n-\t\td = frappe.get_doc('Report', data['name'])\n+def save_report(name, doct... | 976c3bedc393a2be78e0492b142aa6a820842bc1 | diff --git a/frappe/core/doctype/report/test_report.py b/frappe/core/doctype/report/test_report.py
index 36e3b09254ac..5a22304f321a 100644
--- a/frappe/core/doctype/report/test_report.py
+++ b/frappe/core/doctype/report/test_report.py
@@ -4,7 +4,9 @@
import frappe, json, os
import unittest
from frappe.desk.query_rep... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-51835@d06ea20 | getsentry/sentry | Python | 51,835 | ref(escalating): Remove forecast floor bound | Remove floor bound for escalating issues algorithm.
Log exception and call forecast generation function on fetch if the forecast does not exist
fixes https://github.com/getsentry/sentry/issues/51947 | 2023-06-28T20:38:40Z | Remove forecast floor bound in escalating algorithm
### Problem Statement
The forecast floor bound of 200 is not a good estimation of when an issue with < 30 events/hr is escalating.
### Solution Brainstorm
Remove the forecast floor bound of 200.
Change the forecast fetch fallback to call the forecast generation al... | [
{
"body": "### Problem Statement\n\nThe forecast floor bound of 200 is not a good estimation of when an issue with < 30 events/hr is escalating.\n\n### Solution Brainstorm\n\nRemove the forecast floor bound of 200.\r\nChange the forecast fetch fallback to call the forecast generation algorithm and log an except... | 0d89fda696015d53bf4bbdeb82b2f828ca374d85 | {
"head_commit": "d06ea200aaa6a55d8d52fb86caecce81e6e6caf7",
"head_commit_message": "fix: Test",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/group_details.py b/src/sentry/api/endpoints/group_details.py\nindex d19223e573dc1b..17a1d96b8a4dd4 100644\n--- a/src/sentry/api/endpoints/group_details.py\n+++... | [
{
"diff_hunk": "@@ -48,21 +47,29 @@ def save(self) -> None:\n )\n \n @classmethod\n- def fetch(cls, project_id: int, group_id: int) -> EscalatingGroupForecast:\n+ def fetch(cls, project_id: int, group_id: int) -> Optional[EscalatingGroupForecast]:\n+ from sentry.issues.forecasts import ... | 407d5a71eae85c5d0854860a7682179b7f96f90b | diff --git a/src/sentry/api/endpoints/group_details.py b/src/sentry/api/endpoints/group_details.py
index d19223e573dc1b..17a1d96b8a4dd4 100644
--- a/src/sentry/api/endpoints/group_details.py
+++ b/src/sentry/api/endpoints/group_details.py
@@ -222,17 +222,17 @@ def get(self, request: Request, group) -> Response:
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
frappe__frappe-17265@0f046ce | frappe/frappe | Python | 17,265 | fix: Migration failures for version-13 to develop | <img width="963" alt="Screenshot 2022-06-21 at 9 05 04 PM" src="https://user-images.githubusercontent.com/42651287/174841614-57bf4395-3911-4194-995d-a2c0f108e7dd.png">
<img width="944" alt="Screenshot 2022-06-21 at 9 10 10 PM" src="https://user-images.githubusercontent.com/42651287/174841625-ec3c327a-a939-4bce-af95-e6... | 2022-06-21T15:43:44Z | Migration from version-13 -> develop fails.
I've tested several migrations from `version-13` -> `develop`
I should pass `skip-failing` so the model will sync. Once model is synced running `bench migrate` this patch will complete.
`frappe.patches.v14_0.update_workspace2`
```
Retrieving Routes ... | [
{
"body": "I've tested several migrations from `version-13` -> `develop` \r\n\r\nI should pass `skip-failing` so the model will sync. Once model is synced running `bench migrate` this patch will complete.\r\n\r\n`frappe.patches.v14_0.update_workspace2`\r\n\r\n```\r\nRetrieving Routes : [======... | 683e9a380e09e402eb93e7d84ae5e1b925cb5067 | {
"head_commit": "0f046ce7ff42db0963f0e00d9ee9ea466c269f4e",
"head_commit_message": "Merge branch 'develop' into migration_failures",
"patch_to_review": "diff --git a/frappe/core/doctype/doctype/doctype.py b/frappe/core/doctype/doctype/doctype.py\nindex e834b698d52c..0d46a2b74643 100644\n--- a/frappe/core/doctype... | [
{
"diff_hunk": "@@ -184,6 +184,7 @@ frappe.patches.v13_0.jinja_hook\n frappe.patches.v13_0.update_notification_channel_if_empty\n frappe.patches.v13_0.set_first_day_of_the_week\n execute:frappe.reload_doc('custom', 'doctype', 'custom_field')\n+execute:frappe.reload_doc('desk', 'doctype', 'workspace_quick_list')... | 3ec6f7f470036c2dc3a67014803b00b8a4cd0a65 | diff --git a/frappe/core/doctype/doctype/doctype.py b/frappe/core/doctype/doctype/doctype.py
index e56803acb76e..a965d9c1b2e8 100644
--- a/frappe/core/doctype/doctype/doctype.py
+++ b/frappe/core/doctype/doctype/doctype.py
@@ -1298,7 +1298,7 @@ def check_is_published_field(meta):
frappe.throw(_("Is Published Field ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-50321@ab5ab86 | getsentry/sentry | Python | 50,321 | feat(sort): properly calculate sort score for issue-platform occurrences | This PR parameterizes the `better_priority` aggregation to consider errors vs issue-platform events and whether to use certain columns as part of the better priority scoring.
The only difference between the formulas for `better_priority` errors and issue-platform are the timestamp columns used and whether to consid... | 2023-06-05T19:18:20Z | Implement more robust priority scoring for issue platform issues
Currently, we're assigning a score of zero to performance and profiling issues when using betterPriority sort which de-ranks these issues to the very bottom of the sorted issues. Instead, we should consider the data-set we're querying from and exclude col... | [
{
"body": "Currently, we're assigning a score of zero to performance and profiling issues when using betterPriority sort which de-ranks these issues to the very bottom of the sorted issues. Instead, we should consider the data-set we're querying from and exclude columns that aren't present from the score.",
... | 23e09e524d9b530b5f809934e1fd633daa63ffc5 | {
"head_commit": "ab5ab86ddf5825b30f5571be9069987f5e0cba30",
"head_commit_message": "params",
"patch_to_review": "diff --git a/src/sentry/search/snuba/executors.py b/src/sentry/search/snuba/executors.py\nindex 87166c07de2fa5..0a5eb40a93d02a 100644\n--- a/src/sentry/search/snuba/executors.py\n+++ b/src/sentry/sear... | [
{
"diff_hunk": "@@ -237,7 +238,9 @@ def _prepare_aggregations(\n aggregation = self.aggregation_defs[alias]\n # TODO: remove this hack once we can properly support better_priority sort on issue platform dataset",
"line": null,
"original_line": 239,
"original_start_line": null... | 42298728523bbed88d06c4fb0715afbb95303ffb | diff --git a/src/sentry/search/snuba/executors.py b/src/sentry/search/snuba/executors.py
index 87166c07de2fa5..576ca53aa3fd86 100644
--- a/src/sentry/search/snuba/executors.py
+++ b/src/sentry/search/snuba/executors.py
@@ -4,7 +4,7 @@
import logging
import time
from abc import ABCMeta, abstractmethod
-from dataclass... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
huggingface__text-generation-inference-2095@f1a6fdb | huggingface/text-generation-inference | Python | 2,095 | corrected Pydantic warning. | On using python client with pydantic 2, it raises a warning on import time:
this corners of the execution logs
Fixes #1761
- [ ] I ran it locally with the patch
@OlivierDehaene
@Narsil | 2024-06-20T01:39:15Z | Importing from `text_generation.errors` throws Pydantic warning.
### System Info
Using `text-generation` python package version `0.7.0`, importing from the `errors` submodule throws a warning for protected namespace due to `model` being a protected namespace and the existence of the `model_id` field in `NotSupportedEr... | This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. | [
{
"body": "### System Info\n\nUsing `text-generation` python package version `0.7.0`, importing from the `errors` submodule throws a warning for protected namespace due to `model` being a protected namespace and the existence of the `model_id` field in `NotSupportedError`.\r\n\r\n```\r\n/home/chris/Code/venv/li... | cdbf802860390265dd9be6ca42d043587efcf59f | {
"head_commit": "f1a6fdb90007e16f9b04869f0abd38e2fec734f7",
"head_commit_message": "corrected Pydantic warning.",
"patch_to_review": "diff --git a/clients/python/text_generation/types.py b/clients/python/text_generation/types.py\nindex eb872ee6564..92f229ce986 100644\n--- a/clients/python/text_generation/types.p... | [
{
"diff_hunk": "@@ -452,5 +452,6 @@ class StreamResponse(BaseModel):\n \n # Inference API currently deployed model\n class DeployedModel(BaseModel):\n+ model_config = ConfigDict(protected_namespaces=())",
"line": 458,
"original_line": 455,
"original_start_line": null,
"path": "clients/python... | 4b8d150ceb85298931cb333e2c00c7ca5a1c1e62 | diff --git a/clients/python/text_generation/types.py b/clients/python/text_generation/types.py
index eb872ee6564..497468d9f8c 100644
--- a/clients/python/text_generation/types.py
+++ b/clients/python/text_generation/types.py
@@ -1,5 +1,5 @@
from enum import Enum
-from pydantic import BaseModel, field_validator
+from p... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-50227@4dd62a6 | getsentry/sentry | Python | 50,227 | ref(dynamic-sampling): Implement new abstraction for models | This PR implements a completely new system for defining models that we might use for dynamic sampling.
Closes https://github.com/getsentry/sentry/issues/49930 | 2023-06-02T09:10:54Z | Cleanup dynamic sampling code
The dynamic sampling package saw substantial growth w.r.t. responsibilities. Due to the speed of iteration, there is some technical debt in the code which should be cleaned up. It will not require a lot of effort but it will help to keep our standards high. | [
{
"body": "The dynamic sampling package saw substantial growth w.r.t. responsibilities. Due to the speed of iteration, there is some technical debt in the code which should be cleaned up. It will not require a lot of effort but it will help to keep our standards high.",
"number": 49930,
"title": "Cleanu... | a1744da6d946c9fbde2e088e6fa4c72a96793a85 | {
"head_commit": "4dd62a6f33650cbead039cea1109dec8b8715293",
"head_commit_message": "Refactor guarded run",
"patch_to_review": "diff --git a/src/sentry/dynamic_sampling/models/adjustment_models.py b/src/sentry/dynamic_sampling/models/adjustment_models.py\ndeleted file mode 100644\nindex 39e52303c7b8f1..0000000000... | [
{
"diff_hunk": "@@ -0,0 +1,136 @@\n+from dataclasses import dataclass\n+from typing import List, Optional, Tuple\n+\n+from sentry.dynamic_sampling.models.base import Model, ModelInput, ModelType\n+from sentry.dynamic_sampling.models.common import ModelClass, sum_classes_counts\n+from sentry.dynamic_sampling.mod... | fd0cb0c90ba602ca8d5182623cfb4a604fd46396 | diff --git a/src/sentry/dynamic_sampling/models/adjustment_models.py b/src/sentry/dynamic_sampling/models/adjustment_models.py
deleted file mode 100644
index 39e52303c7b8f1..00000000000000
--- a/src/sentry/dynamic_sampling/models/adjustment_models.py
+++ /dev/null
@@ -1,25 +0,0 @@
-from dataclasses import dataclass
-fr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
frappe__frappe-14597@e48cdd8 | frappe/frappe | Python | 14,597 | fix: remove mutable defaults | None of these seem harmful at first but IDK what combination of these will become a bug.
closes https://github.com/frappe/frappe/issues/14596 | 2021-10-27T14:55:57Z | mutable default arguments in sendmail function
I was reading the source and I see the sendmail function has 3 mutable default arguments:
* recipients=[]
* cc=[]
* bcc=[]
Should be an easy fix for someone, there may be more of these in the codebase. | Also more cases of mutable default arguments can be found in:
* accounts/doctype/sales_invoice/pos.py (functions: get_customer_list, make_invoice)
* controller/status_updater.py (functions: get_tolerance_for)
* hub_node/__init__.py (functions: get_list, get_item_favourites)
The email one worries me the most, I ... | [
{
"body": "I was reading the source and I see the sendmail function has 3 mutable default arguments:\r\n\r\n* recipients=[]\r\n* cc=[]\r\n* bcc=[]\r\n\r\nShould be an easy fix for someone, there may be more of these in the codebase.",
"number": 14596,
"title": "mutable default arguments in sendmail func... | 380882f3910508103e3ae033758b59403d79dc9e | {
"head_commit": "e48cdd87af7c9cd7f4caaa5b7db7425c1d7976f7",
"head_commit_message": "fix: mutable defaults",
"patch_to_review": "diff --git a/frappe/__init__.py b/frappe/__init__.py\nindex 9cc83d63a463..b512b23c7629 100644\n--- a/frappe/__init__.py\n+++ b/frappe/__init__.py\n@@ -487,11 +487,11 @@ def get_request_... | [
{
"diff_hunk": "@@ -480,12 +487,11 @@ def get_stats(stats, doctype, filters=[]):\n \treturn stats\n \n @frappe.whitelist()\n-def get_filter_dashboard_data(stats, doctype, filters=[]):\n+def get_filter_dashboard_data(stats, doctype, filters=None):\n \t\"\"\"get tags info\"\"\"\n \timport json\n \ttags = json.loa... | d1992a20242e0b21c3a49bdf57193290b77355f8 | diff --git a/frappe/__init__.py b/frappe/__init__.py
index 9cc83d63a463..b512b23c7629 100644
--- a/frappe/__init__.py
+++ b/frappe/__init__.py
@@ -487,11 +487,11 @@ def get_request_header(key, default=None):
:param default: Default value."""
return request.headers.get(key, default)
-def sendmail(recipients=[], se... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
frappe__frappe-14493@2e4f5e0 | frappe/frappe | Python | 14,493 | fix: handle negative duration | Closes #14492 | 2021-10-18T23:41:30Z | Negative duration gets rendered wrong
## Description of the issue
When setting a negative number in a duration field, the value is displayed incorrectly.
## Context information (for bug reports)
**Output of `bench version`**
```
erpnext 13.12.1
frappe 13.11.0
```
## Steps to reproduce the issue
1. Cr... | [
{
"body": "## Description of the issue\r\n\r\nWhen setting a negative number in a duration field, the value is displayed incorrectly.\r\n\r\n## Context information (for bug reports)\r\n\r\n**Output of `bench version`**\r\n```\r\nerpnext 13.12.1\r\nfrappe 13.11.0\r\n```\r\n\r\n## Steps to reproduce the issue\r\n... | df76d33893e9ed7919f04a56a74d4f984c5479bf | {
"head_commit": "2e4f5e0796a202d5100c5de69ac9e11772029726",
"head_commit_message": "fix: handle negative duration",
"patch_to_review": "diff --git a/frappe/public/js/frappe/utils/utils.js b/frappe/public/js/frappe/utils/utils.js\nindex 831538d25599..065ae415f524 100644\n--- a/frappe/public/js/frappe/utils/utils.... | [
{
"diff_hunk": "@@ -1049,16 +1049,16 @@ Object.assign(frappe.utils, {\n \t\treturn duration;\n \t},\n \n-\tseconds_to_duration(value, duration_options) {\n-\t\tlet secs = value;\n+\tseconds_to_duration(secs, duration_options) {",
"line": null,
"original_line": 1052,
"original_start_line": null,
... | 7649cdff4cb21ee62b2c0cc254d7b722d6d11c3b | diff --git a/frappe/public/js/frappe/utils/utils.js b/frappe/public/js/frappe/utils/utils.js
index 831538d25599..b49dfa02800d 100644
--- a/frappe/public/js/frappe/utils/utils.js
+++ b/frappe/public/js/frappe/utils/utils.js
@@ -1049,18 +1049,20 @@ Object.assign(frappe.utils, {
return duration;
},
- seconds_to_dur... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-49874@f107079 | getsentry/sentry | Python | 49,874 | perf(issue-stream): Prefetch issue when hovering over title | Closes https://github.com/getsentry/sentry/issues/49236
This takes advantage of the preview tooltip which was already making a request to load the event. It does two things to that component:
1. Modifies the event request to look exactly like the one made on the issue details page
2. Adds a silent request for th... | 2023-05-26T19:35:48Z | Prefetch issue when hovering on title
We can load the issues page faster when navigating from the issue stream by beginning the request on hover. We already do this for the event (in order to preview the stacktrace), we just need to add the group details query as well.
There are two steps to doing this:
1. Add th... | [
{
"body": "We can load the issues page faster when navigating from the issue stream by beginning the request on hover. We already do this for the event (in order to preview the stacktrace), we just need to add the group details query as well.\r\n\r\nThere are two steps to doing this:\r\n\r\n1. Add the group que... | 88e48ceeac8a2ed9be8a78958f4f94cc87b55eb0 | {
"head_commit": "f10707903c4f5c8cfaf29ffcec237ed92616a2cc",
"head_commit_message": "perf(issue-stream): Prefetch issue when hovering over title",
"patch_to_review": "diff --git a/static/app/components/groupPreviewTooltip/evidencePreview.spec.tsx b/static/app/components/groupPreviewTooltip/evidencePreview.spec.ts... | [
{
"diff_hunk": "@@ -26,7 +29,7 @@ describe('StackTracePreview', () => {\n });\n \n render(\n- <StackTracePreview issueId=\"issue\" eventId=\"event_id\" projectSlug=\"project_slug\">\n+ <StackTracePreview groupId=\"group-id\" eventId=\"event_id\" projectSlug=\"project_slug\">",
"line": null... | 7dfa499aa80ea6422bed4daa333dd2bb295f591e | diff --git a/static/app/components/groupPreviewTooltip/evidencePreview.spec.tsx b/static/app/components/groupPreviewTooltip/evidencePreview.spec.tsx
index c1ec5d3479ec7e..e405f2d5d9aa2c 100644
--- a/static/app/components/groupPreviewTooltip/evidencePreview.spec.tsx
+++ b/static/app/components/groupPreviewTooltip/eviden... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
huggingface__text-generation-inference-1835@9410a79 | huggingface/text-generation-inference | Python | 1,835 | feat: move allocation logic to rust | Close #2007 | 2024-04-30T16:31:46Z | `CacheManager.allocate` is slow in the prefill when using large `num_blocks`
### System Info
TGI 2.0.4 through docker
### Information
- [X] Docker
- [ ] The CLI directly
### Tasks
- [X] An officially supported command
- [ ] My own modifications
### Reproduction
Hi,
As discussed internally `CacheManager.alloca... | [
{
"body": "### System Info\n\nTGI 2.0.4 through docker\n\n### Information\n\n- [X] Docker\n- [ ] The CLI directly\n\n### Tasks\n\n- [X] An officially supported command\n- [ ] My own modifications\n\n### Reproduction\n\nHi,\r\n\r\nAs discussed internally `CacheManager.allocate` brings a huge overhead with the de... | 757223b352896a9b2b9df46c95c0afcaa0cdf9d4 | {
"head_commit": "9410a79df4fcb5b009f030b86bc0401e90d5621f",
"head_commit_message": "rebased",
"patch_to_review": "diff --git a/Cargo.toml b/Cargo.toml\nindex 16dd942353e..552c0bffb30 100644\n--- a/Cargo.toml\n+++ b/Cargo.toml\n@@ -22,7 +22,12 @@ hf-hub = { version = \"0.3.1\", features = [\"tokio\"] }\n [profile... | [
{
"diff_hunk": "@@ -120,12 +135,14 @@ async fn queue_task(\n token_budget,\n response_sender,\n span,\n- } => span.in_scope(|| {\n- let next_batch =\n- state.next_batch(min_size, max_size, prefill_token_budget, token_bu... | 258ace7cd366d27f8750aaf6e283c15434257fcf | diff --git a/Cargo.toml b/Cargo.toml
index 16dd942353e..552c0bffb30 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -22,7 +22,12 @@ hf-hub = { version = "0.3.1", features = ["tokio"] }
[profile.release]
debug = 1
incremental = true
+panic = "abort"
+
+[profile.release-opt]
+inherits = "release"
+debug = 0
+incremental =... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
frappe__frappe-14358@2c9f089 | frappe/frappe | Python | 14,358 | feat: bulk rename allow merge option | This is more a limitation when using ERPNext Bulk Renaming tool.
This PR should close https://github.com/frappe/erpnext/issues/8790
**Previous Behavior**
If you attempted to merge a document using bulk rename tool you would get an error the target doc name already exists.
**After PR**
Uploader has option t... | 2021-10-04T18:50:45Z | Rename tool should have option to Merge with Existing
Hi,
The rename tool both in the bench and client side does not have an option to merge items.
Suppose if I want to rename 10 items to the same name then the only option left is to individually rename these items since rename tool cannot handle the situation wher... | Reference https://discuss.erpnext.com/t/is-there-a-bulk-item-merge-with-existing-functionality/20038/
+1
In frappe-bench/apps/frappe/frappe/model/rename_doc.py, **rename_doc** function call inside **bulk_rename** function needs to be changed.
Adding, `merge=row[2]` as a third parameter worked for me. And in the excel ... | [
{
"body": "Hi,\r\n\r\nThe rename tool both in the bench and client side does not have an option to merge items.\r\nSuppose if I want to rename 10 items to the same name then the only option left is to individually rename these items since rename tool cannot handle the situation where the name exists both in ben... | 46c5dc9d3f8a928e065f27032b42b217ef1ee9a6 | {
"head_commit": "2c9f08997a1e7b7ce46cea82e5fc8b2b2a583f96",
"head_commit_message": "Merge branch 'frappe:develop' into feat-bulk-rename-merge",
"patch_to_review": "diff --git a/frappe/model/rename_doc.py b/frappe/model/rename_doc.py\nindex 14f1dbf2b082..9377ad74f89f 100644\n--- a/frappe/model/rename_doc.py\n+++ ... | [
{
"diff_hunk": "@@ -471,8 +471,9 @@ def bulk_rename(doctype, rows=None, via_console = False):\n \tfor row in rows:\n \t\t# if row has some content\n \t\tif len(row) > 1 and row[0] and row[1]:\n+\t\t\tmerge = True if len(row) > 2 and (row[2] == \"1\" or row[2].lower() == \"true\") else False",
"line": null,
... | 12e4b33a1f8a9e66091f0531d19f50fff7dc649c | diff --git a/frappe/model/rename_doc.py b/frappe/model/rename_doc.py
index 14f1dbf2b082..de83b24cd8a6 100644
--- a/frappe/model/rename_doc.py
+++ b/frappe/model/rename_doc.py
@@ -458,7 +458,7 @@ def bulk_rename(doctype, rows=None, via_console = False):
"""Bulk rename documents
:param doctype: DocType to be rename... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
frappe__frappe-15891@ec9ae72 | frappe/frappe | Python | 15,891 | fix(doc)!: Always cast datetime, date and time fields | ### BREAKING CHANGE
#### Datetime, Date and Time fields will always be cast to respective objects in `setattr`, this will ensure uniformity while accessing the values, no more `getdate`, `get_datetime`, `to_timedelta` wrapper.
- While importing data, the framework does check for `set_only_once`.
- In normal case sce... | 2022-02-06T21:38:22Z | Data import fails on `set_only_once` fields
## Description of the issue
I'm trying to import ERPNext **Subscriptions** with **Data Import** Tool.
## Context information (for bug reports)
**Output of `bench version`**
```
ERPNext: v13.16.1 (version-13)
Frappe Framework: v13.16.0 (version-13)
```
## Steps... | [
{
"body": "## Description of the issue\r\n\r\nI'm trying to import ERPNext **Subscriptions** with **Data Import** Tool.\r\n\r\n## Context information (for bug reports)\r\n\r\n**Output of `bench version`**\r\n```\r\nERPNext: v13.16.1 (version-13)\r\nFrappe Framework: v13.16.0 (version-13)\r\n```\r\n\r\n## Steps ... | 9a03c535725ea066af5cd4b4f6316d01868876d1 | {
"head_commit": "ec9ae72c9a990c04e05e8891f4fe56c0ae2d001e",
"head_commit_message": "fix: handle Nonetype error",
"patch_to_review": "diff --git a/frappe/model/base_document.py b/frappe/model/base_document.py\nindex 8a81aa561015..fe4626511c28 100644\n--- a/frappe/model/base_document.py\n+++ b/frappe/model/base_do... | [
{
"diff_hunk": "@@ -1058,6 +1075,57 @@ def _extract_images_from_text_editor(self):\n \t\t\tfor df in self.meta.get(\"fields\", {\"fieldtype\": ('=', \"Text Editor\")}):\n \t\t\t\textract_images_from_doc(self, df.fieldname)\n \n+\tdef _cast_date_and_time_fields(self) -> None:\n+\t\t\"\"\"\n+\t\tConverts datetime... | 6930003b610a711b56476119b28734c3adf9ee0e | diff --git a/frappe/automation/doctype/assignment_rule/test_assignment_rule.py b/frappe/automation/doctype/assignment_rule/test_assignment_rule.py
index 2ab2e4d26394..12e7769ec07e 100644
--- a/frappe/automation/doctype/assignment_rule/test_assignment_rule.py
+++ b/frappe/automation/doctype/assignment_rule/test_assignme... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-49573@dd52a42 | getsentry/sentry | Python | 49,573 | fix(rulesnooze): Change default mute for integrations | this pr changes how we deal with muting alerts depending on their rule actions. we created 3 categories that an alert rule can fall into.
1. All the actions are the default (sentry.mail.actions.NotifyEmailAction)
2. Some of the actions are the default while some are other integrations (Slack, Jira, etc.)
3. All ... | 2023-05-22T20:08:41Z | Change default mute to mute for everyone if alert action is Slack
If you just click "mute" on the alert details page, the alert will be muted just for the user, as opposed to muted for everyone (which is in the dropdown). For alerts that have actions that directly go to a Slack channel or Slack user (e.g. "Send a notif... | [
{
"body": "If you just click \"mute\" on the alert details page, the alert will be muted just for the user, as opposed to muted for everyone (which is in the dropdown). For alerts that have actions that directly go to a Slack channel or Slack user (e.g. \"Send a notification to the {workspace} Slack workspace t... | b29182e5387ed3a1b1cb8b47e500ed8de8eafbd0 | {
"head_commit": "dd52a421fce66bdedd1a2f51952dc9c1603f0734",
"head_commit_message": "fix test",
"patch_to_review": "diff --git a/static/app/components/alerts/snoozeAlert.tsx b/static/app/components/alerts/snoozeAlert.tsx\nindex 4251d1fc1abd1c..e7316dc699b845 100644\n--- a/static/app/components/alerts/snoozeAlert.... | [
{
"diff_hunk": "@@ -141,22 +154,31 @@ function SnoozeAlert({isSnoozed, onSnooze, projectSlug, ruleId, hasAccess}: Prop\n size=\"sm\"\n icon={<IconSound />}\n disabled={disabled || !hasAccess}\n- onClick={() => handleMute('me')}\n+ hasDropdown={ruleActionCategory !== RuleAct... | 1028d362bec577321eb6b8377b641f51a8232022 | diff --git a/static/app/components/alerts/snoozeAlert.tsx b/static/app/components/alerts/snoozeAlert.tsx
index 4251d1fc1abd1c..66ca2b83e22309 100644
--- a/static/app/components/alerts/snoozeAlert.tsx
+++ b/static/app/components/alerts/snoozeAlert.tsx
@@ -8,6 +8,7 @@ import ButtonBar from 'sentry/components/buttonBar';
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
frappe__frappe-13065@dfc23eb | frappe/frappe | Python | 13,065 | fix: Evaluate boolean values better via /api/resource/<doctype> | `GET /api/resource/ToDo?limit=10&debug=False&as_dict=0` would be received by the resource handler as debug="False" and as_dict="0" which are both truthy values.
So, even though you requested for a list of lists response without debugging on, you'd get the exact opposite; debug on and a list of dicts.
- Evaluate b... | 2021-04-30T15:51:20Z | bug: is_root in tree view get_tree_nodes not parsed properly
## Description of the issue
When using the `get_tree_nodes` setting of the treeview for custom child behaviour, the `is_root` boolean parameter passed to python is not parsed from a string to boolean, but is passed to python as the string `true`
## Contex... | seems this pr https://github.com/frappe/frappe/pull/13065 handles this issue | [
{
"body": "## Description of the issue\r\nWhen using the `get_tree_nodes` setting of the treeview for custom child behaviour, the `is_root` boolean parameter passed to python is not parsed from a string to boolean, but is passed to python as the string `true`\r\n\r\n## Context information (for bug reports)\r\n\... | ed5ca19233dd2eea581b8d636db60ee8e664e82a | {
"head_commit": "dfc23eb3a3e42869430cf686a29f0b4188894618",
"head_commit_message": "fix(test): Set admin password correctly",
"patch_to_review": "diff --git a/frappe/api.py b/frappe/api.py\nindex 9039ae0e5fbf..c69f76a755c5 100644\n--- a/frappe/api.py\n+++ b/frappe/api.py\n@@ -11,6 +11,7 @@\n import frappe.handle... | [
{
"diff_hunk": "@@ -108,25 +109,39 @@ def handle():\n \n \t\t\telif doctype:\n \t\t\t\tif frappe.local.request.method == \"GET\":\n-\t\t\t\t\tif frappe.local.form_dict.get('fields'):\n-\t\t\t\t\t\tfrappe.local.form_dict['fields'] = json.loads(frappe.local.form_dict['fields'])\n-\t\t\t\t\tfrappe.local.form_dict.... | b215921a971e3b95ff6f93d63da3ffc70a10766f | diff --git a/frappe/api.py b/frappe/api.py
index 9039ae0e5fbf..6427cbfbd855 100644
--- a/frappe/api.py
+++ b/frappe/api.py
@@ -11,6 +11,7 @@
import frappe.handler
from frappe import _
from frappe.utils.response import build_response
+from frappe.utils.data import sbool
def handle():
@@ -108,25 +109,40 @@ def ha... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-49649@bad6c7a | getsentry/sentry | Python | 49,649 | feat(issue-states): Take issue age into account when issues are manually unarchived | Take issue age into account when issues are manually unarchived so that issues < 3 days old are marked as NEW
Fixes https://github.com/getsentry/sentry/issues/48761 | 2023-05-23T22:45:50Z | Unignoring an issue should revert to NEW or ONGOING
When an issue is unignored/unarchived, we should take the issue age into account and set the substatus to NEW or ONGOING accordingly (< 3 days = NEW).
These issues should also be added back into GroupInbox | [
{
"body": "When an issue is unignored/unarchived, we should take the issue age into account and set the substatus to NEW or ONGOING accordingly (< 3 days = NEW). \n\nThese issues should also be added back into GroupInbox",
"number": 48761,
"title": "Unignoring an issue should revert to NEW or ONGOING"
... | a363110ddceaf4982bce4932e4f1c98aade08bdd | {
"head_commit": "bad6c7aa2fb32fa077d780dcc0d93ca9ca7041aa",
"head_commit_message": "Add type:ignore",
"patch_to_review": "diff --git a/src/sentry/issues/escalating.py b/src/sentry/issues/escalating.py\nindex 3f1e92cb9fc56a..13aea667fd0abd 100644\n--- a/src/sentry/issues/escalating.py\n+++ b/src/sentry/issues/esc... | [
{
"diff_hunk": "@@ -343,20 +343,25 @@ def manage_issue_states(\n add_group_to_inbox(group, GroupInboxReason.ONGOING, snooze_details)\n record_group_history(group, GroupHistoryStatus.ONGOING)\n elif group_inbox_reason == GroupInboxReason.UNIGNORED:\n- updated = Group.objects.fi... | cea3090737a8c60f58a6ad4c15e1c3d5cbe8aad9 | diff --git a/src/sentry/api/helpers/group_index/update.py b/src/sentry/api/helpers/group_index/update.py
index a66998ef3e2939..857d32b2756078 100644
--- a/src/sentry/api/helpers/group_index/update.py
+++ b/src/sentry/api/helpers/group_index/update.py
@@ -1,6 +1,7 @@
from __future__ import annotations
from collectio... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
frappe__frappe-12405@ff9890e | frappe/frappe | Python | 12,405 | fix: make UI elements translatable | <!--
Some key notes before you open a PR:
1. Select which branch should this PR be merged in?
2. PR name follows [convention](http://karma-runner.github.io/4.0/dev/git-commit-msg.html)
3. All tests pass locally, UI and Unit tests
4. All business logic and validations must be on the server-side
5. Update ... | 2021-02-15T15:56:55Z | [bug] v13 develop make grid row Edit button, View List Select and global search result doctype translatable
version: V13 develop
__() not called for the following label which makes them not translatable.
1. The recently changed Edit button in Grid Row
grid_row.js line 232
this.open_form_button = $(`
<d... | [
{
"body": "version: V13 develop\r\n\r\n__() not called for the following label which makes them not translatable.\r\n\r\n1. The recently changed Edit button in Grid Row \r\n grid_row.js line 232\r\nthis.open_form_button = $(`\r\n\t\t\t\t\t<div class=\"btn-open-row\">\r\n\t\t\t\t\t\t<a>${frappe.utils.icon('edit... | 4efe2291c15ef5e47c85286a545ef82de405eb86 | {
"head_commit": "ff9890e88f9195c3817dc24ae438be4b10ff8b66",
"head_commit_message": "Update list_sidebar.html\n\nmake placeholder search translatable",
"patch_to_review": "diff --git a/frappe/public/js/frappe/form/grid_row.js b/frappe/public/js/frappe/form/grid_row.js\nindex 675cb6f77cab..2786ff1619a5 100644\n---... | [
{
"diff_hunk": "@@ -303,7 +303,7 @@ frappe.search.SearchDialog = class {\n \n \t\tlet $results_list = $(`<div class=\"results-summary\">\n \t\t\t<div class=\"result-section full-list ${type}-section col-sm-12\">\n-\t\t\t\t<div class=\"result-title\">${type}</div>\n+\t\t\t\t<div class=\"result-title\"> ` + __(ty... | 502991e8c84cc833fecabc26388d6e5ccd3c8674 | diff --git a/frappe/public/js/frappe/form/grid_row.js b/frappe/public/js/frappe/form/grid_row.js
index 675cb6f77cab..9fdd4a8e36c9 100644
--- a/frappe/public/js/frappe/form/grid_row.js
+++ b/frappe/public/js/frappe/form/grid_row.js
@@ -229,7 +229,7 @@ export default class GridRow {
this.open_form_button = $(`
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
frappe__frappe-11900@19a14d0 | frappe/frappe | Python | 11,900 | fix(quick entry): make sure init_callback is always called | Prior to this PR, as noted in issue #7638, it is not possible with
frappe.new_doc to initialize certain fields of the new document, such as the
description of a Task or the posting_date of a Journal Entry (in ERPNext).
The reason this occurs is that currently the route_options which can be set
in the seco... | 2020-11-09T04:02:14Z | [Bug] Cannot set Text Editor's content with frappe.new_doc()
Assume I have a DocType `Task` with these fields:
* `subject` (`Data`)
* `description` (`Text Editor`)
If I call the following in JavaScript, the new `Task`s `subject` will be set to "New task" but the `description` will be left blank.
```js
frappe.n... | This bug still exists in the current develop version. In our case, we are trying to add a custom button which will allow us to create a journal entry (of Voucher Type "Bank Entry") from a Bank Transaction document, and want to also fill in the posting_date (from the date of the Bank Transaction, and one Journal Entry A... | [
{
"body": "Assume I have a DocType `Task` with these fields:\r\n* `subject` (`Data`)\r\n* `description` (`Text Editor`)\r\n\r\nIf I call the following in JavaScript, the new `Task`s `subject` will be set to \"New task\" but the `description` will be left blank.\r\n\r\n```js\r\nfrappe.new_doc(\"Task\", {\"descri... | 44bc0dd81c567f0b6a6a72223caf4f6f2f98fb3f | {
"head_commit": "19a14d09e0dc872594fc5ae0f0be9505ee6e76d3",
"head_commit_message": "fix(quick entry): make sure init_callback is always called\n\n Prior to this PR, as noted in issue #7638, it is not possible with\n frappe.new_doc to initialize certain fields of the new document, such as the\n description of a ... | [
{
"diff_hunk": "@@ -35,7 +35,11 @@ frappe.ui.form.QuickEntryForm = Class.extend({\n \t\t\t\tif (this.is_quick_entry() || this.force) {\n \t\t\t\t\tthis.render_dialog();\n \t\t\t\t\tresolve(this);\n-\t\t\t\t} else {\n+\t\t\t\t} else { // No quick entry, use full Form\n+\t\t\t\t\t// but still give callback a shot... | 06fcb822054d364089646eb947b431180852a46f | diff --git a/frappe/public/js/frappe/form/quick_entry.js b/frappe/public/js/frappe/form/quick_entry.js
index 2da7b8f2364b..eed49e070b38 100644
--- a/frappe/public/js/frappe/form/quick_entry.js
+++ b/frappe/public/js/frappe/form/quick_entry.js
@@ -36,9 +36,14 @@ frappe.ui.form.QuickEntryForm = Class.extend({
this.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
frappe__frappe-11916@b52cfd1 | frappe/frappe | Python | 11,916 | fix: error on trying to check semantic version | The semantic version check fails if an app does not have any releases (in a fork, for example).
<hr>
**Traceback:**
```python
ValueError: Call either Version('1.2.3') or Version(major=1, ...).
File "rq/worker.py", line 793, in perform_job
rv = job.perform()
File "rq/job.py", line 599, in perform
... | 2020-11-11T09:28:22Z | error: frappe.utils.change_log.check_for_update
```
{'method_name': 'frappe.utils.change_log.check_for_update', 'log': <function log at 0x7f837e01f730>, 'retry': 0, 'is_async': True, 'user': 'Administrator', 'kwargs': {}, 'job_name': 'frappe.utils.change_log.check_for_update', 'event': 'daily_long', 'method': <functio... | [
{
"body": "```\r\n{'method_name': 'frappe.utils.change_log.check_for_update', 'log': <function log at 0x7f837e01f730>, 'retry': 0, 'is_async': True, 'user': 'Administrator', 'kwargs': {}, 'job_name': 'frappe.utils.change_log.check_for_update', 'event': 'daily_long', 'method': <function check_for_update at 0x7f8... | 64e80d7aa3025290e61d15795bf9d53b0c8c7bd0 | {
"head_commit": "b52cfd1903a050f0d3493f120d75f00c2d715168",
"head_commit_message": "fix: add git URL check",
"patch_to_review": "diff --git a/frappe/utils/change_log.py b/frappe/utils/change_log.py\nindex 29fee2bac024..75421c43ea7f 100644\n--- a/frappe/utils/change_log.py\n+++ b/frappe/utils/change_log.py\n@@ -1... | [
{
"diff_hunk": "@@ -182,32 +184,37 @@ def parse_latest_non_beta_release(response):\n \n \treturn None\n \n+\n def check_release_on_github(app):\n-\t# Check if repo remote is on github\n \tfrom subprocess import CalledProcessError\n+\n \ttry:\n+\t\t# Check if repo remote is on github\n \t\tremote_url = subproces... | 3e1f6c8103fd705c67968d5b1c9f46867af0ecd5 | diff --git a/frappe/utils/change_log.py b/frappe/utils/change_log.py
index 29fee2bac024..33801af72270 100644
--- a/frappe/utils/change_log.py
+++ b/frappe/utils/change_log.py
@@ -1,15 +1,17 @@
# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
# MIT License. See license.txt
-from __future__ import... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
huggingface__text-generation-inference-443@d0eaafd | huggingface/text-generation-inference | Python | 443 | Fix typo and use POSIX comparison in the makefile | # What does this PR do?
This PR fixes:
- The usage of non posix comparison which may fail depending on the shell used (`=` will always work, `==` only with bash)
- Typo in the env variable name displayed in the error message `BUILD_EXTENSION` instead of `BUILD_EXTENSIONS`
<!-- Remove if not applicable -->
Fi... | 2023-06-12T12:53:36Z | huggingface_hub.utils._validators.HFValidationError: Repo id must be in the form 'repo_name' or 'namespace/repo_name'
### System Info
V100 double 32G，centos8
ghcr.io/huggingface/text-generation-inference:0.8 python
### Information
- [X] Docker
- [ ] The CLI directly
### Tasks
- [X] An officially suppor... | no docker, only run cli is ok， command is `text-generation-launcher --model-id /data/bloom-560m --num-shard 2 --port 8080`
please help me，i'm crazzy....emm
> please help me，i'm crazzy....emm
This is not a discussion forum.
`/data/xxx` is a directory, you forgot to mount your drive on you docker run. | [
{
"body": "### System Info\r\nV100 double 32G，centos8\r\nghcr.io/huggingface/text-generation-inference:0.8 python \r\n\r\n### Information\r\n\r\n- [X] Docker\r\n- [ ] The CLI directly\r\n\r\n### Tasks\r\n\r\n- [X] An officially supported command\r\n- [ ] My own modifications\r\n\r\n### Reproduction\r\n\r\ndock... | d4eb60f48d22f4ae97acef4a239dccdf9549877d | {
"head_commit": "d0eaafdea6749d293cec415b03a9e5c6d083016f",
"head_commit_message": "Fix typo and use Posix comparison\n\nFixes #422",
"patch_to_review": "diff --git a/Makefile b/Makefile\nindex c7f649ecf73..c3c849cf3c9 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2,7 +2,7 @@ install-server:\n \tcd server && make ... | [
{
"diff_hunk": "@@ -2,7 +2,7 @@ install-server:\n \tcd server && make install\n \n install-custom-kernels:\n-\tif [ \"$$BUILD_EXTENSIONS\" == \"True\" ]; then cd server/custom_kernels && python setup.py install; else echo \"Custom kernels are disabled, you need set to BUILD_EXTENSION environment variable to 'Tr... | f550e49fcca5d28c67855100a9d883fbb11c28c1 | diff --git a/Makefile b/Makefile
index c7f649ecf73..3c2f2b9de19 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@ install-server:
cd server && make install
install-custom-kernels:
- if [ "$$BUILD_EXTENSIONS" == "True" ]; then cd server/custom_kernels && python setup.py install; else echo "Custom kernels are dis... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
frappe__frappe-9487@0322164 | frappe/frappe | Python | 9,487 | fix(base_list): Verify that filters are not undefined/empty. #9468 | Fixes an issue with empty filters in certain list views as referenced in #9467
## Explain the **details** for making this change. What existing problem does the pull request solve?
Certain lists in ERPNext reports create issues due to an insufficient handling of not defined or empty filters.
## Screenshots/GIFs... | 2020-02-17T17:09:06Z | setup filter area in base_list.js creates error on custom reports in erpnext due to missing argument
## Description of the issue
following lines in base_list.js create an error on certain lists created in ERPNext
```
setup_filter_area() {
this.filter_area = new FilterArea(this);
if (this.filters.length > 0)... | [
{
"body": "## Description of the issue\r\nfollowing lines in base_list.js create an error on certain lists created in ERPNext\r\n```\r\n\tsetup_filter_area() {\r\n\t\tthis.filter_area = new FilterArea(this);\r\n\r\n\t\tif (this.filters.length > 0) {\r\n\t\t\treturn this.filter_area.set(this.filters);\r\n\t\t}\r... | 630c85a9ccd2bfb78e7f5af6c7ca689a02aaa0b8 | {
"head_commit": "0322164ac1b1e310e44514f3e4b297f78f34ca90",
"head_commit_message": "fix(base_list): Verify that filters are not undefined/empty. #9468\n\nFixes an issue with empty filters in certain list views as referenced in #9467",
"patch_to_review": "diff --git a/frappe/public/js/frappe/list/base_list.js b/f... | [
{
"diff_hunk": "@@ -230,7 +230,7 @@ frappe.views.BaseList = class BaseList {\n \tsetup_filter_area() {\n \t\tthis.filter_area = new FilterArea(this);\n \n-\t\tif (this.filters.length > 0) {\n+\t\tif(this.filters && this.filters.length > 0) {",
"line": null,
"original_line": 233,
"original_start_line... | 777d3e2772a18eb241c74da086beb6fe12f8d17c | diff --git a/frappe/public/js/frappe/list/base_list.js b/frappe/public/js/frappe/list/base_list.js
index cbd0b1954caf..8ebbe216928b 100644
--- a/frappe/public/js/frappe/list/base_list.js
+++ b/frappe/public/js/frappe/list/base_list.js
@@ -230,7 +230,7 @@ frappe.views.BaseList = class BaseList {
setup_filter_area() {
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
frappe__frappe-11689@89f9725 | frappe/frappe | Python | 11,689 | refactor: Replace template syntax for translations | - Replace invalid translation syntax usages with the correct one. (Template strings in translation strings are invalid)
- Updated translation linter to warn about template string as invalid syntax.
- Now linter checks for correctness of syntax if the string starts with the following substrings
<img width="247" al... | 2020-10-12T06:08:03Z | Translation Tool does not pick up ``-denoted strings
There are about 180 translatable strings in the javascript files of frappe and erpnext that use this notation (with ``):
```
__(`Translate me!`)
```
However the translation tool does not pick them up. It seems to look only for strings like `__('Translate me!... | [
{
"body": "There are about 180 translatable strings in the javascript files of frappe and erpnext that use this notation (with ``): \r\n\r\n```\r\n__(`Translate me!`)\r\n```\r\n\r\nHowever the translation tool does not pick them up. It seems to look only for strings like `__('Translate me!')` or `__(\"Translate... | e16a49f496d695f831217ad2e5eb0c7552cbc590 | {
"head_commit": "89f97257ddd97b46c3046de12fbaad7d685e5479",
"head_commit_message": "fix: Replace incorrect translation syntax usages",
"patch_to_review": "diff --git a/.github/helper/translation.py b/.github/helper/translation.py\nindex 5d33355a1b17..ee04de916180 100644\n--- a/.github/helper/translation.py\n+++ ... | [
{
"diff_hunk": "@@ -21,13 +19,12 @@ frappe.ui.form.ControlDynamicLink = frappe.ui.form.ControlLink.extend({\n \t\t\tif (input) {\n \t\t\t\toptions = input.val();\n \t\t\t}\n-\t\t}\n-\t\telse {\n+\t\t} else {\n \t\t\toptions = frappe.model.get_value(this.df.parent, this.docname, this.df.options);\n \t\t}\n \n \t... | 198e25571025ce8f47cd47850bc835436e86c689 | diff --git a/.github/helper/translation.py b/.github/helper/translation.py
index 5d33355a1b17..ee04de916180 100644
--- a/.github/helper/translation.py
+++ b/.github/helper/translation.py
@@ -3,7 +3,7 @@
errors_encounter = 0
pattern = re.compile(r"_\(([\"']{,3})(?P<message>((?!\1).)*)\1(\s*,\s*context\s*=\s*([\"'])(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
frappe__frappe-6055@6f7faad | frappe/frappe | Python | 6,055 | file-api: migrate file api | Migrated file doctype APIs to files.py for streamlined access
closes #2800
adds changes to the way file api functions. For example:
### Pythonic Way
The old call to save a file would require one to do the following:
```py
f = save_file(filename, filedata, doctype, docname,
folder, decode... | 2018-09-05T14:05:11Z | Feature Idea: File manager API
## Introduction
Frappe apps, notably ERPnext, use an internal database to save attached files to documents. This system serves it's purpose well and allows many users to attach files that need to be available to other users. However, more advanced document management requires users to ... | This could be : `/api/file/{filename}` similar to `/api/resource/{doctype}`
Edit: Happy to help if you want to work on it.
I think that would be a good api endpoint. Like I mentioned, my python is not sufficiently advanced to work on this alone, but I could help someone more advanced get to the end result!
> On Mar... | [
{
"body": "## Introduction\r\n\r\nFrappe apps, notably ERPnext, use an internal database to save attached files to documents. This system serves it's purpose well and allows many users to attach files that need to be available to other users. However, more advanced document management requires users to manually... | 28b909435320e3d6d1a3b2e7c02f286984dc39b3 | {
"head_commit": "6f7faad0ecd5efaf3431ae0058fc4b1204c909d1",
"head_commit_message": "file-api: add save test for base64 encoded file\n\nSigned-off-by: Chinmay Pai <chinmaydpai@gmail.com>",
"patch_to_review": "diff --git a/frappe/client.py b/frappe/client.py\nindex 454b0a79e188..0be029599adf 100644\n--- a/frappe/c... | [
{
"diff_hunk": "@@ -265,14 +264,22 @@ def attach_file_to_doc(doctype, docname, file_url):\n \t\t\t# file is already attached\n \t\t\treturn\n \n-\t\tsave_url(file_url, None, doctype, docname, \"Home/Attachments\", 0)\n+\t\t_file = frappe.get_doc({\n+\t\t\t\"doctype\": \"File\",\n+\t\t\t\"file_url\": file_url,\n... | 37290376125a0b5b67779200469c765ae68bb7d4 | diff --git a/frappe/client.py b/frappe/client.py
index 454b0a79e188..0be029599adf 100644
--- a/frappe/client.py
+++ b/frappe/client.py
@@ -9,7 +9,6 @@
import json, os
from six import iteritems, string_types, integer_types
-from frappe.utils.file_manager import save_file
'''
Handle RESTful requests that are mapp... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-48638@3d4de3a | getsentry/sentry | Python | 48,638 | feat(replays): Analytics for open/close Replay>Network>Details panel | Fixes https://github.com/getsentry/sentry/issues/47835 | 2023-05-05T17:16:45Z | [Success Metrics] Add analytics for engagement related to the network details panel req/resp
Log steps in the funnel:
- Clicking on the CTA
- Setting up new SDK
- Setting up allow-list of bodies and/or headers
- Clicking on the network panel and seeing bodies and/or headers
Jasmin's Notes:
I'd like to see the follow... | [
{
"body": "Log steps in the funnel:\n\n- Clicking on the CTA\n- Setting up new SDK\n- Setting up allow-list of bodies and/or headers\n- Clicking on the network panel and seeing bodies and/or headers\n\nJasmin's Notes:\n\nI'd like to see the following steps in the funnel:\n\n1. Click on the Network tab (we alre... | f099ab2e7723d6bb828aab4508c5a2b1d60bb9cf | {
"head_commit": "3d4de3ac37011bb22646c13472729e8437395722",
"head_commit_message": "update field names",
"patch_to_review": "diff --git a/static/app/utils/analytics/replayAnalyticsEvents.tsx b/static/app/utils/analytics/replayAnalyticsEvents.tsx\nindex 8fb0061c964a52..e3ce57cd4afccd 100644\n--- a/static/app/util... | [
{
"diff_hunk": "@@ -1,10 +1,28 @@\n import type {LayoutKey} from 'sentry/utils/replays/hooks/useReplayLayout';\n+import {Output} from 'sentry/views/replays/detail/network/details/getOutputType';\n \n export type ReplayEventParameters = {\n 'replay.details-layout-changed': {\n chosen_layout: LayoutKey;\n ... | 6bc0fecb0dfd377d069d830738fb4a9b637282b9 | diff --git a/static/app/utils/analytics/replayAnalyticsEvents.tsx b/static/app/utils/analytics/replayAnalyticsEvents.tsx
index 8fb0061c964a52..6818d7b455766e 100644
--- a/static/app/utils/analytics/replayAnalyticsEvents.tsx
+++ b/static/app/utils/analytics/replayAnalyticsEvents.tsx
@@ -1,10 +1,28 @@
import type {Layou... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
frappe__frappe-5598@15a8749 | frappe/frappe | Python | 5,598 | Workflow actions | 
Closes : https://github.com/frappe/frappe/issues/5391, https://github.com/frappe/frappe/issues/5553
| 2018-05-23T10:18:19Z | Workflow Action
### Motivation
The user has created workflows on various transactions like leaves, purchase orders etc. There may be multiple users who need to approve and there are multiple stages of approval. The goal is to facilitate communication to the users via email and also create a list of pending actions. ... | This is awesome
@rmehta Possibly add an "expected time to complete by" and "importance level 1-5" for tasks.
There are 2 benefits -
1. Easy prioritization of tasks for user
2. Useful for HR department/managers to review on-time/delays in completion of tasks
I have implemented most functionality,
I will make pr at... | [
{
"body": "### Motivation\r\n\r\nThe user has created workflows on various transactions like leaves, purchase orders etc. There may be multiple users who need to approve and there are multiple stages of approval. The goal is to facilitate communication to the users via email and also create a list of pending ac... | c4e8482da080304b45cd5edb61c3163adc97f7e6 | {
"head_commit": "15a87498f128e42f244e387f935ba2844481142e",
"head_commit_message": "Fix incorrect 'this' reference",
"patch_to_review": "diff --git a/frappe/core/notifications.py b/frappe/core/notifications.py\nindex f156bb9e5a4e..d4111b77b5f7 100644\n--- a/frappe/core/notifications.py\n+++ b/frappe/core/notific... | [
{
"diff_hunk": "@@ -3,8 +3,164 @@\n \n from __future__ import unicode_literals\n import frappe\n-\n from frappe.model.document import Document\n+from frappe.core.page.permission_manager.permission_manager import get_users_with_role\n+from frappe.utils.background_jobs import enqueue\n+from frappe.utils import ge... | 0e6d6acd9d875ba6e25551cb4845073f1cb0871b | diff --git a/frappe/core/notifications.py b/frappe/core/notifications.py
index f156bb9e5a4e..d4111b77b5f7 100644
--- a/frappe/core/notifications.py
+++ b/frappe/core/notifications.py
@@ -12,6 +12,7 @@ def get_notification_config():
"ToDo": "frappe.core.notifications.get_things_todo",
"Event": "frappe.core.notif... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
frappe__frappe-5587@e126fa8 | frappe/frappe | Python | 5,587 | [fix] linked with if there are multiple link field in the same doctype | Fixes https://github.com/frappe/erpnext/issues/13371 | 2018-05-22T13:28:08Z | Linked With enhancements
If we make Sales Return against an Invoice, system does not show return entry while checking "Linked With" on original invoice.
Hint: Invoice has 2 link field with option "Sales Invoice", one gets overwritten while creating a dict {'dt': fname}.
It should be fixed in develop branch becaus... | [
{
"body": "If we make Sales Return against an Invoice, system does not show return entry while checking \"Linked With\" on original invoice.\r\n\r\nHint: Invoice has 2 link field with option \"Sales Invoice\", one gets overwritten while creating a dict {'dt': fname}.\r\n\r\nIt should be fixed in develop branch ... | 06851e7376d729d756fa6e3dafd34911c39f56ec | {
"head_commit": "e126fa86e60c018d968982c9567b4768ee41cebc",
"head_commit_message": "[fix] linked with if there are multiple link field in the same doctype",
"patch_to_review": "diff --git a/frappe/desk/form/linked_with.py b/frappe/desk/form/linked_with.py\nindex f246839857a2..62dce74ae4a6 100644\n--- a/frappe/de... | [
{
"diff_hunk": "@@ -61,21 +64,23 @@ def get_linked_docs(doctype, name, linkinfo=None, for_doctype=None):\n \t\t\t\t\t\tret = None\n \n \t\t\t\telif link.get(\"child_doctype\"):\n-\t\t\t\t\tfilters = [[link.get('child_doctype'), link.get(\"fieldname\"), '=', name]]\n+\t\t\t\t\tor_filters = [[link.get('child_doct... | 621845a4c72b56db19bba419c74d079409982daa | diff --git a/frappe/desk/form/linked_with.py b/frappe/desk/form/linked_with.py
index f246839857a2..13fe3fd31074 100644
--- a/frappe/desk/form/linked_with.py
+++ b/frappe/desk/form/linked_with.py
@@ -8,6 +8,8 @@
import frappe.desk.form.meta
import frappe.desk.form.load
from six import string_types
+from collections i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-49140@8cbd395 | getsentry/sentry | Python | 49,140 | perf(issue-details): cache group details response | this pr adds in caching for the group details response on the issue details page. there are a couple changes being made to make this happen. first, the response will be cached (similar to how we are caching event details). to make this work, right now we are syncing the useApiQuery cache and GroupStore so they are the ... | 2023-05-15T20:50:44Z | Cache group release endpoint
The way we are calling the `/issues/<group_id>/first-last-release` endpoint can be improved in a few ways:
1. Only fetch once when loading the issue. Right now the value is being refetched when scrolling through events, which is not necessary.
2. Cache the response
3. Fetch in parallel... | [
{
"body": "The way we are calling the `/issues/<group_id>/first-last-release` endpoint can be improved in a few ways:\r\n\r\n1. Only fetch once when loading the issue. Right now the value is being refetched when scrolling through events, which is not necessary.\r\n2. Cache the response\r\n3. Fetch in parallel w... | c3b15d7b5167602d77b9899700b853b4188cd8a0 | {
"head_commit": "8cbd395d46c318185f5d0dfc5b985f3dff7fbf6b",
"head_commit_message": "fix issue with project query",
"patch_to_review": "diff --git a/static/app/views/issueDetails/groupDetails.tsx b/static/app/views/issueDetails/groupDetails.tsx\nindex 8b65f67eb5ae06..4a4ebba1ad748e 100644\n--- a/static/app/views/... | [
{
"diff_hunk": "@@ -284,13 +317,9 @@ function useFetchGroupDetails({\n const organization = useOrganization();\n const router = useRouter();\n const params = router.params;\n- const location = useLocation();\n const {projects} = useProjects();\n- const allGroups = useLegacyStore(GroupStore);\n- const... | 46de64eeeb9d3d5a3cf791af8cdf11eb310591ee | diff --git a/static/app/views/issueDetails/groupDetails.tsx b/static/app/views/issueDetails/groupDetails.tsx
index 8b65f67eb5ae06..ace5f9683eed19 100644
--- a/static/app/views/issueDetails/groupDetails.tsx
+++ b/static/app/views/issueDetails/groupDetails.tsx
@@ -4,11 +4,13 @@ import {
isValidElement,
useCallback,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
frappe__frappe-5107@07799d2 | frappe/frappe | Python | 5,107 | List view bulk edit option | Fixes https://github.com/frappe/erpnext/issues/3191
| 2018-03-01T09:33:16Z | Multiple Cancellation/Assignment/Submit Required
I have one suggestion that there should be a way by which user can cancel/assign/submit multiple documents in one go.
Like for e.g., I have 200 Material Request and I want to cancel all therefore as per current feature I have to open each and everyone and press cancel b... | It's common practice in business environments to review documents (Expense Claims, Journal Vouchers, Orders etc) in batches for approval. It would greatly help to have a Bulk Submit feature for scenarios like this. There is already a feature to Delete documents in bulk from the List View. This should be extended to Sub... | [
{
"body": "I have one suggestion that there should be a way by which user can cancel/assign/submit multiple documents in one go.\n\nLike for e.g., I have 200 Material Request and I want to cancel all therefore as per current feature I have to open each and everyone and press cancel button.\n\nMy opinion is syst... | f5a6e22e82d40a17910d62f5bf23a783933a2a30 | {
"head_commit": "07799d2e26e4bb775e0b092f80c9b76775738cd7",
"head_commit_message": "Refactor\n\ncommonified redundant method\nget_json -> parse_json",
"patch_to_review": "diff --git a/frappe/__init__.py b/frappe/__init__.py\nindex 7778068fc095..e03650aa93c0 100644\n--- a/frappe/__init__.py\n+++ b/frappe/__init__... | [
{
"diff_hunk": "@@ -119,19 +119,27 @@ frappe.ui.form.Layout = Class.extend({\n \t\t});\n \t},\n \n-\tmake_field: function(df, colspan, render = false) {\n+\tchange_df: function(fieldname, df, render) {",
"line": null,
"original_line": 122,
"original_start_line": null,
"path": "frappe/public/js/f... | a73d2e8c7ee0201affaa604d638afc4473f5e27f | diff --git a/frappe/__init__.py b/frappe/__init__.py
index 7778068fc095..e03650aa93c0 100644
--- a/frappe/__init__.py
+++ b/frappe/__init__.py
@@ -1468,4 +1468,8 @@ def get_version(doctype, name, limit = None, head = False, raise_err = True):
@whitelist(allow_guest = True)
def ping():
- return "pong"
\ No newline a... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-47157@5a423ce | getsentry/sentry | Python | 47,157 | feat(trace): Update trace details to include performance issues | - This updates the trace details to include performance issues
- Also fix an issue where the transaction wasn't turning red if its only issue was a performance one
- CLoses: https://github.com/getsentry/sentry/issues/45778
![image](https://user-images.githubusercontent.com/4205004/231217615-ad4bc677-4c82-46d2-8f26... | 2023-04-11T15:47:22Z | Update the Event Breakdown to include Performance Issues
The Event Breakdown at the top of the trace view, currently shows the count of errors & transactions. It should also show the count of performance issues.
Check with design, there was a discussion here about having a list of all the performance issues on the pag... | [
{
"body": "The Event Breakdown at the top of the trace view, currently shows the count of errors & transactions. It should also show the count of performance issues.\n\nCheck with design, there was a discussion here about having a list of all the performance issues on the page as well.",
"number": 45778,
... | ea5a2cf79b420dcb4d97c48dd551479f303d1478 | {
"head_commit": "5a423cea309fee8d7abc502c802cc689c91bab67",
"head_commit_message": "fix: typing",
"patch_to_review": "diff --git a/static/app/utils/performance/quickTrace/types.tsx b/static/app/utils/performance/quickTrace/types.tsx\nindex 5f46f092112f5d..1139724624a02f 100644\n--- a/static/app/utils/performance... | [
{
"diff_hunk": "@@ -176,21 +176,24 @@ class TraceDetailsContent extends Component<Props, State> {\n \n renderTraceHeader(traceInfo: TraceInfo) {\n const {meta} = this.props;\n+ const errors = meta?.errors ?? traceInfo.errors.size;\n+ const performanceIssues =\n+ meta?.performance_issues ?? trac... | 21f5c4f0e59f12dd46958a27cf985359c48c3c24 | diff --git a/static/app/utils/performance/quickTrace/types.tsx b/static/app/utils/performance/quickTrace/types.tsx
index 5f46f092112f5d..1139724624a02f 100644
--- a/static/app/utils/performance/quickTrace/types.tsx
+++ b/static/app/utils/performance/quickTrace/types.tsx
@@ -118,6 +118,7 @@ export type QuickTraceQueryCh... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-46706@030a5da | getsentry/sentry | Python | 46,706 | feat(issue-details): Add analytics events for issue tracking | Closes https://github.com/getsentry/sentry/issues/46422 | 2023-03-31T20:26:34Z | Track external issues being created
We have no analytics for a user creating an external issue (ex: Jira). We should add the following analytics events to the front-end:
* integrations.external_issue_modal_opened
* integrations.external_issue_created
We need to make sure to record the `provider`, `group_id`, and `pro... | [
{
"body": "We have no analytics for a user creating an external issue (ex: Jira). We should add the following analytics events to the front-end:\n\n* integrations.external_issue_modal_opened\n* integrations.external_issue_created\n\nWe need to make sure to record the `provider`, `group_id`, and `project_id`.\n"... | 4d6cb0bec3c9598bee4cd14f02ba27459787b673 | {
"head_commit": "030a5dae6ba252b638ae925a90221fc7477b5111",
"head_commit_message": "feat(issue-details): Add analytics events for issue tracking",
"patch_to_review": "diff --git a/static/app/components/group/externalIssueActions.tsx b/static/app/components/group/externalIssueActions.tsx\nindex 5a10557a2ac2fc..69... | [
{
"diff_hunk": "@@ -15,6 +15,11 @@ type SourceMapDebugParam = {\n \n interface GroupEventParams extends CommonGroupAnalyticsData, BaseEventAnalyticsParams {}\n \n+interface ExternalIssueParams extends CommonGroupAnalyticsData {\n+ external_issue_provider: string;\n+ external_issue_type: 'plugin' | 'integratio... | 7b6e710bfb05bfea81279c232d13c23c513aa503 | diff --git a/static/app/components/group/externalIssueActions.tsx b/static/app/components/group/externalIssueActions.tsx
index 5a10557a2ac2fc..7988ba7eeb0fda 100644
--- a/static/app/components/group/externalIssueActions.tsx
+++ b/static/app/components/group/externalIssueActions.tsx
@@ -8,7 +8,10 @@ import IssueSyncList... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-46447@a08c5c7 | getsentry/sentry | Python | 46,447 | feat: Add base config for JS loader with performance/replay | This PR adjusts the loader to include default config when enabling debug/performance/replay.
We should probably do a bit more testing etc. for this, as this is not really covered well as of now.
I did some tests locally with different scenarios, where stuff worked well, as far as I can tell.
## Lazy mode
Lazy... | 2023-03-28T14:31:27Z | JS Loader: Sentry.init should be called - with defaults from docs for Performance/Replay
As the title says, the goal should be that someone should be able to just paste the `<script/>` tag and without any manual calls to `Sentry.init` get the experience using it.
That means, for example, pageload transactions and Repl... | Routing to @getsentry/team-web-sdk-frontend for [triage](https://develop.sentry.dev/processing-tickets/#3-triage), due by **<time datetime=2023-03-29T00:00:00.000Z>Tuesday, March 28th at 5:00 pm</time> (sfo)**. ⏲️
So, I think I have the loader stuff working (locally) now. However, IMHO it would be great to have some ki... | [
{
"body": "As the title says, the goal should be that someone should be able to just paste the `<script/>` tag and without any manual calls to `Sentry.init` get the experience using it.\r\nThat means, for example, pageload transactions and Replays are automatically captured when Performance and/or Replay is ena... | 9ccf1e176f4d03e466ad0476d1726e1fb178827e | {
"head_commit": "a08c5c7f4f62222ce45aed6d9ca38bd133c231e1",
"head_commit_message": "fix loader for performance to v7",
"patch_to_review": "diff --git a/src/sentry/templates/sentry/js-sdk-loader.js.tmpl b/src/sentry/templates/sentry/js-sdk-loader.js.tmpl\nindex aee842cba6b899..8e933c5387b44b 100644\n--- a/src/sen... | [
{
"diff_hunk": "@@ -108,9 +122,21 @@ def _get_context(\n except TypeError:\n sdk_url = \"\" # It fails if it cannot inject the version in the string\n \n+ config: SdkConfig = {\"dsn\": key.dsn_public}\n+\n+ if has_debug:\n+ config[\"debug\"] = True\n+\n+ if h... | 6d3ef015ffdda0178c24d3db3a268e08df797e1c | diff --git a/src/sentry/templates/sentry/js-sdk-loader.js.tmpl b/src/sentry/templates/sentry/js-sdk-loader.js.tmpl
index aee842cba6b899..8e933c5387b44b 100644
--- a/src/sentry/templates/sentry/js-sdk-loader.js.tmpl
+++ b/src/sentry/templates/sentry/js-sdk-loader.js.tmpl
@@ -67,11 +67,15 @@
_newScriptTag.crossOrigi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-46095@c8e02c5 | getsentry/sentry | Python | 46,095 | feat(replay): Add a breadcrumb for `replay.mutations` | This breadcrumb is sent when we detect a large number of mutations (currently 500, but will be increased). This *can* have an impact on end users. We want to start with a breadcrumb first and then eventually be more proactive about skipping processing of mutations.
. This can slow down the Replay SDK ... | [
{
"body": "We should show a better UI for breadcrumbs with category `replay.mutations`. There is a count of the # of mutations that will be processed in `data.count`.\n\nIcon = warning?\nTitle = Replay\nDescription = A large mutation has been detected (data.count). This can slow down the Replay SDK and impact y... | 8aae75842cfe26f1aed3eb63a20b20397c5a008e | {
"head_commit": "c8e02c54f5ab2fd8e87dea09c5a05a79ff9cc3bb",
"head_commit_message": "use t()",
"patch_to_review": "diff --git a/static/app/components/replays/breadcrumbs/utils.tsx b/static/app/components/replays/breadcrumbs/utils.tsx\nindex e6b6e54a7d6327..d696e4da27ff98 100644\n--- a/static/app/components/replay... | [
{
"diff_hunk": "@@ -3,17 +3,23 @@ import {IconWarning} from 'sentry/icons';\n import {t} from 'sentry/locale';\n import {BreadcrumbType, Crumb} from 'sentry/types/breadcrumbs';\n \n+// Replay SDK can send `data` that does not conform to our issue/event breadcrumbs\n+type MaybeCrumbData = null | Record<string, u... | 2d257e0ceeb365b9641f3707ccf648cbca0da9d8 | diff --git a/static/app/components/replays/breadcrumbs/utils.tsx b/static/app/components/replays/breadcrumbs/utils.tsx
index e6b6e54a7d6327..fb9fb543995f0e 100644
--- a/static/app/components/replays/breadcrumbs/utils.tsx
+++ b/static/app/components/replays/breadcrumbs/utils.tsx
@@ -3,17 +3,23 @@ import {IconWarning} fr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.