instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
getsentry__sentry-43924@b2f4e4e | getsentry/sentry | Python | 43,924 | feat(ingest): Add exception metrics to event_manager and post_process_group | Adds exception metrics to be used in Issue Platform upcoming SLOs | 2023-01-31T22:18:58Z | Make ingestor fault tolerant and production ready
Right now we haven't done a comprehensive overview of metrics and error handling for the ingestor (and associated pipeline steps like `post_process` and `eventstream`). We should:
1. Ensure metric consistency in our new ingestor pipeline with our current processing pip... | Need to add more metrics to understand amount of load. Logging is in a decent place
Need to make SLOs for events and transactions as well
https://www.notion.so/sentry/SLO-Update-Q4-FY23-3a100322fcd945528e4d58e89e339379 | [
{
"body": "Right now we haven't done a comprehensive overview of metrics and error handling for the ingestor (and associated pipeline steps like `post_process` and `eventstream`). We should:\r\n1. Ensure metric consistency in our new ingestor pipeline with our current processing pipeline\r\n2. Make sure that al... | 5237fecf3259af8b7400af6c0cef715cd2359f39 | {
"head_commit": "b2f4e4ef04844ce9f6b50ea54466d05ea590da24",
"head_commit_message": "re-raise exception",
"patch_to_review": "diff --git a/src/sentry/tasks/post_process.py b/src/sentry/tasks/post_process.py\nindex 8d1f959a54bdb6..f1ecc27e21d9b3 100644\n--- a/src/sentry/tasks/post_process.py\n+++ b/src/sentry/task... | [
{
"diff_hunk": "@@ -448,6 +448,10 @@ def run_post_process_job(job: PostProcessJob):\n try:\n pipeline_step(job)\n except Exception:\n+ metrics.incr(\n+ \"sentry.tasks.post_process.post_process_group.exception\",\n+ tags={\"issue_category\": gr... | 9c6bc0868694dd18452878302862a1c3ff0ea42e | diff --git a/src/sentry/tasks/post_process.py b/src/sentry/tasks/post_process.py
index 8d1f959a54bdb6..d94ab9c79d4ee1 100644
--- a/src/sentry/tasks/post_process.py
+++ b/src/sentry/tasks/post_process.py
@@ -437,17 +437,23 @@ def post_process_group(
def run_post_process_job(job: PostProcessJob):
group_event = jo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
getsentry__sentry-46129@efe22bd | getsentry/sentry | Python | 46,129 | feat(view-hierarchy): Add Dart plugin to handle deobfuscation | Adds a new plugin to handle deobfuscation. Since we don't currently have the debug files saved in Sentry, this code is awaiting future changes in Sentry CLI and the SDK to begin uploading the file, at which point we can further validate if this needs any updates and roll it out to customers.
I've made the assumption... | 2023-03-21T17:29:21Z | Add deobfuscation code to handle Flutter debug file
We don't currently have support to upload a build artifact that allows us to map obfuscated widget names back to deobfuscated versions (generated by adding `--extra-gen-snapshot-options=--obfuscate,--save-obfuscation-map=build/symbols.json`), but we can still add the ... | Routing to @getsentry/team-mdx for [triage](https://develop.sentry.dev/processing-tickets/#3-triage), due by **<time datetime=2023-03-22T14:03:28.153Z>Wednesday, March 22nd at 10:03</time> (yyz)**. ⏲️ | [
{
"body": "We don't currently have support to upload a build artifact that allows us to map obfuscated widget names back to deobfuscated versions (generated by adding `--extra-gen-snapshot-options=--obfuscate,--save-obfuscation-map=build/symbols.json`), but we can still add the code to handle such a mapping so ... | dda39f6b7a00ad8dab967ddf7a558a1305d22e2f | {
"head_commit": "efe22bda114baf181917ac792323c75df45e13ee",
"head_commit_message": "Add missing r to regex compile string\n\nIt seems like this is the convention",
"patch_to_review": "diff --git a/src/sentry/lang/dart/__init__.py b/src/sentry/lang/dart/__init__.py\nnew file mode 100644\nindex 00000000000000..e69... | [
{
"diff_hunk": "@@ -0,0 +1,110 @@\n+import os\n+import re\n+\n+import sentry_sdk\n+\n+from sentry.eventstore.models import Event\n+from sentry.lang.java.utils import deobfuscation_template\n+from sentry.models import Project, ProjectDebugFile\n+from sentry.utils import json\n+from sentry.utils.safe import get_p... | 5b42df229549c7c2f961f7ff4e6a7c114249795f | diff --git a/src/sentry/lang/dart/__init__.py b/src/sentry/lang/dart/__init__.py
new file mode 100644
index 00000000000000..e69de29bb2d1d6
diff --git a/src/sentry/lang/dart/apps.py b/src/sentry/lang/dart/apps.py
new file mode 100644
index 00000000000000..96b2afc49567dc
--- /dev/null
+++ b/src/sentry/lang/dart/apps.py
@... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-43864@0e18317 | getsentry/sentry | Python | 43,864 | feat(view-hierarchy): Render wireframe | Takes a view hierarchy and renders a wireframe using the x, y, width, and height coordinates using canvas. The canvas should also resize to fit its space (e.g. when the window narrows) without distorting the rendering.
When calculating the coordinates for each node, we have to take into account the position of its p... | 2023-01-31T00:02:50Z | Add a wireframe view to view hierarchies
Using the x, y, width, and height of a view hierarchy window we can reconstruct the view. This should be a bunch of overlayed rectangles and the user should be able to hover over elements and select an element to see more data about that. | The hovering and selecting will be part of #43875 | [
{
"body": "Using the x, y, width, and height of a view hierarchy window we can reconstruct the view. This should be a bunch of overlayed rectangles and the user should be able to hover over elements and select an element to see more data about that.",
"number": 43320,
"title": "Add a wireframe view to v... | 6f32a56f8a19b2f673540e1da5733c50a49b8ddf | {
"head_commit": "0e1831710f8157f5875dfcdaf0c16c9659818c2b",
"head_commit_message": "Merge branch 'master' into nar/feat/view-hierarchy-render-as-wireframe",
"patch_to_review": "diff --git a/static/app/components/events/viewHierarchy/detailsPanel.tsx b/static/app/components/events/viewHierarchy/detailsPanel.tsx\n... | [
{
"diff_hunk": "@@ -0,0 +1,146 @@\n+import {useCallback, useEffect, useMemo, useRef, useState} from 'react';\n+import styled from '@emotion/styled';\n+import {useResizeObserver} from '@react-aria/utils';\n+\n+import {ViewHierarchyWindow} from 'sentry/components/events/viewHierarchy';\n+import {useMousePan} from... | ca828e4b8131b8327707cb447bf64c070f89fbcf | diff --git a/static/app/components/events/viewHierarchy/detailsPanel.tsx b/static/app/components/events/viewHierarchy/detailsPanel.tsx
index 181f82ea8a04ec..9a7095c83d8dc0 100644
--- a/static/app/components/events/viewHierarchy/detailsPanel.tsx
+++ b/static/app/components/events/viewHierarchy/detailsPanel.tsx
@@ -36,11... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-45409@1cf2fd4 | getsentry/sentry | Python | 45,409 | feat(replays): Link from Replay Details tags to replay search results for the tag value | Fixes #44463
| 2023-03-04T00:29:05Z | [Replay Details] Make tags clickable and bring you back to the index page
### Problem Statement
On the Replay Details tag tab, would be cool if you clicked on a tab and it brough you to the index page with a search filter prefilled on the tag. may need to handle array fields in a clean way but should be straightforwa... | [
{
"body": "### Problem Statement\n\nOn the Replay Details tag tab, would be cool if you clicked on a tab and it brough you to the index page with a search filter prefilled on the tag. may need to handle array fields in a clean way but should be straightforward\n\n### Solution Brainstorm\n\n_No response_",
"... | 33dabb730c9bcf69f44cb9923afa71ff2be48660 | {
"head_commit": "1cf2fd403a28a1052d5d2639bb63fe3a556757dd",
"head_commit_message": "feat(replays): Link from Replay Details tags to replay search results for the tag value",
"patch_to_review": "diff --git a/static/app/components/replays/replayTagsTableRow.spec.tsx b/static/app/components/replays/replayTagsTableR... | [
{
"diff_hunk": "@@ -7,12 +9,26 @@ import Placeholder from 'sentry/components/placeholder';\n import {useReplayContext} from 'sentry/components/replays/replayContext';\n import ReplayTagsTableRow from 'sentry/components/replays/replayTagsTableRow';\n import {t} from 'sentry/locale';\n+import useOrganization from... | afafa098a3f7d1dcb64d6ccd3cd53ba074f24ee3 | diff --git a/static/app/components/replays/replayTagsTableRow.spec.tsx b/static/app/components/replays/replayTagsTableRow.spec.tsx
index 69ade943ac284d..7276b5e78c861f 100644
--- a/static/app/components/replays/replayTagsTableRow.spec.tsx
+++ b/static/app/components/replays/replayTagsTableRow.spec.tsx
@@ -2,19 +2,9 @@ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-44167@c938956 | getsentry/sentry | Python | 44,167 | ref(event-details): Move all issue event details rendering logic from EventEntries to GroupEventDetails | Ref https://github.com/getsentry/sentry/issues/44053
- Moves conditional render logic from `EventEntries` to event section components like `EventContext`, `EventDevice` etc. This is to enable them to be imported and used in both EventEntries and GroupEventDetails without duplicating that logic.
- Add `GroupEventDet... | 2023-02-06T18:16:19Z | Break up the `EventEntries` component
The `EventEntries` component is used in issue details, discover, performance, shared issues. Now that issues are becoming more differentiated from the event details, it no longer makes sense to use it for all these disparate use cases.
This work will enable the issues UI to be mor... | [
{
"body": "The `EventEntries` component is used in issue details, discover, performance, shared issues. Now that issues are becoming more differentiated from the event details, it no longer makes sense to use it for all these disparate use cases.\n\nThis work will enable the issues UI to be more flexible and di... | 8566ff3efe3a3026c6732e9b4c5d762fb30d0b02 | {
"head_commit": "c9389568e255d3e683fc65ed3349b2bd57cd5cf2",
"head_commit_message": "ref(event-details): Move all issue event details rendering logic to groupEventDetails",
"patch_to_review": "diff --git a/static/app/components/events/contexts/index.tsx b/static/app/components/events/contexts/index.tsx\nindex 133... | [
{
"diff_hunk": "@@ -0,0 +1,172 @@\n+import {Fragment} from 'react';\n+import styled from '@emotion/styled';\n+\n+import {CommitRow} from 'sentry/components/commitRow';\n+import {EventContexts} from 'sentry/components/events/contexts';\n+import {EventDevice} from 'sentry/components/events/device';\n+import {Even... | 5e2b9c8f0f3be29abb0475fa721f0bd4770aa7f3 | diff --git a/static/app/components/events/contexts/index.tsx b/static/app/components/events/contexts/index.tsx
index 133ced181c3c83..be6b001cf93722 100644
--- a/static/app/components/events/contexts/index.tsx
+++ b/static/app/components/events/contexts/index.tsx
@@ -15,7 +15,7 @@ type Props = {
export function EventCo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
getsentry__sentry-45507@d26baed | getsentry/sentry | Python | 45,507 | feat(monitors): Adds MonitorEnvironment to check_monitor + update endpoint | Adds `MonitorEnvironment` to `check_monitor` and check in update endpoint.
Closes https://github.com/getsentry/sentry/issues/45022 | 2023-03-08T00:10:28Z | Crons: Update `check_monitor` task to dual write into monitor environments
The job needs to be updated to query on the monitor environments, both for missed checkins and for checkins that have run for too long.
It will need to dual write into both the monitor and monitor environment. | Also make sure that we don't change environment on `PUT` update calls to a specific monitor | [
{
"body": "The job needs to be updated to query on the monitor environments, both for missed checkins and for checkins that have run for too long.\r\n\r\nIt will need to dual write into both the monitor and monitor environment.",
"number": 45022,
"title": "Crons: Update `check_monitor` task to dual writ... | 6223dec770dd2d4149761414f4786c9f698ed814 | {
"head_commit": "d26baeddfee117150d87005bc39bf929db33bd00",
"head_commit_message": "Merge branch 'master' into rjo100/check-monitor-monitorenv",
"patch_to_review": "diff --git a/src/sentry/monitors/consumers/check_in.py b/src/sentry/monitors/consumers/check_in.py\nindex fc4b1b211f2b0f..7aea582c559247 100644\n---... | [
{
"diff_hunk": "@@ -46,7 +61,7 @@ def process_message(message: Message[KafkaPayload]) -> None:\n check_in = MonitorCheckIn.objects.select_for_update().get(\n guid=params[\"check_in_id\"],\n project_id=project_id,\n- monitor=monitor,\n+ ... | 957558fbbd050ae7ea5a0f9f4291fe38769ab489 | diff --git a/src/sentry/monitors/consumers/check_in.py b/src/sentry/monitors/consumers/check_in.py
index 05f8a6bf97af65..d5591e2d1335b7 100644
--- a/src/sentry/monitors/consumers/check_in.py
+++ b/src/sentry/monitors/consumers/check_in.py
@@ -10,8 +10,14 @@
from arroyo.types import Commit, Message, Partition
from dja... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-43710@4253c7b | getsentry/sentry | Python | 43,710 | ref(event-details): Convert EventErrors to an FC and use react-query | I'm in the process of breaking up EventEntries and making having fewer class components will make that goal a bit easier.
- Convert EventErrors component to an FC
- Use useQuery for the request it was making
- Rename from `errors.tsx` to `eventErrors.tsx`
- Remove re-export of type in the ErrorItem file, consumer... | 2023-01-26T00:44:02Z | Break up the `EventEntries` component
The `EventEntries` component is used in issue details, discover, performance, shared issues. Now that issues are becoming more differentiated from the event details, it no longer makes sense to use it for all these disparate use cases.
This work will enable the issues UI to be mor... | [
{
"body": "The `EventEntries` component is used in issue details, discover, performance, shared issues. Now that issues are becoming more differentiated from the event details, it no longer makes sense to use it for all these disparate use cases.\n\nThis work will enable the issues UI to be more flexible and di... | 35c7731d9a93f213fd6d63fd581cfb085b6d8073 | {
"head_commit": "4253c7b6b2591577312ba41cdcbb0a2071dd62ab",
"head_commit_message": "ref(event-details): Convert EventErrors to an FC and use react-query",
"patch_to_review": "diff --git a/static/app/components/events/errorItem.tsx b/static/app/components/events/errorItem.tsx\nindex f139a8f6769465..7ebe56a444bca1... | [
{
"diff_hunk": "@@ -0,0 +1,152 @@\n+import styled from '@emotion/styled';\n+import isEqual from 'lodash/isEqual';\n+import uniqWith from 'lodash/uniqWith';\n+\n+import {Alert} from 'sentry/components/alert';\n+import {Error, ErrorItem} from 'sentry/components/events/errorItem';\n+import List from 'sentry/compon... | 005e67dd0538e6c2a56d5db97064b8d88ffdb9f1 | diff --git a/static/app/components/events/errorItem.tsx b/static/app/components/events/errorItem.tsx
index f139a8f6769465..bbfb5ca5537f60 100644
--- a/static/app/components/events/errorItem.tsx
+++ b/static/app/components/events/errorItem.tsx
@@ -12,7 +12,7 @@ import {JavascriptProcessingErrors} from 'sentry/constants/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
getsentry__sentry-45792@7ccbf9a | getsentry/sentry | Python | 45,792 | feat(monitors): Adds ability to search monitors by environment | Adds environment filter for endpoints.
Closes https://github.com/getsentry/sentry/issues/45019 | 2023-03-14T21:08:27Z | Crons: Update `monitor_index` + `monitor_details` endpoint to filter on environment
This updates the monitor endpoints to be queried on environment
1. If no environment is specified use the default environent
2. Status should come from the monitor environment and not the monitor itself | Hmm going to start up on part 2 of the backfill which should make this cleaner | [
{
"body": "This updates the monitor endpoints to be queried on environment\r\n\r\n1. If no environment is specified use the default environent\r\n2. Status should come from the monitor environment and not the monitor itself",
"number": 45019,
"title": "Crons: Update `monitor_index` + `monitor_details` e... | 8da040a31d11a2be411439845c3bc030d37f07bc | {
"head_commit": "7ccbf9a193bede49c30fbc21b65dbd5b1b324df2",
"head_commit_message": "removed serializer",
"patch_to_review": "diff --git a/src/sentry/api/serializers/base.py b/src/sentry/api/serializers/base.py\nindex 20ca254bbeb011..ca14a8ea12c0d4 100644\n--- a/src/sentry/api/serializers/base.py\n+++ b/src/sentr... | [
{
"diff_hunk": "@@ -69,6 +69,20 @@ def get(self, request: Request, organization: Organization) -> Response:\n )\n )\n query = request.GET.get(\"query\")\n+\n+ if \"environment\" in filter_params:\n+ monitor_environments = MonitorEnvironment.objects.filter(\n+ ... | 94859519583e25f7cafef9ed6c4b43507cf53f3b | diff --git a/src/sentry/api/serializers/base.py b/src/sentry/api/serializers/base.py
index 20ca254bbeb011..ca14a8ea12c0d4 100644
--- a/src/sentry/api/serializers/base.py
+++ b/src/sentry/api/serializers/base.py
@@ -45,7 +45,7 @@ def serialize(
:param objects: A list of objects
:param user: The user who will... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-43131@6c85a0a | getsentry/sentry | Python | 43,131 | ref(issue platform): Allow for searching generic issues in Discover | Enable Discover searching for generic issues. When the "Open in Discover" button is clicked and the query is `issue:short_id` there will be results using the issue platform dataset. This does require some front end changes to fully work - it will need to send a param `dataset=issuePlatform`.
Closes #42586 | 2023-01-11T20:35:40Z | Allow issue platform issues to be searched for in discover
We don't necessarily need the full discover functionality here. We just want to be able to search by issue id, so that `open in discover` works, and the events table will work.
We probably just want a way to specify that we're in the generic dataset and be abl... | [
{
"body": "We don't necessarily need the full discover functionality here. We just want to be able to search by issue id, so that `open in discover` works, and the events table will work.\n\nWe probably just want a way to specify that we're in the generic dataset and be able to specify an issue id (and other se... | 729eedf2da2d8b64b4d4d2257dde0e8fd9bdbb8c | {
"head_commit": "6c85a0ab16ca198c7946eb15658fc99e769c357e",
"head_commit_message": "dont use a real domain though technically bar.com exists",
"patch_to_review": "diff --git a/src/sentry/api/bases/organization_events.py b/src/sentry/api/bases/organization_events.py\nindex 9da72cf3833511..6a047fa786c894 100644\n-... | [
{
"diff_hunk": "@@ -0,0 +1,67 @@\n+from typing import List, Optional\n+\n+from snuba_sdk import Column, Function\n+\n+from sentry.search.events.builder import TimeseriesQueryBuilder\n+from sentry.search.events.types import ParamsType\n+from sentry.utils.snuba import Dataset\n+\n+\n+class IssuePlatformTimeseries... | a12d4c5aa56ae63540d4ebbe9d2937b24bff794f | diff --git a/src/sentry/api/bases/organization_events.py b/src/sentry/api/bases/organization_events.py
index 9da72cf3833511..6a047fa786c894 100644
--- a/src/sentry/api/bases/organization_events.py
+++ b/src/sentry/api/bases/organization_events.py
@@ -22,7 +22,13 @@
from sentry.search.events.constants import DURATION_U... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-45712@573e984 | getsentry/sentry | Python | 45,712 | feat(issues-platform): Start writing occurrences to platform | Use system and project options set in https://github.com/getsentry/sentry/pull/45709
Fixes https://github.com/getsentry/sentry/issues/43975 | 2023-03-13T17:20:43Z | Perf Migration: Start writing perf issues to the issue platform
We'll need to start writing performance issues to the issue platform dataset. When we do this, we'll be dual writing for some period of time. Since both perf issue detection and issue platform create/update the issue and counts, we'll need to make sure tha... | [
{
"body": "We'll need to start writing performance issues to the issue platform dataset. When we do this, we'll be dual writing for some period of time. Since both perf issue detection and issue platform create/update the issue and counts, we'll need to make sure that only one of these systems is actively updat... | ad9fa09acb39820a12908d57e0b04a29c71b3a45 | {
"head_commit": "573e98493187406a51ab3f7131c2ccbc0a27da7e",
"head_commit_message": "add group creation options",
"patch_to_review": "diff --git a/bin/load-mocks b/bin/load-mocks\nindex 7663bd1d7512a3..bc60891d913757 100755\n--- a/bin/load-mocks\n+++ b/bin/load-mocks\n@@ -1280,6 +1280,10 @@ if __name__ == \"__mai... | [
{
"diff_hunk": "@@ -0,0 +1,32 @@\n+from typing import Any, Mapping\n+\n+from sentry.issues.grouptype import PerformanceNPlusOneGroupType\n+from sentry.issues.issue_occurrence import IssueOccurrence\n+from sentry.models import Project\n+from sentry.utils.performance_issues.performance_problem import PerformanceP... | f3a5387cfd16f626322e8255f909d8508665294c | diff --git a/bin/load-mocks b/bin/load-mocks
index 7663bd1d7512a3..bc60891d913757 100755
--- a/bin/load-mocks
+++ b/bin/load-mocks
@@ -1280,6 +1280,10 @@ if __name__ == "__main__":
load_performance_issues=options.load_performance_issues,
slow=options.slow,
)
+
+ from sentry.iss... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} | |
getsentry__sentry-42306@17044af | getsentry/sentry | Python | 42,306 | feat(issue platform): Add dummy endpoint for issue occurrences | Create a dummy endpoint to be used internally for testing sending issue occurrence data.
Fixes [42169](https://github.com/getsentry/sentry/issues/42169) | 2022-12-13T20:14:12Z | Add dummy endpoint for creating profile issues
We should add a dummy endpoint that is accessible for superusers only. This endpoint will write an issue occurrence payload to the kafka topic for testing purposes.
We could have a default event and occurrence as part of the endpoint, and allow overrides to be passed, or ... | [
{
"body": "We should add a dummy endpoint that is accessible for superusers only. This endpoint will write an issue occurrence payload to the kafka topic for testing purposes.\n\nWe could have a default event and occurrence as part of the endpoint, and allow overrides to be passed, or just expect the whole payl... | 8ff8116df8fc120c2661adee978f8b78efd257e2 | {
"head_commit": "17044af37b3690f8e477c4fe59e8f13cce18c06c",
"head_commit_message": "add test + best guess at producing",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/issue_occurrence.py b/src/sentry/api/endpoints/issue_occurrence.py\nnew file mode 100644\nindex 00000000000000..6819a14e411102\n--- /d... | [
{
"diff_hunk": "@@ -0,0 +1,71 @@\n+from django.conf import settings\n+from rest_framework import serializers, status\n+from rest_framework.request import Request\n+from rest_framework.response import Response\n+\n+from sentry.api.base import Endpoint\n+from sentry.api.permissions import SuperuserPermission\n+\n... | d6614d9e8ad733447efb93a65696dd35b829283f | diff --git a/src/sentry/api/endpoints/issue_occurrence.py b/src/sentry/api/endpoints/issue_occurrence.py
new file mode 100644
index 00000000000000..402098728a2136
--- /dev/null
+++ b/src/sentry/api/endpoints/issue_occurrence.py
@@ -0,0 +1,77 @@
+from confluent_kafka import Producer
+from django.conf import settings
+fr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
intel__ipex-llm-7953@978d8cb | intel/ipex-llm | Python | 7,953 | del bigdl engine in orca pytorch estimator | ## Description
del bigdl engine in orca pytorch estimator
### 1. Why the change?
del bigdl engine in orca pytorch estimator, as bigdl to hard to deploy.
fixed #7954
### 2. User API changes
del bigdl engine in orca pytorch estimator， user couldm't use bigdl backend in orca pytorch estimator
### 3. Summa... | 2023-03-28T00:49:45Z | Remove jep backend in orca pytorch estmator
As jep's environment is hard to use and deprecated. And ray and spark backend are better choice, we will remove jep backend.
Tasks:
- [ ] 1. remove jep UT and example tests using orca pytorch estimator.
- [ ] 2. remove related code in orca pytorch estimator. | [
{
"body": "As jep's environment is hard to use and deprecated. And ray and spark backend are better choice, we will remove jep backend.\r\nTasks:\r\n- [ ] 1. remove jep UT and example tests using orca pytorch estimator.\r\n- [ ] 2. remove related code in orca pytorch estimator.",
"number": 7954,
"title"... | bdf1c30e4c8fd32560511b08a4cb43ed9921ec8f | {
"head_commit": "978d8cbdd44fee16f6d9f700240e79ef0a535a85",
"head_commit_message": "update",
"patch_to_review": "diff --git a/.github/actions/colab/colab-python-py37-pytorch/action.yml b/.github/actions/colab/colab-python-py37-pytorch/action.yml\nindex e4d210cd4d4..1e4abde4a8a 100644\n--- a/.github/actions/colab... | [
{
"diff_hunk": "@@ -52,7 +52,7 @@ runs:\n pip install -i https://pypi.org/simple --pre bigdl\n pip install -i ${GONDOLIN_PIP_MIRROR} --trusted-host ${GONDOLIN_TRUSTED_HOST} torch==1.7.1 torchvision==0.8.2\n pip install -i ${GONDOLIN_PIP_MIRROR} --trusted-host ${GONDOLIN_TRUSTED_HOST} six... | 2e246e3109f9a7d9c60d109764657d69f925721b | diff --git a/.github/actions/colab/colab-python-py37-pytorch/action.yml b/.github/actions/colab/colab-python-py37-pytorch/action.yml
index e4d210cd4d4..c99a3dbcc82 100644
--- a/.github/actions/colab/colab-python-py37-pytorch/action.yml
+++ b/.github/actions/colab/colab-python-py37-pytorch/action.yml
@@ -51,8 +51,7 @@ r... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
intel__ipex-llm-7915@7dbb886 | intel/ipex-llm | Python | 7,915 | change default hadoop user name from root to os.env[HADOOP_USER_NAME] or current user | ## Description
change default hadoop user name in init_nncontext_on_yarn
### 1. Why the change?
fixed #7905
### 2. User API changes
None
### 3. Summary of the change
change default hadoop user name in init_nncontext_on_yarn
### 4. How to test?
- [ ] N/A
- [ ] Unit test
- [ ] Application tes... | 2023-03-21T07:42:18Z | default to user 'root' when init_nncontext with yarn-cluster and yarn-local modes
I just noticed that bigdl seems to default to 'root' when init_nncontext is called with yarn-cluster and yarn-local modes. That leads to be permission errors if the actual user is not root. This does not happen when using 'local' or 'spar... | Yes, it's really not good to use `root` as default. We will fix it.
Hi @yuwgit Thanks for pointing out, we will fix it.
As a current workaround, you can specify the hadoop_user_name argument in init_orca_context to be your current user (which is default to be root...)
```
init_orca_context(..., hadoop_user_name="...... | [
{
"body": "I just noticed that bigdl seems to default to 'root' when init_nncontext is called with yarn-cluster and yarn-local modes. That leads to be permission errors if the actual user is not root. This does not happen when using 'local' or 'spark-submit' for init_nncontext(). \r\n\r\nAlong with the same con... | 8850f9bbb38c18f598a436327b570b9f574fcbd6 | {
"head_commit": "7dbb886b4f35aa159ddd61a37437ec5899d58447",
"head_commit_message": "update hadoop user name",
"patch_to_review": "diff --git a/python/dllib/src/bigdl/dllib/nncontext.py b/python/dllib/src/bigdl/dllib/nncontext.py\nindex 426b72922d1..98c0b0b48a5 100644\n--- a/python/dllib/src/bigdl/dllib/nncontext... | [
{
"diff_hunk": "@@ -93,7 +93,8 @@ def init_spark_on_yarn(hadoop_conf,\n Default to be None.\n :param additional_archive: Comma-separated list of additional archives to be uploaded and\n unpacked on executors. Default to be None.\n- :param hadoop_user_name: The user name for running ... | 059ea5b0186f774c51b27178136c2af537b313a9 | diff --git a/python/dllib/src/bigdl/dllib/nncontext.py b/python/dllib/src/bigdl/dllib/nncontext.py
index 426b72922d1..ed9d4c8c30b 100644
--- a/python/dllib/src/bigdl/dllib/nncontext.py
+++ b/python/dllib/src/bigdl/dllib/nncontext.py
@@ -65,7 +65,7 @@ def init_spark_on_yarn(hadoop_conf,
extra_pyt... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-41379@620c46a | getsentry/sentry | Python | 41,379 | ref(contexts): Prettify only known contexts - [TET-453] | **Before:**
<img width="1148" alt="image" src="https://user-images.githubusercontent.com/29228205/201894175-e0ccab87-4f1d-40a4-b45f-14e2feea6a54.png">
**After:**
<img width="1133" alt="image" src="https://user-images.githubusercontent.com/29228205/201894221-37a59d91-649d-4686-aeb3-f2a05156aa81.png">
... | 2022-11-15T08:06:25Z | sentry_set_context() doesn't display strings correctly
**Description**
I'm using sentry_set_context() to add some settings to crashes. But when the data is displayed in the web UI the strings have been prettified:
Local_settings
Last Position Latitude 38.897957
Last Position Longitude -77.036560
**When does th... | I think this might rather be a UI concern? You might as well stringify the values on the client instead of passing them as `double` values.
I wasn't sure which repo to create UI issues in. Also it's not the values that are the problem, it's the variable names changing from "last_position.latitude" to Last Position Lati... | [
{
"body": "**Description**\r\n\r\nI'm using sentry_set_context() to add some settings to crashes. But when the data is displayed in the web UI the strings have been prettified:\r\nLocal_settings\r\nLast Position Latitude\t38.897957\r\nLast Position Longitude\t-77.036560\r\n\r\n**When does the problem happen**\r... | 495751a38035084e0a2d440fc99dae21ac7d1240 | {
"head_commit": "620c46a1f824698642d62115971fdb0a087544e3",
"head_commit_message": "ref(contexts): Prettify only known contexts",
"patch_to_review": "diff --git a/static/app/components/events/contexts/default.tsx b/static/app/components/events/contexts/default.tsx\nindex 8ecd3348b152ef..4af0406374a4d9 100644\n--... | [
{
"diff_hunk": "@@ -183,7 +182,7 @@ export function getUnknownData({\n .map(([key, value]) => ({\n key,\n value,\n- subject: startCase(key),\n+ subject: key,",
"line": null,
"original_line": 185,
"original_start_line": null,
"path": "static/app/components/events/context... | 90f6ba02f874cfc4d7ac88b02c032ed8ad9a656a | diff --git a/static/app/components/events/contexts/default.tsx b/static/app/components/events/contexts/default.tsx
index 8ecd3348b152ef..4af0406374a4d9 100644
--- a/static/app/components/events/contexts/default.tsx
+++ b/static/app/components/events/contexts/default.tsx
@@ -1,5 +1,3 @@
-import startCase from 'lodash/st... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
intel__ipex-llm-5097@9525134 | intel/ipex-llm | Python | 5,097 | Chronos : add scheduler for Autoformer | ## Description
add scheduler for Autoformer to fix https://github.com/intel-analytics/BigDL/issues/5096
## Related Link or Issue
https://github.com/intel-analytics/BigDL/issues/5096
## How was this PR tested?
- [x] jenkins passed (please provide link):
http://10.112.231.51:18888/job/BigDL-Chronos-PR-Val... | 2022-07-14T02:22:38Z | Chronos : can't reproduce paper's result as lack of scheduler
I can't reproduce paper's result on the setting of Autoformer 97-720 forecast.
I find the reason is current implementation of Autoformer lack of a lr scheduler comparing with the source code. | [
{
"body": "I can't reproduce paper's result on the setting of Autoformer 97-720 forecast.\r\nI find the reason is current implementation of Autoformer lack of a lr scheduler comparing with the source code.",
"number": 5096,
"title": "Chronos : can't reproduce paper's result as lack of scheduler"
}
] | 16b686609b36fd62cb1abc655109c59280a63b19 | {
"head_commit": "9525134088eb7295359ede5cd15d84fd77956e8b",
"head_commit_message": "add scheduler",
"patch_to_review": "diff --git a/python/chronos/src/bigdl/chronos/model/autoformer/Autoformer.py b/python/chronos/src/bigdl/chronos/model/autoformer/Autoformer.py\nindex 1e3837788f3..c26c9365d93 100644\n--- a/pyth... | [
{
"diff_hunk": "@@ -179,7 +179,9 @@ def predict_step(self, batch, batch_idx):\n return outputs\n \n def configure_optimizers(self):\n- return getattr(optim, self.optim)(self.parameters(), lr=self.lr)\n+ optimizer = getattr(optim, self.optim)(self.parameters(), lr=self.lr)\n+ sch... | 5cfb3c7b31bb18df18a778628a7041c850c15425 | diff --git a/python/chronos/src/bigdl/chronos/forecaster/autoformer_forecaster.py b/python/chronos/src/bigdl/chronos/forecaster/autoformer_forecaster.py
index 16b9b3300ba..542ae7f3853 100644
--- a/python/chronos/src/bigdl/chronos/forecaster/autoformer_forecaster.py
+++ b/python/chronos/src/bigdl/chronos/forecaster/auto... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-42201@001606c | getsentry/sentry | Python | 42,201 | feat(issue-platform): Validate and save Occurrence + Event Messages | Processes Kafka payloads for incoming Occurrences and associated Events
Closes https://github.com/getsentry/sentry/issues/42053 and closes https://github.com/getsentry/sentry/issues/42036 | 2022-12-09T06:01:06Z | Ingestion: Validate issue occurrence messages
Parse and validate issue occurrence messages in issue occurrence consumer, and convert to the `IssueOccurrenceData` (draft forthcoming) typeddict to pass around to the persistence layer
Ingestion: When passed an event, save via event manager
If we had an `Event` passed to ... | [
{
"body": "Parse and validate issue occurrence messages in issue occurrence consumer, and convert to the `IssueOccurrenceData` (draft forthcoming) typeddict to pass around to the persistence layer",
"number": 42036,
"title": "Ingestion: Validate issue occurrence messages"
},
{
"body": "If we had... | de0cdbc7dff9814978186fd6b67ac2e3753c4e58 | {
"head_commit": "001606c0572ef086dd6326f1ac46e5ac9088c5b5",
"head_commit_message": "added log statement",
"patch_to_review": "diff --git a/src/sentry/issues/occurrence_consumer.py b/src/sentry/issues/occurrence_consumer.py\nindex 41c8d877f5c695..f85b2bf109a91b 100644\n--- a/src/sentry/issues/occurrence_consumer.... | [
{
"diff_hunk": "@@ -43,6 +52,92 @@ def create_ingest_occurences_consumer(\n )\n \n \n+def save_event_from_occurrence(\n+ data: Dict[str, Any],\n+ **kwargs: Any,\n+) -> Event:\n+\n+ from sentry.event_manager import EventManager\n+\n+ event_type = \"platform\"",
"line": null,
"original_lin... | afb7714adf4ea68bd1315ea11a0b94ca8028d238 | diff --git a/src/sentry/event_manager.py b/src/sentry/event_manager.py
index d6687cf95061b7..b3001f7e9ad78c 100644
--- a/src/sentry/event_manager.py
+++ b/src/sentry/event_manager.py
@@ -424,7 +424,8 @@ def save(
job = {"data": self._data, "project_id": project.id, "raw": raw, "start_time": start_time}
- ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-41268@1a36f73 | getsentry/sentry | Python | 41,268 | feat(perf): Add wildcard search support to transaction search bar | 
Closes #41237 and [PERF-1775](https://getsentry.atlassian.net/browse/PERF-1775). Backend support for wildcard searches was added in https://github.com/getsentry/sentry/pull/41... | 2022-11-11T16:01:38Z | Add wildcard support to transaction name search
### Problem Statement
The "Search Transactions" bar on the Performance landing page does not support wildcards, so I can't search for a group of related transactions.
### Solution Brainstorm
It should support wildcard searches like the other search bars in Sentry. e.g.... | Routing to @getsentry/visibility for [triage](https://develop.sentry.dev/processing-tickets/#3-triage). ⏲️ | [
{
"body": "### Problem Statement\n\nThe \"Search Transactions\" bar on the Performance landing page does not support wildcards, so I can't search for a group of related transactions.\n\n### Solution Brainstorm\n\nIt should support wildcard searches like the other search bars in Sentry. e.g., Typing something li... | 3c8ffadf905a38e372d40d3315f536b965b7b686 | {
"head_commit": "1a36f735a2484924d6758e7807e9da5b76e38deb",
"head_commit_message": "Clarify function name",
"patch_to_review": "diff --git a/static/app/components/performance/searchBar.spec.tsx b/static/app/components/performance/searchBar.spec.tsx\nindex 2947d9c30fda4c..bf35248e73d5d9 100644\n--- a/static/app/c... | [
{
"diff_hunk": "@@ -227,14 +229,39 @@ function SearchBar(props: SearchBarProps) {\n searchSubstring={searchString}\n loading={loading}\n items={searchResults}\n- onClick={handleSearch}\n- onIconClick={navigateToTransactionSummary}\n+ onClick={handleChoose... | f80c77fa02518380cd6c47e9686daaee10474b34 | diff --git a/static/app/components/performance/searchBar.spec.tsx b/static/app/components/performance/searchBar.spec.tsx
index 2947d9c30fda4c..bf35248e73d5d9 100644
--- a/static/app/components/performance/searchBar.spec.tsx
+++ b/static/app/components/performance/searchBar.spec.tsx
@@ -142,4 +142,33 @@ describe('Search... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
intel__ipex-llm-4487@a8ce33a | intel/ipex-llm | Python | 4,487 | [Nano] consistent save/load for nano pytorch | resolves #4485 | 2022-04-25T02:31:33Z | [Nano] trainer.save accepts multiple types of models
# Description
Current API for model saving and loading. It can do:
1. save/export a pytorch model as openvino format
2. save a `PytorchOpenVINOModel ` as local openvino file
**Do you think this is a bit confusing for users accepting multiple types of models?**... | We should have only one `save` method, which exports standard model format (e.g., OpenVINO or ONNX format) that can be loaded by both nano and standard 3rd party tools (such as OpenVINO or ONNX Runtime).
I think for `trainer.save`, we may follow your first design (**and only support this design**), which means that ou... | [
{
"body": "# Description\r\nCurrent API for model saving and loading. It can do:\r\n1. save/export a pytorch model as openvino format \r\n2. save a `PytorchOpenVINOModel ` as local openvino file\r\n\r\n**Do you think this is a bit confusing for users accepting multiple types of models?** @jason-dai \r\nOthe... | 7d5767c618ac69c38ac2b38464798cb7c2e7a7f2 | {
"head_commit": "a8ce33a7af437776a695522a0c14213492f96689",
"head_commit_message": "remove duplicate import",
"patch_to_review": "diff --git a/python/nano/src/bigdl/nano/deps/openvino/core/openvino_model.py b/python/nano/src/bigdl/nano/deps/openvino/core/openvino_model.py\nindex b6ca0440f89..19022268b79 100644\n... | [
{
"diff_hunk": "@@ -310,56 +310,74 @@ def trace(model: nn.Module, input_sample=None, accelerator=None):\n model is a LightningModule with any dataloader attached.\n :param accelerator: The accelerator to use, defaults to None meaning staying in Pytorch\n ... | 6724a1d5ec904700a501d97e0f05c0da20bda02e | diff --git a/python/nano/src/bigdl/nano/deps/openvino/core/openvino_model.py b/python/nano/src/bigdl/nano/deps/openvino/core/openvino_model.py
index b6ca0440f89..19022268b79 100644
--- a/python/nano/src/bigdl/nano/deps/openvino/core/openvino_model.py
+++ b/python/nano/src/bigdl/nano/deps/openvino/core/openvino_model.py... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
intel__ipex-llm-4972@0614374 | intel/ipex-llm | Python | 4,972 | Nano : add length check in trace | fix https://github.com/intel-analytics/BigDL/issues/4970 | 2022-06-29T07:51:42Z | Nano : length check in trace and friendly warning
When I experiment on BST, the dataloader contains a useless redundant input, then in Trainer.trace, the length of self._forward_args is shorter than inputs, because in torch.onnx.export, the graph does not contain redundant input.
We may add some length check and provi... | [
{
"body": "When I experiment on BST, the dataloader contains a useless redundant input, then in Trainer.trace, the length of self._forward_args is shorter than inputs, because in torch.onnx.export, the graph does not contain redundant input.\r\nWe may add some length check and provide some warnings for user.\r\... | 3bd52938259b7239438249c089cbb34fbe624428 | {
"head_commit": "06143749a2fcbbd97a34ffc8756bdfb05331caf3",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/python/nano/src/bigdl/nano/deps/onnxruntime/core/onnxruntime_model.py b/python/nano/src/bigdl/nano/deps/onnxruntime/core/onnxruntime_model.py\nindex f9d4620532d..b144aae8407 100644\n--- a/py... | [
{
"diff_hunk": "@@ -30,6 +30,9 @@ def forward_step(self, *inputs):\n '''\n This function run through the onnxruntime forwarding step\n '''\n+ if len(self._forward_args) < len(inputs):\n+ invalidInputError(False, \"The length of inputs is inconsistent with the length of ... | efb8b204a7c88989e262060cd4114c2963227290 | diff --git a/python/nano/src/bigdl/nano/deps/onnxruntime/core/onnxruntime_model.py b/python/nano/src/bigdl/nano/deps/onnxruntime/core/onnxruntime_model.py
index f9d4620532d..6a88cca9e61 100644
--- a/python/nano/src/bigdl/nano/deps/onnxruntime/core/onnxruntime_model.py
+++ b/python/nano/src/bigdl/nano/deps/onnxruntime/c... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
intel__ipex-llm-4030@9af0842 | intel/ipex-llm | Python | 4,030 | Resolve inc metric duplicate registration | resolves https://github.com/intel-analytics/BigDL/issues/4002
In previous implementation, each call of quantization, a metric will be registered.
This causes error when we call quantization with a same metric in one script twice.
### previous implementation :
Each metric is registered at runtime, so there can b... | 2022-02-15T08:39:37Z | Nano quantization report AssertionError on the second time
Here is a minimal example:
```python
model = ResNet18(10, pretrained=False, include_top=False, freeze=True)
loss = nn.CrossEntropyLoss()
optimizer = torch.optim.Adam(model.parameters(), lr=0.01)
train_loader = create_data_loader(data_dir, batch_size, num_... | It's not INC's problem. I think each call of `trainer.quantize(..)` will register the metric into INC as `F1`, so this is the reason.
Maybe we should have better implementation in https://github.com/intel-analytics/BigDL/blob/branch-2.0/python/nano/src/bigdl/nano/quantization/neural_compressor/quantization.py#L90-L... | [
{
"body": "Here is a minimal example:\r\n```python\r\nmodel = ResNet18(10, pretrained=False, include_top=False, freeze=True)\r\nloss = nn.CrossEntropyLoss()\r\noptimizer = torch.optim.Adam(model.parameters(), lr=0.01)\r\ntrain_loader = create_data_loader(data_dir, batch_size, num_workers, data_transform)\r\ntra... | 8fc78b4c0c35bcba01ddd32f4b4f62a607478051 | {
"head_commit": "9af084251a17d890347fa3891e301b0bbf6eefb5",
"head_commit_message": "add extra test to make sure metric successfully assigned",
"patch_to_review": "diff --git a/python/nano/src/bigdl/nano/quantization/neural_compressor/metric/base_metric.py b/python/nano/src/bigdl/nano/quantization/neural_compress... | [
{
"diff_hunk": "@@ -96,10 +96,9 @@ def __init__(self):\n to the new local class to avoid that.\n \"\"\"\n self.metric = metric\n-\n self.metric = Metric(\n MyMetric,\n- name=\"%s_%s\" %... | 3e8503c4dc6c94ed3dcd3e769b69cab324121c9f | diff --git a/python/nano/src/bigdl/nano/quantization/neural_compressor/metric/base_metric.py b/python/nano/src/bigdl/nano/quantization/neural_compressor/metric/base_metric.py
index fa26ef7ab86..320311051cb 100644
--- a/python/nano/src/bigdl/nano/quantization/neural_compressor/metric/base_metric.py
+++ b/python/nano/src... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
intel__ipex-llm-2836@5ea12e2 | intel/ipex-llm | Python | 2,836 | bug fix for cmul | ## What changes were proposed in this pull request?
fix cmul error when batchsize equals one of element number. (e.g. input size (64, 64, 112, 112))
## How was this patch tested?
unit tests and example tests
## Related links or issues (optional)
fixed https://github.com/intel-analytics/BigDL/issues/2812
... | 2019-06-11T01:57:25Z | ResNet50 MKLDNN accuracy issue
Analytics-zoo model (converted from caffe) could be directly load by `loadModule`, but the accuracy gets bad(**top1/5 55%/77%** compared to bigdl model **top1/5 75%/92%**)
The model used is resnet50 pretrained one, using mkldnn as backend
However there is no error raised, seems the ... | @Litchilitchy Hi, I use examples in zoo to test model (converted from caffe) accuracy.
**With MKLDNN and MKLBLAS backend, I got same accuracy for Imagenet validation dataset.**
Top1Accuracy is Accuracy(correct: 36433, count: 50000, accuracy: 0.72866)
Top5Accuracy is Accuracy(correct: 45571, count: 50000, accuracy: 0... | [
{
"body": "Analytics-zoo model (converted from caffe) could be directly load by `loadModule`, but the accuracy gets bad(**top1/5 55%/77%** compared to bigdl model **top1/5 75%/92%**)\r\n\r\nThe model used is resnet50 pretrained one, using mkldnn as backend\r\n\r\nHowever there is no error raised, seems the weig... | 00b80ad065c439f56e3319b72b59e8bb7406bc06 | {
"head_commit": "5ea12e25d07153a3782b215bb19594c04231e6c6",
"head_commit_message": "bugfix for cmul",
"patch_to_review": "diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/CMul.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/CMul.scala\nindex 1ab34031115..5c148d5022a 100644\n--- a/sp... | [
{
"diff_hunk": "@@ -82,13 +82,19 @@ class CMul[T: ClassTag](\n }\n \n private def mulOneDimWeight(dim: Int, expand: Tensor[T], output: Tensor[T]): Unit = {\n- val multiplyDimSize = expand.size(dim)\n- var dimOfOutput : Int = 1\n- while(output.size(dimOfOutput) != multiplyDimSize) {\n-\n- dimOf... | d20895ce1cffc7d8c6467875dc1aab7c013a7bd7 | diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/CMul.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/CMul.scala
index 1ab34031115..e9d2271ce93 100644
--- a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/CMul.scala
+++ b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/CMul.scala... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-40784@719a0e2 | getsentry/sentry | Python | 40,784 | feat(replays): Conditionally render Replay touch points by project platform | Adds a new project based condition for rendering replay touch points. Replays are only supported by front-end JavaScript projects. Looking through the defined platform categories in `platformCategories.tsx` it appears that any project with a platform containing 'javascript' in the name is a front-end project in Sentry ... | 2022-10-31T20:11:29Z | Only display Replay touchpoints in Issue/Performance/Discovery views for applicable projects
**Problem:**
We’ve made many improvements to the Performance views (i.e., Transaction Summary and the tabs on this page) such as the Replay ID column on mini-table, “Replays” tab, Replay ID column on “All Events” page, etc.
... | [
{
"body": "**Problem:**\n\nWe’ve made many improvements to the Performance views (i.e., Transaction Summary and the tabs on this page) such as the Replay ID column on mini-table, “Replays” tab, Replay ID column on “All Events” page, etc. \n\nRight now, these touch points are shown even for mobile or backend pro... | 30de03dae139fc3b1b7c08b6939e6b694e95d820 | {
"head_commit": "719a0e21da5cdb6984930a87d96b471132a67c45",
"head_commit_message": "fix(replays): add conditional chain back for tests",
"patch_to_review": "diff --git a/static/app/components/eventOrGroupExtraDetails.tsx b/static/app/components/eventOrGroupExtraDetails.tsx\nindex 05e319bb541c9c..fb66f725f611c4 1... | [
{
"diff_hunk": "@@ -0,0 +1,7 @@\n+import type {MinimalProject} from 'sentry/types';\n+\n+function projectSupportsReplay(project?: MinimalProject) {\n+ return Boolean(project?.platform?.includes('javascript'));",
"line": null,
"original_line": 4,
"original_start_line": null,
"path": "static/app/... | 45175a4aa537272a0cd54eb4c64593bfeb2d931f | diff --git a/static/app/components/eventOrGroupExtraDetails.tsx b/static/app/components/eventOrGroupExtraDetails.tsx
index 05e319bb541c9c..fb66f725f611c4 100644
--- a/static/app/components/eventOrGroupExtraDetails.tsx
+++ b/static/app/components/eventOrGroupExtraDetails.tsx
@@ -17,6 +17,7 @@ import {tct} from 'sentry/l... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-39166@696c4d6 | getsentry/sentry | Python | 39,166 | perf(replay): Improve Replay Details pageload speed by fetching errors in parallel with replay segments | Before we can see that the 3rd request is blocked on the first two:
After this change the 3rd request is only waiting for the 1st to complete. The segment data download is still happening.
,
fetchAllRRwebEvents(),
]);
const replayRecord = mapResponseToReplayRecord(record);
const e... | Related to #38524 | [
{
"body": "Right now we do this in useReplayData:\n```\nconst [record, attachments] = await Promise.all([\n fetchReplay(),\n fetchAllRRwebEvents(),\n]);\nconst replayRecord = mapResponseToReplayRecord(record);\nconst errors = await fetchErrors(replayRecord);\n```\n\nI think it could be faster if we put the er... | 48eb9791a9561abf2bad91f25d48950731feaf09 | {
"head_commit": "696c4d6e465742cf8236c0ced7bfaff1879aa4b9",
"head_commit_message": "remove the old code",
"patch_to_review": "diff --git a/static/app/utils/replays/hooks/useReplayData.tsx b/static/app/utils/replays/hooks/useReplayData.tsx\nindex 2dbf18bcacbc4a..a2d921f313e6cb 100644\n--- a/static/app/utils/repla... | [
{
"diff_hunk": "@@ -189,12 +189,15 @@ function useReplayData({replaySlug, orgSlug}: Options): Result {\n setState(INITIAL_STATE);\n \n try {\n- const [record, attachments] = await Promise.all([\n- fetchReplay(),\n+ const [[replayRecord, errors], attachments] = await Promise.all([\n+ ... | 02a0c7350bc5fc37432680ddde921603a780c79e | diff --git a/static/app/utils/replays/hooks/useReplayData.tsx b/static/app/utils/replays/hooks/useReplayData.tsx
index 2dbf18bcacbc4a..cda94e0b12e711 100644
--- a/static/app/utils/replays/hooks/useReplayData.tsx
+++ b/static/app/utils/replays/hooks/useReplayData.tsx
@@ -185,16 +185,22 @@ function useReplayData({replayS... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
getsentry__sentry-39374@f11c99a | getsentry/sentry | Python | 39,374 | feat(replays): Unit tests to Issues Replays List page | <!-- Describe your PR here. -->
### Changes
- Added unit tests for the `groupReplays.tsx`.
- Added `fetchError` prop to the `ReplaysTable` component to catch api errors
Closes #38842.
### Tests coverage
- [x] Assert that query to the events endpoint is correct
- [x] Snapshot test for empty state
- [x] As... | 2022-09-27T22:09:43Z | [jest] Issues list page loads
- [ ] assert that query to the events endpoint is correct
- [ ] snapshot test for empty state
1. assert that get/fetch call has the correct search params
2. assert that we can change search filters (time, project, text) and get/fetch is correct each time
3. assert that invalid sear... | [
{
"body": "- [ ] assert that query to the events endpoint is correct\r\n- [ ] snapshot test for empty state\r\n\r\n\r\n1. assert that get/fetch call has the correct search params\r\n2. assert that we can change search filters (time, project, text) and get/fetch is correct each time\r\n3. assert that invalid sea... | b5fa9faa20b76697ab7cf681b2aa4725cf3dc5ac | {
"head_commit": "f11c99affb2e9e6b63825f8344742e7f7a5d52b1",
"head_commit_message": "feat: add new feature check test",
"patch_to_review": "diff --git a/static/app/views/organizationGroupDetails/groupReplays/groupReplays.spec.tsx b/static/app/views/organizationGroupDetails/groupReplays/groupReplays.spec.tsx\nnew ... | [
{
"diff_hunk": "@@ -0,0 +1,460 @@\n+import {initializeOrg} from 'sentry-test/initializeOrg';\n+import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';\n+\n+import ProjectsStore from 'sentry/stores/projectsStore';\n+import {OrganizationContext} from 'sentry/views/organizationContext';... | f1397582f8df46207d97172c6a33cae35034bd2e | diff --git a/static/app/views/organizationGroupDetails/groupReplays/groupReplays.spec.tsx b/static/app/views/organizationGroupDetails/groupReplays/groupReplays.spec.tsx
new file mode 100644
index 00000000000000..37f920746087ca
--- /dev/null
+++ b/static/app/views/organizationGroupDetails/groupReplays/groupReplays.spec.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} | |
intel__ipex-llm-2557@c19a8ed | intel/ipex-llm | Python | 2,557 | fix: memory leak in `model.predictImageSet`. | ## What changes were proposed in this pull request?
There're three reasons of memory leak.
1. repeat allocations in bigquant, which will be fixed in BigDL-core.
2. repeat clone module but no release. `model.predictImageSet` will new
Predictor again and again.
3. share weights.
Because of multi models archi... | 2018-06-14T10:29:01Z | Memory leak when using quantized model for prediction
The memory consumption grows steadily as multiple inferences running with quantized model.
After some initial investigation, found the heap memory was actually small and consistent while the used physical memory is steadily increased. | Please provide an example to reproduce the issue.
Synced with @i8run offline and he has successfully repro this issue.
User can reproduce it by calling `model.predictImage` multi times. Because of `predictImage` in `AbstractModule` will new `LocalPredictor` every call, which will `cloneModule` multi times. For normal m... | [
{
"body": "The memory consumption grows steadily as multiple inferences running with quantized model. \r\n\r\nAfter some initial investigation, found the heap memory was actually small and consistent while the used physical memory is steadily increased.",
"number": 2535,
"title": "Memory leak when using... | 2e5f18cae5b55e3c972438fd15eb79ea831c9b9a | {
"head_commit": "c19a8ed843054e288d7e67ac80e0b9217ae091e3",
"head_commit_message": "fix: move delete operation to ModelBroadcast",
"patch_to_review": "diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/models/utils/ModelBroadcast.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/models/utils/... | [
{
"diff_hunk": "@@ -141,13 +173,92 @@ class ModelBroadcast[T: ClassTag](applyProtoBuffer: Boolean = false)\n Array()\n }\n }\n-\n }\n \n-\n object ModelBroadcast {\n def apply[@specialized(Float, Double) T: ClassTag](applyProtoBuffer: Boolean = false)\n (implicit ev: TensorNumeric[T]) : Mo... | 960e95ad0532bd610b8499ace365eedd0540a130 | diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/models/utils/ModelBroadcast.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/models/utils/ModelBroadcast.scala
index cbda51eca05..4bc7530875d 100644
--- a/spark/dl/src/main/scala/com/intel/analytics/bigdl/models/utils/ModelBroadcast.scala
+++ b/spa... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
intel__ipex-llm-2470@a39469b | intel/ipex-llm | Python | 2,470 | [Enhancement ] - Add set label and get uri api | ## What changes were proposed in this pull request?
Add set label and get uri api
## How was this patch tested?
unit test
## Related links or issues (optional)
fixed https://github.com/intel-analytics/BigDL/issues/2468
| 2018-03-28T08:11:56Z | Python ImageFrame needs to have a way to add labels
After a user creates ImageFrame from image files, there is no suitable way to add labels to the image frame. Maybe we can expose rdd/array API to get rdd/array of ImageFeature, and provide set label API to set label for image feature. | [
{
"body": "After a user creates ImageFrame from image files, there is no suitable way to add labels to the image frame. Maybe we can expose rdd/array API to get rdd/array of ImageFeature, and provide set label API to set label for image feature. ",
"number": 2468,
"title": "Python ImageFrame needs to... | bf610b35ff824534ce5e0225f976ae828d7087bc | {
"head_commit": "a39469b98e444f267dce6bad4163aafa794076d4",
"head_commit_message": "add examples",
"patch_to_review": "diff --git a/pyspark/bigdl/examples/imageframe/README.md b/pyspark/bigdl/examples/imageframe/README.md\nnew file mode 100644\nindex 00000000000..6c8a2f610f9\n--- /dev/null\n+++ b/pyspark/bigdl/e... | [
{
"diff_hunk": "@@ -0,0 +1,47 @@\n+## Overview\n+ImageFrame provides rich deep learning APIs for scalable image processing. This example illustrates how to do model validation with Python APIs using inception-v1 model\n+\n+## Run Model validation\n+\n+### Preparation\n+\n+In order to run the validation applicat... | 1c0a91eed13ccb8ae6961b54c9528ea91dcf19b3 | diff --git a/pyspark/bigdl/examples/imageframe/README.md b/pyspark/bigdl/examples/imageframe/README.md
new file mode 100644
index 00000000000..06a49c2a2f2
--- /dev/null
+++ b/pyspark/bigdl/examples/imageframe/README.md
@@ -0,0 +1,47 @@
+## Overview
+ImageFrame provides rich deep learning APIs for scalable image process... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
intel__ipex-llm-2083@986ed6f | intel/ipex-llm | Python | 2,083 | Support adding customized jars after pip install; fix release related | ## What changes were proposed in this pull request?
Support adding customized jars after pip install.
Fix release issues.
Add docs.
## How was this patch tested?
Jenkins and manual test.
## Related links or issues (optional)
fixed #1989
| 2017-12-21T07:36:19Z | support loading custom jars and python-api.zip for python via pip install
When user define new criterions, layers and wrap it in python, it requires loading external jar/python-api.zip when jupyter/BigDL starts up. But pip install doesn't allow loading customized jars/zip now. External jars can only be loaded using sc... | [
{
"body": "When user define new criterions, layers and wrap it in python, it requires loading external jar/python-api.zip when jupyter/BigDL starts up. But pip install doesn't allow loading customized jars/zip now. External jars can only be loaded using script to launch jupyter. \r\n\r\nWe need \r\n\r\n- Suppo... | b2b5522cdb4479c459d35d96e74705508dc196c8 | {
"head_commit": "986ed6f779bd9a83c0262d038bcb4471d0e03920",
"head_commit_message": "support add jars",
"patch_to_review": "diff --git a/pyspark/bigdl/util/common.py b/pyspark/bigdl/util/common.py\nindex 384b8c7427b..f60565f744c 100644\n--- a/pyspark/bigdl/util/common.py\n+++ b/pyspark/bigdl/util/common.py\n@@ -3... | [
{
"diff_hunk": "@@ -83,13 +87,13 @@ def get_bigdl_classpath():\n \"\"\"\n Get and return the jar path for bigdl if exists.\n \"\"\"\n- if(os.getenv(\"BIGDL_CLASSPATH\")):\n- return os.environ[\"BIGDL_CLASSPATH\"]\n+ if os.getenv(\"BIGDL_CLASSPATH\"):\n+ return [os.environ[\"BIGDL... | 76f868484c940cac7cecbe78187aee4d179f6772 | diff --git a/docs/docs/PythonUserGuide/run-from-pip.md b/docs/docs/PythonUserGuide/run-from-pip.md
index da8c1274bbf..da13823bbb3 100644
--- a/docs/docs/PythonUserGuide/run-from-pip.md
+++ b/docs/docs/PythonUserGuide/run-from-pip.md
@@ -12,14 +12,14 @@
* If the type of input data is ndarray instead of RDD or DataFram... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
intel__ipex-llm-2034@bba6d1a | intel/ipex-llm | Python | 2,034 | Concat check input size check | ## What changes were proposed in this pull request?
Each module output inside concat is supposed to have the same dim size exception the one for concatenating, this change is to do the sanity check to make it more user friendly when exception happens
## How was this patch tested?
Unit test
## Related links ... | 2017-12-15T02:18:44Z | Concate layer should pop proper infor to users if size mismatch
Concat requires only size of `dimension` for each output variable and other size should be the same among each output, we should do the size checking otherwise user may get unexpected exception | [
{
"body": "Concat requires only size of `dimension` for each output variable and other size should be the same among each output, we should do the size checking otherwise user may get unexpected exception ",
"number": 2027,
"title": "Concate layer should pop proper infor to users if size mismatch"
}
... | 8714afd58aecb2b32455f24e2fd7daba8e530211 | {
"head_commit": "bba6d1aab8c9161d0bee8d48122f2a9033f1bfe4",
"head_commit_message": "add dim check",
"patch_to_review": "diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Concat.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Concat.scala\nindex fb5e5ec8833..8cb0060629f 100644\n--- a/... | [
{
"diff_hunk": "@@ -108,6 +110,27 @@ class Concat[T: ClassTag](val dimension: Int)(\n this.output\n }\n \n+ private def checkOutputs(outputs : Array[Tensor[T]], dim : Int) : Unit = {",
"line": null,
"original_line": 113,
"original_start_line": null,
"path": "spark/dl/src/main/scala/com/in... | 60e9c1985c8b05a149c0ccdf4e17e0d70691f626 | diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Concat.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Concat.scala
index fb5e5ec8833..f33e0ddf4a2 100644
--- a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Concat.scala
+++ b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Conc... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
intel__ipex-llm-2045@de7832d | intel/ipex-llm | Python | 2,045 | fix null pointer exception in bn when affine is false | ## What changes were proposed in this pull request?
fix null pointer exception in bn when affine is false
## How was this patch tested?
Unit tests
## Related links or issues (optional)
fixed https://github.com/intel-analytics/BigDL/issues/2012
| 2017-12-18T03:27:15Z | SpatialBatchNormalization does not work while affine is false
In BatchNormalization, weight initialization is based on `nOutput` and `affine`
```scala
val weight: Tensor[T] =
if (initWeight != null) initWeight else if (affine) Tensor[T](nOutput) else null
```
Weight will be null if affine is false, but it's n... | [
{
"body": "In BatchNormalization, weight initialization is based on `nOutput` and `affine`\r\n```scala\r\n val weight: Tensor[T] =\r\n if (initWeight != null) initWeight else if (affine) Tensor[T](nOutput) else null\r\n```\r\nWeight will be null if affine is false, but it's not handled properly in forward an... | 5f931bdef649fead838a2ecadc7eeab9e2c3defc | {
"head_commit": "de7832d0a1c64f2063673cd354e4a64a89adc4de",
"head_commit_message": "fix null pointer exception in bn when affine is false",
"patch_to_review": "diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/SpatialBatchNormalization.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/... | [
{
"diff_hunk": "@@ -896,6 +896,7 @@ object SpatialBatchNormalization {\n val n = gradOutput.nElement()\n \n if (scale != null) {\n+ require(scale.size(1) == nChannel, \"scale length is not consist with channel number\")",
"line": null,
"original_line": 899,
"original_start_line": null,
... | 234e96dd957438999f9a719c580ed4c69b7d8d4a | diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/SpatialBatchNormalization.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/SpatialBatchNormalization.scala
index 376e0b5dbd8..4a2aed8389e 100644
--- a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/SpatialBatchNormalization.scala
+++ b/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
intel__ipex-llm-1763@d5a3b74 | intel/ipex-llm | Python | 1,763 | Clone graph keep their original prevs nodes and next nodes sequence | ## What changes were proposed in this pull request?
Clone graph keep their original prevs nodes and next nodes order.
Current cloneGraph may change the next nodes order, thus will influence the update of tree-lstm (it has many shared component)
In the meantime, fix a bug in graph backward that caused by the foll... | 2017-10-26T07:35:47Z | TreeLSTM example will throw exception and loss will be NaN
```
Exception in thread "main" java.lang.IllegalArgumentException: requirement failed: copyStatus:container's length mismatchexcepted 1, but get 0
at scala.Predef$.require(Predef.scala:224) ... | [
{
"body": "```\r\nException in thread \"main\" java.lang.IllegalArgumentException: requirement failed: copyStatus:container's length mismatchexcepted 1, but get 0\r\n at scala.Predef$.require(Predef.scala:224) ... | f62c4d40ec5bb1d955d77afa09d8dbfea7d80107 | {
"head_commit": "d5a3b74be53aa38aa7bfed324e8df569a3de1753",
"head_commit_message": "Clone graph keep their original prevs nodes and next nodes sequence",
"patch_to_review": "diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Graph.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Graph.... | [
{
"diff_hunk": "@@ -509,14 +509,17 @@ class Graph[T: ClassTag](val inputs : Seq[ModuleNode[T]],\n activity.toTensor[T].add(other.toTensor[T])\n } else {\n val actTable = activity.toTable\n- val actLen = actTable.length()\n val otherTable = other.toTable\n- val otherLe... | c7553690a574d10a115268c14f6a29d8102ded3b | diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Graph.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Graph.scala
index 03aaea59d6b..9168f7d5884 100644
--- a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Graph.scala
+++ b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/Graph.s... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-38966@2b2ea18 | getsentry/sentry | Python | 38,966 | feat(replays): Additional analytics tracking events | ### Changes
- Adds new event type and tracks replay play/pause
- Adds new event type and tracks details page tab changes
- Adds new event type and tracks time spent on replay details page
- Adds new event type and tracks fullscreen mode toggle
### Notes
play/pause and fullscreen toggle events can be triggered f... | 2022-09-16T19:03:52Z | Session Replay: additional user analytics events for Amplitude based on feedback
Based on feedback from the team, we'd like to instrument the following user interactions:
- Click the "play" button on the Replay Details page and pause (per user)
- Which tabs in Replay Details are users clicking ("Console", "DOM Even... | cc @ryan953
Relates to [38315](https://github.com/getsentry/sentry/issues/38315)
Example of recording metrics: https://github.com/getsentry/sentry/pull/38370 | [
{
"body": "Based on feedback from the team, we'd like to instrument the following user interactions:\r\n\r\n- Click the \"play\" button on the Replay Details page and pause (per user)\r\n- Which tabs in Replay Details are users clicking (\"Console\", \"DOM Events\", \"Network\", \"Trace\", \"Issues\", \"Memory\... | 14a6c3cfffe454aa02a791e6d12c241c0567136b | {
"head_commit": "2b2ea18a71e00ce01edba32aa82735625c8d146d",
"head_commit_message": "fix(replays): fixes lint issues",
"patch_to_review": "diff --git a/static/app/components/replays/replayController.tsx b/static/app/components/replays/replayController.tsx\nindex ab3c54e7817499..eaaeb44a761ac6 100644\n--- a/static... | [
{
"diff_hunk": "@@ -50,6 +57,15 @@ function ReplayPlayPauseBar({isCompact}: {isCompact: boolean}) {\n togglePlayPause,\n } = useReplayContext();\n \n+ const handlePlayToggle = () => {\n+ trackAdvancedAnalyticsEvent('replay.play-pause', {\n+ organization,\n+ user_email: config.user.email,\n+ ... | d7da43e17174dc58481c268320094279a5f223db | diff --git a/static/app/components/events/eventReplay/replayContent.spec.tsx b/static/app/components/events/eventReplay/replayContent.spec.tsx
index eb8ee3cc25cfee..17408578c67039 100644
--- a/static/app/components/events/eventReplay/replayContent.spec.tsx
+++ b/static/app/components/events/eventReplay/replayContent.sp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
intel__ipex-llm-1667@044176e | intel/ipex-llm | Python | 1,667 | Big dl#1115 Refine the toString() method for too large tensor | ## What changes were proposed in this pull request?
If the tensor is too large, then only print part of it. (The contents are same with those printed from NumPy)
## How was this patch tested?
Test on some points.
1. val t = new DenseTensor[Float](1000).rand()
println(t)
-------------------------Output wil... | 2017-10-16T07:38:01Z | When tensor is too large, only print a part of it in toString method
If the tensor is too large, the whole content of the tensor should not be print out. It's actually not so helpful, and create OOM error.
Here's an example in numpy:
```python
>>> np.ndarray(shape=(100000), dtype=float)
array([ 0., 0., 0., ..... | [
{
"body": "If the tensor is too large, the whole content of the tensor should not be print out. It's actually not so helpful, and create OOM error.\r\n\r\nHere's an example in numpy:\r\n\r\n```python\r\n>>> np.ndarray(shape=(100000), dtype=float)\r\narray([ 0., 0., 0., ..., 0., 0., 0.])\r\n```",
"numbe... | 41012af8fd37e01d6063f6b2299fa244fa88dddd | {
"head_commit": "044176ed8060300c4b70f1c2c5fe73b969d3455b",
"head_commit_message": "Refine the toString() method for too large tensor\n\n(cherry picked from commit 76f7186)",
"patch_to_review": "diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/tensor/DenseTensor.scala b/spark/dl/src/main/scala/com/... | [
{
"diff_hunk": "@@ -1438,26 +1438,63 @@ private[tensor] class DenseTensor[@specialized T: ClassTag](\n case 0 => s\"[${this.getClass.getName} with no dimension]\"\n case 1 =>\n val sb = new StringBuilder\n- this.apply1(e => {\n- sb.append(e).append('\\n')\n- e\n- ... | 10c66621d0b4031870e425e70e159060b7ad8ee1 | diff --git a/docs/docs/ScalaUserGuide/configuration.md b/docs/docs/ScalaUserGuide/configuration.md
index 091a183173e..5e0086a859e 100644
--- a/docs/docs/ScalaUserGuide/configuration.md
+++ b/docs/docs/ScalaUserGuide/configuration.md
@@ -38,4 +38,4 @@ Category|Property|Default value|Description
|bigdl.failure.retryTime... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
intel__ipex-llm-1490@1c2ec2a | intel/ipex-llm | Python | 1,490 | Add some more input/output docs to convolutions, rnns, recursive nns | ## What changes were proposed in this pull request?
Add some more input/output docs to convolutions, rnns, recursive nns
## Related links or issues (optional)
fixed https://github.com/intel-analytics/BigDL/issues/1478
| 2017-08-21T07:06:17Z | add input/output specifics for layers in mddocs
Some user complains layer input/output is not specified clearly in docs and difficult to use. We need to specify them in our md docs. Below is an example input/output spec for `convlstm`.
> The input tensor in forward(input) is expected to be a 5D tensor (batch x time x ... | please merge the modifications in master. | [
{
"body": "Some user complains layer input/output is not specified clearly in docs and difficult to use. We need to specify them in our md docs. Below is an example input/output spec for `convlstm`.\r\n> The input tensor in forward(input) is expected to be a 5D tensor (batch x time x nInputPlane x height x widt... | 7d0b4f17e50b2ece3648924875cd33693c773d8a | {
"head_commit": "1c2ec2a2bdb7925d342b028240f761b1c43a30a6",
"head_commit_message": "add some more input/output docs to convolutions, rnns, recursive nns",
"patch_to_review": "diff --git a/docs/docs/APIGuide/Layers/Convolution-Layers.md b/docs/docs/APIGuide/Layers/Convolution-Layers.md\nindex 54590cb1b68..6bd1c77... | [
{
"diff_hunk": "@@ -1049,7 +1065,12 @@ and the size of sizeTensor is used to set the size of the output (will ignore th\n adjH values used to construct the module). This module can be used without a bias by setting\n parameter noBias = true while constructing the module.\n \n-If input is a 4D tensor nInputPlane... | 8a18f448bee039a97769e1cd9a507fd2bcbff155 | diff --git a/docs/docs/APIGuide/Layers/Convolution-Layers.md b/docs/docs/APIGuide/Layers/Convolution-Layers.md
index 54590cb1b68..a89b0c8c8ac 100644
--- a/docs/docs/APIGuide/Layers/Convolution-Layers.md
+++ b/docs/docs/APIGuide/Layers/Convolution-Layers.md
@@ -13,6 +13,8 @@ SpatialConvolution is a module that applies a... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
getsentry__sentry-37989@79b17ed | getsentry/sentry | Python | 37,989 | feat(replays): Breadcrumb Icon Tab Navigation | ### Changes
- Adds click handler to breadcrumb icon that opens related tab
Closes #36803
<!--
Sentry employees and contractors can delete or ignore the following.
-->
### Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Fu... | 2022-08-18T13:00:35Z | Timeline Events should be clickable and open the relevant detailed tab
I want to be able to click on the event circle, and/or the content of the tooltip, and be taken into the related tab.
For PageLoad, LCP, Reload events the Network tab should be opened.
- In future we should scroll and highlight the specific row in ... | [
{
"body": "I want to be able to click on the event circle, and/or the content of the tooltip, and be taken into the related tab.\n\nFor PageLoad, LCP, Reload events the Network tab should be opened.\n- In future we should scroll and highlight the specific row in the network table. This highlight must be made ob... | 2b9dd402b7a9de4f968a7764b7c23049d5ecc702 | {
"head_commit": "79b17ed4851db11a84b36a0dbdc4ce2afae6299b",
"head_commit_message": "fix(replays): add tab nav handler to timeline nodes",
"patch_to_review": "diff --git a/static/app/components/replays/breadcrumbs/replayTimelineEvents.tsx b/static/app/components/replays/breadcrumbs/replayTimelineEvents.tsx\nindex... | [
{
"diff_hunk": "@@ -105,16 +107,41 @@ function Event({\n // We just need to stack up to 3 times\n const totalStackNumber = Math.min(crumbs.length, 3);\n \n+ // If there is only 1 event use the tab navigation handler on the node\n+ const nodeClickHandler = () => {\n+ if (crumbs.length === 1) {\n+ c... | f92b5fdeb6a26d49affb10bd78e35bc0ea2e889a | diff --git a/static/app/components/replays/breadcrumbs/replayTimelineEvents.tsx b/static/app/components/replays/breadcrumbs/replayTimelineEvents.tsx
index c35b9f63371496..29c33e35ec07bb 100644
--- a/static/app/components/replays/breadcrumbs/replayTimelineEvents.tsx
+++ b/static/app/components/replays/breadcrumbs/replay... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-37705@9839faf | getsentry/sentry | Python | 37,705 | fix(replays): SplitPanel conditional handlers | ### Changes
- Conditionally adds mouse event handlers to split panel if mousedown is engaged
Closes #36816
<!--
Sentry employees and contractors can delete or ignore the following.
-->
### Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of De... | 2022-08-11T14:08:08Z | Bug: SplitPanel should disable mouse event handlers when the pointer is not pressed
Currently the `<SplitPanel>` calls `useMouseTracking()` which unconditionally adds an `onMouseMove` handler (and others).
We don't need that handler being called unless the mouse button is actually being clicked. Therefore `useMouseTr... | [
{
"body": "Currently the `<SplitPanel>` calls `useMouseTracking()` which unconditionally adds an `onMouseMove` handler (and others).\n\nWe don't need that handler being called unless the mouse button is actually being clicked. Therefore `useMouseTracking()` should have an option that toggles it on/off. When it... | 7942cbdce70619aff4cc18615f50cf876444fd7f | {
"head_commit": "9839fafd58ef5dfc31cd4c2d7a511515c3c7e7b9",
"head_commit_message": "fix(replays): conditionally add event handlers if mousedown",
"patch_to_review": "diff --git a/static/app/views/replays/detail/layout/splitPanel.tsx b/static/app/views/replays/detail/layout/splitPanel.tsx\nindex dc7bf2341179d0..6... | [
{
"diff_hunk": "@@ -197,11 +197,15 @@ function SplitPanel(props: Props) {\n onPositionChange: handlePositionChange,\n });\n \n+ const activeTrackingProps = mousedown\n+ ? mouseTrackingProps\n+ : {ref: mouseTrackingProps.ref};",
"line": null,
"original_line": 202,
"original_start_line": ... | 1b74364607eeee256dcf62ad2c4e1d63c8ba4bd1 | diff --git a/static/app/views/replays/detail/layout/splitPanel.tsx b/static/app/views/replays/detail/layout/splitPanel.tsx
index dc7bf2341179d0..568d697647246a 100644
--- a/static/app/views/replays/detail/layout/splitPanel.tsx
+++ b/static/app/views/replays/detail/layout/splitPanel.tsx
@@ -197,11 +197,13 @@ function Sp... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
intel__ipex-llm-1102@e8e7400 | intel/ipex-llm | Python | 1,102 | [Issue 864] save module weights, load (all / part) module weights | ## What changes were proposed in this pull request?
load and save weights.
This is useful for finetuning, If you need to load weights into a different architecture (with some layers in common), for instance for fine-tuning or transfer-learning, you can load weights by layer name.
## How was this patch tested?
... | 2017-06-27T02:15:51Z | Load part of parameters from saved bigdl model
Now BigDL can load serialized BigDL model (without the model definition).
But it does not support loading part of parameters to an existing defined model.
Use case: Finetune a model.
Since many models are extension of some classic model, e.g. VGG16. As I want to fine... | In keras, they can save_weights and load_weights
```
model.save_weights('my_model_weights.h5')
model.load_weights('my_model_weights.h5')
```
If you need to load weights into a different architecture (with some layers in common), for instance for fine-tuning or transfer-learning, you can load weights by layer nam... | [
{
"body": "Now BigDL can load serialized BigDL model (without the model definition).\r\nBut it does not support loading part of parameters to an existing defined model.\r\n\r\nUse case: Finetune a model. \r\nSince many models are extension of some classic model, e.g. VGG16. As I want to finetune the whole model... | 0914440fb8dd9d3af592c95770282b971334bc9c | {
"head_commit": "e8e74002f15e79c7fa0b01dcaff2c4ed40554191",
"head_commit_message": "add support for loading from another model",
"patch_to_review": "diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/abstractnn/AbstractModule.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/abstractnn/... | [
{
"diff_hunk": "@@ -432,6 +432,75 @@ abstract class AbstractModule[A <: Activity: ClassTag, B <: Activity: ClassTag,\n }\n \n /**\n+ * save weights and bias to file\n+ * @param path file to save\n+ * @param overWrite whether to overwrite or not\n+ */\n+ def saveWeights(path: String, overWrite: Bool... | 7ea7d52e2b71d62fad2a00c0d3a07ac9e122f035 | diff --git a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/abstractnn/AbstractModule.scala b/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/abstractnn/AbstractModule.scala
index 836aef196d9..ff9d8b359a9 100644
--- a/spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/abstractnn/AbstractModule.scala
+++ b/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
great-expectations__great_expectations-10487@7c93de8 | great-expectations/great_expectations | Python | 10,487 | [MAINTENANCE] Remove `ipython` dependency |
- [x] Description of PR changes above includes a link to [an existing GitHub issue](https://github.com/great-expectations/great_expectations/issues)
- [x] PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
- [x] Code is linted - run `invoke lint` (uses `ruff format` + `ruff check... | 2024-10-08T15:16:20Z | Light Weight Install
**Is your feature request related to a problem? Please describe.**
In some deployment strategies there is no need to have the Jupiter dependencies installed.
Having the Jupiter (and associated dependencies) installed ends up prolonging the deployment cycle.
**Describe the solution you'd like*... | @JeroenSchmidt Thank you for posting this suggestion! This sounds like a more general case of https://github.com/great-expectations/great_expectations/issues/2688.
Marking this "in investigation", since this is an open discussion.
@jcampbell Please add you thoughts on the substance of this suggestion and its priori... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nIn some deployment strategies there is no need to have the Jupiter dependencies installed. \r\nHaving the Jupiter (and associated dependencies) installed ends up prolonging the deployment cycle.\r\n\r\n**Describe the solution you'd... | aac1e0a0d5915943c80fd16d9f453e6662fe042e | {
"head_commit": "7c93de84b057f8af9a94311ec7d1f3176eba324d",
"head_commit_message": "init commit",
"patch_to_review": "diff --git a/great_expectations/core/expectation_validation_result.py b/great_expectations/core/expectation_validation_result.py\nindex e2cb84f25265..de8c15b62752 100644\n--- a/great_expectations... | [
{
"diff_hunk": "@@ -98,38 +97,6 @@ def nested_update(\n return d\n \n \n-def in_jupyter_notebook():\n- try:\n- shell = get_ipython().__class__.__name__\n- if shell == \"ZMQInteractiveShell\":\n- return True # Jupyter notebook or qtconsole\n- elif shell == \"TerminalIntera... | 30c6b49e994cbf2cbcb4b8b1127d171e347c0cc2 | diff --git a/great_expectations/core/expectation_validation_result.py b/great_expectations/core/expectation_validation_result.py
index e2cb84f25265..de8c15b62752 100644
--- a/great_expectations/core/expectation_validation_result.py
+++ b/great_expectations/core/expectation_validation_result.py
@@ -1,6 +1,5 @@
from __f... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
great-expectations__great_expectations-10625@5dfea2a | great-expectations/great_expectations | Python | 10,625 | [BUGFIX] Stop masking config strings | This should be unneeded, and results in warnings if users don't have sqlalchemy supported (e.g. for ABS)
- [ ] Description of PR changes above includes a link to [an existing GitHub issue](https://github.com/great-expectations/great_expectations/issues)
- [ ] PR title is prefixed with one of: [BUGFIX], [FEATURE], [... | 2024-11-04T16:50:18Z | URL Masking not working for azure blob storage connection string
**Describe the bug**
I am currently getting constant warnings about not having SQL Alchemy installed when the mask_db_url for the following config_variables.yml entry:
AZURE_STORAGE_CONNECTION_STRING: "DefaultEndpointsProtocol=https;EndpointSuffix=cor... | Hi there! Thanks for bringing this to our attention. I've shared it with the team, so please keep an eye out for updates on this issue. | [
{
"body": "**Describe the bug**\r\nI am currently getting constant warnings about not having SQL Alchemy installed when the mask_db_url for the following config_variables.yml entry:\r\n\r\nAZURE_STORAGE_CONNECTION_STRING: \"DefaultEndpointsProtocol=https;EndpointSuffix=core.windows.net;AccountName=<redacted>;Ac... | d51f6c0e16ebcb7c5548a6381ab9d9e4e1c9839c | {
"head_commit": "5dfea2a1bc914635b44e4b42c9edc2c85f3d5b07",
"head_commit_message": "Update docstring",
"patch_to_review": "diff --git a/great_expectations/data_context/util.py b/great_expectations/data_context/util.py\nindex 1c02d27153da..35e2ae8403f3 100644\n--- a/great_expectations/data_context/util.py\n+++ b/... | [
{
"diff_hunk": "@@ -181,8 +181,19 @@ def mask_db_url(cls, url: str, use_urlparse: bool = False, **kwargs) -> str:\n Returns:\n url with password masked e.g. \"postgresql+psycopg2://username:***@host:65432/database\"\n \"\"\" # noqa: E501\n+\n+ from great_expectations.datasour... | 4c136b135920982fa887f5e0f23a8f339784e6c3 | diff --git a/great_expectations/data_context/util.py b/great_expectations/data_context/util.py
index f5cab7044903..d308b1386b4b 100644
--- a/great_expectations/data_context/util.py
+++ b/great_expectations/data_context/util.py
@@ -171,7 +171,7 @@ class PasswordMasker:
@classmethod
def mask_db_url(cls, url: st... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
intel__ipex-llm-774@3a37703 | intel/ipex-llm | Python | 774 | [Issue 621]Support set model in optimizer | ## What changes were proposed in this pull request?
1. add set model in optimizer
2. currently optimizer takes a long time to create and initialize, to avoid confusion, explicitly tell user it's loading data
## How was this patch tested?
unit test and manual test
## Related links or issues (optional)
fixed ht... | 2017-04-13T00:19:20Z | refactor the optimizer initialization process in python api
1. add *set_model()* to optimizer
Currently the model could only be set to optimizer during creation. That means we can't reuse an optimizer for different models. Creating optimizer may be time consuming sometimes.
1. add *prepare_input()* to optimizer
... | [
{
"body": "1. add *set_model()* to optimizer \r\nCurrently the model could only be set to optimizer during creation. That means we can't reuse an optimizer for different models. Creating optimizer may be time consuming sometimes. \r\n1. add *prepare_input()* to optimizer\r\nCurrently optimizer takes a long ti... | 9548fa22db245a4ed9ea594dc9df4a98ae128289 | {
"head_commit": "3a377033a8c6bdb65b5c5d03d04fd3df4cbcbef2",
"head_commit_message": "support set model in optimizer",
"patch_to_review": "diff --git a/pyspark/dl/optim/optimizer.py b/pyspark/dl/optim/optimizer.py\nindex 4a769e5edb3..b282b8f77d8 100644\n--- a/pyspark/dl/optim/optimizer.py\n+++ b/pyspark/dl/optim/o... | [
{
"diff_hunk": "@@ -677,6 +677,12 @@ class DistriOptimizer[T: ClassTag] (\n \n private var models: RDD[DistriOptimizer.Cache[T]] = null\n \n+ import DistriOptimizer._\n+ if (dataset.originRDD != null) {",
"line": null,
"original_line": 681,
"original_start_line": null,
"path": "spark/dl/src/... | ed409b342ff9285576ecbb026e5d58f4a7563746 | diff --git a/pyspark/dl/models/lenet/lenet5.py b/pyspark/dl/models/lenet/lenet5.py
index e2dd441535e..4ab94360d1f 100644
--- a/pyspark/dl/models/lenet/lenet5.py
+++ b/pyspark/dl/models/lenet/lenet5.py
@@ -86,13 +86,13 @@ def get_minst(sc, data_type="train", location="/tmp/mnist"):
state=state,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
getsentry__sentry-36193@9ba8c0b | getsentry/sentry | Python | 36,193 | feat(replays): Adds restart functionality to replays | ### Changes
- Adds isFinished boolean to replay context
- Adds restart function to replay context
- Updates UI to replace play/pause button with restart button when 'isFinished'
### Notes
This resolves a bug where you can keep hitting play after the video has ended and the current time keeps increasing and b... | 2022-06-29T14:57:59Z | Bug: Play button should be disabled on player when at the end of a replay
It currently allows you to play, and the timer jumps beyond the duration of the replay. At the min it should be disabled, but we probably want it to restart. | Routing to @getsentry/emerging-technology for [triage](https://develop.sentry.dev/processing-tickets/#3-triage). ⏲️ | [
{
"body": "It currently allows you to play, and the timer jumps beyond the duration of the replay. At the min it should be disabled, but we probably want it to restart.",
"number": 36139,
"title": "Bug: Play button should be disabled on player when at the end of a replay"
}
] | c4f098feb85171ab6978ed50a0b6c0fe9ccf8c27 | {
"head_commit": "9ba8c0b9a226a90ddc8872397cd19795f19fa774",
"head_commit_message": "feat(replays): adds restart btn when replay is finished",
"patch_to_review": "diff --git a/static/app/components/replays/replayContext.tsx b/static/app/components/replays/replayContext.tsx\nindex f6ffeac61d9a96..332aa290252499 10... | [
{
"diff_hunk": "@@ -379,6 +396,13 @@ export function Provider({children, replay, initialTimeOffset = 0, value = {}}:\n [getCurrentTime]\n );\n \n+ const restart = useCallback(() => {\n+ if (replayerRef.current) {\n+ replayerRef.current.play(0);\n+ setIsPlaying(true);\n+ }\n+ }, [replayer... | 20bb5cba35c0e47ac189738105a15b5f450951a6 | diff --git a/static/app/components/replays/replayContext.tsx b/static/app/components/replays/replayContext.tsx
index f6ffeac61d9a96..c436b2401f1202 100644
--- a/static/app/components/replays/replayContext.tsx
+++ b/static/app/components/replays/replayContext.tsx
@@ -73,6 +73,11 @@ type ReplayPlayerContextProps = {
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-34880@ef1f1b3 | getsentry/sentry | Python | 34,880 | feat(replays): added links to console timestamps so the scrubber can jump to those times | Closes #34824
Screenshots:
As illustrated in the video, you can click on the timestamps and you'll jump to that point in the video.
https://user-images.githubusercontent.com/7014871/169597180-caff2eaa-3b65-49b2-b1cf-1fabce8e979a.mov
<!-- Describe your PR here. -->
<!--
Sentry employees and c... | 2022-05-20T19:20:22Z | Link timestamps within the console view to the replay player.
### Problem Statement
Link timestamps within the console view to the replay player. Right now you can see a relative timestamp but you can't jump to it on the player.
### Solution Brainstorm
_No response_ | Routing to @getsentry/emerging-technology for [triage](https://develop.sentry.dev/processing-tickets/#3-triage). ⏲️ | [
{
"body": "### Problem Statement\n\nLink timestamps within the console view to the replay player. Right now you can see a relative timestamp but you can't jump to it on the player. \n\n### Solution Brainstorm\n\n_No response_",
"number": 34824,
"title": "Link timestamps within the console view to the re... | 3a4134ab1a8e1d44fc5126d5c3e8de8ae9bb255b | {
"head_commit": "ef1f1b31147e3bf447eca7969998155e2863b295",
"head_commit_message": "refactor: consolidated making the relative time to a variable",
"patch_to_review": "diff --git a/static/app/views/replays/detail/console/consoleMessage.tsx b/static/app/views/replays/detail/console/consoleMessage.tsx\nindex a1d82... | [
{
"diff_hunk": "@@ -59,17 +66,26 @@ function Console({breadcrumbs, startTimestamp = 0}: Props) {\n \n {filteredBreadcrumbs.length > 0 ? (\n <ConsoleTable>\n- {filteredBreadcrumbs.map((breadcrumb, i) => (\n- <ConsoleMessage\n- relativeTimestamp={showPlayerTime(\n- ... | ffc93062b66036c4f526512898f191318ff39b6e | diff --git a/static/app/views/replays/detail/console/consoleMessage.tsx b/static/app/views/replays/detail/console/consoleMessage.tsx
index a1d8246bb2ab15..e4d4521b28b2d1 100644
--- a/static/app/views/replays/detail/console/consoleMessage.tsx
+++ b/static/app/views/replays/detail/console/consoleMessage.tsx
@@ -6,6 +6,8 ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
great-expectations__great_expectations-6676@d250a49 | great-expectations/great_expectations | Python | 6,676 | [FEATURE] Support to include ID/PK in validation result for each row - Spark | ### Changes proposed in this pull request:
PySpark implementation of `unexpected_index_column`s value that allows users to specify a primary key (PK) column for identifying rows that failed an Expectation (usually returned as part of the `unexpected_index_list`). The PR also enables `unexpected_index_query` to be r... | 2022-12-30T06:09:29Z | Support to include ID/PK in validation result for each row that failed an expectations
**Is your feature request related to a problem? Please describe.**
When an expectation is run the output includes a “partial_unexpected_list” property of values that were unexpected. While this is useful, in most cases, it doesn't a... | This is a very important feature in my opinion, as Kenton mentioned, we will be able to not only identify the data quality and correctness on the data, but take action as well and help isolate erroneous rows rather than failing the entire dataset.
Thanks for submitting this issue, @KentonParton, and the follow-up, @Oma... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nWhen an expectation is run the output includes a “partial_unexpected_list” property of values that were unexpected. While this is useful, in most cases, it doesn't allow teams to identify, resolve, or divert data with poor quality.... | a110c61179b2bf96e0d9bd776f54762528128990 | {
"head_commit": "d250a49739d5ba621287cd985fbeeaaf7e9b862b",
"head_commit_message": "final update",
"patch_to_review": "diff --git a/great_expectations/expectations/expectation.py b/great_expectations/expectations/expectation.py\nindex 00e241b6276c..572007059e75 100644\n--- a/great_expectations/expectations/expec... | [
{
"diff_hunk": "@@ -2677,6 +2676,120 @@ def _spark_map_condition_rows(\n return filtered.limit(result_format[\"partial_unexpected_count\"]).collect()\n \n \n+def _spark_map_condition_index(\n+ cls,\n+ execution_engine: SparkDFExecutionEngine,\n+ metric_domain_kwargs: Dict,\n+ metric_value_kwargs... | fa1b8d92a6019975896f8415698548ce985c89eb | diff --git a/great_expectations/expectations/expectation.py b/great_expectations/expectations/expectation.py
index 00e241b6276c..f6f4dc21d711 100644
--- a/great_expectations/expectations/expectation.py
+++ b/great_expectations/expectations/expectation.py
@@ -73,6 +73,7 @@
from great_expectations.execution_engine impor... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-34972@49e484e | getsentry/sentry | Python | 34,972 | feat(replays): highlight console based on scrubber time | Closes #34844
Added row highlights to the console screen so you can tell what logs are relevant based on hovered scrubber position.
https://user-images.githubusercontent.com/7014871/170291923-07cfaa7a-a7c9-4ed5-b312-7dd6b601796a.mov
<!--
Sentry employees and contractors can delete or ignore the followi... | 2022-05-24T19:37:32Z | Console should highlight the most-recent row based on the current scrubber `hoverTime`
Like with the chapters component: when the scrubber is hovered we should highlight a row in the console that matches the hovered timestamp.
If there is no console message matching that exact timestamp, then we should highlight only ... | [
{
"body": "Like with the chapters component: when the scrubber is hovered we should highlight a row in the console that matches the hovered timestamp.\n\nIf there is no console message matching that exact timestamp, then we should highlight only console messages that are previous to the hovered-timestamp. \nie:... | 0993781bab07591c1659a4929c6f9b8b3e4a311a | {
"head_commit": "49e484e35d2139e18df8a93ff12b07467ad579fd",
"head_commit_message": "Merge branch 'master' into feat/replays/34844/console-row-highlight-impl",
"patch_to_review": "diff --git a/static/app/views/replays/detail/console/consoleMessage.tsx b/static/app/views/replays/detail/console/consoleMessage.tsx\n... | [
{
"diff_hunk": "@@ -123,8 +129,10 @@ const ConsoleTimestamp = styled(Common)<{isLast: boolean; level: string}>`\n cursor: pointer;\n `;\n \n-const Icon = styled(Common)`\n+const Icon = styled(Common)<{isActive: boolean}>`\n padding: ${space(0.5)} ${space(1)};\n+ border-left: 4px solid",
"line": null,
... | 431aa5d8bfa2d0dea533b9e5ef4ff0c1b714a12e | diff --git a/static/app/views/replays/detail/console/consoleMessage.tsx b/static/app/views/replays/detail/console/consoleMessage.tsx
index 3f86d355201ba5..609d36961bf3a6 100644
--- a/static/app/views/replays/detail/console/consoleMessage.tsx
+++ b/static/app/views/replays/detail/console/consoleMessage.tsx
@@ -66,10 +66... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-34823@de56567 | getsentry/sentry | Python | 34,823 | fix(replays): search is more robust now that we look inside of breadcrumb data. | Closes #34805
<img width="986" alt="image" src="https://user-images.githubusercontent.com/7014871/169409873-7ce69a99-0dfb-4a48-be4c-106f7886ad59.png">
<img width="493" alt="image" src="https://user-images.githubusercontent.com/7014871/169409893-a0938150-2859-400a-a947-bf9b9e43f890.png">
<img width="986" alt="imag... | 2022-05-19T21:45:23Z | Fix the replay details console search to look thru every aspect of the console log.
### Problem Statement
Search doesn't work quite right as certain parts of the message aren't found. Need to fix that so search works like a user would expect.
### Solution Brainstorm
_No response_ | Routing to @getsentry/emerging-technology for [triage](https://develop.sentry.dev/processing-tickets/#3-triage). ⏲️ | [
{
"body": "### Problem Statement\n\nSearch doesn't work quite right as certain parts of the message aren't found. Need to fix that so search works like a user would expect.\n\n### Solution Brainstorm\n\n_No response_",
"number": 34805,
"title": "Fix the replay details console search to look thru every a... | d9e850f2723a9d4919b0038d2f6cb59321eef295 | {
"head_commit": "de56567a57bbaf2cb2059ebbc9277f7c39b18093",
"head_commit_message": "refactor: made the filter function a first class function that just filters the breadcrumbs",
"patch_to_review": "diff --git a/static/app/views/replays/detail/console/index.tsx b/static/app/views/replays/detail/console/index.tsx\... | [
{
"diff_hunk": "@@ -21,20 +21,33 @@ interface Props {\n const getDistinctLogLevels = breadcrumbs =>\n Array.from(new Set<string>(breadcrumbs.map(breadcrumb => breadcrumb.level)));\n \n+export const filterBreadcrumbs = (\n+ breadcrumbs: BreadcrumbTypeDefault[],\n+ searchTerm: string,\n+ logLevel: Array<stri... | 69d44ed3f26fa7135b2942a6235e100570b1031a | diff --git a/static/app/views/replays/detail/console/index.tsx b/static/app/views/replays/detail/console/index.tsx
index 16a166fc2c1039..02e4eb1dfb0b9f 100644
--- a/static/app/views/replays/detail/console/index.tsx
+++ b/static/app/views/replays/detail/console/index.tsx
@@ -11,6 +11,7 @@ import {BreadcrumbLevelType, Br... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
great-expectations__great_expectations-2422@99b5380 | great-expectations/great_expectations | Python | 2,422 | [BUGFIX] Missing `markown_text.j2` jinja template | Changes proposed in this pull request:
- adds missing `markdown_text.j2` jinja template
- some formatting changes for better rendering in Markdown. This includes `markdown_collapse.j2`, which now renders `collapse` content blocks as indented header blocks, rather than just a level-4 header.
- the message in `markdo... | 2021-02-10T01:42:21Z | Missing markown_text jinja template
**Describe the bug**
I am trying to render our JSON expectations to markdown. I followed a tutorial that showed how to do that for validation results but I think a jinja template is missing.
Here is the traceback:
```
~/Library/Caches/pypoetry/virtualenvs/ge-MUDrC1sS-py3.7/lib/... | Thank you for reporting this, @lccambiaghi ! We are going to triage this issue within next couple of days.
@lccambiaghi Could you please post the link to the tutorial that you followed? Thank you!
This does look like a bug. Adding to the core team's queue.
I adapted the code from this util function: https://github.c... | [
{
"body": "**Describe the bug**\r\nI am trying to render our JSON expectations to markdown. I followed a tutorial that showed how to do that for validation results but I think a jinja template is missing.\r\n\r\nHere is the traceback:\r\n```\r\n~/Library/Caches/pypoetry/virtualenvs/ge-MUDrC1sS-py3.7/lib/python3... | 140dd50e751ffc1565eb6b5b1d91e8b590224363 | {
"head_commit": "99b538078dad6156e6e5ed38ddc01be18e97c486",
"head_commit_message": "Extra comment is removed now",
"patch_to_review": "diff --git a/great_expectations/render/view/templates/markdown_collapse.j2 b/great_expectations/render/view/templates/markdown_collapse.j2\nindex 4f34ef0b4741..e139371461ef 10064... | [
{
"diff_hunk": "@@ -0,0 +1,15 @@\n+{% if not content_block_body_styling and content_block.get(\"styling\") %}\n+ {% set content_block_body_styling = content_block.get(\"styling\") | render_styling %}\n+{% endif %}\n+\n+<div id=\"{{content_block_id}}-body\" {{ content_block_body_styling | replace(\"{{section_... | f8ddfe858ef93894f6eb3c4642116846ad9d443f | diff --git a/great_expectations/render/view/templates/markdown_collapse.j2 b/great_expectations/render/view/templates/markdown_collapse.j2
index 4f34ef0b4741..e139371461ef 100644
--- a/great_expectations/render/view/templates/markdown_collapse.j2
+++ b/great_expectations/render/view/templates/markdown_collapse.j2
@@ -1... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
great-expectations__great_expectations-2994@9d65eda | great-expectations/great_expectations | Python | 2,994 | [BUGFIX] [batch.py] fix check for null value | Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING].... | 2021-07-05T14:35:54Z | ValueError on RunTimeBatchRequest.get_json_dict with a pandas df
**Describe the bug**
If you try to get a dict for a RunTimeBatchRequest with a pandas dataframe, you get `ValueError: The truth value of a PandasDataset is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().`
**To Reproduce**
```
from gr... | @majidaldo Thank you for creating this issue! I see that you are trying to serialize the RuntimeBatchRequest. Could you show the broader context of this code snippet?
> @majidaldo Thank you for creating this issue! I see that you are trying to serialize the RuntimeBatchRequest. Could you show the broader context of th... | [
{
"body": "**Describe the bug**\r\nIf you try to get a dict for a RunTimeBatchRequest with a pandas dataframe, you get `ValueError: The truth value of a PandasDataset is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().`\r\n\r\n**To Reproduce**\r\n```\r\nfrom great_expectations.core.batch import R... | 24564468c6ffa33cd77857620b14ab4ca8c46ea6 | {
"head_commit": "9d65eda25c8ca2af1afaf8877796dd2956c9ffc7",
"head_commit_message": "precommit",
"patch_to_review": "diff --git a/great_expectations/core/batch.py b/great_expectations/core/batch.py\nindex cb093bd22246..bd324f6f9d89 100644\n--- a/great_expectations/core/batch.py\n+++ b/great_expectations/core/batc... | [
{
"diff_hunk": "@@ -258,7 +258,9 @@ def get_json_dict(self) -> dict:\n json_dict[\"batch_identifiers\"] = self.batch_identifiers\n if self.runtime_parameters is not None:\n json_dict[\"runtime_parameters\"] = self.runtime_parameters\n- if json_dict[\"runtime_parameters... | 8e3fb9bed2444872f22943e22ab9b9e4ca1ea103 | diff --git a/great_expectations/core/batch.py b/great_expectations/core/batch.py
index cb093bd22246..901aea7af8df 100644
--- a/great_expectations/core/batch.py
+++ b/great_expectations/core/batch.py
@@ -258,7 +258,7 @@ def get_json_dict(self) -> dict:
json_dict["batch_identifiers"] = self.batch_identifiers... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
great-expectations__great_expectations-3257@8aa40d3 | great-expectations/great_expectations | Python | 3,257 | [WIP] [FEATURE] add backend args to run_diagnostics | Fixes #3224
There are many features that are supported in most SQL dialects but not sqlite, it would be useful to have tests for other dialects set to run in Expectation.run_diagnostics.
I welcome suggestions for a cleaner implementation, but because the backends list is currently constructed before iterating o... | 2021-08-16T22:13:19Z | Allow run_diagnostics to specify a different SQLAlchemy backend
**Is your feature request related to a problem? Please describe.**
Many computations aren't supported in sqlite (for example, I'm not sure the core standard deviation expectation works). It would be nice to set a different backend for the unit tests for t... | Hi @edjoesu - thanks for raising this issue! This sounds like an excellent idea, though not something we'd be able to prioritize building internally right now. Is this something you'd have an interest in contributing? I'm happy to offer any guidance/support/review you'd need. Just let me know how I can help.
@talagluck... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nMany computations aren't supported in sqlite (for example, I'm not sure the core standard deviation expectation works). It would be nice to set a different backend for the unit tests for these expectations, or at least easily add M... | 45fe510e750c3df66cc9fcb837112d72c4c40af3 | {
"head_commit": "8aa40d342bc27b165ea2970ee923c7b3b760977f",
"head_commit_message": "Merge branch 'develop' into feature/backend-args-for-diagnostics",
"patch_to_review": "diff --git a/contrib/experimental/great_expectations_experimental/expectations/expect_column_skew_to_be_between.py b/contrib/experimental/grea... | [
{
"diff_hunk": "@@ -400,5 +464,7 @@ def _validate(\n \n \n if __name__ == \"__main__\":\n- self_check_report = ExpectColumnSkewToBeBetween().run_diagnostics()\n+ self_check_report = ExpectColumnSkewToBeBetween().run_diagnostics(\n+ execution_engine_args={\"include_mysql\": True}",
"line": null,... | de62454797ad304087c0f923a6d8041929892b14 | diff --git a/contrib/experimental/great_expectations_experimental/expectations/expect_column_skew_to_be_between.py b/contrib/experimental/great_expectations_experimental/expectations/expect_column_skew_to_be_between.py
index c0dc1b1f6932..836bf8fa3cbc 100644
--- a/contrib/experimental/great_expectations_experimental/ex... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
great-expectations__great_expectations-4042@84b4929 | great-expectations/great_expectations | Python | 4,042 | [BUGFIX] Fix s3 path suffix bug on windows | Resolves #4022
Changes proposed in this pull request:
- Updates ``InferredAssetS3DataConnector`` to use a custom file path sanitizer that does not rely on the host OS, but assumes (according to S3 convention) a ``/`` separator.
### Definition of Done
- [x] My code follows the Great Expectations [style guide]... | 2022-01-21T20:43:26Z | S3 prefixes get broken when running on Windows
**Describe the bug**
On Windows when referencing an S3 data source, the prefix is suffixed with ``\`` instead of ``/``, resulting in query always failing.
**To Reproduce**
Create a ``InferredAssetS3DataConnector`` data connector, and pass any valid prefix (probably ne... | Howdy @scnerd, thanks for reaching out. I'm bringing this up with the team, we'll let keep you informed.
@AFineDayFor Working on a PR for this as well. | [
{
"body": "**Describe the bug**\r\nOn Windows when referencing an S3 data source, the prefix is suffixed with ``\\`` instead of ``/``, resulting in query always failing.\r\n\r\n**To Reproduce**\r\nCreate a ``InferredAssetS3DataConnector`` data connector, and pass any valid prefix (probably needs to be non-empty... | fb99cfed10a5a07e1010f0e5b36f3e6eede12f5a | {
"head_commit": "84b4929a391d393225ed3bd68b5fc20570e4d967",
"head_commit_message": "Added docstring",
"patch_to_review": "diff --git a/great_expectations/datasource/data_connector/inferred_asset_s3_data_connector.py b/great_expectations/datasource/data_connector/inferred_asset_s3_data_connector.py\nindex 0437bea... | [
{
"diff_hunk": "@@ -93,6 +93,22 @@ def __init__(\n \"Unable to load boto3 (it is required for InferredAssetS3DataConnector).\"\n )\n \n+ @staticmethod\n+ def sanitize_prefix(text: str) -> str:",
"line": null,
"original_line": 97,
"original_start_line": null,
"pa... | 886af495a046a79c6fe58ee211f1652310df5767 | diff --git a/great_expectations/datasource/data_connector/configured_asset_s3_data_connector.py b/great_expectations/datasource/data_connector/configured_asset_s3_data_connector.py
index b68da6797cf7..6f11c3b107a7 100644
--- a/great_expectations/datasource/data_connector/configured_asset_s3_data_connector.py
+++ b/grea... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
geldata__gel-8747@9b834a5 | geldata/gel | Python | 8,747 | Support creating indexes concurrently | The implementation in this PR works well and is solid, but there is plenty of room for us to argue about whether the interface is good enough.
The core idea, though, is to have an index field called `create_concurrently` that indicates that an index should be created concurrently, and then there will be a separate C... | 2025-05-29T20:03:18Z | Concurrent index creation
Postgres supports `CREATE INDEX CONCURRENTLY`, and it would be good if we can do something similar.
The two big hurdles are:
- How should it interact with our migration system
- `CREATE INDEX CONCURRENTLY` does not work in a transaction, and we always do our DDL transactionally now | [
{
"body": "Postgres supports `CREATE INDEX CONCURRENTLY`, and it would be good if we can do something similar.\r\n\r\nThe two big hurdles are:\r\n - How should it interact with our migration system\r\n - `CREATE INDEX CONCURRENTLY` does not work in a transaction, and we always do our DDL transactionally now\r\n... | 272a7fd7baa25d64722c79559ac3d1b5b3258cb6 | {
"head_commit": "9b834a5a6aaabdf83f2d1fbd4ca503d7301294a1",
"head_commit_message": "lint",
"patch_to_review": "diff --git a/dev-notes/concurrent-indexes.py b/dev-notes/concurrent-indexes.py\nnew file mode 100644\nindex 00000000000..02abec1af4b\n--- /dev/null\n+++ b/dev-notes/concurrent-indexes.py\n@@ -0,0 +1,39 ... | [
{
"diff_hunk": "@@ -1839,6 +1840,108 @@ def administer_prepare_upgrade(\n )\n \n \n+def _get_index(\n+ ctx: compiler.CompileContext,\n+ ql: qlast.AdministerStmt,\n+) -> tuple[s_indexes.Index, s_schema.Schema]:\n+ if len(ql.expr.args) != 1 or ql.expr.kwargs:\n+ raise errors.QueryError(\n+ ... | 98fee5576971c887e431c6892155cd2fa84b9a4c | diff --git a/dev-notes/concurrent-indexes.py b/dev-notes/concurrent-indexes.py
new file mode 100644
index 00000000000..fc1d4dbe0a3
--- /dev/null
+++ b/dev-notes/concurrent-indexes.py
@@ -0,0 +1,39 @@
+#!/usr/bin/env python3
+
+import gel
+
+def create_concurrent_indexes(db, msg_callback=print):
+ '''Actually create ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
getsentry__sentry-33152@a7e489b | getsentry/sentry | Python | 33,152 | feat(replay): Load all events with a given replayId on the details page | Fetch all events associated with the given root replay, and then render N `<Spans/>` and `<Breadcrumbs/>`, one for each related `sentry-replay-event`.
I put one instance of the `<TagsTable/>` because the tags for every set of `sentry-replay` events should be the same... as the data model evolves that will be a guara... | 2022-03-30T21:05:08Z | Fetch and render all replay events' spans and breadcrumbs
Currently we will have a transaction with name `sentry-replay` that represents the root event that will contain a collection of replays. This will be tagged with a `replayId` that spans other events as well.
This will be temporary, but when we load the detail... | [Failed](https://github.com/getsentry/sentry/actions/runs/2065832394) to route to `Team: Replays`. 😕
Defaulting to @getsentry/open-source for [triage](https://develop.sentry.dev/processing-tickets/#3-triage). ⏲️ | [
{
"body": "Currently we will have a transaction with name `sentry-replay` that represents the root event that will contain a collection of replays. This will be tagged with a `replayId` that spans other events as well.\r\n\r\nThis will be temporary, but when we load the details for a replay, let's fetch all tra... | 7e428fb52fea35579f1c47b40d3cb5fa7f99e95c | {
"head_commit": "a7e489b8b559a6b7efad0c262bba3041c2c7e267",
"head_commit_message": "feat(replay): Load all events with a given replayId on the details page",
"patch_to_review": "diff --git a/static/app/routes.tsx b/static/app/routes.tsx\nindex ca14021e7fcda4..df3bff3af19d28 100644\n--- a/static/app/routes.tsx\n+... | [
{
"diff_hunk": "@@ -0,0 +1,122 @@\n+import {RouteComponentProps, withRouter} from 'react-router';\n+import styled from '@emotion/styled';\n+import first from 'lodash/first';\n+\n+import AsyncComponent from 'sentry/components/asyncComponent';\n+import EventOrGroupTitle from 'sentry/components/eventOrGroupTitle';... | 1f2544c32216191011f0415370b313d216144caf | diff --git a/static/app/views/replays/details.tsx b/static/app/views/replays/details.tsx
index cefce32aa94e8a..1f0c7cc25f70ce 100644
--- a/static/app/views/replays/details.tsx
+++ b/static/app/views/replays/details.tsx
@@ -1,35 +1,54 @@
+import React from 'react';
import {RouteComponentProps} from 'react-router';
imp... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
getsentry__sentry-24183@9cdaec5 | getsentry/sentry | Python | 24,183 | fix(cli): Create user fails with --force-update | Fixes #19139.
| 2021-03-02T19:33:12Z | createuser: Error when trying to --force-update user
`createuser` fails when run against an existing user.
```
$ sudo docker-compose run --rm web sentry --version
sentry, version 10.1.0.dev0 (0bf9ffa08ff2)
$ sudo docker-compose run --rm web sentry createuser --email testuser@test.com --password pass1 --no-superu... | We have the same issue.
same thing
I experienced that issue too. The whole redis configuration went down causing downtime.
`root@sentry-web:/# sentry createuser
09:03:05 [WARNING] sentry.utils.geo: settings.GEOIP_PATH_MMDB not configured.
09:03:13 [INFO] sentry.plugins.github: apps-not-configured
Email: admin@sentr... | [
{
"body": "`createuser` fails when run against an existing user. \r\n\r\n```\r\n$ sudo docker-compose run --rm web sentry --version\r\nsentry, version 10.1.0.dev0 (0bf9ffa08ff2)\r\n$ sudo docker-compose run --rm web sentry createuser --email testuser@test.com --password pass1 --no-superuser --no-input --force-u... | 46b4ec488fb4b5037456198147fe2f071abfc1ba | {
"head_commit": "9cdaec5a149010c90f0563a789a09f7fec98bc3b",
"head_commit_message": "don't use create_user",
"patch_to_review": "diff --git a/src/sentry/runner/commands/createuser.py b/src/sentry/runner/commands/createuser.py\nindex 96853014dd128a..5baaa1adebc557 100644\n--- a/src/sentry/runner/commands/createuse... | [
{
"diff_hunk": "@@ -69,23 +69,27 @@ def createuser(email, password, superuser, no_password, no_input, force_update):\n from sentry.models import User\n from django.conf import settings\n \n- user = User(\n+ fields = dict(\n email=email, username=email, is_superuser=superuser, is_staff=supe... | 1d733a0cd80098eb695f18cded8d68bfa985f475 | diff --git a/src/sentry/runner/commands/createuser.py b/src/sentry/runner/commands/createuser.py
index 96853014dd128a..3aad3eb4fc5808 100644
--- a/src/sentry/runner/commands/createuser.py
+++ b/src/sentry/runner/commands/createuser.py
@@ -69,23 +69,26 @@ def createuser(email, password, superuser, no_password, no_input,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
geldata__gel-8121@d6ad3b8 | geldata/gel | Python | 8,121 | Add TOML config file support | Sample TOML config file:
```toml
["cfg::Config"]
session_idle_timeout = "1 minute"
shared_buffers = "128MiB"
_pg_prepared_statement_cache_size = 10
listen_port = 5858
[[magic_smtp_config]]
_tname = "cfg::SMTPProviderConfig"
name = "gmail"
sender = "alice@example.com"
port = 587
security = "STARTTLS"
... | 2024-12-13T20:05:31Z | Allow reading configuration from a local file
Need an option to read server configuration from a specified JSON file in the local filesystem.
Per-tenant configuration in multitenant
I think there are two components here:
- [ ] Per tenant "environmental" configuration, where we can do the equivalent of passing conf... | Please use Hjson or Yaml. JSON configs are still ugly in 2020.
Truth be told, using YAML is also controversial. I've seen numerous comments on HN/GH with people complaining that whitespace-only nature of YAML makes it hard for some people to edit it. 🤷♂️ This is a bit painful to admit for me since both Elvis and I ar... | [
{
"body": "Need an option to read server configuration from a specified JSON file in the local filesystem. ",
"number": 1325,
"title": "Allow reading configuration from a local file"
},
{
"body": "I think there are two components here:\r\n\r\n- [ ] Per tenant \"environmental\" configuration, whe... | c4e5e4ce55898b1ce080fc0aa07224aefd2e48d7 | {
"head_commit": "d6ad3b8ca56e8e0fb090f898258d9d0a78860417",
"head_commit_message": "Add TOML config file support",
"patch_to_review": "diff --git a/edb/common/asyncutil.py b/edb/common/asyncutil.py\nindex 7d439a6172c..461859076ae 100644\n--- a/edb/common/asyncutil.py\n+++ b/edb/common/asyncutil.py\n@@ -18,9 +18,... | [
{
"diff_hunk": "@@ -965,11 +1025,26 @@ async def acquire_pgcon(self, dbname: str) -> pgcon.PGConnection:\n \n for _ in range(self._pg_pool.max_capacity):\n conn = await self._pg_pool.acquire(dbname)\n- if conn.is_healthy():\n- return conn\n+ if not conn.i... | f215d0c7b91fa66bb3fb0a2a2512eb6841d7e1fd | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index dd944f10e9e..a932bf85d71 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -60,7 +60,7 @@
# The merge conflict there is a nice reminder that you probably need
# to write a patch in edb/pgsql/patches.py, and then you should preserve
# the old value.
-EDGEDB... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
geldata__gel-7158@5a7b775 | geldata/gel | Python | 7,158 | Add cfg::Config._query_cache_mode | Now users may control the cache mode per statement or database. Changing the effective mode on a database will clear its cache registration table.
Fixes #7102, replaces #7122 | 2024-04-04T19:23:58Z | Add a temporary config to switch query cache mode
Before the end goal of proper persistent query cache is achieved with Postgres functions, we'd like to have a config to control the cache mode the server is running in, that is `Config._query_cache_mode`, which is an enum of:
* `IN_MEMORY` - query cache lives in memo... | Looks good Fantix! | [
{
"body": "Before the end goal of proper persistent query cache is achieved with Postgres functions, we'd like to have a config to control the cache mode the server is running in, that is `Config._query_cache_mode`, which is an enum of:\r\n\r\n* `IN_MEMORY` - query cache lives in memory and resets on server res... | 6740474f83bb98dd178a638d97796acb879bd141 | {
"head_commit": "5a7b7755cdee5ef6639ef1d6d26e62f01b4a242a",
"head_commit_message": "Add cfg::Config._query_cache_mode",
"patch_to_review": "diff --git a/edb/buildmeta.py b/edb/buildmeta.py\nindex b1f10353d1a..b7abee1f611 100644\n--- a/edb/buildmeta.py\n+++ b/edb/buildmeta.py\n@@ -55,7 +55,7 @@\n \n \n # Incremen... | [
{
"diff_hunk": "@@ -192,6 +194,13 @@ ALTER TYPE cfg::AbstractConfig {\n 'Recompile all cached queries on DDL if enabled.';\n };\n \n+ CREATE PROPERTY _query_cache_mode -> cfg::QueryCacheMode {",
"line": null,
"original_line": 197,
"original_start_line": null,
"path": "edb/lib/... | bfeb1354549cb07ca2352290fd686754324fbe4c | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index b1f10353d1a..b7abee1f611 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -55,7 +55,7 @@
# Increment this whenever the database layout or stdlib changes.
-EDGEDB_CATALOG_VERSION = 2024_04_02_00_00
+EDGEDB_CATALOG_VERSION = 2024_04_04_00_00
EDGEDB_MAJOR... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
geldata__gel-7228@f8fb856 | geldata/gel | Python | 7,228 | Remove type simplification from schema. | close #7221
Make type simplification for schema utils `ensure_union_type` and `ensure_intersection_type` explicit. Remove the type simplification when generating types from a user schema.
When creating types from a schema, the implicit simplification can cause an error when the name of the simplified type differs... | 2024-04-19T00:46:44Z | Property or link with union type of type and a derived type produces error
Given the schema
```
type A;
type A_ extending A;
type Bad {
property foo -> A | A_;
};
```
The following error is produced:
```
SchemaError: object type 'default::A' already exists
```
Given the schema
```
type... | [
{
"body": "Given the schema\r\n```\r\n type A;\r\n type A_ extending A;\r\n\r\n type Bad {\r\n property foo -> A | A_;\r\n };\r\n```\r\n\r\nThe following error is produced:\r\n```\r\nSchemaError: object type 'default::A' already exists\r\n```\r\n\r\nGiven the schema\r\n```\r\n type A;\r\n type A_ exten... | 18d755d2d883beeb26a62ba2ef3832c61d041ffa | {
"head_commit": "f8fb85667c366ced34a9d6a06985042460a4e10d",
"head_commit_message": "Add test.",
"patch_to_review": "diff --git a/edb/edgeql/compiler/schemactx.py b/edb/edgeql/compiler/schemactx.py\nindex 48b952aef9c..3aa74a3ddf4 100644\n--- a/edb/edgeql/compiler/schemactx.py\n+++ b/edb/edgeql/compiler/schemactx.... | [
{
"diff_hunk": "@@ -4029,6 +4029,18 @@ def test_schema_get_migration_union_ptrs_01(self):\n \n self._assert_migration_consistency(schema)\n \n+ def test_schema_get_migration_union_ptrs_02(self):\n+ schema = r'''\n+ type A;\n+ type A_ extending A;\n+ type B;\n+ type ... | f42b50189697f504a8a62a47c975fe229eeb35bc | diff --git a/edb/edgeql/compiler/schemactx.py b/edb/edgeql/compiler/schemactx.py
index 48b952aef9c..3aa74a3ddf4 100644
--- a/edb/edgeql/compiler/schemactx.py
+++ b/edb/edgeql/compiler/schemactx.py
@@ -396,16 +396,26 @@ def derive_view_name(
def get_union_type(
- types: Iterable[s_types.TypeT],
+ types: Seque... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-25676@48bff41 | getsentry/sentry | Python | 25,676 | feat(direnv): direnv usability improvements | If the Python venv is not set up correctly we call `bootstrap-py3-venv` (we prompt the user first) even if it takes long. We call it once and we get into a good state.
Prompt when `.venv` is missing:
<img width="741" alt="image" src="https://user-images.githubusercontent.com/44410/116594050-cd4da500-a8ef-11eb-9266-... | 2021-04-27T19:16:08Z | direnv usability improvements
Suggested fixes:
- If there are steps that take short time simply take them.
- Give a list of commands in one shot (instead of requiring multiple direnv invocations) to get into a good state.
- Share code paths between `direnv` and `lib.sh`
- Take advantage of `bootstrap-py3-venv` | for posterity: <img width="586" alt="image" src="https://user-images.githubusercontent.com/14209781/115909462-19659900-a45b-11eb-8666-c4129dc0895e.png"> | [
{
"body": "Suggested fixes:\r\n\r\n- If there are steps that take short time simply take them.\r\n- Give a list of commands in one shot (instead of requiring multiple direnv invocations) to get into a good state.\r\n- Share code paths between `direnv` and `lib.sh`\r\n- Take advantage of `bootstrap-py3-venv`",
... | 0282f39f9c9f4b9a3e363c639cd7dc06eaaa1cdf | {
"head_commit": "48bff41f951c9cb1a5ac17d067fb9b3b7ecf83f6",
"head_commit_message": "Comment adjustment",
"patch_to_review": "diff --git a/.envrc b/.envrc\nindex ad98f8774cae27..b87a9c84062d99 100644\n--- a/.envrc\n+++ b/.envrc\n@@ -19,6 +19,7 @@ trap notice ERR\n # This is used to group issues on Sentry.io.\n # ... | [
{
"diff_hunk": "@@ -47,19 +48,23 @@ require() {\n command -v \"$1\" >/dev/null 2>&1\n }\n \n-warn() {\n+debug() {\n+ if [ \"${SENTRY_DIRENV_NOISY}\" ]; then\n+ echo \"${@}\"\n+ fi\n+}\n+\n+info() {\n cat <<EOF\n-${yellow}${bold}direnv: ${@}${reset}",
"line": 52,
"original_line": 52,... | 8b59360526cc972dd55aa6b005f196b43c54ee8b | diff --git a/.envrc b/.envrc
index ad98f8774cae27..aee28840f2796b 100644
--- a/.envrc
+++ b/.envrc
@@ -19,17 +19,29 @@ trap notice ERR
# This is used to group issues on Sentry.io.
# If an issue does not call info() or die() it will be grouped under this
error_message="Unknown issue"
+# This has to be the same value ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
getsentry__sentry-22728@8cca5a0 | getsentry/sentry | Python | 22,728 | Require developers to explicitly request using a different Python 3 v… | …ersion
The developer is now warned if they are using a Python version different than 3.6.
The developer will need to explicitely set `PYTHON_VERSION` if they wish to use a different
Python version.
Fixes #22724 | 2020-12-16T15:20:07Z | Require developers to explicit request using different Python 3 version
I see many folks ending up using Python 3.8 and 3.9 by mistake in their venvs that causes Python package installation issues.
I will be changing it to require setting an env variable explicitly (`ALLOW_NON_DEFAULT_PYTHON_VERSION` or `PYTHON_VERS... | [
{
"body": "I see many folks ending up using Python 3.8 and 3.9 by mistake in their venvs that causes Python package installation issues.\r\n\r\nI will be changing it to require setting an env variable explicitly (`ALLOW_NON_DEFAULT_PYTHON_VERSION` or `PYTHON_VERSION`).",
"number": 22724,
"title": "Requi... | 302f559eb04d63d77079628afa4ac57edc4872b0 | {
"head_commit": "8cca5a040cabb5211636a956706aa5d55a2c1b4e",
"head_commit_message": "Red and exit 1",
"patch_to_review": "diff --git a/scripts/ensure-venv.sh b/scripts/ensure-venv.sh\nindex 82d5d3ce160646..b5fd35f0d7b643 100755\n--- a/scripts/ensure-venv.sh\n+++ b/scripts/ensure-venv.sh\n@@ -6,6 +6,7 @@ if [[ \"$... | [
{
"diff_hunk": "@@ -40,10 +41,26 @@ EOF\n # If .venv is less than Python 3.6 fail\n [[ \"$minor\" -lt 6 ]] &&\n die \"Remove $VIRTUAL_ENV and try again since the Python version installed should be at least 3.6.\"\n- # If .venv is created with Python 3.9 or higher you might enc... | bf6915e4d452cddd18bee9a537d2f7970d59336f | diff --git a/scripts/ensure-venv.sh b/scripts/ensure-venv.sh
index 82d5d3ce160646..618614933af60c 100755
--- a/scripts/ensure-venv.sh
+++ b/scripts/ensure-venv.sh
@@ -6,6 +6,7 @@ if [[ "$SENTRY_NO_VIRTUALENV_CREATION" == "1" ]]; then
exit 0
fi
+red="$(tput setaf 1)"
yellow="$(tput setaf 3)"
bold="$(tput bold)... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
geldata__gel-7123@4d07767 | geldata/gel | Python | 7,123 | Add error when enum length exceeds 63 | Works for both SDL and DDL.
Note: it is possible to change this max length in a custom postgres build.
Close #6186 | 2024-03-27T13:49:46Z | InternalServerError on long enum labels
<!-- Please search existing issues to avoid creating duplicates. -->
<!--
For the EdgeDB Version: run `edgedb query 'select sys::get_version_as_str()'` from your project directory (or run `select sys::get_version_as_str();` in the EdgeDB interactive shell).
For the EdgeDB CL... | This is a Postgres limitation, I believe, but we ought to produce a nicer error of course. | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n\r\n<!--\r\nFor the EdgeDB Version: run `edgedb query 'select sys::get_version_as_str()'` from your project directory (or run `select sys::get_version_as_str();` in the EdgeDB interactive shell).\r\nFor the EdgeDB CLI Version: Ru... | ac9264a2381592927bdbbb05cce7dbdb6309e276 | {
"head_commit": "4d077674746299c726d93200c030f61ec64b1280",
"head_commit_message": "Add max_enum_label_length enum.",
"patch_to_review": "diff --git a/docs/stdlib/enum.rst b/docs/stdlib/enum.rst\nindex cf8110e72b7..2a8850d71b6 100644\n--- a/docs/stdlib/enum.rst\n+++ b/docs/stdlib/enum.rst\n@@ -50,3 +50,5 @@ Enum... | [
{
"diff_hunk": "@@ -47,6 +47,12 @@\n from . import keywords as pg_keywords\n \n \n+# This is a postgres limitation.\n+# Note that this can be overridden in custom builds.\n+# https://www.postgresql.org/docs/current/datatype-enum.html\n+max_enum_label_length = 63",
"line": null,
"original_line": 53,
... | 230c9f7d27d52b9171e847316ca86902e54b9107 | diff --git a/docs/stdlib/enum.rst b/docs/stdlib/enum.rst
index cf8110e72b7..2a8850d71b6 100644
--- a/docs/stdlib/enum.rst
+++ b/docs/stdlib/enum.rst
@@ -50,3 +50,5 @@ Enums
properly reflected. To address this, consider using only
identifier-like enum values in cases where such compatibility
i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
geldata__gel-7082@a9ddeb5 | geldata/gel | Python | 7,082 | Separate triggers by kind in compilation. | Fix #5794
When checking for recursive triggers, the compilation now checks `insert`, `update`, and `delete` separately.
Given the schema in #5794, running the following:
```
insert Theme {name := "hello"};
update Theme filter Theme.name = "hello" set {name := "world
"};
select Theme {*}
```
Produces:
``... | 2024-03-19T23:24:03Z | [Triggers] False positive recursive trigger
<!-- Please search existing issues to avoid creating duplicates. -->
<!--
For the EdgeDB Version: run `edgedb query 'select sys::get_version_as_str()'` from your project directory (or run `select sys::get_version_as_str();` in the EdgeDB interactive shell).
For the EdgeD... | I have same error when using `when` clause (https://github.com/edgedb/edgedb/pull/6184)
```edgeql
type User {
link chats := .<members[is ChatBase];
multi chat_memberships: ChatMembership {
on source delete delete target;
constraint exclusive;
};
trigger RequireChatsMembership after insert, u... | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n\r\n<!--\r\nFor the EdgeDB Version: run `edgedb query 'select sys::get_version_as_str()'` from your project directory (or run `select sys::get_version_as_str();` in the EdgeDB interactive shell).\r\nFor the EdgeDB CLI Version: Ru... | bca75465306e034a45e1ad3166b6581cb3a5698d | {
"head_commit": "a9ddeb5c501873049c045cef1dbbfb33b3fc4a74",
"head_commit_message": "Separate triggers by kind in compilation.",
"patch_to_review": "diff --git a/edb/edgeql/compiler/triggers.py b/edb/edgeql/compiler/triggers.py\nindex 047f915dd3f..ad1b4354d60 100644\n--- a/edb/edgeql/compiler/triggers.py\n+++ b/e... | [
{
"diff_hunk": "@@ -204,27 +204,36 @@ def compile_expr_field(\n scope = self._get_scope(schema)\n kinds = self._get_kinds(schema)\n \n- anchors: dict[str, pathid.PathId | s_types.Type] = {}\n+ singleton_anchors: dict[str, pathid.PathId | s_types.Type] = {}\n ... | 023db506195f196e22a4455c15a3ba84e36aaa87 | diff --git a/edb/edgeql/compiler/options.py b/edb/edgeql/compiler/options.py
index 7702a755ab5..1b4d698fe6f 100644
--- a/edb/edgeql/compiler/options.py
+++ b/edb/edgeql/compiler/options.py
@@ -32,6 +32,7 @@
from edb.schema import types as s_types
from edb.schema import pointers as s_pointers
from edb.ir ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-21586@a0b9061 | getsentry/sentry | Python | 21,586 | fix: "Create project" on UI truncates long project names | Pass `max_length=50` to `slugify_instance()` when called for `Project` model: max length now matches `django.db.models.SlugField`'s `max_length`.
~Partially solves #16616: user still can submit *project name* with max length 64 via project setup wizard (serializer max length; model's max length is even bigger - 200)... | 2020-10-25T19:17:58Z | "Create project" in the sentry GUI truncates long project names
If I create a new project with the name "abcdefghi-abcdefghi-abcdefghi-abcdefghi-abcdefghi-" then its name becomes truncated to 30 characters ("abcdefghi-abcdefghi-abcdefghi-"). I am allowed to enter a long project name in the project creation wizard and I... | Can someone check https://github.com/getsentry/sentry/pull/21586 ? | [
{
"body": "If I create a new project with the name \"abcdefghi-abcdefghi-abcdefghi-abcdefghi-abcdefghi-\" then its name becomes truncated to 30 characters (\"abcdefghi-abcdefghi-abcdefghi-\"). I am allowed to enter a long project name in the project creation wizard and I am not informed anywhere that the trunca... | 36c577ad09ec47d66e3d9d9885c13fd8a7aaae74 | {
"head_commit": "a0b9061e3ea7bdb89e7db7c0ef56bcaf5e65e8d2",
"head_commit_message": "Sync slug and name fields max lengths\n\nThis is done to avoid confusion: previously client could\nsend a longer project *name* (up to 64) and part of it could get\ntruncated without any warnings up to 50 and then be slugified and\... | [
{
"diff_hunk": "@@ -54,7 +54,7 @@ def _resolve(instance, node):\n resolve_expression_node = resolve_combined_expression\n \n \n-def slugify_instance(inst, label, reserved=(), max_length=30, field_name=\"slug\", *args, **kwargs):\n+def slugify_instance(inst, label, reserved=(), max_length=50, field_name=\"slug\"... | 49c037e8024b2cd8b2f8d3bc110191c7276edac1 | diff --git a/src/sentry/api/endpoints/team_projects.py b/src/sentry/api/endpoints/team_projects.py
index 150ce394c76243..5550514c2ca7df 100644
--- a/src/sentry/api/endpoints/team_projects.py
+++ b/src/sentry/api/endpoints/team_projects.py
@@ -15,7 +15,7 @@
class ProjectSerializer(serializers.Serializer):
- name... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
geldata__gel-6780@1204ead | geldata/gel | Python | 6,780 | Support closing all connections to a database on database drop | `drop database` will now interrupt and close idle frontend connections before the actual backend database is dropped. Note, idle-in-transaction frontend connections will also be closed.
@msullivan you can configure `close_frontend_conns=True` conditionally in `execute.pyx`.
Fixes #6776
- [x] Add a test | 2024-02-05T18:30:01Z | Provide a way to force close all connections to a database
This would be useful for certain anticipated branch-related dev workflows.
It doesn't need to be instant, necessarily. Maybe it would be enough to close all the client connections and then wait for everything to clean itself up? | I am assigning this to @fantix aspirationally; if you don't think you'll have time, we can sync up about what I would need to do to implement it.
(And if you do have some time, you could make `DROP DATABASE` apply this unconditionally and then leave me to worry about making it conditional in some useful way.)
I was ab... | [
{
"body": "This would be useful for certain anticipated branch-related dev workflows.\r\n\r\nIt doesn't need to be instant, necessarily. Maybe it would be enough to close all the client connections and then wait for everything to clean itself up?",
"number": 6776,
"title": "Provide a way to force close ... | b6885212ccaf6a647570ed1ae065416e81757208 | {
"head_commit": "1204ead1c829946f022dc37baba809533bb52a00",
"head_commit_message": "make it work on the active queries",
"patch_to_review": "diff --git a/edb/edgeql-parser/src/keywords.rs b/edb/edgeql-parser/src/keywords.rs\nindex 9d7e438a7fb..3b994b22825 100644\n--- a/edb/edgeql-parser/src/keywords.rs\n+++ b/ed... | [
{
"diff_hunk": "@@ -851,7 +851,12 @@ def reduce_create_data_branch(self, *kids):\n #\n class DropBranchStmt(Nonterm):\n def reduce_DROP_BRANCH_DatabaseName(self, *kids):\n- self.val = qlast.DropDatabase(name=kids[2].val)\n+ _, _, name = kids\n+ self.val = qlast.DropDatabase(name=name.va... | 8f2ba7b00d9810a16ebf44abfbf231074263a515 | diff --git a/edb/edgeql-parser/src/keywords.rs b/edb/edgeql-parser/src/keywords.rs
index 9d7e438a7fb..e643e4d9618 100644
--- a/edb/edgeql-parser/src/keywords.rs
+++ b/edb/edgeql-parser/src/keywords.rs
@@ -39,6 +39,7 @@ pub const UNRESERVED_KEYWORDS: phf::Set<&str> = phf_set!(
"extension",
"final",
"first... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
geldata__gel-6760@6a8b55f | geldata/gel | Python | 6,760 | Supress idle tx timeout during compilation | I tested this by adding a sleep when the variable `slowcompile` is used.
Fixes #6758. | 2024-02-01T01:37:45Z | We should suspend the pg transaction timeout while waiting for the compiler
If there is a long running compile job (probably computing a migration?), we can spuriously trigger an idle-in-transaction timeout, since even though the transaction is not idle from edgedb's perspective, it *is* from postgres's. | Another option would be to have a heartbeat task that sends keep alive queries. That might actually be better, since in the common case it would never have to do anything. | [
{
"body": "If there is a long running compile job (probably computing a migration?), we can spuriously trigger an idle-in-transaction timeout, since even though the transaction is not idle from edgedb's perspective, it *is* from postgres's.",
"number": 6758,
"title": "We should suspend the pg transactio... | d1f2c56a4dcf7afbe62d7d38011c3e2db2576df8 | {
"head_commit": "6a8b55fbaef939705190263849b091282322d772",
"head_commit_message": "Suppress the timeout instead",
"patch_to_review": "diff --git a/edb/server/dbview/dbview.pyx b/edb/server/dbview/dbview.pyx\nindex d949d8d64c6..296304ec0fd 100644\n--- a/edb/server/dbview/dbview.pyx\n+++ b/edb/server/dbview/dbvie... | [
{
"diff_hunk": "@@ -499,6 +499,27 @@ cdef class EdgeConnection(frontend.FrontendConnection):\n else:\n return edgeql.NormalizedSource.from_string(text)\n \n+ async def _suppress_tx_timeout(self):\n+ async with self.with_pgcon() as conn:\n+ await conn.sql_execute(b'''\n+ ... | 8a124ae8ea2ccf435aa3a6fa4cf4e4ee313a3696 | diff --git a/edb/server/dbview/dbview.pyx b/edb/server/dbview/dbview.pyx
index d949d8d64c6..296304ec0fd 100644
--- a/edb/server/dbview/dbview.pyx
+++ b/edb/server/dbview/dbview.pyx
@@ -977,6 +977,9 @@ cdef class DatabaseConnectionView:
query_req: QueryRequestInfo,
cached_globally=False,
use_m... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-20810@edcf869 | getsentry/sentry | Python | 20,810 | (onpremise) Fix `TypeError: a float is required` in 0024_auto_20191230_2052.py | Fixes: https://github.com/getsentry/onpremise/issues/366
**Description of bug**
If an on-premise user has migrated rapidly (within the past 90 days) from 9.0.0 to 9.1.2 to 10.x they may encounter a `TypeError: a float is required` error because the event.timestamp does not exist and None is not a valid posix timest... | 2020-09-16T16:18:20Z | Upgrade 9.1.2 to 10. Migration error
Hello!
I've started to use sentry from version 9.0.0. On prod running sentry 9.1.2 now.
I decided install stage with onpremise. Also migrated database from prod. Version 9.1.2 works fine.
When upgrading to 10 I've got an error during migration 0024_auto_20191230_2052:
```
Opera... | Heya, thanks for reporting - we are looking into this.
I've got one more question.
I used Ansible for deploying all of the sentry's services.
What is more correct: to build an image from this Docker file https://github.com/getsentry/sentry/blob/10.0.0/docker/Dockerfile or use a prepared image from dockerhub getsentry... | [
{
"body": "Hello!\r\nI've started to use sentry from version 9.0.0. On prod running sentry 9.1.2 now.\r\nI decided install stage with onpremise. Also migrated database from prod. Version 9.1.2 works fine.\r\nWhen upgrading to 10 I've got an error during migration 0024_auto_20191230_2052:\r\n```\r\nOperations to... | 14d8be9eb89a651de7c82ffcf181140f6b4ae5c7 | {
"head_commit": "edcf8694b6a4ff2782210d06c7dd545cec20e570",
"head_commit_message": "Move the timestamp call to a callback",
"patch_to_review": "diff --git a/src/sentry/migrations/0024_auto_20191230_2052.py b/src/sentry/migrations/0024_auto_20191230_2052.py\nindex 8653ff6faa8de3..8ddfe3bc730bc2 100644\n--- a/src/... | [
{
"diff_hunk": "@@ -55,6 +55,18 @@ def _attach_related(_events):\n event.group = groups.get(event.group_id)\n eventstore.bind_nodes(_events, \"data\")\n \n+ def _attach_timestamp(_events):\n+ \"\"\"\n+ When migrating old data from Sentry 9.0.0 to 9.1.2 to 10 in rapid success... | 5c9b9de53bd459685f6ecd96cee6b34299990a47 | diff --git a/src/sentry/migrations/0024_auto_20191230_2052.py b/src/sentry/migrations/0024_auto_20191230_2052.py
index 8653ff6faa8de3..27e85479651901 100644
--- a/src/sentry/migrations/0024_auto_20191230_2052.py
+++ b/src/sentry/migrations/0024_auto_20191230_2052.py
@@ -11,6 +11,7 @@
from sentry import options
from... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-16327@c292020 | getsentry/sentry | Python | 16,327 | fix: Suppress unexpected Type Error in capturing RouteError | Wraps unreproducible Type Error (missing setter) in Error.message property in a try-catch. Type
Error is unreproducible, and when thrown causes intital error to be ignored and the newer and less
informative Type Error to be captured by Sentry instead. Currently, a minority of users are
affected and certain browser a... | 2020-01-08T18:09:22Z | Capturing RouteError fails unexpectedly
Sometimes when capturing a RouteError, writing to the `message` property of JavaScript's `Error` object causes a `Type Error: setting getter-only property "message"`.
The new Type Error exception thrown is then logged into Sentry, causing the previous RouteError to be discarde... | [
{
"body": "Sometimes when capturing a RouteError, writing to the `message` property of JavaScript's `Error` object causes a `Type Error: setting getter-only property \"message\"`.\r\n\r\nThe new Type Error exception thrown is then logged into Sentry, causing the previous RouteError to be discarded.\r\n\r\nWhile... | a141a2f0e4fa6ce3e7484acc72946557fc39cc3a | {
"head_commit": "c29202053bc43a6346afb01dc52a8d807bdd3561",
"head_commit_message": "Capture error emitted from try-catch",
"patch_to_review": "diff --git a/src/sentry/static/sentry/app/views/routeError.jsx b/src/sentry/static/sentry/app/views/routeError.jsx\nindex 12a4186a1f3349..1a532330b36e85 100644\n--- a/src... | [
{
"diff_hunk": "@@ -35,17 +35,36 @@ class RouteError extends React.Component {\n }\n \n const route = getRouteStringFromRoutes(routes);\n+ const enrichScopeContext = scope => {\n+ scope.setExtra('route', route);\n+ scope.setExtra('orgFeatures', (organization && organization.features) || [])... | 5c871e086c8849b048ac609f10726be954ae10f9 | diff --git a/src/sentry/static/sentry/app/views/routeError.jsx b/src/sentry/static/sentry/app/views/routeError.jsx
index 12a4186a1f3349..dbd40aecdea9a5 100644
--- a/src/sentry/static/sentry/app/views/routeError.jsx
+++ b/src/sentry/static/sentry/app/views/routeError.jsx
@@ -35,17 +35,35 @@ class RouteError extends Reac... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-16646@351821c | getsentry/sentry | Python | 16,646 | fix(migrations): Fix event migration | Add missing method to calculate primary hash to event migration.
This fixes a bug affecting onpremise users upgrading from 9.x to 10.x
Fixes https://github.com/getsentry/onpremise/issues/366 | 2020-01-27T19:41:26Z | Upgrade 9.1.2 to 10. Migration error
Hello!
I've started to use sentry from version 9.0.0. On prod running sentry 9.1.2 now.
I decided install stage with onpremise. Also migrated database from prod. Version 9.1.2 works fine.
When upgrading to 10 I've got an error during migration 0024_auto_20191230_2052:
```
Opera... | Heya, thanks for reporting - we are looking into this. | [
{
"body": "Hello!\r\nI've started to use sentry from version 9.0.0. On prod running sentry 9.1.2 now.\r\nI decided install stage with onpremise. Also migrated database from prod. Version 9.1.2 works fine.\r\nWhen upgrading to 10 I've got an error during migration 0024_auto_20191230_2052:\r\n```\r\nOperations to... | 237d4546542c9f9a3ea8a182ec1f863b7dddde7b | {
"head_commit": "351821cb9b1789ca02f6a514ba7bf5dded1e1226",
"head_commit_message": "fix(migrations): Fix event migration\n\nAdd missing method to calculate primary hash to event migration.\n\nFixes https://github.com/getsentry/onpremise/issues/366",
"patch_to_review": "diff --git a/src/sentry/migrations/0024_aut... | [
{
"diff_hunk": "@@ -52,6 +52,26 @@ def _attach_related(_events):\n event.group = groups.get(event.group_id)\n eventstore.bind_nodes(_events, \"data\")\n \n+ def _get_grouping_variants(event):\n+ from sentry.grouping.api import get_grouping_variants_for_event, load_grouping_config\n... | c903f6c31da4115c33937fd864c0448e1aa151ed | diff --git a/src/sentry/migrations/0024_auto_20191230_2052.py b/src/sentry/migrations/0024_auto_20191230_2052.py
index b62a3b80af5410..a2ea15f3b6119a 100644
--- a/src/sentry/migrations/0024_auto_20191230_2052.py
+++ b/src/sentry/migrations/0024_auto_20191230_2052.py
@@ -3,6 +3,7 @@
from __future__ import unicode_liter... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
geldata__gel-6573@ce6794e | geldata/gel | Python | 6,573 | Doc: access policy fix and expansion | Fixes https://github.com/edgedb/edgedb/issues/6389 where a user noticed that the syntax declaration for access policies makes it look like annotations should be outside the braces when they should be inside, and that we don't have any access policy examples that show where annotations belong either so it took some expe... | 2023-12-06T06:09:56Z | Document Access Policy Annotations
The docs are misleading right now about where annotations can be declared with access policies in the schema.
It took me awhile to figure out they are supposed to be inside the `{}` & a sibling of the `errmessage` set clause.
There were no examples of this, so I was just using the s... | Good catch! I'll put a PR together fixing this along with adding an annotation to the example on the access policy page. | [
{
"body": "The docs are misleading right now about where annotations can be declared with access policies in the schema.\r\nIt took me awhile to figure out they are supposed to be inside the `{}` & a sibling of the `errmessage` set clause.\r\nThere were no examples of this, so I was just using the synopsis bloc... | 457bfc840cc7efcf7a5c5cbe1b82d9c752fcf298 | {
"head_commit": "ce6794e490fa0ed3902ed4f8f001e190aa1379ef",
"head_commit_message": "Add line",
"patch_to_review": "diff --git a/docs/datamodel/access_policies.rst b/docs/datamodel/access_policies.rst\nindex 0ffb8689154..f36681a42f3 100644\n--- a/docs/datamodel/access_policies.rst\n+++ b/docs/datamodel/access_pol... | [
{
"diff_hunk": "@@ -253,7 +261,36 @@ we'll see the post we just created.\n db> select count(BlogPost);\n {1}\n \n-Now let's unset ``current_user`` and see what happens.\n+Next, let's set the ``global current_user`` to some other id. This user has\n+yet to write any posts, so the number of ``BlogPost`` objec... | f005df87bfee937cb942a9fe106177d8cdc6b821 | diff --git a/docs/datamodel/access_policies.rst b/docs/datamodel/access_policies.rst
index 584f85d04ef..2e155ca645d 100644
--- a/docs/datamodel/access_policies.rst
+++ b/docs/datamodel/access_policies.rst
@@ -11,13 +11,13 @@ that can be selected, inserted, updated, or deleted by a particular query.
This is known as *o... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
geldata__gel-6352@24b4f19 | geldata/gel | Python | 6,352 | Support auth for HTTP endpoints | Currently, all extension endpoints except for 'auth' will go through
authentication, since it seems like the safe default.
Fixes #6345.
This is a backwards incompatible change! Unless "Trust" is configured
as a method for HTTP transports (which it will be in dev instances),
HTTP endpoints will stop working whe... | 2023-10-25T01:55:27Z | Implement auth for GraphQL and HTTP
A user wants to expose the SQL protocol outside their VPC, but they can't because this would also expose GQL and HTTP protocols without access control. Implement RBAC on these protocols so that it is safe to expose outside the VPC. | [
{
"body": "A user wants to expose the SQL protocol outside their VPC, but they can't because this would also expose GQL and HTTP protocols without access control. Implement RBAC on these protocols so that it is safe to expose outside the VPC.",
"number": 6345,
"title": "Implement auth for GraphQL and HT... | be6636687f63309c1e734f06498cedf2470848aa | {
"head_commit": "24b4f199472d3a802a1fba1a10b6e5e55465c769",
"head_commit_message": "cleanup stray print",
"patch_to_review": "diff --git a/edb/lib/cfg.edgeql b/edb/lib/cfg.edgeql\nindex 35c42249ea2..1a84d8b6a4e 100644\n--- a/edb/lib/cfg.edgeql\n+++ b/edb/lib/cfg.edgeql\n@@ -38,7 +38,8 @@ CREATE ABSTRACT INHERITA... | [
{
"diff_hunk": "@@ -706,6 +715,52 @@ cdef class HttpProtocol:\n response.status = http.HTTPStatus.BAD_REQUEST\n response.close_connection = True\n \n+ async def _check_http_auth(\n+ self,\n+ HttpRequest request,\n+ HttpResponse response,\n+ str dbname,\n+ ):\n+ ... | 61e615a90713ebc3c93a6d1dcb6ef7debfeee89c | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index 2a8e5ee86ee..c4623a79d62 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -44,7 +44,7 @@
# Increment this whenever the database layout or stdlib changes.
-EDGEDB_CATALOG_VERSION = 2023_10_19_00_00
+EDGEDB_CATALOG_VERSION = 2023_10_25_00_00
EDGEDB_MAJOR... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
geldata__gel-6000@2ccbb2b | geldata/gel | Python | 6,000 | Fix collisions between function parameters named id and the property | We name function params their actual names, which can collide with the
`id` column in tables and produce bad results. It could maybe collide
with source and target in link tables too. It doesn't collide with
everything, because most columns get uuid names.
Qualify references to params with the function name.
Fixes #5... | 2023-08-31T20:22:30Z | Parameter name conflicting with property name
- EdgeDB Version: 3.2+75dd258
- EdgeDB CLI Version: EdgeDB CLI 3.4.0+97cad0e
- OS Version: Mac OS 13.0.1 (22A400)
Steps to Reproduce:
Schema:
```module default {
type User{
}
function getUser(id:uuid) -> set of User {
using(
se... | [
{
"body": "- EdgeDB Version: 3.2+75dd258\r\n- EdgeDB CLI Version: EdgeDB CLI 3.4.0+97cad0e\r\n- OS Version: Mac OS 13.0.1 (22A400)\r\n\r\nSteps to Reproduce:\r\n\r\nSchema:\r\n```module default {\r\n type User{ \r\n }\r\n function getUser(id:uuid) -> set of User {\r\n using(\r\n selec... | 84903dc7409a7016463bcbce68f1bea1beba2dbe | {
"head_commit": "2ccbb2bee81f2a87d7a5d583369d167352e99888",
"head_commit_message": "Fix collisions between function parameters named id and the property\n\nWe name function params their actual names, which can collide with the\n`id` column in tables and produce bad results. It could maybe collide\nwith source and ... | [
{
"diff_hunk": "@@ -57,7 +57,7 @@ def compile_ir_to_sql_tree(\n ignore_shapes: bool = False,\n explicit_top_cast: Optional[irast.TypeRef] = None,\n singleton_mode: bool = False,\n- use_named_params: bool = False,\n+ use_named_params: Optional[tuple[str, ...]] = None,",
"line": null,
"o... | 314ec565c8b83786adf5452e86c9e0811c8cf7f1 | diff --git a/edb/pgsql/compiler/__init__.py b/edb/pgsql/compiler/__init__.py
index 1fa5f97b90f..32a9bc2ec09 100644
--- a/edb/pgsql/compiler/__init__.py
+++ b/edb/pgsql/compiler/__init__.py
@@ -57,7 +57,7 @@ def compile_ir_to_sql_tree(
ignore_shapes: bool = False,
explicit_top_cast: Optional[irast.TypeRef] = N... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-5624@32aecc0 | geldata/gel | Python | 5,624 | Fix casts to scalars | Closes #5616
We've had a codepath to fix this bug for enum already, but now I extended it to anything that:
- is a scalar,
- it not the top-most concrete base of itself,
- is not an object (does not have a `ir_set.path_id`).
| 2023-06-08T13:58:36Z | casts from json to scalar subtypes don't check constraints
```
edgedb> create scalar type x extending str { create constraint expression on (__subject__ not like 'a%') };
OK: CREATE SCALAR TYPE
edgedb> select <x>to_json('"a"');
["a"]
edgedb> select <x><str>to_json('"a"');
edgedb error: ConstraintViolationError: i... | [
{
"body": "```\r\nedgedb> create scalar type x extending str { create constraint expression on (__subject__ not like 'a%') };\r\nOK: CREATE SCALAR TYPE\r\nedgedb> select <x>to_json('\"a\"');\r\n[\"a\"]\r\nedgedb> select <x><str>to_json('\"a\"');\r\nedgedb error: ConstraintViolationError: invalid x\r\n Detail: ... | e0a304033b6e2fa79430ad0c006697ff5949faf6 | {
"head_commit": "32aecc0f651a628ac50fd6c05251b8f01988e78e",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/edb/edgeql/compiler/casts.py b/edb/edgeql/compiler/casts.py\nindex 4c16b362308..11b9c825414 100644\n--- a/edb/edgeql/compiler/casts.py\n+++ b/edb/edgeql/compiler/casts.py\n@@ -104,8 +104,6 @... | [
{
"diff_hunk": "@@ -145,24 +143,29 @@ def compile_cast(\n ir_set, orig_stype, new_stype,\n cardinality_mod=cardinality_mod, ctx=ctx)\n \n+ json_t = ctx.env.get_schema_type_and_track(sn.QualName('std', 'json'))\n if (\n new_stype.issubclass(ctx.env.schema, json_t)\n ... | 85b8d7e53d34e434f3928a37220bb01b033bf71e | diff --git a/edb/edgeql/compiler/casts.py b/edb/edgeql/compiler/casts.py
index 4c16b362308..ba01478535a 100644
--- a/edb/edgeql/compiler/casts.py
+++ b/edb/edgeql/compiler/casts.py
@@ -104,8 +104,6 @@ def compile_cast(
):
return _find_object_by_id(ir_expr, new_stype, ctx=ctx)
- json_t = ctx.env.get_s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-8498@443106e | getsentry/sentry | Python | 8,498 | feat(cli): Prevent `run worker` from binding to queues not declared | Fixes #7856. | 2018-05-18T21:29:18Z | Assert that --queues argument(s) actually exist in codebase before starting celeryd.
Currently, if someone runs a celery worker with the argument:`--queues no-way-this-queue-actually-exists-yet` RabbitMQ will create a queue with the default options, which will cause any future production to the queue to error if there... | Not sure this is still important for prod but I think it can also help self-hosted so taking on.
It's still a "gotcha" for saas but we haven't been "got" in quite some time now. 🤞 | [
{
"body": "Currently, if someone runs a celery worker with the argument:`--queues no-way-this-queue-actually-exists-yet` RabbitMQ will create a queue with the default options, which will cause any future production to the queue to error if there is a configuration mismatch.",
"number": 7856,
"title": "... | d7b28d6b0c5564c65fdbd2f46ca6d427ff86653f | {
"head_commit": "443106e3f3aef083004f2b1d75bba667533651c2",
"head_commit_message": "typos, typos everywhere",
"patch_to_review": "diff --git a/src/sentry/runner/commands/run.py b/src/sentry/runner/commands/run.py\nindex ebf30080112e22..85908367df2bc8 100644\n--- a/src/sentry/runner/commands/run.py\n+++ b/src/sen... | [
{
"diff_hunk": "@@ -211,10 +211,38 @@ def run_worker(**options):\n @click.option(\"--without-mingle\", is_flag=True, default=False)\n @click.option(\"--without-heartbeat\", is_flag=True, default=False)\n @click.option(\"--max-tasks-per-child\", default=10000)\n+@click.option(\"--ignore-unknown-queues\", is_flag... | 84d708eabfa1369d3c81b21ff65e884a88dfc7f4 | diff --git a/src/sentry/runner/commands/run.py b/src/sentry/runner/commands/run.py
index ebf30080112e22..71f1965ea37f98 100644
--- a/src/sentry/runner/commands/run.py
+++ b/src/sentry/runner/commands/run.py
@@ -211,10 +211,38 @@ def run_worker(**options):
@click.option("--without-mingle", is_flag=True, default=False)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
geldata__gel-5565@b8cc2da | geldata/gel | Python | 5,565 | Fix several issues related to schema loading in declarative | The main change is a new schema where if we can't figure out the type
of an expression in a path, create weak dependencies to all pointers
with the same name.
This doesn't always work but in practice it will do very well.
I have some ideas for how we could incorporate correct typechecking
into schema loading, but in ... | 2023-05-27T00:37:44Z | Migrations fail when abstract properties are referenced in globals
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: 2.6
- OS Version: macOS 13.0
Steps to Reproduce:
1. Create the schema below
2. Run `edgedb migration create`
Expected behavior: Migration should run succe... | This is probably an instance of the more general problem that we are trying to sort the items in the schema before we can properly typecheck expressions in them.
Possibly `current_user` just isn't getting checked properly and can be fixed.
I've got two ideas. The first doesn't technically always work but would probab... | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: 2.6\r\n- OS Version: macOS 13.0\r\n\r\nSteps to Reproduce:\r\n\r\n1. Create the schema below\r\n2. Run `edgedb migration create`\r\n\r\nExpected behavior: Migration should run successfully.\r\nActual behavior: T... | 09782afd3b759440abbb1b26ee19b6589be04275 | {
"head_commit": "b8cc2dab7ec86ac9d9bc954a11403bc3c0d31f65",
"head_commit_message": "Generate weak deps in declarative when we don't know the type\n\nIf we can't figure out the type of an expression in a path,\ncreate weak dependencies to all pointers with the same name.\n\nThis doesn't *always* work but in practic... | [
{
"diff_hunk": "@@ -461,6 +469,8 @@ def _fork_context(ctx: TracerContext) -> TracerContext:\n schema=ctx.schema,\n module=ctx.module,\n objects=dict(ctx.objects),\n+ # XXX?",
"line": null,
"original_line": 472,
"original_start_line": null,
"path": "edb/edgeql/trace... | 668d3f30530d25d96d75f2ed14c0cea791e555cf | diff --git a/edb/edgeql/declarative.py b/edb/edgeql/declarative.py
index cd73367503e..a98579747e0 100644
--- a/edb/edgeql/declarative.py
+++ b/edb/edgeql/declarative.py
@@ -70,6 +70,7 @@ class TraceContextBase:
depstack: List[Tuple[qlast.DDLOperation, s_name.QualName]]
modaliases: Dict[Optional[str], str]
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-6159@1a823bb | getsentry/sentry | Python | 6,159 | fix(workflow): Actually use 1000 limit in bulk query action | Ready to merge, fixes https://github.com/getsentry/sentry/issues/6099 | 2017-09-20T00:05:10Z | Bulk merge doesn't apply to all selected
Steps to reproduce
- Use the "Select the first 1,000 issues that match this search query" feature to select multiple pages of issues
- Use the UI to bulk merge issues
Upon refresh, some of the issues appear to have been merged, but many are not merged.
I did wonder if th... | I feel like I noticed this too, which is odd as I thought merge changed the state synchronously.
it's this https://github.com/getsentry/sentry/blob/master/src/sentry/api/paginator.py#L23
looked into this with jess and dena, the problem is the query is being truncated by the paginator
it's shared across all of the bul... | [
{
"body": "Steps to reproduce\r\n- Use the \"Select the first 1,000 issues that match this search query\" feature to select multiple pages of issues\r\n- Use the UI to bulk merge issues\r\n\r\nUpon refresh, some of the issues appear to have been merged, but many are not merged.\r\n\r\nI did wonder if this was b... | 6e47bc607827da5fb8a9976e31d86d59c3607465 | {
"head_commit": "1a823bb5bd5e7fc8539aebb3cdbc5fa1764278d7",
"head_commit_message": "pass max_limit through",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/project_group_index.py b/src/sentry/api/endpoints/project_group_index.py\nindex 38a43ff0625478..951d10398ed3ed 100644\n--- a/src/sentry/api/endpoi... | [
{
"diff_hunk": "@@ -273,7 +273,7 @@ def _build_queryset(\n )\n return queryset\n \n- def query(self, project, count_hits=False, **kwargs):\n+ def query(self, project, count_hits=False, paginator_options={}, **kwargs):",
"line": null,
"original_line": 276,
"original_start_line":... | d70896990ddbc73acfb176aae211ca3ccfb722a6 | diff --git a/src/sentry/api/endpoints/project_group_index.py b/src/sentry/api/endpoints/project_group_index.py
index 38a43ff0625478..cc068a34b96ca2 100644
--- a/src/sentry/api/endpoints/project_group_index.py
+++ b/src/sentry/api/endpoints/project_group_index.py
@@ -15,7 +15,8 @@
from sentry.api.bases.project import P... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-5804@9060348 | getsentry/sentry | Python | 5,804 | Use GroupResolution to query for groups resolved in a release | Fixes #5786 | 2017-08-02T23:46:41Z | Issues resolved via UI do not appear in releases overview
To reproduce:
* Navigate to an issue
* Click "Resolve in current release (abc123)"
* Navigate to that release (abc123)
* Issue does not appear under "New Issues in this Release" | [
{
"body": "To reproduce:\r\n\r\n* Navigate to an issue\r\n* Click \"Resolve in current release (abc123)\"\r\n* Navigate to that release (abc123)\r\n* Issue does not appear under \"New Issues in this Release\"\r\n",
"number": 5786,
"title": "Issues resolved via UI do not appear in releases overview"
}
... | 81ff9121563efffc99bb09d75e324a5be7af48fd | {
"head_commit": "9060348634cf289c272244f7a2a62a0138c31aeb",
"head_commit_message": "Add tests",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/issues_resolved_in_release.py b/src/sentry/api/endpoints/issues_resolved_in_release.py\nindex 3673b6c99916bd..eee0efd4dbbbf5 100644\n--- a/src/sentry/api/endpo... | [
{
"diff_hunk": "@@ -37,13 +39,26 @@ def get(self, request, project, version):\n except Release.DoesNotExist:\n raise ResourceDoesNotExist\n \n+ ids_from_GroupResolution = GroupResolution.objects.filter(\n+ release=release,\n+ ).values_list(\n+ 'group_id', ... | fbd180aeedbbbef025ef08e345da69b0e449d87e | diff --git a/src/sentry/api/endpoints/issues_resolved_in_release.py b/src/sentry/api/endpoints/issues_resolved_in_release.py
index 3673b6c99916bd..33beac817b14c5 100644
--- a/src/sentry/api/endpoints/issues_resolved_in_release.py
+++ b/src/sentry/api/endpoints/issues_resolved_in_release.py
@@ -10,6 +10,7 @@
from sentr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-5417@1112131 | geldata/gel | Python | 5,417 | Fix tuples in global variables and do error checks on arrays | We need to recode tuples to inject OIDs, like we do with arrays and
the like. Somewhat annoyingly, this ends up as a totally separate code
path from the existing re-encoding of tuples for parameters.
This is because for globals, which are schema declared, we have
postgres composite types, and it would be wasteful and ... | 2023-05-04T03:17:41Z | ISE when providing tuple global
- EdgeDB Version: 3.0-dev.7404+local
Providing a tuple global value throws the error `InternalServerError: binary data has type 0 (-) instead of expected 25 (text) in record column 1`. (This error happens in both js and python clients, so I think it's a server bug instead of a problem... | [
{
"body": "- EdgeDB Version: 3.0-dev.7404+local\r\n\r\nProviding a tuple global value throws the error `InternalServerError: binary data has type 0 (-) instead of expected 25 (text) in record column 1`. (This error happens in both js and python clients, so I think it's a server bug instead of a problem with the... | 8b6a6bd9fd9850bd1ee83d67ca315144d8149a56 | {
"head_commit": "1112131165964925576091777a94c754b36d373b",
"head_commit_message": "Fix tuples in global variables and do error checks on arrays\n\nWe need to recode tuples to inject OIDs, like we do with arrays and\nthe like. Somewhat annoyingly, this ends up as a totally separate code\npath from the existing re-... | [
{
"diff_hunk": "@@ -1090,6 +1090,21 @@ def _parse_range_descriptor(\n return RangeDesc(tid=tid, inner=subtype)\n \n \n+def _make_global_rep(typ: s_types.Type, ctx: Context) -> object:\n+ if isinstance(typ, s_types.Tuple):\n+ subtyps = typ.get_subtypes(ctx.schema)\n+ return (\n+ 1... | f14527f7a3791ae3fc4f315ccde1e2580bbc72ee | diff --git a/edb/edgeql/qltypes.py b/edb/edgeql/qltypes.py
index 1948a6116aa..29cbe0ecb0d 100644
--- a/edb/edgeql/qltypes.py
+++ b/edb/edgeql/qltypes.py
@@ -20,6 +20,8 @@
from __future__ import annotations
from typing import *
+import enum
+
from edb.common import enum as s_enum
@@ -312,3 +314,9 @@ def to_edge... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-5355@3b2cf69 | geldata/gel | Python | 5,355 | Fix insert default cycle | Closes #5348 | 2023-04-14T10:17:30Z | Recursive defaults with DML will cause ISE: recursion depth limit exceeded
EdgeDB 3.0-dev.7456+local (repl 3.0.0-dev)
Create a migration on the following schema, an infinite recursion will follow
```
type Test3 {
d1 : str ;
d7 : Test3 {
default := (insert Test3 {
d1 := "d1"
... | [
{
"body": "EdgeDB 3.0-dev.7456+local (repl 3.0.0-dev)\r\n\r\n\r\nCreate a migration on the following schema, an infinite recursion will follow\r\n```\r\ntype Test3 {\r\n d1 : str ;\r\n d7 : Test3 {\r\n default := (insert Test3 {\r\n d1 := \"d1\"\r\n })\r\n }\r\n}\r\n```",
... | 44fc9030bf6bb0b816bb26a6325ec513116c242b | {
"head_commit": "3b2cf691a8465a3bb83a7819c88980d7dae69c31",
"head_commit_message": "Fix insert default cycle",
"patch_to_review": "diff --git a/edb/edgeql/compiler/context.py b/edb/edgeql/compiler/context.py\nindex 9d1c0a980af..4fb777d142b 100644\n--- a/edb/edgeql/compiler/context.py\n+++ b/edb/edgeql/compiler/c... | [
{
"diff_hunk": "@@ -1952,6 +1952,19 @@ async def test_edgeql_ddl_default_11(self):\n };\n \"\"\")\n \n+ async def test_edgeql_ddl_default_12(self):\n+ with self.assertRaisesRegex(\n+ edgedb.QueryError,\n+ 'is part of a default rule cycle'",
"line":... | a4e08f3a7aab600a130daa8182e19361b1453a8d | diff --git a/edb/edgeql/compiler/context.py b/edb/edgeql/compiler/context.py
index 9d1c0a980af..352fcf8beb1 100644
--- a/edb/edgeql/compiler/context.py
+++ b/edb/edgeql/compiler/context.py
@@ -543,6 +543,10 @@ class ContextLevel(compiler.ContextLevel):
if not None, then it is of the form `in a FILTER clause` ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-5310@8ef54ec | geldata/gel | Python | 5,310 | Forbid DML in non-scalar function args | Closes #5172 | 2023-04-06T13:41:11Z | Disallow passing insert/update objects to user-defined functions
(I thought there was an issue for this but I couldn't find it)
If a function is implemented as a SQL function, it won't be able to use overlays to see newly created data. This can cause a bunch of problems, including breaking cardinality.
I think th... | [
{
"body": "(I thought there was an issue for this but I couldn't find it)\r\n\r\nIf a function is implemented as a SQL function, it won't be able to use overlays to see newly created data. This can cause a bunch of problems, including breaking cardinality.\r\n\r\nI think that we don't have any stdlib functions ... | fdd3418aa76726af7a4257d3b30893fa2320839f | {
"head_commit": "8ef54ecfe5ae4d69e7acd294e59f1dfcc5b147df",
"head_commit_message": "Forbid DML in non-scalar function args",
"patch_to_review": "diff --git a/edb/edgeql/compiler/func.py b/edb/edgeql/compiler/func.py\nindex da19483554e..5c6a348af28 100644\n--- a/edb/edgeql/compiler/func.py\n+++ b/edb/edgeql/compi... | [
{
"diff_hunk": "@@ -214,6 +214,18 @@ def compile_FunctionCall(\n ctx=ctx,\n )\n \n+ if func_name.module != 'std':",
"line": null,
"original_line": 217,
"original_start_line": null,
"path": "edb/edgeql/compiler/func.py",
"start_line": null,
"text": "@user1:\nLet's check whe... | 892da5905c81913d0ddbeffbd8c417945c62ebdd | diff --git a/edb/edgeql/compiler/func.py b/edb/edgeql/compiler/func.py
index da19483554e..f830c3c1eed 100644
--- a/edb/edgeql/compiler/func.py
+++ b/edb/edgeql/compiler/func.py
@@ -155,9 +155,10 @@ def compile_FunctionCall(
matched_call = matched[0]
func = matched_call.func
+ assert isinstance(func, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
geldata__gel-5560@0824099 | geldata/gel | Python | 5,560 | Disallow partial paths in the defaults of link properties | Fix #5200 | 2023-05-26T19:30:36Z | Error during compiled migration: QueryError: could not resolve partial path
Version: newest master branch
Steps to reproduce:
1. Replace your project's schema with the following:
2. run `edb cli migration create`, this step should succeeded. If this step fails, then this bug has been fixed.
3. run `edb cli migra... | [
{
"body": "Version: newest master branch\r\n\r\nSteps to reproduce:\r\n1. Replace your project's schema with the following:\r\n2. run `edb cli migration create`, this step should succeeded. If this step fails, then this bug has been fixed.\r\n3. run `edb cli migrate`, this should now give an error that is hard ... | daf7e332a18defbbb6a239e31a96137a7c7325fb | {
"head_commit": "0824099a51b888f6ed1ea76bf30aef89caf5303f",
"head_commit_message": "add test case",
"patch_to_review": "diff --git a/edb/schema/pointers.py b/edb/schema/pointers.py\nindex ec982f22e27..2f882a8ed7c 100644\n--- a/edb/schema/pointers.py\n+++ b/edb/schema/pointers.py\n@@ -1439,6 +1439,7 @@ def _compi... | [
{
"diff_hunk": "@@ -1539,12 +1543,30 @@ def compile_expr_field(\n else:\n in_ddl_context_name = None\n \n+ # If we are in a link property's default field\n+ # do not set path prefix anchor, because link properties\n+ # cannot have defaults that refere... | 0b36b6d385bb8298431e3414e4baec781ffe3efe | diff --git a/edb/schema/pointers.py b/edb/schema/pointers.py
index 00fc009a59a..5cb0ae04b40 100644
--- a/edb/schema/pointers.py
+++ b/edb/schema/pointers.py
@@ -1440,6 +1440,7 @@ def _compile_expr(
make_globals_empty: bool = False,
source_context: Optional[parsing.ParserContext] = None,
detac... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-5270@89932db | geldata/gel | Python | 5,270 | Document setting globals in HTTP/GraphQL | Closes #4314 | 2023-03-30T14:30:13Z | Document `globals` argument for HTTP/GraphQL protocols
What is the best way to specify globals in graphql?
In other words, if a resource has a specific access policy, what is the best way to indicate "session data" like the current user ID when interfacing with edgedb over the graphql interface? | You can pass a `globals` argument to the endpoint, similar to `variables`.
The keys should be fully qualified, like `"default::global_var"`.
This ought to be documented, of course.
@fritzblue does global even work with your GQL client?
I have added 2 globals `currentUserId` (scalar) and `currentUser` (query).
... | [
{
"body": "What is the best way to specify globals in graphql?\r\n\r\nIn other words, if a resource has a specific access policy, what is the best way to indicate \"session data\" like the current user ID when interfacing with edgedb over the graphql interface?",
"number": 4314,
"title": "Document `glob... | b404d181b5deecf99cf8d79e14a13d07761825d7 | {
"head_commit": "89932db316d3935ca30228dc5db83c1eca8ffbfb",
"head_commit_message": "Document setting globals\n\nCloses #4314",
"patch_to_review": "diff --git a/docs/clients/graphql/index.rst b/docs/clients/graphql/index.rst\nindex 846179b3b8e..8e988f1b0f7 100644\n--- a/docs/clients/graphql/index.rst\n+++ b/docs/... | [
{
"diff_hunk": "@@ -94,6 +94,10 @@ request can contain the following fields:\n - ``variables`` - a JSON object containing a set of variables. **Optional**\n unless the GraphQL query string contains variables, in which case it is\n required.\n+- ``globals`` - a JSON object containing global variables. **Opti... | 06d47431ffed73db2724b8929837b872e78cf3ef | diff --git a/docs/clients/graphql/index.rst b/docs/clients/graphql/index.rst
index 846179b3b8e..8e4ddbd8005 100644
--- a/docs/clients/graphql/index.rst
+++ b/docs/clients/graphql/index.rst
@@ -94,6 +94,9 @@ request can contain the following fields:
- ``variables`` - a JSON object containing a set of variables. **Optio... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
getsentry__sentry-5285@9136af5 | getsentry/sentry | Python | 5,285 | Add Slack to the list of filtered web crawlers | This adds Slack to the list of filtered web crawlers. Slack lists 3 different user agents for their crawlers and the `Slack` regex covers all 3 (https://api.slack.com/robots).
Filtering Twitter's crawler was suggested in #5284, but this should already be filtered by the generic `bot[\/\s\)\;]` regex. I added tests f... | 2017-04-24T18:21:01Z | Filter Slackbot crawler
We get issues reported in Sentry whenever we post our internal app links in Slack because the Slackbot web crawler tries to load them and fails. Would it be possible to get Slackbot added to the list of crawlers that are ignored in Sentry? | +1
The three Slack user agents for their crawlers are detailed at https://api.slack.com/robots.
If we're gonna do this, we might as well also get Facebook and Twitter. Unless we already do. (Not looking at code yet)
Facebook is in the list of crawlers at https://github.com/getsentry/sentry/blob/master/src/sentry/filter... | [
{
"body": "We get issues reported in Sentry whenever we post our internal app links in Slack because the Slackbot web crawler tries to load them and fails. Would it be possible to get Slackbot added to the list of crawlers that are ignored in Sentry?",
"number": 5284,
"title": "Filter Slackbot crawler"
... | 84c6f75ab40e12677c81d9210c3fe8ad66d7a0c3 | {
"head_commit": "9136af5fb8995a89f860572ff0812474a74a6e0e",
"head_commit_message": "Add Slack and Twitter to the list of filtered web crawlers.",
"patch_to_review": "diff --git a/src/sentry/filters/web_crawlers.py b/src/sentry/filters/web_crawlers.py\nindex edef1c06bcbfac..a09d18b5ccc37d 100644\n--- a/src/sentry... | [
{
"diff_hunk": "@@ -30,6 +30,10 @@\n r'bot[\\/\\s\\)\\;]',\n # Generic spider\n r'spider[\\/\\s\\)\\;]',\n+ # Slack - see https://api.slack.com/robots\n+ r'Slack',\n+ # Twitter - see https://dev.twitter.com/cards/getting-started#crawling\n+ r'Twitterbot',",
"line": null,
"origina... | cc6bdc92965e9fe7c6154920a42c54ecc214dbf6 | diff --git a/src/sentry/filters/web_crawlers.py b/src/sentry/filters/web_crawlers.py
index edef1c06bcbfac..7b3f3a36e05791 100644
--- a/src/sentry/filters/web_crawlers.py
+++ b/src/sentry/filters/web_crawlers.py
@@ -30,6 +30,8 @@
r'bot[\/\s\)\;]',
# Generic spider
r'spider[\/\s\)\;]',
+ # Slack - see h... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
getsentry__sentry-5144@4c89422 | getsentry/sentry | Python | 5,144 | Discover source maps if not on own last line | Fixes #5058
cc @mattrobenolt | 2017-03-24T05:52:10Z | Sentry should respect sourceMappingURL at EOL
Right now Sentry requires the `sourceMappingURL` directive to be on its own line at the end of a file, which is the literal interpretation of the spec.
But, Chrome and Firefox are more liberal, and will respect `sourceMappingURL` if it follows a bunch of code on the last... | [
{
"body": "Right now Sentry requires the `sourceMappingURL` directive to be on its own line at the end of a file, which is the literal interpretation of the spec.\r\n\r\nBut, Chrome and Firefox are more liberal, and will respect `sourceMappingURL` if it follows a bunch of code on the last line of the file, e.g.... | 1b2ccb8cf719087e47a7f05a614d41489baf57a7 | {
"head_commit": "4c89422f4a5ba3690b8e01635a8e606b97f6ea62",
"head_commit_message": "Discover source maps if not on own last line\n\nFixes ###",
"patch_to_review": "diff --git a/src/sentry/lang/javascript/processor.py b/src/sentry/lang/javascript/processor.py\nindex 4b7f8cadb332df..9d10cb11af888f 100644\n--- a/sr... | [
{
"diff_hunk": "@@ -155,6 +155,19 @@ def discover_sourcemap(result):\n # We want everything AFTER the indicator, which is 21 chars long\n sourcemap = line[21:].rstrip()\n \n+ # If we still haven't found anything, check end of last line AFTER source code.\n+ # This i... | ce4f491b20f0c7db4b4d642168063277ef307e7c | diff --git a/src/sentry/lang/javascript/processor.py b/src/sentry/lang/javascript/processor.py
index 4b7f8cadb332df..f90fc9ba822983 100644
--- a/src/sentry/lang/javascript/processor.py
+++ b/src/sentry/lang/javascript/processor.py
@@ -52,7 +52,7 @@ class ZeroReturnError(Exception):
""", re.X | re.I)
VERSION_RE = re.c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
getsentry__sentry-5101@c394928 | getsentry/sentry | Python | 5,101 | Show the relevant event if present when searching by event id | This pull request fixes #4283
| 2017-03-19T01:12:57Z | Search by event id is broken
Searching by event id no longer shows you the event details. Instead it opens the error group with the latest event showing. This is problematic because there's no other way to get info about the exact event. | I wouldn't consider this broken, but its a nice feature to have. It is very possible this used to once forward to an event and doesn't anymore, but if so its been >1yr since that change was made. It's also important to know that we can't always forward to an event. | [
{
"body": "Searching by event id no longer shows you the event details. Instead it opens the error group with the latest event showing. This is problematic because there's no other way to get info about the exact event. \n",
"number": 4283,
"title": "Search by event id is broken "
}
] | 5f29c85a9217c0b2ef67b9f6d7e4373e5bab3276 | {
"head_commit": "c394928af347412c6eb6fbe15500cea3ffaed237",
"head_commit_message": "Ensures that the relevant event is shown if present when you search by the event id",
"patch_to_review": "diff --git a/src/sentry/api/endpoints/project_group_index.py b/src/sentry/api/endpoints/project_group_index.py\nindex 6706f... | [
{
"diff_hunk": "@@ -226,6 +228,10 @@ def get(self, request, project):\n pass\n else:\n matching_group = Group.objects.get(id=mapping.group_id)\n+ try:\n+ matching_event = Event.objects.get(event_id=query)",
"li... | 8c0de5bd65af783e6e40cd4f8bbef1ff262bf4a0 | diff --git a/src/sentry/api/endpoints/project_group_index.py b/src/sentry/api/endpoints/project_group_index.py
index 6706f37143bea9..d4b1840257f6f3 100644
--- a/src/sentry/api/endpoints/project_group_index.py
+++ b/src/sentry/api/endpoints/project_group_index.py
@@ -25,6 +25,7 @@
GroupResolution, GroupSeen, GroupS... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
geldata__gel-5133@e8ceea3 | geldata/gel | Python | 5,133 | Make sys:: and cfg:: fit propertly into the object model | Objects in `sys` and `cfg` are implemented using custom views. These
views live in the `edgedbss` module and do not get correctly
incorporated into inheritence views for BaseObject (and even for other
abstract objects in the cfg hierarchy).
Move all of those views into `edgedbstd` with the names they ought to
h... | 2023-03-06T21:17:10Z | Objects in `cfg` and `sys` are in a somewhat busted state
Most of types in `cfg` and `sys` are represented in the database as views that live in the `edgedbss` schema, and which are created in `metaschema.py`.
However the knowledge that they should live in `edgedbss` is somewhat inconsistent.
Duplicates of each of ... | > What is the reason why these views are in `edgedbss` instead of just `edgedbstd`? Is this important?
Mostly historical. Ideally we should teach system DDL to special-case these and create in `edgedbstd` properly. | [
{
"body": "Most of types in `cfg` and `sys` are represented in the database as views that live in the `edgedbss` schema, and which are created in `metaschema.py`.\r\n\r\nHowever the knowledge that they should live in `edgedbss` is somewhat inconsistent.\r\nDuplicates of each of those types exist in `edgedbstd`,... | 70599154f6d3d7333f2c152368411c120716c959 | {
"head_commit": "e8ceea34bbc287c0075e736f9b561dab514be9d2",
"head_commit_message": "Make sys:: and cfg:: fit propertly into the object model\n\nObjects in `sys` and `cfg` are implemented using custom views. These\nviews live in the `edgedbss` module and do not get correctly\nincorporated into inheritence views fo... | [
{
"diff_hunk": "@@ -125,8 +125,8 @@ def is_free_object_type(self, schema: s_schema.Schema) -> bool:\n \n def is_fake_object_type(self, schema: s_schema.Schema) -> bool:\n return (\n- self.get_name(schema).module == 'cfg'\n- or self.is_free_object_type(schema)\n+ # se... | 12a887371c3b0d479e554d5cb55ce25eb7db10b3 | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index f3b6e169da7..7785162873f 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -44,7 +44,7 @@
# Increment this whenever the database layout or stdlib changes.
-EDGEDB_CATALOG_VERSION = 2023_02_23_00_00
+EDGEDB_CATALOG_VERSION = 2023_03_06_00_00
EDGEDB_MAJOR... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
geldata__gel-5130@2e5341f | geldata/gel | Python | 5,130 | Trying to enforce no DML constraint in select Where and Orderby Clauses | Fixes https://github.com/edgedb/edgedb/issues/4952 | 2023-03-06T17:09:44Z | Ban `inserts` and `updates` in `filter` and `order by` clauses of `selects`
We should not allow queries like the following:
```
with X := Person select (X {name}, 1) filter {count ((insert Person {name := "t7"})) = 1} ;
```
```
select Foo
filter (insert Bar{val := 1}).val = 1 and false
``` | [
{
"body": "We should not allow queries like the following:\r\n\r\n```\r\nwith X := Person select (X {name}, 1) filter {count ((insert Person {name := \"t7\"})) = 1} ;\r\n```\r\n\r\n```\r\nselect Foo\r\nfilter (insert Bar{val := 1}).val = 1 and false\r\n```\r\n",
"number": 4952,
"title": "Ban `inserts` a... | 70599154f6d3d7333f2c152368411c120716c959 | {
"head_commit": "2e5341f596a81d43533ebd2240678b142dec94f9",
"head_commit_message": "fix flake 8",
"patch_to_review": "diff --git a/edb/edgeql/compiler/context.py b/edb/edgeql/compiler/context.py\nindex 0c47a23b396..693317667a9 100644\n--- a/edb/edgeql/compiler/context.py\n+++ b/edb/edgeql/compiler/context.py\n@@... | [
{
"diff_hunk": "@@ -133,10 +133,14 @@ def compile_SelectQuery(\n forward_rptr=forward_rptr,\n ctx=sctx)\n \n- stmt.where = clauses.compile_where_clause(expr.where, ctx=sctx)\n+ with sctx.new(context.ContextSwitchMode.NEW) as sctx_no_dml:\n+ sctx_no_dml.disallow_d... | dd74ed348826b02b8e664c27fcf8fa19205e4dca | diff --git a/edb/edgeql/compiler/clauses.py b/edb/edgeql/compiler/clauses.py
index d5dd46eb0b4..31a4b6b762a 100644
--- a/edb/edgeql/compiler/clauses.py
+++ b/edb/edgeql/compiler/clauses.py
@@ -52,6 +52,7 @@ def compile_where_clause(
with ctx.newscope(fenced=True) as subctx:
subctx.expr_exposed = context.E... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-5115@da1ca4b | geldata/gel | Python | 5,115 | pg-ext: pretend to be Postgres 13 | Patched `server_version` and `server_version_num` to 13.9
* Also fixed conn params `session_authorization` and `application_name`
* SQL `version()` now shows EdgeDB version info
Fixes #5089 | 2023-03-01T17:14:26Z | Advertise EdgeDB server as Postgres 13 compatible through SQL
The current SQL support (through Postgres binary protocol) in EdgeDB is actually only compatible with Postgres 13, regardless of the actual version of the backend Postgres in use. We should also advertise `13` instead of `14` or higher through the binary pro... | [
{
"body": "The current SQL support (through Postgres binary protocol) in EdgeDB is actually only compatible with Postgres 13, regardless of the actual version of the backend Postgres in use. We should also advertise `13` instead of `14` or higher through the binary protocol.",
"number": 5089,
"title": "... | 833bc4a6e8ce2bc9de5e614749cdef7875ecad8f | {
"head_commit": "da1ca4b05c8522cc526ff19094b66e84a70f807d",
"head_commit_message": "pg-ext: pretend to be Postgres 13\n\n* Also fixed conn params session_authorization and application_name\n* SQL `version()` now shows EdgeDB version info",
"patch_to_review": "diff --git a/edb/buildmeta.py b/edb/buildmeta.py\nind... | [
{
"diff_hunk": "@@ -526,17 +526,28 @@ def parse_search_path(search_path_str: str) -> list[str]:\n if isinstance(arg, pgast.StringConstant)\n ]\n \n- frontend_only = {'search_path'}\n+ # frontend-only settings and their mutability\n+ frontend_only = {\n+ ... | 5a8da2f140f438a65a9a67ac305af159a9735e7e | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index b548bc227eb..f3b6e169da7 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -588,3 +588,24 @@ def get_cache_src_dirs():
def get_default_tenant_id() -> str:
catver = EDGEDB_CATALOG_VERSION
return f'V{catver:x}'
+
+
+def get_version_line() -> str:
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
geldata__gel-4851@f61eda7 | geldata/gel | Python | 4,851 | Partial paths in defaults | Closes #4473
Does not yet handle references links (may not even throw an error). | 2022-12-22T21:09:49Z | Reference properties in a default Schema value
Current error message goes: `edgedb error: QueryError: could not resolve partial path`. I had to dig in multiple places (as always) and found a similar topic in Discord, which was not reported as a limitation in docs, and still is not AFAI searched the docs.
Discord ha... | To make it precise, this issue here is that if we do something like
```
create type Foo { create property x -> str; create property y -> str { set default := .x }; };
```
we get that partial path error message. (Which should be improved in general!)
We should explain that we don't support referring to other proper... | [
{
"body": "Current error message goes: `edgedb error: QueryError: could not resolve partial path`. I had to dig in multiple places (as always) and found a similar topic in Discord, which was not reported as a limitation in docs, and still is not AFAI searched the docs. \r\n\r\nDiscord have a lot of conversation... | de5d9838e47ff2fd90c29ef560ff1fdf41f705a8 | {
"head_commit": "f61eda7f8174caf521b8f652e46f58b3ad4b86e2",
"head_commit_message": "fmt, fix tests",
"patch_to_review": "diff --git a/edb/edgeql/ast.py b/edb/edgeql/ast.py\nindex b39f862ebba..34de159b300 100644\n--- a/edb/edgeql/ast.py\n+++ b/edb/edgeql/ast.py\n@@ -267,6 +267,7 @@ class Subject(SpecialAnchor): ... | [
{
"diff_hunk": "@@ -451,3 +451,21 @@ def contains_set_of_op(ir: irast.Base) -> bool:\n flt = (lambda n: any(x == ft.TypeModifier.SetOfType\n for x in n.params_typemods))\n return bool(ast.find_children(ir, irast.Call, flt, terminate_early=True))\n+\n+\n+class PointerCollectorVis... | b8005597a33583ab0af440094a6c2adc00801824 | diff --git a/edb/edgeql/ast.py b/edb/edgeql/ast.py
index b39f862ebba..34de159b300 100644
--- a/edb/edgeql/ast.py
+++ b/edb/edgeql/ast.py
@@ -267,6 +267,7 @@ class Subject(SpecialAnchor): # __subject__
class DetachedExpr(Expr): # DETACHED Expr
expr: Expr
+ preserve_path_prefix: bool = False
class Globa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-4650@c874a2d | geldata/gel | Python | 4,650 | SQL resolver | Closes #4540
Also a few fixes to `pgsql.ast` and `pgsql.parser` | 2022-11-09T18:50:07Z | SQL name resolution
For the upcoming SQL support, we essentially need to implement a basic SQL name resolver. We will not support all of the SQL, but we need following features:
(using the Movies schema)
```sql
-- map Movie to our ObjectType
-- map Movie.title to the correct property
SELECT Movie.title FROM Movi... | For many-to-many links, I don't think we need to include anything but `Movie` and `actors` in the table name. That fully identifies the link. The `filmography` computed backlink is helpful for writing edgeql queries, but is not fundamental.
So I think it should be named `Movie_actors`, or `"Movie.actors"` if we are ... | [
{
"body": "For the upcoming SQL support, we essentially need to implement a basic SQL name resolver. We will not support all of the SQL, but we need following features:\r\n\r\n(using the Movies schema)\r\n```sql\r\n-- map Movie to our ObjectType\r\n-- map Movie.title to the correct property\r\nSELECT Movie.titl... | 9e7d85cc2c0a5673602db3e45267403f5f7a086b | {
"head_commit": "c874a2d3775934b09db412440cfb911ca3861aaf",
"head_commit_message": "return rel (current table) from functions instead of keeping in context",
"patch_to_review": "diff --git a/edb/pgsql/ast.py b/edb/pgsql/ast.py\nindex 0b2c62798ae..662a3ecb571 100644\n--- a/edb/pgsql/ast.py\n+++ b/edb/pgsql/ast.py... | [
{
"diff_hunk": "@@ -0,0 +1,222 @@\n+#\n+# This source file is part of the EdgeDB open source project.\n+#\n+# Copyright 2008-present MagicStack Inc. and the EdgeDB authors.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the Licen... | a64b531807a39f67ba23114d091971d4356ae2ab | diff --git a/edb/pgsql/ast.py b/edb/pgsql/ast.py
index 0b2c62798ae..b88cdeb92b4 100644
--- a/edb/pgsql/ast.py
+++ b/edb/pgsql/ast.py
@@ -183,7 +183,11 @@ def get_path_outputs(self, flavor: str) -> typing.Dict[
class BaseRangeVar(ImmutableBaseExpr):
- """Range variable, used in FROM clauses."""
+ """
+ Ran... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
geldata__gel-4529@1a119a1 | geldata/gel | Python | 4,529 | Report failing access policy | Closes #4095
- refactor clauses.py
- report names of failed access policies
I have tests to do, but would ask for a quick peek if the major changes are ok.
| 2022-10-14T15:52:10Z | Add custom error message on object level security constraints
Currently, when a access policy constraint is violated the error looks like this:
`edgedb error: EdgeDBError: access policy violation on insert of default::User`
It does not carry any info about what constraint has been violated (it can have more than 1 ... | There's some design work needed to figure out exactly what error message should be output.
An access policy is violated if one or two things happens:
1. Every allow rule is false
2. Some reject rule is true
If a reject rule is false, we should output the error message for it. The main question, then, is what to ... | [
{
"body": "Currently, when a access policy constraint is violated the error looks like this:\r\n`edgedb error: EdgeDBError: access policy violation on insert of default::User`\r\n\r\nIt does not carry any info about what constraint has been violated (it can have more than 1 insert constraint for eg).\r\n\r\nWou... | 4f0d57499b88be093a4446e5823a27fd5d1d56b6 | {
"head_commit": "1a119a1339e60e57f44c04010ef7d42bb9d6e035",
"head_commit_message": "add errmessage to AccessPolicy",
"patch_to_review": "diff --git a/edb/edgeql/compiler/clauses.py b/edb/edgeql/compiler/clauses.py\nindex 871d003f204..d5dd46eb0b4 100644\n--- a/edb/edgeql/compiler/clauses.py\n+++ b/edb/edgeql/comp... | [
{
"diff_hunk": "@@ -839,33 +838,99 @@ def compile_policy_check(\n dml_rvar = relctx.rvar_for_rel(dml_cte, ctx=ctx)\n relctx.include_rvar(ictx.rel, dml_rvar, path_id=subject_id, ctx=ictx)\n \n- cond_ref = clauses.compile_filter_clause(\n- policy_expr.expr, policy_expr.cardinalit... | 7c96b3aacf0938d87f7965a9b7ba83cf327dd87e | diff --git a/edb/edgeql/compiler/clauses.py b/edb/edgeql/compiler/clauses.py
index 871d003f204..d5dd46eb0b4 100644
--- a/edb/edgeql/compiler/clauses.py
+++ b/edb/edgeql/compiler/clauses.py
@@ -40,12 +40,11 @@
def compile_where_clause(
- ir_stmt: irast.FilteredStmt,
- where: Optional[qlast.Base], *,
-... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
geldata__gel-4469@95cccee | geldata/gel | Python | 4,469 | Cast uuid to object | Closes #4435.
I suggest that the two commits are reviewed separately - first one is just refactoring. | 2022-10-03T16:17:28Z | Support casting from `uuid` to object types
We want to support doing things like `<User><uuid>$0` (and probably just `<User>$0`, with the same meaning?), and have it mean something like
`assert_exists((select detached User filter .id = <uuid>$0))`
(probably with a better error message passed to assert_exists).
Thi... | > and probably just `<User>$0`, with the same meaning?
Yes, we want this ^ | [
{
"body": "We want to support doing things like `<User><uuid>$0` (and probably just `<User>$0`, with the same meaning?), and have it mean something like\r\n`assert_exists((select detached User filter .id = <uuid>$0))`\r\n(probably with a better error message passed to assert_exists).\r\n\r\nThis will make it a ... | ecbadbb3485a8ed4ddf4c0cd7d80a3097a7f97aa | {
"head_commit": "95cccee50ae7b088ea68955734b25895c0ebd019",
"head_commit_message": "add a test",
"patch_to_review": "diff --git a/edb/edgeql/compiler/casts.py b/edb/edgeql/compiler/casts.py\nindex 39bfb717e04..39c0dd515d3 100644\n--- a/edb/edgeql/compiler/casts.py\n+++ b/edb/edgeql/compiler/casts.py\n@@ -35,6 +3... | [
{
"diff_hunk": "@@ -2631,3 +2631,24 @@ async def test_edgeql_casts_all_null(self):\n msg=f'{cast.from_type.name} to {cast.to_type.name}',\n json_only=json_only,\n )\n+\n+ async def test_edgeql_casts_uuid_to_object(self):\n+ persons = await self.con.query('se... | 656b14304fb03c2293b329d3af4a394132093637 | diff --git a/edb/edgeql/compiler/casts.py b/edb/edgeql/compiler/casts.py
index 39bfb717e04..96d414efc7f 100644
--- a/edb/edgeql/compiler/casts.py
+++ b/edb/edgeql/compiler/casts.py
@@ -35,6 +35,7 @@
from edb.schema import functions as s_func
from edb.schema import name as sn
from edb.schema import types as s_types
+... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
geldata__gel-4453@ad92c48 | geldata/gel | Python | 4,453 | For query_single, only check that the *last* query in a script is single | Previously we errored if *any* were, which is needless.
Fixes #4311. | 2022-09-29T21:27:10Z | cardinality missmatch
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: 2.1
- OS Version: ubuntu 22.04
If I send `command.edgeql` (below) as the command to parse with expected cardinality `MANY` it returns cardinality `AT_MOST_ONE`. However if I send the same command to parse w... | Also, the error reports a different expected cardinality than the one that was used in the parse message. | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: 2.1\r\n- OS Version: ubuntu 22.04\r\n\r\nIf I send `command.edgeql` (below) as the command to parse with expected cardinality `MANY` it returns cardinality `AT_MOST_ONE`. However if I send the same command to pa... | fe882f9d62b3053787cfc26896a00132af5e3b05 | {
"head_commit": "ad92c48d26f9052371dfc48d31e414f592e16485",
"head_commit_message": "For query_single, only check that the *last* query in a script is single\n\nPreviously we errored if *any* were, which is needless.\n\nFixes #4311.",
"patch_to_review": "diff --git a/edb/server/compiler/compiler.py b/edb/server/c... | [
{
"diff_hunk": "@@ -2012,6 +2008,14 @@ def _try_compile(\n raise errors.InternalServerError(\n f'QueryUnit {unit!r} is cacheable but has config/aliases')\n \n+ multi_card = unit.cardinality in (\n+ enums.Cardinality.MANY, enums.Cardinality.AT_LEAST_O... | 2418f851c61eeae649565792984d8726b838b93b | diff --git a/edb/server/compiler/compiler.py b/edb/server/compiler/compiler.py
index 1f5470b1cc2..9ed9a0d6757 100644
--- a/edb/server/compiler/compiler.py
+++ b/edb/server/compiler/compiler.py
@@ -625,10 +625,6 @@ def _compile_ql_query(
options=self._get_compile_options(ctx),
)
- if ir.ca... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
geldata__gel-4403@8edc922 | geldata/gel | Python | 4,403 | Fix slicing with an empty set | fixes #4327 | 2022-09-22T13:06:37Z | Slicing behaves incorrectly on NULL empty sets
Another instance of a classic edgedb bug.
Slicing is a regular (non-optional) operation, and so empty set inputs should result in an empty set output, like such:
```
edgedb> select [1,2,3][1:<int64>{}];
[]
```
But empty sets that get represented as NULL produce o... | And json slicing behaves incorrectly on NULL subjects:
```
edgedb> select (<optional json>$0)[0:];
Parameter <json>$0 (Ctrl+D for empty set `{}`):
edgedb error: InvalidValueError: cannot slice JSON UNKNOWN
Hint: Slicing is only available for JSON arrays and strings.
``` | [
{
"body": "Another instance of a classic edgedb bug.\r\n\r\nSlicing is a regular (non-optional) operation, and so empty set inputs should result in an empty set output, like such:\r\n```\r\nedgedb> select [1,2,3][1:<int64>{}];\r\n[]\r\n```\r\n\r\nBut empty sets that get represented as NULL produce output as if ... | bd4be4088f20a2c23967074ecaf9282462500428 | {
"head_commit": "8edc9229f635a20d7037095cc33e8f1e68becf6b",
"head_commit_message": "touch catalog version",
"patch_to_review": "diff --git a/edb/buildmeta.py b/edb/buildmeta.py\nindex 90cb857e6aa..a511fcb5d1a 100644\n--- a/edb/buildmeta.py\n+++ b/edb/buildmeta.py\n@@ -44,7 +44,7 @@\n \n \n # Increment this whene... | [
{
"diff_hunk": "@@ -276,29 +276,37 @@ def compile_IndexIndirection(\n \n @dispatch.compile.register(irast.SliceIndirection)\n def compile_SliceIndirection(\n- expr: irast.SliceIndirection, *,\n- ctx: context.CompilerContextLevel) -> pgast.BaseExpr:\n+ expr: irast.SliceIndirection, *, ctx: conte... | fc0b2633d0a70de518c2a09170cb515049156211 | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index 90cb857e6aa..a511fcb5d1a 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -44,7 +44,7 @@
# Increment this whenever the database layout or stdlib changes.
-EDGEDB_CATALOG_VERSION = 2022_08_19_00_00
+EDGEDB_CATALOG_VERSION = 2022_09_20_00_00
EDGEDB_MAJOR... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-4196@7b1c675 | geldata/gel | Python | 4,196 | Avoid doing semi-joins after a sequence of single links | If we have a query like
```
select Post filter .owner.person.id = <uuid>$uid
```
where `owner` is `single`, there is no need to do a semi-join on
`.person`. This can have major performance impacts.
Fixes #4160. | 2022-08-02T22:58:35Z | Slow query when filtering by second link
- EdgeDB Version: 1.4+ffe1237
- OS Version: your CloudFormation template
Simplified schema:
```
Person { multi link personPosts := .<person[is Profile].profilePosts; }
Profile {
link person -> Person {
delegated constraint exclusive;
}
multi link profilePos... | Interesting. I was able to reproduce this slowness.
If we do the select on just one of the post types, like
```
select TTPost filter .owner.person.id = <uuid>'3752263c-12a0-11ed-80df-cbe9314dd309';
```
it is much faster, but still kind of slow: 250ms vs 2.6ms for one of the shape ones.
I think the crux of the is... | [
{
"body": "- EdgeDB Version: 1.4+ffe1237 \r\n- OS Version: your CloudFormation template\r\n\r\nSimplified schema:\r\n```\r\nPerson { multi link personPosts := .<person[is Profile].profilePosts; }\r\nProfile {\r\n link person -> Person {\r\n delegated constraint exclusive;\r\n }\r\n multi link profilePosts... | 2a8842897d7e3a157dee35e8ebc4e31ef99e3e58 | {
"head_commit": "7b1c6751a01d845d1902d35d197c545feb375742",
"head_commit_message": "Avoid doing semi-joins after a sequence of single links\n\nIf we have a query like\n```\nselect Post filter .owner.person.id = <uuid>$uid\n```\nwhere `owner` is `single`, there is no need to do a semi-join on\n`.person`. This can h... | [
{
"diff_hunk": "@@ -964,6 +964,32 @@ def process_set_as_path_type_intersection(\n ir_set, stmt, aspects=['value', 'source'], ctx=ctx)\n \n \n+def _source_path_is_visible(",
"line": null,
"original_line": 967,
"original_start_line": null,
"path": "edb/pgsql/compiler/relgen.py",
"start... | 62aa31369f7a2f1059fc08d8d781b22c3f50a1a5 | diff --git a/edb/pgsql/compiler/relgen.py b/edb/pgsql/compiler/relgen.py
index 4591a248f90..f54c16027bd 100644
--- a/edb/pgsql/compiler/relgen.py
+++ b/edb/pgsql/compiler/relgen.py
@@ -964,6 +964,35 @@ def process_set_as_path_type_intersection(
ir_set, stmt, aspects=['value', 'source'], ctx=ctx)
+def _sour... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
geldata__gel-4114@9a5b62f | geldata/gel | Python | 4,114 | Fix properties of type array<uuid> in migrations | The issue is that the type array<uuid> was in an inconsistent
state. The shadow reflection schema uses array<uuid>, so it is always
in the reflected schema, but since it is created by the reflection
schema code and does not appear in the stdlib, it didn't appear in the
stdschema.
Fix this by adding any collection type... | 2022-07-21T00:25:15Z | Properties or type `array<uuid>` are broken
```
edgedb> start migration to {
....... module default {
....... type Foo {
....... property myArray -> array<uuid>;
....... }; }; };
OK: START MIGRATION
edgedb[tx]> populate migration;
edgedb error: SchemaError: Array ('d2a2fc36-29e2-20f2-9861-9f2633371c73') is alre... | Hah, but it works if you create it with ddl. Amazing. | [
{
"body": "```\r\nedgedb> start migration to {\r\n....... module default {\r\n....... type Foo {\r\n....... property myArray -> array<uuid>;\r\n....... }; }; };\r\nOK: START MIGRATION\r\nedgedb[tx]> populate migration;\r\nedgedb error: SchemaError: Array ('d2a2fc36-29e2-20f2-9861-9f2633371c73') is already prese... | 6c5ed24c04bb544e78e2c45a01852b8e73fcc04c | {
"head_commit": "9a5b62f303cbb116a2625392e7035207d5791e9a",
"head_commit_message": "Fix properties of type array<uuid> in migrations\n\nThe issue is that the type array<uuid> was in an inconsistent\nstate. The shadow reflection schema uses array<uuid>, so it is always\nin the reflected schema, but since it is crea... | [
{
"diff_hunk": "@@ -100,6 +100,9 @@ def parse_into(\n name = s_name.name_from_string(entry['name__internal'])\n layout = schema_class_layout[mcls]\n \n+ if base_schema.has_object(objid) and str(name) != '__schema_version__':",
"line": null,
"original_line": 103,
"original_star... | d2587c9125dfeaaa169c68f71e6e6736a8b2ed0b | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index 415cb22ac32..5df785bda53 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -44,7 +44,7 @@
# Increment this whenever the database layout or stdlib changes.
-EDGEDB_CATALOG_VERSION = 2022_07_15_00_00
+EDGEDB_CATALOG_VERSION = 2022_07_20_00_00
EDGEDB_MAJOR... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
geldata__gel-4118@a488374 | geldata/gel | Python | 4,118 | add `std::json_set` function | Closes #3826 | 2022-07-21T21:48:05Z | Update parts of JSON properties with a json_set function
Let's say initially `myMovie.json = {"a": 10, "b": 20}`
Instead of `update Movie set {myJson := to_json('{"a": 11, "b": 20}')};`, make it possible to do something like: `update Movie set {myJson := json_set(.myJson, 'a', .myJson['a'] + 1)}`.
It could just b... | I propose the following signature:
```
json_set(
target: json,
path: array<str>, # We can't use variadic here, because new_value follows.
new_value: optional json,
named only create_if_missing: bool = false,
named only empty_treatment: JsonSetEmptyTreatment = JsonSetEmptyTreatment.ReturnEmpty,
) ->... | [
{
"body": "Let's say initially `myMovie.json = {\"a\": 10, \"b\": 20}`\r\n\r\nInstead of `update Movie set {myJson := to_json('{\"a\": 11, \"b\": 20}')};`, make it possible to do something like: `update Movie set {myJson := json_set(.myJson, 'a', .myJson['a'] + 1)}`.\r\n\r\nIt could just be syntactic sugar for ... | 49fea5feadfd25b2f55593010fc3437941479077 | {
"head_commit": "a4883743303f7bd3a83347781617d857b9ff8b01",
"head_commit_message": "rename enum for function behaviour for empty json",
"patch_to_review": "diff --git a/docs/stdlib/json.rst b/docs/stdlib/json.rst\nindex 77325ebc123..2443b505b9c 100644\n--- a/docs/stdlib/json.rst\n+++ b/docs/stdlib/json.rst\n@@ -... | [
{
"diff_hunk": "@@ -44,7 +44,7 @@\n \n \n # Increment this whenever the database layout or stdlib changes.\n-EDGEDB_CATALOG_VERSION = 2022_07_22_00_00\n+EDGEDB_CATALOG_VERSION = 2022_07_25_00_00",
"line": null,
"original_line": 47,
"original_start_line": null,
"path": "edb/buildmeta.py",
"st... | bca9dfe085adbbb9c9b7bac9555142f78bdc80c1 | diff --git a/docs/stdlib/json.rst b/docs/stdlib/json.rst
index 77325ebc123..2443b505b9c 100644
--- a/docs/stdlib/json.rst
+++ b/docs/stdlib/json.rst
@@ -38,6 +38,9 @@ JSON
* - :eql:func:`json_get`
- :eql:func-desc:`json_get`
+ * - :eql:func:`json_set`
+ - :eql:func-desc:`json_set`
+
* - :eql:... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
geldata__gel-4014@704d27c | geldata/gel | Python | 4,014 | Disallow shapes on computed links | We currently produce nonsensical error messages saying a type does not
exist that clearly does.
Fixes #3369. | 2022-06-30T20:56:48Z | InvalidReferenceError when creating an alias
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: rc4 (current master)
- OS Version: linux
Steps to Reproduce:
```
edgedb> create type Foo;
OK: CREATE TYPE
edgedb> create type Bar;
OK: CREATE TYPE
edgedb> alter type Foo creat... | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: rc4 (current master)\r\n- OS Version: linux\r\n\r\nSteps to Reproduce:\r\n\r\n```\r\nedgedb> create type Foo;\r\nOK: CREATE TYPE\r\nedgedb> create type Bar;\r\nOK: CREATE TYPE\r\nedgedb> alter type Foo create li... | 5b2905fc82a72ed8b85d0a3f9765b50fa4be712d | {
"head_commit": "704d27c519a3cb39b00d3491783b0c06a62f2e73",
"head_commit_message": "Disallow shapes on computed links\n\nWe currently produce nonsensical error messages saying a type does not\nexist that clearly does.\n\nFixes #3369.",
"patch_to_review": "diff --git a/edb/schema/pointers.py b/edb/schema/pointers... | [
{
"diff_hunk": "@@ -1211,6 +1211,17 @@ def _parse_computable(\n context=srcctx,\n )\n \n+ if (\n+ not isinstance(source, Pointer)\n+ and not source.is_view(schema) # type: ignore\n+ and target.is_view(expression.irast.schema)\n+ ... | c3f06838c6f7693f10e071651b41b0942d5f5d53 | diff --git a/edb/schema/pointers.py b/edb/schema/pointers.py
index 9b6c0875068..d0ec755de27 100644
--- a/edb/schema/pointers.py
+++ b/edb/schema/pointers.py
@@ -1211,6 +1211,17 @@ def _parse_computable(
context=srcctx,
)
+ if (
+ not isinstance(source, Pointer)
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-3899@839d2ce | geldata/gel | Python | 3,899 | Add support for socket activation | Since the idiomatic approach is to have an EdgeDB instance per project
it is easy to end up with dozens of EdgeDB instances running on the user
machine even when idle. This is problematic from memory consumption
perspective (though a lot less with `on_demand` compiler pool mode).
Thankfully, both systemd and launchd h... | 2022-05-25T19:05:55Z | Add support for systemd/launchd/intetd socket activation
edgedb-server should be a good citizen and support common socket-activation protocols. This, coupled with `--auto-shutdown-after` will largely obviate the need for `instance --start-conf` and will make it so that only actively-used server instances are running o... | [
{
"body": "edgedb-server should be a good citizen and support common socket-activation protocols. This, coupled with `--auto-shutdown-after` will largely obviate the need for `instance --start-conf` and will make it so that only actively-used server instances are running on a developer machine.",
"number":... | 5acc42f6dc966902c6fafeebd8ab9cff3dbef10b | {
"head_commit": "839d2ceceb9ec35bbe36f651c9e0ac68c632d13a",
"head_commit_message": "Add support for socket activation\n\nSince the idiomatic approach is to have an EdgeDB instance per project\nit is easy to end up with dozens of EdgeDB instances running on the user\nmachine even when idle. This is problematic fro... | [
{
"diff_hunk": "@@ -0,0 +1,223 @@\n+#\n+# This source file is part of the EdgeDB open source project.\n+#\n+# Copyright 2016-present MagicStack Inc. and the EdgeDB authors.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the Licen... | 5b722df808b8668b1b4a2875513958daa27e9087 | diff --git a/edb/server/args.py b/edb/server/args.py
index 281933cb832..975f37bcba5 100644
--- a/edb/server/args.py
+++ b/edb/server/args.py
@@ -124,8 +124,9 @@ class ServerConfig(NamedTuple):
default_database_user: Optional[str]
devmode: bool
testmode: bool
- bind_addresses: tuple[str]
+ bind_addr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
geldata__gel-3735@76576af | geldata/gel | Python | 3,735 | Make schema::Type.from_alias include generated target types | Aliases with nested shapes need to create schema types for
those views, and it gives the names like `__UserAlias__deck`.
These are types that have `is_view` as True inside the compiler
but don't have an `expr` field, so this fact isn't exposed
to introspection at all.
An alternative would be to add a new field (`is_v... | 2022-04-07T00:18:36Z | Aliases with sub shapes break data view
If you point the data viewer at the `User` table from the `cards` schema in the test suite, it runs a broken query, with the relevant part being something like:
```
__default__AwardAlias__winner_name_upper := ([is default::__AwardAlias__winner].name_upper)[<__std__::int64>$__ed... | [
{
"body": "If you point the data viewer at the `User` table from the `cards` schema in the test suite, it runs a broken query, with the relevant part being something like:\r\n```\r\n__default__AwardAlias__winner_name_upper := ([is default::__AwardAlias__winner].name_upper)[<__std__::int64>$__edb_arg_8:<__std__:... | 76a553355b95c800e1ac22b7d08fccf46c3f685c | {
"head_commit": "76576af1c75b351df56968312d6a5d7932dbb183",
"head_commit_message": "Make schema::Type.from_alias include generated target types\n\nAliases with nested shapes need to create schema types for\nthose views, and it gives the names like `__UserAlias__deck`.\n\nThese are types that have `is_view` as True... | [
{
"diff_hunk": "@@ -76,7 +76,8 @@ CREATE TYPE schema::PseudoType EXTENDING schema::Type;\n \n ALTER TYPE schema::Type {\n CREATE PROPERTY expr -> std::str;\n- CREATE PROPERTY from_alias := EXISTS(.expr);\n+ CREATE PROPERTY expr_type -> int64;",
"line": null,
"original_line": 79,
"original_... | 1c42c40a8b16480938b247e759449bca78f60624 | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index 63eb547b21f..c1ec5058c1b 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -44,7 +44,7 @@
# Increment this whenever the database layout or stdlib changes.
-EDGEDB_CATALOG_VERSION = 2022_04_05_00_00
+EDGEDB_CATALOG_VERSION = 2022_04_06_00_00
EDGEDB_MAJOR... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-3672@9445d14 | geldata/gel | Python | 3,672 | Rebalance deeply nested `UNION` operators | We could do other associative operators if we wanted, like ++. If we
wanted to do +, we'd have to do it after type inference so that we
don't do it on floating point values, where it doesn't hold.
Fixes #3669. | 2022-03-24T23:26:32Z | Bulk Inserting Error: maximum recursion depth exceeded
I'm getting the error `edgedb.errors.InternalServerError: maximum recursion depth exceeded while calling a Python object` when I'm bulk-inserting ~50 small objects in one query.
The schema is:
```
type Person {
required property first_name -> str;
... | It seems like the size of the query overflows the call stack in the compiler.
This can easily be solved by using a `for` instead:
```
for data in array_unpack(<array<tuple<first_name: str, slug: str>>>$json_data)
union (insert Person { first_name := data.first_name, slug := data.slug })
```
where `data` is ... | [
{
"body": "I'm getting the error `edgedb.errors.InternalServerError: maximum recursion depth exceeded while calling a Python object` when I'm bulk-inserting ~50 small objects in one query.\r\n\r\nThe schema is:\r\n```\r\n type Person {\r\n required property first_name -> str;\r\n property last_name -> st... | d02c41a1c7cbd8b5c0e66878394824f34ae63fd3 | {
"head_commit": "9445d14e764b001aef7b556de045d725439db4fc",
"head_commit_message": "Rebalance deeply nested `UNION` operators\n\nWe could do other associative operators if we wanted, like ++. If we\nwanted to do +, we'd have to do it after type inference so that we\ndon't do it on floating point values, where it d... | [
{
"diff_hunk": "@@ -666,3 +692,17 @@ def flatten_set(expr: qlast.Set) -> List[qlast.Expr]:\n elements.append(el)\n \n return elements\n+\n+\n+def collect_binop(expr: qlast.Expr, op: str) -> List[qlast.Expr]:\n+ elements = []\n+ def _go(expr: qlast.Expr) -> None:",
"line": null,
"or... | 31dbd4b3bba7cf13826b6f3fe72d4f825b9e5336 | diff --git a/edb/edgeql/ast.py b/edb/edgeql/ast.py
index e27f2deabe3..74c2160859b 100644
--- a/edb/edgeql/ast.py
+++ b/edb/edgeql/ast.py
@@ -287,6 +287,7 @@ class BinOp(Expr):
left: Expr
op: str
right: Expr
+ rebalanced: bool = False
class SetConstructorOp(BinOp):
diff --git a/edb/edgeql/compiler... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-3098@31bf30b | geldata/gel | Python | 3,098 | Fix issues when migrating between regular and computed pointers | Currently we create columns for single computed pointers, which
are kept empty. These can cause trouble if they are required and
the pointer is computed. Also, data in it can persist if a pointer
goes from real to computed and back to real.
Additionally, while we do not create a link table for multi computed
pointers,... | 2021-10-26T22:25:47Z | Migrating from regular to computable property causes error
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: EdgeDB 1.0-beta.2+dev.5560.g9e95b0fa7
- OS Version: Linux
Steps to Reproduce:
```
db> CREATE TYPE Foo { CREATE PROPERTY val -> str };
OK: CREATE TYPE
db> INSERT Fo... | Those two queries actually work now, but this one fails:
```
CREATE TYPE Foo { CREATE REQUIRED PROPERTY val -> str };
ALTER TYPE Foo { ALTER PROPERTY val { USING ('qqq') } };
INSERT Foo;
```
The issue is that we aren't actually deleting the column | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: EdgeDB 1.0-beta.2+dev.5560.g9e95b0fa7\r\n- OS Version: Linux\r\n\r\nSteps to Reproduce:\r\n\r\n```\r\ndb> CREATE TYPE Foo { CREATE PROPERTY val -> str };\r\nOK: CREATE TYPE\r\ndb> INSERT Foo;\r\n{default::Foo {i... | 43978e4519033753a9efd2da4943a133fea7e308 | {
"head_commit": "31bf30b7a00909852979367822ef941787981e22",
"head_commit_message": "Fix issues when migrating between regular and computed pointers\n\nCurrently we create columns for single computed pointers, which\nare kept empty. These can cause trouble if they are required and\nthe pointer is computed. Also, da... | [
{
"diff_hunk": "@@ -4260,6 +4294,88 @@ def _create_begin(\n self.schedule_endpoint_delete_action_update(\n prop, orig_schema, schema, context)\n \n+ def _delete_property(\n+ self,\n+ prop: s_props.Property,\n+ source: s_sources.Source,\n+ source... | dafd965e1c1aa32f1444220eb1156d7aa0572850 | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index 0bb0b4c8425..e648a5ed34b 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -38,7 +38,7 @@
# Increment this whenever the database layout or stdlib changes.
-EDGEDB_CATALOG_VERSION = 2021_10_24_00_00
+EDGEDB_CATALOG_VERSION = 2021_10_26_00_00
class Me... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-2896@baa1265 | geldata/gel | Python | 2,896 | Better error messages on schema type mismatches | Make `Schema.get` produce its own error on a type mismatch instead of
using `get_by_id`, since it has access to the name and so can produce
a better message. Also pass in the sourcectx when resolving names as
part of shell construction, so that the errors will have source
contexts.
In `declarative`, replace some... | 2021-09-03T17:24:46Z | Bad error reporting on create type
```
CREATE TYPE MyStr EXTENDING str;
ERROR: InternalServerError: 'NoneType' object has no attribute 'is_schema_field'
```
Version `1.0-alpha.2+dev.391.g2276144b`
I obviously needed `CREATE SCALAR TYPE` and would expect it to be grammar error... | Paul, do you think you can look at this one yourself? This needs a relatively simple & quick fix in `edb/schema/` package.
Yes, I can take a look.
> would expect it to be grammar error
`CREATE TYPE` is valid syntax and is used to define object types. The crash in this case is caused by the fact that you're trying to... | [
{
"body": "```\r\nCREATE TYPE MyStr EXTENDING str; \r\nERROR: InternalServerError: 'NoneType' object has no attribute 'is_schema_field'\r\n```\r\nVersion `1.0-alpha.2+dev.391.g2276144b`\r\n\r\nI obviously needed `CREATE SCALAR TYPE` and would expect it to be grammar error (i.... | 1244f72aacb8fb9a80d24b440121990c34d94950 | {
"head_commit": "baa1265084e963420b74fc58ea33ff926efb2a2d",
"head_commit_message": "Handle it in declarative also\n\nFixes #2556.",
"patch_to_review": "diff --git a/edb/edgeql/declarative.py b/edb/edgeql/declarative.py\nindex c70b7af91f1..cd0530517ae 100644\n--- a/edb/edgeql/declarative.py\n+++ b/edb/edgeql/decl... | [
{
"diff_hunk": "@@ -1200,6 +1202,39 @@ def _resolve_type_expr(\n )\n \n \n+TRACER_TO_REAL_TYPE_MAP = {\n+ qltracer.ObjectType: s_objtypes.ObjectType,\n+ qltracer.ScalarType: s_scalars.ScalarType,\n+ qltracer.Constraint: s_constr.Constraint,\n+ qltracer.Annotation: s_anno.Annotation,\n+ ql... | fcbb5abc76e7da86f9778a7422744f3256f0c581 | diff --git a/edb/common/english.py b/edb/common/english.py
new file mode 100644
index 00000000000..2d3fecefdf0
--- /dev/null
+++ b/edb/common/english.py
@@ -0,0 +1,26 @@
+#
+# This source file is part of the EdgeDB open source project.
+#
+# Copyright 2009-present MagicStack Inc. and the EdgeDB authors.
+#
+# Licensed ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-3200@017cfda | geldata/gel | Python | 3,200 | Filter NULL arguments out when calling non-strict functions/operators | We have two related problems with a related solution:
- Our implementation of the AND operator, which carefully
ensures that we return NULL if either input is NULL,
is a huge performance problem that prevents the use of indexes
- User defined functions with implementations that aren't strict in
their argumen... | 2021-11-18T06:56:16Z | Functions don't always have correct strictness behavior with empty sets
Consider, in our `issues` test repo:
```
create function foo(x: str, y: int64) -> str USING (x);
SELECT BooleanTest { name, val, x := foo(.name, .val) };
```
Here, we'll incorrectly output `.name`, even when `.val` is empty.
This only h... | [
{
"body": "Consider, in our `issues` test repo:\r\n```\r\ncreate function foo(x: str, y: int64) -> str USING (x);\r\n\r\nSELECT BooleanTest { name, val, x := foo(.name, .val) };\r\n```\r\n\r\nHere, we'll incorrectly output `.name`, even when `.val` is empty.\r\n\r\nThis only happens downstream of something actu... | fe11d5100ee4ffd69f04ae254c2b49d7afee8ec6 | {
"head_commit": "017cfda35004d5b04c9e30b2bb92744919642caa",
"head_commit_message": "Filter NULL arguments out when calling non-strict functions/operators\n\nWe have two related problems with a related solution:\n - Our implementation of the AND operator, which carefully\n ensures that we return NULL if either in... | [
{
"diff_hunk": "@@ -315,6 +315,24 @@ def compile_SliceIndirection(\n return result\n \n \n+def _compile_call_args(\n+ expr: irast.Call, *,\n+ ctx: context.CompilerContextLevel\n+) -> List[pgast.BaseExpr]:\n+ args = [dispatch.compile(a.expr, ctx=ctx) for a in expr.args]\n+ for ref, ir_arg, typemo... | e72364e7a18d084b38a42a42f9489dd98fcfbd3a | diff --git a/edb/buildmeta.py b/edb/buildmeta.py
index a79ab533eb6..2401aae598f 100644
--- a/edb/buildmeta.py
+++ b/edb/buildmeta.py
@@ -38,7 +38,7 @@
# Increment this whenever the database layout or stdlib changes.
-EDGEDB_CATALOG_VERSION = 2021_11_10_00_00
+EDGEDB_CATALOG_VERSION = 2021_11_17_00_00
class Me... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-2859@55c08b6 | geldata/gel | Python | 2,859 | Drop FINAL from the syntax | The `final` attribute has some internal uses, but they don't exactly
correspond to what FINAL ought to mean in the language. It's
undocumented, so just yank it.
The one snag is that we actually currently when describing DDL will
*always* describe a scalar type as being FINAL, so dumps will contain
`CREATE FINAL SCALAR... | 2021-08-25T19:49:56Z | final seems busted
* We have a `final` property on SubclassableObject. Doing some introspection, it seems to be set on scalar types and on the "source" and "target" properties of links.
* The main implication of final seems to be that the objects are skipped when doing a propagate_ref into children?
* There is syntax... | I think that the right thing for 1.0 is the first option of "drop the syntax"?
There's `CREATE FINAL SCALAR TYPE` syntax (and corresponding SDL syntax).
It also doesn't really seem to do anything?
It's also undocumented, so +1 for dropping the syntaxes for now. | [
{
"body": "* We have a `final` property on SubclassableObject. Doing some introspection, it seems to be set on scalar types and on the \"source\" and \"target\" properties of links.\r\n* The main implication of final seems to be that the objects are skipped when doing a propagate_ref into children?\r\n* There i... | 7e78c8ad7529f4e42e8111215a384ffa51889d65 | {
"head_commit": "55c08b60471e2003948bdab70ca857c1ffe82ce0",
"head_commit_message": "Drop FINAL from the syntax\n\nThe `final` attribute has some internal uses, but they don't exactly\ncorrespond to what FINAL ought to mean in the language. It's\nundocumented, so just yank it.\n\nThe one snag is that we actually cu... | [
{
"diff_hunk": "@@ -370,6 +371,17 @@ def _cmd_tree_from_ast(\n create_cmd = cmd\n \n if isinstance(astnode, qlast.CreateScalarType):\n+ # We don't support FINAL, but old dumps specify it on all\n+ # CREATE SCALAR TYPEs, so we need to permit it in those\n+ # c... | 185313e4ed680120dd0816a38b39c971aa7bd728 | diff --git a/docs/edgeql/introspection/constraints.rst b/docs/edgeql/introspection/constraints.rst
index 87471c1c0de..74ebe709f11 100644
--- a/docs/edgeql/introspection/constraints.rst
+++ b/docs/edgeql/introspection/constraints.rst
@@ -41,7 +41,6 @@ Introspection of the ``schema::Constraint``:
Object ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.