instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
geldata__gel-2526@fa44df2 | geldata/gel | Python | 2,526 | Prevent illegal UPDATEs to covariantly overloaded link types | Insert dynamic type checks in situations where it can occur.
One slightly fiddly part is making sure that we can extract the
`__type__` from the places we need it (since doing this check can
require `__type__` in places where it otherwise wouldn't appear anywhere
in the AST). This is solved with a bit of a hack: ... | 2021-05-05T19:55:22Z | Prevent illegal UPDATEs to covariantly overloaded link types
If we have a schema like
```
type Tgt;
type SubTgt extending Tgt {
required property foo -> str;
};
type Foo {
property name -> str;
required link x -> Tgt;
};
type Bar extending Foo {
overloaded required link x -> SubTgt;
};
``... | [
{
"body": "If we have a schema like\r\n```\r\ntype Tgt;\r\ntype SubTgt extending Tgt {\r\n required property foo -> str;\r\n};\r\n\r\ntype Foo {\r\n property name -> str;\r\n required link x -> Tgt;\r\n};\r\ntype Bar extending Foo {\r\n overloaded required link x -> SubTgt;\r\n};\r\n```\r\n\r\nwe ca... | 1c222624758b549ee03e42952b38c9da85119ec1 | {
"head_commit": "fa44df2f4265e4d05ca5719580b96efafa5862ff",
"head_commit_message": "Prevent illegal UPDATEs to covariantly overloaded link types\n\nInsert dynamic type checks in situations where it can occur.\n\nOne slightly fiddly part is making sure that we can extract the\n__type__ from the places we need it (s... | [
{
"diff_hunk": "@@ -1068,6 +1081,104 @@ def process_update_body(\n dml_parts.check_ctes.append(check_cte)\n \n \n+def check_update_type(\n+ val: pgast.BaseExpr,\n+ rel_or_rvar: Union[pgast.BaseExpr, pgast.PathRangeVar],\n+ *,\n+ is_subquery: bool,\n+ ir_stmt: irast.UpdateStmt,\n+ i... | 7afe7171686ac990c7cf3cef25564f6135e39fc4 | diff --git a/edb/edgeql/compiler/pathctx.py b/edb/edgeql/compiler/pathctx.py
index 6ff109f90d5..eacdf1a03b0 100644
--- a/edb/edgeql/compiler/pathctx.py
+++ b/edb/edgeql/compiler/pathctx.py
@@ -75,7 +75,7 @@ def get_tuple_indirection_path_id(
# typeref_cache=ctx.env.type_ref_cache,
)
- return tuple_pa... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-2519@c781cf0 | geldata/gel | Python | 2,519 | Update union types in reponse to changes in their constituent types | Fixes #2409. | 2021-04-29T23:45:53Z | Server could not figure out migrations
- EdgeDB Version: 1.0-beta.2+dev.5560.g9e95b0fa7
Just doing `create-migration` for this schema from scratch makes an error:
```
module default {
type Category {
required property title -> str;
required property deleted := EXISTS(.<element[IS DeletionRec... | I don't see a link to `Category` in the schema and yet the output implies it's there.
> I don't see a link to `Category` in the schema and yet the output implies it's there.
`element` is a link to an union `Article | Category`
Yes, I see `element`, but not `category`.
> Yes, I see `element`, but not `category`.
W... | [
{
"body": "- EdgeDB Version: 1.0-beta.2+dev.5560.g9e95b0fa7\r\n\r\nJust doing `create-migration` for this schema from scratch makes an error:\r\n```\r\nmodule default {\r\n type Category {\r\n required property title -> str;\r\n required property deleted := EXISTS(.<element[IS DeletionRecord]);... | 9bfa0991018c4ac4abfafc5cdc157337f9c1e306 | {
"head_commit": "c781cf07478abb74e7a62440cfdf0771bae822e9",
"head_commit_message": "Update union types in reponse to changes in their constituent types\n\nFixes #2409.",
"patch_to_review": "diff --git a/edb/schema/links.py b/edb/schema/links.py\nindex 0f00ec29769..dc2f2417342 100644\n--- a/edb/schema/links.py\n+... | [
{
"diff_hunk": "@@ -1628,6 +1628,30 @@ def as_inherited_ref_cmd(\n return cmd\n \n \n+class DeletePointer(\n+ referencing.DeleteReferencedInheritingObject[Pointer_T],\n+ PointerCommand[Pointer_T],\n+):\n+ def _canonicalize(\n+ self,\n+ schema: s_schema.Schema,\n+ context: s... | f1049cd269f4d8c88fbd1a081640a88a4e2e4366 | diff --git a/edb/schema/links.py b/edb/schema/links.py
index 0f00ec29769..dc2f2417342 100644
--- a/edb/schema/links.py
+++ b/edb/schema/links.py
@@ -660,7 +660,7 @@ def _apply_field_ast(
class DeleteLink(
LinkCommand,
- referencing.DeleteReferencedInheritingObject[Link],
+ pointers.DeletePointer[Link],
)... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-2509@9861b5c | geldata/gel | Python | 2,509 | Fix migration prompting while adding required pointers via parent types | The key idea is that we force a `CREATE PROPERTY ... { SET REQUIRED ... }`
to be generated when appropriate even if we would normally elide it.
Forcing this to happen exposed a funny corner case in which the
diffing mechanism sometimes generates DELETE/CREATE pairs for the
__type__ link when a type is renamed. This m... | 2021-04-28T01:35:20Z | Ask for default when adding new required property
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: 1-beta.1
- EdgeDB CLI Version: beta.1
- OS Version: macOS Big Sur
Steps to Reproduce:
I made a minimal repro of how I got my schema into an inconsistent state.
1. Create a... | I have fixes for the updated test case where we add a new required property, but frustratingly, the *original* issue of adding a property via a new parent class might be a bit trickier. I'm going to spend a couple hours looking at it, but I might put up a partial fix without handling that case yes. | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: 1-beta.1\r\n- EdgeDB CLI Version: beta.1\r\n- OS Version: macOS Big Sur\r\n\r\nSteps to Reproduce:\r\n\r\nI made a minimal repro of how I got my schema into an inconsistent state.\r\n\r\n1. Create an initial sch... | a51db6812c08a7922bffcfbc2ea1f5824493ad0b | {
"head_commit": "9861b5cb45d138f27be393d96bb202b3774158b9",
"head_commit_message": "Fix migration prompting while adding required pointers via parent types\n\nThe key idea is that we force a `CREATE PROPERTY ... { SET REQUIRED ... }`\nto be generated when appropriate even if we would normally elide it.\n\nForcing... | [
{
"diff_hunk": "@@ -2605,6 +2606,10 @@ def set_annotation(self, name: str, value: Any) -> None:\n self.annotations = {}\n self.annotations[name] = value\n \n+ def ast_ignore_ownership(self) -> bool:\n+ \"\"\"Whether to force something into the AST even though it is owned\"\"\"",
... | f76068bf901b0b0f5b3012b795995c87698bc751 | diff --git a/edb/schema/delta.py b/edb/schema/delta.py
index f42c5e5263e..b756377c6c8 100644
--- a/edb/schema/delta.py
+++ b/edb/schema/delta.py
@@ -2163,6 +2163,7 @@ def _apply_fields_ast(
# and that have their value actually changed.
not fop.new_inherited
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-2483@c325643 | geldata/gel | Python | 2,483 | enable multiple string prefixes | fixes https://github.com/edgedb/edgedb/issues/2332 | 2021-04-21T21:14:58Z | Feature request: multiple string prefixes at once
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like to see implemented in EdgeDB. -->
Currently you must use either `r` or `b`, not both:
```
edgedb> br"";
error: prefix "br" is not allowed for strings, allowe... | Yeah, it's an oversight we don't have them. | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n\r\n<!-- Describe the feature you'd like to see implemented in EdgeDB. -->\r\nCurrently you must use either `r` or `b`, not both:\r\n```\r\nedgedb> br\"\";\r\nerror: prefix \"br\" is not allowed for strings, allowed: `b`, `r`\r\n... | 519adaa938a80e930b7c3f425d824f7819b09fc1 | {
"head_commit": "c32564378557d3b010c614b7b7f77a96f165f835",
"head_commit_message": "add functional test",
"patch_to_review": "diff --git a/edb/edgeql-parser/src/tokenizer.rs b/edb/edgeql-parser/src/tokenizer.rs\nindex 15e4a280725..23f8af6f0b0 100644\n--- a/edb/edgeql-parser/src/tokenizer.rs\n+++ b/edb/edgeql-par... | [
{
"diff_hunk": "@@ -654,7 +654,15 @@ impl<'a> From<SpannedToken<'a>> for CowToken<'a> {\n }\n }\n \n-fn unquote_bytes<'a>(s: &'a str) -> Result<Vec<u8>, String> {\n+fn unquote_bytes<'a>(value: &'a str) -> Result<Vec<u8>, String> {\n+ if value.starts_with(\"rb\") || value.starts_with(\"br\") {",
"line... | 0fb44fb3d7d358a4004fcdd42cffdefbf7512664 | diff --git a/edb/edgeql-parser/src/tokenizer.rs b/edb/edgeql-parser/src/tokenizer.rs
index 15e4a280725..23f8af6f0b0 100644
--- a/edb/edgeql-parser/src/tokenizer.rs
+++ b/edb/edgeql-parser/src/tokenizer.rs
@@ -339,6 +339,8 @@ impl<'a> TokenStream<'a> {
let (raw, binary) = match prefix {
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
geldata__gel-2482@6aec1a7 | geldata/gel | Python | 2,482 | implement casting between bytes and json | fixes https://github.com/edgedb/edgedb/issues/2459
Casting between bytes and json is enabled by encoding bytes to base64 encoded json strings. | 2021-04-21T19:56:51Z | Inconsistent casting of `bytes`
Weird thing about `<json>` casts is that `bytes` can be cast when part of a shape, but not directly.
```
db> SELECT <json>Foo{z := b'abc'};
{"{\"z\": \"\\\\x616263\"}"}
db> SELECT <json>b'abc';
error: cannot cast 'std::bytes' to 'std::json'
┌─ query:1:14
│
1 │ SELECT <json>... | The problem is that there's no real standard for representing binary data in JSON. So we can solve this by picking one approach and declare it as standard for how EdgeDB will treat binary data w.r.t. JSON. We can use base 64 encoding for this representation and thus allow consistent conversion/casting between `bytes` a... | [
{
"body": "Weird thing about `<json>` casts is that `bytes` can be cast when part of a shape, but not directly.\r\n\r\n```\r\ndb> SELECT <json>Foo{z := b'abc'};\r\n{\"{\\\"z\\\": \\\"\\\\\\\\x616263\\\"}\"}\r\ndb> SELECT <json>b'abc';\r\nerror: cannot cast 'std::bytes' to 'std::json'\r\n ┌─ query:1:14\r\n │\r... | 6df6041d35b27e62ad70ed6c284ceac9de7ab1d2 | {
"head_commit": "6aec1a7749441a1318101f0313161bb00373e394",
"head_commit_message": "Make json output format do base64 encoding as well, use that to drive casts\n\nThis requires some various plumbing changes to make this work in nested cases.\n\nSome logic in the IR side cast generation needed to be updated to not\... | [
{
"diff_hunk": "@@ -104,6 +105,16 @@ def is_abstract(typeref: irast.TypeRef) -> bool:\n return typeref.is_abstract\n \n \n+def is_json(typeref: irast.TypeRef) -> bool:\n+ \"\"\"Return True if *typeref* describes the json type.\"\"\"\n+ return typeref.id == s_obj.get_known_type_id('std::json')",
"l... | ccdc74a217877a800ff4a54cfed67d95b5eb4a05 | diff --git a/docs/stdlib/bytes.rst b/docs/stdlib/bytes.rst
index 3e85e4892a9..726e58014b1 100644
--- a/docs/stdlib/bytes.rst
+++ b/docs/stdlib/bytes.rst
@@ -33,9 +33,7 @@ Bytes
.. eql:type:: std::bytes
- A sequence of bytes.
-
- Bytes cannot be cast into any other type. They represent raw data.
+ A sequen... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-2443@a2a28b0 | geldata/gel | Python | 2,443 | add header to disable implicit ids | fixes https://github.com/edgedb/edgedb/issues/2430 | 2021-04-08T01:06:18Z | query header to toggle implicit object id
A query header that toggles implicit object ids should be added. This would make bindings in statically typed languages more flexible since they would not have to require that users provide an id field to decode the value into. | Feel free to work on this Frederick! | [
{
"body": "A query header that toggles implicit object ids should be added. This would make bindings in statically typed languages more flexible since they would not have to require that users provide an id field to decode the value into.",
"number": 2430,
"title": "query header to toggle implicit objec... | c2d8fe10deb81c381cd058543cc8a93bd425c9e0 | {
"head_commit": "a2a28b03dd970fb43143eee16145dcff73a98e67",
"head_commit_message": "add header to disable implicit ids\n\nhttps://github.com/edgedb/edgedb/issues/2430",
"patch_to_review": "diff --git a/docs/internals/protocol/messages.rst b/docs/internals/protocol/messages.rst\nindex b74abdb24c3..8963f2e483f 100... | [
{
"diff_hunk": "@@ -104,6 +104,7 @@ class CompileContext:\n implicit_limit: int = 0\n inline_typeids: bool = False\n inline_typenames: bool = False\n+ inline_shapeids: bool = True",
"line": null,
"original_line": 107,
"original_start_line": null,
"path": "edb/server/compiler/compi... | 2be98145579c311ab908cfa99053a4848d2792ca | diff --git a/docs/internals/protocol/messages.rst b/docs/internals/protocol/messages.rst
index b74abdb24c3..476bfd6f257 100644
--- a/docs/internals/protocol/messages.rst
+++ b/docs/internals/protocol/messages.rst
@@ -280,6 +280,10 @@ Known headers:
* 0xFF04 ``ALLOW_CAPABILITIES``: ``uint64`` -- optional bitmask of
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
geldata__gel-2410@26239eb | geldata/gel | Python | 2,410 | Consider object exclusive constraints in cardinality inference | This makes object exclusive constraints more consistent with pointer
ones and allows easily filtering on compound exclusive constraints.
We do this by looking at tuple values in addition to directly pointer
references.
Fixes #2097. Lays the groundwork for tuple ON CONFLICT. | 2021-03-29T23:07:34Z | Possibly inconsistent cardinality determination
With the following schema:
```
type Person {
required property name -> str;
constraint exclusive on ((.name,));
}
```
If I run:
```python
query_one_json("""SELECT Person FILTER .name = 'test'""")
```
I get:
```
edgedb.errors.InterfaceError: ... | @elprans
This is a server-side inference issue. @msullivan, we need to take object-level exclusive constraints into account when inferring cardinalities. | [
{
"body": "With the following schema:\r\n\r\n```\r\ntype Person {\r\n required property name -> str;\r\n constraint exclusive on ((.name,));\r\n}\r\n```\r\n\r\nIf I run:\r\n\r\n```python\r\nquery_one_json(\"\"\"SELECT Person FILTER .name = 'test'\"\"\")\r\n```\r\n\r\nI get:\r\n\r\n```\r\nedgedb.errors.Int... | 9e95b0fa79a8abdf9620ef91df9d190ae4971def | {
"head_commit": "26239eb7e83f0c2b5f47ad531d60138541ae5f17",
"head_commit_message": "Consider object exclusive constraints in cardinality inference\n\nThis makes object exclusive constraints more consistent with pointer\nones and allows easily filtering on compound exclusive constraints.\n\nWe do this by looking at... | [
{
"diff_hunk": "@@ -945,12 +1025,25 @@ def _analyse_filter_clause(\n result_set, filter_clause, scope_tree, ctx)\n \n if filtered_ptrs:\n+ ptr_set = set()\n+ # First look at each referenced pointer and see if it has\n+ # an exclusive constraint.\n for ptr, _ in filtered_... | 9da7cfe44e1747ad0135fb49bed93d9da7821d2f | diff --git a/edb/edgeql/compiler/inference/cardinality.py b/edb/edgeql/compiler/inference/cardinality.py
index d47129023d6..31e7028c8fe 100644
--- a/edb/edgeql/compiler/inference/cardinality.py
+++ b/edb/edgeql/compiler/inference/cardinality.py
@@ -36,8 +36,11 @@
from edb.edgeql import qltypes
from edb.schema impor... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-2250@bee26e0 | geldata/gel | Python | 2,250 | Catch more errors in constraints and report them better | Disallow using EXISTS and other SET OF operations on MULTI pointers
(which was previously accepted but didn't work).
Produce a better error than "ISE: unexpectedly long path in simple
expr" for constraints that try to traverse links.
Turn the "multi-table constraints not supported" ISE into a real error
with a... | 2021-02-19T02:36:42Z | Constraint expressions with backlinks give ISE
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: 1.0a7-2021011304
- OS Version: macOS 11.2
A type with a constraint expression containing a backlink causes an `edb.errors.InternalServerError: unexpectedly long path in simple expr`... | This shouldn't be an ISE, but it's a valid error: we don't support reaching across links in constraints yet, only immediate properties/links can be used in a constraint expression. | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: 1.0a7-2021011304\r\n- OS Version: macOS 11.2\r\n\r\nA type with a constraint expression containing a backlink causes an `edb.errors.InternalServerError: unexpectedly long path in simple expr` to be raised. SDL t... | 1c347dc5846a9dca88f01cf2f86178815e4a4003 | {
"head_commit": "bee26e07a9fa91327d85ff08c23f9cdf659cfcf0",
"head_commit_message": "Catch more errors in constraints and report them better\n\nDisallow using EXISTS and other SET OF operations on MULTI pointers\n(which was previously accepted but didn't work).\n\nProduce a better error than \"ISE: unexpectedly lon... | [
{
"diff_hunk": "@@ -188,8 +188,12 @@ def schema_constraint_to_backend_constraint(\n ref_tables = get_ref_storage_info(ir.schema, terminal_refs)\n \n if len(ref_tables) > 1:\n- raise ValueError(\n- 'backend: multi-table constraints are not currently supported')\n+ ... | 3cdb6f7059ea77d06f853ef76344822d7be617a2 | diff --git a/edb/ir/utils.py b/edb/ir/utils.py
index e468dba731e..b5e225db7d4 100644
--- a/edb/ir/utils.py
+++ b/edb/ir/utils.py
@@ -326,3 +326,10 @@ def contains_dml(stmt: irast.Base, *, skip_bindings: bool=False) -> bool:
visitor = ContainsDMLVisitor(skip_bindings=skip_bindings)
res = visitor.visit(stmt) is... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-2313@78fa807 | geldata/gel | Python | 2,313 | Fix a cluster of constraint and rename issues | Some things fixed:
* Track renames while generating ASTs so we don't emit references
to renamed objects
* Make sure to include subjectexpr and args when generating
ALTER CONSTRAINT asts
* Correctly use the nearest *abstract* constraint when generating
constraint names in all cases
* Consistently handle whi... | 2021-03-04T07:28:10Z | "error: constraint 'std::max_len_value' does not exist" during create-migration
EdgeDB Version: EdgeDB 1.0-beta.1+g2eee1afe4.d20210301
Changing schema from:
```
abstract type Event {
required property createdAt -> datetime {
default := datetime_current();
}
required link user -> User;
}
type Po... | If you answer yes to `did you drop constraint 'std::max_len_value' of property 'content'? [y,n,l,c,b,s,q,?]`, there's another error:
```
did you create object type 'default::HasContent'? [y,n,l,c,b,s,q,?]
y
did you alter object type 'default::Post'? [y,n,l,c,b,s,q,?]
y
did you create object type 'default::Reply'?... | [
{
"body": "EdgeDB Version: EdgeDB 1.0-beta.1+g2eee1afe4.d20210301\r\n\r\nChanging schema from:\r\n```\r\nabstract type Event {\r\n required property createdAt -> datetime {\r\n default := datetime_current();\r\n }\r\n\r\n required link user -> User;\r\n}\r\n\r\ntype Post extending Event {\r\n required pr... | b020890708f4568474b66c5fa522e3a35bb41d3c | {
"head_commit": "78fa8075295066a0f242ec518c43898d29b9f856",
"head_commit_message": "Fix a cluster of constraint and rename issues\n\nSome things fixed:\n * Track renames while generating ASTs so we don't emit references\n to renamed objects\n * Make sure to include subjectexpr and args when generating\n ALTER ... | [
{
"diff_hunk": "@@ -534,6 +571,7 @@ def get_ref_implicit_base_delta(\n if not b.get_abstract(schema)\n and b.generic(schema) and b.get_name(schema) != default_base\n ]\n+ # assert not explicit_bases",
"line": null,
"original_line": 574,
"original_start_line": n... | ca956a97ca4e4634ec0af9ee85cf4836edb8624d | diff --git a/edb/schema/constraints.py b/edb/schema/constraints.py
index fb98c210664..d4fde42bb98 100644
--- a/edb/schema/constraints.py
+++ b/edb/schema/constraints.py
@@ -77,6 +77,36 @@ def merge_constraint_params(
return supers[0].get_explicit_field_value(schema, field_name, None)
+def constraintname_fr... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-2217@ef2bf22 | geldata/gel | Python | 2,217 | Run test workflow in shards | This PR adds 3 new options to `edb test`:
* `edb test --shard 2/5` separates all collected tests into 5 shards, and run the 2nd shard only. The split is supposed to be deterministic.
* `edb test --time-file` generates a CSV file of time spent on each test. If the file exists, it'll be taken as an input for `--shard... | 2021-02-12T03:28:53Z | Improve test workflow performance
The current runtime of the test Github workflow has grown quite a bit, because we execute all tests in a single job (with `-j2`). This can be improved by splitting the test suite into chunks that can then be executed in concurrent jobs. Instance bootstrap is also quite slow and canno... | [
{
"body": "The current runtime of the test Github workflow has grown quite a bit, because we execute all tests in a single job (with `-j2`). This can be improved by splitting the test suite into chunks that can then be executed in concurrent jobs. Instance bootstrap is also quite slow and cannot be paralleliz... | 931252366e048c24e06b71106fec2e8539489e82 | {
"head_commit": "ef2bf22a48fb450ce5336364949365dc512cffd6",
"head_commit_message": "Run test workflow in shards\n\nThis PR adds 3 new options to `edb test`:\n\n* `edb test --shard 2/5` separates all collected tests into 5 shards,\n and run the 2nd shard only. The split is supposed to be deterministic.\n* `edb tes... | [
{
"diff_hunk": "@@ -80,8 +83,13 @@\n help='package name to measure code coverage for, '\n 'can be specified multiple times '\n '(e.g --cov edb.common --cov edb.server)')\n-def test(*, files, jobs, include, exclude, verbose, quiet, debug,\n- output_form... | 20c43b9bf8685ad7e686150da10951842a200e40 | diff --git a/.editorconfig b/.editorconfig
index 69692d36be8..562d6ce1ff4 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -4,10 +4,14 @@ root = true
trim_trailing_whitespace = true
insert_final_newline = true
-[*.{py,pyx,pxd,pxi,yml,h}]
+[*.{py,pyx,pxd,pxi,h}]
indent_size = 4
indent_style = space
+[*.yml]
+in... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Test Suite / CI Enhancements"
} | |
geldata__gel-2151@f5eecfe | geldata/gel | Python | 2,151 | Replace weak namespace stripping with smarter rewriting | Instead of "stripping" weak namespaces from all paths, instead rewrite
weak namespaces to be "absolute" by removing namespaces that don't
appear at the binding site for the path.
Fixes #1381. | 2021-01-26T03:20:33Z | Incorrect result for a value computed in WITH block
Run the following in the existing scope tests dataset (from `test_edgeql_scope.py`):
```
WITH
MODULE test,
avg := math::mean({len(Card.name)})
SELECT Card {name, a := avg};
```
Instead of being the same value across all results `a` is different for eac... | I can even simplify it further to:
```
WITH
MODULE test,
avg := count({Card.name})
SELECT Card {name, a := avg};
```
Or even
```
WITH
MODULE test,
avg := Card.name
SELECT Card {name, a := avg};
```
@elprans can we fix this for alpha 3?
(if not move it to Alpha 4)
The fix isn't trivial, so... | [
{
"body": "Run the following in the existing scope tests dataset (from `test_edgeql_scope.py`):\r\n```\r\nWITH \r\n MODULE test,\r\n avg := math::mean({len(Card.name)})\r\nSELECT Card {name, a := avg};\r\n```\r\nInstead of being the same value across all results `a` is different for each as if the functio... | 54ea90c95686f09106a95a2eb50259ee1dd7bd49 | {
"head_commit": "f5eecfe4fd5b4c4409eece3c6c889f23d29ef5b1",
"head_commit_message": "Replace weak namespace stripping with smarter rewriting\n\nInstead of \"stripping\" weak namespaces from all paths, instead rewrite\nweak namespaces to be \"absolute\" by removing namespaces that don't\nappear at the binding site f... | [
{
"diff_hunk": "@@ -254,10 +250,106 @@ def fini_expression(\n return result\n \n \n+class FindPathScopes(ast_visitor.NodeVisitor):\n+ \"\"\"Visitor to find the enclosing path scope id of sub expressions.\n+\n+ Sets inherit an effective scope id from enclosing expressions,\n+ and this visitor comput... | d1f91ba311609945df17eed23b07c00a170378c8 | diff --git a/edb/common/ast/visitor.py b/edb/common/ast/visitor.py
index aaa61c6bcd2..830caf758d5 100644
--- a/edb/common/ast/visitor.py
+++ b/edb/common/ast/visitor.py
@@ -170,7 +170,7 @@ def generic_visit(self, node, *, combine_results=None):
for _field, value in base.iter_fields(node, include_meta=False):
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-2075@834d76c | geldata/gel | Python | 2,075 | Fix "cannot describe type" ISE in cast+array+empty set interactions | Fixes #1586. | 2020-12-22T00:17:46Z | InternalServerError: cannot describe type default::User
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: Docker: `1.0a4-2020071615~buster`
Steps to Reproduce:
Run: ` SELECT <array<User>>{};`
<!-- If the issue is about a query error, please also provide your schema -->
Sc... | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: Docker: `1.0a4-2020071615~buster`\r\n\r\nSteps to Reproduce:\r\n\r\nRun: ` SELECT <array<User>>{};`\r\n\r\n<!-- If the issue is about a query error, please also provide your schema -->\r\nSchema:\r\n```esdl\r\nt... | f26ce600a5c7f6f42c09dbf261a14ff7f031949c | {
"head_commit": "834d76c44f7e334ed75d158ea481baa52d737d27",
"head_commit_message": "Fix \"cannot describe type\" ISE in cast+array+empty set interactions\n\nFixes #1586.",
"patch_to_review": "diff --git a/edb/server/compiler/sertypes.py b/edb/server/compiler/sertypes.py\nindex 651372d5d99..ad2fdc76724 100644\n--... | [
{
"diff_hunk": "@@ -205,7 +206,17 @@ def _describe_type(self, t, view_shapes, view_shapes_metadata,\n elif isinstance(t, s_types.Collection):\n raise errors.SchemaError(f'unsupported collection type {t!r}')\n \n- elif view_shapes.get(t):\n+ elif isinstance(t, s_objtypes.ObjectT... | 3b71e8660f10d56941cca4cc73ea53f257489d66 | diff --git a/edb/server/compiler/sertypes.py b/edb/server/compiler/sertypes.py
index 651372d5d99..948eefbec06 100644
--- a/edb/server/compiler/sertypes.py
+++ b/edb/server/compiler/sertypes.py
@@ -33,6 +33,7 @@
from edb.schema import links as s_links
from edb.schema import objects as s_obj
+from edb.schema import o... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-2032@a572cb2 | geldata/gel | Python | 2,032 | Fix the inconsistent use of the DROP keyword in DDL | Currently, we use `DROP` in DDL somewhat inconsistently and confusingly to:
1. Revert to the default or inherited value (`DROP default`).
2. In specific cases, like `DROP REQUIRED`, to set the field to a falsy value.
3. To actually delete a schema object, such as `DROP PROPERTY`.
To fix this we:
1. Introduce the `R... | 2020-12-05T04:05:41Z | Fix the inconsistent use of the DROP keyword in DDL
Currently, we use `DROP` in DDL somewhat inconsistently and confusingly to:
1. Revert to the default or inherited value (`DROP default`).
2. In specific cases, like `DROP REQUIRED`, to set the field to a falsy value.
3. To actually delete a schema object, such a... | There are more "set to falsy" cases in DDL currently (in addition to `DROP REQUIRED` mentioned above):
`DROP ABSTRACT`: proposed replacement is `SET CONCRETE` or `SET REAL` (alternatively: `RESET ABSTRACT`)
`DROP FINAL`: proposed replacement is `SET NONFINAL` (alternatively: `RESET FINAL`)
`DROP DELEGATED`: propos... | [
{
"body": "Currently, we use `DROP` in DDL somewhat inconsistently and confusingly to:\r\n\r\n1. Revert to the default or inherited value (`DROP default`).\r\n2. In specific cases, like `DROP REQUIRED`, to set the field to a falsy value.\r\n3. To actually delete a schema object, such as `DROP PROPERTY`.\r\n\r\... | e2bf3c304e5b3ebad2c4aff89446b92e1fb0bea2 | {
"head_commit": "a572cb2f647facef1a6fe6cdd96a5d0f287a46b5",
"head_commit_message": "Fix the inconsistent use of the DROP keyword in DDL\n\nCurrently, we use `DROP` in DDL somewhat inconsistently and confusingly to:\n\n1. Revert to the default or inherited value (`DROP default`).\n2. In specific cases, like `DROP ... | [
{
"diff_hunk": "@@ -331,7 +331,7 @@ The following subcommands are allowed in the ``ALTER LINK`` block:\n Remove an :ref:`index <ref_datamodel_indexes>` defined on *index-expr*\n from this link. See :eql:stmt:`DROP INDEX` for details.\n \n-:eql:synopsis:`DROP default`\n+:eql:synopsis:`RESET default`\n ... | 899c7b0fc7df86eaecaa507e610198bd87b5cb79 | diff --git a/docs/edgeql/ddl/constraints.rst b/docs/edgeql/ddl/constraints.rst
index 865c382eb9e..c4b5ee94067 100644
--- a/docs/edgeql/ddl/constraints.rst
+++ b/docs/edgeql/ddl/constraints.rst
@@ -135,7 +135,7 @@ Alter the definition of an
RENAME TO <newname>
USING <constr-expression>
SET errmessag... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
geldata__gel-1964@9b7e997 | geldata/gel | Python | 1,964 | Disallow scalar types with more than one concrete base | Fixes #1790. | 2020-11-10T22:26:31Z | Prohibit inheriting scalar types from more than one non-abstract scalar type
Currently:
```
select> CREATE SCALAR TYPE test::myint EXTENDING std::int64, std::str;
OK: CREATE
```
We have to prohibit this by enforcing that there must be exactly one base non-abstract scalar type in the ancestry of a new non-abstr... | Why that rule instead of requiring a single root scalar type?
> Why that rule instead of requiring a single root scalar type?
Because multiple inheritance from different abstract scalar types is useful. For example:
```
CREATE SCALAR TYPE std::bigint EXTENDING std::anynumeric, std::anyint;
``` | [
{
"body": "Currently:\r\n\r\n```\r\nselect> CREATE SCALAR TYPE test::myint EXTENDING std::int64, std::str;\r\nOK: CREATE\r\n```\r\n\r\nWe have to prohibit this by enforcing that there must be exactly one base non-abstract scalar type in the ancestry of a new non-abstract scalar type.",
"number": 1790,
"... | c8e571d76e76dcc0c999dc09efb1f736dc15d87a | {
"head_commit": "9b7e997da0fce8054e61f94fb256c28f76871934",
"head_commit_message": "Disallow scalar types with more than one concrete base\n\nFixes #1790.",
"patch_to_review": "diff --git a/edb/schema/scalars.py b/edb/schema/scalars.py\nindex 53ffdf84f5c..6bf2b94a4a7 100644\n--- a/edb/schema/scalars.py\n+++ b/ed... | [
{
"diff_hunk": "@@ -222,7 +222,45 @@ class ScalarTypeCommand(\n schema_metaclass=ScalarType,\n context_class=ScalarTypeCommandContext,\n ):\n- pass\n+ def apply(\n+ self,\n+ schema: s_schema.Schema,\n+ context: sd.CommandContext,\n+ ) -> s_schema.Schema:\n+ v_ancesto... | 188a5153f745a3e9929d081745a8f132a3424f35 | diff --git a/edb/schema/scalars.py b/edb/schema/scalars.py
index 53ffdf84f5c..6c678783fe1 100644
--- a/edb/schema/scalars.py
+++ b/edb/schema/scalars.py
@@ -222,7 +222,51 @@ class ScalarTypeCommand(
schema_metaclass=ScalarType,
context_class=ScalarTypeCommandContext,
):
- pass
+ def validate_scalar_anc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-1762@6c99f8c | geldata/gel | Python | 1,762 | Fix broken SET OF/OPTIONAL interactions | The interaction between SET OF and OPTIONAL needs more careful
handling than is done currently.
Basically, the idea is:
1. Merging an optional path with a non-optional one should result in a
non-optional path, *unless* the non-optional path was fenced.
2. When an path is factored out past an optional parent, it shou... | 2020-09-11T22:28:21Z | Bug in interaction of OPTIONAL and SET OF
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: 1.0-alpha.4+dev.92.g20b0bd7f
- OS Version: Linux
Steps to Reproduce:
```
victor> CREATE TYPE Foo;
OK: CREATE
victor> SELECT (<str>Foo.id) ?? (<str>count(Foo));
{}
```
The expect... | Another example is `SELECT (<str>Foo.id ?= <str>count(Foo));`, which returns `{}` instead of `{false}`.
There seems to be some trickiness, here, though, since we *do* want those sides to be correlated. If we add a `num` field to `Foo`, we want `SELECT (Foo.num ?= count(Foo));` to only be true for objects where num =... | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: 1.0-alpha.4+dev.92.g20b0bd7f\r\n- OS Version: Linux\r\n\r\nSteps to Reproduce:\r\n\r\n```\r\nvictor> CREATE TYPE Foo;\r\nOK: CREATE\r\nvictor> SELECT (<str>Foo.id) ?? (<str>count(Foo));\r\n{}\r\n```\r\nThe expec... | 21b003430d6b1bfff4ec9a0e16df7795b040658f | {
"head_commit": "6c99f8c2849ef51861b80ae900371fff5313f3de",
"head_commit_message": "Fix another bug--iterate over paths",
"patch_to_review": "diff --git a/edb/edgeql/compiler/context.py b/edb/edgeql/compiler/context.py\nindex 68241d81c66..c33149b3ee6 100644\n--- a/edb/edgeql/compiler/context.py\n+++ b/edb/edgeql... | [
{
"diff_hunk": "@@ -790,6 +828,14 @@ def find_descendant_and_ns(\n \n return None, frozenset(), None\n \n+ def is_optional_upto(self, ancestor: Optional[ScopeTreeNode]) -> bool:\n+ nobe: Optional[ScopeTreeNode] = self",
"line": null,
"original_line": 832,
"original_start_line": nul... | 8a1a92c60b9edf75fdc9070caf6b895a82ed1d1f | diff --git a/edb/edgeql/compiler/context.py b/edb/edgeql/compiler/context.py
index 68241d81c66..c33149b3ee6 100644
--- a/edb/edgeql/compiler/context.py
+++ b/edb/edgeql/compiler/context.py
@@ -491,6 +491,9 @@ class ContextLevel(compiler.ContextLevel):
"""A set of schema objects for which the shadowing rewrite shou... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-1604@f24e1fa | geldata/gel | Python | 1,604 | Don't crash on empty set as FOR iterator. | This catches the issue and reports an error in the compiler.
Fixes #1585.
I figure there's no compelling reason to also catch the special
syntactic case in the parser, given that we need to handle it in a
more general way in the compiler anyway? | 2020-07-28T21:48:33Z | InternalServerError: local variable 'derived' referenced before assignment
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: Docker: `1.0a4-2020071615~buster`
This code causes error:
```edgeql
START TRANSACTION;
START MIGRATION TO {
module default {
function cre... | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: Docker: `1.0a4-2020071615~buster`\r\n\r\nThis code causes error:\r\n```edgeql\r\nSTART TRANSACTION;\r\nSTART MIGRATION TO {\r\n module default {\r\n function create_user() -> str\r\n {\r\n ... | 8b14cc682b26d7c465ccf2f79abe98b713006cb8 | {
"head_commit": "f24e1fa3fda1b9dafd01c5b3249d1c0ae73012c1",
"head_commit_message": "Don't crash on empty set as FOR iterator.\n\nThis catches the issue and reports an error in the compiler.\n\nFixes #1585.",
"patch_to_review": "diff --git a/edb/edgeql/compiler/schemactx.py b/edb/edgeql/compiler/schemactx.py\nind... | [
{
"diff_hunk": "@@ -213,6 +213,9 @@ def derive_view(\n stmtctx.pend_pointer_cardinality_inference(\n ptrcls=ptr, ctx=ctx)\n \n+ else:\n+ raise RuntimeError(\"unsupported type in derive_view\")",
"line": null,
"original_line": 217,
"original_start... | 264f46daa47f4a6b43ca71fe1cc8795b4ba8e031 | diff --git a/edb/edgeql/compiler/schemactx.py b/edb/edgeql/compiler/schemactx.py
index 1a8ebab3672..2e0cac5f3da 100644
--- a/edb/edgeql/compiler/schemactx.py
+++ b/edb/edgeql/compiler/schemactx.py
@@ -213,6 +213,9 @@ def derive_view(
stmtctx.pend_pointer_cardinality_inference(
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
geldata__gel-1628@47ed491 | geldata/gel | Python | 1,628 | Implement basic select-or-insert via coalesce | Implement a select-or-insert idiom using
`(SELECT ...) ?? (INSERT ...)`.
We only allow it under restricted circumstances (when the select and
insert both use the same value for an exclusive property) and it is
compiled using ON CONFLICT.
This doesn't work when the values are constants yet, because the
normalizer trea... | 2020-08-03T23:43:26Z | SELECT Object IF EXISTS Object ELSE INSERT
Hi, I tried to use the IF...ELSE and EXISTS clauses in order to construct a query that either selects an item if it exists or else inserts it. So since I can do the following:
```
SELECT 1 IF EXISTS (SELECT Person FILTER .name = 'Ryan Gosling')
....... ELSE (SELECT 0);
`... | Soon after opening this and trying various permutations, I realized that the left and right assignments need to be identical in type and be a singleton on both ends if I want to make an insert statement.
Closing this. Please feel free to delete.
@vpetrovykh should we enhance our error message here?
Another related q... | [
{
"body": "Hi, I tried to use the IF...ELSE and EXISTS clauses in order to construct a query that either selects an item if it exists or else inserts it. So since I can do the following:\r\n```\r\nSELECT 1 IF EXISTS (SELECT Person FILTER .name = 'Ryan Gosling') \r\n....... ELSE (SELECT 0);\r\n```\r\n...I tried ... | c569d8dc24a4584fe32d6b7bc823208cbc396283 | {
"head_commit": "47ed491e40235632d55143b43541f368110f9677",
"head_commit_message": "Implement basic select-or-insert via coalesce\n\nImplement a select-or-insert idiom using\n`(SELECT ...) ?? (INSERT ...)`.\n\nWe only allow it under restricted circumstances (when the select and\ninsert both use the same value for ... | [
{
"diff_hunk": "@@ -715,7 +715,7 @@ class MutatingStmt(Stmt):\n \n \n class InsertStmt(MutatingStmt):\n- pass\n+ on_conflict: typing.Optional[typing.List[PointerRef]] = None",
"line": null,
"original_line": 718,
"original_start_line": null,
"path": "edb/ir/ast.py",
"start_line": null,
... | ad74bd99df646aae4f7233c478f0596ba878ab46 | diff --git a/edb/edgeql/compiler/expr.py b/edb/edgeql/compiler/expr.py
index 9cddc49892f..6b63d87d9d7 100644
--- a/edb/edgeql/compiler/expr.py
+++ b/edb/edgeql/compiler/expr.py
@@ -47,6 +47,7 @@
from . import pathctx
from . import setgen
from . import typegen
+from . import stmt
from . import func # NOQA
@@ -7... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
geldata__gel-1575@5f9fc14 | geldata/gel | Python | 1,575 | Disallow using std::exclusive on scalar types | Fixes #1182. | 2020-07-23T20:22:31Z | InternalServerError error creating scalar type
<!-- Please search existing issues to avoid creating duplicates. -->
- EdgeDB Version: `1.0-alpha.2+dev.505.g5b68ec24`
Steps to Reproduce:
```
START TRANSACTION;
CREATE MIGRATION init TO {
module default {
scalar type unique_name extending str {
... | Ah. Right. `exclusive` constraints are not supported on scalar types. The bug is that there's no explicit check for that.
You can only declare such constraints on links and properties (support for object types is being added), so:
```
type User {
required property nickname -> str {
constraint exc... | [
{
"body": "<!-- Please search existing issues to avoid creating duplicates. -->\r\n- EdgeDB Version: `1.0-alpha.2+dev.505.g5b68ec24`\r\n\r\nSteps to Reproduce:\r\n\r\n```\r\nSTART TRANSACTION;\r\nCREATE MIGRATION init TO {\r\n module default {\r\n scalar type unique_name extending str {\r\n ... | 20b0bd7fe932f1e73c0980495d648f9b4dd33bef | {
"head_commit": "5f9fc14ad4329c0555ed41c0d4e2147f40b1d8b3",
"head_commit_message": "Disallow using std::exclusive on scalar types\n\nFixes #1182.",
"patch_to_review": "diff --git a/edb/lib/std/50-constraints.edgeql b/edb/lib/std/50-constraints.edgeql\nindex 684d7eb0113..069e2ca0b20 100644\n--- a/edb/lib/std/50-c... | [
{
"diff_hunk": "@@ -733,6 +736,12 @@ def _populate_concrete_constraint_attrs(\n f'subjectexpr is already defined for {name!r}'\n )\n \n+ if (isinstance(subject_obj, s_scalars.ScalarType)\n+ and constr_base.get_is_aggregate(schema)):\n+ raise errors.In... | c6ddd79d7ab085f231895f8767c1cdb2b9b00bf4 | diff --git a/edb/lib/std/50-constraints.edgeql b/edb/lib/std/50-constraints.edgeql
index 684d7eb0113..069e2ca0b20 100644
--- a/edb/lib/std/50-constraints.edgeql
+++ b/edb/lib/std/50-constraints.edgeql
@@ -46,6 +46,7 @@ std::expression EXTENDING std::constraint
CREATE ABSTRACT CONSTRAINT
std::exclusive EXTENDING std::... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
geldata__gel-1376@a77cb9a | geldata/gel | Python | 1,376 | Propagate dev_mode and psql path to CLI | Fixes edgedb/edgedb-cli#32
Requires edgedb/edgedb-cli#34 to be applied first. | 2020-04-30T15:45:40Z | \psql should use our postgres/bin, not the system one
```
yury> \psql
Error executing command: Error running "psql" "-h" "/Users/yury/.edgedb" "-U" "edgedb" "-p" "55043" "-d" "edgedb"
```
^ I don't have system postgres, so there's no `psql` command in my `$PATH`.
Our Python repl code does this to locate the `p... | Python does that because it is in the same package as edgedb itself. When we use current CLI tools we can use them against *multiple different* edgedb servers, including ones not installed locally.
So to replicate that, we need to expose postgres directory from the edgedb server itself. And that still doesn't work i... | [
{
"body": "```\r\nyury> \\psql\r\nError executing command: Error running \"psql\" \"-h\" \"/Users/yury/.edgedb\" \"-U\" \"edgedb\" \"-p\" \"55043\" \"-d\" \"edgedb\"\r\n```\r\n\r\n^ I don't have system postgres, so there's no `psql` command in my `$PATH`.\r\n\r\nOur Python repl code does this to locate the `psq... | 0dd69ba8fa490ccb87e788f75fcf5e30604ccb18 | {
"head_commit": "a77cb9aaee0ced9602fbd46695d7157d986219cb",
"head_commit_message": "Propagate dev_mode and psql path to CLI\n\nFixes edgedb/edgedb-cli#32",
"patch_to_review": "diff --git a/setup.py b/setup.py\nindex fbd37381820..7014a9d9649 100644\n--- a/setup.py\n+++ b/setup.py\n@@ -298,10 +298,12 @@ class deve... | [
{
"diff_hunk": "@@ -298,10 +298,12 @@ class develop(setuptools_develop.develop):\n def run(self, *args, **kwargs):\n _check_rust()\n build = self.get_finalized_command('build')\n+ build_base = pathlib.Path('build').resolve()",
"line": null,
"original_line": 301,
"original_... | ad15d84424da0fc34bddd957da961c63fc014a16 | diff --git a/setup.py b/setup.py
index fbd37381820..74493b07d28 100644
--- a/setup.py
+++ b/setup.py
@@ -299,9 +299,11 @@ def run(self, *args, **kwargs):
_check_rust()
build = self.get_finalized_command('build')
rust_tmp = pathlib.Path(build.build_temp) / 'rust' / 'cli'
- rust_root = p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
geldata__gel-1512@b7cdec6 | geldata/gel | Python | 1,512 | Forbid reference to link properties not from links | closes #1471 | 2020-07-03T07:04:04Z | InternalServerError: 'NoneType' object has no attribute 'ptrref'
- EdgeDB Version: 1.0-alpha.3+dev.247.g04b74247
Steps to Reproduce:
Error occurs when a computed property has a link property path on a subquery, eg.
```
WITH MODULE schema
SELECT ObjectType {
name,
# error occurs with this line:
annot... | `(SELECT .annotations)@value` should be a `ReferenceError`. The only valid form of link property reference is `.link@prop`. | [
{
"body": "- EdgeDB Version: 1.0-alpha.3+dev.247.g04b74247\r\n\r\nSteps to Reproduce:\r\nError occurs when a computed property has a link property path on a subquery, eg.\r\n\r\n```\r\nWITH MODULE schema\r\nSELECT ObjectType {\r\n name,\r\n\r\n # error occurs with this line:\r\n annotationValues := (SELECT .... | d81cf8500d056191651575285b0bc19602fb501b | {
"head_commit": "b7cdec6bf563122694bf568f185ae80f458b5dea",
"head_commit_message": "Forbid reference to link properties not from links",
"patch_to_review": "diff --git a/edb/edgeql/compiler/setgen.py b/edb/edgeql/compiler/setgen.py\nindex 6f46dc9acbe..8b8cb16b2db 100644\n--- a/edb/edgeql/compiler/setgen.py\n+++ ... | [
{
"diff_hunk": "@@ -264,6 +264,15 @@ def compile_path(expr: qlast.Path, *, ctx: context.ContextLevel) -> irast.Set:\n if ptr_expr.type == 'property':\n # Link property reference; the source is the\n # link immediately preceding this step in the path.\n+ ... | 0000bfcda80e0fa02e748fee012987f8324e328a | diff --git a/edb/edgeql/compiler/setgen.py b/edb/edgeql/compiler/setgen.py
index 6f46dc9acbe..3b32f5d2900 100644
--- a/edb/edgeql/compiler/setgen.py
+++ b/edb/edgeql/compiler/setgen.py
@@ -264,6 +264,13 @@ def compile_path(expr: qlast.Path, *, ctx: context.ContextLevel) -> irast.Set:
if ptr_expr.type == 'p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
geldata__gel-936@3aba084 | geldata/gel | Python | 936 | Make `$something` a token instead of two | Fixes #923 | 2019-12-05T11:14:28Z | Improve tokenization of variables
The current tokenizer separates `$` and ident or number tokens. This means the following is valid (apart from mixing positional and named arguments):
```
SELECT $ x, $ 12, $ `test`
```
It's okay, but isn't needed per se.
It also means tuple access doesn't work sometimes:
... | Right, looks like among other things we need more tests using parametrized queries. Good catch! | [
{
"body": "The current tokenizer separates `$` and ident or number tokens. This means the following is valid (apart from mixing positional and named arguments):\r\n```\r\nSELECT $ x, $ 12, $ `test`\r\n```\r\nIt's okay, but isn't needed per se.\r\n\r\nIt also means tuple access doesn't work sometimes:\r\n`... | 383d4e45fcb22c80c557e682e06128f87b042ba1 | {
"head_commit": "3aba0849199e8dd6decc7cb64101d3ee90a50bd0",
"head_commit_message": "Make `$something` a token instead of two\n\nFixes #923",
"patch_to_review": "diff --git a/edb/edgeql/parser/grammar/commondl.py b/edb/edgeql/parser/grammar/commondl.py\nindex a16f27208f1..715efe9a850 100644\n--- a/edb/edgeql/pars... | [
{
"diff_hunk": "@@ -1776,6 +1776,32 @@ def test_edgeql_syntax_path_28(self):\n SELECT TUP.1.1;\n \"\"\"\n \n+ def test_edgeql_syntax_path_29(self):\n+ # legal when `$0`, `$1`, `$a` and `$abc` are tuples\n+ \"\"\"\n+ SELECT $0.0;\n+ SELECT $0.0.name;\n+ SELEC... | ed99bc5d510e2008c153b4e2498b69a9efea492f | diff --git a/edb/edgeql/codegen.py b/edb/edgeql/codegen.py
index b753001eaed..d722c3bade7 100644
--- a/edb/edgeql/codegen.py
+++ b/edb/edgeql/codegen.py
@@ -446,7 +446,8 @@ def visit_Path(self, node: qlast.Path) -> None:
qlast.Set,
qlast.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
mealie-recipes__mealie-4231@301a7af | mealie-recipes/mealie | Python | 4,231 | feat: Add Household Filter to Meal Plan Rules | ## What type of PR is this?
_(REQUIRED)_
- feature
## What this PR does / why we need it:
_(REQUIRED)_
Adds a household filter to meal plan rules. Similar to tags and categories, if no household is selected, then all households are considered. I had to re-write the part of the recipes repo that does the ... | 2024-09-18T19:52:22Z | [Task] - Enable Cross-Household Recipes
### What is the problem this task addresses?
Currently logged-in users can only see their household's recipes (similar to how it was with groups). One of the main reasons for adding households was specifically to have a common pool of recipes.
### Proposed/Possible Solution(s)?... | [
{
"body": "### What is the problem this task addresses?\n\nCurrently logged-in users can only see their household's recipes (similar to how it was with groups). One of the main reasons for adding households was specifically to have a common pool of recipes.\n\n### Proposed/Possible Solution(s)?\n\nFeatures to a... | 38502e82d4d1eb07d6ac4f2b9fd5d7202954e11e | {
"head_commit": "301a7af07ff5a5184239862eef60ee01d0c5e11d",
"head_commit_message": "Merge branch 'mealie-next' into feat/add-household-filter-to-mealplan-rules",
"patch_to_review": "diff --git a/alembic/versions/2024-09-18-14.52.55_1fe4bd37ccc8_add_households_filter_to_meal_plans.py b/alembic/versions/2024-09-18... | [
{
"diff_hunk": "@@ -40,57 +41,77 @@ def mixins(self):\n self.registered_exceptions,\n )\n \n+ def _get_random_recipes_from_mealplan(\n+ self, plan_date: date, entry_type: PlanEntryType, limit: int = 1\n+ ) -> list[Recipe]:\n+ \"\"\"\n+ Gets rules for a mealplan and... | 4f195c05ef2fd5a8f3ace1288537c91576aff317 | diff --git a/alembic/versions/2024-09-18-14.52.55_1fe4bd37ccc8_add_households_filter_to_meal_plans.py b/alembic/versions/2024-09-18-14.52.55_1fe4bd37ccc8_add_households_filter_to_meal_plans.py
new file mode 100644
index 00000000000..a127e72f44a
--- /dev/null
+++ b/alembic/versions/2024-09-18-14.52.55_1fe4bd37ccc8_add_h... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
mealie-recipes__mealie-1848@34af353 | mealie-recipes/mealie | Python | 1,848 | Fix Issue#1317 | <!--
This template provides some ideas of things to include in your PR description.
To start, try providing a short summary of your changes in the Title above.
If a section of the PR template does not apply to this PR, then delete that section.
-->
## What type of PR is this?
<!--
Delete any of th... | 2022-11-22T20:53:24Z | [v1.0.0b] - You can delete your own admin account while logged in
### First Check
- [X] This is not a feature request
- [X] I added a very descriptive title to this issue.
- [X] I used the GitHub search to find a similar issue and didn't find it.
- [X] I searched the Mealie documentation, with the integrated search.
-... | > You should implement a prompt to confirm this request.
There is a confirmation for deleting a user
> You should disallow the account to be deleted unless there is at least another admin account.
I'm not going to implement this. This page isn't user facing and the implication of administering your own applica... | [
{
"body": "### First Check\n\n- [X] This is not a feature request\n- [X] I added a very descriptive title to this issue.\n- [X] I used the GitHub search to find a similar issue and didn't find it.\n- [X] I searched the Mealie documentation, with the integrated search.\n- [X] I already read the docs and didn't f... | 8ec60668e660516df8144b9b00ab43e35d7f71a1 | {
"head_commit": "34af353b2839099c290235da0650ba09f11de506",
"head_commit_message": "add the alert component on User Management",
"patch_to_review": "diff --git a/frontend/pages/admin/manage/users/index.vue b/frontend/pages/admin/manage/users/index.vue\nindex 28dbf21d874..42221ad8202 100644\n--- a/frontend/pages/... | [
{
"diff_hunk": "@@ -2,9 +2,21 @@\n <v-container fluid>\n <BaseDialog v-model=\"deleteDialog\" :title=\"$t('general.confirm')\" color=\"error\" @confirm=\"deleteUser(deleteTarget)\">\n <template #activator> </template>\n- <v-card-text>\n+\n+ <v-card-text\n+ v-if=\"isUserOwnAccount ==... | 847fe38075be265aa4c91ed03046271f044bc45f | diff --git a/frontend/lang/messages/en-US.json b/frontend/lang/messages/en-US.json
index fbe38eda112..c4998a213b0 100644
--- a/frontend/lang/messages/en-US.json
+++ b/frontend/lang/messages/en-US.json
@@ -151,6 +151,7 @@
"a-name-is-required": "A Name is Required",
"delete-with-name": "Delete {name}",
"co... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
mealie-recipes__mealie-4186@8eef143 | mealie-recipes/mealie | Python | 4,186 | feat: Allow Cookbooks To Share Names | ## What type of PR is this?
_(REQUIRED)_
- feature
## What this PR does / why we need it:
_(REQUIRED)_
This PR allows cookbooks to share the same name. We want this since cookbooks are per-household, and multiple households may want the same cookbook name (e.g. "Sides").
When multiple cookbooks share ... | 2024-09-09T20:56:06Z | [Task] - Allow Cookbooks to Share the Same Name
### What is the problem this task addresses?
Currently cookbooks will throw an error if there's another cookbook with the same name. Similar to recipes, we should allow this as long as the slug is different.
We want this since two different households might have the s... | [
{
"body": "### What is the problem this task addresses?\n\nCurrently cookbooks will throw an error if there's another cookbook with the same name. Similar to recipes, we should allow this as long as the slug is different.\r\n\r\nWe want this since two different households might have the same common cookbook nam... | abe45046403202779ac91abeb816aee963a81046 | {
"head_commit": "8eef14380f90c1f52c339104456fd3d63d5af607",
"head_commit_message": "fix duplicate key in sidebar",
"patch_to_review": "diff --git a/frontend/components/Layout/DefaultLayout.vue b/frontend/components/Layout/DefaultLayout.vue\nindex cc2aa5c00bc..062a70ed350 100644\n--- a/frontend/components/Layout/... | [
{
"diff_hunk": "@@ -0,0 +1,65 @@\n+from collections.abc import Iterable\n+\n+from fastapi import HTTPException, status\n+from pydantic import UUID4\n+from slugify import slugify\n+from sqlalchemy.exc import IntegrityError\n+\n+from mealie.db.models.household.cookbook import CookBook\n+from mealie.repos.reposito... | d6bbf71b28df9667ef8eba70cb93094d0871c0cf | diff --git a/frontend/components/Layout/DefaultLayout.vue b/frontend/components/Layout/DefaultLayout.vue
index cc2aa5c00bc..062a70ed350 100644
--- a/frontend/components/Layout/DefaultLayout.vue
+++ b/frontend/components/Layout/DefaultLayout.vue
@@ -117,6 +117,7 @@ export default defineComponent({
if (!cookbooks.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
mealie-recipes__mealie-4218@4736e66 | mealie-recipes/mealie | Python | 4,218 | fix: Exclude additional sensitive information from mealie logs | ## What type of PR is this?
_(REQUIRED)_
- bug
- cleanup
## What this PR does / why we need it:
_(REQUIRED)_
Add LDAP_QUERY_PASSWORD, OIDC_CLIENT_ID, and OPENAI_API_KEY to the list of excluded settings when logging.
## Which issue(s) this PR fixes:
_(REQUIRED)_
Fixes #4217
## Testing
Run Mealie ... | 2024-09-16T15:26:45Z | [BUG] - Mealie exposes sensitive information in log files
I noticed that Mealie excludes some of the sensitive informatin from the logs, but it does not exclude everything; mainly, it's missing LDAP_QUERY_PASSWORD, OIDC_CLIENT_ID, and OPENAI_API_KEY.
I will open a PR to _hopefully_ fix this issue, although this is m... | You should be able to just add those fields here:
https://github.com/mealie-recipes/mealie/blob/8778559a208d3cdd0332229f4fde6acd4c12f7d4/mealie/app.py#L60-L75
Also, please use the bug template next time: https://github.com/mealie-recipes/mealie/issues/new/choose | [
{
"body": "I noticed that Mealie excludes some of the sensitive informatin from the logs, but it does not exclude everything; mainly, it's missing LDAP_QUERY_PASSWORD, OIDC_CLIENT_ID, and OPENAI_API_KEY.\r\n\r\nI will open a PR to _hopefully_ fix this issue, although this is my first time contributing to Mealie... | abc11748775e159d44576969a1cb83c30b88ce4f | {
"head_commit": "4736e665e9e6f6d513ced82aaec995838113b306",
"head_commit_message": "Add additional values to exclude from logs",
"patch_to_review": "diff --git a/mealie/app.py b/mealie/app.py\nindex 069d0f7e316..05b6f2025e8 100644\n--- a/mealie/app.py\n+++ b/mealie/app.py\n@@ -63,6 +63,9 @@ async def lifespan_fn... | [
{
"diff_hunk": "@@ -63,6 +63,9 @@ async def lifespan_fn(_: FastAPI) -> AsyncGenerator[None, None]:\n settings.model_dump_json(\n indent=4,\n exclude={\n+ \"LDAP_QUERY_PASSWORD\",\n+ \"OIDC_CLIENT_ID\",",
"line": null,
"original_line": 67,
... | 9a2a7de8a434ba4537a78eb0a15efdfcb9858f15 | diff --git a/mealie/app.py b/mealie/app.py
index 069d0f7e316..df0d92dab81 100644
--- a/mealie/app.py
+++ b/mealie/app.py
@@ -63,6 +63,8 @@ async def lifespan_fn(_: FastAPI) -> AsyncGenerator[None, None]:
settings.model_dump_json(
indent=4,
exclude={
+ "LDAP_QUERY_PASSWO... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
mealie-recipes__mealie-1424@c9ab4dc | mealie-recipes/mealie | Python | 1,424 | feat: re-write get all routes to use pagination | Starting a draft since I'm expecting changes and a bunch of feedback. I haven't fully rolled out all the route changes yet, I've just started with shopping lists since I'm more familiar with those.
---
This feature aims to solve for task #1411: to implement the existing pagination logic in place of the ad-hoc get... | 2022-06-17T23:28:42Z | [v1.0.0b] [Task] - Rewrite Pagination For Endpoints
### What is the problem this task addresses?
Currently the `get_all` method for endpoints have different or someone non-traditional behavior. These should be consolidated to support a mix of query parameters and pagination for robust filtering and pagination so cli... | [
{
"body": "### What is the problem this task addresses?\r\n\r\nCurrently the `get_all` method for endpoints have different or someone non-traditional behavior. These should be consolidated to support a mix of query parameters and pagination for robust filtering and pagination so clients can take full advantage ... | c158672d12c4f4f950aa656ce5dcb45eeb1ba065 | {
"head_commit": "c9ab4dcbbf0377f5849d5dcc212de0a484357e57",
"head_commit_message": "modified frontend getAll routes to use paging",
"patch_to_review": "diff --git a/frontend/api/_base.ts b/frontend/api/_base.ts\nindex 3b3e40c81cc..7b251447210 100644\n--- a/frontend/api/_base.ts\n+++ b/frontend/api/_base.ts\n@@ -... | [
{
"diff_hunk": "@@ -240,11 +243,31 @@ def pagination(self, pagination: PaginationQuery, override=None) -> PaginationBa\n \n fltr = self._filter_builder()\n q = q.filter_by(**fltr)\n-\n count = q.count()\n \n+ # interpret -1 as \"get_all\"\n+ if pagination.per_page == -1:\n+... | 74acfdb7524544861cb9dfdc08ad2c81f812621e | diff --git a/.github/workflows/frontend-lint.yml b/.github/workflows/frontend-lint.yml
index 32e3370c71d..7cfe4ae844d 100644
--- a/.github/workflows/frontend-lint.yml
+++ b/.github/workflows/frontend-lint.yml
@@ -9,7 +9,7 @@ on:
- mealie-next
jobs:
- ci:
+ lint:
runs-on: ${{ matrix.os }}
strateg... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
mealie-recipes__mealie-4158@e17b361 | mealie-recipes/mealie | Python | 4,158 | feat: Additional Household Permissions | ## What type of PR is this?
_(REQUIRED)_
<!--
Delete any of the following that do not apply:
-->
- bug
- cleanup
- feature
## What this PR does / why we need it:
_(REQUIRED)_
This PR adds two household-related permissions:
- Household Preference: Lock Recipe Edits From Other Households
- User... | 2024-09-04T19:53:55Z | [Task] - Household Permissions
### What is the problem this task addresses?
Our current permissions model doesn't account for households at all. You're pretty much either a super admin (cross-group), an elevated user, or a regular user.
### Proposed/Possible Solution(s)?
Separate permissions into a few different buc... | [
{
"body": "### What is the problem this task addresses?\n\nOur current permissions model doesn't account for households at all. You're pretty much either a super admin (cross-group), an elevated user, or a regular user.\n\n### Proposed/Possible Solution(s)?\n\nSeparate permissions into a few different buckets:\... | b1820f9b233e52de7ab12ac1f4583a35a768b69b | {
"head_commit": "e17b361d9f31edca5e20508a2adf2d8e2fad5165",
"head_commit_message": "cleaned up migration script",
"patch_to_review": "diff --git a/alembic/versions/2024-09-02-21.39.49_be568e39ffdf_added_household_recipe_lock_setting_and_.py b/alembic/versions/2024-09-02-21.39.49_be568e39ffdf_added_household_reci... | [
{
"diff_hunk": "@@ -64,12 +64,14 @@\n <script lang=\"ts\">\n import { defineComponent, useContext, computed, ref, watch } from \"@nuxtjs/composition-api\";\n import { useLoggedInState } from \"~/composables/use-logged-in-state\";\n+import { useUserApi } from \"~/composables/api\";\n import { useRecipePermission... | 9fbfb8d80883c4fdfda4d966bf5fe7cd9e5d0fe3 | diff --git a/alembic/versions/2024-09-02-21.39.49_be568e39ffdf_added_household_recipe_lock_setting_and_.py b/alembic/versions/2024-09-02-21.39.49_be568e39ffdf_added_household_recipe_lock_setting_and_.py
new file mode 100644
index 00000000000..83f2e55186a
--- /dev/null
+++ b/alembic/versions/2024-09-02-21.39.49_be568e39... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
localstack__localstack-12496@22b4c31 | localstack/localstack | Python | 12,496 | StepFunctions: ListStateMachineAliases pagination support | <!-- Please refer to the contribution guidelines before raising a PR: https://github.com/localstack/localstack/blob/master/docs/CONTRIBUTING.md -->
<!-- Why am I raising this PR? Add context such as related issues, PRs, or documentation. -->
## Motivation
When using the awslocal CLI to list all state machine alias... | 2025-04-07T18:38:15Z | bug: StepFunctions: ListStateMachineAliases action does not support pagination
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current Behavior
When using the awslocal CLI to list all state machine aliases, pagination is currently not supported. The --next-token and --max-resul... | Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our [Slack Community](https://localstack.cloud/contact/) for real-time help and drop a message to LocalStack Pro Support if you ar... | [
{
"body": "### Is there an existing issue for this?\n\n- [x] I have searched the existing issues\n\n### Current Behavior\n\nWhen using the awslocal CLI to list all state machine aliases, pagination is currently not supported. The --next-token and --max-results flags have no effect on the query and will alway re... | 72ed3cd9374533911543ba62f5d74ef8bd351398 | {
"head_commit": "22b4c31f03714f790d0c930155b9e9216c26fa6d",
"head_commit_message": "add one test",
"patch_to_review": "diff --git a/localstack-core/localstack/services/stepfunctions/backend/alias.py b/localstack-core/localstack/services/stepfunctions/backend/alias.py\nindex f6c4995bc7df8..8ad8fbddd056f 100644\n-... | [
{
"diff_hunk": "@@ -67,3 +67,9 @@ def assert_pagination_parameters_valid(\n errors_message = \"; \".join(validation_errors)\n message = f\"{len(validation_errors)} validation {'errors' if len(validation_errors) > 1 else 'error'} detected: {errors_message}\"\n raise ValidationException(me... | 9c4460fff4bf896c414500c5369ba861e5ae8389 | diff --git a/localstack-core/localstack/services/sqs/provider.py b/localstack-core/localstack/services/sqs/provider.py
index efb857dbbf573..10988383bd745 100644
--- a/localstack-core/localstack/services/sqs/provider.py
+++ b/localstack-core/localstack/services/sqs/provider.py
@@ -102,7 +102,6 @@
is_fifo_queue,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mealie-recipes__mealie-969@c2e86ae | mealie-recipes/mealie | Python | 969 | feature: proper multi-tenant-support | Isolate the following tables to be filtered by group_id (possibly more)
## Accidentally committed to `mealie-next`
- [x] Foods
- [x] Units
## In this PR
- [x] Categories - General
- [x] Tags - General
- [x] Tools - General
- [x] rewrite category/tag relation logic to be less cumbersome.
- [x] ensure all i... | 2022-02-08T23:56:59Z | [v1.0.0b] [Task] - Proper Multi-Tenant Support
### What is the problem this task addresses?
Currently several items are shared across groups. All items should be group independent and NOT shared.
### Proposed/Possible Solution(s)?
Isolate the following tables to be filtered by group_id (possibly more)
- [x]... | [
{
"body": "### What is the problem this task addresses?\r\n\r\nCurrently several items are shared across groups. All items should be group independent and NOT shared.\r\n\r\n### Proposed/Possible Solution(s)?\r\n\r\nIsolate the following tables to be filtered by group_id (possibly more)\r\n\r\n- [x] Foods\r\n- ... | 9a82a172cbe632bf0a2aba82c7d8b5bb38764be7 | {
"head_commit": "c2e86ae98dad6c24487e81fedf1753c32a12ee1f",
"head_commit_message": "initial refactor for multitenant tags/cats",
"patch_to_review": "diff --git a/mealie/db/models/group/group.py b/mealie/db/models/group/group.py\nindex d2fc83975ad..2cf9669933f 100644\n--- a/mealie/db/models/group/group.py\n+++ b/... | [
{
"diff_hunk": "@@ -0,0 +1,20 @@\n+from abc import ABC, abstractmethod\n+\n+from fastapi import Response\n+from fastapi.testclient import TestClient\n+\n+from mealie.repos.repository_factory import AllRepositories\n+\n+\n+class ABCMultiTenanatTestCase(ABC):",
"line": null,
"original_line": 9,
"origi... | 292181502b0a045f72d8a41ec702840f20155d18 | diff --git a/docs/docs/changelog/v1.0.0.md b/docs/docs/changelog/v1.0.0.md
index 8e6a8f952e8..3b755f64760 100644
--- a/docs/docs/changelog/v1.0.0.md
+++ b/docs/docs/changelog/v1.0.0.md
@@ -14,6 +14,7 @@
- User/Group settings are now completely separated from the Administration page.
- All settings and configurations ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
mealie-recipes__mealie-57@9c1d0d9 | mealie-recipes/mealie | Python | 57 | Changed uvicorn port to 80 | Closes #55 | 2021-01-09T21:19:24Z | Dockerfile exposes port 80, but runs on port 9000
The Dockerfile exposes port 80 (Inherited from tiangolo/uvicorn-gunicorn-fastapi which in turn inherits it from tiangolo/uvicorn-gunicorn), but the cmd in the dockerfile runs uvicorn on port 9000. I don't think there's any problem in running on port 80 in docker, since ... | [
{
"body": "The Dockerfile exposes port 80 (Inherited from tiangolo/uvicorn-gunicorn-fastapi which in turn inherits it from tiangolo/uvicorn-gunicorn), but the cmd in the dockerfile runs uvicorn on port 9000. I don't think there's any problem in running on port 80 in docker, since nothing else will run on the co... | 4b0e9c0d761937e1b2278a3e42b21604b481d8ec | {
"head_commit": "9c1d0d9ec95462a553e8763011ba12c8dc3b48fc",
"head_commit_message": "Changed port in docker-compose to match dockerfile",
"patch_to_review": "diff --git a/Dockerfile b/Dockerfile\nindex c79a16c3a8b..b19242d2e78 100644\n--- a/Dockerfile\n+++ b/Dockerfile\n@@ -21,4 +21,4 @@ COPY ./mealie /app\n COPY... | [
{
"diff_hunk": "@@ -9,13 +9,7 @@ services:\n container_name: mealie\n restart: always\n ports:\n- - 9090:9000\n- environment:\n- db_username: root\n- db_password: example\n- db_host: mongo\n- db_port: 27017\n- volumes:\n+ - 9090:80\n - ./mealie/data/img:/app... | fe69114b0b5e9c74897ec4b375b86496e5d422e8 | diff --git a/Dockerfile b/Dockerfile
index 4a803d0268b..3edd658ef89 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -26,4 +26,4 @@ ENV ENV prod
VOLUME [ "/app/data" ]
-CMD ["uvicorn", "app:app", "--host", "0.0.0.0", "--port", "9000"]
\ No newline at end of file
+CMD ["uvicorn", "app:app", "--host", "0.0.0.0", "--port"... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} | |
localstack__localstack-12459@c588669 | localstack/localstack | Python | 12,459 | Fix subnet tags going missing | <!-- Please refer to the contribution guidelines before raising a PR: https://github.com/localstack/localstack/blob/master/docs/CONTRIBUTING.md -->
<!-- Why am I raising this PR? Add context such as related issues, PRs, or documentation. -->
## Motivation
#11853 introduced a regression whereby the structure of the... | 2025-03-31T14:55:11Z | LocalStack does not detect subnet tags with Terraform
### Description:
**Problem Description:**
I am using **LocalStack** version `4.2` to perform AWS infrastructure testing with **Terraform**. However, when creating subnets in LocalStack, the **tags** are not correctly applied to the subnets, even though the tags a... | Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our [Slack Community](https://localstack.cloud/contact/) for real-time help and drop a message to LocalStack Pro Support if you ar... | [
{
"body": "### Description:\n\n**Problem Description:** \nI am using **LocalStack** version `4.2` to perform AWS infrastructure testing with **Terraform**. However, when creating subnets in LocalStack, the **tags** are not correctly applied to the subnets, even though the tags are properly defined in Terraform... | c6340e2b9e4526a961af3be22c4090a999b9a0ec | {
"head_commit": "c588669d2cc4830f39bf9b9b1eccacf58177600c",
"head_commit_message": "Remove unused import found by lint checker",
"patch_to_review": "diff --git a/localstack-core/localstack/services/ec2/patches.py b/localstack-core/localstack/services/ec2/patches.py\nindex d9db4cad11e08..6c523d1125d90 100644\n---... | [
{
"diff_hunk": "@@ -78,15 +78,22 @@ def ec2_create_subnet(\n tags: Optional[dict[str, str]] = None,\n **kwargs,\n ):\n+ # Patch this method so that we can create a subnet with a specific \"custom\"\n+ # ID. The custom ID that we will use is contained within a special tag.\n ... | 78aa52efd9d9139f03568971e8b3e4b4aa2f62dc | diff --git a/localstack-core/localstack/services/ec2/patches.py b/localstack-core/localstack/services/ec2/patches.py
index d9db4cad11e08..d26d94a3df83b 100644
--- a/localstack-core/localstack/services/ec2/patches.py
+++ b/localstack-core/localstack/services/ec2/patches.py
@@ -78,15 +78,22 @@ def ec2_create_subnet(
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-12286@edd40cd | localstack/localstack | Python | 12,286 | ElasticSearch: Fix missing JRE in 5.x and 6.x | ## Background
In https://github.com/localstack/localstack/pull/11462, we changed the ElasticSearch/OpenSearch installers to use the [bundled JRE](https://www.elastic.co/guide/en/elasticsearch/reference/current/install-elasticsearch.html#jvm-version). However, based on https://github.com/localstack/localstack/issues/... | 2025-02-19T11:04:02Z | bug: Elastic Search 6.8 - JAVA_HOME doesn't exist
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current Behavior
When creating a new elastic search 6.8 domain within the localstack container like so:
```
awslocal es create-elasticsearch-domain --domain-name my-domain-name --... | Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our [Slack Community](https://localstack.cloud/contact/) for real-time help and drop a message to LocalStack Pro Support if you ar... | [
{
"body": "### Is there an existing issue for this?\n\n- [x] I have searched the existing issues\n\n### Current Behavior\n\nWhen creating a new elastic search 6.8 domain within the localstack container like so:\n\n```\nawslocal es create-elasticsearch-domain --domain-name my-domain-name --elasticsearch-version ... | f269fe2dba8a30c3fe6c30afbbd61f7a63029aed | {
"head_commit": "edd40cdaa683a065fa47765e86d7b13cdf46363d",
"head_commit_message": "Fix critical startup config for older versions",
"patch_to_review": "diff --git a/localstack-core/localstack/services/opensearch/cluster.py b/localstack-core/localstack/services/opensearch/cluster.py\nindex 65ef2dd9c4ed5..c8a1fec... | [
{
"diff_hunk": "@@ -233,6 +236,12 @@ class ElasticsearchPackageInstaller(PackageInstaller):\n def __init__(self, version: str):\n super().__init__(\"elasticsearch\", version)\n \n+ def get_java_env_vars(self, target: InstallTarget) -> dict[str, str]:\n+ install_dir = self._get_install_dir(... | 9cdaea9351816905fcb4606320602f45f73792d0 | diff --git a/localstack-core/localstack/services/opensearch/cluster.py b/localstack-core/localstack/services/opensearch/cluster.py
index 65ef2dd9c4ed5..cae1916c90b09 100644
--- a/localstack-core/localstack/services/opensearch/cluster.py
+++ b/localstack-core/localstack/services/opensearch/cluster.py
@@ -675,14 +675,25 ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-11827@b541ef1 | localstack/localstack | Python | 11,827 | ExpectedBucketOwner for S3 bucket policy operations | <!-- Please refer to the contribution guidelines before raising a PR: https://github.com/localstack/localstack/blob/master/docs/CONTRIBUTING.md -->
<!-- Why am I raising this PR? Add context such as related issues, PRs, or documentation. -->
## Motivation
Closes #11826
<!-- What changes does this PR make? How... | 2024-11-11T08:03:57Z | feature request: S3 ExpectedBucketOwner for bucket policy operations
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Feature description
Implement ExpectedBucketOwner parameter and its behavior in 3 S3 operations:
- PutBucketPolicy
- GetBucketPolicy
- DeleteBucketPolicy
#... | Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our [Slack Community](https://localstack.cloud/contact/) for real-time help and drop a message to LocalStack Pro Support if you ar... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Feature description\n\nImplement ExpectedBucketOwner parameter and its behavior in 3 S3 operations: \r\n- PutBucketPolicy\r\n- GetBucketPolicy \r\n- DeleteBucketPolicy\n\n### 🧑💻 Implementation\n\n_No respo... | 59d47941d8fa29ce166fcfff228b77cdbc1aacde | {
"head_commit": "b541ef13c90961f3c80de1210299abc892da1959",
"head_commit_message": "Raise InvalidBucketOwnerAWSAccountID if needed",
"patch_to_review": "diff --git a/localstack-core/localstack/aws/api/s3/__init__.py b/localstack-core/localstack/aws/api/s3/__init__.py\nindex 3a7cdafe351b4..fe68fb7ff8cf9 100644\n-... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "tests/aws/services/s3/test_s3.snapshot.json",
"start_line": null,
"text": "@user1:\nnit: I think as `test_put_and_get_bucket_policy` was renamed/deleted, its snapshot is still living in this fil... | 61cea5e8a26b2d8365c7b558c42d47b2a5f63654 | diff --git a/localstack-core/localstack/services/s3/exceptions.py b/localstack-core/localstack/services/s3/exceptions.py
index e87356e24e3f6..4e00d8dce33a2 100644
--- a/localstack-core/localstack/services/s3/exceptions.py
+++ b/localstack-core/localstack/services/s3/exceptions.py
@@ -41,3 +41,8 @@ def __init__(self, me... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
localstack__localstack-11632@239ccee | localstack/localstack | Python | 11,632 | Fix: CFn repeated deployments breaking | <!-- Please refer to the contribution guidelines before raising a PR: https://github.com/localstack/localstack/blob/master/docs/CONTRIBUTING.md -->
<!-- Why am I raising this PR? Add context such as related issues, PRs, or documentation. -->
## Motivation
As reported in https://github.com/localstack/localstack/issues... | 2024-10-03T15:50:27Z | bug: repeated CDK deploy fails with InvalidChangeSetStatus
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
When
I run the following commands:
* `cdklocal bootstrap`
* `cdklocal deploy --require-approval never`
* `cdklocal destroy -f`
* `cdklocal
* deplo... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\nWhen \r\nI run the following commands:\r\n* `cdklocal bootstrap`\r\n* `cdklocal deploy --require-approval never`\r\n* `cdklocal destroy -f`\r\n* `cdklocal\r\n* deploy --require-approval n... | 5d2c09020fff4391ac27991d5f95351abca09c39 | {
"head_commit": "239ccee001a16a0bd81eddcb14312090c7f2fc8d",
"head_commit_message": "Add skipped failling test",
"patch_to_review": "diff --git a/localstack-core/localstack/services/cloudformation/provider.py b/localstack-core/localstack/services/cloudformation/provider.py\nindex c7dcfcb0889db..b10617ed92ef5 1006... | [
{
"diff_hunk": "@@ -103,10 +103,16 @@ def find_active_stack_by_name_or_id(\n \n \n def find_change_set(\n- account_id: str, region_name: str, cs_name: str, stack_name: Optional[str] = None\n+ account_id: str,\n+ region_name: str,\n+ cs_name: str,\n+ stack_name: Optional[str] = None,\n+ active_... | 7322e95c505ef114347877972f5143f0d8ea9f8b | diff --git a/localstack-core/localstack/services/cloudformation/provider.py b/localstack-core/localstack/services/cloudformation/provider.py
index c7dcfcb0889db..b10617ed92ef5 100644
--- a/localstack-core/localstack/services/cloudformation/provider.py
+++ b/localstack-core/localstack/services/cloudformation/provider.py... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
localstack__localstack-11133@b1be7b6 | localstack/localstack | Python | 11,133 | fix CBOR timestamp parsing | ## Motivation
Kinesis supports _CBOR_ (Concise Binary Object Representation) encoding as `Content-Type` in addition to JSON.
CBOR support was added for LocalStack with #6494 by extending our ASF parsers and serializers, and patching CBOR support into `botocore` (when being used as a proxy to `kinesis-mock`).
Unfortu... | 2024-07-03T13:04:07Z | HTTP body could not be parsed as CBOR
When using apache flink and running the code locally, below error happened in the localstack from docker console -
localstack.aws.protocol.parser.ProtocolParserError: HTTP body could not be parsed as CBOR.
localstack-main | 2023-11-21T05:35:06.808 INFO --- [ asgi_gw_2] lo... | Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our [Slack Community](https://localstack.cloud/contact/) for real-time help and drop a message to LocalStack Pro Support if you ar... | [
{
"body": "When using apache flink and running the code locally, below error happened in the localstack from docker console - \r\n\r\nlocalstack.aws.protocol.parser.ProtocolParserError: HTTP body could not be parsed as CBOR.\r\nlocalstack-main | 2023-11-21T05:35:06.808 INFO --- [ asgi_gw_2] localstack.requ... | a4095638a6c92a70e15aebb07b9520e8907c3e50 | {
"head_commit": "b1be7b622709c4e115c66a6613005f8dfd84c6d2",
"head_commit_message": "fix CBOR timestamp parsing",
"patch_to_review": "diff --git a/localstack-core/localstack/aws/client.py b/localstack-core/localstack/aws/client.py\nindex dfe475147188c..54f15968419f3 100644\n--- a/localstack-core/localstack/aws/cl... | [
{
"diff_hunk": "@@ -567,6 +578,77 @@ def test_get_records_shard_iterator_with_surrounding_quotes(\n \n assert aws_client.kinesis.get_records(ShardIterator=f'\"{shard_iterator}\"')[\"Records\"]\n \n+ @markers.aws.validated\n+ def test_subscribe_to_shard_with_at_timestamp_cbor(\n+ self,\n+ ... | 2880f8fc789dbe0d4d334e15c3a54387eb21c2b2 | diff --git a/localstack-core/localstack/aws/client.py b/localstack-core/localstack/aws/client.py
index dfe475147188c..54f15968419f3 100644
--- a/localstack-core/localstack/aws/client.py
+++ b/localstack-core/localstack/aws/client.py
@@ -2,7 +2,7 @@
import io
import logging
-from datetime import datetime
+from datet... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-10041@68f3277 | localstack/localstack | Python | 10,041 | feat: DynamoDB TTL | <!-- Please refer to the contribution guidelines before raising a PR: https://github.com/localstack/localstack/blob/master/CONTRIBUTING.md -->
<!-- Why am I raising this PR? Add context such as related issues, PRs, or documentation. -->
## Motivation
This PR implements the Time to Live feature in DynamoDB, as repo... | 2024-01-10T13:49:41Z | DynamoDB TTL not implemented
I'm trying to use the recent time-to-live feature in DynamoDB, but I get a `An unknown operation was requested` exception. My guess is that the feature is not yet implemented in Localstack. Are there any plans for including it? | Thanks for reporting @justinian336 , this would indeed be a useful feature. Would you be able to work on a pull request? I'd be happy to provide the general direction, and help out where needed. Thanks
Sure, I'd be glad to help. I'll study your code and make a PR when I'm ready. Do you have any guidelines for contribut... | [
{
"body": "I'm trying to use the recent time-to-live feature in DynamoDB, but I get a `An unknown operation was requested` exception. My guess is that the feature is not yet implemented in Localstack. Are there any plans for including it?",
"number": 236,
"title": "DynamoDB TTL not implemented"
}
] | 4407db9bc9373103950f8c364669e95b26ccecdd | {
"head_commit": "68f32774c3bf248c672578e281c002c352da51a2",
"head_commit_message": "consider max batch size",
"patch_to_review": "diff --git a/localstack/services/dynamodb/models.py b/localstack/services/dynamodb/models.py\nindex e128540690891..ec9e1cc433a1b 100644\n--- a/localstack/services/dynamodb/models.py\n... | [
{
"diff_hunk": "@@ -356,15 +359,123 @@ def modify_context_region(context: RequestContext, region: str):\n context.request.headers[\"Authorization\"] = original_authorization\n \n \n+class DynamoDBDeveloperEndpoints:\n+ \"\"\"\n+ Developer endpoints for DynamoDB\n+ DELETE /_aws/dynamodb/expired ... | e65c6e0073a1e07df28647fd2395f00c4583519f | diff --git a/localstack/config.py b/localstack/config.py
index 3cc1baf6aa11f..e32c362eaa674 100644
--- a/localstack/config.py
+++ b/localstack/config.py
@@ -816,6 +816,9 @@ def populate_edge_configuration(
# the port on which to expose dynamodblocal
DYNAMODB_LOCAL_PORT = int(os.environ.get("DYNAMODB_LOCAL_PORT") or 0... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
localstack__localstack-9856@d19cbcc | localstack/localstack | Python | 9,856 | fix s3 key handling with trailing slash | <!-- Please refer to the contribution guidelines before raising a PR: https://github.com/localstack/localstack/blob/master/CONTRIBUTING.md -->
<!-- Why am I raising this PR? Add context such as related issues, PRs, or documentation. -->
## Motivation
This would fix #9837. We've had multiple iterations of this, we ... | 2023-12-12T12:57:55Z | bug: S3 listObjects and folder names containing a space
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
When folder names contain a space then `listObjects` returns names without `/` at the end. Without space it works fine.
### Expected Behavior
Folders conta... | Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our [Slack Community](https://localstack.cloud/contact/) for real-time help and drop a message to LocalStack Pro Support if you ar... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\nWhen folder names contain a space then `listObjects` returns names without `/` at the end. Without space it works fine.\n\n### Expected Behavior\n\nFolders containing space in the name are... | d68c9def509f0d948bf394d0f37cd1ce5c11a233 | {
"head_commit": "d19cbcc6843988df19f11368b8e40b187a713352",
"head_commit_message": "update comment",
"patch_to_review": "diff --git a/localstack/aws/protocol/parser.py b/localstack/aws/protocol/parser.py\nindex c0237d81193c1..eda8b144932cf 100644\n--- a/localstack/aws/protocol/parser.py\n+++ b/localstack/aws/pro... | [
{
"diff_hunk": "@@ -1063,17 +1062,21 @@ def _parse_shape(\n Special handling of parsing the shape for s3 object-names (=key):\n trailing '/' are valid and need to be preserved, however, the url-matcher removes it from the key\n we check the request.url to verify the name.\n- We de... | 1b266de13e766c3b094f97423edc1d8e484b6c0b | diff --git a/localstack/aws/protocol/parser.py b/localstack/aws/protocol/parser.py
index c0237d81193c1..82f0dfb589ddf 100644
--- a/localstack/aws/protocol/parser.py
+++ b/localstack/aws/protocol/parser.py
@@ -69,7 +69,6 @@
from abc import ABC
from email.utils import parsedate_to_datetime
from typing import IO, Any, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
kivy__kivy-4921@08ab46d | kivy/kivy | Python | 4,921 | Added an allow_screensaver property for Window | Currently SDL2 automatically disables the screensaver, but has functions for enabling or disabling manually. Kivy doesn't do anything other than the default, so this affects all Kivy apps. It isn't very noticeable on the desktop, but probably isn't desirable as a default, and on mobile devices it prevents them from sle... | 2017-01-14T23:28:45Z | device doesnt go on sleep mode
Hello I have successfully compiled and installed my kivy app on android 6 device , but the device doesnt go on sleep mode even though I havent enabled wake lock
I am using the master branch of kivy , python for android and buildozer. Thank you | Are you sure you haven't enabled it in `Developer settings` or in a similar OS settings? Don't you have it connected via USB or something? The basic app isn't able to make Android stay awake.
the same happens even without usb attached , besides I havent enabled 'Stay Awake' mode in developers settings (Off)
Can you pr... | [
{
"body": "Hello I have successfully compiled and installed my kivy app on android 6 device , but the device doesnt go on sleep mode even though I havent enabled wake lock\r\n\r\nI am using the master branch of kivy , python for android and buildozer. Thank you",
"number": 969,
"title": "device doesnt ... | daf6407e880aa46480b1e58854e8cedba63ffbbe | {
"head_commit": "08ab46ddd42580c56974de2be275fdbba06ef8e6",
"head_commit_message": "Added allow_screensaver property for Window",
"patch_to_review": "diff --git a/kivy/config.py b/kivy/config.py\nindex 0e916a382a..4f3e841cfc 100644\n--- a/kivy/config.py\n+++ b/kivy/config.py\n@@ -318,7 +318,7 @@\n _is_rpi = exis... | [
{
"diff_hunk": "@@ -195,6 +197,10 @@ def _set_minimum_size(self, *args):\n 'Both Window.minimum_width and Window.minimum_height must be '\n 'bigger than 0 for the size restriction to take effect.')\n \n+ def _set_allow_screensaver(self, *args):\n+ allow_screensaver = se... | 49ccdbab597b4c965086d5ab0dddefba26541e90 | diff --git a/kivy/config.py b/kivy/config.py
index 0e916a382a..ba3f2f9844 100644
--- a/kivy/config.py
+++ b/kivy/config.py
@@ -197,6 +197,9 @@
'data/fonts/Roboto-Bold.ttf', 'data/fonts/Roboto-BoldItalic.ttf']
Default font used for widgets displaying any text.
+ `allow_screensaver`: int, one of 0 or 1... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-9749@e7d1fa1 | localstack/localstack | Python | 9,749 | [SFN] Enhancements for Intrinsic Function StringSplit | <!-- Please refer to the contribution guidelines before raising a PR: https://github.com/localstack/localstack/blob/master/CONTRIBUTING.md -->
<!-- Why am I raising this PR? Add context such as related issues, PRs, or documentation. -->
## Motivation
For the current implementation of the SFN interpreter, the Intri... | 2023-11-28T09:27:08Z | bug: SFN - `States.StringSplit` errors when the same value in AWS succeeds
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
When using the `States.StringSplit` intrinsic function for AWS Step Functions, I get the following error:
```
│ Error: creating Step F... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\nWhen using the `States.StringSplit` intrinsic function for AWS Step Functions, I get the following error:\r\n\r\n```\r\n│ Error: creating Step Functions State Machine (repro): InvalidDefin... | 731873d7256d5ca6e76d1a79cb9e07a3a76385a9 | {
"head_commit": "e7d1fa1f2f84873a2857dab30a9bcb373c3e7daf",
"head_commit_message": "minor test refactoring",
"patch_to_review": "diff --git a/localstack/services/stepfunctions/asl/component/intrinsic/function/statesfunction/string_operations/string_split.py b/localstack/services/stepfunctions/asl/component/intri... | [
{
"diff_hunk": "@@ -67,4 +67,5 @@ def _eval_body(self, env: Environment) -> None:\n pattern = \"|\".join(patterns)\n \n parts = re.split(pattern, string)\n- env.stack.append(parts)\n+ parts_clean = list(filter(lambda sub: bool(sub), parts))",
"line": null,
"original_line": ... | 532effe81c5b60f2daf15f374e27470e5161766b | diff --git a/localstack/services/stepfunctions/asl/component/intrinsic/function/statesfunction/string_operations/string_split.py b/localstack/services/stepfunctions/asl/component/intrinsic/function/statesfunction/string_operations/string_split.py
index 961bae889a6fe..9be2ce9afafde 100644
--- a/localstack/services/stepf... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
localstack__localstack-9891@1bd5eb3 | localstack/localstack | Python | 9,891 | [SFN] Enhanced Support for Exception Handling in Parallel States | <!-- Please refer to the contribution guidelines before raising a PR: https://github.com/localstack/localstack/blob/master/CONTRIBUTING.md -->
<!-- Why am I raising this PR? Add context such as related issues, PRs, or documentation. -->
## Motivation
The SFN v2 interpreter is currently unable to propagate Parallel... | 2023-12-16T21:17:36Z | bug: Step Functions error not propagated outside of Parallel state
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
I'm executing a state machine using the following definition:
```json
{
"StartAt": "Parallel",
"States": {
"Parallel": {
... | [
{
"body": "### Is there an existing issue for this?\r\n\r\n- [X] I have searched the existing issues\r\n\r\n### Current Behavior\r\n\r\nI'm executing a state machine using the following definition:\r\n\r\n```json\r\n{\r\n \"StartAt\": \"Parallel\",\r\n \"States\": {\r\n \"Parallel\": {\r\n \"Type\": \... | ce5fe90919f92d60a141793afa8de7d14f418d58 | {
"head_commit": "1bd5eb38271e5c50425171d2ea6a542d99ff6cc2",
"head_commit_message": "Merge branch 'master' into MEP-sfn-9863",
"patch_to_review": "diff --git a/localstack/services/stepfunctions/asl/component/state/state_execution/state_parallel/branch_worker.py b/localstack/services/stepfunctions/asl/component/st... | [
{
"diff_hunk": "@@ -1,41 +1,116 @@\n-from typing import Final\n+import copy\n+import datetime\n+import threading\n+from typing import Final, Optional\n \n+from localstack.aws.api.stepfunctions import ExecutionFailedEventDetails, HistoryEventType\n+from localstack.services.stepfunctions.asl.component.common.erro... | 801487306b4fc2514a2896ad20d77d12d5c45ee3 | diff --git a/localstack/services/stepfunctions/asl/component/state/state_execution/state_parallel/branch_worker.py b/localstack/services/stepfunctions/asl/component/state/state_execution/state_parallel/branch_worker.py
new file mode 100644
index 0000000000000..2512aac30e579
--- /dev/null
+++ b/localstack/services/stepf... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
kivy__kivy-7110@56c4447 | kivy/kivy | Python | 7,110 | Makefile: Detect python verion and gracefully fail on unsupported version | fixes https://github.com/kivy/kivy/issues/7109 | 2020-09-27T10:28:23Z | Add a check for python version in `make` and gracefully exit rather than fail on python version 2.
**Software Versions**
* Python:
* OS: OSX 10.15.6
* Kivy: master 27 sept 2020
* Kivy installation method: clone master and `make`
**Describe the bug**
Make fails with `python` referring to python2 does not fail gr... | maybe something like
```python
PYTHON_MINIMUM_VERSION = (3, 6, 0)
if sys.version_info < PYTHON_MINIMUM_VERSION:
logger.error("Kivy requires at least Python%d.%d.%d", *PYTHON_MININUM_VERSION)
``` | [
{
"body": "**Software Versions**\r\n* Python:\r\n* OS: OSX 10.15.6\r\n* Kivy: master 27 sept 2020\r\n* Kivy installation method: clone master and `make`\r\n\r\n**Describe the bug**\r\nMake fails with `python` referring to python2 does not fail gracefully\r\n\r\n**Expected behavior**\r\n```\r\n kivy % make \r\np... | 0b7d32702714c4792e5373171423357ffd22d054 | {
"head_commit": "56c4447ffb0c5b20ecec3c4b15c49fd6cd0c5643",
"head_commit_message": "Detect python verion and gracefully fail on unsupported ver.",
"patch_to_review": "diff --git a/Makefile b/Makefile\nindex 0c6ce1c5b8..c0fcfcb939 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1,4 +1,16 @@\n+ifeq (, $(shell which py... | [
{
"diff_hunk": "@@ -1,4 +1,16 @@\n+ifeq (, $(shell which python ))\n+ $(error \"PYTHON=$(PYTHON) not found in $(PATH)\")\n+endif\n+\n PYTHON = python\n+PYTHON_VERSION_MIN=3.6",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "Makefile",
"start_line": null,
"text":... | 20a0641b7666b2078f6e2adfbd715e164e13e671 | diff --git a/Makefile b/Makefile
index 0c6ce1c5b8..bb7f29e050 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,16 @@
+ifeq (, $(shell which python ))
+ $(error "PYTHON=$(PYTHON) not found in $(PATH)")
+endif
+
PYTHON = python
+PYTHON_VERSION_MIN=3.0
+PYTHON_VERSION=$(shell $(PYTHON) -c 'import sys; print("%d.%d"% sys.... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
kivy__kivy-6897@e99c29b | kivy/kivy | Python | 6,897 | RecycleView: Add behavior to set RV data using kv ids | Adds the `RecycleKVIDsDataViewBehavior` class. Fixes #6878.
It's similar to the existing `RecycleDataViewBehavior` class, except that the data can signify properties of objects named with an id in KV. E.g. given a KV rule::
```
<MyRule@RecycleKVIDsDataViewBehavior+BoxLayout>:
Label:
id: name
L... | 2020-05-26T02:23:04Z | Allow using kv ids in RecycleView data keys
**Software Versions**
* Python: 3.6.9
* OS: Ubuntu 18.04.4 LTS
* Kivy: 1.11.0
* Kivy installation method: PIP
**Describe the bug**
The official information regarding recycleview shows the following:
```yaml
<RV>:
viewclass: 'Label' ### Here
RecycleBoxLay... | that's interesting, my way of achieving this is to map the properties of the internal widgets to properties on the root widget, and populate them there.
```yaml
<ThisInfo@BoxLayout>:
name_text: ""
salary_text: ""
position_text: ""
BoxLayout:
size_hint_x: 1.3
orientation: 'verti... | [
{
"body": "**Software Versions**\r\n* Python: 3.6.9 \r\n* OS: Ubuntu 18.04.4 LTS\r\n* Kivy: 1.11.0\r\n* Kivy installation method: PIP\r\n\r\n**Describe the bug**\r\nThe official information regarding recycleview shows the following: \r\n```yaml\r\n<RV>:\r\n viewclass: 'Label' ### Here\r\n RecycleBoxLayout... | 1d16c821f01e45795a0f3d33cc4754ab47cd950c | {
"head_commit": "e99c29b578d476a350b6af4b8efc99d5da7c2653",
"head_commit_message": "Add back root data key to example.",
"patch_to_review": "diff --git a/examples/widgets/recycleview/basic_data.py b/examples/widgets/recycleview/basic_data.py\nindex 94071252d4..41bd281591 100644\n--- a/examples/widgets/recyclevie... | [
{
"diff_hunk": "@@ -108,6 +111,34 @@ def apply_selection(self, rv, index, is_selected):\n pass\n \n \n+class RecycleKVIDsDataViewBehavior(RecycleDataViewBehavior):\n+ \"\"\"Similar to :class:`RecycleDataViewBehavior`, except that the data keys\n+ can signify properties of objects named with an id ... | 2c021f87b1b2a39b791550a1e2687032060004dc | diff --git a/examples/widgets/recycleview/basic_data.py b/examples/widgets/recycleview/basic_data.py
index 94071252d4..41bd281591 100644
--- a/examples/widgets/recycleview/basic_data.py
+++ b/examples/widgets/recycleview/basic_data.py
@@ -1,4 +1,4 @@
-from random import sample
+from random import sample, randint
from ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-10130@3a8c327 | localstack/localstack | Python | 10,130 | [SFN]: Support for CausePath and ErrorPath | <!-- Please refer to the contribution guidelines before raising a PR: https://github.com/localstack/localstack/blob/master/CONTRIBUTING.md -->
<!-- Why am I raising this PR? Add context such as related issues, PRs, or documentation. -->
## Motivation
On September 7, 2023, AWS extended the language support for Step... | 2024-01-26T19:08:37Z | bug: StepFunctions: Doesnt support ErrorPath
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
When i try to deploy a Step functions workflow on local stack with AWS CDK, i get the following error
```
The stack named StackNamefailed to deploy: CREATE_FAILED (An... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\nWhen i try to deploy a Step functions workflow on local stack with AWS CDK, i get the following error\r\n```\r\nThe stack named StackNamefailed to deploy: CREATE_FAILED (An error occurred ... | d808535fe5c5071e688a1c8370482adb4575ad80 | {
"head_commit": "3a8c327065824f51bc1d819df14efd77da40e57b",
"head_commit_message": "support for errorpath and causepath",
"patch_to_review": "diff --git a/localstack/services/stepfunctions/asl/antlr/ASLLexer.g4 b/localstack/services/stepfunctions/asl/antlr/ASLLexer.g4\nindex 9a5bd2e90dd8e..dfb0bb6a99582 100644\n... | [
{
"diff_hunk": "@@ -0,0 +1,51 @@\n+from typing import Final\n+\n+from localstack.services.stepfunctions.asl.component.intrinsic.function.function import Function\n+from localstack.services.stepfunctions.asl.component.intrinsic.functionname.state_fuinction_name_types import (\n+ StatesFunctionNameType,\n+)\n+... | 7ad0afafa57f2e83a49cabf898050ce826b1a087 | diff --git a/localstack/services/stepfunctions/asl/antlr/ASLLexer.g4 b/localstack/services/stepfunctions/asl/antlr/ASLLexer.g4
index 9a5bd2e90dd8e..dfb0bb6a99582 100644
--- a/localstack/services/stepfunctions/asl/antlr/ASLLexer.g4
+++ b/localstack/services/stepfunctions/asl/antlr/ASLLexer.g4
@@ -122,7 +122,9 @@ NEXT: '... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
kivy__kivy-5926@2e2ea47 | kivy/kivy | Python | 5,926 | Animation: Fix kivy.animation.Sequence and kivy.animation.Parallel consistency | fix #5204 #5443 #5929 | 2018-08-31T00:21:12Z | kivy.animation.Sequence sends "on_complete" event while animation is still in progress
### Versions
* Python: 2.7
* OS: Linux Ubuntu 16.04
* Kivy: 1.10.1.dev0
* Kivy installation method: git clone and python setup.py install
### Description
The program uses Animation to pulse a Widget color from black to re... | Seems to work properly with 1.9.2
Not in my version of 1.9.2. I think it's a race condition; the "on_complete" event is delivered before the animation is canceled:
```python
def stop(self, widget):
'''Stop the animation previously applied to a widget, triggering the
`on_complete` event.'''
... | [
{
"body": "### Versions\r\n\r\n* Python: 2.7\r\n* OS: Linux Ubuntu 16.04\r\n* Kivy: 1.10.1.dev0\r\n* Kivy installation method: git clone and python setup.py install\r\n\r\n### Description\r\n\r\nThe program uses Animation to pulse a Widget color from black to red and back again. When the animation completes, t... | 5cfa5bf6edeaaa6b3fc3948d76bb6d356e3d0150 | {
"head_commit": "2e2ea475843d8e7745705dd29ef5266b0ae83786",
"head_commit_message": "re-write unit tests in pytest-style",
"patch_to_review": "diff --git a/kivy/animation.py b/kivy/animation.py\nindex 83123a5942..12366845f4 100644\n--- a/kivy/animation.py\n+++ b/kivy/animation.py\n@@ -391,41 +391,7 @@ def __and__... | [
{
"diff_hunk": "@@ -455,11 +421,64 @@ def cancel_property(self, widget, prop):\n not self.anim2.have_properties_to_animate(widget)):\n self.cancel(widget)\n \n- def on_anim1_start(self, instance, widget):\n+ def have_properties_to_animate(self, widget):\n+ return (self.a... | 5141354fb3d1a36864e279a9d4f0e746920ee357 | diff --git a/kivy/animation.py b/kivy/animation.py
index 83123a5942..fa64b187a0 100644
--- a/kivy/animation.py
+++ b/kivy/animation.py
@@ -84,6 +84,7 @@
__all__ = ('Animation', 'AnimationTransition')
from math import sqrt, cos, sin, pi
+from collections import ChainMap
from kivy.event import EventDispatcher
from ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ludwig-ai__ludwig-3173@02f59ca | ludwig-ai/ludwig | Python | 3,173 | Fix TorchVision channel preprocessing | This PR introduces automatic channel resizing for torchvision models to ensure that images fed into torchvision encoders always have 3 channels. Closes #3170. | 2023-03-01T19:37:53Z | Clarification about TorchVision Pretrained Model Encoders usage
Hi,
This is not really a bug but more like a question for clarification since I might not understand the documentation properly.
What I want to do is to test various encoder architectures for my image classification problem. So I was quite happy when... | Hey @tboo, thanks for reporting this. The issue here is that the pretrained TorchVision models all assume 3 channel input images. I consider this a bug on our side, since it should work without you needing to do anything in particular to your data or adjust preprocessing.
At the moment I'm thinking the fix on our si... | [
{
"body": "Hi,\r\n\r\nThis is not really a bug but more like a question for clarification since I might not understand the documentation properly.\r\n\r\nWhat I want to do is to test various encoder architectures for my image classification problem. So I was quite happy when I saw the TorchVision encoder zoo po... | 4f6d6aeffd868b28ddd55e0494be3e7d8279d952 | {
"head_commit": "02f59ca12a3f7b4d667965d736c2693688cf7800",
"head_commit_message": "add descriptive docstring",
"patch_to_review": "diff --git a/ludwig/features/image_feature.py b/ludwig/features/image_feature.py\nindex 50388fda3aa..48cb4f30ce2 100644\n--- a/ludwig/features/image_feature.py\n+++ b/ludwig/feature... | [
{
"diff_hunk": "@@ -701,16 +743,23 @@ def add_feature_data(\n model_type = feature_config[ENCODER].get(\"type\", None)\n model_variant = feature_config[ENCODER].get(\"model_variant\")\n if model_variant:\n- torchvision_parameters = torchvision_model_registry.get(model_type).ge... | 55fff6a2deac39658eba13155976f588b4815e8a | diff --git a/ludwig/features/image_feature.py b/ludwig/features/image_feature.py
index 50388fda3aa..375f7864401 100644
--- a/ludwig/features/image_feature.py
+++ b/ludwig/features/image_feature.py
@@ -17,6 +17,7 @@
import os
import warnings
from collections import Counter
+from dataclasses import dataclass
from fun... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ludwig-ai__ludwig-3056@3fd55f0 | ludwig-ai/ludwig | Python | 3,056 | Fix LR reduce on plateau interaction with base LR decay | Fixes #3049. | 2023-02-07T18:36:51Z | Learning rate reduction not functional
**Describe the bug**
Despite the respective settings in the `trainer` section, the learning rate does not decay when a plateau is reached.
**To Reproduce**
I am using ludwig for image classification with the following .yaml
```
input_features:
- name: image_path
type:... | Hey @tboo, thanks for reporting this issue. We recently made some big changes to learning rate reduction, so definitely want to make sure it's working correctly!
I was able to repro the issue you're seeing in your environment and will take some time to dig into it tomorrow. | [
{
"body": "**Describe the bug**\r\nDespite the respective settings in the `trainer` section, the learning rate does not decay when a plateau is reached.\r\n\r\n**To Reproduce**\r\n\r\nI am using ludwig for image classification with the following .yaml\r\n```\r\ninput_features:\r\n- name: image_path\r\n type: i... | 9d58f0f431fbe364a363f9a7abf0b6e2e5386e98 | {
"head_commit": "3fd55f06aaf731ed4cf488bed0b5ab78f527de50",
"head_commit_message": "Fixed progress tracker",
"patch_to_review": "diff --git a/ludwig/modules/lr_scheduler.py b/ludwig/modules/lr_scheduler.py\nindex 5a1e03598af..cc1a2b06747 100644\n--- a/ludwig/modules/lr_scheduler.py\n+++ b/ludwig/modules/lr_sched... | [
{
"diff_hunk": "@@ -83,8 +106,18 @@ def eval_step(self, progress_tracker: ProgressTracker, validation_field: str):\n last_metric: TrainerMetric = split_metrics[validation_field][validation_metric][-1]\n last_metric_value = last_metric[-1]\n \n+ prev_num_reductions = self._eval_scheduler.n... | f04cf4958a055b9a0f3e56762abaa41c39dd54c3 | diff --git a/ludwig/modules/lr_scheduler.py b/ludwig/modules/lr_scheduler.py
index 5a1e03598af..3cf3b8f83fe 100644
--- a/ludwig/modules/lr_scheduler.py
+++ b/ludwig/modules/lr_scheduler.py
@@ -25,9 +25,26 @@ def step(self, metrics):
return super().step(metrics)
+ @property
+ def num_reduce_lr(self) -... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ludwig-ai__ludwig-3166@b3df410 | ludwig-ai/ludwig | Python | 3,166 | Make Horovod an optional dependency when using Ray | Closes #3161.
Falls back to DDP if Horovod is not installed. We may choose to make DDP the default in v0.8. | 2023-03-01T01:14:16Z | auto_train shouldn't require horovod
**Describe the bug**
Using the autoML feature in auto_train seems to require horovod, but it should be possible to leverage autoML on a single machine without requiring horovod (which is very difficult to install). If this is indeed by design, it should be called out as a requirem... | Hey @skunkwerk, thanks for the feature request! Yes, this should be pretty doable. We should be able to have a fix in the next day or so, and include it in v0.7.1. | [
{
"body": "**Describe the bug**\r\nUsing the autoML feature in auto_train seems to require horovod, but it should be possible to leverage autoML on a single machine without requiring horovod (which is very difficult to install). If this is indeed by design, it should be called out as a requirement in the auto_... | 37adc92532086e89580f974af5c5fb737286466a | {
"head_commit": "b3df410206e1f49224783c9dc07cf939315b8a92",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/ludwig/backend/_ray210_compat.py b/ludwig/backend/_ray210_compat.py\nindex 9b48447bb94..a0... | [
{
"diff_hunk": "@@ -1,8 +1,10 @@\n import contextlib\n from abc import ABC, abstractmethod\n-from typing import Any, Callable, Optional\n+from typing import Any, Callable, Dict, Optional, Tuple, Type\n \n import torch\n+from ray.train.backend import BackendConfig\n+from ray.train.data_parallel_trainer import Da... | bae9b916f244efcd2aba628323272a0a2e4f0cf6 | diff --git a/ludwig/backend/_ray210_compat.py b/ludwig/backend/_ray210_compat.py
index 9b48447bb94..a05c64f3e20 100644
--- a/ludwig/backend/_ray210_compat.py
+++ b/ludwig/backend/_ray210_compat.py
@@ -5,9 +5,6 @@
import ray
from ray.air.config import RunConfig
-from ray.air.result import Result
-from ray.train.base... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ludwig-ai__ludwig-2328@d77ee41 | ludwig-ai/ludwig | Python | 2,328 | Removes empty partitions after dropping rows and splitting datasets | This PR addresses two separate issues: https://github.com/ludwig-ai/ludwig/issues/2324 and https://github.com/ludwig-ai/ludwig/issues/2308.
The issues are addressed by culling empty partitions from the Dask DataFrame at two points: (1) after dropping rows with NaNs (part of the DROP_ROWS missing value strategy) and ... | 2022-07-28T21:16:50Z | Metadata mismatch while calculating overall stats
On occassion, I see the following error in `model.evaluate()` while computing overall stats using a sample of the dataframe. I haven't been able to reproduce this error consistently, but it does surface from time to time.
This was seen while training a small image d... | Update: This might be an issue on Ray's end - https://docs.ray.io/en/latest/_modules/ray/data/dataset.html#Dataset.to_dask
@arnavgarg1 to create an reproducible script for this error and then create an issue on Ray's GitHub to get this fixed. In the mean time, we might be manually able to override/customize the `da... | [
{
"body": "On occassion, I see the following error in `model.evaluate()` while computing overall stats using a sample of the dataframe. I haven't been able to reproduce this error consistently, but it does surface from time to time. \r\n\r\nThis was seen while training a small image dataset with only 1 image in... | 44afa4f620fe851e0a77b2b5d10769f7b120f77a | {
"head_commit": "d77ee4193cbd887e876d2c1826bd0040704aa3b2",
"head_commit_message": "Merge branch 'master' into remove-empty-partitions",
"patch_to_review": "diff --git a/ludwig/data/dataframe/dask.py b/ludwig/data/dataframe/dask.py\nindex 783bbe893ab..a8fbcd86496 100644\n--- a/ludwig/data/dataframe/dask.py\n+++ ... | [
{
"diff_hunk": "@@ -129,7 +149,24 @@ def to_ray_dataset(self, df):\n return from_dask(df)\n \n def from_ray_dataset(self, dataset) -> dd.DataFrame:\n- return dataset.to_dask()\n+ \"\"\"Custom Ray to Dask conversion implementation to pass in meta during dd.DataFrame creation.\"\"\"",
... | 5cd4d49c9b1ea516813bb60437e8e76df06a2878 | diff --git a/ludwig/data/dataframe/dask.py b/ludwig/data/dataframe/dask.py
index 783bbe893ab..a3a23147cf5 100644
--- a/ludwig/data/dataframe/dask.py
+++ b/ludwig/data/dataframe/dask.py
@@ -20,9 +20,7 @@
import dask
import dask.array as da
import dask.dataframe as dd
-import ray.data
from dask.diagnostics import Pro... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ludwig-ai__ludwig-2191@1143cef | ludwig-ai/ludwig | Python | 2,191 | Fix changing parameters on plateau. | Fixes #2186 | 2022-06-23T21:14:03Z | Comparing invalid types to determine reduced learning rate
Config:
```yaml
input_features:
- name: doc
type: text
preprocessing:
max_sequence_length: 4096
output_features:
- name: cls
type: category
column: cls
trainer:
epochs: 10
early_stop: 3
reduce_learning_rate_on_plate... | [
{
"body": "Config:\r\n```yaml\r\ninput_features:\r\n - name: doc\r\n type: text\r\n preprocessing:\r\n max_sequence_length: 4096\r\noutput_features:\r\n - name: cls\r\n type: category\r\n column: cls\r\ntrainer:\r\n epochs: 10\r\n early_stop: 3\r\n reduce_learning_rate_on_plateau: 1\r\n r... | cf9060e7ac3fe100c0377a33de6d1b76cb45418c | {
"head_commit": "1143cef069a50321d11c50a8c55ddc0f7ed8843e",
"head_commit_message": "Fix changing parameters on plateau.",
"patch_to_review": "diff --git a/ludwig/models/trainer.py b/ludwig/models/trainer.py\nindex 71954b62f09..ad1cf008eaa 100644\n--- a/ludwig/models/trainer.py\n+++ b/ludwig/models/trainer.py\n@@... | [
{
"diff_hunk": "@@ -137,3 +135,27 @@ def test_scale_lr(learning_rate_scaling, expected_lr, tmpdir, ray_test_cluster):\n \n actual_lr = ray.get(run_scale_lr.remote(config, data_csv, num_workers, outdir))\n assert actual_lr == expected_lr\n+\n+\n+def test_changing_parameters_on_plateau(tmpdir, ray_test_cl... | fbb15f984b7f88fbcd72d6273bf47861523b1fe5 | diff --git a/ludwig/models/trainer.py b/ludwig/models/trainer.py
index 71954b62f09..ad1cf008eaa 100644
--- a/ludwig/models/trainer.py
+++ b/ludwig/models/trainer.py
@@ -140,15 +140,15 @@ def __init__(
:param resume: Resume training a model that was being trained. (default: False).
:type resume: Boolea... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ludwig-ai__ludwig-2370@628be76 | ludwig-ai/ludwig | Python | 2,370 | Encoder refactor V2 | This PR contains all of Connor's commits from https://github.com/ludwig-ai/ludwig/pull/2269 (`:encoder_refactor`) merged atop the master branch, plus additional refactoring and test fixes in `:daniel/encoder_refactor`
```
master -----------------+------+>
| |
daniel/encoder_refactor | ... | 2022-08-09T23:24:16Z | RFC: Nesting Refactor for Encoder/Decoder Config
In the push to create a fully fledged schema using Marshmallow, we've run into a bit of an issue. When specifying things like optimizers, the structure of the config works well in a nested structure like this:
```
trainer:
learning_rate: 0.001
optimizer:
... | I'm not necessarily opposed to this change, but this would be a rather significant backwards compatibility layer that we'd need to maintain for a long time, so definitely want to verify that this is absolutely something we want to do.
> * Specifying encoder parameters in the future SDK config object will be complic... | [
{
"body": "In the push to create a fully fledged schema using Marshmallow, we've run into a bit of an issue. When specifying things like optimizers, the structure of the config works well in a nested structure like this:\r\n```\r\ntrainer:\r\n learning_rate: 0.001\r\n optimizer:\r\n type: adam\... | 51db5e63ae1befcccdf7ad3bbcbf827d473a6751 | {
"head_commit": "628be765baa61977c40063ad9d3a08e47072b440",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/ludwig/combiners/combiners.py b/ludwig/combiners/combiners.py\nindex 666afddd0bc..3d833c31... | [
{
"diff_hunk": "@@ -94,16 +88,14 @@ def add_feature_data(\n \n @register_input_feature(BAG)\n class BagInputFeature(BagFeatureMixin, InputFeature):\n- encoder = \"embed\"\n- vocab = []\n-\n- def __init__(self, feature, encoder_obj=None):\n- super().__init__(feature)\n- self.overwrite_defa... | 098df586139c19a5a2fcf09f6c9f544e414f53ad | diff --git a/ludwig/combiners/combiners.py b/ludwig/combiners/combiners.py
index 666afddd0bc..3d833c31074 100644
--- a/ludwig/combiners/combiners.py
+++ b/ludwig/combiners/combiners.py
@@ -29,16 +29,14 @@
from ludwig.modules.fully_connected_modules import FCStack
from ludwig.modules.reduction_modules import SequenceR... | {
"difficulty": "high",
"estimated_review_effort": 5,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
localstack__localstack-9119@aad9b80 | localstack/localstack | Python | 9,119 | StepFunctions: Multi-accounts compatibility | ## Motivation
This PR introduces multi-account support to the legacy StepFunctions provider. It also makes multi-account friendly fixes to the work-in-progress StepFunctions v2 provider.
cc: @MEPalma
## Implementation
The legacy provider uses [StepFunctions Local](https://docs.aws.amazon.com/step-functions... | 2023-09-12T11:25:25Z | bug: Stepfunctions creates resources in the fallback account
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
Stepfunctions v2 provider creates resources in the fallback account `000000000000` and not the account made by the original requester.
### Expected Beh... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\nStepfunctions v2 provider creates resources in the fallback account `000000000000` and not the account made by the original requester.\n\n### Expected Behavior\n\n_No response_\n\n### How ... | 0aea7e2b62a7694b36c9f9a9f94f8263ca38be82 | {
"head_commit": "aad9b80492fdc9f7b22f48af0184cb5febf6dd23",
"head_commit_message": "Maintain backward compatibility",
"patch_to_review": "diff --git a/localstack/constants.py b/localstack/constants.py\nindex 8abca4bf08009..547da354d4cf7 100644\n--- a/localstack/constants.py\n+++ b/localstack/constants.py\n@@ -15... | [
{
"diff_hunk": "@@ -26,8 +26,14 @@\n \n \n class Environment:\n- def __init__(self, context_object_init: ContextObjectInitData):\n+ def __init__(\n+ self, account_id: str, region_name: str, context_object_init: ContextObjectInitData\n+ ):\n super(Environment, self).__init__()\n+",
"l... | 670df14bd5041f23ff2145267eb6e6bd137e4fe4 | diff --git a/localstack/services/stepfunctions/asl/component/state/state_execution/state_map/item_reader/resource_eval/resource_eval_s3.py b/localstack/services/stepfunctions/asl/component/state/state_execution/state_map/item_reader/resource_eval/resource_eval_s3.py
index ce06edc11d34c..6eed0be685eaa 100644
--- a/local... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
ludwig-ai__ludwig-2175@33fadbf | ludwig-ai/ludwig | Python | 2,175 | Hyperopt steps per epoch not being computed correctly | Following up on [this issue](https://github.com/ludwig-ai/ludwig/issues/2144), when using windowing in the backend over a partitioned dataset (> 1 partition), we observed that the `steps_per_epoch` was being under-calculated. This results in each epoch only comprising of a fraction of the dataset.
This PR modifies t... | 2022-06-21T19:34:55Z | [Hyperopt] Steps per epoch not being computed correctly
- Total dataset size = 570M (Including test, train, val)
- Batch size = 32K
- Expected steps per epoch = 570M / 32K = ~17800
- Observed steps per epoch = 354 (From stdout at start of experiment training `training for 1000 epochs, and 354000 steps`)
- Not perfo... | I suspect this is because of the windowing. [Here](https://github.com/ludwig-ai/ludwig/blob/master/ludwig/data/dataset/ray.py#L98) we define the window over the dataset, and later [here](https://github.com/ludwig-ai/ludwig/blob/master/ludwig/data/dataset/ray.py#L175) we take the size over this result to determine the t... | [
{
"body": "- Total dataset size = 570M (Including test, train, val)\r\n- Batch size = 32K\r\n- Expected steps per epoch = 570M / 32K = ~17800\r\n- Observed steps per epoch = 354 (From stdout at start of experiment training `training for 1000 epochs, and 354000 steps`)\r\n- Not performing distributed training\r\... | 884c319bb4bf72713584ce0c1fae4e0bd7d34993 | {
"head_commit": "33fadbf9e374f25b3d2bf16814b915c469a479f3",
"head_commit_message": "Modify RayDatasetShard length to factor in windowing and dataset partitions",
"patch_to_review": "diff --git a/ludwig/backend/ray.py b/ludwig/backend/ray.py\nindex 47005b7b54f..a234082d1b6 100644\n--- a/ludwig/backend/ray.py\n+++... | [
{
"diff_hunk": "@@ -172,7 +186,10 @@ def initialize_batcher(self, batch_size=128, should_shuffle=True, seed=0, ignore\n @lru_cache(1)\n def __len__(self):\n # TODO(travis): find way to avoid calling this, as it's expensive\n- return next(self.dataset_iter).count()\n+ next_iteration... | 9f0b3dc0e3abffa934cf3d5b5aec38949e517596 | diff --git a/ludwig/data/dataset/ray.py b/ludwig/data/dataset/ray.py
index 55a8e343739..d8bb507e27a 100644
--- a/ludwig/data/dataset/ray.py
+++ b/ludwig/data/dataset/ray.py
@@ -156,12 +156,12 @@ def __init__(
self.dataset_shard = dataset_shard
self.features = features
self.training_set_metada... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-7246@23e37c5 | localstack/localstack | Python | 7,246 | Bugfix: Fix S3 internalError when try to get an object | Fix https://github.com/localstack/localstack/issues/6553
| 2022-11-25T22:10:53Z | bug: S3 internalError when try to get an object which was deleted before instead of error code NoSuchKey
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
We have some tests which are creating and deleting objects at s3. This tests are failing with localstack ver... | Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our [Slack Community](https://localstack.cloud/contact/) for real-time help and drop a message to LocalStack Pro Support if you ar... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\nWe have some tests which are creating and deleting objects at s3. This tests are failing with localstack version 0.14.4 and newer.\r\n\r\nBecause of an internalError we get as error null i... | de9ca61055d232e6d79f7b6f1fd60d4bd8b20718 | {
"head_commit": "23e37c52d700b5d0afc20d6731c575af4c24b331",
"head_commit_message": "Fix s3 GetObject method error\n\nFix https://github.com/localstack/localstack/issues/6553",
"patch_to_review": "diff --git a/localstack/services/s3/s3_listener.py b/localstack/services/s3/s3_listener.py\nindex bfcb920345253..f8db... | [
{
"diff_hunk": "@@ -688,7 +688,7 @@ def add_accept_range_header(response):\n def is_object_expired(bucket_name: str, key: str) -> bool:\n bucket = BackendState.get_bucket(bucket_name)\n key_obj = bucket.keys.get(key)\n- if not key_obj or not key_obj._expiry:\n+ if not key_obj or not getattr(key_ob... | 238e3a55e0aab9cfe7c0606554fb59f35ba11196 | diff --git a/localstack/services/s3/s3_listener.py b/localstack/services/s3/s3_listener.py
index bfcb920345253..c7527f60960fa 100644
--- a/localstack/services/s3/s3_listener.py
+++ b/localstack/services/s3/s3_listener.py
@@ -17,7 +17,6 @@
from botocore.client import ClientError
from moto.s3.exceptions import InvalidF... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-7321@62fdd77 | localstack/localstack | Python | 7,321 | Add hot reloading for new lambda provider | ## Motivation
For efficient lambda development, we have to provide an easy solution to hot reload lambda functions, especially those of interpreted languages (like python and nodejs).
However, we want to make it available for all managed runtimes.
It should also only reset the environments if a change is detected,... | 2022-12-13T15:28:52Z | feature request: Lambda ASF provider code hot-reload
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Feature description
The new ASF provider should feature the option for hot reloading for all supported languages.
It should only restart environments when necessary, and should... | Can't wait to use this feature. This is the key thing that can turn LocalStack to a truly viable solution for our team.
I’m not sure if you implement one combined solution for all runtimes, or if it varies based on the language/version, but Node v18 introduced [watch mode](https://nodejs.org/api/cli.html#--watch) whi... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Feature description\n\nThe new ASF provider should feature the option for hot reloading for all supported languages.\r\nIt should only restart environments when necessary, and should be easy to use.\n\n### 🧑... | c4fe1280d394a6439c20129716c29370b2d22fdc | {
"head_commit": "62fdd7736dad36ab48ee70c1d4a9bee4d4891d9c",
"head_commit_message": "add developer tools test to circleci config, fix another <3.10 issue",
"patch_to_review": "diff --git a/.circleci/config.yml b/.circleci/config.yml\nindex 4458197d61825..20db836d1decf 100644\n--- a/.circleci/config.yml\n+++ b/.ci... | [
{
"diff_hunk": "@@ -579,11 +594,11 @@ def set_archive_code(\n # get metadata\n lambda_arn = func_arn(lambda_name_or_arn)\n lambda_details = store.lambdas[lambda_arn]\n- is_local_mount = code.get(\"S3Bucket\") == config.BUCKET_MARKER_LOCAL\n+ is_local_mount = is_hot_reloading(code)\n \n if ... | 89fea468a749019f76e5989ae4be7e7be8b67a0d | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 4458197d61825..20db836d1decf 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -147,7 +147,7 @@ jobs:
name: Test ASF Lambda provider
environment:
PROVIDER_OVERRIDE_LAMBDA: "asf"
- TEST_PATH: "tests... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ludwig-ai__ludwig-2133@41b67af | ludwig-ai/ludwig | Python | 2,133 | feat: Adding feature type shared parameter capability for hyperopt | This change enables using the `defaults` keyword within hyperopt to set default parameters for feature groups. This will help add search spaces more concisely for datasets with a large number of features while also reducing the search space to allow for a deeper search during hyperopt.
For e.g., a user can now add ... | 2022-06-13T20:15:32Z | [Hyperopt] Allow default shared parameter search spaces
It would be helpful to enable using a new `defaults` keyword within hyperopt to set default parameters for feature groups. This will help add search spaces more concisely for datasets with a large number of features while also reducing the search space to allow fo... | [
{
"body": "It would be helpful to enable using a new `defaults` keyword within hyperopt to set default parameters for feature groups. This will help add search spaces more concisely for datasets with a large number of features while also reducing the search space to allow for a deeper search during hyperopt.\r\... | a53f9f8585d3d97782d7dca2a976077b2fdcaa9e | {
"head_commit": "41b67af871311fb7c41be2650b80869850dcf196",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/ludwig/constants.py b/ludwig/constants.py\nindex 23355f6cf67..e299d42c0b8 100644\n--- a/lu... | [
{
"diff_hunk": "@@ -805,9 +828,36 @@ def get_build_hyperopt_executor(executor_type):\n executor_registry = {\"ray\": RayTuneExecutor}\n \n \n-def set_values(model_dict, name, parameters_dict):\n- if name in parameters_dict:\n- params = parameters_dict[name]\n+def set_values(model_dict, feature_name, p... | 1c9f65a12d4b835e002045b54f575bc1f1bfba0d | diff --git a/ludwig/constants.py b/ludwig/constants.py
index 23355f6cf67..f3fa150c925 100644
--- a/ludwig/constants.py
+++ b/ludwig/constants.py
@@ -13,6 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
# =================================================... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
ludwig-ai__ludwig-2051@f52a39f | ludwig-ai/ludwig | Python | 2,051 | Fix progress bar ray | # Code Pull Requests
Please provide the following:
- Fix #1528
- Moves all the tqdm logic into the ray driver and uses a Callback from ray train to trigger tqdm stuff. Need to remove some of the coordinator logic into the LudwigProgressbar Class since all child processes need to run ray.train.report if one of t... | 2022-05-23T19:55:36Z | [ray] Fix training progress bars
Progress bars are not rendering properly in the terminal for Ray, instead printing one line per step.
This solution here is to use something like Callbacks to send updates back to the head / driver to print. | Proposed general solution from the Ray side, but looks like it still has some way to go before being landed and released: https://github.com/ray-project/ray/pull/21977 | [
{
"body": "Progress bars are not rendering properly in the terminal for Ray, instead printing one line per step.\r\n\r\nThis solution here is to use something like Callbacks to send updates back to the head / driver to print.",
"number": 1528,
"title": "[ray] Fix training progress bars"
}
] | e08d76560f940151c52771ad6c5d3e175a9403c9 | {
"head_commit": "f52a39f4cb2d9ecc27b26c226229e0eb9ee8e7ab",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/ludwig/backend/ray.py b/ludwig/backend/ray.py\nindex b5cd3c3666e..ebb6c67d93b 100644\n--- ... | [
{
"diff_hunk": "@@ -0,0 +1,73 @@\n+import uuid\n+\n+import tqdm\n+\n+try:\n+ import ray.train as rt # noqa: E402",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "ludwig/progress_bar.py",
"start_line": null,
"text": "@user1:\nIs the `noqa: E402` necessary?\n\n... | 2cb66896134b3472e4252fa7d3df647d4cc7117a | diff --git a/ludwig/backend/ray.py b/ludwig/backend/ray.py
index 8e5d7b1aad2..7f078974725 100644
--- a/ludwig/backend/ray.py
+++ b/ludwig/backend/ray.py
@@ -26,6 +26,7 @@
import pandas as pd
import ray
import torch
+import tqdm
from ray import ObjectRef
from ray.data.dataset_pipeline import DatasetPipeline
from r... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ludwig-ai__ludwig-1830@e3c40ee | ludwig-ai/ludwig | Python | 1,830 | fix: Updated fs_utils to get valid windows path from url | Resolves #1802 which was having an issue writing to a windows file path after calling `get_fs_and_path`
```
File I:\Anaconda\envs\ludwig5\lib\site-packages\ludwig\utils\fs_utils.py:133, in open_file(url, *args, **kwargs)
[130](file:///i%3A/Anaconda/envs/ludwig5/lib/site-packages/ludwig/utils/fs_utils.py?line=1... | 2022-03-21T01:02:17Z | Problem logging an experiment to wandb
**Describe the bug**
Logging a training run works fine, however when logging an experiment run (the evaluation part) with the default parameters, there is a OSError 22 relating to "probabilities_<UNK>.csv"
`OSError: [Errno 22] Invalid argument: '/results/classification_Distilb... | Hi @danielduckworth thanks for raising this issue, on the surface this issues looks to be related to the difference between windows and unix file paths. Are you able to share a small sample of the dataset so that I might try and reproduce in a windows environment?
Unfortunately not the original data I was using. But I... | [
{
"body": "**Describe the bug**\r\nLogging a training run works fine, however when logging an experiment run (the evaluation part) with the default parameters, there is a OSError 22 relating to \"probabilities_<UNK>.csv\"\r\n\r\n`OSError: [Errno 22] Invalid argument: '/results/classification_Distilbert_2/label_... | 18bb9b00615013e4c6cbf214cc8921abe4072997 | {
"head_commit": "e3c40ee338794c0fed2788a3dba6d9876a0c0de7",
"head_commit_message": "Refactor assert handling for fs, and dded pytest filesystem marker",
"patch_to_review": "diff --git a/ludwig/utils/fs_utils.py b/ludwig/utils/fs_utils.py\nindex 26555a79f54..5f83d312615 100644\n--- a/ludwig/utils/fs_utils.py\n+++... | [
{
"diff_hunk": "@@ -0,0 +1,87 @@\n+# Copyright (c) 2019 Uber Technologies, Inc.",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "tests/ludwig/utils/test_fs_utils.py",
"start_line": null,
"text": "@user1:\nnit: Remove the header for new files."
}
] | 0bff24e4c39c36c2657d494467ccee62dce5b0f5 | diff --git a/ludwig/utils/fs_utils.py b/ludwig/utils/fs_utils.py
index 26555a79f54..5f83d312615 100644
--- a/ludwig/utils/fs_utils.py
+++ b/ludwig/utils/fs_utils.py
@@ -18,6 +18,7 @@
import os
import pathlib
import tempfile
+from urllib.parse import unquote, urlparse
import fsspec
import h5py
@@ -27,6 +28,10 @@
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-6199@76c0b27 | localstack/localstack | Python | 6,199 | Add `AWS::OpenSearchService::Domain` | This PR adds the `Domain` resource for OpenSearch in CloudFormation. It functions the same as the Elasticsearch Domain (except some differences in parameters).
I chose the code duplication because the OpenSearch Resource might diverge in the future.
Fixes #6163 | 2022-06-03T13:04:55Z | question: Are there any plans to add AWS::OpenSearchService::Domain resource?
### Is there an existing issue for this?
- [X] I have searched the existing issues and read the documentation
### Question
I am using serverless framework with localstack and I am unable to define an `AWS::OpenSearchService::Domain` resour... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues and read the documentation\n\n### Question\n\nI am using serverless framework with localstack and I am unable to define an `AWS::OpenSearchService::Domain` resource. I guess I'll have to use `AWS::Elasticsearch::Dom... | b536b1f9d58d7890bf55c5beb48faca3daba129b | {
"head_commit": "76c0b2796555f33e786d73edc518455377bcff2c",
"head_commit_message": "Remove unused variable",
"patch_to_review": "diff --git a/localstack/services/cloudformation/models/__init__.py b/localstack/services/cloudformation/models/__init__.py\nindex dbe6d3792729b..23431649b3ffd 100644\n--- a/localstack/... | [
{
"diff_hunk": "@@ -0,0 +1,82 @@\n+from localstack.aws.api.opensearch import (\n+ OpenSearchPartitionInstanceType,\n+ OpenSearchWarmPartitionInstanceType,\n+)\n+from localstack.services.cloudformation.deployment_utils import remove_none_values\n+from localstack.services.cloudformation.service_models impor... | 09ac0b74e48bad3b92e6a1875244bcc1e18b72b8 | diff --git a/localstack/services/cloudformation/models/__init__.py b/localstack/services/cloudformation/models/__init__.py
index dbe6d3792729b..23431649b3ffd 100644
--- a/localstack/services/cloudformation/models/__init__.py
+++ b/localstack/services/cloudformation/models/__init__.py
@@ -8,6 +8,7 @@
"ec2",
"e... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
localstack__localstack-6168@dd96a86 | localstack/localstack | Python | 6,168 | Fix SNS format when delivering to a DLQ | There was an issue when delivering to a SQS DLQ after failing to deliver an SNS notification. The format wasn't properly handled, and we passed the event directly down to the SQS client.
### Problem
As notified in #5604, the format of the message received from the DLQ after failing to deliver a message with SNS was... | 2022-05-30T11:35:16Z | question: Is there any reason behind SNS DLQ message have different format than original AWS?
### Is there an existing issue for this?
- [X] I have searched the existing issues and read the documentation
### Question
I'm trying to implement locally DLQ for SNS with SQS, the problem is, on localstack SQS DLQ me... | [
{
"body": "### Is there an existing issue for this?\r\n\r\n- [X] I have searched the existing issues and read the documentation\r\n\r\n### Question\r\n\r\nI'm trying to implement locally DLQ for SNS with SQS, the problem is, on localstack SQS DLQ message coming from SNS have different format than what you would... | de2bf6652320edcadcf461057a6cdf7ee3cc9fb0 | {
"head_commit": "dd96a8655bd3aca82dce584999e303b5b5c97aa9",
"head_commit_message": "add snapshot to tests",
"patch_to_review": "diff --git a/localstack/services/sns/provider.py b/localstack/services/sns/provider.py\nindex c2b1efb69665a..c7a3988022df9 100644\n--- a/localstack/services/sns/provider.py\n+++ b/local... | [
{
"diff_hunk": "@@ -46,6 +48,24 @@\n PUBLICATION_RETRIES = 4\n \n \n+# copy/pasted from test_sqs.py, utility function\n+def queue_exists(sqs_client, queue_url: str) -> bool:\n+ \"\"\"\n+ Checks whether a queue with the given queue URL exists.\n+\n+ :param sqs_client: the botocore client\n+ :param qu... | 8abc6cbe9f787f3b9f69c4063c2b05ee6ce14e96 | diff --git a/localstack/services/sns/provider.py b/localstack/services/sns/provider.py
index c2b1efb69665a..9849f8d647e10 100644
--- a/localstack/services/sns/provider.py
+++ b/localstack/services/sns/provider.py
@@ -804,7 +804,7 @@ async def message_to_subscriber(
elif subscriber["Protocol"] == "sqs":
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
localstack__localstack-6547@de368b1 | localstack/localstack | Python | 6,547 | [SecretsManager] Fixed raising of incorrect error message when creating a secret staged for deletion. | Related to: https://github.com/localstack/localstack/issues/6530
- Updates the `SecretsManager`'s `CreateSecret` routine to raise an `InvalidRequestException` whenever a secret sharing its `SecretId` with another secret staged for deletion is received.
- Updates the arn tagging strategy to ensure creation of new se... | 2022-07-29T10:52:31Z | bug: When attempting to create a secret that is mark for deletion the wrong exception is thrown.
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
Attempt to create a secret with the same name as a secret waiting for deletion throws `ResourceExistsException`
###... | Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our [Slack Community](https://localstack.cloud/contact/) for real-time help and drop a message to LocalStack Pro Support if you ar... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\nAttempt to create a secret with the same name as a secret waiting for deletion throws `ResourceExistsException`\n\n### Expected Behavior\n\nAttempt to create a secret with the same name as... | f63158d61fd5b6258c332bc3ce7f0fa1d2c01586 | {
"head_commit": "de368b16420f50555882b1bc45ce1e72f27a5e29",
"head_commit_message": "minor test ident name",
"patch_to_review": "diff --git a/localstack/services/secretsmanager/provider.py b/localstack/services/secretsmanager/provider.py\nindex 86221226837cd..6a598b727313a 100644\n--- a/localstack/services/secret... | [
{
"diff_hunk": "@@ -1709,3 +1713,36 @@ def test_delete_non_existent_secret_returns_as_if_secret_exists(self, sm_client)\n assert response[\"Name\"] == secret_id\n assert response[\"ARN\"] is not None\n assert response[\"DeletionDate\"] is not None\n+\n+ def test_exp_raised_on_creation... | 43c300d44a8df9fc2e3e39439e47548185da7b14 | diff --git a/localstack/services/secretsmanager/provider.py b/localstack/services/secretsmanager/provider.py
index 86221226837cd..d4c0ddd1c7698 100644
--- a/localstack/services/secretsmanager/provider.py
+++ b/localstack/services/secretsmanager/provider.py
@@ -70,6 +70,11 @@
AWSPREVIOUS: Final[str] = "AWSPREVIOUS"
AW... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-6123@61fd8d6 | localstack/localstack | Python | 6,123 | Use asyncio run_in_executor to prevent is_ssl_socket check from blocking | This PR aims to fix blocking of the whole event loop for the lookahead for the SSL duplex socket.
Currently, the method is_ssl_socket will block until the first 5 bytes can be read - if the client does not provide these bytes, the eventloop will block and refuse any connections for the time being.
This PR fixes thi... | 2022-05-23T09:57:20Z | bug: Opening TCP connections to localstack slows down concurrent requests
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
It seems like whenever I open a connection to `localhost:4566` (4566 being exposed from the localstack container), for the next ~1 second a... | I checked how this behaved in 0.11.1 (on amd64) and it's even worse - the server hangs indefinitely as long as the telnet session is open!
I enabled debug logging in the event loop. This is what I get when I open 10 TCP connections at once: (it logs every second)
<details>
<summary>diff</summary>
```diff
diff -... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\nIt seems like whenever I open a connection to `localhost:4566` (4566 being exposed from the localstack container), for the next ~1 second any HTTP calls will have delayed responses. If I o... | 5d5d3e6d8aeace535b3ca703a04e36df6aaf81eb | {
"head_commit": "61fd8d6566a266508468843dd63a269083701959",
"head_commit_message": "use asyncio run_in_executor to make is_ssl_socket check threaded",
"patch_to_review": "diff --git a/localstack/services/generic_proxy.py b/localstack/services/generic_proxy.py\nindex f3ebda2552fa1..9f8ee0be16e1e 100644\n--- a/loc... | [
{
"diff_hunk": "@@ -935,7 +936,8 @@ def do_shutdown(self):\n \n \n async def _accept_connection2(self, protocol_factory, conn, extra, sslcontext, *args, **kwargs):\n- is_ssl_socket = DuplexSocket.is_ssl_socket(conn)\n+ loop = asyncio.get_event_loop()\n+ is_ssl_socket = await loop.run_in_executor(None, ... | 015e716ae385bd6be46869df7e763bc5111b9c93 | diff --git a/localstack/services/generic_proxy.py b/localstack/services/generic_proxy.py
index f3ebda2552fa1..c24572cf24435 100644
--- a/localstack/services/generic_proxy.py
+++ b/localstack/services/generic_proxy.py
@@ -41,6 +41,7 @@
from localstack.services.messages import Headers, MessagePayload
from localstack.se... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-5837@87be9df | localstack/localstack | Python | 5,837 | adds authorizer object to lambda event | This PR adds the authorizer object to the lambda event and encapsulates a new property into the invocation context to represent the authorization type (lambda, iam, jwt)
Fixes #5130
| 2022-04-10T18:18:55Z | bug: fails to invoke lambda in docker
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
I'm using localstack in docker-compose to test a lambda function. The lambda is in a docker image and gets triggered when a file is uploaded to s3.
Here is the localstack ... | Update: I got past the above error by using `HOST_TMP_FOLDER`, but now the function times out and there are no logs from it.
```yml
localstack:
image: localstack/localstack:latest
ports:
- 4566:4566
environment:
SERVICES: s3,sns,lambda,iam
AWS_DEFAULT_REGION: us-west-2
L... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\nI'm using localstack in docker-compose to test a lambda function. The lambda is in a docker image and gets triggered when a file is uploaded to s3. \r\n\r\nHere is the localstack docker-co... | e601ead5ed5ef5240e8a6df2f839b062b4e20ce4 | {
"head_commit": "87be9dfa29548d771ad42a06f52995a4c12da8cd",
"head_commit_message": "adds authorizer object to lambda event",
"patch_to_review": "diff --git a/localstack/services/apigateway/apigateway_listener.py b/localstack/services/apigateway/apigateway_listener.py\nindex f082f78dfd492..2fd46e31e5443 100644\n-... | [
{
"diff_hunk": "@@ -132,6 +132,13 @@ def auth_identity(self) -> Optional[Dict]:\n self.auth_info[\"identity\"] = {}\n return self.auth_info[\"identity\"]\n \n+ @property\n+ def authorizer_type(self) -> str:\n+ if isinstance(self.auth_info, dict):\n+ if self.au... | 290081c60ff2dc190baddcb22ae4b972f2c38e51 | diff --git a/localstack/services/apigateway/apigateway_listener.py b/localstack/services/apigateway/apigateway_listener.py
index f082f78dfd492..2fd46e31e5443 100644
--- a/localstack/services/apigateway/apigateway_listener.py
+++ b/localstack/services/apigateway/apigateway_listener.py
@@ -555,6 +555,12 @@ def invoke_res... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-5923@4800c3a | localstack/localstack | Python | 5,923 | Handling TableClass in DynamoDB | `TableClass` was not managed for the CRUD operations in DynamoDB. This PR should fix #5916 | 2022-04-23T09:17:36Z | bug: Response object TableDescription contains a member which is not specified: TableClass
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
> ERROR:localstack.aws.protocol.serializer: Response object TableDescription contains a member which is not specified: Tab... | Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our [Slack Community](https://localstack.cloud/contact/) for real-time help and drop a message to LocalStack Pro Support if you ar... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\n> ERROR:localstack.aws.protocol.serializer: Response object TableDescription contains a member which is not specified: TableClass\r\n> \r\n> Traceback (most recent call last):\r\n> \r\n> ... | 4b88a7bf49d828e68c1ba5ffc1854e6d108e76d3 | {
"head_commit": "4800c3a3dbf6a9d143c1478ce4fe3f1a8b33438d",
"head_commit_message": "Formatting for linting",
"patch_to_review": "diff --git a/localstack/services/dynamodb/provider.py b/localstack/services/dynamodb/provider.py\nindex 1d334c2ca3c07..f74c2f92efc70 100644\n--- a/localstack/services/dynamodb/provider... | [
{
"diff_hunk": "@@ -491,8 +501,18 @@ def update_table(\n is_no_update_error = (\n e.code == \"ValidationException\" and \"Nothing to update\" in e.message\n )\n- if is_no_update_error and update_table_input.get(\"ReplicaUpdates\"):\n- table_name ... | a065e52679bafecbd76f9c92b22ec42115ac9d2a | diff --git a/localstack/services/dynamodb/provider.py b/localstack/services/dynamodb/provider.py
index 1d334c2ca3c07..05fd9f47b5cbf 100644
--- a/localstack/services/dynamodb/provider.py
+++ b/localstack/services/dynamodb/provider.py
@@ -421,6 +421,12 @@ def create_table(
if "StreamSpecification" in table_defin... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ludwig-ai__ludwig-1379@e4b406f | ludwig-ai/ludwig | Python | 1,379 | Enable end-to-end training for text features using ParallelCNN | This PR allows end to end training for text input.
- Added output shapes to ParallelCNN. | 2021-10-12T21:30:18Z | Test and remove any regressions in modeling performance due to PyTorch migration
Test performance regressions on key datasets
- [x] ATIS
- [x] MNIST
- [x] Titanic
These are tests that are triggered periodically that train lightweight models on standard datasets and confirm that there aren't any performance regr... | [
{
"body": "Test performance regressions on key datasets\r\n\r\n- [x] ATIS\r\n- [x] MNIST\r\n- [x] Titanic\r\n\r\nThese are tests that are triggered periodically that train lightweight models on standard datasets and confirm that there aren't any performance regressions.",
"number": 1373,
"title": "Test ... | 90b35aea37458e2460e3c5b1b55a77e1d5f18bf4 | {
"head_commit": "e4b406fcd96b23ef381551e576a406a5af117495",
"head_commit_message": "Added output shapes to ParallelCNN",
"patch_to_review": "diff --git a/ludwig/encoders/sequence_encoders.py b/ludwig/encoders/sequence_encoders.py\nindex 44018eb9ebc..237e300260d 100644\n--- a/ludwig/encoders/sequence_encoders.py\... | [
{
"diff_hunk": "@@ -422,7 +422,8 @@ def __init__(\n else:\n self.dropout = None\n \n- def forward(self, inputs, training=None, mask=None):\n+ def forward(self, inputs: torch.Tensor):\n+ inputs = inputs.int()",
"line": null,
"original_line": 426,
"original_start_line"... | 6ef876da0988babdf7e8a4358f572aadf4590d08 | diff --git a/ludwig/encoders/sequence_encoders.py b/ludwig/encoders/sequence_encoders.py
index 44018eb9ebc..237e300260d 100644
--- a/ludwig/encoders/sequence_encoders.py
+++ b/ludwig/encoders/sequence_encoders.py
@@ -520,10 +520,6 @@ def __init__(
default_dropout=dropout,
)
- @propert... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} | |
localstack__localstack-4802@67fe8d1 | localstack/localstack | Python | 4,802 | Correctly format code if inline code is used on update | Currently, the method wrapping the code in a zip file is not called on update.
This PR fixes this behavior, and adds a test to test it.
Fixes #4786 | 2021-10-28T09:39:54Z | bug: Redeploying lambda with CDK fails "localstack.services.awslambda.lambda_api.ClientError: Uploaded Lambda code for runtime (nodejs14.x) is not in Zip format"
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
When using CDK to deploy a simple Lambda func... | [
{
"body": "### Is there an existing issue for this?\r\n\r\n- [X] I have searched the existing issues\r\n\r\n### Current Behavior\r\n\r\nWhen using CDK to deploy a simple Lambda function the stack deploys first time and is successful. \r\nThough when deployed a second time it fails. \r\n\r\nIf I change the name ... | a201ff49852c27b35fc326a160a55ef873fd382c | {
"head_commit": "67fe8d17594361b38f894c123d77f0cbe1804ab7",
"head_commit_message": "fix double-zipping of files, activate test",
"patch_to_review": "diff --git a/.circleci/config.yml b/.circleci/config.yml\nindex 5838285f15149..ef98a45323e6e 100644\n--- a/.circleci/config.yml\n+++ b/.circleci/config.yml\n@@ -77,... | [
{
"diff_hunk": "@@ -0,0 +1,114 @@\n+Resources:\n+ fnServiceRole5D180AFD:\n+ Type: AWS::IAM::Role\n+ Properties:\n+ AssumeRolePolicyDocument:\n+ Statement:\n+ - Action: sts:AssumeRole\n+ Effect: Allow\n+ Principal:\n+ Service: lambda.amazonaws.com\n+... | a2edd278f75057e236703b12df64f6d1b31ccbfe | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 5838285f15149..ef98a45323e6e 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -77,7 +77,7 @@ jobs:
name: Test docker client
environment:
DEBUG: 1
- TEST_PATH: "tests/integration/docker"
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
localstack__localstack-5645@c04e232 | localstack/localstack | Python | 5,645 | [SecretsManager] Fixes | Addresses the following bug reports:
- It is possible to create secrets with invalid names which fail when you try to retrieve secrets for them with the message Secrets Manager can't find the specified secret value for staging label: AWSCURRENT
- Last accessed is not being updated when fetching secrets (getSecretValu... | 2022-03-10T12:00:25Z | bug: error on enable secrets manager rotation
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
**Trying enable secrets rotation**
```bash
awslocal secretsmanager rotate-secret \
--secret-id arn:aws:secretsmanager:sa-east-1:000000000000:secret:my-secret-... | I'm also running into this bug and my configuration is pretty much the same, but I'm using the AWS SDK for Node.
There may be a similarly related bug where when creating a new secret value with the `AWSPENDING` stage label, it removes the `AWSCURRENT` stage label from the current version, which isn't supposed to happen... | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Current Behavior\n\n**Trying enable secrets rotation**\r\n\r\n```bash\r\nawslocal secretsmanager rotate-secret \\\r\n --secret-id arn:aws:secretsmanager:sa-east-1:000000000000:secret:my-secret-mrUQmq \\\r\... | c856533f34df4759837233dba26154997808c479 | {
"head_commit": "c04e23250a0ffc71b12091745ef33cdeef1aa988",
"head_commit_message": "[minor]",
"patch_to_review": "diff --git a/localstack/services/secretsmanager/provider.py b/localstack/services/secretsmanager/provider.py\nindex 0f52bfe6a5490..1d662e2601d96 100644\n--- a/localstack/services/secretsmanager/provi... | [
{
"diff_hunk": "@@ -68,143 +84,458 @@ def __init__(self):\n apply_patches()\n \n @staticmethod\n- def _transform_context_secret_id(context: RequestContext) -> Optional[Dict]:\n+ def _transform_context_secret_id(secret_id: SecretIdType) -> Optional[SecretIdType]:\n # If secret ARN ends ... | c280a99be627302d1bb9446ff18faa825935d710 | diff --git a/localstack/services/secretsmanager/provider.py b/localstack/services/secretsmanager/provider.py
index 04ea357e1106b..fb605a8899e4b 100644
--- a/localstack/services/secretsmanager/provider.py
+++ b/localstack/services/secretsmanager/provider.py
@@ -1,11 +1,16 @@
+from __future__ import annotations
+
import... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-2110@5de701c | localstack/localstack | Python | 2,110 | Make Lambda batch size configurable for Kinesis event source mappings | * Set default batch size event source = 10
* Create multiple events according to the batch size
Fixes #1131 | 2020-02-29T17:52:55Z | Lambda Event Source Mapping From Kinesis Does Not Always Honor Batch Size
I have a setup where there is a node.js application that writes to a kinesis stream using putRecords for two items. The kinesis stream feeds a Lambda function that is configured with an eventSourceMapping with a batch size of 1. However, when I d... | Hi, thanks for reporting @tmoser2525 . This should be relatively easy to achieve - instead of creating a single `event` with all records, we could create multiple events according to the batch size configuration of the event source mapping here:
https://github.com/localstack/localstack/blob/master/localstack/service... | [
{
"body": "I have a setup where there is a node.js application that writes to a kinesis stream using putRecords for two items. The kinesis stream feeds a Lambda function that is configured with an eventSourceMapping with a batch size of 1. However, when I debug what the Records Kinesis feeds the lambda for an i... | 0a6e57ac423df7112997b24f7d7049ca48d154d5 | {
"head_commit": "5de701c26fbbfb39c2dd19f0916af54c1ecf0213",
"head_commit_message": "Fix issue #1131\n* Fix long-line issue with lint",
"patch_to_review": "diff --git a/localstack/services/awslambda/lambda_api.py b/localstack/services/awslambda/lambda_api.py\nindex 1d207e6556b66..7a705516b3c4e 100644\n--- a/local... | [
{
"diff_hunk": "@@ -1134,7 +1143,9 @@ def create_event_source_mapping():\n in: body\n \"\"\"\n data = json.loads(to_str(request.data))\n- mapping = add_event_source(data['FunctionName'], data['EventSourceArn'], data.get('Enabled'))\n+ mapping = add_event_source(\n+ data['Funct... | b43c2d0f40cc26ffdf51391d527da1ccd74469f7 | diff --git a/localstack/services/awslambda/lambda_api.py b/localstack/services/awslambda/lambda_api.py
index 1d207e6556b66..167b90be1c917 100644
--- a/localstack/services/awslambda/lambda_api.py
+++ b/localstack/services/awslambda/lambda_api.py
@@ -63,6 +63,8 @@
LAMBDA_ZIP_FILE_NAME = 'original_lambda_archive.zip'
LA... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
localstack__localstack-1579@cd2e27f | localstack/localstack | Python | 1,579 | Honor signed header requests | This adds support for signed requests that include response header overrides.
Fixes #1203 | 2019-09-19T23:18:36Z | response-content-disposition is not honored on download
When generating a pre-signed URL for download and specifying response-content-disposition to set a target filename, the actual download does not contain the Content-Disposition header therefore the download file does not have the requested filename.
I have conf... | [
{
"body": "When generating a pre-signed URL for download and specifying response-content-disposition to set a target filename, the actual download does not contain the Content-Disposition header therefore the download file does not have the requested filename.\r\n\r\nI have confirmed that this works corrected i... | 6a2a26fbc5043f30e76b92456643339f6abf034d | {
"head_commit": "cd2e27f74265db040d95e79064134f3a5f2e42c6",
"head_commit_message": "Honor signed header requests\n\nFixes #1203",
"patch_to_review": "diff --git a/localstack/services/s3/s3_listener.py b/localstack/services/s3/s3_listener.py\nindex 671ffda790534..376e5e6276915 100644\n--- a/localstack/services/s3... | [
{
"diff_hunk": "@@ -649,6 +649,22 @@ def return_response(self, method, path, data, headers, response):\n except Exception:\n pass\n \n+ # Honor response header overrides\n+ # https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectGET.html\n+ if met... | 783b66f7de7e8d6faede07539ff62cb1ebfd5204 | diff --git a/localstack/services/s3/s3_listener.py b/localstack/services/s3/s3_listener.py
index 671ffda790534..c5e933121205a 100644
--- a/localstack/services/s3/s3_listener.py
+++ b/localstack/services/s3/s3_listener.py
@@ -43,6 +43,16 @@
# list of destination types for bucket notifications
NOTIFICATION_DESTINATION_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ludwig-ai__ludwig-608@6eff19c | ludwig-ai/ludwig | Python | 608 | Add k fold cv cli feature | # Code Pull Requests
Resolves #462.
#### Summary of changes:
```
Added function kfold_cross_validate() function in train..py that calls full_train() k times.
Added function generate_kfold_splits() function to utils/data_utils.py
Create `kfold_training_statistics.json` statistics file to hold results fr... | 2020-01-09T02:43:48Z | k-fold cross validation for training models with CLI
**Describe the use case**
Training multiple models with shuffled training data (k-folds) can reveals information about our data sets. For example, one fold may be much less accurate than other folds telling us that we might need to increase the total number of sampl... | @danielduckworth Thanks for the suggestion. This is a good idea.
Feel free to create a pr if you have time to work on it :)
@msaisumanth I'll work on it with my team and submit something in the next few weeks. We have already benefited greatly from Ludwig so happy to contribute.
Thank you so much @danielduckworth... | [
{
"body": "**Describe the use case**\r\nTraining multiple models with shuffled training data (k-folds) can reveals information about our data sets. For example, one fold may be much less accurate than other folds telling us that we might need to increase the total number of samples.\r\n\r\n**Describe the soluti... | e8af86cddff04f523d990203db2321b446debcb3 | {
"head_commit": "6eff19c611830ff7b04cc85f980f3adafc945944",
"head_commit_message": "Merge branch 'master' into add_k-fold_cv_cli_feature",
"patch_to_review": "diff --git a/ludwig/train.py b/ludwig/train.py\nindex cd090ac1edb..51b2e228f49 100644\n--- a/ludwig/train.py\n+++ b/ludwig/train.py\n@@ -21,10 +21,13 @@\n... | [
{
"diff_hunk": "@@ -396,6 +400,68 @@ def full_train(\n )\n \n \n+def kfold_cross_validate(\n+ model_definition,\n+ model_definition_file=None,\n+ data_csv=None,\n+ data_train_csv=None,\n+ data_validation_csv=None,\n+ o... | 712f5e25fdaa73df5f5d24c5bb71ea6e220cf68f | diff --git a/ludwig/experiment.py b/ludwig/experiment.py
index 522aa3c0482..a4adb7a2f7c 100644
--- a/ludwig/experiment.py
+++ b/ludwig/experiment.py
@@ -22,6 +22,10 @@
import logging
import os
import sys
+import tempfile
+
+import numpy as np
+import pandas as pd
import yaml
from ludwig.contrib import contrib_co... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
localstack__localstack-1358@7bc1a07 | localstack/localstack | Python | 1,358 | Improve documentation around @LocalstackDockerProperties | Fixes #1324.
| 2019-06-05T20:18:31Z | Docker example with junit5 throws java.lang.IllegalStateException
looks like this snippet for Junit5 (have not tested it with Junit4) is not working with `lambda` and `stepfunctions`
```
@ExtendWith(LocalstackDockerExtension.class)
@LocalstackDockerProperties(randomizePorts = true, services = { "sqs", "kinesis:770... | Hello,
I think that specifying the `randomizePorts` + a default port for Kinesis is causing the error.
When you specify `RandomizePorts` it means this:
```java
public RunCommand withExposedPorts(String portsToExpose, boolean randomize) {
String portsOption = String.format("%s:%s", randomize ? "" : por... | [
{
"body": "looks like this snippet for Junit5 (have not tested it with Junit4) is not working with `lambda` and `stepfunctions`\r\n\r\n```\r\n@ExtendWith(LocalstackDockerExtension.class)\r\n@LocalstackDockerProperties(randomizePorts = true, services = { \"sqs\", \"kinesis:77077\" })\r\npublic class MyDockerClou... | cfaf9d7d9fc2adce789f64afe8f7f046ba30918a | {
"head_commit": "7bc1a07dd5cef6790171bbe8ba642ada8b866748",
"head_commit_message": "Improve documentation around @LocalstackDockerProperties",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 100b81b7b2dfc..ccb7d70d1c7e8 100644\n--- a/README.md\n+++ b/README.md\n@@ -371,7 +371,7 @@ duration of the t... | [
{
"diff_hunk": "@@ -386,12 +386,25 @@ Or with JUnit 5 :\n \n ```\n @ExtendWith(LocalstackDockerExtension.class)\n-@LocalstackDockerProperties(randomizePorts = true, services = { \"sqs\", \"kinesis:77077\" })\n+@LocalstackDockerProperties(services = { \"sqs\", \"kinesis:77077\" })\n public class MyDockerCloudApp... | 011f576d6677fac22a6c14ae8b608d81dc4fff69 | diff --git a/README.md b/README.md
index 100b81b7b2dfc..f1d833ea8f297 100644
--- a/README.md
+++ b/README.md
@@ -371,7 +371,7 @@ duration of the test. The container can be configured by using the @LocalstackD
```
@RunWith(LocalstackDockerTestRunner.class)
-@LocalstackDockerProperties(randomizePorts = true, service... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
mindsdb__mindsdb-10336@c9fbf4d | mindsdb/mindsdb | Python | 10,336 | Fix docs to use couchbasevector | ## Description
Please include a summary of the change and the issue it solves.
Fixes #10337
## Type of change
(Please delete options that are not relevant)
- [ ] 🐛 Bug fix (non-breaking change which fixes an issue)
- [ ] ⚡ New feature (non-breaking change which adds functionality)
- [ ] 📢 Breaking ... | 2025-01-07T07:31:04Z | [Docs]: Fix couchbase vector store docs
### Short description of what should be added or improved
There needs a minor change in the docs, where it points to couchbase instead of couchbasevector handler
### Video or screenshots
_No response_
### Anything else?
_No response_ | [
{
"body": "### Short description of what should be added or improved\n\nThere needs a minor change in the docs, where it points to couchbase instead of couchbasevector handler \n\n### Video or screenshots\n\n_No response_\n\n### Anything else?\n\n_No response_",
"number": 10337,
"title": "[Docs]: Fix co... | fe1f63f7e856748a26ea8c3324c09f3f2d6b9f96 | {
"head_commit": "c9fbf4d4a09168fceefd073a49c6c6491d652b0f",
"head_commit_message": "Fix docs to use couchbasevector",
"patch_to_review": "diff --git a/docs/integrations/data-integrations/couchbasevector.mdx b/docs/integrations/data-integrations/couchbasevector.mdx\nindex 776d91823d6..dfc5df967e1 100644\n--- a/do... | [
{
"diff_hunk": "@@ -22,7 +22,7 @@ In order to make use of this handler and connect to a Couchbase server in MindsD\n ```sql\n CREATE DATABASE couchbase_vectorsource\n WITH\n-engine='couchbase',\n+engine='couchbasevector',",
"line": null,
"original_line": 25,
"original_start_line": null,
"path": ... | 7197d4f14334ba800b64b370158f7a4029acfcde | diff --git a/docs/integrations/data-integrations/couchbasevector.mdx b/docs/integrations/data-integrations/couchbasevector.mdx
deleted file mode 100644
index 776d91823d6..00000000000
--- a/docs/integrations/data-integrations/couchbasevector.mdx
+++ /dev/null
@@ -1,116 +0,0 @@
----
-title: CouchbaseVector
-sidebarTitle:... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
mindsdb__mindsdb-9524@1e71135 | mindsdb/mindsdb | Python | 9,524 | Shared pgvector in cloud | ## Description
**Updates:**
Using default vector storage
- if `KB_PGVECTOR_URL` env variable is set:
- pgvector database with name `kb_pgvector_store` will be created
- it will use connection args from `KB_PGVECTOR_URL` (exampe: postgresql://user:password@server:5432/db)
- database will be created if... | 2024-07-22T13:08:19Z | [Bug]: Unable to create knowledge base with default embedding model
### Short description of current behavior
Creating knowledge base without embedding model defined should create langchain_embedding model under the hood and use it.
But after langchain_embedding is not permanent handler (changed in this PR) mindsdb ... | [
{
"body": "### Short description of current behavior\n\nCreating knowledge base without embedding model defined should create langchain_embedding model under the hood and use it.\r\nBut after langchain_embedding is not permanent handler (changed in this PR) mindsdb unable create model. \r\nHow to fix:\r\n- cre... | d44c90ed00ae719ab3dc4630a4d56ec2da3a31d2 | {
"head_commit": "1e71135c528242e86bf07d9f4960094673cf582e",
"head_commit_message": "don't delete default model",
"patch_to_review": "diff --git a/mindsdb/api/executor/datahub/datanodes/project_datanode.py b/mindsdb/api/executor/datahub/datanodes/project_datanode.py\nindex 3189045c9fc..7a08c94689a 100644\n--- a/m... | [
{
"diff_hunk": "@@ -30,8 +32,42 @@ class PgVectorHandler(VectorStoreHandler, PostgresHandler):\n def __init__(self, name: str, **kwargs):\n \n super().__init__(name=name, **kwargs)\n+ self._is_shared_db = False\n self.connect()\n \n+ def _make_connection_args(self):\n+ cloud... | 6aa1a2570faed59b11f6e56a9e572d8ab72ea68d | diff --git a/mindsdb/api/executor/datahub/datanodes/project_datanode.py b/mindsdb/api/executor/datahub/datanodes/project_datanode.py
index 3189045c9fc..7a08c94689a 100644
--- a/mindsdb/api/executor/datahub/datanodes/project_datanode.py
+++ b/mindsdb/api/executor/datahub/datanodes/project_datanode.py
@@ -181,4 +181,4 @@... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
mindsdb__mindsdb-9473@9e3f0c9 | mindsdb/mindsdb | Python | 9,473 | Updates to LiteLLM integration | ## Description
This PR fixes #9472 , https://github.com/mindsdb/mindsdb/security/dependabot/142 and https://github.com/mindsdb/mindsdb/security/dependabot/143 and also updates the README to follow up to the new structure.
## Type of change
(Please delete options that are not relevant)
- [X] 🐛 Bug fix (no... | 2024-07-09T12:27:47Z | [Bug]: LiteLLM integration issues when querying
When querying the LiteLLM integration, the following error is returned:
```
[litellm/litellm_handler_simple1]: BadRequestError: litellm.BadRequestError: BadRequestError: OpenAIException - Error code: 400 - {'error': {'message': "Invalid 'functions': empty array. Expecte... | [
{
"body": "When querying the LiteLLM integration, the following error is returned:\r\n```\r\n[litellm/litellm_handler_simple1]: BadRequestError: litellm.BadRequestError: BadRequestError: OpenAIException - Error code: 400 - {'error': {'message': \"Invalid 'functions': empty array. Expected an array with minimum ... | d5dcc7eb067f8c750c29a783487f23f306d5a1ed | {
"head_commit": "9e3f0c9e413a0f3fc8303dd5d49a9799a60e24ab",
"head_commit_message": "Update README",
"patch_to_review": "diff --git a/mindsdb/integrations/handlers/litellm_handler/README.md b/mindsdb/integrations/handlers/litellm_handler/README.md\nindex 7fa5753442b..48898beea5e 100644\n--- a/mindsdb/integrations... | [
{
"diff_hunk": "@@ -1,120 +1,60 @@\n-# Litellm Handler\n+## LlamaIndex Handler",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "mindsdb/integrations/handlers/litellm_handler/README.md",
"start_line": null,
"text": "@user1:\nThis should be LiteLLM."
},
{
"... | 9414708b302e55994b8116a4517a719692511618 | diff --git a/mindsdb/integrations/handlers/litellm_handler/README.md b/mindsdb/integrations/handlers/litellm_handler/README.md
index 7fa5753442b..baa817edc22 100644
--- a/mindsdb/integrations/handlers/litellm_handler/README.md
+++ b/mindsdb/integrations/handlers/litellm_handler/README.md
@@ -1,120 +1,60 @@
-# Litellm H... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
mindsdb__mindsdb-9359@c75ed37 | mindsdb/mindsdb | Python | 9,359 | Run prediction in partitions | ## Description
Depends on: https://github.com/mindsdb/mindsdb_sql/pull/382
Fixes https://linear.app/mindsdb/issue/SQL-20/research-partitioning-approach
Execute prediction in partitions. If partition_size param is used:
```sql
select * from int.tab1 a
join proj.pred1 p1
using partition_size... | 2024-06-17T12:11:01Z | [Bug]: Error if `JOIN` model with empty data
### Short description of current behavior
If run batch prediction query (`join` model with data), where data query returns empty list of records, then error appear.
### Video or screenshots
_No response_
### Expected behavior
_No response_
### How to reproduce the erro... | [
{
"body": "### Short description of current behavior\n\nIf run batch prediction query (`join` model with data), where data query returns empty list of records, then error appear.\n\n### Video or screenshots\n\n_No response_\n\n### Expected behavior\n\n_No response_\n\n### How to reproduce the error\n\n1. Follow... | 8b2fe1fcdc73c7f83f67b996ae7cafe584289caa | {
"head_commit": "c75ed37a99a43bbd1a49db10093a11cd504792ee",
"head_commit_message": "mindsdb sql dep",
"patch_to_review": "diff --git a/.github/workflows/test_on_push.yml b/.github/workflows/test_on_push.yml\nindex ff060a77e68..45079ecbe74 100644\n--- a/.github/workflows/test_on_push.yml\n+++ b/.github/workflows/... | [
{
"diff_hunk": "@@ -64,10 +55,98 @@ class MapReduceStepCall(BaseStepCall):\n \n bind = MapReduceStep\n \n- def call(self, step):\n+ def call(self, step: MultipleSteps):\n if step.reduce != 'union':\n raise LogicError(f'Unknown MapReduceStep type: {step.reduce}')\n \n+ partit... | d2d8779b583adaa4ac65e8ff489c2c63fd53f66d | diff --git a/.github/workflows/test_on_push.yml b/.github/workflows/test_on_push.yml
index 8a1bd701302..2c9db8b3d5e 100644
--- a/.github/workflows/test_on_push.yml
+++ b/.github/workflows/test_on_push.yml
@@ -127,12 +127,12 @@ jobs:
- name: Run unit tests
run: |
if [ "$RUNNER_OS" == "Linux" ]... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
mindsdb__mindsdb-9807@e26b59f | mindsdb/mindsdb | Python | 9,807 | Integration of Groq Models with MindsDB | ## Description
This PR integrates Groq models into MindsDB to enable faster AI predictions. By leveraging Groq’s high-speed processing, users can obtain quicker results.
Fixes #9796
## Type of change
(Please delete options that are not relevant)
- [ ] 🐛 Bug fix (non-breaking change which fixes an issue... | 2024-10-08T06:14:10Z | [Integration]: Groq LLMs
### Is there an existing integration?
- [X] I have searched the existing integrations.
### Use Case
- Faster AI Predictions: Groq models provide quicker results for database queries using MindsDB.
### Motivation
Users will get faster AI responses and reduced computational costs... | I would like to work on this | [
{
"body": "### Is there an existing integration?\r\n\r\n- [X] I have searched the existing integrations.\r\n\r\n### Use Case\r\n\r\n- Faster AI Predictions: Groq models provide quicker results for database queries using MindsDB.\r\n\r\n\r\n### Motivation\r\n\r\nUsers will get faster AI responses and reduced com... | a2efa634716a90107bbf3b3aa6ea61daad92d78e | {
"head_commit": "e26b59ff9044314bb6e68160279e7d6b388f95ac",
"head_commit_message": "Merge branch 'main' into feat/groq-handler",
"patch_to_review": "diff --git a/mindsdb/integrations/handlers/groq_handler/README.md b/mindsdb/integrations/handlers/groq_handler/README.md\nnew file mode 100644\nindex 00000000000..d... | [
{
"diff_hunk": "@@ -0,0 +1,132 @@\n+import os\n+import pandas as pd\n+import openai\n+from openai import OpenAI, NotFoundError, AuthenticationError\n+from typing import Dict, Optional\n+from mindsdb.integrations.handlers.openai_handler import Handler as OpenAIHandler\n+from mindsdb.integrations.utilities.handle... | f86c61e9a9b293746535c02bf4d55913a830b0ca | diff --git a/mindsdb/integrations/handlers/groq_handler/README.md b/mindsdb/integrations/handlers/groq_handler/README.md
new file mode 100644
index 00000000000..7fee4101a6f
--- /dev/null
+++ b/mindsdb/integrations/handlers/groq_handler/README.md
@@ -0,0 +1,116 @@
+---
+title: Groq
+sidebarTitle: Groq
+---
+
+This docum... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
mindsdb__mindsdb-9313@049d551 | mindsdb/mindsdb | Python | 9,313 | Added Job to Trigger a Release of the Docker Desktop Extension | ## Description
This PR adds a job to the production workflow that deploys MindsDB artifacts to trigger a new release of the Docker Desktop extension. This is done by triggering [this workflow](https://github.com/mindsdb/mindsdb-docker-extension/blob/main/.github/workflows/bump-mindsdb-version.yml) setup in the repos... | 2024-06-07T12:42:43Z | Auto-update MindsDB Container When New Image is Released
At the moment, since the extension is using Docker Compose to bring up the containers, if the MindsDB image (mindsdb/mindsdb:latest) has already been pulled by the user (or if the extension was installed) and a new version of the image is released subsequently, t... | Only partially resolved by https://github.com/mindsdb/mindsdb-docker-extension/pull/12 | [
{
"body": "At the moment, since the extension is using Docker Compose to bring up the containers, if the MindsDB image (mindsdb/mindsdb:latest) has already been pulled by the user (or if the extension was installed) and a new version of the image is released subsequently, the extension will continue to use the ... | 3525ad011de78e7a892223cbc067d6fdc6430d0e | {
"head_commit": "049d5510057a9031b0357e46861c97492ee03306",
"head_commit_message": "updated the var used to access tag",
"patch_to_review": "diff --git a/.github/workflows/build_deploy_prod.yml b/.github/workflows/build_deploy_prod.yml\nindex 9b5541cbb61..09002cc02c6 100644\n--- a/.github/workflows/build_deploy_... | [
{
"diff_hunk": "@@ -114,9 +114,31 @@ jobs:\n ref: main\n client_payload: '{\"image-tag-prefix\": \"${{ env.CI_REF_NAME }}\", \"deploy-env\": \"prod\"}'\n \n+ trigger_dd_extension_release:\n+ # Trigger private repo to deploy to prod env\n+ runs-on: mdb-dev\n+ needs: docker_build\n+ ... | 35b64598bebf0c50d878315c406d3d124eff046f | diff --git a/.github/workflows/build_deploy_prod.yml b/.github/workflows/build_deploy_prod.yml
index 9b5541cbb61..a500e5ed13d 100644
--- a/.github/workflows/build_deploy_prod.yml
+++ b/.github/workflows/build_deploy_prod.yml
@@ -4,8 +4,8 @@ on:
release:
types: [published]
paths-ignore:
- - 'docs/**'
-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mindsdb__mindsdb-9186@e3f823b | mindsdb/mindsdb | Python | 9,186 | Fix pydantic warnings | Fixes #9185
I've had to rename some pydantic model fields to avoid the protected namespace in pydantic v2. | 2024-05-09T02:13:41Z | [Bug]: Pydantic warnings in docker container
### Short description of current behavior
Running the current `main` branch in a docker container produces a number of pydantic warnings:
```
You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
warnings.warn(
/usr/local/li... | [
{
"body": "### Short description of current behavior\n\nRunning the current `main` branch in a docker container produces a number of pydantic warnings:\r\n\r\n```\r\nYou may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.\r\n warnings.warn(\r\n/usr/local/lib/python3.10/s... | 416c6b8bd5a221aa7f8435491c7969cf3357f387 | {
"head_commit": "e3f823bebd2e1bf301405f36233d61d00d367915",
"head_commit_message": "Update location of BaseSettings and add annotations",
"patch_to_review": "diff --git a/.github/workflows/test_on_push.yml b/.github/workflows/test_on_push.yml\nindex ba5c45719fd..616b63316a5 100644\n--- a/.github/workflows/test_o... | [
{
"diff_hunk": "@@ -239,9 +239,9 @@ class MSTeamsHandlerConfig(BaseSettings):\n }\n }\n \n- TEST_CHAT_MESSAGES_DATA = [TEST_CHAT_MESSAGE_DATA]\n+ TEST_CHAT_MESSAGES_DATA: List = [TEST_CHAT_MESSAGE_DATA]",
"line": null,
"original_line": 242,
"original_start_line": null,
"path": ... | d3902ef49d7dd3943ffac102edbec2b5a3a8165c | diff --git a/.github/workflows/test_on_push.yml b/.github/workflows/test_on_push.yml
index ba5c45719fd..616b63316a5 100644
--- a/.github/workflows/test_on_push.yml
+++ b/.github/workflows/test_on_push.yml
@@ -130,6 +130,7 @@ jobs:
env PYTHONPATH=./ pytest tests/unit/test_mongodb_server.py
env PYTH... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
mindsdb__mindsdb-8938@728de33 | mindsdb/mindsdb | Python | 8,938 | updated docker docs | ## Description
updated docker desktop docs
Fixes #8956
## Type of change
- [ ] 📄 This change is a documentation update
| 2024-03-18T11:08:44Z | [Docs]: Add Revamped Documentation for Docker and Docker Desktop
### Short description of what should be added or improved
The documentation for running MindsDB via Docker should be revamped by including best practices for its use.
The documentation for the MindsDB Docker Desktop Extension should also be revamped giv... | [
{
"body": "### Short description of what should be added or improved\n\nThe documentation for running MindsDB via Docker should be revamped by including best practices for its use.\r\nThe documentation for the MindsDB Docker Desktop Extension should also be revamped given that we have taken ownership of maintai... | a5c0efc7707ebe2d4b7bcac130c53523d6bd7391 | {
"head_commit": "728de3374fcf1e63055c62541268809ab9a11664",
"head_commit_message": "docker (desktop) docs",
"patch_to_review": "diff --git a/docs/setup/self-hosted/docker-desktop.mdx b/docs/setup/self-hosted/docker-desktop.mdx\nindex c478f8522f3..d6fccf1789e 100644\n--- a/docs/setup/self-hosted/docker-desktop.md... | [
{
"diff_hunk": "@@ -49,35 +18,48 @@ It is the Docker image of MindsDB that comes with [these integrations](https://g\n It is the Docker image of MindsDB that comes with [these integrations](https://github.com/mindsdb/mindsdb/blob/staging/default_handlers.txt) and the Hugging Face integration preloaded.\n </Tip>... | 53f68a4b011bf47a2dd556ebbcb6db3465cfcb86 | diff --git a/docs/assets/install-dependencies-gui-x.png b/docs/assets/install-dependencies-gui-x.png
new file mode 100644
index 00000000000..a4afc61191c
Binary files /dev/null and b/docs/assets/install-dependencies-gui-x.png differ
diff --git a/docs/assets/install-dependencies-gui.png b/docs/assets/install-dependencies... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
mindsdb__mindsdb-8682@66ba8ee | mindsdb/mindsdb | Python | 8,682 | youtube documentation update | ## Description
Documentation update to reflect the YouTube handler Readme.md. I assume that the read me is up to date.
Fixes #8667
## Type of change
- [ x ] 📄 This change requires a documentation update
## Checklist:
- [ x ] My code follows the style guidelines(PEP 8) of MindsDB.
- [ x ] I have appro... | 2024-01-24T23:28:44Z | [Docs]: Update the Documentation for the YouTube Integration
### Short description of what should be added or improved
The documentation for the YouTube handler needs to be updated in line with the recent updates that have been made, especially the use of OAuth for authentication.
### Video or screenshots
_No respon... | [
{
"body": "### Short description of what should be added or improved\n\nThe documentation for the YouTube handler needs to be updated in line with the recent updates that have been made, especially the use of OAuth for authentication.\n\n### Video or screenshots\n\n_No response_\n\n### Anything else?\n\n_No res... | d1b3d721b2ffdf03a4d29c525d660617c6e87c7a | {
"head_commit": "66ba8ee52d8a68eec7bcf2533ff627797a22c288",
"head_commit_message": "youtube documentation update",
"patch_to_review": "diff --git a/docs/integrations/app-integrations/youtube.mdx b/docs/integrations/app-integrations/youtube.mdx\nindex b9eea5e8e4f..4cda7bb8804 100644\n--- a/docs/integrations/app-i... | [
{
"diff_hunk": "@@ -5,66 +5,79 @@ sidebarTitle: YouTube\n \n In this section, we present how to connect YouTube to MindsDB.\n \n-[YouTube](https://www.youtube.com/) is a popular online video-sharing platform and social media website where users can upload, view, share, and interact with videos created by indivi... | 0693c4fb535bcc92da7d5619453cd9a981229b76 | diff --git a/docs/integrations/app-integrations/youtube.mdx b/docs/integrations/app-integrations/youtube.mdx
index b9eea5e8e4f..13f6ffc9d9e 100644
--- a/docs/integrations/app-integrations/youtube.mdx
+++ b/docs/integrations/app-integrations/youtube.mdx
@@ -5,66 +5,79 @@ sidebarTitle: YouTube
In this section, we pres... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
mem0ai__mem0-2395@2819776 | mem0ai/mem0 | Python | 2,395 | Add: Pinecone integration | ## Description
This PR includes the integration for Pinecone.
Fixes #2385
## Type of change
- [x] New feature (non-breaking change which adds functionality)
- [x] Refactor (does not change functionality, e.g. code style improvements, linting)
- [x] Documentation update
## How Has This Been Tested?
... | 2025-03-18T06:37:57Z | Pinecone as Vector DB
### 🚀 The feature
Pinecone as a vector database for the MEM0 project can help efficiently store and retrieve high-dimensional embeddings.
### Motivation, pitch
This gives more flexibility to the user to use Pinecone database as a vectordb. | @Dev-Khant I can pick this up if this is on your timeline.
Yes, please feel free to work on it.
Will make a PR once done. | [
{
"body": "### 🚀 The feature\n\nPinecone as a vector database for the MEM0 project can help efficiently store and retrieve high-dimensional embeddings.\n\n### Motivation, pitch\n\nThis gives more flexibility to the user to use Pinecone database as a vectordb.",
"number": 2385,
"title": "Pinecone as Vec... | 66d3f9b93ca530c873dfbe74311ec00d6a09aa0b | {
"head_commit": "28197762203371149c1ae3ea18835ef09318bbbf",
"head_commit_message": "Refactor and Formatting",
"patch_to_review": "diff --git a/Makefile b/Makefile\nindex 2d3763d252..3fb584f3bb 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -13,7 +13,7 @@ install:\n install_all:\n \tpoetry install\n \tpoetry run pip ... | [
{
"diff_hunk": "@@ -24,17 +24,17 @@ class OutputData(BaseModel):\n class PineconeDB(VectorStoreBase):\n def __init__(\n self,\n- collection_name: str,\n- embedding_model_dims: int,\n- client: Optional[\"Pinecone\"] = None,\n- api_key: Optional[str] = None,\n- envir... | 589adb6782af237047f21c66c7af9456267d5c9d | diff --git a/Makefile b/Makefile
index 2d3763d252..3fb584f3bb 100644
--- a/Makefile
+++ b/Makefile
@@ -13,7 +13,7 @@ install:
install_all:
poetry install
poetry run pip install groq together boto3 litellm ollama chromadb weaviate weaviate-client sentence_transformers vertexai \
- google-gen... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
mem0ai__mem0-2266@28dd765 | mem0ai/mem0 | Python | 2,266 | Add config option for vertex embedding tasks | ## Description
__Feature__
The feature provides users with multiple options for embedding tasks in Vertex AI, and modifies `EmbeddingBase.embed` to include the memory action that triggered the function call.
__Motivation__
Vertex AI offers multiple options for embedding tasks, allowing the extraction of t... | 2025-02-27T04:51:48Z | Add multiple options for vertex ai embedding tasks
### 🚀 The feature
The feature will provide users with multiple options for embedding tasks of Vertex AI.
### Motivation, pitch
Vertex AI offers multiple options for embedding tasks, allowing the extraction of text embeddings for specific use cases, such as disting... | @Dev-Khant I would like to contribute this feature. Could you please assign this to me?
Hey @rst0070 Great. Feel free to work on it. | [
{
"body": "### 🚀 The feature\n\nThe feature will provide users with multiple options for embedding tasks of Vertex AI. \n\n### Motivation, pitch\n\nVertex AI offers multiple options for embedding tasks, allowing the extraction of text embeddings for specific use cases, such as distinguishing between a \"retrie... | 8d07469ba7cb69aad95d46cecc9fc7956c7e41e8 | {
"head_commit": "28dd7655d2f20a217191ec9eda685fb71315ddae",
"head_commit_message": "Add test",
"patch_to_review": "diff --git a/docs/components/embedders/config.mdx b/docs/components/embedders/config.mdx\nindex a5ad8fa049..82756e2034 100644\n--- a/docs/components/embedders/config.mdx\n+++ b/docs/components/embed... | [
{
"diff_hunk": "@@ -58,6 +58,9 @@ Here's a comprehensive list of all parameters that can be used across different\n | `azure_kwargs` | Key-Value arguments for the AzureOpenAI embedding model |\n | `openai_base_url` | Base URL for OpenAI API | OpenAI |\n | `vertex_credentials_... | 049b115e70fd3c926222f4122eb7c0ac6900de9b | diff --git a/docs/components/embedders/config.mdx b/docs/components/embedders/config.mdx
index a5ad8fa049..91e7259a36 100644
--- a/docs/components/embedders/config.mdx
+++ b/docs/components/embedders/config.mdx
@@ -57,7 +57,10 @@ Here's a comprehensive list of all parameters that can be used across different
| `model_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-4580@6a601de | kedro-org/kedro | Python | 4,580 | Improve error handling for Custom Datasets | ## Description
Resolves https://github.com/kedro-org/kedro/issues/4577
Before the fix; if there were errors such as import errors in your custom dataset, you got the following error message
```
DatasetError: An exception occurred when parsing config for dataset 'reporting.cancellation_policy_grid':
Class 'demo... | 2025-03-17T17:01:16Z | Importing custom kedro catalog with missing dependency suppreses missing library import error traceback
## Description
When importing catalog class (e.g., `MyCustomDataset`) kedro suppresses import traceback in case the class dependencies are missing. If the user has the mentioned class but it relies on some other libs... | As I look at the implementation, this comment in `core:_load_obj` doesn't seem valid
```
# ModuleNotFoundError: When `load_obj` can't find `mod_path` (e.g `kedro.io.pandas`)
# this is because we try a combination of all prefixes.
# AttributeError: When `load_obj` manages to load `mod_path` but it ... | [
{
"body": "## Description\nWhen importing catalog class (e.g., `MyCustomDataset`) kedro suppresses import traceback in case the class dependencies are missing. If the user has the mentioned class but it relies on some other libs that were not installed, the user will never know but will get the misleading error... | 769629fb23c19a7629ee8b1ae97940665d6d57bf | {
"head_commit": "6a601deff6e16a5f9c0d1637c7dea098c17df1e4",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/.secrets.baseline b/.secrets.baseline\nindex cbacd9f01c..43586daf06 100644\n--- a/.secrets.baseline\n+++ b/.secrets.baseline\n@@ -206,7 +206,7 @@\n \"filename\": \"tests/io/tes... | [
{
"diff_hunk": "@@ -587,21 +588,28 @@ def parse_dataset_definition(\n class_paths = (prefix + dataset_type for prefix in _DEFAULT_PACKAGES)\n \n for class_path in class_paths:\n- tmp = _load_obj(class_path)\n+ tmp, warning = _load_obj(\n+ class_path\n+ ... | 550e29334ff356c8463dc1e4e3361fd8051d71bc | diff --git a/.secrets.baseline b/.secrets.baseline
index cbacd9f01c..07707f56eb 100644
--- a/.secrets.baseline
+++ b/.secrets.baseline
@@ -206,7 +206,7 @@
"filename": "tests/io/test_data_catalog.py",
"hashed_secret": "15dd2c9ccec914f1470b4dccb45789844e49cf70",
"is_verified": false,
- "... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mem0ai__mem0-2068@e17717b | mem0ai/mem0 | Python | 2,068 | fix VectorStoreBase abstract methods params | ## Description
Fixes #2067
## Type of change
Please delete options that are not relevant.
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as ... | 2024-12-02T09:52:33Z | input params of VectorStoreBase abstract class methods is wrong
### 🐛 Describe the bug
for example:
``` python
@abstractmethod
def insert(self, name, vectors, payloads=None, ids=None):
"""Insert vectors into a collection."""
pass
```
but acutal implemention is:
```python
def ins... | [
{
"body": "### 🐛 Describe the bug\r\n\r\nfor example:\r\n``` python\r\n @abstractmethod\r\n def insert(self, name, vectors, payloads=None, ids=None):\r\n \"\"\"Insert vectors into a collection.\"\"\"\r\n pass\r\n```\r\nbut acutal implemention is:\r\n```python\r\n def insert(self, vectors... | dd06333732d652388d8f9c5f56afb6f9955552d6 | {
"head_commit": "e17717b5c96f9d3278c1ab9e9709dca19d84a015",
"head_commit_message": "fix VectorStoreBase abstract methods params",
"patch_to_review": "diff --git a/mem0/vector_stores/base.py b/mem0/vector_stores/base.py\nindex 21f47f3a09..48ae8334bf 100644\n--- a/mem0/vector_stores/base.py\n+++ b/mem0/vector_stor... | [
{
"diff_hunk": "@@ -3,32 +3,32 @@\n \n class VectorStoreBase(ABC):\n @abstractmethod\n- def create_col(self, name, vector_size, distance):\n+ def create_col(self, vector_size, distance):",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "mem0/vector_stores/base.p... | 9edf26fab94e33a2425451c705e9c54b78dc38c8 | diff --git a/mem0/vector_stores/base.py b/mem0/vector_stores/base.py
index 21f47f3a09..db62c57294 100644
--- a/mem0/vector_stores/base.py
+++ b/mem0/vector_stores/base.py
@@ -8,27 +8,27 @@ def create_col(self, name, vector_size, distance):
pass
@abstractmethod
- def insert(self, name, vectors, payloa... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} | |
mindsdb__mindsdb-8429@a9889fc | mindsdb/mindsdb | Python | 8,429 | Moving MySQL driver to use autocommit | This changes the MySQL integration to use autocommit. This fixes #7234. The rationale in that ticket is that python errors, if caught, could lead to dangling open transactions with unexpected results. This concern is valid. If we need transactions we should provide a context manager for them so that exiting the conte... | 2023-11-27T04:57:29Z | [mysql-integration] Enable autocommit
### Short description and motivation for the proposed feature
Currently, when a MySQL query succeeds a commit is made explicitly, and when a query fails a rollback is made. Autocommit is not disabled explicitly, but it's disabled by default by all Python MySQL modules.
Using au... | Looking at this, I am wondering if it would make sense to make sure we have a context manager available so that if someone wants to do multiple statements in a transaction a `with` clause can be used for that. And then without that, autocommit would be enabled.
I'll leave to @ZoranPandovski to decide if supporting tra... | [
{
"body": "### Short description and motivation for the proposed feature\n\nCurrently, when a MySQL query succeeds a commit is made explicitly, and when a query fails a rollback is made. Autocommit is not disabled explicitly, but it's disabled by default by all Python MySQL modules.\r\n\r\nUsing autocommit is b... | 1b16044626159dd8322c60073a59cf106f65918a | {
"head_commit": "a9889fca63e569dce292c968148661328917e081",
"head_commit_message": "Moving MySQL driver to use autocommit\n\nThis changes the MySQL integration to use autocommit. This fixes #7234.\nThe rationale in that ticket is that python errors, if caught, could\nlead to dangling open transactions with unexpec... | [
{
"diff_hunk": "@@ -136,8 +136,20 @@ def test_create_table(self, handler):\n tables = self.get_table_names(handler)\n assert new_table in tables, f\"expected to have {new_table} in database, but got: {tables}\"\n \n+ def test_insert_table(self, handler):\n+ tablename = \"test_mdb\"\n+ ... | c0f60f9b2e32f6d329871e007036f47dc83e2a84 | diff --git a/mindsdb/integrations/handlers/mysql_handler/mysql_handler.py b/mindsdb/integrations/handlers/mysql_handler/mysql_handler.py
index b732f99686f..daf94e7ab49 100644
--- a/mindsdb/integrations/handlers/mysql_handler/mysql_handler.py
+++ b/mindsdb/integrations/handlers/mysql_handler/mysql_handler.py
@@ -1,3 +1,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mem0ai__mem0-1965@081481c | mem0ai/mem0 | Python | 1,965 | Implemented Gemini (#1490) | ## Description
Added support for Gemini using `google-generativeai` module. (sorry it took so long 👍)
Fixes #1490
## Type of change
- [✅] New feature (non-breaking change which adds functionality)
- [✅] Documentation update
## How Has This Been Tested?
Also added unit test for Gemini in `tests/llms... | 2024-10-16T11:41:32Z | Gemini Support?
### 🚀 The feature
Add support for Google's Gemini.
### Motivation, pitch
I would like to use this in the ongoing Gemini API developer competition in which I'm making a pretty straight-forward agentic AI for Windows. Upon discovering this, I believed it would be useful to me, but then I realized that... | Hi @into-the-night, We do support Gemini in Embedchain: https://docs.embedchain.ai/components/llms#google-ai.
Do you need Gemini support for Mem0?
Yes, yes for mem0. That's what I was trying to make the issue about.
Alright, so for now you can use Gemini models from [Litellm](https://docs.mem0.ai/llms#litellm). I'll... | [
{
"body": "### 🚀 The feature\n\nAdd support for Google's Gemini.\n\n### Motivation, pitch\n\nI would like to use this in the ongoing Gemini API developer competition in which I'm making a pretty straight-forward agentic AI for Windows. Upon discovering this, I believed it would be useful to me, but then I real... | b6f9054567d8537bd5c16d4a3142d9f102333402 | {
"head_commit": "081481c6d202d598125e5ff25170f14ee5b273cd",
"head_commit_message": "Merge pull request #1 from mem0ai/main\n\nmerge main from mem0ai/mem0",
"patch_to_review": "diff --git a/docs/components/llms/models/gemini.mdx b/docs/components/llms/models/gemini.mdx\nnew file mode 100644\nindex 0000000000..f02... | [
{
"diff_hunk": "@@ -22,6 +22,7 @@ openai = \"^1.33.0\"\n posthog = \"^3.5.0\"\n pytz = \"^2024.1\"\n sqlalchemy = \"^2.0.31\"\n+google-generativeai = \"^0.8.3\"",
"line": null,
"original_line": 25,
"original_start_line": null,
"path": "pyproject.toml",
"start_line": null,
"text": "@user1... | 29881ca27bb2b7ace841dedb45ed7c099c4b9329 | diff --git a/docs/components/llms/models/gemini.mdx b/docs/components/llms/models/gemini.mdx
new file mode 100644
index 0000000000..f020a2dd23
--- /dev/null
+++ b/docs/components/llms/models/gemini.mdx
@@ -0,0 +1,33 @@
+---
+title: Gemini
+---
+
+To use Gemini model, you have to set the `GEMINI_API_KEY` environment var... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-4556@5af3250 | kedro-org/kedro | Python | 4,556 | Rename instances of `extra_params` and `_extra_params` to `runtime_params` | ## Description
Resolves #4525
## Development notes
- Renamed all instances of `extra_params` in `KedroSession` and `PipelineSpecs` to `runtime_params`
- Renamed all instances of `_extra_params` to `runtime_params` in `KedroContext`
- Updated tests
- Updated release note and migration guide
## Develope... | 2025-03-10T23:59:11Z | Kedro: Rename all params (extra_params, _extra_params) to runtime_params
## Description
To be consistent with naming `params`, we will rename instances of `extra_params`, `_extra_params` to `runtime_params` across the codebase
**NOTE:** This ticket is planned as part of kedro 1.0. It needs to go in `develop` branch
... | This ticket is on hold for - https://github.com/kedro-org/kedro/issues/4475 to complete
@ravi-kumar-pilla why is it blocked by #4475? I'm expecting that to be quite a big refactoring and this rename shouldn't be so complex right?
> [@ravi-kumar-pilla](https://github.com/ravi-kumar-pilla) why is it blocked by [#4475](ht... | [
{
"body": "## Description\n\nTo be consistent with naming `params`, we will rename instances of `extra_params`, `_extra_params` to `runtime_params` across the codebase\n\n**NOTE:** This ticket is planned as part of kedro 1.0. It needs to go in `develop` branch\n\n## Context\n\nWe have the below terminology and ... | 8cb3f1c40ceb926c32003dc78e53bde690ee18fb | {
"head_commit": "5af325040a0d456d78fde1af09857ca095a6ecb2",
"head_commit_message": "Merge branch 'develop' into chore/rename-params",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex b051d085c3..d82bc15050 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -7,6 +7,7 @@\n \n ## Breaking changes to the ... | [
{
"diff_hunk": "@@ -173,7 +173,7 @@ class KedroContext:\n env: str | None = field(init=True)\n _package_name: str = field(init=True)\n _hook_manager: PluginManager = field(init=True)\n- _extra_params: dict[str, Any] | None = field(\n+ runtime_params: dict[str, Any] | None = field(",
"line"... | 9789857eb58b94cd304294f3da4719d9b67cafca | diff --git a/RELEASE.md b/RELEASE.md
index b051d085c3..d82bc15050 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -7,6 +7,7 @@
## Breaking changes to the API
* Private methods `_is_project` and `_find_kedro_project` are changed to `is_kedro_project` and `find_kedro_project`.
+* Renamed instances of `extra_params` and `... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
mindsdb__mindsdb-8268@25d06ad | mindsdb/mindsdb | Python | 8,268 | Added Dependencies for ChromaDB to Docker | ## Description
This PR adds the dependencies for the ChromaDB handler to Docker image.
Fixes https://github.com/mindsdb/mindsdb/issues/8267
## Type of change
- [X] ⚡ New feature (non-breaking change which adds functionality)
## Verification Process
To ensure the changes are working as expected:
- ... | 2023-11-03T13:22:51Z | [Bug]: ChromaDB Dependencies Missing in Docker
### Short description of current behavior
The ChromaDB handler is not functional in Docker due to the missing the `chromadb` and `pysqlite3-binary` dependencies.
### Video or screenshots
_No response_
### Expected behavior
_No response_
### How to reproduce the error... | [
{
"body": "### Short description of current behavior\n\nThe ChromaDB handler is not functional in Docker due to the missing the `chromadb` and `pysqlite3-binary` dependencies.\n\n### Video or screenshots\n\n_No response_\n\n### Expected behavior\n\n_No response_\n\n### How to reproduce the error\n\n_No response... | 8ad2e92d3a896dfacfb4d2db8fb31a069400016f | {
"head_commit": "25d06ada5ca2a462bbcbdc0123b02beba862d22d",
"head_commit_message": "added the dependencies for the ChromaDB handler to the Docker image",
"patch_to_review": "diff --git a/docker/release b/docker/release\nindex d532cda51d6..463655796eb 100644\n--- a/docker/release\n+++ b/docker/release\n@@ -107,7 ... | [
{
"diff_hunk": "@@ -107,7 +107,8 @@ RUN python -m pip install --prefer-binary --no-cache-dir --upgrade pip==23.1.2 &\n pip install --prefer-binary --no-cache-dir 'weaviate-client~=3.24.2' || true && \\\n pip install --prefer-binary --no-cache-dir 'pgvector' || true && \\\n pip install --prefer-binar... | b49ef408c428f7e077ab59d0eec64a417e9b29d5 | diff --git a/docker/release b/docker/release
index d532cda51d6..4263187a7e7 100644
--- a/docker/release
+++ b/docker/release
@@ -107,7 +107,8 @@ RUN python -m pip install --prefer-binary --no-cache-dir --upgrade pip==23.1.2 &
pip install --prefer-binary --no-cache-dir 'weaviate-client~=3.24.2' || true && \
pi... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
mem0ai__mem0-815@ac33ddd | mem0ai/mem0 | Python | 815 | Unstructured File Loader Support - USF | ## Description
I have added UnstructuredFileLoader for handling unstrcutured content. datatype: USF
Fixes # (issue)
## Type of change
- [* ] New feature
## How Has This Been Tested?
I have tested it in my APP.
## Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have... | 2023-10-17T17:17:12Z | UnstructuredFileLoader to Support .txt Files
### 🚀 The feature
In order to enhance the flexibility and usability of EmbedChain, it would be beneficial to introduce an UnstructuredFileLoader that can handle .txt files. This feature would allow users to easily import and work with unstructured text data within the Embe... | [
{
"body": "### 🚀 The feature\n\nIn order to enhance the flexibility and usability of EmbedChain, it would be beneficial to introduce an UnstructuredFileLoader that can handle .txt files. This feature would allow users to easily import and work with unstructured text data within the EmbedChain environment.\r\n\... | c8846e0e932bdc6fd26b51abd3318ce276ec9858 | {
"head_commit": "ac33ddd60162313b7c512b18b4f4d81dd45f4c53",
"head_commit_message": "Update README.md",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 7ed2ffeea8..427d58c226 100644\n--- a/README.md\n+++ b/README.md\n@@ -47,7 +47,8 @@ Embedchain empowers you to create ChatGPT like apps, on your own ... | [
{
"diff_hunk": "@@ -77,6 +79,7 @@ def _get_loader(self, data_type: DataType, config: LoaderConfig) -> BaseLoader:\n DataType.CSV: CsvLoader,\n DataType.MDX: MdxLoader,\n DataType.IMAGES: ImagesLoader,\n+ DataType.UNSTRUCTURED: UnstructuredLoader",
"line": null,... | 78974c5dd3917f3495f9f14c2b5b6002531a6afb | diff --git a/README.md b/README.md
index 7ed2ffeea8..427d58c226 100644
--- a/README.md
+++ b/README.md
@@ -47,7 +47,8 @@ Embedchain empowers you to create ChatGPT like apps, on your own dynamic dataset
* Doc file
* JSON file
* Code documentation website loader
-* Notion and many more.
+* Notion
+* Unstructured file ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
mem0ai__mem0-841@a30ff5c | mem0ai/mem0 | Python | 841 | [Feature] GMAIL Loader | ## Description
This adds the ability to load gmail data into the app.
Fixes # ([338](https://github.com/embedchain/embedchain/issues/338))
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix ... | 2023-10-23T18:04:08Z | add support for email request
### 🚀 The feature
For emails, you should figure out how to import and understand .mbox files. Gmail allows you to export all your emails in one go and exports them in .mbox format
### Motivation, pitch
- opened on behalf of user Kushal from whatsapp
### Alternatives
_No res... | [
{
"body": "### 🚀 The feature\r\n\r\nFor emails, you should figure out how to import and understand .mbox files. Gmail allows you to export all your emails in one go and exports them in .mbox format\r\n\r\n### Motivation, pitch\r\n\r\n- opened on behalf of user Kushal from whatsapp\r\n\r\n### Alternatives\r\n\r... | 78ec91a3a9135280c5168e7e4a0def15a3393976 | {
"head_commit": "a30ff5cc8cefe786a40c302260fe69bceaa49811",
"head_commit_message": "code clean up",
"patch_to_review": "diff --git a/.gitignore b/.gitignore\nindex b6df6ac072..b0b048ace7 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -176,3 +176,8 @@ notebooks/*.yaml\n .ipynb_checkpoints/\n \n !configs/*.yaml\n+... | [
{
"diff_hunk": "@@ -0,0 +1,35 @@\n+---\n+title: '📬 GMAIL'",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "docs/data-sources/gmail.mdx",
"start_line": null,
"text": "@user1:\n```suggestion\r\ntitle: '📬 Gmail'\r\n```"
},
{
"diff_hunk": "@@ -0,0 +1,124 @@... | b9bd51d065117dca397cb502470c14e867bc0bf6 | diff --git a/docs/data-sources/gmail.mdx b/docs/data-sources/gmail.mdx
new file mode 100644
index 0000000000..4c0dbfbf26
--- /dev/null
+++ b/docs/data-sources/gmail.mdx
@@ -0,0 +1,35 @@
+---
+title: '📬 Gmail'
+---
+
+To use GmailLoader you must install the extra dependencies with `pip install --upgrade embedchain[gmai... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
kedro-org__kedro-4353@a990155 | kedro-org/kedro | Python | 4,353 | Refactor run methods more into abstract method | ## Description
Resolves #4290
## Development notes
- Refactored and merged logic of the various `_run` method implementations into the abstract `_run` method.
- Added abstract `_get_executor` method, implemented by each runner.
- Refactored logic to determine number of workers from `ParallelRunner` and `Thread... | 2024-11-26T15:00:34Z | Abstract `_run` as much as possible
## Description
The `_run()` method implementation in the various runners is very similar. We can refactor this to be even more similar so we can move all common code into the `_run()` in the `AbstractRunner`.
## Context
This will make it easier for people to implement a custom r... | [
{
"body": "## Description\r\nThe `_run()` method implementation in the various runners is very similar. We can refactor this to be even more similar so we can move all common code into the `_run()` in the `AbstractRunner`.\r\n\r\n## Context\r\nThis will make it easier for people to implement a custom runner, be... | 50e0cb57d0ca7581c69d9c0cad2367935c8ab969 | {
"head_commit": "a990155f2e3fb70a0bcc8d6d066f5e77745adcf6",
"head_commit_message": "Address review comments\n\nSigned-off-by: Merel Theisen <merel.theisen@quantumblack.com>",
"patch_to_review": "diff --git a/kedro/runner/parallel_runner.py b/kedro/runner/parallel_runner.py\nindex 4f20295285..99390e144f 100644\n-... | [
{
"diff_hunk": "@@ -189,14 +172,17 @@ def _get_required_workers_count(self, pipeline: Pipeline) -> int:\n \n return min(required_processes, self._max_workers)\n \n+ def _get_executor(self, max_workers: int) -> ProcessPoolExecutor:",
"line": null,
"original_line": 175,
"original_start_line... | be2e2850678e66ec3dfa3b284df80edf332b36ca | diff --git a/kedro/runner/parallel_runner.py b/kedro/runner/parallel_runner.py
index 4f20295285..4dba5fc774 100644
--- a/kedro/runner/parallel_runner.py
+++ b/kedro/runner/parallel_runner.py
@@ -4,11 +4,7 @@
from __future__ import annotations
-import os
-import sys
-from collections import Counter
-from concurrent... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
mem0ai__mem0-618@bcd73b5 | mem0ai/mem0 | Python | 618 | allow_reset as constructor argument | ## Description
Set `allow_reset` as constructor argument in ChromadbConfig.
Fixes #608
## Type of change
Please delete options that are not relevant.
- [x] New feature (non-breaking change which adds functionality)
## How Has This Been Tested?
- [x] Unit Test
## Checklist:
- [x] My code foll... | 2023-09-14T05:03:52Z | feature request: `allow_reset` as a constructor argument for `ChromaDbConfig`
### 🚀 The feature
Currently we throw
```
ValueError: For safety reasons, resetting is disabled.Please enable it by including `chromadb_settings={"allow_reset": True}` in your ChromaDbConfig`.
```
It's debatable whether we need this... | Can I pick it up @cachho?
> Can I pick it up @cachho?
yes
Just make sure to update the actual code, tests and the error message
> Just make sure to update the actual code, tests and the error message
Yes | [
{
"body": "### 🚀 The feature\r\n\r\nCurrently we throw \r\n```\r\nValueError: For safety reasons, resetting is disabled.Please enable it by including `chromadb_settings={\"allow_reset\": True}` in your ChromaDbConfig`.\r\n```\r\n\r\nIt's debatable whether we need this safety mechanism at all.\r\n\r\nBut either... | a662b2a6c6b3cef8d17f14b2bc669f8060cbaf45 | {
"head_commit": "bcd73b58c16267c2c0d9a6feefcb7d5f940ba30f",
"head_commit_message": "allow_reset as constructor argument",
"patch_to_review": "diff --git a/embedchain/config/vectordbs/ChromaDbConfig.py b/embedchain/config/vectordbs/ChromaDbConfig.py\nindex a1b32559cd..31d3e3c7d8 100644\n--- a/embedchain/config/ve... | [
{
"diff_hunk": "@@ -27,9 +28,10 @@ def __init__(\n :type port: Optional[str], optional\n :param chroma_settings: Chroma settings dict, defaults to None\n :type chroma_settings: Optional[dict], optional\n+ :param allow_reset: Resets the database. defaults to False",
"line": 29,... | 0a4482883931a18e1171d2f0465e908be2f60998 | diff --git a/embedchain/config/vectordbs/ChromaDbConfig.py b/embedchain/config/vectordbs/ChromaDbConfig.py
index a1b32559cd..2dddadbd4f 100644
--- a/embedchain/config/vectordbs/ChromaDbConfig.py
+++ b/embedchain/config/vectordbs/ChromaDbConfig.py
@@ -12,6 +12,7 @@ def __init__(
dir: Optional[str] = None,
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
mem0ai__mem0-605@f7cf6f9 | mem0ai/mem0 | Python | 605 | Fix/dont print the entire text when data type is text | ## Description
Make data (src) in print statement which is longer than 50 characters to be shortened with ellipsis
Fixes #602
##Bug
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
## How Has This Been Tested?
Tested the function
Please descr... | 2023-09-13T00:10:49Z | dont print the entire text when data type is text
### 🐛 Describe the bug
When we are adding a data type "text", the entire text gets printed due to the below statement.
we can either skip printing text altogether or print part of it.
print(f"All data from {src} already exists in the database.") | Could this be assigned to me?
Hey @dtee1 welcome to embedchain.
Yeah sure. Just assigned. | [
{
"body": "### 🐛 Describe the bug\n\nWhen we are adding a data type \"text\", the entire text gets printed due to the below statement. \r\n\r\nwe can either skip printing text altogether or print part of it.\r\n\r\nprint(f\"All data from {src} already exists in the database.\")",
"number": 602,
"title"... | 701d0b21ef5a0516004e6cf4cc81806cb92f2188 | {
"head_commit": "f7cf6f9969d977f64055d536d627af2aec063df6",
"head_commit_message": "Minor fix",
"patch_to_review": "diff --git a/embedchain/embedchain.py b/embedchain/embedchain.py\nindex d6364b5b49..188429f715 100644\n--- a/embedchain/embedchain.py\n+++ b/embedchain/embedchain.py\n@@ -283,7 +283,10 @@ def load_... | [
{
"diff_hunk": "@@ -380,7 +383,10 @@ def load_and_embed_v2(\n data_dict = {id: value for id, value in data_dict.items() if id not in existing_ids}\n \n if not data_dict:\n- print(f\"All data from {src} already exists in the database.\")\n+ srcCopy = src",
... | 545009a3ea6a12dbd07f5d9e997cf5b52c4c038d | diff --git a/embedchain/embedchain.py b/embedchain/embedchain.py
index d6364b5b49..89dc2e94e9 100644
--- a/embedchain/embedchain.py
+++ b/embedchain/embedchain.py
@@ -283,7 +283,10 @@ def load_and_embed(
data_dict = {id: value for id, value in data_dict.items() if id not in existing_ids}
if ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
kedro-org__kedro-4497@07cc57d | kedro-org/kedro | Python | 4,497 | [DOC] dynamic session loading in non jupyter environments (marimo, python scripts, streamlit) | ## Description
As discussed in #4440 currently kedro users that decide to not use jupyter for exploration cannot dynamically load their kedro config (catalog, credentials, etc) as those non jupyter environments lack the `%` magic commands that kedro currently relies on for its ipython/jupyter integration
This PR ... | 2025-02-18T17:28:21Z | `kedro marimo` + better programmatic setup for non jupyter/ipython envs
## Description
I'm frustrated by Kedro's heavy reliance on IPython magics (%reload_kedro) for notebook setup. While this works for Jupyter, it creates barriers for:
- Modern notebook interfaces like marimo that don't support IPython magics
- Script... | I read the thread in marimo but I cannot signup/login to Discord so I can only comment here.
The majority of the magic function is making sure the root path is set correctly. They are not too important in the context of using absolute path but as Python cares where do you actually execute the command from.
The functi... | [
{
"body": "## Description\nI'm frustrated by Kedro's heavy reliance on IPython magics (%reload_kedro) for notebook setup. While this works for Jupyter, it creates barriers for:\n- Modern notebook interfaces like marimo that don't support IPython magics\n- Script-based workflows where magics aren't available, th... | 565aaa7ed1d6b31bbde623905c7c1956708ea14d | {
"head_commit": "07cc57dce0c3380be40a9d0b0549e54df7493cee",
"head_commit_message": "added item to release.md\n\nSigned-off-by: lucharo <luis@merqato.eu>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex e974dd5bcc..348465111e 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -6,6 +6,7 @@\n \n ## Bug... | [
{
"diff_hunk": "@@ -0,0 +1,36 @@\n+# How to use Kedro from Marimo and non-Jupyter environments\n+\n+This guide explains how to set up Kedro programmatically without relying on IPython magics, making it compatible with non-Jupyter environments (python scripts or streamlit apps) and modern notebook interfaces lik... | 7c2b7124dd45cd38a1308ecb9e2152cc9af27fc6 | diff --git a/.github/styles/Kedro/ignore-names.txt b/.github/styles/Kedro/ignore-names.txt
index 2731d1b139..a37dd7d1b7 100644
--- a/.github/styles/Kedro/ignore-names.txt
+++ b/.github/styles/Kedro/ignore-names.txt
@@ -16,6 +16,7 @@ Carvalho
Cvetanka
Czakon
Chan
+Chaves
Comym
Couto
da
diff --git a/.github/styles/... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
mindsdb__mindsdb-8245@8bfef7c | mindsdb/mindsdb | Python | 8,245 | modify get_api_key util function and affected handlers | ## Description
Please include a summary of the change and the issue it solves.
Fixes #7496
## Type of change
(Please delete options that are not relevant)
- [ ] 🐛 Bug fix (non-breaking change which fixes an issue)
## Checklist:
- [ ] My code follows the style guidelines(PEP 8) of MindsDB.
- [ ]... | 2023-11-01T18:57:35Z | [refactor] Modify `get_api_key` to always check integration name in field
Currently, `mindsdb.integrations.utilities.handler_utils.get_api_key` checks for the parameter `api_name` only in the env variable and config file. We should modify its behavior so that it also checks for f`{integration_name}_api_key` in model cr... | [
{
"body": "Currently, `mindsdb.integrations.utilities.handler_utils.get_api_key` checks for the parameter `api_name` only in the env variable and config file. We should modify its behavior so that it also checks for f`{integration_name}_api_key` in model creation and engine creation time arguments. This will en... | 1c9e166322a0c8b65026fc6c4e9b53697e25a3b1 | {
"head_commit": "8bfef7cbc7536a4d7537de8b77a32d0685c0f45c",
"head_commit_message": "corrected error message",
"patch_to_review": "diff --git a/docs/integrations/ai-engines/anthropic.mdx b/docs/integrations/ai-engines/anthropic.mdx\nindex d15edbe7c69..60a61dd24d5 100644\n--- a/docs/integrations/ai-engines/anthrop... | [
{
"diff_hunk": "@@ -49,6 +49,6 @@ def get_api_key(\n \n if strict:\n raise Exception(\n- 'Missing API key \"api_key\". Either re-create this ML_ENGINE specifying the `api_key` parameter, or re-create this model and pass the API key with `USING` syntax.'\n+ \"Missing API key f'\... | 7a7150bf9b99ccd667c43e81735e5b4e1938130e | diff --git a/1.35.0 b/1.35.0
new file mode 100644
index 00000000000..2ac00a80c4b
--- /dev/null
+++ b/1.35.0
@@ -0,0 +1,67 @@
+Collecting google-cloud-aiplatform
+ Downloading google_cloud_aiplatform-1.39.0-py2.py3-none-any.whl.metadata (28 kB)
+Requirement already satisfied: google-api-core!=2.0.*,!=2.1.*,!=2.2.*,!=2.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
mem0ai__mem0-448@7321cf4 | mem0ai/mem0 | Python | 448 | feat: system prompt | ## Description
Allow passing of a system prompt.
Fixes #443
## Type of change
Please delete options that are not relevant.
- [X] New feature (non-breaking change which adds functionality)
## How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructio... | 2023-08-15T18:42:56Z | Add support to pass system prompt
### 🚀 The feature
OpenAI supports passing system prompt. We need to add support for this in embedchain
### Motivation, pitch
System prompts help in better controlling the persona of the bot.
### Alternatives
_No response_
### Additional context
_No response_ | [
{
"body": "### 🚀 The feature\n\nOpenAI supports passing system prompt. We need to add support for this in embedchain\n\n### Motivation, pitch\n\nSystem prompts help in better controlling the persona of the bot.\n\n### Alternatives\n\n_No response_\n\n### Additional context\n\n_No response_",
"number": 443,... | 28e06be26f7b3ece8de31103752a6b78f17bdc6a | {
"head_commit": "7321cf445f6954be2c6f08571c9f05931621cfb6",
"head_commit_message": "docs: added system_prompt",
"patch_to_review": "diff --git a/docs/advanced/query_configuration.mdx b/docs/advanced/query_configuration.mdx\nindex 6ab51d3dc4..23f47815b8 100644\n--- a/docs/advanced/query_configuration.mdx\n+++ b/d... | [
{
"diff_hunk": "@@ -133,15 +133,18 @@ def _get_azure_openai_answer(prompt: str, config: ChatConfig) -> str:\n if config.top_p and config.top_p != 1:\n logging.warning(\"Config option `top_p` is not supported by this model.\")\n \n- messages = CustomApp._get_messages(prompt)\n+ ... | f6201cc3f7560d94c3681a2f81edb9a9449cf27f | diff --git a/docs/advanced/configuration.mdx b/docs/advanced/configuration.mdx
index 8cafe6a02a..baf5a9f7fa 100644
--- a/docs/advanced/configuration.mdx
+++ b/docs/advanced/configuration.mdx
@@ -68,7 +68,7 @@ einstein_chat_template = Template("""
Human: $query
Albert Einstein:""")
-query_config = Qu... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
kedro-org__kedro-4030@1769be6 | kedro-org/kedro | Python | 4,030 | Fix `OmegaConfigLoader` __repr__ and missing keys method | ## Description
<!-- Why was this PR created? -->
Fix #3618, since we are trying to improve the interactive experience. While it's still a bit unclear as `AbstractConfigLoader` inherit from `UserDict`, `OmegaConfigLoader` only presents traits for dictionary access pattern, i.e. dict["key"], but not the other API such... | 2024-07-25T09:36:35Z | OmegaConfigLoader's `__repr__` is not implemented correctly, and it does not behave similar to a `UserDict`
## Description
<!-- Short description of the problem here. -->
Currently, `base_env` and `default_run_env` is not included in the `__repr__`.
When it is printed, it shows something like this
> In [11]: c
... | [
{
"body": "## Description\r\n<!-- Short description of the problem here. -->\r\nCurrently, `base_env` and `default_run_env` is not included in the `__repr__`.\r\n\r\nWhen it is printed, it shows something like this\r\n\r\n> In [11]: c\r\n> Out[11]: OmegaConfigLoader(conf_source=/Users/Nok_Lam_Chan/dev/kedro-ins... | fd17607434b8037aa6d19a73bcd1659f1f74c709 | {
"head_commit": "1769be68d731e59f2be3e20ae8a8d689f728f3db",
"head_commit_message": "linter is not happy about this\n\nSigned-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex cc8b9032c9..cd1eb2b5ae 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@... | [
{
"diff_hunk": "@@ -77,6 +79,7 @@ Many thanks to the following Kedroids for contributing PRs to this release:\n * Fixed error handling message for malformed yaml/json files in OmegaConfigLoader.\n * Fixed a bug in `node`-creation allowing self-dependencies when using transcoding, that is datasets named like `na... | bc9827086bee74d59a4c3a53676025ec9b38a760 | diff --git a/RELEASE.md b/RELEASE.md
index cc8b9032c9..f3eeec104d 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -11,6 +11,8 @@
* Made [kedro-telemetry](https://github.com/kedro-org/kedro-plugins/tree/main/kedro-telemetry) a core dependency.
* Implemented dataset pretty printing.
* Implemented `DataCatalog` pretty prin... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
mindsdb__mindsdb-8701@2b62e60 | mindsdb/mindsdb | Python | 8,701 | 💎💎GEMini updated | ## Description
Please include a summary of the change and the issue it solves.
Fixes #8699
## Type of change
(Please delete options that are not relevant)
- [ ] 🐛 Bug fix (non-breaking change which fixes an issue)
- [x] ⚡ New feature (non-breaking change which adds functionality)
- [ ] 📢 Breaki... | 2024-01-27T09:41:24Z | Gemini Handler Updates
### Short description and motivation for the proposed feature
Add following features to gemini:
- vision mode
- prompt template mode
- embedding mode
- question with context
- question without context
- json struct
### Video or screenshots
_No response_
### Describe some possi... | [
{
"body": "### Short description and motivation for the proposed feature\r\n\r\nAdd following features to gemini:\r\n- vision mode\r\n- prompt template mode\r\n- embedding mode\r\n- question with context\r\n- question without context\r\n- json struct\r\n\r\n\r\n### Video or screenshots\r\n\r\n_No response_\r\n\... | 198b34e56a17e4ba1bcbba7dc061e7a1e13c14a6 | {
"head_commit": "2b62e607163586e1baecf89bee0af85180d5087a",
"head_commit_message": "flake8 done",
"patch_to_review": "diff --git a/mindsdb/integrations/handlers/google_gemini_handler/README.md b/mindsdb/integrations/handlers/google_gemini_handler/README.md\nindex 0944b2b829b..4c0a61846a0 100644\n--- a/mindsdb/in... | [
{
"diff_hunk": "@@ -6,35 +6,105 @@ Google Generative AI is a library that provides access to powerful language mode\n \n *Note:* Ensure you have the necessary API key for accessing the Google gen AI library. You can get your API key at https://makersuite.google.com/. \n \n+>> This Handler requires python>=3.9 t... | 0c3947e551f686b3a7add3d431c0fb9dba89f83e | diff --git a/mindsdb/integrations/handlers/google_gemini_handler/README.md b/mindsdb/integrations/handlers/google_gemini_handler/README.md
index 348fc461c2f..8767028b469 100644
--- a/mindsdb/integrations/handlers/google_gemini_handler/README.md
+++ b/mindsdb/integrations/handlers/google_gemini_handler/README.md
@@ -3,8... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
mindsdb__mindsdb-8015@8f7ab02 | mindsdb/mindsdb | Python | 8,015 | Add support for default vectorDB for Knowledge Base | ## Description
Allows user to create knowledge base without defining storage. By default, it will create in memory ChromaDB
continuing from https://github.com/mindsdb/mindsdb/pull/7886
How to test:
Using local mindsdb:
```
CREATE ML_ENGINE embedding FROM langchain_embedding;
CREATE MODEL cohere_embed... | 2023-10-23T16:21:12Z | [Bug]: ChromaDB in memory vectorDB doesn't work in cloud
### Short description of current behavior
It expects a full persistence path, not possible for user to know the path
### Video or screenshots
_No response_
### Expected behavior
User should be able to create an in memory database on cloud
### How to reprodu... | [
{
"body": "### Short description of current behavior\n\nIt expects a full persistence path, not possible for user to know the path\n\n### Video or screenshots\n\n_No response_\n\n### Expected behavior\n\nUser should be able to create an in memory database on cloud\n\n### How to reproduce the error\n\n_No respon... | 5a23ee85768c50dfa365bc33949e7f81d4c7ecd8 | {
"head_commit": "8f7ab027c5eb66f00a5706119de28045c6de59dd",
"head_commit_message": "only create in memory chroma for local runs and not cloud",
"patch_to_review": "diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml\nindex c585d58c1d9..1ef1e9b557c 100644\n--- a/.pre-commit-config.yaml\n+++ b/.pre-comm... | [
{
"diff_hunk": "@@ -1285,14 +1299,25 @@ def answer_create_kb(self, statement: CreateKnowledgeBase):\n embedding_model_id = model_record[\"model_record\"].id\n \n # search for the vector database table\n- if len(statement.storage.parts) < 2:\n+ if statement.storage and len(statement... | f91096acf79fa7f84816efb65f5dc7883ee4f042 | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index c585d58c1d9..1ef1e9b557c 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -4,12 +4,13 @@ repos:
rev: 22.3.0
hooks:
- id: black
- args: [--skip-string-normalization] #prevents conversion of single to double ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
mem0ai__mem0-545@9103b96 | mem0ai/mem0 | Python | 545 | Add dry_run to add() | ## Description
Added **dry_run** method to `add` in Embedchain class.
Fixes #399
## Type of change
Please delete options that are not relevant.
- [x] New feature (non-breaking change which adds functionality)
- [x] Documentation update
## How Has This Been Tested?
`poetry run pytest`
- [x] Uni... | 2023-09-04T09:35:50Z | feature request: `dry_run` for `add` method
### 🚀 The feature
A dry run method on add could show the chunks. This way you can make sure loader and chunker work as intended.
### Motivation, pitch
This way you have no cost when testing loaders.
### Alternatives
_No response_
### Additional context
It could be imp... | [
{
"body": "### 🚀 The feature\n\nA dry run method on add could show the chunks. This way you can make sure loader and chunker work as intended.\n\n### Motivation, pitch\n\nThis way you have no cost when testing loaders.\n\n### Alternatives\n\n_No response_\n\n### Additional context\n\nIt could be implemented in... | 79f5a1d0529eb288cabe92203687140b4899853d | {
"head_commit": "9103b96faf5321d9728fbfab4cb28219b0b18a03",
"head_commit_message": "return in dict format",
"patch_to_review": "diff --git a/docs/advanced/interface_types.mdx b/docs/advanced/interface_types.mdx\nindex cc775a1528..41332a97b6 100644\n--- a/docs/advanced/interface_types.mdx\n+++ b/docs/advanced/int... | [
{
"diff_hunk": "@@ -133,13 +133,13 @@ def add(\n data_formatter = DataFormatter(data_type, config)\n self.user_asks.append([source, data_type.value, metadata])\n documents, _metadatas, _ids, new_chunks = self.load_and_embed(\n- data_formatter.loader, data_formatter.chunker, so... | 8086884923b9a72b9e715a0728f440c002f1cf20 | diff --git a/docs/advanced/interface_types.mdx b/docs/advanced/interface_types.mdx
index 0337038b8c..0d8fe9ca0b 100644
--- a/docs/advanced/interface_types.mdx
+++ b/docs/advanced/interface_types.mdx
@@ -36,7 +36,7 @@ print(naval_chat_bot.chat("what did the author say about happiness?"))
#### Dry Run
-Dry Run is an... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
mem0ai__mem0-380@f2699a0 | mem0ai/mem0 | Python | 380 | feat: add method - detect format / data_type | ## Description
Automatically detect and use the `data_type` in `add` method.
* a quite sophisticated system to detect the data_type (checks if it's a url, string, local file and then the file extension)
* added tons of unit tests
* documentation changes
**breaking change** because the first argument of add i... | 2023-07-27T15:18:37Z | [Feature Request] Auto-Detect data-type, make the it optional
First off... Great job!!! Simple and tight code. Much appreciate you making/sharing it.
There was one quick suggestion I had: In order to minimize boilerplate code, it would be good to modify the interface to make the `file_type` variable optional and de... | Good suggestion, defnitely on the roadmap
#380 will resolve this
Agreed.
Lets revamp this `add` function as
- Users can use this embed some data for their bot
- Args:
- `path`: takes url, directory path or something else like s3 uri etc in future. We should parse the what the type of `path` is. Eg, determine ... | [
{
"body": "First off... Great job!!! Simple and tight code. Much appreciate you making/sharing it. \r\n\r\nThere was one quick suggestion I had: In order to minimize boilerplate code, it would be good to modify the interface to make the `file_type` variable optional and detected based on the input content. If t... | 4021d93168e0fd219472c9224536181b086f0c31 | {
"head_commit": "f2699a04d550f0f710ad574a79e45a82c0339620",
"head_commit_message": "fix: use clean metadata implmentation",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 904ae9bc8c..c58450b4c6 100644\n--- a/README.md\n+++ b/README.md\n@@ -28,8 +28,8 @@ pip install embedchain\n zuck_bot = Llama2... | [
{
"diff_hunk": "@@ -36,52 +39,81 @@ def __init__(self, config: BaseAppConfig):\n self.is_docs_site_instance = False\n self.online = False\n \n- def add(self, data_type, url, metadata=None, config: AddConfig = None):\n+ def add(self, source, data_type=None, metadata=None, config: AddConfig ... | 4bf7cf6fa0a7737e4524546e67ee089d6e1a2e2a | diff --git a/README.md b/README.md
index 904ae9bc8c..c58450b4c6 100644
--- a/README.md
+++ b/README.md
@@ -28,8 +28,8 @@ pip install embedchain
zuck_bot = Llama2App()
# Embed your data
- zuck_bot.add("youtube_video", "https://www.youtube.com/watch?v=Ff4fRgnuFgQ")
- zuck_bot.add("web_page", "https://en.wikiped... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.