instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
mindsdb__mindsdb-7648@08500a1 | mindsdb/mindsdb | Python | 7,648 | Outlook to Email docs | ## Description
This PR updates the docs and readme for the Email integration with additional info about connecting to Outlook.
Fixes #7647
## Type of change
(Please delete options that are not relevant)
- [ ] 🐛 Bug fix (non-breaking change which fixes an issue)
- [ ] ⚡ New feature (non-breaking change... | 2023-10-09T10:02:43Z | [Docs]: Add information about connecting to Outlook
The missing documentation for connecting to Outlook affects users who prefer to use Outlook as their email provider. Without the necessary information, users may face difficulties in configuring their email settings and connecting to their Outlook accounts. | [
{
"body": "The missing documentation for connecting to Outlook affects users who prefer to use Outlook as their email provider. Without the necessary information, users may face difficulties in configuring their email settings and connecting to their Outlook accounts.",
"number": 7647,
"title": "[Docs]:... | c326cd992dc0aef510e0693ad8cfd3cf7e54677d | {
"head_commit": "08500a10f5201fc8823748509d6288b0b56f6d4c",
"head_commit_message": "Update email README",
"patch_to_review": "diff --git a/docs/integrations/app-integrations/email.mdx b/docs/integrations/app-integrations/email.mdx\nindex afeea2df84b..db2faff2cef 100644\n--- a/docs/integrations/app-integrations/e... | [
{
"diff_hunk": "@@ -50,40 +50,83 @@ At the moment, the handler has only been tested with Gmail accounts.\n \n ## TODO\n \n-- [ ] Test the handler for other email providers like Outlook, Yahoo, etc.\n+- [ ] Test the handler for other email providers like Yahoo, etc.\n \n-## Example Usage\n \n-The first step is t... | 59d3fbf141b6ba6b4160197d222db2c104669e65 | diff --git a/docs/integrations/app-integrations/email.mdx b/docs/integrations/app-integrations/email.mdx
index afeea2df84b..db2faff2cef 100644
--- a/docs/integrations/app-integrations/email.mdx
+++ b/docs/integrations/app-integrations/email.mdx
@@ -8,7 +8,7 @@ In this section, we present how to connect Email accounts t... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
kedro-org__kedro-3693@b6d1eab | kedro-org/kedro | Python | 3,693 | Unhide cookiecutter errors in `kedro new` | ## Description
Close [#2564](https://github.com/kedro-org/kedro/issues/2564)
## Development notes
- Unhide cookiecutter errors in `kedro new`, so when `--verbose` flag is not provided short cookiecutter error is in the output; with `--verbose` flag full cookiecutter error is in the output;
- Added unit test to ... | 2024-03-11T13:47:07Z | Unhide cookiecutter errors in `kedro new`
## Description
Somehow the opposite of gh-2401: when cookiecutter fails, `kedro new` prompts you to re-run with `--verbose`:
```
> kedro new --starter=spaceflights
Project Name
============
Please enter a human readable name for your new project.
Spaces, hyphens, and... | [
{
"body": "## Description\r\nSomehow the opposite of gh-2401: when cookiecutter fails, `kedro new` prompts you to re-run with `--verbose`:\r\n\r\n```\r\n> kedro new --starter=spaceflights\r\n\r\nProject Name\r\n============\r\nPlease enter a human readable name for your new project.\r\nSpaces, hyphens, and unde... | 12bb1dd23855454a0e18a67843fc88540cc2eaf8 | {
"head_commit": "b6d1eabec07c6ab816e06cdee7c5ed3b9c8d4595",
"head_commit_message": "Fixed VERBOSE_EXISTS redefining\n\nSigned-off-by: Elena Khaustova <ymax70rus@gmail.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex c2d3f4c211..d20475cc22 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -1,6 ... | [
{
"diff_hunk": "@@ -490,6 +491,16 @@ def test_fail_if_dir_exists(self, fake_kedro_cli):\n assert result.exit_code != 0\n assert \"directory already exists\" in result.output\n \n+ def test_cookiecutter_exception_if_no_verbose(self, fake_kedro_cli):\n+ \"\"\"Check if original cookiecutt... | e4b32930e24e2a7d2f833a479c6ccc4623973df4 | diff --git a/RELEASE.md b/RELEASE.md
index e22d9f9a47..c534720754 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -1,6 +1,7 @@
# Upcoming Release 0.19.4
## Major features and improvements
+* Cookiecutter errors are shown in short format without the `--verbose` flag.
* Kedro commands now work from any subdirectory with... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jupyterhub__jupyterhub-3904@f51faa2 | jupyterhub/jupyterhub | Python | 3,904 | Escape named server name | This escapes the server name when used in paths, but keeps the original server name in the database.
Closes https://github.com/jupyterhub/jupyterhub/issues/3144
An alternative to this implementation is to require that server names are url-safe and error if they're not, i.e. the client UI would be responsible for ... | 2022-05-22T22:31:59Z | Named Server names are not URL escaped
### Bug description
<!-- Use this section to clearly and concisely describe the bug. -->
A user created a named server with a name that contains a whitespace, this caused a malformed URL and subsequently crashed jupyterhub when it runs add_route()
#### Expected behaviour
<!-... | Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
<br>If you haven't done so already, check out [Jupyter's Code of Conduct](https://github.com/jupyter/governance/blob/master/conduct/code_of_conduct.md). Also, please try to follow the issue templat... | [
{
"body": "### Bug description\r\n<!-- Use this section to clearly and concisely describe the bug. -->\r\nA user created a named server with a name that contains a whitespace, this caused a malformed URL and subsequently crashed jupyterhub when it runs add_route()\r\n\r\n#### Expected behaviour\r\n<!-- Tell us ... | b18a05c2c8a8ff86f9255bc2abaa356c418d3dd3 | {
"head_commit": "f51faa25ed226ac362df1064be260a4946cfde3f",
"head_commit_message": "Ban `/` from server-name",
"patch_to_review": "diff --git a/jupyterhub/handlers/pages.py b/jupyterhub/handlers/pages.py\nindex b7aad49cb9..b154b0d8db 100644\n--- a/jupyterhub/handlers/pages.py\n+++ b/jupyterhub/handlers/pages.py\... | [
{
"diff_hunk": "@@ -118,6 +118,9 @@ def get(self, user_name=None, server_name=''):\n \n @needs_scope(\"servers\")\n async def _get(self, user_name, server_name):\n+ if '/' in server_name:\n+ raise web.HTTPError(400, f\"Invalid server_name: {server_name}\")",
"line": null,
"orig... | 3c059f3acf1db9c7ea17f68c6b224c5083832f3c | diff --git a/jupyterhub/apihandlers/base.py b/jupyterhub/apihandlers/base.py
index 1658999c17..b6ccb4e8f3 100644
--- a/jupyterhub/apihandlers/base.py
+++ b/jupyterhub/apihandlers/base.py
@@ -12,7 +12,7 @@
from .. import orm
from ..handlers import BaseHandler
from ..scopes import get_scopes_for
-from ..utils import g... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mindsdb__mindsdb-7403@2543e06 | mindsdb/mindsdb | Python | 7,403 | [ENH] Ollama handler | ## Description
This PR adds an integration to Ollama, a popular LLM library that simplifies LLM deployment (macOS only, for now).
It also moves a helper function from the OpenAI handler to the common `integrations/libs/llm_utils.py` file, so that any LLM handler can use it. Moving forward, this file should host a... | 2023-09-22T21:21:00Z | [Integration]: Ollama
### Is there an existing integration?
- [X] I have searched the existing integrations.
### Use Case
Local LLMs, fast inference.
### Motivation
Ollama enables fast inferencing for local LLMs like Llama2.
### Implementation
Start with macOS support.
### Anything else?
_No response_ | We may want to do a set of primitives for LLM fine tuning as part of this integration. E.g. chunking, embedding and all other RAG stuff should be at the base level so that other engines can leverage it. | [
{
"body": "### Is there an existing integration?\n\n- [X] I have searched the existing integrations.\n\n### Use Case\n\nLocal LLMs, fast inference.\n\n### Motivation\n\nOllama enables fast inferencing for local LLMs like Llama2.\n\n### Implementation\n\nStart with macOS support.\n\n### Anything else?\n\n_No res... | c113ac4eee579d3a62c1a83c8af0431358667a05 | {
"head_commit": "2543e061e4ebfecbd650de56584167e880ccd3b7",
"head_commit_message": "fix instruction",
"patch_to_review": "diff --git a/mindsdb/integrations/handlers/ollama_handler/README.md b/mindsdb/integrations/handlers/ollama_handler/README.md\nnew file mode 100644\nindex 00000000000..ea1cf65acd0\n--- /dev/nu... | [
{
"diff_hunk": "@@ -0,0 +1,127 @@\n+import json\n+import requests\n+from typing import Dict, Optional\n+\n+import pandas as pd\n+\n+from mindsdb.integrations.libs.base import BaseMLEngine\n+from mindsdb.integrations.libs.llm_utils import get_completed_prompts\n+\n+\n+class OllamaHandler(BaseMLEngine):\n+ nam... | a325d20a004abee61221a6e49a12146b21a2e8e2 | diff --git a/mindsdb/integrations/handlers/ollama_handler/README.md b/mindsdb/integrations/handlers/ollama_handler/README.md
new file mode 100644
index 00000000000..ea1cf65acd0
--- /dev/null
+++ b/mindsdb/integrations/handlers/ollama_handler/README.md
@@ -0,0 +1,85 @@
+# Ollama handler
+
+## Briefly describe the ML fr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
mindsdb__mindsdb-7518@1a8a2c9 | mindsdb/mindsdb | Python | 7,518 | LAST keyword support & spanner update | ## Description
Added LAST keyword. It is created for handling new data from sources and organize pipelines to process new pieces of data
Updated spanner handler: https://docs.google.com/document/d/13gxXva1KLaY_NOg3JIFvRhs2Q8Gwq4hjf6WfWrezQfE/edit#heading=h.yk4h1jjpgwmd
Simple example:
```sql
select * from db... | 2023-10-03T14:57:54Z | [Job] stateful job (add cursor state)
### Short description and motivation for the proposed feature
Remember states across different invocations of the job.
This feature is useful in implementing a use case like incremental data fetching.
### Video or screenshots
_No response_
### Describe some possib... | [
{
"body": "### Short description and motivation for the proposed feature\r\n\r\nRemember states across different invocations of the job. \r\nThis feature is useful in implementing a use case like incremental data fetching.\r\n\r\n\r\n\r\n### Video or screenshots\r\n\r\n_No response_\r\n\r\n### Describe some pos... | 274de3400285a4403f583d7a9f83741a5e091295 | {
"head_commit": "1a8a2c9eb5a0c3bb46fde421094db91a5006983c",
"head_commit_message": "rollback sql dep",
"patch_to_review": "diff --git a/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py b/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py\nindex c8523320f63..7ea0c00cf96 100644\n--- a/mindsdb/api/mysql/mysql_pro... | [
{
"diff_hunk": "@@ -0,0 +1,158 @@\n+import copy\n+from collections import defaultdict\n+\n+from mindsdb_sql.parser.ast import Identifier, Select, BinaryOperation, Last, Constant, Star\n+from mindsdb_sql.planner.utils import query_traversal\n+\n+\n+class LastQuery:\n+ \"\"\"\n+ Tracks last values in query\... | 8224d0062de7a2705e2b5a7355b6f3e10eca1d7d | diff --git a/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py b/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py
index c8523320f63..a6509f63b6b 100644
--- a/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py
+++ b/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py
@@ -64,7 +64,6 @@
from mindsdb_sql.render.sqlalche... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
kedro-org__kedro-3544@f40a875 | kedro-org/kedro | Python | 3,544 | [Ready] 0.19 Migration guide documentation | ## Description
Closes #3500
I've created a page in `resources/migration.html` to store a narrative version of the migration guide we have previously published in release notes. I suggest that we use it for future releases and just have a section in the release notes that points to it in the future. It's better for... | 2024-01-22T18:04:29Z | Create migration guide documentation content
## Description
Beyond the content in the release notes (or to replace it) there needs to be a page to point at that explains migration tasks for each breaking release. This should be relatively straightforward in 0.19 as we've a release note but it needs some structuring an... | See the PR https://github.com/kedro-org/kedro/pull/3544 for a first draft of a page of migration narrative for 0.19. It needs some time from engineering to flesh out the example snippets and explain where those changes should be applied. I've guided this through comments (which need to be removed). Handing over to engi... | [
{
"body": "## Description\r\nBeyond the content in the release notes (or to replace it) there needs to be a page to point at that explains migration tasks for each breaking release. This should be relatively straightforward in 0.19 as we've a release note but it needs some structuring and extra narrative flow.\... | ca67641ec4699de2136353d01b9794dadfb6071c | {
"head_commit": "f40a875318ed134c664dcfe0ecb853ba2afc2b7b",
"head_commit_message": "Add link to migration guide to release notes\n\nSigned-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex 3bcf6773d8..2ab73e229e 100644\n--- a/RELEASE.md\n+++ b/RELE... | [
{
"diff_hunk": "@@ -30,11 +30,18 @@\n * Added documentation about `bootstrap_project` and `configure_project`.\n * Added documentation about `kedro run` and hook execution order.\n \n+## Migration guide from Kedro 0.18.* to 0.19.*\n+[See the migration guide for 0.19 in the Kedro documentation](https://docs.kedr... | 76dd330b5f56b09794000dc24190121f55776100 | diff --git a/RELEASE.md b/RELEASE.md
index 3bcf6773d8..fd83265b42 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -30,10 +30,17 @@
* Added documentation about `bootstrap_project` and `configure_project`.
* Added documentation about `kedro run` and hook execution order.
+## Migration guide from Kedro 0.18.* to 0.19.*
+[... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
kedro-org__kedro-3437@cfdfc11 | kedro-org/kedro | Python | 3,437 | Remove setuptools dependency | ## Description
Remove setuptools dependency as mentioned in #2350
## Development notes
<!-- What have you changed, and how has this been tested? -->
## Developer Certificate of Origin
We need all contributions to comply with the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). All... | 2023-12-18T15:58:41Z | Remove setuptools from core dependencies
## Description
I'm always frustrated when `pip install kedro` upgrades the versions of `setuptools`, `wheel` and `pip`.
## Context
Usually I would not expect `pip install` to upgrade these packages unless I explicitly run `python3 -m pip install --upgrade pip setuptools whe... | super reasonable suggestion @ZiruiXuQB - I'm actually amazed this hasn't been suggested before!
I wouldn't move `setuptools` to an optional dependency, but rather remove it altogether. Instead of invoking `setup.py` directly, it's preferable to use `python -m build` (as of PEP 517, PEP 518). However, I suppose then `bu... | [
{
"body": "## Description\r\nI'm always frustrated when `pip install kedro` upgrades the versions of `setuptools`, `wheel` and `pip`.\r\n\r\n## Context\r\nUsually I would not expect `pip install` to upgrade these packages unless I explicitly run `python3 -m pip install --upgrade pip setuptools wheel`.\r\n\r\nTh... | fc9b70b8e1a978ab59dd91c2163489a8af44fb7f | {
"head_commit": "cfdfc1136abd9474f6470bba904a419f77cf0ad9",
"head_commit_message": "Remove setuptools\n\nSigned-off-by: Dmitry Sorokin <dmd40in@gmail.com>",
"patch_to_review": "diff --git a/kedro/framework/cli/micropkg.py b/kedro/framework/cli/micropkg.py\nindex dcdfc5d99e..09fdfe7ef8 100644\n--- a/kedro/framewo... | [
{
"diff_hunk": "@@ -227,9 +226,11 @@ def _pull_package( # noqa: PLR0913\n # However, the rest of the code expects the non-normalized package name,\n # so we have to find it.\n packages = [\n- package\n- for package in FlatLayoutPackageFinder().find(project_root_dir... | 5326d7e9d718f8097bac33948fec8613ea7499a2 | diff --git a/RELEASE.md b/RELEASE.md
index 901100e061..6273792449 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -5,6 +5,7 @@
## Bug fixes and other changes
* Removed example pipeline requirements when examples are not selected in `tools`.
* Allowed modern versions of JupyterLab and Jupyter Notebooks.
+* Removed setupt... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
kedro-org__kedro-3425@d9ea55b | kedro-org/kedro | Python | 3,425 | Don't include requirements only needed for example pipeline | ## Description
<!-- Why was this PR created? -->
context: #3386
## Development notes
<!-- What have you changed, and how has this been tested? -->
- Updated `utils.py` to remove `seaborn` and `scikit-learn` and the extras from `kedro-datasets`
- Updated requirements and toml to `Path` parameter types
- Upda... | 2023-12-14T12:20:54Z | Don't include requirements only needed for example pipeline
### Description
With the tools selection flow requirements get added but the following are only needed for running the example pipeline and also get included if the user doesn't want the example:
- seaborn
- scikit-learn
- kedro-datasets[....] the proble... | [
{
"body": "### Description\r\nWith the tools selection flow requirements get added but the following are only needed for running the example pipeline and also get included if the user doesn't want the example:\r\n\r\n- seaborn\r\n- scikit-learn\r\n- kedro-datasets[....] the problem here is not `kedro-dataset` i... | 67cadc21e56dc8c29a8f85b6a03262fe5448a8aa | {
"head_commit": "d9ea55b4e34a71c1cf3ddd604ff3fa0a3c3f1b05",
"head_commit_message": "Merge branch 'main' into dev/remove-requirements-when-no-examples",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex 401d6efc3a..18f4f18d23 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -3,6 +3,7 @@\n ## Major fea... | [
{
"diff_hunk": "@@ -141,13 +144,36 @@ def _remove_pyspark_viz_starter_files(is_viz: bool, python_package_name: str) ->\n _remove_file(test_pipeline_path)\n \n \n-def setup_template_tools(selected_tools_list: str, requirements_file_path: str, pyproject_file_path: str, python_package_name: str, example_pipeli... | 926120e4802e60fc73586481ee18af3b9eb30612 | diff --git a/RELEASE.md b/RELEASE.md
index f5ddf807c2..bbcbd98836 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -3,6 +3,9 @@
## Major features and improvements
## Bug fixes and other changes
+* Removed example pipeline requirements when examples are not selected in `tools`.
+
+## Breaking changes to the API
* Added ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
kedro-org__kedro-3370@e01555a | kedro-org/kedro | Python | 3,370 | Allow `kedro new` with config file without tools or example | > **NOTE:** Kedro datasets are moving from `kedro.extras.datasets` to a separate `kedro-datasets` package in
> [`kedro-plugins` repository](https://github.com/kedro-org/kedro-plugins). Any changes to the dataset implementations
> should be done by opening a pull request in that repository.
## Description
<!-- Why w... | 2023-11-30T11:54:12Z | Make it possible to create project from config without providing `add_ons` or `example_pipeline`
## Description
Creating a project from config without providing `add_ons` or `example_pipeline` fails.
## Context
`config.yml`:
```yaml
project_name: My First Kedro Project
repo_name: testing-kedro
python_package... | [
{
"body": "## Description\r\nCreating a project from config without providing `add_ons` or `example_pipeline` fails.\r\n\r\n## Context\r\n`config.yml`:\r\n\r\n```yaml\r\nproject_name: My First Kedro Project\r\nrepo_name: testing-kedro\r\npython_package: test_kedro\r\n```\r\nBy itself, this doesn't work - throws... | 57854f22209ed8912e481ad742c79c445f56dc99 | {
"head_commit": "e01555a07057b952d1ed8b40c5e98a403cb38d17",
"head_commit_message": "Update config validation\n\nSigned-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>",
"patch_to_review": "diff --git a/kedro/framework/cli/starters.py b/kedro/framework/cli/starters.py\nindex f0de8f51eb..0881a9c08d 100644\n--... | [
{
"diff_hunk": "@@ -704,9 +704,22 @@ def _validate_config_file_against_prompts(\n if config is None:\n raise KedroCliError(\"Config file is empty.\")\n missing_keys = set(prompts) - set(config)\n- if missing_keys:\n+ missing_mandatory_keys = missing_keys - {\"tools\", \"example_pipeline\"}... | 108136a6ea13e2928d01280152053f772013d66f | diff --git a/kedro/framework/cli/starters.py b/kedro/framework/cli/starters.py
index 638616c9a5..6c976d5817 100644
--- a/kedro/framework/cli/starters.py
+++ b/kedro/framework/cli/starters.py
@@ -708,10 +708,20 @@ def _validate_config_file_against_prompts(
"""
if config is None:
raise KedroCliError("C... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
kedro-org__kedro-3363@8280587 | kedro-org/kedro | Python | 3,363 | Allow plural and singular tool naming for test, log, doc | ## Description
Fixes #3339
## Development notes
Updated the mapping from shorthand tool name to number to include plural as well as singular naming for the testing, logging and documentation options. Data, lint, pyspark, and viz don't make sense in other forms.
## Developer Certificate of Origin
We need al... | 2023-11-29T16:21:33Z | Improving shortname handling of --addons flag
## Description
The shortnames we've allocated for the add ons fluctuate on whether they are plural or not. log vs logs, test vs tests.
At the moment the short names are: `log,test,lint,data,docs,viz`. But many engineers instinctively think of `logs` rather than `log... | [
{
"body": "## Description\r\n\r\nThe shortnames we've allocated for the add ons fluctuate on whether they are plural or not. log vs logs, test vs tests. \r\n\r\nAt the moment the short names are: `log,test,lint,data,docs,viz`. But many engineers instinctively think of `logs` rather than `log` and `tests` rather... | 1e9f0c96f8cb452e103babaf0ac5a01cb5e65bba | {
"head_commit": "82805874e05ef845ab1985c0ab6106ba92a31f88",
"head_commit_message": "Merge branch 'develop' into flexible-plural-singular-tools",
"patch_to_review": "diff --git a/kedro/framework/cli/starters.py b/kedro/framework/cli/starters.py\nindex 6c976d5817..4384ebc1fb 100644\n--- a/kedro/framework/cli/start... | [
{
"diff_hunk": "@@ -1222,13 +1222,16 @@ class TestToolsAndExampleFromCLI:\n [\n \"lint\",\n \"test\",\n+ \"tests\",\n \"log\",\n+ \"logs\",\n \"docs\",\n+ \"doc\",\n \"data\",\n \"pyspark\",\n ... | e7076237c37be5008ce14b5270b58d4f5338ad8a | diff --git a/kedro/framework/cli/starters.py b/kedro/framework/cli/starters.py
index 6c976d5817..4384ebc1fb 100644
--- a/kedro/framework/cli/starters.py
+++ b/kedro/framework/cli/starters.py
@@ -110,8 +110,11 @@ class KedroStarterSpec: # noqa: too-few-public-methods
TOOLS_SHORTNAME_TO_NUMBER = {
"lint": "1",
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
kedro-org__kedro-3357@012d855 | kedro-org/kedro | Python | 3,357 | Rename addons to tools | > **NOTE:** Kedro datasets are moving from `kedro.extras.datasets` to a separate `kedro-datasets` package in
> [`kedro-plugins` repository](https://github.com/kedro-org/kedro-plugins). Any changes to the dataset implementations
> should be done by opening a pull request in that repository.
## Description
<!-- Why w... | 2023-11-28T16:17:09Z | Iterate on feedback on Project Creation Flow
Following the **internal** user feedback session on 13/09/2023:
We presented the following prototype
```
(my-virtual-environment) ➜ kedro new
Project Name
============
Please enter a human readable name for your new project.
Spaces, hyphens, and underscores are... | Following the **external** user feedback section on 4/10/2023:
We received feedback on the following points
- a flag to indicate that they wanted default values
- users were happy to go through the interactive flow if no flags were used
- users wanted to ability to create their own add-ons
- users understoo... | [
{
"body": "Following the **internal** user feedback session on 13/09/2023:\r\n\r\nWe presented the following prototype\r\n```\r\n(my-virtual-environment) ➜ kedro new \r\n\r\nProject Name\r\n============\r\nPlease enter a human readable name for your new project.\r\nSpaces, hyphens, and underscores are allowed.... | b7e2623c1829c5ce683a81888d5afefaf1be1ad5 | {
"head_commit": "012d8554aadd5fb607ac450ca8305e7cdcec8866",
"head_commit_message": "Replace add-ons with tools\n\nSigned-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>",
"patch_to_review": "diff --git a/features/steps/cli_steps.py b/features/steps/cli_steps.py\nindex 355a745702..4494aade8a 100644\n--- a/fe... | [
{
"diff_hunk": "@@ -170,13 +170,13 @@ def starter():\n @click.option(\"--starter\", \"-s\", \"starter_alias\", help=STARTER_ARG_HELP)\n @click.option(\"--checkout\", help=CHECKOUT_ARG_HELP)\n @click.option(\"--directory\", help=DIRECTORY_ARG_HELP)\n-@click.option(\"--addons\", \"-a\", \"selected_add_ons_flag\",... | d138efcf4772c04ad5ea2d7bf785d91d05ced835 | diff --git a/RELEASE.md b/RELEASE.md
index d3d19c9403..6794b7ba3b 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -2,7 +2,7 @@
## Major features and improvements
* Dropped Python 3.7 support.
-* Introduced add-ons and example to the `kedro new` CLI flow.
+* Introduced project tools and example to the `kedro new` CLI fl... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
mindsdb__mindsdb-2895@8cfe1b6 | mindsdb/mindsdb | Python | 2,895 | Added Hive Handler #2360 | Fixes #2360
## Please describe what changes you made, in as much detail as possible
- I Have added Hive Handler to mindsdb's Repo for DEV contest and it has passed all basic Testing
mindsdb | 2022-09-10T21:11:45Z | Hive (Hive Server2?) as a Datasource
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Is your feature request related to a problem? Please describe.
A user would like to use Hive as a datasource.
### Describe the solution you'd like.
Be able to train ML models in MindsDB f... | Hi @ZoranPandovski. Can I take this up?
Hey sure @bispaul
Hi @bispaul, did you start on this?
Hi @ZoranPandovski , I have started but couldn't work much due to my workload. I will try to complete this before the end of this month. Thank You. | [
{
"body": "### Is there an existing issue for this?\n\n- [X] I have searched the existing issues\n\n### Is your feature request related to a problem? Please describe.\n\nA user would like to use Hive as a datasource.\r\n\r\n\n\n### Describe the solution you'd like.\n\nBe able to train ML models in MindsDB from ... | 78ed5abe15d9c435a6e66e21bcfddc1085d48eab | {
"head_commit": "8cfe1b65bdd969f26141e334d2d3b0fd2168b6d2",
"head_commit_message": "Added Hive Handler #2360",
"patch_to_review": "diff --git a/mindsdb/integrations/handlers/hive_handler/README.md b/mindsdb/integrations/handlers/hive_handler/README.md\nnew file mode 100644\nindex 00000000000..aaaf1fdc515\n--- /d... | [
{
"diff_hunk": "@@ -0,0 +1,191 @@\n+from typing import Optional\n+from collections import OrderedDict\n+import pandas as pd\n+from pyhive import (hive, sqlalchemy_hive)\n+from sqlalchemy import create_engine\n+\n+from mindsdb_sql import parse_sql\n+from mindsdb_sql.render.sqlalchemy_render import SqlalchemyRend... | 3a14573f233ef7bd038e991acfcea8ae78c2ebad | diff --git a/mindsdb/integrations/handlers/hive_handler/README.md b/mindsdb/integrations/handlers/hive_handler/README.md
new file mode 100644
index 00000000000..aaaf1fdc515
--- /dev/null
+++ b/mindsdb/integrations/handlers/hive_handler/README.md
@@ -0,0 +1,40 @@
+# Hive Handler
+
+This is the implementation of the Hiv... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
jupyterhub__jupyterhub-3298@ed6231d | jupyterhub/jupyterhub | Python | 3,298 | Fix asyncio deprecation asyncio.Task.all_tasks | This is to fix #3297 | 2020-12-02T18:15:45Z | Cannot shutdown on python 3.9 due to asyncio deprecation
### Bug description
When using jupyterhub with python3.9, you will not be able to shutdown (e.g. via ctrl+c). When attempting to stop asyncio tasks, you will get `type object '_asyncio.Task' has no attribute 'all_tasks'` error. `asyncio.Task.all_tasks()` and `cu... | [
{
"body": "### Bug description\r\nWhen using jupyterhub with python3.9, you will not be able to shutdown (e.g. via ctrl+c). When attempting to stop asyncio tasks, you will get `type object '_asyncio.Task' has no attribute 'all_tasks'` error. `asyncio.Task.all_tasks()` and `current_task()` have been deprecated s... | 4b254fe5edd395e244eea730f521deaa517136dd | {
"head_commit": "ed6231d3aa71f86ed059c285460bd051825af4b0",
"head_commit_message": "Fix asyncio deprecation asyncio.Task.all_tasks",
"patch_to_review": "diff --git a/jupyterhub/app.py b/jupyterhub/app.py\nindex b6d8571ad9..6cf4b093a2 100644\n--- a/jupyterhub/app.py\n+++ b/jupyterhub/app.py\n@@ -29,6 +29,13 @@\n ... | [
{
"diff_hunk": "@@ -29,6 +29,13 @@\n if sys.version_info[:2] < (3, 3):\n raise ValueError(\"Python < 3.3 not supported: %s\" % sys.version)\n \n+# For compatibility with python versions 3.6 or earlier.\n+# asyncio.Task.all_tasks() is fully moved to asyncio.all_tasks() starting with 3.9. Also applies to curr... | f866bbcf454fc521bf26515c4b8e8a3afb28a366 | diff --git a/jupyterhub/app.py b/jupyterhub/app.py
index b6d8571ad9..a3bc17e0ed 100644
--- a/jupyterhub/app.py
+++ b/jupyterhub/app.py
@@ -29,6 +29,14 @@
if sys.version_info[:2] < (3, 3):
raise ValueError("Python < 3.3 not supported: %s" % sys.version)
+# For compatibility with python versions 3.6 or earlier.
+... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
jupyterhub__jupyterhub-3077@522ef3d | jupyterhub/jupyterhub | Python | 3,077 | Add Configuration Reference section to docs | Closes #3066
Tried a naive approach to capture the output of `jupyterhub --generate-config` and `jupyterhub --help-all` commands, and display in the generated documentation.
It worked, but as I am still learning Sphinx and how to use/extend it, there may be other better alternatives? For example, I got similar b... | 2020-06-08T11:54:46Z | Include Default Config Files and Documented CLI Options in docs
### Proposed change
Many people deploy this into containerized environments, and as such generating a config file to modify or running `jupyterhub --help-all` to get the options when starting the server is a time-consuming and non-trivial task depending o... | Automatically including the output of `jupyterhub --generate-config` and `jupyterhub --help-all` as part of the docs build sounds like a good idea to me. We'll probably want to do some post-processing to convert some absolute paths like the cwd and home to e.g. `.` and `~` (or be fancy and define these as variables in ... | [
{
"body": "### Proposed change\r\nMany people deploy this into containerized environments, and as such generating a config file to modify or running `jupyterhub --help-all` to get the options when starting the server is a time-consuming and non-trivial task depending on your environment. It would be great if th... | 77edffd695bbef3b132fb3e9f1c6f080a84977e2 | {
"head_commit": "522ef3daeae97c663890cfbf26ddd3a9ce2df190",
"head_commit_message": "Add Configuration Reference",
"patch_to_review": "diff --git a/docs/source/conf.py b/docs/source/conf.py\nindex 64e4939a5d..e0eb3bb914 100644\n--- a/docs/source/conf.py\n+++ b/docs/source/conf.py\n@@ -60,11 +60,65 @@\n import rec... | [
{
"diff_hunk": "@@ -0,0 +1,30 @@\n+==============================\n+Configuration Reference\n+==============================\n+\n+.. important::\n+\n+ Make sure the version of JupyterHub for this documentation matches your\n+ installation version, as the output of this command may change between versions.... | 84d252402572a2aae2a0db6144786807e4fcdb0f | diff --git a/docs/source/conf.py b/docs/source/conf.py
index 64e4939a5d..e0eb3bb914 100644
--- a/docs/source/conf.py
+++ b/docs/source/conf.py
@@ -60,11 +60,65 @@
import recommonmark
from recommonmark.transform import AutoStructify
+# -- Config -------------------------------------------------------------
+from jup... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
kedro-org__kedro-3325@67f44af | kedro-org/kedro | Python | 3,325 | Add E2E test for tools | ## Description
For most of the add-ons flow I've been testing the work manually: create a new project with a combination of add-ons, install requirements and try a kedro run. This process has uncovered several bugs already.
## Context
We should add automated tests to test at least some of the add-ons flow.
Impl... | 2023-11-21T14:27:00Z | Add e2e tests for `add-ons` flow
## Description
For most of the add-ons flow I've been testing the work manually: create a new project with a combination of add-ons, install requirements and try a `kedro run`. This process has uncovered several bugs already.
## Context
We should add automated tests to test at leas... | [
{
"body": "## Description\r\nFor most of the add-ons flow I've been testing the work manually: create a new project with a combination of add-ons, install requirements and try a `kedro run`. This process has uncovered several bugs already.\r\n\r\n## Context\r\nWe should add automated tests to test at least some... | 5292834047fb99f3d21d3b430ed152a037c1718c | {
"head_commit": "67f44af77779da3537b3091f582cd501f501ecf6",
"head_commit_message": "Merge branch 'develop' into dev/e2e-test-for-add-ons",
"patch_to_review": "diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml\nindex d39505f8fc..c8a970f893 100644\n--- a/.github/workflows/e2e-tests.yml... | [
{
"diff_hunk": "@@ -453,6 +478,49 @@ def is_created(name):\n assert is_created(path)\n \n \n+@then('the expected tool directories and files should be created with \"{tools}\"')\n+def check_created_project_structure_from_tools(context, tools):\n+ \"\"\"Behave step to check the subdirectories created b... | 053f981a88dc21c423a11c72ca65c2b185b81ede | diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml
index d39505f8fc..45e37525ac 100644
--- a/.github/workflows/e2e-tests.yml
+++ b/.github/workflows/e2e-tests.yml
@@ -42,6 +42,20 @@ jobs:
- name: Add MSBuild to PATH
if: inputs.os == 'windows-latest'
uses: microsoft/s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} | |
jupyterhub__jupyterhub-2936@b92efcd | jupyterhub/jupyterhub | Python | 2,936 | make init_spawners check O(running servers) not O(total users) | by making the query on Server objects instead of User objects, which is logically equivalent because we were already filtering on `if spawner.server is not None`
avoids lots of ORM work on startup since there are typically a small number of running servers relative to the total number of users
this also means tha... | 2020-02-18T16:13:42Z | Extremely slow hub start up with large numbers of users
**Describe the bug**
We have an instance of JupyterHub with over 50,000 users in it, connected to a custom authenticator. When starting the hub pod it takes over 15 minutes to get to the ready state, where it is accepting requests. During this period of time th... | After some investigation in the code, I'm curious if this block is the culprit: https://github.com/jupyterhub/jupyterhub/blob/bc7bb5076ff2deabc7702c75dce208166d14568e/jupyterhub/app.py#L1668-L1702
Iterating through all 50k + users on boot definitely has a cost, even if only a few ms per user, that adds up. Would it ... | [
{
"body": "**Describe the bug**\r\n\r\nWe have an instance of JupyterHub with over 50,000 users in it, connected to a custom authenticator. When starting the hub pod it takes over 15 minutes to get to the ready state, where it is accepting requests. During this period of time the Hub is effectively offline for ... | bc7bb5076ff2deabc7702c75dce208166d14568e | {
"head_commit": "b92efcd7b064315e63219a4ef807c40cf541484e",
"head_commit_message": "spawner test assumed app.users is populated",
"patch_to_review": "diff --git a/jupyterhub/app.py b/jupyterhub/app.py\nindex 0bd57de746..b0cc694a7d 100644\n--- a/jupyterhub/app.py\n+++ b/jupyterhub/app.py\n@@ -1670,9 +1670,12 @@ a... | [
{
"diff_hunk": "@@ -1670,9 +1670,12 @@ def init_hub(self):\n # This lets whitelist be used to set up initial list,\n # but changes to the whitelist can occur in the database,\n # and persist across sessions.\n+ total_users = 0\n for user in db.query(orm.User):\n ... | 606775f72da2ce648a5a5fbe8e452c72f082e263 | diff --git a/jupyterhub/app.py b/jupyterhub/app.py
index 0bd57de746..41abcf4c5e 100644
--- a/jupyterhub/app.py
+++ b/jupyterhub/app.py
@@ -1670,9 +1670,12 @@ async def init_users(self):
# This lets whitelist be used to set up initial list,
# but changes to the whitelist can occur in the database,
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
mindsdb__mindsdb-2843@2cd0029 | mindsdb/mindsdb | Python | 2,843 | ☑☑ ADDED Timescaledb Handler | Fixes #2842
## Please describe what changes you made, in as much detail as possible
- All this basic testing done please check this out .
- You can you timescale db [cloud](https://console.cloud.timescale.com/signup) for TESTING
mindsdb | 2022-08-31T12:33:18Z | [New Integration]: Integration With TimeScaleDB
### Is there an existing integration?
- [X] I have searched the existing integrations.
### Use Case
TimescaleDB is an open-source developed by Timescale Inc. It is written in C and extends PostgreSQL. TimescaleDB supports standard SQL queries and is a relational ... | [
{
"body": "### Is there an existing integration?\r\n\r\n- [X] I have searched the existing integrations.\r\n\r\n### Use Case\r\n\r\nTimescaleDB is an open-source developed by Timescale Inc. It is written in C and extends PostgreSQL. TimescaleDB supports standard SQL queries and is a relational database.Addition... | c68d5363ed8dad479c29f1c9c3b14b5fa49d81a2 | {
"head_commit": "2cd00295ba7d09ec87e74ceb9abb4d7aee044890",
"head_commit_message": "Deleted extra file",
"patch_to_review": "diff --git a/mindsdb/integrations/handlers/informix_handler/README.md b/mindsdb/integrations/handlers/informix_handler/README.md\ndeleted file mode 100644\nindex 1146b8a8a2b..00000000000\n... | [
{
"diff_hunk": "@@ -0,0 +1,37 @@\n+# TimeScaleDB Handler\n+\n+This is the implementation of the TimeScaleDB handler for MindsDB.\n+\n+## TimeScaleDB\n+TimescaleDB is an open-source database designed to make SQL scalable for time-series data. It is engineered up from PostgreSQL and packaged as a PostgreSQL exten... | 9e949bc0cea170526f2991e22b137fe14043753a | diff --git a/mindsdb/integrations/handlers/timescaledb_handler/README.md b/mindsdb/integrations/handlers/timescaledb_handler/README.md
new file mode 100644
index 00000000000..a981904a867
--- /dev/null
+++ b/mindsdb/integrations/handlers/timescaledb_handler/README.md
@@ -0,0 +1,37 @@
+# TimeScaleDB Handler
+
+This is th... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
mindsdb__mindsdb-2743@f665f1e | mindsdb/mindsdb | Python | 2,743 | 💯💯 Added Monetdb Handler | Fixes #2729
## Please describe what changes you made, in as much detail as possible
- Added MonetDB Handler And Tested .
- you can test and Provide your feedback
- [Installation](https://www.monetdb.org/documentation-Jan2022/admin-guide/installation/)
mindsdb | 2022-08-20T13:32:57Z | [New Integration]: Integration with MonetDB
### Is there an existing integration?
- [X] I have searched the existing integrations.
### Use Case
**MonetDB** is an open-source column-oriented relational database management system. It is designed to provide high performance on complex queries against large databases, s... | @ZoranPandovski can i work on this. | [
{
"body": "### Is there an existing integration?\n\n- [X] I have searched the existing integrations.\n\n### Use Case\n\n**MonetDB** is an open-source column-oriented relational database management system. It is designed to provide high performance on complex queries against large databases, such as combining ta... | 769423f91754c9be7095d325cc47aedae81b93ba | {
"head_commit": "f665f1efbb46c7cb7af480f8cb568e3c8c17656c",
"head_commit_message": "Merge branch 'mindsdb:staging' into monetdb",
"patch_to_review": "diff --git a/mindsdb/integrations/handlers/monetdb_handler/README.md b/mindsdb/integrations/handlers/monetdb_handler/README.md\nnew file mode 100644\nindex 0000000... | [
{
"diff_hunk": "@@ -0,0 +1,273 @@\n+from collections import OrderedDict\n+from typing import Optional\n+from mindsdb_sql.parser.ast.base import ASTNode\n+from mindsdb.integrations.libs.base_handler import DatabaseHandler\n+from mindsdb.utilities.log import log\n+from mindsdb_sql import parse_sql\n+from mindsdb_... | b51048ffbcf514a31bcd2eadb3a1ab8f3806fc5e | diff --git a/mindsdb/integrations/handlers/monetdb_handler/README.md b/mindsdb/integrations/handlers/monetdb_handler/README.md
new file mode 100644
index 00000000000..92f5a59a39b
--- /dev/null
+++ b/mindsdb/integrations/handlers/monetdb_handler/README.md
@@ -0,0 +1,38 @@
+# MonetDB Handler
+
+This is the implementation... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jupyterhub__jupyterhub-2684@0058ed8 | jupyterhub/jupyterhub | Python | 2,684 | Handle pre_spawn_start possible exceptions | This should fix https://github.com/jupyterhub/jupyterhub/issues/2683 :eyes:
| 2019-08-14T10:26:54Z | pre_spawn_start exceptions may lead to redirect loop
**Describe the bug**
if we override authenticator `pre_spawn_start` with a coroutine and throw exceptions from it, it could lead to the redirect loop issue with an eventual 500 error, instead of showing the exception. however, exceptions `options_from_form` are r... | [
{
"body": "**Describe the bug**\r\n\r\nif we override authenticator `pre_spawn_start` with a coroutine and throw exceptions from it, it could lead to the redirect loop issue with an eventual 500 error, instead of showing the exception. however, exceptions `options_from_form` are rendered properly as error mess... | 146aec7e0c1dc59134f995eb7f363e1dc7ac169b | {
"head_commit": "0058ed803d611d1d585f7d96b80c3b0586f64560",
"head_commit_message": "Address feedback",
"patch_to_review": "diff --git a/jupyterhub/handlers/pages.py b/jupyterhub/handlers/pages.py\nindex 2aa2c3e846..53525dc8fa 100644\n--- a/jupyterhub/handlers/pages.py\n+++ b/jupyterhub/handlers/pages.py\n@@ -172... | [
{
"diff_hunk": "@@ -172,7 +172,17 @@ def _render_form(self, for_user, spawner_options_form, message=''):\n spawner._spawn_future = None\n # not running, no form. Trigger spawn and redirect back to /user/:name\n f = asyncio.ensure_future(self.spawn_single_user(user, server... | 03693c379e19f3823c3bad7f60cb0a4927e183e0 | diff --git a/jupyterhub/handlers/pages.py b/jupyterhub/handlers/pages.py
index 2aa2c3e846..aa2f37cc79 100644
--- a/jupyterhub/handlers/pages.py
+++ b/jupyterhub/handlers/pages.py
@@ -172,7 +172,16 @@ async def get(self, for_user=None, server_name=''):
spawner._spawn_future = None
# not run... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
mindsdb__mindsdb-2472@118b079 | mindsdb/mindsdb | Python | 2,472 | Ckan integration | Fixes #2312
This PR will introduce new handler for [CKAN](https://github.com/ckan/ckan/) (data management) integration.
* CKAN has API endpoints where we could retrieve the data
* Connect to `datastore_search_sql` to retreive data
* Use the data for model training
| 2022-07-11T16:08:59Z | [New Integration]: Integration with CKAN
### Is there an existing integration?
- [X] I have searched the existing integrations.
### Use Case
CKAN is an open-source DMS (data management system) for powering data hubs and data portals. It not only stores the data, but makes it discoverable and presentable. Having inte... | Working on this | [
{
"body": "### Is there an existing integration?\n\n- [X] I have searched the existing integrations.\n\n### Use Case\n\nCKAN is an open-source DMS (data management system) for powering data hubs and data portals. It not only stores the data, but makes it discoverable and presentable. Having integration with the... | 054c13525d72618e1ee210079ce4554bc688864a | {
"head_commit": "118b079ddf5c4ecfaa13df6fed527b94cca07a17",
"head_commit_message": "Fix test",
"patch_to_review": "diff --git a/mindsdb/integrations/handlers/ckan_handler/__about__.py b/mindsdb/integrations/handlers/ckan_handler/__about__.py\nnew file mode 100644\nindex 00000000000..b3d77fbd9b7\n--- /dev/null\n+... | [
{
"diff_hunk": "@@ -0,0 +1,92 @@\n+from ckanapi import RemoteCKAN as rc\n+import pandas as pd\n+\n+from mindsdb.integrations.libs.base_handler import DatabaseHandler\n+from mindsdb.integrations.libs.response import HandlerStatusResponse, HandlerResponse, RESPONSE_TYPE\n+from mindsdb_sql.parser.ast.base import A... | 0506b0502d9d1e420d0362060ff6d809bde416c9 | diff --git a/mindsdb/integrations/handlers/ckan_handler/README.md b/mindsdb/integrations/handlers/ckan_handler/README.md
new file mode 100644
index 00000000000..aee70ca0d26
--- /dev/null
+++ b/mindsdb/integrations/handlers/ckan_handler/README.md
@@ -0,0 +1,29 @@
+## CKAN Integration handler
+
+This handler is used to i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
jupyterhub__jupyterhub-1455@d3a3b8c | jupyterhub/jupyterhub | Python | 1,455 | Add db-upgrade test | This test is not run with pytest because it involves creating an additional virtualenv with older jupyterhub.
Fixes two migration bugs:
1. stamp the revision in `upgrade-db` to ensure that the right starting revision is used.
2. workaround issue in mysql, where an extra step is needed to allow dropping the `_server_i... | 2017-09-27T17:10:00Z | Error when running jupyterhub upgrade-db
**How to reproduce the issue**
Run `jupyterhub upgrade-db --db=mysql+pymysql://db_url_xxx`
**What you expected to happen**
DB is upgraded for 0.8
**What actually happens**
```
INFO [alembic.runtime.migration] Context impl MySQLImpl.
INFO [alembic.runtime.migration] ... | same error as #1162 which is closed
It probably can be solved by call check_db_revision before dbutil.upgrade(hub.db_url).
Got another error when running `jupyterhub upgrade-db --db=mysql+pymysql://db_url_xxx` after executed below sql to set alembic_version.
```
CREATE TABLE alembic_version (version_num VARCHAR(32) ... | [
{
"body": "**How to reproduce the issue**\r\nRun `jupyterhub upgrade-db --db=mysql+pymysql://db_url_xxx`\r\n\r\n**What you expected to happen**\r\nDB is upgraded for 0.8\r\n\r\n**What actually happens**\r\n```\r\nINFO [alembic.runtime.migration] Context impl MySQLImpl.\r\nINFO [alembic.runtime.migration] Will... | f79b71727b4b87db8300ca62feaf7b604b4974d2 | {
"head_commit": "d3a3b8ca19acfc0b50c02a308e150ffc536f8af3",
"head_commit_message": "test db-upgrade on travis",
"patch_to_review": "diff --git a/.travis.yml b/.travis.yml\nindex ce484ce557..12370e4c3f 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -13,6 +13,7 @@ env:\n services:\n - mysql\n - postgresql\n+... | [
{
"diff_hunk": "@@ -0,0 +1,33 @@\n+#!/usr/bin/env bash\n+set -e\n+\n+TMPDIR=$(mktemp -d)\n+ENVDIR=\"$TMPDIR/env\"\n+\n+# initialize the databases\n+bash \"$(dirname $0)\"/init-db.sh\n+\n+# create virtualenv with jupyterhub 0.7\n+echo \"creating virutalenv in $ENVDIR\"\n+python -m virtualenv \"$ENVDIR\"",
"l... | 122c989b7a701ec31177ae1a2cec77ea77d96d1e | diff --git a/.travis.yml b/.travis.yml
index ce484ce557..992a0fa4d9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -11,8 +11,8 @@ env:
global:
- ASYNC_TEST_TIMEOUT=15
services:
- - mysql
- - postgresql
+ - postgres
+ - docker
# installing dependencies
before_install:
@@ -21,10 +21,12 @@ before_install:
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jupyterhub__jupyterhub-939@eb5e755 | jupyterhub/jupyterhub | Python | 939 | more debugging and health checks for services | - log that external services are added (helps catch accidental external services due to missing fields)
- check connectivity of services with web endpoints periodically
closes #934 | 2017-01-16T14:36:40Z | Improve logging information for services
**How to reproduce the issue**
Configure a managed service, but forget to include the `command` argument (or other important ones, such as the URL)/
**What you expected to happen**
It would be nice is JupyterHub gave more information in the logging to indicate that a ma... | @ellisonbg Good suggestion 👍 | [
{
"body": "**How to reproduce the issue**\r\n\r\nConfigure a managed service, but forget to include the `command` argument (or other important ones, such as the URL)/\r\n\r\n**What you expected to happen**\r\n\r\nIt would be nice is JupyterHub gave more information in the logging to indicate that a managed serv... | 2effd3da1604658788e9265d29b112d956ce8fb3 | {
"head_commit": "eb5e755aa6e784b71b2eb35095b4d01b20fe1d4c",
"head_commit_message": "more debugging and health checks for services\n\n- log that external services are added (helps catch accidental external services due to missing fields)\n- check connectivity of services with web endpoints periodically",
"patch_t... | [
{
"diff_hunk": "@@ -160,6 +160,11 @@ class Service(LoggingConfigurable):\n def managed(self):\n \"\"\"Am I managed by the Hub?\"\"\"\n return bool(self.command)\n+ \n+ @property\n+ def kind(self):\n+ \"\"\"Am I managed (as text)\"\"\"",
"line": null,
"original_line": ... | 3efd2398cae3e42b5e8028a963e53161be459824 | diff --git a/jupyterhub/app.py b/jupyterhub/app.py
index 2e8834419e..3702e542a6 100644
--- a/jupyterhub/app.py
+++ b/jupyterhub/app.py
@@ -259,6 +259,9 @@ class JupyterHub(Application):
proxy_check_interval = Integer(30,
help="Interval (in seconds) at which to check if the proxy is running."
).tag(co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
kedro-org__kedro-3032@d64a9ef | kedro-org/kedro | Python | 3,032 | Add nightly build workflow and create an issue if it fails |
## Description
<!-- Why was this PR created? -->
Close https://github.com/kedro-org/kedro/issues/2970
## Development notes
<!-- What have you changed, and how has this been tested? -->
- Add nightly build + notification workflow to GHA similar to `kedro-plugins`
- Pin `azure-storage-blob < 12.18.0` - Temporar... | 2023-09-13T16:10:04Z | Add nightly build to tests on Github Actions
## Description
<!-- Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..." -->
Part of migration to GitHub Actions | [
{
"body": "## Description\r\n<!-- Is your feature request related to a problem? A clear and concise description of what the problem is: \"I'm always frustrated when ...\" -->\r\nPart of migration to GitHub Actions\r\n\r\n",
"number": 2970,
"title": "Add nightly build to tests on Github Actions"
}
] | df4a222a5a10386a3473145b8a8e2279b9ff9ef0 | {
"head_commit": "d64a9ef5e84eb7f8c56b7a4ba9c6c532bf27f37b",
"head_commit_message": "Pin azure-storage-blob version + add nightly build\n\nSigned-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>",
"patch_to_review": "diff --git a/.github/workflows/all-checks.yml b/.github/workflows/all-checks.yml\nindex 51ef... | [
{
"diff_hunk": "@@ -0,0 +1,29 @@\n+name: Run nightly tests on all plugins",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": ".github/workflows/nightly-build.yml",
"start_line": null,
"text": "@author:\n```suggestion\r\nname: Run nightly tests on Kedro\r\n```"
}
] | e243db0a359bf48f5b2154db5a8dc6e396544f4c | diff --git a/.github/workflows/all-checks.yml b/.github/workflows/all-checks.yml
index 51efe0e4db..5fe306d018 100644
--- a/.github/workflows/all-checks.yml
+++ b/.github/workflows/all-checks.yml
@@ -1,6 +1,7 @@
name: Run all checks on Kedro
on:
+ workflow_call:
push:
branches:
- main
diff --git a/.g... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} | |
jupyterhub__jupyterhub-1303@55000f9 | jupyterhub/jupyterhub | Python | 1,303 | consolidate server APIHandlers | no need for separate handlers for named and default servers
avoid claiming that empty responses are JSON.
Fixes 202 error handling by setting content-type: text/plain when sending empty responses.
Errors were raised in jQuery because response was empty but content-type header claimed it was application/json.
... | 2017-08-02T13:16:53Z | 'Stop server' raises an alert if it gets back a 202 Accepted
If stopping a server is slow, the JupyterHub API responds with a '202 Accepted'. The UI should do something with this - right now it just throws up an error box. | [
{
"body": "If stopping a server is slow, the JupyterHub API responds with a '202 Accepted'. The UI should do something with this - right now it just throws up an error box.",
"number": 1256,
"title": "'Stop server' raises an alert if it gets back a 202 Accepted"
}
] | f86202c07d6ba557d33bb3cfef2332d17581801d | {
"head_commit": "55000f98bcb84525d6d3f790601dffe190863bae",
"head_commit_message": "include non-empty body with 202 responses\n\nreply claims to be application/json, so make sure it has some content",
"patch_to_review": "diff --git a/jupyterhub/apihandlers/users.py b/jupyterhub/apihandlers/users.py\nindex 24e249... | [
{
"diff_hunk": "@@ -183,79 +183,49 @@ class UserServerAPIHandler(APIHandler):\n \"\"\"\n @gen.coroutine\n @admin_or_self\n- def post(self, name):\n+ def post(self, name, server_name=''):",
"line": null,
"original_line": 183,
"original_start_line": null,
"path": "jupyterhub/apih... | 57c8ad6b92f71e0c305dfef8316da70f20b81b50 | diff --git a/jupyterhub/apihandlers/users.py b/jupyterhub/apihandlers/users.py
index 24e2499317..23b235988d 100644
--- a/jupyterhub/apihandlers/users.py
+++ b/jupyterhub/apihandlers/users.py
@@ -156,9 +156,9 @@ def delete(self, name):
yield gen.maybe_future(self.authenticator.delete_user(user))
# remo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
kedro-org__kedro-3235@5c52557 | kedro-org/kedro | Python | 3,235 | Add name flag to kedro new | > **NOTE:** Kedro datasets are moving from `kedro.extras.datasets` to a separate `kedro-datasets` package in
> [`kedro-plugins` repository](https://github.com/kedro-org/kedro-plugins). Any changes to the dataset implementations
> should be done by opening a pull request in that repository.
## Description
<!-- Why w... | 2023-10-26T23:04:07Z | Addition `--name` `-n` argument for kedro new in non-interactive mode
## Description
<!-- Is your feature request related to a problem? A clear and concise description of what the problem is: "I'm always frustrated when ..." -->
When you have created a Kedro project and execute a kedro command on the CLI for the fi... | I've been looking for this in a loooong time, i definitely upvote this!
Tangentially related #1692
Can I also ask for telemetry consent at this point as well? For CI/CD workflows this is critical.
> Can I also ask for telemetry consent at this point as well? For CI/CD workflows this is critical.
Relate to
- #1640
... | [
{
"body": "## Description\r\n<!-- Is your feature request related to a problem? A clear and concise description of what the problem is: \"I'm always frustrated when ...\" -->\r\n\r\nWhen you have created a Kedro project and execute a kedro command on the CLI for the first time it asks a <project_name>. This is ... | ac551d5da8ffaa762beceec7c1cdef1c0812d8b8 | {
"head_commit": "5c52557facfbdf74bbb5dccf0842353e50f6b2dd",
"head_commit_message": "Test if names are set correctly\n\nSigned-off-by: lrcouto <laurarccouto@gmail.com>",
"patch_to_review": "diff --git a/kedro/framework/cli/starters.py b/kedro/framework/cli/starters.py\nindex bdb4f49294..e116d8ef0e 100644\n--- a/k... | [
{
"diff_hunk": "@@ -321,6 +328,7 @@ def new(config_path, starter_alias, selected_addons, checkout, directory, **kwar\n config = _fetch_config_from_user_prompts(prompts_required, cookiecutter_context)\n \n config = _get_addons_from_cli_input(selected_addons, config)\n+ config = _get_name_from_cli_... | 7caf1bd98ff8aa812271f95ac5ffa75e30f96b74 | diff --git a/RELEASE.md b/RELEASE.md
index 92aa726ba1..483e3f607b 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -27,6 +27,7 @@
### CLI
* Removed deprecated `kedro docs` command.
* Added the `--addons` flag to the `kedro new` command.
+* Added the `--name` flag to the `kedro new` command.
### ConfigLoader
* Made `O... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-2993@a66f4a5 | kedro-org/kedro | Python | 2,993 | Make dataset factory resolve nested dict properly | ## Description
<!-- Why was this PR created? -->
Fix #2992
- resolve config properly for nested dict
- resolve config properly for lists
## Development notes
<!-- What have you changed, and how has this been tested? -->
* I have updated the `DataCatalog._resolve_config()` function -
* To recursively call... | 2023-08-31T16:18:28Z | Dataset factories doesn't resolve nested config properly
## Description
Reported by @m-gris
Dataset factories does not work properly for config that is nested.
## Context
The problem is in `DataCatalog._resolve_config()`. It fills out the placeholder on top level keys properly but doesn't go into nested dicts.
... | Hi @ankatiyar,
I encountered the same problem and was about to post an issue when I found yours.
I think the config resolver also fails if an argument contains a list (not only a nested dict).
I was about to suggest something like this:
```python
def _resolve_config(
self,
data_set_name:... | [
{
"body": "## Description\r\nReported by @m-gris\r\nDataset factories does not work properly for config that is nested.\r\n\r\n## Context\r\nThe problem is in `DataCatalog._resolve_config()`. It fills out the placeholder on top level keys properly but doesn't go into nested dicts.\r\n\r\n## Steps to Reproduce\r... | ad002bdf5e36a2060c3339a73f226dfef24ee62b | {
"head_commit": "a66f4a59d34401bee14c6a706b868f20e0f7f468",
"head_commit_message": "Remove iterable\n\nSigned-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex 8d5cb62415..6f18db1fe1 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -11,6 +11,8 @@... | [
{
"diff_hunk": "@@ -840,7 +863,10 @@ def test_unmatched_key_error_when_parsing_config(\n ):\n \"\"\"Check error raised when key mentioned in the config is not in pattern name\"\"\"\n catalog = DataCatalog.from_config(**config_with_dataset_factories_bad_pattern)\n- pattern = \"Unable t... | 4e5ed69d74c8239ffb4636dbc72fb08640a19146 | diff --git a/RELEASE.md b/RELEASE.md
index 8d5cb62415..6f18db1fe1 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -11,6 +11,8 @@
## Major features and improvements
## Bug fixes and other changes
+* Updated dataset factories to resolve nested catalog config properly.
+
## Documentation changes
## Breaking changes to t... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jupyterhub__jupyterhub-1165@d76632d | jupyterhub/jupyterhub | Python | 1,165 | add hub_connect_ip | allows specifying the connect ip/hostname for the Hub when it differs from hub_ip (the bind address).
Used when the Hub is not on the same host as the spawners and/or proxy (e.g. docker, kubernetes, etc.)
One default change: when `hub_ip` is 0.0.0.0 (all-interfaces), the default connect ip is `socket.gethostname()` i... | 2017-06-06T10:52:53Z | Any way to give a different hub IP to singleuser servers?
My current setup uses Jupyterhub 0.7.2 in a docker container, using a modified version of the batchspawner to start singleuser servers on a cluster. `JupyterHub.hub_ip` is set to `0.0.0.0`, but it binds to `127.0.0.1`. This address is given to the singleuser se... | Setting `hub_ip` does set the bind ip. If you set this to 0.0.0.0, 127.0.0.1 is used for connecting unless overridden somewhere. Some Spawners (e.g. DockerSpawner) set a separate `hub_connect_ip`, but this should be handled at the Hub level so that different spawners don't need to reimplement this. I'll work on it. | [
{
"body": "My current setup uses Jupyterhub 0.7.2 in a docker container, using a modified version of the batchspawner to start singleuser servers on a cluster. `JupyterHub.hub_ip` is set to `0.0.0.0`, but it binds to `127.0.0.1`. This address is given to the singleuser server under the `--hub-api-url` argument... | 6810aba5e9105b97a2d04eea705a4aef9f944ebb | {
"head_commit": "d76632de917ea8070133a1983e1e095b73590a87",
"head_commit_message": "update tests for connect_ip changes",
"patch_to_review": "diff --git a/jupyterhub/app.py b/jupyterhub/app.py\nindex 4ba8018421..930b1977bd 100644\n--- a/jupyterhub/app.py\n+++ b/jupyterhub/app.py\n@@ -392,11 +392,26 @@ def _depre... | [
{
"diff_hunk": "@@ -26,10 +27,22 @@ class Server(HasTraits):\n orm_server = Instance(orm.Server, allow_none=True)\n \n ip = Unicode()\n+ connect_ip = Unicode()\n proto = Unicode('http')\n port = Integer()\n base_url = Unicode('/')\n cookie_name = Unicode('')\n+ \n+ @property\n+ ... | 1ddbf97c11855483c9f9d0ded55885505cbbf78b | diff --git a/jupyterhub/app.py b/jupyterhub/app.py
index 4ba8018421..930b1977bd 100644
--- a/jupyterhub/app.py
+++ b/jupyterhub/app.py
@@ -392,11 +392,26 @@ def _deprecated_proxy_api(self, change):
)
hub_port = Integer(8081,
- help="The port for this process"
+ help="The port for the Hub p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mindsdb__mindsdb-939@41e52c9 | mindsdb/mindsdb | Python | 939 | Install mindsdb from pypi in deploy step | Fixes #804
Release image (which created in a `deploy` step) needs to contain MindsDB version installed from PyPi repository (not from local source files) In this case we ensure that release image and PyPi have same version. | 2020-11-16T14:35:26Z | Pip install after deploy
As part of our github action testing suite we need to add a step/script that runs *after* the deploy to pypi and tries to install the latest `mindsdb` version deployed there.
This is because, in certain scenarios, the pypi version install can be different from the way we install it in when t... | Hi I'm new to opensource could you please explain what should has to be done in this issue? Do I need to install mindsdb on my local machine? | [
{
"body": "As part of our github action testing suite we need to add a step/script that runs *after* the deploy to pypi and tries to install the latest `mindsdb` version deployed there.\r\n\r\nThis is because, in certain scenarios, the pypi version install can be different from the way we install it in when tes... | 6655fd95668a3ca8c2c59a4a0a191acc78ae4b3a | {
"head_commit": "41e52c9ec57e69b8741797b12ad5db4e406a0887",
"head_commit_message": "wakey wakey GitHub Actions",
"patch_to_review": "diff --git a/.github/workflows/mindsdb.yml b/.github/workflows/mindsdb.yml\nindex a257195636c..698755549b6 100644\n--- a/.github/workflows/mindsdb.yml\n+++ b/.github/workflows/mind... | [
{
"diff_hunk": "@@ -68,6 +68,11 @@ jobs:\n CHECK_FOR_UPDATES: False\n DB_MACHINE_KEY: ${{secrets.DB_MACHINE_KEY}}\n DATABASE_CREDENTIALS: ${{secrets.DATABASE_CREDENTIALS}}\n+ - name: Install latest version from pypi (just testing)\n+ run: |\n+ sleep 20\n+ pip instal... | 767a26cf9308c72575a0c744852b35db42c0272a | diff --git a/.github/workflows/mindsdb.yml b/.github/workflows/mindsdb.yml
index a257195636c..42256979785 100644
--- a/.github/workflows/mindsdb.yml
+++ b/.github/workflows/mindsdb.yml
@@ -124,6 +124,11 @@ jobs:
python setup.py sdist
twine upload dist/*
+ - name: Install latest version from pypi
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
kedro-org__kedro-3145@105e06f | kedro-org/kedro | Python | 3,145 | Make `OmegaConfigLoader` accept paths containing dots outside of conf_source | > **NOTE:** Kedro datasets are moving from `kedro.extras.datasets` to a separate `kedro-datasets` package in
> [`kedro-plugins` repository](https://github.com/kedro-org/kedro-plugins). Any changes to the dataset implementations
> should be done by opening a pull request in that repository.
## Description
<!-- Why w... | 2023-10-09T15:12:22Z | Fix Configuration Loader to Handle Paths Containing dots
## Description
When working within Databricks workflows, it's possible to create a job that utilizes a notebook hosted inside a repository. Each time the job is executed, the code is automatically cloned to a path that depends on the commit. In my case, I have... | @erwinpaillacan Potential conflict requirements with https://github.com/kedro-org/kedro/pull/2977
Does it work with other ConfigLoader? And what will be the expected behavior?
We can hard coded for. ipynb_checkpoints but doesn't seem ideal to me.
I think we need to ignore internal folders but after project root, no... | [
{
"body": "## Description\r\n\r\nWhen working within Databricks workflows, it's possible to create a job that utilizes a notebook hosted inside a repository. Each time the job is executed, the code is automatically cloned to a path that depends on the commit. In my case, I have hosted a notebook that runs the K... | c21eeeabd7422ba8374a9ed55cb61f75cc0342c7 | {
"head_commit": "105e06f6e68baf6298eeb8461065d6938de8a0ac",
"head_commit_message": "Merge branch 'main' into bug/config-hidden-filepaths",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex c79395c06c..c77b871184 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -15,6 +15,7 @@\n \n ## Bug fixes and oth... | [
{
"diff_hunk": "@@ -6,6 +6,7 @@\n import io\n import logging\n import mimetypes\n+import os",
"line": null,
"original_line": 9,
"original_start_line": null,
"path": "kedro/config/omegaconf_config.py",
"start_line": null,
"text": "@user1:\nWe actually try to not use `os` if it's possible.... | fae6bc9189b571258e18df94f2f4792ba2f5372f | diff --git a/RELEASE.md b/RELEASE.md
index 77aa9855a9..5265599e40 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -15,6 +15,7 @@
## Bug fixes and other changes
* Updated dataset factories to resolve nested catalog config properly.
+* Updated `OmegaConfigLoader` to handle paths containing dots outside of `conf_source`.
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mindsdb__mindsdb-602@57900b1 | mindsdb/mindsdb | Python | 602 | table name escaping | close #593
this fix allow use via sql-interface predictors with names contains 'minus' and 'space' signs (and probably other else supported by current database) | 2020-07-20T13:25:23Z | DB exception when running mysql api
In the latest version on staging branch running mindsdb mysql api as ` python3 -m mindsdb --api mysql --config config.json` throws:
```
Using configuration file: config.json
Traceback (most recent call last):
File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module... | [
{
"body": "In the latest version on staging branch running mindsdb mysql api as ` python3 -m mindsdb --api mysql --config config.json` throws:\r\n\r\n```\r\nUsing configuration file: config.json\r\nTraceback (most recent call last):\r\n File \"/usr/local/lib/python3.7/runpy.py\", line 193, in _run_module_as_m... | dc6fc18b138e232a3f12bf267968c1366a77c804 | {
"head_commit": "57900b1e0a55895de9a1e4fdb216291caeb6b149",
"head_commit_message": "close #593 table name escaping",
"patch_to_review": "diff --git a/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py b/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py\nindex 17bad908487..597484d027c 100644\n--- a/mindsdb/api/m... | [
{
"diff_hunk": "@@ -100,10 +100,10 @@ def save_datasource(self, name, source_type, source, file_path=None):\n password = self.config['integrations']['default_mariadb']['password']\n host = self.config['integrations']['default_mariadb']['host']\n port = self.config['integratio... | 6d6ac0de23551043c183e733bf70a76aaa850d09 | diff --git a/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py b/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py
index 17bad908487..597484d027c 100644
--- a/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py
+++ b/mindsdb/api/mysql/mysql_proxy/classes/sql_query.py
@@ -166,7 +166,7 @@ def _parseQuery(self, sql):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
mindsdb__mindsdb-483@612d9c2 | mindsdb/mindsdb | Python | 483 | Hotfix: Unit test file structure, pytest back to travis | 2020-06-11T09:21:29Z | Figure out the issues related to data analysis v2
Since the 1.21.0 release @setohe0909 has reported some issues, we should sync with him to figure out what they are and how to solve them.
Issues running unit tests in travis
At the moment travis seems to silently fail if I add `pytests` to the `.travis.yml`, but I see ... | I have am 100% against the tests being in the same thing they are testing.
It goes against all conventions, completely. Nobody does that.
Tests are a lot of code. Tests can easily grow way larger than the thing they are testing. It's a lot of useless clutter for developers. Also if you are distributing the code som... | [
{
"body": "Since the 1.21.0 release @setohe0909 has reported some issues, we should sync with him to figure out what they are and how to solve them.",
"number": 479,
"title": "Figure out the issues related to data analysis v2"
},
{
"body": "At the moment travis seems to silently fail if I add `p... | ed07cef222522e9899fd1c7cb41d3bdf4d4fd7e1 | {
"head_commit": "612d9c2423fa8f24b2c677c97c375b4bb9461821",
"head_commit_message": "New unit test structure, readme additions, pytest back to travis, add test requirements to setup.py tests_require",
"patch_to_review": "diff --git a/.travis.yml b/.travis.yml\nindex 15170a8dca5..f95f309f907 100644\n--- a/.travis.... | [
{
"diff_hunk": "@@ -132,8 +133,8 @@ def get_value_bucket(value, buckets, col_stats, hmd=None):\n \n elif col_stats['data_subtype'] in (DATA_SUBTYPES.BINARY, DATA_SUBTYPES.INT, DATA_SUBTYPES.FLOAT):\n bucket = closest(buckets, value)\n- elif col_stats['data_subtype'] in (DATA_SUBTYPES.IMAGE) and h... | 44385bdc1a59eebdcb374a689be2c37155cb18fb | diff --git a/.travis.yml b/.travis.yml
index 15170a8dca5..94e91788e95 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -53,10 +53,12 @@ cache: pip
install:
- if [ "$TRAVIS_OS_NAME" != "windows" ]; then travis_wait 15 pip3 install --upgrade pip; fi
- if [ "$TRAVIS_OS_NAME" = "windows" ]; then travis_wait 15 pip inst... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} | |
mindsdb__mindsdb-452@67db1bc | mindsdb/mindsdb | Python | 452 | Data Analytics Backend V2 | * Resolves #450
* Resolves #435 (Not fully, but what it doesn't, is now part of other issues)
* Adds a new data cleaning phase that runs multiple times (much less complex than other phases).
* Major refactoring to the StatsGenerator that greatly simplify the logic and remove a bunch of bugs, that being said, the or... | 2020-05-28T07:06:07Z | Various improvements to the Data Analysis
There will be various improvements to the Data Analysis phase for version 1.20.0 (compatible with scout version 2.0).
For now I will keep track of all of them here, if some of them require their own issue we can open them later.
Currently still discussing the changes arou... | [
{
"body": "There will be various improvements to the Data Analysis phase for version 1.20.0 (compatible with scout version 2.0).\r\n\r\nFor now I will keep track of all of them here, if some of them require their own issue we can open them later.\r\n\r\nCurrently still discussing the changes around this interna... | 51701d605e294d1c0309d706af762dbc9a77797d | {
"head_commit": "67db1bc46ae4d8dd7b60462e1268c18769b02019",
"head_commit_message": "removed debugging logic",
"patch_to_review": "diff --git a/mindsdb/__about__.py b/mindsdb/__about__.py\nindex 064f9484ebf..5628949b489 100755\n--- a/mindsdb/__about__.py\n+++ b/mindsdb/__about__.py\n@@ -1,6 +1,6 @@\n __title__ = ... | [
{
"diff_hunk": "@@ -0,0 +1,36 @@\n+import random\n+import numpy as np\n+\n+from mindsdb.external_libs.stats import calculate_sample_size\n+from mindsdb.libs.constants.mindsdb import *\n+from mindsdb.libs.helpers.text_helpers import clean_float\n+\n+def sample_data(df, sample_margin_of_error, sample_confidence_l... | d35e0ec862af57aa13878b6d6fc3c0cfe67c1b5b | diff --git a/mindsdb/__about__.py b/mindsdb/__about__.py
index 064f9484ebf..5628949b489 100755
--- a/mindsdb/__about__.py
+++ b/mindsdb/__about__.py
@@ -1,6 +1,6 @@
__title__ = 'MindsDB'
__package_name__ = 'mindsdb'
-__version__ = '1.17.9'
+__version__ = '1.18.0'
__description__ = "MindsDB's goal is to make it very ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
kedro-org__kedro-2306@f54f95d | kedro-org/kedro | Python | 2,306 | Add new function to specify namespace for `KedroSession` and `kedro run` | > **NOTE:** Kedro datasets are moving from `kedro.extras.datasets` to a separate `kedro-datasets` package in
> [`kedro-plugins` repository](https://github.com/kedro-org/kedro-plugins). Any changes to the dataset implementations
> should be done by opening a pull request in that repository.
## Description
<!-- Why w... | 2023-02-10T07:13:53Z | Add an option to run a specific namespace in `KedroSession` run and `kedro run`
## Description
Currently there's a way to select different sections from a pipeline to run, but selecting by namespace is missing. We should add a way for users to run a specific subpipeline (namespace) by executing this in the terminal:... | This should be `multiple=False` just like pipeline | [
{
"body": "## Description\r\n\r\nCurrently there's a way to select different sections from a pipeline to run, but selecting by namespace is missing. We should add a way for users to run a specific subpipeline (namespace) by executing this in the terminal:\r\n\r\n```\r\nkedro run --namespace data_engineering.pre... | d52fd50a334d86ba3245b956a5d85ab6f6ac6401 | {
"head_commit": "f54f95dca6186d8d93bf6c27c1be25e4688c668a",
"head_commit_message": "Fix broken tests and update new test for namespace argument\n\nSigned-off-by: Nok Chan <nok.lam.chan@quantumblack.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex c28405b148..3ba79aef7c 100644\n--- a/RELEASE... | [
{
"diff_hunk": "@@ -19,6 +19,7 @@\n * Save node outputs after every `yield` before proceeding with next chunk.\n * Fixed incorrect parsing of Azure Data Lake Storage Gen2 URIs used in datasets.\n * Added support for loading credentials from environment variables using `OmegaConfigLoader`.\n+* Added new abilit... | a1acb12e4443b7b9e87da3ecbf64614649fc7e21 | diff --git a/RELEASE.md b/RELEASE.md
index f800f3c086..4429027e83 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -19,6 +19,7 @@
* Save node outputs after every `yield` before proceeding with next chunk.
* Fixed incorrect parsing of Azure Data Lake Storage Gen2 URIs used in datasets.
* Added support for loading creden... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-2061@7212428 | kedro-org/kedro | Python | 2,061 | Revise visualisation documentation for Plotly charts, Matplotlib | This PR is now ready for review.
## Description
Resolves kedro-org/kedro#1949
I've made some improvements to the docs for Kedro-Viz in the "Visualisation with Kedro-Viz" section:
* Readability changes in the pages that introduce kedro viz and plotly reporting
* Improvements to use the spaceflights starter (... | 2022-11-24T10:29:43Z | Improve visualisation sections for the basics and for Plotly reporting
## Description
The Kedro-Viz section of the docs needs to be updated. There are currently 3 pages and this issue is to address the first 2 pages "Get started" and "Visualise charts" in detail to make improvements for readability, clarity and corr... | There's a PR outstanding for this (see above #2061) but we are blocked on a bug in the example code (explained on Slack https://github.com/kedro-org/kedro-viz/issues/1205) and a bug in Kedro Viz (https://github.com/kedro-org/kedro-viz/issues/1205) | [
{
"body": "## Description\r\n\r\nThe Kedro-Viz section of the docs needs to be updated. There are currently 3 pages and this issue is to address the first 2 pages \"Get started\" and \"Visualise charts\" in detail to make improvements for readability, clarity and correctness.\r\n\r\nThe final section on experim... | 4f87d77dd41076009a47291c3c662f80d351b8c2 | {
"head_commit": "7212428c3cbe62159c8e27dabd1e92d4b3e1ee09",
"head_commit_message": "Reduce diagram width",
"patch_to_review": "diff --git a/docs/source/contribution/contribute_to_kedro.md b/docs/source/contribution/contribute_to_kedro.md\nindex 51a1aa594d..2695589711 100644\n--- a/docs/source/contribution/contri... | [
{
"diff_hunk": "@@ -1,31 +1,33 @@\n # Set up experiment tracking\n \n-Experiment tracking is the process of saving all machine-learning related experiment information so that it is easy to find and compare past runs. [Kedro-Viz](https://github.com/kedro-org/kedro-viz) supports native experiment tracking from [v... | 14ceb8cceee81067a1e3ce850d89727a0f8d2787 | diff --git a/docs/source/contribution/contribute_to_kedro.md b/docs/source/contribution/contribute_to_kedro.md
index 51a1aa594d..2695589711 100644
--- a/docs/source/contribution/contribute_to_kedro.md
+++ b/docs/source/contribution/contribute_to_kedro.md
@@ -5,7 +5,7 @@ We welcome any and all contributions to Kedro, at... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-2073@b5f00d5 | kedro-org/kedro | Python | 2,073 | Remove outdated credentials.yml warning | Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
## Description
Fixes #1952
**Note:** Tests for credentials handling live in `test_data_catalog.py`
<!-- Why was this PR created? -->
## Development notes
<!-- What have you changed, and how has this been tested? -->
## Checklist
- [ ] Re... | 2022-11-28T18:01:13Z | Remove/change log level for "Credentials not found in your Kedro project config"
## Description
When getting the credentials in the KedroContext, we specifically look for the `credentials` file. If a project doesn't make use of this file a warning log will be thrown saying "Credentials not found in your Kedro project ... | [
{
"body": "## Description\r\nWhen getting the credentials in the KedroContext, we specifically look for the `credentials` file. If a project doesn't make use of this file a warning log will be thrown saying \"Credentials not found in your Kedro project config\". Not all users use the credentials file and so thi... | e598bfc8ac0a6aa30b4c6c468b0c1300fa3142d6 | {
"head_commit": "b5f00d5a5c3bc5f4e46d00f8e1ec149d8ca6e345",
"head_commit_message": "Remove warning and add tests\n\nSigned-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>",
"patch_to_review": "diff --git a/kedro/framework/context/context.py b/kedro/framework/context/context.py\nindex df7ad635ab..936758bb21 ... | [
{
"diff_hunk": "@@ -42,10 +43,16 @@ def _get_credentials(\n Raises:\n KeyError: When a data set with the given name has not yet been\n registered.\n+ MissingConfigError: When no credentials file is found in the\n+ project.\n \n \"\"\"\n try:\n return cre... | d1a7a7f7932ed3f666f52ae18d026bf25bb2f8ad | diff --git a/RELEASE.md b/RELEASE.md
index 043a9bbd6c..769c990e46 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -25,6 +25,7 @@
* Fixed bug causing `load_ipython_extension` not to register the `%reload_kedro` line magic when called in a directory that does not contain a Kedro project.
* Added anyconfig's `ac_context` pa... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
kedro-org__kedro-1773@6932a2c | kedro-org/kedro | Python | 1,773 | Provide useful error message when trying to run specific nodes within namespaces | ## Description
<!-- Why was this PR created? -->
This PR addresses [this issue](https://github.com/kedro-org/kedro/issues/1301); currently omitting a namespace when trying to run individual nodes results in an uninformative Value Error:
> ValueError: Pipeline does not contain nodes named ['preprocess_companies_n... | 2022-08-09T13:19:24Z | [KED-2422] Provide useful error message when trying to run specific nodes within namespaces
(transfer from Jira, created by @datajoely)
### Description
Responded to wizard thread on slack.
The user was trying to run `kedro run -n [node_name]` this was not working for the user since they were trying to run a node... | We could also say the node name `'generate_performance_report' is available under the following namespaces ['a', 'b', 'c'], did you mean to specify any of those?`? | [
{
"body": "(transfer from Jira, created by @datajoely)\r\n\r\n### Description\r\nResponded to wizard thread on slack.\r\n\r\nThe user was trying to run `kedro run -n [node_name]` this was not working for the user since they were trying to run a node that actually lived within a namespace so he actually needed t... | f4914201d7f6f38318c2c1f074fcdf802b3e1e0d | {
"head_commit": "6932a2c5a9bcc8231b816ac0c6b6b4ca4c7a0260",
"head_commit_message": "Add comments to tests\n\nSigned-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex 6ae6981e90..20bb0f06e3 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -15,6 +1... | [
{
"diff_hunk": "@@ -791,6 +791,56 @@ def test_only_nodes_unknown(self, pipeline_list_with_lists, target_node_names):\n with pytest.raises(ValueError, match=pattern):\n full.only_nodes(*target_node_names)\n \n+ @pytest.mark.parametrize(\n+ \"namespaced_node\", [\"node1\", \"node2\",... | c188157098b0a9637b081bcc78ed8665a35ddcd5 | diff --git a/RELEASE.md b/RELEASE.md
index a91be4bb07..4fa46a8130 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -15,6 +15,7 @@
## Bug fixes and other changes
* Use default `False` value for rich logging `set_locals`, to make sure credentials and other sensitive data isn't shown in logs.
+* When using `kedro run -n [s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-1795@d1b6693 | kedro-org/kedro | Python | 1,795 | Improve resume pipeline suggestion for SequentialRunner | ## Description
<!-- Why was this PR created? -->
Resolves [#1477](https://github.com/kedro-org/kedro/issues/1477)
## Development notes
<!-- What have you changed, and how has this been tested? -->
After a failed run, Kedro suggests a command to the user:
`You can resume the pipeline run by adding the followin... | 2022-08-18T14:09:39Z | [KED-2857] Suggestion for re-run command on failure, i.e. kedro run --from-nodes, should take into account memory dataset
(transfer from Jira, created by @limdauto)
Currently, when a pipeline fails, there is a suggested command to re-run the pipeline from a particular node. However, if the inputs to this node are Memo... | [
{
"body": "(transfer from Jira, created by @limdauto)\n\nCurrently, when a pipeline fails, there is a suggested command to re-run the pipeline from a particular node. However, if the inputs to this node are MemoryDataSet, the pipeline won't be run correctly. A user suggested that Kedro would back track to the l... | 46a8f0310eb533af77ef9c3ab6fa2ed611188a17 | {
"head_commit": "d1b6693e5259e10d11b215309896c0e499760c1e",
"head_commit_message": "Merge branch 'main' into feat/improve-resume-scenario-suggestion",
"patch_to_review": "diff --git a/kedro/runner/parallel_runner.py b/kedro/runner/parallel_runner.py\nindex ee744d5871..89dd4ce41c 100644\n--- a/kedro/runner/parall... | [
{
"diff_hunk": "@@ -157,31 +158,121 @@ def create_default_data_set(self, ds_name: str) -> AbstractDataSet:\n Returns:\n An instance of an implementation of ``AbstractDataSet`` to be\n used for all unregistered datasets.\n-\n \"\"\"\n pass\n \n def _suggest_res... | 74d0cecff87f03b14f57916b240e3a2e30c39216 | diff --git a/kedro/runner/parallel_runner.py b/kedro/runner/parallel_runner.py
index ee744d5871..f19846b71b 100644
--- a/kedro/runner/parallel_runner.py
+++ b/kedro/runner/parallel_runner.py
@@ -332,11 +332,7 @@ def _run( # pylint: disable=too-many-locals,useless-suppression
break # pragma: no co... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
kedro-org__kedro-1746@037d3d6 | kedro-org/kedro | Python | 1,746 | Implement support for schema in saving dask parquet (#1736) | Signed-off-by: Aivin V. Solatorio <avsolatorio@gmail.com>
## Description
Resolves: https://github.com/kedro-org/kedro/issues/1736
## Development notes
This change allows the use of the schema argument in the `dask.to_parquet` API from kedro's `dask.ParquetDataSet`.
A custom parser for the schema is implement... | 2022-08-01T18:07:36Z | Support for defining a pyarrow schema for dask.ParquetDataSet in catalog.yml
## Description
I am working on a pipeline that outputs a dask ParquetDataSet. The inferred schema is not accurate, so I need to specify the schema manually. I don't think the current implementation supports the definition of complex schema, e... | We'd very much appreciate a PR @avsolatorio ! This sounds like a useful addition.
> We'd very much appreciate a PR @avsolatorio ! This sounds like a useful addition.
PR opened for this @datajoely : https://github.com/kedro-org/kedro/pull/1746 :) | [
{
"body": "## Description\r\nI am working on a pipeline that outputs a dask ParquetDataSet. The inferred schema is not accurate, so I need to specify the schema manually. I don't think the current implementation supports the definition of complex schema, e.g., nested list of int64.\r\n\r\n## Context\r\nThis cha... | edf08f4dc003d49700a9a2b6410d71577e637cc6 | {
"head_commit": "037d3d6b7318ec1a2287f1df1babeda7e383b0c8",
"head_commit_message": "Implement support for schema in saving dask parquet (#1736)\n\nSigned-off-by: Aivin V. Solatorio <avsolatorio@gmail.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex c85f122778..37c291fee3 100644\n--- a/RELEA... | [
{
"diff_hunk": "@@ -128,8 +152,63 @@ def _load(self) -> dd.DataFrame:\n )\n \n def _save(self, data: dd.DataFrame) -> None:\n+ self._process_schema()\n data.to_parquet(self._filepath, storage_options=self.fs_args, **self._save_args)\n \n+ def _process_schema(self) -> None:\n+ ... | 5b2c8efb9fcd583e93b4a279c782d680c714f6a8 | diff --git a/RELEASE.md b/RELEASE.md
index c85f122778..7cd8d6a862 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -22,6 +22,7 @@
| `video.VideoDataSet` | Read and write video files from a filesystem | `kedro.extras.datasets.video` |
| `video.video_dataset.SequenceVideo` | Cr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-1642@630b00f | kedro-org/kedro | Python | 1,642 | Fix/the `getpass.getuser()` call fails when no user is present | ## Description
Fixes #1624.
## Development notes
We now wrap the call in a `try-except` block to prevent the failure.
## Checklist
- [x] Read the [contributing](https://github.com/kedro-org/kedro/blob/main/CONTRIBUTING.md) guidelines
- [ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progre... | 2022-06-22T14:24:21Z | KedroSession: getpass.getuser() call fails
## Description
First of all, I want to thank you for this splendid work that is Kedro. I believe it makes our life easier and I am glad that we have adopted it at my company.
This is the first time that I post an issue here, so I hope to frame this correctly!
In my compan... | Hello @naikio and thank you for your comments! Very pleased to hear that kedro makes your life easier 🙂 Do you mind me asking what your company is?
Thanks for the very clear bug report. You're right that that this `username` isn't currently used anywhere, and your current workaround of setting `USERNAME` in an envi... | [
{
"body": "## Description\r\nFirst of all, I want to thank you for this splendid work that is Kedro. I believe it makes our life easier and I am glad that we have adopted it at my company.\r\nThis is the first time that I post an issue here, so I hope to frame this correctly!\r\n\r\nIn my company, we are using ... | a925fd59187a642e124527f0f1097e92ea8d1819 | {
"head_commit": "630b00f704d742e207ecd00dc4b85ef20e657c39",
"head_commit_message": "Lint and improve test\n\nSigned-off-by: Antony Milne <antony.milne@quantumblack.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex 57ec4d926a..511baae0ce 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -29,6 +2... | [
{
"diff_hunk": "@@ -496,6 +496,28 @@ def test_git_describe_error(\n ]\n assert actual_log_messages == expected_log_messages\n \n+ def test_get_username_error(self, fake_project, mock_package_name, mocker, caplog):\n+ \"\"\"Test that username information is not added to the session stor... | 6dd16fe096f9a5f0f855633b6378e95cd7f1df67 | diff --git a/RELEASE.md b/RELEASE.md
index 57ec4d926a..511baae0ce 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -29,6 +29,7 @@
* Bumped the upper bound for the Flake8 dependency to <5.0.
* `kedro jupyter notebook/lab` no longer reuses a Jupyter kernel.
* Required `cookiecutter>=2.1.1` to address a [known command injec... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
microsoft__autogen-6747@39aa458 | microsoft/autogen | Python | 6,747 | Fix GraphFlow to support multiple task execution without explicit reset | ## Problem
When using GraphFlow with a termination condition, the second task execution would immediately terminate without running any agents. The first task would run successfully, but subsequent tasks would skip all agents and go directly to the stop agent.
This was demonstrated by the following issue:
```python
... | 2025-07-03T16:10:13Z | bug: GraphFlow with termination condition automatically ends after first query.
### What happened?
**Describe the bug**
When I run GraphFlow API and using a termination condition, it would not continue conversation without resetting team state.
**To Reproduce**
Steps to reproduce the behavior. Please include code and... | Thanks @Ronaldo93
@copliot could you fix this bug? Use the following test case in `python/packages/autogen-agentchat/tests/test_group_chat_graph.py`
```python
@pytest.mark.asyncio
async def test_digraph_group_chat_multiple_task_execution(runtime: AgentRuntime | None) -> None:
"""Test that GraphFlow can run multip... | [
{
"body": "### What happened?\n\n**Describe the bug**\nWhen I run GraphFlow API and using a termination condition, it would not continue conversation without resetting team state.\n\n**To Reproduce**\nSteps to reproduce the behavior. Please include code and outputs such as stacktrace.\n\n- If your input is just... | aa0d835f4dd966f45bcd5d0fa354f88993ee70bc | {
"head_commit": "39aa458aa8e694910792e1504f09f263c5c5d923",
"head_commit_message": "Refactor GraphFlowManager to preserve message history and extract reset logic\n\nCo-authored-by: ekzhu <320302+ekzhu@users.noreply.github.com>",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agent... | [
{
"diff_hunk": "@@ -478,20 +478,22 @@ async def select_speaker(self, thread: Sequence[BaseAgentEvent | BaseChatMessage\n async def validate_group_state(self, messages: List[BaseChatMessage] | None) -> None:\n pass\n \n+ def _reset_execution_state(self) -> None:\n+ \"\"\"Reset the graph exe... | cfaf09a7a7e489704c0b194b55794e58de6aaa59 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/teams/_group_chat/_graph/_digraph_group_chat.py b/python/packages/autogen-agentchat/src/autogen_agentchat/teams/_group_chat/_graph/_digraph_group_chat.py
index aaca418df92b..544afb2224e2 100644
--- a/python/packages/autogen-agentchat/src/autogen_agent... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
kedro-org__kedro-1604@8a21f37 | kedro-org/kedro | Python | 1,604 | Consistent node execution order by sorting node with `Sequentialrunner` | Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
## Description
<!-- Why was this PR created? -->
#1350
## Development notes
<!-- What have you changed, and how has this been tested? -->
The trickiest part of the PR is actually the test. It's not straightforward to reproduce the random behaviour. If y... | 2022-06-09T13:18:21Z | Consistent nodes execution order with `SequentialRunner`
## Description
I'm always frustrated when I execute an identical pipeline it can yield different results. The root cause of this issue is due to the fact that multiple combinations of nodes exists. Kedro only try to solve the DAGs by finding 1 possible solution,... | So on this - we use the `toposort~=1.5` external library, since Kedro was released there is now a stdlib https://docs.python.org/3/library/graphlib.html module that does the same thing. If we do look into making this deterministic, it might be a good opportunity to adopt this too.
Note: currently we are using a functio... | [
{
"body": "## Description\r\nI'm always frustrated when I execute an identical pipeline it can yield different results. The root cause of this issue is due to the fact that multiple combinations of nodes exists. Kedro only try to solve the DAGs by finding 1 possible solution, but it is not guaranteed to be the ... | 4710b6c9ae0aed895deb9612108fdcd5a26c029f | {
"head_commit": "8a21f37a726d145b7e0ab2df674c5d3599eb124b",
"head_commit_message": "Merge branch 'main' into feat/consistent_node_execution_order_with_sequential_runner",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex ae71953088..e40bae5552 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -25,9 +2... | [
{
"diff_hunk": "@@ -588,6 +592,52 @@ def test_connected_pipeline(self, disjoint_pipeline):\n assert len(pipeline.inputs()) == 1\n assert len(pipeline.outputs()) == 1\n \n+ def test_pipeline_consistent_nodes_order(self, mocker):\n+ \"\"\"\n+ Pipeline that have multiple possib... | 90126e6287fc5b69551e3be842aa3e2ee6f7de35 | diff --git a/RELEASE.md b/RELEASE.md
index 5bf3cb45e8..57ec4d926a 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -25,10 +25,12 @@
* Reduced number of log lines by changing the logging level from `INFO` to `DEBUG` for low priority messages.
* Kedro's framework-side logging configuration no longer performs file-based logg... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
microsoft__autogen-6678@7e31ee1 | microsoft/autogen | Python | 6,678 | Fix output task messages 6150 | ## Why are these changes needed?
The existing run_stream methods used fragile count-based logic (count <= len(task)) to skip task messages during streaming. This approach was brittle and broke when team structure changed or task composition varied, particularly affecting SocietyOfMindAgent's ability to properly enca... | 2025-06-14T06:33:01Z | Adding a `output_task_messages` to `run_stream` methods to avoid messages in `task` are included.
### Confirmation
- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.
### Issue body
Help `SocietyOfMi... | [
{
"body": "### Confirmation\n\n- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.\n\n### Issue body\n\nHelp `SocietyOfMindAgent` to avoid fragile counting-based skipping of task messages. Also,... | c150f850446974c12f64fbcd896f8868daa9009b | {
"head_commit": "7e31ee1a57e9636c68001cfa1ef2b3a137c4c983",
"head_commit_message": "refactor: added output_task_messages flag in the BaseGroupChatManager",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_base_chat_agent.py b/python/packages/autogen-agentchat/src/a... | [
{
"diff_hunk": "@@ -504,7 +511,18 @@ async def stop_runtime() -> None:\n # Collect the output messages in order.\n output_messages: List[BaseAgentEvent | BaseChatMessage] = []\n stop_reason: str | None = None\n- # Yield the messsages until the queue is empty.\n+ ... | dba704c87b1316581c71d4a6aff256215b66b38e | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_base_chat_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_base_chat_agent.py
index 6f9c067428ea..ea4a74a28e62 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_base_chat_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
kedro-org__kedro-1612@b0c9375 | kedro-org/kedro | Python | 1,612 | Generic typings abstract dataset | Signed-off-by: Niels Drost <codingdutchman@gmail.com>
## Description
Resolves #1564
## Development notes
Only generic types have been added for `AbstractDataSet` and `AbstractVersionedDataSet`, to define load and save types.
In all classes in extras that use before mentioned classes, the correct types have be... | 2022-06-12T15:57:53Z | Feature: make AbstractDataset take data type as generic parameter.
## Description
Abstract dataset is currently incompletely typed, as _load and _save use "Any".
## Context
I would like to write typed code.
## Possible Implementation
Use:
```
class AbstractDataset(Generic[DS]): ...
```
If necessary f... | Hi @shaunc, thanks very much for the suggestion! This sounds like a very good idea, but I just want to understand it a bit better since I'm not quite sure how you would intend to use it in practice?
Are you just suggesting that we add the `Generic` to `AbstractDataset` inheritance + `_load` + `_save` methods or are ... | [
{
"body": "## Description\r\n\r\nAbstract dataset is currently incompletely typed, as _load and _save use \"Any\".\r\n\r\n## Context\r\n\r\nI would like to write typed code.\r\n\r\n## Possible Implementation\r\n\r\nUse:\r\n```\r\nclass AbstractDataset(Generic[DS]): ...\r\n```\r\nIf necessary for deprecation, co... | 1e16196987fc10dc191fd7aa9fe5ea2db92f84c3 | {
"head_commit": "b0c93757cc6abbec024579e50cd46b0ff0abaf41",
"head_commit_message": "fixed tests\n\nSigned-off-by: Niels Drost <codingdutchman@gmail.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex 1bf296a84f..1fe5f2efa2 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -25,6 +25,7 @@\n * Reduc... | [
{
"diff_hunk": "@@ -21,7 +21,7 @@\n HoloViews = TypeVar(\"HoloViews\")\n \n \n-class HoloviewsWriter(AbstractVersionedDataSet):\n+class HoloviewsWriter(AbstractVersionedDataSet[HoloViews, str]):",
"line": null,
"original_line": 24,
"original_start_line": null,
"path": "kedro/extras/datasets/holo... | d8d45613e50f1685d1acdf0a3cbd8aa694fdc1d3 | diff --git a/RELEASE.md b/RELEASE.md
index 174a8d2935..6630cb511a 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -31,6 +31,7 @@
* `kedro jupyter notebook/lab` no longer reuses a Jupyter kernel.
* Required `cookiecutter>=2.1.1` to address a [known command injection vulnerability](https://security.snyk.io/vuln/SNYK-PYTHON... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
microsoft__autogen-6653@48e1227 | microsoft/autogen | Python | 6,653 | OTel GenAI Traces for Agent and Tool | Add OTel GenAI traces:
- `create_agent`
- `invoke_agnet`
- `execute_tool`
Introduces context manager helpers to create these traces. The helpers also serve as instrumentation points for other instrumentation libraries.
Resolves #6644 | 2025-06-09T11:02:10Z | OTel traces should follow semantic convention for GenAI
### Confirmation
- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.
### Issue body
Make sure the trace implementations follow the GenAI semant... | [
{
"body": "### Confirmation\n\n- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.\n\n### Issue body\n\nMake sure the trace implementations follow the GenAI semantic convention. ",
"number":... | 892492f1d99b8f5a1eb616d7b5d02d4b414e0687 | {
"head_commit": "48e1227b2a3760e96cdb6de5e3494c56c4eb742f",
"head_commit_message": "Merge branch 'main' into ekzhu-otel-genai",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_ass... | [
{
"diff_hunk": "@@ -0,0 +1,174 @@\n+from collections.abc import Generator\n+from contextlib import contextmanager\n+from typing import Any, Optional\n+\n+from opentelemetry import trace\n+from opentelemetry.semconv._incubating.attributes.gen_ai_attributes import (\n+ GEN_AI_AGENT_DESCRIPTION,\n+ GEN_AI_AG... | 68db1e4684370a0ceb04676b6dfa55764ca7ed12 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
index 66cee0b7c3c8..905df4f9d3e9 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
microsoft__autogen-6645@12d8528 | microsoft/autogen | Python | 6,645 | Feature/agentchat message id field 6317 | ## Why are these changes needed?
This PR implements unique ID fields for AgentChat messages to enable proper correlation between streaming chunks and completed messages. Currently, there's no way to correlate `ModelClientStreamingChunkEvent` chunks with their eventual completed message, which can lead to duplicate m... | 2025-06-07T10:57:43Z | AgentChat messages should have an `id` field.
### Confirmation
- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.
### Issue body
Message id is useful to correlate `ModelClientStreamingChunkEvent` wi... | Hi @ekzhu, I'm interested in working on this, my initial thought was https://github.com/microsoft/autogen/pull/6351.
Currently I'm not sure if the "consumer" refers to a `Console()` call, could you help to explain a bit more? If it's, I haven't figured out the necessity of maintaining a `full_message_id`. For example,... | [
{
"body": "### Confirmation\n\n- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.\n\n### Issue body\n\nMessage id is useful to correlate `ModelClientStreamingChunkEvent` with the eventual compl... | 3436ec2ca1999ea9ac8c05fb9389fd2913e3bedd | {
"head_commit": "12d8528bbe2ab4a7a4e3820d9f9d17ae026eb08c",
"head_commit_message": "fix: used default factory unless for streaming chunk events",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_age... | [
{
"diff_hunk": "@@ -655,6 +646,9 @@ async def run_reasoning_agent() -> None:\n component_config_schema = AssistantAgentConfig\n component_provider_override = \"autogen_agentchat.agents.AssistantAgent\"\n \n+ # Store correlation between CreateResult objects and message IDs\n+ _message_id_map: Dict[... | 000009528c2e71151a2f4e99618e8b737ae3b8c8 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
index 905df4f9d3e9..6ecf6cf737b5 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-1500@b8bced8 | kedro-org/kedro | Python | 1,500 | Reduce Kedro package size by removing docs from it | Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
## Description
<!-- Why was this PR created? -->
Kedro 0.18.0 is 112MB unpackaged, and 111MB of that is just from docs. For faster installations and reducing disk usage, this PR will remove docs from kedro package and alias `kedro docs` cli... | 2022-05-04T13:33:29Z | Reduce Kedro package size by removing the docs from kedro
## Description
The kedro wheel is 87MB big. Kedro is 114MB big on disk. Most of that (112MB) is assets used for the website framework, like for example 70MB of images.
## Context
Fast installation means shorter cicd loops. Small disk usage means easier f... | +💯 for this. Kedro 0.18 is now 112MB unpackaged, and 111MB of that is just docs.
Just to give some context: the reason that the docs are part of the package is because historically there were instances where people were using locked down environments in which they could `pip install kedro` but didn't have access t... | [
{
"body": "## Description\r\n\r\nThe kedro wheel is 87MB big. Kedro is 114MB big on disk. Most of that (112MB) is assets used for the website framework, like for example 70MB of images. \r\n\r\n## Context\r\nFast installation means shorter cicd loops. Small disk usage means easier for edge devices.\r\n\r\n## Po... | 7c5b55f7edbfa57b48014f89b93a2cc9cf1ba8c6 | {
"head_commit": "b8bced8cf8a9c68c0ee98b6a608136a73e831036",
"head_commit_message": "Update Makefile\n\nSigned-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>",
"patch_to_review": "diff --git a/Makefile b/Makefile\nindex 9d6e2550be..ac7d2449c1 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1,6 +1... | [
{
"diff_hunk": "@@ -1,6 +1,4 @@\n install: build-docs",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "Makefile",
"start_line": null,
"text": "@user1:\nDoes this even need to do `build-docs` any more? I don't think so.\n\n@author:\nAh yes we don’t need to do `bui... | f5bfd913af07e6d665e5463dfcf71393fda564ba | diff --git a/Makefile b/Makefile
index 9d6e2550be..1dbaa716fe 100644
--- a/Makefile
+++ b/Makefile
@@ -1,6 +1,4 @@
-install: build-docs
- rm -rf kedro/framework/html
- cp -r docs/build/html kedro/framework
+install:
pip install .
clean:
diff --git a/RELEASE.md b/RELEASE.md
index 7303507ab7..2b5dcc42e8 100644
--- a... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
kedro-org__kedro-1491@01492ec | kedro-org/kedro | Python | 1,491 | Alter framework logging.yml configuration | Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
## Description
<!-- Why was this PR created? -->
Adds the changes outlined in #1470 to update the inbuilt logging setup.
## Development notes
The changes were tested by running some cli commands and noting the changes in the output between this an... | 2022-04-29T13:08:37Z | Alter framework logging.yml configuration
Various small changes to make to the framework kedro/config/logging.yml (**not to the project conf/base/logging.yml**):
* delete the section `root`
* add the `kedro.io` and `kedro.pipeline` that are in project conf/base/logging.yml to the framework kedro/config/logging.yml
... | Might fix the [`kedro-airflow` problem](https://github.com/kedro-org/kedro-plugins/issues/13), double check this is the case. | [
{
"body": "Various small changes to make to the framework kedro/config/logging.yml (**not to the project conf/base/logging.yml**):\r\n* delete the section `root`\r\n* add the `kedro.io` and `kedro.pipeline` that are in project conf/base/logging.yml to the framework kedro/config/logging.yml \r\n* add the followi... | 686dba54775ddc7a1ddaef5481e3b82717d33b0f | {
"head_commit": "01492ec2c9bd6973ea0fcc4973443b07fafb9874",
"head_commit_message": "Add changes to framework logging.yml\n\nSigned-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>",
"patch_to_review": "diff --git a/kedro/config/logging.yml b/kedro/config/logging.yml\nindex 8f671003ef..437becff10 100644\n--- ... | [
{
"diff_hunk": "@@ -33,15 +33,21 @@ handlers:\n \n loggers:\n anyconfig:\n- level: WARNING\n- handlers: [console]\n+ level: INFO",
"line": null,
"original_line": 36,
"original_start_line": null,
"path": "kedro/config/logging.yml",
"start_line": null,
"text": "@us... | 7372f2cf565c70bfafee88267bc196d79d56486d | diff --git a/kedro/config/default_logger.py b/kedro/config/default_logger.py
index 3aefdcd10b..886151b996 100644
--- a/kedro/config/default_logger.py
+++ b/kedro/config/default_logger.py
@@ -12,3 +12,4 @@
with open(os.path.join(CURRENT_DIR, "logging.yml"), encoding="utf-8") as conf_file:
LOGGING_CONFIG = yaml.saf... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
microsoft__autogen-6592@cdf7f14 | microsoft/autogen | Python | 6,592 | Add support for specifying the languages to parse from the `CodeExecutorAgent` response | ## Why are these changes needed?
The `CodeExecutorAgent` can generate code blocks in various programming languages, some of which may not be supported by the executor environment. Adding support for specifying languages to be parsed helps users ignore unnecessary code blocks, preventing potential execution errors.
... | 2025-05-25T15:59:33Z | CodeExecutorAgent should be able to ignore certain languages
### What happened?
**Describe the bug**
code executor throw Unsupported language: echarts
**To Reproduce**
```
code_executor_agent = CodeExecutorAgent(
name="code_executor", code_executor=code_executor
)
assistant_agent = Assista... | What is your scenario here? Are there other code blocks you need to execute that are generated in addition to the echarts one?
> What is your scenario here? Are there other code blocks you need to execute that are generated in addition to the echarts one?
There are also Python and Shell code blocks, but the ECharts co... | [
{
"body": "### What happened?\n\n**Describe the bug**\ncode executor throw Unsupported language: echarts\n**To Reproduce**\n```\ncode_executor_agent = CodeExecutorAgent(\n name=\"code_executor\", code_executor=code_executor\n )\n\n assistant_agent = AssistantAgent(\n name=\"c... | 03394a42c08b2caca7566a0a53ba0f6550e69d28 | {
"head_commit": "cdf7f14f0207ddac53b0bd38c9afa94b3d863c7a",
"head_commit_message": "Add support for specifying the languages to parse from the agent's response (#6471)\n\nSigned-off-by: Abhijeetsingh Meena <abhijeet040403@gmail.com>",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen... | [
{
"diff_hunk": "@@ -358,6 +362,13 @@ def __init__(\n self._model_client_stream = model_client_stream\n self._max_retries_on_error = max_retries_on_error\n \n+ if supported_languages:\n+ self._supported_languages = supported_languages\n+ else:\n+ self._supporte... | 3f8b6737b3cc08a6ad402ccc1609ffac951fe0b6 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.py
index 2efa6d5a7400..4dc3c36394d4 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
kedro-org__kedro-1366@8ba140a | kedro-org/kedro | Python | 1,366 | Experiment Tracking: Store username in the session store | Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
## Description
<!-- Why was this PR created? -->
https://github.com/kedro-org/kedro/issues/1298
As part of Experiment Tracking, users have indicated that it's important for them to be able to log the username of the person executing the ... | 2022-03-24T11:03:42Z | Experiment Tracking: Store username in the session store
As part of Experiment Tracking, users have indicated that it's important for them to be able to log the gitsha and username of the person executing the run.
These fields already appear on the UI, so we just need to make sure they're stored in the Session stor... | [
{
"body": "As part of Experiment Tracking, users have indicated that it's important for them to be able to log the gitsha and username of the person executing the run. \r\n\r\nThese fields already appear on the UI, so we just need to make sure they're stored in the Session store.\r\n\r\n_Update: we already log ... | c7475956121e951be553ad015af1cf41008bbd57 | {
"head_commit": "8ba140af720c782a066fb37f8c87dda7ab9eb257",
"head_commit_message": "lint\n\nSigned-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>",
"patch_to_review": "diff --git a/kedro/framework/session/session.py b/kedro/framework/session/session.py\nindex 2adcf7b32c..baf308768b 100644\n-... | [
{
"diff_hunk": "@@ -190,6 +190,8 @@ def create( # pylint: disable=too-many-arguments\n if extra_params:\n session_data[\"extra_params\"] = extra_params\n \n+ session_data[\"username\"] = os.environ.get(\"USER\") or os.environ.get(\"USERNAME\")",
"line": null,
"original_line":... | 5a086da4e1165813edc71d33f8f622d229ebdcda | diff --git a/RELEASE.md b/RELEASE.md
index 471f281a4b..9a30f7c52d 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -4,6 +4,7 @@
* Documented distribution of Kedro pipelines with Dask.
## Bug fixes and other changes
+* Added `username` to Session store for logging during Experiment Tracking.
## Upcoming deprecations f... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
microsoft__autogen-6578@3297106 | microsoft/autogen | Python | 6,578 | Default usage statistics for streaming responses | ## Why are these changes needed?
Enables usage statistics for streaming responses by default.
There is a similar bug in the AzureAI client. Theoretically adding the parameter
```
model_extras={"stream_options": {"include_usage": True}}
```
should fix the problem, but I'm currently unable to test that workflow... | 2025-05-22T18:00:04Z | models_usage shows prompt_tokens and completion_tokens as 0
### What happened?
**Describe the bug**
I was previously using v0.5.1 and sometime over the last few weeks, I had upgraded to v0.5.6. I was checking the history data and noticed that the `prompt_tokens` and `completion_tokens` under `models_usage` are coming ... | v0.5.7, cannot reproduce
```python
from autogen_agentchat.agents import AssistantAgent
from autogen_ext.models.openai import OpenAIChatCompletionClient
async def main():
client = OpenAIChatCompletionClient(model="gemini-2.0-flash")
assistant = AssistantAgent(
"assistant",
model_client=client,
... | [
{
"body": "### What happened?\n\n**Describe the bug**\nI was previously using v0.5.1 and sometime over the last few weeks, I had upgraded to v0.5.6. I was checking the history data and noticed that the `prompt_tokens` and `completion_tokens` under `models_usage` are coming as 0. \nI remember they used to report... | 9bbcfa03ac8cdbbc1f7dc53bbb2e1c03cc597d25 | {
"head_commit": "329710644d5802275db0f789537f685687407e4b",
"head_commit_message": "Merge branch 'main' into default_stream_usage",
"patch_to_review": "diff --git a/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py b/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_clie... | [
{
"diff_hunk": "@@ -770,6 +770,12 @@ async def create_stream(\n extra_create_args,\n )\n \n+ # Force usage statistics if the user hasn't specified any stream options.\n+ if \"stream_options\" not in create_params.create_args:\n+ create_params.create_args[\"stream_opt... | 35fd3d238816b7d243eacd92cdbc528f3054c7a9 | diff --git a/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py b/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py
index 936b3a6c7a23..c6f3d11be0ba 100644
--- a/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py
+++ b/python/packages/autogen-e... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
microsoft__autogen-6529@23be68e | microsoft/autogen | Python | 6,529 | feat: support multiple workbenches in assistant agent | resolves: #6456 | 2025-05-14T14:12:56Z | MCP Server is giving "The selected tool does not have a callable 'function'" when using via autogen
### What happened?
This is all running MCP server and I have also validated it via cloude desktop
```
from typing import Dict
from mcp.server.fastmcp import FastMCP
# Initialize the FastMCP server with a name
mcp = Fas... | Hi! Thanks for raising the issue.
From what I see, this looks more like a usage misunderstanding rather than a bug.
Here’s a working example that demonstrates how to properly set up `McpWorkbench` with a `RoundRobinGroupChat` using tools exposed via MCP:
```python
import asyncio
from autogen_ext.tools.mcp import Mc... | [
{
"body": "### What happened?\n\nThis is all running MCP server and I have also validated it via cloude desktop\n```\nfrom typing import Dict\nfrom mcp.server.fastmcp import FastMCP\n\n# Initialize the FastMCP server with a name\nmcp = FastMCP(\"simple_weather\")\n\n# Weather data for different topics\nWEATHER_... | 6cadc7dc17b23eee31c275bd9c64c0d65dbf45bf | {
"head_commit": "23be68e414103b7cc72ef58bbfd9476a7144583b",
"head_commit_message": "Merge remote-tracking branch 'origin/main' into mcp_mult_workbenches",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/au... | [
{
"diff_hunk": "@@ -66,7 +66,7 @@ class AssistantAgentConfig(BaseModel):\n name: str\n model_client: ComponentModel\n tools: List[ComponentModel] | None = None\n- workbench: ComponentModel | None = None\n+ workbenches: List[ComponentModel] | None = None",
"line": null,
"original_line":... | 286f1f074deeb852ad9883e05a0599ff7d675a06 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
index 04acc9020487..12995b8ca150 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
kedro-org__kedro-1349@eeaedab | kedro-org/kedro | Python | 1,349 | Remove the `init_kedro` line magic from the Kedro IPython extension | ## Description
<!-- Why was this PR created? -->
Fixes https://github.com/kedro-org/kedro/issues/1336
`reload_kedro` called with a path now also sets that path as default. `reload_kedro` called on its own relies on the previously set default. The very first default is either `None` (if the extension was loaded in ... | 2022-03-15T09:54:52Z | Remove the `init_kedro` line magic from the Kedro IPython extension
Currently the Kedro IPython extension has two line magic commands, `reload_kedro` and `init_kedro`. The way their are implemented makes `init_kedro` useless and entirely subsumed by `reload_kedro`, so we should drop it. When doing this, we should make ... | [
{
"body": "Currently the Kedro IPython extension has two line magic commands, `reload_kedro` and `init_kedro`. The way their are implemented makes `init_kedro` useless and entirely subsumed by `reload_kedro`, so we should drop it. When doing this, we should make sure:\n\n- All `init_kedro` references in the doc... | 069a1a8be0e6c23508c23667650d33dfb1b2e30b | {
"head_commit": "eeaedab02562af52250ec69b2f74b11838505c62",
"head_commit_message": "Remove global\n\nSigned-off-by: lorenabalan <lorena.balan@quantumblack.com>",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex f106f35b9e..bf0c53d2cc 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -79,6 +79,7 @@\n ... | [
{
"diff_hunk": "@@ -44,17 +47,26 @@ def reload_kedro(path, env: str = None, extra_params: Dict[str, Any] = None):\n from kedro.framework.session.session import _activate_session\n from kedro.framework.startup import bootstrap_project\n \n- path = path or project_path\n- metadata = bootstrap_projec... | 27cd3eda7ef5d399f4534a118d7320771bd301c3 | diff --git a/RELEASE.md b/RELEASE.md
index f106f35b9e..bf0c53d2cc 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -79,6 +79,7 @@
* Added the `PluginManager` `hook_manager` argument to `KedroContext` and the `Runner.run()` method, which will be provided by the `KedroSession`.
* Removed the public method `get_hook_manager(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
microsoft__autogen-6460@ed049dc | microsoft/autogen | Python | 6,460 | add tool_call_summary_msg_format_fct and test | ## Why are these changes needed?
This change introduces support for dynamic formatting of tool call summary messages by allowing a user-defined `tool_call_summary_format_fct`. Instead of relying solely on a static string template, this function enables runtime generation of summary messages based on the specific too... | 2025-05-05T06:27:52Z | Insufficient static string template for ToolCallSummaryMessage
### What happened?
**The Problem**
I have the following use case:
A tool call with huge payload if successful. Model must not reflect on it.
If tool call is successful, I just need have a tool call summary message like "Tool Foo has been executed success... | [
{
"body": "### What happened?\n\n**The Problem** \nI have the following use case:\nA tool call with huge payload if successful. Model must not reflect on it. \nIf tool call is successful, I just need have a tool call summary message like \"Tool Foo has been executed successfully\", whereas I need all details fo... | aa22b622d013a73f355754a1184d980179f8ec91 | {
"head_commit": "ed049dc0b57625efda29ec318efe3fee90f29f27",
"head_commit_message": "add tool_call_summary_msg_format_fct and test",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/... | [
{
"diff_hunk": "@@ -652,6 +653,7 @@ def __init__(\n model_client_stream: bool = False,\n reflect_on_tool_use: bool | None = None,\n tool_call_summary_format: str = \"{result}\",\n+ tool_call_summary_format_fct: Callable[[FunctionCall, FunctionExecutionResult], str] | None = None,"... | 5010fa47bdfdcd41b785a36da66658680ab77fe9 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
index c189021a2e2c..04acc9020487 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
microsoft__autogen-6316@e50cb0b | microsoft/autogen | Python | 6,316 | Fix: Azure AI Search Tool Client Lifetime Management | ## Why are these changes needed?
This PR fixes a bug where the underlying azure `SearchClient` was being closed prematurely due to use of `async with client` : inside the tool's run method. this caused the users to encounter errors "HTTP transport has already been closed"
## Related issue number
Closes #6308 "
... | 2025-04-17T02:02:19Z | AzureAISearchTool Not working as expected
### What happened?
**Describe the bug**
Getting following error when I am trying to use Hybrid Search tool with Assistant Agent.
{
"source": "CodeAnalysisAgent",
"models_usage": null,
"metadata": {},
"content": "\nTool Call Execution Results:\n\nError: Error f... | @jay-thakur can you look into this?
ack
looked into the issue.
potential root cause is - when we use `async with client` : the client is automatically closed (its HTTP transport is shut down) at the end of the block and if the agent tries to use the client after this block, it will encounter the "HTTP transport has a... | [
{
"body": "### What happened?\n\n**Describe the bug**\nGetting following error when I am trying to use Hybrid Search tool with Assistant Agent.\n\n{\n \"source\": \"CodeAnalysisAgent\",\n \"models_usage\": null,\n \"metadata\": {},\n \"content\": \"\\nTool Call Execution Results:\\n\\nError: Error f... | 629fb86e96a167e4d6ba93d084e2292aa4d661c1 | {
"head_commit": "e50cb0ba41f2bf28f256a275f30302409d550b8c",
"head_commit_message": "fix tests",
"patch_to_review": "diff --git a/python/packages/autogen-ext/src/autogen_ext/tools/azure/_ai_search.py b/python/packages/autogen-ext/src/autogen_ext/tools/azure/_ai_search.py\nindex ec12a16ca494..355ef364015e 100644\n... | [
{
"diff_hunk": "@@ -241,6 +241,12 @@ def __init__(\n self._client: Optional[SearchClient] = None\n self._cache: Dict[str, Dict[str, Any]] = {}\n \n+ async def aclose(self) -> None:",
"line": null,
"original_line": 244,
"original_start_line": null,
"path": "python/packages/auto... | 58c039af205ffb510e27b4655a04a887e6e9e90f | diff --git a/python/packages/autogen-ext/src/autogen_ext/tools/azure/_ai_search.py b/python/packages/autogen-ext/src/autogen_ext/tools/azure/_ai_search.py
index ec12a16ca494..07da00e1b9e9 100644
--- a/python/packages/autogen-ext/src/autogen_ext/tools/azure/_ai_search.py
+++ b/python/packages/autogen-ext/src/autogen_ext... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-11230@eec1225 | jax-ml/jax | Python | 11,230 | Make JAX compatible with numpy version 1.23.0 | For more discussion of these changes, see #11221
Fixes #11221 | 2022-06-23T18:48:10Z | autodiff fails under numpy 1.23
Something in the numpy 1.23 release broke autodiff; in particular, float0 arrays are being converted to bool:
```python
import jax
import numpy
print(numpy.__version__)
print(jax.grad(lambda x: x+0., allow_int=True)(1).dtype)
```
Newest numpy:
```
1.23.0
bool
```
previous ver... | Temporary pinning to fix CI in https://github.com/google/jax/pull/11220
Located the issue to this line: https://github.com/google/jax/blob/b623ed58b0415f31b4c2f2c389220f1e51de8d93/jax/interpreters/ad.py#L65
In numpy 1.22, `dtype(t) is float0` is True, and in numpy 1.23 `dtype(t) is float0` is False.
This is the oper... | [
{
"body": "Something in the numpy 1.23 release broke autodiff; in particular, float0 arrays are being converted to bool:\r\n```python\r\nimport jax\r\nimport numpy\r\nprint(numpy.__version__)\r\nprint(jax.grad(lambda x: x+0., allow_int=True)(1).dtype)\r\n```\r\nNewest numpy:\r\n```\r\n1.23.0\r\nbool\r\n```\r\np... | e4d1e1beb3c9e2f4d9a2ece4be2e41a23ece9d65 | {
"head_commit": "eec1225d7420e8daae4e82fb5bae292972215a35",
"head_commit_message": "TST: skip tests on numpy 1.23.0 due to regressions in that release",
"patch_to_review": "diff --git a/jax/_src/custom_derivatives.py b/jax/_src/custom_derivatives.py\nindex 43a46d68d068..6af5643f1a5c 100644\n--- a/jax/_src/custom... | [
{
"diff_hunk": "@@ -6,4 +6,4 @@ pillow>=8.3.1,<9.1.0\n pytest-benchmark\n pytest-xdist\n wheel\n-numpy<1.23.0\n+numpy",
"line": null,
"original_line": 9,
"original_start_line": null,
"path": "build/test-requirements.txt",
"start_line": null,
"text": "@user1:\nRemove this? setup.py should... | 617df70135db2a8314bf41386007a82b64e5c403 | diff --git a/build/test-requirements.txt b/build/test-requirements.txt
index facfd3e3ff00..5ca72ab2cec4 100644
--- a/build/test-requirements.txt
+++ b/build/test-requirements.txt
@@ -6,4 +6,3 @@ pillow>=8.3.1,<9.1.0
pytest-benchmark
pytest-xdist
wheel
-numpy<1.23.0
diff --git a/jax/_src/custom_derivatives.py b/jax/_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
microsoft__autogen-5916@64879b8 | microsoft/autogen | Python | 5,916 | fix: Recurrent SendMessageAsync deadlock in message handler | In the .NET InProcessRuntime we tried to minimize the amount of tasks created. Unfortunately, this results in a deadlock when a send message handler is attempting to SendMessage during the handling of the incoming message.
The fix is to create a new task for delivering the message in the message processing loop, whi... | 2025-03-12T16:16:45Z | Deadlock in logically recurrent calls to SendMessageAsync
### Confirmation
- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.
### Issue body
If a message handler invoked during SendMessage then atte... | [
{
"body": "### Confirmation\n\n- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.\n\n### Issue body\n\nIf a message handler invoked during SendMessage then attempts to send a message and await ... | 712aba6b4e7a62610a8ea95c053f3c214d8f779f | {
"head_commit": "64879b8d6a0375fe72edda799d0d715dccb253c9",
"head_commit_message": "fix: Recurrent SendMessageAsync deadlock in message handler\n\nIn the .NET InProcessRuntime we tried to minimize the amount of tasks created. Unfortunately, this results in a deadlock when a send message handler is attempting to Se... | [
{
"diff_hunk": "",
"line": null,
"original_line": null,
"original_start_line": null,
"path": "dotnet/src/Microsoft.AutoGen/Core/InProcessRuntime.cs",
"start_line": null,
"text": "@user1:\nWith the change to multiple concurrent tasks which may send messages resulting in new agent instance... | 3e00e2c115d0af24c9f7e40cf6cf2fd0ee5bcc5b | diff --git a/dotnet/src/Microsoft.AutoGen/Core/InProcessRuntime.cs b/dotnet/src/Microsoft.AutoGen/Core/InProcessRuntime.cs
index bf18b1da2c35..dddee1845d42 100644
--- a/dotnet/src/Microsoft.AutoGen/Core/InProcessRuntime.cs
+++ b/dotnet/src/Microsoft.AutoGen/Core/InProcessRuntime.cs
@@ -14,8 +14,8 @@ public sealed class... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
jax-ml__jax-9239@cbb2f7b | jax-ml/jax | Python | 9,239 | Eliminate redundancies in jax.scipy.linalg.expm | ## Summary
This PR introduces a minor change to the `expm` function:
- Currently, given the matrix `A`, `expm` computes all Pade approximant numerators/denominators, then selects which one to use based on the norm of the matrix.
- This PR modifies this to only compute the relevant Pade approximant numerator/denomi... | 2022-01-19T15:20:10Z | Redundant computation in expm?
Hi all:
It looks to me there are redundant calculations in the `expm` function, but wanted to ask to see if I'm missing something (perhaps something clever is happening in compilation).
E.g., for `float64` and `complex128`, the numerator/denominator for the Pade approximant is gene... | This sounds right to me! Indeed using `jnp.select` is wasting compute, and `cond`/`switch` could save it. I don't remember any context around why `expm` was written this way (@zhangqiaorjc do you remember?) but it may just have been for simplicity. In that case, what you describe would be a welcome upgrade!
I guess tha... | [
{
"body": "Hi all:\r\n\r\nIt looks to me there are redundant calculations in the `expm` function, but wanted to ask to see if I'm missing something (perhaps something clever is happening in compilation). \r\n\r\nE.g., for `float64` and `complex128`, the numerator/denominator for the Pade approximant is generate... | d6ea8b28973c820f2f44ab347d34767d94e10763 | {
"head_commit": "cbb2f7baabaab1084b4ed5b6617ebd7ec1181d74",
"head_commit_message": "changed to use argwhere",
"patch_to_review": "diff --git a/jax/_src/scipy/linalg.py b/jax/_src/scipy/linalg.py\nindex bd710892a3e8..7f0212b74028 100644\n--- a/jax/_src/scipy/linalg.py\n+++ b/jax/_src/scipy/linalg.py\n@@ -289,28 +... | [
{
"diff_hunk": "@@ -289,28 +289,20 @@ def _calc_P_Q(A):\n A_L1 = np_linalg.norm(A,1)\n n_squarings = 0\n if A.dtype == 'float64' or A.dtype == 'complex128':\n- U3, V3 = _pade3(A)\n- U5, V5 = _pade5(A)\n- U7, V7 = _pade7(A)\n- U9, V9 = _pade9(A)\n maxnorm = 5.371920351148152\n n_squarings = j... | 2d2ac12aa074a137cdf9d3d427b36f14b1fb3f1f | diff --git a/jax/_src/scipy/linalg.py b/jax/_src/scipy/linalg.py
index bd710892a3e8..1d2cca00f3a8 100644
--- a/jax/_src/scipy/linalg.py
+++ b/jax/_src/scipy/linalg.py
@@ -289,28 +289,20 @@ def _calc_P_Q(A):
A_L1 = np_linalg.norm(A,1)
n_squarings = 0
if A.dtype == 'float64' or A.dtype == 'complex128':
- U3, V... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
microsoft__autogen-5961@e5cb30f | microsoft/autogen | Python | 5,961 | Fix R1 reasoning parser for openai client | <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. -->
Hey @ekzhu, can you please have a look at this. This resolves the issues with parsing of the R1 reasoning tokens at least for openai client there are still areas where it still us... | 2025-03-16T02:05:22Z | ERROR when using deepseek r1
### What happened?
**Describe the bug**
-----
{"error":{"message":"deepseek-reasoner does not support successive user or assistant messages (messages[1] and messages[2] in your input). You should interleave the user/assistant messages in the message sequence.","type":"invalid_request_erro... | Can you post a reproducible code example for this? Not a code snippet. An example that can run from command line.
I do not have access to DeepSeek's hosted model -- I have access to locally hosted DeepSeek models. So I cannot test this for you. Can you reproduce this using a locally hosted DeepSeek model e.g., using ... | [
{
"body": "### What happened?\n\n**Describe the bug**\n\n-----\n{\"error\":{\"message\":\"deepseek-reasoner does not support successive user or assistant messages (messages[1] and messages[2] in your input). You should interleave the user/assistant messages in the message sequence.\",\"type\":\"invalid_request_... | e5ab7d55cf688a91416eac730674d2e5c330dba0 | {
"head_commit": "e5cb30f59e4a5fc62499b71797cb44d451b8e3ca",
"head_commit_message": "fixex R1 reasoning parser for openai client",
"patch_to_review": "diff --git a/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py b/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client... | [
{
"diff_hunk": "@@ -617,6 +617,8 @@ async def create(\n else:\n finish_reason = choice.finish_reason\n content = choice.message.content or \"\"\n+ if choice.message.model_extra['reasoning_content'] is not None:",
"line": null,
"original_line": 620,
"origina... | f9f48a0cb5afb6593dfb73d66b8dd318f36d3de3 | diff --git a/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py b/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py
index 2301655b32d1..3acedc93e1d8 100644
--- a/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py
+++ b/python/packages/autogen-e... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
microsoft__autogen-6170@0a8e983 | microsoft/autogen | Python | 6,170 | Adding bedrock chat completion for anthropic models |
## Why are these changes needed?
Anthropic models are supported by AWS bedrock. ChatCompletionClient can be created for anthropic bedrock models using this changes. This enables the user to do the following
- Add any anthropic models and version from AWS bedrock
- Can use ChatCompletionClient for bedrock anthrop... | 2025-04-01T12:46:43Z | Add support for AWS Bedrock integration
### What feature would you like to be added?
- **New Module:** Create a new module for AWS Bedrock integration.
- **New Class:** Implement a new class `.autogen_ext.models.aws.BedrockChatCompletionClient` based on the `ChatCompletionClient` base class.
- **Reference:** Please re... | Thank you @Hama18, for start, you can take a look at the CONTRIBUTING.md for how to run tests locally. You can check with us when you are stuck.
For API documentation, it would be good to have at least 1 runnable code block showing a hello world example. Would be good to also show a streaming example.
The two exampl... | [
{
"body": "### What feature would you like to be added?\n\n- **New Module:** Create a new module for AWS Bedrock integration.\n- **New Class:** Implement a new class `.autogen_ext.models.aws.BedrockChatCompletionClient` based on the `ChatCompletionClient` base class.\n- **Reference:** Please refer to existing e... | 99d853a9cb3517302d65869af82b4fff60159144 | {
"head_commit": "0a8e9835be61367ccd924a17934f9e06e03eeb59",
"head_commit_message": "adding bedrock chat completion for anthropic models",
"patch_to_review": "diff --git a/python/packages/autogen-ext/src/autogen_ext/models/anthropic/_anthropic_client.py b/python/packages/autogen-ext/src/autogen_ext/models/anthrop... | [
{
"diff_hunk": "@@ -1073,3 +1073,118 @@ def _from_config(cls, config: AnthropicClientConfigurationConfigModel) -> Self:\n copied_config[\"api_key\"] = config.api_key.get_secret_value()\n \n return cls(**copied_config)\n+\n+class AnthropicBedrockChatCompletionClient(\n+ BaseAnthropicChatCo... | c6c1b66b1d06b6457b11d874d9bab59e30485be7 | diff --git a/python/packages/autogen-ext/src/autogen_ext/models/anthropic/__init__.py b/python/packages/autogen-ext/src/autogen_ext/models/anthropic/__init__.py
index 75365d781eb3..b34cec71671e 100644
--- a/python/packages/autogen-ext/src/autogen_ext/models/anthropic/__init__.py
+++ b/python/packages/autogen-ext/src/au... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
microsoft__autogen-6098@9f69448 | microsoft/autogen | Python | 6,098 | Add code generation support to `CodeExecutorAgent` | ## Why are these changes needed?
- To add support for code generation, execution and reflection to `CodeExecutorAgent`.
## Related issue number
Closes #5824
## Checks
- [x] I've included any doc changes needed for <https://microsoft.github.io/autogen/>. See <https://github.com/microsoft/autogen/blob/main/CONT... | 2025-03-25T16:46:46Z | Enable `CodeExecutorAgent` to generate its own code and executing it.
### Confirmation
- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.
### Issue body
Adding optional parameters: `system_message` ... | Hi @ekzhu,
I experimented with a baseline approach where I inherited from `AssistantAgent` instead of `BaseChatAgent`. I renamed `CodeExecutorAgent.on_messages` to `CodeExecutorAgent.execute_code_block` and added the following method:
```python
# A very raw implementation
async def on_messages_with_code_exec(self... | [
{
"body": "### Confirmation\n\n- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.\n\n### Issue body\n\nAdding optional parameters: `system_message` and `model_client` to `CodeExecutorAgent` so ... | 71a4eaedf9bb6ed069e0adf9477709a926cd3ba8 | {
"head_commit": "9f694487b49a34826c22751d817aba786170bb5d",
"head_commit_message": "Add code generation support to `CodeExecutorAgent` (#5824)\n\nSigned-off-by: Abhijeetsingh Meena <abhijeet040403@gmail.com>",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_e... | [
{
"diff_hunk": "@@ -108,20 +144,113 @@ def __init__(\n self,\n name: str,\n code_executor: CodeExecutor,\n+ model_client: ChatCompletionClient,",
"line": null,
"original_line": 147,
"original_start_line": null,
"path": "python/packages/autogen-agentchat/src/autogen... | 079f28ea0d89c8efc09a85ba936be95a267a0b37 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.py
index 870a620c447b..ae9312cc7d67 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_code_executor_agent.p... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-107@651589e | kedro-org/kedro | Python | 107 | [KED-1076] Add open flag to build-docs that opens the documentation on build | ## Notice
- [x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the [Apache 2.0 license](https://www.apache.org/licenses/LICENSE-2.0.txt) and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties,... | 2019-09-28T14:15:50Z | [KED-1054] Add option to kedro build-docs which also opens the documentation
## Description
I find myself writing '`kedro build-docs ; open docs/build/html/index.html`', adding a simple
`--open` argument would be appreciated. I do plan to PR this myself, I'm just not sure when I have time.
## Context
- Saves tim... | Correct me if I'm wrong, but `open` is MacOS-specific, and `xdg-open` should be used on Linux.
That might be a cross-platform solution: https://docs.python.org/3.7/library/webbrowser.html
It would be amazing if you find some time to send a pull request. Thank you for raising this anyway!
@datajoely - as a temporary... | [
{
"body": "## Description\r\nI find myself writing '`kedro build-docs ; open docs/build/html/index.html`', adding a simple \r\n`--open` argument would be appreciated. I do plan to PR this myself, I'm just not sure when I have time.\r\n\r\n## Context\r\n- Saves time\r\n- Is almost always the next action after ru... | cb7d83cd969f827b9d8886f8d61bc7587405a25a | {
"head_commit": "651589e3dd2ed7d04c934b3d42f7e14d6cc30def",
"head_commit_message": "Merge branch 'develop' into feature/open-docs-option",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex 29f422e0cd..6baa6f08ff 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -11,12 +11,14 @@\n * Improved an error m... | [
{
"diff_hunk": "@@ -249,6 +253,11 @@ def build_docs():\n ]\n )\n call([\"sphinx-build\", \"-M\", \"html\", \"docs/source\", \"docs/build\", \"-a\"])\n+ if open_docs:\n+ p = Path(\"docs/build/html/index.html\").resolve().as_uri()",
"line": null,
"original_line": 257,
"origin... | 93863066e0ab728f8a0eef7747eae046deb01ce0 | diff --git a/RELEASE.md b/RELEASE.md
index 29f422e0cd..4ac4a3ca16 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -11,12 +11,13 @@
* Improved an error message when versioned local dataset is saved and unversioned path already exists.
* Enabled tuples to be returned from a node.
* Disallow the ConfigLoader loading the sa... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
microsoft__autogen-5954@db237a3 | microsoft/autogen | Python | 5,954 | Implement 'candidate_func' parameter to filter down the pool of candidates for selection | ## Summary of Changes
- Added 'candidate_func' to 'SelectorGroupChat' to narrow-down the pool of candidate speakers.
- Introduced a test in tests/test_group_chat_endpoint.py to validate its functionality.
- Updated the selector group chat user guide with an example demonstrating 'candidate_func'.
## Why are these... | 2025-03-15T10:38:49Z | `candidate_func` in `SelectorGroupChat`
### Confirmation
- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.
### Issue body
In `SelectorGroupChat`, the `selector_func` allows for customizing an exact... | Hi, can I work on this?
@Ethan0456 sure. Feel free to ask more clarification.
This `candidate_func` should be applied only if the `selector_func` is not set, as part of the `select_speaker` implementation.
Also make sure to add unit test and API documentation for it. | [
{
"body": "### Confirmation\n\n- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.\n\n### Issue body\n\nIn `SelectorGroupChat`, the `selector_func` allows for customizing an exact selection of a... | 8f8ee0478ab1a8a272f801d1ec1e899eef2277e6 | {
"head_commit": "db237a3c6141df675a00e8f4ac20dea0b37522bb",
"head_commit_message": "Remove 'participants' parameter from 'candidate_func' and increase its precedence over 'allowed_repeated_speaker' (#5828)\n\nSigned-off-by: Abhijeetsingh Meena <abhijeet040403@gmail.com>",
"patch_to_review": "diff --git a/python/... | [
{
"diff_hunk": "@@ -287,11 +287,10 @@ class SelectorGroupChat(BaseGroupChat, Component[SelectorGroupChatConfig]):\n function that takes the conversation history and returns the name of the next speaker.\n If provided, this function will be used to override the model to select the next sp... | 89c01273d4fffa8802d481f3951acc0865868f2a | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/teams/_group_chat/_selector_group_chat.py b/python/packages/autogen-agentchat/src/autogen_agentchat/teams/_group_chat/_selector_group_chat.py
index 0403025dec69..2446024c3c21 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/teams/_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
kedro-org__kedro-20@2012623 | kedro-org/kedro | Python | 20 | Expand user home directory (~) for TextLocalDataSet | ## Notice
- [x] I acknowledge and agree that, by checking this box and clicking “Submit Pull Request”:
- I submit this contribution under the [Apache 2.0 license](https://www.apache.org/licenses/LICENSE-2.0.txt) and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties,... | 2019-06-12T00:51:15Z | User home directory is not expanded for TextLocalDataSet
## Description
User home directory `~` is not automatically expanded for `TextLocalDataSet`, but it is automatically expanded for `ParquetLocalDataSet` and `CSVLocalDataSet `.
## Context
Trying to specify file paths relative to user home directory to simplif... | [
{
"body": "## Description\r\nUser home directory `~` is not automatically expanded for `TextLocalDataSet`, but it is automatically expanded for `ParquetLocalDataSet` and `CSVLocalDataSet `.\r\n\r\n## Context\r\nTrying to specify file paths relative to user home directory to simplify interoperability and handoff... | 01af3133ffcd5d864caf9b70633aaf9d78e67e8d | {
"head_commit": "2012623077bcf94196a607493a48a9a6d14a9fa4",
"head_commit_message": "Update RELEASE.md\n\non branch kalexqb:add_expanduser",
"patch_to_review": "diff --git a/RELEASE.md b/RELEASE.md\nindex cab292d1bf..74c09105a6 100644\n--- a/RELEASE.md\n+++ b/RELEASE.md\n@@ -2,9 +2,13 @@\n \n ## Major features an... | [
{
"diff_hunk": "@@ -82,6 +82,9 @@ def test_assess_if_file_exists(self, txt_data_set, sample_text, filepath_txt):\n traditional_write(filepath_txt, sample_text)\n assert txt_data_set.exists()\n \n+ def test_filepath_expanduser(self):\n+ txt_dataset = TextLocalDataSet(filepath='~')\n+ ... | 2aa64bf8cf6360e87d20d768f51af1fb7a0120fd | diff --git a/RELEASE.md b/RELEASE.md
index e9ccf0c98d..6a712f70f1 100644
--- a/RELEASE.md
+++ b/RELEASE.md
@@ -7,13 +7,16 @@
## Bug fixes and other changes
* Add support for pipeline nodes made up from partial functions
+## Bug fixes and other changes
+* Expand user home directory (~) for TextLocalDataSet (see issu... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
microsoft__autogen-5843@e07fb7a | microsoft/autogen | Python | 5,843 | Support for external agent runtime in AgentChat | Resolves #4075
1. Introduce custom runtime parameter for all AgentChat teams (RoundRobinGroupChat, SelectorGroupChat, etc.). This is done by making sure each team's topics are isolated from other teams, and decoupling state from agent identities. Also, I removed the closure agent from the BaseGroupChat and use the g... | 2025-03-06T02:40:05Z | Accessing Agent runtime through AgentChat
### What feature would you like to be added?
Currently, AgentChat instantiate an agent runtime each time `run()` is called on a team. Rather than recreating a new runtime, we should reuse the same runtime
```python
runtime = ...
team = SelectorGroupChat(..., runtime=runtime... | Is this issue already released?
@asheeshgarg not it is not.
@ekzhu thanks do we have any milestone specified for this? When to expect this feature
@asheeshgarg would you like to join our weekly office hour to discuss? #4059
This is an important feature, but the team at the moment is pushing for .NET Core API. The p... | [
{
"body": "### What feature would you like to be added?\n\nCurrently, AgentChat instantiate an agent runtime each time `run()` is called on a team. Rather than recreating a new runtime, we should reuse the same runtime\n\n```python\n\nruntime = ...\n\nteam = SelectorGroupChat(..., runtime=runtime)\nresult = awa... | 30b1b8f90cac1f44f4ae5f4fe134e9364380b60e | {
"head_commit": "e07fb7a5f31a947ca033e809b90b6a008a2c4b08",
"head_commit_message": "make test robust",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py\nindex 64... | [
{
"diff_hunk": "@@ -197,14 +205,18 @@ async def main() -> None:\n def __init__(\n self,\n participants: List[ChatAgent],\n+ *,",
"line": null,
"original_line": 208,
"original_start_line": null,
"path": "python/packages/autogen-agentchat/src/autogen_agentchat/teams/_gro... | c1855941aa1be02361412c4846af0e6c799d7183 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
index 649c38c2b55a..ee4130659a0f 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
microsoft__autogen-5936@0e3c25e | microsoft/autogen | Python | 5,936 | feat: add structured output to model clients | Resolves #5933
1. Add a new `type[BaseModel]` option for `json_output` in `ChatCompletionClient.create` and `ChatCompletionClient.create_stream`, using them for the output type of structured output.
2. Add support for this new option for `OpenAIChatCompletionClient`, `AzureOpenAIChatCompletionClient`, `OllamaChatC... | 2025-03-14T00:11:45Z | Add structured output to model client API
### Confirmation
- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.
### Issue body
1. `output_type` to `ChatCompletionClient` APIs.
2. Add `structured_outpu... | [
{
"body": "### Confirmation\n\n- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.\n\n### Issue body\n\n1. `output_type` to `ChatCompletionClient` APIs.\n2. Add `structured_output` as a new `Mod... | 9bde5ef911e28d63f4c681f917096609d7cdf98f | {
"head_commit": "0e3c25e380c25156047afc79843790fc8a57ace8",
"head_commit_message": "add structured output to model clients",
"patch_to_review": "diff --git a/python/packages/autogen-core/src/autogen_core/models/_model_client.py b/python/packages/autogen-core/src/autogen_core/models/_model_client.py\nindex 84f008... | [
{
"diff_hunk": "@@ -395,13 +399,17 @@ async def create_stream(\n *,\n tools: Sequence[Tool | ToolSchema] = [],\n json_output: Optional[bool] = None,\n+ output_type: Optional[type[BaseModel]] = None,\n extra_create_args: Mapping[str, Any] = {},\n cancellation_token:... | 190e26f3db2722b1bcf1b0dd915467059017a839 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
index b3fef0f6eb6d..ee8afbce1582 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
jax-ml__jax-6899@b4ccecc | jax-ml/jax | Python | 6,899 | support custom PRNG implementations | Today jax offers a single splittable PRNG implementation (threefry 2x32) and models its key as a `uint32[2]`. A batch of keys is a `uint32` array whose trailing dimension comprises the length-2 keys.
With this PR, we have two goals:
1. To encapsulate the "raw array" key representation, in order to prevent unsafe ... | 2021-06-04T22:22:32Z | Allow pluggable PRNG implementations
Currently we use ThreeFry2x32 as our PRNG, but it has an uncomfortably small key space (2^64).
An easy way to improve this would be to use the 4x32 variant of ThreeFry instead which has a key space of size 2^128. | This sounds fun...
For backward compatibility, do you think it might make sense to implement this beside the current approach (e.g. with `jax.random.PRNGKey4()` or something similar?)
Or maybe better, a `keysize` keyword to `PRNGKey` that defaults to 2, and can optionally be set to 4, with the intention of eventuall... | [
{
"body": "Currently we use ThreeFry2x32 as our PRNG, but it has an uncomfortably small key space (2^64).\r\n\r\nAn easy way to improve this would be to use the 4x32 variant of ThreeFry instead which has a key space of size 2^128.",
"number": 5081,
"title": "Allow pluggable PRNG implementations"
}
] | c39c0933ae15040afb3aeb6bd3f28afc376fb1ce | {
"head_commit": "b4ccecca88bca4d25dd68eeba59ebb5336266898",
"head_commit_message": "factor PRNG routines from random module to prng",
"patch_to_review": "diff --git a/jax/_src/prng.py b/jax/_src/prng.py\nnew file mode 100644\nindex 000000000000..0b3bcfc19920\n--- /dev/null\n+++ b/jax/_src/prng.py\n@@ -0,0 +1,341... | [
{
"diff_hunk": "@@ -0,0 +1,475 @@\n+# Copyright 2021 Google LLC\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# https://www.apache.org/licenses/LICENSE-2.0\n+#\n... | 4eb437a568dc70119a3d3bb859e9093d1a051734 | diff --git a/jax/__init__.py b/jax/__init__.py
index 176294667ab3..9b2021b4a18e 100644
--- a/jax/__init__.py
+++ b/jax/__init__.py
@@ -38,7 +38,7 @@
del _config_module
from ._src.config import (
- config, enable_checks, check_tracer_leaks, checking_leaks,
+ config, enable_checks, check_tracer_leaks, checking_leak... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
microsoft__autogen-5887@6e2014e | microsoft/autogen | Python | 5,887 | feat: Pause and Resume for AgentChat Teams and Agents | 1. Add `on_pause` and `on_resume` API to `ChatAgent` to support pausing behavior when running `on_message` concurrently.
2. Add `GroupChatPause` and `GroupChatResume` RPC events and handle them in `ChatAgentContainer`.
3. Add `pause` and `resume` API to `BaseGroupChat` to allow for this behavior accessible from the pu... | 2025-03-10T01:50:14Z | Add pause/resume APIs for agents in AgentChat
### Confirmation
- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.
### Issue body
Agents can be in I/O or compute intensive tasks that requires pause a... | [
{
"body": "### Confirmation\n\n- [x] I confirm that I am a maintainer and so can use this template. If I am not, I understand this issue will be closed and I will be asked to use a different template.\n\n### Issue body\n\nAgents can be in I/O or compute intensive tasks that requires pause and resume that allows... | 8fb9ca3a3efe00159a6e16465509d3849a313549 | {
"head_commit": "6e2014e439c63682c6d8494b57fb08123062c86c",
"head_commit_message": "Implement pause and resume functionalities in BaseGroupChat",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_base_chat_agent.py b/python/packages/autogen-agentchat/src/autogen_age... | [
{
"diff_hunk": "@@ -565,6 +565,84 @@ async def main() -> None:\n # Indicate that the team is no longer running.\n self._is_running = False\n \n+ async def pause(self) -> None:\n+ \"\"\"Pause its participants when the team is running by calling their\n+ :meth:`~autogen_ag... | d8d02848723f14e2da2fda0405fc2068280c4182 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_base_chat_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_base_chat_agent.py
index b2e4e4fde48c..94b89235df89 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_base_chat_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
microsoft__autogen-5581@ee49556 | microsoft/autogen | Python | 5,581 | bugfix exception issue 5580 |
## Why are these changes needed?
fixing intermittent bug #5580
was using the wrong scheduler.
## Related issue number
closes #5580
| 2025-02-17T22:21:52Z | intermittent bug: Exception thrown: 'System.InvalidOperationException' in Orleans.Runtime.dll: 'Activation access violation. A non-activation thread attempted to access activation services.'
### What happened?
```Exception has occurred: CLR/System.InvalidOperationException
Exception thrown: 'System.InvalidOperationExc... | [
{
"body": "### What happened?\n\n```Exception has occurred: CLR/System.InvalidOperationException\nException thrown: 'System.InvalidOperationException' in Orleans.Runtime.dll: 'Activation access violation. A non-activation thread attempted to access activation services.'\n at Orleans.Runtime.GrainRuntime.<Chec... | 17888819c25bffacef996f89b745d66e54936a99 | {
"head_commit": "ee49556ffc82f7aa8ec1b14db81436757acb1f88",
"head_commit_message": "with help from Reuben making the message registry write more robust.",
"patch_to_review": "diff --git a/dotnet/src/Microsoft.AutoGen/RuntimeGateway.Grpc/Services/Orleans/MessageRegistryGrain.cs b/dotnet/src/Microsoft.AutoGen/Runt... | [
{
"diff_hunk": "@@ -38,7 +42,7 @@ public async Task AddMessageToEventBufferAsync(string topic, CloudEvent message)\n _ = Task.Delay(_bufferTime)\n .ContinueWith(\n async _ => await RemoveMessage(topic, message),\n- TaskScheduler.Default\n+ TaskSc... | 33da2b51e194008ba905c4b2ec4c1eff40f93411 | diff --git a/dotnet/src/Microsoft.AutoGen/RuntimeGateway.Grpc/Services/Orleans/MessageRegistryGrain.cs b/dotnet/src/Microsoft.AutoGen/RuntimeGateway.Grpc/Services/Orleans/MessageRegistryGrain.cs
index 59dec750da41..534114920d7d 100644
--- a/dotnet/src/Microsoft.AutoGen/RuntimeGateway.Grpc/Services/Orleans/MessageRegist... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
microsoft__autogen-5695@c180410 | microsoft/autogen | Python | 5,695 | add anthropic native support | <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. -->
Claude 3.7 just came out. Its a pretty capable model and it would be great to support it in Autogen.
This will could augment the already excellent support we have for Anthropic... | 2025-02-25T05:13:24Z | Support for anthropic models in v0.4
### What feature would you like to be added?
Currently there is no way to use anthropic models with autogen 0.4 I need a way to use Claude models just like I was able to do so in 0.2.
Also there is no support for performing RAG as of now
### Why is this needed?
Claude models ar... | Thanks @raagul-qb. I am editing this Issue to remove the RAG part to help making this issue more specific.
@rohanthacker was that you or someone else posted on Reddit about working on an Anthropic client?
For RAG, please see rag tools like graphrag: https://microsoft.github.io/autogen/stable/reference/python/autogen... | [
{
"body": "### What feature would you like to be added?\n\nCurrently there is no way to use anthropic models with autogen 0.4 I need a way to use Claude models just like I was able to do so in 0.2.\n\nAlso there is no support for performing RAG as of now\n\n### Why is this needed?\n\nClaude models are better a... | 1f30622adcfc88b0839620d3708669f919f37ef0 | {
"head_commit": "c180410f863813000e29426c5889313ed1af181a",
"head_commit_message": "update tests",
"patch_to_review": "diff --git a/python/packages/autogen-ext/src/autogen_ext/models/anthropic/__init__.py b/python/packages/autogen-ext/src/autogen_ext/models/anthropic/__init__.py\nnew file mode 100644\nindex 0000... | [
{
"diff_hunk": "@@ -0,0 +1,987 @@\n+import asyncio\n+import base64\n+import inspect\n+import json\n+import logging\n+import re\n+import warnings\n+\n+# from asyncio import Task\n+from typing import (\n+ Any,\n+ AsyncGenerator,\n+ Coroutine,\n+ Dict,\n+ List,\n+ Literal,\n+ Mapping,\n+ Op... | 70e2250843802aa5940f3b807b3dd011655ff325 | diff --git a/python/packages/autogen-core/src/autogen_core/models/_model_client.py b/python/packages/autogen-core/src/autogen_core/models/_model_client.py
index a378f29a3d7c..3d157d240b88 100644
--- a/python/packages/autogen-core/src/autogen_core/models/_model_client.py
+++ b/python/packages/autogen-core/src/autogen_co... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jax-ml__jax-4959@f93ca36 | jax-ml/jax | Python | 4,959 | Change round/round_p API and implement jax2tf conversion & tests | Fixes google/jax#4952. | 2020-11-19T14:28:12Z | [jax2tf] Incorrect translation for jax.lax.round
```
import jax
import jax.experimental.jax2tf as jax2tf
import jax.numpy as jnp
import tensorflow as tf
tf.compat.v1.enable_eager_execution()
print("Jax:", jax.lax.round(0.5))
print("Jax2Tf:", jax2tf.convert(jax.lax.round)(0.5))
```
```
Jax: 1.0
Jax2Tf: tf... | @bchetioui Is this now fixed?
@hawkinsp I think #4959 is ready, but it has not been merged! | [
{
"body": "```\r\nimport jax\r\nimport jax.experimental.jax2tf as jax2tf\r\nimport jax.numpy as jnp\r\nimport tensorflow as tf\r\ntf.compat.v1.enable_eager_execution()\r\n\r\nprint(\"Jax:\", jax.lax.round(0.5))\r\nprint(\"Jax2Tf:\", jax2tf.convert(jax.lax.round)(0.5))\r\n```\r\n\r\n```\r\nJax: 1.0\r\nJax2Tf: tf... | 17d9fc1457487f832363b4a0c73b7e7889b6ba08 | {
"head_commit": "f93ca369a88bae48dcbebc8b04336d6e8c019baa",
"head_commit_message": "[jax2tf] Fix and test conversion of round.\nFixes google/jax#4952.",
"patch_to_review": "diff --git a/jax/_src/lax/lax.py b/jax/_src/lax/lax.py\nindex b8a298f71cff..8653b2fe7525 100644\n--- a/jax/_src/lax/lax.py\n+++ b/jax/_src/l... | [
{
"diff_hunk": "@@ -196,3 +196,14 @@ Linear algebra operators (jax.lax.linalg)\n qr\n svd\n triangular_solve\n+\n+Argument wrappers",
"line": null,
"original_line": 200,
"original_start_line": null,
"path": "docs/jax.lax.rst",
"start_line": null,
"text": "@user1:\nI might cal... | 9c56277878b90a541ea5b26c3f2e51eaf678e32b | diff --git a/docs/jax.lax.rst b/docs/jax.lax.rst
index f0902417d20a..cfc29b5c938d 100644
--- a/docs/jax.lax.rst
+++ b/docs/jax.lax.rst
@@ -196,3 +196,14 @@ Linear algebra operators (jax.lax.linalg)
qr
svd
triangular_solve
+
+Argument classes
+----------------
+
+.. automodule:: jax.lax
+
+.. autoclass:: ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
microsoft__autogen-5215@220f486 | microsoft/autogen | Python | 5,215 | Rysweet 5207 net runtime interface to match python add registration to interface and inmemoryruntime |
* add Registry abstractions and Registry Storage to Core/Contracts
* brings Grpc in line with these abstractions
* add registeragenttype to in memory runtime. Note it's not necessary to call this because we register all the agents with reflection unless you tell the runtime not to.....
## Why are these changes ... | 2025-01-27T04:00:14Z | .NET runtime interface to match python - add registration to interface and InMemoryRuntime
### What feature would you like to be added?
add RegisterAgentType to the agent runtime (its already in the backend server, but in memory we don't need it because we just load the agents from relection.
### Why is this needed?... | [
{
"body": "### What feature would you like to be added?\n\nadd RegisterAgentType to the agent runtime (its already in the backend server, but in memory we don't need it because we just load the agents from relection. \n\n### Why is this needed?\n\nIn .NET when the agents are all in one process we can use reflec... | e582072947b3afc6d8279785386acb19f0ba265b | {
"head_commit": "220f4865670ddeba49405e8f3adcd286f63ef799",
"head_commit_message": "adding tests for Registry.cs",
"patch_to_review": "diff --git a/dotnet/.editorconfig b/dotnet/.editorconfig\nindex 3821c59cc19f..ce670b6c3aa2 100644\n--- a/dotnet/.editorconfig\n+++ b/dotnet/.editorconfig\n@@ -701,3 +701,7 @@ gen... | [
{
"diff_hunk": "@@ -0,0 +1,76 @@\n+// Copyright (c) Microsoft Corporation. All rights reserved.\n+// RegsitryStorage.cs\n+using System.Text.Json;\n+using Microsoft.AutoGen.Contracts;\n+using Microsoft.Extensions.Logging;\n+\n+namespace Microsoft.AutoGen.Core;\n+/// <summary>\n+/// Storage implementation for the... | 4e92ec229f04b13d9aabbc595bb12ae9a6db498b | diff --git a/.gitignore b/.gitignore
index bd419b14d7c7..899d49f9dd67 100644
--- a/.gitignore
+++ b/.gitignore
@@ -195,4 +195,7 @@ samples/apps/autogen-studio/autogenstudio/models/test/
notebook/coding
# dotnet artifacts
-artifacts
\ No newline at end of file
+artifacts
+
+# project data
+registry.json
\ No newline... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
microsoft__autogen-5106@fe28aad | microsoft/autogen | Python | 5,106 | Add sources field to TextMentionTermination | <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. -->
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->
##... | 2025-01-18T22:15:20Z | Stop Conditions for specific agents only
### What feature would you like to be added?
It would be nice if `TextMentionTermination("...")` in v4 could be defined for specific agents i.e. it should only stop if the specific agent sends / receives (tbd) the mentioned text.
### Why is this needed?
More often than not th... | Usually the prompt is set in system message so it won't show up in the message stream. Though I agree adding an `source` field can be useful for allowing only one agent to trigger the termination.
Happy to accept a PR for this.
Really? I heard that system message is mostly used for generic instructions. But for inst... | [
{
"body": "### What feature would you like to be added?\n\nIt would be nice if `TextMentionTermination(\"...\")` in v4 could be defined for specific agents i.e. it should only stop if the specific agent sends / receives (tbd) the mentioned text.\n\n### Why is this needed?\n\nMore often than not the prompt conta... | 34bc82e24ff7e35fd81eced8ac139ca7c93bec52 | {
"head_commit": "fe28aadaf3a65b529e09801b588b83a96b89254c",
"head_commit_message": "Add sources field to TextMentionTermination",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/conditions/_terminations.py b/python/packages/autogen-agentchat/src/autogen_agentchat/conditio... | [
{
"diff_hunk": "@@ -100,14 +100,16 @@ class TextMentionTermination(TerminationCondition, Component[TextMentionTerminat\n \n Args:\n text: The text to look for in the messages.\n+ sources: Check only messages of the specified agents for the text to look for.\n \"\"\"\n \n component_con... | 78de38d51cbdc9e24591d63502a086e959ca52e6 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/conditions/_terminations.py b/python/packages/autogen-agentchat/src/autogen_agentchat/conditions/_terminations.py
index e33f2fcb70a7..7c46545e8c16 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/conditions/_terminations.py
+++ b/p... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
microsoft__autogen-5249@12e45f9 | microsoft/autogen | Python | 5,249 | Add default_header support | <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. -->
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->
##... | 2025-01-29T13:36:18Z | ChatCompletionClient.load_component support default-headers
### What feature would you like to be added?
ChatCompletionClient.load_component support default-headers
### Why is this needed?
When I use AzureOpenAIChatCompletionClient and pass the below parameters, the code is working fine,
model_client = AzureOpen... | When I add **default_headers** property in _AzureOpenAIClientConfigurationConfigModel_, it can work fine.
class AzureOpenAIClientConfigurationConfigModel(BaseOpenAIClientConfigurationConfigModel):
# Azure specific
azure_endpoint: str
azure_deployment: str | None = None
api_version: str
azure_ad_toke... | [
{
"body": "### What feature would you like to be added?\n\nChatCompletionClient.load_component support default-headers\n\n### Why is this needed?\n\nWhen I use AzureOpenAIChatCompletionClient and pass the below parameters, the code is working fine,\n model_client = AzureOpenAIChatCompletionClient(\n ... | 088a50faa5dbf364452ed4489cfaf04c37e9242a | {
"head_commit": "12e45f91e2519e7c081b4d38f7eb010a9703fc57",
"head_commit_message": "Merge branch 'main' into feature/support_default_headers",
"patch_to_review": "diff --git a/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py b/python/packages/autogen-ext/src/autogen_ext/models/openai/_... | [
{
"diff_hunk": "@@ -74,6 +74,7 @@ class BaseOpenAIClientConfigurationConfigModel(CreateArgumentsConfigModel):\n max_retries: int | None = None\n model_capabilities: ModelCapabilities | None = None # type: ignore\n model_info: ModelInfo | None = None\n+ default_header: Dict[str, str] | None = Non... | 6103aafed13877f881f44190e5aa4d57d8c7d6d7 | diff --git a/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py b/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py
index ca652d6580c5..e973862dfe91 100644
--- a/python/packages/autogen-ext/src/autogen_ext/models/openai/_openai_client.py
+++ b/python/packages/autogen-e... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
microsoft__autogen-5026@f041f1c | microsoft/autogen | Python | 5,026 | PoC AGS dev container | ## Why are these changes needed?
This is the first draft of a dev container for AGS. A dev container would streamline contributor onboarding and eliminate environment inconsistencies, reducing setup friction and "works on my machine" issues. This is crucial for AutoGen Studio's Python/React architecture, which requi... | 2025-01-13T13:32:23Z | Dev container for AutoGen Studio
### What feature would you like to be added?
Add a dev container configuration for AutoGen Studio to enable consistent development environments. The dev container should include:
* Python environment with core dependencies for AutoGen Studio development
* Node.js and npm for the front... | [
{
"body": "### What feature would you like to be added?\n\nAdd a dev container configuration for AutoGen Studio to enable consistent development environments. The dev container should include:\n\n* Python environment with core dependencies for AutoGen Studio development\n* Node.js and npm for the frontend stack... | 6954e516b6cb814d6f54e30f977eaabb95b087bc | {
"head_commit": "f041f1c6ed8c013f0df6b59d1fe7418446ddafc0",
"head_commit_message": "Merge branch 'main' into poc-devcontainer",
"patch_to_review": "diff --git a/python/packages/autogen-core/docs/src/user-guide/autogenstudio-user-guide/installation.md b/python/packages/autogen-core/docs/src/user-guide/autogenstud... | [
{
"diff_hunk": "@@ -57,61 +57,65 @@ conda deactivate\n \n ``````\n \n-## Install Using pip (Recommended)\n+## Install from PyPi (Recommended)\n \n You can install AutoGen Studio using pip, the Python package manager.\n \n ```bash\n pip install -U autogenstudio\n ```\n \n-### Install from Source\\*\\*\n+## Insta... | 5fcf4901755feba75d72c68f6adeea407bdc1b1c | diff --git a/python/packages/autogen-core/docs/src/user-guide/autogenstudio-user-guide/installation.md b/python/packages/autogen-core/docs/src/user-guide/autogenstudio-user-guide/installation.md
index 2ca91af58251..0dd73c3cc0af 100644
--- a/python/packages/autogen-core/docs/src/user-guide/autogenstudio-user-guide/insta... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
jax-ml__jax-3162@77224a5 | jax-ml/jax | Python | 3,162 | Simplify handling of non-linear equations in backward_pass and fix remat | Previously, `backward_pass` has been generalized to be able to handle
non-linear computation in the body, but it could easily get confused
into doing unnecessary work only to throw it away later. Additionally, it
treated any call primitive embedded inside remat like remat itself,
which is obviously wrong.
This p... | 2020-05-20T10:58:58Z | remat + eager mode = unnecessary FLOPs in backward_pass
While `remat` takes great care to avoid unnecessary FLOPs during tracing of the primal code (see the discussion around the `concrete` parameter), it looks like some FLOPs have slipped through the cracks in the `backward_pass`! To verify you can apply the diff belo... | Wow, brilliant catch!
I've forgotten the details now, but I think having some structure/bookkeeping to distinguish between primals and tangents from JVPs (and similarly for VJPs) would have been helpful when we were prototyping grad of sharded_jit (specifically in the sharded_jit translation rule I think). Not sure how... | [
{
"body": "While `remat` takes great care to avoid unnecessary FLOPs during tracing of the primal code (see the discussion around the `concrete` parameter), it looks like some FLOPs have slipped through the cracks in the `backward_pass`! To verify you can apply the diff below, that I'm folding for readability.\... | 7d157c71815e5386f2b449bac69ef9e3ab7e701f | {
"head_commit": "77224a52352d7a181672052b2e88635a627da291",
"head_commit_message": "Track the number of remat reevaluations in a test",
"patch_to_review": "diff --git a/jax/interpreters/ad.py b/jax/interpreters/ad.py\nindex cf52c42a1d2f..2e41f77168c1 100644\n--- a/jax/interpreters/ad.py\n+++ b/jax/interpreters/a... | [
{
"diff_hunk": "@@ -548,17 +466,50 @@ def traceable(num_primals, in_tree_def, *primals_and_tangents):\n yield out_flat, tree_def\n \n \n-def call_transpose(primitive, params, call_jaxpr, args, ct):\n+def call_transpose(primitive, params, call_jaxpr, args, ct, _):\n all_args, in_tree_def = tree_flatten(((), ... | 8bfcbeabd8560609a465ecc81abfb63a8b0433ec | diff --git a/jax/interpreters/ad.py b/jax/interpreters/ad.py
index cf52c42a1d2f..2f615168ab94 100644
--- a/jax/interpreters/ad.py
+++ b/jax/interpreters/ad.py
@@ -170,47 +170,18 @@ def write_primal(v, val):
# forces primal_in to contain UndefinedPrimals for tangent values!
map(write_primal, jaxpr.invars, p... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
microsoft__autogen-4995@79de944 | microsoft/autogen | Python | 4,995 | fix: fix user input in m1 | Closes #4975 | 2025-01-10T17:48:09Z | RuntimeError: Failed to get user input: Failed to get user input:
### What happened?
Error doesn't occur with the `--no-hil` option.
```console
(.venv-m1) gaganbansal@MacBook-Pro workspace % m1 "hi"
Enter your response: ---------- user ----------
hi
---------- MagenticOneOrchestrator ----------
We are working to add... | @peterychang , any insights on this? | [
{
"body": "### What happened?\n\nError doesn't occur with the `--no-hil` option.\n\n```console\n(.venv-m1) gaganbansal@MacBook-Pro workspace % m1 \"hi\"\nEnter your response: ---------- user ----------\nhi\n---------- MagenticOneOrchestrator ----------\n\nWe are working to address the following user request:\n\... | 0554fa3e2a647570a798b9ab6e02290f1b823a05 | {
"head_commit": "79de944d9ff44c240c4366a4532c4e25801759a3",
"head_commit_message": "undo changes",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py\nindex 2ad9... | [
{
"diff_hunk": "@@ -3,6 +3,7 @@\n import warnings\n \n from autogen_agentchat.ui import Console\n+from autogen_agentchat.ui._console import UserInputManager",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "python/packages/magentic-one-cli/src/magentic_one_cli/_m1.py",
... | 6a1295da4521f6381e9194c4a0ed3b398c17ce54 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py
index 2ad9a24682f0..89e0b61a50ee 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py
+++ b/p... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
microsoft__autogen-5055@d699556 | microsoft/autogen | Python | 5,055 | Declarative BaseChat Agents | <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. -->
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->
##... | 2025-01-15T06:05:17Z | Support declarative configs for BaseChatAgents (and derivatives) - UserProxy, AssistantAgent, WebSurferAgent
Support a workflow where an Agent's configuration can be made declarative
```python
# dump
agent = AssistantAgent(
name="assistant",
model_client=model_client,
handoffs=["flights_refunder", "user"]... | [
{
"body": "Support a workflow where an Agent's configuration can be made declarative\n\n```python\n\n# dump\nagent = AssistantAgent(\n name=\"assistant\",\n model_client=model_client,\n handoffs=[\"flights_refunder\", \"user\"],\n tools=[web_search],\n system_message=\"Use tools to solve tasks.\"... | 1f22a7b7a169f2f812185517f53437c43cb39fb9 | {
"head_commit": "d69955691277ab996106aa3f64fb21c41856f79a",
"head_commit_message": "Merge branch 'main' into declarative_agentchat_agents_vd",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentc... | [
{
"diff_hunk": "@@ -462,3 +482,34 @@ async def load_state(self, state: Mapping[str, Any]) -> None:\n assistant_agent_state = AssistantAgentState.model_validate(state)\n # Load the model context state.\n await self._model_context.load_state(assistant_agent_state.llm_context)\n+\n+ def ... | 8696814d3e59f2581c2fa15afcf8653ea864a8f2 | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
index 4a359eded38c..2c71a2558df0 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
microsoft__autogen-4984@489db97 | microsoft/autogen | Python | 4,984 | Make termination condition config declarative | <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. -->
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->
... | 2025-01-10T05:59:59Z | Support declarative configs for TerminationCondition
Step 1 in making components in agentchat natively declarative.
```python
from autogen_agentchat.conditions import StopMessageTermination, MaxMessageTermination
max_term = MaxMessageTermination(5)
stop_term = StopMessageTermination()
or_term = max_term | stop_t... | [
{
"body": "Step 1 in making components in agentchat natively declarative. \n\n```python\n\nfrom autogen_agentchat.conditions import StopMessageTermination, MaxMessageTermination \n\nmax_term = MaxMessageTermination(5)\nstop_term = StopMessageTermination() \n\nor_term = max_term | stop_term\nprint(or_term.dump_c... | 9570e82299374b345d2e1e37ea8aa0436754d7da | {
"head_commit": "489db97f5824c47d8a693b1210302f7e92971baa",
"head_commit_message": "make termination condition declarative",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/base/_termination.py b/python/packages/autogen-agentchat/src/autogen_agentchat/base/_termination.py... | [
{
"diff_hunk": "@@ -1,14 +1,19 @@\n import asyncio\n from abc import ABC, abstractmethod\n-from typing import List, Sequence\n+from typing import Any, List, Sequence\n+from typing_extensions import Self\n+\n+from pydantic import BaseModel\n \n from ..messages import AgentEvent, ChatMessage, StopMessage\n+from a... | 9cc873d35186f8428a6eeacadfde09ed1bad0c7e | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/base/__init__.py b/python/packages/autogen-agentchat/src/autogen_agentchat/base/__init__.py
index 5815adc35fa9..dcb0a24c3e79 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/base/__init__.py
+++ b/python/packages/autogen-agentchat/... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
microsoft__autogen-4856@ec37a30 | microsoft/autogen | Python | 4,856 | feat!: Add support for model family specification | Adds support for the model client to advertise the family of model it supports.
This is a non breaking change but the change, however, for a client to properly advertise its family changes are required.
I'm not sure if I like the `ModelFamily` class or not. The idea was to make it easier to find the families tha... | 2024-12-30T16:25:42Z | Add model-family to context of model client
Model families sometimes have different behavior. To allow an agent to modify its behavior based on a give model we should expose model family.
Open question:
- What is the taxonomy of model families?
- How do we allow a user to define a "new" model family while still trying... | [
{
"body": "Model families sometimes have different behavior. To allow an agent to modify its behavior based on a give model we should expose model family.\n\nOpen question:\n- What is the taxonomy of model families?\n- How do we allow a user to define a \"new\" model family while still trying to reduce the surf... | 190fcd15ed7c5a0d32c1608dd9c47aff5867ce16 | {
"head_commit": "ec37a3022583161387b3512ca40d4fb774cab524",
"head_commit_message": "Add support for model family specification",
"patch_to_review": "diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_as... | [
{
"diff_hunk": "@@ -1,28 +1,51 @@\n from __future__ import annotations\n \n+import warnings\n from abc import ABC, abstractmethod\n-from typing import Mapping, Optional, Sequence\n+from typing import Literal, Mapping, Optional, Sequence, TypeAlias\n \n-from typing_extensions import (\n- Any,\n- AsyncGener... | 04c3dc53b4acf35bec716cb3064b06267c594efa | diff --git a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py b/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
index e5f38ea5b8a9..95f8e8dd8dd5 100644
--- a/python/packages/autogen-agentchat/src/autogen_agentchat/agents/_assistant_agent.py
+++ b/pyth... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
jax-ml__jax-3140@0ea946b | jax-ml/jax | Python | 3,140 | Add a primitive integer_pow() for values raised to a fixed integer scalar. | Use `integer_pow()` in the RHS JVP of `div()`. Also use it in `square()` and `reciprocal()`.
Fixes #3136
```
In [1]: from jax import grad, make_jaxpr
In [2]: def inv(x): return 1/x
In [3]: print(grad(grad(grad(grad(grad(grad(inv))))))(4.))
0.043945312
In [4]: make_jaxpr(grad(grad(grad(grad(grad(grad(inv)))... | 2020-05-18T20:46:51Z | Higher order derivatives return wrong results
When trying to compute higher order derivatives of a very simple function:
```python
def inv(x):
return 1/X
print(grad(grad(grad(grad(grad(grad(inv))))))(4.))
```
It prints `-1.9560547` instead of the correct `0.0439453125`.
It starts returning incorrect r... | Just a quick thought for now, though we should look at this more: it seems to be a 32bit numerical tolerance thing because enabling 64bit computation solves it:
```python
from jax import grad
from jax import config
config.update("jax_enable_x64", True)
def inv(x):
return 1/x
f = grad(grad(grad(grad(grad(... | [
{
"body": "When trying to compute higher order derivatives of a very simple function:\r\n\r\n```python\r\ndef inv(x):\r\n return 1/X\r\n\r\nprint(grad(grad(grad(grad(grad(grad(inv))))))(4.))\r\n```\r\n\r\nIt prints `-1.9560547` instead of the correct `0.0439453125`. \r\nIt starts returning incorrect results ... | ed0e227ef516cd48c4a7ab2f9709f883faa1e034 | {
"head_commit": "0ea946bc93f435a7ef825b8a486c127a6e75d4a1",
"head_commit_message": "Add a primitive integer_pow() for values raised to fixed integer scalar.\n\nUse integer_pow() in the RHS JVP of div(). Also use it in square() and reciprocal().\n\nFixes #3136\n\n```\nIn [1]: from jax import grad, make_jaxpr\nIn [2... | [
{
"diff_hunk": "@@ -182,9 +182,7 @@ def gelu(x):\n <https://arxiv.org/abs/1606.08415>`_, section 2.\n \"\"\"\n sqrt_2_over_pi = np.sqrt(2 / np.pi).astype(x.dtype)\n- # Does not use the power operator here.\n- # See https://github.com/google/jax/pull/3036\n- x_cubed = x * x * x\n+ x_cubed = lax.integer... | 0ccfcf112342b2779a79e6a1ef67b94df4911737 | diff --git a/jax/experimental/jet.py b/jax/experimental/jet.py
index d3e4d892b25b..308e00575b70 100644
--- a/jax/experimental/jet.py
+++ b/jax/experimental/jet.py
@@ -261,6 +261,15 @@ def _pow_taylor(primals_in, series_in):
return primal_out, series_out
jet_rules[lax.pow_p] = _pow_taylor
+def _integer_pow_taylor(... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-3160@c9c05ff | jax-ml/jax | Python | 3,160 | revise "Tracer with raw numpy" error message | fixes #3133 | 2020-05-20T03:14:24Z | Tracing a function that indexes into Numpy array gives a poor error message
The following code fails on the last line
```
f = lambda i: jnp.zeros((3, 3))[i, :]
g = lambda i: np.zeros((3, 3))[i, :]
a = np.array([1, 2])
f(a) # Okay
jax.jit(f)(a) # Okay
g(a) # Okay
jax.jit(g)(a) # Fai... | I think the only way to specialize this error would be to do some sort of call stack tracing in ``__array__``. The most useful thing may be to print the context of the call as part of the error; for example, something like this:
```python
import inspect
class MyClass:
def __array__(self):
frame = inspect.c... | [
{
"body": "The following code fails on the last line\r\n\r\n```\r\nf = lambda i: jnp.zeros((3, 3))[i, :]\r\ng = lambda i: np.zeros((3, 3))[i, :]\r\n\r\na = np.array([1, 2])\r\n\r\nf(a) # Okay\r\njax.jit(f)(a) # Okay\r\n\r\ng(a) # Okay\r\njax.jit(g)(a) # Fail\r\n```\r\nwith the standard err... | 42b425d8e556583a2afce6388aa101932805aad1 | {
"head_commit": "c9c05ff5ca5845ed6e14fe23496a20b3e18ce0b7",
"head_commit_message": "fix f-string typo",
"patch_to_review": "diff --git a/jax/core.py b/jax/core.py\nindex 625d9047882b..1c85d85ab4c4 100644\n--- a/jax/core.py\n+++ b/jax/core.py\n@@ -371,11 +371,18 @@ class Tracer(object):\n __slots__ = ['_trace',... | [
{
"diff_hunk": "@@ -371,11 +371,18 @@ class Tracer(object):\n __slots__ = ['_trace', '__weakref__']\n \n def __array__(self, *args, **kw):\n- raise Exception(\"Tracer can't be used with raw numpy functions. \"\n- \"You might have\\n\"\n- \" import numpy as np\\n\"\n... | c68f6746de4a672b1b76cc95234e4e9c95417c39 | diff --git a/jax/core.py b/jax/core.py
index 625d9047882b..81be2e0038af 100644
--- a/jax/core.py
+++ b/jax/core.py
@@ -371,11 +371,18 @@ class Tracer(object):
__slots__ = ['_trace', '__weakref__']
def __array__(self, *args, **kw):
- raise Exception("Tracer can't be used with raw numpy functions. "
- ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-2828@7c7a0ed | jax-ml/jax | Python | 2,828 | handle mapped_invars correctly in more places | fixes #2822
We didn't handle `pmap`'s `mapped_invars` correctly in all places in #1959. (I'm actually not sure if #1959 introduced the bug where things were working before, or just refactored it in terms of `mapped_invars`, though my guess is that because the information now contained in `mapped_invars` was implicit... | 2020-04-24T18:03:55Z | map of pmap IndexError bug
Map of pmap seems to fail due to a strange shape bug. See repro below.
```
import jax.numpy as np
from jax import lax, pmap, vmap, random
def vv(x, y):
"""Vector-vector multiply"""
return np.dot(x, y)
def distributed_matrix_vector(x, y, distributed=True):
"""Matrix vector m... | If we replace the `pmap` call with a `vmap` then we get:
```
Not batched
Outside matrix vector code (800,)
Vmap + vmap (used to be vmap + pmap)
Result (10, 800, 1)
mapped
Result (10, 800)
map + pmap
Result (10, 800, 1)
```
This makes me think that we need to tweak the reshapes on the `distributed=True` ... | [
{
"body": "Map of pmap seems to fail due to a strange shape bug. See repro below.\r\n```\r\nimport jax.numpy as np\r\nfrom jax import lax, pmap, vmap, random\r\n\r\ndef vv(x, y):\r\n \"\"\"Vector-vector multiply\"\"\"\r\n return np.dot(x, y)\r\n\r\ndef distributed_matrix_vector(x, y, distributed=True):\r\n ... | 8f902452abd016b73d287641a5b999e96c3c8365 | {
"head_commit": "7c7a0ede9357e27b71e1975b17b5b26979bfaa56",
"head_commit_message": "handle mapped_invars correctly in more places\n\nfixes #2822\n\nWe didn't handle mapped_invars correctly in all places in #1959. In\nparticular, in #1959 we:\n 1. assumed the `mapped_invars` parameter of xla_pmap_p was only\n ... | [
{
"diff_hunk": "@@ -990,6 +990,9 @@ def process_env_traces(post_processor: str, primitive: Primitive,\n \n def _call_bind(processor: str, post_processor: str, primitive: Primitive,\n f: lu.WrappedFun, *args, **params):\n+ # TODO add a check like this, clean up to get rid of strings",
"line": ... | d7e2206bcffcd34dffe122be866349f26d7953f7 | diff --git a/jax/api.py b/jax/api.py
index f31f88b88c37..7ae1486101db 100644
--- a/jax/api.py
+++ b/jax/api.py
@@ -982,7 +982,8 @@ def f_pmapped(*args, **kwargs):
axis_size=local_axis_size,
global_axis_size=axis_size,
devices=tuple(devices) if devices is not None else devices,
- name=f... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-3048@4909a1b | jax-ml/jax | Python | 3,048 | Update random.logistic() to prevent infinities | Fixes #3043 | 2020-05-11T23:04:51Z | random.logistic returns -inf
If I call jax.random.logistic with key array([2308802225, 3876068305], dtype=uint32) and shape=(10000, 12), the sampled array contains -inf. I don't think this behavior is correct or at least it is not expected and causes downstream code that assumes finite floats to crash.
I can work ar... | This is a consequence of using a 32-bit implementation of the standard logit generating function: x is drawn from a uniform distribution between 0 and 1, then transformed according to `y = log(x / (1 - x))`. For real numbers there is an infinitessimally small chance of `x=0` which maps to `y=-inf`, in 32-bit arithmetic... | [
{
"body": "If I call jax.random.logistic with key array([2308802225, 3876068305], dtype=uint32) and shape=(10000, 12), the sampled array contains -inf. I don't think this behavior is correct or at least it is not expected and causes downstream code that assumes finite floats to crash.\r\n\r\nI can work around t... | 16cf84514862b73a191a02eb551028eb2b16c700 | {
"head_commit": "4909a1bb1bc8a5d2bf5e10459b1bc90ccb3d2463",
"head_commit_message": "Make comment more concise",
"patch_to_review": "diff --git a/jax/random.py b/jax/random.py\nindex 13eae646c46d..0227f309c17e 100644\n--- a/jax/random.py\n+++ b/jax/random.py\n@@ -1227,8 +1227,21 @@ def logistic(key, shape=(), dty... | [
{
"diff_hunk": "@@ -1227,8 +1227,21 @@ def logistic(key, shape=(), dtype=onp.float64):\n \n @partial(jit, static_argnums=(1, 2))\n def _logistic(key, shape, dtype):\n+ # Mathematically, we can compute the distribution by generating uniformly-distributed\n+ # numbers x in the open interval (a, b) and computing... | 0b61facbd8a41805bc602b36c5217c877fa98cd2 | diff --git a/jax/random.py b/jax/random.py
index 13eae646c46d..7d93de5417e1 100644
--- a/jax/random.py
+++ b/jax/random.py
@@ -1227,8 +1227,21 @@ def logistic(key, shape=(), dtype=onp.float64):
@partial(jit, static_argnums=(1, 2))
def _logistic(key, shape, dtype):
+ # Mathematically, we can compute the distributio... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-2508@e087afa | jax-ml/jax | Python | 2,508 | Added clearer error message for tracers in numpy.split | Fixes: #2506
Now we print:
TypeError: In jax.numpy.split argument 2: tracer value encountered where a
concrete value is expected.
Use `functools.partial` or transformation parameters such as `static_argnums`
for `jit` to preserve the concrete value during JAX tracing.
See `https://jax.readthedocs.io/en/latest... | 2020-03-25T10:58:13Z | Confusing error message when passing a traced value to numpy.split
In the following code a traced value is passed to the `num_or_indices` parameter of `numpy.split`:
```
api.jit(lambda idx: np.split(np.zeros((6,2)), idx)(2)
```
The error messages include a chain of exceptions, neither of which :
```
IndexError:... | Will change the error message to:
```
TypeError: In jax.numpy.split argument 2: tracer value encountered where a concrete value is expected.
Use `functools.partial` or transformation parameters such as `static_argnums` for `jit` to preserve the concrete value during JAX tracing.
See `https://jax.readthedocs.io/en/l... | [
{
"body": "In the following code a traced value is passed to the `num_or_indices` parameter of `numpy.split`:\r\n```\r\napi.jit(lambda idx: np.split(np.zeros((6,2)), idx)(2)\r\n```\r\n\r\nThe error messages include a chain of exceptions, neither of which :\r\n```\r\nIndexError: tuple index out of range\r\n```\r... | 3ca7f6e4f120853a5f0c9f98c6b8b2db30300820 | {
"head_commit": "e087afa02bbfb4a469891ad44aaf6657e866d230",
"head_commit_message": "Added clarification for tracers inside jit of grad",
"patch_to_review": "diff --git a/docs/faq.rst b/docs/faq.rst\nindex 07817ee4ca54..3741f986e7c0 100644\n--- a/docs/faq.rst\n+++ b/docs/faq.rst\n@@ -65,6 +65,136 @@ Additional re... | [
{
"diff_hunk": "@@ -65,6 +65,136 @@ Additional reading:\n \n * `JAX - The Sharp Bits: Pure Functions <https://jax.readthedocs.io/en/latest/notebooks/Common_Gotchas_in_JAX.html#%F0%9F%94%AA-Pure-functions>`_.\n \n+.. comment We refer to the anchor below in JAX error messages\n+\n+`Abstract tracer value encount... | c5f4b84272a11cbbe172aa7d84b8df0da9a9b2a4 | diff --git a/docs/faq.rst b/docs/faq.rst
index 07817ee4ca54..6754bbfd4e19 100644
--- a/docs/faq.rst
+++ b/docs/faq.rst
@@ -65,6 +65,138 @@ Additional reading:
* `JAX - The Sharp Bits: Pure Functions <https://jax.readthedocs.io/en/latest/notebooks/Common_Gotchas_in_JAX.html#%F0%9F%94%AA-Pure-functions>`_.
+.. com... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
microsoft__autogen-4711@e34afd9 | microsoft/autogen | Python | 4,711 | Add Documentation for AGS | <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. -->
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->
... | 2024-12-15T05:33:49Z | Add v1 documentation for AutoGen Studio to v0.4 website.
Update v0.4 website to add documentation for AutoGen Studio.
- [ ] Update packages page
- [ ] Add docs
- [ ] Installation
- [ ] Usage
- [ ] FAQs | [
{
"body": "Update v0.4 website to add documentation for AutoGen Studio. \n\n \n\n- [ ] Update packages page \n- [ ] Add docs \n - [ ] Installation \n - [ ] Usage \n - [ ] FAQs \n",
"number": 4706,
"title": "Add v1 documentation for AutoGen Studio to v0.4 website."
}
] | 7c0bbf674fe1a02060fd4e4b8d0dd09590f00500 | {
"head_commit": "e34afd9cb8e60d2af54b5404731df9b4500d117c",
"head_commit_message": "update docs readme/image",
"patch_to_review": "diff --git a/python/packages/autogen-core/docs/src/user-guide/autogenstudio-user-guide/faq.md b/python/packages/autogen-core/docs/src/user-guide/autogenstudio-user-guide/faq.md\nnew ... | [
{
"diff_hunk": "@@ -0,0 +1,55 @@\n+---\n+myst:\n+ html_meta:\n+ \"description lang=en\": |\n+ Usage for AutoGen Studio - A low code tool for building and debugging multi-agent systems\n+---\n+\n+# Usage\n+\n+The expected usage behavior is that developers use the provided Team Builder interface to to de... | b9510c6dbec6d56c91b53097f43b5d935d47c906 | diff --git a/python/packages/autogen-core/docs/src/user-guide/autogenstudio-user-guide/faq.md b/python/packages/autogen-core/docs/src/user-guide/autogenstudio-user-guide/faq.md
new file mode 100644
index 000000000000..0894df2528d9
--- /dev/null
+++ b/python/packages/autogen-core/docs/src/user-guide/autogenstudio-user-g... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
jax-ml__jax-1268@16bd272 | jax-ml/jax | Python | 1,268 | Fix cond batching rule issues | Fixes #1263, which lacks broadcasting mechanism for `select` (thanks @mattjj)
Fixes a swap of `tconst_bat, t_bat, fconst_bat, f_bat` in batching rule implementation too. | 2019-08-30T02:29:55Z | cond batching rule shape mismatch
A simple script to repro
```
from jax import lax, numpy as np, vmap, jit, random
from jax.config import config; config.update('jax_platform_name', 'cpu')
def f(rng, x):
cond = random.bernoulli(rng)
y = np.abs(x) - 1.
return lax.cond(cond, x, lambda x: x, y, lambda ... | Thanks for catching this! I think it's just that the `Select` HLO / `lax.select` primitive has limited automatic broadcasting (which we sometimes forget), so we need to do the broadcast ourselves. We did this [for the While batching rule](https://github.com/google/jax/blob/fd9e0333a6430bb06bd7a0c9faa650c66fdf2a21/jax/l... | [
{
"body": "A simple script to repro\r\n```\r\nfrom jax import lax, numpy as np, vmap, jit, random\r\nfrom jax.config import config; config.update('jax_platform_name', 'cpu')\r\n\r\ndef f(rng, x):\r\n cond = random.bernoulli(rng)\r\n y = np.abs(x) - 1.\r\n return lax.cond(cond, x, lambda x: x, y, lambda... | c3e52cfc5af3b3c628e04c2dc74024d48f828854 | {
"head_commit": "16bd27258d01aa28a55c1d3771a6b6b82aa8f475",
"head_commit_message": "use lax instead of numpy to avoid circular import",
"patch_to_review": "diff --git a/jax/lax/lax_control_flow.py b/jax/lax/lax_control_flow.py\nindex d9689500a1ae..1f5915064318 100644\n--- a/jax/lax/lax_control_flow.py\n+++ b/jax... | [
{
"diff_hunk": "@@ -339,7 +344,7 @@ def _cond_batching_rule(args, dims, true_jaxpr, false_jaxpr, true_nconsts,\n args, [1, true_nconsts, true_nops, false_nconsts])\n size, = {x.shape[d] for x, d in zip(args, dims) if d is not batching.not_mapped}\n orig_bat = [d is not batching.not_mapped for d in dim... | b7edc39bcf77a3c372b08736d17c002f72e5d9a9 | diff --git a/jax/lax/lax_control_flow.py b/jax/lax/lax_control_flow.py
index d9689500a1ae..dbd1d09e041b 100644
--- a/jax/lax/lax_control_flow.py
+++ b/jax/lax/lax_control_flow.py
@@ -329,6 +329,10 @@ def make_computation(name, jaxpr, op_shape):
return c.Conditional(pred, true_op, true_c, false_op, false_c)
+def ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-1613@eae47b2 | jax-ml/jax | Python | 1,613 | vmap improvements | The aim here is to close #183 (a one-liner, after all this time!), close #705, and close #795.
Re: #183, we just had to replace this line:
```python
in_tracers = map(partial(BatchTracer, trace), in_vals, in_dims)
```
with this one:
```python
in_tracers = [BatchTracer(trace, val, dim) if dim is not No... | 2019-10-31T17:41:24Z | Allow vmap to accept unbatchable arguments if they aren't mapped over
I want to use vmap on functions that have some arguments which don't need to be mapped over. I can specify this using in_axes, but vmap doesn't allow this for some argument types. It seems to check if every argument is a valid type for batching, ev... | I think we can make this work by making an in-axis of `None` do something similar to what `argnums` does in `grad` (i.e. basically doing the `partial`/closure thing).
I just got this error:
```
TypeError: got inconsistent map dimension sizes: {64, 1, 10, 4}
```
which really stumped me for a while... More clarity he... | [
{
"body": "I want to use vmap on functions that have some arguments which don't need to be mapped over. I can specify this using in_axes, but vmap doesn't allow this for some argument types. It seems to check if every argument is a valid type for batching, even if that argument is ignored due to in_axes. Can... | b3e4a1a8501fcedde190a19d6f21625ae15e2314 | {
"head_commit": "eae47b2330b445d07a79fb2173084d3f13d59ebb",
"head_commit_message": "improve vmap error messages\n\nfixes #705",
"patch_to_review": "diff --git a/jax/api.py b/jax/api.py\nindex 75c6170bf9be..853612219385 100644\n--- a/jax/api.py\n+++ b/jax/api.py\n@@ -565,21 +565,28 @@ def vmap(fun, in_axes=0, out... | [
{
"diff_hunk": "@@ -565,21 +565,28 @@ def vmap(fun, in_axes=0, out_axes=0):\n \n Args:\n fun: Function to be mapped over additional axes.\n- in_axes: Specifies which input axes to map over. Normally this is a tuple with\n- one axes specification for each function argument. An integer is interpret... | 46fe76c23a652800d465da27eba10fe9e0753707 | diff --git a/jax/api.py b/jax/api.py
index 75c6170bf9be..e742fbab8f19 100644
--- a/jax/api.py
+++ b/jax/api.py
@@ -47,7 +47,8 @@
from .api_util import (wraps, flatten_fun, apply_flat_fun, flatten_fun_nokwargs,
flatten_fun_nokwargs2, apply_flat_fun_nokwargs)
from .tree_util import (tree_map, tr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jax-ml__jax-1790@7ec2ac5 | jax-ml/jax | Python | 1,790 | Implement gamma sampler using core.Primitive interface | This PR tries to address #1789. While working on a fix, I realize that (compiling time) `lax.map` outperforms `vmap` for most usage cases. So I believe that the tests for gamma/beta/dirichlet will be much faster than before. With this, probably #552 and #1188 is not necessary to be addressed anymore.
However, I am g... | 2019-12-01T15:12:39Z | grad and vmap do not composable with gamma sampler
Here is a repro code, which triggers error `NotImplementedError: Forward-mode differentiation rule for 'while' not implemented` when trying to take gradient of `g`.
```
import jax
import jax.numpy as np
jax.config.update('jax_platform_name', 'cpu')
def f(a):
... | This is another manifestation of https://github.com/google/jax/issues/1249.
Oh... Thanks, @shoyer! That seems like the problem which I get. I'll try to see if I can go back to several months ago to not use custom_transform for gamma sampler. | [
{
"body": "Here is a repro code, which triggers error `NotImplementedError: Forward-mode differentiation rule for 'while' not implemented` when trying to take gradient of `g`.\r\n```\r\nimport jax\r\nimport jax.numpy as np\r\njax.config.update('jax_platform_name', 'cpu')\r\n\r\ndef f(a):\r\n return jax.rando... | c5a9eba3a8742c9d8f4e40fa9c2f43839f1d8481 | {
"head_commit": "7ec2ac58ca3fb2142dc1bf2b4eb5335f119273cc",
"head_commit_message": "not use custom transform for gamma sampler",
"patch_to_review": "diff --git a/jax/random.py b/jax/random.py\nindex 92806f1c7308..941a0ddec2e8 100644\n--- a/jax/random.py\n+++ b/jax/random.py\n@@ -41,7 +41,9 @@\n from jax import a... | [
{
"diff_hunk": "@@ -878,18 +880,46 @@ def _case4(zagf):\n def _gamma_grad(sample, a):\n samples = np.reshape(sample, -1)\n alphas = np.reshape(a, -1)\n- grads = vmap(_gamma_grad_one)(samples, alphas)\n+ if np.size(alphas) == 1:\n+ grads = _gamma_grad_one(samples[0], alphas[0])\n+ else:\n... | 6f50e3f0db2803ca82b8525ebb68c08f88e0c10f | diff --git a/jax/random.py b/jax/random.py
index 84b1562ac5ad..4a7341bf822c 100644
--- a/jax/random.py
+++ b/jax/random.py
@@ -41,8 +41,11 @@
from jax import abstract_arrays
from jax.numpy.linalg import cholesky
from jax.scipy.special import logit
+from jax.interpreters import ad
from jax.interpreters import batchi... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-1175@d857d3f | jax-ml/jax | Python | 1,175 | improve prng compile times with loop rolling | fixes #1172
Code from #1172:
```python
from jax import jit, random
from jax.config import config; config.update("jax_platform_name", "cpu")
import time
def f(key, i):
for _ in range(i):
_, key = random.split(key)
return key
for i in range(17):
t = time.time()
key = jit(f, sta... | 2019-08-13T14:20:33Z | compiling time grows non-linear w.r.t. the number of random.split ops
A repro code
```
from jax import jit, random
from jax.config import config; config.update("jax_platform_name", "cpu")
import time
def f(key, i):
for _ in range(i):
_, key = random.split(key)
return key
for i in range(17):... | Thanks for opening this. We'll look into it.
Can you send me a master list of JAX bugs that are blocking or otherwise inconveniencing your work? I want to prioritize them, but I fear that I've lost track of the most important ones.
This isn't a great workaround, but just to make sure you're aware, if you make just o... | [
{
"body": "A repro code\r\n```\r\nfrom jax import jit, random\r\nfrom jax.config import config; config.update(\"jax_platform_name\", \"cpu\")\r\nimport time\r\n\r\ndef f(key, i):\r\n for _ in range(i):\r\n _, key = random.split(key)\r\n return key\r\n\r\nfor i in range(17):\r\n t = time.time()\r... | 744216f13fefc1de6295467e99aac32b180cf164 | {
"head_commit": "d857d3f595f387495b016b6b60de91ed9636af79",
"head_commit_message": "improve prng compile times with outer-loop rolling",
"patch_to_review": "diff --git a/jax/random.py b/jax/random.py\nindex 1f7e5a5cf49a..535941031cfa 100644\n--- a/jax/random.py\n+++ b/jax/random.py\n@@ -123,38 +123,19 @@ def app... | [
{
"diff_hunk": "@@ -398,6 +398,7 @@ def testIssue756(self):\n self.assertEqual(onp.result_type(w), onp.float32)\n \n def testNoOpByOpUnderHash(self):\n+ raise SkipTest() # TODO(mattjj): re-enable this test",
"line": null,
"original_line": 401,
"original_start_line": null,
"path": "te... | 75bb38e7418aa5203badea7d0bcf6afc1272a177 | diff --git a/jax/random.py b/jax/random.py
index 1f7e5a5cf49a..0a2474ce912f 100644
--- a/jax/random.py
+++ b/jax/random.py
@@ -32,7 +32,7 @@
from . import numpy as np
from . import tree_util
from .api import custom_transforms, defjvp, jit, vmap
-from .numpy.lax_numpy import _constant_like, asarray
+from .numpy.lax_n... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
jax-ml__jax-1234@e90457d | jax-ml/jax | Python | 1,234 | add dtype warnings to array-creation routines | fixes #1230
Unless the `jax_enable_x64` option is set, we truncate all 64 bit dtypes to their 32bit counterparts (and complex128 to complex64) by using the function `xla_bridge.canonicalize_dtype` in both lax_numpy.py and lax.py. According to #1230 that behavior can be surprising when a user writes code that explici... | 2019-08-22T16:25:12Z | JAX should throw an error (or warning?) when asked to cast to a dtype it does not support on a device
I believe JAX should in some way notify the user when a cast operation cannot be performed.
``` python
a = np.ones((1,2,3))
print(a.dtype) # reports float32
a = np.array(a, dtype='float64') # JAX should throw an er... | Great point, you're right! Let's do this.
By the way, if you want to switch on support for 64-bit values (in which case this cast will work as you expect), see the first item in our [Gotchas list](https://github.com/google/jax#current-gotchas). | [
{
"body": "I believe JAX should in some way notify the user when a cast operation cannot be performed.\r\n``` python\r\na = np.ones((1,2,3))\r\nprint(a.dtype) # reports float32\r\na = np.array(a, dtype='float64') # JAX should throw an error on this line\r\nprint(a.dtype) # reports float32\r\n```",
"number":... | 80ac43bbae6549b79f7a40dd75970900b2e1c8d5 | {
"head_commit": "e90457d737ba287d46a063aff467f2079a92b722",
"head_commit_message": "add dtype warnings to array-creation routines\n\nfixes #1230",
"patch_to_review": "diff --git a/jax/lax/__init__.py b/jax/lax/__init__.py\nindex 26d6a8274a83..47eabb8f81d3 100644\n--- a/jax/lax/__init__.py\n+++ b/jax/lax/__init__... | [
{
"diff_hunk": "@@ -1442,38 +1443,49 @@ def array(object, dtype=None, copy=True, order=\"K\", ndmin=0):\n \n @_wraps(onp.asarray)\n def asarray(a, dtype=None, order=None):\n+ lax._check_user_dtype_supported(dtype, \"asarray\")\n return array(a, dtype=dtype, copy=False, order=order)\n \n \n @_wraps(onp.zeros_... | afe21bafa4d2f280941b2ae410280b1e902c0356 | diff --git a/jax/lax/__init__.py b/jax/lax/__init__.py
index 26d6a8274a83..47eabb8f81d3 100644
--- a/jax/lax/__init__.py
+++ b/jax/lax/__init__.py
@@ -18,7 +18,7 @@
_reduce_and, _reduce_window_sum, _reduce_window_max,
_reduce_window_min, _reduce_window_prod, _float, _complex,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-1118@8c628a2 | jax-ml/jax | Python | 1,118 | Implement lax.map | Fixes GH-1113 | 2019-08-05T19:14:27Z | lax.map
Sometimes, it makes more sense to repeatedly apply a function the old fashioned way in a loop, rather than the auto-batching `vmap` way. Use cases that come to mind:
- Reduced memory usage.
- Heterogeneous computation, if using primitives like `cond` and `while_loop`.
This can be done with `lax.scan`, but ... | Great idea. Thinking about it only for a moment, the only thing this implementation might miss out on compared to writing our own `lax.map` primitive is that XLA might not notice that the loop is parallelizable (since we'll build a computation that threads through a trivial carry of `()` and ignores it, so XLA would ne... | [
{
"body": "Sometimes, it makes more sense to repeatedly apply a function the old fashioned way in a loop, rather than the auto-batching `vmap` way. Use cases that come to mind:\r\n- Reduced memory usage.\r\n- Heterogeneous computation, if using primitives like `cond` and `while_loop`.\r\n\r\nThis can be done wi... | 3afed05446252083f2bc870539b5fbcb0447fbb9 | {
"head_commit": "8c628a267becaf36c19d450bf75f1e12a95da91e",
"head_commit_message": "Implement lax.map\n\nFixes GH-1113",
"patch_to_review": "diff --git a/docs/jax.lax.rst b/docs/jax.lax.rst\nindex 3e6dc45063ac..8f74f3414a54 100644\n--- a/docs/jax.lax.rst\n+++ b/docs/jax.lax.rst\n@@ -133,6 +133,7 @@ Control flow ... | [
{
"diff_hunk": "@@ -889,3 +889,34 @@ def scan_bind(consts, init, xs, forward, length, jaxpr):\n pe.custom_partial_eval_rules[scan_p] = _scan_partial_eval\n xla.initial_style_translations[scan_p] = xla.lower_fun(_scan_impl, initial_style=True)\n batching.primitive_batchers[scan_p] = _scan_batching_rule\n+\n+\n+d... | 548e5fa7baf17d41416750c32c86e58f617b760c | diff --git a/docs/jax.lax.rst b/docs/jax.lax.rst
index 3e6dc45063ac..8f74f3414a54 100644
--- a/docs/jax.lax.rst
+++ b/docs/jax.lax.rst
@@ -133,6 +133,7 @@ Control flow operators
cond
fori_loop
+ map
scan
while_loop
diff --git a/jax/lax/lax_control_flow.py b/jax/lax/lax_control_flow.py
index 1... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
jax-ml__jax-1025@f25b2f8 | jax-ml/jax | Python | 1,025 | Merge scatter and gather indexing implementations. | I would still like to do some performance benchmarking (i.e., write some benchmarks), but sending this out for an initial review.
Fixes #1006 | 2019-07-16T18:26:59Z | Load from 2d array within vmap results in two gathers rather than just one
```
import jax
import jax.numpy as np
import numpy as onp
def test(arr, x, y):
return arr[x, y]
rand_x = onp.random.randint(0, 200, size=1024)
rand_y = onp.random.randint(0, 200, size=1024)
rand_arr = onp.random.uniform(0, 1, size=... | Just adding more info to this: this behavior is because of how we implemented NumPy indexing in [`jax.numpy._rewriting_take`](https://github.com/google/jax/blob/8e794ad98806d61fdfed4bf243d81c8545f741cc/jax/numpy/lax_numpy.py#L2167), in that we basically handle one index at a time just for simplicity's sake (and because... | [
{
"body": "```\r\nimport jax\r\nimport jax.numpy as np\r\nimport numpy as onp\r\n\r\ndef test(arr, x, y):\r\n return arr[x, y]\r\n\r\nrand_x = onp.random.randint(0, 200, size=1024)\r\nrand_y = onp.random.randint(0, 200, size=1024)\r\nrand_arr = onp.random.uniform(0, 1, size=(200,200))\r\ntest_vmap = jax.vmap(t... | d90993f798ff00404e2d5869f78d3642d99b6a33 | {
"head_commit": "f25b2f878b381e56f12d90b6c7e4b919f71a5b4b",
"head_commit_message": "Merge scatter and gather indexing implementations.",
"patch_to_review": "diff --git a/jax/numpy/lax_numpy.py b/jax/numpy/lax_numpy.py\nindex f3a8ff9d37b2..d4434f1e958a 100644\n--- a/jax/numpy/lax_numpy.py\n+++ b/jax/numpy/lax_num... | [
{
"diff_hunk": "@@ -541,6 +541,7 @@ def fun(unpacked_indexer, x):\n for dtype in all_dtypes\n for rng in [jtu.rand_default()])\n def testAdvancedIntegerIndexing(self, shape, dtype, rng, indexer):\n+ print(\"indexer\", indexer)",
"line": null,
"original_line": 544,
"original_start_li... | 549cd23f3a427b009ff22dad88b5808a6696a6a1 | diff --git a/jax/numpy/lax_numpy.py b/jax/numpy/lax_numpy.py
index f3a8ff9d37b2..d4434f1e958a 100644
--- a/jax/numpy/lax_numpy.py
+++ b/jax/numpy/lax_numpy.py
@@ -2207,160 +2207,288 @@ def take_along_axis(arr, indices, axis):
### Indexing
+def _rewriting_take(arr, idx):
+ # Computes arr[idx].
+ # All supported c... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
jax-ml__jax-976@d04954d | jax-ml/jax | Python | 976 | Convert int input to static_argnums to a tuple | User could make mistake of passing an int to static_argnums, this helps to avoid unnecessary error.
Fix #969 | 2019-07-04T17:30:33Z | convert integer for `static_argnums` to tuple automatically
I've made the same mistake a few times on `static_argnums` on `jit` function, by not using a tuple
e.g., `jit(f, static_argnums=1)`
would it be possible / reasonable to add a simple `if` statement to convert it to tuple?
where the correct way is `jit(... | [
{
"body": "I've made the same mistake a few times on `static_argnums` on `jit` function, by not using a tuple \r\n\r\ne.g., `jit(f, static_argnums=1)`\r\nwould it be possible / reasonable to add a simple `if` statement to convert it to tuple?\r\n\r\nwhere the correct way is `jit(f, static_argnums=(1,) )`\r\n\r... | b9b49a3b3abc1cd1cc65174433abee2a9cd05df8 | {
"head_commit": "d04954d31f4807655166f2053691d5e005e62ac5",
"head_commit_message": "Convert int input to static_argnums to a tuple\n\nUser could make mistake of passing an int to static_argnums, this helps to avoid unnecessary error.",
"patch_to_review": "diff --git a/jax/api.py b/jax/api.py\nindex 047df3c9f4c5.... | [
{
"diff_hunk": "@@ -110,6 +110,9 @@ def _jit(fun, static_argnums, device_values=True):\n def f_jitted(*args, **kwargs):\n if _jit_is_disabled or config.read('jax_disable_jit'):\n return fun(*args, **kwargs)\n+ if isinstance(static_argnums, int):\n+ # static_argnums is a tuple of ints\n+ ... | f3a741ef28c1a1e5f941b1607998e5b45bd8ae78 | diff --git a/jax/api.py b/jax/api.py
index 047df3c9f4c5..0f43232dd5fe 100644
--- a/jax/api.py
+++ b/jax/api.py
@@ -110,6 +110,9 @@ def _jit(fun, static_argnums, device_values=True):
def f_jitted(*args, **kwargs):
if _jit_is_disabled or config.read('jax_disable_jit'):
return fun(*args, **kwargs)
+ if i... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
jax-ml__jax-868@4e872b9 | jax-ml/jax | Python | 868 | Implement batching for np.linalg.solve | Fixes #826
Also fix a type mismatch bug in dynamic_slice_in_dim exposed by the new tests. | 2019-06-18T01:21:44Z | linalg.solve doesn't respect broadcasting semantics
I'm attempting a batched matrix solve,
```python
import jax.numpy as jp
import numpy as np
A = np.eye(2)[np.newaxis]
b = np.ones((3, 2))
print(A.shape, b.shape)
print(np.linalg.solve(A, b))
print(jp.linalg.solve(A, b))
```
but I'm getting the following:
`... | I also observed this problem and solved it by making `A` and `b` have the same batch_shape (using `np.broadcast_to`).
@fehiepsi Hmm that's not actually working for me. I now have shapes `(3, 2, 2)` and `(3, 2)` for A and b, respectively but I'm still seeing the same error.
And `A.shape == (3, 2, 2)` `b.shape == (3, 2... | [
{
"body": "I'm attempting a batched matrix solve,\r\n```python\r\nimport jax.numpy as jp\r\nimport numpy as np\r\n\r\nA = np.eye(2)[np.newaxis]\r\nb = np.ones((3, 2))\r\nprint(A.shape, b.shape)\r\nprint(np.linalg.solve(A, b))\r\nprint(jp.linalg.solve(A, b))\r\n```\r\nbut I'm getting the following:\r\n```\r\n(1,... | 0190684ee216f13d9a379ef55c94d866401f7281 | {
"head_commit": "4e872b96b97433ad6a05a03903d592082e49e2ef",
"head_commit_message": "Fix type mismatch with int32-type indices under a jit with 64-bit types enabled.",
"patch_to_review": "diff --git a/jax/lax/lax.py b/jax/lax/lax.py\nindex 3dd0bd4e51e5..597d33d02deb 100644\n--- a/jax/lax/lax.py\n+++ b/jax/lax/lax... | [
{
"diff_hunk": "@@ -1164,7 +1164,7 @@ def index_in_dim(operand, index, axis=0, keepdims=True):\n \n def dynamic_slice_in_dim(operand, start_index, slice_size, axis=0):\n \"\"\"Convenience wrapper around dynamic_slice applying to one dimension.\"\"\"\n- start_indices = [onp.array([0])] * operand.ndim\n+ star... | 88cc66d169be055da535f2d2b410ec9520f4b4ec | diff --git a/jax/lax/lax.py b/jax/lax/lax.py
index 3dd0bd4e51e5..0f065566d18e 100644
--- a/jax/lax/lax.py
+++ b/jax/lax/lax.py
@@ -1164,7 +1164,7 @@ def index_in_dim(operand, index, axis=0, keepdims=True):
def dynamic_slice_in_dim(operand, start_index, slice_size, axis=0):
"""Convenience wrapper around dynamic_sl... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-778@7ee59e9 | jax-ml/jax | Python | 778 | Instantiate symbolic zeros in the scatter-add transpose rule. | Fixes #776. | 2019-05-28T14:31:47Z | Scatter transpose rule doesn’t handle symbolic zeros
Unfortunately, I don't have a terribly concise repro for this error. From playing around with it, it seems as though the error probably involves index_update, but it's hard to be sure. However, given the function
```python
def nvt_nose_hoover(energy_fn, dt, T, ch... | Looks like just a bug in the scatter transpose rule; it doesn’t handle symbolic zeros like transpose rules need to.
Totally for my own curiosity, is there a reason why this only affects the version where apply_fn was jitted? | [
{
"body": "Unfortunately, I don't have a terribly concise repro for this error. From playing around with it, it seems as though the error probably involves index_update, but it's hard to be sure. However, given the function\r\n\r\n```python\r\ndef nvt_nose_hoover(energy_fn, dt, T, chain_length=5, tau=0.01):\r\n... | 90eda42e6efe6edab5bb8db330a88f173ef7c60f | {
"head_commit": "7ee59e96d347dcf6f6707fecca91267207560f68",
"head_commit_message": "Instantiate symbolic zeros in the scatter-add transpose rule.\n\nFixes #776.",
"patch_to_review": "diff --git a/jax/lax/lax.py b/jax/lax/lax.py\nindex 442300300a61..522ccdb982bc 100644\n--- a/jax/lax/lax.py\n+++ b/jax/lax/lax.py\... | [
{
"diff_hunk": "@@ -2809,6 +2809,7 @@ def _scatter_add_transpose_rule(t, operand, scatter_indices, updates,\n operand_t = t\n \n if updates is None:\n+ t = ad.instantiate_zeros(operand, t)",
"line": null,
"original_line": 2812,
"original_start_line": null,
"path": "jax/lax/lax.py",
... | cfdf1cd3e900122d8b29f4a3d8f2c266f8c48bef | diff --git a/jax/lax/lax.py b/jax/lax/lax.py
index 442300300a61..de0ca96faf09 100644
--- a/jax/lax/lax.py
+++ b/jax/lax/lax.py
@@ -2804,6 +2804,9 @@ def _scatter_add_transpose_rule(t, operand, scatter_indices, updates,
update_jaxpr, update_consts, dimension_numbers,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
jax-ml__jax-818@12b90dd | jax-ml/jax | Python | 818 | make custom_transforms handle pytrees, add api.defvjp | Before this PR, using `custom_transforms` (from #419) with functions that took tuples/lists/dicts (i.e. pytrees) as arguments would silently fail. Moreover, defining custom rules that took as input or returned as output any pytree values wouldn't work. Finally, `custom_transforms` functions didn't automatically support... | 2019-06-05T19:02:34Z | Easy api for custom primitives and vjps
JAX supports custom primitives and vjps, just like Autograd did. Improvements:
1) add this to documentation
2) add a minimal example of this in the examples section
3) add a wrapper function if appropriate? | Thanks.
I am most concerned about adding wrappers of external libraries that have already been implemented with other forms of computing backend. We use a set of operators for particle mesh simulation and FFTs.
When we are talking about custom primitives, we also need to notify the auto-differ how to pick the te... | [
{
"body": "JAX supports custom primitives and vjps, just like Autograd did. Improvements:\r\n1) add this to documentation\r\n2) add a minimal example of this in the examples section\r\n3) add a wrapper function if appropriate?",
"number": 116,
"title": "Easy api for custom primitives and vjps"
}
] | 1feefd10ac42189ff9333a51138c67e67457d0bd | {
"head_commit": "12b90ddf68a61c4449bc3c978dc76a794c04acc9",
"head_commit_message": "fix typo",
"patch_to_review": "diff --git a/docs/jax.rst b/docs/jax.rst\nindex 857f54932c9e..00a9eade7440 100644\n--- a/docs/jax.rst\n+++ b/docs/jax.rst\n@@ -19,6 +19,6 @@ Module contents\n ---------------\n \n .. automodule:: ja... | [
{
"diff_hunk": "@@ -952,25 +954,608 @@ def _valid_jaxtype(arg):\n return True\n \n \n+class CustomTransformsFunction(object):\n+ def __init__(self, fun, prim):\n+ self.fun = fun\n+ self.prim = prim\n+ wraps(fun)(self)\n+\n+ def __repr__(self):\n+ return '<jax.custom_transforms function {fun}>'... | 7c308dca29d0042e7375a633f08f4723d9fc54d7 | diff --git a/docs/jax.rst b/docs/jax.rst
index 857f54932c9e..00a9eade7440 100644
--- a/docs/jax.rst
+++ b/docs/jax.rst
@@ -19,6 +19,6 @@ Module contents
---------------
.. automodule:: jax
- :members: jit, disable_jit, grad, value_and_grad, vmap, pmap, jacfwd, jacrev, hessian, jvp, linearize, vjp, make_jaxpr, ev... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
jax-ml__jax-661@978d838 | jax-ml/jax | Python | 661 | Add support for batched LU decomposition. | Fixes #655. | 2019-04-30T17:22:59Z | Implement vmap/batching support for LU decomposition
I'm trying to solve linear equations Ax = b with vmap:
```python
import jax.numpy as np
import jax.random as random
from jax import vmap
key = random.PRNGKey(0)
A = random.normal(key, shape=(100, 2, 2))
x = random.normal(key, shape=(100, 2))
b = vmap(l... | I can add a simple implementation that batches by performing LU decompositions in a loop easily enough. | [
{
"body": "I'm trying to solve linear equations Ax = b with vmap:\r\n\r\n```python\r\nimport jax.numpy as np\r\nimport jax.random as random\r\nfrom jax import vmap\r\n\r\nkey = random.PRNGKey(0)\r\n\r\nA = random.normal(key, shape=(100, 2, 2))\r\nx = random.normal(key, shape=(100, 2))\r\nb = vmap(lambda A, x: A... | 0f495b65adbc7d3603e148dd2d5b044962de9728 | {
"head_commit": "978d838733e8eeb77d043dc72a24141d9cb07874",
"head_commit_message": "Add test for QR batching.",
"patch_to_review": "diff --git a/jax/lax_linalg.py b/jax/lax_linalg.py\nindex 75bde6362b37..f6b6838d6bab 100644\n--- a/jax/lax_linalg.py\n+++ b/jax/lax_linalg.py\n@@ -47,8 +47,7 @@ def eigh(x, lower=Tr... | [
{
"diff_hunk": "@@ -47,8 +47,7 @@ def eigh(x, lower=True, symmetrize_input=True):\n def lu(x): return lu_p.bind(x)\n \n def qr(x, full_matrices=True):\n- q, r = qr_p.bind(x, full_matrices=full_matrices)\n- return q, r\n+ return qr_p.bind(x, full_matrices=full_matrices)",
"line": null,
"original_line"... | 00cb31df113d62102aad274e57f0babb4656bc80 | diff --git a/jax/lax_linalg.py b/jax/lax_linalg.py
index 75bde6362b37..aa8120e28ca5 100644
--- a/jax/lax_linalg.py
+++ b/jax/lax_linalg.py
@@ -42,9 +42,12 @@ def cholesky(x, symmetrize_input=True):
def eigh(x, lower=True, symmetrize_input=True):
if symmetrize_input:
x = symmetrize(x)
- return eigh_p.bind(x, l... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
microsoft__autogen-4159@afbda9c | microsoft/autogen | Python | 4,159 | .net changes to re-enable xlang support, add subscription apis | adding subscription request/response api
adds response on register agent
closes #4154
cleanup some package versions
improves hello samples
fixes a few asynhronous await bugs found along the way
| 2024-11-12T21:04:33Z | add Subscription management apis to service
### What feature would you like to be added?
need to add support for
message TypeSubscription {
string topic_type = 1;
string agent_type = 2;
}
message Subscription {
oneof subscription {
TypeSubscription typeSubscription = 1;
}
}
message AddSubscr... | [
{
"body": "### What feature would you like to be added?\n\nneed to add support for \nmessage TypeSubscription {\n string topic_type = 1;\n string agent_type = 2;\n}\n\nmessage Subscription {\n oneof subscription {\n TypeSubscription typeSubscription = 1;\n }\n}\n\nmessage AddSubscriptionReque... | 2b7658a9dafd34d0e7039975c89c53693e1d9d92 | {
"head_commit": "afbda9c444f982ef1ae4d3e52ae7e3d7d1bfcf3d",
"head_commit_message": "fix busted merge from main",
"patch_to_review": "diff --git a/dotnet/Directory.Packages.props b/dotnet/Directory.Packages.props\nindex c1b26f2f9b91..5321860e427f 100644\n--- a/dotnet/Directory.Packages.props\n+++ b/dotnet/Directo... | [
{
"diff_hunk": "@@ -0,0 +1,48 @@\n+// Copyright (c) Microsoft Corporation. All rights reserved.\n+// SubscriptionsGrain.cs\n+\n+namespace Microsoft.AutoGen.Agents;\n+\n+public sealed class SubscriptionsGrain([PersistentState(\"state\", \"PubSubStore\")] IPersistentState<SubscriptionsState> state) : Grain, ISubs... | ffbe67206bdca0ee2dcd16493839c2c632543ef0 | diff --git a/dotnet/Directory.Packages.props b/dotnet/Directory.Packages.props
index c1b26f2f9b91..5321860e427f 100644
--- a/dotnet/Directory.Packages.props
+++ b/dotnet/Directory.Packages.props
@@ -4,26 +4,25 @@
<MicrosoftSemanticKernelVersion>1.22.0</MicrosoftSemanticKernelVersion>
<MicrosoftSemanticKernelE... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
microsoft__autogen-3980@4a5db95 | microsoft/autogen | Python | 3,980 | Agentbase refactor | Remove some unused code and refactor so that IAgentBase/IAgentContext open up possibility of abstracting the grpc services so that we can also provide a completely in-memory runtime.
closes #3950 | 2024-10-28T16:49:05Z | decouple .NET grpc and runtime so that runtime is pluggable
### What feature would you like to be added?
we really could do with having the grace layer disentangled from Orleans/in-memory/dapr etc so the the runtime and api protocol are separated.
### Why is this needed?
separation of concerns | [
{
"body": "### What feature would you like to be added?\n\nwe really could do with having the grace layer disentangled from Orleans/in-memory/dapr etc so the the runtime and api protocol are separated. \n\n### Why is this needed?\n\nseparation of concerns",
"number": 3950,
"title": "decouple .NET grpc a... | 87bd1de3966a6881b0bdbe147f5775da895e0256 | {
"head_commit": "4a5db951fba4e93366755e0f7b7511e70f946eff",
"head_commit_message": "Merge branch 'main' into agentbase-refactor",
"patch_to_review": "diff --git a/dotnet/AutoGen.sln b/dotnet/AutoGen.sln\nindex 83147d38dc7b..5d83a07f0a9c 100644\n--- a/dotnet/AutoGen.sln\n+++ b/dotnet/AutoGen.sln\n@@ -127,6 +127,8... | [
{
"diff_hunk": "@@ -19,18 +19,18 @@ public async ValueTask SendResponseAsync(RpcRequest request, RpcResponse respons\n }\n public async ValueTask SendRequestAsync(AgentBase agent, RpcRequest request)\n {\n- await _runtime.SendRequest(agent, request);\n+ await _runtime.SendRequest(agent... | 132427fca7f151d5f68a2dcbdaa91a4b9e1e2a68 | diff --git a/dotnet/samples/Hello/HelloAgent/README.md b/dotnet/samples/Hello/HelloAgent/README.md
index 795eed07281d..2de64ebaa01b 100644
--- a/dotnet/samples/Hello/HelloAgent/README.md
+++ b/dotnet/samples/Hello/HelloAgent/README.md
@@ -118,4 +118,4 @@ message ReadmeRequested {
</ItemGroup>
```
-You can send me... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
microsoft__autogen-4044@e5bddfc | microsoft/autogen | Python | 4,044 | [.NET] Update version of Microsoft.Extension.Ai & System.Text.Json | <!-- Thank you for your contribution! Please review https://microsoft.github.io/autogen/docs/Contribute before opening a pull request. -->
<!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. -->
##... | 2024-11-01T23:36:38Z | [.Net] Update M.E.A.I to 9.0.0-preview.9.24525.1
### What feature would you like to be added?
And S.T.J to `8.0.5`
### Why is this needed?
The latest M.E.A.I now depends on a lower `STJ` version. Much friendly to existing projects which can't update STJ to 9.* for some reason | @LittleLittleCloud If we update `Microsoft.Extensions.Ai` to `9.0.0-preview.9.24525.1`, we cannot downgrade `System.Text.Json` because `9.0.0-rc.2.24473.5` is the min version.
https://www.nuget.org/packages/Microsoft.Extensions.AI/9.0.0-preview.9.24525.1#dependencies-body-tab:~:text=9.0.0%2Drc.2.24473.5)-,System.Text.... | [
{
"body": "### What feature would you like to be added?\n\nAnd S.T.J to `8.0.5`\n\n### Why is this needed?\n\nThe latest M.E.A.I now depends on a lower `STJ` version. Much friendly to existing projects which can't update STJ to 9.* for some reason",
"number": 4031,
"title": "[.Net] Update M.E.A.I to 9.0... | 5e0b677acc10bbbf4fab889bbcc0c70f3f13abb8 | {
"head_commit": "e5bddfc3eb355ac4f73863dcc353fef821445c46",
"head_commit_message": "remove copilot generated comment",
"patch_to_review": "diff --git a/dotnet/Directory.Build.props b/dotnet/Directory.Build.props\nindex bb78c84d14f4..81b36c126e2e 100644\n--- a/dotnet/Directory.Build.props\n+++ b/dotnet/Directory.... | [
{
"diff_hunk": "@@ -13,6 +13,10 @@\n <CSNoWarn>CS1998;CS1591;CS8002;</CSNoWarn>\n <SKEXPNoWarn>SKEXP0001;SKEXP0010;SKEXP0020</SKEXPNoWarn>\n <NoWarn>$(NoWarn);$(CSNoWarn);$(SKEXPNoWarn);NU5104</NoWarn>\n+\n+ <!-- Some properties require a different version of System.Json.Text > 8.0.5\n+ Some c... | ad1c22d865ead33090f375a6e311d80d8fd5ccde | diff --git a/dotnet/Directory.Build.props b/dotnet/Directory.Build.props
index ae30d2c48a5e..1e84f78232ad 100644
--- a/dotnet/Directory.Build.props
+++ b/dotnet/Directory.Build.props
@@ -13,6 +13,7 @@
<CSNoWarn>CS1998;CS1591;CS8002;</CSNoWarn>
<SKEXPNoWarn>SKEXP0001;SKEXP0010;SKEXP0020</SKEXPNoWarn>
<NoW... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.