instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
marimo-team__marimo-1381@3b94410 | marimo-team/marimo | Python | 1,381 | Hotkey for splitting cells | Fixes: https://github.com/marimo-team/marimo/issues/1372
The issue mentioned using Ctrl+Shift+- as the hotkey, but that seemed to have some interaction with zooming in the browser.
I have the hotkey set to Mod+Shift+' for now; if you'd like to change that, I'm happy to do so!
Also, tested in the browser but co... | 2024-05-15T20:25:18Z | Split Cell Hotkey
### Description
Many of our users have asked for the ability to split cells using a hotkey. This would be a great first issue.
### Suggested solution
A hotkey to split a cell at the current line into two cells, similar to Jupyter. Maybe `Ctrl+Shift+-`.
### Alternative
_No response_
### Additiona... | [
{
"body": "### Description\n\nMany of our users have asked for the ability to split cells using a hotkey. This would be a great first issue.\n\n### Suggested solution\n\nA hotkey to split a cell at the current line into two cells, similar to Jupyter. Maybe `Ctrl+Shift+-`.\n\n### Alternative\n\n_No response_\n\n... | 26436b37b6b29609910b50a3925b56e5dcea6daf | {
"head_commit": "3b9441021d406825d456dbfcb96f236aedbcf043",
"head_commit_message": "Hotkey for splitting cells",
"patch_to_review": "diff --git a/frontend/src/components/editor/cell/code/cell-editor.tsx b/frontend/src/components/editor/cell/code/cell-editor.tsx\nindex b04c53d8763..e38f226df17 100644\n--- a/front... | [
{
"diff_hunk": "@@ -236,6 +240,21 @@ export function cellMovementBundle(\n return true;\n },\n },\n+ {\n+ key: HOTKEYS.getHotkey(\"cell.splitCell\").key,\n+ preventDefault: true,\n+ stopPropagation: true,\n+ run: (ev) => {\n+ const cursorPos = ev.state.selection.m... | c1f6271d9a9a53e60e4eed761b8aaf2e2a0b02ba | diff --git a/frontend/src/components/editor/cell/code/cell-editor.tsx b/frontend/src/components/editor/cell/code/cell-editor.tsx
index b04c53d8763..e38f226df17 100644
--- a/frontend/src/components/editor/cell/code/cell-editor.tsx
+++ b/frontend/src/components/editor/cell/code/cell-editor.tsx
@@ -91,7 +91,7 @@ const Cel... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
marimo-team__marimo-1304@bc69046 | marimo-team/marimo | Python | 1,304 | Improvement: annotate cycles with variable names | Fixes #847 | 2024-05-02T20:33:01Z | Naming in cycle resolution
### Description
I am trying to migrate a notebook with a cycle. It is hard to debug especially when the cycle is long.
### Suggested solution
Could the edges of the dependency graph be annotated with the variable names? For example
```
This cell is in a cycle:
cell-5 -> cell-0
c... | Fantastic suggestion -- we should do this! Will get around to it when we have spare time. | [
{
"body": "### Description\r\n\r\nI am trying to migrate a notebook with a cycle. It is hard to debug especially when the cycle is long.\r\n\r\n### Suggested solution\r\n\r\nCould the edges of the dependency graph be annotated with the variable names? For example \r\n```\r\nThis cell is in a cycle:\r\ncell-5 ->... | 7df6c5e00d52a73f17b30222630617ad20be63dc | {
"head_commit": "bc6904605c06aa93d2ec371f96d71a721dac7719",
"head_commit_message": "switched to list instead of set",
"patch_to_review": "diff --git a/frontend/src/components/editor/output/MarimoErrorOutput.tsx b/frontend/src/components/editor/output/MarimoErrorOutput.tsx\nindex 80ea506f963..73928b4c21b 100644\n... | [
{
"diff_hunk": "@@ -32,11 +32,11 @@\n from types import ModuleType\n \n \n-def _check_edges(error: Error, expected_edges: Sequence[Edge]) -> None:\n+def _check_edges(error: Error, expected_edges: Sequence[EdgeWithVar]) -> None:\n assert isinstance(error, CycleError)\n- assert len(error.edges) == len(... | 89cc570636f69b83dd763ec6a95afec87424776f | diff --git a/frontend/src/components/editor/output/MarimoErrorOutput.tsx b/frontend/src/components/editor/output/MarimoErrorOutput.tsx
index 80ea506f963..c49fe49a9cd 100644
--- a/frontend/src/components/editor/output/MarimoErrorOutput.tsx
+++ b/frontend/src/components/editor/output/MarimoErrorOutput.tsx
@@ -63,11 +63,1... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-5996@1012f64 | modin-project/modin | Python | 5,996 | FEAT-#6014: Stop defaulting to pandas in groupby frontend for fill-like methods | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
Taking certain progress done by Ponder guys into upstream.
<!-- Please give a short brie... | 2023-04-13T08:32:49Z | Stop defaulting to pandas in groupby frontend for fill-like methods
Instead of calling `self._default_to_pandas()` in `modin/pandas/groupby.py`, we should call the query compiler and let it default to pandas if something is not implemented.
This allows to implement such functions in non-pandas backends like HDK and ... | [
{
"body": "Instead of calling `self._default_to_pandas()` in `modin/pandas/groupby.py`, we should call the query compiler and let it default to pandas if something is not implemented.\r\n\r\nThis allows to implement such functions in non-pandas backends like HDK and other non-pandas engines.\r\n\r\nThis issue i... | cf9e7fcc917c7acc156c9e18747fecfc2da57cdd | {
"head_commit": "1012f644bbc5bddc87d26a00de26b3916eab15a9",
"head_commit_message": "Fix lint issues",
"patch_to_review": "diff --git a/modin/core/dataframe/algebra/default2pandas/__init__.py b/modin/core/dataframe/algebra/default2pandas/__init__.py\nindex 876b1e6a8af..2ad4064ca00 100644\n--- a/modin/core/datafra... | [
{
"diff_hunk": "@@ -3135,12 +3156,24 @@ def groupby_agg_builder(df, by=None, drop=False, partition_idx=None):\n by = []\n \n by += not_broadcastable_by\n+ if level is not None:\n+ assert not by, \"When handling simple level groupby, `by` must be empty\"\n+ ... | abb748ef92476461d28174d1f4fcbb5362aaed9e | diff --git a/modin/core/dataframe/algebra/default2pandas/__init__.py b/modin/core/dataframe/algebra/default2pandas/__init__.py
index fbbab29c439..e753e591064 100644
--- a/modin/core/dataframe/algebra/default2pandas/__init__.py
+++ b/modin/core/dataframe/algebra/default2pandas/__init__.py
@@ -22,7 +22,7 @@
from .rollin... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
marimo-team__marimo-1278@7dedef9 | marimo-team/marimo | Python | 1,278 | improvement: mo.ui.spinner can display without a context manager | Fixes #1271
Add a `_mime_()` to the spinner class to display without a context manager | 2024-04-30T17:39:00Z | Possibility of placing "Spinner" element anywhere on UI, similar to other UI components (Buttons, forms etc.)
### Description
I'm looking for a way to place a spinner element that pops up upon some user interaction, to show the status of a long running task (calculation). As I work with UI elements, like buttons, form... | I have a fix out for this: https://github.com/marimo-team/marimo/pull/1278
Here is an example for usage:
```python
import marimo
__generated_with = "0.4.7"
app = marimo.App()
@app.cell
def __():
import marimo as mo
return mo,
@app.cell
def __(mo):
counter_button = mo.ui.button(
... | [
{
"body": "### Description\n\nI'm looking for a way to place a spinner element that pops up upon some user interaction, to show the status of a long running task (calculation). As I work with UI elements, like buttons, forms, batch etc, I often stack these together using vstack or hstack, to order elements neat... | ee0ee043c3647380decda7664f812ae15fbd8eaa | {
"head_commit": "7dedef97b55c8b67eff2c15b2d4cd996d8534850",
"head_commit_message": "pycheck",
"patch_to_review": "diff --git a/marimo/_plugins/stateless/status/_progress.py b/marimo/_plugins/stateless/status/_progress.py\nindex 782063000dd..3276dd38441 100644\n--- a/marimo/_plugins/stateless/status/_progress.py\... | [
{
"diff_hunk": "@@ -239,21 +234,49 @@ def spinner(\n mo.ui.table(data)\n ```\n \n+ You can also show the spinner without a context manager:\n+\n+ ```python\n+ mo.hstack(\n+ [\n+ mo.status.spinner(title=\"Loading ...\")\n+ if condition\n+ else mo.md(\"Done... | f847ca46f6a6599c6eb7d9f75a96891bdc23c2c2 | diff --git a/marimo/_plugins/stateless/status/_progress.py b/marimo/_plugins/stateless/status/_progress.py
index 782063000dd..71ec67f55b3 100644
--- a/marimo/_plugins/stateless/status/_progress.py
+++ b/marimo/_plugins/stateless/status/_progress.py
@@ -1,18 +1,18 @@
# Copyright 2024 Marimo. All rights reserved.
from ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
marimo-team__marimo-1170@8d5785d | marimo-team/marimo | Python | 1,170 | improvement: support plotly config and renderers | Fixes #846
Adds support for plotly config and using their `pio.renderers` feature.
```python
@app.cell
def __(fig, mo):
fig # Uses the default renderer
return
@app.cell
def __(fig, mo):
mo.ui.plotly(fig) # Uses the default renderer
return
@app.cell
def __(fig, mo):
mo.ui.pl... | 2024-04-18T17:46:04Z | Plotly renderer config support
### Describe the bug
I want to set plotly defaults. In Jupyter I normally use scrollZoom and editable plots by default.
But in Marimo it seems that plotly plots neither have scrollZoom nor are they editable. Are either possible? Do I need to choose a different 'renderer'? Wrapping in a ... | @jamieray , thanks for opening this issue. We haven't really looked into default Plotly rendering options. How important is it to you that we support this?
I'll still have some use for Marimo without `editable`, but I use `scrollZoom` on almost every plot because I don't know what axis limits will be useful a priori. ... | [
{
"body": "### Describe the bug\n\nI want to set plotly defaults. In Jupyter I normally use scrollZoom and editable plots by default.\n\nBut in Marimo it seems that plotly plots neither have scrollZoom nor are they editable. Are either possible? Do I need to choose a different 'renderer'? Wrapping in a mo.ui.pl... | af34fd8146d79af0326d2929f74415b6fb78fbaf | {
"head_commit": "8d5785dd5745f9921128bb2d4772f01c42259a98",
"head_commit_message": "fixes",
"patch_to_review": "diff --git a/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx b/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx\nindex 9f6c1cbe262..592378ed0bf 100644\n--- a/frontend/src/plugins/impl/plotly/PlotlyP... | [
{
"diff_hunk": "@@ -0,0 +1,106 @@\n+# Copyright 2024 Marimo. All rights reserved.\n+\n+import marimo\n+\n+__generated_with = \"0.4.0\"\n+app = marimo.App()\n+\n+\n+@app.cell\n+def __(mo):\n+ mo.md(\n+ \"This notebook covers a couple different cases for rendering plotly under different configs and with... | 915d72a91036feef1c55e5dccaa3c1fa744d7e27 | diff --git a/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx b/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx
index 9f6c1cbe262..592378ed0bf 100644
--- a/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx
+++ b/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx
@@ -13,9 +13,11 @@ import useEvent from "react-use-even... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
marimo-team__marimo-1146@da1c095 | marimo-team/marimo | Python | 1,146 | feat: mo.cli_args | Fixes #1137
Use `mo.cli_args` to access command-line arguments passed to the notebook. This allows you to pass arguments to the notebook that are not controllable by the user. The arguments will be parsed from the command line when running the notebook as an application with `marimo run` or `marimo edit`. These a... | 2024-04-17T02:41:08Z | Provide non-Marimo command-line arguments to app
### Description
Access a filtered list of command-line arguments that were not used by Marimo, mostly to configure notebooks running as scripts.
### Suggested solution
Provide some API, e.g. `mo.args()`, similar to `mo.query_params()`, that returns a list of arg... | +1
I think it'd be ideal if query_params and args shared the command
I sketched this out a bit a while back. I didn't want to combine the two implicitly because the author can control the CLI args, while the user can control the query-params, and by default it would be nice to keep those permissions separate. Also the... | [
{
"body": "### Description\r\n\r\nAccess a filtered list of command-line arguments that were not used by Marimo, mostly to configure notebooks running as scripts.\r\n\r\n### Suggested solution\r\n\r\nProvide some API, e.g. `mo.args()`, similar to `mo.query_params()`, that returns a list of arguments that Marimo... | 99dcddd299acc68b0a9af8af297afb49571a9743 | {
"head_commit": "da1c09564432f2d473aa4cb887ee3287d930a9a4",
"head_commit_message": "Apply suggestions from code review",
"patch_to_review": "diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml\nindex 8cbed43481b..13a115c2d28 100644\n--- a/.github/workflows/test.yaml\n+++ b/.github/workflows/te... | [
{
"diff_hunk": "@@ -215,6 +215,28 @@ def query_params() -> QueryParams:\n return get_context().kernel.query_params\n \n \n+@mddoc\n+def cli_args() -> CLIArgs:\n+ \"\"\"Get the command line arguments of a marimo app.",
"line": null,
"original_line": 220,
"original_start_line": null,
"path"... | 38ded11359848a81cac2b6067aed48fe5f5b1355 | diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index 8cbed43481b..13a115c2d28 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -66,7 +66,7 @@ jobs:
test_python:
name: Tests on ${{ matrix.os }}, Python ${{ matrix.python-version }} with ${{ matrix.dependencies ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
marimo-team__marimo-1002@1df65d9 | marimo-team/marimo | Python | 1,002 | feat: create_asgi_app to programatically run marimo apps | This exposes a new function from the `marimo` module: `create_asgi_app`. Which is a builder to add many marimo apps:
Closes #904 #395
Regarding the API:
* i chose a builder instead of seperate `create_asgi_app` so 1) we can share configs, 2) we can initialize shared singletons between the apps
* i called the to... | 2024-03-26T00:26:56Z | Embed Marimo in FastAPI/Starlette Server
### Description
I'd like to make Marimo embeddable in another FastAPI / Starlette server, i.e. Marimo as a library.
### Suggested solution
```python
from marimo import Instance # made up :)
my_notebook = Instance('/path/to/notebook.py')
my_notebook.start_kernel(... | This is something I've thought about and makes a lot of sense. I'm not sure what the best entrypoint is (file-path, app code, etc) and what the API is (return a starlette app, routes, etc)
We will need to think about this, and we are open to suggestions. Ideally the API is minimal but room to expand.
Have you see... | [
{
"body": "### Description\n\nI'd like to make Marimo embeddable in another FastAPI / Starlette server, i.e. Marimo as a library.\r\n\r\n\r\n\n\n### Suggested solution\n\n```python\r\nfrom marimo import Instance # made up :) \r\n\r\nmy_notebook = Instance('/path/to/notebook.py')\r\n\r\nmy_notebook.start_kernel(... | 7fbbac4cae57a42e455d0d2fc57add8d2e7c6a83 | {
"head_commit": "1df65d9539b5b3282e59e1215e73b912a598fe43",
"head_commit_message": "fix asgi",
"patch_to_review": "diff --git a/docs/guides/deploying/index.md b/docs/guides/deploying/index.md\nindex dd877ab2636..def789008e1 100644\n--- a/docs/guides/deploying/index.md\n+++ b/docs/guides/deploying/index.md\n@@ -5... | [
{
"diff_hunk": "@@ -64,39 +66,39 @@ async def __call__(\n return await self.app(scope, receive, send)\n \n \n-ALLOWED_BASE_URLS = set([\"/health\", \"/healthz\", \"/metrics\", \"/\"])\n+# ALLOWED_BASE_URLS = set([\"/health\", \"/healthz\", \"/metrics\", \"/\"])\n \n \n-class StripBaseURLMiddleware:\n- ... | 7a1459dfa5088656b76feeea40fb7109e3f3b221 | diff --git a/docs/guides/deploying/index.md b/docs/guides/deploying/index.md
index dd877ab2636..def789008e1 100644
--- a/docs/guides/deploying/index.md
+++ b/docs/guides/deploying/index.md
@@ -5,6 +5,7 @@
:maxdepth: 2
:hidden:
+ programmatically
deploying_docker
deploying_public_gallery
```
@@ -13,6 +14... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
marimo-team__marimo-1021@656d7e8 | marimo-team/marimo | Python | 1,021 | feat: enable toggling to md mode automatically via mod-shift-m | Features demonstrated in video:
- markdown toggle in cell menu
- markdown toggle doesnt show in cell menu when non-markdown-convertible code
- markdown shortcut works (mod-shift-m)
However, it seems that when a cell is created, the `editorView` is null until _something_ is typed. For this reason, I only know how ... | 2024-03-29T00:34:16Z | Markdown Cell Shortcut?
### Description
I have to type `mo.md()` first to start a markdown cell / get the markdown editor to show up (I think?)
### Suggested solution
Have either a shortcut (cmd+shift+m?) or UI method in a cell's six-dot menu to convert a cell to markdown instead, so I can immediately start text usi... | > I have to type mo.md() first to start a markdown cell / get the markdown editor to show up (I think?)
Yes, that's right.
In marimo, there are only Python cells; we don't have a distinction between Python and Markdown cells. The markdown editor is just a friendly skin over `mo.md()`.
> Have either a shortcut ... | [
{
"body": "### Description\n\nI have to type `mo.md()` first to start a markdown cell / get the markdown editor to show up (I think?)\n\n### Suggested solution\n\nHave either a shortcut (cmd+shift+m?) or UI method in a cell's six-dot menu to convert a cell to markdown instead, so I can immediately start text us... | 5d0c854c6350935dd74366e8c6513c45cebba00e | {
"head_commit": "656d7e8b7b046e657984e3296aee6648608fe632",
"head_commit_message": "feat: enable toggling to md mode automatically via mod-shift-m",
"patch_to_review": "diff --git a/frontend/src/components/editor/actions/useCellActionButton.tsx b/frontend/src/components/editor/actions/useCellActionButton.tsx\nin... | [
{
"diff_hunk": "@@ -58,3 +63,37 @@ export function formatAll(updateCellCode: CellActions[\"updateCellCode\"]) {\n const views = notebookCellEditorViews(getNotebook());\n return formatEditorViews(views, updateCellCode);\n }\n+\n+export function canToggleMarkdown(editorView: EditorView | null) {\n+ if (\n+ ... | c883ad5b921ef9c19e296725b1eff5e2c273aa4e | diff --git a/frontend/src/components/editor/actions/useCellActionButton.tsx b/frontend/src/components/editor/actions/useCellActionButton.tsx
index 39054da87fc..a0beb3fc34a 100644
--- a/frontend/src/components/editor/actions/useCellActionButton.tsx
+++ b/frontend/src/components/editor/actions/useCellActionButton.tsx
@@ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
marimo-team__marimo-841@e8c6358 | marimo-team/marimo | Python | 841 | Fix: form internal value | This PR handles an edge case in which the form's wrapped element changes its value without firing an event, due to Python re-creating the form
Fixes #840 | 2024-02-27T00:41:25Z | `ui.form()` initial value not updated when re-rendered
### Describe the bug
This issue was raised on Discord by @ztawil.
When a `form` element is re-rendered without unmounting/remounting, its initial value in the frontend isn't updated, causing it to return the incorrect value on submit.
This can be seen by p... | [
{
"body": "### Describe the bug\r\n\r\nThis issue was raised on Discord by @ztawil.\r\n\r\nWhen a `form` element is re-rendered without unmounting/remounting, its initial value in the frontend isn't updated, causing it to return the incorrect value on submit.\r\n\r\nThis can be seen by populating the form's ini... | 087b2624bcfad7da9902184b9d4ebc6e09bcc2bc | {
"head_commit": "e8c6358a062c7bb7c62c5ee799bb909f9e140ba4",
"head_commit_message": "Fix: form internal value",
"patch_to_review": "diff --git a/frontend/src/plugins/impl/FormPlugin.tsx b/frontend/src/plugins/impl/FormPlugin.tsx\nindex 1fa1d80e3a1..e93713b823c 100644\n--- a/frontend/src/plugins/impl/FormPlugin.ts... | [
{
"diff_hunk": "@@ -225,6 +225,14 @@ const Form = ({\n setInternalValue(UI_ELEMENT_REGISTRY.lookupValue(elementId));\n }, [elementId]);\n \n+ // Edge case: the Form plugin may be re-created in Python with the same\n+ // wrapped `elementId`, meaning the value of the wrapped element\n+ // can change with... | fb9b85b0cdeb062d17d604e35f65da58cb26a8a7 | diff --git a/frontend/src/plugins/impl/FormPlugin.tsx b/frontend/src/plugins/impl/FormPlugin.tsx
index 1fa1d80e3a1..7f21541e595 100644
--- a/frontend/src/plugins/impl/FormPlugin.tsx
+++ b/frontend/src/plugins/impl/FormPlugin.tsx
@@ -225,6 +225,14 @@ const Form = ({
setInternalValue(UI_ELEMENT_REGISTRY.lookupValue(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
marimo-team__marimo-357@9843590 | marimo-team/marimo | Python | 357 | Add indexes property to mo.ui.plotly, and update points to use original column names | Fixes https://github.com/marimo-team/marimo/issues/353
* Add indexes property to mo.ui.plotly - this is a great escape hatch to filter an original dataset in case not all the data is passed to plotly)
* update points to use original column names, instead of `x`, `y`
| 2023-11-15T15:24:39Z | mo.ui.plotly: send tooltip back in selection
### Description
One of our users was using reactive plotly.
Their plot had some tooltips, and they would like the tooltips to be sent back with selection.
### Suggested solution
Include a "tooltip" key in the entries of `fig.value`
```
{"x": ..., "y": ..., "tooltip... | [
{
"body": "### Description\n\nOne of our users was using reactive plotly.\r\n\r\nTheir plot had some tooltips, and they would like the tooltips to be sent back with selection.\n\n### Suggested solution\n\nInclude a \"tooltip\" key in the entries of `fig.value`\r\n\r\n```\r\n{\"x\": ..., \"y\": ..., \"tooltip\":... | 206226d70f936d0f0ad7c905710f3f8444109277 | {
"head_commit": "98435901f1f91e98f9f18dca172532c74f78107a",
"head_commit_message": "Add indexes property to mo.ui.plotly, and update points to use original column names",
"patch_to_review": "diff --git a/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx b/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx\nindex ... | [
{
"diff_hunk": "@@ -120,6 +121,14 @@ def points(self) -> List[Dict[str, Any]]:\n return []\n return self._selection_data[\"points\"] # type:ignore\n \n+ @property\n+ def indexes(self) -> List[int]:",
"line": null,
"original_line": 125,
"original_start_line": null,
"pat... | c3b2c3f7f840863ea5ea59f2b1ac1e03f48dc77a | diff --git a/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx b/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx
index 6b4aa8af753..7ace6c54b3e 100644
--- a/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx
+++ b/frontend/src/plugins/impl/plotly/PlotlyPlugin.tsx
@@ -7,9 +7,9 @@ import Plot, { Figure } from "react-plo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
matplotlib__matplotlib-30202@36299b6 | matplotlib/matplotlib | Python | 30,202 | Add explicit overloads for pyplot.{show,subplot} | <!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
## PR summary
This PR update `lib/matplotlib/pyplot.py` to add overloads for the following methods:
- `subplot`
- `show`
## PR checklist
- [... | 2025-06-21T11:24:04Z | [MNT]: pyplot type hints
### Summary
Is there any reason why some functions in `pyplot.py` use `*args` and `**kwargs` as their only parameters (e.g. show, figlegend, or savefig) and therefore have untyped parameters?
### Proposed fix
Specify the actual signature or type parameters with Unpack[TypedDict] and Unpack[t... | It depends: in the majority of cases e.g. `savefig`, `figlegend` these are customized wrappers and `*args, **kwargs` are only shorthands to pass though all parameters. You could spell them out explicitly at the cost of having to ensure consistency manually whenever the signature changes. There's a part of pyplot wrappe... | [
{
"body": "### Summary\n\nIs there any reason why some functions in `pyplot.py` use `*args` and `**kwargs` as their only parameters (e.g. show, figlegend, or savefig) and therefore have untyped parameters?\n\n### Proposed fix\n\nSpecify the actual signature or type parameters with Unpack[TypedDict] and Unpack[t... | 5a10e4d29d2929a4093a42f9263c8237b2be6360 | {
"head_commit": "36299b62a2b1ae3be1363044e779da06b6d120ba",
"head_commit_message": "Create subplot overloads on pyplot.py\n\n(cherry picked from commit f4693e3c984f4775e29c3d10e48f58ae7de84e98)",
"patch_to_review": "diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py\nindex cf5c9b4b739f..6a72bc091b0... | [
{
"diff_hunk": "@@ -569,6 +569,14 @@ def draw_if_interactive(*args, **kwargs):\n return _get_backend_mod().draw_if_interactive(*args, **kwargs)\n \n \n+@overload\n+def show() -> None: ...\n+\n+\n+@overload\n+def show(block: bool) -> None: ...",
"line": null,
"original_line": 577,
"original_start... | 768e69bc4277b9b62ec33dde8232dd7cd81a93fc | diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py
index cf5c9b4b739f..d3da41ca9d5c 100644
--- a/lib/matplotlib/pyplot.py
+++ b/lib/matplotlib/pyplot.py
@@ -569,6 +569,14 @@ def draw_if_interactive(*args, **kwargs):
return _get_backend_mod().draw_if_interactive(*args, **kwargs)
+@overload
+def sh... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
matplotlib__matplotlib-30199@b5dfb32 | matplotlib/matplotlib | Python | 30,199 | Add explicit getter / setter overloads for pyplot.{xlim,ylim} | <!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
## PR summary
This PR update the `tools/boilerplate.py` for autogenerate getter / setter:
- `Axes.xlim`
- `Axes.ylim`
- Any method with the follo... | 2025-06-21T11:12:08Z | [MNT]: pyplot type hints
### Summary
Is there any reason why some functions in `pyplot.py` use `*args` and `**kwargs` as their only parameters (e.g. show, figlegend, or savefig) and therefore have untyped parameters?
### Proposed fix
Specify the actual signature or type parameters with Unpack[TypedDict] and Unpack[t... | It depends: in the majority of cases e.g. `savefig`, `figlegend` these are customized wrappers and `*args, **kwargs` are only shorthands to pass though all parameters. You could spell them out explicitly at the cost of having to ensure consistency manually whenever the signature changes. There's a part of pyplot wrappe... | [
{
"body": "### Summary\n\nIs there any reason why some functions in `pyplot.py` use `*args` and `**kwargs` as their only parameters (e.g. show, figlegend, or savefig) and therefore have untyped parameters?\n\n### Proposed fix\n\nSpecify the actual signature or type parameters with Unpack[TypedDict] and Unpack[t... | 5a10e4d29d2929a4093a42f9263c8237b2be6360 | {
"head_commit": "b5dfb32058ef8ef10f931f0f337e9bffb2113338",
"head_commit_message": "Revert boilerplate.py and manually copy xlim and ylim overloads on pyplot.py",
"patch_to_review": "diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py\nindex cf5c9b4b739f..c16b79895759 100644\n--- a/lib/matplotlib/py... | [
{
"diff_hunk": "@@ -2096,6 +2096,25 @@ def box(on: bool | None = None) -> None:\n ## Axis ##\n \n \n+@overload\n+def xlim() -> tuple[float, float]:\n+ ...\n+\n+\n+# Autogenerated by boilerplate.py. Do not edit as changes will be lost.",
"line": null,
"original_line": 2104,
"original_start_line":... | 2f615827ce8771c1a541c6c442d38689c5368364 | diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py
index cf5c9b4b739f..afc2be9a1221 100644
--- a/lib/matplotlib/pyplot.py
+++ b/lib/matplotlib/pyplot.py
@@ -2096,6 +2096,24 @@ def box(on: bool | None = None) -> None:
## Axis ##
+@overload
+def xlim() -> tuple[float, float]:
+ ...
+
+
+@overload
+d... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
matplotlib__matplotlib-30200@8ee42ff | matplotlib/matplotlib | Python | 30,200 | Add explicit signatures for pyplot.{polar,savefig,set_loglevel} | <!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
## PR summary
This PR update `lib/matplotlib/pyplot.py`to replace `*args, **kwargs` with the real signature for the following methods:
- `savefig`
... | 2025-06-21T11:17:46Z | [MNT]: pyplot type hints
### Summary
Is there any reason why some functions in `pyplot.py` use `*args` and `**kwargs` as their only parameters (e.g. show, figlegend, or savefig) and therefore have untyped parameters?
### Proposed fix
Specify the actual signature or type parameters with Unpack[TypedDict] and Unpack[t... | It depends: in the majority of cases e.g. `savefig`, `figlegend` these are customized wrappers and `*args, **kwargs` are only shorthands to pass though all parameters. You could spell them out explicitly at the cost of having to ensure consistency manually whenever the signature changes. There's a part of pyplot wrappe... | [
{
"body": "### Summary\n\nIs there any reason why some functions in `pyplot.py` use `*args` and `**kwargs` as their only parameters (e.g. show, figlegend, or savefig) and therefore have untyped parameters?\n\n### Proposed fix\n\nSpecify the actual signature or type parameters with Unpack[TypedDict] and Unpack[t... | 5a10e4d29d2929a4093a42f9263c8237b2be6360 | {
"head_commit": "8ee42ff9de44ba03298ab85592c4a04ee5554e96",
"head_commit_message": "Add type hint on polar and set_loglevel on pyplot.py. Correct polar content\n\n(cherry picked from commit 92dc04501bab539586cac48a3266891c75a4cb7c)",
"patch_to_review": "diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pypl... | [
{
"diff_hunk": "@@ -2690,7 +2690,13 @@ def matshow(A: ArrayLike, fignum: None | int = None, **kwargs) -> AxesImage:\n return im\n \n \n-def polar(*args, **kwargs) -> list[Line2D]:\n+def polar(\n+ *args: float | ArrayLike | str,\n+ scalex: bool = True,\n+ scaley: bool = True,\n+ d... | 9d40b99a79040902d094feb0f1cc13a5c8827a6e | diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py
index cf5c9b4b739f..8da666499702 100644
--- a/lib/matplotlib/pyplot.py
+++ b/lib/matplotlib/pyplot.py
@@ -50,7 +50,7 @@
import sys
import threading
import time
-from typing import TYPE_CHECKING, cast, overload
+from typing import IO, TYPE_CHECKING, cas... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
matplotlib__matplotlib-29842@c77e9d5 | matplotlib/matplotlib | Python | 29,842 | Don't drag draggables on scroll events | ## PR summary
Fixes https://github.com/matplotlib/matplotlib/issues/29142; replaces https://github.com/matplotlib/matplotlib/pull/29270. The solution here is to set a custom picker on `DraggableBase` that doesn't fire if the event is a scroll event.
## PR checklist
<!-- Please mark any checkboxes that do not app... | 2025-03-31T21:10:07Z | [MNT]: Draggable legend gets stuck on cursor after scroll event
### Summary
Draggable legend gets stuck to cursor after scrolling while hovering the artist. To 'unstick' it, it is necessary to left click. I believe the expected behavior is to only drag the legend while holding the left mouse button. If that is not the... | Perhaps related to #29066 too?
I am not sure to be honest. I don't know much about the backends. But the problem described doesn't appear to be the same. In fact I tried implementing my solution inside offsetbox.py and it worked as predicted. Scroll events no longer make legend stick to cursor.
This is the propos... | [
{
"body": "### Summary\n\nDraggable legend gets stuck to cursor after scrolling while hovering the artist. To 'unstick' it, it is necessary to left click. I believe the expected behavior is to only drag the legend while holding the left mouse button. If that is not the case, please close this issue.\n\n### Prop... | a3aad584ae9f79f7d7477dec7e96334d49924369 | {
"head_commit": "c77e9d555de041df77650d798ef81e0f619cf15e",
"head_commit_message": "Move picker to method",
"patch_to_review": "diff --git a/lib/matplotlib/offsetbox.py b/lib/matplotlib/offsetbox.py\nindex 56b10c785ff9..28f91553819e 100644\n--- a/lib/matplotlib/offsetbox.py\n+++ b/lib/matplotlib/offsetbox.py\n@@... | [
{
"diff_hunk": "@@ -1500,6 +1500,10 @@ def __init__(self, ref_artist, use_blit=False):\n ]\n ]\n \n+ @staticmethod\n+ def _picker(artist, mouseevent):\n+ return (artist.contains(mouseevent) and mouseevent.name != \"scroll_event\"), {}",
"line": 1506,
"original_line": 150... | 0622c25348b42decb1de3400efe90b20e755d8b9 | diff --git a/lib/matplotlib/offsetbox.py b/lib/matplotlib/offsetbox.py
index 56b10c785ff9..7ac89450c813 100644
--- a/lib/matplotlib/offsetbox.py
+++ b/lib/matplotlib/offsetbox.py
@@ -1486,7 +1486,7 @@ def finalize_offset(self):
def __init__(self, ref_artist, use_blit=False):
self.ref_artist = ref_artist
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-29673@fc00227 | matplotlib/matplotlib | Python | 29,673 | DOC: document the issues with overlaying new mpl on old mpl | closes #26827
| 2025-02-24T19:03:05Z | [Bug]: ImportError when using Matplotlib v3.8.0 in Python package tests
### Bug summary
I am encountering an ImportError when attempting to use Matplotlib v3.8.0 in my Python package's tests, specifically when running them with pytest. This issue does not occur with older versions of Matplotlib, such as v3.7.3.
### C... | breaks my CI too
Your installs are crossed. You are picking up mpl_toolkits from a different distribution.
On the other hand this happens pretty commonly - I forget the explanation and maybe indicates an issue with how we install the wheels?
This looks like an installation issue?
It is certainly true that `docstr... | [
{
"body": "### Bug summary\n\nI am encountering an ImportError when attempting to use Matplotlib v3.8.0 in my Python package's tests, specifically when running them with pytest. This issue does not occur with older versions of Matplotlib, such as v3.7.3.\n\n### Code for reproduction\n\n```python\n>>> import mat... | c9402f3493e2872bd9015902d9e5ba9aecc975f1 | {
"head_commit": "fc00227b2856cf1fbc148f31fbf32bf32a96595b",
"head_commit_message": "Update doc/api/prev_api_changes/api_changes_3.8.0/behaviour.rst\n\nCo-authored-by: Jody Klymak <jklymak@gmail.com>",
"patch_to_review": "diff --git a/doc/api/prev_api_changes/api_changes_3.8.0/behaviour.rst b/doc/api/prev_api_cha... | [
{
"diff_hunk": "@@ -171,3 +171,22 @@ saved.\n \n Previously, *mincnt* was inclusive with no *C* provided but exclusive when *C* is provided.\n It is now inclusive of *mincnt* in both cases.\n+\n+\n+``matplotlib.mpl_toolkits`` is now an implicit namespace package\n+-----------------------------------------------... | 3f1b7f7acc49e5714eb9f8966a9b909b53e82259 | diff --git a/doc/api/prev_api_changes/api_changes_3.8.0/behaviour.rst b/doc/api/prev_api_changes/api_changes_3.8.0/behaviour.rst
index 0b598723e26c..8a21d5b4941e 100644
--- a/doc/api/prev_api_changes/api_changes_3.8.0/behaviour.rst
+++ b/doc/api/prev_api_changes/api_changes_3.8.0/behaviour.rst
@@ -171,3 +171,22 @@ save... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-29879@3f139f2 | matplotlib/matplotlib | Python | 29,879 | Adding elinestyle property to errorbar | This PR is intended to add an elinestyle parameter to the errorbar function. The issue is described here: https://github.com/matplotlib/matplotlib/issues/29681
The errorbar object contains horizontal and vertical lines to demonstrate error ranges on a graph. At the moment, the line style of the errorbar can only b... | 2025-04-06T21:06:37Z | [ENH]: Add parameter 'error_linestyle' to plt.errorbar()
### Problem
Currently, **plt.errorbar()** does not provide a direct way to change the linestyle of the error bars themselves. The _linestyle_ parameter only affects the main connecting line, and modifying the error bars requires accessing the returned object and... | While naming is debatable, I‘d call this `elinestyle` for consistency with `ecolor` and `elinewidth`.
@MBeusch do you want to make a pull request?
Thanks for the quick response! I originally proposed this as a suggestion rather than something I planned to implement myself. If the idea seems useful, I’d be happy to see... | [
{
"body": "### Problem\n\nCurrently, **plt.errorbar()** does not provide a direct way to change the linestyle of the error bars themselves. The _linestyle_ parameter only affects the main connecting line, and modifying the error bars requires accessing the returned object and manually setting e.g. _set_linestyl... | b95676ac7e3e4b5ac086cf5a848d381083037bd4 | {
"head_commit": "3f139f2714144233d98c03999ccd3d9c34d4ff2e",
"head_commit_message": "Update lib/matplotlib/axes/_axes.py\n\nCo-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py\nindex b46cbce39c58..b... | [
{
"diff_hunk": "@@ -3458,7 +3458,7 @@ def _errorevery_to_mask(x, errorevery):\n label_namer=\"y\")\n @_docstring.interpd\n def errorbar(self, x, y, yerr=None, xerr=None,\n- fmt='', ecolor=None, elinewidth=None, capsize=None,\n+ fmt='', ecolor=None, e... | ff0370a99014847c0a86a6e5d97cc08e5e3ed0df | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index 3d7899885c59..1b3159a17533 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -3463,7 +3463,8 @@ def _errorevery_to_mask(x, errorevery):
def errorbar(self, x, y, yerr=None, xerr=None,
fmt='... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-29347@c818093 | matplotlib/matplotlib | Python | 29,347 | DOC: Explain parameters linthresh and linscale of symlog scale | Closes #29335 via addressing https://github.com/matplotlib/matplotlib/issues/29335#issuecomment-2548980673.
| 2024-12-19T13:43:40Z | [ENH]: Indicating change of scale for symlog
### Problem
I appreciate that matplotlib provides various scales, including symlog.
However, I see the problem that it is not quite clear in the axis labels what happens.
### Proposed solution
I propose to (at least optionally) insert automatically a break (like // ) on... | Fundamentally, I believe this is a good idea. It's a bit difficult to implement though. Conceptually, we only have the locator, which determines tick positions. We don't have any infrastructure/API to handle the additional markers. Any automatism would need architectural changes.
A simple workaround would be a dedic... | [
{
"body": "### Problem\n\nI appreciate that matplotlib provides various scales, including symlog. \r\nHowever, I see the problem that it is not quite clear in the axis labels what happens.\n\n### Proposed solution\n\nI propose to (at least optionally) insert automatically a break (like // ) on the axis at the t... | a18354a2590948d6b03f86785840b667ff37290e | {
"head_commit": "c818093bf9be12ad66097ffb0deebbc5b9c1b940",
"head_commit_message": "DOC: Explain parameters linthresh and linscale of symlog scale\n\nCloses #29335 via addressing https://github.com/matplotlib/matplotlib/issues/29335#issuecomment-2548980673.",
"patch_to_review": "diff --git a/galleries/examples/s... | [
{
"diff_hunk": "@@ -34,12 +39,85 @@\n plt.show()\n \n # %%\n-# It should be noted that the coordinate transform used by ``symlog``\n-# has a discontinuous gradient at the transition between its linear\n-# and logarithmic regions. The ``asinh`` axis scale is an alternative\n-# technique that may avoid visual art... | 6694a9c136c4f5adf1cc72ecf8807c6771d21262 | diff --git a/galleries/examples/scales/symlog_demo.py b/galleries/examples/scales/symlog_demo.py
index e50be0d0c8a8..47742b853cc9 100644
--- a/galleries/examples/scales/symlog_demo.py
+++ b/galleries/examples/scales/symlog_demo.py
@@ -1,7 +1,12 @@
"""
-===========
-Symlog Demo
-===========
+============
+Symlog scale
... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-29144@a6cbf32 | matplotlib/matplotlib | Python | 29,144 | Use both TCL_SETVAR and TCL_SETVAR2 for tcl 9 support | Provides both the older and newer APIs for compatibility with both tcl 9 plus and older versions.
Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
Closes #29126
<!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/d... | 2024-11-15T18:43:28Z | [Bug]: TkAgg backend is broken with tcl/tk 9.0
### Bug summary
When trying to use TkAgg backend with tkinter compiled with tcl/tk 9.0(ex. `python-tk` with Python 3.13 from Homebrew), the backend fails to load
### Code for reproduction
```Python
from matplotlib.backends.backend_tkagg import FigureCanvasTkAgg
... | it looks like tcl/tk 9.0 was release on Sept 26, 2024 https://www.tcl.tk/software/tcltk/9.0.html
Looking at https://www.tcl.tk/man/tcl8.6/TclLib/SetVar.htm I do not see any warning that `Tcl_SetVar` is deprecated and it still appears to be documented in https://www.tcl.tk/man/tcl9.0/TclLib/SetVar.html . Can you pl... | [
{
"body": "### Bug summary\r\n\r\nWhen trying to use TkAgg backend with tkinter compiled with tcl/tk 9.0(ex. `python-tk` with Python 3.13 from Homebrew), the backend fails to load\r\n\r\n### Code for reproduction\r\n\r\n```Python\r\nfrom matplotlib.backends.backend_tkagg import FigureCanvasTkAgg\r\n```\r\n\r\n\... | c740fc842ac4bd30767a158ee797a6bb18cc21cd | {
"head_commit": "a6cbf32f701eb1c0fa9ff1ae029adcfa04772c73",
"head_commit_message": "Use both TCL_SETVAR and TCL_SETVAR2 for tcl 9 support\n\nCo-authored-by: Antony Lee <anntzer.lee@gmail.com>",
"patch_to_review": "diff --git a/src/_tkagg.cpp b/src/_tkagg.cpp\nindex 04ca3d4d1b84..1afe19ab417f 100644\n--- a/src/_t... | [
{
"diff_hunk": "@@ -343,8 +355,8 @@ PYBIND11_MODULE(_tkagg, m, py::mod_gil_not_used())\n throw py::error_already_set();\n }\n \n- if (!TCL_SETVAR) {\n- throw py::import_error(\"Failed to load Tcl_SetVar\");\n+ if (!(TCL_SETVAR || TCL_SETVAR2)) {\n+ throw py::import_error(\"Failed... | a6a442d3f67e92893e7bd8fa0187b9bf755bb401 | diff --git a/src/_tkagg.cpp b/src/_tkagg.cpp
index 04ca3d4d1b84..bfb19cc476ea 100644
--- a/src/_tkagg.cpp
+++ b/src/_tkagg.cpp
@@ -92,6 +92,7 @@ static Tk_PhotoPutBlock_t TK_PHOTO_PUT_BLOCK;
// Global vars for Tcl functions. We load these symbols from the tkinter
// extension module or loaded Tcl libraries at run-ti... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-28981@b1822cf | matplotlib/matplotlib | Python | 28,981 | FIX: macos: Use standard NSApp run loop in our input hook | ## PR summary
We want to defer back to Python's native input hook handling when we don't have any figures to interact with, otherwise our runloop will continue running unecessarily.
Additionally, we need to add a short runloop burst in our hotloop to avoid saturating the CPU while waiting for input. (i.e. sitting... | 2024-10-16T03:31:48Z | [Bug]: High CPU utilization of the macosx backend
### Bug summary
After showing interactive figure, the CPU utilization of python process went to 100%.
### Code for reproduction
```Python
#######################################################
# Case 1: 100% cpu
import matplotlib.pyplot as plt
fig = plt.figure(... | ```
# Case 1: 100% cpu
import matplotlib.pyplot as plt
fig = plt.figure()
plt.plot(range(5))
plt.show()
# after closing the window
import pandas # starting 100% CPU utilization
```
Does the `import` finish, or is it stuck there?
I can't reproduce this on an arm mac.
Are you able to reproduce th... | [
{
"body": "### Bug summary\n\nAfter showing interactive figure, the CPU utilization of python process went to 100%.\r\n\n\n### Code for reproduction\n\n```Python\n#######################################################\r\n# Case 1: 100% cpu\r\nimport matplotlib.pyplot as plt\r\nfig = plt.figure()\r\nplt.plot(ra... | 9489b938556b16633591c2e829462b1aa4e4a46e | {
"head_commit": "b1822cf873ad7ed10e727548566bd19653e9102a",
"head_commit_message": "FIX: macos: remove our custom PyOS_InputHook after our runloop stops\n\nWe want to defer back to Python's native input hook handling when\nwe don't have any figures to interact with, otherwise our runloop\nwill continue running une... | [
{
"diff_hunk": "@@ -1122,7 +1128,7 @@ - (void)close\n {\n [super close];\n --FigureWindowCount;\n- if (!FigureWindowCount) [NSApp stop: self];\n+ if (!FigureWindowCount) stop(NULL);",
"line": null,
"original_line": 1131,
"original_start_line": null,
"path": "src/_macosx.m",
"st... | b2eaad18dcf3dc19fd4dce5f60710e1b315b167d | diff --git a/src/_macosx.m b/src/_macosx.m
index 09838eccaf98..3c9842120547 100755
--- a/src/_macosx.m
+++ b/src/_macosx.m
@@ -40,60 +40,84 @@
static bool keyChangeCapsLock = false;
/* Keep track of the current mouse up/down state for open/closed cursor hand */
static bool leftMouseGrabbing = false;
-/* Keep track o... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
matplotlib__matplotlib-28970@12f4078 | matplotlib/matplotlib | Python | 28,970 | Add explicit converter setting to Axis | Closes #19229
<!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
## PR summary
<!-- Please provide at least 1-2 sentences describing the pull request in detail
(Why is this change required? What problem ... | 2024-10-11T18:46:00Z | Add public API for setting an axis unit converter
### Problem
I would like to define and use a custom unit converter class. The existing `mpl.units.registry` system is type-based, which does not work for my usecase. I need my converter to generalize over types. But I also know exactly which (existing) axis objects s... | This would not be enough as https://github.com/matplotlib/matplotlib/pull/10206 added a cut-out (which was refactored a bit in https://github.com/matplotlib/matplotlib/pull/13738 and https://github.com/matplotlib/matplotlib/pull/14363) to not try and convert numbers.
In addition to adding `set_converter` would would... | [
{
"body": "### Problem\r\n\r\nI would like to define and use a custom unit converter class. The existing `mpl.units.registry` system is type-based, which does not work for my usecase. I need my converter to generalize over types. But I also know exactly which (existing) axis objects should use the converter.\r\... | e8654e11da3634bba866c5ad7781da76f2b77d65 | {
"head_commit": "12f407839234b123a494429e8d51e8320e164d52",
"head_commit_message": "Add explicit converter setting to Axis\n\nCloses #19229",
"patch_to_review": "diff --git a/lib/matplotlib/axis.py b/lib/matplotlib/axis.py\nindex 8e612bd8c702..3b5de64bbcec 100644\n--- a/lib/matplotlib/axis.py\n+++ b/lib/matplotl... | [
{
"diff_hunk": "@@ -657,6 +657,7 @@ def __init__(self, axes, *, pickradius=15, clear=True):\n self.clear()\n else:\n self.converter = None\n+ self._explicit_converter = False",
"line": null,
"original_line": 660,
"original_start_line": null,
"path": "li... | 6f97b1c37628fff59eb895a83100bcd61bfac596 | diff --git a/doc/api/axis_api.rst b/doc/api/axis_api.rst
index 0870d38c9439..85ba990ffece 100644
--- a/doc/api/axis_api.rst
+++ b/doc/api/axis_api.rst
@@ -169,6 +169,8 @@ Units
Axis.convert_units
Axis.set_units
Axis.get_units
+ Axis.set_converter
+ Axis.get_converter
Axis.update_units
diff --git... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-28853@de80f58 | matplotlib/matplotlib | Python | 28,853 | MNT: Check the input sizes of regular X,Y in pcolorfast | Closes #28059.
^ | 2024-09-20T13:18:09Z | [Bug]: pcolorfast should validate that regularly spaced X or Y inputs have the right size
### Bug summary
Currently, when X/Y are passed to pcolorfast and are regularly spaced arrays, pcolorfast just uses their first and last values for the image extents, without verifying that the coordinate sizes are actually correc... | Apologies if I am misunderstanding the problem. When you say verifying that the coordinate sizes are actually correct, can you elaborate a bit more?
I understand that you mean this issue occurs if you have two regularly spaced arrays for X and Y, such as X = [1, 2, 3, 4] and Y=[2, 4, 6, 8, 10]. When those are used f... | [
{
"body": "### Bug summary\n\nCurrently, when X/Y are passed to pcolorfast and are regularly spaced arrays, pcolorfast just uses their first and last values for the image extents, without verifying that the coordinate sizes are actually correct.\n\n### Code for reproduction\n\n```Python\nfrom pylab import *\r\n... | fe6389f9b1bcad62b5b3620fa73507febc703607 | {
"head_commit": "de80f58b780f0dc700fd353be8fdb73b8769680e",
"head_commit_message": "MNT: Check the input sizes of regular X,Y in pcolorfast\n\nCloses #28059.",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py\nindex d7b649ae437f..6824006e7bdf 100644\n--- a/lib/matplotl... | [
{
"diff_hunk": "@@ -6626,6 +6626,27 @@ def test_pcolorfast_bad_dims():\n ax.pcolorfast(np.empty(6), np.empty((4, 7)), np.empty((8, 8)))\n \n \n+def test_pcolorfast_regular_xy_incompatible_size():\n+ \"\"\"\n+ Test that the sizes of X, Y, C are compatible for regularly spaced X, Y.\n+\n+ Note th... | bc648cae0f64f6f56f352ae1383c0a0cc805fae9 | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index d7b649ae437f..6824006e7bdf 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -6634,6 +6634,15 @@ def pcolorfast(self, *args, alpha=None, norm=None, cmap=None, vmin=None,
if x.size == 2 and y.siz... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-28830@b307395 | matplotlib/matplotlib | Python | 28,830 | Feature: Support passing DataFrames to table.table | ## PR summary
Resolves #28726 : feature request: support passing DataFrames to table.table
[dawnwangcx](https://github.com/dawnwangcx) wanted a feature to enable building tables using Pandas's DataFrame object. I implemented his solution and made a Unit test in test_table.py to confirm the DataFrame was correctly co... | 2024-09-17T05:17:56Z | feature request: support passing DataFrames to table.table
### Bug summary
When trying to input a dataframe to a table, it will raise keyerror. Since cellText [0] will not give the first row of the dataframe and thus not returning the correct column length. So, I made a modification to recognize cellText as dataframe.... | I would not consider this a bug a the input is documented as a 2D list of strings (https://matplotlib.org/stable/api/table_api.html#matplotlib.table.table) .
That said, this may be a reasonable feature request as I don't think it would be too hard to detect if we were passed a `pd.DataFrame` and then convert it to a... | [
{
"body": "### Bug summary\n\nWhen trying to input a dataframe to a table, it will raise keyerror. Since cellText [0] will not give the first row of the dataframe and thus not returning the correct column length. So, I made a modification to recognize cellText as dataframe.\r\ncontact: chenxuw@alumni.cmu.edu\n\... | 64d45cb8f45a38109b729cd3e1835e2dd36e65fc | {
"head_commit": "b30739522a0dc26a12a61009526f161e076a9425",
"head_commit_message": "Added check for Pandas Dataframe in table.table",
"patch_to_review": "diff --git a/lib/matplotlib/table.py b/lib/matplotlib/table.py\nindex 0f75021926fd..adfcbae4b0c9 100644\n--- a/lib/matplotlib/table.py\n+++ b/lib/matplotlib/ta... | [
{
"diff_hunk": "@@ -25,6 +25,7 @@\n \"\"\"\n \n import numpy as np\n+import pandas as pd",
"line": null,
"original_line": 28,
"original_start_line": null,
"path": "lib/matplotlib/table.py",
"start_line": null,
"text": "@user1:\npandas is an optional dependency for matplotlib. We cannot r... | ef7d139ea25d817d9f98b0e162efcdb26435cd8a | diff --git a/doc/users/next_whats_new/pass_pandasDataFrame_into_table.rst b/doc/users/next_whats_new/pass_pandasDataFrame_into_table.rst
new file mode 100644
index 000000000000..aaefa1b2011b
--- /dev/null
+++ b/doc/users/next_whats_new/pass_pandasDataFrame_into_table.rst
@@ -0,0 +1,20 @@
+``ax.table`` will accept a pan... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-28625@7aefeba | matplotlib/matplotlib | Python | 28,625 | added typing_extensions.Self to _AxesBase.twinx | ## PR summary
- adds `typing_extensions >= 4.0.0` as a dependency
- annotates `_AxesBase.twinx` and `_AxesBase.twiny` with return type `typing_extensions.Self`
- [x] closes #28624
- [N/A] new and changed code is [tested](https://matplotlib.org/devdocs/devel/testing.html)
- [N/A] *Plotting related* features are de... | 2024-07-29T18:06:28Z | [Bug]: Bad type hint in `_AxesBase.twinx()`
### Bug summary
Incorrect type annotation for `_AxesBase.twinx()` (should be `Self`, not `_AxesBase`).
### Code for reproduction
```Python
import matplotlib.pyplot as plt
import numpy as np
# First create some toy data:
x = np.linspace(0, 2 * np.pi, 400)
y = n... | Potentially fixing this requires adding `typing_extensions` as a dependency, since `typing.Self` is not available in 3.10.
Otherwise, users might not have it in their virtual environment when installing `matplotlib`, leaving the stubs broken. | [
{
"body": "### Bug summary\r\n\r\nIncorrect type annotation for `_AxesBase.twinx()` (should be `Self`, not `_AxesBase`).\r\n\r\n### Code for reproduction\r\n\r\n```Python\r\nimport matplotlib.pyplot as plt\r\nimport numpy as np\r\n\r\n# First create some toy data:\r\nx = np.linspace(0, 2 * np.pi, 400)\r\ny = np... | f7b3def52b39a070064e0e713042cd948c985643 | {
"head_commit": "7aefebaa986649022c36e9a3917d2a1293875ac6",
"head_commit_message": "added typing_extensions.Self to _AxesBase.twinx",
"patch_to_review": "diff --git a/environment.yml b/environment.yml\nindex 264f02800690..3ca4ca6b5050 100644\n--- a/environment.yml\n+++ b/environment.yml\n@@ -28,6 +28,7 @@ depend... | [
{
"diff_hunk": "@@ -39,6 +39,7 @@ dependencies = [\n \"pillow >= 8\",\n \"pyparsing >= 2.3.1\",\n \"python-dateutil >= 2.7\",\n+ \"typing-extensions >= 4.0.0\",",
"line": null,
"original_line": 42,
"original_start_line": null,
"path": "pyproject.toml",
"start_line": null,
... | cf441b945f96659f565ec42fc2303ca7541eaa79 | diff --git a/lib/matplotlib/axes/_base.pyi b/lib/matplotlib/axes/_base.pyi
index 1fdc0750f0bc..362d644d11f2 100644
--- a/lib/matplotlib/axes/_base.pyi
+++ b/lib/matplotlib/axes/_base.pyi
@@ -4,6 +4,7 @@ import datetime
from collections.abc import Callable, Iterable, Iterator, Sequence
from matplotlib import cbook
fr... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-28478@2491647 | matplotlib/matplotlib | Python | 28,478 | bugfix for `PathSimplifier` | <!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
## PR summary
<!-- Please provide at least 1-2 sentences describing the pull request in detail
(Why is this change required? What problem does it ... | 2024-06-27T09:50:41Z | `PathSimplifier` fails to ignore `CLOSEPOLY` vertices
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
This bug does not seem to have surfaced anywhere ye... | This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatic... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nThis bug does not seem to have surfaced anywhere yet, but `Path`'s with ... | b485f5a9e1a2caf3af5e2bafa07390fe7609c3f8 | {
"head_commit": "24916479e506c206ae000939cba268e963a1543e",
"head_commit_message": "simplified test further",
"patch_to_review": "diff --git a/lib/matplotlib/tests/test_path.py b/lib/matplotlib/tests/test_path.py\nindex 2c4df6ea3b39..c9799f04ad46 100644\n--- a/lib/matplotlib/tests/test_path.py\n+++ b/lib/matplot... | [
{
"diff_hunk": "@@ -541,3 +541,18 @@ def test_cleanup_closepoly():\n cleaned = p.cleaned(remove_nans=True)\n assert len(cleaned) == 1\n assert cleaned.codes[0] == Path.STOP\n+\n+\n+def test_simplify_closepoly():\n+ # The values of the vertices in a CLOSEPOLY should always be ignored,\... | 5c6dde09377ede16beca01f565d8f34b3d1d04c7 | diff --git a/lib/matplotlib/tests/test_simplification.py b/lib/matplotlib/tests/test_simplification.py
index 0a5c215eff30..a052c24cb655 100644
--- a/lib/matplotlib/tests/test_simplification.py
+++ b/lib/matplotlib/tests/test_simplification.py
@@ -518,3 +518,54 @@ def test_clipping_full():
simplified = list(p.iter_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mitmproxy__mitmproxy-7445@0eec303 | mitmproxy/mitmproxy | Python | 7,445 | Prompt user before clearing screen | #### Description
Fixes #7413
Refs #7282
~- Added prompts for destructive shortcuts~
~- Mapped the no-prompts version to `ctrl+[key]`~
~Yet to add tests and update [KeyMapConfig.load_path](https://github.com/mitmproxy/mitmproxy/blob/6e4cb235fdc7d0f55b8edcda37e9f7cb0c8fda22/mitmproxy/tools/console/keymap.py... | 2025-01-06T10:34:26Z | Ask confirmation before clearing flow list (key z)
#### Problem Description
The `z` keybinding, used to clear flow list, doesn't ask for confirmation, immediately and irreversibly deleting all flows.
It's not impossible to accidentally hit the z key and lose all the flows after a long debugging session.
#### Propo... | I agree with this change and can send a PR if @mhils is okay with this
Yes, sounds good to me. 👍
On Wed, Dec 25, 2024, 12:01 Gaurav Jain ***@***.***> wrote:
> I agree with this change and can send a PR if @mhils
> <https://github.com/mhils> is okay with this
>
> —
> Reply to this email directly, view it on G... | [
{
"body": "#### Problem Description\r\nThe `z` keybinding, used to clear flow list, doesn't ask for confirmation, immediately and irreversibly deleting all flows.\r\nIt's not impossible to accidentally hit the z key and lose all the flows after a long debugging session.\r\n\r\n#### Proposal\r\nSimilar to the ex... | 6a39a1d78b2eeb8dccf6c18ffb07e3d8e83ee059 | {
"head_commit": "0eec3033ce289e86a283488fe4c85267edfc4de7",
"head_commit_message": "[autofix.ci] apply automated fixes",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex d2022b5f35..a1b6388cc1 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -21,6 +21,8 @@\n ([#7456](https://github.com/mit... | [
{
"diff_hunk": "@@ -284,6 +284,27 @@ def console_command(self, *command_str: str) -> None:\n quoted += \" \"\n signals.status_prompt_command.send(partial=quoted)\n \n+ @command.command(\"console.command.confirm\")\n+ def console_command_confirm(\n+ self,\n+ prompt: str,\n... | e5e360a5baa54147e4017b41524fb1565896f0de | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d2022b5f35..a1b6388cc1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -21,6 +21,8 @@
([#7456](https://github.com/mitmproxy/mitmproxy/pull/7456), @jwadolowski)
- Remove check for status codes in the blocklist add-on.
([#7453](https://github.com/mitmproxy/mitmproxy/p... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mitmproxy__mitmproxy-7066@5505166 | mitmproxy/mitmproxy | Python | 7,066 | Make `DnsResolver.resolver` and `DnsResolver.name_servers` as cached functions instead of cached properties | #### Description
Fixes #7064
`mitmproxy_rs.get_system_dns_servers()` might fail with `RuntimeError`s, which would crash mitmproxy while initializing `DnsResolver`'s attributes during startup. We fix this by making `DnsResolver.resolver` and `DnsResolver.name_servers` as cached functions instead of cached properties
... | 2024-08-01T16:10:17Z | 【10.4.1】 mitm start failed: failed to get dns servers
#### Problem Description
After upgrading to 10.4.1 from 10.3.1, the mitm program could not be loaded.
#### Steps to reproduce the behavior:
1. **pipx** --upgrade mitmproxy
2. start mitmproxy
3.
#### System Information
Paste the output of "mitmproxy --v... | Which OS are you on?
`
(base) root@ttg-virtual-machine:~# uname -a
Linux ttg-virtual-machine 5.4.0-181-generic #201-Ubuntu SMP Thu Mar 28 15:39:01 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
`
When I downgraded the app version to 10.3.1, everything went back to normal.
> Which OS are you on?
Ubuntu 20.04.6 LTS
Thanks... | [
{
"body": "#### Problem Description\r\nAfter upgrading to 10.4.1 from 10.3.1, the mitm program could not be loaded.\r\n\r\n#### Steps to reproduce the behavior:\r\n1. **pipx** --upgrade mitmproxy\r\n2. start mitmproxy\r\n3. \r\n\r\n#### System Information\r\nPaste the output of \"mitmproxy --version\" here.\r... | b08acf4ab8d51405563123793e644c0c2aa52c6e | {
"head_commit": "5505166b31a36ebdac7624d3a52ff41ff2dc04bd",
"head_commit_message": "Fixup",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex c33b602f45..b08e326bf4 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -16,6 +16,7 @@\n ([#7045](https://github.com/mitmproxy/mitmproxy/pull/7045), ... | [
{
"diff_hunk": "@@ -16,6 +16,7 @@\n ([#7045](https://github.com/mitmproxy/mitmproxy/pull/7045), @mhils)\n - Container images are now published to both Docker Hub and GitHub Container Registry.\n ([#7061](https://github.com/mitmproxy/mitmproxy/pull/7061), @mhils)\n+- Make `DnsResolver.resolver` and `DnsResol... | e02e2c66ccdd7cdea7d252705b7a6b80d014d885 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index c33b602f45..13ed1a16c6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,8 @@
## Unreleased: mitmproxy next
+- Fix a crash on startup when mitmproxy is unable to determine the OS' DNS servers
+ ([#7066](https://github.com/mitmproxy/mitmproxy/pull/7066), @errorx... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mitmproxy__mitmproxy-6619@0317b9b | mitmproxy/mitmproxy | Python | 6,619 | Fix `Couldn't parse: falling back to Raw` for empty JSON array | #### Description
fix #6603
#### Checklist
- [x] I have updated tests where applicable.
- [ ] I have added an entry to the CHANGELOG.
| 2024-01-27T14:15:07Z | `Couldn't parse: falling back to Raw` for empty JSON array
#### Problem Description
The following response packet:
```
HTTP/2.0 200
date: Sun, 14 Jan 2024 23:30:12 GMT
content-type: application/json; charset=utf-8
content-length: 2
server: nginx/1.18.0 (Ubuntu)
cache-control: no-store
x-amzn-trace-id: [REDA... | Thanks! Looks like an edge case for the empty array, the following all work: `[1]`, `"foo"` and `null`
@Prinzhorn I would like to fix this. Could you show me the part(s) of the codebase where this is handled?
@haanhvu sure, it's probably somewhere in https://github.com/mitmproxy/mitmproxy/blob/main/mitmproxy/contentvie... | [
{
"body": "#### Problem Description\r\nThe following response packet:\r\n\r\n```\r\nHTTP/2.0 200 \r\ndate: Sun, 14 Jan 2024 23:30:12 GMT\r\ncontent-type: application/json; charset=utf-8\r\ncontent-length: 2\r\nserver: nginx/1.18.0 (Ubuntu)\r\ncache-control: no-store\r\nx-amzn-trace-id: [REDACTED]\r\nx-frame-opt... | 6c7089f7a3bdc2f13017599fc9edfe247af65b67 | {
"head_commit": "0317b9b232e3b583b99b6eb0ecaf704513582829",
"head_commit_message": "Reorder condition",
"patch_to_review": "diff --git a/mitmproxy/contentviews/graphql.py b/mitmproxy/contentviews/graphql.py\nindex 5263b75f5f..4916197bb1 100644\n--- a/mitmproxy/contentviews/graphql.py\n+++ b/mitmproxy/contentview... | [
{
"diff_hunk": "@@ -30,7 +30,12 @@ def is_graphql_query(data):\n \n \n def is_graphql_batch_query(data):\n- return isinstance(data, list) and isinstance(data[0], dict) and \"query\" in data[0]\n+ return (\n+ len(data) > 0",
"line": null,
"original_line": 34,
"original_start_line": null,... | 88b63bb57fd7ed9d42e1aca68927eccc834f4db5 | diff --git a/mitmproxy/contentviews/graphql.py b/mitmproxy/contentviews/graphql.py
index 5263b75f5f..b76b7bf054 100644
--- a/mitmproxy/contentviews/graphql.py
+++ b/mitmproxy/contentviews/graphql.py
@@ -30,7 +30,12 @@ def is_graphql_query(data):
def is_graphql_batch_query(data):
- return isinstance(data, list) ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-27998@d99c8e0 | matplotlib/matplotlib | Python | 27,998 | Add a new `orientation` parameter to Violinplot and deprecate `vert` | <!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
## PR summary
<!-- Please provide at least 1-2 sentences describing the pull request in detail
(Why is this change required? What problem does it ... | 2024-04-01T10:08:56Z | boxplot/violinplot orientation-setting API
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
Currently, boxplot(), bxp(), violin(), and violinplot() take a... | I think this is a good idea.
Should be easy enough to capture `vert`, emit and deprecation warning, and then set `orientation` accordingly.
(and while we're at it, the manage_xticks arg should be renamed to manage_ticks, as it covers both orientations)
just throwing this out there: what would you say to `manage_labe... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nCurrently, boxplot(), bxp(), violin(), and violinplot() take a `vert: bo... | 955432c552d6da7250a76c4f623b33b5d4e6c215 | {
"head_commit": "d99c8e0f529918be0be670d6ffd44d06da905e00",
"head_commit_message": "fix broken tests",
"patch_to_review": "diff --git a/doc/api/next_api_changes/deprecations/27998-TS.rst b/doc/api/next_api_changes/deprecations/27998-TS.rst\nnew file mode 100644\nindex 000000000000..ab69b87f0989\n--- /dev/null\n+... | [
{
"diff_hunk": "@@ -8572,6 +8599,24 @@ def violin(self, vpstats, positions=None, vert=True, widths=0.5,\n datashape_message = (\"List of violinplot statistics and `{0}` \"\n \"values must have the same length\")\n \n+ if vert is not None:\n+ _api.warn_depre... | bb3457656b36313551bede4e6be056c22ca3ace0 | diff --git a/doc/api/next_api_changes/deprecations/27998-TS.rst b/doc/api/next_api_changes/deprecations/27998-TS.rst
new file mode 100644
index 000000000000..ab69b87f0989
--- /dev/null
+++ b/doc/api/next_api_changes/deprecations/27998-TS.rst
@@ -0,0 +1,7 @@
+``violinplot`` and ``violin`` *vert* parameter
+~~~~~~~~~~~~~... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mitmproxy__mitmproxy-4910@1d3207e | mitmproxy/mitmproxy | Python | 4,910 | Quote argument of view.flows.resolve | #### Description
Fix #4899.
Quote the argument of internal `view.flows.resolve` calls.
Not sure what is an effective way to test it. The internal `view.flows.resolve` happens after the user invokes `:view.flows.remove ...` Should the test be written in `test_view.py`, `test_types.py` or `test_integration.py`?
... | 2021-11-18T00:36:00Z | Command argument mismatch when executing command: ":view.flows.remove '~m POST'"
I am trying to delete all the POST flows.
I execute the command
`:view.flows.remove '~m POST'`
And get the following error
```
error: Command argument mismatch:
Expected: OrderedDict([('flow_spec', <Parameter "flow_spec:... | [
{
"body": "I am trying to delete all the POST flows.\r\n\r\nI execute the command\r\n\r\n`:view.flows.remove '~m POST'`\r\n\r\nAnd get the following error\r\n\r\n```\r\nerror: Command argument mismatch:\r\n Expected: OrderedDict([('flow_spec', <Parameter \"flow_spec: str\">)])\r\n Received: ['~m', 'POST']... | 39fa242e25ad6d879e7021db188d0d32f4d77115 | {
"head_commit": "1d3207e1493c0132a5e0d779546272d6790ac65f",
"head_commit_message": "Quote view.flows.resolve argument",
"patch_to_review": "diff --git a/mitmproxy/types.py b/mitmproxy/types.py\nindex 01d7ac47f8..03391ce982 100644\n--- a/mitmproxy/types.py\n+++ b/mitmproxy/types.py\n@@ -369,7 +369,7 @@ class _Flo... | [
{
"diff_hunk": "@@ -369,7 +369,7 @@ class _FlowType(_BaseFlowType):\n \n def parse(self, manager: \"CommandManager\", t: type, s: str) -> flow.Flow:\n try:\n- flows = manager.execute(\"view.flows.resolve %s\" % (s))\n+ flows = manager.execute(\"view.flows.resolve '%s'\" % (s))"... | 12a385905be01914281a75688c001c63c5c23ed0 | diff --git a/mitmproxy/types.py b/mitmproxy/types.py
index 01d7ac47f8..b4b17d80ea 100644
--- a/mitmproxy/types.py
+++ b/mitmproxy/types.py
@@ -369,7 +369,7 @@ class _FlowType(_BaseFlowType):
def parse(self, manager: "CommandManager", t: type, s: str) -> flow.Flow:
try:
- flows = manager.execu... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
mitmproxy__mitmproxy-5430@0de08b6 | mitmproxy/mitmproxy | Python | 5,430 | fix huge (>65kb) http2 responses corrupted | #### Description
BufferedH2Connection is able to buffer huge response and send it to client, properly following flow control specs.
But trailers are not subject to flow control and were mistankenly sent immediate.
That led to the situation that mitmproxy worked fine on small responses (that fit in 65k bytes - init... | 2022-06-24T11:22:04Z | [grpc] mitmproxy corrupts huge (>65kb) responses
#### Problem Description
Grpc requests with huge responses fails with error `io.grpc.StatusException: INTERNAL: Encountered end-of-stream mid-frame` if mitmproxy is used. Requests succeed without mitmproxy.
In my case response was 200k bytes.
#### Steps to reprodu... | [
{
"body": "#### Problem Description\r\nGrpc requests with huge responses fails with error `io.grpc.StatusException: INTERNAL: Encountered end-of-stream mid-frame` if mitmproxy is used. Requests succeed without mitmproxy.\r\nIn my case response was 200k bytes.\r\n\r\n\r\n#### Steps to reproduce the behavior:\r\n... | 3eab9f0856403c53871d258bba289dfcbeb6e0df | {
"head_commit": "0de08b695174bcb46b898d0d7855091ffe539ee7",
"head_commit_message": "add changelog for #5428",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex d54e35a0fe..35078673c1 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -8,6 +8,8 @@\n ([#5372](https://github.com/mitmproxy/mitmpr... | [
{
"diff_hunk": "@@ -77,8 +79,16 @@ def send_data(\n # We can't send right now, so we buffer.\n self.stream_buffers[stream_id].append(SendH2Data(data, end_stream))\n \n+ def send_trailers(self, stream_id, trailers):\n+ if self.stream_buffers.get(stream_id, None):\n+ ... | ead6352682363b0a0015afe08dc5068f221db389 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d54e35a0fe..35078673c1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,8 @@
([#5372](https://github.com/mitmproxy/mitmproxy/discussions/5372), @jixunmoe)
* Drop pkg_resources dependency.
([#5401](https://github.com/mitmproxy/mitmproxy/issues/5401), @PavelICS... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
matplotlib__matplotlib-27882@4c31f35 | matplotlib/matplotlib | Python | 27,882 | Deleting all images that have passed tests before upload | <!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
## PR summary
<!-- Please provide at least 1-2 sentences describing the pull request in detail
(Why is this change required? What problem does it ... | 2024-03-08T01:58:59Z | Only upload failed images on failure
Currently when a job fails on GHA we upload all 109 MB across ~7k files which takes a surprisingly long time. What we really want is just the images that failed and the computed difference.
This is labeled as "good first issue" because there are no API designs here (it is all co... | @andrzejnovak actually did this in #19466, but we closed it when I accidentally did the upload carte-blanche in a different PR. I had some slight reservations about where the subsetting was in that PR. It seems our tests must have ballooned though, because it was only 50 MB at that point.
I'm a beginner and I would lik... | [
{
"body": "Currently when a job fails on GHA we upload all 109 MB across ~7k files which takes a surprisingly long time. What we really want is just the images that failed and the computed difference.\r\n\r\nThis is labeled as \"good first issue\" because there are no API designs here (it is all configuring CI... | f007886036b610eaa2f266e0dfbc9de807c2430d | {
"head_commit": "4c31f35c10c57e727f62e49b7a40a91c9b737eea",
"head_commit_message": "Deleting all images that have passed tests before upload\n\nModified code to delete all types of files which have not failed\n\nMinor extension handling\n\nChecking if file exists before deleting\n\nDid not delete directories",
"... | [
{
"diff_hunk": "@@ -318,6 +318,35 @@ jobs:\n --maxfail=50 --timeout=300 --durations=25 \\\n --cov-report=xml --cov=lib --log-level=DEBUG --color=yes\n \n+ - name: Cleanup non-failed image files\n+ run: |\n+ function remove_files() {\n+ local extension=$1... | 8883d69292695e69887ac00126d38787804e2422 | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index a825b4cf263b..8e45fa60d6a7 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -318,6 +318,39 @@ jobs:
--maxfail=50 --timeout=300 --durations=25 \
--cov-report=xml --cov=lib --log-level=DEBUG... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
matplotlib__matplotlib-27773@90a3971 | matplotlib/matplotlib | Python | 27,773 | MNT: pcolormesh robust underflow | Closes #27770
This looks to be a numpy masked array problem, but multiplication doesn't trigger the spurious underflow, and probably is a touch faster as well.
| 2024-02-12T02:17:53Z | [Bug]: pcolormesh issue with np.seterr(under='raise')
### Bug summary
When `np.seterr(under="raise")` is set, the pcolormesh fails. Maybe this should be internally disabled?
### Code for reproduction
```python
import numpy as np
import matplotlib.pylab as plt
ca=array([0.5, 0.6, 0.7, 0.8, 0.9, 1. , 1.1, 1.2, 1.... | This seems a bug upstream in numpy:
```
np.seterr(under="raise")
x=np.arange(0, 3, 0.1)
dX = np.diff(x)
X = np.ma.array(x)
dX = np.diff(X)
dX = dX / 2.0
```
returns
```
Traceback (most recent call last):
File "/Users/jklymak/matplotlib/testit.py", line 9, in <module>
dX = dX / 2.0
~~~^~... | [
{
"body": "### Bug summary\n\nWhen `np.seterr(under=\"raise\")` is set, the pcolormesh fails. Maybe this should be internally disabled?\n\n### Code for reproduction\n\n```python\nimport numpy as np\r\nimport matplotlib.pylab as plt\r\n\r\nca=array([0.5, 0.6, 0.7, 0.8, 0.9, 1. , 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.... | 641e3def2c8f915f741937ddfc7ff28ca86a6370 | {
"head_commit": "90a3971386cf7c8a5f1fcda33060d4c0978950e7",
"head_commit_message": "MNT: make pcolormesh more robust to masked array underflow",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py\nindex b1aeb87e6b45..711d930a1253 100644\n--- a/lib/matplotlib/axes/_axes.p... | [
{
"diff_hunk": "@@ -1517,6 +1517,22 @@ def test_pcolorargs():\n ax.pcolormesh(X, Y, Z, shading='auto')\n \n \n+def test_pcolormesh_underflow_error():\n+ \"\"\"\n+ Test that underflow errors don't crop up in pcolormesh. Probably\n+ a numpy bug, but...\n+ \"\"\"\n+ oldsettings = np.geterr(... | 793f1dfc4d9f5ab3021d16580c3010c1a792dc38 | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index b1aeb87e6b45..711d930a1253 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -5883,7 +5883,7 @@ def _pcolorargs(self, funcname, *args, shading='auto', **kwargs):
def _interp_grid(X):
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
mitmproxy__mitmproxy-4486@d8aeef1 | mitmproxy/mitmproxy | Python | 4,486 | Merge WebSocketFlow into HTTPFlow, add WebSocket UI | This PR fixes #4425 and then adds WebSocket Message display in mitmprox as a cherry on top! 🍒
| 2021-03-08T18:56:37Z | Combine WebSocketFlow and HTTPFlow
HTTPFlow and WebSocketFlow currently have a really ugly relation where one depends on the other, they appear separately in dumps, etc. To fix this madness, I would propose we merge WebSocketFlow and HTTPFlow: HTTPFlow just gets a `.websocket: Optional[WebSocketData]` attribute, which ... | I do like the very clear separation of concerns with two classes and the distinction in the dump. They are two different protocols, where one happens to look like the other for the first couple of milliseconds. Pure coincidence. 🤞
I'm open to being talked into making `WebSocketFlow` a subclass of `HTTPFlow`, but g... | [
{
"body": "HTTPFlow and WebSocketFlow currently have a really ugly relation where one depends on the other, they appear separately in dumps, etc. To fix this madness, I would propose we merge WebSocketFlow and HTTPFlow: HTTPFlow just gets a `.websocket: Optional[WebSocketData]` attribute, which contains everyth... | a00f247f0edfb303bd54cb1f0b7b4e97c4a56fd0 | {
"head_commit": "d8aeef1bfdc30cdcd6f045521aa03ddae56d5e99",
"head_commit_message": "ressurect `killed`, is_text -> type",
"patch_to_review": "diff --git a/examples/addons/websocket-simple.py b/examples/addons/websocket-simple.py\nindex 836b123840..c4ec4d22f9 100644\n--- a/examples/addons/websocket-simple.py\n+++... | [
{
"diff_hunk": "@@ -1,168 +1,126 @@\n \"\"\"\n-*Deprecation Notice:* Mitmproxy's WebSocket API is going to change soon,\n-see <https://github.com/mitmproxy/mitmproxy/issues/4425>.\n+Mitmproxy used to have its own WebSocketFlow type until mitmproxy 6, but now WebSocket connections now are represented\n+as HTTP f... | ab1bcfe7d2d3724f08d77339ce118033ce37c0a6 | diff --git a/examples/addons/websocket-simple.py b/examples/addons/websocket-simple.py
index 836b123840..c4ec4d22f9 100644
--- a/examples/addons/websocket-simple.py
+++ b/examples/addons/websocket-simple.py
@@ -5,17 +5,17 @@
def websocket_message(flow):
# get the latest message
- message = flow.messages[-1]
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
mitmproxy__mitmproxy-4790@017344d | mitmproxy/mitmproxy | Python | 4,790 | TLS: add `tls_handshake` hook, ignore-after-clienthello | This PR adds two new features to our TLS implementation:
1. A new `tls_handshake` hook, which gets fired after a TLS handshake has been completed (successfully or not). I'm not sure yet if the name is perfect, feedback is welcome.
2. Make it possible to stop TLS interception from the `tls_clienthello` event hook.
... | 2021-09-03T22:28:36Z | Make it possible to enable TLS passthrough from `tls_clienthello` hook.
From Slack:
> given that I cannot decrypt the connection, I am currently attempting to bypass the TLS connections altogether.
by doing the following:
```
def next_layer(self, nextlayer: layer.NextLayer):
is_tls = is_tls_record_magic(nex... | [
{
"body": "From Slack:\r\n\r\n> given that I cannot decrypt the connection, I am currently attempting to bypass the TLS connections altogether.\r\nby doing the following:\r\n```\r\ndef next_layer(self, nextlayer: layer.NextLayer):\r\n is_tls = is_tls_record_magic(nextlayer.data_client())\r\n if(is_tls):\... | 6398dc308a85fb3e42aaeb09ae311c05afe92daa | {
"head_commit": "017344dfe48fc4fc2a88d55740814b9067d18e88",
"head_commit_message": "tls: api docs++",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex b6266a14ce..4a22948810 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -3,11 +3,13 @@\n ## Unreleased: mitmproxy next\n \n * Support proxy a... | [
{
"diff_hunk": "@@ -124,6 +124,7 @@ def category(name: str, desc: str, hooks: List[Type[hooks.Hook]]) -> None:\n tls.TlsClienthelloHook,\n tls.TlsStartClientHook,\n tls.TlsStartServerHook,\n+ tls.TlsHandshakeHook,",
"line": null,
"original_line": 127,
"... | 3cb87f5a2f00790535e9ffa3c7ccf3566291a055 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6c52595fc8..cee75fc2df 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,8 @@
## Unreleased: mitmproxy next
* Support proxy authentication for SOCKS v5 mode (@starplanet)
+* Make it possible to ignore connections in the tls_clienthello event hook (@mhils)
+* Add ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
matplotlib__matplotlib-27618@106ce16 | matplotlib/matplotlib | Python | 27,618 | Add option of running stubtest using tox | <!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
This gives developers the option of running stubtests using `tox`. This is useful, because the stubtests can't be run on local editable installs (see h... | 2024-01-09T14:57:05Z | [Bug]: Running stubtest locally fails
### Bug summary
Running `python tools/stubtest.py` fails for me locally with
```
% python tools/stubtest.py
error: matplotlib failed to find stubs
Stub:
MISSING
Runtime:
<module 'matplotlib' from '/Users/dstansby/software/matplotlib/lib/matplotlib/__init__.p... | Unfortunately the way meson does editable installs doesn't work with stubtest...
It does work with a normal install.
It also does work if you edit the `.pth` file in site-packages to point to the `lib/matplotlib` folder
> Unfortunately the way meson does editable installs doesn't work with stubtest..
Can you update ... | [
{
"body": "### Bug summary\n\nRunning `python tools/stubtest.py` fails for me locally with\r\n\r\n```\r\n% python tools/stubtest.py \r\nerror: matplotlib failed to find stubs\r\nStub:\r\nMISSING\r\nRuntime:\r\n<module 'matplotlib' from '/Users/dstansby/software/matplotlib/lib/matplotlib/__init__.py... | cd8281b686bf7c441fcbbbc1e36763e30d7f0327 | {
"head_commit": "106ce164d84f7a71ef83bb3c988ae21f45bef1b6",
"head_commit_message": "Add instructions on running stubtest",
"patch_to_review": "diff --git a/.github/workflows/mypy-stubtest.yml b/.github/workflows/mypy-stubtest.yml\nindex f042688feb62..1280926021f1 100644\n--- a/.github/workflows/mypy-stubtest.yml... | [
{
"diff_hunk": "@@ -32,13 +26,16 @@ jobs:\n sh -s -- -b \"$HOME/bin\"\n echo \"$HOME/bin\" >> $GITHUB_PATH\n \n+ - name: Install tox\n+ run: python -m pip install tox\n+\n - name: Run mypy stubtest\n env:\n REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHU... | 590d477a9f3ad2243ecef2ebe665279c26fb37e3 | diff --git a/.github/workflows/mypy-stubtest.yml b/.github/workflows/mypy-stubtest.yml
index f042688feb62..f009720a43e0 100644
--- a/.github/workflows/mypy-stubtest.yml
+++ b/.github/workflows/mypy-stubtest.yml
@@ -18,12 +18,6 @@ jobs:
with:
python-version: 3.9
- - name: Install mypy
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
modin-project__modin-5940@3142228 | modin-project/modin | Python | 5,940 | FIX-#4048: support sqlalchemy objects in `con` parameter for `to_sql` | <!--
Thank you for your contribution!
Please review the contributing docs: https://modin.readthedocs.io/en/latest/development/contributing.html
if you have questions about contributing.
-->
## What do these changes do?
<!-- Please give a short brief about these changes. -->
- [x] first commit message and P... | 2023-04-05T13:56:04Z | BUG: passing connection object to to_sql causes "can not pickle" error
### System information
- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: windows server
- **Modin version** (`modin.__version__`): 0.12.1
- **Python version**:3.8.12
- **Code we can use to reproduce**: may be
<!--
You can obtain... | Hi @EnderWuBinHao!
Thanks for reporting! I can reproduce your issue using Postgresql DBMS, see reproducer below:
```
import modin.pandas as pd
from sqlalchemy import create_engine
table_name = "test_table"
conn_str = "postgresql://username:password@localhost/db_name"
conn = create_engine(conn_str)
df = pd.D... | [
{
"body": "### System information\r\n- **OS Platform and Distribution (e.g., Linux Ubuntu 16.04)**: windows server\r\n- **Modin version** (`modin.__version__`): 0.12.1\r\n- **Python version**:3.8.12\r\n- **Code we can use to reproduce**: may be\r\n\r\n<!--\r\nYou can obtain the Modin version with\r\n\r\npython ... | e1d42410c3900f93be420303e745de29c1e6bda1 | {
"head_commit": "314222843a1261e26d44761d5ecb96a429eb5850",
"head_commit_message": "FIX-#4048: support sqlalchemy objects in 'con' parameter for 'to_sql'\n\nSigned-off-by: Anatoly Myachev <anatoly.myachev@intel.com>",
"patch_to_review": "diff --git a/modin/core/execution/dask/implementations/pandas_on_dask/io/io... | [
{
"diff_hunk": "@@ -170,6 +170,19 @@ def to_sql(cls, qc, **kwargs):\n # since the mapping operation is non-blocking, each partition will return an empty DF\n # so at the end, the blocking operation will be this empty DF to_pandas\n \n+ import sqlalchemy as sa\n+\n+ if not isinstanc... | 96bebe32b1fc7ff18339df13a783d76649e7c2c8 | diff --git a/modin/core/io/sql/sql_dispatcher.py b/modin/core/io/sql/sql_dispatcher.py
index 38e65fe856d..2625a5d71cc 100644
--- a/modin/core/io/sql/sql_dispatcher.py
+++ b/modin/core/io/sql/sql_dispatcher.py
@@ -110,6 +110,17 @@ def _read(cls, sql, con, index_col=None, **kwargs):
new_frame.synchronize_labels(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
kornia__kornia-3034@bcfb449 | kornia/kornia | Python | 3,034 | Add ignore_index to dice, focal and tversky loss | #### Changes
* adds `ignore_index` argument to dice and tversky losses.
* a second commit also adds code to the focal loss, but without tests. I couldn't easily extend an existing test case to properly test the new parameter. IMHO, I would drop this second commit for now.
fixes #839
#### Type of change
- [x] ... | 2024-10-09T12:35:13Z | "ignore_index" argment for focal loss and dice loss
When I try to train for segmentation on VOC 2012 with Dice loss, I always run into cuda illegal error and I finally found that this may be caused by out-of-range indexes (255 out of 20 classes). Since pytorch CrossEntropyLoss has an argment "ignore_index" to deal with... | [
{
"body": "When I try to train for segmentation on VOC 2012 with Dice loss, I always run into cuda illegal error and I finally found that this may be caused by out-of-range indexes (255 out of 20 classes). Since pytorch CrossEntropyLoss has an argment \"ignore_index\" to deal with this issue, I wonder if there ... | 274e3bea4560ea3c714001751bd24defea1d0d2f | {
"head_commit": "bcfb449c212e7484a057e31ae0bfcfcd075d7200",
"head_commit_message": "fix copy&paste bug in binary_focal_loss_with_logits",
"patch_to_review": "diff --git a/kornia/losses/dice.py b/kornia/losses/dice.py\nindex 2b78a6838a..bbf032468f 100644\n--- a/kornia/losses/dice.py\n+++ b/kornia/losses/dice.py\n... | [
{
"diff_hunk": "@@ -20,6 +20,7 @@ def focal_loss(\n gamma: float = 2.0,\n reduction: str = \"none\",\n weight: Optional[Tensor] = None,\n+ ignore_index: int = -100,",
"line": null,
"original_line": 23,
"original_start_line": null,
"path": "kornia/losses/focal.py",
"start_line"... | f3bf1e23b1d2ce6fdacd37c9e9a022d6e4cd80b0 | diff --git a/kornia/losses/_utils.py b/kornia/losses/_utils.py
new file mode 100644
index 0000000000..2e78df19ed
--- /dev/null
+++ b/kornia/losses/_utils.py
@@ -0,0 +1,23 @@
+from __future__ import annotations
+
+from typing import Optional
+
+import torch
+
+
+def mask_ignore_pixels(
+ target: torch.Tensor, ignore_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
lutris__lutris-4866@5415015 | lutris/lutris | Python | 4,866 | Make Nvidia info not depend on /proc access | Some environments have limited access to /proc, but we can still retrieve the same info in other ways.
(Fixes #4858) | 2023-05-21T02:30:53Z | Lutris 0.5.13 PermissionError: [Errno 13] Permission denied: '/proc/driver/nvidia/version'
### Bug description
Installed Lutris 0.5.13 since Starcraft 2 stopped working in Lutris 0.5.11. I uninstalled the apt install of Lutris and installed the Snap version instead.
However Lutris won't start at all. Issuing the st... | > I uninstalled the apt install of Lutris and installed the Snap version instead.
Then uninstall it and re-install the deb package, it's available on the releases page.
To my knowledge, the snap package is still being worked on and isn't ready for regular use.
Also, leave an issue here: https://github.com/CapeCrusa... | [
{
"body": "### Bug description\n\nInstalled Lutris 0.5.13 since Starcraft 2 stopped working in Lutris 0.5.11. I uninstalled the apt install of Lutris and installed the Snap version instead.\r\n\r\nHowever Lutris won't start at all. Issuing the start command in CLI gives the following error. See using sudo below... | ada7f28d56370c32d83fc93e0a4d113f087ea61b | {
"head_commit": "5415015f6f041c4eb3f9fc98d0c7108e7f80a9b6",
"head_commit_message": "Typing additions for drivers file",
"patch_to_review": "diff --git a/lutris/util/graphics/drivers.py b/lutris/util/graphics/drivers.py\nindex 01bb0f9bd1..b07437f115 100644\n--- a/lutris/util/graphics/drivers.py\n+++ b/lutris/util... | [
{
"diff_hunk": "@@ -2,83 +2,139 @@\n \n Everything in this module should rely on /proc or /sys only, no executable calls\n \"\"\"\n+import contextlib\n import os\n import re\n+from typing import Dict, Iterable, List\n \n+from lutris.util.graphics.glxinfo import GlxInfo\n from lutris.util.log import logger\n+fro... | 4f6d4f427b7ea2b96fcdcb6e128958059d8d7506 | diff --git a/lutris/util/graphics/drivers.py b/lutris/util/graphics/drivers.py
index 01bb0f9bd1..94f196606c 100644
--- a/lutris/util/graphics/drivers.py
+++ b/lutris/util/graphics/drivers.py
@@ -4,81 +4,186 @@
"""
import os
import re
+from typing import Dict, Iterable, List
+from lutris.util.graphics.glxinfo impor... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
lutris__lutris-3860@d52d472 | lutris/lutris | Python | 3,860 | Silence bogus "Could not retrieve game installer" dialog | This removes two bogus error reports - one is a dialog, the other a log message.
The offending code treats 'None' coming back from the install() method of a game service as an 'installer not found' error, but this is not correct. This method returns 'None' when it has starting an installation, but it is still ongoin... | 2021-11-27T19:30:49Z | "Could not retrieve game installer" when trying to install a game from EGS source
Whenever I try to install a game through the Epic Games source, I always get a "Could not retrieve game installer" when the installer window pops up. After I close it (which seems to put the installer window to foreground for some reason,... | [
{
"body": "Whenever I try to install a game through the Epic Games source, I always get a \"Could not retrieve game installer\" when the installer window pops up. After I close it (which seems to put the installer window to foreground for some reason, very annoying), I can install EGS just fine.",
"number":... | e03f91f7ffa5a04dae4ef7759b93d0a011cf67ec | {
"head_commit": "d52d472b00904bc4e055ffa614b09f7975f72493",
"head_commit_message": "Merge branch 'lutris:master' into dj/could-not-retrieve",
"patch_to_review": "diff --git a/lutris/gui/application.py b/lutris/gui/application.py\nindex 2fbdf1309b..896ad593e8 100644\n--- a/lutris/gui/application.py\n+++ b/lutris/... | [
{
"diff_hunk": "@@ -184,7 +184,17 @@ def get_installers_from_api(self, appid):\n return service_installers\n \n def install(self, db_game):\n- \"\"\"Install a service game\"\"\"\n+ \"\"\"Install a service game, or starts the installer of the game.\n+\n+ Args:\n+ db_na... | 0762ae5e59d8aaca7ed79d6a5c4c4c36f22437e3 | diff --git a/lutris/gui/application.py b/lutris/gui/application.py
index 2fbdf1309b..896ad593e8 100644
--- a/lutris/gui/application.py
+++ b/lutris/gui/application.py
@@ -502,8 +502,6 @@ def on_game_install(self, game):
if game_id:
game = Game(game_id)
game.launch()
- ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
matplotlib__matplotlib-27172@9f80d55 | matplotlib/matplotlib | Python | 27,172 | ENH: Change logging to warning when creating a legend with no labels | Fixes #27145
Also add test_legend_nolabels_warning()
## PR summary
After discussion in the linked issue, it was determined that `warnings.warn()` was better than `log.warning()` for alerting users that we can't draw a legend if there are no labels. This PR implements the change from `log.warning()` to `warnings... | 2023-10-23T13:05:15Z | [ENH]: Make "No artists with labels found to put in legend" a warning
### Problem
When I receive this issue, it's hard to debug and find the specific call to `ax.legend()` if I can't raise Warnings to Exceptions. I sometimes nest plotting functions in order to draw the same plot different ways or arrange plots in ... | This is related to #23422 though this one is a little more ambiguous if it should actually be a warning or not as the user _can_ suppress the warning by either adding a label or removing the legend call.
Thanks for the link :) My issue is definitely an example of @mwaskom's point that "you can convert a warning to a... | [
{
"body": "### Problem\r\n\r\nWhen I receive this issue, it's hard to debug and find the specific call to `ax.legend()` if I can't raise Warnings to Exceptions. I sometimes nest plotting functions in order to draw the same plot different ways or arrange plots in a composite figure, depending upon the presenta... | e50154367059dd321f5a4aa33e08009351aaff91 | {
"head_commit": "9f80d5598d0ffa101e8db0968788290caa72a105",
"head_commit_message": "TST: Add test for drawing empty legend()",
"patch_to_review": "diff --git a/galleries/examples/text_labels_and_annotations/custom_legends.py b/galleries/examples/text_labels_and_annotations/custom_legends.py\nindex f1714a21a481..... | [
{
"diff_hunk": "@@ -1375,3 +1377,16 @@ def test_legend_handle_label_mismatch_no_len():\n labels=iter([\"pl1\", \"pl2\", \"pl3\"]))\n assert len(legend.legend_handles) == 2\n assert len(legend.get_texts()) == 2\n+\n+\n+def test_legend_nolabels_warning():\n+ plt.plot([1, 2, 3])\... | dbe82fe1a4a7d5b33a4d4dd5e66e66ed4f242f22 | diff --git a/galleries/examples/text_labels_and_annotations/custom_legends.py b/galleries/examples/text_labels_and_annotations/custom_legends.py
index f1714a21a481..18ace0513228 100644
--- a/galleries/examples/text_labels_and_annotations/custom_legends.py
+++ b/galleries/examples/text_labels_and_annotations/custom_lege... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-27183@9d772c4 | matplotlib/matplotlib | Python | 27,183 | Fix behaviour of Figure.clear() for SubplotParams | <!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
## PR summary
* Update `Figure.clear()` to reset the properties of `Figure.subplotpars`.
* Add representation method for `matplotlib.gridspec.Su... | 2023-10-24T20:38:24Z | figure.clf() and subplots_adjust
This might not be a bug but I doubt that it is an intended behavior. `figure.clf() ` don't change the subplot parameters to any default values so it is not enough to do `figure.clf() ` when testing to plot with or without for example `tight_layout `. This is easy to fix by adding for... | I'm not sure if this is intended behaviour or not. If understand what you are describing, it seems like `clf` should indeed reset those values. Not sure about the utility of getters and setters etc.
There is a tension in the docs between reproducibility and simplicity. See the `legend` doc (in Master) for one ... | [
{
"body": "This might not be a bug but I doubt that it is an intended behavior. `figure.clf() ` don't change the subplot parameters to any default values so it is not enough to do `figure.clf() ` when testing to plot with or without for example `tight_layout `. This is easy to fix by adding for example:\r\n`... | 697c2405bbff4b0319eaf68359705f5b2462bb2a | {
"head_commit": "9d772c465bf8bb0d1e60ed67ef6a96cc3e84e34e",
"head_commit_message": "Update lib/matplotlib/tests/test_gridspec.py\n\nCo-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>",
"patch_to_review": "diff --git a/doc/users/next_whats_new/subplots_adjust.rst b/doc/users/next_whats_new/s... | [
{
"diff_hunk": "@@ -0,0 +1,9 @@\n+Resetting the subplot parameters for figure.clear()\n+---------------------------------------------------\n+\n+When calling `.Figure.clear()` the settings for `.gridspec.SubplotParams` are restored to the default values.\n+\n+The `.gridspec.SubplotParams` object has a new metho... | d5c9f7b7ea1886d7b761581becb1fb873ca4a7a1 | diff --git a/doc/users/next_whats_new/subplots_adjust.rst b/doc/users/next_whats_new/subplots_adjust.rst
new file mode 100644
index 000000000000..e0848ec8a3dc
--- /dev/null
+++ b/doc/users/next_whats_new/subplots_adjust.rst
@@ -0,0 +1,7 @@
+Resetting the subplot parameters for figure.clear()
+--------------------------... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
mitmproxy__mitmproxy-4236@1fa0361 | mitmproxy/mitmproxy | Python | 4,236 | [#4235] Automatic view mode based on should_render method | #### Description
This fixes #4235.
This is second attempt to support `+json` content type suffix. The first attempt in #3353 was declined. I applied authors suggestions regarding using `should_render` method for automatic view selection.
#### Checklist
- [x] I have updated tests where applicable.
- [x] I... | 2020-10-15T13:44:53Z | Recognize `+json` content type suffix
Currently mitmproxy uses json view automatically only when request/response content type is exactly `application/json`. Mitmproxy uses default raw view mode, when content mode has vendor-specific media-type with json suffix, e.g. `application/vnd.my.company+json`. User has to chang... | [
{
"body": "Currently mitmproxy uses json view automatically only when request/response content type is exactly `application/json`. Mitmproxy uses default raw view mode, when content mode has vendor-specific media-type with json suffix, e.g. `application/vnd.my.company+json`. User has to change view mode to json... | f6df2be863d3554acf03d6fc20482f58fbfdc3df | {
"head_commit": "1fa03614035eb6039da90a8b17d5cb6e8bd9250d",
"head_commit_message": "[#4235] Fix linter warnings",
"patch_to_review": "diff --git a/CHANGELOG b/CHANGELOG\nindex b9bfb74de4..d2e9b35721 100644\n--- a/CHANGELOG\n+++ b/CHANGELOG\n@@ -16,6 +16,7 @@ Unreleased: mitmproxy next\n * Fix file unlinking ... | [
{
"diff_hunk": "@@ -48,3 +48,6 @@ def __call__(self, data, **metadata):\n data = parse_msgpack(data)\n if data is not PARSE_ERROR:\n return \"MsgPack\", format_msgpack(data)\n+\n+ def should_render(self, content_type):\n+ return content_type in self.__content_types",
"l... | 31fce98061b66ea4cba385593a980c0b96a9dc54 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index db6cb5ffb9..b03e6a6029 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -41,6 +41,8 @@ If you depend on these features, please raise your voice in
* mitmproxy's command line interface now supports Windows (@mhils)
* The `clientconnect`, `clientdisconnect`, `serverconnect`... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
lutris__lutris-2116@88c41b2 | lutris/lutris | Python | 2,116 | Kill Processes on Install Cancellation | Attempt to fix #2084 | 2019-05-07T14:04:23Z | Lutris doesn't completely kill Wine processes in the prefix after cancellation of the installation
It's not uncommon for me to get "creating prefix" messages just after cancellation of the game installation and see active processes that were launched during installation process in System Monitor (which are what trigger... | [
{
"body": "It's not uncommon for me to get \"creating prefix\" messages just after cancellation of the game installation and see active processes that were launched during installation process in System Monitor (which are what triggering prefix re-creation after Lutris deletes it).\r\nAnd same happens if the in... | 780ef9713f91f8c09d59c3a0923bc2713722a7b0 | {
"head_commit": "88c41b215f214a6ffcc9df112cd967dad69746ea",
"head_commit_message": "Updated install cancelation to kill wine processes",
"patch_to_review": "diff --git a/lutris/gui/installerwindow.py b/lutris/gui/installerwindow.py\nindex e516e83f84..71610e3bd6 100644\n--- a/lutris/gui/installerwindow.py\n+++ b/... | [
{
"diff_hunk": "@@ -481,6 +482,7 @@ def cancel_installation(self, widget=None):\n }\n )\n if confirm_cancel_dialog.result != Gtk.ResponseType.YES:\n+ Popen(['wineserver', '-k9'], shell=True)",
"line": null,
"original_line": 485,
"original_start_line": null,
... | 693d0ddcd27b6afd3d9704e5f49f43ef06ac9df5 | diff --git a/lutris/gui/installerwindow.py b/lutris/gui/installerwindow.py
index e516e83f84..17d881a240 100644
--- a/lutris/gui/installerwindow.py
+++ b/lutris/gui/installerwindow.py
@@ -24,6 +24,8 @@
from lutris.util.log import logger
from lutris.util.strings import add_url_tags, escape_gtk_label
+from subprocess ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
matplotlib__matplotlib-26906@a5cb9ef | matplotlib/matplotlib | Python | 26,906 | Fix masking for Axes3D.plot() | <!--
Thank you so much for your PR! To help us review your contribution, please check
out the development guide https://matplotlib.org/devdocs/devel/index.html
-->
## PR summary
Closes https://github.com/matplotlib/matplotlib/issues/25043 - there was someone who volunteered to look at doing that fix, but I'm no... | 2023-09-24T20:21:20Z | [ENH]: Plotting masked arrays correctly in 3D line plot
### Problem
It would be great if the masking feature worked in 3D plots:
```
import matplotlib.pyplot as plt
import numpy as np
# Create some data
x = np.linspace(0, 10, 100)
y = np.linspace(0, 10, 100)
z = np.sin(x) * np.cos(y)
# Mask some of the d... | Can I work on this issue? I am pretty new to this
Hi @jalajk24, welcome to Matplotlib! Anyone is welcome to work on anything but, if you are new, it may be better to look through our [Good First Issues](https://github.com/matplotlib/matplotlib/issues?q=is%3Aissue+is%3Aopen+label%3A%22Good+first+issue%22). Please also... | [
{
"body": "### Problem\n\nIt would be great if the masking feature worked in 3D plots:\r\n\r\n```\r\nimport matplotlib.pyplot as plt\r\nimport numpy as np\r\n\r\n# Create some data\r\nx = np.linspace(0, 10, 100)\r\ny = np.linspace(0, 10, 100)\r\nz = np.sin(x) * np.cos(y)\r\n\r\n# Mask some of the data\r\nmask =... | 112a2257387b72490f7ab0e0b428a2abd2c39374 | {
"head_commit": "a5cb9ef1d1550db0540334deba7f32265f1173f3",
"head_commit_message": "Consolidate 3D masking and fix for Axes3D.plot()\n\nMove function to cbook\n\nWhitespace\n\nPrivatize cbook._broadcast_with_masks",
"patch_to_review": "diff --git a/lib/matplotlib/cbook.py b/lib/matplotlib/cbook.py\nindex b56de55... | [
{
"diff_hunk": "@@ -130,6 +130,7 @@ class GrouperView(Generic[_T]):\n \n def simple_linear_interpolation(a: ArrayLike, steps: int) -> np.ndarray: ...\n def delete_masked_points(*args): ...\n+def _broadcast_with_masks(*args, compress: bool=False) -> list[ArrayLike]: ...",
"line": null,
"original_line": 1... | 0762613cf07dcace06cffdae731b681e0a728dea | diff --git a/lib/matplotlib/cbook.py b/lib/matplotlib/cbook.py
index b56de559532d..b0cde743482b 100644
--- a/lib/matplotlib/cbook.py
+++ b/lib/matplotlib/cbook.py
@@ -1088,6 +1088,44 @@ def _combine_masks(*args):
return margs
+def _broadcast_with_masks(*args, compress=False):
+ """
+ Broadcast inputs, co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-26519@7f65d6b | matplotlib/matplotlib | Python | 26,519 | Fix mathtext mismatched braces | ## PR summary
Fixes #26510
## PR checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A].-->
- [x] "closes #0000" is in the body of the PR description to [link the related issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [x] n... | 2023-08-14T09:23:57Z | [Bug]: mathtext silently ignores content after mismatched opening brace
### Bug summary
All's in the title.
### Code for reproduction
```python
from pylab import *; figtext(.5, .5, r"$a={a$")
```
### Actual outcome
"a = " is printed.
### Expected outcome
An exception is thrown.
### Additional information
This... | [
{
"body": "### Bug summary\n\nAll's in the title.\n\n### Code for reproduction\n\n```python\nfrom pylab import *; figtext(.5, .5, r\"$a={a$\")\n```\n\n\n### Actual outcome\n\n\"a = \" is printed.\n\n### Expected outcome\n\nAn exception is thrown.\n\n### Additional information\n\nThis appears at least as far bac... | 835220b60d5021aa39dca0ee030db96214d4ffb4 | {
"head_commit": "7f65d6b58e2cef2445f6b8778381dd3a56937dd1",
"head_commit_message": "Add unclosed group to grammar\n\nCo-authored-by: Kyle Sunden <git@ksunden.space>",
"patch_to_review": "diff --git a/lib/matplotlib/_mathtext.py b/lib/matplotlib/_mathtext.py\nindex 25a825b7b0d9..73cb0ae1189d 100644\n--- a/lib/mat... | [
{
"diff_hunk": "@@ -2030,7 +2032,8 @@ def main(self, s, loc, toks):\n return [Hlist(toks)]\n \n def math_string(self, s, loc, toks):\n- return self._math_expression.parseString(toks[0][1:-1])\n+ return self._math_expression.parseString(toks[0][1:-1],\n+ ... | 3dc34576a0e70981860146a712bcc0a91812afdf | diff --git a/lib/matplotlib/_mathtext.py b/lib/matplotlib/_mathtext.py
index 25a825b7b0d9..24aab9046e27 100644
--- a/lib/matplotlib/_mathtext.py
+++ b/lib/matplotlib/_mathtext.py
@@ -1894,6 +1894,7 @@ def csnames(group, names):
p.function = csnames("name", self._function_names)
p.group = p.start_gro... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
lutris__lutris-3787@6f3fbdd | lutris/lutris | Python | 3,787 | lowercase when wine_version not None (Fixes #3764) | ## Proposed changes
os: ubuntu 21.10
version: 0.5.9.1
when launching game with wine from play button it may doing nothing.
when running lutris with debug flag following error show up
```python
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/lutris/exceptions.py", line 57, in wrap... | 2021-10-28T00:10:09Z | Cannot run WINE games error get_wine_version(path).lower() returns None
until recently running WINE games has worked really well
but now whenever i press on the "launch" button, it gets permanently greyed out with "Launching" on the button.
when running Lutris from a terminal and trying to launch a game, I get:
``... | [
{
"body": "until recently running WINE games has worked really well\r\nbut now whenever i press on the \"launch\" button, it gets permanently greyed out with \"Launching\" on the button.\r\nwhen running Lutris from a terminal and trying to launch a game, I get:\r\n\r\n```\r\nTraceback (most recent call last):\r... | 86635d962fab0d6c590937a050013ba0d1f6e4f5 | {
"head_commit": "6f3fbdd97b0639efc7643dc42a14fd1bfee1c3f3",
"head_commit_message": "fix: dev: handle TypeError",
"patch_to_review": "diff --git a/lutris/util/wine/wine.py b/lutris/util/wine/wine.py\nindex 9e22e68a6a..d0a1df4db5 100644\n--- a/lutris/util/wine/wine.py\n+++ b/lutris/util/wine/wine.py\n@@ -290,8 +29... | [
{
"diff_hunk": "@@ -313,7 +316,10 @@ def is_version_fsync(path):\n for fsync_version in fsync_compatible_versions:\n if fsync_version in version_prefix or fsync_version in version_suffix:\n return True\n- return \"fsync\" in get_wine_version(path).lower()\n+ wine_version = get_wine... | 5bd94c89536bb20e23e264306e17673084144453 | diff --git a/lutris/util/wine/wine.py b/lutris/util/wine/wine.py
index 0682b28532..f1bd997bee 100644
--- a/lutris/util/wine/wine.py
+++ b/lutris/util/wine/wine.py
@@ -290,8 +290,11 @@ def is_version_esync(path):
for esync_version in esync_compatible_versions:
if esync_version in version_prefix or esync_ve... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
kornia__kornia-2456@0b6d3d6 | kornia/kornia | Python | 2,456 | Add pre-trained flag for SAM | #### Changes
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
<!-- List any dependencies that are required for this change. -->
Fixes #2452
#### Type of change
<!-- Please delete options that are not relevant. -->
- [ ] �... | 2023-07-15T02:35:33Z | Add ability to use `pretrained=True` for SAM
## 🚀 Feature
<!-- A clear and concise description of the feature proposal -->
Add ability to use `pretrained=True` for SAM (and MobileSAM).
```python
prompter = VisualPrompter(SamConfig('vit_b', pretrained=True))
```
In other words, when there is `pretrained=Tru... | [
{
"body": "## 🚀 Feature\r\n<!-- A clear and concise description of the feature proposal -->\r\n\r\nAdd ability to use `pretrained=True` for SAM (and MobileSAM).\r\n\r\n```python\r\nprompter = VisualPrompter(SamConfig('vit_b', pretrained=True))\r\n```\r\n\r\nIn other words, when there is `pretrained=True`, we w... | 366c313b02ea623c1a4824734f5b61c7b2d0ed8c | {
"head_commit": "0b6d3d6b1f82c6916bf4374e6ba482d40bc3f300",
"head_commit_message": "add pre-trained for SAM",
"patch_to_review": "diff --git a/kornia/contrib/models/sam/model.py b/kornia/contrib/models/sam/model.py\nindex 84a1455d06..e9addb4aef 100644\n--- a/kornia/contrib/models/sam/model.py\n+++ b/kornia/contr... | [
{
"diff_hunk": "@@ -172,8 +174,20 @@ def from_config(config: SamConfig) -> Sam:\n else:\n raise NotImplementedError('Unexpected config. The model_type should be provide or the encoder configs.')\n \n- if config.checkpoint:\n- model.load_checkpoint(config.checkpoint)\n+ ... | e30b16238452ecb424b7c4679dfd46fea12aff7c | diff --git a/kornia/contrib/models/sam/model.py b/kornia/contrib/models/sam/model.py
index 84a1455d06..487c8615ec 100644
--- a/kornia/contrib/models/sam/model.py
+++ b/kornia/contrib/models/sam/model.py
@@ -8,6 +8,7 @@
"""
from __future__ import annotations
+import warnings
from dataclasses import dataclass
from ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
matplotlib__matplotlib-26160@855641d | matplotlib/matplotlib | Python | 26,160 | add setters and getters for _AxLine's xy1, xy2 and slope parameters | ## PR summary
Closes #26081. Add setter and getter methods for `_AxLine` to modify the control points and slope of the artist.
Setters will not allow the modification of `xy2` if `slope` is set and vice versa.
`Axline` is now public and documented.
## PR checklist
<!-- Please mark any checkboxes that do not apply ... | 2023-06-21T08:22:38Z | [ENH]: Add setters for _AxLine._xy1, ._xy2, ._slope
### Problem
Currently the control points / slope of the artist returned by axline() cannot be (publically) modified after being instantiated. It would be nice if the relevant properties (xy1, xy2, slope) had setters (following normal Artist design).
For simplicit... | [
{
"body": "### Problem\n\nCurrently the control points / slope of the artist returned by axline() cannot be (publically) modified after being instantiated. It would be nice if the relevant properties (xy1, xy2, slope) had setters (following normal Artist design).\r\n\r\nFor simplicity it is probably enough if ... | 9fdf6adf70819c8d34e9f47eeb8470aea35d78c0 | {
"head_commit": "855641d00efe88584f06315963d6d74defa62ed7",
"head_commit_message": "add setters and getters for AxLine",
"patch_to_review": "diff --git a/doc/api/lines_api.rst b/doc/api/lines_api.rst\nindex 4cde67c7e656..bf7ec73493a3 100644\n--- a/doc/api/lines_api.rst\n+++ b/doc/api/lines_api.rst\n@@ -17,6 +17,... | [
{
"diff_hunk": "@@ -0,0 +1,16 @@\n+Axline setters and getters\n+--------------------------\n+The returned object from ``Axes.axline`` now supports getter and setter",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": "doc/users/next_whats_new/axline_setters.rst",
"start_... | 6a3157e32cf93061211552c352bc09ed0d0fe607 | diff --git a/doc/api/lines_api.rst b/doc/api/lines_api.rst
index 4cde67c7e656..bf7ec73493a3 100644
--- a/doc/api/lines_api.rst
+++ b/doc/api/lines_api.rst
@@ -17,6 +17,7 @@ Classes
Line2D
VertexSelector
+ AxLine
Functions
---------
diff --git a/doc/users/next_whats_new/axline_setters.rst b/doc/users/nex... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
matplotlib__matplotlib-26151@c6a1bf5 | matplotlib/matplotlib | Python | 26,151 | Add substack cmd for mathtext | ## PR summary
Fixes #14247
## PR checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A].-->
- [x] "closes #0000" is in the body of the PR description to [link the related issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
- [ ] ... | 2023-06-19T13:14:26Z | latex \substack doesn't work
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
<!--A short 1-2 sentences that succinctly describes the bug-->
**Code for... | Could you post a minimal example of the code needed to produce the error, and the error message you get?
Let's just assume this is a request for the latex \substack command (https://tex.stackexchange.com/questions/153490/atop-vs-substack-for-multiple-lines-under-a-sum).
This issue has been marked "inactive" because it ... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\n<!--A short 1-2 sentences that succinctly describes the bug-->\r\n\r\n**... | 4dbba98f38575c9adc76e59d83e930aa8cff6149 | {
"head_commit": "c6a1bf5b26de11e4c328419d6bd5e87327179e53",
"head_commit_message": "Add substack command for mathtext\n\nCo-Authored By: Kyle Sunden <git@ksunden.space>",
"patch_to_review": "diff --git a/lib/matplotlib/_mathtext.py b/lib/matplotlib/_mathtext.py\nindex d86385e94589..a80c9f614b4a 100644\n--- a/lib... | [
{
"diff_hunk": "@@ -27,6 +27,11 @@\n from .font_manager import FontProperties, findfont, get_font\n from .ft2font import FT2Image, KERNING_DEFAULT\n \n+from pyparsing import __version__ as pyparsing_version\n+if pyparsing_version < '3.0.0':",
"line": null,
"original_line": 31,
"original_start_line":... | f780312df190236a3a8e710be1d75ea3d25058f4 | diff --git a/lib/matplotlib/_mathtext.py b/lib/matplotlib/_mathtext.py
index d86385e94589..3c937d3fe224 100644
--- a/lib/matplotlib/_mathtext.py
+++ b/lib/matplotlib/_mathtext.py
@@ -18,7 +18,7 @@
Empty, Forward, Literal, NotAny, oneOf, OneOrMore, Optional,
ParseBaseException, ParseException, ParseExpression,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-26071@ee2c848 | matplotlib/matplotlib | Python | 26,071 | ENH: macosx allow figures to be opened in tabs or windows | ## PR summary
Allow users to select how new figures are created when opening new windows. The default is to keep using the system preferences, but one can also select "tab" or "window" to override the default system preferences. I've called the new rcParam `figure.window_mode`, but definitely open to other suggestio... | 2023-06-04T19:23:36Z | Figures in windows not tabs
I want to create multiple figure with Matplotlib in python, using the macosx backend. Currently, my code looks something like this:
```python
import matplotlib.pyplot as plt
import numpy as np
x = np.linspace(0, 2, 100)
f1 = plt.figure(1)
plt.plot(x,x**2)
f2 = plt.figure(2)
p... | It seems this an OS "feature". Is [this](https://discussions.apple.com/thread/7852724) of any help?
Kind of. Changing that setting does help, however it affects *all* applications. I *generally* prefer things opening in new tabs, but in this case I don't. Applications can override this system-wide setting. Seems like... | [
{
"body": "I want to create multiple figure with Matplotlib in python, using the macosx backend. Currently, my code looks something like this:\r\n\r\n```python\r\nimport matplotlib.pyplot as plt\r\nimport numpy as np\r\n\r\nx = np.linspace(0, 2, 100)\r\n\r\nf1 = plt.figure(1)\r\nplt.plot(x,x**2)\r\n\r\nf2 = plt... | eb33b94da7acc05f4e8baf428f8a97e76c001f84 | {
"head_commit": "ee2c8482b57485b94ce9d3108084d9a7bbc45088",
"head_commit_message": "ENH: macosx allow figures can be opened in tabs or windows\n\nAllow users to select how new figures are created when opening\nnew windows. The default is to keep using the system preferences,\nbut one can also select \"tab\" or \"w... | [
{
"diff_hunk": "@@ -832,6 +851,10 @@ int mpl_check_modifier(\n {\"destroy\",\n (PyCFunction)FigureManager_destroy,\n METH_NOARGS},\n+ {\"_set_window_mode\",\n+ (PyCFunction)FigureManager__set_window_mode,\n+ METH_VARARGS,\n+ \"Set the window open mode (au... | fc57f753e309e3b4fdf8b8e039bf66f920f50235 | diff --git a/doc/users/next_whats_new/macosx_windows_tabs.rst b/doc/users/next_whats_new/macosx_windows_tabs.rst
new file mode 100644
index 000000000000..85fd76b6cb6d
--- /dev/null
+++ b/doc/users/next_whats_new/macosx_windows_tabs.rst
@@ -0,0 +1,7 @@
+macosx: New figures can be opened in either windows or tabs
+------... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-26064@eab74da | matplotlib/matplotlib | Python | 26,064 | add ishikawa diagram to examples | ## PR summary
Closes #25222. Adds a fishbone plot to the specialty plots example in the docs. This PR is a continuation of https://github.com/matplotlib/matplotlib/pull/25248 except the plot is different. It's a simple representation of a fishbone plot which takes the input data as a dictionary of nested lists or tupl... | 2023-06-04T12:25:50Z | [ENH]: add organizational charts to supported plots
### Problem
I would like to efficiently use matplotlib to produce also organizational charts like the Ishikawa (fishbone) diagram to include also the cause-effect relationships into professional and academical documents. For the Ishikawa case, it could be interesting... | Thanks for your interest in improving Matplotlib!
That type of chart is super-specialized and I would expect better suited to an external library. We don't provide a tree plot, either, though https://github.com/erdogant/treeplot does. If the external library proved popular, and/or there was a compelling reason i... | [
{
"body": "### Problem\n\nI would like to efficiently use matplotlib to produce also organizational charts like the Ishikawa (fishbone) diagram to include also the cause-effect relationships into professional and academical documents. For the Ishikawa case, it could be interesting to modify the treeplot by usin... | 19d93b787649652059bd4163c2b23c10e5088f4f | {
"head_commit": "eab74da6e1fba863395e9129e16d81dba2ef29f2",
"head_commit_message": "remove redundant line",
"patch_to_review": "diff --git a/galleries/examples/specialty_plots/ishikawa_diagram.py b/galleries/examples/specialty_plots/ishikawa_diagram.py\nnew file mode 100644\nindex 000000000000..976fdc516887\n---... | [
{
"diff_hunk": "@@ -0,0 +1,200 @@\n+\"\"\"\n+================\n+Ishikawa Diagram\n+================\n+\n+Ishikawa Diagrams, fishbone diagrams, herringbone diagrams, or cause-and-effect\n+diagrams are used to identify problems in a system by showing how causes and\n+effects are linked.\n+Source: https://en.wikip... | ae97baf23c87f6140cc4e32f83e8918cc69977ca | diff --git a/galleries/examples/specialty_plots/ishikawa_diagram.py b/galleries/examples/specialty_plots/ishikawa_diagram.py
new file mode 100644
index 000000000000..18761ca36043
--- /dev/null
+++ b/galleries/examples/specialty_plots/ishikawa_diagram.py
@@ -0,0 +1,203 @@
+"""
+================
+Ishikawa Diagram
+======... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-26003@e69d6aa | matplotlib/matplotlib | Python | 26,003 | added alias to gray and grey match same colormaps | ## PR summary
Closes #8965
As suggested in the issue discussion, added alias to match the different spellings of gray and grey in the end of _gen_cmap_registry function in cm.py
cmap_d['grey'] = cmap_d['gist_grey'] = cmap_d['gray']
cmap_d['Grays'] = cmap_d['Greys']
cmap_d['gist_yerg'] = cmap_d['gi... | 2023-05-29T20:33:44Z | Add alias for colormaps for grey vs gray English issues
<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->
<!--You can feel free to delete the sections that do not apply.-->
### Bug report
**Bug summary**
The current colormap options reflect American Eng... | I don't mind making things uniform by moving towards either direction (well I have no horse in this game :-)) but I'm quite strongly against adding more aliases -- it's not as it matplotlib's API ever claimed to be localized anyways (I'm not a native English speaker but I'm not going to complain that I have to write `p... | [
{
"body": "<!--To help us understand and resolve your issue, please fill out the form to the best of your ability.-->\r\n<!--You can feel free to delete the sections that do not apply.-->\r\n\r\n### Bug report\r\n\r\n**Bug summary**\r\n\r\nThe current colormap options reflect American English spellings for 2/3 ... | 3d3a1afd6d7c83ea79670b7c0b3568f92496b906 | {
"head_commit": "e69d6aabf8849714884ea67d7e20a99304739b48",
"head_commit_message": "added alias to gray and grey match same colormaps",
"patch_to_review": "diff --git a/lib/matplotlib/cm.py b/lib/matplotlib/cm.py\nindex 38158db9564a..d9796cd4deea 100644\n--- a/lib/matplotlib/cm.py\n+++ b/lib/matplotlib/cm.py\n@@... | [
{
"diff_hunk": "@@ -46,6 +46,13 @@ def _gen_cmap_registry():\n for cmap in list(cmap_d.values()):\n rmap = cmap.reversed()\n cmap_d[rmap.name] = rmap\n+\n+ # Register colormap aliases for gray and grey.\n+ cmap_d['grey'] = cmap_d['gist_grey'] = cmap_d['gray']",
"line": null,
"o... | bb0e29b462a236aa9cd92432564f38b0255ebde5 | diff --git a/lib/matplotlib/cm.py b/lib/matplotlib/cm.py
index 38158db9564a..7ed873a7547c 100644
--- a/lib/matplotlib/cm.py
+++ b/lib/matplotlib/cm.py
@@ -42,6 +42,13 @@ def _gen_cmap_registry():
colors.ListedColormap(spec['listed'], name)
if 'listed' in spec else
colors.LinearSeg... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
kornia__kornia-2131@c952482 | kornia/kornia | Python | 2,131 | Fix params computation for `LongestMaxSize` and `SmallestMaxSize` | Fixes #2123
#### Type of change
- [x] 🧪 Tests Cases
- [x] 🐞 Bug fix (non-breaking change which fixes an issue) | 2023-01-09T13:09:42Z | Weird behavior of LongestMaxSize
### Describe the bug
Hello me again,
I might be doing something wrong with the way I use kornia augmentations, please let me know if it is the case.
I was expecting `LongestMaxSize` in kornia to perform similarily as the albumentation implementation. Meaning that I can throw an... | Seems like Resize behave similarly when size is an integer.
@johnnv1 @shijianjian Is this the expected behavior ?
@twsl Can you take a look?
Unfortunately I don't have much time right now, but a quick peek at the source code makes me wonder if the resize generator in the resize augmentation does include any checks to r... | [
{
"body": "### Describe the bug\r\n\r\nHello me again,\r\n\r\nI might be doing something wrong with the way I use kornia augmentations, please let me know if it is the case.\r\n\r\nI was expecting `LongestMaxSize` in kornia to perform similarily as the albumentation implementation. Meaning that I can throw any ... | 598444893212899f6f3678f45a10b5315ef0f5f9 | {
"head_commit": "c952482142177a6eb54484023e006a420aeb878e",
"head_commit_message": "Fix the side resize for `SmallestMaxSize`",
"patch_to_review": "diff --git a/kornia/augmentation/_2d/geometric/resize.py b/kornia/augmentation/_2d/geometric/resize.py\nindex eb6bb059cb..efef0526a6 100644\n--- a/kornia/augmentatio... | [
{
"diff_hunk": "@@ -114,6 +114,12 @@ def __init__(\n p=p,\n )\n \n+ def apply_transform(\n+ self, input: Tensor, params: Dict[str, Tensor], flags: Dict[str, Any], transform: Optional[Tensor] = None\n+ ) -> Tensor:\n+ self._param_generator = rg.ResizeGenerator(resize_to=se... | fa4c81e2a97edf51475f454080f7c918901d1b09 | diff --git a/kornia/augmentation/random_generator/_2d/resize.py b/kornia/augmentation/random_generator/_2d/resize.py
index 40db27b41c..cabe5d40b2 100644
--- a/kornia/augmentation/random_generator/_2d/resize.py
+++ b/kornia/augmentation/random_generator/_2d/resize.py
@@ -66,25 +66,27 @@ def forward(self, batch_shape: to... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-25964@67d1126 | matplotlib/matplotlib | Python | 25,964 | Fix get_constrained_layout_pads |
## PR summary
- fix non-existing function `get_info()`
- complete docs
closes #25963
## PR checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A].-->
- [x] "closes #0000" is in the body of the PR description to [link the related issue](https://docs.github.com/en/issues/tracking-yo... | 2023-05-24T14:20:19Z | [Bug]: fig.get_constrained_layout_pads() raises AttributeError
### Bug summary
`fig.get_constrained_layout_pads()` fails because the LayoutEngine has no function `get_info()`.
### Code for reproduction
```python
import matplotlib.pyplot as plt
fig = plt.figure(layout='constrained')
print(fig.get_constrained_layo... | [
{
"body": "### Bug summary\n\n`fig.get_constrained_layout_pads()` fails because the LayoutEngine has no function `get_info()`.\n\n### Code for reproduction\n\n```python\nimport matplotlib.pyplot as plt\r\n\r\nfig = plt.figure(layout='constrained')\r\nprint(fig.get_constrained_layout_pads())\n```\n\n\n### Actual... | 6a323c043b77154656b28fd34ac4ca6dfb0ecf9b | {
"head_commit": "67d112685a503a620938ce6db5a5898201ff1e9c",
"head_commit_message": "Fix get_constrained_layout_pads()\n\n- fix non-existing function get_info()\n- complete docs",
"patch_to_review": "diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py\nindex 39517e14d0e3..08bb483d606b 100644\n--- a/l... | [
{
"diff_hunk": "@@ -1603,3 +1603,11 @@ def test_savefig_metadata(fmt):\n def test_savefig_metadata_error(fmt):\n with pytest.raises(ValueError, match=\"metadata not supported\"):\n Figure().savefig(io.BytesIO(), format=fmt, metadata={})\n+\n+\n+def test_get_constrained_layout_pads():\n+ expected ... | b45d2c4cf94a3d3b471803f0f348151ba6ca4ae5 | diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
index 39517e14d0e3..08bb483d606b 100644
--- a/lib/matplotlib/figure.py
+++ b/lib/matplotlib/figure.py
@@ -2872,7 +2872,7 @@ def get_constrained_layout_pads(self, relative=False):
"""
if not isinstance(self.get_layout_engine(), Constraine... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
kornia__kornia-2132@57c3fd1 | kornia/kornia | Python | 2,132 | fix TensorWrapper serialization | #### Changes
Fixes #2126
- add also `TensorWarpper.unwrap` method
#### Type of change
<!-- Please delete options that are not relevant. -->
- [ ] 📚 Documentation Update
- [x] 🧪 Tests Cases
- [x] 🐞 Bug fix (non-breaking change which fixes an issue)
- [ ] 🔬 New feature (non-breaking change which adds ... | 2023-01-09T14:22:36Z | Round trip `torch.save` / `torch.load` not working for `Hyperplane`
### Describe the bug
Crashing when trying to save and reload a `Hyperplane` using `torch`:
```
Traceback (most recent call last):
File "save_hyperplane.py", line 16, in <module>
plane = torch.load("./saved_plane.pt")
File "/home/kyle/... | @Hackerman342 will take a look soon. This i guess is after introducing Vector3 and Scalar types | [
{
"body": "### Describe the bug\r\n\r\nCrashing when trying to save and reload a `Hyperplane` using `torch`:\r\n\r\n```\r\nTraceback (most recent call last):\r\n File \"save_hyperplane.py\", line 16, in <module>\r\n plane = torch.load(\"./saved_plane.pt\")\r\n File \"/home/kyle/venv/lib/python3.8/site-pack... | 598444893212899f6f3678f45a10b5315ef0f5f9 | {
"head_commit": "57c3fd1541b800132648cdadfa6378d45f475ef4",
"head_commit_message": "fix TensorWrapper serialization",
"patch_to_review": "diff --git a/kornia/core/tensor_wrapper.py b/kornia/core/tensor_wrapper.py\nindex 029f403cfa..51133714ff 100644\n--- a/kornia/core/tensor_wrapper.py\n+++ b/kornia/core/tensor_... | [
{
"diff_hunk": "@@ -35,14 +35,21 @@ def __init__(self, data: Tensor) -> None:\n self.__dict__[\"used_attrs\"] = set()\n self.__dict__[\"used_calls\"] = set()\n \n- @property\n- def data(self) -> Tensor:\n- return self._data\n+ def unwrap(self):\n+ return unwrap(self)\n+\n+... | 3f182f1e7b4d7878d817d0ba292e3b9d58679e0f | diff --git a/kornia/core/tensor_wrapper.py b/kornia/core/tensor_wrapper.py
index 029f403cfa..dd327d43b2 100644
--- a/kornia/core/tensor_wrapper.py
+++ b/kornia/core/tensor_wrapper.py
@@ -35,15 +35,22 @@ def __init__(self, data: Tensor) -> None:
self.__dict__["used_attrs"] = set()
self.__dict__["used_c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
kornia__kornia-2130@3b453d6 | kornia/kornia | Python | 2,130 | Add 3D-SSIM loss | Hi team, this PR aims to add SSIM Loss and Metrics for 3D images. Based on the following comment - https://github.com/kornia/kornia/issues/1158#issuecomment-880569245 and the Monai Implementation. Will have to skim through the paper once more to follow up on this - https://github.com/kornia/kornia/issues/1158#issuecomm... | 2023-01-08T22:27:53Z | [Feature request] Add 3D-SSIM
## 🚀 Feature
3D-SSIM
## Motivation
SSIM and SSIMLoss are currently only supported in 2D in kornia. While it is common in medical imaging to compute SSIM on 3D volumes. In addition, 3D-SSIM is useful for video.
## Pitch
Adding 3D-SSIM
## Alternatives
N/A
## Additional conte... | @wendy-xiaozong that would be a nice feature. Do you have any implementation reference ?
Hey @edgarriba,
I did find a paper on 3D-SSIM ([3D-SSIM FOR VIDEO QUALITY ASSESSMENT](https://ieeexplore.ieee.org/document/6466936)) from the same author of the SSIM paper. To compute it, it appears that they are simply converti... | [
{
"body": "## 🚀 Feature\r\n3D-SSIM\r\n\r\n## Motivation\r\nSSIM and SSIMLoss are currently only supported in 2D in kornia. While it is common in medical imaging to compute SSIM on 3D volumes. In addition, 3D-SSIM is useful for video.\r\n\r\n## Pitch\r\nAdding 3D-SSIM\r\n\r\n## Alternatives\r\nN/A\r\n\r\n## Add... | 598444893212899f6f3678f45a10b5315ef0f5f9 | {
"head_commit": "3b453d6957532e98b65c89af9cdf9043fc05a3d3",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/kornia/filters/__init__.py b/kornia/filters/__init__.py\nindex c399e2829b..ea9754cf18 1006... | [
{
"diff_hunk": "@@ -0,0 +1,105 @@\n+import torch\n+import torch.nn as nn\n+\n+import kornia.metrics as metrics\n+\n+\n+def ssim3d_loss(\n+ img1: torch.Tensor,\n+ img2: torch.Tensor,\n+ window_size: int,\n+ max_val: float = 1.0,\n+ eps: float = 1e-12,\n+ reduction: str = 'mean',\n+ padding: ... | 344dc8af8d2ae9f31b362e4fdec6421eed59a69d | diff --git a/kornia/filters/__init__.py b/kornia/filters/__init__.py
index c399e2829b..5d8d497e3f 100644
--- a/kornia/filters/__init__.py
+++ b/kornia/filters/__init__.py
@@ -15,6 +15,8 @@
get_gaussian_kernel1d_t,
get_gaussian_kernel2d,
get_gaussian_kernel2d_t,
+ get_gaussian_kernel3d,
+ get_gaussi... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-25775@5e5a03d | matplotlib/matplotlib | Python | 25,775 | Support customizing antialiasing for text and annotation | ## PR Summary
Closes #25675
Change overview: now text objects and annotation objects support parameter 'antialiased'.
When antialiased is not specified, it will use the value from rcParams instead.
Examples are
```
mpl.text.Text(.5, .5, "foo\nbar", antialiased=True)
plt.text(0.5, 0.5, '6 inches x 2 inches',... | 2023-04-26T21:26:46Z | [ENH]: Add get/set_antialiased to Text objects
### Problem
Currently, Text objects always retrieve their antialiasing state via the global rcParams["text.antialias"], unlike other artists for which this can be configured on a per-artist basis via `set_antialiased` (and read via `set_antialiased`).
### Proposed soluti... | i would like to work on this issue .Please assign me this issue
@ANSHTYAGI7 you are welcome to work on this issue, but we do not assign them.
Based on my understanding, I found currently only AGG and Cairo backends support customizing font antialiasing. So we are going to add support for these two? | [
{
"body": "### Problem\n\nCurrently, Text objects always retrieve their antialiasing state via the global rcParams[\"text.antialias\"], unlike other artists for which this can be configured on a per-artist basis via `set_antialiased` (and read via `set_antialiased`).\n\n### Proposed solution\n\nAdd similar gett... | 26224d96066b5c60882296c551f54ca7732c0af0 | {
"head_commit": "5e5a03db4033cf627520e7bb2b9f037e35d184d3",
"head_commit_message": "streamlined image comparison tests for text antialiasing",
"patch_to_review": "diff --git a/doc/api/next_api_changes/behavior/25775-HZ.rst b/doc/api/next_api_changes/behavior/25775-HZ.rst\nnew file mode 100644\nindex 000000000000... | [
{
"diff_hunk": "@@ -0,0 +1,39 @@\n+Support customizing antialiasing for text and annotation\n+--------------------------------------------------------\n+``matplotlib.pyplot.annotate()`` and ``matplotlib.pyplot.text()`` now support parameter ``antialiased``.\n+When ``antialiased`` is set to ``True``, antialiasin... | 95e070962451d2546da87853e2034de8f720e0fb | diff --git a/doc/api/next_api_changes/behavior/25775-HZ.rst b/doc/api/next_api_changes/behavior/25775-HZ.rst
new file mode 100644
index 000000000000..118195811b98
--- /dev/null
+++ b/doc/api/next_api_changes/behavior/25775-HZ.rst
@@ -0,0 +1,29 @@
+Default antialiasing behavior changes for ``Text`` and ``Annotation``
+~... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-25746@bf4259a | matplotlib/matplotlib | Python | 25,746 | Tick label font family via tick_params | ## PR Summary
Closes #18425. Added a `labelfont` kwarg to change tick label fonts conveniently, without changing the rest of the text.
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**Documentation and Tests**
- [x] Has pytest style unit tests (and `pytest` passes)
... | 2023-04-21T12:49:56Z | Add fontfamily/labelfont to tick_params
<!--
Welcome! Thanks for thinking of a way to improve Matplotlib.
Before creating a new feature request please search the issues for relevant feature requests.
-->
### Problem
There is no simple way of assigning a fontfamily to tick labels without needing to either o... | It doesn't look like anyone is working on this, so I'll try it out.
Pull request currently in review: https://github.com/matplotlib/matplotlib/pull/19110 | [
{
"body": "<!--\r\nWelcome! Thanks for thinking of a way to improve Matplotlib.\r\n\r\n\r\nBefore creating a new feature request please search the issues for relevant feature requests.\r\n-->\r\n\r\n### Problem\r\n\r\nThere is no simple way of assigning a fontfamily to tick labels without needing to either over... | 4bdae2e004b29d075f96a7dbbee918f7dfb13ed1 | {
"head_commit": "bf4259a8d61c2737260c854a33dba857a6f3ce53",
"head_commit_message": "Tick label font family via tick_params",
"patch_to_review": "diff --git a/doc/users/next_whats_new/tick_labelfont_param.rst b/doc/users/next_whats_new/tick_labelfont_param.rst\nnew file mode 100644\nindex 000000000000..b7d9877f54... | [
{
"diff_hunk": "@@ -0,0 +1,8 @@\n+Allow setting the tick label fonts with a keyword argument\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+``Axes.tick_params`` now accepts a *labelfontfamily* keyword that changes the tick\n+label font separately from the rest of the text objects:\n+\n+.. code-b... | 76ec4818c2f0c07eabedb9c60b57802f3d74600c | diff --git a/doc/users/next_whats_new/tick_labelfont_param.rst b/doc/users/next_whats_new/tick_labelfont_param.rst
new file mode 100644
index 000000000000..66dd25a5006f
--- /dev/null
+++ b/doc/users/next_whats_new/tick_labelfont_param.rst
@@ -0,0 +1,8 @@
+Allow setting the tick label fonts with a keyword argument
+~~~~... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-25624@009415f | matplotlib/matplotlib | Python | 25,624 | FIX: correctly unset the layout engine in Figure.tight_layout |
## PR Summary
closes #7805
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**Documentation and Tests**
- [x] Has pytest style unit tests (and `pytest` passes)
- [na] Documentation is sphinx and numpydoc compliant (the docs should [build](https://matplotlib.or... | 2023-04-05T13:35:00Z | tight layout kwargs have no effect if rc autolayout setting is set (MPL 1.5.3)
### Bug report
**Bug summary**
kwargs passed to tight layout do not have an effect if rc the figure.autolayout setting is set
**Code for reproduction**
No padding is inserted in the following example if figure.autolayout is set t... | This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatic... | [
{
"body": "### Bug report\r\n\r\n**Bug summary**\r\n\r\nkwargs passed to tight layout do not have an effect if rc the figure.autolayout setting is set\r\n\r\n**Code for reproduction**\r\n\r\nNo padding is inserted in the following example if figure.autolayout is set to True in the rc\r\n\r\n```python\r\nimport ... | 8ca75e445d136764bbc28d8db7346c261e8c6c41 | {
"head_commit": "009415f3ebe1087f13a0acfda02734874b1e8d39",
"head_commit_message": "FIX: correctly unset the layout engine in Figure.tight_layout\n\ncloses #7805",
"patch_to_review": "diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py\nindex 926944e5a577..32c5388592d0 100644\n--- a/lib/matplotlib/f... | [
{
"diff_hunk": "@@ -659,6 +659,15 @@ def test_invalid_layouts():\n fig.set_layout_engine(\"constrained\")\n \n \n+@check_figures_equal(extensions=[\"png\"])\n+def test_tightlayout_autolayout_deconfilct(fig_test, fig_ref):",
"line": null,
"original_line": 663,
"original_start_line": null,
... | 02014be44efa100f6b345c453de8834b59dacc5c | diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
index 926944e5a577..32c5388592d0 100644
--- a/lib/matplotlib/figure.py
+++ b/lib/matplotlib/figure.py
@@ -3515,7 +3515,7 @@ def tight_layout(self, *, pad=1.08, h_pad=None, w_pad=None, rect=None):
and previous_engine is not None:
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
kornia__kornia-1809@689b4b4 | kornia/kornia | Python | 1,809 | fix tests float16 module losses | #### Changes
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
<!-- List any dependencies that are required for this change. -->
Fixes #1805
#### Type of change
<!-- Please delete options that are not relevant. -->
- [ ] ... | 2022-07-27T21:42:05Z | Configure `rtol` and `atol` parameters to pass tests on the `losses` module
## 🚀 Feature
When running tests using `float16` and `cuda` in `losses` module, errors occurs.
`pytest test/losses -v --dtype=float16 --device=cuda`
```================================================================================... | @MrShevan probably need a mechanism in the Test class that chooses the tolerance based on the precision ?
I started this initiative some time ago but never had the chance to implement it across the library
https://github.com/kornia/kornia/blob/master/kornia/testing/__init__.py#L78
worth to explore adding that fun... | [
{
"body": "## 🚀 Feature\r\n\r\nWhen running tests using `float16` and `cuda` in `losses` module, errors occurs.\r\n\r\n `pytest test/losses -v --dtype=float16 --device=cuda`\r\n \r\n ```========================================================================================= short test summary info ===========... | cd6e667a1a9966898a72b8f59b5f2f9ab96ca0ff | {
"head_commit": "689b4b4a652975fca7331dfb032e7eaa21ff503b",
"head_commit_message": "add `assert_close` method to BaseTester",
"patch_to_review": "diff --git a/kornia/testing/__init__.py b/kornia/testing/__init__.py\nindex 426518dd19..c82bbfdb0d 100644\n--- a/kornia/testing/__init__.py\n+++ b/kornia/testing/__ini... | [
{
"diff_hunk": "@@ -961,8 +961,33 @@ def test_random_vflip_coord_check(self, device, dtype):\n == input[..., input_coordinates[0, 1, :], input_coordinates[0, 0, :]]\n ).all()\n \n+ @pytest.mark.skip(reason=\"not implemented yet\")\n+ @pytest.mark.nn",
"line": null,
"original_li... | 947a84d8b9c6b83715d69ddf1e4a33446989a51b | diff --git a/kornia/testing/__init__.py b/kornia/testing/__init__.py
index 426518dd19..6c144a97f4 100644
--- a/kornia/testing/__init__.py
+++ b/kornia/testing/__init__.py
@@ -1,6 +1,7 @@
"""The testing package contains testing-specific utilities."""
import contextlib
import importlib
+import math
from abc import AB... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
kornia__kornia-1571@65ef791 | kornia/kornia | Python | 1,571 | [fix] RandomCrop fix and improvement | Fixes #1569
1. fix `keepdim` bug
2. improve `same_on_batch` for slicing in a loop | 2022-02-09T15:18:55Z | keepdim=True in RandomCrop not working
### Describe the bug
Setting `keepdim=True` in `RandomCrop()` has no effect. The batch dim is added either way.
### Reproduction steps
```bash
1. Initialize RandomCrop with keepdim=True
2. Transform a C,H,W tensor
```
### Expected behavior
Expected: Receive 3D tensor
Actua... | Thanks for reporting. Fixed in #1571 | [
{
"body": "### Describe the bug\n\nSetting `keepdim=True` in `RandomCrop()` has no effect. The batch dim is added either way.\n\n### Reproduction steps\n\n```bash\n1. Initialize RandomCrop with keepdim=True\r\n2. Transform a C,H,W tensor\n```\n\n\n### Expected behavior\n\nExpected: Receive 3D tensor\r\nActual: ... | fe17f46c2239e3bb0c360a7c40ea1217e9355384 | {
"head_commit": "65ef7911d5a62a5bb23a1d75758c016684035ba1",
"head_commit_message": "Update kornia/augmentation/_2d/geometric/crop.py",
"patch_to_review": "diff --git a/kornia/augmentation/_2d/geometric/center_crop.py b/kornia/augmentation/_2d/geometric/center_crop.py\nindex cf524b33d6..1693708575 100644\n--- a/k... | [
{
"diff_hunk": "@@ -110,14 +110,17 @@ def apply_transform(\n if self.flags[\"cropping_mode\"] == \"slice\": # uses advanced slicing to crop\n # TODO: implement as separated function `crop_and_resize_iterative`\n B, C, _, _ = input.shape\n- H, W = self.size\n- ... | 24d05081268d0253e3cffd1ab87ad31b582ddb12 | diff --git a/kornia/augmentation/_2d/geometric/center_crop.py b/kornia/augmentation/_2d/geometric/center_crop.py
index cf524b33d6..f85e41b75d 100644
--- a/kornia/augmentation/_2d/geometric/center_crop.py
+++ b/kornia/augmentation/_2d/geometric/center_crop.py
@@ -110,14 +110,18 @@ def apply_transform(
if self.f... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
kornia__kornia-1765@925cbc2 | kornia/kornia | Python | 1,765 | adding weights to positive examples | #### Changes
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
<!-- List any dependencies that are required for this change. -->
Fixes #1744
#### Type of change
<!-- Please delete options that are not relevant. -->
- [ ] ... | 2022-06-30T15:24:19Z | Improve binary focal loss to trade off recall and precision by adding weights to positive examples like torch.nn.BCEWithLogitsLoss
## 🚀 Feature
Improve binary focal loss to trade off recall and precision by adding weights to positive examples. Just like `pos_weight` parameter in torch.nn.BCEWithLogitsLoss. `pos_weigh... | @xiaoyuan0203 Open to send a PR ?
@xiaoyuan0203 @edgarriba Looks interesting! Can I take it?
@MrShevan sure ! go ahead
> @xiaoyuan0203 Open to send a PR ?
Sorry for reply to you until now. Could you tell me how to do it?
Oh sorry. I see you are interested in creating your own PR. Let me know if it's free
It's f... | [
{
"body": "## 🚀 Feature\r\nImprove binary focal loss to trade off recall and precision by adding weights to positive examples. Just like `pos_weight` parameter in torch.nn.BCEWithLogitsLoss. `pos_weight` must be a vector with length equal to the number of classes.\r\n",
"number": 1744,
"title": "Improv... | c909722c82ec7c4dcc0da80fbd8f0c73176818c6 | {
"head_commit": "925cbc21ce4acaee9f196246a55431170f6ed562",
"head_commit_message": "Update kornia/losses/focal.py\n\nCo-authored-by: Edgar Riba <edgar.riba@gmail.com>",
"patch_to_review": "diff --git a/CHANGELOG.md b/CHANGELOG.md\nindex aec6a26936..5397043a02 100644\n--- a/CHANGELOG.md\n+++ b/CHANGELOG.md\n@@ -1... | [
{
"diff_hunk": "@@ -157,6 +157,7 @@ def binary_focal_loss_with_logits(\n gamma: float = 2.0,\n reduction: str = 'none',\n eps: Optional[float] = None,\n+ pos_weight: Optional[torch.Tensor] = None,",
"line": null,
"original_line": 160,
"original_start_line": null,
"path": "kornia/l... | 3bcea7ba82ccbccaaebfe5f7c56e620356f0a3f0 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index aec6a26936..5397043a02 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add Lovasz-Hinge/Softmax losses (#1682)
- Add `adjust_sigmoid` and `adjust_log` initial implementation... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
kornia__kornia-1521@7998a41 | kornia/kornia | Python | 1,521 | Fix #1520 | #### Changes
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
<!-- List any dependencies that are required for this change. -->
Fixes # (issue)
#### Type of change
<!-- Please delete options that are not relevant. -->
- ... | 2022-01-07T17:42:15Z | Padding error with `RandomCrop`
### Describe the bug
Tests are failing because of the following test `TestAugmentationSequential::test_random_crops` possibly introduced by the combination of be104a5 and 3f8e7a3.
Output error:
```python
if mode.startswith("vertices"):
batched = boxes.ndim == 4
... | [
{
"body": "### Describe the bug\n\nTests are failing because of the following test `TestAugmentationSequential::test_random_crops` possibly introduced by the combination of be104a5 and 3f8e7a3.\r\n\r\nOutput error:\r\n\r\n```python\r\n if mode.startswith(\"vertices\"):\r\n batched = boxes.ndim == 4\r... | 406f03aa3da709dddeee4a6992a1158d2054fc63 | {
"head_commit": "7998a41ddb429228266e12932ea0dfce7669de7d",
"head_commit_message": "update",
"patch_to_review": "diff --git a/kornia/augmentation/container/augment.py b/kornia/augmentation/container/augment.py\nindex ef5f9c80ea..1060c0efd8 100644\n--- a/kornia/augmentation/container/augment.py\n+++ b/kornia/augm... | [
{
"diff_hunk": "@@ -269,38 +269,58 @@ class BBoxApplyInverse(ApplyInverseImpl):\n This is for transform boxes in the format (B, N, 4, 2).\n \"\"\"\n \n- apply_func = partial(transform_bbox, mode=\"xyxy\", restore_coordinates=True)\n-\n-\n-class BBoxXYXYApplyInverse(ApplyInverseImpl):\n- \"\"\"Appl... | 562f4f618a6f3afdf23b549a3ee9c7d15e157f2c | diff --git a/kornia/augmentation/container/augment.py b/kornia/augmentation/container/augment.py
index ef5f9c80ea..bf0160e709 100644
--- a/kornia/augmentation/container/augment.py
+++ b/kornia/augmentation/container/augment.py
@@ -181,11 +181,17 @@ def inverse( # type: ignore
"""
if data_keys is None... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
kornia__kornia-1375@c1a28ba | kornia/kornia | Python | 1,375 | Add more border_type options for filter2D | #### Changes
Fixes #973
Added valid padding option as requested in #973.
Added tests for the same.
#### Type of change
<!-- Please delete options that are not relevant. -->
- [x] 🧪 Tests Cases
- [x] 🔬 New feature (non-breaking change which adds functionality)
- [x] 📝 This change requires a documentati... | 2021-10-11T06:29:36Z | Add more border_type options for filter2D
## 🚀 Feature
1. For filter2D, add border_types that are provided by **filter2** of **Matlab**.
For example, border_type of 'valid':
```
% 'valid' - returns only those parts of the correlation
% that are computed without the zero-pad... | If I understand it right, 'valid' should not be a ```border_type``` here but a padding strategy similar to tensorflow's ```valid padding``` and ```same padding```. Meanwhile, what has been implemented in kornia is the ```same padding```? If everything above is correct, I think the ```valid padding``` could be a good fe... | [
{
"body": "## 🚀 Feature\r\n1. For filter2D, add border_types that are provided by **filter2** of **Matlab**.\r\n For example, border_type of 'valid':\r\n ```\r\n % 'valid' - returns only those parts of the correlation\r\n % that are computed without the zero-padded\r\n ... | bb6a67825ec2475e118459707f6095f132ab9024 | {
"head_commit": "c1a28bada60df864b61df82cf49ddad6e235dc54",
"head_commit_message": "Implemented feature requested in issue #973\nAdded tests for the same",
"patch_to_review": "diff --git a/kornia/filters/filter.py b/kornia/filters/filter.py\nindex 15d2f2e530..c5aac40b83 100644\n--- a/kornia/filters/filter.py\n++... | [
{
"diff_hunk": "@@ -93,19 +99,24 @@ def filter2d(\n \n tmp_kernel = tmp_kernel.expand(-1, c, -1, -1)\n \n- # pad the input tensor\n height, width = tmp_kernel.shape[-2:]\n- padding_shape: List[int] = _compute_padding([height, width])\n- input_pad: torch.Tensor = F.pad(input, padding_shape, mode... | a3fb589ac0f42851d6335c532bc288ea4f19486e | diff --git a/kornia/filters/filter.py b/kornia/filters/filter.py
index 15d2f2e530..051469630d 100644
--- a/kornia/filters/filter.py
+++ b/kornia/filters/filter.py
@@ -31,7 +31,8 @@ def _compute_padding(kernel_size: List[int]) -> List[int]:
def filter2d(
- input: torch.Tensor, kernel: torch.Tensor, border_type: ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-24655@17fac2e | matplotlib/matplotlib | Python | 24,655 | Update font_manager to only use registry on Win | * Follow-up on https://github.com/matplotlib/matplotlib/pull/24641, which introduces a bug (fonts are added regardless of their extension).
* Undoes https://github.com/matplotlib/matplotlib/pull/22909 and implements another way to fix https://github.com/matplotlib/matplotlib/issues/22859: don't scrape dirs with `list_... | 2022-12-07T13:49:51Z | [Bug]: findSystemFonts should not look in subdirectories of C:\Windows\Fonts\
### Bug summary
findSystemFonts takes the font in the directory: C:\Windows\Fonts\Deleted
It should not take them. They are supposedly deleted. It is better to ignore them.
### Code for reproduction
```python
matplotlib.font_manager.fin... | Do you have a reference documenting this directory? Thanks.
No, I don't have any reference. I actually search on the web and I was surprised to find nothing about that.
If you want to access to the folder, write `\\localhost\c$\Windows\Fonts` in your Windows File Explorer.
My point is that if there is no documentat... | [
{
"body": "### Bug summary\n\nfindSystemFonts takes the font in the directory: C:\\Windows\\Fonts\\Deleted\r\n\r\nIt should not take them. They are supposedly deleted. It is better to ignore them.\n\n### Code for reproduction\n\n```python\nmatplotlib.font_manager.findSystemFonts\n```\n\n\n### Actual outcome\n\n... | 1bb68a8c8737708e9c1f269a80fcbf8adb1aeb79 | {
"head_commit": "17fac2e67157a9c30ff1d9839fad7d09c3b53c4f",
"head_commit_message": "DOC: add behavior change note for only considering fonts in registry",
"patch_to_review": "diff --git a/doc/api/next_api_changes/behavior/24655-AK.rst b/doc/api/next_api_changes/behavior/24655-AK.rst\nnew file mode 100644\nindex ... | [
{
"diff_hunk": "@@ -0,0 +1,14 @@\n+On windows only fonts known to the registry will be discovered\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Previously, Matplotlib would recursively walk user and system font directories\n+to discover fonts, however this lead to a number of undesirable... | dfec6b309d29e2250c3b19ea2d1ffcbe90cd9668 | diff --git a/doc/api/next_api_changes/behavior/24655-AK.rst b/doc/api/next_api_changes/behavior/24655-AK.rst
new file mode 100644
index 000000000000..04b4141e4517
--- /dev/null
+++ b/doc/api/next_api_changes/behavior/24655-AK.rst
@@ -0,0 +1,15 @@
+On Windows only fonts known to the registry will be discovered
+~~~~~~~~... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-24627@146b478 | matplotlib/matplotlib | Python | 24,627 | MNT: when clearing an Axes via clear/cla fully detach children | Reset the Axes and Figure of the children to None to help break cycles.
Closes #6982
## PR Summary
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**Documentation and Tests**
- [x] Has pytest style unit tests (and `pytest` passes)
I do not think this needs... | 2022-12-05T00:05:54Z | cla(), clf() should unset the `.axes` and `.figure` attributes of deparented artists
mpl2.0b3: Removing an artist from its axes unsets its `.axes` attribute, but clearing the axes does not do so.
```
In [11]: f, a = plt.subplots(); l, = a.plot([1, 2]); l.remove(); print(l.axes)
None
In [12]: f, a = plt.subplots(); l,... | [
{
"body": "mpl2.0b3: Removing an artist from its axes unsets its `.axes` attribute, but clearing the axes does not do so.\n\n```\nIn [11]: f, a = plt.subplots(); l, = a.plot([1, 2]); l.remove(); print(l.axes)\nNone\n\nIn [12]: f, a = plt.subplots(); l, = a.plot([1, 2]); a.cla(); print(l.axes)\nAxes(0.125,0.11;0... | 9d22ab09d52d279b125d8770967569de070913b2 | {
"head_commit": "146b478cc16e648fbd3e3f5629a4b9fed0e53b0d",
"head_commit_message": "MNT: compress swap to one line",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py\nindex 574310ea763a..4ea2b2433706 100644\n--- a/lib/matplotlib/axes/_base.py\n+++ b/lib/matplotlib/axes... | [
{
"diff_hunk": "@@ -8359,6 +8359,19 @@ def test_extent_units():\n im.set_extent([2, 12, date_first, date_last], clip=False)\n \n \n+def test_cla_clears_chlidren_axes_and_fig():",
"line": null,
"original_line": 8362,
"original_start_line": null,
"path": "lib/matplotlib/tests/test_axes.py"... | c77fa4c05b52481062c60d5b26a88ceadd753674 | diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
index 574310ea763a..4ea2b2433706 100644
--- a/lib/matplotlib/axes/_base.py
+++ b/lib/matplotlib/axes/_base.py
@@ -1315,7 +1315,9 @@ def __clear(self):
self._get_patches_for_fill = _process_plot_var_args(self, 'fill')
self._grid... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
matplotlib__matplotlib-24397@e2131bb | matplotlib/matplotlib | Python | 24,397 | Simplify appveyor to only use conda | Closes #24394
## PR Summary
Avoid mixing conda and pip (except for those pip dependencies in the environment.yml)
Should fix appveyor tests failing due to pip pywin32 version.
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**Tests and Styling**
- [x] Has pytest style unit... | 2022-11-08T07:08:49Z | [TST]: Appveyor Qt tests failing
### Summary
Appveyor Qt sigint tests appear to be consistently failing due DLL loading
<details>
<summary> Relevant log portion</summary>
```
__________________________ test_sigint[show-kwargs0] __________________________
[gw0] win32 -- Python 3.8.13 C:\Miniconda3-x64\envs\t... | Full log: https://ci.appveyor.com/project/matplotlib/matplotlib/builds/45303213/job/p0makskomsa3rssy
Neither Qt or PyQt had releases on conda-forge in the last few days which was my first guess at what is going wrong.
Sorry I miss-read these logs on #24380 .
https://www.appveyor.com/updates/2022/11/07/
Probably r... | [
{
"body": "### Summary\n\nAppveyor Qt sigint tests appear to be consistently failing due DLL loading\r\n\r\n<details>\r\n<summary> Relevant log portion</summary>\r\n\r\n\r\n```\r\n__________________________ test_sigint[show-kwargs0] __________________________\r\n[gw0] win32 -- Python 3.8.13 C:\\Miniconda3-x64\\... | 9d8fde258d66168f20800155af614c8ca0bb8e24 | {
"head_commit": "e2131bb26e9c60bbb823f74dbb5e6de03ba43ee0",
"head_commit_message": "Just skip memleak test on windows entirely",
"patch_to_review": "diff --git a/.appveyor.yml b/.appveyor.yml\nindex df7536f16c7e..0ed198d8f359 100644\n--- a/.appveyor.yml\n+++ b/.appveyor.yml\n@@ -18,17 +18,14 @@ environment:\n ... | [
{
"diff_hunk": "@@ -4,14 +4,20 @@\n import matplotlib\n import pytest\n \n-# Get the names of all matplotlib submodules, except for the unit tests.\n-module_names = [m.name for m in walk_packages(path=matplotlib.__path__,\n- prefix=f'{matplotlib.__name__}.')\n- ... | 518416a5ac281fb1cce0919206acf0bfa548202a | diff --git a/.appveyor.yml b/.appveyor.yml
index df7536f16c7e..0ed198d8f359 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -18,17 +18,14 @@ environment:
PYTHONIOENCODING: UTF-8
PYTEST_ARGS: -raR --numprocesses=auto --timeout=300 --durations=25
--cov-report= --cov=lib --log-level=DEBUG
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Test Suite / CI Enhancements"
} |
kornia__kornia-1102@8897521 | kornia/kornia | Python | 1,102 | [Feat] Stereo camera class | ### Description
Added a StereoCamera class that allows users to reproject a disparity tensor to a point cloud as discussed in #836 .
I have many ideas for a stereo module and more functionality in the future, but wanted to get the setup and interface created first.
Let me know where to add these ideas to the ro... | 2021-06-13T17:28:30Z | [Feature request] StereoCamera model and OpenCV initializations
## 🚀 Feature
For Stereo Vision tasks it would be handy to have a `StereoCamera` model which can be initialized with two `kornia.geometry.camera.PinholeCamera` and the stereo calibration. The `StereoCamera` can have some handy methods such as `StereoCamer... | @copaah this sounds like a really good contribution idea. Could you sketch a bit the shape of this API before implementing ? If I'm not wrong `calibrateCamera` and `stereoCalibrate` just return the estimated intrinsics/extrinsics. Why then a method called `from_OpenCV_calibration` ? the API could just consume those te... | [
{
"body": "## 🚀 Feature\r\nFor Stereo Vision tasks it would be handy to have a `StereoCamera` model which can be initialized with two `kornia.geometry.camera.PinholeCamera` and the stereo calibration. The `StereoCamera` can have some handy methods such as `StereoCamera.get_disparity_from_depth` and `StereoCame... | 7d01c502af02ef53168f843a6c9e9a7145ca2195 | {
"head_commit": "889752156472cb07138fd6005c2f9c4dee6bf081",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/docs/source/geometry.camera.rst b/docs/source/geometry.camera.rst\nindex 0e5423cf11..d57e5... | [
{
"diff_hunk": "@@ -0,0 +1,287 @@\n+import torch\n+\n+\n+class StereoException(Exception):\n+ def __init__(self, msg, *args, **kwargs):",
"line": null,
"original_line": 5,
"original_start_line": null,
"path": "kornia/geometry/camera/stereo.py",
"start_line": null,
"text": "@user1:\n``... | 464196dbcc8861e4850461acf62bf816c0a68351 | diff --git a/docs/source/geometry.camera.rst b/docs/source/geometry.camera.rst
index 0e5423cf11..d57e51440a 100644
--- a/docs/source/geometry.camera.rst
+++ b/docs/source/geometry.camera.rst
@@ -8,3 +8,4 @@ kornia.geometry.camera
geometry.camera.pinhole
geometry.camera.perspective
+ geometry.camera.stereo
d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-24238@cb0a6a0 | matplotlib/matplotlib | Python | 24,238 | Update example and docstring to encourage the use of functools.partial in FuncAnimation | ## PR Summary
Fixes #20326
Closes #20358
Closes #24139
Merged contents from #20358 and #24139 with comments. Probably have missed something...
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**Tests and Styling**
- [ ] Has pytest style unit tests (and `pytest` ... | 2022-10-21T08:29:18Z | FuncAnimation Named Arguments
### Problem
I would like to use named arguments in FuncAnimation.
Currently:
```
ani = matplotlib.animation.FuncAnimation(
fig, update, frames=len(raw_history),
interval=500, repeat=True, repeat_delay=1,
fargs=(raw_history, action_history, style)
)
```
This would be sli... | I don't particularly like `fargs` to begin with (I prefer functools.partial), but given that it's here, adding fkwargs seems reasonable.
So why don‘t we discourage fargs and advertise partial instead, including the note that you can use kwargs there?
That works for me too.
This would just require adding fkwargs as keyw... | [
{
"body": "### Problem\r\n\r\nI would like to use named arguments in FuncAnimation.\r\n\r\nCurrently:\r\n```\r\nani = matplotlib.animation.FuncAnimation(\r\n fig, update, frames=len(raw_history),\r\n interval=500, repeat=True, repeat_delay=1,\r\n fargs=(raw_history, action_history, style)\r\n)\r\n```\r\nThis... | f15aeee5e8d380c2ea04bcbed202a8940a7db1d0 | {
"head_commit": "cb0a6a0558b7543e6d6914649934a4e768f425f0",
"head_commit_message": "Apply suggestions from code review\n\nCo-authored-by: Thomas A Caswell <tcaswell@gmail.com>",
"patch_to_review": "diff --git a/doc/api/animation_api.rst b/doc/api/animation_api.rst\nindex 132590456763..13b0acf026c2 100644\n--- a/... | [
{
"diff_hunk": "@@ -133,8 +133,37 @@ artist at a global scope and let Python sort things out. For example ::\n init_func=init, blit=True)\n plt.show()\n \n-The second method is to use `functools.partial` to 'bind' artists to\n-function. A third method is to use closures to build up t... | d97cc32411df85c4ce5055829948eb90f49b3656 | diff --git a/doc/api/animation_api.rst b/doc/api/animation_api.rst
index 132590456763..d1b81e20b5c8 100644
--- a/doc/api/animation_api.rst
+++ b/doc/api/animation_api.rst
@@ -108,7 +108,7 @@ this means that the callable objects you pass in must know what
artists they should be working on. There are several approaches... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
kornia__kornia-967@707c0e7 | kornia/kornia | Python | 967 | Implement fast version of crop function in augmentations | ### Description
Fixes #966
### Status
**Ready/Work in progress/Hold**
### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not applicable items -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Breaking change (fix or new feature that would cause existing func... | 2021-04-16T19:38:18Z | Slower than new PyTorch GPU transformations
## ❓ Questions and Help
Kornia's augmentations seem to be slower than PyTorch's one. The dataset I am using is CelebA.
I have:
OS: Ubuntu 20.04
GPU: 1080ti
PyTorch: 1.8.0
torchvision: 0.9.0
```python
from torchvision.io import read_image
from torchvision.data... | Hi @FrancescoSaverioZuppichini,
Thank you for reporting. Torchvision implemented the RandomCrop and related in a non-differentiable way, while Kornia is not.
We are aware of the timing issue that brought by the differentiable cropping implementation, and we are planning on incorporating the non-differentiable implem... | [
{
"body": "## ❓ Questions and Help\r\nKornia's augmentations seem to be slower than PyTorch's one. The dataset I am using is CelebA.\r\n\r\nI have:\r\n\r\nOS: Ubuntu 20.04\r\nGPU: 1080ti\r\nPyTorch: 1.8.0\r\ntorchvision: 0.9.0\r\n\r\n```python\r\n\r\nfrom torchvision.io import read_image\r\nfrom torchvision.dat... | 9e0facf308ad92ccd83b79666a33f84a86c09ce9 | {
"head_commit": "707c0e7281f5e9dc7ac365c4dab68db8c3fc76dc",
"head_commit_message": "implement indexing random resize crop",
"patch_to_review": "diff --git a/kornia/augmentation/augmentation.py b/kornia/augmentation/augmentation.py\nindex 88e9f98c97..e5124c924e 100644\n--- a/kornia/augmentation/augmentation.py\n+... | [
{
"diff_hunk": "@@ -884,7 +891,26 @@ def compute_transformation(self, input: torch.Tensor, params: Dict[str, torch.Te\n return F.compute_crop_transformation(input, params, self.flags)\n \n def apply_transform(self, input: torch.Tensor, params: Dict[str, torch.Tensor]) -> torch.Tensor:\n- retu... | 32b59b8fa54de8a8fd113329af1d39f0bcc764b7 | diff --git a/kornia/augmentation/augmentation.py b/kornia/augmentation/augmentation.py
index 5df842b198..8e35980e38 100644
--- a/kornia/augmentation/augmentation.py
+++ b/kornia/augmentation/augmentation.py
@@ -38,6 +38,7 @@
)
from kornia.utils import _extract_device_dtype
from kornia.enhance.normalize import normal... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
kornia__kornia-896@c8bb639 | kornia/kornia | Python | 896 | Fixes warp_affine and warp_perspective | ### Description
This PR fixes known issues around warp_affine and warp_perspective. Fixes https://github.com/kornia/kornia/issues/747
The main issue is with align_corners - basically in order to match opencv it needs to be set by default to True.
- [x] Fix warp affine and add tests
- [x] Fix warp perspective ... | 2021-03-06T20:31:14Z | [Bug] warp_perspective does not return the input if used with identity matrix
## 🐛 Bug
The output of `kornia.geometry.warp_perspective` does not equal the input if the identity matrix is used.
## To Reproduce
Steps to reproduce the behavior:
```python
import torch
from kornia.geometry import warp_perspec... | @pmeier I can confirm that happens the same in 0.4.0, 0.3.2, 0.3.1 but no in 0.3.0
@pmeier `align_corners` should be set to `True` - this change was introduced in https://github.com/kornia/kornia/pull/574
See: https://github.com/kornia/kornia/blob/master/kornia/geometry/transform/imgwarp.py#L48 it's now set False by... | [
{
"body": "## 🐛 Bug\r\n\r\nThe output of `kornia.geometry.warp_perspective` does not equal the input if the identity matrix is used.\r\n\r\n## To Reproduce\r\n\r\nSteps to reproduce the behavior:\r\n\r\n```python\r\nimport torch\r\nfrom kornia.geometry import warp_perspective\r\n\r\ntorch.manual_seed(0)\r\n\r\... | 77cbfa05b9ca2b7e9b97f509db16fd799764e4d0 | {
"head_commit": "c8bb639fa33748afb0b438692a9815b8b6a73213",
"head_commit_message": "remove DeprecationWarning type from warnings",
"patch_to_review": "diff --git a/kornia/geometry/transform/imgwarp.py b/kornia/geometry/transform/imgwarp.py\nindex d828efa4e9..db67e4fe4e 100644\n--- a/kornia/geometry/transform/img... | [
{
"diff_hunk": "@@ -65,7 +54,7 @@ def warp_perspective(src: torch.Tensor, M: torch.Tensor, dsize: Tuple[int, int],\n 'bilinear' | 'nearest'. Default: 'bilinear'.\n border_mode (str): padding mode for outside grid values\n 'zeros' | 'border' | 'reflection'. Default: 'zeros'.\n- ... | 151efcfa6d98487b986749e2c793ea559e4dbd94 | diff --git a/kornia/augmentation/augmentation.py b/kornia/augmentation/augmentation.py
index 2dd20d91a3..9203b39881 100644
--- a/kornia/augmentation/augmentation.py
+++ b/kornia/augmentation/augmentation.py
@@ -838,9 +838,9 @@ class RandomResizedCrop(AugmentationBase2D):
... [6., 7., 8.... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-24111@3f99c20 | matplotlib/matplotlib | Python | 24,111 | FIX: add missing method to ColormapRegistry | ## PR Summary
After putting pending deprecations on `cm.get_cmap` we discovered that downstream libraries (pandas) were using the deprecated method to normalize between `None` (to get the default colormap), strings, and Colormap instances. This adds a method to `ColormapRegistry` to do this normalization.
This ca... | 2022-10-06T22:09:31Z | [ENH]: Default `matplotlib.colormaps[None]` to call `matplotlib.colormaps[matplotlib.rcParams['image.cmap']]`?
### Problem
While addressing the `matplotlib.cm.get_cmap` deprecation in 3.6:
```
PendingDeprecationWarning: The get_cmap function will be deprecated in a future version. Use ``matplotlib.colormaps[name]`... | If folks agree it's a regression error (& I think it kinda is) the fix is I think add something like
```python
if item is None:
item = mpl.rcParams['image.cmap']
```
which is a direct port of the `get_cmap` code
https://github.com/matplotlib/matplotlib/blob/a152851669b9df06302d3a133c7413b863f00283/lib/... | [
{
"body": "### Problem\n\nWhile addressing the `matplotlib.cm.get_cmap` deprecation in 3.6:\r\n\r\n```\r\nPendingDeprecationWarning: The get_cmap function will be deprecated in a future version. Use ``matplotlib.colormaps[name]`` instead.\r\n```\r\nI noticed that `None` isn't directly migrate-able \r\n\r\n```\r... | 239386650a2c3a537d36de9cd85d09bd0f6796cf | {
"head_commit": "3f99c20e649fd0d533332ee4e3b4102e07d0b7f2",
"head_commit_message": "DOC: remove note about ColormapRegistry being experimental\n\nWe are committed now!",
"patch_to_review": "diff --git a/doc/api/prev_api_changes/api_changes_3.6.0/deprecations.rst b/doc/api/prev_api_changes/api_changes_3.6.0/depre... | [
{
"diff_hunk": "@@ -193,6 +187,39 @@ def unregister(self, name):\n \"colormap.\")\n self._cmaps.pop(name, None)\n \n+ def get_cmap(self, cmap):\n+ \"\"\"\n+ Ensure that at given object is a converted to a color map.\n+\n+ If *cmap* in `None`, returns ... | 4f8ece457ba0d979813d6e992c3d6562cd7db2d0 | diff --git a/doc/api/prev_api_changes/api_changes_3.6.0/deprecations.rst b/doc/api/prev_api_changes/api_changes_3.6.0/deprecations.rst
index d59077d2b2d2..3a9e91e12289 100644
--- a/doc/api/prev_api_changes/api_changes_3.6.0/deprecations.rst
+++ b/doc/api/prev_api_changes/api_changes_3.6.0/deprecations.rst
@@ -52,7 +52,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-23987@5efddd3 | matplotlib/matplotlib | Python | 23,987 | FIX: do not set constrained layout on false-y values |
## PR Summary
closes #23986
While fixing this I discovered that `plt.figure(..., constrained_layout={})` can take a dictionary but that is not documented. Given that it is discouraged, I did not document this feature, but added a test and decided that an empty dictionary should be "True" for this purpose.
#... | 2022-09-22T21:39:02Z | [Bug]: Constrained layout UserWarning even when False
### Bug summary
When using layout settings such as `plt.subplots_adjust` or `bbox_inches='tight`, a UserWarning is produced due to incompatibility with constrained_layout, even if constrained_layout = False. This was not the case in previous versions.
### Code... | Yup, that is indeed a bug https://github.com/matplotlib/matplotlib/blob/e98d8d085e8f53ec0467422b326f7738a2dd695e/lib/matplotlib/figure.py#L2428-L2431
PR on the way.
@VanWieren Did you mean to close this? We normally keep bugs open until the PR to fix it is actually merged.
> @VanWieren Did you mean to close this? ... | [
{
"body": "### Bug summary\r\n\r\nWhen using layout settings such as `plt.subplots_adjust` or `bbox_inches='tight`, a UserWarning is produced due to incompatibility with constrained_layout, even if constrained_layout = False. This was not the case in previous versions.\r\n\r\n### Code for reproduction\r\n\r\n``... | e98d8d085e8f53ec0467422b326f7738a2dd695e | {
"head_commit": "5efddd3db6dbef5284b66ef13ec617067f6697e0",
"head_commit_message": "FIX: do not set constrained layout on false-y values\n\ncloses #23986",
"patch_to_review": "diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py\nindex 5bbb786984d2..447f508194a1 100644\n--- a/lib/matplotlib/figure.py... | [
{
"diff_hunk": "@@ -656,3 +656,14 @@ def test_compressed1():\n pos = axs[1, 2].get_position()\n np.testing.assert_allclose(pos.x1, 0.8618, atol=1e-3)\n np.testing.assert_allclose(pos.y0, 0.1934, atol=1e-3)\n+\n+\n+@pytest.mark.parametrize('arg, state', [\n+ (True, True),\n+ (False, False),\n+ ... | fe1aed2b85753b573c702ee71798f61a42a6efba | diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
index 5bbb786984d2..447f508194a1 100644
--- a/lib/matplotlib/figure.py
+++ b/lib/matplotlib/figure.py
@@ -2426,9 +2426,12 @@ def __init__(self,
if isinstance(tight_layout, dict):
self.get_layout_engine().set(**tight_layout)
... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-23947@023d0c6 | matplotlib/matplotlib | Python | 23,947 | Fix building on MINGW | ## PR Summary
Fix building matplotlib on MINGW. Recent changes in https://github.com/matplotlib/matplotlib/commit/e1fcc90c13b037da1501aa53b3491d27081598ca broke it.
Fixes #23943
## PR Checklist
**Tests and Styling**
- [ ] Has pytest style unit tests (and `pytest` passes).
- [ ] Is [Flake 8](https://flake8... | 2022-09-19T08:00:56Z | [Bug]: Couldn't build matplotlib 3.6.0 with both Clang-15 and GCC-12
### Bug summary
It fails to build with Clang-15 and GCC-12
Clang:
```
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -march=x86-64 -mtune=generic -O2 -pipe -O3 -march=x86-64 -mtune=generic -O2 -pipe -O3 ... | I have been compiling in linux with gcc 12 without a problem.
It seems that `FARPROC` is a windows thing: https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-callwindowprocw
@MehdiChinoune Do you understand what changed in gcc / clang to make this code fail? Do we need a windows specific versi... | [
{
"body": "### Bug summary\n\nIt fails to build with Clang-15 and GCC-12\r\nClang:\r\n```\r\n clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -march=x86-64 -mtune=generic -O2 -pipe -O3 -march=x86-64 -mtune=generic -O2 -pipe -O3 -march=x86-64 -mtune=generic -O2 -pipe -D_... | 3c615b5b9de388ce7225a0ef06da37dd2e60650d | {
"head_commit": "023d0c6af0f461b6c93aee29638b36a5b28dd69a",
"head_commit_message": "Fix building on MINGW",
"patch_to_review": "diff --git a/src/_tkagg.cpp b/src/_tkagg.cpp\nindex bbca8e8d066c..86d54ca61c30 100644\n--- a/src/_tkagg.cpp\n+++ b/src/_tkagg.cpp\n@@ -231,13 +231,13 @@ bool load_tcl_tk(T lib)\n {\n ... | [
{
"diff_hunk": "@@ -231,13 +231,13 @@ bool load_tcl_tk(T lib)\n {\n // Try to fill Tcl/Tk global vars with function pointers. Return whether\n // all of them have been filled.\n- if (void* ptr = dlsym(lib, \"Tcl_SetVar\")) {\n+ if (auto ptr = dlsym(lib, \"Tcl_SetVar\")) {\n TCL_SETVAR = (... | 62058a47afff68f76a89d8905ed931fcf4779165 | diff --git a/src/_tkagg.cpp b/src/_tkagg.cpp
index bbca8e8d066c..663c06fd0474 100644
--- a/src/_tkagg.cpp
+++ b/src/_tkagg.cpp
@@ -231,13 +231,13 @@ bool load_tcl_tk(T lib)
{
// Try to fill Tcl/Tk global vars with function pointers. Return whether
// all of them have been filled.
- if (void* ptr = dlsym(... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-23931@9d61661 | matplotlib/matplotlib | Python | 23,931 | Raise ValueError on negative number inputs for set_aspect | ## PR Summary
This PR fixes the issue where the function set_aspect when given a negative number as a parameter leads to infinite loop (#23847)
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**Tests and Styling**
- [N/A] Has pytest style unit tests (and `pytest` passes... | 2022-09-18T15:38:35Z | [Bug]: set_aspect with negative argument leads to infinite loop
### Bug summary
When calling `plt.gca().set_aspect(-1)` it leads to a infinite loop, where `ValueError: 'box_aspect' and 'fig_aspect' must be positive` repeatedly, until I terminate python.
### Code for reproduction
```python
import matplotlib.pyplot as... | Please provide more info: a full minimal example (the code snippet above does not raise) and the full stack trace.
---
Side note: Possibly someting in the backend/event loop. With Qt backend and an added `plt.show()` I get
```
Traceback (most recent call last):
File "/home/tim/anaconda3/envs/mpl35/lib/pyth... | [
{
"body": "### Bug summary\n\nWhen calling `plt.gca().set_aspect(-1)` it leads to a infinite loop, where `ValueError: 'box_aspect' and 'fig_aspect' must be positive` repeatedly, until I terminate python.\n\n### Code for reproduction\n\n```python\nimport matplotlib.pyplot as plt\r\nplt.plot()\r\nplt.gca().set_as... | 21493c53b110aca458259178ae2aa1fb4b113f94 | {
"head_commit": "9d616615417eac104e12f2915f3fe875177bb2e4",
"head_commit_message": "Update _base.py",
"patch_to_review": "diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py\nindex ebe1ef7911d4..d6d4d301e87e 100644\n--- a/lib/matplotlib/axes/_base.py\n+++ b/lib/matplotlib/axes/_base.py\n@@ -... | [
{
"diff_hunk": "@@ -1680,6 +1680,8 @@ def set_aspect(self, aspect, adjustable=None, anchor=None, share=False):\n aspect = 1\n if not cbook._str_equal(aspect, 'auto'):\n aspect = float(aspect) # raise ValueError if necessary\n+ if aspect<0:",
"line": null,
"ori... | 14662e03ea61095b5b5c6287173d993ac8d6247a | diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
index ebe1ef7911d4..d8c939ed2c43 100644
--- a/lib/matplotlib/axes/_base.py
+++ b/lib/matplotlib/axes/_base.py
@@ -1680,6 +1680,8 @@ def set_aspect(self, aspect, adjustable=None, anchor=None, share=False):
aspect = 1
if not cb... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-23751@cfb27b3 | matplotlib/matplotlib | Python | 23,751 | FIX: show bars when the first location is nan |
## PR Summary
Due to the way we handle units on the bar width having an invalid value in the
first position of the x bar (of y of barh) would effectively poison all of the
widths making all of the bars invisible.
This also renames the cbook function _safe_first_non_none function ->
_safe_first_finite and adj... | 2022-08-26T21:50:36Z | [Bug]: barplot does not show anything when x or bottom start and end with NaN
### Bug summary
I am not sure if this is a bug or an optimization, but in most cases it is fine to plot bars of arrays containing NaN (only the NaN values are not displayed, the rest is ok).
Here I found that when the `x` array or the `bo... | I can reproduce this, but do not understand it yet.
In 7c4b000c423c9e136da52d75ebecdcd312156a8f / https://github.com/matplotlib/matplotlib/pull/12903 we added some logic to make sure that width would work with interesting units, notable time deltas and and datetime data.
To do this we effective add the width to the ... | [
{
"body": "### Bug summary\n\nI am not sure if this is a bug or an optimization, but in most cases it is fine to plot bars of arrays containing NaN (only the NaN values are not displayed, the rest is ok).\r\n\r\nHere I found that when the `x` array or the `bottom` array have NaNs at the extremities, no bar is d... | de98877e3dc45de8dd441d008f23d88738dc015d | {
"head_commit": "cfb27b348139f635325734ff4509e6d67a4b6e54",
"head_commit_message": "FIX: show bars when the first location is nan\n\nDue to the way we handle units on the bar width having an invalid value in the\nfirst position of the x bar (of y of barh) would effectively poison all of the\nwidths making all of t... | [
{
"diff_hunk": "@@ -1715,7 +1715,14 @@ def _safe_first_non_none(obj, skip_none=True):\n supporting both index access and the iterator protocol.\n The first non-None element will be obtained when skip_none is True.\n \"\"\"\n- if skip_none is False:\n+ def safe_isfinite(val):\n+ try:\n+ ... | bbf0cd2610eb253fdfee73276e0a57fb8a28851b | diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
index cb1d4c989c23..205b594e7588 100644
--- a/lib/matplotlib/axes/_axes.py
+++ b/lib/matplotlib/axes/_axes.py
@@ -2179,12 +2179,12 @@ def _convert_dx(dx, x0, xconv, convert):
# removes the units from unit packages like `pint` that
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-23516@ca0b9ea | matplotlib/matplotlib | Python | 23,516 | warning when scatter plot color settings discarded | ## PR Summary
first pr, happy to add/make any necessary changes
closes #23487
The changed test in `test_colorbar.py` was related removing a colorbar from a scatter plot. I don't think the `cmap` there was necessary to test this. And running the tests on my own revealed the `cmap` wasn't changing the color of the s... | 2022-07-29T18:24:47Z | [Bug]: scatter plot color settings discarded unless c given
### Bug summary
When making an animation of a scatter plot, if you don't set `c` (the color value parameter) when initializing the artist, the color settings are ignored.
### Code for reproduction
```python
import matplotlib.animation as animation
import m... | Thank you for diagnosing and reporting this @adamjstewart
> Raise an error/warning if cmap/vmin/vmax are given but c is not
I think this is the better option of the two. It will capture some unintentional usage and I think will be less surprising in the long run.
https://github.com/matplotlib/matplotlib/blo... | [
{
"body": "### Bug summary\n\nWhen making an animation of a scatter plot, if you don't set `c` (the color value parameter) when initializing the artist, the color settings are ignored.\n\n### Code for reproduction\n\n```python\nimport matplotlib.animation as animation\r\nimport matplotlib.pyplot as plt\r\nimpor... | 12d3c8e6389728fe584d395bb5f9635a817d39ac | {
"head_commit": "ca0b9ea8997c8962b41e2f8a348681b53a2afea4",
"head_commit_message": "Fixed tests to look for proper warning message",
"patch_to_review": "diff --git a/doc/api/next_api_changes/behavior/23516-MS.rst b/doc/api/next_api_changes/behavior/23516-MS.rst\nnew file mode 100644\nindex 000000000000..32bdb8a7... | [
{
"diff_hunk": "@@ -0,0 +1,6 @@\n+Warning when scatter plot color settings discarded\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+When making an animation of a scatter plot, if you don't set *c* (the color\n+value parameter) when initializing the artist, the color settings are ignored.\n+`.Axes.scatte... | 586a1a5cb773f7fdbb4afcc99b240d363b29856b | diff --git a/doc/api/next_api_changes/behavior/23516-MS.rst b/doc/api/next_api_changes/behavior/23516-MS.rst
new file mode 100644
index 000000000000..1d66b6d22eb8
--- /dev/null
+++ b/doc/api/next_api_changes/behavior/23516-MS.rst
@@ -0,0 +1,6 @@
+Warning when scatter plot color settings discarded
+~~~~~~~~~~~~~~~~~~~~~... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-16610@d5d290f | mlflow/mlflow | Python | 16,610 | Delete experiment tag | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/frontsideair/mlflow/pull/16610?quickstart=1)
#### Install mlflow from this PR
```
# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/16610/mer... | 2025-07-07T11:34:15Z | Delete Experiments Tag[FR]
### Willingness to contribute
Yes. I would be willing to contribute this feature with guidance from the MLflow community.
### Proposal Summary
In the python API there's support to add tags for both Experiments and Runs. However, there's only delete_tag support for runs. This FR is to inclu... | @marygracemoesta, thank you for bringing this issue to our attention!
There is absolutely no reason not to support the deletion of a tag from an experiment. I'm assigning this issue to you, but please let us know if you have any other important tasks to do.
Implementation-wise, it should be straightforward. You can... | [
{
"body": "### Willingness to contribute\n\nYes. I would be willing to contribute this feature with guidance from the MLflow community.\n\n### Proposal Summary\n\nIn the python API there's support to add tags for both Experiments and Runs. However, there's only delete_tag support for runs. This FR is to include... | 792fdb77ecdced0fe10de20b58ea836bb1eb29d5 | {
"head_commit": "d5d290f247f0cdd5bff9b6c96da4550a62324c13",
"head_commit_message": "Add deleteExperimentTag to JS MlflowService\n\nSigned-off-by: Fatih Altinok <fatihaltinok@live.com>",
"patch_to_review": "diff --git a/mlflow/__init__.py b/mlflow/__init__.py\nindex 516e0b710eb78..d9459ef1b8f4f 100644\n--- a/mlfl... | [
{
"diff_hunk": "@@ -830,6 +830,29 @@ def set_experiment_tag(key: str, value: Any) -> None:\n MlflowClient().set_experiment_tag(experiment_id, key, value)\n \n \n+def delete_experiment_tag(key: str) -> None:\n+ \"\"\"\n+ Delete a tag from the current experiment.\n+\n+ Args:\n+ key: Tag name. ... | 77f5a740523e85941a52f3916cdd22a4dcd0bdad | diff --git a/mlflow/__init__.py b/mlflow/__init__.py
index 516e0b710eb78..d9459ef1b8f4f 100644
--- a/mlflow/__init__.py
+++ b/mlflow/__init__.py
@@ -267,6 +267,7 @@
create_experiment,
create_external_model,
delete_experiment,
+ delete_experiment_tag,
delete_logged_model_tag,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
mlflow__mlflow-16551@e4701a3 | mlflow/mlflow | Python | 16,551 | Rewrite dev/preview_docs.py in JavaScript to simplify preview-docs workflow | This PR rewrites the `dev/preview_docs.py` Python script in JavaScript to simplify the preview-docs workflow and eliminate unnecessary dependencies.
## Problem
The current `preview-docs.yml` workflow required both Node.js (for Netlify deployment) and Python (for PR comment management), leading to:
- Slower CI runs du... | 2025-07-03T09:36:27Z | Rewrite dev/preview_docs.py in JavaScript to simplify preview-docs workflow
## Description
Currently, the `preview-docs.yml` workflow uses a Python script (`dev/preview_docs.py`) to manage documentation preview comments on pull requests. This requires setting up Python in the workflow and installing dependencies like ... | [
{
"body": "## Description\n\nCurrently, the `preview-docs.yml` workflow uses a Python script (`dev/preview_docs.py`) to manage documentation preview comments on pull requests. This requires setting up Python in the workflow and installing dependencies like `requests`, even though the workflow already uses Node.... | 73c83842e3fd1df0fc47961439b3e24263e056de | {
"head_commit": "e4701a314c1d5b4ed4aa2904daecaca119f855f3",
"head_commit_message": "Complete JavaScript migration: remove Python script and finalize implementation\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/.github/workflows/preview-docs.js b/.github/w... | [
{
"diff_hunk": "@@ -0,0 +1,121 @@\n+/**\n+ * Script to manage documentation preview comments on pull requests.\n+ * This replaces the Python script dev/preview_docs.py to eliminate the need for Python setup\n+ * in the preview-docs workflow.\n+ */\n+\n+const MARKER = \"<!-- documentation preview -->\";\n+\n+/**... | 05ff0f612240661aeeabb2c78c8d04f0fd464fee | diff --git a/.github/workflows/preview-comment.js b/.github/workflows/preview-comment.js
new file mode 100644
index 0000000000000..5674890cdbc74
--- /dev/null
+++ b/.github/workflows/preview-comment.js
@@ -0,0 +1,119 @@
+/**
+ * Script to manage documentation preview comments on pull requests.
+ */
+
+const MARKER = "<... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
mlflow__mlflow-16543@d206952 | mlflow/mlflow | Python | 16,543 | Improve DarkThemeSwitch UX: Remove switch and make icon clickable | This PR improves the user experience of the `DarkThemeSwitch` component by removing the redundant switch toggle and making the theme icon directly clickable.
## Changes Made
### Before
```tsx
<Switch
componentId="..."
checked={isDarkTheme}
onChange={setIsDarkTheme}
/>
{isDarkTheme ? <MoonIcon /> : <S... | 2025-07-03T02:35:02Z | Improve DarkThemeSwitch UX: Remove switch and make icon clickable
## Summary
Currently, the `DarkThemeSwitch` component in `mlflow/server/js/src/common/components/DarkThemeSwitch.tsx` has both a switch toggle and an icon (moon/sun). This creates redundant UI elements for the same functionality.
## Proposed Changes
1... | [
{
"body": "## Summary\n\nCurrently, the `DarkThemeSwitch` component in `mlflow/server/js/src/common/components/DarkThemeSwitch.tsx` has both a switch toggle and an icon (moon/sun). This creates redundant UI elements for the same functionality.\n\n## Proposed Changes\n\n1. **Remove the Switch component** - Curre... | 925326c1ab6e908e705830a9ca64fd9be5fa9425 | {
"head_commit": "d206952c1e667ba044364d80ce9481a68240d457",
"head_commit_message": "Fix DarkThemeSwitch alignment with GitHub/Docs links by reducing button size\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/mlflow/server/js/src/common/components/DarkTheme... | [
{
"diff_hunk": "@@ -23,17 +23,17 @@ export const DarkThemeSwitch = ({\n isDarkTheme: boolean;\n setIsDarkTheme: (isDarkTheme: boolean) => void;\n }) => (\n- <span\n+ <ToggleIconButton\n+ componentId=\"codegen_mlflow_app_src_common_components_darkthemeswitch.tsx_32\"\n+ pressed={isDarkTheme}\n+ on... | 258e678878efbe32d78c7ee83b5637631b869e33 | diff --git a/mlflow/server/js/src/common/components/DarkThemeSwitch.test.tsx b/mlflow/server/js/src/common/components/DarkThemeSwitch.test.tsx
new file mode 100644
index 0000000000000..b76f0059d9a2e
--- /dev/null
+++ b/mlflow/server/js/src/common/components/DarkThemeSwitch.test.tsx
@@ -0,0 +1,56 @@
+import React from '... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
matplotlib__matplotlib-23299@7fce03e | matplotlib/matplotlib | Python | 23,299 | FIX/API: do not reset backend key in rc_context | The motivating issue is that if the backend was the auto backend sentinel and
the backend was first fully resolved in an `rc_context` block, then we would
reset back to the sentinel an exit which would lead to strange behavior with
figures being erroneously closed.
~Adding a general purpose exclusion list seems l... | 2022-06-18T01:34:39Z | [Bug]: Calling matplotlib.pyplot.show() outside of matplotlib.pyplot.rc_context no longer works
### Bug summary
Creating a plot inside of matplotlib.pyplot.rc_context and then calling matplotlib.pyplot.show() outside said context causes the program to freeze.
### Code for reproduction
```python
import matplot... | I cannot reproduce on master, MacOS, Qt5Agg, from the interpreter. Do you have something interesting in your matplotlibrc?
I have also tried on main with CentOS, both using python and ipython interpreters, and it does not happen here either.
> Do you have something interesting in your matplotlibrc?
I have made no ... | [
{
"body": "### Bug summary\r\n\r\nCreating a plot inside of matplotlib.pyplot.rc_context and then calling matplotlib.pyplot.show() outside said context causes the program to freeze.\r\n\r\n### Code for reproduction\r\n\r\n```python\r\nimport matplotlib.pyplot as plt\r\n\r\nwith plt.rc_context():\r\n plt.plot... | 3eadeacc06c9f2ddcdac6ae39819faa9fbee9e39 | {
"head_commit": "7fce03e84b41526c55e07ce9a1c6b8298f9809b3",
"head_commit_message": "FIX/API: Do not reset rcParams['backend'] in rc_context\n\nThe motivating issue is that if the backend was the auto backend sentinel and\nthe backend was first fully resolved in an `rc_context` block, then we would\nreset back to t... | [
{
"diff_hunk": "@@ -0,0 +1,9 @@\n+mpl.rc_context no longer resests the `'backend'` key",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "doc/api/next_api_changes/behavior/23299-TAC.rst",
"start_line": null,
"text": "@user1:\n```suggestion\r\nmpl.rc_context no long... | 4d6bab4cfd74d8c13dfd2321cc0ad1cb3eaecd9f | diff --git a/doc/api/next_api_changes/behavior/23299-TAC.rst b/doc/api/next_api_changes/behavior/23299-TAC.rst
new file mode 100644
index 000000000000..745bd47d6c6b
--- /dev/null
+++ b/doc/api/next_api_changes/behavior/23299-TAC.rst
@@ -0,0 +1,6 @@
+mpl.rc_context no longer resets the value of ``'backend'``
+~~~~~~~~~~... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-23266@941ae96 | matplotlib/matplotlib | Python | 23,266 | negative_linestyles kwarg in contour.py | ## PR Summary
I made the `negative_linestyles` for contours toggle-able via kwarg. The only way to toggle this currently is with `rcParams`.
*I am re-opening this issue from a fresh branch. There was some discussion in #23102.*
In the attached issue, we had some discussion on whether this is a good idea or not, ... | 2022-06-14T04:56:38Z | [ENH]: contour kwarg for negative_linestyle
### Problem
if you contour a negative quantity, it gets dashed lines. Leaving aside whether this is a good default or not, the only way to toggle this is via `rcParams['contour.negative_linestyle']=False`.
### Proposed solution
I think this should be togglable via k... | Should the current `linestyles` kwarg be used to accomplish this or should a new kwarg be added? I have a simple solution adding a new kwarg (though it would need a little more work before it is ready).
The following code snippet and images will show a solution with an added kwarg, but I expect this is not exactly w... | [
{
"body": "### Problem\n\nif you contour a negative quantity, it gets dashed lines. Leaving aside whether this is a good default or not, the only way to toggle this is via `rcParams['contour.negative_linestyle']=False`. \r\n\n\n### Proposed solution\n\n\r\nI think this should be togglable via kwarg, though I ... | dab648ac5eff66a39742f718a356ebe250e01880 | {
"head_commit": "941ae964ef5b3c844de04fa66b4c7baf602ee1d8",
"head_commit_message": "Added negative_linestyles to contour",
"patch_to_review": "diff --git a/lib/matplotlib/contour.py b/lib/matplotlib/contour.py\nindex d666a906812d..e8e6f88fd9ae 100644\n--- a/lib/matplotlib/contour.py\n+++ b/lib/matplotlib/contour... | [
{
"diff_hunk": "@@ -1751,6 +1757,18 @@ def _initialize_x_y(self, z):\n iterable is shorter than the number of contour levels\n it will be repeated as necessary.\n \n+negative_linestyles : None or str, optional\n+ {'solid', 'dashed', 'dashdot', 'dotted'}",
"line": null,
"orig... | 1b3b39042426694f29d8448c211403eeaaa7296f | diff --git a/lib/matplotlib/contour.py b/lib/matplotlib/contour.py
index d666a906812d..4da7da70d080 100644
--- a/lib/matplotlib/contour.py
+++ b/lib/matplotlib/contour.py
@@ -701,7 +701,7 @@ def __init__(self, ax, *args,
hatches=(None,), alpha=None, origin=None, extent=None,
cmap=Non... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
matplotlib__matplotlib-23449@b6fe8b0 | matplotlib/matplotlib | Python | 23,449 | Add pan and zoom toolbar handling to 3D Axes (Replaces PR#22614) | ## PR Summary
Starting with @greglucas's work in https://github.com/matplotlib/matplotlib/pull/22614, I got panning and zooming working again with the toolbar buttons. Closes https://github.com/matplotlib/matplotlib/issues/110 (the oldest open issue!)
**Changes in this PR:**
* Pan and zoom buttons enabled for 3D p... | 2022-07-19T21:00:58Z | pan and zoom are broken for mplot3d
Chances are, this will probably fall on me to address, but I am documenting it here in case someone else realizes the issue.
When creating 3d axes in the old manner (ie, ax = Axes3D(fig)), the panning and zooming features are completely useless and often produces incomprehensible re... | This is partially resolved by disabling the zoom feature (through the button). Note that zooming is still possible by right-clicking the figure and dragging the mouse up and down.
Disabling the Pan feature is trickier...
I am going to declare this issue closed with the current work-around in place in master.
Pan an... | [
{
"body": "Chances are, this will probably fall on me to address, but I am documenting it here in case someone else realizes the issue.\n\nWhen creating 3d axes in the old manner (ie, ax = Axes3D(fig)), the panning and zooming features are completely useless and often produces incomprehensible results. Axes cr... | 924e2107069c8fe9b8d7683a0b5ec0055c7c3647 | {
"head_commit": "b6fe8b0b5f9eb66001a61291b69c17161219aa26",
"head_commit_message": "Docstrings",
"patch_to_review": "diff --git a/doc/users/next_whats_new/3d_plot_pan_zoom.rst b/doc/users/next_whats_new/3d_plot_pan_zoom.rst\nnew file mode 100644\nindex 000000000000..89b0a019bf59\n--- /dev/null\n+++ b/doc/users/n... | [
{
"diff_hunk": "@@ -864,28 +862,20 @@ def get_proj(self):\n # The coordinates for the eye viewing point. The eye is looking\n # towards the middle of the box of data from a distance:\n eye = R + self._dist * ps\n-\n- # TODO: Is this being used somewhere? Can it be removed?\n ... | 28fae531c3b107fd8da4c750df27b951fd65fb96 | diff --git a/doc/api/next_api_changes/deprecations/23449-SS.rst b/doc/api/next_api_changes/deprecations/23449-SS.rst
new file mode 100644
index 000000000000..cc5123fc0b7d
--- /dev/null
+++ b/doc/api/next_api_changes/deprecations/23449-SS.rst
@@ -0,0 +1,3 @@
+``axes3d.vvec``, ``axes3d.eye``, ``axes3d.sx``, and ``axes3d.... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-16526@5a54849 | mlflow/mlflow | Python | 16,526 | Update docs/package.json to format CSS files using prettier | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/Copilot/mlflow/pull/16526?quickstart=1)
#### Install mlflow from this PR
```
# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/16526/merge
# ... | 2025-07-02T08:07:26Z | Update docs/package.json to format CSS files using prettier
## Summary
The prettier configuration in `docs/package.json` currently only formats TypeScript/TSX and Markdown/MDX files, but does not include CSS files. This should be updated to also format CSS files to maintain consistent code style across the documentati... | [
{
"body": "## Summary\n\nThe prettier configuration in `docs/package.json` currently only formats TypeScript/TSX and Markdown/MDX files, but does not include CSS files. This should be updated to also format CSS files to maintain consistent code style across the documentation.\n\n## Current Configuration\n\nThe ... | 111488eb276d523d483ebcef97f4794d2195e847 | {
"head_commit": "5a54849f1a953d1c6e3c9f06c7a789a0cec16ec0",
"head_commit_message": "Update docs/package.json prettier scripts to include CSS files\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/docs/api_reference/theme/mlflow/static/css/badge_only.css b/do... | [
{
"diff_hunk": "@@ -20,8 +20,8 @@\n \"write-heading-ids\": \"docusaurus write-heading-ids\",\n \"typecheck\": \"tsc\",\n \"prettier\": \"prettier\",\n- \"prettier:fix\": \"prettier \\\"{**/*.(ts|tsx),**/*.(md|mdx)}\\\" --write\",\n- \"prettier:check\": \"prettier \\\"{**/*.(ts|tsx),**/*.(md|md... | ab91e95dc8d406ffb493280a4e37933c09a70833 | diff --git a/docs/.prettierignore b/docs/.prettierignore
new file mode 100644
index 0000000000000..1a7e4d3f752e4
--- /dev/null
+++ b/docs/.prettierignore
@@ -0,0 +1,2 @@
+# Exclude vendor/theme CSS files in api_reference directory
+api_reference/**/*.css
\ No newline at end of file
diff --git a/docs/package.json b/docs... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} | |
matplotlib__matplotlib-23069@4d6568c | matplotlib/matplotlib | Python | 23,069 | TST: forgive more failures on pyside2 / pyside6 cross imports | ## PR Summary
closes #23004
This is testing that we warn something is a bad idea and failing because it is indeed a bad idea.
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**Tests and Styling**
- [x] Has pytest style unit tests (and `pytest` passes).
- [x] Is ... | 2022-05-18T19:57:04Z | [Bug]: test failure of test_cross_Qt_imports in 3.5.2
### Bug summary
While building 3.5.2 for Arch Linux, I’ve encountered a test failure for test_cross_Qt_imports.
### Code for reproduction
```python
xvfb-run -a -s "-screen 0 640x480x24" test-env/bin/python -m pytest -ra -n auto -v --color=yes --pyargs matp... | SIGABRT means your Qt5/6 crashed; not sure we can do anything about that.
The point of that test is so we can warn if the user is doing something that is a really bad idea (trying to use Qt5 and Qt6 in the same process) before it crashes.
We already have a cut-out for segfault (-11), I think the fix is to also allow... | [
{
"body": "### Bug summary\r\n\r\nWhile building 3.5.2 for Arch Linux, I’ve encountered a test failure for test_cross_Qt_imports.\r\n\r\n### Code for reproduction\r\n\r\n```python\r\nxvfb-run -a -s \"-screen 0 640x480x24\" test-env/bin/python -m pytest -ra -n auto -v --color=yes --pyargs matplotlib mpl_toolkits... | 8bfd2c43344215008a2f5597ecc0ee467fb039d3 | {
"head_commit": "4d6568c8220e9141103a947837423144e694f312",
"head_commit_message": "TST: forgive more failures on pyside2 / pyside6 cross imports\n\ncloses #23004",
"patch_to_review": "diff --git a/lib/matplotlib/tests/test_backends_interactive.py b/lib/matplotlib/tests/test_backends_interactive.py\nindex bd56c3... | [
{
"diff_hunk": "@@ -359,6 +359,10 @@ def test_cross_Qt_imports():\n # are doing something that we do not expect to work\n if ex.returncode == -11:\n continue\n+ # We got the abort signal which is likely because the Qt5 /\n+ ... | 5cf44f88e7e201d03dd55e039bc13e7ae0e045fe | diff --git a/lib/matplotlib/tests/test_backends_interactive.py b/lib/matplotlib/tests/test_backends_interactive.py
index bd56c3c58a38..a89e745304a2 100644
--- a/lib/matplotlib/tests/test_backends_interactive.py
+++ b/lib/matplotlib/tests/test_backends_interactive.py
@@ -357,7 +357,11 @@ def test_cross_Qt_imports():
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-16367@49cb824 | mlflow/mlflow | Python | 16,367 | Use Resolver for TYPE_CHECKING Detection in clint linter | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/Copilot/mlflow/pull/16367?quickstart=1)
#### Install mlflow from this PR
```
# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/16367/merge
# ... | 2025-06-21T09:13:52Z | Use Resolver for TYPE_CHECKING Detection in clint linter
## Problem Statement
Currently, in `dev/clint/src/clint/linter.py`, the detection of `TYPE_CHECKING` usage is hardcoded to only recognize direct usage of the name `TYPE_CHECKING`. This doesn't handle cases where `TYPE_CHECKING` is imported with an alias or from ... | [
{
"body": "## Problem Statement\n\nCurrently, in `dev/clint/src/clint/linter.py`, the detection of `TYPE_CHECKING` usage is hardcoded to only recognize direct usage of the name `TYPE_CHECKING`. This doesn't handle cases where `TYPE_CHECKING` is imported with an alias or from a different module path.\n\n## Motiv... | 3a2ca851dcace5dce7fdd954af9b4d0908dabd64 | {
"head_commit": "49cb824f5ed29f1d1e3731d17c22fd7071e747b1",
"head_commit_message": "Implement resolver-based TYPE_CHECKING detection in clint linter\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/dev/clint/src/clint/linter.py b/dev/clint/src/clint/linter.p... | [
{
"diff_hunk": "@@ -690,8 +690,13 @@ def visit_type_annotation(self, node: ast.AST) -> None:\n self.in_type_annotation = False\n \n def visit_If(self, node: ast.If) -> None:\n- if isinstance(node.test, ast.Name) and node.test.id == \"TYPE_CHECKING\":\n- self.in_TYPE_CHECKING = True... | 0836c881e7293d94fbb69a16ab4119c79e65f9ad | diff --git a/dev/clint/src/clint/linter.py b/dev/clint/src/clint/linter.py
index b211bde4391d9..8ac7ed568fc1e 100644
--- a/dev/clint/src/clint/linter.py
+++ b/dev/clint/src/clint/linter.py
@@ -690,7 +690,10 @@ def visit_type_annotation(self, node: ast.AST) -> None:
self.in_type_annotation = False
def vi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
mlflow__mlflow-16311@a21e7be | mlflow/mlflow | Python | 16,311 | Add linting rule to enforce thread_name_prefix for ThreadPoolExecutor | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/Copilot/mlflow/pull/16311?quickstart=1)
#### Install mlflow from this PR
```
# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/16311/merge
# ... | 2025-06-18T11:11:46Z | Add linting rule to enforce thread_name_prefix for ThreadPoolExecutor
## Problem Statement
Currently, there is no automated check to ensure that `ThreadPoolExecutor` instances are created with a `thread_name_prefix` argument. This leads to inconsistent thread naming practices in the codebase, which makes debugging and... | [
{
"body": "## Problem Statement\n\nCurrently, there is no automated check to ensure that `ThreadPoolExecutor` instances are created with a `thread_name_prefix` argument. This leads to inconsistent thread naming practices in the codebase, which makes debugging and traceability of thread-related issues more diffi... | cbde7a8a7f7c4b8364df65403cf593fade34586a | {
"head_commit": "a21e7be3988ac07ac5f568185b290cd73a78db8a",
"head_commit_message": "Fix existing ThreadPoolExecutor violations by adding thread_name_prefix\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/dev/clint/src/clint/linter.py b/dev/clint/src/clint/l... | [
{
"diff_hunk": "@@ -240,7 +240,9 @@ def process_api_requests(\n ) = transform_request_json_for_chat_if_necessary(requests, lc_model)\n \n requests_iter = enumerate(converted_chat_requests)\n- with ThreadPoolExecutor(max_workers=max_workers) as executor:\n+ with ThreadPoolExecutor(\n+ max_wo... | cc349ee43da2b8c8719415f24ffdd8d78ec8dff3 | diff --git a/dev/clint/src/clint/linter.py b/dev/clint/src/clint/linter.py
index 27941ce1efa5e..9fecf7d72e5b5 100644
--- a/dev/clint/src/clint/linter.py
+++ b/dev/clint/src/clint/linter.py
@@ -651,6 +651,12 @@ def visit_Call(self, node: ast.Call) -> None:
if self.path.parts[0] != "tests" and rules.UnnamedThrea... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} | |
mlflow__mlflow-16307@6a988e2 | mlflow/mlflow | Python | 16,307 | Auto-generate ID for Rule Classes in clint using `__init_subclass__` with itertools.count | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/Copilot/mlflow/pull/16307?quickstart=1)
#### Install mlflow from this PR
```
# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/16307/merge
# ... | 2025-06-18T07:13:07Z | Auto-generate ID for Rule Classes in clint
# Auto-generate ID for Rule Classes
_This plan was created by Claude to document the implementation approach for auto-generating Rule IDs._
## Problem Statement
Currently, each Rule subclass in `dev/clint/src/clint/rules.py` must manually implement the `_id()` method to ret... | [
{
"body": "# Auto-generate ID for Rule Classes\n\n_This plan was created by Claude to document the implementation approach for auto-generating Rule IDs._\n\n## Problem Statement\n\nCurrently, each Rule subclass in `dev/clint/src/clint/rules.py` must manually implement the `_id()` method to return a unique ident... | 0b1afe79ceaeb56b84ef7aa60e66ae20a4de15f0 | {
"head_commit": "6a988e2b3f412bba53e5fda0e1d93c8eac8509b2",
"head_commit_message": "Implement auto-generation of Rule IDs using __init_subclass__ with itertools.count\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/dev/clint/src/clint/rules.py b/dev/clint/s... | [
{
"diff_hunk": "@@ -11,12 +13,18 @@\n \n class Rule(ABC):\n _CLASS_NAME_TO_RULE_NAME_REGEX = re.compile(r\"(?<!^)(?=[A-Z])\")\n+ _id_counter = itertools.count(start=1)\n+ _generated_id: str\n+\n+ def __init_subclass__(cls, **kwargs):\n+ super().__init_subclass__(**kwargs)\n+ # Only ge... | 6834aed0244f245d1ed21ab2486eb5ae486ca508 | diff --git a/dev/clint/src/clint/rules.py b/dev/clint/src/clint/rules.py
index c8ed92d46fd28..765255d64cda0 100644
--- a/dev/clint/src/clint/rules.py
+++ b/dev/clint/src/clint/rules.py
@@ -1,6 +1,8 @@
from __future__ import annotations
import ast
+import inspect
+import itertools
import re
from abc import ABC, ab... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
mlflow__mlflow-16243@3827261 | mlflow/mlflow | Python | 16,243 | Add CircleCI step to show docs/build/latest directory size | <details><summary>🛠 DevTools 🛠</summary>
<p>
[](https://codespaces.new/Copilot/mlflow/pull/16243?quickstart=1)
#### Install mlflow from this PR
```
# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/16243/merge
# ... | 2025-06-13T09:11:15Z | Add CircleCI step to show docs/build/latest directory size
## Description
Add a step in the CircleCI configuration (`.circleci/config.yml`) to display the size of the `docs/build/latest` directory. This will help monitor the documentation build size and identify potential issues with documentation generation.
## Prop... | [
{
"body": "## Description\n\nAdd a step in the CircleCI configuration (`.circleci/config.yml`) to display the size of the `docs/build/latest` directory. This will help monitor the documentation build size and identify potential issues with documentation generation.\n\n## Proposed Changes\n\nAdd a new step in th... | 5f0333c663c85c115980a17632e657ec3a87ca1f | {
"head_commit": "3827261eb3a18837f2c94a21157b6b9b95744681",
"head_commit_message": "Simplify docs build size step to show only total size\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/.circleci/config.yml b/.circleci/config.yml\nindex 682c9e41366ef..4b3c0... | [
{
"diff_hunk": "@@ -93,6 +93,17 @@ jobs:\n command: |\n yarn build-all -- --no-r\n python changed_pages.py\n+ - run:\n+ name: Show docs build size\n+ working_directory: docs\n+ command: |\n+ if [ -d \"./build/latest\" ]; then",
"li... | a3c5e57bea4410864a038c5b6e90c9aec195c0f6 | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 682c9e41366ef..23d71373c6e38 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -93,6 +93,12 @@ jobs:
command: |
yarn build-all -- --no-r
python changed_pages.py
+ - run:
+ name: Show docs buil... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} | |
matplotlib__matplotlib-22835@50d413d | matplotlib/matplotlib | Python | 22,835 | Fix BoundaryNorm cursor data output | ## PR Summary
This should fix #21915 with an `isinstance(norm, BoundaryNorm)` check and special logic to figure out the `delta` for calculating the value for the significant digits to show as cursor data output.
I opted to use the boundaries of the `BoundaryNorm` directly, instead of calculating the midpoints of ne... | 2022-04-12T23:13:58Z | [Bug]: scalar mappable format_cursor_data crashes on BoundarNorm
### Bug summary
In 3.5.0 if you do:
```python
import matplotlib.pyplot as plt
import numpy as np
import matplotlib as mpl
fig, ax = plt.subplots()
norm = mpl.colors.BoundaryNorm(np.linspace(-4, 4, 5), 256)
X = np.random.randn(10, 10)
pc = a... | I think the correct fix is to specifically check for BoundaryNorm there and implement special logic to determine the positions of the neighboring intervals (on the BoundaryNorm) for that case.
I tried returning the passed in `value` instead of the exception at https://github.com/matplotlib/matplotlib/blob/b2bb7be4ba343... | [
{
"body": "### Bug summary\r\n\r\nIn 3.5.0 if you do:\r\n\r\n```python\r\nimport matplotlib.pyplot as plt\r\nimport numpy as np\r\nimport matplotlib as mpl\r\n\r\nfig, ax = plt.subplots()\r\nnorm = mpl.colors.BoundaryNorm(np.linspace(-4, 4, 5), 256)\r\nX = np.random.randn(10, 10)\r\npc = ax.imshow(X, cmap='RdBu... | c33557d120eefe3148ebfcf2e758ff2357966000 | {
"head_commit": "50d413d79f3316dc1cdc98145f5191b32df74a45",
"head_commit_message": "Add test for BoundaryNorm cursor data output",
"patch_to_review": "diff --git a/lib/matplotlib/artist.py b/lib/matplotlib/artist.py\nindex 1f33b9d3ec11..0f47035ed99c 100644\n--- a/lib/matplotlib/artist.py\n+++ b/lib/matplotlib/ar... | [
{
"diff_hunk": "@@ -1303,10 +1304,22 @@ def format_cursor_data(self, data):\n return \"[]\"\n normed = self.norm(data)\n if np.isfinite(normed):\n- # Midpoints of neighboring color intervals.\n- neighbors = self.norm.inverse(\n- ... | ec8b93e21b3d9962543ae85c2776195eb594d27f | diff --git a/lib/matplotlib/artist.py b/lib/matplotlib/artist.py
index 1f33b9d3ec11..24a60fd4d121 100644
--- a/lib/matplotlib/artist.py
+++ b/lib/matplotlib/artist.py
@@ -12,6 +12,7 @@
import matplotlib as mpl
from . import _api, cbook
+from .colors import BoundaryNorm
from .cm import ScalarMappable
from .path im... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
matplotlib__matplotlib-22926@88e846a | matplotlib/matplotlib | Python | 22,926 | Fix RangeSlider for same init values #22686 | ## PR Summary
Change the way that polygon is initilized to cover edge case of same init values. The method axhspan is no longer used and the polygon is created manually. (closes #22686 )
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**Tests and Styling**
- [ ] Has p... | 2022-04-28T13:39:16Z | [Bug]: cannot give init value for RangeSlider widget
### Bug summary
I think `xy[4] = .25, val[0]` should be commented in /matplotlib/widgets. py", line 915, in set_val
as it prevents to initialized value for RangeSlider
### Code for reproduction
```python
import numpy as np
import matplotlib.pyplot as plt
... | Huh, the polygon object must have changed inadvertently. Usually, you have
to "close" the polygon by repeating the first vertex, but we make it
possible for polygons to auto-close themselves. I wonder how (when?) this
broke?
On Tue, Mar 22, 2022 at 10:29 PM vpicouet ***@***.***> wrote:
> Bug summary
>
> I think xy[4]... | [
{
"body": "### Bug summary\r\n\r\nI think `xy[4] = .25, val[0]` should be commented in /matplotlib/widgets. py\", line 915, in set_val\r\nas it prevents to initialized value for RangeSlider\r\n\r\n### Code for reproduction\r\n\r\n```python\r\nimport numpy as np\r\nimport matplotlib.pyplot as plt\r\nfrom matplot... | e779b97174ff3ab2737fbdffb432ef8689201602 | {
"head_commit": "88e846a6a5a937c71c1ccbdad985c80c92fd5a16",
"head_commit_message": "Create method _fill_verts",
"patch_to_review": "diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py\nindex cd79e9523a04..8a54bdd1c40f 100644\n--- a/lib/matplotlib/widgets.py\n+++ b/lib/matplotlib/widgets.py\n@@ -19... | [
{
"diff_hunk": "@@ -719,9 +723,15 @@ def __init__(\n facecolor=track_color\n )\n ax.add_patch(self.track)\n- self.poly = ax.axvspan(valinit[0], valinit[1], 0, 1, **kwargs)\n+ verts = self._fill_verts(verts, valinit)\n+ poly = Polygon(verts... | 4cc82f1975d5230a9d4bc40e1954b34928346c6e | diff --git a/lib/matplotlib/tests/test_widgets.py b/lib/matplotlib/tests/test_widgets.py
index 11db0493a711..d4a2bb1685fb 100644
--- a/lib/matplotlib/tests/test_widgets.py
+++ b/lib/matplotlib/tests/test_widgets.py
@@ -1161,6 +1161,23 @@ def handle_positions(slider):
assert_allclose(handle_positions(slider), (0.1,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-16231@b3c45e2 | mlflow/mlflow | Python | 16,231 | Implement lint rule MLF0024 to prevent unnamed threading.Thread | # Context
While I was working on https://github.com/mlflow/mlflow/pull/16229, I found the Optuna integration leaves some zombie threads which call `time.sleep`. If it used a named thread, I would've identified the root cause much faster. Let's enforce that threads are always named.
<details><summary>🛠 DevT... | 2025-06-12T15:06:29Z | Lint Rule to Prevent Unnamed `threading.Thread`
# Proposal: Lint Rule to Prevent Unnamed `threading.Thread`
## Summary
This proposal suggests implementing a lint rule to prevent the creation of unnamed `threading.Thread` instances in Python code. Unnamed threads make debugging and monitoring significantly more diffic... | [
{
"body": "# Proposal: Lint Rule to Prevent Unnamed `threading.Thread`\n\n## Summary\n\nThis proposal suggests implementing a lint rule to prevent the creation of unnamed `threading.Thread` instances in Python code. Unnamed threads make debugging and monitoring significantly more difficult, especially in comple... | 8c2af744e89b0239edaaea57afabbb003d8225a8 | {
"head_commit": "b3c45e28068decb602d540c555f971a28a376d9e",
"head_commit_message": "Fix unnamed threading.Thread instances identified by MLF0024 rule\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/dev/clint/src/clint/linter.py b/dev/clint/src/clint/linter.... | [
{
"diff_hunk": "@@ -236,7 +236,7 @@ def _run():\n finally:\n loop.close()\n \n- thread = threading.Thread(target=_run)\n+ thread = threading.Thread(target=_run, name=\"llamaindex_async_task_runner\")",
"line": null,
"original_line": 239,
"ori... | 653b8b3a4f78a509982e50d21dd364e3c553f927 | diff --git a/dev/clint/src/clint/linter.py b/dev/clint/src/clint/linter.py
index 628faf429042b..1a997bd247be0 100644
--- a/dev/clint/src/clint/linter.py
+++ b/dev/clint/src/clint/linter.py
@@ -638,6 +638,9 @@ def visit_Call(self, node: ast.Call) -> None:
if self.path.parts[0] != "tests" and _is_set_active_mode... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} | |
matplotlib__matplotlib-22820@4fa2782 | matplotlib/matplotlib | Python | 22,820 | [Doc] consolidate `rect` documentation | ## PR Summary
Consolidate `rect` documentation. Closes #22819
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
**Tests and Styling**
- [ ] Has pytest style unit tests (and `pytest` passes).
- [x] Is [Flake 8](https://flake8.pycqa.org/en/latest/) compliant (install ... | 2022-04-10T17:28:56Z | [Doc]: Make rect argument consistent in the docstrings
### Documentation Link
_No response_
### Problem
The `rect` argument to functions is inconsistently documented in the codebase. We should consolidate the argument into a single choice.
The options I found searching for `rect : ` are:
```bash
rect : tuple[fl... | I'd like to work on this.
Below, while creating an instance of `Grid`, it not only accepts a tuple but also an integer. Do I not touch the integer part and just make changes to the documentation of the tuple?
https://github.com/matplotlib/matplotlib/blob/2df11ccd4221d4a1d7001ab374e44f8f3c51316f/lib/mpl_toolkits/ax... | [
{
"body": "### Documentation Link\n\n_No response_\n\n### Problem\n\nThe `rect` argument to functions is inconsistently documented in the codebase. We should consolidate the argument into a single choice.\r\n\r\nThe options I found searching for `rect : ` are:\r\n```bash\r\nrect : tuple[float, float, float, flo... | 9cf4611377acbcf4d7191672944df3ae4b30d918 | {
"head_commit": "4fa278267eefc0333f38fb55de6ec384bcf5c6e0",
"head_commit_message": "Merge branch 'main' into consolidate-rect-documentation",
"patch_to_review": "diff --git a/lib/matplotlib/_tight_layout.py b/lib/matplotlib/_tight_layout.py\nindex 81465f9b5db6..055f3fce04e4 100644\n--- a/lib/matplotlib/_tight_la... | [
{
"diff_hunk": "@@ -460,7 +460,7 @@ def tight_layout(self, figure, renderer=None,\n h_pad, w_pad : float, optional\n Padding (height/width) between edges of adjacent subplots.\n Defaults to *pad*.\n- rect : tuple of 4 floats, default: (0, 0, 1, 1), i.e. the whole figure\n+... | d9d91301f871d51b8f9e3254819da9a2d43761fa | diff --git a/lib/matplotlib/_tight_layout.py b/lib/matplotlib/_tight_layout.py
index 81465f9b5db6..055f3fce04e4 100644
--- a/lib/matplotlib/_tight_layout.py
+++ b/lib/matplotlib/_tight_layout.py
@@ -41,8 +41,8 @@ def _auto_adjust_subplotpars(
h_pad, w_pad : float
Padding (height/width) between edges of ad... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
matplotlib__matplotlib-22711@2566eaa | matplotlib/matplotlib | Python | 22,711 | RangeSlider handle set_val bugfix | ## PR Summary
This bug fix is in response to issue #22706.
There was an issue with the handles not updating when set_val was called on a RangeSlider object.
I updated set_val to adjust the appropriate handles when set_val is called. There are still other issues with handles in the RangeSlider class, but this ... | 2022-03-27T00:34:37Z | [Bug]: cannot give init value for RangeSlider widget
### Bug summary
I think `xy[4] = .25, val[0]` should be commented in /matplotlib/widgets. py", line 915, in set_val
as it prevents to initialized value for RangeSlider
### Code for reproduction
```python
import numpy as np
import matplotlib.pyplot as plt
... | Huh, the polygon object must have changed inadvertently. Usually, you have
to "close" the polygon by repeating the first vertex, but we make it
possible for polygons to auto-close themselves. I wonder how (when?) this
broke?
On Tue, Mar 22, 2022 at 10:29 PM vpicouet ***@***.***> wrote:
> Bug summary
>
> I think xy[4]... | [
{
"body": "### Bug summary\r\n\r\nI think `xy[4] = .25, val[0]` should be commented in /matplotlib/widgets. py\", line 915, in set_val\r\nas it prevents to initialized value for RangeSlider\r\n\r\n### Code for reproduction\r\n\r\n```python\r\nimport numpy as np\r\nimport matplotlib.pyplot as plt\r\nfrom matplot... | f670fe78795b18eb1118707721852209cd77ad51 | {
"head_commit": "2566eaa43278d99d1d90e0cb192c6e4d21a13487",
"head_commit_message": "RangeSlider handle set_val bugfix",
"patch_to_review": "diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py\nindex da5b40a5ef28..a7f87ab58dae 100644\n--- a/lib/matplotlib/widgets.py\n+++ b/lib/matplotlib/widgets.py... | [
{
"diff_hunk": "@@ -835,12 +838,19 @@ def _update(self, event):\n self._active_handle = None\n return\n \n- # determine which handle was grabbed\n- handle = self._handles[\n- np.argmin(\n+ if self.orientation == \"vertical\":\n+ # determine whic... | 0c6ccf6c2ffcf27389118c1272297312e75b1ebd | diff --git a/lib/matplotlib/tests/test_widgets.py b/lib/matplotlib/tests/test_widgets.py
index a19770e3b0a1..cf98e3aea85e 100644
--- a/lib/matplotlib/tests/test_widgets.py
+++ b/lib/matplotlib/tests/test_widgets.py
@@ -1105,19 +1105,30 @@ def test_range_slider(orientation):
# Check initial value is set correctly
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-16080@846ab94 | mlflow/mlflow | Python | 16,080 | Enhance check-vcs-permalinks pre-commit hook configuration | This PR adds the `check-vcs-permalinks` pre-commit hook to ensure VCS permalinks across the codebase use permanent commit hashes instead of branch names.
## Changes Made
Added `check-vcs-permalinks` hook to `.pre-commit-config.yaml`:
```yaml
- id: check-vcs-permalinks
files: \.(py|md|mdx|rst|yaml|yml)$
require_s... | 2025-06-05T05:07:38Z | Enhance check-vcs-permalinks pre-commit hook configuration
## Issue Description
The `check-vcs-permalinks` pre-commit hook is currently configured in our `.pre-commit-config.yaml` file but only applies to Python files (`.py`). This hook is valuable for ensuring that VCS permalinks in our codebase are properly formatte... | [
{
"body": "## Issue Description\n\nThe `check-vcs-permalinks` pre-commit hook is currently configured in our `.pre-commit-config.yaml` file but only applies to Python files (`.py`). This hook is valuable for ensuring that VCS permalinks in our codebase are properly formatted and up-to-date.\n\n## Current Config... | 07ba4a64cda5b9482afca7e8f29224948e082843 | {
"head_commit": "846ab94d60cc1b502453318ddcfa78cc7aeda1d6",
"head_commit_message": "Add check-vcs-permalinks hook to pre-commit configuration\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml\nindex 45aa0f3726... | [
{
"diff_hunk": "@@ -8,6 +8,9 @@ repos:\n - id: end-of-file-fixer\n files: \\.(proto|txt|sh|rst)$\n exclude: ^examples/\n+ - id: check-vcs-permalinks\n+ files: \\.(py|md|mdx|rst|yaml|yml)$",
"line": null,
"original_line": 12,
"original_start_line": null,
"path": ... | 09fd8c97651bfb85f752bd41aec0d144033a4295 | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 45aa0f372631e..9ff812b1ed00b 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -8,6 +8,9 @@ repos:
- id: end-of-file-fixer
files: \.(proto|txt|sh|rst)$
exclude: ^examples/
+ - id: check-vcs-permalinks
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Test Suite / CI Enhancements"
} | |
matplotlib__matplotlib-22665@e30cd8e | matplotlib/matplotlib | Python | 22,665 | Improve error message for incorrect color string | ## PR Summary
Closes #22662
The error message when supplying an empty string for color was a bit confusing:
```
raise ValueError("Using a string of single character colors as "
"a color sequence is not supported. The colors "
"can be passed as an explicit list instead.")
```
... | 2022-03-18T07:37:32Z | Leave color parameter empty should be fine[ENH]:
### Problem
Sometimes, I want to leave the facecolor empty to avoid overlap with other point and at the same time, I don't want to use alpha parameter since it will change the color actually. What I want is to ask you if you can remove the warning _"MatplotlibDeprecati... | Note that this raises an error in recent versions.
You can just pass an empty list instead:
```
import matplotlib.pyplot as plt
plt.scatter([0,1,2],[1,1,1],s=500,marker='o',edgecolor='k',c=[])
plt.scatter([0,1,2],[1,1,1],s=50,marker='o',edgecolor='b',c=[])
plt.show()
```
or None depending on what you ... | [
{
"body": "### Problem\n\nSometimes, I want to leave the facecolor empty to avoid overlap with other point and at the same time, I don't want to use alpha parameter since it will change the color actually. What I want is to ask you if you can remove the warning _\"MatplotlibDeprecationWarning: Using a string of... | e3c819516689ce436e90cd11b1dd2948e7a5f6f2 | {
"head_commit": "e30cd8e73542a59e455ab95d357b81decb430c13",
"head_commit_message": "Improve error message for empty string color",
"patch_to_review": "diff --git a/lib/matplotlib/colors.py b/lib/matplotlib/colors.py\nindex 6d126e6725fb..a219959cc9bd 100644\n--- a/lib/matplotlib/colors.py\n+++ b/lib/matplotlib/co... | [
{
"diff_hunk": "@@ -362,9 +362,7 @@ def to_rgba_array(c, alpha=None):\n pass\n \n if isinstance(c, str):\n- raise ValueError(\"Using a string of single character colors as \"\n- \"a color sequence is not supported. The colors can \"\n- \"be pass... | 52642c7f667899db74596fcb83857b358bb6f950 | diff --git a/lib/matplotlib/colors.py b/lib/matplotlib/colors.py
index 6d126e6725fb..ec6abf1dd78e 100644
--- a/lib/matplotlib/colors.py
+++ b/lib/matplotlib/colors.py
@@ -362,9 +362,7 @@ def to_rgba_array(c, alpha=None):
pass
if isinstance(c, str):
- raise ValueError("Using a string of single cha... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
mlflow__mlflow-16014@7be62ec | mlflow/mlflow | Python | 16,014 | Support string guidelines for `meets_guidelines` judge | The `mlflow.genai.judges.meets_guidelines` function was documented to accept both single strings and lists of strings for the `guidelines` parameter, but the underlying `databricks.agents.evals.judges.guideline_adherence` function only accepts lists. This caused runtime errors when users passed a single string guidelin... | 2025-06-02T09:01:41Z | Support string guidelines for `meets_guidelines` judge
The `mlflow.genai.judges.meets_guidelines` should allow both single string and list of strings inputs. The underlying databricks judge only accept a list of judge, so our judge API should wrap it in a list. The change should be tested in `test_guideline_adherence` ... | [
{
"body": "The `mlflow.genai.judges.meets_guidelines` should allow both single string and list of strings inputs. The underlying databricks judge only accept a list of judge, so our judge API should wrap it in a list. The change should be tested in `test_guideline_adherence` test case in `tests/genai/scorers/te... | 7afab096ac42f81664b4892f996fdc3bf0e2f513 | {
"head_commit": "7be62ec4952122083307bd989a3baf17ba0b8bdd",
"head_commit_message": "Support string guidelines for meets_guidelines judge\n\nCo-authored-by: B-Step62 <31463517+B-Step62@users.noreply.github.com>",
"patch_to_review": "diff --git a/mlflow/genai/judges/databricks.py b/mlflow/genai/judges/databricks.p... | [
{
"diff_hunk": "@@ -243,6 +244,33 @@ def test_guideline_adherence():\n assessment_name=\"is_english\",\n )\n \n+ # 3. Test meets_guidelines judge with string input (should wrap in list)\n+ with patch(\"databricks.agents.evals.judges.guideline_adherence\") as mock_guideline_adherence:\n+ ... | 1099b950d41852db0a37da3379cafa07566b11c7 | diff --git a/mlflow/genai/judges/databricks.py b/mlflow/genai/judges/databricks.py
index 5c863d644ea4d..5f89557cfd2bd 100644
--- a/mlflow/genai/judges/databricks.py
+++ b/mlflow/genai/judges/databricks.py
@@ -278,6 +278,10 @@ def meets_guidelines(
"""
from databricks.agents.evals.judges import guideline_adher... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
mlflow__mlflow-16009@a2d00a3 | mlflow/mlflow | Python | 16,009 | Replace `dev/check-notebooks.sh` with `clint` rule for trace UI detection | This PR replaces the standalone `dev/check-notebooks.sh` script with a proper `clint` rule that integrates seamlessly with the existing linting infrastructure.
## Changes Made
1. **Added new rule**: `ForbiddenTraceUIInNotebook` (MLF0022) in `dev/clint/src/clint/rules.py` that detects the presence of MLflow Trace UI i... | 2025-06-02T07:11:28Z | Remove `dev/check-notebooks.sh` and use `clint` instead
`clint` is a custom linter used in this repository to check python scripts/notebooks. We should use it to check notebooks instead of the `dev/check-notebooks.sh` script.
Instructions:
1. Add a new rule in `dev/clint/src/clint/rules.py`.
2. Update `_lint_cell` in... | [
{
"body": "`clint` is a custom linter used in this repository to check python scripts/notebooks. We should use it to check notebooks instead of the `dev/check-notebooks.sh` script.\n\nInstructions:\n\n1. Add a new rule in `dev/clint/src/clint/rules.py`.\n2. Update `_lint_cell` in `dev/clint/src/clint/linter.py`... | 0e0fe9e665aece995c0a9a54ca400961568fa05a | {
"head_commit": "a2d00a3a3334d0760ad6963feffa7f3ee877f2ab",
"head_commit_message": "Refactor _has_trace_ui_content to reduce nesting\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml\nindex 9442f05520350..45aa... | [
{
"diff_hunk": "@@ -674,21 +674,55 @@ def post_visit(self) -> None:\n self._check(loc, rules.LazyModule())\n \n \n+def _has_trace_ui_content(output: dict[str, Any]) -> bool:\n+ \"\"\"Check if an output contains MLflow trace UI content.\"\"\"\n+ data = output.get(\"data\")\n+ if not ... | e81c4be6b71741af8e84a6dc012bf443f7288c18 | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 9442f05520350..45aa0f372631e 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -49,14 +49,6 @@ repos:
stages: [pre-commit]
require_serial: true
- - id: check-notebooks
- name: check-notebooks
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Style, Linting, Formatting Fixes"
} | |
matplotlib__matplotlib-22566@e1a0de8 | matplotlib/matplotlib | Python | 22,566 | Add rcparam for figure label size and weight | ## PR Summary
Closes #22564
Add `figure.labelsize` and `figure.labelweight` rcParams to set figure label size and weight different from title.
Test added also for titlesize/-weight rcParams as I didn't find any.
## PR Checklist
<!-- Please mark any checkboxes that do not apply to this PR as [N/A]. -->
... | 2022-02-26T17:12:08Z | [ENH]: Font weight for Figure title and labels
### Problem
Figure title (_Figure.suptitle()_) and labels (_Figure.supxlabel()_ and _Figure.supylabel()_) have the same default font size and weight. Although one can modify these values when creating the title and/or labels, it would be easier if users were able to set d... | [
{
"body": "### Problem\n\nFigure title (_Figure.suptitle()_) and labels (_Figure.supxlabel()_ and _Figure.supylabel()_) have the same default font size and weight. Although one can modify these values when creating the title and/or labels, it would be easier if users were able to set different defaults.\n\n### ... | 89331ee0681ce0cabb229737bc2861ed46c5aca0 | {
"head_commit": "e1a0de8715a60831f21be2b7e6311b789c7a6556",
"head_commit_message": "Add rcparam for figure label size and weight",
"patch_to_review": "diff --git a/doc/users/next_whats_new/figure_label_rcparams.rst b/doc/users/next_whats_new/figure_label_rcparams.rst\nnew file mode 100644\nindex 000000000000..14... | [
{
"diff_hunk": "@@ -1370,6 +1370,20 @@ def test_kwargs_pass():\n assert sub_fig.get_label() == 'sub figure'\n \n \n+@check_figures_equal(extensions=[\"png\"])\n+def test_rcparams(fig_test, fig_ref):\n+ fig_ref.supxlabel(\"xlabel\", weight='bold', size=15)\n+ fig_ref.supylabel(\"ylabel\", weight='bold'... | 2dfd8203461c3fe60413ef3baae85a3dc64be4bd | diff --git a/doc/users/next_whats_new/figure_label_rcparams.rst b/doc/users/next_whats_new/figure_label_rcparams.rst
new file mode 100644
index 000000000000..149da1e92cf0
--- /dev/null
+++ b/doc/users/next_whats_new/figure_label_rcparams.rst
@@ -0,0 +1,10 @@
+Allow setting figure label size and weight globally and sepa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
mlflow__mlflow-15953@949a1bd | mlflow/mlflow | Python | 15,953 | Update dev/show_package_release_dates.py to display release time as well as date | The `dev/show_package_release_dates.py` script previously displayed only the release date of installed packages in YYYY-MM-DD format. This update enhances the script to show the complete release timestamp in YYYY-MM-DD HH:MM:SS format for more precise release information.
**Changes made:**
- Modified `get_release_date... | 2025-05-29T02:12:21Z | Update dev/show_package_release_dates.py to display release time as well as date
The dev/show_package_release_dates.py script currently displays the release date of installed packages in the format YYYY-MM-DD. It would be helpful to also display the release time (e.g., YYYY-MM-DD HH:MM:SS) for more precise information.... | [
{
"body": "The dev/show_package_release_dates.py script currently displays the release date of installed packages in the format YYYY-MM-DD. It would be helpful to also display the release time (e.g., YYYY-MM-DD HH:MM:SS) for more precise information.\n\nCurrent output example:\n```\nPackage ... | 557c8e522ec4c058fdf81c2dae4275906a18587f | {
"head_commit": "949a1bdd812b8d7e66e490a728fd885d26b224cf",
"head_commit_message": "Update show_package_release_dates.py to display release time as well as date\n\nCo-authored-by: harupy <17039389+harupy@users.noreply.github.com>",
"patch_to_review": "diff --git a/dev/show_package_release_dates.py b/dev/show_pac... | [
{
"diff_hunk": "@@ -47,9 +47,9 @@ async def main() -> None:\n packages, versions = list(zip(*distributions))\n package_length = get_longest_string_length(packages)\n version_length = get_longest_string_length(versions)\n- release_date_length = len(\"Release Date\")\n- print(\"Package\".ljust(p... | 3c74e69a9017e1ef5e7451bbfd1a7569fbfc15f0 | diff --git a/dev/show_package_release_dates.py b/dev/show_package_release_dates.py
index 047ccee038407..5b51e5f2d559f 100644
--- a/dev/show_package_release_dates.py
+++ b/dev/show_package_release_dates.py
@@ -28,7 +28,7 @@ async def get_release_date(session: aiohttp.ClientSession, package: str, version
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.