commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
087caca42074bccbfc19a1b469cf556ad7390d65 | Xidorn Quan | 2021-06-07T11:39:31 | Bug 1714457 - Make predefined symbolic counter styles not overridable. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D116938 | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index c7854b1ef..f6a8019a9 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -55,7 +55,12 @@ pub fn parse_counter_style_name<'i, 't>(
}
fn is_valid_name_definition(ident: &CustomIdent) -> bool {
- ident.0 != atom!("dec... | 1 | 6 | 1 |
614cb93386f818d4ac934865adbe54578720e3a8 | Emilio Cobos Álvarez | 2021-06-07T10:16:39 | Bug 1713787 - Fix whitespace handling inside CSS variables. r=xidorn
As per w3c/csswg-drafts#881 and w3c/csswg-drafts#774.
Differential Revision: https://phabricator.services.mozilla.com/D116459 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index a36fd68f2..667fc687f 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -318,11 +318,6 @@ fn parse_declaration_value<'i, 't>(
missing_closing_characters: &mut String,
) -> Result<(TokenSerializationType, TokenSeria... | 3 | 20 | 55 |
55835d0e736c6188953fb8e433b558d71f8e1060 | Csoregi Natalia | 2021-06-07T10:55:29 | Backed out 5 changesets (bug 1711479) for multiple failures e.g. test_css-properties-db.js. CLOSED TREE
Backed out changeset f1b19a0463cd (bug 1711479)
Backed out changeset 3d1d2b4a2713 (bug 1711479)
Backed out changeset 4e689776fe5d (bug 1711479)
Backed out changeset 85b6b2648f60 (bug 1711479)
Backed out changeset a1... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index a88aec3b6..7a864c06d 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1008,7 +1008,26 @@ fn static_assert() {
${impl_simple("font_variant_alternates", "mFont.variantAlternates")}
- ${impl_s... | 5 | 99 | 98 |
b864d6c65586ac001efb2b902297ca02c964994b | Jonathan Kew | 2021-06-07T08:58:12 | Bug 1711479 - Implement CSS support for the optional adjustment-basis metric keywords for the font-size-adjust property (enabled on Nightly only for now). r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D115596 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 7a864c06d..a88aec3b6 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1008,26 +1008,7 @@ fn static_assert() {
${impl_simple("font_variant_alternates", "mFont.variantAlternates")}
- pub fn s... | 5 | 98 | 99 |
d80c42d7d5d2846a3fe161e97ac0bf8eaa6c8cdc | Butkovits Atila | 2021-06-06T21:31:38 | Backed out changeset 1a6ee358d131 (bug 1714457) for causing failures at redefine-attr-mapping.html. CLOSED TREE | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index f6a8019a9..c7854b1ef 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -55,12 +55,7 @@ pub fn parse_counter_style_name<'i, 't>(
}
fn is_valid_name_definition(ident: &CustomIdent) -> bool {
- ident.0 != atom!("dec... | 1 | 1 | 6 |
15a46823e39a244016a0d5aa161b18501b3216af | Narcis Beleuzu | 2021-06-06T14:16:55 | Backed out 2 changesets (bug 1713787) for wpt failures on declarations-trim-whitespace.html . CLOSED TREE
Backed out changeset 1ddacb243ae6 (bug 1713787)
Backed out changeset 2dc1eff1effd (bug 1713787) | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 667fc687f..a36fd68f2 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -318,6 +318,11 @@ fn parse_declaration_value<'i, 't>(
missing_closing_characters: &mut String,
) -> Result<(TokenSerializationType, TokenSeria... | 3 | 55 | 20 |
5ee7fcc9df491d18a7cd5fb25907c2150be7dc39 | Emilio Cobos Álvarez | 2021-06-04T12:24:18 | Bug 1713787 - Make custom properties that are IACVT guaranteed-invalid. r=boris
This effectively backs out bug 1623396.
See:
https://github.com/w3c/csswg-drafts/pull/6006
https://drafts.csswg.org/css-variables/#guaranteed-invalid-value
And related discussion. Matches Chrome stable as per https://groups.google.c... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 02e96fb98..a36fd68f2 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -584,8 +584,7 @@ impl<'a> CustomPropertiesBuilder<'a> {
match result {
Ok(new_value) => new_value,
... | 1 | 5 | 20 |
922e3cff55689bfe9db820bbc1a5c703f241dd68 | Emilio Cobos Álvarez | 2021-06-04T10:55:41 | Bug 1467309 - Reserve -- as a custom property name. r=xidorn
I think this should be fairly low risk, let's try to get it done sooner
rather than later.
Differential Revision: https://phabricator.services.mozilla.com/D116456 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 0d0a43223..02e96fb98 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -88,7 +88,7 @@ pub type Name = Atom;
///
/// <https://drafts.csswg.org/css-variables/#typedef-custom-property-name>
pub fn parse_name(s: &str) ->... | 1 | 1 | 1 |
e70cf6127db7f8b4a74e4aec17d97ce91acf3eaf | Emilio Cobos Álvarez | 2021-06-03T17:51:48 | Bug 1714357 - Use a nicer media query for proton context menus. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D116736 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 4c23620dd..0c748e09f 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -590,6 +590,23 @@ fn eval_moz_os_version(
query_value.as_ptr() == os_version
}
+fn eval_moz_windows_non_native_menus(
+ devic... | 1 | 23 | 2 |
1fa1081d50c50faa385838ebd48f20da750c9311 | Emilio Cobos Álvarez | 2021-05-21T00:39:48 | Bug 1709018 - Don't simplify percentages that resolve to lengths in min/max/clamp. r=boris
Those can't be ordered at specified / computed value time, since the
percentage basis could be negative.
Needs tests of course, running through try atm.
Differential Revision: https://phabricator.services.mozilla.com/D115591 | diff --git a/style/values/computed/length_percentage.rs b/style/values/computed/length_percentage.rs
index 098b1abfa..cea2466ce 100644
--- a/style/values/computed/length_percentage.rs
+++ b/style/values/computed/length_percentage.rs
@@ -607,22 +607,11 @@ impl CalcLengthPercentageLeaf {
impl PartialOrd for CalcLengthPe... | 2 | 8 | 15 |
17a5826ccf6166dd4c756be51b8b32ebeee68153 | Emilio Cobos Álvarez | 2021-05-20T08:31:34 | Bug 1711170 - Look at the right element for exportparts in each_applicable_non_document_style_rule_data. r=boris
Otherwise we might not find those rules for invalidation.
Differential Revision: https://phabricator.services.mozilla.com/D115130 | diff --git a/style/dom.rs b/style/dom.rs
index 49cc99469..7ed6d4b33 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -887,7 +887,7 @@ pub trait TElement:
}
}
// TODO: Could be more granular.
- if !shadow... | 1 | 1 | 1 |
0a7770868b4a0ad2d6b6bf3668606474f3c8002b | Emilio Cobos Álvarez | 2021-05-19T09:00:38 | Bug 1707310 - Refactor the author sheet cache to keep alive the relevant StylesheetContents. r=boris
This prevents incorrectly reusing cached results when the contents go
away and new contents are allocated with the same address.
Note that these keep alive transitively everything else under them, so
all other mediali... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index dc89a90cb..e653c9bdd 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -253,6 +253,14 @@ impl<T> Arc<T> {
}
}
+ /// Like from_raw, but returns an addrefed arc instead.
+ #[inline]
+ pub unsafe fn from_raw_addrefed(ptr: *const T) -> Se... | 3 | 126 | 55 |
173052e2d7593525e74bd68edb15f6103bb83602 | Emilio Cobos Álvarez | 2021-05-14T10:45:04 | Bug 1711189 - Avoid returning fmt::Errors for things that are not formatting errors.
They are not. The serialization code already checks if the result is
empty, which can happen for other reasons. This makes the code a bit
more resilient to misuse.
Differential Revision: https://phabricator.services.mozilla.com/D1151... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 6ad3674cb..f5f94ca06 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1486,13 +1486,13 @@ impl ShorthandId {
// shorthand, since it only accepts CSS-wide keywords (... | 1 | 2 | 2 |
8e99ccec764b8869c071022ac9910cced31e1b8d | Emilio Cobos Álvarez | 2021-05-14T10:45:03 | Bug 1711189 - Avoid trying to serialize 'all' with stuff that isn't variable references or CSS wide keywords.
All is special, and that'd cause an error later on.
Differential Revision: https://phabricator.services.mozilla.com/D115132 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index f41dab32b..6ad3674cb 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1537,6 +1537,11 @@ impl ShorthandId {
return None;
}
+ if self == ShorthandId::A... | 1 | 5 | 0 |
7d829e1f23b9445f1e4fd6a1da5b37bd0307e23a | Emilio Cobos Álvarez | 2021-05-12T22:52:28 | Bug 1710643 - Use titlebar colors when using CSD rather than -moz-menubartext. r=stransky
As the titlebar may be different when active / inactive, and have
other colors than a menubar.
Differential Revision: https://phabricator.services.mozilla.com/D114875 | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index ea8b7cb55..693cbd0c9 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -363,6 +363,14 @@ pub enum SystemColor {
#[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
MozColheaderhove... | 1 | 8 | 0 |
a5226b6498f021d62c841d335c344f2d4224c437 | Emilio Cobos Álvarez | 2021-05-12T21:45:18 | Bug 1708384 - Properly hide -moz-context-properties from content. r=dholbert
Depends on D114481
Differential Revision: https://phabricator.services.mozilla.com/D114482 | diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs
index 820b2d25d..b9d55c01b 100644
--- a/style/properties/longhands/inherited_svg.mako.rs
+++ b/style/properties/longhands/inherited_svg.mako.rs
@@ -209,6 +209,9 @@ ${helpers.predefined_type(
"MozContext... | 1 | 3 | 0 |
b1aaa719cb2c5825185c51ad71694c6a92c6133d | Emilio Cobos Álvarez | 2021-05-12T21:45:18 | Bug 1708384 - Properly hide -moz-control-character-visibility from content. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D114481 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 6ff393851..f94786d89 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -337,6 +337,9 @@ ${helpers.predefined_type(
"text::... | 1 | 3 | 0 |
5767bcd0d10fff07256b19e4926faaa96fa7ab43 | Emilio Cobos Álvarez | 2021-05-12T19:13:21 | Bug 1710643 - Remove support for unused gtk infobar widget and colors. r=stransky
Presumably they were for notifications and now we use native notifications?
Differential Revision: https://phabricator.services.mozilla.com/D114874 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index e06e162a4..103e891d1 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1826,8 +1826,6 @@ pub enum Appearance {
#[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
MozWindowTitlebarMaximiz... | 2 | 0 | 4 |
1b56f986ccd540179eb3ffe42e3ba92f48dfe1c9 | Emilio Cobos Álvarez | 2021-05-12T10:15:37 | Bug 1709415 - Support -webkit-image-set as a parse-time alias to image-set(). r=karlcow,twisniewski
The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.
If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict... | diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs
index 19a041f61..1b770a07c 100644
--- a/style/values/specified/image.rs
+++ b/style/values/specified/image.rs
@@ -365,7 +365,14 @@ impl ImageSet {
cors_mode: CorsMode,
only_url: bool,
) -> Result<Self, ParseError<'i>> ... | 1 | 8 | 1 |
f8983cd2bdc63be2f8fe48ed0d9e544ab8b1b883 | Emilio Cobos Álvarez | 2021-05-10T13:09:42 | Bug 1707170 - Will-change should only create stacking contexts / containing blocks / etc if the property it'd change would apply. r=miko
As per https://drafts.csswg.org/css-will-change/#will-change.
> If any non-initial value of a property would cause the element to
> generate a containing block for absolutely positi... | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 73a2ec870..f2d0234a9 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -48,7 +48,6 @@ ${helpers.single_keyword(
engines="gecko servo-2013 servo-2020"
animation_v... | 6 | 49 | 58 |
a7be98fda6d076cc159db93be00dda587e1d2b6d | Emilio Cobos Álvarez | 2021-05-06T09:57:19 | Bug 1709647 - Remove unused NS_CHANGE_COLOR_IF_SAME_AS_BG. r=jfkthame
It was introduced in bug 1024930, but it is unused since.
Differential Revision: https://phabricator.services.mozilla.com/D114389 | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index 3a5eae286..8101a8f6b 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -174,8 +174,6 @@ pub enum SystemColor {
#[css(skip)]
TextSelectForeground,
#[css(skip)]
- TextSelectForeground... | 1 | 0 | 2 |
7024016a37a71f1a1199071948b7b2cbfdf17612 | Emilio Cobos Álvarez | 2021-05-03T11:40:26 | Bug 1707720 - Use saturating addition for math-depth. r=fredw
Differential Revision: https://phabricator.services.mozilla.com/D114070 | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index df6a8ed66..0bd177bcc 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -828,14 +828,14 @@ impl ToComputedValue for specified::MathDepth {
let parent = cx.builder.get_parent_font().clone_math... | 1 | 2 | 2 |
d1d0e46411cdaee93e8f951113751aa95b59134e | Xidorn Quan | 2021-05-02T03:27:50 | Bug 1708897 - Remove layout.css.ruby.position-alternate.enabled pref. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D114044 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 666472796..6ff393851 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -304,7 +304,7 @@ ${helpers.single_keyword(
${helpers.pr... | 2 | 3 | 16 |
ed358f8099637fd5aa737d75e023cfa25312ba90 | Emilio Cobos Álvarez | 2021-05-01T21:04:47 | Bug 1708063 - Don't allow whitespace between media query operator delim tokens. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D113648 | diff --git a/style/media_queries/media_feature_expression.rs b/style/media_queries/media_feature_expression.rs
index 10bf16500..1658439da 100644
--- a/style/media_queries/media_feature_expression.rs
+++ b/style/media_queries/media_feature_expression.rs
@@ -196,23 +196,37 @@ fn consume_operation_or_colon(input: &mut Par... | 1 | 30 | 16 |
a8928fd18cfd9f288ed7774a1511d856b60a3021 | Csoregi Natalia | 2021-04-28T15:09:01 | Backed out changeset e01ec8694924 (bug 1700957) as requested. CLOSED TREE | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index a9c813d79..4c23620dd 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -663,7 +663,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 2 | 1 |
f965ae1a992292bae52d954ba6025e1eda6372db | imoraru | 2021-04-28T13:08:31 | Backed out changeset d3056dc50fe3 (bug 1707614) for causing devtools failures at browser_rules_colorpicker-release-outside-frame.js . CLOSED TREE | diff --git a/style/element_state.rs b/style/element_state.rs
index 1fd9f8f11..8a9f4065b 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -122,9 +122,11 @@ bitflags! {
const IN_MOZINERT_STATE = 1 << 43;
/// State for the topmost dialog element in top layer
const IN_TOPMOST_M... | 3 | 7 | 3 |
d4e45ba1635412246c11afccd189c381c9a443a2 | Emilio Cobos Álvarez | 2021-04-28T10:01:23 | Bug 1707614 - Don't use -moz-devtools-highlighted for background contrast checks in the accessibility inspector. r=nchevobbe
It's the wrong pseudo-class name! Plus, it's not really needed, just
override the page styles temporarily.
Remove the pseudo-class, since it's its only remaining usage.
Differential Revision: ... | diff --git a/style/element_state.rs b/style/element_state.rs
index 8a9f4065b..1fd9f8f11 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -122,11 +122,9 @@ bitflags! {
const IN_MOZINERT_STATE = 1 << 43;
/// State for the topmost dialog element in top layer
const IN_TOPMOST_M... | 3 | 3 | 7 |
44207cd4257be89501fdfecd54e9714507a5af12 | Emma Malysz | 2021-04-28T03:17:56 | Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110135 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 4c23620dd..a9c813d79 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -663,7 +663,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 1 | 2 |
fdcfd07e4a66a4e18f721c436f173ac666fd4e7e | Butkovits Atila | 2021-04-28T02:55:14 | Backed out changeset 1c362512f27b (bug 1700957) for causing failures at test_chrome_only_media_queries.html. CLOSED TREE | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index a9c813d79..4c23620dd 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -663,7 +663,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 2 | 1 |
93e05c5bb230adee5cd066e2288acc0d416859f3 | Emilio Cobos Álvarez | 2021-04-28T00:40:18 | Bug 1707116 - Make sure to consume the flusher when we hit the cascade data cache. r=boris
So that sheets are properly marked as committed. The issue is that we
have this "committed" optimization, to avoid doing work if somebody adds
and removes an stylesheet without us flushing in the meantime:
https://searchfox.o... | diff --git a/style/stylist.rs b/style/stylist.rs
index 25324c9f6..74f47ede6 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -139,6 +139,9 @@ where
debug!(" > {:?}", sheet);
}
}
+ // The line below ensures the "committed" bit is updated properly
+ ... | 1 | 3 | 0 |
8d73ed8c9219324ef4847ce7f642be47cabc3b5a | Emilio Cobos Álvarez | 2021-04-27T16:20:35 | Bug 1707895 - Make the -moz-toolbar-prefers-color-scheme a tri-state. r=mstriemer
This will allow detecting the system theme, which allows fixing some of
the blocked bugs.
Note that when using the system theme we will still match light or dark
appropriately, so this shouldn't change behavior just yet.
Differential R... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index f6703bc9b..4c23620dd 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -406,18 +406,42 @@ fn eval_prefers_color_scheme(device: &Device, query_value: Option<PrefersColorSc
}
}
+/// Values for the -moz... | 1 | 33 | 9 |
20a4e4e15e5f4289077152f05db717482916442a | Emilio Cobos Álvarez | 2021-04-27T10:41:00 | Bug 1705605 - Implement accent-color in nsNativeBasicTheme. r=mstange
This is a new addition for CSS UI Level 4:
https://drafts.csswg.org/css-ui-4/#widget-accent
I want to provide feedback on some spec issues, and thought it was a
kinda neat thing to prototype (it also makes testing contrast and such
with random G... | diff --git a/style/properties/longhands/inherited_ui.mako.rs b/style/properties/longhands/inherited_ui.mako.rs
index 233ef3653..f08abbc62 100644
--- a/style/properties/longhands/inherited_ui.mako.rs
+++ b/style/properties/longhands/inherited_ui.mako.rs
@@ -73,13 +73,26 @@ ${helpers.single_keyword(
${helpers.predefin... | 5 | 66 | 8 |
d052ea20534fcb2d9ce60d333ca48dbe78ad01ac | Emilio Cobos Álvarez | 2021-04-26T15:46:52 | Bug 1707597 - Garbage-collect event state bits. r=smaug
We had about 9 gaps / unused bits. I moved the devtools ones at the end
because I think we should be able to remove them (but separate bug).
Differential Revision: https://phabricator.services.mozilla.com/D113365 | diff --git a/style/element_state.rs b/style/element_state.rs
index 853d4039b..8a9f4065b 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -54,84 +54,79 @@ bitflags! {
/// Non-standard: https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-broken
const IN_BROKEN_STATE = 1 << 14;
... | 2 | 39 | 44 |
6a7e55d303873f68474c65fa10e5c90f94beb8e1 | Emilio Cobos Álvarez | 2021-04-21T13:39:13 | Bug 1706223 - Fix whitespace handling in clamp() parsing. r=xidorn
We should just restore the state when seeing whitespace and an unknown
token like when we do when finding any other token a few lines below.
This is not an issue for most callers (it's only an issue for clamp())
because the other callers use either `p... | diff --git a/style/values/specified/calc.rs b/style/values/specified/calc.rs
index eb8b2fe42..808e2fb49 100644
--- a/style/values/specified/calc.rs
+++ b/style/values/specified/calc.rs
@@ -373,9 +373,9 @@ impl CalcNode {
rhs.negate();
sum.push(rhs);
... | 1 | 3 | 3 |
cbd0e5b60d9f029fc461c348b964673a21b398df | Mark Striemer | 2021-04-18T22:22:49 | Bug 1701691 - -moz-toolbar-prefers-color-scheme for dark theme detection r=desktop-theme-reviewers,emilio,harry
This adds a new @media query -moz-toolbar-prefers-color-scheme which works like
prefers-color-scheme but is set based on the browser theme rather than the OS
theme. The background colour of the toolbar is us... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 287ab6a17..f6703bc9b 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -406,6 +406,21 @@ fn eval_prefers_color_scheme(device: &Device, query_value: Option<PrefersColorSc
}
}
+/// The color-scheme of ... | 1 | 22 | 1 |
4426f7ce0d416f70bb4185b7e0a06cd3e1d4cf34 | Pierre TALLOTTE | 2021-04-16T20:58:59 | Bug 1695404 - Support the type() function in image-set. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D109201 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index a116121a2..503eb1e07 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -360,4 +360,11 @@ impl Device {
};
SideOffsets2D::new(top, right, bottom, left)
}
+
+ /// Returns true if the give... | 4 | 71 | 8 |
d2b0ec5cf0035c5ab5da864216984ae4720aa57e | Noemi Erli | 2021-04-16T02:29:10 | Backed out changeset 1c9943dacbdb (bug 1701691) for causing failures in browser_toolbar_prefers_color_scheme.js CLOSED TREE | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index f6703bc9b..287ab6a17 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -406,21 +406,6 @@ fn eval_prefers_color_scheme(device: &Device, query_value: Option<PrefersColorSc
}
}
-/// The color-scheme of ... | 1 | 1 | 22 |
b32a9a493c6222101719a9bc67cf6795a877036a | Emilio Cobos Álvarez | 2021-04-16T01:01:45 | Bug 1705509 - Hide -moz-outline-radius behind a pref. r=mstange
This property does nothing since bug 315209 got implemented.
Every single user that I checked was doing the same math by hand, so
hooray for good defaults :-)
Differential Revision: https://phabricator.services.mozilla.com/D112253 | diff --git a/style/properties/longhands/outline.mako.rs b/style/properties/longhands/outline.mako.rs
index 9789797f4..aa5a7ce32 100644
--- a/style/properties/longhands/outline.mako.rs
+++ b/style/properties/longhands/outline.mako.rs
@@ -53,6 +53,7 @@ ${helpers.predefined_type(
engines="gecko",
boxed=T... | 2 | 2 | 0 |
d054874b3b6bcd2c8c17e4c26d1b0896a1f45e50 | Csoregi Natalia | 2021-04-15T19:18:09 | Backed out changeset 79c1392f7c43 (bug 1701691) for failures on browser_toolbar_prefers_color_scheme.js. CLOSED TREE | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index f6703bc9b..287ab6a17 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -406,21 +406,6 @@ fn eval_prefers_color_scheme(device: &Device, query_value: Option<PrefersColorSc
}
}
-/// The color-scheme of ... | 1 | 1 | 22 |
b703e61f4fd54fc912b836e684e846fe3f12877d | Emilio Cobos Álvarez | 2021-04-15T09:33:58 | Bug 1704179 - Add a CSS error to the console when using non-featureless :host selectors. r=boris
(which would never match by definition).
Differential Revision: https://phabricator.services.mozilla.com/D111610 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index d59ea19b9..732a34a5b 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -842,7 +842,7 @@ impl<'a, Impl: 'a + SelectorImpl> SelectorIter<'a, Impl> {
#[inline]
pub(crate) fn is_featureless_host_selector(&mut self) -> bool {
self.se... | 3 | 51 | 3 |
1f087a25ba2e345fd0fb98f75f2235e71965081e | Morgan Reschenberg | 2021-04-14T21:33:11 | Bug 1705168: Enable forced-colors in UA and chrome always r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D112069 | diff --git a/style/media_queries/media_feature_expression.rs b/style/media_queries/media_feature_expression.rs
index 41be485d5..10bf16500 100644
--- a/style/media_queries/media_feature_expression.rs
+++ b/style/media_queries/media_feature_expression.rs
@@ -221,7 +221,11 @@ fn disabled_by_pref(feature: &Atom, context: &... | 1 | 5 | 1 |
5eb6ade4e96d2cb291428f1e72c642f573aed89d | Emilio Cobos Álvarez | 2021-04-13T10:53:40 | Bug 1704551 - Add attribute names to the bloom filter. r=boris
Safari does this. This reduces the runtime in the example linked from
comment 0 quite a lot (40ms on a local opt build, from ~130ms on a
release nightly build).
I added a pref because there's a slight chance of performance
regressions on pages that do not... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index b562b8b55..d59ea19b9 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -209,6 +209,12 @@ macro_rules! with_all_bounds {
/// pseudo-elements
type PseudoElement: $($CommonBounds)* + PseudoElement<Impl = Self>;
+
+ ... | 5 | 96 | 8 |
e65b2830300245c89dc101c98728203cf079b7ca | Emilio Cobos Álvarez | 2021-04-11T17:39:12 | Bug 1704332 - Remove various image-orientation related prefs. r=tnikkel
These shipped in 77.
Differential Revision: https://phabricator.services.mozilla.com/D111550 | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index 32f9819a4..cea3fde02 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -84,8 +84,7 @@ ${helpers.single_keyword(
${helpers.single... | 1 | 1 | 2 |
4d07d967508bcc826a9121f03cb65a20396eaa35 | Mark Striemer | 2021-04-11T17:28:02 | Bug 1702330 - Remove -moz-proton-infobars media query support r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D110963 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index a3000f46b..287ab6a17 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -624,7 +624,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 1 | 2 |
cf1d173ad00a53529a6b367038801c99dc27b06d | Marco Bonardo | 2021-04-09T18:20:21 | Bug 1703274 - Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl
Differential Revision: https://phabricator.services.mozilla.com/D110998 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 62d674aa3..a3000f46b 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -624,7 +624,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 1 | 2 |
4b63262449dbd7b67817afb8ba3fc2f0218bb511 | Emilio Cobos Álvarez | 2021-04-09T18:02:49 | Bug 1704155 - Remove dead prefers-color-scheme: no preference code. r=dholbert
It was removed in bug 1643656.
Differential Revision: https://phabricator.services.mozilla.com/D111461 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index a47783e5c..62d674aa3 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -275,10 +275,6 @@ enum PrefersReducedMotion {
Reduce,
}
-fn color_scheme_no_preference_enabled(_: &crate::parser::ParserContext)... | 1 | 1 | 7 |
edd81fa9c9abc55fedf7051f5f0b156423838700 | Dorel Luca | 2021-04-09T17:21:35 | Backed out 8 changesets (bug 1702330)for Browser-chrome failures in est/popups/browser_popup_blocker.js. CLOSED TREE
Backed out changeset b81511f8e157 (bug 1702330)
Backed out changeset 15f60f1d3f14 (bug 1702330)
Backed out changeset 809af1f94b4b (bug 1702330)
Backed out changeset 63cec3eadb4f (bug 1702330)
Backed out... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 7215f9bae..a47783e5c 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -630,7 +630,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 2 | 1 |
8a296c90997211f657b58c9011933f3d54709668 | Mark Striemer | 2021-04-09T15:26:25 | Bug 1702330 - Remove -moz-proton-infobars media query support r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D110963 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index a47783e5c..7215f9bae 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -630,7 +630,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 1 | 2 |
76b700129fe51b640850bbcc2233f955d31dd9b8 | Cosmin Sabou | 2021-04-09T14:51:48 | Backed out changeset bd396182f84a (bug 1703274) for causing wpt failures on shape-outside-shape-arguments-000.html. CLOSED TREE | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index e833fcf8e..a47783e5c 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -630,7 +630,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 2 | 1 |
0e9b50028cac3313f3f949e7cdba2aecffe60170 | Marco Bonardo | 2021-04-09T11:05:17 | Bug 1703274 - Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl
Differential Revision: https://phabricator.services.mozilla.com/D110998 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index a47783e5c..e833fcf8e 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -630,7 +630,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 1 | 2 |
7d387511c86472ab6e3733bf2fe010d281951c63 | Alexandru Michis | 2021-04-09T00:34:23 | Backed out 5 changesets (bug 1702330) for causing failures in browser_aboutNewTab_defaultBrowserNotification.js
CLOSED TREE
Backed out changeset 365fd1bb6dde (bug 1702330)
Backed out changeset eba73c72be18 (bug 1702330)
Backed out changeset e1277c21543f (bug 1702330)
Backed out changeset 907e4fcda266 (bug 1702330)
Ba... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 7215f9bae..a47783e5c 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -630,7 +630,7 @@ macro_rules! bool_pref_feature {
/// to support new types in these entries and (2) ensuring that either
/// nsPresCon... | 1 | 2 | 1 |
f3e2390e7ab3e06f6e810c7eab5020af426f5092 | David Parks | 2021-04-06T19:28:18 | Bug 1682030 - Clean up NPAPI plugin fallback behavior. r=jmathies,emilio
Similifies use of EventStates and ObjectType/FallbackType enums since most states they represented are no longer valid with the removal of NPAPI plugins. The state machine for (unsupported) plugin elements is now much simpler but still distingu... | diff --git a/style/element_state.rs b/style/element_state.rs
index 0852b4574..853d4039b 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -132,8 +132,6 @@ bitflags! {
const IN_MOZINERT_STATE = 1 << 54;
/// State for the topmost dialog element in top layer
const IN_TOPMOST_MO... | 1 | 0 | 2 |
a3c56bf3f0e1e8e662ac3f10fd01133b531206d6 | Emilio Cobos Álvarez | 2021-04-06T09:55:01 | Bug 1703018 - Reduce boilerplate needed to add system-metric media features. r=boris
There's no reason we can't just query LookAndFeel and we need to use
sSystemMetrics. In the past, LookAndFeel queries were not cached, but
this is no longer the case, so perf wise should be pretty equivalent.
Note that we don't need ... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index c76968be5..a47783e5c 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -541,22 +541,6 @@ fn eval_moz_is_resource_document(
query_value.map_or(is_resource_doc, |v| v == is_resource_doc)
}
-fn eval_sys... | 1 | 57 | 49 |
790119e436c082f92f19eb297977cba335461d81 | Csoregi Natalia | 2021-04-06T00:54:12 | Backed out 24 changesets (bug 1682030) for bustage on ProcessHangMonitor.cpp and nsCOMPtr.h. CLOSED TREE
Backed out changeset 5b1644096477 (bug 1682030)
Backed out changeset 35ae60eea3c7 (bug 1682030)
Backed out changeset 3eca76a6d639 (bug 1682030)
Backed out changeset 259c45447ad9 (bug 1682030)
Backed out changeset d... | diff --git a/style/element_state.rs b/style/element_state.rs
index 853d4039b..0852b4574 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -132,6 +132,8 @@ bitflags! {
const IN_MOZINERT_STATE = 1 << 54;
/// State for the topmost dialog element in top layer
const IN_TOPMOST_MO... | 1 | 2 | 0 |
b6f5c96db31a47f51747069303c00843d79cac2c | Emilio Cobos Álvarez | 2021-04-05T20:48:05 | Bug 1698132 - Convert proton pref checks from @supports rules to media features. r=Gijs
This means that dynamic changes will be handled correctly, we can use
StaticPrefs, etc.
Differential Revision: https://phabricator.services.mozilla.com/D110816 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index bfc78b84b..c76968be5 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -584,6 +584,31 @@ macro_rules! system_metric_feature {
)
}
+ feature!(
+ $feature_name,
+ ... | 1 | 34 | 1 |
d272a427edda7ff97035a3ba5dc08bc3c64fe851 | Neil Deakin | 2021-04-01T00:13:09 | Bug 1700148, add an appearance type that forces a dropshadow on menus on Windows, and uses SetWindowRgn to clip the popup to the border radius, r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D109833 | diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs
index 1dfdfcc1a..400eaedf5 100644
--- a/style/properties/longhands/ui.mako.rs
+++ b/style/properties/longhands/ui.mako.rs
@@ -53,7 +53,7 @@ ${helpers.single_keyword(
${helpers.single_keyword(
"-moz-window-shadow",
- "d... | 1 | 1 | 1 |
fdb9a7a076cbd1b1a884e4287e1461bfd23a4b22 | Jonathan Kew | 2021-03-29T21:14:43 | Bug 1698495 - Add the size-adjust descriptor to the style system. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D110022 | diff --git a/style/font_face.rs b/style/font_face.rs
index 075507386..5d59df2df 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -21,7 +21,7 @@ use crate::values::specified::font::SpecifiedFontStyle;
use crate::values::specified::font::SpecifiedFontVariationSettings;
use crate::values::specified::font::{Ab... | 2 | 15 | 1 |
86580e6c367bac369890df194f6204434f2839cd | Emilio Cobos Álvarez | 2021-03-24T22:57:37 | Bug 1699088 - Use a single system font definition rather than two. r=cmartin
Follow the pattern we use for system colors.
Differential Revision: https://phabricator.services.mozilla.com/D108822 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 30eaac343..c3987874d 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -554,7 +554,7 @@
keyword = keyword=Keyword(name, values, **keyword_kwargs)
%>
<%call expr="longhand(name,... | 5 | 168 | 197 |
a55b1cb6c3248e3740516251fb8f7d5018004e62 | Jonathan Kew | 2021-03-23T17:10:22 | Bug 1681691 - Add ascent-, descent- and line-gap-override descriptors to the style system. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D109287 | diff --git a/style/font_face.rs b/style/font_face.rs
index 52cebcb9d..075507386 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -19,7 +19,7 @@ use crate::values::specified::font::SpecifiedFontFeatureSettings;
use crate::values::specified::font::SpecifiedFontStyle;
#[cfg(feature = "gecko")]
use crate::val... | 2 | 50 | 1 |
9b183597eaa39fe9cf3f026bb302a63b75e27a2b | Jonathan Kew | 2021-03-23T17:10:22 | Bug 1681691 - Convert the font-stretch descriptor to use NonNegativePercentage. r=emilio
Depends on D109285
Differential Revision: https://phabricator.services.mozilla.com/D109286 | diff --git a/style/font_face.rs b/style/font_face.rs
index 24204efc1..52cebcb9d 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -194,7 +194,7 @@ impl FontStretchRange {
fn compute_stretch(s: &FontStretch) -> f32 {
match *s {
FontStretch::Keyword(ref kw) => kw.compute()... | 3 | 7 | 28 |
d793d7344ea7dfef2c5216a26761ea5a61b2c516 | Jonathan Kew | 2021-03-23T17:10:21 | Bug 1681691 - Create a NonNegativePercentage type in values:specified. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D109285 | diff --git a/style/values/specified/mod.rs b/style/values/specified/mod.rs
index 946bf3c2c..6341d495d 100644
--- a/style/values/specified/mod.rs
+++ b/style/values/specified/mod.rs
@@ -71,7 +71,7 @@ pub use self::list::Quotes;
pub use self::motion::{OffsetPath, OffsetRotate};
pub use self::outline::OutlineStyle;
pub... | 2 | 15 | 1 |
b92302395c4753cb9ad36263ede68710a388673d | smolnar | 2021-03-23T10:00:39 | Backed out 8 changesets (bug 1681691) for causing wpt failures in idlharness.https.html. CLOSED TREE
Backed out changeset dda736a69ceb (bug 1681691)
Backed out changeset 64edecd0df6f (bug 1681691)
Backed out changeset a19844063d00 (bug 1681691)
Backed out changeset 5dd06c73f703 (bug 1681691)
Backed out changeset 1bc40... | diff --git a/style/font_face.rs b/style/font_face.rs
index 075507386..24204efc1 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -19,7 +19,7 @@ use crate::values::specified::font::SpecifiedFontFeatureSettings;
use crate::values::specified::font::SpecifiedFontStyle;
#[cfg(feature = "gecko")]
use crate::val... | 5 | 30 | 72 |
95a75c7b001a51df7be6e1e7b4ac31606b7be6e9 | Cosmin Sabou | 2021-03-22T18:37:38 | Backed out 10 changesets (bug 1681691) for wpt failures on fontface-override-descriptor-getter-setter.sub.html and idlharness.https.html. CLOSED TREE
Backed out changeset e43fba82fb31 (bug 1681691)
Backed out changeset 104675869016 (bug 1681691)
Backed out changeset 536bbc4b9ecd (bug 1681691)
Backed out changeset bb53... | diff --git a/style/font_face.rs b/style/font_face.rs
index 075507386..24204efc1 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -19,7 +19,7 @@ use crate::values::specified::font::SpecifiedFontFeatureSettings;
use crate::values::specified::font::SpecifiedFontStyle;
#[cfg(feature = "gecko")]
use crate::val... | 5 | 30 | 72 |
63d0b97ff46e0b74ccb3bcd167a2777e24b04018 | Markus Stange | 2021-03-17T16:50:08 | Bug 1697338 - Remove unused -moz-default-appearance values -moz-mac-vibrancy-light/dark, and the system colors of the same name. r=emilio
Starting with macOS 10.14, the generic light/dark vibrancy is deprecated, and semantic vibrancy names are preferred.
If we ever need more vibrancy, we can add new values with semant... | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index b3a49d17b..cbd6ce70b 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1829,10 +1829,6 @@ pub enum Appearance {
#[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
MozMacSourceListSelecti... | 2 | 0 | 6 |
18c0632efd1d4e37ba9d47608a5781d19e429bd2 | Emilio Cobos Alvarez | 2021-03-16T20:09:56 | Bug 1698272 - Respect system colors in the color and background-color properties. r=morgan
The reason why this doesn't work is because these styles come from
datetimebox.css, which is really an author style.
We could special-case these elements, but the approach that the CSSWG resolved
on for the new forced-colors sp... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 0199caf4a..781f1a31f 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -423,6 +423,10 @@ fn tweak_when_ignoring_colors(
// A few special-cases ahead.
match **declaration {
PropertyDeclaration::Bac... | 2 | 13 | 1 |
316bededf017171153d6830a6b7a6b5dd203b9ff | Emilio Cobos Álvarez | 2021-03-15T21:05:01 | Bug 1697998 - Invalidate a bit more aggressively when a pseudo-element matches, in order to also invalidate the cached pseudo-styles on the parent. r=mats
This should probably be fine. If it becomes a perf issue somehow we can
implement the RESTYLE_PSEUDOS hint or what not.
Differential Revision: https://phabricator.... | diff --git a/style/invalidation/element/invalidator.rs b/style/invalidation/element/invalidator.rs
index c148b63e3..79131a800 100644
--- a/style/invalidation/element/invalidator.rs
+++ b/style/invalidation/element/invalidator.rs
@@ -20,10 +20,10 @@ pub trait InvalidationProcessor<'a, E>
where
E: TElement,
{
- ... | 2 | 31 | 75 |
15638992267678589b4302cb954cbe739a27f3fd | Emilio Cobos Alvarez | 2021-03-15T20:59:42 | Bug 1698291 - Make -moz-accent-color reflect the windows accent color. r=dao
And remove the windows-specific versions of this color.
Also fix the hard-coded defaults by the colors I get in the default windows
theme.
Differential Revision: https://phabricator.services.mozilla.com/D108325 | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index 74e4ce39b..cdb31e812 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -337,10 +337,6 @@ pub enum SystemColor {
#[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
MozAccentColorFo... | 1 | 0 | 4 |
4709f05e1dd60adfa480008b4d0298b0d7366fd1 | Emilio Cobos Álvarez | 2021-03-11T18:23:01 | Bug 1697842 - Don't specify a rayon minor version in Cargo.toml. r=jrmuizel
This will allow us to not change these files if we need to change the
rayon version to fix stability issues like bug 1694671.
Differential Revision: https://phabricator.services.mozilla.com/D108042 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 95ebd60c1..e8d47ce73 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -59,7 +59,7 @@ num-derive = "0.3"
owning_ref = "0.4"
parking_lot = "0.11"
precomputed-hash = "0.1.1"
-rayon = "1.5"
+rayon = "1"
selectors = { path = "../selectors" }
serde = {version... | 1 | 1 | 1 |
409e95fb0c7bd849fddac34616be5b108a5b45a3 | Emilio Cobos Álvarez | 2021-03-10T12:34:09 | Bug 1696447 - Share CascadeData instances across ShadowRoots. r=boris
This should be both a memory and speed win for pages using a lot of
Shadow DOM.
In order to make the cache properly work we need to start keying media query
results on the actual StyleSheetContents, as that's what we share on Gecko, but
that should... | diff --git a/style/author_styles.rs b/style/author_styles.rs
index 58d9bda42..dfd33711e 100644
--- a/style/author_styles.rs
+++ b/style/author_styles.rs
@@ -5,16 +5,16 @@
//! A set of author stylesheets and their computed representation, such as the
//! ones used for ShadowRoot.
-use crate::context::QuirksMode;
us... | 11 | 175 | 178 |
790a72ea04b3876874931a27b06bdb45823ae5a3 | Emilio Cobos Álvarez | 2021-03-10T12:34:09 | Bug 1696447 - Make the cascade data cache generic. r=boris
We're going to use it both for UA sheets and for author styles in Shadow
DOM.
Differential Revision: https://phabricator.services.mozilla.com/D107265 | diff --git a/style/stylesheet_set.rs b/style/stylesheet_set.rs
index 9e858a456..d392d1795 100644
--- a/style/stylesheet_set.rs
+++ b/style/stylesheet_set.rs
@@ -184,7 +184,9 @@ pub struct SheetCollectionFlusher<'a, S>
where
S: StylesheetInDocument + PartialEq + 'static,
{
- iter: slice::IterMut<'a, Stylesheet... | 2 | 158 | 78 |
2306b9f963aca81c821a953950100bf01d99598c | Emilio Cobos Álvarez | 2021-03-08T23:29:30 | Bug 1696409 - Paper over a crash in non-nightly. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D107400 | diff --git a/style/context.rs b/style/context.rs
index 608e58ea0..238208456 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -117,21 +117,6 @@ impl Default for StyleSystemOptions {
}
}
-impl StyleSystemOptions {
- #[cfg(feature = "servo")]
- /// On Gecko's nightly build?
- pub fn is_nightly(&sel... | 2 | 15 | 16 |
c65c85208bc5667956bbcde2b1d3e0c371cc156e | Micah Tigley | 2021-03-08T23:27:49 | Bug 1695403 - Support image-set in the content property. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D107397 | diff --git a/style/values/computed/counters.rs b/style/values/computed/counters.rs
index 40cfe46ef..1ae46c772 100644
--- a/style/values/computed/counters.rs
+++ b/style/values/computed/counters.rs
@@ -4,7 +4,7 @@
//! Computed values for counter properties
-use crate::values::computed::url::ComputedImageUrl;
+use c... | 3 | 32 | 16 |
86b23607f9cec8605f12b22b7688bf8577b2f5af | Micah Tigley | 2021-03-07T21:38:20 | Bug 1696677 - Have collect_completion_keywords return `url` and `image-set` for CursorImage. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D107381 | diff --git a/style/values/specified/ui.rs b/style/values/specified/ui.rs
index d37fe6479..4594cbfcc 100644
--- a/style/values/specified/ui.rs
+++ b/style/values/specified/ui.rs
@@ -11,7 +11,7 @@ use crate::values::specified::image::Image;
use crate::values::specified::Number;
use cssparser::Parser;
use std::fmt::{se... | 1 | 6 | 3 |
19dc5a505684b0fb52aff9d2d81b48264425c766 | Emilio Cobos Álvarez | 2021-03-05T02:30:23 | Bug 1696434 - Address spec changes re. color-mix. r=boris,desktop-theme-reviewers
It was clarified that the percentages are weights, and two weights are
now allowed. Missing percentages are computed as 100% - the other or
50%. Other than that, commas are required etc, which is good since
that's how I implemented it or... | diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs
index 77091da01..773310dd9 100644
--- a/style/values/animated/color.rs
+++ b/style/values/animated/color.rs
@@ -105,8 +105,44 @@ impl Color {
}
/// Mix two colors into one.
- pub fn mix(left: &Color, right: &Color, progress: f32... | 2 | 82 | 10 |
53fb27d2678919ea85d41d8b21af4214d54f5ec1 | Micah Tigley | 2021-03-03T18:34:46 | Bug 1695402 - Support image-set() on the cursor property. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D106745 | diff --git a/style/values/computed/ui.rs b/style/values/computed/ui.rs
index ae12dfcda..562b7d158 100644
--- a/style/values/computed/ui.rs
+++ b/style/values/computed/ui.rs
@@ -5,7 +5,7 @@
//! Computed values for UI properties
use crate::values::computed::color::Color;
-use crate::values::computed::url::ComputedIma... | 4 | 49 | 20 |
271f3d36e7882f53ead31112bbe96a170b0b3a59 | Csoregi Natalia | 2021-03-03T17:54:08 | Backed out changeset 78567f53575e (bug 1695402) for failures on test_css-properties-db.js. CLOSED TREE | diff --git a/style/values/computed/ui.rs b/style/values/computed/ui.rs
index 562b7d158..ae12dfcda 100644
--- a/style/values/computed/ui.rs
+++ b/style/values/computed/ui.rs
@@ -5,7 +5,7 @@
//! Computed values for UI properties
use crate::values::computed::color::Color;
-use crate::values::computed::image::Image;
+u... | 4 | 20 | 49 |
a0e2aa4f9615c2aa92db6e2f33da9a51b7aeffce | Emilio Cobos Álvarez | 2021-03-03T16:35:53 | Bug 1695376 - Implement basic color-mix() functionality, behind a pref, but exposed to chrome code. r=boris
This is straight-forward and builds on the color animation code. This
implements only the <percentage> syntax, not the whole <color-adjuster>
syntax, which seems fairly more complex.
Of course, this only uses s... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index acfdfc514..0199caf4a 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -386,13 +386,15 @@ where
type DeclarationsToApplyUnlessOverriden = SmallVec<[PropertyDeclaration; 2]>;
fn tweak_when_ignoring_colors(
- b... | 3 | 108 | 38 |
3bb9ec45a9bfce9a393be18d038f609a3e1646ce | Emilio Cobos Álvarez | 2021-03-02T12:11:35 | Bug 1695390 - Move extremum lengths to the individual Size / MaxSize types. r=boris
This will prevent growing them when introducing fit-content(<length>).
This can _almost_ be derived, if it wasn't because of the quirky stuff.
I think the macro is probably good enough for now but let me know if you
disagree.
Differe... | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index 0908273b8..bcba3eb9b 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -185,7 +185,10 @@ impl Size {
GenericSize::Auto => false,
GenericSize::LengthPercentage(ref lp) => lp.... | 4 | 44 | 58 |
68fe800ddfdce3b96e3e33cbdb7ed0cae9d6e18a | Brindusan Cristian | 2021-03-02T11:41:40 | Backed out changeset be6d9849825d (bug 1695390) for wr failures in col-definite-max-size-001.html. CLOSED TREE | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index bcba3eb9b..0908273b8 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -185,10 +185,7 @@ impl Size {
GenericSize::Auto => false,
GenericSize::LengthPercentage(ref lp) => lp.... | 4 | 58 | 44 |
9dd1a91c665ff8b7bc9d467bfac6716c1287f1b7 | Emilio Cobos Álvarez | 2021-03-01T16:05:14 | Bug 1695369 - Simplify StyleColor representation. r=jwatt
There's no need for CurrentColor / Numeric variants when we can
represent them with the complex form.
Differential Revision: https://phabricator.services.mozilla.com/D106690 | diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs
index 9f4fa5c52..4ef73dda2 100644
--- a/style/values/animated/color.rs
+++ b/style/values/animated/color.rs
@@ -35,17 +35,14 @@ impl RGBA {
#[inline]
pub fn new(red: f32, green: f32, blue: f32, alpha: f32) -> Self {
RGBA {
-... | 5 | 212 | 198 |
6fe62494a27490060ca937d5f04f7f0eb9dac44d | Simon Sapin | 2021-02-25T09:39:53 | Bug 1695165 - Fix warnings introduced in newer Rust Nightly. r=jdm,emilio
This cherry-picks https://github.com/servo/servo/pull/28202
MANUAL PUSH: Otherwise review information gets lost. | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 1e9366093..1f034cad9 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -279,7 +279,7 @@ impl<'a> BuilderWithConfig<'a> {
fn get_builder(self) -> Builder {
for key in self.config.keys() {
if !self.used_keys.contains(k... | 20 | 43 | 43 |
dd8bfa6f9b75e92a5f04ec8ab4ac68950957eb14 | Emilio Cobos Álvarez | 2021-02-25T18:05:08 | Bug 1694864 - Remove prefers-contrast: forced as per CSSWG resolution. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D106485 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 52c245969..37d667896 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -309,25 +309,11 @@ fn eval_prefers_reduced_motion(device: &Device, query_value: Option<PrefersReduc
/// https://drafts.csswg.org/mediaq... | 1 | 9 | 31 |
9779fc03a8b7f6a2fc35e05b7d7cecb880bf88b1 | Boris Chiou | 2021-02-25T01:50:55 | Bug 1670155 - Implement Animate trait and ComputeSquaredDistance trait for <ratio>. r=emilio
I also update the wpt becasue it seems the original one lets <ratio>
support the addition. However, the spec says "Addition of <ratio>s is not
possible".
Differential Revision: https://phabricator.services.mozilla.com/D106219 | diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs
index 707906194..2e08d3d26 100644
--- a/style/properties/longhands/position.mako.rs
+++ b/style/properties/longhands/position.mako.rs
@@ -457,7 +457,7 @@ ${helpers.predefined_type(
"AspectRatio",
"computed::... | 4 | 83 | 7 |
5d2651f66588cc2d36bc47d03ff90964f9a0eed6 | Boris Chiou | 2021-02-25T01:50:55 | Bug 1670155 - Move Ratio into independent files. r=emilio
Based on https://drafts.csswg.org/css-values/#ratios, <ratio> should be
a general types in css values, and now the media query and the position use
this type, so let's move it into the independent files.
Differential Revision: https://phabricator.services.mozi... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 9c17c6a79..52c245969 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -10,8 +10,8 @@ use crate::media_queries::media_feature::{AllowsRanges, ParsingRequirements};
use crate::media_queries::media_feature::{... | 12 | 142 | 115 |
9691a866dbc8983f5093af236955e7de4fb9b3e0 | Emilio Cobos Álvarez | 2021-02-24T01:11:40 | Bug 1694141 - Implement :user-valid and :user-invalid. r=xidorn
And alias :-moz-ui-valid and :-moz-ui-invalid to them.
There are CSSWG resolutions for these for quite a while, and spec for
user-invalid.
Differential Revision: https://phabricator.services.mozilla.com/D105966 | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index 1fff5d190..317cbfb83 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -77,8 +77,8 @@ macro_rules! apply_non_ts_list {
("read-only", ReadOnly, IN_READ... | 3 | 6 | 4 |
d016eb256403ffaf7b6d2e78518e9644981d279d | Emilio Cobos Álvarez | 2021-02-23T10:43:03 | Bug 1693886 - Increase custom property size limit a bit. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D105978 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 4a0bf5bed..0d0a43223 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -174,11 +174,11 @@ impl VariableValue {
/// Prevent values from getting terribly big since you can use custom
/// properties expon... | 1 | 3 | 3 |
1f414a72922c500c72e8a80fa1c1a911ca9f7a0f | Emilio Cobos Álvarez | 2021-02-23T00:46:36 | Bug 1694129 - Hide :-moz-submit-invalid behind a pref. r=hiro
No other browser supports anything like this and we don't even have
internal users. Only uses of this I've found on the wild were just
resetting the box shadow internal styling we added in bug 582277 (and
since removed in bug 600151).
Differential Revision... | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index 7010de45c..dbb9ac4db 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -140,6 +140,9 @@ impl NonTSPseudoClass {
if let NonTSPseudoClass::Autofill = *self {
return static_prefs::pref... | 1 | 3 | 0 |
34372ac95d70a21ec371521ba7a498b394e60378 | Markus Stange | 2021-02-17T01:40:04 | Bug 1693196 - Remove -moz-mac-fullscreen-button value. r=emilio
Depends on D105379
Differential Revision: https://phabricator.services.mozilla.com/D105380 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 43f88bf4f..e4e35e4aa 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1789,9 +1789,6 @@ pub enum Appearance {
#[parse(condition = "ParserContext::in_ua_or_chrome_sheet")]
MozWinExcludeGlass,
- ... | 1 | 0 | 3 |
be1f3d5b768e05fc64d25e16e940a6367f6c5e20 | Emilio Cobos Álvarez | 2021-02-17T00:30:52 | No bug - remove useless semicolon that causes a rust nightly warning. DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D105387 | diff --git a/style/values/animated/font.rs b/style/values/animated/font.rs
index a3eb1fe1e..1f0eb749f 100644
--- a/style/values/animated/font.rs
+++ b/style/values/animated/font.rs
@@ -116,7 +116,7 @@ impl<'a> FontSettingTagIter<'a> {
let mut sorted_tags = Vec::from_iter(tags.iter());
sorted_t... | 1 | 1 | 1 |
acba55023993769eb290f287bd96c3a1823d5aba | Emilio Cobos Álvarez | 2021-02-17T00:21:36 | Bug 1690836 - Reduce the amount of code generated by UnparsedValues::substitute_variables. r=boris
This reduces the amount of assembly instructions generated by this
function from 18k+ to ~800.
This should make reasoning about its stack space usage sane, and should
fix the ASAN stack overflows, but also we should tak... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 36e6ee4cf..acfdfc514 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -547,6 +547,7 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> {
declaration.value.substitute_variables(
declaration.id,
+ ... | 5 | 57 | 59 |
5906758aff5d57d192863c0fb4fd13e342cd0746 | Emilio Cobos Álvarez | 2021-02-17T00:21:36 | Bug 1690836 - Cache substituted values from shorthand properties during the cascade. r=xidorn
This brings the time down to 1.6ms from 4.8ms on the test-case in the
bug. This should be improvable too, but I think this is a nice
improvement for regular styling as well.
Differential Revision: https://phabricator.service... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 2fefd0ba0..36e6ee4cf 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -10,11 +10,10 @@ use crate::dom::TElement;
use crate::font_metrics::FontMetricsProvider;
use crate::logical_geometry::WritingMode;
use crate:... | 4 | 96 | 54 |
0448dd9649ca9c85c93e1094160a97853fe363b0 | Emilio Cobos Álvarez | 2021-02-17T00:21:35 | Bug 1690836 - Rustfmt cascade.rs. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D105186 | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 8fbccd1d9..2fefd0ba0 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -10,21 +10,23 @@ use crate::dom::TElement;
use crate::font_metrics::FontMetricsProvider;
use crate::logical_geometry::WritingMode;
use crate:... | 1 | 75 | 75 |
7aea6a6d553fad5a421c66aa86ee43ad6a7edb06 | smolnar | 2021-02-16T15:00:05 | Backed out 2 changesets (bug 1690836) for causing bc failures in browser_editAddressDialog. CLOSED TREE
Backed out changeset 834a980cbd49 (bug 1690836)
Backed out changeset 9455553189d2 (bug 1690836) | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 36e6ee4cf..8fbccd1d9 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -10,22 +10,21 @@ use crate::dom::TElement;
use crate::font_metrics::FontMetricsProvider;
use crate::logical_geometry::WritingMode;
use crate:... | 4 | 125 | 164 |
1f066d6ce52b322e43eadfe4ebab18da5da8842a | Emilio Cobos Álvarez | 2021-02-16T13:38:08 | Bug 1690836 - Cache substituted values from shorthand properties during the cascade. r=xidorn
This brings the time down to 1.6ms from 4.8ms on the test-case in the
bug. This should be improvable too, but I think this is a nice
improvement for regular styling as well.
Differential Revision: https://phabricator.service... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 2fefd0ba0..36e6ee4cf 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -10,11 +10,10 @@ use crate::dom::TElement;
use crate::font_metrics::FontMetricsProvider;
use crate::logical_geometry::WritingMode;
use crate:... | 4 | 93 | 54 |
a04bbf4aaf6c4e3ba52f115aa58150caf45b4d71 | Pierre TALLOTTE | 2021-02-12T15:45:48 | Bug 1688695 - Hide non-standard values of caption-side. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D104321 | diff --git a/style/values/specified/table.rs b/style/values/specified/table.rs
index cd2bfa96c..79136b12c 100644
--- a/style/values/specified/table.rs
+++ b/style/values/specified/table.rs
@@ -4,6 +4,8 @@
//! Specified types for CSS values related to tables.
+use crate::parser::ParserContext;
+
/// Specified valu... | 1 | 11 | 0 |
18ce2e7a3ed826e199844695c6d891b75ff800e2 | Emilio Cobos Álvarez | 2021-02-12T15:42:38 | Bug 1691858 - Minor cleanup of our @page rule setup. r=AlaskanEmily
Actually, there's not so much we can improve right now, in the sense
that:
* We need the ::-moz-page-content pseudo-element to be able to set
`display` on the page, since that's a style rule rather than a @page
rule. We could get away without it.
... | diff --git a/style/stylist.rs b/style/stylist.rs
index 418a86bc5..9a2134450 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -669,7 +669,7 @@ impl Stylist {
{
debug_assert!(pseudo.is_precomputed());
- let rule_node = self.rule_node_for_precomputed_pseudo(guards, pseudo, None);
+ let... | 1 | 20 | 22 |
d9594317efb9fbb6c8a96ee1c809e72e7dc21a12 | Butkovits Atila | 2021-02-11T22:10:31 | Backed out changeset 80d28bc966b1 (bug 1691858) for causing failures on nsIFrame.cpp. CLOSED TREE | diff --git a/style/stylist.rs b/style/stylist.rs
index 9a2134450..418a86bc5 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -669,7 +669,7 @@ impl Stylist {
{
debug_assert!(pseudo.is_precomputed());
- let rule_node = self.rule_node_for_precomputed_pseudo(guards, pseudo, vec![]);
+ l... | 1 | 22 | 20 |
c4a54c40b57b700c299593437fcc484c5cfaa52c | Emilio Cobos Álvarez | 2021-02-11T16:36:54 | Bug 1691781 - Make Linux tab bar use the darker of the highlight / highlighttext colors. r=dao
Some GTK themes use very soft colors for selection backgrounds, using
darker colors for the text. This makes the tab and focus outlines in the
tab bar not have sufficient contrast with usual backgrounds.
I needed to do this... | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index e44568fb5..e64910496 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -227,6 +227,14 @@ pub enum SystemColor {
MozMacActiveSourceListSelection,
MozMacTooltip,
+ /// Theme accent color... | 1 | 8 | 0 |
9c190f2afd8e26102afa1edd8448b81577f46eec | Emilio Cobos Álvarez | 2021-02-10T15:30:40 | Bug 1682607 - Normalize NaN in some other font-related lengths etc. r=jfkthame,layout-reviewers
Depends on D104563
Differential Revision: https://phabricator.services.mozilla.com/D104565 | diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs
index ecc2a78a4..fb59a53ce 100644
--- a/style/values/specified/font.rs
+++ b/style/values/specified/font.rs
@@ -925,7 +925,7 @@ impl FontSize {
// If the parent font was keyword-derived, this is too.
// Tack t... | 2 | 2 | 2 |
579e16e42b23cda0054ec17206656b69d1f07348 | Emilio Cobos Álvarez | 2021-02-10T15:30:40 | Bug 1691652 - Normalize NaN to zero as a result of calc(). r=layout-reviewers,jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D104563 | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index 008970e9c..f4108b35b 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -224,6 +224,12 @@ impl CSSPixelLength {
CSSPixelLength(px)
}
+ /// Returns a normalized (NaN turned to zero) ... | 4 | 25 | 6 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.