commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
6c069454118d89afab5bf917ed7eb3dfaa82904f
Emilio Cobos Álvarez
2021-02-09T00:35:51
Bug 1691287 - Remove the need for needs_context in the mako glue. r=boris It's only used to disambiguate between the one-argument and the trait version of Keyword::parse. Instead, just explicitly use the trait version, so that we don't need to specify it. Differential Revision: https://phabricator.services.mozilla.co...
diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs index 505cd0c08..ed8659f70 100644 --- a/style/properties/helpers.mako.rs +++ b/style/properties/helpers.mako.rs @@ -9,7 +9,7 @@ %> <%def name="predefined_type(name, type, initial_value, parse_method='parse', - needs_context=...
11
14
49
1f94c729a02f05174168a9fb7aac7c133d123b8e
Dorel Luca
2021-02-09T00:22:59
Backed out changeset 786ed9df69ff (bug 1691287) for build bustages in gecko/layout/style/ServoCSSPropList. CLOSED TREE
diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs index ed8659f70..505cd0c08 100644 --- a/style/properties/helpers.mako.rs +++ b/style/properties/helpers.mako.rs @@ -9,7 +9,7 @@ %> <%def name="predefined_type(name, type, initial_value, parse_method='parse', - vector=False, ...
10
48
14
900fca9a6447541be82ffb5ba4abfd96c62b1635
Emilio Cobos Álvarez
2021-02-08T19:43:10
Bug 1691287 - Remove the need for needs_context in the mako glue. r=boris It's only used to disambiguate between the one-argument and the trait version of Keyword::parse. Instead, just explicitly use the trait version, so that we don't need to specify it. Differential Revision: https://phabricator.services.mozilla.co...
diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs index 505cd0c08..ed8659f70 100644 --- a/style/properties/helpers.mako.rs +++ b/style/properties/helpers.mako.rs @@ -9,7 +9,7 @@ %> <%def name="predefined_type(name, type, initial_value, parse_method='parse', - needs_context=...
10
14
48
aaf06daef94ed156aa85d98128358daa52880773
Emilio Cobos Álvarez
2021-02-02T23:45:25
Bug 1690225 - Remove focus-visible feature flag. r=edgar This shipped in 85, we can remove the feature flag now. Keep :-moz-focusring as an alias to :focus-visible at parse time. Differential Revision: https://phabricator.services.mozilla.com/D103752
diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs index 7ed67725d..1fff5d190 100644 --- a/style/gecko/non_ts_pseudo_class_list.rs +++ b/style/gecko/non_ts_pseudo_class_list.rs @@ -55,8 +55,6 @@ macro_rules! apply_non_ts_list { ("fullscreen", Fullscreen, IN_F...
3
1
6
5c05194282cbcd61b4c311d2417582c8c9c42282
Mihai Alexandru Michis
2021-02-02T23:42:37
Backed out 2 changesets (bug 1690225) for causing multiple bc failures. CLOSED TREE Backed out changeset 381ee01f5034 (bug 1690225) Backed out changeset cde1d10aae1c (bug 1690225)
diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs index 1fff5d190..7ed67725d 100644 --- a/style/gecko/non_ts_pseudo_class_list.rs +++ b/style/gecko/non_ts_pseudo_class_list.rs @@ -55,6 +55,8 @@ macro_rules! apply_non_ts_list { ("fullscreen", Fullscreen, IN_F...
3
6
1
bb918d1ffe6f34cbff8dcc96a3d4554632204296
Mats Palmgren
2021-01-30T13:47:10
Bug 1683748 - Support Grid/Flex/Table/Column layout for the rendered legend of a fieldset. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D101555
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 466314367..43f88bf4f 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -265,6 +265,12 @@ impl Display { .unwrap() } + /// Returns the raw underlying u16 value. + #[inline] + pub cons...
1
6
0
9b0bd8b8c83268395b8b79c367fef80d32cd6c4f
Dorel Luca
2021-01-29T20:07:09
Backed out changeset 2d16e9e90401 (bug 1683748) for WPT failures in html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-grid-flex-multicol.html. CLOSED TREE
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 43f88bf4f..466314367 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -265,12 +265,6 @@ impl Display { .unwrap() } - /// Returns the raw underlying u16 value. - #[inline] - pub cons...
1
0
6
b983d6f1a0ddaabe16234a85a3de18dbca920824
Emilio Cobos Álvarez
2021-01-28T22:11:54
Bug 1689253 - Add a more sensible scrollbar size API to nsITheme, and use it to replace ScrollbarNonDisappearing. r=spohl There's no reason we should need an scrollbar box to query the size of a scrollbar. I plan to use this in the following patch to make the size of a resizer not vary depending on whether the contain...
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 651141887..466314367 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1835,10 +1835,6 @@ pub enum Appearance { #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")] MozMacVibrantTitlebarLi...
1
0
4
78233895c31dd74e694934cb21e76bc596c2a759
Emily McDonough
2021-01-27T00:47:56
Bug 1647843 - Add page-size parsing to Servo r=emilio Differential Revision: https://phabricator.services.mozilla.com/D102360
diff --git a/style/values/computed/mod.rs b/style/values/computed/mod.rs index d37dc2549..b46507c05 100644 --- a/style/values/computed/mod.rs +++ b/style/values/computed/mod.rs @@ -70,6 +70,7 @@ pub use self::list::MozListReversed; pub use self::list::Quotes; pub use self::motion::{OffsetPath, OffsetRotate}; pub use...
6
183
0
4b08b829efdeff4e4b340bdca9d6cc3d9c096214
Mats Palmgren
2021-01-25T11:53:57
Bug 1687239 part 3 - Remove the PluginProblem UA Widget and related CSS pseudos. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D102901
diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs index 7bffe282a..7ed67725d 100644 --- a/style/gecko/non_ts_pseudo_class_list.rs +++ b/style/gecko/non_ts_pseudo_class_list.rs @@ -66,8 +66,6 @@ macro_rules! apply_non_ts_list { ("-moz-autofill-preview", Moz...
2
0
3
5394054f2c09ec58b94aa3c3b9c1310d8aed31fe
Emilio Cobos Álvarez
2021-01-21T06:14:16
Bug 1686613 - Add a non-native-theme media query. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D102457
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 589d7dd76..9c17c6a79 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -543,6 +543,16 @@ fn eval_moz_print_preview( query_value.map_or(is_print_preview, |v| v == is_print_preview) } +fn eval_moz_non_...
1
17
1
4dccbd317eecb5297924351b9384befd33d8dc84
longsonr
2021-01-18T08:11:05
Bug 1687136 - remove svg.transform-box.enabled pref r=emilio It's been default true since Firefox 55 via bug 1208550 Differential Revision: https://phabricator.services.mozilla.com/D102093
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index ca93fd916..cf30afaa1 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -573,7 +573,6 @@ ${helpers.single_keyword( "border-box fill-box view-box", engines="gecko"...
1
0
1
deadfc855ef98b1a4ebb1f68ff6b62f243410ac9
Emilio Cobos Álvarez
2021-01-17T14:44:41
Bug 1551040 - Add dark mode to plaintext.css, and a document rule to target plaintext documents. r=boris We add two @-moz-document functions: `plain-text-document()`, matching the obvious, and `unobservable-document()`, which matches a top-level document with no opener. This is the equivalent check we do for automatic...
diff --git a/style/stylesheets/document_rule.rs b/style/stylesheets/document_rule.rs index 2f8c5bc48..77aade97a 100644 --- a/style/stylesheets/document_rule.rs +++ b/style/stylesheets/document_rule.rs @@ -110,6 +110,13 @@ pub enum DocumentMatchingFunction { /// Matching function for a media document. #[css(fu...
2
37
2
f52ce617426dee8583e1424bd5e75f7713bcf216
Emilio Cobos Álvarez
2021-01-17T15:07:49
Bug 1551040 - Allow resource:// stylesheets to use chrome-only rules. r=boris We'll use it to use @-moz-document from plaintext.css. Differential Revision: https://phabricator.services.mozilla.com/D101516
diff --git a/style/parser.rs b/style/parser.rs index 27ba5ea73..837b97400 100644 --- a/style/parser.rs +++ b/style/parser.rs @@ -140,7 +140,7 @@ impl<'a> ParserContext<'a> { /// Returns whether chrome-only rules should be parsed. #[inline] pub fn chrome_rules_enabled(&self) -> bool { - self.url_da...
3
5
5
7e688bfdab26de426c5fdd25b448fd09a039114f
Dorel Luca
2021-01-17T14:38:39
Backed out 3 changesets (bug 1551040) for Browser-chrome failures in browser/base/content/test/static/browser_parsable_css.js Backed out changeset f48f479bcacd (bug 1551040) Backed out changeset a6cd4b393999 (bug 1551040) Backed out changeset 252cbf40efcb (bug 1551040)
diff --git a/style/parser.rs b/style/parser.rs index 837b97400..27ba5ea73 100644 --- a/style/parser.rs +++ b/style/parser.rs @@ -140,7 +140,7 @@ impl<'a> ParserContext<'a> { /// Returns whether chrome-only rules should be parsed. #[inline] pub fn chrome_rules_enabled(&self) -> bool { - self.url_da...
5
7
42
3b19db2bb3e1afc664e4dbeed6135e7f4d456af0
Bogdan Tara
2021-01-16T18:53:31
Backed out 3 changesets (bug 1551040) for stylesheets related bustage CLOSED TREE Backed out changeset 3822fe3e163d (bug 1551040) Backed out changeset 032025f28d8f (bug 1551040) Backed out changeset 1aeb38c2dce3 (bug 1551040)
diff --git a/style/parser.rs b/style/parser.rs index 837b97400..27ba5ea73 100644 --- a/style/parser.rs +++ b/style/parser.rs @@ -140,7 +140,7 @@ impl<'a> ParserContext<'a> { /// Returns whether chrome-only rules should be parsed. #[inline] pub fn chrome_rules_enabled(&self) -> bool { - self.url_da...
5
6
42
0bcccd0339b46394d50f0c77d431a30a535bb04c
Emilio Cobos Álvarez
2021-01-16T10:53:09
Bug 1551040 - Add dark mode to plaintext.css, and a document rule to target plaintext documents. r=boris We add two @-moz-document functions: `plain-text-document()`, matching the obvious, and `unobservable-document()`, which matches a top-level document with no opener. This is the equivalent check we do for automatic...
diff --git a/style/stylesheets/document_rule.rs b/style/stylesheets/document_rule.rs index 2f8c5bc48..7f09abc3b 100644 --- a/style/stylesheets/document_rule.rs +++ b/style/stylesheets/document_rule.rs @@ -110,6 +110,13 @@ pub enum DocumentMatchingFunction { /// Matching function for a media document. #[css(fu...
2
37
1
601bcc14171644a5ce300389b475eeac27a23198
Mihai Alexandru Michis
2021-01-16T10:47:04
Backed out 4 changesets (bug 1551040) for causing mochitest failures. CLOSED TREE Backed out changeset 06c07b144db8 (bug 1551040) Backed out changeset a6ebb45be432 (bug 1551040) Backed out changeset 38f1416a92c3 (bug 1551040) Backed out changeset 6c80881c8844 (bug 1551040)
diff --git a/style/parser.rs b/style/parser.rs index 837b97400..27ba5ea73 100644 --- a/style/parser.rs +++ b/style/parser.rs @@ -140,7 +140,7 @@ impl<'a> ParserContext<'a> { /// Returns whether chrome-only rules should be parsed. #[inline] pub fn chrome_rules_enabled(&self) -> bool { - self.url_da...
5
7
42
e759af865c51811af5b685bfb3668b56bd81b349
Emilio Cobos Álvarez
2021-01-16T03:44:10
Bug 1551040 - Fix a warning by removing a now-unused use statement. MANUAL PUSH: bustage on a CLOSED TREE.
diff --git a/style/stylesheets/document_rule.rs b/style/stylesheets/document_rule.rs index 7f09abc3b..77aade97a 100644 --- a/style/stylesheets/document_rule.rs +++ b/style/stylesheets/document_rule.rs @@ -279,7 +279,6 @@ impl DocumentCondition { #[cfg(feature = "gecko")] fn allowed_in(&self, context: &Parse...
1
0
1
7e1f029e7f66d9ecae3204401a585f03ea42b6bf
Emilio Cobos Álvarez
2021-01-11T01:53:12
Bug 1685917 - Remove layout.css.unknown-webkit-pseudo-element. r=heycam Enabled since bug 1486325 (Firefox 64). Depends on D101290 Differential Revision: https://phabricator.services.mozilla.com/D101291
diff --git a/style/gecko/pseudo_element_definition.mako.rs b/style/gecko/pseudo_element_definition.mako.rs index 0478a114d..41dff1a94 100644 --- a/style/gecko/pseudo_element_definition.mako.rs +++ b/style/gecko/pseudo_element_definition.mako.rs @@ -205,12 +205,10 @@ impl PseudoElement { if starts_with_...
1
4
6
a2bfc1ac908ec66953b24b11866b5d64101001a5
Emilio Cobos Álvarez
2021-01-11T01:55:50
Bug 1685917 - Remove layout.css.file-selector-button.enabled pref. r=heycam On by default since bug 1662478 (Firefox 82) Depends on D101289 Differential Revision: https://phabricator.services.mozilla.com/D101290
diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs index 55d202c92..5a9b955b1 100644 --- a/style/gecko/pseudo_element.rs +++ b/style/gecko/pseudo_element.rs @@ -160,12 +160,7 @@ impl PseudoElement { /// Whether this pseudo-element is enabled for all content. pub fn enabled_in_content...
1
1
6
4299a7eb1d91988ad58093fe95b9b6f7c317ceb0
Emilio Cobos Álvarez
2021-01-11T01:57:17
Bug 1685917 - Remove the moz-focus-outer code. r=heycam This pseudo does nothing and we successfully removed it in bug 1655859 (firefox 81). Differential Revision: https://phabricator.services.mozilla.com/D101289
diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs index ed312dc2d..55d202c92 100644 --- a/style/gecko/pseudo_element.rs +++ b/style/gecko/pseudo_element.rs @@ -161,9 +161,6 @@ impl PseudoElement { /// Whether this pseudo-element is enabled for all content. pub fn enabled_in_content(&s...
1
0
3
ea1271639082f6ce52e73bfe7f21ec7185f8cb3e
Nicolas Silva
2021-01-07T15:29:27
Bug 1683294 - Update rayon to 1.5 r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D100110
diff --git a/style/Cargo.toml b/style/Cargo.toml index e8d47ce73..95ebd60c1 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -59,7 +59,7 @@ num-derive = "0.3" owning_ref = "0.4" parking_lot = "0.11" precomputed-hash = "0.1.1" -rayon = "1" +rayon = "1.5" selectors = { path = "../selectors" } serde = {version...
1
1
1
fa39669e74a0f835dfa8ff0cae7e65c65e21058e
Tim Nguyen
2021-01-08T10:12:00
Bug 1685621 - Fix serialization of complex :not(). r=emilio Differential Revision: https://phabricator.services.mozilla.com/D101090
diff --git a/selectors/parser.rs b/selectors/parser.rs index 865424120..56f801d06 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -1503,14 +1503,6 @@ impl<Impl: SelectorImpl> ToCss for Component<Impl> { AttributeOther(ref attr_selector) => attr_selector.to_css(dest), // Pseudo-...
1
2
9
120acd80868eb7b052e6b87c61ae3a3a5c1ca2f3
Emilio Cobos Álvarez
2021-01-08T01:53:37
Bug 1684909 - Don't allow to parse image-set(none). r=boris `none` is not technically part of the `<image>` syntax. Tests in following patches. Depends on D100698 Differential Revision: https://phabricator.services.mozilla.com/D100699
diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs index 6dff0e5ca..2fa8d0bb1 100644 --- a/style/values/specified/image.rs +++ b/style/values/specified/image.rs @@ -180,7 +180,7 @@ impl Parse for Image { context: &ParserContext, input: &mut Parser<'i, 't>, ) -> Result<...
1
6
8
5add0f37c7dbab1199d3e747a91483d500688b3d
Emilio Cobos Álvarez
2021-01-08T09:54:23
Bug 1684909 - Implement source selection for image-set. r=boris This is based on the logic in ResponsiveImageSelector::SelectImage (just simplified because there's no viewport-dependent widths here). Differential Revision: https://phabricator.services.mozilla.com/D100698
diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs index 3c8379c8c..52cb9cd49 100644 --- a/style/values/computed/image.rs +++ b/style/values/computed/image.rs @@ -18,7 +18,7 @@ use crate::values::computed::{ ToComputedValue, Resolution, }; use crate::values::generics::image::{self as ge...
3
71
13
bb08e50897ec6ce0ed121940db7066162ba8ab8f
Emilio Cobos Álvarez
2021-01-08T09:44:24
Bug 1685078 - Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin This allows supporting image-set(), etc, and simplifies the bullet frame code significantly, too thanks to two changes: * Instead of manually managing the image request, use the CSS image loader, with the `REQUEST_REQUIR...
diff --git a/style/properties/longhands/list.mako.rs b/style/properties/longhands/list.mako.rs index 202c7839d..9a8b39328 100644 --- a/style/properties/longhands/list.mako.rs +++ b/style/properties/longhands/list.mako.rs @@ -52,10 +52,10 @@ ${helpers.single_keyword( ${helpers.predefined_type( "list-style-image"...
4
7
13
b0d9aac68d1755ef36d03830a1d4932ec63e32aa
Razvan Maries
2021-01-08T07:19:12
Backed out changeset e577d67c6c42 (bug 1685621) for perma failures on parse-not.html. CLOSED TREE
diff --git a/selectors/parser.rs b/selectors/parser.rs index 56f801d06..865424120 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -1503,6 +1503,14 @@ impl<Impl: SelectorImpl> ToCss for Component<Impl> { AttributeOther(ref attr_selector) => attr_selector.to_css(dest), // Pseudo-...
1
9
2
e285d31a0ddd03d3dc7c4e41970c014ddc39d0f7
Dorel Luca
2021-01-07T08:44:10
Backed out changeset 47c73e5e08a4 (bug 1685078) for multiple failures related to CSS. CLOSED TREE
diff --git a/style/properties/longhands/list.mako.rs b/style/properties/longhands/list.mako.rs index 9a8b39328..202c7839d 100644 --- a/style/properties/longhands/list.mako.rs +++ b/style/properties/longhands/list.mako.rs @@ -52,10 +52,10 @@ ${helpers.single_keyword( ${helpers.predefined_type( "list-style-image"...
4
13
7
c1371b0d9846de07402c0e4aa7aa9423f1616fab
Emilio Cobos Álvarez
2021-01-07T04:15:29
Bug 1684770 - Implement parsing and serialization for most of image-set(). r=boris This implements the basic image-set notation without the format() function (for simplicity). There's a remaining serialization issue (we should probably skip 1x resolutions), but that's fine for now, I'll address this in a follow-up wh...
diff --git a/style/gecko/url.rs b/style/gecko/url.rs index 406ae12e5..31e38e444 100644 --- a/style/gecko/url.rs +++ b/style/gecko/url.rs @@ -285,14 +285,15 @@ impl SpecifiedImageUrl { /// Provides an alternate method for parsing that associates the URL /// with anonymous CORS headers. - pub fn parse_with...
6
153
31
1b9486aad5eb3fe2b4bb44554e9dc7ae911699c1
Emilio Cobos Álvarez
2021-01-04T20:12:05
Bug 1684220 - Remove some dead plugins code. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D100472
diff --git a/style/element_state.rs b/style/element_state.rs index 5dc3cc0c2..e05ff8778 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -55,12 +55,6 @@ bitflags! { const IN_BROKEN_STATE = 1 << 14; /// Non-standard: https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-loading ...
3
0
25
d2e39646178f982f9ed34130b5b0856cfb1ec6dc
Emilio Cobos Álvarez
2021-01-04T17:56:33
Bug 1684673 - Use an AutoTArray for atom arrays in attributes (class / part). r=smaug These are never empty, and storing 4 elements inline seems worth it given we also heap-allocate the array itself. Depends on D100592 Differential Revision: https://phabricator.services.mozilla.com/D100593
diff --git a/style/gecko/snapshot_helpers.rs b/style/gecko/snapshot_helpers.rs index f34fca40f..8d99f84a9 100644 --- a/style/gecko/snapshot_helpers.rs +++ b/style/gecko/snapshot_helpers.rs @@ -43,14 +43,16 @@ unsafe fn get_class_or_part_from_attr(attr: &structs::nsAttrValue) -> Class { (*container).mType, ...
1
6
3
fab1dea999650859fc3dfab8b7114990cac17124
Emilio Cobos Álvarez
2021-01-02T17:37:45
Bug 1684673 - Inline nsTArray::deref. r=xidorn This shaves >50ms if the compiler decides not to inline it, compilers are sometimes dumb. Depends on D100593 Differential Revision: https://phabricator.services.mozilla.com/D100594
diff --git a/style/gecko_bindings/sugar/ns_t_array.rs b/style/gecko_bindings/sugar/ns_t_array.rs index 04ba326c6..d10ed420d 100644 --- a/style/gecko_bindings/sugar/ns_t_array.rs +++ b/style/gecko_bindings/sugar/ns_t_array.rs @@ -13,6 +13,7 @@ use std::slice; impl<T> Deref for nsTArray<T> { type Target = [T]; + ...
1
1
0
787ea5d59ebbf18c232895be8e2e0720536a2ef0
Emilio Cobos Álvarez
2021-01-02T04:50:01
Bug 1684673 - Reorder some conditions when handling class/part attributes. r=xidorn Empty class attributes are uncommon. Differential Revision: https://phabricator.services.mozilla.com/D100592
diff --git a/style/gecko/snapshot_helpers.rs b/style/gecko/snapshot_helpers.rs index ee8d7dfd7..f34fca40f 100644 --- a/style/gecko/snapshot_helpers.rs +++ b/style/gecko/snapshot_helpers.rs @@ -34,27 +34,26 @@ unsafe fn ptr<T>(attr: &structs::nsAttrValue) -> *const T { unsafe fn get_class_or_part_from_attr(attr: &struc...
1
17
18
5a25d5cd304fcf26101c6be9721518aa3c7bdfbe
Emilio Cobos Álvarez
2020-12-23T02:59:11
Bug 1683295 - Make next_in_preorder generate slightly better code. r=heycam This avoids the panic code in release builds. Differential Revision: https://phabricator.services.mozilla.com/D100094
diff --git a/style/dom.rs b/style/dom.rs index 2edf5ae7d..86c5a3828 100644 --- a/style/dom.rs +++ b/style/dom.rs @@ -188,22 +188,18 @@ pub trait TNode: Sized + Copy + Clone + Debug + NodeInfo + PartialEq { return Some(c); } - if Some(*self) == scoped_to { - return None; - ...
1
7
11
69954d77f4e86a56c81b775006bc192f352e9614
Emilio Cobos Álvarez
2020-12-17T14:04:35
Bug 1682003 - Avoid UTF-8 -> UTF-16 conversion during CSSOM serialization. r=heycam This lifts a bunch of string conversions higher up the stack, but allows us to make the servo code use utf-8 unconditionally, and seemed faster in my benchmarking (see comment 0). It should also make a bunch of attribute setters faste...
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index bd0a87f0b..9170f6e65 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -14,7 +14,7 @@ use crate::parser::ParserContext; use crate::properties::animated_properties::{Animation...
3
15
101
5a7569899f7ee1e652236129e51f2bb5a516c2a2
Emilio Cobos Álvarez
2020-12-16T20:24:03
Bug 1682174 - Remove layout.css.moz-any-is-is.enabled. r=boris We shipped this, let's remove the MozAny code. Differential Revision: https://phabricator.services.mozilla.com/D99607
diff --git a/selectors/parser.rs b/selectors/parser.rs index 70f664192..865424120 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -416,22 +416,6 @@ where ) } -/// Parse a comma separated list of compound selectors. -pub fn parse_compound_selector_list<'i, 't, P, Impl>( - parser: &P, - input:...
4
3
82
0e872e65f578f620e13d46a747bf3c7b2223303f
Emilio Cobos Álvarez
2020-12-16T08:16:16
Bug 1475316 - Expose :autofill behind a pref to content, and add :-webkit-autofill as a compat alias. r=nordzilla Nightly only until we get resolutions on the relevant spec issues. Differential Revision: https://phabricator.services.mozilla.com/D99296
diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs index dd473aaf3..d4c0bca62 100644 --- a/style/gecko/selector_parser.rs +++ b/style/gecko/selector_parser.rs @@ -121,6 +121,7 @@ impl NonTSPseudoClass { "-moz-full-screen" => Some(NonTSPseudoClass::Fullscreen), ...
1
5
1
beabe070d56120fd24859a4a6e59f218fc3ea131
Emilio Cobos Álvarez
2020-12-16T08:16:08
Bug 1475316 - Rename -moz-autofill to just autofill. r=geckoview-reviewers,esawin,boris No compat impact, as this remains an internal pseudo-class for the time being. Differential Revision: https://phabricator.services.mozilla.com/D99295
diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs index d1e49036d..d927e886b 100644 --- a/style/gecko/non_ts_pseudo_class_list.rs +++ b/style/gecko/non_ts_pseudo_class_list.rs @@ -37,6 +37,7 @@ macro_rules! apply_non_ts_list { ("any-link", AnyLink, IN_VISITE...
2
3
2
54f2f96c1374f9ad2a8a9b3d749798f7e0fb8e05
Dorel Luca
2020-12-16T01:42:27
Backed out changeset a9b7489b5a3a (bug 1475316) for Browser-chrome failures in browser/base/content/test/static/browser_parsable_css.js. CLOSED TREE
diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs index d927e886b..d1e49036d 100644 --- a/style/gecko/non_ts_pseudo_class_list.rs +++ b/style/gecko/non_ts_pseudo_class_list.rs @@ -37,7 +37,6 @@ macro_rules! apply_non_ts_list { ("any-link", AnyLink, IN_VISITE...
2
2
3
00ef333cf3611d9c1e7d37633c3792be2dda4132
Kartik Gautam
2020-12-15T10:34:54
Bug 1679758 - Remove trailing empty lines r=sylvestre,marionette-reviewers,jgraham Differential Revision: https://phabricator.services.mozilla.com/D99595
diff --git a/style/properties/shorthands/padding.mako.rs b/style/properties/shorthands/padding.mako.rs index 4d2ea361e..11ddfed3b 100644 --- a/style/properties/shorthands/padding.mako.rs +++ b/style/properties/shorthands/padding.mako.rs @@ -56,4 +56,3 @@ ${helpers.two_properties_shorthand( engines="gecko", sp...
1
0
1
e35d42ea48dd13991a00dbef024ff89fa27841e8
Dragana Damjanovic
2020-12-14T18:38:49
Bug 1682262 - Update neqo to 0.4.18 and bindgen to 0.56 r=necko-reviewers,emilio,valentin Differential Revision: https://phabricator.services.mozilla.com/D99665
diff --git a/style/Cargo.toml b/style/Cargo.toml index eddbe047b..e8d47ce73 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -84,7 +84,7 @@ void = "1.0.2" [build-dependencies] lazy_static = "1" log = "0.4" -bindgen = {version = "0.53", optional = true, default-features = false} +bindgen = {version = "0.56", o...
1
1
1
d22e9295a84e5e3c0af410b4f7d71e08675f9b89
Emilio Cobos Álvarez
2020-12-14T16:14:35
Bug 1682295 - Remove some text-decoration prefs that are always on. r=layout-reviewers,mats Differential Revision: https://phabricator.services.mozilla.com/D99675
diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs index 658fa39f5..f60e51c20 100644 --- a/style/properties/longhands/inherited_text.mako.rs +++ b/style/properties/longhands/inherited_text.mako.rs @@ -109,8 +109,6 @@ ${helpers.predefined_type( extra_s...
3
2
18
cee0c40638f31ead947a6d2b5f31443c3b9190c0
Emilio Cobos Álvarez
2020-12-14T13:43:50
Bug 1603455 - Remove layout.css.xul-tree-pseudos.content.enabled. r=heycam We unshipped these a while ago and left the pref just for testing purposes. But now all the reftests using it were conveniently migrated to chrome:// tests, so we no longer need it. Differential Revision: https://phabricator.services.mozilla.c...
diff --git a/style/gecko/pseudo_element_definition.mako.rs b/style/gecko/pseudo_element_definition.mako.rs index f4a6671bd..0478a114d 100644 --- a/style/gecko/pseudo_element_definition.mako.rs +++ b/style/gecko/pseudo_element_definition.mako.rs @@ -112,11 +112,7 @@ impl PseudoElement { % for pseudo in PSEU...
1
1
5
c0fd1b88a36e0cb31dd8e4ac626d1ec1917502f3
Dorel Luca
2020-12-13T14:38:21
Backed out changeset f3aaf04fce3b (bug 1679758) for Devtool failures in browser_styleeditor_syncAddProperty.js. CLOSED TREE
diff --git a/style/properties/shorthands/padding.mako.rs b/style/properties/shorthands/padding.mako.rs index 11ddfed3b..4d2ea361e 100644 --- a/style/properties/shorthands/padding.mako.rs +++ b/style/properties/shorthands/padding.mako.rs @@ -56,3 +56,4 @@ ${helpers.two_properties_shorthand( engines="gecko", sp...
1
1
0
4179653056c137534baea2f356344bd5665582f1
Kartik Gautam
2020-12-13T13:28:30
Bug 1679758 - Remove trailing empty lines r=sylvestre Differential Revision: https://phabricator.services.mozilla.com/D99595
diff --git a/style/properties/shorthands/padding.mako.rs b/style/properties/shorthands/padding.mako.rs index 4d2ea361e..11ddfed3b 100644 --- a/style/properties/shorthands/padding.mako.rs +++ b/style/properties/shorthands/padding.mako.rs @@ -56,4 +56,3 @@ ${helpers.two_properties_shorthand( engines="gecko", sp...
1
0
1
a76f2dfb4c643f55a2b9dc82a6f580894ef8b7a9
Emilio Cobos Álvarez
2020-12-10T11:37:16
Bug 1632469 - Use `SmallVec::try_reserve`. r=manishearth Differential Revision: https://phabricator.services.mozilla.com/D72147
diff --git a/fallible/lib.rs b/fallible/lib.rs index 1e01e8f80..5b4836bf2 100644 --- a/fallible/lib.rs +++ b/fallible/lib.rs @@ -86,78 +86,34 @@ fn try_double_vec<T>(vec: &mut Vec<T>) -> Result<(), FailedAllocationError> { impl<T: Array> FallibleVec<T::Item> for SmallVec<T> { #[inline(always)] fn try_push(&m...
1
15
59
1c2c204439b07c94392c799f5f73704f5eb9b4ef
Emilio Cobos Álvarez
2020-12-10T11:10:05
Bug 1632469 - Update smallvec. r=manishearth Differential Revision: https://phabricator.services.mozilla.com/D72146
diff --git a/style/Cargo.toml b/style/Cargo.toml index c8e96b0b9..eddbe047b 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -66,8 +66,7 @@ servo_arc = { path = "../servo_arc" } servo_atoms = {path = "../atoms", optional = true} servo_config = {path = "../config", optional = true} smallbitvec = "2.3.0" -# See...
1
1
2
d12d1cd1612b72af5856e8716524348ad37f3bd6
Emilio Cobos Álvarez
2020-12-05T17:12:44
Bug 1671170 - Downgrade smallvec to 1.3. r=markh See https://github.com/servo/rust-smallvec/issues/243 and the PRs in the comments. Differential Revision: https://phabricator.services.mozilla.com/D98802
diff --git a/style/Cargo.toml b/style/Cargo.toml index eddbe047b..c8e96b0b9 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -66,7 +66,8 @@ servo_arc = { path = "../servo_arc" } servo_atoms = {path = "../atoms", optional = true} servo_config = {path = "../config", optional = true} smallbitvec = "2.3.0" -small...
1
2
1
cde2ed4a7e90c7ecc26e504885f75a2cce3830cd
Emilio Cobos Álvarez
2020-12-04T15:41:24
Bug 1680084 - Use a more precise rule start for sanitization. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D98710
diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs index e8c6ffe42..219c5632a 100644 --- a/style/stylesheets/mod.rs +++ b/style/stylesheets/mod.rs @@ -407,8 +407,10 @@ impl CssRule { allow_import_rules, }; - parse_one_rule(&mut input, &mut rule_parser) - .map_err(...
3
21
22
d8c04e311bc52cf28e0e997a8f6407aae4a235e5
Emilio Cobos Álvarez
2020-12-04T10:47:55
Bug 1680558 - Update cssparser to get ParserState in rule parser. r=heycam The changes should be trivial. The third_party changes are up for review in https://github.com/servo/rust-cssparser/pull/277 (and of course I'll land with a bump to 0.28 rather than the override after that gets r+'d). The basic idea is that w...
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 802f65219..56458631d 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -31,7 +31,7 @@ accountable-refcell = { version = "0.2.0", optional = true } app_units = "0.7" content-security-policy = { version = "0.4.0", features ...
8
30
30
361025eb611c70487ae9b6031360025b04f32a75
Razvan Maries
2020-12-04T04:48:30
Backed out changeset 54068f044426 (bug 1680558) for perma failures on browser_resources_stylesheets.js. CLOSED TREE
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 56458631d..802f65219 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -31,7 +31,7 @@ accountable-refcell = { version = "0.2.0", optional = true } app_units = "0.7" content-security-policy = { version = "0.4.0", features ...
8
30
30
84d269cdd44e610d5c5f00a04f5d0830588e1694
Emilio Cobos Álvarez
2020-12-03T19:37:05
Bug 1678077 - Make CssUrl::is_fragment marginally more efficient. r=boris No need to do utf8 shenanigans for what this function does. Differential Revision: https://phabricator.services.mozilla.com/D97473
diff --git a/style/gecko/url.rs b/style/gecko/url.rs index 678adb39b..406ae12e5 100644 --- a/style/gecko/url.rs +++ b/style/gecko/url.rs @@ -109,7 +109,7 @@ impl CssUrlData { /// Returns true if this URL looks like a fragment. /// See https://drafts.csswg.org/css-values/#local-urls pub fn is_fragment(&se...
1
1
1
309cb01fcbe9887ab7b57b49d30f11cc0807130d
Emily McDonough
2020-12-01T00:03:28
Bug 1678733 - Separate out some of the declaration precedence components from @viewport rules r=emilio Differential Revision: https://phabricator.services.mozilla.com/D97817
diff --git a/style/stylesheets/cascading_at_rule.rs b/style/stylesheets/cascading_at_rule.rs new file mode 100644 index 000000000..b23b0720f --- /dev/null +++ b/style/stylesheets/cascading_at_rule.rs @@ -0,0 +1,70 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy ...
3
73
57
1cac19f04919ec058086ed1564692c61b34ea814
Tim Nguyen
2020-11-30T12:45:14
Bug 1679714 - Remove layout.css.conic-gradient.enabled preference. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D98126
diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs index 1a2cf38ea..590beb0fb 100644 --- a/style/values/specified/image.rs +++ b/style/values/specified/image.rs @@ -63,16 +63,6 @@ pub type PercentOrNone = generic::PercentOrNone<Percentage>; type LengthPercentageItemList = crate::OwnedSlic...
1
4
16
84575af4a4adfa896d3ae1dcd4f8fcf190c59b38
Sunita Sen
2020-11-24T13:33:51
Bug 1329241 - Add support for touch-action:pinch-zoom - Add pinch-zoom support to touchAction r=kats,emilio Differential Revision: https://phabricator.services.mozilla.com/D97815
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 4a78474d2..651141887 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1171,7 +1171,7 @@ bitflags! { /// Values for the `touch-action` property. #[derive(MallocSizeOf, SpecifiedValueInfo, ToComput...
1
6
2
7e6f75d7f74463277e4eacf0686824001d7b51e1
Sunita Sen
2020-11-23T01:40:21
Bug 1329241 - Add support for touch-action:pinch-zoom - Rewrite to_css and parse for touchAction r=kats,emilio Differential Revision: https://phabricator.services.mozilla.com/D97650
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index c26907e14..4a78474d2 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1200,43 +1200,68 @@ impl ToCss for TouchAction { where W: Write, { - match *self { - TouchAction::...
1
53
28
723d5f200cbe2b5c613bee2ddab956c4cbff9ef5
Emilio Cobos Álvarez
2020-11-22T00:41:29
Bug 1678881 - Run latest rustfmt in servo/. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D97855
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index d8a7f6715..589d7dd76 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -107,7 +107,12 @@ fn eval_aspect_ratio( query_value: Option<Ratio>, range_or_operator: Option<RangeOrOperator>, ) -> bool { -...
21
82
72
a702749c43b4af26fd592f6b985e1d4fb9679050
Emilio Cobos Álvarez
2020-11-22T01:02:22
Bug 1678881 - Avoid some allocations in selector serialization. r=xidorn The allocations in display_to_css_identifier show up in the profiles of bug 1675628. Differential Revision: https://phabricator.services.mozilla.com/D97856
diff --git a/selectors/parser.rs b/selectors/parser.rs index 955a42842..70f664192 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -10,15 +10,15 @@ use crate::builder::{SelectorBuilder, SelectorFlags, SpecificityAndFlags}; use crate::context::QuirksMode; use crate::sink::Push; pub use crate::visitor::Se...
21
271
167
7668eafb5cb12d61ee822d1dc8b3e969fdd7f73f
Tim Nguyen
2020-11-17T01:20:33
Bug 1525737 - Remove support for XUL grid display values. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53297
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 14f9027bb..3bd4918fc 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -109,12 +109,6 @@ pub enum DisplayInside { #[cfg(feature = "gecko")] MozBox, #[cfg(feature = "gecko")] - MozGrid, - ...
1
0
18
4b82d49739e8f38e1715bf5d5ca628c3ae40b47c
David Parks
2020-11-18T15:55:34
Bug 1675349: Replace plugin behavior with a basic fallback r=jmathies,mixedpuppy The browser currently only enables plugin behavior for Flash and our internal test plugins. This patch replaces support for those plugins with a simple fallback that shows a transparent region where the plugin would have been. It remove...
diff --git a/style/element_state.rs b/style/element_state.rs index 2e3ccb3b3..5dc3cc0c2 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -144,6 +144,8 @@ bitflags! { const IN_MOZINERT_STATE = 1 << 54; /// State for the topmost dialog element in top layer const IN_TOPMOST_MO...
3
5
0
f310bf3554705cc8881c4d8e2307d24db690c478
Bogdan Tara
2020-11-18T04:06:36
Backed out 19 changesets (bug 1675349) for lint failures on browser_ext_browsingData_pluginData and test_archive CLOSED TREE Backed out changeset 244e0f2b410c (bug 1675349) Backed out changeset ba5724069dd4 (bug 1675349) Backed out changeset 37fca259c7e9 (bug 1675349) Backed out changeset f2b16caca1fc (bug 1675349) Ba...
diff --git a/style/element_state.rs b/style/element_state.rs index 5dc3cc0c2..2e3ccb3b3 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -144,8 +144,6 @@ bitflags! { const IN_MOZINERT_STATE = 1 << 54; /// State for the topmost dialog element in top layer const IN_TOPMOST_MO...
3
0
5
2e21f44b40a2029d06e0402d2d4a7a4ccaa94be0
Mihai Alexandru Michis
2020-11-17T12:48:54
Bug 1676513 - Fix lint error in matching.rs a=lint-fix CLOSED TREE
diff --git a/selectors/matching.rs b/selectors/matching.rs index 634ed90d6..244572b53 100644 --- a/selectors/matching.rs +++ b/selectors/matching.rs @@ -914,8 +914,8 @@ where is_from_end, cache.as_deref_mut(), ); - if let Some(c) = cache.as_mut() { - c.insert(elemen...
1
2
2
6027cacfdc146e5d10b5ad15df564c7c403b05c2
Sylvestre Ledru
2020-11-17T12:02:22
Bug 1676513 - Fix clippy warnings r=emilio,webdriver-reviewers,whimboo,rhunt Depends on D96634 Differential Revision: https://phabricator.services.mozilla.com/D96636
diff --git a/derive_common/cg.rs b/derive_common/cg.rs index 8abfd8714..292868498 100644 --- a/derive_common/cg.rs +++ b/derive_common/cg.rs @@ -360,7 +360,7 @@ pub fn to_css_identifier(mut camel_case: &str) -> String { } } if !first { - result.push_str("-"); + resul...
10
20
23
15565579629227d72ab5c265f2531bbe5303bbd3
Markus Stange
2020-11-16T20:43:35
Bug 1676434 - Replace obsolete -moz-mac-yosemite-theme media query with a new -moz-mac-big-sur-theme media query. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D97089
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 4fd6e622a..d8a7f6715 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -816,7 +816,7 @@ pub static MEDIA_FEATURES: [MediaFeatureDescription; 55] = [ system_metric_feature!(atom!("-moz-overlay-scrollbars...
1
1
1
fe2766531bc0e20f4185be27c2c4aae6cb703468
Emilio Cobos Álvarez
2020-11-13T12:53:45
Bug 1618639 - Make focus-visible match the spec more closely. r=edgar The spec text has been improved a while ago, so I think we should do this. This keeps the current moz-focusring behavior when the pref is disabled, but when enabled it becomes effectively an alias of focus-visible. Differential Revision: https://ph...
diff --git a/style/element_state.rs b/style/element_state.rs index ebf6aa42a..2e3ccb3b3 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -103,6 +103,8 @@ bitflags! { /// Non-standard & undocumented. const IN_INCREMENT_SCRIPT_LEVEL_STATE = 1 << 38; /// Non-standard: https://...
2
3
5
a8e3abdf11c24b898b4134dad5e0a327b7a383cb
Emilio Cobos Álvarez
2020-11-08T14:01:50
Bug 1675514 - Fix declaration block serialization and logical properties. r=boris As per https://github.com/w3c/csswg-drafts/issues/3030. Also remove a system font special-case. It's generally handled in shorthands/font.mako.rs, and when it's not, it's really the same issue as https://github.com/w3c/csswg-drafts/issu...
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index d8ac84a8e..bd0a87f0b 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -930,7 +930,7 @@ impl PropertyDeclarationBlock { let mut already_serialized = NonCustomProperty...
2
145
94
bc3e7e0799e1aab84e0becc8add2db38cb064b1e
Emilio Cobos Álvarez
2020-11-06T22:30:28
Bug 1664372 - Fix font loading invalidation to account for metrics coming from the parent style. r=jfkthame We were only looking at the given frame's style, which is not sufficient for this case. Differential Revision: https://phabricator.services.mozilla.com/D96237
diff --git a/style/properties/computed_value_flags.rs b/style/properties/computed_value_flags.rs index dc9597e08..cc7d9c94f 100644 --- a/style/properties/computed_value_flags.rs +++ b/style/properties/computed_value_flags.rs @@ -57,19 +57,24 @@ bitflags! { /// Whether the child explicitly inherits any reset pr...
2
18
13
7066fa3dea4d4f332d361a0ba49dd8587ff48f84
Emilio Cobos Álvarez
2020-11-06T02:37:44
Bug 1675639 - Shrink custom property maps before making them immutable. r=boris Differential Revision: https://phabricator.services.mozilla.com/D96132
diff --git a/style/custom_properties.rs b/style/custom_properties.rs index 4943fd1a7..4a0bf5bed 100644 --- a/style/custom_properties.rs +++ b/style/custom_properties.rs @@ -662,6 +662,7 @@ impl<'a> CustomPropertiesBuilder<'a> { let inherited = self.inherited.as_ref().map(|m| &***m); substitute...
1
1
0
a5517f64117beafd743b1e2105ea4c0e7688a75a
Emilio Cobos Álvarez
2020-11-06T12:46:13
Bug 1675639 - Update indexmap. r=boris New versions have shrink_to_fit(). This also explicitly requests the "std" feature, because otherwise autocfg fails to pass the panic=abort flag to rustc and it chokes. Depends on D96130 Differential Revision: https://phabricator.services.mozilla.com/D96131
diff --git a/style/Cargo.toml b/style/Cargo.toml index 4ccd41311..c71f7de1c 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -43,7 +43,7 @@ fxhash = "0.2" hashbrown = "0.9" hashglobe = { path = "../hashglobe" } html5ever = {version = "0.24", optional = true} -indexmap = "1.0" +indexmap = {version = "1.0", fea...
1
1
1
dc315b1ded33c38f03d88f4d25eefe7b63ef76a9
Emilio Cobos Álvarez
2020-11-06T02:37:44
Bug 1675639 - Don't waste string space before making values immutable. r=boris Differential Revision: https://phabricator.services.mozilla.com/D96130
diff --git a/style/custom_properties.rs b/style/custom_properties.rs index 23e25b5a1..4943fd1a7 100644 --- a/style/custom_properties.rs +++ b/style/custom_properties.rs @@ -247,8 +247,11 @@ impl VariableValue { .collect::<Vec<_>>() .into_boxed_slice(); + let mut css = css.into_owned()...
1
12
6
a27e231abbe3d6e32d5a28106423858bcf50c742
Narcis Beleuzu
2020-11-06T01:32:33
Backed out 3 changesets (bug 1675639) for Bpgo bustages. CLOSED TREE Backed out changeset 9a7b394ca845 (bug 1675639) Backed out changeset 270207ea42c1 (bug 1675639) Backed out changeset 3d38566d80c6 (bug 1675639)
diff --git a/style/custom_properties.rs b/style/custom_properties.rs index 4a0bf5bed..23e25b5a1 100644 --- a/style/custom_properties.rs +++ b/style/custom_properties.rs @@ -247,11 +247,8 @@ impl VariableValue { .collect::<Vec<_>>() .into_boxed_slice(); - let mut css = css.into_owned()...
1
6
13
0893ced9383a8dc6548a0c8b38f44766676a4b90
Dzmitry Malyshau
2020-11-02T22:56:40
Bug 1674917 - Update parking_lot to 0.11 r=nika Differential Revision: https://phabricator.services.mozilla.com/D95610
diff --git a/style/Cargo.toml b/style/Cargo.toml index 38ce8ebbb..4ccd41311 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -57,7 +57,7 @@ num-integer = "0.1" num-traits = "0.2" num-derive = "0.3" owning_ref = "0.4" -parking_lot = "0.10" +parking_lot = "0.11" precomputed-hash = "0.1.1" rayon = "1" selecto...
1
1
1
2546e9c868273c9caa1d4605e72aa68a3e8e4b46
Emilio Cobos Álvarez
2020-10-30T19:47:19
Bug 1673930 - Use document quirks mode rather than sheet quirks mode for stylesheet invalidation. r=nordzilla In order to determine whether classes or ids are case insensitive we need the document quirks mode. The sheet quirks mode almost always matches, but may not match when sheets are added by privileged APIs. Dif...
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index e5ffccf11..08425f220 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -9,6 +9,7 @@ use crate::gecko::values::{convert_nscolor_to_rgba, convert_rgba_to_nscolor}; use crate::gecko_bindings::bindings; use crate:...
3
8
2
cca9e938417135737748774fb501dfb0e9b623b4
Emilio Cobos Álvarez
2020-10-29T18:03:54
Bug 933562 - Implement complex :not(). r=jfkthame This fixes the failures in bug 1671573 and just works thanks to the invalidation improvements I did for :is / :where. Added a couple tests for invalidation which is the tricky bit. 001 is a very straight-forward test, 002 is the :is test but with :is() replaced by dou...
diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml index a3e6db922..db42b16ec 100644 --- a/selectors/Cargo.toml +++ b/selectors/Cargo.toml @@ -28,7 +28,6 @@ phf = "0.8" precomputed-hash = "0.1" servo_arc = { version = "0.1", path = "../servo_arc" } smallvec = "1.0" -thin-slice = "0.1.0" to_shmem = { path = "....
6
107
168
b7dd7b23b6d1af99387d5b0dacde4e5849e85502
Markus Stange
2020-10-27T12:37:44
Bug 1673132 - Use the -moz-default-appearance values "scrollbar-horizontal" and "scrollbar-vertical" on macOS and remove the now-unused value "scrollbar". r=emilio Other platforms were already converted to scrollbar-horizontal and scrollbar-vertical in bug 1205643. Differential Revision: https://phabricator.services....
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 72c85d155..14f9027bb 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1641,9 +1641,6 @@ pub enum Appearance { /// The resizer itself. #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")] ...
1
0
3
214f02e875d717eebfde411022eb93c7574cfa4c
Markus Stange
2020-10-27T12:37:44
Bug 1673132 - Remove "scrollbar-small" -moz-default-appearance value and replace its single use with scrollbar-width: thin. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D94673
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 121e741eb..72c85d155 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1644,9 +1644,6 @@ pub enum Appearance { /// A scrollbar. #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")] Sc...
1
0
3
faa78373eca1412af4e8ddf146e7bb4036be8559
Emilio Cobos Álvarez
2020-10-26T09:58:31
Bug 1673259 - Remove unused DeclarationBlock::get_at_importance. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D94693
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index eef63d2d2..d8ac84a8e 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -348,21 +348,6 @@ impl PropertyDeclarationBlock { .find(|(declaration, _)| declaration.id()...
1
0
15
a0b781b5cac80cb497cd67d1fa9e7beaec662871
Cameron McCormack
2020-10-16T12:49:47
Bug 1671401 - Use separate Scrollbar and ThemedScrollbar ColorIDs. r=spohl Otherwise on Windows, we have a ColorID::Scrollbar but not any of the other scrollbar part colors, and the Windows-provided value for Scrollbar doesn't work well with the default values for the other scrollbar parts that come from the non-nativ...
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index d1f27eeb5..e44568fb5 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -108,15 +108,17 @@ pub enum SystemColor { #[css(skip)] SpellCheckerUnderline, #[css(skip)] - ScrollbarInactive...
1
7
5
cd17a2478692c5b57b0902b644c3198857b55ddd
Jon Bauman
2020-10-16T19:49:05
Bug 1670341 - Update mp4parse-rust to eliminate multiple versions of hashbrown crate. r=emilio Also update servo's `style` package to use hashbrown 0.9. Differential Revision: https://phabricator.services.mozilla.com/D93616
diff --git a/style/Cargo.toml b/style/Cargo.toml index 825190f7e..38ce8ebbb 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -40,7 +40,7 @@ encoding_rs = {version = "0.8", optional = true} euclid = "0.22" fallible = { path = "../fallible" } fxhash = "0.2" -hashbrown = "0.7" +hashbrown = "0.9" hashglobe = { p...
1
1
1
5c723a52d55c2903b195cff0f27b0b9892e32149
Emilio Cobos Álvarez
2020-10-15T16:12:16
Bug 1669742 - Always serialize ratio with both components. r=boris Differential Revision: https://phabricator.services.mozilla.com/D93639
diff --git a/style/values/generics/position.rs b/style/values/generics/position.rs index 2b4448f03..76e5c94e0 100644 --- a/style/values/generics/position.rs +++ b/style/values/generics/position.rs @@ -5,7 +5,6 @@ //! Generic types for CSS handling of specified and computed values of //! [`position`](https://drafts.cs...
1
14
7
ea5d512b7b08b3de5645f3b2507ede18ebff8bd6
Cameron McCormack
2020-10-15T04:54:41
Bug 1669368 - Use LookAndFeelCache to pass Gtk theme-derived scrollbar colors to content processes. r=spohl Differential Revision: https://phabricator.services.mozilla.com/D93467
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index 675e1b9a1..d1f27eeb5 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -107,6 +107,16 @@ pub enum SystemColor { IMESelectedConvertedTextUnderline, #[css(skip)] SpellCheckerUnderline, +...
1
10
0
0d9082e6490987463e8d7f46da507e5872c3d897
Razvan Maries
2020-10-15T04:45:35
Backed out 4 changesets (bug 1670694, bug 1670853, bug 1669368, bug 1670145) for build bustages on nsNativeBasicTheme.h. CLOSED TREE Backed out changeset fcb1b57645e0 (bug 1669368) Backed out changeset 6ac5b674c3b6 (bug 1670853) Backed out changeset 913fd041e5dd (bug 1670145) Backed out changeset 89504c0fb0cd (bug 167...
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index d1f27eeb5..675e1b9a1 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -107,16 +107,6 @@ pub enum SystemColor { IMESelectedConvertedTextUnderline, #[css(skip)] SpellCheckerUnderline, -...
1
0
10
7ffd101f8cfb664cb04fee52e780ea9d737f0758
Boris Chiou
2020-10-12T15:05:46
Bug 1669232 - Serialize a 0/0 ratio as 0/0 in all value stages. r=emilio Based on the update of github.com/w3c/csswg-drafts/issues/5084, a 0/0 ratio will serialize as 0/0 in all value stages. Differential Revision: https://phabricator.services.mozilla.com/D93182
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 4fea1030d..4fd6e622a 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -87,8 +87,12 @@ fn eval_aspect_ratio_for<F>( where F: FnOnce(&Device) -> Size2D<Au>, { + // A ratio of 0/0 behaves as the rati...
3
17
10
22e0cf43d221a382f9513de6ea10f2249bde3457
Emilio Cobos Álvarez
2020-10-09T03:20:34
Bug 1669459 - Introduce InspectorUtils.supports(). r=rcaliman,heycam Which allows to run CSS.supports in chrome/user-agent context. We should probably add a couple more tweaks for stuff like quirks or what not (the `ParsingMode` enum), but that seem lower priority. I only added the one-value version of CSS.supports b...
diff --git a/style/parser.rs b/style/parser.rs index 81effece0..e38602144 100644 --- a/style/parser.rs +++ b/style/parser.rs @@ -82,27 +82,6 @@ impl<'a> ParserContext<'a> { } } - /// Create a parser context for on-the-fly parsing in CSSOM - #[inline] - pub fn new_for_cssom( - url_data: &...
2
2
22
b673e4025ba97231783482399229d3011e8d3f18
Emilio Cobos Álvarez
2020-10-08T05:39:33
Bug 1669600 - Properly distinguish between empty children and no children in rule iterator. r=heycam So that skip_children(), which just pops the stack and is used by the dynamic media query evaluation code, works as it should. Differential Revision: https://phabricator.services.mozilla.com/D92717
diff --git a/style/stylesheets/rules_iterator.rs b/style/stylesheets/rules_iterator.rs index 1fa25837a..ad3aa9759 100644 --- a/style/stylesheets/rules_iterator.rs +++ b/style/stylesheets/rules_iterator.rs @@ -60,7 +60,7 @@ fn children_of_rule<'a, C>( quirks_mode: QuirksMode, guard: &'a SharedRwLockReadGuard<'...
1
14
12
cd637e79917f1667d6980cf77eb39054ac665060
Emilio Cobos Álvarez
2020-10-08T09:42:49
Bug 1669858 - Use Option::as_deref() in style code. r=xidorn And drive-by simplify another function that was only doing Option::clone(). Differential Revision: https://phabricator.services.mozilla.com/D92839
diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs index 4319f982d..83c122c5f 100644 --- a/style/gecko/selector_parser.rs +++ b/style/gecko/selector_parser.rs @@ -471,7 +471,7 @@ impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> { } fn default_namespace(&self) -> Option<N...
4
10
16
6c97e3e6cb49cef56df394d5a387af3315502864
Razvan Maries
2020-10-02T14:11:33
Backed out changeset 20fadec3e9dc (bug 1187682) for perma failures on layout/reftests/mathml/stretchy-munderover-1c.html. CLOSED TREE
diff --git a/style/font_metrics.rs b/style/font_metrics.rs index d67d3d72d..b521fdf76 100644 --- a/style/font_metrics.rs +++ b/style/font_metrics.rs @@ -18,12 +18,6 @@ pub struct FontMetrics { pub x_height: Option<Length>, /// The zero advance. This is usually writing mode dependent pub zero_advance_meas...
4
5
98
da409ba46ae3a0e276481d42605a7d2295003b3c
Frederic Wang
2020-10-02T11:33:34
Bug 1187682 - Use ScriptPercentScaleDown and ScriptScriptPercentScaleDown constants. r=emilio The math-depth implementation is refined to take into account the ScriptPercentScaleDown and ScriptScriptPercentScaleDown constants (if the parent's first valid font has a MATH table) in order to calculate the scale factor be...
diff --git a/style/font_metrics.rs b/style/font_metrics.rs index b521fdf76..d67d3d72d 100644 --- a/style/font_metrics.rs +++ b/style/font_metrics.rs @@ -18,6 +18,12 @@ pub struct FontMetrics { pub x_height: Option<Length>, /// The zero advance. This is usually writing mode dependent pub zero_advance_meas...
4
98
5
5c9a592f54a18c03006f5db4e8c7bb65a6020d5a
Emilio Cobos Álvarez
2020-09-29T22:04:56
Bug 1668029 - When resetting background color for high contrast, preserve alpha channel appropriately. r=morgan But discard it when backplating behind text, so that text is readable. This should be uncontroversial... Dealing with widgets is a bit harder so TBD. Differential Revision: https://phabricator.services.moz...
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index 0a84f7e89..8fbccd1d9 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -385,6 +385,8 @@ fn tweak_when_ignoring_colors( declaration: &mut Cow<PropertyDeclaration>, declarations_to_apply_unless_overriden: &m...
2
40
15
594a88898161ea63da1d96515460e39c91c68a83
Razvan Maries
2020-09-29T21:20:09
Backed out changeset f1130dfcdbc4 (bug 1668029) for perma failures on backplate-select-001.html. CLOSED TREE
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index 8fbccd1d9..0a84f7e89 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -385,8 +385,6 @@ fn tweak_when_ignoring_colors( declaration: &mut Cow<PropertyDeclaration>, declarations_to_apply_unless_overriden: &m...
2
15
40
6ceb828769bfe651a3f5bd6e982eda800cbc1d5e
Frederic Wang
2020-09-28T10:42:49
Bug 1667527 - Implement CSS parsing for the math-depth property r=emilio Differential Revision: https://phabricator.services.mozilla.com/D91500
diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs index a04a74abf..e0d6f689c 100644 --- a/style/values/computed/font.rs +++ b/style/values/computed/font.rs @@ -35,6 +35,7 @@ use style_traits::{CssWriter, ParseError, ToCss}; use to_shmem::{self, SharedMemoryBuilder, ToShmem}; pub use crate::...
2
26
26
87dbe08304345d81e5724b62ea97e1e403fb778b
tobar2018
2020-09-25T10:29:08
Bug 1659264 - Remove all references to the preference 'layout.css.moz-touch-enabled.enabled'. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D91401
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index c96996a18..4fea1030d 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -559,19 +559,6 @@ fn eval_system_metric( query_value.map_or(supports_metric, |v| v == supports_metric) } -fn eval_moz_touch_enab...
2
1
26
bf5638b0bcae8e94b709cb5764c4162e4af534db
Frederic Wang
2020-09-24T15:34:17
Bug 1666075 - Implement displaystyle attribute on all MathML elements. r=emilio Gecko implements the displaystyle attribute as defined by MathML 3 i.e. only on the math, mstyle and mtable elements. This commit follows MathML Core and instead define it as a global attribute mapped to math-style. See https://mathml-refr...
diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs index f706ddad9..32c034c75 100644 --- a/style/properties/longhands/font.mako.rs +++ b/style/properties/longhands/font.mako.rs @@ -247,6 +247,7 @@ ${helpers.single_keyword( has_effect_on_gecko_scrollbars=False, anima...
1
1
0
2c53ac148cce226ebdeb313e6044e20de813faea
Frederic Wang
2020-09-23T13:04:48
Bug 1665975 - Implement the math-style property. r=emilio This patch renames the internal -moz-math-display to math-style and exposes it under the layout.css.math-style.enabled preference. The initial value becomes "normal" but that does not affect the default MathML behavior since the UA style sheet sets the math-sty...
diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs index 2ed226f78..f706ddad9 100644 --- a/style/properties/longhands/font.mako.rs +++ b/style/properties/longhands/font.mako.rs @@ -239,14 +239,14 @@ ${helpers.predefined_type( )} ${helpers.single_keyword( - "-moz-math-d...
2
9
9
677853df324abfcb69560bbce38be1535eb23c67
Narcis Beleuzu
2020-09-23T10:06:21
Backed out changeset 9480237e1e6f (bug 1665975) for xpcshell failure on test_css-properties-db.js. CLOSED TREE
diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs index f706ddad9..2ed226f78 100644 --- a/style/properties/longhands/font.mako.rs +++ b/style/properties/longhands/font.mako.rs @@ -239,14 +239,14 @@ ${helpers.predefined_type( )} ${helpers.single_keyword( - "math-style"...
2
9
9
beb744cae98b17ce42bbea373d3a0e27b9af01bb
Emilio Cobos Álvarez
2020-09-21T11:05:51
Bug 1660804 - Don't optimize ::before/::after away if content/display have been specified via custom properties. r=jwatt We need to treat them the same way as we treat content: inherit. Differential Revision: https://phabricator.services.mozilla.com/D90222
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index 11f3beb24..e161e2690 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -478,6 +478,25 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> { .rule_cache_conditions .borrow_mut() .se...
4
27
8
5f140e74b618c37b21d076360d0f7075accc9add
Emilio Cobos Álvarez
2020-09-21T09:57:46
Bug 1665816 - CSSOM should respect rule-level property restrictions. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D90729
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index fe52e6059..7bae033c9 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -1263,11 +1263,12 @@ pub fn parse_style_attribute( url_data: &UrlExtraData, error_reporter: Op...
3
19
13
b629ac007331534904e5f97023e2f9efcb249cc6
Bogdan Tara
2020-09-21T07:07:03
Backed out changeset 0da5103ba772 (bug 1665975) for mozglue_static::panic_hook mass crashes CLOSED TREE
diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs index 348ea647e..2ed226f78 100644 --- a/style/properties/longhands/font.mako.rs +++ b/style/properties/longhands/font.mako.rs @@ -239,14 +239,14 @@ ${helpers.predefined_type( )} ${helpers.single_keyword( - "math-style"...
2
9
9
709d840e06afb54e326eed34dcff5172f37a50ad
Frederic Wang
2020-09-21T05:41:51
Bug 1665975 - Implement the math-style property. r=emilio This patch renames the internal -moz-math-display to math-style and exposes it under the layout.css.math-style.enabled preference. The initial value becomes "normal" but that does not affect the default MathML behavior since the UA style sheet sets the math-sty...
diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs index 2ed226f78..348ea647e 100644 --- a/style/properties/longhands/font.mako.rs +++ b/style/properties/longhands/font.mako.rs @@ -239,14 +239,14 @@ ${helpers.predefined_type( )} ${helpers.single_keyword( - "-moz-math-d...
2
9
9