commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
fa1bfb5de7d0d91775350aa8f566d43cfa78f90d
Emilio Cobos Álvarez
2020-09-19T14:28:51
Bug 1665823 - Consider display: none elements as having current style for animation-only traversal. r=hiro This is mostly a band-aid, though it also serves sorta as an optimization. The issue here is basically bug 1393323. By re-cascading, right now we can't come up with the right before-change style if CSSOM has mut...
diff --git a/style/dom.rs b/style/dom.rs index 60e1be054..351f54af6 100644 --- a/style/dom.rs +++ b/style/dom.rs @@ -584,14 +584,35 @@ pub trait TElement: traversal_flags: TraversalFlags, ) -> bool { if traversal_flags.for_animation_only() { - // In animation-only restyle we never touc...
1
24
3
34b72040f8afb0122bb7dcae3e48916e01a14754
Emilio Cobos Álvarez
2020-09-14T22:33:01
Bug 1664718 - Allow :is() and :where() to have better error recovery. r=xidorn Adjust is-where-parsing.html to work with both the new and old behavior, and add a test for the new behavior. Depends on D90049 Differential Revision: https://phabricator.services.mozilla.com/D90050
diff --git a/selectors/parser.rs b/selectors/parser.rs index da87b9bb0..4416461f4 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -251,6 +251,11 @@ pub trait Parser<'i> { false } + /// The error recovery that selector lists inside :is() and :where() have. + fn is_and_where_error_reco...
2
60
14
fa6b1bfcce252261976e743aabdfb2eab8de7c8e
Mihai Alexandru Michis
2020-09-14T17:32:50
Backed out 2 changesets (bug 1664718) for causing wpt and bc failures. CLOSED TREE Backed out changeset 62e71d3b6b32 (bug 1664718) Backed out changeset c8a8791a26ed (bug 1664718)
diff --git a/selectors/parser.rs b/selectors/parser.rs index 4416461f4..da87b9bb0 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -251,11 +251,6 @@ pub trait Parser<'i> { false } - /// The error recovery that selector lists inside :is() and :where() have. - fn is_and_where_error_reco...
2
14
60
db23898f4a7b4f9ddcbba7e1dc08799f5ce3fc69
Emilio Cobos Álvarez
2020-09-14T15:37:36
Bug 1664718 - Fix selectors unit tests. MANUAL PUSH: Fix BR bustage. CLOSED TREE
diff --git a/selectors/parser.rs b/selectors/parser.rs index 9156bb496..4416461f4 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -2691,6 +2691,10 @@ pub mod tests { true } + fn is_and_where_error_recovery(&self) -> ParseErrorRecovery { + ParseErrorRecovery::Disca...
1
4
0
18049da98f7cf41796a9c162d780e964f74d2cc6
Emilio Cobos Álvarez
2020-09-14T15:04:22
Bug 1664718 - Allow :is() and :where() to have better error recovery. r=xidorn Adjust is-where-parsing.html to work with both the new and old behavior, and add a test for the new behavior. Depends on D90049 Differential Revision: https://phabricator.services.mozilla.com/D90050
diff --git a/selectors/parser.rs b/selectors/parser.rs index da87b9bb0..9156bb496 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -251,6 +251,11 @@ pub trait Parser<'i> { false } + /// The error recovery that selector lists inside :is() and :where() have. + fn is_and_where_error_reco...
2
56
14
6398d94a52e44db9c34d293b1fed62c1e8967399
Emilio Cobos Álvarez
2020-09-13T21:57:04
Bug 1664718 - Minor cleanup: Use shorthand initialization in selectors. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D90049
diff --git a/selectors/matching.rs b/selectors/matching.rs index 3414f9d6e..75d8e3670 100644 --- a/selectors/matching.rs +++ b/selectors/matching.rs @@ -751,7 +751,7 @@ where &NamespaceConstraint::Specific(&crate::parser::namespace_empty_string::<E::Impl>()), local_name, ...
2
15
15
07e1220ec4f5ec21292798e88eb02ac086c95cb9
Emilio Cobos Álvarez
2020-09-13T11:33:13
Bug 1664156 - Remove -moz-suppressed. r=edgar Per spec we shouldn't behave differently depending on how we blocked the image/object/etc. This may have made sense in the past when ad blockers were implemented via nsIContentPolicy, but I think nowadays it doesn't make sense, and showing fallback is preferred. There's ...
diff --git a/style/element_state.rs b/style/element_state.rs index cdce4d3cc..ebf6aa42a 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -53,8 +53,6 @@ bitflags! { const IN_MOZ_UI_INVALID_STATE = 1 << 13; /// Non-standard: https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-broke...
3
0
4
fdd96907e26bc26d79e7047dae3050937b9ef7b9
Noemi Erli
2020-09-12T19:56:18
Backed out changeset 64eb902728bc (bug 1664156) for causing mochitest failures in test_meta_csp_self.html CLOSED TREE
diff --git a/style/element_state.rs b/style/element_state.rs index ebf6aa42a..cdce4d3cc 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -53,6 +53,8 @@ bitflags! { const IN_MOZ_UI_INVALID_STATE = 1 << 13; /// Non-standard: https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-broke...
3
4
0
8cbeb1bc1f61c3946bbaf9bc1a5def847e86cb62
Emilio Cobos Álvarez
2020-09-11T19:26:40
Bug 1664432 - Remove -moz-user-disabled. r=edgar We treat it exactly the same as -moz-broken. The pseudo-class is not exposed to content, so I don't think we have a reason to keep it around. Differential Revision: https://phabricator.services.mozilla.com/D89904
diff --git a/style/element_state.rs b/style/element_state.rs index a3d001a2f..cdce4d3cc 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -53,8 +53,6 @@ bitflags! { const IN_MOZ_UI_INVALID_STATE = 1 << 13; /// Non-standard: https://developer.mozilla.org/en-US/docs/Web/CSS/:-moz-broke...
3
0
5
bb2b231eb7b57102bc67f48e3f3547b1d1d0bbfa
Emilio Cobos Álvarez
2020-09-08T10:33:03
Bug 1663618 - Speed up custom property diffing. r=boris When entering or leaving fullscreen in youtube, we spend most of the restyle time diffing custom properties, under IndexMap::eq. Turns out that IndexMap equality is not order-aware, and thus you actually need to make a hashmap lookup for each entry in the map, w...
diff --git a/style/gecko/restyle_damage.rs b/style/gecko/restyle_damage.rs index a97098363..4749daea1 100644 --- a/style/gecko/restyle_damage.rs +++ b/style/gecko/restyle_damage.rs @@ -57,7 +57,7 @@ impl GeckoRestyleDamage { &mut reset_only, ) }; - if reset_only && old_styl...
3
23
2
25fa133a64f15123660a1b65b27f399a00215ebd
Emilio Cobos Álvarez
2020-09-05T00:42:43
Bug 1663231 - Make @font-face and @counter-style serialization closer other browsers and style rules. r=xidorn Style rules serialize on one line and so should @font-face blocks. Part of https://github.com/w3c/csswg-drafts/issues/4828. Differential Revision: https://phabricator.services.mozilla.com/D89302
diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs index ecdc8828e..c7854b1ef 100644 --- a/style/counter_style/mod.rs +++ b/style/counter_style/mod.rs @@ -232,12 +232,12 @@ macro_rules! counter_style_descriptors { fn to_css(&self, _guard: &SharedRwLockReadGuard, dest: &mut CssStringWriter...
2
11
8
73845838d567c594334686011ee48e304c027692
Emilio Cobos Álvarez
2020-09-01T22:58:10
Bug 1662478 - Rename ::file-chooser-button to ::file-selector-button, and enable it in all channels. r=jwatt See https://github.com/w3c/csswg-drafts/issues/5049 Differential Revision: https://phabricator.services.mozilla.com/D88995
diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs index 16e3ab312..ed312dc2d 100644 --- a/style/gecko/pseudo_element.rs +++ b/style/gecko/pseudo_element.rs @@ -38,7 +38,7 @@ impl ::selectors::parser::PseudoElement for PseudoElement { PseudoElement::After | Pseu...
1
3
3
36104f2ea3dbecabf8e0956b775cbebff5742582
Emilio Cobos Álvarez
2020-08-27T09:37:31
Bug 1660857 - Only apply grayscale filter for printing on print preview. r=jwatt,dholbert Differential Revision: https://phabricator.services.mozilla.com/D88065
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index ed0dac477..c96996a18 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -521,6 +521,18 @@ fn eval_moz_is_glyph( query_value.map_or(is_glyph, |v| v == is_glyph) } +fn eval_moz_print_preview( + devic...
2
28
1
007dd315e49c781a331abb9c1e4b8fe300110ddf
Narcis Beleuzu
2020-08-26T21:28:58
Backed out 2 changesets (bug 1660857) for bc failures on browser_parsable_css.js . CLOSED TREE Backed out changeset 1378546cc0db (bug 1660857) Backed out changeset 6c8985ac1d4c (bug 1660857)
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index c96996a18..ed0dac477 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -521,18 +521,6 @@ fn eval_moz_is_glyph( query_value.map_or(is_glyph, |v| v == is_glyph) } -fn eval_moz_print_preview( - devic...
2
1
28
349fa19626ef76bbbf985eeac88699afaef0d7e6
Emilio Cobos Álvarez
2020-08-26T19:12:15
Bug 1660857 - Only apply grayscale filter for printing on print preview. r=jwatt,dholbert Depends on D88064 Differential Revision: https://phabricator.services.mozilla.com/D88065
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index ed0dac477..c96996a18 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -521,6 +521,18 @@ fn eval_moz_is_glyph( query_value.map_or(is_glyph, |v| v == is_glyph) } +fn eval_moz_print_preview( + devic...
2
28
1
4da4a4efe49405da65c78b910c1fc98f29cf3dbe
Masatoshi Kimura
2020-08-26T11:45:35
Bug 1658690 - Replace :-moz-native-anonymous-no-specificity with :where(:-moz-native-anonymous). r=emilio Differential Revision: https://phabricator.services.mozilla.com/D88255
diff --git a/selectors/builder.rs b/selectors/builder.rs index 4e295a159..0bf894a72 100644 --- a/selectors/builder.rs +++ b/selectors/builder.rs @@ -17,7 +17,7 @@ //! is non-trivial. This module encapsulates those details and presents an //! easy-to-use API for the parser. -use crate::parser::{Combinator, Component...
6
4
31
23f419abbfda51dba2d38164ba8273649ff35cf3
Emilio Cobos Álvarez
2020-08-20T10:45:42
Bug 1659718 - Bail out when collecting invalidations for nested rules if any of them make us fully invalid. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D87446
diff --git a/style/invalidation/stylesheets.rs b/style/invalidation/stylesheets.rs index b58688832..b50e04b0f 100644 --- a/style/invalidation/stylesheets.rs +++ b/style/invalidation/stylesheets.rs @@ -564,7 +564,10 @@ impl StylesheetInvalidationSet { let rules = EffectiveRulesItera...
1
4
1
03409b6e104e8e2692a16e9557dd92b65520248a
Emilio Cobos Álvarez
2020-08-19T10:32:16
Bug 1414600 - Make media queries and viewport units in print be evaluated against the default page size minus margins. r=dholbert,nordzilla For that, move the default page margin computation to nsPresContext. See https://github.com/w3c/csswg-drafts/issues/5437 as to why doing this and other alternatives. Differentia...
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 321669ce1..ed0dac477 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -17,18 +17,6 @@ use crate::Atom; use app_units::Au; use euclid::default::Size2D; -fn viewport_size(device: &Device) -> Size2D<Au> { ...
2
27
18
903eafccd150f46fcabb9d283a9160c31cfe4401
Nicolas Silva
2020-08-18T17:28:27
Bug 1656236 - Update euclid in stylo. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D85762
diff --git a/style/Cargo.toml b/style/Cargo.toml index b7899be7f..825190f7e 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -37,7 +37,7 @@ cssparser = "0.27" derive_more = "0.99" new_debug_unreachable = "1.0" encoding_rs = {version = "0.8", optional = true} -euclid = "0.20" +euclid = "0.22" fallible = { pat...
3
29
30
c05e88c29ea1534d1c47f27cca2c9b5b2a9627ca
Nicolas Silva
2020-08-18T22:09:27
Bug 1656236 - Update to euclid 0.22. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D85549
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 77915f1fa..802f65219 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -32,7 +32,7 @@ app_units = "0.7" content-security-policy = { version = "0.4.0", features = ["serde"], optional = true } crossbeam-channel = { version ...
1
1
1
5edf9ec73ae83cb9ec5d8b024ea5233aa8b55793
Csoregi Natalia
2020-08-19T01:58:49
Backed out changeset b6d1532f6cd4 (bug 1414600) for failures on mq_print_height.xhtml . CLOSED TREE
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index ed0dac477..321669ce1 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -17,6 +17,18 @@ use crate::Atom; use app_units::Au; use euclid::default::Size2D; +fn viewport_size(device: &Device) -> Size2D<Au> { ...
2
18
27
43aad5c177b3a75c14ef9381ab989b3fc73b0244
Csoregi Natalia
2020-08-18T17:22:57
Backed out 3 changesets (bug 1656236) for wrench failures on filter-drop-shadow-clip-3.yaml. CLOSED TREE Backed out changeset 78205b816ac8 (bug 1656236) Backed out changeset dc4ccb5a8ea9 (bug 1656236) Backed out changeset dcfa644ba078 (bug 1656236)
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 802f65219..77915f1fa 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -32,7 +32,7 @@ app_units = "0.7" content-security-policy = { version = "0.4.0", features = ["serde"], optional = true } crossbeam-channel = { version ...
4
31
30
28e4e332171a4ea70357fec088cdc7fc30f2cdde
Zeke Medley
2020-08-17T20:50:49
Bug 1591204 - Support forced colors media feature r=emilio Enabled behind layout.css.forced-colors.enabled pending finalization of the spec: <https://drafts.csswg.org/mediaqueries-5/#forced-colors> Differential Revision: https://phabricator.services.mozilla.com/D87147
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index ef08cafab..321669ce1 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -353,6 +353,26 @@ fn eval_prefers_contrast(device: &Device, query_value: Option<PrefersContrast>) } } +/// Possible values for t...
2
30
1
3349884b69c1d449c72668acec050a602c2d12ec
Sean Feng
2020-08-17T15:41:19
Bug 1200896 - Make the document blocked by the topmost element in the top layer r=emilio Spec: https://html.spec.whatwg.org/multipage/#blocked-by-a-modal-dialog Depends on D86392 Differential Revision: https://phabricator.services.mozilla.com/D86227
diff --git a/style/element_state.rs b/style/element_state.rs index da44186b4..a3d001a2f 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -148,6 +148,8 @@ bitflags! { /// https://html.spec.whatwg.org/multipage/interaction.html#inert-subtrees const IN_MOZINERT_STATE = 1 << 54; + ...
4
7
0
d5b15de425b12158a8b031b49cf5fe840dbd8f33
Shinichi Morimoto
2020-08-17T17:51:31
Bug 1659265 - remove layout.css.offset-logical-properties.enabled. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D87297
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index 25354ab19..5515b2d16 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -30,7 +30,6 @@ "computed::LengthPercentageOrAuto::auto()", eng...
1
0
1
a8f6d83782359994f8fe56d4c34ce7ea25875ce9
Zeke Medley
2020-08-17T01:41:16
Bug 1658780 - Update the prefers-contrast media query to use the new more/less keywords r=emilio Per the resolution here: https://github.com/w3c/csswg-drafts/issues/2943#issuecomment-672994920 Differential Revision: https://phabricator.services.mozilla.com/D86848
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 0a8698016..ef08cafab 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -313,8 +313,8 @@ fn eval_prefers_reduced_motion(device: &Device, query_value: Option<PrefersReduc #[repr(u8)] #[allow(missing_docs)] ...
1
8
9
6cd8c94b0f7904e08717442b4d8167b6d2e1fbd5
Emilio Cobos Álvarez
2020-08-16T00:43:48
Bug 1600635 - Fix two minor issues with scrollbar style caching. r=heycam Add -moz-inert and -moz-script-level to the set of internal properties that aren't included in "all". -moz-inert may need to be uncacheable in the future if we make it not change the pointer-events computed value. Left a comment to that effect....
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index c48d1bc01..a23f97d57 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -162,6 +162,9 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { /// user-select: none; /// pointer-events: none; /// cursor: defau...
1
3
0
0fc3e3981f6e2a0d5e1741f2fae551f89ff03253
Mihai Alexandru Michis
2020-08-14T06:06:45
Backed out 3 changesets (Bug 1200896) for causing Bug 1659042. CLOSED TREE Backed out changeset 17df14f0b129 (bug 1200896) Backed out changeset 5d9e9bd12cd2 (bug 1200896) Backed out changeset 7f016de8d52f (bug 1200896)
diff --git a/style/element_state.rs b/style/element_state.rs index a3d001a2f..da44186b4 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -148,8 +148,6 @@ bitflags! { /// https://html.spec.whatwg.org/multipage/interaction.html#inert-subtrees const IN_MOZINERT_STATE = 1 << 54; - ...
4
0
6
9d2ee54c60c400dabb0f067f1ac9b7bcc0c91e61
Sean Feng
2020-08-13T19:05:37
Bug 1200896 - Make the document blocked by the topmost element in the top layer r=emilio Spec: https://html.spec.whatwg.org/multipage/#blocked-by-a-modal-dialog Differential Revision: https://phabricator.services.mozilla.com/D86227
diff --git a/style/element_state.rs b/style/element_state.rs index da44186b4..a3d001a2f 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -148,6 +148,8 @@ bitflags! { /// https://html.spec.whatwg.org/multipage/interaction.html#inert-subtrees const IN_MOZINERT_STATE = 1 << 54; + ...
4
6
0
15e23920d37ef493db1a82802926cc20df7e3e70
Emilio Cobos Álvarez
2020-08-12T04:26:07
Bug 561154 - Implement :-moz-any() as an alias of :is(). r=heycam This is strictly better and more flexible, but can change specificity so have a pref in case it causes trouble. I doubt it will though, the specificity rules of :is() make more sense, and my gut feeling is that :-moz-any is not very used on the wild. M...
diff --git a/selectors/parser.rs b/selectors/parser.rs index 9980bdeeb..8f87c785f 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -254,6 +254,11 @@ pub trait Parser<'i> { false } + /// Whether the given function name is an alias for the `:is()` function. + fn is_is_alias(&self, _name...
2
15
0
84e69886aa4beea35fc7eae25606141f5215eb06
Emilio Cobos Álvarez
2020-08-11T10:27:42
Bug 1658525- Remove layout.css.comparison-functions.enabled. r=xidorn Shipped since FF75 (bug 1519519). Differential Revision: https://phabricator.services.mozilla.com/D86693
diff --git a/style/values/specified/calc.rs b/style/values/specified/calc.rs index 9947fc7a8..fa5415ee3 100644 --- a/style/values/specified/calc.rs +++ b/style/values/specified/calc.rs @@ -517,26 +517,8 @@ impl CalcNode { name: &CowRcStr<'i>, location: cssparser::SourceLocation, ) -> Result<MathF...
1
1
19
a9102e7406f5686954d03f644d956a954e39cacb
Emilio Cobos Álvarez
2020-08-11T05:54:22
Bug 1658470 - Remove layout.css.is-where-selectors.enabled. r=heycam Shipped since 78 (bug 1632646). Differential Revision: https://phabricator.services.mozilla.com/D86662
diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs index c50ee5feb..3afe31d71 100644 --- a/style/gecko/selector_parser.rs +++ b/style/gecko/selector_parser.rs @@ -343,8 +343,7 @@ impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> { #[inline] fn parse_is_and_where(&self) ->...
1
1
2
731e2dbbb7f690f1e5bfeb158b717c3146a05174
Emilio Cobos Álvarez
2020-08-11T05:54:17
Bug 1658470 - Remove layout.css.shadow-parts.enabled. r=heycam Shipped since 72 (bug 1559074). Differential Revision: https://phabricator.services.mozilla.com/D86661
diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs index fd0494fa4..c50ee5feb 100644 --- a/style/gecko/selector_parser.rs +++ b/style/gecko/selector_parser.rs @@ -349,7 +349,7 @@ impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> { #[inline] fn parse_part(&self) -> bool { ...
1
1
1
93d7a547bd127c62d796defd3359aa1faddc3d0a
Razvan Maries
2020-08-10T20:08:04
Backed out 2 changesets (bug 1200896) for perma failures on browser_pioneer_ui.js. CLOSED TREE Backed out changeset c7ae88fd1bd7 (bug 1200896) Backed out changeset 8b57f059e63e (bug 1200896)
diff --git a/style/element_state.rs b/style/element_state.rs index a3d001a2f..da44186b4 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -148,8 +148,6 @@ bitflags! { /// https://html.spec.whatwg.org/multipage/interaction.html#inert-subtrees const IN_MOZINERT_STATE = 1 << 54; - ...
4
0
6
2c97113a3d62ab3f70e4a789c385cce760066013
Emilio Cobos Álvarez
2020-08-10T18:00:44
Bug 1655751 - Invalidate for CSSOM changes in a more fine-grained way. r=heycam Also, for changes in CSS declarations, like changing cssRules[i].style.color or something, we end up avoiding a lot of the work we were doing. This page still trips us in the sense that they add a stylesheet, then call getBoundingClientRe...
diff --git a/style/invalidation/stylesheets.rs b/style/invalidation/stylesheets.rs index 18d24a28a..b58688832 100644 --- a/style/invalidation/stylesheets.rs +++ b/style/invalidation/stylesheets.rs @@ -16,10 +16,26 @@ use crate::selector_map::{MaybeCaseInsensitiveHashMap, PrecomputedHashMap}; use crate::selector_parser...
6
273
74
19663671527221efb21ecfc63f17a74c3fc02f55
Emilio Cobos Álvarez
2020-08-10T18:00:29
Bug 1655751 - Fix a silly mistake in which we'd prefer a local name / tag invalidation to an id invalidation. r=heycam ID invalidations should always win. This also prefers invalidations deeper in the subtree to higher up. Differential Revision: https://phabricator.services.mozilla.com/D85615
diff --git a/style/invalidation/stylesheets.rs b/style/invalidation/stylesheets.rs index 4b37133a2..18d24a28a 100644 --- a/style/invalidation/stylesheets.rs +++ b/style/invalidation/stylesheets.rs @@ -340,6 +340,8 @@ impl StylesheetInvalidationSet { data.hint.contains(RestyleHint::RESTYLE_SELF) || any_children...
1
5
3
95942fc1c379b60685cce4315e9f20bdd0094c8e
Dorel Luca
2020-08-05T15:39:35
Backed out 4 changesets (bug 1656236) for Webrender build bustage in reftests/filters/filter-drop-shadow-clip-3.yaml. CLOSED TREE Backed out changeset c24f6a05294b (bug 1656236) Backed out changeset a5d6a6f2f3ac (bug 1656236) Backed out changeset bf4a2fe9f9c0 (bug 1656236) Backed out changeset c5189b274b91 (bug 165623...
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 802f65219..77915f1fa 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -32,7 +32,7 @@ app_units = "0.7" content-security-policy = { version = "0.4.0", features = ["serde"], optional = true } crossbeam-channel = { version ...
4
31
30
d82ec01081b0cdeaa2be9a2b9cc3983586e73ccf
Cristina Coroiu
2020-08-05T09:10:43
Backed out 4 changesets (bug 1656236) for build bustages on a CLOSED TREE Backed out changeset bd79e14bc5ba (bug 1656236) Backed out changeset dc76da883823 (bug 1656236) Backed out changeset c4883923e091 (bug 1656236) Backed out changeset 9464c1dcb0c9 (bug 1656236)
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 802f65219..77915f1fa 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -32,7 +32,7 @@ app_units = "0.7" content-security-policy = { version = "0.4.0", features = ["serde"], optional = true } crossbeam-channel = { version ...
4
31
30
3645c1fe2f7eb1ccf6014fb787d8c035effe157a
Emilio Cobos Álvarez
2020-08-03T21:19:56
Bug 1656954 - Use Overflow::is_scrollable in StyleAdjuster. r=mats It was introduced in the overflow: clip work but this standalone equivalent remained. Differential Revision: https://phabricator.services.mozilla.com/D85778
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index e612d3b99..c48d1bc01 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -533,13 +533,9 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { let overflow_x = box_style.clone_overflow_x(); let overflow_y = box_style.clone_ove...
1
1
5
3d6f3994507a9c0f3f694f951670595ca0c67a48
Mats Palmgren
2020-08-01T01:57:41
Bug 1531609 part 2 - Implement overflow:clip/visible combinations. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D73717
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index a11a19561..e612d3b99 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -469,48 +469,22 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { } } - /// CSS3 overflow-x and overflow-y require some fixup as well in some - ...
1
11
37
ac5b5515944a1e0ddefe00736e451511cfa367f2
Jeremy Ir
2020-08-01T01:56:58
Bug 1531609 part 1 - Rename overflow:-moz-hidden-unscrollable to overflow:clip. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D73716
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index fb5fae96b..a11a19561 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -499,10 +499,10 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { { // overflow: clip is deprecated, so convert to hidden if it's /...
2
24
4
eaf79576fddf08a39b259f00b4d705302c7609d9
Butkovits Atila
2020-07-31T20:56:54
Backed out 3 changesets (bug 1635473, bug 1531609) for reftest failures. CLOSED TREE Backed out changeset 1e7b32808be8 (bug 1531609) Backed out changeset e64a61869cdb (bug 1531609) Backed out changeset 6da37d7f6dd3 (bug 1635473)
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index e612d3b99..fb5fae96b 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -469,22 +469,48 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { } } - /// CSS overflow-x and overflow-y require some fixup as well in some cases....
2
39
33
fc7cbf91a1873fab039a12abc047c6cf46b829e2
Zeke Medley
2020-07-31T16:11:38
Bug 546052 - Add parsing for cross-fade from CSS Image Values and Replaced Content Module Level 4 r=emilio This is the first of what will likely be a couple patches for cross-fade's implementation. Bug 546052 tracks it's complete implementation. Differential Revision: https://phabricator.services.mozilla.com/D81889
diff --git a/style/parser.rs b/style/parser.rs index 26e7cab1a..81effece0 100644 --- a/style/parser.rs +++ b/style/parser.rs @@ -207,6 +207,18 @@ where } } +impl<T> Parse for Box<T> +where + T: Parse +{ + fn parse<'i, 't>( + context: &ParserContext, + input: &mut Parser<'i, 't>, + ) -> Re...
5
205
5
d0a0b942cb36608f3184735e4068005bd60e8fa2
Dorel Luca
2020-07-28T23:12:55
Backed out changeset 9e9c50bbb2f3 (bug 546052) for build bustage on Linux. CLOSED TREE
diff --git a/style/parser.rs b/style/parser.rs index 81effece0..26e7cab1a 100644 --- a/style/parser.rs +++ b/style/parser.rs @@ -207,18 +207,6 @@ where } } -impl<T> Parse for Box<T> -where - T: Parse -{ - fn parse<'i, 't>( - context: &ParserContext, - input: &mut Parser<'i, 't>, - ) -> Re...
4
5
192
1c281ec5d3b83246439cc7ee9f5f15ad1c332e32
Zeke Medley
2020-07-28T22:18:31
Bug 546052 - Add parsing for cross-fade from CSS Image Values and Replaced Content Module Level 4 r=emilio This is the first of what will likely be a couple patches for cross-fade's implementation. Bug 546052 tracks it's complete implementation. Differential Revision: https://phabricator.services.mozilla.com/D81889
diff --git a/style/parser.rs b/style/parser.rs index 26e7cab1a..81effece0 100644 --- a/style/parser.rs +++ b/style/parser.rs @@ -207,6 +207,18 @@ where } } +impl<T> Parse for Box<T> +where + T: Parse +{ + fn parse<'i, 't>( + context: &ParserContext, + input: &mut Parser<'i, 't>, + ) -> Re...
4
192
5
601c31c9fd7520977fc3a109a6f47ecd30068283
Brian Birtles
2020-07-27T18:45:35
Bug 1654195 - Make text-combine-upright not animatable; r=boris Differential Revision: https://phabricator.services.mozilla.com/D84935
diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs index 41614a04d..658fa39f5 100644 --- a/style/properties/longhands/inherited_text.mako.rs +++ b/style/properties/longhands/inherited_text.mako.rs @@ -353,7 +353,7 @@ ${helpers.single_keyword( "text-co...
1
1
1
c15cca2238f48183b401d2577629b7e9d344e3ed
Alexander Surkov
2020-07-26T21:30:56
Bug 921504 - implement -moz-inert CSS property r=emilio -moz-inert CSS property reflects inert subtrees concept and can be used to implement HTML:dialog element and HTML:inert attribute Differential Revision: https://phabricator.services.mozilla.com/D81701
diff --git a/style/element_state.rs b/style/element_state.rs index 027ebc839..da44186b4 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -145,6 +145,9 @@ bitflags! { /// /// https://html.spec.whatwg.org/multipage/#centered-alignment const IN_MODAL_DIALOG_STATE = 1 << 53; + ...
6
69
0
693299fccaf13362bb49bc0919b1dfdc81730546
Philipp Zech
2020-07-23T21:31:23
Bug 1648938 - Convert writing-modes #defines to an enum class. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D84016
diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs index 37d86d626..32f9819a4 100644 --- a/style/properties/longhands/inherited_box.mako.rs +++ b/style/properties/longhands/inherited_box.mako.rs @@ -31,6 +31,7 @@ ${helpers.single_keyword( servo_2020_pre...
1
1
0
399d04540b7d56eb70501a81c17c7d1c0db6e35e
Narcis Beleuzu
2020-07-22T20:53:55
Backed out 2 changesets (bug 921504) for wpt failures on inert-retargeting-iframe.tentative.html . CLOSED TREE Backed out changeset 8b75cd744e80 (bug 921504) Backed out changeset a56b2d354613 (bug 921504)
diff --git a/style/element_state.rs b/style/element_state.rs index da44186b4..027ebc839 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -145,9 +145,6 @@ bitflags! { /// /// https://html.spec.whatwg.org/multipage/#centered-alignment const IN_MODAL_DIALOG_STATE = 1 << 53; - ...
6
0
69
f9f62f5b1330ba81ca36da244dcb4cff86498db3
Alexander Surkov
2020-07-22T04:26:08
Bug 921504 - implement HTML:inert r=emilio,heycam Differential Revision: https://phabricator.services.mozilla.com/D81701
diff --git a/style/element_state.rs b/style/element_state.rs index 027ebc839..da44186b4 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -145,6 +145,9 @@ bitflags! { /// /// https://html.spec.whatwg.org/multipage/#centered-alignment const IN_MODAL_DIALOG_STATE = 1 << 53; + ...
6
69
0
acf5cfc2761efd89624f0aa9944741e269755a68
Mats Palmgren
2020-07-21T19:46:45
Bug 1653052 - [css-grid] Make empty and all-whitespace strings in 'grid-template-areas' invalid. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D84398
diff --git a/style/values/specified/position.rs b/style/values/specified/position.rs index 72886b2d7..1b55e0108 100644 --- a/style/values/specified/position.rs +++ b/style/values/specified/position.rs @@ -710,6 +710,11 @@ impl TemplateAreas { }); current_area_index = Some(index...
1
5
0
fd2de4871ef58d68f9eac20ceda36e728fdf83e2
Narcis Beleuzu
2020-07-20T14:37:32
Backed out 2 changesets (bug 921504) for mochitest failures on test_animation-type-longhand.html . CLOSED TREE Backed out changeset e87edffd46b9 (bug 921504) Backed out changeset eb53880e5f0e (bug 921504)
diff --git a/style/element_state.rs b/style/element_state.rs index da44186b4..027ebc839 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -145,9 +145,6 @@ bitflags! { /// /// https://html.spec.whatwg.org/multipage/#centered-alignment const IN_MODAL_DIALOG_STATE = 1 << 53; - ...
6
0
69
25af9d8105c1c14ed2c1e53bfa65d73a883a8297
Emilio Cobos Álvarez
2020-07-20T07:40:17
Bug 1652698 - Make stylesheet invalidation faster. r=heycam This fixes performance issues when there's a massive number of rules and a massive DOM. Instead of going through all rules for all the DOM, we now look stuff in hashmaps. Differential Revision: https://phabricator.services.mozilla.com/D83506
diff --git a/style/invalidation/stylesheets.rs b/style/invalidation/stylesheets.rs index 244366af2..4b37133a2 100644 --- a/style/invalidation/stylesheets.rs +++ b/style/invalidation/stylesheets.rs @@ -7,28 +7,23 @@ #![deny(unsafe_code)] +use crate::context::QuirksMode; use crate::dom::{TDocument, TElement, TNode}...
2
197
122
b7f674795224caef007bad3b4ec4683786f61db3
Cameron McCormack
2020-07-17T09:56:53
Bug 1643246 - Don't use attribute selectors for determining if a select is a drop down or a list box. r=emilio Instead add a pseudo-class that does the expected size="" attribute parsing. Removing the Gtk-specific rule setting the text color since it doesn't seem to have any effect currently. Differential Revision: ...
diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs index 7b737f4d9..034ce0694 100644 --- a/style/gecko/non_ts_pseudo_class_list.rs +++ b/style/gecko/non_ts_pseudo_class_list.rs @@ -32,6 +32,7 @@ macro_rules! apply_non_ts_list { [ ("-moz-table-bor...
4
19
0
08ac36b5a934c05558cc9dc6ca881af23baf7159
Cameron McCormack
2020-07-16T22:04:38
Bug 1620467 - Part 12: Hide range and number-input appearance values from content. r=emilio Forgot to follow up on these two remaining non-standard values that may have been being used to reset a <meter> or <input type=number> back to its original appearance, but which telemetry showed no usage of. Differential Revis...
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 72fe58526..078f74a4a 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1612,6 +1612,7 @@ pub enum Appearance { #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")] MozMenulistArrowButton, ...
1
2
0
82f3b839d6443b99f4b7824b0a21e2235b55b8e6
Cameron McCormack
2020-07-16T22:04:31
Bug 1620467 - Part 11: Re-order Appearance values. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D83437
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index ea0e2e111..72fe58526 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1531,8 +1531,31 @@ pub enum Appearance { /// This value doesn't make sense for -moz-default-appearance, but we don't bother to gua...
1
23
23
d21c1db8840af26a7ae80c3c5a87cfa1ae582629
Cameron McCormack
2020-07-16T22:04:21
Bug 1620467 - Part 7: Avoid exposing `appearance: range-thumb` to content. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D83433
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 7304634be..e77387a98 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1623,7 +1623,8 @@ pub enum Appearance { RadioLabel, /// nsRangeFrame and its subparts Range, - RangeThumb, // FIXME: ...
1
2
1
73ab617b272c955698c442b192e159f6c4138d41
Cameron McCormack
2020-07-16T22:04:17
Bug 1620467 - Part 6: Mark appearance values that are only used internally as chrome-only. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D83432
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 3658a791d..7304634be 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1654,10 +1654,14 @@ pub enum Appearance { #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")] ScrollbarbuttonRight, ...
1
4
0
e20fa752266a757ccffa47a5115e73b1e0323ed7
Cameron McCormack
2020-07-16T22:04:14
Bug 1620467 - Part 5: Remove appearance values not used by the browser or Web content. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D83431
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 399f828d1..3658a791d 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1551,8 +1551,6 @@ pub enum Appearance { /// A groupbox. #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")] Gro...
1
0
15
ebb5de48c54599261dc78469c689459135ccce5c
Cameron McCormack
2020-07-16T22:04:14
Bug 1620467 - Part 4: Change internal uses of -moz-appearance to appearance and -moz-default-appearance. r=emilio,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,ntim,agi,miketaylr Uses of `-moz-appearance: none` are changed to `appearance: none`. Uses of other values that are simply reverting the appea...
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 18a46bc18..ca93fd916 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -635,7 +635,7 @@ ${helpers.predefined_type( engines="gecko", animation_value_type="none", ...
1
1
1
eba72f2e244914f4675e8a128dfa53e8682b808d
Cameron McCormack
2020-07-16T22:04:12
Bug 1620467 - Part 3: Defer to -moz-default-appearance when appearance is auto. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D83429
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index b33458a0f..8ab4aea3d 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -766,7 +766,13 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { use crate::properties::longhands::appearance::computed_value::T as Appearance; use ...
1
7
1
71cf1ec240bc46e7519707daffc637efe8ffbdac
Cameron McCormack
2020-07-16T22:04:11
Bug 1620467 - Part 2: Add unprefixed appearance property and make -moz-appearance and -webkit-appearance be aliases. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D83428
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 943bd0f27..18a46bc18 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -615,22 +615,19 @@ ${helpers.predefined_type( spec="https://drafts.csswg.org/css-contain/#conta...
3
12
10
66fe078d03767b5236ee5358d6117126c797d17a
Emilio Cobos Álvarez
2020-07-16T18:51:21
Bug 1653339 - Teach style_derive's map_type_params about mapping self correctly. r=boris Consider the following: struct Complex<T> { something: T, #[compute(field_bound)] something_else: Generic<Self, T>, } That will generate: impl<T> ToComputedValue for Complex<T> where T: ToComputedValue, Gene...
diff --git a/derive_common/cg.rs b/derive_common/cg.rs index c51c0d775..8abfd8714 100644 --- a/derive_common/cg.rs +++ b/derive_common/cg.rs @@ -154,19 +154,19 @@ pub fn fmap_trait_output(input: &DeriveInput, trait_path: &Path, trait_output: & segment.into() } -pub fn map_type_params<F>(ty: &Type, params: &[&Ty...
2
21
13
e75bf6344580c39f09f58698ed50a41ad5546014
Emilio Cobos Álvarez
2020-07-15T03:45:33
Bug 1631449 - Apply a grayscale filter to pages when monochrome. r=jwatt This hooks the "monochrome" media query and co to the nsIPrintSettings.printInColor setting. This print setting we're using is not exposed in the print preview UI, but you can test it setting the print.print_in_color preference to "false", and t...
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index f3b829743..0a8698016 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -247,13 +247,12 @@ fn eval_color_index( /// https://drafts.csswg.org/mediaqueries-4/#monochrome fn eval_monochrome( - _: &Device,...
1
2
3
b8746e023ee60cc65984eb3a821d654a50626a8d
Emilio Cobos Álvarez
2020-07-06T16:26:20
Bug 1650189 - Fix an off-by-one in the transition property iterator. r=mrobinson By the time we get to iterate over the longhands of a shorthand, we've already advanced the range iterator, so we look at the next duration and such, which causes this bug. I'm seriously baffled that no existing test caught this when it ...
diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs index 304f026de..f2fc745c5 100644 --- a/style/properties/helpers/animated_properties.mako.rs +++ b/style/properties/helpers/animated_properties.mako.rs @@ -820,7 +820,7 @@ impl<'a> Iterator for Trans...
1
1
1
2581cbe92baa21c873ab15537b4a5739527ff721
Cameron McCormack
2020-07-03T04:11:18
Bug 1650259 - Remove unused function on Appearance. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D82124
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index a02e49c1a..f87b85942 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1848,14 +1848,6 @@ pub enum Appearance { Count, } -impl Appearance { - /// Returns whether we're the `none` value. - #[in...
1
0
8
583d85275574345b90f292c05dc9fbe5b9482c7e
Cameron McCormack
2020-07-03T04:06:13
Bug 1650256 - Remove unused StyleAppearance values. r=emilio The parsing of these values was disabled in bug 1554150. Differential Revision: https://phabricator.services.mozilla.com/D82122
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 6fc86b486..a02e49c1a 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1537,16 +1537,9 @@ pub enum Appearance { ButtonArrowPrevious, #[parse(condition = "ParserContext::in_ua_or_chrome_sheet")] ...
1
0
13
f774d396a1f6a636f7be74879d6e08a65fed1883
Emilio Cobos Álvarez
2020-06-30T22:31:22
Bug 1631929 - Have the destructor of CalcNode be never inline. r=dmajor You tell me which other things need it... Copy-constructor? operator==? and such? Differential Revision: https://phabricator.services.mozilla.com/D73385
diff --git a/style/values/generics/calc.rs b/style/values/generics/calc.rs index cd3318183..0d791e5d0 100644 --- a/style/values/generics/calc.rs +++ b/style/values/generics/calc.rs @@ -60,6 +60,13 @@ pub enum SortKey { /// /// FIXME: This would be much more elegant if we used `Self` in the types below, /// but we ca...
1
7
0
4bdc828fc46bc2d38957a7551972a75f02f6f1ed
Zeke Medley
2020-06-29T17:46:12
Bug 1506364 - Implement the prefers-contrast media-query. r=morgan,emilio Differential Revision: https://phabricator.services.mozilla.com/D79553
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index a02ddcfd6..f3b829743 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -308,6 +308,53 @@ fn eval_prefers_reduced_motion(device: &Device, query_value: Option<PrefersReduc } } +/// Possible values for ...
3
71
4
edbe6030255524829469544a9a60757c9f12b145
Emilio Cobos Álvarez
2020-06-22T09:45:40
Bug 1646224 - Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame This avoids arbitrary precision loss when computing REM units and so on, which is particularly important if we ever change the base of our app units (but useful regardless). Differential Revision: https://phabricator.services...
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index 27cb666fc..663acae7b 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -11,6 +11,7 @@ use crate::gecko_bindings::structs; use crate::media_queries::MediaType; use crate::properties::ComputedValues; use crate:...
12
99
100
4628b9525becf055e3d24ea58653c7f4c34aaf84
Emilio Cobos Álvarez
2020-06-18T18:14:29
Bug 1646811 - Fix gecko build. Depends on D80248 Differential Revision: https://phabricator.services.mozilla.com/D80249
diff --git a/style/animation.rs b/style/animation.rs index 4576b91ef..ac6d4efa1 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -889,7 +889,8 @@ impl ElementAnimationSet { } } - pub(crate) fn apply_active_animations( + /// Apply all active animations. + pub fn apply_active_animation...
7
27
34
a4dbedd3227698fa8348df5d093b4f87f5840066
Emilio Cobos Álvarez
2020-06-18T18:14:24
Bug 1646811 - Remove some unused extern crate declarations now that style is in rust 2018. This avoids some warnings. Depends on D80247 Differential Revision: https://phabricator.services.mozilla.com/D80248
diff --git a/style/build.rs b/style/build.rs index 1d5211d69..2247e8761 100644 --- a/style/build.rs +++ b/style/build.rs @@ -4,15 +4,6 @@ #[macro_use] extern crate lazy_static; -#[cfg(feature = "gecko")] -extern crate bindgen; -#[cfg(feature = "gecko")] -extern crate log; -#[cfg(feature = "gecko")] -extern crate re...
3
2
52
ef758df473fb756e9b2ac10d0fd0598c68a1dacf
Emilio Cobos Álvarez
2020-06-18T18:14:21
Bug 1646811 - servo: Remove the dependency on font-kit from style. No good reason to have this IMO, and helps remove some #[cfg] blocks. Depends on D80246 Differential Revision: https://phabricator.services.mozilla.com/D80247
diff --git a/style/lib.rs b/style/lib.rs index ae048826a..6116c1266 100644 --- a/style/lib.rs +++ b/style/lib.rs @@ -40,8 +40,6 @@ extern crate debug_unreachable; extern crate derive_more; extern crate euclid; extern crate fallible; -#[cfg(feature = "servo")] -extern crate font_kit; extern crate fxhash; #[cfg(feat...
2
0
53
03950c1405ffb9c8fa95294e5c538536c472798f
Emilio Cobos Álvarez
2020-06-18T18:14:13
Bug 1646811 - Fix servo build. Depends on D80245 Differential Revision: https://phabricator.services.mozilla.com/D80246
diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs index 13f8b9998..6fee8c2e7 100644 --- a/style/values/specified/font.rs +++ b/style/values/specified/font.rs @@ -796,6 +796,7 @@ impl FontSizeKeyword { FontSizeKeyword::XLarge => medium * 3.0 / 2.0, FontSizeKeyword::XX...
1
1
0
e3fa441b0be90bcbc9487bfe908daf23b88d1445
Emilio Cobos Álvarez
2020-06-18T18:14:10
Bug 1646811 - Sync some comment changes from servo. Depends on D80244 Differential Revision: https://phabricator.services.mozilla.com/D80245
diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml index 273901499..bccdaaaf7 100644 --- a/fallible/Cargo.toml +++ b/fallible/Cargo.toml @@ -17,9 +17,9 @@ smallvec = "1.0" # feature is specified. # # In that case, we actually call the system malloc functions to reserve space, -# otherwise we just let rust do its...
4
4
5
5e8eba329f716f956814f85414cf6f73a469f7e1
Martin Robinson
2020-06-18T18:14:07
Bug 1646811 - servo: Combine AnimationAndTransitionDeclarations and AnimationRules. These two structs are very similar, so we can combine them. Depends on D80243 Differential Revision: https://phabricator.services.mozilla.com/D80244
diff --git a/style/animation.rs b/style/animation.rs index ad5e41553..4576b91ef 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -14,6 +14,7 @@ use crate::properties::animated_properties::{AnimationValue, AnimationValueMap}; use crate::properties::longhands::animation_direction::computed_value::single_value...
6
39
51
dcaa982c852a2d6ae997c6676b16d2daf4c2b908
Martin Robinson
2020-06-18T18:14:05
Bug 1646811 - servo: Add animation and transition support for pseudo-elements. This change extends the DocumentAnimationSet to hold animations for pseudo-elements. Since pseudo-elements in Servo are not in the DOM like in Gecko, they need to be handled a bit carefully in stylo. When a pseudo-element has an animation,...
diff --git a/style/animation.rs b/style/animation.rs index ecb921a5e..ad5e41553 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -19,6 +19,7 @@ use crate::properties::{ PropertyDeclarationId, }; use crate::rule_tree::CascadeLevel; +use crate::selector_parser::PseudoElement; use crate::shared_lock::{L...
6
286
55
3ec98a8daf6156a99d7c90e1c76864497c406217
Martin Robinson
2020-06-18T18:14:02
Bug 1646811 - servo: Add DocumentAnimationSet and AnimationSetKey. This will be used in order to hold animations for pseudo elements in the DocumentAnimationSet. Also no longer store the OpaqueNode in the animation and transition data structures. This is already part of the DocumentAnimationSet key. Depends on D80241...
diff --git a/style/animation.rs b/style/animation.rs index 75efde37b..ecb921a5e 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -19,6 +19,7 @@ use crate::properties::{ PropertyDeclarationId, }; use crate::rule_tree::CascadeLevel; +use crate::shared_lock::{Locked, SharedRwLock}; use crate::style_reso...
3
83
27
fe275c36878b60d0832962b1cd4dd869455fe75f
Matthias Deiml
2020-06-18T18:13:59
Bug 1646811 - servo: Implement visibility for layout_2020. Depends on D80240 Differential Revision: https://phabricator.services.mozilla.com/D80241
diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs index fe2cc5ed0..37d86d626 100644 --- a/style/properties/longhands/inherited_box.mako.rs +++ b/style/properties/longhands/inherited_box.mako.rs @@ -9,10 +9,8 @@ // TODO: collapse. Well, do tables first. ${...
1
1
3
33a1ea4b256a897fd3904f741e4fcb1870ea5832
Utsav Oza
2020-06-18T18:13:56
Bug 1646811 - servo: Derive Serialize and Deserialize traits for font styles. Depends on D80239 Differential Revision: https://phabricator.services.mozilla.com/D80240
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index 761de9d17..e0e0fe4cb 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -2602,7 +2602,8 @@ pub mod style_structs { % for style_struct in data.active_style_structs(): % ...
3
6
7
0d849c42998902ad9f8c8dddfd878e8c9f93641b
Utsav Oza
2020-06-18T18:12:56
Bug 1646811 - servo: Enable textAlign, textBaseline and direction attributes for canvas. Depends on D80238 Differential Revision: https://phabricator.services.mozilla.com/D80239
diff --git a/style/lib.rs b/style/lib.rs index 6116c1266..ae048826a 100644 --- a/style/lib.rs +++ b/style/lib.rs @@ -40,6 +40,8 @@ extern crate debug_unreachable; extern crate derive_more; extern crate euclid; extern crate fallible; +#[cfg(feature = "servo")] +extern crate font_kit; extern crate fxhash; #[cfg(feat...
2
53
0
faa061a5d1809de702b485cd7fc91ad2fe8c27a3
Utsav Oza
2020-06-18T18:12:46
Bug 1646811 - servo: Implement CanvasRenderingContext2D.font property. Depends on D80237 Differential Revision: https://phabricator.services.mozilla.com/D80238
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index 018ece507..761de9d17 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -2602,7 +2602,7 @@ pub mod style_structs { % for style_struct in data.active_style_structs(): % ...
3
19
3
a7dab2b98074d51617e55f23b7084856b665e9f8
Martin Robinson
2020-06-18T18:12:34
Bug 1646811 - servo: animations: Don't always re-resolve the node style. When animations and transitions change don't always re-resolve node style, just replace the animation and transition rules and re-cascade. Depends on D80236 Differential Revision: https://phabricator.services.mozilla.com/D80237
diff --git a/style/animation.rs b/style/animation.rs index b107aaaf2..75efde37b 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -882,10 +882,9 @@ impl ElementAnimationSet { } fn cancel_active_transitions(&mut self) { - self.dirty = !self.transitions.is_empty(); - for transition i...
3
108
45
d89936dd8f25c67e89dc2ec9d2846e270802f44d
Simon Sapin
2020-06-18T18:12:23
Bug 1646811 - servo: Enable parsing of `flex-*` properties for layout-2020. Depends on D80235 Differential Revision: https://phabricator.services.mozilla.com/D80236
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index 239c2edd5..25354ab19 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -72,7 +72,8 @@ ${helpers.predefined_type( ${helpers.single_keyword( "flex-...
2
14
7
b6f99705713af1f76c42316f285c93afc279eb6a
Martin Robinson
2020-06-18T18:12:14
Bug 1646811 - servo: Include animations and transitions in the cascade. Instead of applying animations and transitions to styled elements, include them in the cascade. This allows them to interact properly with things like font-size and !important rules. Depends on D80234 Differential Revision: https://phabricator.s...
diff --git a/style/animation.rs b/style/animation.rs index d7601a8ed..b107aaaf2 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -10,7 +10,7 @@ use crate::bezier::Bezier; use crate::context::{CascadeInputs, SharedStyleContext}; use crate::dom::{OpaqueNode, TDocument, TElement, TNode}; -use crate::properti...
8
199
114
dfb8c6c2684395df819a261ec095450c99fa1ab6
Martin Robinson
2020-06-18T18:12:07
Bug 1646811 - servo: Better computation of animation keyframes. This begins to address #26625 by properly applying CSS variables during keyframe computation and no longer using `apply_declarations`. Instead, walk the declarations, combining them into IntermediateComputedKeyframe, maintaining declarations that modify C...
diff --git a/style/animation.rs b/style/animation.rs index c54253ed9..d7601a8ed 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -8,20 +8,21 @@ // compile it out so that people remember it exists. use crate::bezier::Bezier; -use crate::context::SharedStyleContext; -use crate::dom::{OpaqueNode, TElement, ...
5
256
124
9cd18af39febc92af6ed85ec5b5f6ee7ff97a975
Martin Robinson
2020-06-18T18:11:57
Bug 1646811 - servo: Cache animation computed values when animations change. Instead of recalculating the animation style every tick of an animation, cache the computed values when animations change. In addition to being more efficient, this will allow us to return animation rules as property declarations because we d...
diff --git a/style/animation.rs b/style/animation.rs index a0d684f1a..c54253ed9 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -17,7 +17,7 @@ use crate::properties::longhands::animation_fill_mode::computed_value::single_va use crate::properties::longhands::animation_play_state::computed_value::single_valu...
5
217
164
5ae58852deca7e436bf3a5177472a5eb4d760220
Simon Sapin
2020-06-18T18:11:47
Bug 1646811 - Enable `order` in layout-2020. Depends on D80231 Differential Revision: https://phabricator.services.mozilla.com/D80232
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index 3af5f8656..239c2edd5 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -266,7 +266,8 @@ ${helpers.predefined_type( "order", "Integer", "...
1
2
1
9101e81d846e1666e49bccb9fdc477730bb56440
Simon Sapin
2020-06-18T18:11:39
Bug 1646811 - servo: Gate layout 2020 flex implementation behind a pref. Differential Revision: https://phabricator.services.mozilla.com/D80231
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index f4fb64172..676262500 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -34,6 +34,17 @@ fn moz_box_display_values_enabled(context: &ParserContext) -> bool { static_prefs::pref!("layout.css.xul-box-di...
1
18
17
c3e3bec0396e380f198a058a833f5b67899ce678
Cosmin Sabou
2020-06-18T15:26:51
Backed out changeset 299e19193e11 (bug 1646224) for causing font related failures. CLOSED TREE
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index 663acae7b..27cb666fc 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -11,7 +11,6 @@ use crate::gecko_bindings::structs; use crate::media_queries::MediaType; use crate::properties::ComputedValues; use crate:...
12
100
99
c97b424878f5ac5f3ea02ca2f8f827f7cb465d73
Emilio Cobos Álvarez
2020-06-18T13:55:03
Bug 1646224 - Use mozilla::Length rather than nscoord to store font sizes. r=heycam,jfkthame This avoids arbitrary precision loss when computing REM units and so on, which is particularly important if we ever change the base of our app units (but useful regardless). Differential Revision: https://phabricator.services...
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index 27cb666fc..663acae7b 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -11,6 +11,7 @@ use crate::gecko_bindings::structs; use crate::media_queries::MediaType; use crate::properties::ComputedValues; use crate:...
12
99
100
58d1bf97ce58ed2a4843931536ee40a628c9dd9c
Emilio Cobos Álvarez
2020-06-17T23:40:30
Bug 1646546 - Port the style crate to rust 2018. r=boris Differential Revision: https://phabricator.services.mozilla.com/D80101
diff --git a/style/Cargo.toml b/style/Cargo.toml index 96ed4fbe4..54ddd5258 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -6,6 +6,7 @@ license = "MPL-2.0" publish = false build = "build.rs" +edition = "2018" # https://github.com/rust-lang/cargo/issues/3544 links = "servo_style_crate" diff --git a/styl...
9
18
14
9615d6d6f08421f84f6de3cd9fc20c02a34dbd12
Emilio Cobos Álvarez
2020-06-17T22:27:45
Bug 1646546 - Fix some manual occurrences of try(). r=boris Depends on D80099 Differential Revision: https://phabricator.services.mozilla.com/D80100
diff --git a/style/values/specified/effects.rs b/style/values/specified/effects.rs index 87578b127..fd92e6ee9 100644 --- a/style/values/specified/effects.rs +++ b/style/values/specified/effects.rs @@ -149,18 +149,17 @@ impl Parse for BoxShadow { } } if lengths.is_none() { - ...
1
9
10
4cb7e9d81d058f35d20d16656c24080f798d357a
Philipp Zech
2020-06-17T11:08:44
Bug 1636205 - Remove StyleFontSize enum from nsStyleConsts.h. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D77511
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index ab60099b3..595534bd9 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -854,12 +854,13 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> { let new_size = { let font = self.context.builder.get_font(); - ...
6
58
80
30303230ab3e7576767a6568efbd996dee54bfe3
Emilio Cobos Álvarez
2020-06-14T23:26:04
Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo It was removed from the spec. Differential Revision: https://phabricator.services.mozilla.com/D78834
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 4d60dc2ff..a02ddcfd6 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -278,6 +278,10 @@ enum PrefersReducedMotion { Reduce, } +fn color_scheme_no_preference_enabled(_: &crate::parser::ParserContext)...
1
5
0
8e6a7590ced60f1350dce018ef71531a54de1bfc
Emilio Cobos Álvarez
2020-06-14T09:45:06
Backed out 2 changesets (bug 477157) for border rendering regressions. Backed out changeset 04543b8ded50 (bug 477157) Backed out changeset 5df17ecbcaa1 (bug 477157) MANUAL PUSH: backout
diff --git a/style/gecko/values.rs b/style/gecko/values.rs index 530d5e525..a755556e8 100644 --- a/style/gecko/values.rs +++ b/style/gecko/values.rs @@ -34,14 +34,18 @@ pub fn convert_nscolor_to_rgba(color: u32) -> RGBA { ) } -/// Ensures that `width`, if non-zero, is at least one device pixel. These -/// width...
2
10
5
63392d299dc1adfdd1c3d7bbed8fe901873e7cec
Emilio Cobos Álvarez
2020-06-11T11:27:58
Bug 1640623 - Use an enum class for LookAndFeel::FontID. r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D76696
diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs index 98ed7fb7f..a0d851bca 100644 --- a/style/properties/longhands/font.mako.rs +++ b/style/properties/longhands/font.mako.rs @@ -368,7 +368,7 @@ ${helpers.predefined_type( let id = match *self { ...
1
1
1
fae33cc0cb82aa381f8b261e03173f832e4b5795
neil
2020-06-10T13:16:34
Bug 1641324 Remove the layout.css.scrollbar-width.enabled and layout.css.scrollbar-color.enabled prefs r=emilio Differential Revision: https://phabricator.services.mozilla.com/D78400
diff --git a/style/properties/longhands/inherited_ui.mako.rs b/style/properties/longhands/inherited_ui.mako.rs index 25b531909..bbe342096 100644 --- a/style/properties/longhands/inherited_ui.mako.rs +++ b/style/properties/longhands/inherited_ui.mako.rs @@ -77,13 +77,7 @@ ${helpers.predefined_type( "Default::defaul...
2
0
8
4895c2de875f7eb19719d743a5ec89146b292b35
Emilio Cobos Álvarez
2020-06-10T10:44:32
Bug 477157 - Ceil border and outline widths to 1 dev px at computed value time, but don't floor others to dev pixels until paint time. r=mats,dbaron This seems to match what other browsers do, and seems saner layout-wise, at least. I only annotated outline-width-interpolation.html because it's already fixed upstream ...
diff --git a/style/gecko/values.rs b/style/gecko/values.rs index a755556e8..530d5e525 100644 --- a/style/gecko/values.rs +++ b/style/gecko/values.rs @@ -34,18 +34,14 @@ pub fn convert_nscolor_to_rgba(color: u32) -> RGBA { ) } -/// Round `width` down to the nearest device pixel, but any non-zero value that -/// ...
2
5
10
29d66d3aa5d4dc4aef348dc7aa0e468ca4d7f76e
Razvan Maries
2020-06-09T15:24:48
Backed out changeset bca9f7459a16 (bug 1643656) for reftests perma failures. CLOSED TREE
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index a02ddcfd6..4d60dc2ff 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -278,10 +278,6 @@ enum PrefersReducedMotion { Reduce, } -fn color_scheme_no_preference_enabled(_: &crate::parser::ParserContext)...
1
0
5