commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
10f117c49aab8c2bdc8b2bcd4e1c87531ad2f594 | Emilio Cobos Álvarez | 2018-06-04T11:25:41 | Bug 1449243: Remove invalid assertion. r=me
We can look at stale styles while trying to figure out if we need any
invalidation, and that's ok.
MozReview-Commit-ID: 4mBIFNm9qJv | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 9ff92a19e..a666d571e 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -181,7 +181,6 @@ impl<'lr> TShadowRoot for GeckoShadowRoot<'lr> {
let author_styles = AuthorStyles::<GeckoStyleSheet>::from_ffi(author_styles);
- ... | 1 | 0 | 1 |
f0e89702563aa57f16d5a60a09b5badeab50bff4 | Emilio Cobos Álvarez | 2018-06-01T14:13:15 | Bug 1466008: followup: set the rule type in the custom properties code, since we use it. r=me on a CLOSED TREE
Though I think it may be slightly fishy if used in, e.g., a @keyframes block.
For our purposes right now it doesn't make a difference, I think.
MozReview-Commit-ID: A7VCTOqaIuB | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 9ce7d3dfc..b7bc96973 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1422,10 +1422,12 @@ impl UnparsedValue {
.and_then(|css| {
// As of this writing, only th... | 1 | 3 | 1 |
8a2939738fcd4b23e04b0520d0f54284816c62d5 | Emilio Cobos Álvarez | 2018-06-01T12:00:57 | Bug 1466095: Make PropertyId::parse less of a footgun. r=xidorn
MozReview-Commit-ID: 2BmtSDPmHj9 | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 0263de83f..a66058caf 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -1158,7 +1158,7 @@ impl<'a, 'b, 'i> DeclarationParser<'i> for PropertyDeclarationParser<'a, 'b> {
... | 5 | 44 | 26 |
87a986c92e0bee0f0a997974775f1488fe65b4a7 | Emilio Cobos Álvarez | 2018-06-01T09:35:57 | Bug 1466008: Make will-change honor prefs properly, and clean it up while at it. r=xidorn
Will add a test, though in JSConf right now...
MozReview-Commit-ID: JyzwaRgf5Ct | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 741aa7b86..4b9023588 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3515,77 +3515,27 @@ fn static_assert() {
pub fn set_will_change(&mut self, v: longhands::will_change::computed_value::T) {
... | 3 | 103 | 66 |
fb45a96cb2ebb5d12c0e7595a95f4ea7f994cb17 | Gerald Squelart | 2018-05-31T08:22:48 | Bug 1464091 - Ignore case in media feature names inside media query expressions - r=heycam
Media feature names are converted to lower case before being processed, making
them effectively case-insensitive.
Prefixes ("min-", etc.) and values are already treated in a case-insensitive
manner.
MozReview-Commit-ID: JUeeEQE... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 554606bb9..833db60a0 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -23,7 +23,7 @@ use properties::ComputedValues;
use servo_arc::Arc;
use std::fmt::{self, Write};
use std::sync::atomic::{AtomicBool, Atomi... | 1 | 2 | 2 |
6029c764c4ae8f85c630b446c0fbc54b795a41a9 | Yusuf Sermet | 2018-05-30T21:28:53 | Bug 1465250 - Make contain:paint trigger clipping independent of the overflow property. r=mattwoodrow
MozReview-Commit-ID: 2QbfZD1jnWX | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 2bb400f63..8bbc40ca8 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -315,39 +315,6 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
}
}
- #[cfg(feature = "gecko")]
- fn adjust_for_contain(&mut self) {
- u... | 1 | 0 | 34 |
ba94320a71556562ff7d5e242ac03e7105253402 | Nazım Can Altınova | 2018-05-30T16:15:25 | Bug 1464496 - Part 1: Merge ServoDeclarationBlock and DeclarationBlock r=emilio
MozReview-Commit-ID: By9fV70Oq0K | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 562d6458a..9ff92a19e 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1215,16 +1215,9 @@ impl<'le> TElement for GeckoElement<'le> {
unsafe {
let slots = self.extended_slots()?;
- let base_declaratio... | 1 | 1 | 8 |
e03befb10007084289c01d4210d4982c692b9cf4 | Dan Glastonbury | 2018-05-23T05:23:26 | Bug 1465307 - P1: Extend StyleComplexColor to support additive blending. r=hiro,xidorn
Refactored StyleComplexColor to support "complex" blending between
background (numeric) color and foreground color (currentColor).
Made explicit the distinction between numeric, currentColor and a
complex blend in Gecko and Stylo.
... | diff --git a/style/gecko_bindings/sugar/style_complex_color.rs b/style/gecko_bindings/sugar/style_complex_color.rs
index 696eb6968..3a37f9cb0 100644
--- a/style/gecko_bindings/sugar/style_complex_color.rs
+++ b/style/gecko_bindings/sugar/style_complex_color.rs
@@ -5,28 +5,21 @@
//! Rust helpers to interact with Gecko'... | 5 | 248 | 204 |
4863ff3242387fea412e44eee79cdc9c95a6092a | Gurzau Raul | 2018-06-07T03:40:03 | Backed out changeset 9bdd12949711 (bug 1465250) for multiple failures on /css-contain/contain-paint-002.html on a CLOSED TREE | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 8bbc40ca8..2bb400f63 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -315,6 +315,39 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
}
}
+ #[cfg(feature = "gecko")]
+ fn adjust_for_contain(&mut self) {
+ u... | 1 | 34 | 0 |
501f164bc3ee46504512444010f7d618e9ba401e | Xidorn Quan | 2018-05-11T00:12:17 | Bug 1463917 part 1 - Add scrollcorner to -moz-appearance so that widget can render it. r=heycam
MozReview-Commit-ID: 1Za22ifONfG | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index aea51fed7..ce04a0a66 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -606,8 +606,9 @@ ${helpers.single_keyword("-moz-appearance",
scalethumb-hor... | 1 | 3 | 2 |
362710ab1bd0e53233a7088c2ffe4a6f710e009b | Dan Glastonbury | 2018-04-27T02:07:20 | Bug 1457353 - P1: Change nscolor to StyleComplexColor. r=xidorn
Change mStopColor, mFloodColor, and mLightingColor in nsStyleSVGReset.
MozReview-Commit-ID: KMRMtHk1jNK | diff --git a/style/properties/longhand/svg.mako.rs b/style/properties/longhand/svg.mako.rs
index 2ec7bcc59..6d7bf803f 100644
--- a/style/properties/longhand/svg.mako.rs
+++ b/style/properties/longhand/svg.mako.rs
@@ -21,8 +21,8 @@ ${helpers.single_keyword("vector-effect", "none non-scaling-stroke",
${helpers.predefi... | 1 | 8 | 8 |
24d25680a45518c96de009a62f63e4ccf0e0c335 | Morgan Rae Reschenberg | 2018-05-30T14:49:31 | Bug 1463589 - Add contain:size and contain:content parsing functionality. r=emilio
MozReview-Commit-ID: 4fOqln3oOpC | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index baa1ed015..741aa7b86 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3626,10 +3626,13 @@ fn static_assert() {
pub fn set_contain(&mut self, v: longhands::contain::computed_value::T) {
us... | 2 | 50 | 10 |
aa27da1f1dcaed919b82a3bd8761d643f9511c22 | Emilio Cobos Álvarez | 2018-05-10T16:48:08 | Bug 1460382: Make element-backed pseudos inherit from NAC subtree roots and other NAC inherit from their parents. r=heycam
Currently, NAC always inherits from the closest non-NAC ancestor element,
regardless of whether it is for an element-backed pseudo or not.
This patch changes the inheritance so that for element-b... | diff --git a/style/dom.rs b/style/dom.rs
index 0e5da1542..42f6e9ba0 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -466,12 +466,6 @@ pub trait TElement:
&[]
}
- /// For a given NAC element, return the closest non-NAC ancestor, which is
- /// guaranteed to exist.
- fn closest_non_native_anonymo... | 6 | 53 | 49 |
dcb9edf5e7eb79751980d7949c2d9030baaa17b7 | Emilio Cobos Álvarez | 2018-05-29T13:09:00 | Bug 1465066: Cleanup transform animation. r=hiro
MozReview-Commit-ID: D9rq8CZIgf5 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 9ada8d523..f45b7ffe9 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2501,107 +2501,83 @@ impl Animate for Compu... | 1 | 50 | 74 |
e6dc33ce7f875d611215a1f03ec22fe9efd2f678 | Emilio Cobos Álvarez | 2018-05-29T11:03:54 | Bug 1464865: Some trivial cleanup. r=xidorn
MozReview-Commit-ID: 8ClaBR9ooGb | diff --git a/style/stylesheets/rule_parser.rs b/style/stylesheets/rule_parser.rs
index 4964db5aa..a446068fa 100644
--- a/style/stylesheets/rule_parser.rs
+++ b/style/stylesheets/rule_parser.rs
@@ -268,8 +268,8 @@ impl<'a, 'i, R: ParseErrorReporter> AtRuleParser<'i> for TopLevelRuleParser<'a,
self.state... | 1 | 30 | 34 |
cec3461cc25b79916e3b5b7678ebf5f55aeaa13a | Emilio Cobos Álvarez | 2018-05-28T21:56:20 | Bug 1464865: Don't let @namespace rules that aren't going to be inserted affect the namespace map. r=xidorn
MozReview-Commit-ID: 9bjlEBExqsr | diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs
index b3360fa41..2d6539c08 100644
--- a/style/stylesheets/mod.rs
+++ b/style/stylesheets/mod.rs
@@ -46,7 +46,7 @@ pub use self::media_rule::MediaRule;
pub use self::namespace_rule::NamespaceRule;
pub use self::origin::{Origin, OriginSet, OriginSetIterat... | 4 | 94 | 75 |
5e1a69860a0f68a6a9c5da5d4278fe5e443a771f | shindli | 2018-05-29T10:39:43 | Backed out changeset ad877938d752 (bug 1464865) for wpt3 failures in /css/cssom/insertRule-import-no-index.htm on a CLOSED TREE | diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs
index 2d6539c08..b3360fa41 100644
--- a/style/stylesheets/mod.rs
+++ b/style/stylesheets/mod.rs
@@ -46,7 +46,7 @@ pub use self::media_rule::MediaRule;
pub use self::namespace_rule::NamespaceRule;
pub use self::origin::{Origin, OriginSet, OriginSetIterat... | 4 | 78 | 87 |
6b7098913579023011cb1f421a7295e97742ab87 | Emilio Cobos Álvarez | 2018-05-28T21:56:20 | Bug 1464865: Don't let @namespace rules that aren't going to be inserted affect the namespace map. r=xidorn
MozReview-Commit-ID: 9bjlEBExqsr | diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs
index b3360fa41..2d6539c08 100644
--- a/style/stylesheets/mod.rs
+++ b/style/stylesheets/mod.rs
@@ -46,7 +46,7 @@ pub use self::media_rule::MediaRule;
pub use self::namespace_rule::NamespaceRule;
pub use self::origin::{Origin, OriginSet, OriginSetIterat... | 4 | 87 | 78 |
14e9913895fbce3f551186da39af813cd82b6b31 | Yusuf Sermet | 2018-05-29T06:54:01 | Bug 1463599 - Create a stacking context for contain:paint. r=mattwoodrow
MozReview-Commit-ID: Ln72MOlHXwi | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 026a3ca79..f8389a19a 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -593,7 +593,7 @@ ${helpers.predefined_type("contain",
"specified::Contain::em... | 1 | 1 | 1 |
10458dc3524995134732f82ed28462bb7570f21a | Hiroyuki Ikezoe | 2018-05-29T03:33:16 | Bug 1464647 - Implement the smarter interporation for transform. r=birtles,emilio
Corresponding to this spec change;
https://github.com/w3c/csswg-drafts/commit/32812668df0a086fc2bcc6e51de6ea5f186b82e6
The expected value in test_transitions_per_property.html can be calculated;
'start' + ('end' - 'start') * 0.25
Mo... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 1c282e46b..9ada8d523 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2564,6 +2564,31 @@ impl Animate for Compute... | 1 | 25 | 0 |
9158fce235db305b4b71de108846ba6bfebbb297 | Emilio Cobos Álvarez | 2018-05-28T17:32:06 | No bug - trivial TopLevelRuleParser construction cleanup. r=me
MozReview-Commit-ID: 5CdOdQPZzyb | diff --git a/style/stylesheets/stylesheet.rs b/style/stylesheets/stylesheet.rs
index 08c2cb05f..5f10c1dd5 100644
--- a/style/stylesheets/stylesheet.rs
+++ b/style/stylesheets/stylesheet.rs
@@ -363,13 +363,13 @@ impl Stylesheet {
let rule_parser = TopLevelRuleParser {
stylesheet_origin: origin,
-... | 1 | 4 | 4 |
9142c72fd0850131f9a5d34eabdcdadbc186ddb8 | Simon Sapin | 2018-05-03T10:14:41 | No bug - Import style changes for Servo PR #20703. r=me
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
MozReview-Commit-ID: 7Crl7d1Vs1N | diff --git a/style/servo/restyle_damage.rs b/style/servo/restyle_damage.rs
index da682119e..5cde20c96 100644
--- a/style/servo/restyle_damage.rs
+++ b/style/servo/restyle_damage.rs
@@ -191,7 +191,8 @@ fn compute_damage(old: &ComputedValues, new: &ComputedValues) -> ServoRestyleDam
// This should check every CSS pr... | 1 | 2 | 1 |
091c301c83540f3bea596ac7456e2ce5b26630f9 | Emilio Cobos Álvarez | 2018-05-28T13:58:18 | No bug - Appease Servo's tidy lint. r=me
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
MozReview-Commit-ID: CoejeixDmI6 | diff --git a/style/values/animated/mod.rs b/style/values/animated/mod.rs
index 2bb80df0e..53d3719b0 100644
--- a/style/values/animated/mod.rs
+++ b/style/values/animated/mod.rs
@@ -11,11 +11,11 @@
use app_units::Au;
use euclid::{Point2D, Size2D};
use smallvec::SmallVec;
-use values::computed::length::CalcLengthOrPer... | 1 | 1 | 1 |
8ddff8f531a9eb7a0c7d50f3e19a623d5a87a8a8 | Emilio Cobos Álvarez | 2018-05-25T14:56:41 | Bug 1464428: Optimize QuerySelector in shadow trees. r=xidorn
Pretty much the same setup we have for document.
We have the awkwardness of having to check containing shadow manually for
ShadowRoot because it's not available in TNode (and making it available added a
bit more complexity that wasn't worth it IMO).
MozRe... | diff --git a/style/dom.rs b/style/dom.rs
index bee4d8832..0e5da1542 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -135,14 +135,17 @@ pub trait TDocument: Sized + Copy + Clone {
fn quirks_mode(&self) -> QuirksMode;
/// Get a list of elements with a given ID in this document, sorted by
- /// document pos... | 3 | 103 | 42 |
c3398db75d4e834cb527b66dcbb2501b0fbae861 | arthur.iakab | 2018-05-28T10:17:34 | Backed out changeset 8fb0fa2dca36 (bug 1464428) for Reftest crashes on a CLOSED TREE | diff --git a/style/dom.rs b/style/dom.rs
index 0e5da1542..bee4d8832 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -135,17 +135,14 @@ pub trait TDocument: Sized + Copy + Clone {
fn quirks_mode(&self) -> QuirksMode;
/// Get a list of elements with a given ID in this document, sorted by
- /// tree positio... | 3 | 42 | 100 |
7621d7a3f54b3cd57133bc66aaddc7b588582c6d | Emilio Cobos Álvarez | 2018-05-26T21:50:11 | Bug 1459403: The fix: scale and translate appropriately. r=hiro
Loops are hard. This hasn't been the funniest Saturday evening.
MozReview-Commit-ID: I8rfuIRIsrY | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 673ba86f8..1c282e46b 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2154,7 +2154,7 @@ impl From<MatrixDecompose... | 1 | 4 | 4 |
bed405c3faa270dbd38a9808d0c82a75b3781975 | Emilio Cobos Álvarez | 2018-05-26T21:48:55 | Bug 1459403: Move skew and rotation application to their own scope for clarity. r=hiro
The skew resetting of temp I think fixes a bug in presence of skew in every
direction, but again haven't double-checked.
MozReview-Commit-ID: Bn93CoaG8Bu | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 107167196..673ba86f8 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2161,43 +2161,47 @@ impl From<MatrixDecompo... | 1 | 37 | 33 |
fa886f9085288be9528bb896f87eb90ef07dba0c | Emilio Cobos Álvarez | 2018-05-26T21:46:14 | Bug 1459403: Cleanup multiply(). r=hiro
We assign all the members, the result matrix doesn't really need to be any clone
of a.
MozReview-Commit-ID: 3NkhvyfqQL | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 3178a14ad..107167196 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2213,16 +2213,17 @@ impl From<MatrixDecompo... | 1 | 9 | 8 |
ebad26ff7d1fcbf453b73f4d8862d8dff373f902 | Emilio Cobos Álvarez | 2018-05-26T21:44:50 | Bug 1459403: Add a FIXME comment which I think reveals a bug but I haven't confirmed it. r=hiro
MozReview-Commit-ID: DgCfqA5TNzP | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index b20889f0d..3178a14ad 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2478,6 +2478,8 @@ impl Animate for Computed... | 1 | 2 | 0 |
396200a9bd6e34c52a21c598c4e44c4b0ffb3b3f | Emilio Cobos Álvarez | 2018-05-26T21:42:07 | Bug 1459403: Cleanup and add references to decompose_3d_matrix. r=hiro
Same, no functional change, but I basically rewrote this two times so...
MozReview-Commit-ID: FXOnJDPyPu5 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 8001ecf3f..b20889f0d 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1908,7 +1908,8 @@ impl ComputeSquaredDistan... | 1 | 49 | 43 |
7d3de1795b97cebeb34fc99254a21e439aac9b7e | Emilio Cobos Álvarez | 2018-05-26T21:40:45 | Bug 1459403: Cleanup and add references to Quaternion::animate. r=hiro
No functional change, but I did this while searching for the bug.
MozReview-Commit-ID: KsJxFoYaOq1 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 42c531bac..8001ecf3f 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1820,12 +1820,16 @@ impl Animate for Quater... | 1 | 35 | 24 |
006f5ed2db33df67d0804fc928bd5078ecf7b598 | Emilio Cobos Álvarez | 2018-05-26T21:35:52 | Bug 1459403: Trivial cleanup. r=hiro
MozReview-Commit-ID: K7zVYGiYAn6 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 3bdd1264a..42c531bac 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1503,10 +1503,10 @@ impl Animate for Matrix... | 1 | 4 | 4 |
6878c87475263e6ba3bf7734b8809a0af8155fc2 | Emilio Cobos Álvarez | 2018-05-26T14:23:36 | Bug 1464615: Reuse computed rotate animation. r=hiro
I have the feeling this fixes a bug, but...
MozReview-Commit-ID: Aj478qCbMV9 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 4a88e7a52..3bdd1264a 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1300,18 +1300,10 @@ impl Animate for Comput... | 1 | 4 | 41 |
e1d30e7dc437c73ce29f0772a4deb5c03b069faf | Emilio Cobos Álvarez | 2018-05-25T18:11:37 | Bug 1464615: Match rotate ops. r=hiro
Per bug 1322189 we really should. I've copied the setup we have already for
translate / scale, but we should really clean this up a bit more I'd think.
In any case, probably skew should be matched as well...
MozReview-Commit-ID: Jky5k8HVfuH | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index d74759921..4a88e7a52 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1289,7 +1289,11 @@ impl Animate for Compute... | 3 | 46 | 1 |
f8771b7eec9a7dc849032e185791e9ff1c48ac9a | Emilio Cobos Álvarez | 2018-05-24T15:49:24 | Bug 1464060: Make the general setup for computed style bits nicer. r=xidorn
This patch:
* Makes StyleStructID an enum class, and moves it to the mozilla namespaces.
* Introduces StyleStructConstants with some constants scattered through the
codebase.
* Makes the computed style bits an enum class, and splits m... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 4d1440531..baa1ed015 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -41,7 +41,6 @@ use gecko_bindings::structs;
use gecko_bindings::structs::nsCSSPropertyID;
use gecko_bindings::structs::mozilla::CS... | 1 | 3 | 5 |
46934a59b02b589ef1f4e4b7264312508f22836b | Emilio Cobos Álvarez | 2018-05-24T13:03:17 | Bug 1464060: Remove a bunch of unused style bits. r=xidorn
MozReview-Commit-ID: FLACqfSHfSO | diff --git a/layout/construct.rs b/layout/construct.rs
index 291e8941e..dcbe79e3e 100644
--- a/layout/construct.rs
+++ b/layout/construct.rs
@@ -1533,8 +1533,11 @@ impl<'a, ConcreteThreadSafeLayoutNode> PostorderNodeMutTraversal<ConcreteThreadS
let style = node.style(self.style_context());
- // Bail... | 4 | 5 | 20 |
a0b86d76ee5da339ead91984b3a19e1148fdaebb | Emilio Cobos Álvarez | 2018-05-25T14:56:41 | Bug 1464428: Optimize QuerySelector in shadow trees. r=xidorn
Pretty much the same setup we have for document.
We have the awkwardness of having to check containing shadow manually for
ShadowRoot because it's not available in TNode (and making it available added a
bit more complexity that wasn't worth it IMO).
MozRe... | diff --git a/style/dom.rs b/style/dom.rs
index bee4d8832..0e5da1542 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -135,14 +135,17 @@ pub trait TDocument: Sized + Copy + Clone {
fn quirks_mode(&self) -> QuirksMode;
/// Get a list of elements with a given ID in this document, sorted by
- /// document pos... | 3 | 100 | 42 |
c5c8be0e840e07069f5bb395af6db9ce975d602a | Emilio Cobos Álvarez | 2018-05-26T14:22:52 | Bug 1464595: Cleanup single transform functions that can't really error. r=hiro
Also call them "resolve" since it's the general term for computing something
more specific than what you have.
Though I don't feel strongly about that, feel free to push back.
MozReview-Commit-ID: KtqjzlppZLp | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 057360c94..d74759921 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2376,16 +2376,15 @@ impl Matrix3D {
/// ... | 1 | 40 | 34 |
e37a255ed0087d151d7a14744a82048f57e4ff73 | Emilio Cobos Álvarez | 2018-05-25T12:12:44 | No bug - Use a static atom instead of a dynamic one. r=me
MozReview-Commit-ID: CUTwfsCrovQ | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 77a9b09d7..8db4bd7e9 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -474,7 +474,7 @@ impl SingleFontFamily {
FontFamilyType::eFamily_cursive => SingleFontFamily::Generic(atom!("cursive")),
... | 1 | 1 | 1 |
2b8bf37479d210ce164fabd4ecb6565e8abf91ea | Emilio Cobos Álvarez | 2018-05-24T22:51:43 | No bug - Remove dead and unsafe code. r=me
MozReview-Commit-ID: 9seuLNCJAqz | diff --git a/style/gecko_bindings/sugar/ns_com_ptr.rs b/style/gecko_bindings/sugar/ns_com_ptr.rs
index f50eda02c..488dc8626 100644
--- a/style/gecko_bindings/sugar/ns_com_ptr.rs
+++ b/style/gecko_bindings/sugar/ns_com_ptr.rs
@@ -13,13 +13,6 @@ impl<T> nsCOMPtr<T> {
pub fn raw<U>(&self) -> *mut T {
self.mR... | 1 | 0 | 14 |
825db9b3d259ac207644d41320331c9a3523f993 | Xidorn Quan | 2018-05-24T04:12:55 | Bug 1463978 - Don't generate catch-all branch if a image layer keyword value is exhaustive. r=emilio
MozReview-Commit-ID: H8T9Low6kqY | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 1fc486975..4d1440531 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3805,7 +3805,9 @@ fn static_assert() {
% endif
=> Keyword::${to_camel_case(va... | 3 | 48 | 33 |
5f1b54428a2719cc822607a35b44713b19d9c586 | Xidorn Quan | 2018-05-23T03:58:38 | Bug 1463603 - Ensure modified_reset is set when {mutate,take}_reset_struct is called. r=heycam
MozReview-Commit-ID: 8mqVb7kl0ok | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index f28c04e79..ba38d9532 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -3199,6 +3199,7 @@ impl<'a> StyleBuilder<'a> {
% endif
% endif
% endfor
+ <% del property %>
... | 1 | 4 | 2 |
38a93176b60b2fc53346127758296476a7102d64 | Emilio Cobos Álvarez | 2018-05-22T08:24:03 | Bug 1462829: followup: Add a comment regarding why a type is generic. rs=xidorn
DONTBUILD, comment only.
MozReview-Commit-ID: 5DE8W2n1NP | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 03b588ad6..209c06df0 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -119,6 +119,10 @@
use values::computed::ComputedVecIter;
/// The generic type defining the value... | 1 | 4 | 0 |
da627a1504aa610401ddaad61a299a6f01c63dfc | Olli Pettay | 2018-05-21T21:11:11 | Bug 1463116 - Make mBindingParent strong, r=bz | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index c00a41049..7a565ec46 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -665,7 +665,7 @@ impl<'le> GeckoElement<'le> {
fn non_xul_xbl_binding_parent_raw_content(&self) -> *mut nsIContent {
debug_assert!(!self.is_xul_elemen... | 1 | 1 | 1 |
3a17c117bf1a6ee55039dd5aed3e0b12ea4e0713 | shindli | 2018-05-21T20:55:58 | Backed out changeset 603804d62ce8 (bug 1463116) for force-cargo-library-build bustage on a CLOSED TREE | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 9ff19049e..c00a41049 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -665,7 +665,7 @@ impl<'le> GeckoElement<'le> {
fn non_xul_xbl_binding_parent_raw_content(&self) -> *mut nsIContent {
debug_assert!(!self.is_xul_elemen... | 1 | 1 | 1 |
881e71f2be9f5f0acf2dcc647195ddeafc58fbe9 | Olli Pettay | 2018-05-21T20:02:07 | Bug 1463116 - Make mBindingParent strong, r=bz | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index c00a41049..9ff19049e 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -665,7 +665,7 @@ impl<'le> GeckoElement<'le> {
fn non_xul_xbl_binding_parent_raw_content(&self) -> *mut nsIContent {
debug_assert!(!self.is_xul_elemen... | 1 | 1 | 1 |
1bde5e3d4abdca57dfc1b0b35a9bcbbd206845c4 | Emilio Cobos Álvarez | 2018-05-21T09:56:09 | No bug - Import style changes from Servo PR #20843. r=me
MozReview-Commit-ID: FpQXZUBdgNN | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index d48644016..77a9b09d7 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -21,7 +21,7 @@ use std::slice;
use style_traits::{CssWriter, ParseError, ToCss};
use values::CSSFloat;
use values::animated::{ToAnima... | 1 | 3 | 3 |
ee0ca3ace60b086400a5fd20838b3fd4bf6a48a2 | Emilio Cobos Álvarez | 2018-05-20T18:09:22 | No bug - Import style changes from Servo PR #20506. r=me
MozReview-Commit-ID: BELRJUdRUaU | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index b86a59fc6..3d9a8e579 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2607,10 +2607,16 @@ fn static_assert() {
}
pub fn set_font_stretch(&mut self, v: longhands::font_stretch::computed_valu... | 7 | 75 | 21 |
04b73f84d21ed0ab93a437e7a171524abefbd833 | Dorel Luca | 2018-05-20T23:48:20 | Backed out changeset 76a4f60761f9 for breaking Mochitests on multiple platforms on layout/style/test/test_transitions_per_property.html. | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 3d9a8e579..b86a59fc6 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2607,16 +2607,10 @@ fn static_assert() {
}
pub fn set_font_stretch(&mut self, v: longhands::font_stretch::computed_valu... | 7 | 21 | 75 |
c4a3ea3b43ee1d81c44721089e2bc9f9db8773c0 | Mats Palmgren | 2018-05-17T15:30:35 | Bug 1461039 - Inlinify display:list-item to display:inline for now, until we support 'display:inline list-item' properly. r=xidorn | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index f56d6afd4..d716e9e67 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -212,6 +212,8 @@ impl Display {
Display::Table => Display::InlineTable,
Display::Flex => Display::InlineFlex,
... | 1 | 2 | 0 |
c571065b94b1407f88a65f63d5c5e0e8dd023e3a | Xidorn Quan | 2018-05-16T12:21:57 | Bug 1461858 followup - Use RefPtr::new instead of RefPtr::from_ptr_ref + clone. | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 314ded9cb..bbc2776da 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -679,8 +679,8 @@ pub mod basic_shape {
match other.mType {
StyleShapeSourceType::URL => unsafe {
... | 2 | 6 | 6 |
a3cefeec1cc69187aa00c1b83e496acce693764c | Xidorn Quan | 2018-05-16T04:35:37 | Bug 1461858 part 4 - Rename from_url_value_data to from_url_value and reuse URLValue passed in for ComputedUrl. r=emilio
MozReview-Commit-ID: LJGm3lUS9mD | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index bb0ea1e50..314ded9cb 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -634,6 +634,7 @@ pub mod basic_shape {
use gecko_bindings::structs::{StyleGeometryBox, StyleShapeSource, StyleShapeSourceType};
use gecko_... | 3 | 19 | 25 |
4f16cc859c2516687a10e7db6311e78dd0b1411e | Xidorn Quan | 2018-05-16T04:01:25 | Bug 1461858 part 3 - Have from_image_request reuse ImageValue from image request directly. r=emilio
And also remove ComputedImageUrl::from_url_value_data.
MozReview-Commit-ID: 5zifQlU7tOz | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 76faf2a44..bb0ea1e50 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -426,9 +426,10 @@ impl nsStyleImage {
}
}
- unsafe fn get_image_url(self: &nsStyleImage) -> ComputedImageUrl {
- let url_v... | 2 | 7 | 14 |
4eddb7af8e486d8ff8879874a71ca149d777647c | Xidorn Quan | 2018-05-16T03:39:58 | Bug 1461858 part 2 - Make from_image_request infallible. r=emilio
All callsites already assert, so moving the assertion into the method
should be fine. It is not expected to handle a null image value anyway.
MozReview-Commit-ID: J8CA8m22eSv | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index f127e16a9..102f59dad 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -317,13 +317,10 @@ impl ComputedImageUrl {
}
/// Convert from nsStyleImageReques to ComputedImageUrl.
- pub unsafe fn from_image_request(image_request: &nsStyleImage... | 2 | 5 | 12 |
d667d660941db4b6b9b8d82ece883693a93d1dcb | Xidorn Quan | 2018-05-16T02:19:31 | Bug 1461858 part 1 - Make creating CssUrl infallible. r=emilio
There were a check in CssUrl::parse_from_string for extra data, which
was removed as part of servo/servo#16241, so it never fails now.
CssUrl::from_url_value_data doesn't seem to need Result from the very
beginning. It is unclear why it was made that way.... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 951360b8f..76faf2a44 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -429,7 +429,6 @@ impl nsStyleImage {
unsafe fn get_image_url(self: &nsStyleImage) -> ComputedImageUrl {
let url_value = bindings::Geck... | 6 | 28 | 42 |
cfb87e80d6170b15d1144a21ce9d653ff26afaa6 | Emilio Cobos Álvarez | 2018-05-15T09:37:12 | No bug - Fix Servo build. r=me
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
MozReview-Commit-ID: DpRWVlcU0ki | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index c6de9d2f2..9e5d4c3b7 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -2643,10 +2643,10 @@ impl ComputedValuesInner {
/// ineffective, and would yield an empty `::before` or `::... | 4 | 9 | 6 |
b424907ea63d071df08dd6497b250ce6dc6b1e62 | Emilio Cobos Álvarez | 2018-05-15T09:37:00 | No bug - Make servo-tidy happy. r=me
MozReview-Commit-ID: HDlgkGdvdBg | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index 4961a6e21..d371f0a74 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -15,8 +15,8 @@ use malloc_size_of::{MallocSizeOf, MallocSizeOfOps};
use nsstring::nsCString;
use parser::{Parse, ParserContext};
use servo_arc::{Arc, RawOffsetArc};
-use std::me... | 3 | 6 | 6 |
1a31405c266056acceab03acb9ad3022d85ff9f0 | Emilio Cobos Álvarez | 2018-05-14T13:19:34 | Bug 1442195: Don't crash when finding an unexpected default font type. r=xidorn
For now just return sans-serif, though as the FIXME comment indicates we should
probably just carry around the font-name instead.
MozReview-Commit-ID: CIPbV3R5Ul | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index db8e3e502..3f20b8328 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2326,14 +2326,25 @@ fn static_assert() {
let shared_fontlist = unsafe { fontlist.mFontlist.mBasePtr.to_safe() };
... | 1 | 14 | 3 |
3b35da48e25a694f8046375310ec7fc0cd463694 | Emilio Cobos Álvarez | 2018-05-14T10:29:40 | Bug 1461288: Distinguish between specified and computed URLs. r=xidorn
This is needed to serialize computed URLs correctly from getComputedStyle.
MozReview-Commit-ID: 9wakhqNrszb | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 78d09bac3..951360b8f 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -145,11 +145,11 @@ impl nsStyleImage {
match image {
GenericImage::Gradient(boxed_gradient) => self.set_gradient(*boxed_gradie... | 11 | 375 | 295 |
9969440b5abdc41b9b0acb842ee64cca3124a0e5 | Emilio Cobos Álvarez | 2018-05-14T10:40:31 | Bug 1461296: Ensure all lonhands have a working clone(), and to_css. r=xidorn
This removes some dubious font-family code too.
It ensures that vector longhands have a proper clone implementation
auto-generating it using `collect()`.
MozReview-Commit-ID: FkdnbTkeF6E | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index c751bd843..05c26d1f9 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -10,6 +10,7 @@
%>
<%namespace name="helpers" file="/helpers.mako.rs" />
+use Atom;
use app_units::Au;
use custom_properties::C... | 4 | 64 | 22 |
0828e3fa6294012da3c572cbcbf6687e2bfa6cb4 | Emilio Cobos Álvarez | 2018-05-10T16:11:52 | Bug 1460655: Support x as a resolution unit. r=xidorn
MozReview-Commit-ID: TjU0FLCLMN | diff --git a/style/values/specified/resolution.rs b/style/values/specified/resolution.rs
index 37df94125..52da8eaea 100644
--- a/style/values/specified/resolution.rs
+++ b/style/values/specified/resolution.rs
@@ -17,6 +17,9 @@ pub enum Resolution {
/// Dots per inch.
#[css(dimension)]
Dpi(CSSFloat),
+ ... | 1 | 6 | 0 |
b161b87d58200f91e8b01e15a3fc50150e9517d8 | Emilio Cobos Álvarez | 2018-05-10T16:06:27 | Bug 1460655: Make resolutions more like the rest of the CSS values. r=xidorn
MozReview-Commit-ID: 3Gt8VX1KhjC | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 7d9724cc6..554606bb9 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -7,7 +7,7 @@
use app_units::AU_PER_PX;
use app_units::Au;
use context::QuirksMode;
-use cssparser::{BasicParseErrorKind, Parser, Token, R... | 5 | 128 | 50 |
3800b044af7d1befd57a41a83ed1129c51a9f0e7 | Xidorn Quan | 2018-05-10T00:40:17 | Bug 1460456 part 3 - Add scrollbar-{face,track}-color properties. r=heycam
MozReview-Commit-ID: ImNfHHfzRdM | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 62b531b62..1fc486975 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1436,6 +1436,7 @@ impl Clone for ${style_struct.gecko_struct_name} {
# Types used with predefined_type()-defined properties th... | 2 | 24 | 3 |
bdf8a639ab5ca096ba2a64758ce1a3b0db30f3f0 | Xidorn Quan | 2018-05-09T23:56:10 | Bug 1460456 part 2 - Rename CaretColor to ColorOrAuto for reusing. r=heycam
MozReview-Commit-ID: LD6PlNI60GC | diff --git a/style/gecko_bindings/sugar/style_complex_color.rs b/style/gecko_bindings/sugar/style_complex_color.rs
index 0e06b4c50..696eb6968 100644
--- a/style/gecko_bindings/sugar/style_complex_color.rs
+++ b/style/gecko_bindings/sugar/style_complex_color.rs
@@ -6,8 +6,9 @@
use gecko::values::{convert_nscolor_to_r... | 7 | 19 | 45 |
1a870a6f7668cb5cfe38bb4ba1793b7042b2c19d | Kristen Wright | 2018-05-08T22:05:33 | Bug 1459367 - Convert NS_STYLE_IMAGELAYER_ATTACHMENT_* to enum class. r=manishearth
Converted NS_STYLE_IMAGELAYER_ATTATCHMENT_* vals to enum class, StyleImageLayerAttachment. | diff --git a/style/properties/longhand/background.mako.rs b/style/properties/longhand/background.mako.rs
index d6b9e6e69..a1f1b0394 100644
--- a/style/properties/longhand/background.mako.rs
+++ b/style/properties/longhand/background.mako.rs
@@ -54,7 +54,7 @@ ${helpers.predefined_type(
${helpers.single_keyword("backgro... | 1 | 1 | 1 |
907ea7be86fe6bb6dc29a3412fe2dbfd9ebb4b39 | Emilio Cobos Álvarez | 2018-03-25T15:31:55 | Bug 509958: Unprefix :-moz-selection. r=dbaron,xidorn
Our implementation is totally not what the spec says, but totally what other
UAs do, see https://github.com/w3c/csswg-drafts/issues/2474.
So given this is causing webcompat pain, I think we should be pragmatic and just
unprefix this.
We could keep serialization a... | diff --git a/style/gecko/pseudo_element_definition.mako.rs b/style/gecko/pseudo_element_definition.mako.rs
index 275a04e5b..caaeeac62 100644
--- a/style/gecko/pseudo_element_definition.mako.rs
+++ b/style/gecko/pseudo_element_definition.mako.rs
@@ -216,11 +216,7 @@ impl PseudoElement {
None
}
- /// C... | 1 | 5 | 5 |
c201f9f0846f4c43241db47a14b2ee10aafe61d1 | Xidorn Quan | 2018-05-09T06:07:36 | Bug 1460192 - Rename pointing to inherited_ui. r=heycam
And also merge values::*::pointing into values::*::ui.
MozReview-Commit-ID: FM4gWEszahB | diff --git a/style/gecko_bindings/sugar/style_complex_color.rs b/style/gecko_bindings/sugar/style_complex_color.rs
index 0d5a20944..0e06b4c50 100644
--- a/style/gecko_bindings/sugar/style_complex_color.rs
+++ b/style/gecko_bindings/sugar/style_complex_color.rs
@@ -7,7 +7,7 @@
use gecko::values::{convert_nscolor_to_rgb... | 12 | 103 | 134 |
c7ea5ab576f300bb9b09c9ad1c2f60cedece98a8 | Emilio Cobos Álvarez | 2018-05-05T15:28:58 | Bug 1459436: Remove some unneeded cfg(..). r=emilio
The less not-compiled code in common builds, the better for everybody.
MozReview-Commit-ID: 3JQfz6AYhPG | diff --git a/style/animation.rs b/style/animation.rs
index 685d39335..bbf847d7f 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
//! CSS transitions and animations.
-#![deny(missing_docs)]
use Atom;
use bezier::Bezier;
@@ -40... | 3 | 8 | 8 |
169fd4a4c07153d42201288ed133c68eb5acc90f | Emilio Cobos Álvarez | 2018-05-05T15:39:12 | Bug 1459436: Implement Debug for KeyframeAnimationStyle by hand. r=emilio
The ComputedValues format is huge and unneeded.
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
MozReview-Commit-ID: 44OuCMWJPLk | diff --git a/style/animation.rs b/style/animation.rs
index 983078e8d..685d39335 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -16,6 +16,7 @@ use properties::longhands::animation_direction::computed_value::single_value::T
use properties::longhands::animation_play_state::computed_value::single_value::T as ... | 1 | 18 | 1 |
98ede8d0fcc5eec29be9ce116efc3c8ad51bbe69 | Emilio Cobos Álvarez | 2018-05-05T15:19:06 | Bug 1459436: Fix servo build. r=emilio
MozReview-Commit-ID: Ex5RKgPgd8x | diff --git a/layout/animation.rs b/layout/animation.rs
index 274978114..b3416984f 100644
--- a/layout/animation.rs
+++ b/layout/animation.rs
@@ -39,14 +39,14 @@ where
let mut new_running_animations = vec![];
while let Ok(animation) = new_animations_receiver.try_recv() {
let mut should_push = true;
- ... | 5 | 32 | 32 |
8ac4455a1b99c61ac38a87fac49fb53d5f57ab7e | Emilio Cobos Álvarez | 2018-05-05T14:24:36 | Bug 1459436: Fix tidy issues. r=emilio
MozReview-Commit-ID: KXInHzAiiD8 | diff --git a/style/stylist.rs b/style/stylist.rs
index 54d006d4f..34f187e48 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1450,7 +1450,8 @@ impl Stylist {
// See [3] for the bug to implement whatever gets resolved, and related
// bugs for a bit more context.
//
- // [1]: htt... | 2 | 3 | 2 |
7efb179885a2a6afa968633ec2972eef2b5d7df2 | Xidorn Quan | 2018-05-02T11:07:07 | Bug 1457524 part 4 - Allow 16% false positives in test bloom::create_and_insert_some_stuff. r=heycam
It seems that the result of hash algorithm used in bloom filter depends
on the pointer length. On 64bit platforms, there are 135 false positives
in the first part of that test, and 8 in the second part. However, on
32b... | diff --git a/selectors/bloom.rs b/selectors/bloom.rs
index e06649d73..e4cd0a77f 100644
--- a/selectors/bloom.rs
+++ b/selectors/bloom.rs
@@ -335,7 +335,7 @@ fn create_and_insert_some_stuff() {
let false_positives = (1001_usize..2000).filter(|i| bf.might_contain(i)).count();
- assert!(false_positives < 150, ... | 1 | 1 | 1 |
831d7ce617563a2fd71cc36f2ac1c8657b1d3a0c | Emilio Cobos Álvarez | 2018-05-03T17:24:05 | Bug 1457678: Make the font canvas code not mess with the rule tree. r=xidorn,hiro
Inserting a lot of rules in the root level is super-inefficient. This fixes it
by not doing it.
It gives the root rule node to the style, but that's fine, since it's useless.
All this code-path is already pretty messy.
MozReview-Commit... | diff --git a/style/stylist.rs b/style/stylist.rs
index 732edc212..54d006d4f 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1555,27 +1555,25 @@ impl Stylist {
E: TElement,
{
use font_metrics::get_metrics_provider_for_product;
- use std::iter;
-
- // FIXME(emilio): Why do we... | 1 | 14 | 16 |
3de6de97684a2b17054b642dd0b12dd01ee9d622 | Emilio Cobos Álvarez | 2018-05-03T15:43:30 | Bug 1458927: Fix perspective squared distance computation. r=hiro
MozReview-Commit-ID: YwjTheRonB | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index d4da6fde5..387507516 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2632,16 +2632,7 @@ impl ComputeSquaredDista... | 1 | 1 | 10 |
008930d5c09c1fcd1096195e3cdc05b932b88eb3 | Emilio Cobos Álvarez | 2018-05-03T15:34:32 | Bug 1458715: followup: don't fix distance computation so fast. r=me
On a CLOSED TREE
MozReview-Commit-ID: 1Y3As81hnRx | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 387507516..d4da6fde5 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2632,7 +2632,16 @@ impl ComputeSquaredDista... | 1 | 10 | 1 |
f2945bbe00df6148c7eb982b759f0cdc86963cbd | Emilio Cobos Álvarez | 2018-05-03T08:15:15 | Bug 1458715: Fix perspective interpolation. r=hiro
It's not sound to insert random matrices in random positions in the transform
operation list.
I cannot make any sense of what the old code was trying to do.
MozReview-Commit-ID: 5BtCiueEPlR | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 57a8ed998..387507516 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1291,16 +1291,8 @@ impl Animate for Compute... | 2 | 8 | 23 |
6873eb340996ff76b22410bfc77760c8fa7d0153 | Emilio Cobos Álvarez | 2018-04-30T17:23:14 | Bug 1457920: Remove ServoStyleSheet usage. r=xidorn
MozReview-Commit-ID: LIBkovuQ6MB | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index ac41eaa14..a4ed8294a 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -8,7 +8,7 @@ use atomic_refcell::{AtomicRef, AtomicRefCell, AtomicRefMut};
use context::QuirksMode;
use dom::TElement;
use gecko_bindings::bindings::{self, RawServoStyleSet}... | 2 | 9 | 9 |
f8c0ed060137569a2603324bda97e8cab73dab93 | Emilio Cobos Álvarez | 2018-04-30T15:50:03 | Bug 1457920: Merge ServoStyleSheet and StyleSheet. r=xidorn
These are the most minimal changes I could make. More cleanups incoming.
MozReview-Commit-ID: AdMOA1acQIH | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 567a9b7f6..ac41eaa14 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -9,7 +9,7 @@ use context::QuirksMode;
use dom::TElement;
use gecko_bindings::bindings::{self, RawServoStyleSet};
use gecko_bindings::structs::{self, RawGeckoPresContextOwned... | 1 | 4 | 4 |
3ef3fced01d3d33618c8647c29742c5d68a6c672 | Emilio Cobos Álvarez | 2018-05-01T05:09:12 | Bug 1018269: Handle Shadow DOM in keyframes lookup. r=heycam
MozReview-Commit-ID: AeUmsOHOUYR | diff --git a/style/stylist.rs b/style/stylist.rs
index a76a461b7..732edc212 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1421,14 +1421,52 @@ impl Stylist {
}
/// Returns the registered `@keyframes` animation for the specified name.
- ///
- /// FIXME(emilio): This needs to account for the e... | 1 | 45 | 7 |
9f87b8acef8860a51f13381ec8a7c18431846203 | Emilio Cobos Álvarez | 2018-04-29T03:34:28 | Bug 1457635: Remove values::Verbatim. r=xidorn
No point of having two things that do the same.
MozReview-Commit-ID: Do1L4bvOeVQ | diff --git a/style_derive/to_css.rs b/style_derive/to_css.rs
index 7ac7d3a1a..0caef8b01 100644
--- a/style_derive/to_css.rs
+++ b/style_derive/to_css.rs
@@ -175,7 +175,7 @@ fn derive_single_field_expr(
{
let mut iter = #field.iter().peekable();
if iter.peek().i... | 2 | 1 | 16 |
3f8167441c20f95ca52874f0227465b60da4669c | Emilio Cobos Álvarez | 2018-04-29T02:48:47 | Bug 1457635: Move represents_keyword to the css attributes. r=xidorn
MozReview-Commit-ID: 21yuU4h34AQ | diff --git a/style/values/generics/border.rs b/style/values/generics/border.rs
index 6230a1cf3..c25560ed0 100644
--- a/style/values/generics/border.rs
+++ b/style/values/generics/border.rs
@@ -23,12 +23,13 @@ pub enum BorderImageSideWidth<LengthOrPercentage, Number> {
/// A generic value for the `border-image-slice`... | 8 | 24 | 69 |
005e675dcb126b01962c358c4ae129b6b96b14b0 | Emilio Cobos Álvarez | 2018-04-29T03:12:57 | Bug 1457332: Derive ToCss for Counters. r=xidorn
MozReview-Commit-ID: 1jOglcqt1Dd | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index a3d316df3..4479d0405 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -5697,9 +5697,9 @@ clip-path
) {
unsafe {
bindings::Gecko_ClearAndResizeCounter${counter_prop... | 3 | 29 | 44 |
ab583c71cb79d8e68400d50914a99325145eec0b | Xidorn Quan | 2018-04-29T11:17:26 | Bug 1448759 part 1 - Make KTableEntry an independent type. r=heycam
MozReview-Commit-ID: oZfJAigThN | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index e488fdfa0..7d9724cc6 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -13,7 +13,7 @@ use euclid::TypedScale;
use gecko::values::{convert_nscolor_to_rgba, convert_rgba_to_nscolor};
use gecko_bindings::bindings... | 1 | 3 | 3 |
2915f7c2ba53c551855a126bfb587b6ff518132c | Emilio Cobos Álvarez | 2018-04-29T01:02:21 | No bug - Fix tidy issues and Servo build, and fix unit test bustage. r=me
MozReview-Commit-ID: 7MFLnVZmZUg | diff --git a/layout/display_list/builder.rs b/layout/display_list/builder.rs
index 141bbb52b..65b12137c 100644
--- a/layout/display_list/builder.rs
+++ b/layout/display_list/builder.rs
@@ -66,9 +66,9 @@ use style::servo::restyle_damage::ServoRestyleDamage;
use style::values::{Either, RGBA};
use style::values::compute... | 12 | 26 | 15 |
add68161ef30c8c37247f23325f32f6b1f0df349 | Emilio Cobos Álvarez | 2018-04-29T00:43:47 | No bug - Change the configuration of some properties for servo. r=me
MozReview-Commit-ID: FxJQrXziRK0 | diff --git a/style/properties/longhand/position.mako.rs b/style/properties/longhand/position.mako.rs
index 7666781eb..a99cebfdb 100644
--- a/style/properties/longhand/position.mako.rs
+++ b/style/properties/longhand/position.mako.rs
@@ -352,7 +352,7 @@ ${helpers.predefined_type("grid-template-areas",
${helpers.predefi... | 1 | 2 | 2 |
eaf5ac968b255f012fc5aff7273ae1046d613d11 | Emilio Cobos Álvarez | 2018-04-29T00:30:59 | No bug - Derive an attribute for servo. r=me
MozReview-Commit-ID: DQBJeg3xbuM | diff --git a/style/values/generics/font.rs b/style/values/generics/font.rs
index ecebe9b2c..f5e62e0ab 100644
--- a/style/values/generics/font.rs
+++ b/style/values/generics/font.rs
@@ -227,6 +227,7 @@ impl Default for KeywordSize {
///
/// https://drafts.csswg.org/css-fonts-4/#font-style-prop
#[allow(missing_docs)]
... | 1 | 1 | 0 |
a69a78c300be65f0c4e2517d27adfd314f9a1238 | Emilio Cobos Álvarez | 2018-04-29T00:27:09 | No bug - Reorder an import to sync with servo. r=me
MozReview-Commit-ID: 4BLELl3T54p | diff --git a/style/values/computed/percentage.rs b/style/values/computed/percentage.rs
index 0e0fd6053..653532aea 100644
--- a/style/values/computed/percentage.rs
+++ b/style/values/computed/percentage.rs
@@ -6,8 +6,8 @@
use std::fmt;
use style_traits::{CssWriter, ToCss};
-use values::animated::ToAnimatedValue;
us... | 1 | 1 | 1 |
ef26ceb8fd26a39fc72c43542de551ce5d116397 | Emilio Cobos Álvarez | 2018-04-29T00:26:14 | No bug - Get rid of an import and sync with servo. r=me
MozReview-Commit-ID: 5aGNna6ulsM | diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs
index 9de07ee8a..17ff3af63 100644
--- a/style/values/specified/font.rs
+++ b/style/values/specified/font.rs
@@ -24,7 +24,7 @@ use values::computed::{font as computed, Context, Length, NonNegativeLength, ToC
use values::computed::font::{Family... | 1 | 2 | 2 |
33a43ed6bd91f645522c2920a4b9dc43f112b084 | Emilio Cobos Álvarez | 2018-04-28T23:59:00 | No bug - sync some changes from servo. r=me
MozReview-Commit-ID: HyRI5CfZh5w | diff --git a/style/font_face.rs b/style/font_face.rs
index d732a5c0f..5a111925a 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -22,13 +22,12 @@ use style_traits::{Comma, CssWriter, OneOrMoreSeparated, ParseError};
use style_traits::{StyleParseErrorKind, ToCss};
use style_traits::values::SequenceWriter;
... | 3 | 14 | 17 |
65fc911b02797a1068c1862227d95c3b4ee75ab8 | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 12 - Manually implement collect_completion_keywords for some types. r=emilio
MozReview-Commit-ID: 6T35uylxgho | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index a0ecfc7b3..bca7e1088 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -15,11 +15,11 @@ use malloc_size_of::{MallocSizeOf, MallocSizeOfOps};
use parser::{Parse, ParserContext};
use servo_arc::{Arc, RawOffsetArc};
use std::mem;
-use style_traits::{P... | 7 | 209 | 34 |
3b5acbfc9fbb84acab1950ef4f4365ca1fd77f49 | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 11 - Add some attributes for SpecifiedValueInfo to help deriving more from types. r=emilio
MozReview-Commit-ID: IyohSTbUO31 | diff --git a/style/values/generics/basic_shape.rs b/style/values/generics/basic_shape.rs
index 80375ad8f..3bad738c1 100644
--- a/style/values/generics/basic_shape.rs
+++ b/style/values/generics/basic_shape.rs
@@ -69,6 +69,7 @@ pub enum BasicShape<H, V, LengthOrPercentage> {
/// <https://drafts.csswg.org/css-shapes/#... | 18 | 138 | 36 |
18af921d0b518745e797e3817c0c6c1d9874d512 | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 10 - Handle keywords for color values. r=emilio
MozReview-Commit-ID: 5GvIHSeQuCX | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index 32e0316f6..3066c5b8c 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -14,7 +14,7 @@ use parser::{Parse, ParserContext};
use properties::longhands::system_colors::SystemColor;
use std::fmt::{self,... | 1 | 10 | 1 |
79fa8ed661550d41e7ce7dce0f8a69879b8687c8 | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 9 - Use unified list for TextDecorationLine and implement its SpecifiedValueInfo. r=emilio
MozReview-Commit-ID: 2sCnK1AecFk | diff --git a/style/values/computed/text.rs b/style/values/computed/text.rs
index 7afb774ef..f2bcf11fe 100644
--- a/style/values/computed/text.rs
+++ b/style/values/computed/text.rs
@@ -15,8 +15,7 @@ use values::generics::text::InitialLetter as GenericInitialLetter;
use values::generics::text::LineHeight as GenericLine... | 2 | 112 | 122 |
590fa6aa6aa6d971a4d866b2ac4d2f64fc676f8f | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 8 - Have TextAlign derive ToCss and unship char value from it. r=emilio
MozReview-Commit-ID: CXDnyqzjQkq | diff --git a/style/values/specified/text.rs b/style/values/specified/text.rs
index d2ce18dcf..4bae78fc8 100644
--- a/style/values/specified/text.rs
+++ b/style/values/specified/text.rs
@@ -355,13 +355,17 @@ impl Parse for TextDecorationLine {
}
macro_rules! define_text_align_keyword {
- ($($name: ident => $discr... | 1 | 8 | 17 |
2433db3a6d3b27dd0948d73f3e48600fe7700a1d | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 7 - Have Parse derive respect #[css(skip)] on variant as well and derive Parse for KeywordSize. r=emilio
MozReview-Commit-ID: evSvk1RQGe | diff --git a/style/values/generics/font.rs b/style/values/generics/font.rs
index a46ed143f..712a13554 100644
--- a/style/values/generics/font.rs
+++ b/style/values/generics/font.rs
@@ -186,8 +186,9 @@ impl<Length> SpecifiedValueInfo for KeywordInfo<Length> {
}
/// CSS font keywords
-#[derive(Animate, Clone, Compute... | 3 | 7 | 17 |
f146bdec22bd1e488962b8fadf9d92058ad4195b | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 6 - Allow shorthands to specify their own impl of SpecifiedValueInfo and manual impl it for font and border. r=emilio
MozReview-Commit-ID: 3B9OfkWU0Eq | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 2aa93bbb7..017996f87 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -619,9 +619,14 @@
% endif
</%def>
-<%def name="shorthand(name, sub_properties, derive_serialize=False, **kwargs)">
+... | 3 | 46 | 22 |
235c8d65af227f24190705f35321354a4dcb054f | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 5 - Derive ToCss for values::generics::font::KeywordSize. r=emilio
MozReview-Commit-ID: 9ek3PcqYiU3 | diff --git a/style/values/generics/font.rs b/style/values/generics/font.rs
index 0b0f90cdf..a46ed143f 100644
--- a/style/values/generics/font.rs
+++ b/style/values/generics/font.rs
@@ -187,18 +187,21 @@ impl<Length> SpecifiedValueInfo for KeywordInfo<Length> {
/// CSS font keywords
#[derive(Animate, Clone, ComputeS... | 1 | 4 | 25 |
429212e28cd08714189f399b5ce9ad7ad1646903 | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 4 - Use unified lists to impl several bitflag font-variant properties. r=emilio
This also changes their ToCss impl to use SequenceWriter instead of
checking has_value manually.
SpecifiedValueInfo for those types are also implemented in this patch.
MozReview-Commit-ID: 23h2VWS417H | diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs
index 017b20f87..ea3607e8d 100644
--- a/style/values/specified/font.rs
+++ b/style/values/specified/font.rs
@@ -15,7 +15,9 @@ use malloc_size_of::{MallocSizeOf, MallocSizeOfOps};
use parser::{Parse, ParserContext};
use properties::longhands:... | 1 | 230 | 279 |
1dc2b727537c93d432c1cbbd65f90a302bbd1876 | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 3 - Add SequenceWriter::item_str for writing str items. r=emilio
This will be used in the next patch for font-variant bitflag types.
MozReview-Commit-ID: 2IvcsnYBNqA | diff --git a/style_traits/values.rs b/style_traits/values.rs
index d6bd05b7b..481eb1aff 100644
--- a/style_traits/values.rs
+++ b/style_traits/values.rs
@@ -173,16 +173,10 @@ where
Self { inner, separator }
}
- /// Serialises a CSS value, writing any separator as necessary.
- ///
- /// The sepa... | 1 | 26 | 9 |
e20774cdaa48c50e82315ef28fe69b9b77c27acc | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 2 - Add collect_values function to SpecifiedValueInfo trait for collecting possible values. r=emilio
This is the basic structure of the stuff. Following patches will fill
the gap between Gecko and Servo on value generating, and finally hook
it into InspectorUtils.
MozReview-Commit-ID: KNLAfFBiY6e | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index c528cd6b8..5e64aa031 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -42,7 +42,7 @@ use selector_parser::PseudoElement;
use selectors::parser::SelectorParseErrorKind;
#[cfg(featur... | 4 | 146 | 27 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.