commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
4c18f5da2b8538c86c6864c0168600ad0afe87e1
Cameron McCormack
2018-08-22T05:37:39
Bug 1485252 - Add MallocSizeOf impls for 128-bit integers. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D3947
diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs index f4774d66a..11e962541 100644 --- a/malloc_size_of/lib.rs +++ b/malloc_size_of/lib.rs @@ -845,8 +845,8 @@ macro_rules! malloc_size_of_is_0( ); malloc_size_of_is_0!(bool, char, str); -malloc_size_of_is_0!(u8, u16, u32, u64, usize); -malloc_size_of_is_0!(...
1
2
2
43c8f01a9763c5a348e87530a6af10222ec604d4
Boris Chiou
2018-08-22T01:20:21
Bug 1429298 - Part 3: Use macro for path parser. r=emilio There are a lot of duplicates, so we use macro to refine them. Depends on D2963 Differential Revision: https://phabricator.services.mozilla.com/D2966
diff --git a/style/values/specified/motion.rs b/style/values/specified/motion.rs index 8b370369b..ffaaf7cff 100644 --- a/style/values/specified/motion.rs +++ b/style/values/specified/motion.rs @@ -70,6 +70,34 @@ struct PathParser<'a> { path: Vec<PathCommand>, } +macro_rules! parse_arguments { + ( + $p...
1
78
163
b55994556417c23dc734f5b1d8579f9f8ecaabef
Cameron McCormack
2018-08-20T04:11:37
Bug 1484575 - Simplify PropertyDeclarationBlock::get a little. r=xidorn Depends On D3747 Differential Revision: https://phabricator.services.mozilla.com/D3748
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 7d1e2f3aa..38af8f2fa 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -305,14 +305,8 @@ impl PropertyDeclarationBlock { } } - self.declarations...
1
2
8
f59ae94bb53fa583ab7134460c53e54547ab35fc
Cameron McCormack
2018-08-20T05:34:16
Bug 1484571 - Replace NormalDeclarationIterator return type with `impl Trait`. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D3747
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index ad5aa75e8..7d1e2f3aa 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -138,56 +138,9 @@ impl<'a> DoubleEndedIterator for DeclarationImportanceIterator<'a> { } } -/// ...
1
13
52
54144a5d32d4559e2f127828bf73684ddaa9eda6
Emilio Cobos Álvarez
2018-08-18T16:41:40
Bug 1484459: Appease Servo's tidy lint. r=me
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 8d7147f6a..386d0ad5b 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -8,13 +8,12 @@ use Atom; use app_units::Au; use euclid::Size2D; use gecko_bindings::bindings; -use values::computed::CSSPixelLength; ...
4
26
31
6a67d02690c7f1e218bf6b4deeff8a733c5327d0
Emilio Cobos Álvarez
2018-08-18T16:19:34
Bug 1484459: Port servo to the new media query system. r=me Port `width`, and also add the `scan` media feature so I don't need to add ugliness just to workaround the unused keyword_evaluator macro. This is not part of the Gecko build in any case.
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 3595133f5..8d7147f6a 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -16,17 +16,6 @@ use media_queries::media_feature::{MediaFeatureDescription, Evaluator}; use media_queries::media_feature::{AllowsRanges...
3
57
134
f29126620fc9889f1e4905eff64690d94cab3e70
Emilio Cobos Álvarez
2018-08-18T16:02:11
Bug 1484459: Update num-traits in style. r=me
diff --git a/style/Cargo.toml b/style/Cargo.toml index fa2282213..2c39e800b 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -49,7 +49,7 @@ matches = "0.1" nsstring = {path = "../../support/gecko/nsstring", optional = true} num_cpus = {version = "1.1.0", optional = true} num-integer = "0.1" -num-traits = "0.1...
1
1
1
7c08da643f0621cab3a732b11a5babba2386ca42
Emilio Cobos Álvarez
2018-08-17T21:26:24
No bug - Remove an inaccurate and useless debug message. r=me
diff --git a/style/stylist.rs b/style/stylist.rs index 52feb19c4..dbddca725 100644 --- a/style/stylist.rs +++ b/style/stylist.rs @@ -1131,11 +1131,6 @@ impl Stylist { let rule_hash_target = element.rule_hash_target(); - debug!( - "Determining if style is shareable: pseudo: {}", - ...
1
0
5
9216956454867da620512f0a0ac66fc4034416c0
Emilio Cobos Álvarez
2018-08-17T21:25:37
Bug 1483808 - Make webkit device-pixel-ratio media queries a proper alias to resolution. r=dholbert According to the spec: https://compat.spec.whatwg.org/#css-media-queries-webkit-device-pixel-ratio And to the Chromium implementation: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/medi...
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 58afc901f..3595133f5 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -150,14 +150,10 @@ fn eval_device_pixel_ratio( query_value: Option<f32>, range_or_operator: Option<RangeOrOperator>, ) -> boo...
2
9
7
1dc624a88a224d0c03c507ab226508221e295d55
Xidorn Quan
2018-08-17T12:46:02
Bug 1484146 - Use AspectRatio directly for RangeOrOperator::evaluate. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D3587
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 0ff420a16..58afc901f 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -118,11 +118,8 @@ where }; let size = get_size(device); - RangeOrOperator::evaluate( - range_or_operator, - ...
2
29
12
f140a8836154e59be48872d566c043986613398b
Emilio Cobos Álvarez
2018-08-14T23:29:40
Bug 1483964: Manually inline class and ID getters. r=xidorn Somewhat ugly but hopefully not too much. Somehow it ends up removing more lines than adding. Differential Revision: https://phabricator.services.mozilla.com/D3536
diff --git a/style/gecko/snapshot.rs b/style/gecko/snapshot.rs index d70c6259b..fc4a9121a 100644 --- a/style/gecko/snapshot.rs +++ b/style/gecko/snapshot.rs @@ -51,10 +51,6 @@ impl GeckoElementSnapshot { (self.mContains as u8 & flags as u8) != 0 } - fn as_ptr(&self) -> *const Self { - self - ...
4
137
83
16b5cc1dfdafc407fca9f5456bfadc395638875a
Nicholas Nethercote
2018-08-17T05:33:22
Bug 1484096 - Remove use of `fnv` in bloom.rs. r=heycam To support that, this patch also does the following. - Removes the insert(), remove() and might_contain() methods, because they are specialized versions of insert_hash(), remove_hash(), and might_contain_hash(), and they are only used by tests within this fi...
diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml index 20ca61fb7..6d5a93b34 100644 --- a/selectors/Cargo.toml +++ b/selectors/Cargo.toml @@ -24,7 +24,6 @@ bitflags = "1.0" matches = "0.1" cssparser = "0.24.0" log = "0.4" -fnv = "1.0" fxhash = "0.2" phf = "0.7.18" precomputed-hash = "0.1" diff --git a/sele...
3
24
43
96480af9dbea432a09c3c571dd8511da2ca0e077
Emilio Cobos Álvarez
2018-08-17T01:07:22
Bug 1483823 - Deduplicate system metric atoms. r=xidorn Now that :-moz-system-metric is gone, there's no real reason for the atoms to be separate. Differential Revision: https://phabricator.services.mozilla.com/D3497
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 8a0eaf7aa..0ff420a16 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -401,7 +401,7 @@ fn eval_moz_touch_enabled( eval_system_metric( device, query_value, - atom!("touch-enable...
1
23
25
84029c1fe323b0cd2c30b57b803cb5b224867f01
Emilio Cobos Álvarez
2018-08-16T10:05:52
No bug - Add some spec links to media queries. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D3489
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 822a64d73..8a0eaf7aa 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -51,6 +51,7 @@ fn device_size(device: &Device) -> Size2D<Au> { Size2D::new(Au(width), Au(height)) } +/// https://drafts.csswg.or...
1
23
2
086c64ba569e129aca3b12698e9e0e94b4cef0b8
Xidorn Quan
2018-08-16T09:34:43
No bug - Simplify some code in NoCalcLength::parse_dimension. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D3473
diff --git a/style/values/specified/length.rs b/style/values/specified/length.rs index 27206a409..b6fe9bc23 100644 --- a/style/values/specified/length.rs +++ b/style/values/specified/length.rs @@ -421,46 +421,34 @@ impl NoCalcLength { value: CSSFloat, unit: &str, ) -> Result<Self, ()> { - ...
1
26
38
1b8f62ea7e7d344d887c4678a3118775383cb913
Emilio Cobos Álvarez
2018-08-14T08:49:21
Bug 1477773: Simplify visited-related code in invalidation. r=xidorn We match with AllLinksVisitedAndUnvisited for style invalidation, and we already do a subtree restyle because :visited matching doesn't depend on the actual element state. So all this stuff is just not needed. The comment points to the attribute tes...
diff --git a/style/invalidation/element/state_and_attributes.rs b/style/invalidation/element/state_and_attributes.rs index 0be44c1fc..1eb022b29 100644 --- a/style/invalidation/element/state_and_attributes.rs +++ b/style/invalidation/element/state_and_attributes.rs @@ -24,12 +24,6 @@ use selectors::matching::matches_sel...
1
27
78
ef3a9066ef74b777ae2b0648ea6768e0f8a37726
Emilio Cobos Álvarez
2018-08-14T08:47:25
Bug 1477773: no-op visited changes earlier if visited links are disabled. r=xidorn We force a repaint from ContentStateChangedInternal if visited links are disabled, and that's observable. Let's cut it off as early as we can to avoid timing attacks even when :visited is disabled. Differential Revision: https://phabri...
diff --git a/style/gecko/data.rs b/style/gecko/data.rs index 6b9005c75..0bd938c67 100644 --- a/style/gecko/data.rs +++ b/style/gecko/data.rs @@ -8,7 +8,7 @@ use atomic_refcell::{AtomicRef, AtomicRefCell, AtomicRefMut}; use context::QuirksMode; use dom::TElement; use gecko_bindings::bindings::{self, RawServoStyleSet}...
2
14
41
00ce26ddf0f0f5a996312dd8d7308a56905a2019
Nathan Froyd
2018-08-14T20:46:28
Bug 1483344 - remove unused kernel32-sys dependency from style; r=emilio
diff --git a/style/Cargo.toml b/style/Cargo.toml index dc4f2cb3e..9e536ae08 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -73,9 +73,6 @@ unicode-bidi = "0.3" unicode-segmentation = "1.0" void = "1.0.2" -[target.'cfg(windows)'.dependencies] -kernel32-sys = "0.2" - [build-dependencies] lazy_static = "1" ...
1
0
3
213abff8d227ddec342da9128883977461da11e8
Henri Sivonen
2018-07-06T07:44:43
Bug 1402247 - Use encoding_rs for XPCOM string encoding conversions. r=Nika,erahm,froydnj. Correctness improvements: * UTF errors are handled safely per spec instead of dangerously truncating strings. * There are fewer converter implementations. Performance improvements: * The old code did exact buffer lengt...
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 81f9b2ec7..33a66498b 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -2124,7 +2124,7 @@ fn static_assert() { }; for (servo, gecko) in v.0.areas.into_iter().zip(refptr.mNamedAreas.it...
1
7
7
8d0587edb95aaa708147808a5b42f741d552502f
Xidorn Quan
2018-08-14T08:37:37
Bug 1483090 - Rename StyleUserInterface to StyleUI. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D3276
diff --git a/style/properties/longhands/inherited_ui.mako.rs b/style/properties/longhands/inherited_ui.mako.rs index 9718e33a8..e597f97ce 100644 --- a/style/properties/longhands/inherited_ui.mako.rs +++ b/style/properties/longhands/inherited_ui.mako.rs @@ -4,7 +4,7 @@ <%namespace name="helpers" file="/helpers.mako.r...
1
1
1
2b575d5ec8021f8f2ff699dd76d2b492280ac2ec
Cameron McCormack
2018-08-12T11:16:25
Bug 1482677 - Remove unused BorrowedAtom. r=emilio,TYLin MozReview-Commit-ID: FEnicnGj118 Differential Revision: https://phabricator.services.mozilla.com/D3159
diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs index b0c875026..e70c7a47c 100644 --- a/style/gecko_string_cache/mod.rs +++ b/style/gecko_string_cache/mod.rs @@ -49,10 +49,6 @@ pub struct Atom(*mut WeakAtom); /// where `'a` is the lifetime of something that holds a strong reference to th...
1
0
4
c7fdaf87c939f69f1cfb17b0056669e9bab01fd1
L. David Baron
2018-08-10T02:20:53
Bug 1481866: Swap order of values in 'overflow' shorthand property. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D3069
diff --git a/style/properties/shorthands/box.mako.rs b/style/properties/shorthands/box.mako.rs index 3886c7d2d..960e608ce 100644 --- a/style/properties/shorthands/box.mako.rs +++ b/style/properties/shorthands/box.mako.rs @@ -7,7 +7,7 @@ <%helpers:shorthand name="overflow" flags="SHORTHAND_IN_GETCS" - sub_...
1
6
6
1ee7c14328d0f5f1c9e98fce1fdf1b291a8d98d8
Xidorn Quan
2018-08-09T13:49:47
Bug 1481984 - Use function pointer rather than Fn trait object for collect_property_completion_keywords. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D2985
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index df0b46557..64e99ba20 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -603,16 +603,17 @@ impl NonCustomPropertyId { /// See PropertyId::collect_property_completion_keywords. ...
1
5
4
e4abfc827d06d4a743718e5a55107da7439b1a1a
Emilio Cobos Álvarez
2018-08-07T23:10:03
Bug 1481681: Fix Servo build and unit tests. r=me
diff --git a/style/lib.rs b/style/lib.rs index 519b61877..a43f3f87c 100644 --- a/style/lib.rs +++ b/style/lib.rs @@ -93,6 +93,7 @@ extern crate string_cache; #[macro_use] extern crate style_derive; extern crate style_traits; +#[cfg(feature = "gecko")] extern crate thin_slice; extern crate time; extern crate uluru...
3
5
3
21037774aeaa8c2a409ffc61f87760d6fc916e08
Emilio Cobos Álvarez
2018-08-07T22:57:12
Bug 1481681: Appease Servo's tidy lint. r=me
diff --git a/style/context.rs b/style/context.rs index f2d79aa23..16bba2a86 100644 --- a/style/context.rs +++ b/style/context.rs @@ -14,8 +14,8 @@ use dom::{SendElement, TElement}; use dom::OpaqueNode; use euclid::Size2D; use euclid::TypedScale; -use fxhash::FxHashMap; use font_metrics::FontMetricsProvider; +use fx...
3
4
4
29fddeec889410f9a155d8d3763d64ea37d52440
Emilio Cobos Álvarez
2018-08-07T22:48:25
Bug 1481681: Sync some dependencies with servo. r=me
diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml index e8f531469..176355acd 100644 --- a/fallible/Cargo.toml +++ b/fallible/Cargo.toml @@ -10,7 +10,7 @@ name = "fallible" path = "lib.rs" [dependencies] -smallvec = "0.6" +smallvec = "0.6.2" hashglobe = { path = "../hashglobe" } # This crate effectively doe...
5
10
10
e0973ac2835334271cb58637eb60567b149295d9
Emilio Cobos Álvarez
2018-08-07T18:32:19
No bug - Fixup some indentation. r=me DONTBUILD
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index 543729602..cf1a2b56a 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -379,7 +379,8 @@ impl<'ln> TNode for GeckoNode<'ln> { self.0 .mFirstChild.raw::<nsIContent>() .as_ref() - ...
1
4
2
4c1248e5c725ed29a577475bca03538400bd058c
Xidorn Quan
2018-08-07T13:57:45
Bug 1481125 - Put overflow: -moz-scrollbar-* behind pref. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D2845
diff --git a/style/properties/shorthands/box.mako.rs b/style/properties/shorthands/box.mako.rs index 1425f0128..3886c7d2d 100644 --- a/style/properties/shorthands/box.mako.rs +++ b/style/properties/shorthands/box.mako.rs @@ -20,30 +20,36 @@ input: &mut Parser<'i, 't>, ) -> Result<Longhands, ParseError<'i>...
1
28
22
01c61ae7c23fd4dd2c553bc196dd8dbaef778102
Emilio Cobos Álvarez
2018-08-07T10:36:18
Bug 1481162 - Cleanup invalidation processor constructor. r=xidorn It used to be this way because of lifetime issues (plus the shadow datas were in RwLocks at some point IIRC). Now we guarantee that as long as the element is away the cascade data is as well, so we don't need to thread it around. Differential Revision...
diff --git a/style/data.rs b/style/data.rs index 3df6e31c7..71a0ac233 100644 --- a/style/data.rs +++ b/style/data.rs @@ -16,7 +16,6 @@ use selector_parser::{PseudoElement, RestyleDamage, EAGER_PSEUDO_COUNT}; use selectors::NthIndexCache; use servo_arc::Arc; use shared_lock::StylesheetGuards; -use smallvec::SmallVec;...
2
12
21
4fa90adfbdd8d4a581125668242ba3b042dae4a5
Boris Chiou
2018-08-07T07:56:01
Bug 1480649 - Use union to wrap different shape-like types. r=xidorn 1. We will add more shape-like types in the future, so it's better to use union to reduce the memory usage. 2. Those shape-like types are mutual exclusive, so we could use union to wrap them. Differential Revision: https://phabricator.services...
diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs index 14fee693a..3b1f31a1b 100644 --- a/style/gecko/conversions.rs +++ b/style/gecko/conversions.rs @@ -659,7 +659,7 @@ pub mod basic_shape { StyleShapeSourceType::None => Some(ShapeSource::None), StyleShapeSourceType...
2
5
5
a633eb81aeceefb073e42baabb6e9aad58d55d3e
Emilio Cobos Álvarez
2018-08-06T23:52:52
Bug 1481156 - Remove unused selectors methods. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D2767
diff --git a/selectors/tree.rs b/selectors/tree.rs index ef544cc7e..112b02dbb 100644 --- a/selectors/tree.rs +++ b/selectors/tree.rs @@ -45,12 +45,6 @@ pub trait Element: Sized + Clone + Debug { self.parent_element() } - /// Skips non-element nodes - fn first_child_element(&self) -> Option<Self>; ...
3
0
40
a989b39583fd4824c5d48e1b9b1bbaaf24055c6c
Emilio Cobos Álvarez
2018-08-07T00:33:34
Bug 1481204 - Don't print rerun-if-changed files until binding generation has succeeded. r=xidorn Otherwise they may clobber useful output. Differential Revision: https://phabricator.services.mozilla.com/D2783
diff --git a/style/build_gecko.rs b/style/build_gecko.rs index 68d160ab5..8387f6513 100644 --- a/style/build_gecko.rs +++ b/style/build_gecko.rs @@ -120,7 +120,6 @@ mod bindings { let mut file = File::open(&path).unwrap(); let mut content = String::new(); file.read_to_string(&mut content).unw...
1
5
1
9ff7a5d896bd736ce35a86ec5bc020e920e28e9d
Olli Pettay
2018-08-06T19:29:27
Bug 1469521 - Change storage of previous and next children in nsINode, r=bz
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index 85e8c4eae..5eecc6911 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -30,7 +30,7 @@ use gecko::selector_parser::{NonTSPseudoClass, PseudoElement, SelectorImpl}; use gecko::snapshot_helpers; use gecko_bindings::bindings; use gecko_...
1
12
9
c5cfba6dc26de84e9dfd3c8c006122b4351a5bd2
Emilio Cobos Álvarez
2018-08-01T12:57:01
Bug 1480054: Restrict XUL tree pseudos on nightly and early-beta. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D2598 MozReview-Commit-ID: I1dUPuGKkyX
diff --git a/style/gecko/pseudo_element_definition.mako.rs b/style/gecko/pseudo_element_definition.mako.rs index 06323699b..b507fafd8 100644 --- a/style/gecko/pseudo_element_definition.mako.rs +++ b/style/gecko/pseudo_element_definition.mako.rs @@ -112,7 +112,11 @@ impl PseudoElement { % for pseudo in PSEU...
2
8
2
ff76c8193bf58f8ee613e63cf734299f478fcdf7
Margareta Eliza Balazs
2018-08-06T11:09:07
Backed out 2 changesets (bug 1480054) for reftest failures in build/tests/reftest/tests/layout/reftests/bugs/664127-1.xul on a CLOSED TREE Backed out changeset 854bba84bd34 (bug 1480054) Backed out changeset 37861e92aa13 (bug 1480054)
diff --git a/style/gecko/pseudo_element_definition.mako.rs b/style/gecko/pseudo_element_definition.mako.rs index b507fafd8..06323699b 100644 --- a/style/gecko/pseudo_element_definition.mako.rs +++ b/style/gecko/pseudo_element_definition.mako.rs @@ -112,11 +112,7 @@ impl PseudoElement { % for pseudo in PSEU...
2
2
8
0eae4f580c5aa5e66d625776cd029c8c774c5030
Noemi Erli
2018-08-04T16:19:08
Backed out changeset ffb51c458444 (bug 1480054) for Reftest failures
diff --git a/style/gecko/pseudo_element_definition.mako.rs b/style/gecko/pseudo_element_definition.mako.rs index b507fafd8..06323699b 100644 --- a/style/gecko/pseudo_element_definition.mako.rs +++ b/style/gecko/pseudo_element_definition.mako.rs @@ -112,11 +112,7 @@ impl PseudoElement { % for pseudo in PSEU...
2
2
8
c185f7e09aeb2076db451ff59362a84c7e53142c
Emilio Cobos Álvarez
2018-08-01T09:57:45
Bug 1480043: Remove the concept of 'canonical' pseudos. r=xidorn We only have this so that ::-moz-placeholder keeps serializing as ::-moz-placeholder, but I don't think anybody really cares. Edge aliases ::-webkit-input-placeholder to ::-ms-input-placeholder at parse time as well, as can be seen in: ``` let s = docu...
diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs index 296b63398..a08da8d40 100644 --- a/style/gecko/pseudo_element.rs +++ b/style/gecko/pseudo_element.rs @@ -162,15 +162,6 @@ impl PseudoElement { self.is_anon_box() && !self.is_tree_pseudo_element() } - /// Covert non-canoni...
4
7
14
3389ff3d68276111d618f7a85f856740b23357c0
Xidorn Quan
2018-08-01T04:13:41
Bug 1475033 part 3 - Add scrollbar-width property. r=heycam MozReview-Commit-ID: CmCbaZosUrU
diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs index 13a940b2b..419024862 100644 --- a/style/properties/longhands/ui.mako.rs +++ b/style/properties/longhands/ui.mako.rs @@ -16,6 +16,17 @@ ${helpers.single_keyword("ime-mode", "auto normal active disabled inactive", ...
1
11
0
de524a6aa44c9774deb07e128863d63df2d81839
Cameron McCormack
2018-07-16T02:15:47
Bug 1475197 - Part 1: Shrink selectors::Component to 24 bytes. r=emilio This saves about 37 KiB of memory across the UA style sheets. MozReview-Commit-ID: EoZnlmyWwxX
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index a75ad1812..c08a4315e 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -37,6 +37,7 @@ servo_arc = { path = "../servo_arc" } smallbitvec = "2.1.0" smallvec = "0.6" string_cache = { version = "0.7", optional = true } +thin...
12
96
50
170cc6a61037f82b567fd5ab14f56fbee449d06e
shindli
2018-07-31T16:30:46
Backed out 3 changesets (bug 1428676) for bc failures in browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE Backed out changeset 6ba5975115fc (bug 1428676) Backed out changeset 7f1270a9ec3d (bug 1428676) Backed out changeset 662bfc31a950 (bug 1428676)
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 765731c13..ed08ac850 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -515,6 +515,7 @@ ${helpers.predefined_type( products="gecko", alias="-webkit-appearance:la...
2
7
12
a609ad234f55a7558c13b7d7dc6cf2e075983e73
Jonathan Watt
2018-06-19T19:12:45
Bug 1428676 pt 1. Add a '-moz-menulist-button' value to '-moz-appearance'. r=emilio The '-moz-menulist-button' value currently behavies identically to the 'menulist-button' value. This is not implemented as an alias because later patches in this patch series will change the behavior of our pre-existing 'menulist-butt...
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index ed08ac850..765731c13 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -515,7 +515,6 @@ ${helpers.predefined_type( products="gecko", alias="-webkit-appearance:la...
2
12
7
9704c72daabb6991f6c4d23fc976fb0eef8d87d7
Emilio Cobos Álvarez
2018-07-30T11:10:09
Bug 1479398: Micro-optimize is_root to avoid poking at the parent in the common case. r=xidorn We can discard the common case of an element having another element or document fragment parent, which is the common case. Then we can discard detached subtrees looking at is_in_document(). The only case where we have a no...
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index eed9ebe00..b00755a1d 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -2074,15 +2074,15 @@ impl<'le> ::selectors::Element for GeckoElement<'le> { #[inline] fn is_root(&self) -> bool { - let parent_node = match self....
1
5
5
ca6519d4d52199726604cfe95aaf82f326bc28ee
Emilio Cobos Álvarez
2018-07-30T16:04:05
Bug 1479450: Convert GetStringValue to use Servo. r=xidorn And remove gPropertyTable / kCSSRawProperties while at it. Differential Revision: https://phabricator.services.mozilla.com/D2516 MozReview-Commit-ID: 8U87BcBkrJF
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index 27458cf67..809820eae 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -427,9 +427,10 @@ impl NonCustomPropertyId { unsafe { ::std::mem::transmute(self.0 as i32) } } +...
1
3
2
3aa7d2b1c9ff6386c37130a4064e4fa351f5866a
Emilio Cobos Álvarez
2018-07-30T15:32:17
Bug 1479450: Implement nsCSSProps::LookupProperty using Rust. r=xidorn Always assume allowed-for-all-content. There are a couple callers which weren't doing that: * A unit test -> removed. * ComputeAnimationDistance: Used for testing (in transitions_per_property), and for the animation inspector. The animation ...
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index 5e341e82d..27458cf67 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -1870,6 +1870,18 @@ impl PropertyId { id.enabled_for_all_content() } + /// Converts this Prop...
1
12
0
79491352b80533cf2973034cdaf24029fbead28e
Emilio Cobos Álvarez
2018-07-30T12:25:22
Back out changeset 89fcb03e210c (Bug 1479398) because it's not reviewed yet. r=backout MozReview-Commit-ID: 84HzaAj5BTu
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index b00755a1d..eed9ebe00 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -2074,15 +2074,15 @@ impl<'le> ::selectors::Element for GeckoElement<'le> { #[inline] fn is_root(&self) -> bool { - if self.as_node().get_bool_fl...
1
5
5
30a1b7ad9489f3a5c35e00b6aa1b4106fc087ef9
Emilio Cobos Álvarez
2018-07-27T15:44:48
Bug 1479012: Improve logging for attribute changes. r=xidorn And general Element logging. We now print all the attributes for comparison. If this turns out to be too verbose we can change it to diff them or something. Differential Revision: https://phabricator.services.mozilla.com/D2471 MozReview-Commit-ID: 1Gl9Aum...
diff --git a/style/gecko/snapshot.rs b/style/gecko/snapshot.rs index bb0e4a991..d70c6259b 100644 --- a/style/gecko/snapshot.rs +++ b/style/gecko/snapshot.rs @@ -156,6 +156,15 @@ impl GeckoElementSnapshot { } impl ElementSnapshot for GeckoElementSnapshot { + fn debug_list_attributes(&self) -> String { + us...
4
46
33
296255686f64051343d21cb5ad6cf188f03b9706
Emilio Cobos Álvarez
2018-07-30T11:10:09
Bug 1479398: Micro-optimize is_root to avoid poking at the parent in the common case. r=xidorn Summary: We can discard the common case of an element having another element or document fragment parent, which is the common case. Then we can discard detached subtrees looking at is_in_document(). The only case where we ...
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index 58768e17e..12ee767e3 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -2087,15 +2087,15 @@ impl<'le> ::selectors::Element for GeckoElement<'le> { #[inline] fn is_root(&self) -> bool { - let parent_node = match self....
1
5
5
ad3b5c70dffedf6913c126355c5412830a4015e4
Emilio Cobos Álvarez
2018-07-30T10:53:18
Bug 1478985: Add a root bucket to the selector map. r=xidorn :root can't change without getting unbound from the tree so no fancy stuff other than that needed. This removes a lot of revalidation and attribute invalidation matching from the Chrome, and looks like it should be a good idea in general. Differential Revi...
diff --git a/style/selector_map.rs b/style/selector_map.rs index 3b0dcca95..3ab78ce2d 100644 --- a/style/selector_map.rs +++ b/style/selector_map.rs @@ -96,6 +96,8 @@ pub trait SelectorMapEntry: Sized + Clone { /// TODO: Tune the initial capacity of the HashMap #[derive(Debug, MallocSizeOf)] pub struct SelectorMap<T...
1
37
4
79e1802418557c7ec20280ec18b14859740d907b
Emilio Cobos Álvarez
2018-07-27T12:30:14
Bug 1478990: Make NonCustomPropertyId <-> nsCSSPropertyId conversions fast. r=xidorn We have a different order in nsCSSPropertyId for no good reason. The only invariant there is that longhands come before shorthands, and shorthands before aliases. Luckily that's also an invariant that NonCustomPropertyId has, so we c...
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index 28bdb0573..5e341e82d 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -410,17 +410,35 @@ pub mod animated_properties { #[derive(Clone, Copy, Debug)] pub struct NonCustomPropertyId(...
1
81
48
c8dc82107218ebf2eeacd6896b1b85f52b65aaa7
Emilio Cobos Álvarez
2018-07-28T22:36:09
Bug 1479216: Restore the order of Scrollbarbutton appearance values. r=xidorn The patch at bug 1478391 comment 6 changed the way the math in Scrollbarbutton* worked, which pretty surely caused this. Restore the original order and math to be the same as before bug 1478391. MozReview-Commit-ID: CK3iOqeX2NW
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 5f34ef918..afa88955d 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -999,10 +999,10 @@ pub enum Appearance { /// A scrollbar button (up/down/left/right). /// Keep these in order (some code casts...
1
1
1
2957c24d8aa8796ae75708546a884035d74c6320
Nicholas Nethercote
2018-07-27T06:49:04
Bug 1477628 - Convert FnvHash{Set,Map} instances to FxHash{Set,Map} (attempt 2). r=heycam
diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml index 19adcdd15..0826c1273 100644 --- a/selectors/Cargo.toml +++ b/selectors/Cargo.toml @@ -25,6 +25,7 @@ matches = "0.1" cssparser = "0.24.0" log = "0.4" fnv = "1.0" +fxhash = "0.2" phf = "0.7.18" precomputed-hash = "0.1" servo_arc = { version = "0.1", pat...
18
49
44
7c676d70f1b57bd164d31b17db99748c64d7f755
Bogdan Tara
2018-07-27T04:00:56
Backed out changeset 72b855b514f9 (bug 1477628) for rusttests build bustages CLOSED TREE
diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml index 211ff3cdb..19adcdd15 100644 --- a/selectors/Cargo.toml +++ b/selectors/Cargo.toml @@ -24,7 +24,7 @@ bitflags = "1.0" matches = "0.1" cssparser = "0.24.0" log = "0.4" -fxhash = "0.2" +fnv = "1.0" phf = "0.7.18" precomputed-hash = "0.1" servo_arc = { ve...
18
48
48
f3c48a34571f9f3f977cf6efec69af70e8701b97
Nicholas Nethercote
2018-07-26T23:01:15
Bug 1477628 - Convert FnvHash{Set,Map} instances to FxHash{Set,Map}. r=heycam It doesn't appear to make much difference to performance, but it does let us remove the `fnv` crate from the repo.
diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml index 19adcdd15..211ff3cdb 100644 --- a/selectors/Cargo.toml +++ b/selectors/Cargo.toml @@ -24,7 +24,7 @@ bitflags = "1.0" matches = "0.1" cssparser = "0.24.0" log = "0.4" -fnv = "1.0" +fxhash = "0.2" phf = "0.7.18" precomputed-hash = "0.1" servo_arc = { ve...
18
48
48
011b9b5e3a8392f0d7d5e9bdfe52c71fe5835e97
Cosmin Sabou
2018-07-26T04:38:47
Backed out 2 changesets (bug 1475197) for causing linux build bustages because of compile errors. Backed out changeset 108e22d963cb (bug 1475197) Backed out changeset 4bd5f8588422 (bug 1475197)
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index c08a4315e..a75ad1812 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -37,7 +37,6 @@ servo_arc = { path = "../servo_arc" } smallbitvec = "2.1.0" smallvec = "0.6" string_cache = { version = "0.7", optional = true } -thin...
12
41
87
cee5a7f59b13f400ae6b6b3811974abdc9dfbd16
Cameron McCormack
2018-07-16T02:15:47
Bug 1475197 - Part 1: Shrink selectors::Component to 24 bytes. r=emilio This saves about 37 KiB of memory across the UA style sheets. MozReview-Commit-ID: EoZnlmyWwxX
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index a75ad1812..c08a4315e 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -37,6 +37,7 @@ servo_arc = { path = "../servo_arc" } smallbitvec = "2.1.0" smallvec = "0.6" string_cache = { version = "0.7", optional = true } +thin...
12
87
41
c7285833b76202001e64718026e3a9061f395f07
Hiroyuki Ikezoe
2018-07-24T07:50:47
Bug 1365045 - Introduce nsCSSKeywordAndBoolTableEntry. r=heycam The values in the boolean context depend on its feature. For examples, in the case of prefers-reduced-motion 'no-preference' means false and 'reduced' mean true in the boolean context, whereas in the case of prefers-contrast 'no-preference' means false a...
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index 9c5ef4d71..221281ba4 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -16,6 +16,7 @@ use gecko_bindings::structs; use gecko_bindings::structs::{nsCSSKTableEntry, nsCSSKeyword, nsCSSUnit, nsCSSValue}; use geck...
1
126
34
1b7d886fb464b97d52b9d73258e793213083fa89
Emilio Cobos Álvarez
2018-07-24T01:36:41
Bug 1477883: Fix servo build. r=me MozReview-Commit-ID: LU5Id4244ft
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index 81cf3d378..957335d32 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -257,32 +257,41 @@ ${helpers.predefined_type( )} % else: ...
2
36
27
b1d33cfe123ba987a3f5b5694cbccd0726f38657
Emilio Cobos Álvarez
2018-07-24T01:35:47
Bug 1477883: Update itoa. r=me Has been updated in servo for a long time, and we already have the new version in tree. MozReview-Commit-ID: 1yNOsqwLign
diff --git a/style/Cargo.toml b/style/Cargo.toml index ac385fd54..9ac162b02 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -40,7 +40,7 @@ fnv = "1.0" hashglobe = { path = "../hashglobe" } html5ever = {version = "0.22", optional = true} itertools = "0.7.6" -itoa = "0.3" +itoa = "0.4" lazy_static = "1" log ...
1
1
1
81e046ba3835eb9e67de3c35bde7acac731ebd0f
nupurbaghel
2018-07-03T19:47:22
Bug 1477883: Cherry-pick style changes from servo/servo#21181. r=emilio MozReview-Commit-ID: FpZ0YvXEYmP
diff --git a/style/values/specified/source_size_list.rs b/style/values/specified/source_size_list.rs index d41fc283b..33078c064 100644 --- a/style/values/specified/source_size_list.rs +++ b/style/values/specified/source_size_list.rs @@ -18,6 +18,7 @@ use values::specified::{Length, NoCalcLength, ViewportPercentageLengt...
1
7
0
d2d3058180fafba251ab393ffccb3bf24d7fc13c
Bastien Orivel
2018-07-24T01:17:48
Bug 1477883: Update parking_lot to 0.6. r=emilio Cherry-pick of servo/servo#21216. MozReview-Commit-ID: 4sTKSSCbrP4
diff --git a/style/Cargo.toml b/style/Cargo.toml index d82100023..ac385fd54 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -52,7 +52,7 @@ num-integer = "0.1.32" num-traits = "0.1.32" new-ordered-float = "1.0" owning_ref = "0.3.3" -parking_lot = "0.5" +parking_lot = "0.6" precomputed-hash = "0.1.1" rayon =...
2
9
7
234d1212a74bc88a496bac86f48deaf7f9471f60
Emilio Cobos Álvarez
2018-07-22T14:10:23
Bug 1477553: Hide display: -moz-box|-moz-inline-box from content on Nightly and early beta. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D2288 MozReview-Commit-ID: F9BeAneKY6e
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 632c8f9c9..cec7c8ccc 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -30,6 +30,17 @@ fn moz_display_values_enabled(context: &ParserContext) -> bool { } } +#[cfg(feature = "gecko")] +fn moz_box_disp...
1
13
0
d620747f0ffe059b48dec3c889e4d1dcc8d6f728
Cosmin Sabou
2018-07-23T15:03:10
Backed out 2 changesets (bug 1477553) for reftest failures on xulscroll.html. Backed out changeset a5bebad6bb23 (bug 1477553) Backed out changeset 8d4b97056365 (bug 1477553)
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index cec7c8ccc..632c8f9c9 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -30,17 +30,6 @@ fn moz_display_values_enabled(context: &ParserContext) -> bool { } } -#[cfg(feature = "gecko")] -fn moz_box_disp...
1
0
13
97842b47675a0e37749719bebef1de32a4494039
Cosmin Sabou
2018-07-23T10:17:09
Backed out changeset d0cb9041aa08 (bug 1477553) for browser chrome mochitest failures on /browser_parsable_css.js.
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index cec7c8ccc..632c8f9c9 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -30,17 +30,6 @@ fn moz_display_values_enabled(context: &ParserContext) -> bool { } } -#[cfg(feature = "gecko")] -fn moz_box_disp...
1
0
13
8825a873c199e263804a91c54f06e04376d6adab
Ting-Yu Lin
2018-07-22T02:53:44
Bug 1477533 - Convert NS_STYLE_COLUMN_SPAN_* to an enum class. r=heycam MozReview-Commit-ID: F8M1DlpBop2
diff --git a/style/properties/longhands/column.mako.rs b/style/properties/longhands/column.mako.rs index 86c605a1c..e7305e5b4 100644 --- a/style/properties/longhands/column.mako.rs +++ b/style/properties/longhands/column.mako.rs @@ -61,6 +61,7 @@ ${helpers.predefined_type( ${helpers.single_keyword("column-span", "no...
1
1
0
f477bf242255579904ef6f88338505ada523312b
Emilio Cobos Álvarez
2018-07-19T17:50:19
Bug 1475511: Add @-moz-document media-document(image|video|plugin). r=xidorn MozReview-Commit-ID: CD3O1vGLAoV
diff --git a/style/stylesheets/document_rule.rs b/style/stylesheets/document_rule.rs index df8f39883..56750ae7b 100644 --- a/style/stylesheets/document_rule.rs +++ b/style/stylesheets/document_rule.rs @@ -71,6 +71,16 @@ impl DeepCloneWithLock for DocumentRule { } } +/// The kind of media document that the rule ...
1
28
0
0ea9255289450966e676ae7090aa1e12a6e2d6a1
Emilio Cobos Álvarez
2018-07-19T17:12:18
Bug 1475511: Make document condition parsing a bit nicer. r=xidorn MozReview-Commit-ID: Gi0FxrEAYcE
diff --git a/style/stylesheets/document_rule.rs b/style/stylesheets/document_rule.rs index 9fc1bbfe1..df8f39883 100644 --- a/style/stylesheets/document_rule.rs +++ b/style/stylesheets/document_rule.rs @@ -122,33 +122,32 @@ impl DocumentMatchingFunction { context: &ParserContext, input: &mut Parser<'i,...
1
22
23
f8aa9007665d181217da2a021a8de77828fcf4f1
Emilio Cobos Álvarez
2018-07-19T10:56:27
Bug 1475511: UrlMatchingFunction -> DocumentMatchingFunction. r=xidorn MozReview-Commit-ID: HLcaVmehFW7
diff --git a/style/stylesheets/document_rule.rs b/style/stylesheets/document_rule.rs index f27d47d17..9fc1bbfe1 100644 --- a/style/stylesheets/document_rule.rs +++ b/style/stylesheets/document_rule.rs @@ -71,9 +71,9 @@ impl DeepCloneWithLock for DocumentRule { } } -/// A URL matching function for a `@document` ...
1
19
19
4f0896caa756b49ea2804b680378a2b6d5f24957
Ting-Yu Lin
2018-07-21T19:00:26
Bug 1477533 - Convert NS_STYLE_COLUMN_FILL_* to an enum class. r=heycam I put Balance as the first item in StyleColumnFill because it is the default value. MozReview-Commit-ID: A4DVMLL6XBa
diff --git a/style/properties/longhands/column.mako.rs b/style/properties/longhands/column.mako.rs index 7a97c3f41..86c605a1c 100644 --- a/style/properties/longhands/column.mako.rs +++ b/style/properties/longhands/column.mako.rs @@ -33,6 +33,7 @@ ${helpers.predefined_type( ${helpers.single_keyword("column-fill", "ba...
1
1
0
b9f696dde342bdd04681795056b3d1500255851f
Ting-Yu Lin
2018-07-21T00:09:31
Bug 1477533 - Use static const class variable to represent column-count: auto. r=heycam NS_STYLE_COLUMN_COUNT_UNLIMITED is unused, so I remove it. MozReview-Commit-ID: HLHLn9ZbkUY
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index ac5acfd05..c91ef4d44 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -5379,21 +5379,21 @@ clip-path #[allow(unused_unsafe)] pub fn set_column_count(&mut self, v: longhands::column_count::co...
1
4
4
e36c52004edcbd60d5066eb1f585c42810bbcd4f
Emilio Cobos Álvarez
2018-07-16T14:07:58
Bug 1450250: Make svg:use use an actual shadow tree. r=heycam Summary: This fixes a couple fuzz bugs and prevents special-casing <svg:use> even more in bug 1431255. Unfortunately not as many hacks went away as I'd have hoped, since we still need to match document rules, see the linked SVGWG issues. But blocks_ancest...
diff --git a/selectors/matching.rs b/selectors/matching.rs index 7c4812cb9..fd4765c2d 100644 --- a/selectors/matching.rs +++ b/selectors/matching.rs @@ -418,10 +418,6 @@ where match combinator { Combinator::NextSibling | Combinator::LaterSibling => element.prev_sibling_element(), Combinator::Chil...
5
25
29
bd334a7cca64ff4e38a0be27225c7181d003645c
Xidorn Quan
2018-07-19T00:11:04
Bug 1473180 part 5 - Remove DeclarationPushMode. r=emilio MozReview-Commit-ID: LFgYeKE1SNk
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 571b231cd..ad5aa75e8 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -64,19 +64,6 @@ pub struct SourcePropertyDeclarationUpdate { any_removal: bool, } -/// Enum for ...
2
32
69
a6ed487308c396a523758d0585b275da6683d695
Xidorn Quan
2018-07-19T00:11:04
Bug 1473180 part 4 - Remove DeclarationPushMode::Update and related code. r=emilio MozReview-Commit-ID: 1fI5YRa54lQ
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 4d775e853..571b231cd 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -72,10 +72,6 @@ pub enum DeclarationPushMode { /// importance, the new declaration will be discarde...
1
0
41
9417559c285a3443cc41947d87dedefea8a82f6e
Xidorn Quan
2018-07-19T00:11:04
Bug 1473180 part 2 - Add new algorithm for setting property to be used in later commit. r=emilio MozReview-Commit-ID: CdM8hDB6rFj
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 7f6fc15bd..4d775e853 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -11,6 +11,7 @@ use cssparser::{DeclarationListParser, parse_important, ParserInput, CowRcStr}; use cssp...
2
219
11
a1b236149a6126668de9180ba9d1935764aaa689
Emilio Cobos Álvarez
2018-07-17T12:11:30
Bug 1474959: Remove IS_STYLE_IF_VISITED. r=xidorn MozReview-Commit-ID: 8rnlaMOJisA
diff --git a/style/properties/computed_value_flags.rs b/style/properties/computed_value_flags.rs index 4ddc9a1f4..931aef000 100644 --- a/style/properties/computed_value_flags.rs +++ b/style/properties/computed_value_flags.rs @@ -56,13 +56,10 @@ bitflags! { /// Whether the child explicitly inherits any reset pr...
4
7
43
a4f74027ddbae8af15ba392d9074372239791cae
Emilio Cobos Álvarez
2018-07-17T12:08:17
Bug 1474959: Push visited style computation a bit further down. r=xidorn MozReview-Commit-ID: 1DILenWIw4D
diff --git a/style/animation.rs b/style/animation.rs index d090ecb1e..2d421ce06 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -9,7 +9,7 @@ use bezier::Bezier; use context::SharedStyleContext; use dom::{OpaqueNode, TElement}; use font_metrics::FontMetricsProvider; -use properties::{self, CascadeFlags, C...
6
155
140
a310328ba04f9a59b0b846241ef5404ed219a47d
Emilio Cobos Álvarez
2018-07-08T14:15:41
Bug 1309752: Cleanup might_need_transitions_update. r=birtles Thought I had to update this as well, but nope. When basically any style changes we already update transitions. needs_transitions_update already handles the physical mapping changing by checking whether any transition for the physical property remain there...
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index 00a7dcdb2..035cf0f78 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -1589,25 +1589,24 @@ impl<'le> TElement for GeckoElement<'le> { fn might_need_transitions_update( &self, - old_values: Option<&ComputedValues...
1
12
13
59cc685914b82e7fce200a28c79ebb888bde8d9c
Emilio Cobos Álvarez
2018-07-08T14:14:21
Bug 1309752: Update animations if the logical to physical property mapping changes. r=birtles MozReview-Commit-ID: 1lbOcniojVO
diff --git a/style/matching.rs b/style/matching.rs index 05630b07f..6f239d361 100644 --- a/style/matching.rs +++ b/style/matching.rs @@ -233,18 +233,23 @@ trait PrivateMatchMethods: TElement { fn needs_animations_update( &self, context: &mut StyleContext<Self>, - old_values: Option<&Comput...
1
25
12
373cf01a9bfe90c9ecf602dc586ea3cce5a995be
Bobby Holley
2018-07-17T22:23:26
Bug 1476445 - Use an acquire load for is_unique in servo_arc. r=manishearth MozReview-Commit-ID: Dv7Rql4KUgr Differential Revision: https://phabricator.services.mozilla.com/D2205
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs index e2063c79a..3e6cd65e8 100644 --- a/servo_arc/lib.rs +++ b/servo_arc/lib.rs @@ -349,15 +349,10 @@ impl<T: ?Sized> Arc<T> { #[inline] pub fn is_unique(&self) -> bool { - // We can use Relaxed here, but the justification is a bit subtle. + // ...
1
3
8
156a020c507f90c6e8affcdd98fa97930f5375a5
Philipp Klein
2018-07-10T17:05:17
Bug 1473804: Add doc comments to specified `float` and `clear` CSS property. r=emilio DONTBUILD, because comment-only change. MozReview-Commit-ID: 1Ls9NKrDlES
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 0140ac33d..632c8f9c9 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -833,6 +833,7 @@ impl TransitionProperty { #[cfg_attr(feature = "servo", derive(Deserialize, Serialize))] #[derive(Clone, Copy, Debug,...
1
2
0
57a002e13d190b04c6636358656c56ffe1e530cc
Emilio Cobos Álvarez
2018-07-16T17:46:00
Bug 1476054: Remove a useless cfg. r=me MozReview-Commit-ID: HrVqhA6FiIA
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index fe1ae5d66..a4396d0b4 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -35,7 +35,7 @@ use logical_geometry::WritingMode; #[cfg(feature = "gecko")] use malloc_size_of::{MallocSizeOf, ...
1
1
1
5d1b22fdf9a186811c998c68e7cd6578ed8895a6
Emilio Cobos Álvarez
2018-07-16T17:01:24
Bug 1476054: Fixes and cleanups for Servo PR #21156. r=me Similar to the previous patch, logical clear doesn't appear in computed style objects. MozReview-Commit-ID: FbN0hiUGzYa
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 9c5d90524..ac5acfd05 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -3086,6 +3086,14 @@ fn static_assert() { <% float_keyword = Keyword("float", "Left Right None", gecko_enum_prefix="StyleFloat")...
1
8
0
056955de654dd6ef5c31a9ff209cceceb34d74da
Philipp Klein
2018-07-10T07:13:20
Bug 1476054: Move `clear` CSS property outside mako. r=emilio Imports servo/servo#21156. Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io> MozReview-Commit-ID: CLZN4FdUvDN
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 407e8da2a..627b9a8ce 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -67,60 +67,16 @@ ${helpers.predefined_type( gecko_ffi_name="mFloat" )} -<%helpers:single_key...
5
82
56
50ae536ba919a5f6a2854cef2121aea77985fda6
Emilio Cobos Álvarez
2018-07-16T16:50:18
Bug 1476054: Fixes and cleanups for Servo PR #21139. r=me Logical floats don't appear in the computed style objects, so there's no need to check for them. MozReview-Commit-ID: 3ocJrRB3jeO
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 03265c721..9c5d90524 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -3083,6 +3083,9 @@ fn static_assert() { <%call expr="impl_keyword_clone('display', 'mDisplay', display_keyword)"></%call> +...
1
3
0
7695d912bbecaa2b6e6dca9a6be3ced59c81aa18
Philipp Klein
2018-07-06T11:01:54
Bug 1476054: Move `float` CSS property outside mako. r=emilio Imports servo/servo#21139. Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io> MozReview-Commit-ID: EoLK36GMq3d
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index ce04a0a66..407e8da2a 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -54,61 +54,18 @@ ${helpers.single_keyword("position", "static absolute relative fixed sticky", ...
5
81
55
238be7ad71f5e8a5b4bbef183f75749839bd4eea
Gurzau Raul
2018-07-16T20:56:23
Backed out 6 changesets (bug 1476054) for failing on servo/ports/geckolib/glue.rs on a CLOSED TREE Backed out changeset f4941fe345ad (bug 1476054) Backed out changeset cc571c618e4c (bug 1476054) Backed out changeset 0a712d7bcb66 (bug 1476054) Backed out changeset 62293a989ed2 (bug 1476054) Backed out changeset ef2a43e...
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index ac5acfd05..03265c721 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -3083,17 +3083,6 @@ fn static_assert() { <%call expr="impl_keyword_clone('display', 'mDisplay', display_keyword)"></%call> ...
7
110
173
e08950346144fbe001d8157ba4d5ac32d44242d6
Dan Glastonbury
2018-07-03T04:15:06
Bug 1467622 - P4: Correct background/foreground ratio mixing. r=xidorn MozReview-Commit-ID: InAZVcH2Vkt
diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs index 7f6b4cd9d..4356c5a3d 100644 --- a/style/values/animated/color.rs +++ b/style/values/animated/color.rs @@ -126,11 +126,11 @@ impl Animate for Color { let (this_weight, other_weight) = procedure.weights(); Ok(match (*se...
2
70
18
8cc8eda4d8c6552c92bfdb9f707450ff90d65885
Dan Glastonbury
2018-06-27T07:07:37
Bug 1467622 - P1: nsStyleSVGPaint - Change nscolor to StyleComplexColor. r=xidorn MozReview-Commit-ID: 1bbQzOoOuBe
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index c262af439..03265c721 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -667,14 +667,14 @@ def set_gecko_property(ffi_name, expr): SVGPaintKind::Color(color) => { paint.mType...
4
15
13
7c8b430e7eab67b6f84e68b25abb57faf6652405
Emilio Cobos Álvarez
2018-07-12T06:58:09
Bug 1475220: Cleanup push_applicable_declarations. r=xidorn This patch changes the behavior to skipping XBL rules for getDefaultComputedStyle. MozReview-Commit-ID: 52cwDyBAXO
diff --git a/style/stylist.rs b/style/stylist.rs index aa5f77d0d..5acdcf33b 100644 --- a/style/stylist.rs +++ b/style/stylist.rs @@ -1175,7 +1175,6 @@ impl Stylist { pseudo_element.is_some() ); - let only_default_rules = rule_inclusion == RuleInclusion::DefaultOnly; let matches_u...
1
40
43
5c00e6a95fb654dc65efaf227e4e84c0b1d1b8e3
Xidorn Quan
2018-07-13T12:06:05
Bug 1475229 - Remove unused parent parameter in ComputedValues::new. r=emilio MozReview-Commit-ID: EBG0TS7tI4P
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 398070040..c262af439 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -83,7 +83,6 @@ pub struct ComputedValues(::gecko_bindings::structs::mozilla::ComputedStyle); impl ComputedValues { pub fn new(...
2
9
18
94948547d0fc7717f8e3f529ad5da525235b4b1f
Cameron McCormack
2018-07-12T09:44:00
Bug 1475191 - Measure heap allocations hanging off selector components. r=emilio MozReview-Commit-ID: D7vZQ7v8owS
diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs index eaec2cb20..641d27648 100644 --- a/malloc_size_of/lib.rs +++ b/malloc_size_of/lib.rs @@ -693,6 +693,90 @@ impl MallocSizeOf for selectors::parser::AncestorHashes { } } +impl<Impl: selectors::parser::SelectorImpl> MallocSizeOf + for selectors::pa...
5
89
16
f60732e95e34d266d3de6cedaa0460623a67d570
Xidorn Quan
2018-07-12T04:19:16
Bug 1461285 followup - Remove a unused line to fix a warning.
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index 3af1068fc..3a5d6691b 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -2254,7 +2254,6 @@ impl<'a> Iterator for AllShorthandDeclarationIterator<'a> { )) ...
1
0
1
f939bacf1ececed9091734793a86a61c3695785e
Brindusan Cristian
2018-07-11T06:37:26
Backed out 5 changesets (bug 1467622) for reftest failures on layout/reftests/svg/smil/style/anim-css-fill-1-from-by-curcol-hex.svg. CLOSED TREE Backed out changeset 8694fe928b04 (bug 1467622) Backed out changeset 74533cad9479 (bug 1467622) Backed out changeset e1dbee410e98 (bug 1467622) Backed out changeset 56142038c...
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index ad6e0a078..398070040 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -668,14 +668,14 @@ def set_gecko_property(ffi_name, expr): SVGPaintKind::Color(color) => { paint.mType...
6
31
85
64ab29713b0b52ff508b04161ed53e78d2c37f49
Dan Glastonbury
2018-06-27T07:07:37
Bug 1467622 - P1: nsStyleSVGPaint - Change nscolor to StyleComplexColor. r=xidorn MozReview-Commit-ID: 1bbQzOoOuBe
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 398070040..ad6e0a078 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -668,14 +668,14 @@ def set_gecko_property(ffi_name, expr): SVGPaintKind::Color(color) => { paint.mType...
4
15
13
62012291b7fc1873a63bb1db365792f3db3b04c8
Xidorn Quan
2018-07-11T00:54:47
Bug 1461285 part 3 - Have the CSSOM appending behavior behind a pref and only enable it on Nightly. r=emilio MozReview-Commit-ID: 6BzPTNjXjyA
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 0d5ba5189..29277eef1 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -47,8 +47,12 @@ pub enum DeclarationPushMode { /// importance, the new declaration will be discarde...
1
55
12
594ca886ff82faea152e79f5e2b299563839642a
Xidorn Quan
2018-07-11T00:52:52
Bug 1461285 part 2 - Add a declaration iterator to AllShorthand for simplify code. r=emilio MozReview-Commit-ID: 9w2B3SpdkQo
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 92fa0bc41..0d5ba5189 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -455,34 +455,9 @@ impl PropertyDeclarationBlock { mode, ); } - ...
2
47
28
2b993b606d10a0af8ed6d2668c13b7d29f9049d1
Xidorn Quan
2018-07-09T06:03:32
Bug 1461285 part 1 - Rename DeclarationSource to DeclarationPushMode. r=emilio MozReview-Commit-ID: Iyv9JrXrpzl
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 8727ba4cc..92fa0bc41 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -39,13 +39,17 @@ impl AnimationRules { } } -/// Whether a given declaration comes from CSS parsi...
2
22
24
55843616dd4041cc324843ef92eb7add9af314e4
Boris Chiou
2018-07-05T22:41:23
Bug 1467277 - Avoid getting zero normalized vector of rotate3d for animations. r=hiro If we have a rotate axis whose length is extremely large, we will get an infinite value, and its normalized vector is a zero vector, instead of an unit vector, i.e. (x/inf, y/inf, z/inf) == (0, 0, 0). The solution is: we scale the ve...
diff --git a/style/values/generics/transform.rs b/style/values/generics/transform.rs index cd321945f..a0cbc57d6 100644 --- a/style/values/generics/transform.rs +++ b/style/values/generics/transform.rs @@ -569,7 +569,7 @@ pub fn get_normalized_vector_and_angle<T: Zero>( // rotation to not be applied, so we use ...
1
1
1
1488ee575b34a0f82c8e6e38b634ac9cabc1753d
Boris Chiou
2018-07-09T19:10:50
Bug 1467277 - Bump euclid to 0.18 for style, style_traits, malloc_size_of, and tests. r=emilio In order to drop old euclid version, we still need to bump euclid for plane-split and gfx/*. However, it needs more update and is not related to this bug, so let's do that in other place. Here, we bump euclid to 0.18.1, and ...
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 677184093..a75ad1812 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -25,7 +25,7 @@ servo = [ [dependencies] app_units = "0.6" cssparser = "0.24.0" -euclid = "0.17" +euclid = "0.18" hashglobe = { path = "../hashglobe"...
4
3
4
cbbd9041cae609659a134f0b75b6d8a7b75c4d54
Oriol Brufau
2018-07-05T10:56:34
Bug 1472567 - Honor logical border colors in visited links r=emilio MozReview-Commit-ID: IF8yvkFmPc4
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index f7a811671..e2431925c 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -3768,14 +3768,6 @@ where PropertyDeclarationId::Custom(..) => continue, }; - ...
1
8
8
585be4b7b275c422526be6ce785178e43ef90a04
Emilio Cobos Álvarez
2018-07-07T23:27:12
No bug - Trivial indentation fix. r=me MozReview-Commit-ID: JqBxF7i0HQZ
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index 63e7cc877..f7a811671 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -1490,7 +1490,7 @@ impl UnparsedValue { PropertyDeclaration::CSSWideKeyword(WideKeywordDeclaration ...
1
1
1