commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
4b14f6bdcc7ea61d109b84732671ade4056ecb05 | Emilio Cobos Álvarez | 2018-07-06T01:44:28 | Bug 1473779: Make writing-mode and direction non-animatable. r=heycam
Per https://github.com/w3c/csswg-drafts/issues/2751
MozReview-Commit-ID: GCG3vJWNPfC | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index 1bbfeabba..efb3ec19c 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -26,7 +26,7 @@ ${helpers.single_keyword(
... | 1 | 5 | 2 |
92dba6b3de765f3b74865fa4c1f5411d1f109d20 | Emilio Cobos Álvarez | 2018-07-06T01:41:56 | Bug 1473779: Reformat most of inherited_box.mako.rs. r=heycam
image-orientation is being changed as we speak, so I left it there to avoid
bitrot.
MozReview-Commit-ID: IwpA5HEuVU | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index 23dfe7fef..1bbfeabba 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -7,57 +7,71 @@
<% data.new_style_struct("InheritedBox", inh... | 1 | 52 | 38 |
176d34b93cdf0798e8fda53d6a7c59126d4049ea | Emilio Cobos Álvarez | 2018-07-06T03:13:28 | Bug 1473793: Other minor properties.mako.rs cleanups and improvements. r=heycam
Also, add an is_logical method, which we'll use in a bit.
MozReview-Commit-ID: Hq63wgbiRRu | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 11b7f8b08..63e7cc877 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -946,25 +946,17 @@ impl LonghandId {
}
/// Returns whether this property is animatable.
+ #[inlin... | 1 | 28 | 31 |
8d40c99acba586c2bcfb2df938a03601f4eab88d | Emilio Cobos Álvarez | 2018-07-06T03:08:03 | Bug 1473793: Add a clone helper that works regardless of whether the property is logical. r=heycam
MozReview-Commit-ID: 74jdo8vPOAc | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 7a34cc4ad..d4a96e1f1 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -207,8 +207,8 @@ impl AnimatedProperty {
... | 2 | 21 | 17 |
ed565186e12abf88601122c2c7ccd6b44d74c9f2 | Emilio Cobos Álvarez | 2018-07-06T03:05:57 | Bug 1473793: Remove dead code. r=heycam
MozReview-Commit-ID: Ifx8tjAJSAM | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 53d0baf9a..c82288e14 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -49,8 +49,7 @@ use gecko::values::round_border_to_device_pixels;
use logical_geometry::WritingMode;
use media_queries::Device;
us... | 1 | 2 | 27 |
75fff82e265c478cc46ef39f9becf913ba01db0b | Brindusan Cristian | 2018-07-06T07:24:30 | Backed out 3 changesets (bug 1473793) for build bustages. CLOSED TREE
Backed out changeset c18adbadea5a (bug 1473793)
Backed out changeset a9501d2a9632 (bug 1473793)
Backed out changeset b5834f9aff57 (bug 1473793) | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index c82288e14..53d0baf9a 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -49,7 +49,8 @@ use gecko::values::round_border_to_device_pixels;
use logical_geometry::WritingMode;
use media_queries::Device;
us... | 3 | 74 | 50 |
ff7e45fbea3ed2c3881e751aec00b853e46cf2ff | Emilio Cobos Álvarez | 2018-07-06T03:08:03 | Bug 1473793: Add a clone helper that works regardless of whether the property is logical. r=heycam
MozReview-Commit-ID: 74jdo8vPOAc | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 7a34cc4ad..c8190e402 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -207,8 +207,8 @@ impl AnimatedProperty {
... | 2 | 20 | 16 |
587fd27e8d71e3cb0477baa722de7dbe582c8aa5 | Bobby Holley | 2018-07-03T23:47:48 | Bug 1431285 - Cap the number of style threads at six. r=emilio
MozReview-Commit-ID: 3qI1mIvDn8j
Differential Revision: https://phabricator.services.mozilla.com/D1928 | diff --git a/style/gecko/global_style_data.rs b/style/gecko/global_style_data.rs
index f1cb107df..6671de986 100644
--- a/style/gecko/global_style_data.rs
+++ b/style/gecko/global_style_data.rs
@@ -65,7 +65,12 @@ lazy_static! {
.map(|s| s.parse::<usize>().expect("invalid STYLO_THREADS value"));
let... | 1 | 6 | 1 |
809c0202a4dd30a3d55639e56932a5b57f15cf98 | Emilio Cobos Álvarez | 2018-07-01T23:06:17 | Bug 1472552 - Reformat font.mako.rs. r=xidorn
To be consistent, use the block indentation the rest of the Rust code uses.
Differential Revision: https://phabricator.services.mozilla.com/D1906 | diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs
index 69f95532c..e14d16e0c 100644
--- a/style/properties/longhands/font.mako.rs
+++ b/style/properties/longhands/font.mako.rs
@@ -7,13 +7,15 @@
<% data.new_style_struct("Font", inherited=True) %>
-${helpers.predefined_ty... | 1 | 276 | 226 |
6cecf361be6cdecde12f4094683f96035d745f1b | Emilio Cobos Álvarez | 2018-07-01T12:29:44 | Bug 1472538: Update bindgen. r=xidorn
Surprisingly painless.
I'll update to 0.37.4 instead of .3, but that only contains
https://github.com/rust-lang-nursery/rust-bindgen/pull/1343 on top to prevent
build warnings.
MozReview-Commit-ID: H0uMtdGnXvL | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 4e524604a..0fab04df4 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ kernel32-sys = "0.2"
[build-dependencies]
lazy_static = "1"
log = "0.4"
-bindgen = { version = "0.33.2", optional = true, default-features = false }
+bindgen = { version ... | 1 | 1 | 1 |
c5188575b708ffd85a1d4415fef91028f201db73 | Emilio Cobos Álvarez | 2018-06-30T23:01:46 | No bug - Appease Servo's tidy lint.
MozReview-Commit-ID: 3PxU77BJFEB | diff --git a/style/element_state.rs b/style/element_state.rs
index c57cf4feb..1652dee67 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -71,7 +71,7 @@ bitflags! {
const IN_OPTIONAL_STATE = 1 << 22;
/// <https://html.spec.whatwg.org/multipage/#selector-read-write>
const IN_... | 2 | 4 | 5 |
c134efb32edcc912788455a9b3a78bb4f49316b7 | Emilio Cobos Álvarez | 2018-06-30T22:48:03 | No bug - Fix servo build.
MozReview-Commit-ID: EEuyLgAv8LR | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index b4c7c4232..eaec2cb20 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -807,8 +807,6 @@ malloc_size_of_is_0!(webrender_api::NormalBorder);
#[cfg(feature = "webrender_api")]
malloc_size_of_is_0!(webrender_api::RepeatMode);
#[cfg(feature ... | 2 | 1 | 3 |
10058cf6779f273f4c5fc218e6528cb8569cbfa2 | Emilio Cobos Álvarez | 2018-06-30T15:19:50 | No bug - Remove stray newline. r=me
MozReview-Commit-ID: 4oTHDBjMJHp | diff --git a/style/values/generics/counters.rs b/style/values/generics/counters.rs
index 66da2625f..779d56d65 100644
--- a/style/values/generics/counters.rs
+++ b/style/values/generics/counters.rs
@@ -122,7 +122,6 @@ impl<ImageUrl> Content<ImageUrl> {
pub fn normal() -> Self {
Content::Normal
}
-
}
... | 1 | 0 | 1 |
e8e6560aa0a830c5cc45d7980e70839d4ccf92d8 | Emilio Cobos Álvarez | 2018-06-30T13:16:31 | Bug 1472443: Serialize content properties using Servo. r=xidorn
... and cleanup unused keywords / getters using the scripts in
layout/style/tools
Differential Revision: https://phabricator.services.mozilla.com/D1901
MozReview-Commit-ID: BRUGcje7X0q | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 19a5fb99e..53d0baf9a 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -5643,7 +5643,7 @@ clip-path
use values::specified::Attr;
if self.gecko.mContents.is_empty() {
- retu... | 1 | 1 | 1 |
a8631e4318ec87001bcf09fbdcbb09620c5ace5f | Emilio Cobos Álvarez | 2018-06-30T13:05:15 | Bug 1472443: Make StyleContentType an enum class. r=xidorn
Most of it is automated by:
%s/eStyleContentType_/StyleContentType::/g
%s/nsStyleContentType/StyleContentType/g
But I removed some parentheses by hand.
Differential Revision: https://phabricator.services.mozilla.com/D1900
MozReview-Commit-ID: 3IcirjIYX... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index f83e0836c..19a5fb99e 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -5489,8 +5489,7 @@ clip-path
use values::generics::CounterStyleOrNone;
use gecko_bindings::structs::nsStyleContent... | 1 | 25 | 26 |
11a0a78946bac99aa1ad884b626b35f82366ebe6 | Emilio Cobos Álvarez | 2018-06-30T13:45:43 | Bug 1116638: Expose logical props in computed style. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D1862 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index d49eabefe..3e51c1a6c 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -410,6 +410,7 @@ pub struct NonCustomPropertyId(usize);
impl NonCustomPropertyId {
#[cfg(feature = "geck... | 1 | 4 | 0 |
e5b69a3872cf53725b3bd8583098c6315d4513b9 | Olli Pettay | 2018-06-29T22:30:37 | Bug 1419661, if ExtendedDOMSlots are used before slots, use FatSlots to have fewer allocations, r=mrbkap | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 47205f737..ee0c134b2 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -651,7 +651,10 @@ impl<'le> GeckoElement<'le> {
#[inline]
fn extended_slots(&self) -> Option<&structs::FragmentOrElement_nsExtendedDOMSlots> {
se... | 1 | 4 | 1 |
2d7c41ce224e198d0bae36464809543ec96de528 | Gerald Squelart | 2018-06-28T04:51:38 | Bug 1459524 - Removed layout.css.all-shorthand.enabled pref - r=heycam
The 'all' shorthand has shipped a long time ago, so this pref is not needed
anymore.
MozReview-Commit-ID: GND8qSVAfCG | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 5ba361961..d49eabefe 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -178,7 +178,6 @@ pub mod shorthands {
data.declare_shorthand(
"all",
logical_... | 1 | 0 | 1 |
7427ac6642dc2571195c938ede86706744322c61 | Emilio Cobos Álvarez | 2018-06-28T10:58:06 | Bug 1454165 - Make :host() and ::slotted() account for the inner selector's specificity. r=xidorn
As resolved in https://github.com/w3c/csswg-drafts/issues/1915.
Differential Revision: https://phabricator.services.mozilla.com/D1849 | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 0be3eb90e..29ac822fa 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -23,7 +23,7 @@ use sink::Push;
use smallvec::{self, SmallVec};
use std::cmp;
use std::iter;
-use std::ops::Add;
+use std::ops::{AddAssign, Add};
use std::ptr;
use std:... | 1 | 37 | 12 |
05c92fbad7cb77da5cf017cd974890f69814bbbc | Olli Pettay | 2018-06-28T12:58:11 | Bug 1471871 - Unconditionally enable :defined in chrome (but not unconditionally enabled for querySelector), r=emilio | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index 56e62b6de..04f57b738 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -47,7 +47,7 @@ macro_rules! apply_non_ts_list {
("visited", Visited, visited, I... | 1 | 1 | 1 |
02e8863a4522ebd79860dba1e819ca3f6d51faf0 | Olli Pettay | 2018-06-28T11:55:45 | Bug 1331334 - Implement :defined pseudo-class for custom elements, r=emilio | diff --git a/style/element_state.rs b/style/element_state.rs
index 0960ca3d4..c57cf4feb 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -71,7 +71,8 @@ bitflags! {
const IN_OPTIONAL_STATE = 1 << 22;
/// <https://html.spec.whatwg.org/multipage/#selector-read-write>
const IN_... | 4 | 7 | 1 |
77fdead9b7a32576e94597d27e73c2ff5a9e5232 | Emilio Cobos Álvarez | 2018-06-27T09:22:21 | Bug 1464782: Put offset-* aliases behind a pref. r=xidorn
MozReview-Commit-ID: Hl6Muim3wVH | diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs
index d7e4e27a3..3b34047fc 100644
--- a/style/properties/longhands/position.mako.rs
+++ b/style/properties/longhands/position.mako.rs
@@ -29,7 +29,7 @@
"computed::LengthOrPercentageOrAuto::Auto",
spe... | 1 | 1 | 1 |
b3f0991847b158b65ef938cbac0aafc02a5abadb | Emilio Cobos Álvarez | 2018-06-26T18:37:00 | Bug 1464782: Rename offset-* logical properties to inset-*. r=xidorn
MozReview-Commit-ID: BW44sru99RF | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 11a1283f1..e07c9bd57 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -856,7 +856,7 @@
elif len(maybe_size) == 1:
size = maybe_size[0]
def phys_ident(side, phy_sid... | 2 | 5 | 4 |
3559da1787363240659d8403dfbbdf2ceaffa28f | Xidorn Quan | 2018-06-27T05:34:29 | Bug 1471114 part 2 - Generate ComputedStyleMap entry list from property data. r=emilio
This changes the order of properties returned from gCS. The old order
doesn't make much sense, and other browsers don't agree on an identical
order either, so it should be trivial to change it. Also the spec isn't
super clear / usef... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index b27527d01..5ba361961 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -836,6 +836,8 @@ bitflags! {
* they can be checked in the C++ side via ServoCSSPropList.h. */
... | 6 | 8 | 0 |
cb45f956420e8615555bda451a624aa80ba55d07 | Xidorn Quan | 2018-06-27T05:28:22 | Bug 1471486 part 2 - Use RUSTFMT env in stylo build script. r=emilio
MozReview-Commit-ID: JOg0xkmG5Yx | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 95bb16229..68d160ab5 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -182,14 +182,21 @@ mod bindings {
// Disable rust unions, because we replace some types inside of
// them.
let mut builder = Builder:... | 1 | 14 | 7 |
ffd57aabf9858d19fd103f0a27d38eb62c5104d2 | Xidorn Quan | 2018-06-27T00:43:21 | Bug 1471104 followup - Upgrade cssparser and revendor.
MozReview-Commit-ID: 74rBgkJEcYd | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index 92376a6cd..677184093 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -24,7 +24,7 @@ servo = [
[dependencies]
app_units = "0.6"
-cssparser = "0.23.0"
+cssparser = "0.24.0"
euclid = "0.17"
hashglobe = { path = "../has... | 4 | 4 | 4 |
7e71d6ec1510f407b708749cd96731ad035e96f2 | Xidorn Quan | 2018-06-27T00:42:51 | Bug 1471104 - Remove location from preludes and take it from argument. r=emilio
MozReview-Commit-ID: HeJUQvkacaf | diff --git a/style/stylesheets/font_feature_values_rule.rs b/style/stylesheets/font_feature_values_rule.rs
index 8ce16e2cc..c70a46c1c 100644
--- a/style/stylesheets/font_feature_values_rule.rs
+++ b/style/stylesheets/font_feature_values_rule.rs
@@ -428,6 +428,7 @@ macro_rules! font_feature_values_blocks {
... | 3 | 75 | 84 |
04064266d2cf08e56634dd810a68e4fd0b97227f | Emilio Cobos Álvarez | 2018-06-25T22:33:39 | Bug 1471063: Simplify selector serialization. r=xidorn
MozReview-Commit-ID: 959U7yd5W9j | diff --git a/selectors/parser.rs b/selectors/parser.rs
index ac5390451..399f21e63 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -995,8 +995,7 @@ impl<Impl: SelectorImpl> ToCss for Selector<Impl> {
let mut combinators = self.iter_raw_match_order()
.rev()
- .filter(|x| x... | 1 | 7 | 7 |
2f3539368f48bf1bd78a693f8373f1a82ab0a63e | Emilio Cobos Álvarez | 2018-06-25T22:30:52 | Bug 1471063: Deindent the serialization loop. r=xidorn
MozReview-Commit-ID: GPlUAx7YXVb | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 3210f1085..ac5390451 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -1007,72 +1007,73 @@ impl<Impl: SelectorImpl> ToCss for Selector<Impl> {
debug_assert!(!combinators_exhausted);
// https://drafts.csswg.org/cssom/#s... | 1 | 62 | 61 |
12d2ab08c9b2d78d7c5cd29d674e347f544256ee | Emilio Cobos Álvarez | 2018-06-25T22:25:58 | Bug 1471063: Remove unneeded combinator check in selector-matching. r=xidorn
The combinator doesn't change during the loop, no need to check it.
MozReview-Commit-ID: KIAt0WiEOtI | diff --git a/selectors/matching.rs b/selectors/matching.rs
index c3591ff27..7c4812cb9 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -576,7 +576,7 @@ where
_ => {},
}
- if element.is_link() || combinator.is_sibling() {
+ if element.is_link() {
visite... | 1 | 1 | 1 |
d96c45ab55c73dc32850a53c2ecb2ef7fc33565c | Hiroyuki Ikezoe | 2018-06-26T02:08:24 | Bug 1418806 - Try to allocate possible size for AnimationValueMap before composing. r=birtles
The EffectSet count does not exactly represent the count what we really need
for AnimationValueMap, but in most cases it matches. For example;
1) The element has two different keyframes animations
@keyframes anim1 {
to... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 0ce4a45d1..ffac86e97 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -37,6 +37,7 @@ use gecko_bindings::bindings::Gecko_ElementHasAnimations;
use gecko_bindings::bindings::Gecko_ElementHasCSSAnimations;
use gecko_bindings::bindings... | 1 | 10 | 1 |
df170c284db67e8be46d53b46b82d3f22ac748e7 | Hiroyuki Ikezoe | 2018-06-25T23:51:13 | Bug 1418806 - Introduce a constant variable to represents the number of all animatable longhands. r=xidorn
We will use this number to cap the pre-allocation AnimationValueMap in the next
patch.
MozReview-Commit-ID: Iqq9plbD8Vl | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index b6a8879e1..b27527d01 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -100,6 +100,7 @@ pub mod longhands {
% for style_struct in data.style_structs:
include!("${repr(os.pat... | 1 | 1 | 0 |
89369d413982a44042c28a6c58db5d5543038075 | Emilio Cobos Álvarez | 2018-06-21T17:35:35 | Bug 1422225: Error reporting fixes. r=xidorn
Do it so that we always try to evaluate the media expression and the modern
syntax last, so that the most specific error message comes up.
MozReview-Commit-ID: 2tqdAsWh6Kh | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index a6322842f..9c5ef4d71 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -7,7 +7,7 @@
use app_units::AU_PER_PX;
use app_units::Au;
use context::QuirksMode;
-use cssparser::{BasicParseErrorKind, Parser, RGBA, To... | 4 | 29 | 57 |
7c6094f8e57620d5e7368b02835d090eaab85146 | Emilio Cobos Álvarez | 2018-06-16T07:59:04 | Bug 1422225: Evaluate MediaConditions, and glue it all together. r=xidorn
MozReview-Commit-ID: 3MThE2FvfDf | diff --git a/style/media_queries/media_condition.rs b/style/media_queries/media_condition.rs
index 091d70495..c2c29c129 100644
--- a/style/media_queries/media_condition.rs
+++ b/style/media_queries/media_condition.rs
@@ -7,11 +7,12 @@
//! https://drafts.csswg.org/mediaqueries-4/#typedef-media-condition
use cssparse... | 4 | 96 | 58 |
59fd1e9a299840864ed47cf3525db7e3d03031cc | Emilio Cobos Álvarez | 2018-06-16T06:58:20 | Bug 1422225: Add serialization code for MediaCondition. r=xidorn
MozReview-Commit-ID: AxQQottV1hG | diff --git a/style/media_queries/media_condition.rs b/style/media_queries/media_condition.rs
index cb3bd73ee..091d70495 100644
--- a/style/media_queries/media_condition.rs
+++ b/style/media_queries/media_condition.rs
@@ -8,7 +8,8 @@
use cssparser::{Parser, Token};
use parser::ParserContext;
-use style_traits::Parse... | 1 | 35 | 1 |
3032ecc96808ec975c963c3b35f833ec311ecdb4 | Emilio Cobos Álvarez | 2018-06-16T06:51:07 | Bug 1422225: Add code to parse media conditions. r=xidorn
Still unused.
MozReview-Commit-ID: IQfxObw9BV5 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 02fc864eb..a6322842f 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -651,141 +651,150 @@ impl MediaFeatureExpression {
})?;
input.parse_nested_block(|input| {
- // FIXME: remove... | 4 | 259 | 130 |
a41abdc11b230b97f42aee71591073d8204a96f6 | Emilio Cobos Álvarez | 2018-06-16T04:29:57 | Bug 1422225: Rename Expression to MediaFeatureExpression. r=xidorn
Which is more appropriate, given it represents a `<media-feature>` per spec, and
expression is a bit overloaded :)
MozReview-Commit-ID: Fed1nJhHxDu | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index fd07595f4..02fc864eb 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -292,16 +292,16 @@ enum RangeOrOperator {
Operator(Operator),
}
-/// A expression for gecko contains a reference to the media featur... | 5 | 31 | 32 |
cdc884c61cf093cbf66ee5fa861b812df8ba865e | Emilio Cobos Álvarez | 2018-06-16T04:23:50 | Bug 1422225: Allow parsing operators in media feature expressions. r=xidorn
The only bit from the spec which I haven't implemented to my knowledge is the
bit that allows you to swap the position of the media feature and the value,
because it unnecessarily complicates parsing (we parse the value in terms of the
feature... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 771f4570b..fd07595f4 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -7,7 +7,7 @@
use app_units::AU_PER_PX;
use app_units::Au;
use context::QuirksMode;
-use cssparser::{BasicParseErrorKind, Parser, RGBA};
+... | 1 | 173 | 35 |
fd0734f6b836e3a365eceafb8d186fea0ffda4a2 | Emilio Cobos Álvarez | 2018-06-24T02:06:49 | Bug 1374017: Add namespace bucket for the selector map. r=heycam
After bug 1470163 we have some nasty selectors from mathml.css in every page.
We only want to match them against MathML elements.
This patch brings the global revalidation selectors from 14 to 2 in about:blank.
Also halves the ones from XUL documents.
... | diff --git a/style/selector_map.rs b/style/selector_map.rs
index 3b9b6f201..3b0dcca95 100644
--- a/style/selector_map.rs
+++ b/style/selector_map.rs
@@ -5,7 +5,7 @@
//! A data structure to efficiently index structs containing selectors by local
//! name, ids and hash.
-use {Atom, LocalName, WeakAtom};
+use {Atom, L... | 1 | 42 | 9 |
fc273aa30f3149f97a59f41dcab4f5d0dd6c8001 | Emilio Cobos Álvarez | 2018-06-23T17:57:44 | No bug - Fix servo build. r=me
MozReview-Commit-ID: 5irg82k3o6m | diff --git a/style/encoding_support.rs b/style/encoding_support.rs
index eadcfa4c1..7aec18bee 100644
--- a/style/encoding_support.rs
+++ b/style/encoding_support.rs
@@ -55,7 +55,7 @@ impl Stylesheet {
///
/// Takes care of decoding the network bytes and forwards the resulting
/// string to `Stylesheet::f... | 2 | 7 | 12 |
ec4b2c853f5edb33c472a29be91bcee38aac6554 | Emilio Cobos Álvarez | 2018-06-21T13:19:48 | Bug 1470145: Better debugging for media-query related code and ua-cache. r=xidorn
MozReview-Commit-ID: 3XHAxK2BOTS | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 1c34762f2..771f4570b 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -64,6 +64,27 @@ pub struct Device {
used_viewport_size: AtomicBool,
}
+impl fmt::Debug for Device {
+ fn fmt(&self, f: &mut fmt::... | 4 | 49 | 11 |
a2270484d96851e243c5346af15c4c30ead4fa8a | Emilio Cobos Álvarez | 2018-06-21T11:09:35 | Bug 1470145: Better debugging for stylesheets and URLs. r=xidorn
MozReview-Commit-ID: FIcz2K1ZYX0 | diff --git a/style/error_reporting.rs b/style/error_reporting.rs
index af1e7ba5b..b5d5ba17e 100644
--- a/style/error_reporting.rs
+++ b/style/error_reporting.rs
@@ -7,7 +7,6 @@
#![deny(missing_docs)]
use cssparser::{BasicParseErrorKind, ParseErrorKind, SourceLocation, Token};
-use log;
use std::fmt;
use style_tra... | 6 | 62 | 27 |
18473c2bc13036fa4c0b1d5258ee2873645e269e | Nicholas Nethercote | 2018-06-21T23:38:42 | Bug 1447951 - Store nsDynamicAtom's chars after the end of the object. r=froydnj
This reduces memory usage because we only need one allocation instead of two
for the dynamic atom and its chars, and because we don't need to store a
refcount and a size. It precludes sharing of chars between dynamic atoms, but
we weren't... | diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs
index 297599e20..b0c875026 100644
--- a/style/gecko_string_cache/mod.rs
+++ b/style/gecko_string_cache/mod.rs
@@ -122,7 +122,8 @@ impl WeakAtom {
unsafe { u8_ptr.offset(string_offset) as *const u16 }
} else {
... | 1 | 2 | 1 |
bd7bb86230fe34b90d4177b248e19c07e44cf4df | Emilio Cobos Álvarez | 2018-06-21T10:31:10 | Bug 1470105: Fix a typo in stylesheet cloning. r=jwatt
Summary: Just something I noticed while writing unrelated code.
Reviewers: jwatt
Bug #: 1470105
Differential Revision: https://phabricator.services.mozilla.com/D1747
MozReview-Commit-ID: 7KMTT9Kmdwc | diff --git a/style/stylesheets/stylesheet.rs b/style/stylesheets/stylesheet.rs
index 5312826bd..131466b52 100644
--- a/style/stylesheets/stylesheet.rs
+++ b/style/stylesheets/stylesheet.rs
@@ -137,7 +137,7 @@ impl DeepCloneWithLock for StylesheetContents {
url_data: RwLock::new((*self.url_data.read()).clon... | 1 | 1 | 1 |
b7140b0d1408a33997f0c06d8e809d3d6a8c979b | Emilio Cobos Álvarez | 2018-06-20T19:07:45 | Bug 1469957: Move the error reporter into ParserContext. r=xidorn
Summary:
This should make it easier to report errors, and also reduce codesize.
The reason this was so generic is that error reporting was unconditionally
enabled and was super-hot, but now that's no longer the case after bug 1452143,
so we can afford ... | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index 94b10aa0d..2542dee36 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -9,8 +9,8 @@
use Atom;
use cssparser::{AtRuleParser, DeclarationListParser, DeclarationParser};
use cssparser::{CowRcStr, Parser, SourceLocation,... | 13 | 128 | 194 |
6216621db90c187a09d60fd7a70d093855606961 | Emilio Cobos Álvarez | 2018-05-23T18:11:22 | No bug - Remove some cfgs. r=me
DONTBUILD, since this is not part of the build.
MozReview-Commit-ID: 90UkG6QJWq | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 4b53c9723..cd89a4bbf 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -24,7 +24,7 @@ use style_traits::{CssWriter, ParseError, ParsingMode, StyleParseErrorKind, ToCs
use sty... | 2 | 3 | 5 |
2321c6db1dc586acc38544be2d99e4a24ab0ab7a | Emilio Cobos Álvarez | 2018-06-20T10:09:55 | Bug 1468651: followup: Fix windows build bustage. r=me CLOSED TREE
MozReview-Commit-ID: 9Xj5lMFG4Ab | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index ece5956b2..2ed1a4498 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -98,7 +98,7 @@ macro_rules! expanded {
#[allow(missing_docs)]
pub mod longhands {
% for style_struct in d... | 1 | 2 | 2 |
3da1a448731afa398a935eefdd7582ffa11bd856 | Emilio Cobos Álvarez | 2018-06-19T11:07:00 | Bug 1468651: Rename mask.mako.rs to svg.mako.rs for consistency. r=heycam
MozReview-Commit-ID: 6sqGxL8hhA0 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index a3d4787ab..a2ac0603a 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -171,7 +171,7 @@ pub mod shorthands {
<%include file="/shorthands/inherited_text.mako.rs" />
<%include... | 2 | 1 | 1 |
17197591f22cfe295fad7fb4ae781390586ec3e1 | Emilio Cobos Álvarez | 2018-06-19T11:05:25 | Bug 1468651: Rename the properties directories from "shorthand" to "shorthands", "longhand" to "longhands". r=heycam
MozReview-Commit-ID: CY4THCC4zkX | diff --git a/style/properties/longhand/background.mako.rs b/style/properties/longhands/background.mako.rs
similarity index 100%
rename from style/properties/longhand/background.mako.rs
rename to style/properties/longhands/background.mako.rs
diff --git a/style/properties/longhand/border.mako.rs b/style/properties/longha... | 38 | 37 | 37 |
bc8415b2df57aca9e0b53159deb7b81dc3202450 | Emilio Cobos Álvarez | 2018-06-13T22:31:05 | Bug 1468651: remove shorthand/serialize.mako.rs. r=heycam
MozReview-Commit-ID: 8Xyep2Q7trR | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 4d18e0ca6..e74fc888e 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -137,7 +137,32 @@ pub mod shorthands {
use style_traits::{ParseError, StyleParseErrorKind};
use values... | 2 | 26 | 28 |
0ef53dfb3c34c4f9a22265af4ccc774eaaacb4d3 | Emilio Cobos Álvarez | 2018-06-16T09:50:28 | Bug 1469076: Fix the broken invariants of the rule node cache. r=heycam
We were spuriously reframing the <shadow> because it initially shared style with
the <br>, which ended up being display: none, while the <shadow> should've been
display: contents from the beginning.
lookup_by_rules seems pretty prone to obscure b... | diff --git a/style/sharing/mod.rs b/style/sharing/mod.rs
index 314e98770..d6148d16b 100644
--- a/style/sharing/mod.rs
+++ b/style/sharing/mod.rs
@@ -815,7 +815,11 @@ impl<E: TElement> StyleSharingCache<E> {
Some(candidate.element.borrow_data().unwrap().share_styles())
}
- /// Attempts to find an elem... | 2 | 23 | 2 |
d44db45d9e7f89a8ec450aeb8e2c9fad9e334472 | Emilio Cobos Álvarez | 2018-06-18T10:30:24 | Bug 1468665: Don't call the before change closure with the locked declaration block. r=xidorn
Test Plan: No behavior change.
Reviewers: xidorn
Bug #: 1468665
Differential Revision: https://phabricator.services.mozilla.com/D1681
MozReview-Commit-ID: JI18xI6aHCh | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 4e368c0c2..4b53c9723 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -564,51 +564,71 @@ impl PropertyDeclarationBlock {
true
}
- /// <https://drafts.csswg... | 1 | 56 | 38 |
97fa7c5d2961466bb1091a918c97227bdabf8087 | Dan Glastonbury | 2018-06-19T04:18:33 | Bug 1467621 - P1: nsCSSShadowItem - Change nscolor to StyleComplexColor. r=xidorn
MozReview-Commit-ID: moE2CI7fT8 | diff --git a/style/gecko_bindings/sugar/ns_css_shadow_item.rs b/style/gecko_bindings/sugar/ns_css_shadow_item.rs
index 8bdf38d4f..dfd819bce 100644
--- a/style/gecko_bindings/sugar/ns_css_shadow_item.rs
+++ b/style/gecko_bindings/sugar/ns_css_shadow_item.rs
@@ -5,9 +5,7 @@
//! Rust helpers for Gecko's `nsCSSShadowItem`... | 5 | 27 | 42 |
b947a63919096ecf205715ea490984f659f441b3 | Emilio Cobos Álvarez | 2018-06-18T17:34:14 | No bug - Appease Servo's tidy check. r=me
MozReview-Commit-ID: 1vFNTQmNpCf | diff --git a/style/media_queries/media_list.rs b/style/media_queries/media_list.rs
index 89926815d..5243174e0 100644
--- a/style/media_queries/media_list.rs
+++ b/style/media_queries/media_list.rs
@@ -6,9 +6,9 @@
//!
//! https://drafts.csswg.org/mediaqueries/#typedef-media-query-list
+use context::QuirksMode;
use ... | 3 | 4 | 5 |
c013d7e80d02072d58d665a3a9b5d3789993e60f | Emilio Cobos Álvarez | 2018-06-18T08:54:35 | Bug 1469244: Remove stale servo/components/{servo,nonzero} directories. r=jwatt
Summary: Looks like I missed this in bug 1464834.
Test Plan: Not part of the build, so no tests.
Reviewers: jwatt
Subscribers: heycam, xidorn
Bug #: 1469244
Differential Revision: https://phabricator.services.mozilla.com/D1679
MozRev... | diff --git a/nonzero/Cargo.toml b/nonzero/Cargo.toml
deleted file mode 100644
index 15ba28f7e..000000000
--- a/nonzero/Cargo.toml
+++ /dev/null
@@ -1,15 +0,0 @@
-[package]
-name = "nonzero"
-version = "0.0.1"
-authors = ["The Servo Project Developers"]
-license = "MPL-2.0"
-publish = false
-
-[lib]
-path = "lib.rs"
-
-... | 4 | 0 | 811 |
14cb459229a039b8258f85c22d1b09e79d6cf9b1 | Emilio Cobos Álvarez | 2018-06-18T08:25:47 | Bug 1469228: Cherry-pick malloc_size_of_derive and style_derive changes from servo/servo#20690. r=me
MozReview-Commit-ID: 7mPuoWwjX2Z | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index 7db5fbc8f..92376a6cd 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -29,7 +29,7 @@ euclid = "0.17"
hashglobe = { path = "../hashglobe" }
hyper = { version = "0.10", optional = true }
hyper_serde = { version = "0.8", o... | 5 | 10 | 16 |
84318a7c0150fd415b18d6f68c10236c142254c1 | Jonathan Watt | 2018-05-25T17:44:17 | Bug 1429713 part 1 - Add a -webkit-appearance alias for -moz-appearance (behind a pref). r=emilio | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 898f7391d..aea51fed7 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -626,6 +626,7 @@ ${helpers.single_keyword("-moz-appearance",
gecko_ffi_name="m... | 1 | 1 | 0 |
4b1e22bc1b4586fa3c8fe22b9b54a14c2eafd901 | Emilio Cobos Álvarez | 2018-06-16T10:21:41 | Bug 1468640: Relax a bit an invalid assertion. r=me
We may end up looking at a non-flushed AuthorStyles object when looking at
whether attribute changes and such may affect style.
Check the styles are clean to preserve the assertion, since if that happens
before the first flush, we may not have updated the quirks_mod... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 5475be1e3..0ce4a45d1 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -178,11 +178,13 @@ impl<'lr> TShadowRoot for GeckoShadowRoot<'lr> {
as *const bindings::RawServoAuthorStyles)
};
+
let author_s... | 1 | 3 | 1 |
01adf13d3a7692e862f7c337afb01fc2b6029947 | Emilio Cobos Álvarez | 2018-06-14T21:35:10 | No bug - Minor indentation cleanup. r=me
MozReview-Commit-ID: 7MAVnsjXx63 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 833db60a0..883688cd1 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -118,8 +118,7 @@ impl Device {
/// Set the font size of the root element (for rem)
pub fn set_root_font_size(&self, size: Au) {
... | 1 | 1 | 2 |
93bcf0ee1ddab73e5042b8b50520c8140be82ae9 | Emilio Cobos Álvarez | 2018-06-14T20:54:07 | Bug 1468846: Move MediaQuery and friends to its own module. r=xidorn
MozReview-Commit-ID: 3FRMnIHFwR3 | diff --git a/style/media_queries/media_query.rs b/style/media_queries/media_query.rs
new file mode 100644
index 000000000..fa7b387cf
--- /dev/null
+++ b/style/media_queries/media_query.rs
@@ -0,0 +1,197 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL ... | 2 | 200 | 189 |
8a061067b9a0082bcc7a2dc12fad151217c6f6fd | Emilio Cobos Álvarez | 2018-06-14T20:38:47 | Bug 1468846: Qualifier::parse. r=xidorn
MozReview-Commit-ID: 4IOJpaS9ijI | diff --git a/style/media_queries/mod.rs b/style/media_queries/mod.rs
index e1db6ca40..eeb6b9500 100644
--- a/style/media_queries/mod.rs
+++ b/style/media_queries/mod.rs
@@ -24,7 +24,7 @@ pub use servo::media_queries::{Device, Expression};
pub use gecko::media_queries::{Device, Expression};
/// <https://drafts.csswg... | 1 | 2 | 15 |
cd79cbaa6bb3dd539dc1e183f0fc16b1512319aa | Emilio Cobos Álvarez | 2018-06-14T20:22:07 | Bug 1468846: Move MediaList to its own module. r=xidorn
And move the parsing from a free function to MediaList::parse.
MozReview-Commit-ID: 75ES6I2EEOE | diff --git a/style/media_queries/media_list.rs b/style/media_queries/media_list.rs
new file mode 100644
index 000000000..89926815d
--- /dev/null
+++ b/style/media_queries/media_list.rs
@@ -0,0 +1,143 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was... | 3 | 159 | 142 |
607961f7370230e409e2d5efc6de549e7fcd4d46 | Emilio Cobos Álvarez | 2018-06-14T20:03:59 | Bug 1468846: Move media_queries module to be a directory. r=xidorn
MozReview-Commit-ID: 7H93L6f0bAl | diff --git a/style/media_queries.rs b/style/media_queries/mod.rs
similarity index 100%
rename from style/media_queries.rs
rename to style/media_queries/mod.rs | 1 | 0 | 0 |
1b667d561a18addcfa1fc263c8b38cea023b40a2 | Emilio Cobos Álvarez | 2018-06-14T20:00:18 | Bug 1468846: Unify some #[derive]s between Servo and Gecko. r=xidorn
MozReview-Commit-ID: FqoNCuLcdm7 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 833db60a0..9dbfb5c8c 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -229,7 +229,7 @@ impl Device {
}
/// The kind of matching that should be performed on a media feature value.
-#[derive(Clone, Copy, Debu... | 3 | 10 | 14 |
be3675a0c1bfccd8aa407abaa4fca9a1ba42165a | Dan Glastonbury | 2018-06-07T05:55:26 | Bug 1467379 - P1: nsStyleGradientStop - Change nscolor to StyleComplexColor. r=xidorn
MozReview-Commit-ID: D9KQcv9uQ4S | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index bbc2776da..14fee693a 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -9,7 +9,7 @@
#![allow(unsafe_code)]
use app_units::Au;
-use gecko::values::{convert_rgba_to_nscolor, GeckoStyleCoordConvertible};
+use gecko::va... | 3 | 14 | 22 |
5413e984f4e8ddf8acb0b3c07e18b9e6fc7239d0 | Nazım Can Altınova | 2018-06-05T15:16:51 | Bug 1451289 - Part 9: Merge ServoDocumentRule and CSSMozDocumentRule r=emilio
MozReview-Commit-ID: BkMMXBWdsfz | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 3ef3d07da..7351cbfea 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -9,12 +9,12 @@
#![allow(non_snake_case, missing_docs)]
use gecko_bindings::bindings::RawServoCounterStyleRule;
-use gecko_bindings::bindings::RawServoDo... | 1 | 2 | 2 |
4c9bcac786cf5a30e15fa5eb62d7ec05cd9ab5ed | Hiroyuki Ikezoe | 2018-06-12T21:42:14 | Bug 1468294 - Double f64::EPSILON for calculation error. r=birtles
It's possible that both this_weight and other_weght have calculation errors
which are approximately equal to f64::EPSILON.
MozReview-Commit-ID: 8OddG9rI3qd | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index d935726eb..de0e48c78 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1739,7 +1739,9 @@ impl Animate for Quaterni... | 1 | 3 | 1 |
45d4d3feb30c5e04c53d45c69afb86fcb399b390 | Emilio Cobos Álvarez | 2018-06-11T23:54:27 | Bug 1468269: Derive Animate for ComplexColorRatios. r=kamidphish
It'd generate the same implementation.
MozReview-Commit-ID: Afpv0sjeWdj | diff --git a/style/values/animated/color.rs b/style/values/animated/color.rs
index 6a82896d6..1b01a8645 100644
--- a/style/values/animated/color.rs
+++ b/style/values/animated/color.rs
@@ -92,16 +92,6 @@ impl ComputeSquaredDistance for RGBA {
}
}
-impl Animate for ComplexColorRatios {
- #[inline]
- fn ani... | 2 | 1 | 11 |
523b010b1587d19038a0ed35f94967f90ebef9bb | Emilio Cobos Álvarez | 2018-06-11T23:29:49 | Bug 1468266: Fix servo build and tidy lints. r=me
MozReview-Commit-ID: G1iVniPvdJw | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index acdaebef2..d935726eb 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -31,10 +31,11 @@ use values::CSSFloat;
use ... | 4 | 26 | 23 |
4cbd39af3d5b92c756387dd3a8e9519ae45ea52e | Emilio Cobos Álvarez | 2018-06-11T23:44:40 | Bug 1468266: Import style changes from Servo PR #20935. r=me
MozReview-Commit-ID: EDVRsfTKZUB | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 88ad478f5..8a80fdfb6 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -32,7 +32,7 @@ bitflags = "1.0"
byteorder = "1.0"
cfg-if = "0.1.0"
cssparser = "0.23.0"
-debug_unreachable = "0.1.1"
+new_debug_unreachable = "1.0"
encoding_rs = {version = "0.7", opti... | 2 | 7 | 7 |
d6898ca28cd9991cd96f87bd200a88b5248945ae | Emilio Cobos Álvarez | 2018-06-09T23:08:43 | Bug 1416282: Add diagnostics. r=xidorn
MozReview-Commit-ID: GTnFyZnXR84 | diff --git a/selectors/builder.rs b/selectors/builder.rs
index f100166f4..0be3eb90e 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -36,6 +36,7 @@ use std::slice;
/// (from left to right). Once the process is complete, callers should invoke
/// build(), which transforms the contents of the SelectorBui... | 2 | 19 | 8 |
9769b00348f0d818a85bb50729b25f3586cf0326 | Emilio Cobos Álvarez | 2018-06-07T18:27:57 | Bug 1467536: Add a Servo API to get the serialized style of a property. r=xidorn
This is intended to be used by GetComputedStyle when there's no layout
dependency.
MozReview-Commit-ID: 3GAbjo1uQ34 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 4e52412c1..cdebe6622 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -22,8 +22,7 @@ use std::cell::RefCell;
use std::fmt::{self, Write};
use std::mem::{self, ManuallyDrop};
-#[c... | 1 | 66 | 27 |
4e76ca4d5adc962990cedbb63fe47dd70ff9e1ad | Emilio Cobos Álvarez | 2018-06-05T19:17:08 | Bug 1466963: Trivially simplify a condition. r=xidorn
MozReview-Commit-ID: L9LzpPt4js4 | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index e9d7f8cfd..4e368c0c2 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -517,15 +517,15 @@ impl PropertyDeclarationBlock {
continue;
}
-... | 1 | 8 | 8 |
050ca0c799a03e650c421d6f5339ba09d52cddb7 | Emilio Cobos Álvarez | 2018-06-05T19:13:48 | Bug 1466963: Add a before-change callback to remove_property. r=xidorn
MozReview-Commit-ID: 4vyN9iLT7e3 | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index c88458d0f..e9d7f8cfd 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -567,7 +567,14 @@ impl PropertyDeclarationBlock {
/// <https://drafts.csswg.org/cssom/#dom-cssstyle... | 1 | 25 | 13 |
f2002b68ec4eb5054dd0e9a50f67acea542578ca | Emilio Cobos Álvarez | 2018-06-05T19:13:04 | Bug 1466963: Remove unused PropertyDeclarationBlock::set_importance. r=xidorn
MozReview-Commit-ID: 1YrlOvktag9 | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index e192d08b2..c88458d0f 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -564,23 +564,6 @@ impl PropertyDeclarationBlock {
true
}
- /// Set the declaration im... | 1 | 0 | 17 |
e33e06622df68a4ff56ed74ea360a82fcb24b1f5 | Emilio Cobos Álvarez | 2018-06-05T18:11:04 | Bug 1466963: Fix a typo. r=xidorn
Nobody looks at the result from parsing, but this is the right thing to return.
MozReview-Commit-ID: 9P5VARiPIAk | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 3cdbf61de..e192d08b2 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -492,9 +492,9 @@ impl PropertyDeclarationBlock {
/// declaration with more importance, and will... | 1 | 3 | 3 |
28318d583716ddb1f203c5391ee487e8edd1b0ec | Emilio Cobos Álvarez | 2018-06-04T19:58:14 | Bug 1466963: Inline some trivial bits. r=xidorn
MozReview-Commit-ID: A219QehiMqZ | diff --git a/style/gecko_bindings/sugar/ns_compatibility.rs b/style/gecko_bindings/sugar/ns_compatibility.rs
index 3fe63391d..eaf97ca6f 100644
--- a/style/gecko_bindings/sugar/ns_compatibility.rs
+++ b/style/gecko_bindings/sugar/ns_compatibility.rs
@@ -8,6 +8,7 @@ use context::QuirksMode;
use gecko_bindings::structs::... | 2 | 4 | 0 |
a82452290b2b208434561785e09164e93c41f6b6 | Boris Zbarsky | 2018-06-06T15:34:30 | Bug 1467134. Use Atomic<bool> for the staticpref version of layout.css.font-variations.enabled. r=emilio
Atomic<bool> is implemented in terms of AtomicBase<uint32_t>, because that way
you don't need to depend on atomic 1-byte operations. That means that the rust
bindgen sees it as a u32, not a bool.
It's a bit con... | diff --git a/style/font_face.rs b/style/font_face.rs
index 5a111925a..57c0f3b0b 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -323,7 +323,7 @@ macro_rules! is_descriptor_enabled {
("font-variation-settings") => {
unsafe {
use gecko_bindings::structs::mozilla;
- mozill... | 1 | 1 | 1 |
7b23ee91206268cf1e7fa8b51e03347e13e75177 | Emilio Cobos Álvarez | 2018-06-04T18:57:49 | Bug 1466645: Remove PropertyId::name. r=xidorn
It's only used for the error path in property parsing, so most of the time is
not useful.
Use the just-introduced NonCustomPropertyId::name to preserve the alias name,
which we were doing by passing the name around.
MozReview-Commit-ID: 46xxZKCoeBB | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index a66058caf..3cdbf61de 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -1116,9 +1116,7 @@ where
let mut parser = Parser::new(&mut input);
let start_position = parser... | 5 | 47 | 42 |
04ad4043b5856776cb338955c2f867eec78a95ad | Emilio Cobos Álvarez | 2018-06-04T19:08:35 | Bug 1466645: Make getting a property name explicitly an indexing operation. r=xidorn
The six milliseconds spent in Olli's profile make me thing this is not getting
optimized and we expected.
Also move it to NonCustomPropertyId, so it works for aliases properly too.
MozReview-Commit-ID: 4d76Z55ZBEH | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 2c80c2573..e20788538 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -428,6 +428,17 @@ impl NonCustomPropertyId {
MAP[self.0]
}
+ /// Get the property name.
+ ... | 1 | 15 | 10 |
b35214e736f50ee67a47afcab3abee96c6b80584 | Emilio Cobos Álvarez | 2018-06-05T13:53:43 | Bug 1466645: Avoid useless allocations in custom property name serialization. r=xidorn
And make transition-property more correct by serializing --0 unescaped instead
of escaped.
MozReview-Commit-ID: CCBSe5Frd0d | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 38245b707..2c80c2573 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -49,6 +49,7 @@ use stylesheets::{CssRuleType, Origin, UrlExtraData};
use values::generics::text::LineHeight;
u... | 3 | 32 | 7 |
cbb11013735192c409e5dc443e35dfaa2acb68c6 | Emilio Cobos Álvarez | 2018-06-04T18:09:51 | Bug 1466609: Make clearing atoms slightly more ergonomic. r=xidorn
I prefer to do it this way because Atom has inline paths for static atoms and
such.
MozReview-Commit-ID: CFsBHl80KDY | diff --git a/style/gecko_bindings/sugar/refptr.rs b/style/gecko_bindings/sugar/refptr.rs
index 5019663a5..10c9e6276 100644
--- a/style/gecko_bindings/sugar/refptr.rs
+++ b/style/gecko_bindings/sugar/refptr.rs
@@ -4,6 +4,7 @@
//! A rust helper to ease the use of Gecko's refcounted types.
+use Atom;
use gecko_bindi... | 2 | 17 | 8 |
3f9ff1e9214718e561253c90ae04240d6628f59c | Emilio Cobos Álvarez | 2018-06-04T17:53:45 | Bug 1466609: Make the threadsafe refcounting macros more reusable. r=xidorn
MozReview-Commit-ID: IanxqRksGqE | diff --git a/style/gecko_bindings/sugar/refptr.rs b/style/gecko_bindings/sugar/refptr.rs
index 76a7021ef..5019663a5 100644
--- a/style/gecko_bindings/sugar/refptr.rs
+++ b/style/gecko_bindings/sugar/refptr.rs
@@ -4,7 +4,7 @@
//! A rust helper to ease the use of Gecko's refcounted types.
-use gecko_bindings::struct... | 1 | 32 | 30 |
21ccdeec0849b429c7e55412b63814dd8431334d | Emilio Cobos Álvarez | 2018-06-04T17:24:43 | Bug 1466609: Move some parsing-only attributes to use #[parse(..)] instead of #[css(..)]. r=xidorn
I need to admit I'm ambivalent about this one :).
MozReview-Commit-ID: F1jlfnQKXwo | diff --git a/style/parser.rs b/style/parser.rs
index 1b7c65e25..6dbfe1cfa 100644
--- a/style/parser.rs
+++ b/style/parser.rs
@@ -157,12 +157,12 @@ impl<'a> ParserContext<'a> {
///
/// The derive code understands the following attributes on each of the variants:
///
-/// * `#[css(aliases = "foo,bar")]` can be used t... | 8 | 39 | 29 |
143e83b21fc26116179df092ec9d076788da1648 | Dan Glastonbury | 2018-06-05T01:49:51 | Bug 1465307 - P3: Extract {animated,computed}::Color common parts. r=xidorn
Extract the common parts of `animated::Color` and `computed::Color` out
into `generics::color::Color<T>` that is generic over the type of
RGBA color.
MozReview-Commit-ID: EymSr7aqnAP | diff --git a/style/gecko_bindings/sugar/style_complex_color.rs b/style/gecko_bindings/sugar/style_complex_color.rs
index 3a37f9cb0..90e93b72f 100644
--- a/style/gecko_bindings/sugar/style_complex_color.rs
+++ b/style/gecko_bindings/sugar/style_complex_color.rs
@@ -9,8 +9,8 @@ use gecko_bindings::structs::StyleComplexCo... | 7 | 122 | 146 |
f35de004e83b2f72049635d4d89c120381f3dcb0 | Dan Glastonbury | 2018-06-05T01:24:12 | Bug 1465307 - P2: Fix nsStyleBorder::mBorderColor for GCC. r=xidorn
GCC doesn't like StyleComplexColor with constructor in an anonymous
struct in an anonymous union. Replace the use of a union to access
`mBorder[..]Color` fields as an array with an accessor methods.
MozReview-Commit-ID: 1Wulh1qKYCZ | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 13d93b0a1..f83e0836c 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -388,17 +388,9 @@ impl ${style_struct.gecko_struct_name} {
<%!
def get_gecko_property(ffi_name, self_param = "self"):
- if "m... | 1 | 1 | 9 |
5f8ee8a91f3187330399238b71b514660293648f | Emilio Cobos Álvarez | 2018-06-04T14:27:00 | Bug 1465291: Make pseudo-elements work with :host. r=xidorn
Imported WebKit's test as a WPT.
MozReview-Commit-ID: 19ZThuoqKLW | diff --git a/selectors/parser.rs b/selectors/parser.rs
index fc840bfe9..2c9d65057 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -544,10 +544,26 @@ impl<Impl: SelectorImpl> Selector<Impl> {
}
/// Whether this selector is a featureless :host selector, with no
- /// combinators to the left.
... | 2 | 35 | 28 |
8b49fe89edef1b65ae72380a413723f72a0d1bd8 | Emilio Cobos Álvarez | 2018-06-04T17:14:20 | Bug 1466406: Work around a bindgen bug on Android. r=xidorn
MozReview-Commit-ID: 2lltjH7IoZu | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 96f20fd90..5475be1e3 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1118,7 +1118,23 @@ impl<'le> TElement for GeckoElement<'le> {
assert_eq!(base as *const _, self.0 as *const _, "Bad cast");
}
- let ... | 1 | 17 | 1 |
bce3be340045cdc3917ddea77440efff56958cbb | Emilio Cobos Álvarez | 2018-06-01T15:11:00 | Bug 1466136: Don't look at the rule type from value parsing. r=hiro
This would cause properties to change the value semantics between, e.g.,
@keyframes and non-@keyframes, which would be observable.
It happens not to be observable since the animation-* and transition-*
properties are not allowed in @keyframes, nor ha... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index b7bc96973..38245b707 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -499,6 +499,11 @@ impl NonCustomPropertyId {
_ => {}
}
+ self.allowed_in_ignoring... | 2 | 43 | 4 |
6f341a3e5151d6ded259571b143793431a26cf28 | Emilio Cobos Álvarez | 2018-06-04T19:48:43 | No bug - Sprinkle some #[inline] on methods that have inline fast-paths. r=me
MozReview-Commit-ID: 5kOmctLTAX0 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index f85bffaaa..96f20fd90 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1356,6 +1356,7 @@ impl<'le> TElement for GeckoElement<'le> {
!self.is_in_native_anonymous_subtree()
}
+ #[inline]
fn implemented_pseudo_ele... | 1 | 2 | 0 |
8f199eb42d73aadd34f3ef275de3c88e48a7f69a | Emilio Cobos Álvarez | 2018-06-04T19:46:22 | No bug - Sprinkle some inline in methods that are just pointer-chasing or function calls. r=me
MozReview-Commit-ID: 8G2NQPBVuXn | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 4eae24a2b..f85bffaaa 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -615,31 +615,37 @@ impl<'le> GeckoElement<'le> {
// GeckoNode is a raw reference.
//
// We can use a Cell<T>, but that's a bit of a pain.
+ #[inli... | 1 | 7 | 0 |
9c1bc6ecb1b3e297600176474535fe70aaab5f9b | Emilio Cobos Álvarez | 2018-06-04T19:40:07 | Bug 1466647: Update smallbitvec to v2.1.1. r=me
Actual code changes reviewed upstream in:
https://github.com/servo/smallbitvec/pull/12
MozReview-Commit-ID: 3vKVPMovBj | diff --git a/style/Cargo.toml b/style/Cargo.toml
index ce2326dac..88ad478f5 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -60,7 +60,7 @@ serde = {version = "1.0", optional = true, features = ["derive"]}
servo_arc = { path = "../servo_arc" }
servo_atoms = {path = "../atoms", optional = true}
servo_config = ... | 1 | 1 | 1 |
b18a1babec5a414876d21cf53b839655b088890b | Emilio Cobos Álvarez | 2018-06-04T19:16:33 | No bug - Minor indentation cleanup. r=me
MozReview-Commit-ID: JmilaCX3rNy | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 209c06df0..d266d3e27 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -809,8 +809,10 @@
use values::generics::rect::Rect;
use values::specified;
- pub fn parse_value<'... | 1 | 4 | 2 |
7a6b9ccb21d656f77e4b79946781b8068fbb142f | Emilio Cobos Álvarez | 2018-06-02T18:53:33 | Bug 1288572: Don't hide -moz-box / -moz-inline-box yet. r=mats
I'd really prefer to not land this patch, but...
MozReview-Commit-ID: HzmvhTd32gz | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index bece7115c..4890f225e 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -80,10 +80,8 @@ pub enum Display {
#[cfg(feature = "gecko")]
WebkitInlineBox,
#[cfg(feature = "gecko")]
- #[css(parse_... | 1 | 0 | 2 |
31addff95a217f9af82407be09a0f82a15439301 | Emilio Cobos Álvarez | 2018-06-02T17:35:12 | Bug 1288572: Hide -moz- display values from content behind a pref. r=xidorn
MozReview-Commit-ID: HDQPub043H1 | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 82e609c44..6c388d1ef 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -9,8 +9,6 @@
inherited=False,
gecko_name="Display") ... | 2 | 22 | 3 |
192679e9cab6268c32c3a2eb623ab8eac8fad3dd | Emilio Cobos Álvarez | 2018-06-02T16:38:42 | Bug 1288572: Introduce css(parse_condition). r=xidorn
This will allow us to add a pref for this, and to parse it only on chrome easily.
MozReview-Commit-ID: L1rsyc2A2hu | diff --git a/style/parser.rs b/style/parser.rs
index 26f4aeea0..1b7c65e25 100644
--- a/style/parser.rs
+++ b/style/parser.rs
@@ -150,10 +150,19 @@ impl<'a> ParserContext<'a> {
}
}
-// XXXManishearth Replace all specified value parse impls with impls of this
-// trait. This will make it easy to write more generi... | 3 | 49 | 7 |
a935ce3a3bdbc72e02895a68e55e3da02d4268bb | Emilio Cobos Álvarez | 2018-06-04T13:36:24 | Bug 1419695: Use custom_properties::Name in TransitionProperty. r=xidorn
MozReview-Commit-ID: BUSWrcA5hkw | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 059188f82..3caee1e7f 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -6,6 +6,7 @@
use Atom;
use cssparser::Parser;
+use custom_properties::Name as CustomPropertyName;
use parser::{Parse, ParserContext... | 1 | 2 | 1 |
e2b2dd93add81e97fb1c6b62b940809aec6fe99b | Emilio Cobos Álvarez | 2018-06-01T15:09:34 | Bug 1419695: Move TransitionProperty where it belongs. r=xidorn
MozReview-Commit-ID: 9PN6VfbDbLA | diff --git a/style/animation.rs b/style/animation.rs
index 15c58c609..d090ecb1e 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -10,7 +10,7 @@ use context::SharedStyleContext;
use dom::{OpaqueNode, TElement};
use font_metrics::FontMetricsProvider;
use properties::{self, CascadeFlags, ComputedValues, Long... | 9 | 109 | 115 |
968818b75e7abeff27ce49c78753714b0ac31884 | Emilio Cobos Álvarez | 2018-06-01T14:36:54 | Bug 1419695: Hide multiple -moz-window-* properties from content. r=xidorn
MozReview-Commit-ID: Jsqt3kqjPiq | diff --git a/style/properties/longhand/ui.mako.rs b/style/properties/longhand/ui.mako.rs
index 683a8967e..13a940b2b 100644
--- a/style/properties/longhand/ui.mako.rs
+++ b/style/properties/longhand/ui.mako.rs
@@ -41,13 +41,17 @@ ${helpers.single_keyword("-moz-window-shadow", "none default menu tooltip sheet"
... | 1 | 14 | 9 |
d4582d5b9ecf931ba75adf97fbcc012ba5c1f0f7 | Emilio Cobos Álvarez | 2018-06-01T14:34:08 | Bug 1419695: Make the transition-property code make more sense. r=xidorn
We were working around the lack of alias support during parsing in
TransitionProperty by doing a Gecko lookup. That's a hack and is now gone.
MozReview-Commit-ID: EptUvJNTrZr | diff --git a/style/animation.rs b/style/animation.rs
index bbf847d7f..15c58c609 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -303,7 +303,8 @@ impl PropertyAnimation {
let duration = box_style.transition_duration_mod(transition_index);
match transition_property {
- Transitio... | 6 | 86 | 43 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.