commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
0c151c03aae93c2615992b14f2588b285ffae1d2 | Xidorn Quan | 2018-04-28T23:03:31 | Bug 1434130 part 1 - Skip system font variant for ToCss in font subproperties. r=emilio
System font keywords are not a valid value for those properties.
The newly-added #[css(skip)] would be reused by deriving algorithm of
SpecifiedValueInfo to skip them as well.
MozReview-Commit-ID: EmnhkaA9RR5 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 3c5bb762e..2aa93bbb7 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -411,6 +411,7 @@
#[derive(Clone, Copy, Debug, Eq, PartialEq, SpecifiedValueInfo, ToCss)]
pub enum Specifie... | 4 | 23 | 0 |
d3926f0288566f60ad1702a176b3ecf1e2d97256 | Emilio Cobos Álvarez | 2018-04-28T07:41:48 | Bug 1457652: Fix serialization order of the outline shorthand. r=xidorn
This is going to be tested in
https://github.com/w3c/web-platform-tests/pull/10700.
MozReview-Commit-ID: 7Oi1it70YFw | diff --git a/style/properties/shorthand/outline.mako.rs b/style/properties/shorthand/outline.mako.rs
index d2f044666..14b935f3b 100644
--- a/style/properties/shorthand/outline.mako.rs
+++ b/style/properties/shorthand/outline.mako.rs
@@ -5,7 +5,7 @@
<%namespace name="helpers" file="/helpers.mako.rs" />
<%helpers:sho... | 1 | 1 | 1 |
1a7ef573af88702f4b2b6b99f8cb19336a1e284f | Dorel Luca | 2018-04-28T11:54:16 | Backed out changeset 2a03e9effe84 (bug 1457652) for WPT failures on /css/cssom/shorthand-values.html | diff --git a/style/properties/shorthand/outline.mako.rs b/style/properties/shorthand/outline.mako.rs
index 14b935f3b..d2f044666 100644
--- a/style/properties/shorthand/outline.mako.rs
+++ b/style/properties/shorthand/outline.mako.rs
@@ -5,7 +5,7 @@
<%namespace name="helpers" file="/helpers.mako.rs" />
<%helpers:sho... | 1 | 1 | 1 |
7fd47e5bcfac95a07bea77c2360530d443d9b76b | Gerald Squelart | 2018-04-27T01:31:25 | Bug 1417761 - Remove "layout.css.text-combine-upright.enabled" pref - r=xidorn
Shipped since Firefox 48, other browsers have similar impls, and the related
spec has been in CR since a while ago.
The syntax of this property as implemented should be considered to be pretty
stable, so we can remove this pref.
MozReview-... | diff --git a/style/properties/longhand/inherited_text.mako.rs b/style/properties/longhand/inherited_text.mako.rs
index abf105467..975d7eabe 100644
--- a/style/properties/longhand/inherited_text.mako.rs
+++ b/style/properties/longhand/inherited_text.mako.rs
@@ -292,7 +292,6 @@ ${helpers.single_keyword("ruby-position", "... | 1 | 0 | 1 |
aba11ac66f95d035ea19f3983f067aa81d494b37 | Emilio Cobos Álvarez | 2018-04-25T14:51:29 | No bug - Cherry-pick servo build fixes for style and fix style unit tests. r=me
MozReview-Commit-ID: 857HqA1oK66 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index e0d6b6cc2..7841d953c 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -2243,7 +2243,7 @@ pub mod style_structs {
// Corresponds to the fields in
... | 2 | 11 | 1 |
a5096c0d43b6b1faf08ea7118f1f0adad9ef1de5 | Jonathan Watt | 2018-04-25T13:54:26 | Bug 1458219 - Remove the 'property_name' macro. r=xidorn | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index a1d2ee9d0..5e3d8eaea 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -56,12 +56,6 @@ use style_adjuster::StyleAdjuster;
pub use self::declaration_block::*;
-#[cfg(feature = "ge... | 1 | 0 | 6 |
c45f331dea41af01500f77645c4c6fcda0f28b65 | Emilio Cobos Álvarez | 2018-04-24T13:41:40 | Bug 1456471: Unify MediaList and ServoMediaList. r=xidorn
MozReview-Commit-ID: KFWxoohpGlb | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 331b07ea5..567a9b7f6 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -94,15 +94,15 @@ impl StylesheetInDocument for GeckoStyleSheet {
}
fn media<'a>(&'a self, guard: &'a SharedRwLockReadGuard) -> Option<&'a MediaList> {
- use ... | 1 | 4 | 4 |
b6e5b48ee445d436719cd9ad2af205c9f1709809 | Narcis Beleuzu | 2018-04-24T19:31:15 | Backed out 20 changesets (bug 1265342) for mochitest-plain-headless failures on layout/style/test/test_first_letter_restrictions.html. CLOSED TREE
Backed out changeset 6c80ec2d0398 (bug 1265342)
Backed out changeset 62d571916086 (bug 1265342)
Backed out changeset fd247f38f8a7 (bug 1265342)
Backed out changeset 83aee3d... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 026a3ca79..806afcbd1 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -660,21 +660,9 @@ ${helpers.predefined_type(
products="gecko",
gecko_pref="layout.css.shape-ou... | 1 | 0 | 12 |
aecf310806a2b61d762e29409c2bfab3f2af6e36 | Emilio Cobos Álvarez | 2018-04-18T17:48:24 | Bug 1455032: Pack the shadow cascade order in ApplicableDeclarationBlock. r=heycam
I didn't bother not shifting there. We need to load the whole thing and shift
for at least one of cascade level / shadow cascade order.
Callers of level() other than for_rule_tree are non-existent in release builds,
so we'd be doing th... | diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs
index 1e39c4169..d4674fa1b 100644
--- a/style/applicable_declarations.rs
+++ b/style/applicable_declarations.rs
@@ -10,7 +10,6 @@ use servo_arc::Arc;
use shared_lock::Locked;
use smallvec::SmallVec;
use std::fmt::{self, Debug};
-use std... | 2 | 56 | 37 |
371d8ff80aa334c92bc8569e513e426ead3559de | Mats Palmgren | 2018-04-23T23:52:51 | Bug 1398482 part 1 - [css-grid][css-flexbox][css-multicol] Add 'row-gap' and 'gap' properties; make 'grid-[column|row]-gap' and 'grid-gap' alias the respective unprefixed properties (Stylo part). r=emilio
This also makes 'normal' the initial value for the grid-*
properties, per:
https://github.com/w3c/csswg-drafts/is... | diff --git a/style/properties/longhand/column.mako.rs b/style/properties/longhand/column.mako.rs
index 3b2a3ec38..7a97c3f41 100644
--- a/style/properties/longhand/column.mako.rs
+++ b/style/properties/longhand/column.mako.rs
@@ -31,17 +31,6 @@ ${helpers.predefined_type(
-${helpers.predefined_type(
- "column-ga... | 3 | 31 | 29 |
62b4e026d7041b037120ff885569f0eee70d95c8 | Emilio Cobos Álvarez | 2018-04-23T16:46:10 | Bug 1426516: Remove Valgrind workaround to make ::slotted use the rule hash. r=me
MozReview-Commit-ID: 2q14kHjajIr | diff --git a/style/selector_map.rs b/style/selector_map.rs
index 68f025b3e..3b9b6f201 100644
--- a/style/selector_map.rs
+++ b/style/selector_map.rs
@@ -454,13 +454,7 @@ fn specific_bucket_for<'a>(component: &'a Component<SelectorImpl>) -> Bucket<'a>
//
// So inserting `span` in the rule hash makes se... | 1 | 1 | 7 |
eb9132a48d289d2820ffc43a0ade045f32574c81 | Emilio Cobos Álvarez | 2018-04-20T17:57:36 | Bug 1454883: Only parse font-stretch keywords in the font shorthand. r=xidorn
MozReview-Commit-ID: 4BqnOSz83w4 | diff --git a/style/properties/shorthand/font.mako.rs b/style/properties/shorthand/font.mako.rs
index cc3cd819c..5e14fd6ab 100644
--- a/style/properties/shorthand/font.mako.rs
+++ b/style/properties/shorthand/font.mako.rs
@@ -27,6 +27,7 @@
use properties::longhands::system_font::SystemFont;
use values::specifi... | 2 | 57 | 5 |
1b180ff869cc9f8ee92d83c1c6f0f54d579d7bfc | Jonathan Watt | 2018-04-23T14:52:20 | Bug 1436048: Use user defined types for font-stretch / font-style. r=jfkthame,jwatt
Co-authored-by: Emilio Cobos Álvarez <emilio@crisal.io>
MozReview-Commit-ID: 7ONYtICeAqb | diff --git a/style/gecko/rules.rs b/style/gecko/rules.rs
index b2a64c19f..a57314a41 100644
--- a/style/gecko/rules.rs
+++ b/style/gecko/rules.rs
@@ -26,19 +26,12 @@ impl<'a> ToNsCssValue for &'a FamilyName {
impl<'a> ToNsCssValue for &'a SpecifiedFontStretch {
fn convert(self, nscssvalue: &mut nsCSSValue) {
- ... | 5 | 51 | 37 |
bd32997bac47569584f0d02e2484cec998c6b8cc | Emilio Cobos Álvarez | 2018-04-19T20:01:15 | Bug 1455358: Cleanup (a bit) system font copypasta. r=xidorn
If I had to write that again I would've killed myself :).
This is still not perfect, and the system font code is still quite a mess, but
well, little steps.
MozReview-Commit-ID: BmrZlCSejo7 | diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs
index cebb9ae28..c6a2c31a1 100644
--- a/style/values/specified/font.rs
+++ b/style/values/specified/font.rs
@@ -26,6 +26,41 @@ use values::generics::font::{KeywordInfo as GenericKeywordInfo, KeywordSize, Var
use values::specified::{AllowQuirk... | 1 | 69 | 335 |
f282411f7b19ee0fd005525a7b9a670ea7f9c976 | Emilio Cobos Álvarez | 2018-04-19T19:40:25 | Bug 1455358: Fix clamping on animations. r=xidorn
MozReview-Commit-ID: Awyub0dMOmq | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index 01485dd71..e6f6ea34a 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -20,8 +20,7 @@ ${helpers.predefined_type(
"FontStyle",
initial_value="computed::FontStyle:... | 5 | 37 | 10 |
d3650233b708c0422f4740b0f58596fb202abbbf | Emilio Cobos Álvarez | 2018-04-19T19:23:31 | Bug 1455358: Use a generic type in preparation to fix animation. r=xidorn
Apart from a bit more code reuse.
MozReview-Commit-ID: 2BNOK6v30lX | diff --git a/style/font_face.rs b/style/font_face.rs
index f887b8876..d732a5c0f 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -26,8 +26,8 @@ use values::computed::font::FamilyName;
use values::specified::font::{AbsoluteFontWeight, FontStretch as SpecifiedFontStretch};
#[cfg(feature = "gecko")]
use valu... | 8 | 143 | 111 |
591b321018dc889a9a0fcf0cbb73906360c87f79 | Emilio Cobos Álvarez | 2018-04-19T18:38:08 | Bug 1455358: Update font-style to css-fonts-4. r=xidorn
This patch is meant to be squashed with the following two. This is an initial
strawman implementation that I wrote to unblock jwatt, cleanups and fixes
follow.
Note that this is style pretty much untested until jwatt's patches are ready,
since Gecko doesn't unde... | diff --git a/style/font_face.rs b/style/font_face.rs
index 514feba99..f887b8876 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -6,10 +6,6 @@
//!
//! [ff]: https://drafts.csswg.org/css-fonts/#at-font-face-rule
-#![deny(missing_docs)]
-
-#[cfg(feature = "gecko")]
-use computed_values::font_style;
use cs... | 10 | 352 | 56 |
414d37f0049a736d471a7c580cd3b92625c630db | Emilio Cobos Álvarez | 2018-04-17T14:44:17 | Bug 1454883: Update font-stretch to css-fonts-4. r=xidorn
These won't "just work", pending changes from bug 1436048 to use a floating
point representation for those.
MozReview-Commit-ID: Bi5iTdFreMA | diff --git a/style/font_face.rs b/style/font_face.rs
index d47dd71b2..514feba99 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -9,7 +9,7 @@
#![deny(missing_docs)]
#[cfg(feature = "gecko")]
-use computed_values::{font_stretch, font_style};
+use computed_values::font_style;
use cssparser::{AtRuleParser,... | 10 | 262 | 118 |
96fe65d3bb8fa5a18a34692ed0c0ce031730df02 | Xidorn Quan | 2018-04-20T14:38:08 | Bug 1455623 part 2 - Not copy generated binding files into dist. r=emilio
MozReview-Commit-ID: GBnkmwjDS8Y | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index b5dd2ed41..95bb16229 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -3,31 +3,13 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
mod common {
- use std::{env, fs, io};
- use std::path::{Path, PathBuf};
+ use st... | 1 | 22 | 30 |
45b87654e79dd047fe60292db5b992d1fbbab433 | Matt Brubeck | 2018-04-18T00:24:54 | Bug 1455902: Update to smallbitvec 2.1. r=nox,emilio
This cherry-picks servo commit e3f79d91306655f4cbe3eefe6106b9c10218f464.
MozReview-Commit-ID: JO1wwjFuz5N | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index 829f812df..7db5fbc8f 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -34,7 +34,7 @@ selectors = { path = "../selectors" }
serde = { version = "1.0.27", optional = true }
serde_bytes = { version = "0.10", optional = true... | 4 | 16 | 17 |
08bd9c1a85fffdd23a3cff77c6e2b7ddbf70cc1c | Xidorn Quan | 2018-04-20T10:32:57 | Bug 1454830 part 3 - Add CAN_ANIMATE_ON_COMPOSITOR in Servo side and propagate it to ServoCSSPropList.h. r=emilio
MozReview-Commit-ID: 2OBCliDY02g | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 35aff0506..806afcbd1 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -410,7 +410,8 @@ ${helpers.predefined_type(
extra_prefixes=transform_extra_prefixes,
animation... | 3 | 14 | 8 |
958121abe6b1d0deefe6abebf6bba7012356d879 | Xidorn Quan | 2018-04-20T09:13:16 | Bug 1454830 part 2 - Add GETCS_NEEDS_LAYOUT_FLUSH flag in Servo side and propagate it to ServoCSSPropList.h. r=emilio
MozReview-Commit-ID: 5k08FWjobCg | diff --git a/style/properties/longhand/border.mako.rs b/style/properties/longhand/border.mako.rs
index bf2e8e921..9bb3dbcec 100644
--- a/style/properties/longhand/border.mako.rs
+++ b/style/properties/longhand/border.mako.rs
@@ -43,17 +43,19 @@
needs_context=False,
)}
- ${helpers.predefined_type("bor... | 8 | 152 | 98 |
248fba0b0d3795dbc264bfbd08f6eab4e5dbf9d5 | Emilio Cobos Álvarez | 2018-04-19T15:50:32 | Bug 1363875: [css-align]: Rename justify-items: auto to legacy. r=mats,xidorn
MozReview-Commit-ID: Jfwib2XDmSw | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 0b55820f1..b6a473477 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1806,7 +1806,7 @@ fn static_assert() {
}
pub fn set_computed_justify_items(&mut self, v: values::specified::JustifyItem... | 5 | 73 | 70 |
df7949b6d7dd5e424612eb2b4e52be1bc5a5885b | Emilio Cobos Álvarez | 2018-04-17T11:30:04 | Bug 1454596: Update font-weight property and descriptor to css-fonts-4. r=xidorn
Need to change the tests still, but that should be trivial.
MozReview-Commit-ID: 27aS2UrgXjs | diff --git a/style/font_face.rs b/style/font_face.rs
index a890822d0..d47dd71b2 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -9,7 +9,7 @@
#![deny(missing_docs)]
#[cfg(feature = "gecko")]
-use computed_values::{font_stretch, font_style, font_weight};
+use computed_values::{font_stretch, font_style};
... | 9 | 197 | 138 |
190e3fb4c3e28ada01c6104ae866607da977277b | Bobby Holley | 2018-02-15T00:39:35 | Bug 1346988 - Parse sheets on the thread pool. r=bz,r=emilio
Note that we also drop the dead optional aReusableSheets argument from
the async parsing path, since it was always null.
MozReview-Commit-ID: KddpGFdaqEe | diff --git a/style/gecko_bindings/sugar/refptr.rs b/style/gecko_bindings/sugar/refptr.rs
index 0d8fb817a..76a7021ef 100644
--- a/style/gecko_bindings/sugar/refptr.rs
+++ b/style/gecko_bindings/sugar/refptr.rs
@@ -312,3 +312,9 @@ impl_threadsafe_refcount!(
Gecko_AddRefSharedFontListArbitraryThread,
Gecko_Relea... | 2 | 9 | 4 |
b886e58e4fec14835e3281583a02cd08809d9d56 | Emilio Cobos Álvarez | 2018-04-18T07:56:33 | Bug 1454162: Fix cascade order of !important in Shadow DOM. r=heycam
No cleaner ideas right now that carrying that counter around... Maybe a custom
type may be cleaner?
This makes ApplicableDeclarationBlock a bit bigger. I could probably try to make
the counter a 4 / 5-bit number or something and pack the counter the... | diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs
index ab7c47307..1e39c4169 100644
--- a/style/applicable_declarations.rs
+++ b/style/applicable_declarations.rs
@@ -5,7 +5,7 @@
//! Applicable declarations management.
use properties::PropertyDeclarationBlock;
-use rule_tree::{CascadeL... | 4 | 131 | 42 |
e94a4534f083e375ff39a78e5b57619d5bb61bd8 | Xidorn Quan | 2018-04-18T09:39:51 | Bug 1454831 - Generate nsCSSPropertyID.h from data file directly. r=emilio
MozReview-Commit-ID: CcX2uzgjWFo | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 2d1db9e70..b5dd2ed41 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -33,8 +33,7 @@ mod common {
#[cfg(feature = "bindgen")]
mod bindings {
use bindgen::{Builder, CodegenConfig};
- use bindgen::callbacks::{EnumVariantCustomBehavior... | 1 | 1 | 38 |
b67b7eda3e6336ec7f3a8d23ce496bb2ecb88009 | Jonathan Watt | 2018-04-17T12:24:30 | No bug - Fix error name in comment for try_match_ident_ignore_ascii_case. r=nox,emilio
MozReview-Commit-ID: GDejDQE7sj3 | diff --git a/style/macros.rs b/style/macros.rs
index 38060f1d3..f8f4759c1 100644
--- a/style/macros.rs
+++ b/style/macros.rs
@@ -47,7 +47,7 @@ macro_rules! trivial_to_computed_value {
};
}
-/// A macro to parse an identifier, or return an `UnexpectedIndent` error
+/// A macro to parse an identifier, or return a... | 1 | 1 | 1 |
995c03484adcb006f0e90d7a9800ce21c53a97c9 | Emilio Cobos Álvarez | 2018-04-17T17:55:25 | Bug 1454030: followup: Fix Servo build bustage. r=me
DONTBUILD, since code is not part of the build.
MozReview-Commit-ID: KU2sDFDjeNV | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 01b9a13ba..71df0e703 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -135,7 +135,7 @@ use style::selector_parser::{RestyleDamage, Snapshot};
use style::shared_lock::{SharedRwLock as StyleSharedRwLock, SharedRwLockReadGuard};
use st... | 2 | 42 | 10 |
c60e0682fbc57a6a5f60c08f8fef776bde0e42e7 | Emilio Cobos Álvarez | 2018-04-17T17:50:49 | Bug 1453702: followup: Fix Servo build. r=me
DONTBUILD
MozReview-Commit-ID: 6MklMseUFzO | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index 55bacd037..309ddaf7e 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -397,6 +397,14 @@ impl<'le> TElement for ServoLayoutElement<'le> {
unsafe { self.element.is_html_element() }
}
+ fn is_ma... | 2 | 10 | 1 |
60573261b9d6a350435b0da265dcf6333e2574b8 | Xidorn Quan | 2018-04-17T11:18:37 | Bug 1453258 - Support calc in cursor. r=emilio
MozReview-Commit-ID: 1ZzxkYboWZg | diff --git a/style/values/computed/pointing.rs b/style/values/computed/pointing.rs
index a0102c120..a89db9104 100644
--- a/style/values/computed/pointing.rs
+++ b/style/values/computed/pointing.rs
@@ -6,137 +6,16 @@
//!
//! https://drafts.csswg.org/css-ui/#pointing-keyboard
-use cssparser::Parser;
-use parser::{Par... | 3 | 134 | 165 |
811caeaf31cd2ce0a245f082a87cc1721ed4cdf3 | Emilio Cobos Álvarez | 2018-04-17T10:44:28 | No bug - Remove an unused import. r=me
MozReview-Commit-ID: E92BZF0SnHm | diff --git a/style/stylesheets/rules_iterator.rs b/style/stylesheets/rules_iterator.rs
index 81bf890b0..b46e24c22 100644
--- a/style/stylesheets/rules_iterator.rs
+++ b/style/stylesheets/rules_iterator.rs
@@ -11,7 +11,6 @@ use smallvec::SmallVec;
use std::slice;
use stylesheets::{CssRule, DocumentRule, ImportRule, Me... | 1 | 0 | 1 |
7f315ffd3aca2336e95dffb765fd7f8d6a96959c | Bobby Holley | 2018-02-20T23:52:13 | Bug 1454030 - Allow placeholder import sheets. r=emilio
This is necessary because we can't create GeckoStyleSheets off-main-thread,
so we need a placeholder until it can be filled in.
MozReview-Commit-ID: ssRme4fLYg | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 9c58a292d..331b07ea5 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -5,6 +5,7 @@
//! Data needed to style a Gecko document.
use atomic_refcell::{AtomicRef, AtomicRefCell, AtomicRefMut};
+use context::QuirksMode;
use dom::TElement;
use gec... | 5 | 149 | 67 |
28dac65666e3abaf3265772dd89277648f5af1fb | Emilio Cobos Álvarez | 2018-04-14T16:38:29 | Bug 1453702: [css-display] Move unboxing to style, and handle display: contents before other suppressions. r=mats,xidorn
This also adopts the resolution of [1] while at it, and switches XUL to not
support display: contents until a use case appears.
This makes our behavior consistent both with the spec and also in ter... | diff --git a/style/dom.rs b/style/dom.rs
index acc1c364c..bee4d8832 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -434,6 +434,15 @@ pub trait TElement:
/// Return whether this element is an element in the HTML namespace.
fn is_html_element(&self) -> bool;
+ /// Return whether this element is an element... | 3 | 129 | 16 |
25dc52c6d5ea38027cd2960fd9410d51b23baac8 | Emilio Cobos Álvarez | 2018-04-13T18:13:10 | Bug 1453206: Fix IsInAnonymousSubtree to account for XBL in Shadow DOM. r=smaug
MozReview-Commit-ID: B2aYury8K7i | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 1beeaf0fe..2764c7e73 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -637,10 +637,11 @@ impl<'le> GeckoElement<'le> {
!self.xbl_binding_with_content().is_none()
}
- /// This and has_xbl_binding_parent duplicate the... | 1 | 15 | 17 |
40d1988e2a66e47c2590416c6aa52e27b814f1ae | Andreea Pavel | 2018-04-13T20:06:55 | Backed out 2 changesets (bug 1453206) for crashtest failures on muliple files e.g. tests/reftest/tests/layout/base/crashtests/416107.xhtml on a CLOSED TREE
Backed out changeset 1844a120acda (bug 1453206)
Backed out changeset b12b7c5b8178 (bug 1453206) | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 2764c7e73..1beeaf0fe 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -637,11 +637,10 @@ impl<'le> GeckoElement<'le> {
!self.xbl_binding_with_content().is_none()
}
- /// This duplicates the logic in Gecko's virtual ... | 1 | 17 | 15 |
caae0ae58a93c5332fbe2e56c4cbb491eda08df8 | Jonathan Watt | 2018-04-13T19:34:37 | Bug 1436048 part 1 - Use a user defined type for font weight everywhere. r=jfkthame,emilio | diff --git a/style/gecko/rules.rs b/style/gecko/rules.rs
index ccf49f829..2f1442796 100644
--- a/style/gecko/rules.rs
+++ b/style/gecko/rules.rs
@@ -25,7 +25,7 @@ impl<'a> ToNsCssValue for &'a FamilyName {
impl ToNsCssValue for font_weight::T {
fn convert(self, nscssvalue: &mut nsCSSValue) {
- nscssvalue... | 4 | 18 | 7 |
4eb3626f698456dfc65eeb97af21ba6874ef66ce | Emilio Cobos Álvarez | 2018-04-10T16:40:22 | Bug 1453148: Let overflow parse two values. r=xidorn
Per https://github.com/w3c/csswg-drafts/issues/2484.
MozReview-Commit-ID: D7M3PhnTtD2 | diff --git a/style/properties/shorthand/box.mako.rs b/style/properties/shorthand/box.mako.rs
index 7f2fe128e..1bf868b1b 100644
--- a/style/properties/shorthand/box.mako.rs
+++ b/style/properties/shorthand/box.mako.rs
@@ -4,8 +4,11 @@
<%namespace name="helpers" file="/helpers.mako.rs" />
-<%helpers:shorthand name="... | 1 | 15 | 9 |
0ea4a1ebf9d01a120379ddb4f027d6f90b766bea | Brindusan Cristian | 2018-04-12T07:13:56 | Backed out changeset 84fc374da5e3 (bug 1453148) for mochitest failures on layout/style/test/test_bug319381.html CLOSED TREE | diff --git a/style/properties/shorthand/box.mako.rs b/style/properties/shorthand/box.mako.rs
index 1bf868b1b..7f2fe128e 100644
--- a/style/properties/shorthand/box.mako.rs
+++ b/style/properties/shorthand/box.mako.rs
@@ -4,11 +4,8 @@
<%namespace name="helpers" file="/helpers.mako.rs" />
-<%helpers:shorthand
- n... | 1 | 9 | 15 |
fa87a387b04414e12f26eefd3964bc338bcd7dd2 | ddh | 2018-04-11T20:33:38 | servo: Merge #20626 - added spec comments for progressive web metrics (from avadacatavra:pwm-spec); r=asajeffrey
<!-- Please describe your changes on the following line: -->
r? @asajeffrey
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with... | diff --git a/metrics/lib.rs b/metrics/lib.rs
index 59657738e..1a17f75ca 100644
--- a/metrics/lib.rs
+++ b/metrics/lib.rs
@@ -102,6 +102,7 @@ fn set_metric<U: ProgressiveWebMetric>(
}
+// spec: https://github.com/WICG/time-to-interactive
// https://github.com/GoogleChrome/lighthouse/issues/27
// we can look at th... | 1 | 2 | 0 |
716f036a49bc8e16368a9340bcd6f03e4142b51a | Connor Brewster | 2018-04-11T15:12:52 | servo: Merge #20579 - Replace initial about:blank loads (from cbrewster:about_blank_replace); r=asajeffrey
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 9b3e2e8a1..9217939ee 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -2438,12 +2438,13 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
.collect::<Vec<_>>()
... | 2 | 13 | 3 |
a2e2bf3f2281bc550cfcec29321dcf0b0032b184 | Xidorn Quan | 2018-04-11T03:46:08 | Bug 1452542 part 4 - Have ENABLED_IN flags in nsCSSPropList.h match those in Servo side. r=emilio
MozReview-Commit-ID: 48t5u1D5rZX | diff --git a/style/properties/longhand/ui.mako.rs b/style/properties/longhand/ui.mako.rs
index 5f2215760..cddc689e6 100644
--- a/style/properties/longhand/ui.mako.rs
+++ b/style/properties/longhand/ui.mako.rs
@@ -41,19 +41,20 @@ ${helpers.single_keyword("-moz-window-shadow", "none default menu tooltip sheet"
... | 1 | 3 | 3 |
cfb3fc8dfad390f0ef1c5f5c86cdf660e69aff35 | Emilio Cobos Álvarez | 2018-04-10T22:46:39 | servo: Merge #20616 - style: Simplify border-image-repeat serialization (from emilio:border-image-repeat); r=nox
We're the only ones to preserve explicitly the second keyword, as noticed in:
https://github.com/w3c/web-platform-tests/pull/10170
Reland of #20610 because it got backed out because I wasn't paying atte... | diff --git a/style/values/computed/border.rs b/style/values/computed/border.rs
index 49b9eeda7..dc6333ccb 100644
--- a/style/values/computed/border.rs
+++ b/style/values/computed/border.rs
@@ -5,10 +5,8 @@
//! Computed types for CSS values related to borders.
use app_units::Au;
-use std::fmt::{self, Write};
-use st... | 2 | 28 | 53 |
c38ad6eb47fc2de9de7b39c115b0902a23240b96 | Alan Jeffrey | 2018-04-10T19:10:07 | servo: Merge #20614 - Use the incumbent global as the source of x-origin postMessage (from asajeffrey:script-dissimilar-orgin-postMessage-from-incumbent); r=cbrewster
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the ... | diff --git a/script/dom/dissimilaroriginwindow.rs b/script/dom/dissimilaroriginwindow.rs
index 602338be2..846ce9ca0 100644
--- a/script/dom/dissimilaroriginwindow.rs
+++ b/script/dom/dissimilaroriginwindow.rs
@@ -192,9 +192,13 @@ impl DissimilarOriginWindowMethods for DissimilarOriginWindow {
impl DissimilarOriginWi... | 1 | 5 | 1 |
1552b78fb7d65840c62a257f96a69f840801b7b3 | Gurzau Raul | 2018-04-10T16:42:20 | Backed out changeset d186bcce1235 for failing on layout/style/test/test_shorthand_property_getters.html on a CLOSED TREE | diff --git a/style/values/computed/border.rs b/style/values/computed/border.rs
index dc6333ccb..49b9eeda7 100644
--- a/style/values/computed/border.rs
+++ b/style/values/computed/border.rs
@@ -5,8 +5,10 @@
//! Computed types for CSS values related to borders.
use app_units::Au;
+use std::fmt::{self, Write};
+use st... | 2 | 53 | 28 |
0e734ce659c0ba07ce128cbcd3062d0788a03870 | Emilio Cobos Álvarez | 2018-04-10T12:49:28 | servo: Merge #20610 - style: Simplify border-image-repeat serialization (from emilio:border-image-repeat); r=nox
We're the only ones to preserve explicitly the second keyword, as noticed in:
https://github.com/w3c/web-platform-tests/pull/10170
Source-Repo: https://github.com/servo/servo
Source-Revision: 07dd37a0cf... | diff --git a/style/values/computed/border.rs b/style/values/computed/border.rs
index 49b9eeda7..dc6333ccb 100644
--- a/style/values/computed/border.rs
+++ b/style/values/computed/border.rs
@@ -5,10 +5,8 @@
//! Computed types for CSS values related to borders.
use app_units::Au;
-use std::fmt::{self, Write};
-use st... | 2 | 28 | 53 |
812d4dd194fcb4e82fd3af410c07b4a8a11dfa40 | Anthony Ramine | 2018-04-10T08:28:40 | servo: Merge #20598 - Four nondescript WebGL improvements (from servo:webgl); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: ce72e526566de70ed71684ebc39a531f59c92aa5 | diff --git a/script/dom/webgl_validations/tex_image_2d.rs b/script/dom/webgl_validations/tex_image_2d.rs
index dc1807299..8a1b9ad9c 100644
--- a/script/dom/webgl_validations/tex_image_2d.rs
+++ b/script/dom/webgl_validations/tex_image_2d.rs
@@ -151,6 +151,13 @@ impl<'a> WebGLValidator for CommonTexImage2DValidator<'a> ... | 3 | 11 | 10 |
8d1331952f8ab82f489fe33abe8200247f9b9638 | Emilio Cobos Álvarez | 2018-04-10T06:16:30 | servo: Merge #20606 - style: Implement the functional :host(..) selector (from emilio:host); r=xidorn
We could invalidate in a slightly more fine-grained way, but I don't think it's
worth the churn vs. keeping the special-cases minimal.
Bug: 1452640
Reviewed-by: xidorn
MozReview-Commit-ID: 5DkQrgwg9GW
Source-Repo: ht... | diff --git a/selectors/builder.rs b/selectors/builder.rs
index b81c729ee..d4ed2d309 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -314,7 +314,7 @@ fn complex_selector_specificity<Impl>(mut iter: slice::Iter<Component<Impl>>)
Component::FirstChild | Component::LastChild |
Comp... | 8 | 82 | 47 |
9ab3ca5355a6c96e00b6a3fdd9f5b41c29a4069f | Simon Sapin | 2018-04-09T19:44:16 | servo: Merge #20474 - Use new std::num::NonZero* types instead of deprecated core::nonzero::NonZero (from servo:nonzero); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: bfb9fe6159ba61f0155a5ecc5a473b2a3edd6ef6 | diff --git a/canvas_traits/webgl.rs b/canvas_traits/webgl.rs
index 4c7e692e9..cbb088e71 100644
--- a/canvas_traits/webgl.rs
+++ b/canvas_traits/webgl.rs
@@ -3,7 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use euclid::Size2D;
-use nonzero::NonZero;
+use nonzero::NonZeroU32;
use offscreen_... | 8 | 104 | 137 |
dfbe895e14cf05c5efd0489664e02618b92746fa | Emilio Cobos Álvarez | 2018-04-09T10:41:59 | servo: Merge #20597 - style: Implement the non-functional :host selector (from emilio:host); r=xidorn
Kinda tricky because :host only matches rules on the shadow root where the rules
come from. So we need to be careful during invalidation and style sharing.
I didn't use the non_ts_pseudo_class_list bits because as so... | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 2220477b5..b81c729ee 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -314,6 +314,7 @@ fn complex_selector_specificity<Impl>(mut iter: slice::Iter<Component<Impl>>)
Component::FirstChild | Component::LastChild |
Comp... | 12 | 240 | 135 |
a7b61f868ce06b2407ae2ea7e77c8980cdc9e02a | Xidorn Quan | 2018-04-09T09:19:48 | servo: Merge #20592 - Use Servo code to check whether a property is inherited (from upsuper:is-inherited); r=emilio
This is the Servo side change of [bug 1452534](https://bugzilla.mozilla.org/show_bug.cgi?id=1452534).
Source-Repo: https://github.com/servo/servo
Source-Revision: 0f20e82690db5e865b12eef2bed2d787d4b0228... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 8c2376ecf..39e9b25fa 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -826,7 +826,8 @@ impl LonghandId {
}
}
- fn inherited(&self) -> bool {
+ /// Returns wheth... | 1 | 2 | 1 |
109e92b25297d6a0d1cea687756744deb14676e7 | Manish Goregaokar | 2018-04-09T05:47:58 | servo: Merge #20575 - Use correct filler y value when animating with an implied-y translate()s (from Manishearth:filler-y); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1451724
Source-Repo: https://github.com/servo/servo
Source-Revision: e460b4ab8a9abfe70d0cac9cf03160510f791b7c | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index bb6931cdd..237cf021b 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1204,7 +1204,8 @@ impl Animate for Computed... | 1 | 2 | 1 |
80065c581c99e88385ed42c44c174e2ec70dedcf | Emilio Cobos Álvarez | 2018-04-07T15:07:55 | servo: Merge #20586 - style: Respect the -moz- gradient pref again (from emilio:moz-gradient-pref); r=xidorn
This hopefully allows us to unship them eventually.
Bug: 1451874
Reviewed-by: xidorn
MozReview-Commit-ID: 2MDRZLmLMM0
Source-Repo: https://github.com/servo/servo
Source-Revision: 954ac8157f1acac6454ced09bfc948... | diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs
index 844e50cbf..9bf565ac6 100644
--- a/style/values/specified/image.rs
+++ b/style/values/specified/image.rs
@@ -227,9 +227,21 @@ impl Parse for Gradient {
let (shape, repeating, mut compat_mode) = match result {
Som... | 1 | 13 | 1 |
4b048a5cebeb2606799db359b31512e8270e0515 | Emilio Cobos Álvarez | 2018-04-07T14:10:35 | servo: Merge #20583 - selectors: Don't serialize :nth-child(-n) as -1n (from emilio:affine-stuff); r=upsuper
Source-Repo: https://github.com/servo/servo
Source-Revision: ecfcf35c26e789bacd2c46786bf0d75f0b20944f | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 601b7e239..9f33683b9 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -1021,6 +1021,7 @@ impl<Impl: SelectorImpl> ToCss for Component<Impl> {
(0, 0) => dest.write_char('0'),
(1, 0) => dest.write_char('n'),
+ ... | 1 | 1 | 0 |
dbf0a4b4fcdfbb80c05229e8106853716aec6395 | Xidorn Quan | 2018-04-07T13:18:28 | servo: Merge #20582 - Have CSSOM append rather than replace slot in declaration block (from upsuper:cssom-append); r=emilio
The early return for identical setting in importance matching as well as the comment before `index_to_remove` are removed because the order is web-exposing regardless of whether it's from CSSOM o... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index c2d7b42ca..58c4bd97e 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -518,53 +518,33 @@ impl PropertyDeclarationBlock {
}
let important =... | 1 | 21 | 41 |
2024b9b0e8216ef68c6fb4f98b10d586312f88a8 | Ramshell | 2018-04-06T23:48:59 | servo: Merge #20573 - Add support for percentages in column-gap (from Ramshell:issue/20498); r=mbrubeck
<!-- Please describe your changes on the following line: -->
# Changes in this PR
* I've removed the `if product == "gecko"` line in order to make the column_gap type "NonNegativeLengthOrPercentageOrNormal" always.
... | diff --git a/layout/multicol.rs b/layout/multicol.rs
index 22f8e3e24..3659d50e2 100644
--- a/layout/multicol.rs
+++ b/layout/multicol.rs
@@ -106,9 +106,8 @@ impl Flow for MulticolFlow {
{
let column_style = self.block_flow.fragment.style.get_column();
- // FIXME(#20498): This should s... | 2 | 4 | 8 |
8b54d021d71d23d92e126a3083378c6ac5c14632 | Bobby Holley | 2018-04-06T21:33:07 | servo: Merge #20577 - Avoid Gecko Namespace registration from Servo (from bholley:no_namespace_registration); r=upsuper
https://bugzilla.mozilla.org/show_bug.cgi?id=1451421
Source-Repo: https://github.com/servo/servo
Source-Revision: db9ab0440a75b8663efb816edc2b66faca59a1fd | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 115f83f51..90853e851 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1596,9 +1596,6 @@ extern "C" {
extern "C" {
pub fn Gecko_AddPropertyToSet(arg1: nsCSSPropertyIDSetBorrowedMut, ar... | 8 | 155 | 86 |
a39a64cfaff043de8346675c8fb37dafe0dcef2a | Jonathan Watt | 2018-04-06T13:22:33 | servo: Merge #20572 - Stop using NS_STYLE_FONT_WEIGHT_NORMAL and NS_STYLE_FONT_WEIGHT_BOLD (from jwatt:master); r=emilio
The Servo side of the changes for
https://bugzilla.mozilla.org/show_bug.cgi?id=1452040
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- ... | diff --git a/style/gecko/rules.rs b/style/gecko/rules.rs
index 20d438d21..790124c5f 100644
--- a/style/gecko/rules.rs
+++ b/style/gecko/rules.rs
@@ -33,9 +33,9 @@ impl<'a> ToNsCssValue for &'a FontWeight {
fn convert(self, nscssvalue: &mut nsCSSValue) {
match *self {
FontWeight::Normal =>
- ... | 1 | 2 | 2 |
66ddd4f030c00c4e6ba4358289ca9b2baef8b427 | Bastien Orivel | 2018-04-06T12:14:00 | servo: Merge #20486 - Bump walkdir (from Eijebong:walkdir); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: ad4905cb900925107c06b655109e373c48450464 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index ee9f914ff..504be54c3 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -80,5 +80,5 @@ lazy_static = "1"
log = "0.4"
bindgen = { version = "0.33.2", optional = true, default-features = false }
regex = {version = "0.2", optional = true}
-walkdir = "1.0"
+wal... | 1 | 1 | 1 |
6c4345a545480a79939ef1f3b471a6cc847a6df8 | Emilio Cobos Álvarez | 2018-04-06T11:11:37 | servo: Merge #20571 - style: Don't restrict alignment shorthand parsing now that's not ambiguous (from emilio:align-shorthands-again); r=mats
Bug: 1339656
Reviewed-by: mats
MozReview-Commit-ID: AnYBt6zwnPl
Source-Repo: https://github.com/servo/servo
Source-Revision: 646e4873095a62e3bc525322dc49ed3b58e2db61 | diff --git a/style/properties/shorthand/position.mako.rs b/style/properties/shorthand/position.mako.rs
index 2c58895c9..e5b07d616 100644
--- a/style/properties/shorthand/position.mako.rs
+++ b/style/properties/shorthand/position.mako.rs
@@ -52,15 +52,19 @@
use values::specified::NonNegativeNumber;
use propert... | 2 | 61 | 85 |
c09f27e771282fba25479839c362ee4c7ac6ae96 | Anthony Ramine | 2018-04-06T09:52:06 | servo: Merge #20565 - Daily batch of drive-by WebGL improvements, wholesome and gluten-free (from servo:webgl); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: c09662993951df7e319fbec831db1ee959c3fd6f | diff --git a/script/dom/webglrenderbuffer.rs b/script/dom/webglrenderbuffer.rs
index feac4eed4..a672f9faa 100644
--- a/script/dom/webglrenderbuffer.rs
+++ b/script/dom/webglrenderbuffer.rs
@@ -95,11 +95,14 @@ impl WebGLRenderbuffer {
// validation.
match internal_format {
constants::RGBA4... | 2 | 9 | 11 |
213bd892a0623568d972f64825fc51ebed280cf0 | Anthony Ramine | 2018-04-05T07:31:41 | servo: Merge #20539 - Moar WebGL improvements, again (from servo:webgl); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 4645e5bda38d057deb23ca8bc95c2f1d696a180d | diff --git a/canvas/webgl_thread.rs b/canvas/webgl_thread.rs
index bba93918c..7bcb303bb 100644
--- a/canvas/webgl_thread.rs
+++ b/canvas/webgl_thread.rs
@@ -678,8 +678,9 @@ impl WebGLImpl {
ctx.gl().clear(mask),
WebGLCommand::ClearColor(r, g, b, a) =>
ctx.gl().clear_color(... | 4 | 49 | 54 |
df6a5ef9cc155655b98226de3199584e02f87609 | Xidorn Quan | 2018-04-03T23:33:59 | servo: Merge #20519 - Use Servo data to back @font-face rule in Gecko (from upsuper:font-face-rule); r=emilio
This is the Servo side change of [bug 1449087](https://bugzilla.mozilla.org/show_bug.cgi?id=1449087).
Source-Repo: https://github.com/servo/servo
Source-Revision: 34b13dac66b48790003ccd069f4636f1def77e7d | diff --git a/style/font_face.rs b/style/font_face.rs
index 7e4b45c24..885a4f39f 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -13,7 +13,6 @@ use computed_values::{font_stretch, font_style, font_weight};
use cssparser::{AtRuleParser, DeclarationListParser, DeclarationParser, Parser};
use cssparser::{Sour... | 9 | 216 | 441 |
b7d06fd4ea81d64176883e55696a00e03e859997 | Fausto Núñez Alberro | 2018-04-03T22:12:13 | servo: Merge #20482 - Implement a URL-generic type for ListStyleImage (from brainlessdeveloper:list-style-image-computed); r=emilio
<!-- Please describe your changes on the following line: -->
This should fix the following two "expected to fail" tests described in https://github.com/servo/servo/issues/18015:
- getCo... | diff --git a/layout/construct.rs b/layout/construct.rs
index 3849e43ad..291e8941e 100644
--- a/layout/construct.rs
+++ b/layout/construct.rs
@@ -52,11 +52,10 @@ use style::context::SharedStyleContext;
use style::dom::TElement;
use style::logical_geometry::Direction;
use style::properties::ComputedValues;
-use style:... | 23 | 132 | 110 |
81f0ea04043c39108c1a4d0064471177e80f9bf8 | Bastien Orivel | 2018-04-03T13:14:41 | servo: Merge #20517 - Fix the env_logger update (from Eijebong:fix_log); r=mbrubeck
When building an env_logger, we need to pass it the environment,
otherwise it just takes some defaults and doesn't log anything.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6b7957d9a009af5e5b5d36df70f100a5b5b64917 | diff --git a/servo/lib.rs b/servo/lib.rs
index 6de31837e..1d8e64ab8 100644
--- a/servo/lib.rs
+++ b/servo/lib.rs
@@ -404,13 +404,15 @@ impl<Window> Servo<Window> where Window: WindowMethods + 'static {
pub fn setup_logging(&self) {
let constellation_chan = self.constellation_chan.clone();
- let e... | 1 | 10 | 6 |
39d3735a4aaa163c9e4aff57d1adee7f8779bcc3 | Nicholas Nethercote | 2018-04-03T05:54:24 | servo: Merge #20508 - Convert StylePrefs to StaticPrefs (from nnethercote:bug-1448225); r=emilio
<!-- Please describe your changes on the following line: -->
This is the Servo part of https://bugzilla.mozilla.org/show_bug.cgi?id=1448225.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]`... | diff --git a/style/font_face.rs b/style/font_face.rs
index 96a13416f..7e4b45c24 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -224,13 +224,13 @@ macro_rules! is_descriptor_enabled {
("font-display") => {
unsafe {
use gecko_bindings::structs::mozilla;
- mozilla::StyleP... | 9 | 46 | 46 |
5038db6f5a6f70842a93d5fa6ebd42cb80fb40fe | Brody Eastwood | 2018-04-03T02:24:34 | servo: Merge #20447 - NCSU Canvas Rendering Project Initial Steps (from Brody-Eastwood:master); r=jdm
<!-- Please describe your changes on the following line: -->
Implements the initial steps from:
https://github.com/servo/servo/wiki/Canvas-rendering-project
---
<!-- Thank you for contributing to Servo! Please repla... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index d464f6488..cf1e3a79b 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -64,6 +64,7 @@ pub struct CanvasPaintThread<'a> {
old_image_key: Option<webrender_api::ImageKey>,
/// An old webrender image k... | 11 | 167 | 153 |
4d9c93a3738fef36821262db07c3eaa3e8368788 | Emilio Cobos Álvarez | 2018-04-02T17:36:01 | servo: Merge #20501 - style: Use a more consistent style for parsing functions (from emilio:parsing-style); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: a208d4246cf0e02a1a22196f26692bd29fb35011 | diff --git a/style/properties/longhand/svg.mako.rs b/style/properties/longhand/svg.mako.rs
index 691b68704..bea30301e 100644
--- a/style/properties/longhand/svg.mako.rs
+++ b/style/properties/longhand/svg.mako.rs
@@ -139,8 +139,10 @@ ${helpers.single_keyword("mask-origin",
background_size::get_initial_value()
... | 14 | 126 | 69 |
5af5da04211dee9259e2abfb1dc62e49a595d777 | Emilio Cobos Álvarez | 2018-04-02T16:09:29 | servo: Merge #20481 - style: Derive a debug impl instead of implementing by hand (from emilio:debug-wat); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 39018f933997e266e11968d82f556af15c5321d8 | diff --git a/style/values/generics/image.rs b/style/values/generics/image.rs
index ca041d5ed..e5e725ebe 100644
--- a/style/values/generics/image.rs
+++ b/style/values/generics/image.rs
@@ -120,7 +120,7 @@ pub enum GradientItem<Color, LengthOrPercentage> {
/// A color stop.
/// <https://drafts.csswg.org/css-images/#... | 1 | 1 | 13 |
d480804b645fa03cbacb7f17eebd6198a3364b30 | Josh Matthews | 2018-04-02T14:40:02 | servo: Merge #20504 - Hide non-Servo heap measurement (from jdm:unbreak); r=bustage
This hides the changes in #20391 from Gecko builds that use the malloc_size_of crate.
Source-Repo: https://github.com/servo/servo
Source-Revision: c0bf170a11f61e721ee88d661fa0d97a464fbb69 | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index b7a0b805b..829f812df 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -10,9 +10,13 @@ path = "lib.rs"
[features]
servo = [
+ "hyper",
+ "hyper_serde",
"mozjs",
+ "serde",
"serde_bytes",
"string_... | 2 | 21 | 4 |
f089a69403e1174b15072f99f5566a88c703d911 | modal-d17 | 2018-04-02T06:01:50 | servo: Merge #20391 - Measure cache memory usage (from modal17:iss19251); r=jdm
<!-- Please describe your changes on the following line: -->
- [X] make the memory cache data structure derive MallocSizeOf
- [X] add a new IpcReceiver argument to ResourceChannelManager::start that is used for listening to messages from t... | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index 73f65c95a..b7a0b805b 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -23,13 +23,17 @@ app_units = "0.6"
cssparser = "0.23.0"
euclid = "0.17"
hashglobe = { path = "../hashglobe" }
+hyper = "0.10"
+hyper_serde = "0.8"
m... | 12 | 303 | 76 |
190d60cd2c966d68d3dd8ab08d1b1b47729ff975 | Emilio Cobos Álvarez | 2018-04-02T01:18:27 | servo: Merge #20500 - style: Add support for 'flex-basis:content' in the style system (from emilio:1105111); r=xidorn
Bug: 1105111
Reviewed-by: xidorn
MozReview-Commit-ID: 5WhgHJJ0mDB
Source-Repo: https://github.com/servo/servo
Source-Revision: ca7463df9ee6f7d3886c2bbcb2d0842f24c4abf7 | diff --git a/layout/flex.rs b/layout/flex.rs
index 58abdee6c..42ed7910b 100644
--- a/layout/flex.rs
+++ b/layout/flex.rs
@@ -75,28 +75,16 @@ impl AxisSize {
fn from_flex_basis(
flex_basis: FlexBasis,
main_length: LengthOrPercentageOrAuto,
- containing_length: Option<Au>
+ containing_length: Au,
) -> M... | 13 | 198 | 105 |
a7702833d955debaeceb0e7d075ab680bbe2fd00 | Mats Palmgren | 2018-04-01T22:59:15 | servo: Merge #20499 - style: Implement percentages for 'column-gap' (from emilio:1398537); r=emilio,dholbert
Bug: 1398537
Reviewed-by: emilio,dholbert
Source-Repo: https://github.com/servo/servo
Source-Revision: 1e2411d2c50f87e2fbcfc91167029bd345649653 | diff --git a/layout/multicol.rs b/layout/multicol.rs
index 6eb8ac6ec..22f8e3e24 100644
--- a/layout/multicol.rs
+++ b/layout/multicol.rs
@@ -106,6 +106,7 @@ impl Flow for MulticolFlow {
{
let column_style = self.block_flow.fragment.style.get_column();
+ // FIXME(#20498): This should s... | 5 | 26 | 12 |
64b832cc9efffffd96bd9a7bd4bd4c159b6c39fc | Li Hao Tan | 2018-04-01T16:00:08 | servo: Merge #20495 - Move `text-emphasis-position` outside of mako (from LiHaoTan:move-text-emphasis-position); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appro... | diff --git a/style/properties/longhand/inherited_text.mako.rs b/style/properties/longhand/inherited_text.mako.rs
index 9e9c27ee7..99efd55c6 100644
--- a/style/properties/longhand/inherited_text.mako.rs
+++ b/style/properties/longhand/inherited_text.mako.rs
@@ -206,93 +206,15 @@ ${helpers.predefined_type(
spec="htt... | 5 | 113 | 89 |
c494e208176da328725d3bf349bedde5248b60dc | Emilio Cobos Álvarez | 2018-03-31T00:31:36 | servo: Merge #20479 - style: Add a fast path to each_anonymous_content_child (from emilio:anon-child-bit); r=upsuper
If we know that we don't have anon children it is pointless to go through FFI.
Source-Repo: https://github.com/servo/servo
Source-Revision: 107fd47b93e5e8586ca27293052b9fedc75b88e4 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index ae8612fa4..6902093be 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1121,6 +1121,10 @@ impl<'le> TElement for GeckoElement<'le> {
where
F: FnMut(Self),
{
+ if !self.may_have_anonymous_children() {
+ ... | 1 | 4 | 0 |
33cb889993f33fbe5a7ea3045f1fc54eca5df2d3 | Emilio Cobos Álvarez | 2018-03-29T13:12:45 | servo: Merge #20454 - Update to rustc 1.25.0-nightly (bacb5c58d 2018-01-26) (from emilio:rustup); r=SimonSapin
Update to rust version 1.26.0-nightly (188e693b3 2018-03-26)
Source-Repo: https://github.com/servo/servo
Source-Revision: d232705106478e0a2e5de78f8b40144408879c36 | diff --git a/selectors/attr.rs b/selectors/attr.rs
index 8ef4365d7..c912f7f8b 100644
--- a/selectors/attr.rs
+++ b/selectors/attr.rs
@@ -4,7 +4,6 @@
use cssparser::ToCss;
use parser::SelectorImpl;
-#[allow(unused_imports)] use std::ascii::AsciiExt;
use std::fmt;
#[derive(Clone, Eq, PartialEq)]
diff --git a/sele... | 3 | 0 | 3 |
3ea22276bb1892030228cafb01ddeefc2661a2f7 | Bastien Orivel | 2018-03-28T21:18:31 | servo: Merge #20468 - Fix style/build_gecko.rs for log 0.4 on a CLOSED TREE (from Eijebong:fix_log); r=mbrubeck
Fix style/build_gecko.rs for log 0.4
Source-Repo: https://github.com/servo/servo
Source-Revision: c8b0dc965d02754622c766017c2fec4145a2f15e | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 0ff056049..affe3ecf2 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -448,11 +448,11 @@ mod bindings {
}
impl log::Log for BuildLogger {
- fn enabled(&self, meta: &log::LogMetadata) -> bool {
+ fn en... | 1 | 14 | 8 |
3b722f0ca8f1f83718d4e0b3a030a47eaf475ee4 | Bastien Orivel | 2018-03-28T19:08:52 | servo: Merge #20465 - Bump env_logger to 0.5 and log to 0.4 in every servo crate (from Eijebong:log); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 12d82fe621947c2b29b12d9c9e9a81b0f4baa117 | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index d99b799ce..b673e430d 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -18,7 +18,7 @@ euclid = "0.17"
fnv = "1.0"
gleam = "0.4.29"
ipc-channel = "0.10"
-log = "0.3.5"
+log = "0.4"
num-traits = "0.1.32"
offscreen_gl_context = { version = "0.15", featu... | 29 | 75 | 68 |
ef8bd5ddb61e7470b160cdc2e1cba6cdf56ddf06 | Xidorn Quan | 2018-03-28T12:15:14 | servo: Merge #20460 - Remove StyleBackendType uses (from upsuper:remove-stylebackendtype); r=emilio
This is the Servo side change of [bug 1447828](https://bugzilla.mozilla.org/show_bug.cgi?id=1447828).
Source-Repo: https://github.com/servo/servo
Source-Revision: 433d2f65778c955854a5cd911fc62878524be610 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 9c32d301c..ae8612fa4 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1190,7 +1190,6 @@ impl<'le> TElement for GeckoElement<'le> {
let base_declaration: &structs::DeclarationBlock =
slots.mSMILOverrideSt... | 1 | 0 | 1 |
83cb41dc1f188c3ecb88bf1203279205940dd516 | Yusuf Simonson | 2018-03-28T02:44:32 | servo: Merge #20450 - Properly rethrow any exceptions from parsing JSON in Body mixin's `Json()` (from ysimonson:fix-13464); r=jdm
This fixes #13464 by rethrowing exceptions from parsing JSON.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fi... | diff --git a/script/body.rs b/script/body.rs
index 35ee2dae2..1ae05e4b0 100644
--- a/script/body.rs
+++ b/script/body.rs
@@ -16,8 +16,10 @@ use js::jsapi::Heap;
use js::jsapi::JSContext;
use js::jsapi::JSObject;
use js::jsapi::JS_ClearPendingException;
+use js::jsapi::JS_GetPendingException;
use js::jsapi::JS_Parse... | 1 | 8 | 3 |
1eb427ecabba9e7b47d53782ffc1459c967d9f50 | Anthony Weston | 2018-03-28T01:21:56 | servo: Merge #20430 - Pass new method in CollectServoSizes to get size of ObjectPrivateVisitor (from aeweston98:aew-issue7084); r=jdm
<!-- Please describe your changes on the following line: -->
These changes are the servo changes to allow the measurement of DOM objects with the ObjectPrivateVisitor API. Two new funct... | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index 41d9a9cc9..45af5d4d7 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -23,7 +23,7 @@ app_units = "0.6"
cssparser = "0.23.0"
euclid = "0.17"
hashglobe = { path = "../hashglobe" }
-mozjs = { version = "0.4", features = ["... | 6 | 42 | 49 |
b06b597fc76188cc5e44551befcf055831997c40 | Xidorn Quan | 2018-03-27T22:51:48 | servo: Merge #20456 - Remove nsCSSPseudoClasses and friends (from upsuper:remove-nscsspseudoclasses); r=emilio
This is the Servo side change of [bug 1449097](https://bugzilla.mozilla.org/show_bug.cgi?id=1449097) and [bug 1449089](https://bugzilla.mozilla.org/show_bug.cgi?id=1449089).
Source-Repo: https://github.com/s... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 4e76b4679..024016645 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -54,7 +54,6 @@ use gecko_bindings::structs::RawServoSelectorList;
use gecko_bindings::structs::RawServoSourceSizeList;
... | 5 | 58 | 160 |
606571985894f863683563b1bb0b11c37b414812 | Xidorn Quan | 2018-03-27T06:56:25 | servo: Merge #20444 - Add comment for overflow-{x,y} applying to ::placeholder (from upsuper:overflow-placeholder); r=emilio
Add comment based on [flags in nsCSSPropList.h](https://searchfox.org/mozilla-central/rev/003262ae12ce937950ffb8d3b0fa520d1cc38bff/layout/style/nsCSSPropList.h#3244,3256).
Source-Repo: https://... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index d0da5476b..e606f081c 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -205,6 +205,8 @@ ${helpers.single_keyword("-servo-overflow-clip-box", "padding-box content-box",
%>
... | 1 | 4 | 0 |
64a47b625ce036d379283f28b1edf33e74bc62de | csmoe | 2018-03-26T19:42:03 | servo: Merge #20307 - Measure time required before a layout query is serviced by the layout thread (from csmoe:measure_query_time); r=jdm
<!-- Please describe your changes on the following line: -->
- [X] extract QueryMsg from ReflowGoal
- [X] introduce QueryMsg timestamp
---
<!-- Thank you for contributing to Servo... | diff --git a/layout_thread/Cargo.toml b/layout_thread/Cargo.toml
index f7cffec34..e7c54e353 100644
--- a/layout_thread/Cargo.toml
+++ b/layout_thread/Cargo.toml
@@ -19,6 +19,7 @@ euclid = "0.17"
fnv = "1.0"
gfx = {path = "../gfx"}
gfx_traits = {path = "../gfx_traits"}
+histogram = "0.6.8"
html5ever = "0.22"
ipc-ch... | 7 | 209 | 156 |
a9b0545c008b5a8110134ea7e4559d0887a1e2c0 | Anthony Ramine | 2018-03-26T18:49:16 | servo: Merge #20423 - Use ByteBuf for the canvas messages (from servo:bytes); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 9c5bdd932e4ce8720e25241cb1bbdd85be3c92a5 | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index 576f948e4..d99b799ce 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -21,6 +21,7 @@ ipc-channel = "0.10"
log = "0.3.5"
num-traits = "0.1.32"
offscreen_gl_context = { version = "0.15", features = ["serde", "osmesa"] }
+serde_bytes = "0.10"
servo_conf... | 18 | 166 | 62 |
f1d04ec801f6c3b5a3ed3c7b58cc1470b2209cf2 | OJ Kwon | 2018-03-26T16:05:24 | servo: Merge #20439 - refactor(websocket): do not borrow sender anymore (from kwonoj:refactor-websocket-send); r=jdm
<!-- Please describe your changes on the following line: -->
Relates to #20438.
Per instructed, this PR aim to remove borrwing `Websocket::sender`, by explicitly injecting instance via ctor.
---
<!-- ... | diff --git a/script/dom/websocket.rs b/script/dom/websocket.rs
index c072f4bb0..031741db0 100644
--- a/script/dom/websocket.rs
+++ b/script/dom/websocket.rs
@@ -106,27 +106,27 @@ pub struct WebSocket {
buffered_amount: Cell<u64>,
clearing_buffer: Cell<bool>, //Flag to tell if there is a running thread to clea... | 1 | 13 | 25 |
340b5e9c2725c4bc5e1b301b16ccf2e7f40bd0be | Nicholas Nethercote | 2018-03-26T08:08:14 | servo: Merge #20433 - Statically allocate static atoms (from nnethercote:bug-1411469); r=froydnj
<!-- Please describe your changes on the following line: -->
This is the Servo part of bug 1411469.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace ... | diff --git a/style/gecko/generated/structs.rs b/style/gecko/generated/structs.rs
index ddb76282f..923b16f41 100644
--- a/style/gecko/generated/structs.rs
+++ b/style/gecko/generated/structs.rs
@@ -17188,26 +17188,25 @@ pub mod root {
pub struct nsAtom {
pub _bitfield_1: root::__BindgenBitfieldUnit<[u8; 4u... | 2 | 58 | 23 |
35535c67859753a78b8c14b8c49275fd884b8379 | Bastien Orivel | 2018-03-25T19:11:29 | servo: Merge #20402 - Dedupe lazy_static (from Eijebong:lazy_static); r=emilio
:tada: :tada: :tada:
Source-Repo: https://github.com/servo/servo
Source-Revision: 34f388229df4f201302ee51a8969c0556692bf0b | diff --git a/net/connector.rs b/net/connector.rs
index 659fb4b6a..58cfc8c3e 100644
--- a/net/connector.rs
+++ b/net/connector.rs
@@ -52,12 +52,9 @@ pub type Connector = HttpsConnector;
pub fn create_ssl_client(ca_file: &PathBuf) -> OpensslClient {
let mut ssl_connector_builder = SslConnectorBuilder::new(SslMeth... | 1 | 3 | 6 |
25f1be57d94de1a7cbdf8941f7bb41b880e00576 | Emilio Cobos Álvarez | 2018-03-24T23:05:47 | servo: Merge #20419 - Update mozjs (from emilio:mozjs-up); r=jdm
Peeks up https://github.com/servo/rust-mozjs/pull/408.
Source-Repo: https://github.com/servo/servo
Source-Revision: b8279b376bb4b6118c5a65fa6aeaf5a08c6e953b | diff --git a/script/dom/dommatrix.rs b/script/dom/dommatrix.rs
index f5658a943..5cbe4ad9b 100644
--- a/script/dom/dommatrix.rs
+++ b/script/dom/dommatrix.rs
@@ -61,8 +61,8 @@ impl DOMMatrix {
// https://drafts.fxtf.org/geometry-1/#dom-dommatrix-fromfloat32array
pub fn FromFloat32Array(
global: &Globa... | 4 | 121 | 77 |
b039644a992ea4c4b19512e92929ae94285b3fe0 | Anthony Ramine | 2018-03-24T18:58:38 | servo: Merge #20414 - Implement gl.getParameter(gl.ALIASED_POINT_SIZE_RANGE) (from servo:webgl); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 782d4d4af61b7c9f60dfb494f8a5bfb6407945d2 | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index 604fb4e16..576f948e4 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -16,7 +16,7 @@ compositing = {path = "../compositing"}
cssparser = "0.23.0"
euclid = "0.17"
fnv = "1.0"
-gleam = "0.4"
+gleam = "0.4.29"
ipc-channel = "0.10"
log = "0.3.5"
num-tr... | 7 | 18 | 5 |
9862cd78972797b63370fd104b6c0c1626109206 | Anthony Ramine | 2018-03-24T04:18:28 | servo: Merge #20400 - Implement HTMLCanvasElement.toDataURL for WebGL canvas (fixes #19147) (from servo:webgl); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 72f326b22bfa9dfae30941883979fd9f3090d044 | diff --git a/script/dom/htmlcanvaselement.rs b/script/dom/htmlcanvaselement.rs
index c866664cb..b1bea124a 100644
--- a/script/dom/htmlcanvaselement.rs
+++ b/script/dom/htmlcanvaselement.rs
@@ -345,11 +345,22 @@ impl HTMLCanvasElementMethods for HTMLCanvasElement {
... | 2 | 45 | 1 |
46f23d975d360e374987a385c5581f7ae69846b0 | MaximilianDauner | 2018-03-24T03:15:51 | servo: Merge #20404 - GamepadButtonList::sync_from_vr should use more iterators #20392 (from MaximilianDauner:issue_20392); r=jdm
<!-- Please describe your changes on the following line: -->
Used the zip function instead of iterating over both vectors with an indexing variable and using unwrap.
---
<!-- Thank you for... | diff --git a/script/dom/gamepadbuttonlist.rs b/script/dom/gamepadbuttonlist.rs
index 46f69fb97..24afa3b1b 100644
--- a/script/dom/gamepadbuttonlist.rs
+++ b/script/dom/gamepadbuttonlist.rs
@@ -37,10 +37,8 @@ impl GamepadButtonList {
}
pub fn sync_from_vr(&self, vr_buttons: &[WebVRGamepadButton]) {
- ... | 1 | 2 | 4 |
9aa436c8fa4c29573d5d8416094f7f95f8304093 | Igor Matuszewski | 2018-03-23T17:06:01 | servo: Merge #20399 - Sanitize Heap::handle(_mut) functions (from Xanewok:remove-heap-handle-mut); r=jdm
<!-- Please describe your changes on the following line: -->
Complementary to https://github.com/servo/rust-mozjs/pull/404.
Removing `Heap::handle_mut` didn't warrant any changes on Servo side, and so the changes ... | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index b9cb45d41..6f05c34f2 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -16,7 +16,7 @@ app_units = "0.6"
cssparser = "0.23.0"
euclid = "0.17"
hashglobe = { path = "../hashglobe" }
-mozjs = { version = "0.3", features = ["... | 6 | 26 | 7 |
6cd2711993ada27872396cc4949ab28b56aaa733 | OJ Kwon | 2018-03-23T06:30:49 | servo: Merge #20320 - feat(capture_webrender): write webrender revision into text (from kwonoj:feat-wr-revision); r=jdm
<!-- Please describe your changes on the following line: -->
Relates to https://github.com/servo/servo/pull/20315#issuecomment-373819735.
This PR try to generate `wr.txt` when trigger webrender capt... | diff --git a/compositing/Cargo.toml b/compositing/Cargo.toml
index 72851fbb8..8896f70d8 100644
--- a/compositing/Cargo.toml
+++ b/compositing/Cargo.toml
@@ -4,6 +4,7 @@ version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false
+build = "build.rs"
[lib]
name = "compositing"
... | 3 | 68 | 2 |
7fdb1e1e6265b3cfc8c220a5153cdab80950d77d | Glenn Watson | 2018-03-22T23:11:10 | servo: Merge #20395 - Update WR (accelerated webgl fix on mac, line decoration optimizations) (from glennw:update-wr-webgl); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 0dbacc76e7f801bd4815f488047f6e20f6aeedd8 | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index 8e7e26786..b3e6093f6 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -595,6 +595,7 @@ impl<'a> CanvasPaintThread<'a> {
format: webrender_api::ImageFormat::BGRA8,
offset: 0... | 5 | 3 | 10 |
7e5a645a1ef0d1ce862389f4179d006cd682cbe9 | Josh Matthews | 2018-03-22T22:20:38 | servo: Merge #20390 - Don't OOM when laying out basic web pages on Android (from jdm:android-layout-workaround); r=emilio
This is a workaround for the symptom described in https://github.com/servo/servo/issues/20149#issuecomment-375366991 which looks like either a standard library or compiler bug. My release android b... | diff --git a/layout/inline.rs b/layout/inline.rs
index 1918b2920..375f7460a 100644
--- a/layout/inline.rs
+++ b/layout/inline.rs
@@ -266,10 +266,10 @@ impl LineBreaker {
}
/// Reinitializes the pending line to blank data.
- fn reset_line(&mut self) -> Line {
+ fn reset_line(&mut self) {
self.... | 1 | 3 | 3 |
de8dc1f292f30357e9efdb43afec3f69422a8ba3 | Nakul Jindal | 2018-03-22T20:38:32 | servo: Merge #20132 - Profiler for blocked IpcReceiver::recv() (from nakul02:issue_19223); r=jdm
<!-- Please describe your changes on the following line: -->
Implements feature #19223
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with app... | diff --git a/profile/time.rs b/profile/time.rs
index c075272fb..6c1130345 100644
--- a/profile/time.rs
+++ b/profile/time.rs
@@ -10,7 +10,7 @@ use influent::create_client;
use influent::measurement::{Measurement, Value};
use ipc_channel::ipc::{self, IpcReceiver};
use profile_traits::energy::{energy_interval_ms, read... | 23 | 143 | 57 |
25d1a93274d38d11fb0baa18a0b369f1ba4accc2 | Paul Rouget | 2018-03-22T12:10:45 | servo: Merge #20228 - Ports refactoring (from paulrouget:ports_refactor); r=jdm
Depends on https://github.com/servo/servo/pull/20071 and https://github.com/servo/servo/pull/19895
This PR does 3 things:
1) merge all the embedder coordinates callbacks into one
2) hand the embedder messages directly to the embedder
3) s... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 2b409b7ae..ba31138d5 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -34,9 +34,9 @@ use style_traits::viewport::ViewportConstraints;
use time::{now, precise_time_ns, precise_time_s};
use touch::{TouchHandler, TouchActio... | 6 | 102 | 225 |
fe2cb4acf4cc7c2a1e3ce2652a4250f430bdeeb7 | OJ Kwon | 2018-03-21T22:18:55 | servo: Merge #20368 - refactor(counter_style): parse int via parse_non_negative (from kwonoj:refactor-counter-style); r=emilio
<!-- Please describe your changes on the following line: -->
Relates to #20332.
This PR intends to refactor `counter_style` to use `parse_non_negative` where applicable, mostly which uses `ex... | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index 475a2186b..8ef206fd6 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -299,7 +299,7 @@ counter_style_descriptors! {
/// <https://drafts.csswg.org/css-counter-styles/#counter-style-pad>
"pad" pad / eCSSCount... | 2 | 13 | 19 |
c31bd9d601b2e096c66a94b05b7f334961ab87a3 | Bastien Orivel | 2018-03-21T18:16:57 | servo: Merge #20378 - Bump parking_lot to 0.5 (from Eijebong:parking_lot); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 1c2bed5a6909268c85d61ec73b2ab63602294eb1 | diff --git a/layout/Cargo.toml b/layout/Cargo.toml
index 1dd6c1c73..e1d210be0 100644
--- a/layout/Cargo.toml
+++ b/layout/Cargo.toml
@@ -28,7 +28,7 @@ malloc_size_of = { path = "../malloc_size_of" }
msg = {path = "../msg"}
net_traits = {path = "../net_traits"}
ordered-float = "0.4"
-parking_lot = "0.4"
+parking_lot ... | 4 | 4 | 4 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.