commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
9acc55643515be3afe6c99283ca14625015be08e | Xidorn Quan | 2017-08-30T03:13:02 | servo: Merge #18302 - Harden assert for creating atom from raw pointer (from upsuper:atom-assert); r=bholley
One of Stylo's common assertion turns out to be from having a null Atom (see [Gecko 1385925 bug comment 7](https://bugzilla.mozilla.org/show_bug.cgi?id=1385925#c7)). It would be helpful if we can catch this kin... | diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs
index d83900970..3844ddc29 100644
--- a/style/gecko_string_cache/mod.rs
+++ b/style/gecko_string_cache/mod.rs
@@ -265,7 +265,7 @@ impl Atom {
/// called on it.
#[inline]
pub unsafe fn from_addrefed(ptr: *mut nsIAtom) -> Self {... | 1 | 2 | 2 |
715130f3f3fee396e92c0bf0141170c5e14bd7a2 | Pu Xingyu | 2017-08-30T00:15:59 | servo: Merge #18175 - layout: Stop call normal block size assignment for flex container (from stshine:no-floats-in-flexbox); r=mbrubeck
No need to call the `assign_block_size_block_base()` method of normal block in flex.rs since it is implemented for CSS2.
<!-- Please describe your changes on the following line: -->
... | diff --git a/layout/block.rs b/layout/block.rs
index 6124492dc..379b4f7fd 100644
--- a/layout/block.rs
+++ b/layout/block.rs
@@ -1429,6 +1429,9 @@ impl BlockFlow {
/// Determines the type of formatting context this is. See the definition of
/// `FormattingContextType`.
pub fn formatting_context_type(&sel... | 3 | 29 | 11 |
9558802f608fccf3eb910b407f96a5f6e07c89d2 | Emilio Cobos Álvarez | 2017-08-29T19:18:58 | servo: Merge #18268 - style: Recascade the document instead of using the dirty_on_viewport_size_change bit (from emilio:dirty-viewport-followup); r=SimonSapin
This allows us to simplify a lot of code.
On top of #18267.
Source-Repo: https://github.com/servo/servo
Source-Revision: 473934c989c94773c38f585b1c4500cd8c811... | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index d211ab880..d1eb7a1b2 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -38,7 +38,7 @@ use layout::data::StyleAndLayoutData;
use layout::wrapper::GetRawData;
use msg::constellation_msg::{BrowsingContextId, Pipe... | 13 | 13 | 181 |
cf89ddb2f363218f368ad128c195ab5593eb3068 | Paul Rouget | 2017-08-29T16:26:45 | servo: Merge #18295 - enable antialiasing by default (from paulrouget:better_default_options); r=jdm
This is not a problem for regular Servo because these values are toggled when the command line is parsed. But it's not the case when embedding Servo.
Source-Repo: https://github.com/servo/servo
Source-Revision: 62930d... | diff --git a/config/opts.rs b/config/opts.rs
index 45663c458..aa9a4bd0a 100644
--- a/config/opts.rs
+++ b/config/opts.rs
@@ -516,9 +516,9 @@ pub fn default_opts() -> Opts {
bubble_inline_sizes_separately: false,
show_debug_fragment_borders: false,
show_debug_parallel_layout: false,
- e... | 1 | 3 | 3 |
ba4d54f02f421705d9d4cb781243694db5e586cc | Josh Matthews | 2017-08-29T14:46:22 | servo: Merge #18290 - Report more specific CSS selector errors (from jdm:selectorerr); r=heycam
Report more specific errors for invalid CSS selectors. Reviewed by @heycam in https://bugzilla.mozilla.org/show_bug.cgi?id=1384216.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not r... | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 7195d63f1..99a8f0869 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -90,6 +90,12 @@ impl<Impl: SelectorImpl> SelectorBuilder<Impl> {
self.simple_selectors.is_empty()
}
+ /// Returns true if combinators have ever been push... | 3 | 110 | 81 |
f76adc2096240f81631a08e91268b906eb1e5993 | Emilio Cobos Álvarez | 2017-08-29T12:37:55 | servo: Merge #18293 - style: Box the PerPseudo<SelectorMap>, so we don't waste a lot of space (from emilio:selector-map-box); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: 5062dc5914d97e16b93c847574282067dcde49f7 | diff --git a/style/stylist.rs b/style/stylist.rs
index 14150c58a..98fa47bfb 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -257,7 +257,7 @@ impl DocumentCascadeData {
Some(pseudo) => {
origin_cascade_data
.pseudo... | 1 | 7 | 3 |
a36dfdc3b75ff6a09e19c6a491c93b4cf4e3c5a4 | Emilio Cobos Álvarez | 2017-08-29T10:18:33 | servo: Merge #18292 - style: Prevent Animate to generate NaN float values (from emilio:animate-nan); r=nox
This should fix the assertions in https://bugzilla.mozilla.org/show_bug.cgi?id=1394558.
Source-Repo: https://github.com/servo/servo
Source-Revision: 1c4d0d2d5d3e34e62ad3585b96632f354dbbe208 | diff --git a/style/values/animated/mod.rs b/style/values/animated/mod.rs
index c2d42192f..1972d839a 100644
--- a/style/values/animated/mod.rs
+++ b/style/values/animated/mod.rs
@@ -125,7 +125,10 @@ impl Animate for i32 {
impl Animate for f32 {
#[inline]
fn animate(&self, other: &Self, procedure: Procedure) -... | 1 | 9 | 2 |
7974453281cf6d6c83a65c4cc5f443d2796a0f79 | Manish Goregaokar | 2017-08-29T08:57:16 | servo: Merge #18275 - Mark the CoordData traits as unsafe (from Manishearth:coorddata-unsafe); r=nox
r? @nox
Source-Repo: https://github.com/servo/servo
Source-Revision: bea11cadf9f24109b510c2b865be1c8e49db8926 | diff --git a/style/gecko_bindings/sugar/ns_style_coord.rs b/style/gecko_bindings/sugar/ns_style_coord.rs
index cf9b684bb..abd53037c 100644
--- a/style/gecko_bindings/sugar/ns_style_coord.rs
+++ b/style/gecko_bindings/sugar/ns_style_coord.rs
@@ -20,7 +20,7 @@ impl nsStyleCoord {
}
}
-impl CoordData for nsStyleCo... | 1 | 10 | 10 |
77923b42506fcf8fa66278ae320aa609915b77d6 | Emilio Cobos Álvarez | 2017-08-29T07:48:09 | servo: Merge #18281 - style: Avoid scanning the longhand id twice in the fast path of PropertyDeclarationBlock::parse_common (from emilio:more-parse-dumbness); r=jdm
This makes the overhead of this function much lower according to `perf`.
And in general makes sense, removing overhead from the fast path.
Source-Repo:... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 790b158a7..1e8302d99 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -397,12 +397,14 @@ impl PropertyDeclarationBlock {
importance: Importance,
overwrite_m... | 1 | 7 | 5 |
a257801269d56643316cabdccc1a2546658e0162 | Emilio Cobos Álvarez | 2017-08-29T06:34:57 | servo: Merge #18280 - style: Avoid dropping a parse error on the floor when checking whether a prop is enabled (from emilio:parse-dumbness); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 441ae08d2408329c5f26deacf64ca488686fd812 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 1872b8c2e..58ab8588c 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1070,7 +1070,7 @@ impl PropertyId {
None => return ::custom_properties::parse_name(property_name)
... | 1 | 11 | 8 |
8fa1de1ea77ffa1a5a9398cc5d2601ee46a7e2c4 | Tom Tromey | 2017-08-29T03:57:13 | servo: Merge #18276 - Use cssparser's new_with_line_number_offset (from tromey:cssparser-line-number-offset); r=SimonSapin
cssparser provides a way to set the initial line number on a
ParserInput. This patch changes servo to use this facility, rather than
reimplement the same functionality itself.
---
- [x] `./mach... | diff --git a/script/dom/htmlstyleelement.rs b/script/dom/htmlstyleelement.rs
index a18b29bd3..ac5df3d96 100644
--- a/script/dom/htmlstyleelement.rs
+++ b/script/dom/htmlstyleelement.rs
@@ -98,7 +98,7 @@ impl HTMLStyleElement {
shared_lock, Some(&loader),
... | 6 | 17 | 51 |
6ba3c37b51f7bf42aaf960410387d2183beec5a8 | Emilio Cobos Álvarez | 2017-08-29T00:18:37 | servo: Merge #18282 - style: Remove uninlineable function in PropertyDeclarationIterator (from emilio:moar-parsing); r=jdm
That literally made no sense, and is probably leftover from where we passed Map
directly there.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9e2f243b4d7015f67b4ea8310c9d242ec2eb6f... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 54ffa4621..790b158a7 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -97,12 +97,7 @@ impl<'a> Iterator for PropertyDeclarationIterator<'a> {
type Item = &'a PropertyDec... | 1 | 1 | 6 |
20241628502c4d08b6c9b6b2014a726cef07878f | Josh Matthews | 2017-08-28T23:14:59 | servo: Merge #18279 - Prioritize parsing non-custom property names (from jdm:rearrange); r=emilio
This should cause a slight improvement in the common case where we are parsing non-custom property names.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
Source... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 391778b8b..1872b8c2e 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1011,10 +1011,6 @@ impl PropertyId {
/// will be used. It is `Origin::Author` for stylesheet_origin and
... | 1 | 2 | 5 |
cd73423f657cecc7d7a0d3bfb82f87069e61000c | Anthony Ramine | 2017-08-28T21:09:11 | servo: Merge #18287 - Fix impl of ToComputedValue for TrackSize<T> (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: ffc4ed187405f3fe654abeb682a61495f03cb687 | diff --git a/style/values/generics/grid.rs b/style/values/generics/grid.rs
index 87f427f6c..478617482 100644
--- a/style/values/generics/grid.rs
+++ b/style/values/generics/grid.rs
@@ -10,7 +10,7 @@ use parser::{Parse, ParserContext};
use std::{fmt, mem, usize};
use style_traits::{ToCss, ParseError, StyleParseError};... | 1 | 53 | 2 |
f4c8816c8548baaad71320474c5efe2e7ec38ca1 | Moses Miller | 2017-08-28T18:39:25 | servo: Merge #18247 - Silenced camel case warning for the iOS enum variant (from Majora320:master); r=emilio
Fix a simple warning.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
This change is obviously too trivial for tests.
Source-Repo: https://github.com... | diff --git a/config/opts.rs b/config/opts.rs
index 158e2850f..45663c458 100644
--- a/config/opts.rs
+++ b/config/opts.rs
@@ -448,6 +448,7 @@ pub fn multiprocess() -> bool {
enum UserAgent {
Desktop,
Android,
+ #[allow(non_camel_case_types)]
iOS
} | 1 | 1 | 0 |
901629afc3a70daf71ac9f3a5454d3a23d8e649a | Raphaël Lustin | 2017-08-28T16:18:52 | servo: Merge #18269 - Use `Filter buffer by name and type` algorithm implementation (from rlustin:filter-buffer-by-name-and-type); r=ferjm
Following #18176, it uses the new implementation and removes the old one.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any error... | diff --git a/script/dom/performance.rs b/script/dom/performance.rs
index fdcbfd4a8..fa9edfb39 100644
--- a/script/dom/performance.rs
+++ b/script/dom/performance.rs
@@ -35,24 +35,6 @@ impl PerformanceEntryList {
}
}
- pub fn get_entries(&self) -> Vec<Root<PerformanceEntry>> {
- self.entries.cl... | 2 | 6 | 24 |
458bc86f707a922b8bfee2bf606af7163e59b69c | Emilio Cobos Álvarez | 2017-08-28T13:48:47 | servo: Merge #18267 - style: Don't look for viewport units in stylesheets (from emilio:dirty-on-viewport-size-change); r=SimonSapin
Use whether we've computed any viewport unit instead.
This is more accurate (we avoid restyling unnecessarily if we've found anything
ever on the stylesheet, but that hasn't matched).
T... | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index d592b2839..0517c504b 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -1143,6 +1143,7 @@ impl LayoutThread {
let document_shared_lock = document.style_shared_lock();
self.document_shared_lock = Some(document_shared_lock.clon... | 9 | 39 | 65 |
9f86b07ec1443390896710d5327bc294fce5b0f9 | Emilio Cobos Álvarez | 2017-08-28T12:01:51 | servo: Merge #18261 - style: Really only resolve applicable ::before / ::after (from emilio:silly-pseudo-style); r=heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: 94c870726f0f549ab011451d0bafb4fe6a60e2c1 | diff --git a/style/style_resolver.rs b/style/style_resolver.rs
index 53add177b..bd47d356b 100644
--- a/style/style_resolver.rs
+++ b/style/style_resolver.rs
@@ -194,7 +194,12 @@ where
&primary_style,
layout_parent_style_for_pseudo
);
+
if let S... | 1 | 5 | 0 |
e8fb57f56ae50123adecafb0d3037c8b798fdbae | Hiroyuki Ikezoe | 2017-08-28T05:29:36 | servo: Merge #18265 - Don't fallback to discrete animations within animate() (from hiikezoe:dont-fallback-to-discrete-animation); r=birtles
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1394287
---
<!-- Thank you for contributing to Servo! Please replace eac... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 2f7aaafc6..e3c831c8b 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2623,13 +2623,7 @@ where
(&SVG... | 1 | 3 | 18 |
7c36552eb2fe2e0c5d274d68d0d81bbc8382400a | Glenn Watson | 2017-08-28T04:14:05 | servo: Merge #18264 - Update WR (debugger, renderer API changes) (from glennw:update-wr-api); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: e53bf5d675e195b6bf69e1c78fbb552b3daa80f6 | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 89d2fff0c..8ff38e772 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -812,9 +812,9 @@ impl<Window: WindowMethods> IOCompositor<Window> {
WindowEvent::ToggleWebRenderDebug(option) => {
let mut... | 2 | 6 | 6 |
71724e6d4322e53bb52fdbef2e1025f65d8d59bf | Emilio Cobos Álvarez | 2017-08-26T23:13:40 | servo: Merge #18257 - stylo: Make a few functions output more useful debug information (from emilio:debug-stuff-helps); r=bholley
Reviewed by Bobby on bug 1389645.
Source-Repo: https://github.com/servo/servo
Source-Revision: 08b9588011b0e70ad48177e890fc5475048db96b | diff --git a/style/dom.rs b/style/dom.rs
index 6b67336aa..60046312c 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -206,7 +206,13 @@ impl<N: TNode> Debug for ShowSubtreeDataAndPrimaryValues<N> {
fn fmt_with_data<N: TNode>(f: &mut fmt::Formatter, n: N) -> fmt::Result {
if let Some(el) = n.as_element() {
- ... | 1 | 9 | 2 |
cb2c37069ebc28df7aa2489bed59f71ff8e2c728 | Nick Price | 2017-08-26T22:07:28 | servo: Merge #18243 - [18224] Check if line_count is zero to calculate space around line (from DominoTree:18224); r=stshine
<!-- Please describe your changes on the following line: -->
Check line_count before attempting to calculate space around line
---
<!-- Thank you for contributing to Servo! Please replace each `... | diff --git a/layout/flex.rs b/layout/flex.rs
index dc5290184..db7fc0a93 100644
--- a/layout/flex.rs
+++ b/layout/flex.rs
@@ -711,14 +711,18 @@ impl FlexFlow {
line_interval = match line_align {
align_content::T::space_between => {
- if line_count == 1 {
+ ... | 1 | 6 | 2 |
84b7806bd699f573940a9c265774828821af32a9 | Keith Yeung | 2017-08-26T21:09:16 | servo: Merge #18252 - Remove border collapse argument from compute_border_and_padding (from KiChjang:remove-bc-arg); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 8f7bcdfef3ead441320f52b8570f8bf25f1840f2 | diff --git a/layout/block.rs b/layout/block.rs
index b22519ee7..6124492dc 100644
--- a/layout/block.rs
+++ b/layout/block.rs
@@ -51,7 +51,7 @@ use servo_geometry::max_rect;
use std::cmp::{max, min};
use std::fmt;
use std::sync::Arc;
-use style::computed_values::{border_collapse, box_sizing, display, float, overflow_... | 6 | 12 | 33 |
7d80cc2e0de9e2b907b13579366df0cb491592ed | Bobby Holley | 2017-08-26T17:22:33 | servo: Merge #18246 - stylo: followup fixes for restyle roots (from bholley:restyle_root_followups); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1392863
Source-Repo: https://github.com/servo/servo
Source-Revision: 1fd0edf158bb479b420fb6ddc76470d82c88cb61 | diff --git a/style/dom.rs b/style/dom.rs
index 74f0b8b5b..6b67336aa 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -506,7 +506,7 @@ pub trait TElement : Eq + PartialEq + Debug + Hash + Sized + Copy + Clone +
/// In Gecko, this corresponds to the regular dirty descendants bit, the
/// animation-only dirty des... | 3 | 8 | 9 |
95fbddb8245da7ea88e14239589144cab91a522e | Bobby Holley | 2017-08-26T04:29:46 | servo: Merge #18248 - stylo: Check stack depth in invalidation machinery and re-enable limits (from bholley:more_stack_limits); r=bholley
https://bugzilla.mozilla.org/show_bug.cgi?id=1376884
Source-Repo: https://github.com/servo/servo
Source-Revision: 3c42792efade03a31b9eeca8be457992cf83722c | diff --git a/style/context.rs b/style/context.rs
index 4e166929b..d7db7a5ab 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -16,7 +16,7 @@ use euclid::Size2D;
use fnv::FnvHashMap;
use font_metrics::FontMetricsProvider;
#[cfg(feature = "gecko")] use gecko_bindings::structs;
-use parallel::STYLE_THREAD_STACK_S... | 6 | 80 | 40 |
77a4cc0d145de9e4e2e91a2f5b1150126123e20a | Simon Sapin | 2017-08-26T01:24:58 | servo: Merge #18171 - Use Parser::skip_whitespace in a few places to make Parser::try rewind less (from servo:skip_whitespace); r=emilio
**Do not merge yet.** This pulls in unrelated cssparser changes which add a dependency to `dota`, and we’d like to resolve https://github.com/dtolnay/dtoa/pull/9 before landing dtoa ... | diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml
index 465365434..16ed24a31 100644
--- a/selectors/Cargo.toml
+++ b/selectors/Cargo.toml
@@ -25,7 +25,7 @@ unstable = []
[dependencies]
bitflags = "0.7"
matches = "0.1"
-cssparser = "0.19"
+cssparser = "0.19.3"
log = "0.3"
fnv = "1.0"
phf = "0.7.18"
diff --g... | 5 | 22 | 23 |
11986ce36979558d5da2a8d4780b587e68302c4f | Kevin Hsieh | 2017-08-25T22:30:22 | servo: Merge #18244 - stylo: Update CSS fallback font when lang changes (from kahsieh:master); r=Manishearth
r=manishearth in BugZilla.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1367860](https://bugzilla.mozilla.org/show_bug... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 8e8bae7a5..8735f2389 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2169,9 +2169,10 @@ fn static_assert() {
}
}
- pub fn fixup_system(&mut self) {
+ pub fn fixup_system(&mut sel... | 3 | 28 | 17 |
55f046535241cd79941cf5acf6c5c2d962105f9f | Bobby Holley | 2017-08-25T19:34:19 | servo: Merge #18240 - Revert rayon stack limits until we sort out the crashtest bustage (from bholley:revert_small_rayon_stacks); r=emilio
https://treeherder.mozilla.org/logviewer.html#?job_id=125956235&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=125956235&repo=autoland&lineNumber=13571
Source... | diff --git a/style/context.rs b/style/context.rs
index 4217cecd5..4e166929b 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -644,8 +644,8 @@ impl StackLimitChecker {
//
// The correctness of depends on the assumption that no stack wraps
// around the end of the address space.
- ... | 2 | 4 | 5 |
32a53990838c17e789195e5262fd10b123407125 | Bobby Holley | 2017-08-25T17:23:41 | servo: Merge #18238 - Replace the sequential/parallel distinction with a unified adaptive traversal (from bholley:adaptive_driver); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1393632
Source-Repo: https://github.com/servo/servo
Source-Revision: 72c59ff830b256ca5bd6df7736a9d9acfc9d3e52 | diff --git a/layout/parallel.rs b/layout/parallel.rs
index 6b8cb3ef2..a6bd121fd 100644
--- a/layout/parallel.rs
+++ b/layout/parallel.rs
@@ -21,8 +21,6 @@ use style::dom::UnsafeNode;
use traversal::{AssignBSizes, AssignISizes, BubbleISizes};
use traversal::{PostorderFlowTraversal, PreorderFlowTraversal};
-pub use s... | 11 | 178 | 203 |
aa9981fdaaf340e1b976e0582deb42ac0b1ee8a0 | Fernando Jiménez Moreno | 2017-08-25T16:18:12 | servo: Merge #18232 - Remove unused SelectorIter import (from ferjm:unused.selectoriter); r=emilio
Follow up of #18225
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: d6858ab2061f4ae9b81b567e594d46e1a6... | diff --git a/selectors/visitor.rs b/selectors/visitor.rs
index dc2993a6a..929040f9f 100644
--- a/selectors/visitor.rs
+++ b/selectors/visitor.rs
@@ -7,7 +7,7 @@
#![deny(missing_docs)]
use attr::NamespaceConstraint;
-use parser::{Combinator, Component, SelectorImpl, SelectorIter};
+use parser::{Combinator, Component... | 1 | 1 | 1 |
4a7d98a3a0863d6adc59316e458d023218ac3627 | Julian Seward | 2017-08-25T15:14:23 | servo: Merge #18231 - Bug 1376883 - stylo: Drop thread pool stack size to 100k. r=bholley (from julian-seward1:master); r=bholley
<!-- Please describe your changes on the following line: -->
Bug 1376883 - stylo: Drop thread pool stack size to 100k. r=bholley.
---
<!-- Thank you for contributing to Servo! Please rep... | diff --git a/style/context.rs b/style/context.rs
index c7c5d2ae3..3183cd057 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -16,6 +16,7 @@ use euclid::Size2D;
use fnv::FnvHashMap;
use font_metrics::FontMetricsProvider;
#[cfg(feature = "gecko")] use gecko_bindings::structs;
+use parallel::STYLE_THREAD_STACK_S... | 3 | 96 | 20 |
25a6054b70cb01741aa38ed96480e7da19717cf8 | Emilio Cobos Álvarez | 2017-08-25T14:03:35 | servo: Merge #18237 - style: Use consistent indentation in the stylist code (from emilio:stylist-indent); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: f69eb90614fdc80206535d3303d5ef507cd79cc9 | diff --git a/style/stylist.rs b/style/stylist.rs
index 16301de19..cf4eff1df 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -671,13 +671,14 @@ impl Stylist {
/// parent; otherwise, non-inherited properties are reset to their initial
/// values. The flow constructor uses this flag when constructing ano... | 1 | 256 | 204 |
58913d78d07d00c5c287a072ad54b24fc598895f | Emilio Cobos Álvarez | 2017-08-25T12:59:24 | servo: Merge #18235 - style: Remove SharedStyleContext::quirks_mode (from emilio:shared-context-cleanup); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 4fca1703cfddc5e52309d3425ae5c2e529606536 | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index f06ced471..d211ab880 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -67,7 +67,7 @@ use style::CaseSensitivityExt;
use style::applicable_declarations::ApplicableDeclarationBlock;
use style::attr::AttrValue;
... | 6 | 16 | 24 |
1cc929472cc76d7ff105c4b52dbc77d00db04ac6 | Emilio Cobos Álvarez | 2017-08-25T07:30:50 | servo: Merge #18215 - style: Only store applicable ::before / ::after pseudo styles during the traversal (from emilio:applicable-pseudo); r=heycam
This should help memory usage quite a bit.
Source-Repo: https://github.com/servo/servo
Source-Revision: 772a8464eb8dcd4fd50cd342b7c6fa165745dd1e | diff --git a/layout/query.rs b/layout/query.rs
index 5803a247e..9d1d4f182 100644
--- a/layout/query.rs
+++ b/layout/query.rs
@@ -702,7 +702,7 @@ pub fn process_resolved_style_request<'a, N>(context: &LayoutContext,
thread_local: &mut tlc,
};
- let styles = resolve_style(&mut context, element, RuleInc... | 6 | 109 | 17 |
0a8e5320c1fe1c7eca14b90e03f55667a157745a | Josh Matthews | 2017-08-25T06:10:03 | servo: Merge #18225 - Remove unused selector visitor argument (from jdm:unused-visitor-argument); r=emilio
The real win here is avoiding cloning the iterator when nobody actually uses it.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests f... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 706e3c2de..1948523c0 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -272,7 +272,7 @@ impl<Impl: SelectorImpl> SelectorMethods for Selector<Impl> {
let mut current = self.iter();
let mut combinator = None;
loop {
- ... | 3 | 1 | 3 |
a3e076655ca058c5db37917957454893549d1a57 | Manish Goregaokar | 2017-08-24T23:42:44 | servo: Merge #18223 - Handle calcs in ScrollSnapPoints conversions (from Manishearth:stylo-scrollsnap); r=emilio
fixes bug 1393580
https://bugzilla.mozilla.org/show_bug.cgi?id=1393580
Source-Repo: https://github.com/servo/servo
Source-Revision: d7f7d550ab2f0f0edbcc36dab510701f21a25f7a | diff --git a/style/gecko/values.rs b/style/gecko/values.rs
index 69d13c49f..04f5d0946 100644
--- a/style/gecko/values.rs
+++ b/style/gecko/values.rs
@@ -414,10 +414,8 @@ impl GeckoStyleCoordConvertible for ScrollSnapPoint<LengthOrPercentage> {
Some(
match coord.unit() {
nsStyleUni... | 1 | 2 | 4 |
f911b1b5d1b1c369f0a77c59c67a34b0c682eae9 | Imanol Fernandez | 2017-08-24T21:25:53 | servo: Merge #18221 - Use FnvHashMap in WebGL implementation (from MortimerGoro:webgl_fnv); r=jdm
<!-- Please describe your changes on the following line: -->
Follow up from the WebGL redesign: https://github.com/servo/servo/pull/17891
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` ... | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index d38f8c5aa..83d91f93b 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -15,6 +15,7 @@ canvas_traits = {path = "../canvas_traits"}
compositing = {path = "../compositing"}
cssparser = "0.19"
euclid = "0.15"
+fnv = "1.0"
gleam = "0.4"
ipc-channel = "0.8... | 5 | 29 | 26 |
d86030ce29499a876183fdce9aa47f0b4f5f17e4 | Brad Werth | 2017-08-24T19:58:49 | servo: Merge #18207 - Add a reusable sheets parameter to Servo_StyleSheet_FromUTF8Bytes (from bradwerth:reuseImports); r=xidorn
MozReview-Commit-ID: DdMQpUY1WcJ
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1387933
https://reviewboard.mozilla.org/r/171308/
... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 8bfbd705c..df7f5f2a0 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1929,7 +1929,9 @@ extern "C" {
extra_data:
... | 1 | 3 | 1 |
5b60c32b57815230e0c5fee53c7b3adbd7a665e6 | Hiroyuki Ikezoe | 2017-08-24T11:48:53 | servo: Merge #18214 - Try to update running CSS animations when CSS rules are changed (from hiikezoe:animation-name-change-in-css-rule); r=birtles
In the case where values in CSS rules changed directly by CSSOM, the old
value in the CSS rule block is immediately replaced by the new one. So if
the element, which is app... | diff --git a/style/matching.rs b/style/matching.rs
index a00871018..701c20304 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -170,12 +170,12 @@ trait PrivateMatchMethods: TElement {
// If the traverse is triggered by CSS rule changes, we need to
// try to update all CSS animations... | 1 | 3 | 3 |
b041da159de5d05b526102b647a11fb00433398c | Ting-Yu Lin | 2017-08-24T10:17:27 | servo: Merge #18213 - Improve debug log related to selector matching (from aethanyc:improve-debug-log); r=emilio
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index a29299c47..b9b2da857 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -519,13 +519,13 @@ fn matches_complex_selector_internal<E, F>(mut selector_iter: SelectorIter<E::Im
{
*relevant_link = relevant_link.examine_potential_link(elemen... | 2 | 4 | 4 |
cd40ea9bdc5ec89ea41afe8d90bade60c82c3a82 | Anthony Ramine | 2017-08-24T09:05:03 | servo: Merge #18208 - Use darling and derive more things (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: d3c2017b23a39b3a55990bb3da676de5eb479f90 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index f0c65e018..2f7aaafc6 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -787,40 +787,6 @@ impl ToAnimatedZero for Vi... | 9 | 55 | 106 |
b7184ab8a8aa82ebe09e8edabbeb266b344884c8 | Martin Robinson | 2017-08-24T06:31:34 | servo: Merge #18188 - Allow overflow:scroll without a stacking context (from mrobinson:overflow-stacking-context); r=mbrubeck
Fix the long-standing bug where items that are positioned and have
overflow:scroll or overflow:auto automatically create stacking
contexts. In order to do this we need to fix another bug where ... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 709469fa7..e7f4474e8 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -169,6 +169,9 @@ pub struct DisplayListBuildState<'a> {
/// recursively building and processing the display list.
pub curr... | 2 | 33 | 43 |
5ad6b8ce35937b538fb6263a31c1aab212cfa1b8 | Jonathan Jayet | 2017-08-23T21:05:35 | servo: Merge #18205 - Add initial iOS User-Agent (from JJayet:ios_support); r=jdm
This commit adds an initial iOS User-Agent as discussed here : https://github.com/servo/servo/issues/18154#issuecomment-324382850
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete... | diff --git a/config/opts.rs b/config/opts.rs
index 96ac781ff..158e2850f 100644
--- a/config/opts.rs
+++ b/config/opts.rs
@@ -448,6 +448,7 @@ pub fn multiprocess() -> bool {
enum UserAgent {
Desktop,
Android,
+ iOS
}
fn default_user_agent_string(agent: UserAgent) -> &'static str {
@@ -478,13 +479,19 @@... | 1 | 10 | 2 |
825b8158edfc744ea3c3cc68a9a6b7139642200d | Anthony Ramine | 2017-08-23T17:13:18 | servo: Merge #18204 - Fix quote dependency version (from servo:quote); r=bustage
Source-Repo: https://github.com/servo/servo
Source-Revision: 16c1446137317b7e974d65119d2187b81f0d2394 | diff --git a/dom_struct/Cargo.toml b/dom_struct/Cargo.toml
index e63689de0..4f3593db6 100644
--- a/dom_struct/Cargo.toml
+++ b/dom_struct/Cargo.toml
@@ -10,4 +10,4 @@ path = "lib.rs"
proc-macro = true
[dependencies]
-quote = "0.3"
+quote = "0.3.15"
diff --git a/domobject_derive/Cargo.toml b/domobject_derive/Cargo.t... | 4 | 4 | 4 |
a74dacc48bcaa90662d71bbb34bd7471d097ef74 | Jonathan Jayet | 2017-08-23T15:59:39 | servo: Merge #18189 - First step toward iOS Support (from JJayet:ios_support); r=larsbergstrom
This mostly prevents Gaol/sandboxing to be used during compilation.
There are a number of issues with : `expat-sys`, `servo-freetype-sys`, `fontsan`, `heartbeats-simple-sys`, `mozjs_sys`.
Also modified `components/script/do... | diff --git a/constellation/Cargo.toml b/constellation/Cargo.toml
index f2ab08dc1..2d659bd43 100644
--- a/constellation/Cargo.toml
+++ b/constellation/Cargo.toml
@@ -41,5 +41,5 @@ servo_url = {path = "../url"}
webvr_traits = {path = "../webvr_traits"}
webrender_api = {git = "https://github.com/servo/webrender", featur... | 7 | 22 | 15 |
c560b69d1f2ab2116e0240733e214d98ba78b73e | Anthony Ramine | 2017-08-23T15:01:15 | servo: Merge #18200 - Introduce style_derive::cg (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: e629f8da7ba373f6575c2e9ccc6259b7f2c4e3e4 | diff --git a/style_derive/animate.rs b/style_derive/animate.rs
index 5ce1040e9..888a5e61c 100644
--- a/style_derive/animate.rs
+++ b/style_derive/animate.rs
@@ -2,56 +2,29 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+use cg... | 9 | 291 | 485 |
ab22f57d96bea626797dfc15c8f0d37bd7be439f | Emilio Cobos Álvarez | 2017-08-23T12:40:03 | servo: Merge #18191 - style: Implement finer-grained stylist rebuilds (from emilio:incremental-rebuilds); r=SimonSapin,heycam
This is on top of #18170, and aims to resolve https://bugzilla.mozilla.org/show_bug.cgi?id=1386045.
Source-Repo: https://github.com/servo/servo
Source-Revision: c5cf6dc9658c8b90d3cb17f0dbd53e3... | diff --git a/style/stylesheet_set.rs b/style/stylesheet_set.rs
index 8548ac53f..01e8bedc1 100644
--- a/style/stylesheet_set.rs
+++ b/style/stylesheet_set.rs
@@ -9,16 +9,25 @@ use invalidation::stylesheets::StylesheetInvalidationSet;
use media_queries::Device;
use shared_lock::SharedRwLockReadGuard;
use std::slice;
-... | 3 | 356 | 160 |
8af07f154aef60c0e119bba4b8862d92c681c777 | Boris Chiou | 2017-08-23T10:04:20 | servo: Merge #18197 - stylo: Bug 1387990 - Fix the interpolation of 2d matrix (from BorisChiou:stylo/transform/2dmatrix); r=birtles
Write a 2d matrix decomposition for Gecko, so the visual results and test results
could match those in Gecko. In long-term, we should let Gecko follow the spec, so we
can drop the redunda... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index a97b8e260..683c23555 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1399,6 +1399,7 @@ impl ComputeSquaredDistan... | 1 | 82 | 0 |
509af896fa06405ae30e87f26840a674300d36c3 | Paul Rouget | 2017-08-23T08:55:27 | servo: Merge #18181 - Make it possible to close a browsing context from the embedder (from paulrouget:close_browser); r=cbrewster
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` wi... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index d8ec355bf..a7f979af8 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -828,6 +828,13 @@ impl<Window: WindowMethods> IOCompositor<Window> {
}
}
+ WindowEvent::CloseBrowser(ctx) => ... | 4 | 23 | 1 |
2c5e4b09b52019d78add36a08db597264faa36f8 | Hiroyuki Ikezoe | 2017-08-23T04:43:25 | servo: Merge #18195 - Don't cache style data if the element has running animations (from hiikezoe:disable-style-cache-for-animations); r=bholley,birtles
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1379203
---
<!-- Thank you for contributing to Servo! Pleas... | diff --git a/style/sharing/mod.rs b/style/sharing/mod.rs
index 27d911362..739ff6b90 100644
--- a/style/sharing/mod.rs
+++ b/style/sharing/mod.rs
@@ -509,6 +509,23 @@ impl<E: TElement> StyleSharingCandidateCache<E> {
return;
}
+ // If the element has running animations, we can't share styl... | 1 | 17 | 0 |
3e2a7f6cc998770c8ae158f1f4b38a8b6e816a2e | Anthony Ramine | 2017-08-22T19:53:11 | servo: Merge #18192 - Derive Animate and ToAnimatedZero (from servo:we-are-leaving-babylon); r=emilio
ONLY PARSE NEEDS DERIVING NOW. THE HYPE IS REAL.
Source-Repo: https://github.com/servo/servo
Source-Revision: ec2dae90685da47c17cde9011736c893b037ff01 | diff --git a/style/macros.rs b/style/macros.rs
index b4a274151..c766d4140 100644
--- a/style/macros.rs
+++ b/style/macros.rs
@@ -84,20 +84,10 @@ macro_rules! define_keyword_type {
($name: ident, $css: expr) => {
#[allow(missing_docs)]
#[cfg_attr(feature = "servo", derive(HeapSizeOf))]
- #[... | 25 | 271 | 479 |
4bb366f7bb7f7c3c6d0d8dd6f764d5ad2454ac41 | J. Ryan Stinnett | 2017-08-22T18:42:39 | servo: Merge #18190 - Stylo: Fix up Servo_StyleSheet_GetOrigin for Linux 32-bit ABI (from jryans:stylo-linux32-getorigin); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1392447
Source-Repo: https://github.com/servo/servo
Source-Revision: 5bfd5b966b19337f6b8ba9f95957bf7e49548b10 | diff --git a/style/gecko/generated/atom_macro.rs b/style/gecko/generated/atom_macro.rs
index 00114fe62..52e7f740c 100644
--- a/style/gecko/generated/atom_macro.rs
+++ b/style/gecko/generated/atom_macro.rs
@@ -4322,6 +4322,8 @@ cfg_if! {
pub static nsGkAtoms_AsyncScrollLayerCreationFailed: *mut nsIAtom;
... | 4 | 95 | 166 |
ff4524f59c4e3bb677757efd78b5087d8cb756a3 | Emilio Cobos Álvarez | 2017-08-22T16:45:42 | servo: Merge #18170 - style: Move the StyleSheetSet into the Stylist (from emilio:stylist-stylesheet-set); r=SimonSapin
This will allow tracking whether there have been only additions to the
stylesheet set, and in that case don't destroy and completely rebuild the
invalidation map.
This is on top of #18143.
Source-R... | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index caff54134..59796fe3f 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -129,15 +129,13 @@ use style::context::RegisteredSpeculativePainters;
use style::dom::{ShowSubtree, ShowSubtreeDataAndPrimaryValues, TElement, TNode};
use style::error_re... | 7 | 458 | 337 |
6ba46e1ce4d10e37e4c47158b61fdf75aba36f5b | Fernando Jiménez Moreno | 2017-08-22T15:06:30 | servo: Merge #17876 - Wait for actual paint before setting paint related metrics (from ferjm:pwm.webrender); r=jdm
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/servo/servo
Source-Revision: 43d1f45b73baa6b70e647f32f1637e05604bcc5... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 1349f004d..d8ec355bf 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -186,6 +186,13 @@ pub struct IOCompositor<Window: WindowMethods> {
/// GL functions interface (may be GL or GLES)
gl: Rc<gl::Gl>,
+
+ ///... | 12 | 158 | 41 |
c9f0e3614d8a8584ee4e779d385a716e06ed8600 | Emilio Cobos Álvarez | 2017-08-22T10:48:37 | servo: Merge #18184 - style: Inline a bunch of trivial stuff we're paying function calls for in Geckolib (from emilio:inline); r=upsuper
Reviewed by Xidorn in https://bugzilla.mozilla.org/show_bug.cgi?id=1392170.
Source-Repo: https://github.com/servo/servo
Source-Revision: 1059ef4fdeb5c76102c3da22293d836942740033 | diff --git a/style/data.rs b/style/data.rs
index 35f75b10b..ff4a214ef 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -72,6 +72,7 @@ impl RestyleData {
///
/// FIXME(bholley): The only caller of this should probably just assert that
/// the hint is empty and call clear_flags_and_damage().
+ #[inline... | 5 | 23 | 0 |
db2dfd85433d029b847885ddffee74e8d2672783 | Glenn Watson | 2017-08-21T21:11:20 | servo: Merge #18077 - Add key bindings for more WR debug / profiler options (from glennw:wr-profiling); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 10779f02519b193f07df997ab013ce7ca45cf656 | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index c5ceec0aa..1349f004d 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -34,7 +34,7 @@ use touch::{TouchHandler, TouchAction};
use webrender;
use webrender_api::{self, ClipId, DeviceUintRect, DeviceUintSize, LayoutPoint, L... | 2 | 19 | 6 |
9aba0022e167d55b70c41989508581fb4db9da19 | Mantaroh Yoshinaga | 2017-08-21T19:35:09 | servo: Merge #18168 - Add ComputeSquaredDistance trait for SvgLengthOrPercentageOrNumber (from mantaroh:stroke-distance); r=nox
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1387986
This patch will add ComputeSquaredDistance trait for SvgLen... | diff --git a/style/values/computed/mod.rs b/style/values/computed/mod.rs
index 8695a99ae..664fdcbbe 100644
--- a/style/values/computed/mod.rs
+++ b/style/values/computed/mod.rs
@@ -369,7 +369,7 @@ impl From<GreaterThanOrEqualToOneNumber> for CSSFloat {
#[allow(missing_docs)]
#[cfg_attr(feature = "servo", derive(Hea... | 2 | 41 | 4 |
5e7c7ae8a641c7e65704821f0b74aeb09aa1f235 | Emilio Cobos Álvarez | 2017-08-21T18:21:20 | servo: Merge #18173 - style: Keep dirty bit invariants during invalidation (from emilio:invalidation-dirty-thingie); r=bholley
There's the question of whether should we be recursing into the invalidation
code for elements without data... Probably not, but that's a somewhat more
risky change.
Bug: 1391444
Source-Repo:... | diff --git a/style/invalidation/element/invalidator.rs b/style/invalidation/element/invalidator.rs
index 234a627dd..e1bb22ccb 100644
--- a/style/invalidation/element/invalidator.rs
+++ b/style/invalidation/element/invalidator.rs
@@ -29,6 +29,15 @@ pub struct TreeStyleInvalidator<'a, 'b: 'a, E>
where E: TElement,
... | 1 | 11 | 2 |
2d182cac57ecaa199aced561e93975908bee861e | Emilio Cobos Álvarez | 2017-08-21T15:59:10 | servo: Merge #18143 - style: Remove Stylist::is_device_dirty (from emilio:stylist-stylesheets); r=<try>
More progress on unifying how Gecko and Servo track stylist dirtiness.
Source-Repo: https://github.com/servo/servo
Source-Revision: e60266a72302a0ed332f1dd18d335b6092c47da4 | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index 1a6bd945c..097cf74a2 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -137,7 +137,7 @@ use style::selector_parser::SnapshotMap;
use style::servo::restyle_damage::{REFLOW, REFLOW_OUT_OF_FLOW, REPAINT, REPOSITION, STORE_OVERFLOW};
use style::... | 3 | 94 | 107 |
f3cd13d8c5b9ec2cc47347b3b1943692d6102393 | Xidorn Quan | 2017-08-21T12:49:11 | servo: Merge #18169 - Add whitespace before line number in grid line (from upsuper:write-css-fix); r=nox
This is a followup fix of #18159 where the space was incorrectly removed.
Source-Repo: https://github.com/servo/servo
Source-Revision: d4e43d9d7668d55f6cbf2586115c9a856525e88e | diff --git a/style/values/generics/grid.rs b/style/values/generics/grid.rs
index d7e817762..8093fdfea 100644
--- a/style/values/generics/grid.rs
+++ b/style/values/generics/grid.rs
@@ -58,6 +58,7 @@ impl ToCss for GridLine {
}
if let Some(i) = self.line_num {
+ dest.write_str(" ")?;
... | 1 | 1 | 0 |
153b57f9fcf0d79e17968ce359b2b0194635f583 | Xidorn Quan | 2017-08-21T11:46:11 | servo: Merge #18139 - Update parser state only after rule is successfully parsed (from upsuper:parser-state); r=SimonSapin
This is expected to fix several web-platform tests mentioned in [bug 1389187](https://bugzilla.mozilla.org/show_bug.cgi?id=1389187).
Source-Repo: https://github.com/servo/servo
Source-Revision: 4... | diff --git a/style/stylesheets/rule_parser.rs b/style/stylesheets/rule_parser.rs
index 43d26c2c2..4f9fe566c 100644
--- a/style/stylesheets/rule_parser.rs
+++ b/style/stylesheets/rule_parser.rs
@@ -169,7 +169,6 @@ impl<'a, 'i> AtRuleParser<'i> for TopLevelRuleParser<'a> {
return Err(StyleParseError:... | 1 | 4 | 4 |
e2fec82133515ab6bdead0ab6cd4d723d510a139 | Xidorn Quan | 2017-08-21T09:14:08 | servo: Merge #18159 - Replace write! with to_css and write_str in some ToCss impls (from upsuper:write-to-css); r=nox
Some of this is necessary for fixing things like [bug 1370779](https://bugzilla.mozilla.org/show_bug.cgi?id=1370779) because otherwise we would still not be using the new numeric serialization algorith... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index be2cafa77..4833b0489 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -32,7 +32,7 @@ use string_cache::Atom;
use style_traits::{CSSPixel, DevicePixel};
use style_traits::{ToCss, ParseError, StyleParseError};
... | 11 | 58 | 42 |
ad54772e0b485bd389d819f4f81a1d159ede882f | Paul Rouget | 2017-08-21T08:02:21 | servo: Merge #18149 - make sure proper frame tree is sent when iframes change (from paulrouget:hittest-issue); r=cbrewster
We ran into a hittest issue because the frame tree was not correctly updated after #17425.
The frame tree should be updated on tab change (via send_frame_tree) or when the frame sub tree changes ... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 3e9b0cc80..672def8ab 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -2307,12 +2307,7 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
self.update_activity(pipeline_id);
se... | 1 | 20 | 17 |
befdfc3235cba7a6cfa055abb6d96caab24e3129 | Brian Birtles | 2017-08-21T04:05:57 | servo: Merge #18165 - Expand var() references in single_value_to_css (from birtles:expand-variables-in-serialize); r=hiro
These are the Servo-side changes for [Gecko bug 1385139](https://bugzilla.mozilla.org/show_bug.cgi?id=1385139).
This is a temporary step needed to support Gecko's getKeyframes() API until we imple... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 69fbfda33..c77274bbf 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2562,7 +2562,9 @@ extern "C" {
pub fn Servo_DeclarationBlock_SerializeOneValue(declarations:
... | 2 | 28 | 4 |
29b9ef0b5f4f8cc7689afb99aa658116218480b5 | Emilio Cobos Álvarez | 2017-08-20T12:00:25 | servo: Merge #18153 - stylo: Remove a lot of the restyle damage related complexity (from emilio:restyle-damage-cleanup); r=heycam
The only reason why we had the `existing_style_for_style_damage` bit is to apply
some optimizations that we don't have anymore.
I still want to reintroduce a few of them, at least for the ... | diff --git a/layout/animation.rs b/layout/animation.rs
index ebbba82fc..19f621f7f 100644
--- a/layout/animation.rs
+++ b/layout/animation.rs
@@ -161,9 +161,10 @@ pub fn recalc_style_for_animations(context: &LayoutContext,
&mut fragment.style,
... | 10 | 76 | 199 |
089cfcda56472a2b5ad158ee69bffd47e251027d | Emilio Cobos Álvarez | 2017-08-20T07:14:08 | servo: Merge #18158 - style: Skip state pseudo-classes when finding a pseudo-element (from emilio:pseudo-crash); r=heycam
Bug: 1391577
Reviewed-by: heycam
MozReview-Commit-ID: 1ICBijtcf2b
Source-Repo: https://github.com/servo/servo
Source-Revision: 4f3fb904ae6863aa86bb3c8b7abee5533478af13 | diff --git a/style/invalidation/element/invalidator.rs b/style/invalidation/element/invalidator.rs
index 44f6b8da3..234a627dd 100644
--- a/style/invalidation/element/invalidator.rs
+++ b/style/invalidation/element/invalidator.rs
@@ -595,14 +595,27 @@ impl<'a, 'b: 'a, E> TreeStyleInvalidator<'a, 'b, E>
... | 1 | 14 | 1 |
2f087ed8882bb7a1b439b16c5816bb5647012ef6 | Boris Chiou | 2017-08-20T03:52:50 | servo: Merge #18156 - stylo: Bug 1389429 - The interpolations of rotatex and rotatey are not correct (from BorisChiou:stylo/animation/rotatexy); r=birtles
These patches fix the potential divided-by-zero issue on non-normalizable
direction vector of rotate3d, and the interpolation between rotatex/rotatey and none.
---... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 52701c1b0..40eaa8b3e 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1340,8 +1340,9 @@ fn build_identity_transfo... | 1 | 28 | 26 |
a961b8b4f30837df332e687567c794cc5de89d6a | Tamir Duberstein | 2017-08-19T13:51:16 | servo: Merge #18148 - style: pass a borrow instead of an Arc (from tamird:computedvalues-arc-borrow); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1380133 has landed,
permitting us to pass a plain borrow into Gecko_CalcStyleDifference;
propagate this through style.
Closes #17795.
- [x] `./mach build -d` doe... | diff --git a/style/gecko/restyle_damage.rs b/style/gecko/restyle_damage.rs
index b9b6be3bd..6ba02600e 100644
--- a/style/gecko/restyle_damage.rs
+++ b/style/gecko/restyle_damage.rs
@@ -9,7 +9,6 @@ use gecko_bindings::structs;
use gecko_bindings::structs::{nsChangeHint, nsStyleContext, nsStyleStructID};
use matching::... | 2 | 7 | 8 |
bb90433373735af309eae79a809889fd0cc3a233 | Xidorn Quan | 2017-08-19T10:45:53 | servo: Merge #18136 - Use Option<RGBA> for color in shadow (from upsuper:shadow-color); r=emilio
This fixes [bug 1390697](https://bugzilla.mozilla.org/show_bug.cgi?id=1390697) by downgrading the support of currentcolor in shadow to what Gecko currently supports.
Source-Repo: https://github.com/servo/servo
Source-Revi... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 75e288e48..5ec71dd09 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -1411,7 +1411,7 @@ impl FragmentDisplayListBuilding for Fragment {
state.add_display_item(DisplayItem::BoxShadow(box Bo... | 5 | 26 | 26 |
196d6a25f1c73a03a45c89ef3dcbe8c907abd06b | Keith Yeung | 2017-08-18T23:39:02 | servo: Merge #17521 - Update fetch methods (from KiChjang:update-fetch); r=jdm
Includes updates to main fetch, scheme fetch, HTTP fetch, HTTP-redirect fetch, HTTP-network fetch, HTTP-network-or-cache fetch and CORS preflight fetch.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9f64630eaa5731db10b113ce0... | diff --git a/constellation/network_listener.rs b/constellation/network_listener.rs
index 239a6089f..038d304fa 100644
--- a/constellation/network_listener.rs
+++ b/constellation/network_listener.rs
@@ -103,6 +103,7 @@ impl NetworkListener {
self.res_init = Some(ResponseInit {
... | 7 | 252 | 234 |
2d526e89cd034422c558fba276eef33e95d87a3b | Nikhil Shagrithaya | 2017-08-18T21:27:05 | servo: Merge #18056 - End TreeBuilder's reliance on DOM (from cynicaldevil:remove-treesink-dep-on-dom); r=nox
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:... | diff --git a/gfx/Cargo.toml b/gfx/Cargo.toml
index 5be6b7e1e..50575b625 100644
--- a/gfx/Cargo.toml
+++ b/gfx/Cargo.toml
@@ -55,7 +55,7 @@ freetype = "0.3"
servo-fontconfig = "0.2.1"
[target.'cfg(target_os = "android")'.dependencies]
-xml5ever = {version = "0.8", features = ["unstable"]}
+xml5ever = {version = "0.9... | 8 | 136 | 95 |
6bc3b46585e9f714da203ed6b647d1f4e44e579a | Nazım Can Altınova | 2017-08-18T20:28:37 | servo: Merge #18144 - Handle single X keyword value in LegacyPosition (from canaltinova:legacy-position-x); r=emilio
This is reviewed by emilio in bugzilla.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./... | diff --git a/style/values/specified/position.rs b/style/values/specified/position.rs
index 3b7b8c9ba..0adf66e3d 100644
--- a/style/values/specified/position.rs
+++ b/style/values/specified/position.rs
@@ -320,11 +320,6 @@ impl LegacyPosition {
return Ok(Self::new(x_pos, y_pos));
},
... | 1 | 3 | 7 |
065ed3968b4c4ffbcf89ff797cd9d503afb094b6 | Emilio Cobos Álvarez | 2017-08-18T17:58:46 | servo: Merge #18142 - style: Less messy namespace handling (from emilio:less-mess-ns); r=SimonSapin
This PR accounts for the fact that the namespace table is only needed in
`NestedRuleParser`, and only for style rules, in order to simplify the setup and
be able to fix a few bugs wrt parsing of invalid rules.
Source-R... | diff --git a/script/dom/css.rs b/script/dom/css.rs
index 0ee5a9536..b1b0210d1 100644
--- a/script/dom/css.rs
+++ b/script/dom/css.rs
@@ -36,9 +36,13 @@ impl CSS {
decl.push_str(&value);
let decl = Declaration(decl);
let url = win.Document().url();
- let context = ParserContext::new_for... | 8 | 159 | 83 |
f6a32d50cd11f41b80955bf7850d6a9e51f3cc3c | Emilio Cobos Álvarez | 2017-08-18T13:33:35 | servo: Merge #18124 - style: Replicate the list of stylesheets on the layout thread (from emilio:stylist-stylesheets); r=SimonSapin
This is a patch that unifies a bit how Gecko and Stylo stylesheets work, in
order to be able to eventually move the stylesheets into the stylist, and be
able to incrementally update the i... | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index 736826ece..1a6bd945c 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -117,7 +117,6 @@ use std::collections::HashMap;
use std::mem as std_mem;
use std::ops::{Deref, DerefMut};
use std::process;
-use std::slice;
use std::sync::{Arc, Mutex,... | 13 | 408 | 193 |
dfdb6a939c31ff49eeff6c402423dc8db7ba8a59 | Glenn Watson | 2017-08-18T11:55:43 | servo: Merge #18138 - Update WR (remove internal webgl implementation) (from glennw:update-wr-remove-webgl); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 0fcbcf7fc5b050f8749c25d4821d4b219e5b264f | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index e8bf234a0..d38f8c5aa 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -19,6 +19,6 @@ gleam = "0.4"
ipc-channel = "0.8"
log = "0.3.5"
num-traits = "0.1.32"
-offscreen_gl_context = { version = "0.11", features = ["serde"] }
+offscreen_gl_context = { ver... | 2 | 1 | 21 |
8b5443186b791ebcc41de8f534daa2ca39d51aa8 | Emilio Cobos Álvarez | 2017-08-18T09:42:12 | servo: Merge #18131 - style: Multiple calc serialization fixes (from emilio:calc-serialization); r=canaltinova
This puts us in line with the spec as written, except for caveat in https://github.com/w3c/csswg-drafts/issues/1731.
Need to fix computed calc() too, I'm less confident that we won't need to change test expe... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 5b05a4229..e382a623c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -29,7 +29,7 @@ servo = ["serde", "heapsize", "heapsize_derive",
gecko_debug = ["nsstring_vendor/gecko_debug"]
[dependencies]
-app_units = "0.5.2"
+app_units = "0.5.3"
arrayvec = "0.3.... | 4 | 53 | 21 |
80f6a3de42a55e420d329f36cdf367c12d875015 | Boris Chiou | 2017-08-18T07:24:33 | servo: Merge #18086 - stylo: Bug 1362896 - Implement ComputeSquaredDistance for TransformList (from BorisChiou:stylo/transform/distance); r=nox,birtles
We implement ComputeSquaredDistance for TransformList.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 1e3558482..52701c1b0 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -8,7 +8,7 @@
use app_units::Au;
use cssp... | 2 | 266 | 29 |
498f7f1d6e1c01205b7de9a053168b9c5f88ea39 | Mantaroh Yoshinaga | 2017-08-18T04:39:00 | servo: Merge #17704 - Add animation value related with stroke-dasharray / stroke-dashoffset / stroke-width (from mantaroh:interpolate-stroke); r=nox
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1369614
This patch will:
* Add animation valu... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 682e2cfb3..6f1b0d2a7 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -588,7 +588,7 @@ def set_gecko_property(ffi_name, expr):
// set on mContextFlags, and the length field is set to the initial va... | 6 | 286 | 45 |
6253486c8d2ded698726d49ea754ae66ece8a059 | Bobby Holley | 2017-08-18T03:28:34 | servo: Merge #18137 - Avoid creating a stylo thread pool in e10s parent processes (from bholley:thread_pool_parent_process); r=upsuper
Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1375911
Source-Repo: https://github.com/servo/servo
Source-Revision: 489b25004bdc1ccd9348f659e6a608656c55c13b | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index d4b7e9432..69fbfda33 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1568,6 +1568,9 @@ extern "C" {
extern "C" {
pub fn Gecko_RegisterNamespace(ns: *mut nsIAtom) -> i32;
}
+extern "... | 2 | 5 | 1 |
a2b471c8c8f77c74722da521e672958fa962c136 | Connor Brewster | 2017-08-18T02:00:10 | servo: Merge #18092 - Only run DOMTokenList update steps if token was found (from cbrewster:ce_domtokenlist); r=jdm
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate... | diff --git a/script/dom/domtokenlist.rs b/script/dom/domtokenlist.rs
index b4be05e2f..c3834ceed 100644
--- a/script/dom/domtokenlist.rs
+++ b/script/dom/domtokenlist.rs
@@ -158,9 +158,9 @@ impl DOMTokenListMethods for DOMTokenList {
} else {
atoms.remove(pos);
}
+ /... | 1 | 2 | 2 |
da662981a28211de2cab76452c1d24d6753b0f04 | Martin Robinson | 2017-08-18T00:42:20 | servo: Merge #18123 - Improve containing block creation for position:absolute flows (from mrobinson:absolute-containing-blocks); r=pcwalton
Instead of only promoting flows with positioned fragments to containing
blocks, also do this for flows which have the transform, perspective or
filter properties set. This is what... | diff --git a/layout/block.rs b/layout/block.rs
index e0dcc4b68..d868e1fe9 100644
--- a/layout/block.rs
+++ b/layout/block.rs
@@ -448,20 +448,16 @@ pub struct AbsoluteAssignBSizesTraversal<'a>(pub &'a SharedStyleContext<'a>);
impl<'a> PreorderFlowTraversal for AbsoluteAssignBSizesTraversal<'a> {
#[inline]
fn ... | 10 | 95 | 29 |
b16414d9d5282e6f6833379f443bc9f2f72f943a | Glenn Watson | 2017-08-17T22:28:18 | servo: Merge #18096 - Update WR (new texture cache allocator, shader deinit path) (from glennw:update-wr-deinit); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: f6a42ed9c17d0586860ead8a2e0663deb8d9621c | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 99273256d..93654eb71 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -412,6 +412,10 @@ impl<Window: WindowMethods> IOCompositor<Window> {
compositor
}
+ pub fn deinit(self) {
+ self.webrender.dei... | 2 | 8 | 1 |
55615f275098d4f29da29068f12286000b09407b | Imanol Fernandez | 2017-08-17T19:06:10 | servo: Merge #18127 - Fix bound textures and framebuffers when a WebGL Canvas is resized (from MortimerGoro:webgl_bind_tex2d); r=emilio
<!-- Please describe your changes on the following line: -->
Fix bound textures and framebuffers when a WebGL Canvas is resized. This causes some invisible textures in WebGL based ga... | diff --git a/script/dom/webglrenderingcontext.rs b/script/dom/webglrenderingcontext.rs
index c45362b4f..78e6c1e31 100644
--- a/script/dom/webglrenderingcontext.rs
+++ b/script/dom/webglrenderingcontext.rs
@@ -279,6 +279,22 @@ impl WebGLRenderingContext {
// default scissor when the canvas was created or the la... | 1 | 16 | 0 |
b723350e5d95d08368fdae184dd4fbb00ca32b1b | Simon Sapin | 2017-08-17T16:05:32 | servo: Merge #18126 - geckolib: Fix some warnings (treated as error) new in Rust Nigthly (from servo:glow-fox); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: cc86ca2bcdec5e89ee5279085ea38db63ef41af9 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 327b4b056..f8455749a 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -352,7 +352,7 @@ impl nsStyleImage {
// NB: stops are guaranteed to be none in the gecko side by
// default.
- ... | 5 | 15 | 15 |
1b8017b5b311c0dc3fcb34a586f81fab3f9bd0c1 | Emilio Cobos Álvarez | 2017-08-17T15:03:54 | servo: Merge #18113 - script: Optimize CompareDocumentPosition (from emilio:node-is-before); r=nox
I need this to compute the proper insertion point for a given stylesheet.
Source-Repo: https://github.com/servo/servo
Source-Revision: b6e0f4e9523d61ddbcef755e2d5887e05016e0a4 | diff --git a/script/dom/node.rs b/script/dom/node.rs
index 750361888..a337caf4e 100644
--- a/script/dom/node.rs
+++ b/script/dom/node.rs
@@ -74,9 +74,10 @@ use selectors::matching::{matches_selector_list, MatchingContext, MatchingMode};
use selectors::parser::SelectorList;
use servo_arc::Arc;
use servo_url::ServoUrl... | 1 | 71 | 44 |
24d1be642695f664ad4263b26027307e6851fc90 | Tom Tromey | 2017-08-17T13:08:16 | servo: Merge #18073 - Expose the source map URL on a style sheet (from tromey:source-map-url); r=SimonSapin
This changes Servo to track the source map URL of a style sheet. This
parallels a change going in to Gecko:
https://bugzilla.mozilla.org/show_bug.cgi?id=1388855
<!-- Please describe your changes on the followi... | diff --git a/script/dom/htmlmetaelement.rs b/script/dom/htmlmetaelement.rs
index 9370675eb..481da1c09 100644
--- a/script/dom/htmlmetaelement.rs
+++ b/script/dom/htmlmetaelement.rs
@@ -113,6 +113,7 @@ impl HTMLMetaElement {
// resize; they don't need to force all styles to be
... | 4 | 16 | 4 |
4622eb2972aad1ed436d87bad1d19e0cbfb3c6cb | Ting-Yu Lin | 2017-08-17T04:09:35 | servo: Merge #18121 - style: Move functions related to anonymous element to GeckoElement (Bug 1390773) (from aethanyc:move-anonymous-flag-functions); r=emilio
This change was reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1390773
Source-Repo: https://github.com/servo/servo
Source-Revision: 5964be77217ee42af... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 6b7e2ca60..59c0b040d 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -62,8 +62,6 @@ use gecko_bindings::structs::ELEMENT_HAS_DIRTY_DESCENDANTS_FOR_SERVO;
use gecko_bindings::structs::ELEMENT_HAS_SNAPSHOT;
use gecko_bindings::struct... | 1 | 33 | 20 |
1d360c898de2b4c0b8a2c12726dab4de4ce65904 | Anthony Ramine | 2017-08-17T01:26:22 | servo: Merge #18117 - Move more CSS values to their own submodules (from servo:we-are-leaving-babylon); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 575bcf3989b1e058bcdc9ebe73b4eedc1476f1ed | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index cfc7947f2..38ac83a94 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -867,27 +867,6 @@ impl Animatable for i32 {
... | 7 | 489 | 420 |
9727f3dcfda91d928d94c023e96d319a34783eda | Martin Robinson | 2017-08-17T00:18:48 | servo: Merge #18112 - Use the is_absolute_containing_block method everywhere (from mrobinson:containing-block-helper); r=mbrubeck
This is a better approach than relying on
contains_positioned_fragments, because in the future other properties
will create absolute containing blocks.
<!-- Please describe your changes on... | diff --git a/layout/block.rs b/layout/block.rs
index e5ef74013..e0dcc4b68 100644
--- a/layout/block.rs
+++ b/layout/block.rs
@@ -1989,12 +1989,12 @@ impl Flow for BlockFlow {
// For relatively-positioned descendants, the containing block formed by a block is just
// the content box. The containing b... | 4 | 17 | 28 |
81c0c094810047d09a0f01119b968b582fe51441 | Hiroyuki Ikezoe | 2017-08-16T23:17:18 | servo: Merge #18102 - Implement distance for shadow list (from hiikezoe:compute-distance-for-shadow-list); r=boris
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1387973
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not r... | diff --git a/style/values/animated/effects.rs b/style/values/animated/effects.rs
index 8db9f4368..f969aef0c 100644
--- a/style/values/animated/effects.rs
+++ b/style/values/animated/effects.rs
@@ -104,11 +104,24 @@ where
}
}
-impl<S> ComputeSquaredDistance for ShadowList<S> {
+impl<S> ComputeSquaredDistance for... | 1 | 17 | 4 |
fd52a04655e75e2cfb38484d75d8c1dda1bfff5d | Connor Brewster | 2017-08-16T22:09:37 | servo: Merge #17250 - Unwrap function before calling IsConstructor (from cbrewster:unwrap_constructor); r=jdm
`IsConstructor` returns true for all wrappers that are callable. Wrapped
arrow functions are callable and thus `IsConstructor` will return true
if given one; however, if we unwrap the arrow function, `IsConstr... | diff --git a/script/dom/customelementregistry.rs b/script/dom/customelementregistry.rs
index a625d4641..e3f90217c 100644
--- a/script/dom/customelementregistry.rs
+++ b/script/dom/customelementregistry.rs
@@ -27,6 +27,7 @@ use dom::window::Window;
use dom_struct::dom_struct;
use html5ever::{LocalName, Namespace, Pref... | 1 | 10 | 1 |
480c78bec6696fa0423dc386900205adfd50e637 | Martin Robinson | 2017-08-16T12:06:32 | servo: Merge #18107 - Remove unused StackingContextType (from mrobinson:remove-pseudo-scrolling-area); r=emilio
This hasn't been in use for quite some time.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is c... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index c83ae8fe8..98ece855d 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -399,7 +399,6 @@ pub enum StackingContextType {
Real,
PseudoPositioned,
PseudoFloat,
- PseudoScrollingArea,
}
#[derive(Clone, HeapSizeOf, ... | 1 | 0 | 1 |
2593a03c2608c27a9d5c67b49716437ff053baa0 | Brian Birtles | 2017-08-16T10:46:56 | servo: Merge #18103 - Don't allow interpolating 'fill:none' with 'fill:none' (from birtles:drop-fill-none-interpolation); r=hiro
From [Gecko bug 1390364](https://bugzilla.mozilla.org/show_bug.cgi?id=1390364).
In SMIL we don't expect the 'none' value of the 'fill' property to be additive and hence the following animat... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 64d29252d..cfc7947f2 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2478,7 +2478,6 @@ impl Animatable for Inter... | 1 | 0 | 1 |
867eda84d8c327d1152e4a0088320115972fd8cf | Bobby Holley | 2017-08-16T09:22:23 | servo: Merge #18097 - Avoid recursion in clear_descendant_data (from bholley:avoid_recursion_clear_descendant_data); r=emilio
This will allow us to have a tight stack limit in https://bugzilla.mozilla.org/show_bug.cgi?id=1376883
Source-Repo: https://github.com/servo/servo
Source-Revision: 467316e35bb494b9e9b2b4c480b3... | diff --git a/style/traversal.rs b/style/traversal.rs
index 37abedfc2..29e36eb29 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -509,7 +509,7 @@ where
if data.styles.is_display_none() {
debug!("{:?} style is display:none - clearing data from descendants.",
element);... | 1 | 21 | 17 |
e3a4e16c936c51726ac4884fcaaddbcdb8fd8a5a | Emilio Cobos Álvarez | 2017-08-16T07:56:13 | servo: Merge #18087 - style: Cleanup a bit Stylist and SelectorMap (from emilio:stylist-clear-cleanup); r=heycam
Bug: 1390255
Reviewed-by: heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: b300800b2c450f325c0308e9dcd7ec0113498e37 | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 1ac69f2f2..7d99e4af8 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -17,7 +17,7 @@ use properties::ComputedValues;
use servo_arc::Arc;
use shared_lock::{Locked, StylesheetGuards, SharedRwLockReadGuard};
use stylesheet_set::StylesheetSet;
-us... | 8 | 147 | 265 |
8224e4dc6e91da16a9b77c54f64c20d48d4919d7 | Ting-Yu Lin | 2017-08-16T06:47:46 | servo: Merge #18104 - style: Skip matching :nth-child if element is the root of anonymous subtree (from aethanyc:fix-nth-child-xbl-bug1382102); r=emilio
This was reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1382102
Source-Repo: https://github.com/servo/servo
Source-Revision: 24270f93571e0a1254d402f1c897bc... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 8f6b2fa6a..ead73c6a7 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -776,6 +776,10 @@ fn matches_generic_nth_child<E, F>(element: &E,
where E: Element,
F: FnMut(&E, ElementSelectorFlags),
{
+ if element.ignores_nth_c... | 3 | 21 | 2 |
7230d642b859a41560a1b195b701da10722bcece | KuoE0 | 2017-08-16T04:11:04 | servo: Merge #18099 - Make emtpy rule can be inserted into rule tree (from KuoE0:make-empty-rule-can-be-inserted-into-rule-tree); r=emilio
<!-- Please describe your changes on the following line: -->
We really want to ensure empty rule nodes appear in the rule tree for devtools, this condition ensures that if we find ... | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index ff511a2a5..1b1062d25 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -210,7 +210,10 @@ impl RuleTree {
_ => {},
};
}
- if any_normal {
+ // We really want to en... | 1 | 4 | 1 |
68dd14a0cd3f75e3cc884e23e16c7fe356b27ea8 | Emilio Cobos Álvarez | 2017-08-16T00:29:45 | servo: Merge #18095 - stylo: Remove some unused FFI functions (from emilio:unused); r=bholley
Bug: 1390650
Reviewed-by: bholley
MozReview-Commit-ID: K9fXGRmgkr4
Source-Repo: https://github.com/servo/servo
Source-Revision: eba896157edf3ba4f0d65b68eb63dd9cd40cdce4 | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 368623c3d..bd7d263e1 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -511,12 +511,6 @@ extern "C" {
extern "C" {
pub fn Servo_StyleSet_Drop(ptr: RawServoStyleSetOwned);
}
-extern "C"... | 3 | 0 | 37 |
9869b44356cdbed557c098aa1cea0b52d506a79f | Alex Touchet | 2017-08-15T23:21:51 | servo: Merge #18040 - Update Firefox version in user agent (from atouchet:user-agent); r=jdm
<!-- Please describe your changes on the following line: -->
GitHub has started throwing warnings about using an outdated version of Firefox when loaded with Servo. I am assuming that this is due to Servo using Firefox 37.0 in... | diff --git a/config/opts.rs b/config/opts.rs
index e94eef277..96ac781ff 100644
--- a/config/opts.rs
+++ b/config/opts.rs
@@ -453,22 +453,22 @@ enum UserAgent {
fn default_user_agent_string(agent: UserAgent) -> &'static str {
#[cfg(all(target_os = "linux", target_arch = "x86_64"))]
const DESKTOP_UA_STRING: &'... | 1 | 6 | 6 |
b8ea74521b90511cfb28002dda746686e4ec2757 | Bobby Holley | 2017-08-15T22:07:20 | servo: Merge #18094 - Avoid leaving stale ANCESTOR_WAS_RECONSTRUCTED bits in the tree (from bholley:ancestor_reconstruct); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1390179
Source-Repo: https://github.com/servo/servo
Source-Revision: 99b4b7e9602ea1440d2d2ae6c32be30bd0c4f721 | diff --git a/style/data.rs b/style/data.rs
index 096f09f00..35f75b10b 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -106,10 +106,14 @@ impl RestyleData {
}
/// Sets the flag that tells us whether we've reconstructed an ancestor.
- pub fn set_reconstructed_ancestor(&mut self) {
- // If it weren... | 4 | 45 | 24 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.