commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
29a8538db90f743a8de9d65fd7fad04f20329e55 | Simon Sapin | 2017-08-15T12:31:04 | servo: Merge #18046 - Upgrade to rustc 1.21.0-nightly (13d94d5fa 2017-08-10) (from servo:rustup); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 7d9b82b9efa7b10a2e34d93df5ac535d99518f7a | diff --git a/devtools/lib.rs b/devtools/lib.rs
index d5a2764a7..6a25696ea 100644
--- a/devtools/lib.rs
+++ b/devtools/lib.rs
@@ -306,7 +306,7 @@ fn run_server(sender: Sender<DevtoolsControlMsg>,
columnNumber: console_message.columnNumber,
},
};
- for mut stream in &mut *con... | 37 | 69 | 62 |
38f0684534fb703c83cd20cdd465dabd78b5c635 | Daisuke Akatsuka | 2017-08-15T10:50:15 | servo: Merge #18085 - Make content animatable (from dadaa:make-content-animatable); r=hiro
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach ... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 9d4b6f230..327b4b056 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -919,3 +919,16 @@ impl<T> Rect<T> where T: GeckoStyleCoordConvertible {
)
}
}
+
+/// Convert to String from given chars pointer.
+pub... | 4 | 94 | 16 |
b4d357a107764233ebda7aa5eb2002598d0a6da6 | Hiroyuki Ikezoe | 2017-08-15T09:37:44 | servo: Merge #18084 - Currentcolor for box shadow animation (from hiikezoe:currentcolor-for-box-shadow-animation); r=xidorn
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1388220
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` d... | diff --git a/style/gecko_bindings/sugar/ns_css_shadow_item.rs b/style/gecko_bindings/sugar/ns_css_shadow_item.rs
index 0111256d5..13f5b2493 100644
--- a/style/gecko_bindings/sugar/ns_css_shadow_item.rs
+++ b/style/gecko_bindings/sugar/ns_css_shadow_item.rs
@@ -23,12 +23,7 @@ impl nsCSSShadowItem {
#[inline]
p... | 1 | 21 | 11 |
1791774342e8a3ef9b2b9de47db8013f48a12049 | Hiroyuki Ikezoe | 2017-08-15T08:28:21 | servo: Merge #18081 - Fix interpolation between auto and other values (from hiikezoe:interpolation-with-auto); r=birtles,boris,mantaroh
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1387939
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index bb079321b..80ab02ae5 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1396,6 +1396,8 @@ impl<'le> TElement for GeckoElement<'le> {
existing_transitions: &HashMap<TransitionProperty,
... | 4 | 11 | 10 |
1eb028654e391357658bd3f8a74590a1fb14c743 | Emilio Cobos Álvarez | 2017-08-15T06:08:56 | servo: Merge #18083 - style: Simplify the ruby text adjustment (from emilio:ruby-text); r=upsuper
StyleAdjuster keeps a reference to the parent style, so no need to get it as an
argument.
Source-Repo: https://github.com/servo/servo
Source-Revision: fff50acd8188865c50a12ba6f623d14f94761919 | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 06ff2df66..3b3513c45 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -108,9 +108,9 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
///
/// Note that this, for Gecko, comes through Servo_ComputedValues_Inherit.
#[cfg(fe... | 1 | 4 | 4 |
047a5226e8c5d86bbd308bc0ebf44eeae0890baf | Hiroyuki Ikezoe | 2017-08-15T04:31:19 | servo: Merge #18079 - Don't convert zero component value to 'auto' in clone__moz_image_region (from hiikezoe:moz-image-region); r=boris
Currently Gecko treats 'auto' component value as zero for animation.
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=138795... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index e7f9db30b..92cc18ab3 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4222,21 +4222,11 @@ fn static_assert() {
return Either::Second(Auto);
}
- let get_clip_rect_component... | 1 | 4 | 14 |
0b394d6812bcac4002cd9020f0fce9ccc0b86d64 | Hiroyuki Ikezoe | 2017-08-15T03:07:31 | servo: Merge #18078 - Make vertical-align animatable between percentage and percentage or l… (from hiikezoe:vertical-align-animation); r=boris
…ength.
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1387949
---
- [X] `./mach build -d` does not report any erro... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 87325fa70..ac1e5dc36 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -943,10 +943,10 @@ impl Animatable for Verti... | 1 | 3 | 3 |
d99b9933f5e3dd99cc948c3594d30703ec93c5ad | Xidorn Quan | 2017-08-15T01:12:31 | servo: Merge #18076 - Check pref when parsing :fullscreen pseudo-class (from upsuper:fullscreen-pref); r=TYLin
This is the Servo side change of [bug 1374902](https://bugzilla.mozilla.org/show_bug.cgi?id=1374902).
Source-Repo: https://github.com/servo/servo
Source-Revision: 4771e6ea1ec76556803dab7b118eb1f8dbd1a6a0 | diff --git a/style/gecko/generated/structs_debug.rs b/style/gecko/generated/structs_debug.rs
index 04581692a..beff8e966 100644
--- a/style/gecko/generated/structs_debug.rs
+++ b/style/gecko/generated/structs_debug.rs
@@ -9216,6 +9216,11 @@ pub mod root {
"_ZN7mozilla10StylePrefs28sFramesTimingFunctio... | 4 | 33 | 15 |
48e42b136b6f572db0262f56c0b3cb1b64a1f16e | Xidorn Quan | 2017-08-15T00:10:06 | servo: Merge #18075 - Apply line break suppression to text when in any ruby (from upsuper:text-in-ruby); r=Manishearth
This should fix [bug 1388904](https://bugzilla.mozilla.org/show_bug.cgi?id=1388904).
Source-Repo: https://github.com/servo/servo
Source-Revision: 6f5e7639347766b7c36919ee9b8cd528dff8f58c | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 70d9880fb..06ff2df66 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -108,8 +108,9 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
///
/// Note that this, for Gecko, comes through Servo_ComputedValues_Inherit.
#[cfg(fe... | 1 | 15 | 1 |
d43659db6a950cd504a1dd1a7034bc3e043d5a5d | Connor Brewster | 2017-08-14T21:44:22 | servo: Merge #18074 - Enqueue attribute changed callback when replacing attr (from cbrewster:set_attr_node); r=jdm
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate ... | diff --git a/script/dom/element.rs b/script/dom/element.rs
index 6aeef3ce9..eab06c5c1 100644
--- a/script/dom/element.rs
+++ b/script/dom/element.rs
@@ -1674,6 +1674,15 @@ impl ElementMethods for Element {
}
// Step 4.
+ if self.get_custom_element_definition().is_some() {
+ ... | 1 | 9 | 0 |
41f4b9b0edd1954a5afaa212da4b174bf1a0fe1a | Eric Rahm | 2017-08-14T21:22:50 | Bug 1393230 - Part 3: Convert the xpcom string classes to be templated on char type. r=njn, r=fitzgen, r=sfink
This removes the double-include macro hackery that we use to define two
separate string types (nsAString and nsACString) in favor of a templated
solution.
Annotations for Valgrind and the JS hazard analysis ... | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index de8daefd3..32ec46c13 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -292,7 +292,7 @@ mod bindings {
},
};
for fixup in fixups.iter() {
- result = Regex::new(&format!(r"\b{}\b", fixup.pat)).unwrap().... | 1 | 2 | 2 |
e1178fb580641ce721e7e752218310b144f6f3d7 | Emilio Cobos Álvarez | 2017-08-14T11:42:44 | servo: Merge #18070 - stylo: only clear relevant origins when medium features change (from emilio:orig-medium); r=heycam
Bug: 1389871
Reviewed-by: heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: 1573309b868bc971b4cd1fe7153c57c4bf37c6cc | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index ecf25e3a6..368623c3d 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1990,7 +1990,7 @@ extern "C" {
extern "C" {
pub fn Servo_StyleSet_MediumFeaturesChanged(set: RawServoStyleSetBorr... | 6 | 134 | 64 |
71e12af3585f696c29e537cdc9442b482a8269e9 | Hiroyuki Ikezoe | 2017-08-14T10:33:45 | servo: Merge #18069 - Make scroll-snap-{coordinate, destination} discrete animation (from hiikezoe:scroll-snap); r=daisuke
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1387941
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` ... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index 857d7b4d5..531096dcf 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -721,7 +721,7 @@ ${helpers.predefined_type("scroll-snap-destination",
product... | 1 | 2 | 2 |
40014ae2bd3306b26473343993d7bb6359d34af0 | Cameron McCormack | 2017-08-14T09:19:34 | servo: Merge #18067 - geckolib: Return @font-face rules to Gecko in the expected cascade order (from heycam:fix-cascade); r=xidorn
From https://bugzilla.mozilla.org/show_bug.cgi?id=1389937. Reviewed by Xidorn there. Waiting until try server is back up and running before landing this, though.
Source-Repo: https://gi... | diff --git a/style/stylesheets/origin.rs b/style/stylesheets/origin.rs
index 1d2bbadd0..ba598fede 100644
--- a/style/stylesheets/origin.rs
+++ b/style/stylesheets/origin.rs
@@ -64,6 +64,17 @@ impl<T> PerOrigin<T> {
PerOriginIter {
data: &self,
cur: 0,
+ rev: false,
+ ... | 1 | 15 | 3 |
d80563f824ce5eaecb843c1f3b0f4cba560650b5 | Daisuke Akatsuka | 2017-08-14T07:24:47 | servo: Merge #18066 - Make -moz-appearance animatable (from dadaa:make-moz-appearance-animatable); r=hiro
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 74a7b157a..e7f9db30b 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -456,7 +456,10 @@ def set_gecko_property(ffi_name, expr):
</%def>
<%def name="impl_keyword_clone(ident, gecko_ffi_name, keyword,... | 2 | 5 | 2 |
2aad0563c38d29eabd229f1acd12ab95adf1ed8a | Boris Chiou | 2017-08-14T04:08:03 | servo: Merge #18068 - Fix the conversion from Perspective into ComputedMatrix (from BorisChiou:stylo/animation/perspective); r=birtles
We convert a perspective function into a ComputedMatrix, but we apply the
perspective length to a wrong matrix item. We should put it into m34,
instead of m43. m43 is for translate par... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 4b423751d..2f11d506f 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1474,11 +1474,17 @@ fn add_weighted_transfo... | 1 | 9 | 3 |
c41e80614733b2e79cabb72269af8c5e2fbd09a7 | Nicholas Nethercote | 2017-08-14T02:07:01 | servo: Merge #18065 - Overhaul ComputedValues measurement, and add style structs measurement (from nnethercote:bug-1387956); r=bholley
<!-- Please describe your changes on the following line: -->
See https://bugzilla.mozilla.org/show_bug.cgi?id=1387956.
---
<!-- Thank you for contributing to Servo! Please replace ea... | diff --git a/style/data.rs b/style/data.rs
index 38099cb6e..096f09f00 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -16,7 +16,7 @@ use shared_lock::StylesheetGuards;
use std::fmt;
use std::ops::{Deref, DerefMut};
#[cfg(feature = "gecko")]
-use stylesheets::{MallocSizeOfWithRepeats, SizeOfState};
+use stylesheets... | 3 | 34 | 36 |
70732de1087b14de86d03f2fca8bc880451f52d0 | Emilio Cobos Álvarez | 2017-08-13T15:39:39 | servo: Merge #18061 - style: Remove a few unneeded transmutes (from emilio:trans); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: bec0d02ad3fe399d96c639b86ff46eba0af88793 | diff --git a/style/stylesheets/origin.rs b/style/stylesheets/origin.rs
index 7ca3e21fc..1d2bbadd0 100644
--- a/style/stylesheets/origin.rs
+++ b/style/stylesheets/origin.rs
@@ -5,7 +5,6 @@
///! [CSS cascade origins](https://drafts.csswg.org/css-cascade/#cascading-origins).
use std::marker::PhantomData;
-use std::me... | 1 | 3 | 4 |
c78f9b5a5fc47c03f9669818bde8ad233a7d4f97 | Bobby Holley | 2017-08-12T02:15:12 | servo: Merge #18054 - Simplify throttled animation flushes (from bholley:simplify_throttled_animation_flushes); r=bholley
https://bugzilla.mozilla.org/show_bug.cgi?id=1388031
Source-Repo: https://github.com/servo/servo
Source-Revision: 4ddf6dbd153969e990d05298bc25a06be868319c | diff --git a/style/dom.rs b/style/dom.rs
index d2ed5ae3d..7df9c850f 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -462,6 +462,28 @@ pub trait TElement : Eq + PartialEq + Debug + Hash + Sized + Copy + Clone +
data.has_styles() && !data.restyle.hint.has_non_animation_invalidations()
}
+ /// Returns w... | 5 | 92 | 73 |
9030cd9ca6b0a7c93f38d063278c0e0fe4768820 | Bobby Holley | 2017-08-12T00:01:15 | servo: Merge #18053 - Overhaul dirty descendants propagation in preparation for restyle roots (from bholley:descendants_bit_refactor); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1389385
Source-Repo: https://github.com/servo/servo
Source-Revision: faad7ffb457100d35164b132c012e221cbc62bf5 | diff --git a/layout_thread/dom_wrapper.rs b/layout_thread/dom_wrapper.rs
index 0981ec42c..beb929d5e 100644
--- a/layout_thread/dom_wrapper.rs
+++ b/layout_thread/dom_wrapper.rs
@@ -63,14 +63,13 @@ use std::hash::{Hash, Hasher};
use std::marker::PhantomData;
use std::mem::transmute;
use std::sync::atomic::Ordering;
-... | 6 | 70 | 162 |
946afb51f5398beae97ef2146cf5ff36154a8e9e | Manish Goregaokar | 2017-08-11T22:51:36 | servo: Merge #18052 - stylo: Don't call fixup_generic_font for system or CSS wide specified fonts (from Manishearth:fixup_generic); r=heycam
r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1383869
Source-Repo: https://github.com/servo/servo
Source-Revision: c3bbe9284cf3598305b034927002edf41d8b38fb | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 352bf0f8a..a62d00be5 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2165,11 +2165,17 @@ fn static_assert() {
}
pub fn fixup_none_generic(&mut self, device: &Device) {
+ self.gecko.... | 2 | 14 | 1 |
5ff6ad8fd38062daaa766927545632a82e1efeae | Hiroyuki Ikezoe | 2017-08-11T12:57:05 | servo: Merge #18043 - Make -webkit-text-stroke-width animatable (from hiikezoe:webkit-text-stroke-width); r=daisuke
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1389452
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when th... | diff --git a/style/properties/longhand/inherited_text.mako.rs b/style/properties/longhand/inherited_text.mako.rs
index 8384671de..ecb0a9364 100644
--- a/style/properties/longhand/inherited_text.mako.rs
+++ b/style/properties/longhand/inherited_text.mako.rs
@@ -747,7 +747,7 @@ ${helpers.predefined_type("-webkit-text-str... | 1 | 1 | 1 |
ac649994314f31fcbc9d3632246c9faa04ee80fe | Xidorn Quan | 2017-08-11T11:32:44 | servo: Merge #18042 - Make nsStylePosition::mGridTemplate{Columns,Rows} a UniquePtr (from upsuper:grid-template); r=canaltinova
This is the Servo side change of [bug 1388255](https://bugzilla.mozilla.org/show_bug.cgi?id=1388255).
Source-Repo: https://github.com/servo/servo
Source-Revision: 58e8a3126af09dcdd346a1dddc5... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 52ee3dfd6..2f9b9d720 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -16,6 +16,7 @@ use gecko_bindings::structs::mozilla::css::URLValue;
use gecko_bindings::structs::mozilla::css::URLValue... | 4 | 273 | 113 |
525e177ad4ab7a6844da26ca0b88ee50e67704a0 | Anthony Ramine | 2017-08-11T10:24:39 | servo: Merge #18035 - Animate basic shapes (from servo:animate-basic-shapes); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: d197e1f6bdee00a2f81695167f8f7bba1eed845a | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 5877e3917..9d4b6f230 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -590,8 +590,8 @@ pub mod basic_shape {
use gecko::values::GeckoStyleCoordConvertible;
use gecko_bindings::structs;
use gecko_bindings... | 8 | 456 | 48 |
2cd8ec5afb007ef76f2b8f5d29bfdad5d021bcde | Cameron McCormack | 2017-08-11T05:40:18 | servo: Merge #18037 - style: Split collected @font-face / @counter-style rules per origin (from heycam:split-cascade-font-counter); r=emilio
<!-- Please describe your changes on the following line: -->
More refactoring in preparation for rebuilding sheets only from the origin that changed.
---
<!-- Thank you for con... | diff --git a/layout_thread/lib.rs b/layout_thread/lib.rs
index 26d1ef7bb..9635e0b08 100644
--- a/layout_thread/lib.rs
+++ b/layout_thread/lib.rs
@@ -114,7 +114,6 @@ use servo_url::ServoUrl;
use std::borrow::ToOwned;
use std::cell::{Cell, RefCell};
use std::collections::HashMap;
-use std::marker::PhantomData;
use st... | 3 | 100 | 44 |
11edf0bcb284698db833939a17b04491d2cb358a | Martin Robinson | 2017-08-10T12:13:00 | servo: Merge #18038 - Remove an unused DisplayListBuildState member (from mrobinson:removed-unused-db-builder-state-member); r=emilio
I'm not sure this member was ever used.
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` w... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index d3954ad89..afc01739a 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -72,7 +72,7 @@ use style_traits::ToCss;
use style_traits::cursor::Cursor;
use table_cell::CollapsedBordersForCell;
use webrender_... | 1 | 1 | 10 |
ccc77467a0e36f9274abcbc4aa59abd72718b599 | Xidorn Quan | 2017-08-10T06:42:30 | servo: Merge #18033 - Use namespace id instead of atom in synthesize_presentational_hints_for_legacy_attributes (from upsuper:disable-mathml); r=Manishearth
Using namespace id fixes this issue because in Gecko, the pref of MathML (as well as SVG) works in the way that we choose a different namespace id (the disabled i... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index b3cd83ea3..0ecbf8abe 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1534,9 +1534,9 @@ impl<'le> PresentationalHintsSynthesizer for GeckoElement<'le> {
};
};
- let ns = self.get_namespace();
+ l... | 1 | 4 | 4 |
1745ccbf1816dfae74ed09bbcfabad48ae1cc638 | Manish Goregaokar | 2017-08-10T05:04:28 | servo: Merge #18032 - stylo: Fixes for min font size and logical properties (from Manishearth:fixes); r=heycam
r=heycam https://bugzilla.mozilla.org/show_bug.cgi?id=1388941 and https://bugzilla.mozilla.org/show_bug.cgi?id=1388943
Source-Repo: https://github.com/servo/servo
Source-Revision: d415617a5bbe65a73bd805808a7... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 186627be1..7785e8aa4 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2643,12 +2643,13 @@ fn static_assert() {
#[allow(non_snake_case)]
pub fn set__moz_min_font_size_ratio(&mut self, v: lon... | 2 | 26 | 3 |
a59bdb38c9fa86846a1b98616637d2982a2faa94 | Fausto Núñez Alberro | 2017-08-10T01:34:04 | servo: Merge #17812 - Introduce ComputedUrl (from brainlessdeveloper:use-resolved-url-instead-of-original); r=emilio
<!-- Please describe your changes on the following line: -->
Use the new `ComputedUrl` type for computed types and `SpecifiedUrl` for specified types instead of using the `SpecifiedUrl` implementation ... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 88dc2272f..07031c2f6 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -44,7 +44,7 @@ use values::animated::effects... | 14 | 127 | 46 |
2143cb47c3d9f125ebe9479359271a6b8dec3bbd | Cameron McCormack | 2017-08-10T00:28:07 | servo: Merge #18017 - style: Move all origin-specific cascade data to PerOriginCascadeData (from heycam:split-cascade); r=emilio
<!-- Please describe your changes on the following line: -->
This is a preliminary refactoring in preparation for only rebuilding cascade data for origins that have a change. https://bugzil... | diff --git a/selectors/bloom.rs b/selectors/bloom.rs
index 0e8290fc8..2b96e4f51 100644
--- a/selectors/bloom.rs
+++ b/selectors/bloom.rs
@@ -2,9 +2,11 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-//! Simple counting bloom f... | 6 | 344 | 196 |
99b04f55b07a0ad67b1cdadc74c1ed90f24d3b5a | Simon Sapin | 2017-08-09T21:16:33 | servo: Merge #18025 - Update to cssparser 0.19, count line numbers during tokenization (from servo:line-counting); r=jdm
https://github.com/servo/rust-cssparser/pull/177
Also simplify the `ParseErrorReporter` trait a bit.
Source-Repo: https://github.com/servo/servo
Source-Revision: 845131c425ebd50eea2fe5bf6005b6c304... | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index 836e959ef..ad149dacc 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -12,7 +12,7 @@ path = "lib.rs"
[dependencies]
azure = {git = "https://github.com/servo/rust-azure"}
canvas_traits = {path = "../canvas_traits"}
-cssparser = "0.18"
+cssparser = "0.1... | 23 | 104 | 137 |
18b4a888f2668bfd94d61b5412751f06239a6339 | Bobby Holley | 2017-08-09T18:03:00 | servo: Merge #18026 - Continue cleaning up the traversal entry point machinery (from bholley:continue_traversal_cleanup); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1388623
Source-Repo: https://github.com/servo/servo
Source-Revision: 2b92a7e82d49b8fcead78f91abbabdedf2a569c1 | diff --git a/style/data.rs b/style/data.rs
index 07870fad7..38099cb6e 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -69,14 +69,23 @@ impl RestyleData {
}
/// Clear all the restyle state associated with this element.
- fn clear(&mut self) {
- *self = Self::new();
+ ///
+ /// FIXME(bholley... | 3 | 18 | 7 |
ed79ccb9d81b71c11403da5f0a384b6635c05e26 | Emilio Cobos Álvarez | 2017-08-09T16:58:12 | servo: Merge #18022 - style: Only zoom absolute lengths (from emilio:text-zoom-woes); r=Manishearth
As silly as it may seem to specify font-sizes using viewport units, we weren't
handling zoom for them correctly either.
Bug: 1388588
Reviewed-by: Manishearth
MozReview-Commit-ID: 3Q6phYAu5CE
Source-Repo: https://github... | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index 8d8fcf017..96ba9199b 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -844,8 +844,11 @@ ${helpers.single_keyword_system("font-variant-caps",
}
/// Com... | 3 | 31 | 14 |
3664fa0100466394262f180c650a4f6be09a5e83 | Fernando Jiménez Moreno | 2017-08-09T15:19:57 | servo: Merge #18021 - Update Trusted<T> documentation (from ferjm:trusted.doc); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 8074c6aaad06c11e85f6cf02404457c9b91a0092 | diff --git a/script/dom/bindings/refcounted.rs b/script/dom/bindings/refcounted.rs
index bbac02288..8acbe823e 100644
--- a/script/dom/bindings/refcounted.rs
+++ b/script/dom/bindings/refcounted.rs
@@ -11,7 +11,7 @@
//! To guarantee the lifetime of a DOM object when performing asynchronous operations,
//! obtain a `Tr... | 1 | 1 | 1 |
b0ac45c37c17e49dcc76b1f35c8acae0caea054d | Hiroyuki Ikezoe | 2017-08-09T08:45:56 | servo: Merge #18018 - Make list-style-type animatable (from hiikezoe:list-style-type-animatable); r=emilio
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1388652
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report an... | diff --git a/style/context.rs b/style/context.rs
index 675fff06c..7ae849d07 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -5,7 +5,7 @@
//! The context within which style is calculated.
#[cfg(feature = "servo")] use animation::Animation;
-use animation::PropertyAnimation;
+#[cfg(feature = "servo")] use ani... | 4 | 17 | 3 |
2ee510e36545742b6c910c74927be726a6491f6a | Boris Chiou | 2017-08-09T03:33:03 | servo: Merge #18016 - stylo: Don't apply the rotation if it cannot be normalized (from BorisChiou:stylo/transform/rotate); r=heycam
According to the spec, the computed value of transform is as specified, but
with relative lengths converted into absolute lengths, so in Gecko, we do
nothing while computing the value of ... | diff --git a/layout/fragment.rs b/layout/fragment.rs
index fd2d5698e..2510b185d 100644
--- a/layout/fragment.rs
+++ b/layout/fragment.rs
@@ -2887,8 +2887,17 @@ impl Fragment {
for operation in operations {
let matrix = match *operation {
transform::ComputedOperation::Rotate(ax, ay... | 2 | 12 | 4 |
e2dabd5d7d94b0a65676fc89de0ab12c7b9be670 | Glenn Watson | 2017-08-08T21:05:54 | servo: Merge #18002 - Update WR (text optimizations, Linux subpixel positioning / rasterization) (from glennw:update-wr-linux-subpx); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 31582a487437f599005bb96bf94a1942b8e46d24 | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index b3433e62b..b7e217770 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -585,28 +585,32 @@ impl<'a> CanvasPaintThread<'a> {
};
let data = webrender_api::ImageData::Raw(Arc::new(eleme... | 8 | 57 | 32 |
fbb92fecbe3e3bd1a7d8638792b169252504e2ef | Matt Brubeck | 2017-08-08T19:04:23 | servo: Merge #18004 - Clean up and simplify layout traversal code (from mbrubeck:layout-cleanup); r=pcwalton
Various refactorings of the code for traversing flow trees, including:
* Add a generic inorder traversal method
* Remove unused `traverse_postorder_absolute_flows` method
* Combine `compute_absolute_position` ... | diff --git a/layout/block.rs b/layout/block.rs
index f42b749e7..e5ef74013 100644
--- a/layout/block.rs
+++ b/layout/block.rs
@@ -36,9 +36,8 @@ use floats::{ClearType, FloatKind, Floats, PlacementInfo};
use flow::{self, BaseFlow, EarlyAbsolutePositionInfo, Flow, FlowClass, ForceNonfloatedFlag};
use flow::{BLOCK_POSITI... | 17 | 170 | 214 |
a2240662788691344536164a5bea80b3ce5543da | DarkDrek | 2017-08-08T18:01:00 | servo: Merge #18003 - Move percentage to mod.rs (from DarkDrek:move_percentage); r=canaltinova
<!-- Please describe your changes on the following line: -->
The tests in the issue worked for me locally.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and repl... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 68500b3ca..186627be1 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -62,9 +62,8 @@ use std::mem::{forget, uninitialized, transmute, zeroed};
use std::{cmp, ops, ptr};
use stylesheets::{MallocSizeOfW... | 5 | 163 | 166 |
cf40fa137a03c7ede376afedcd797734a096caaa | Emilio Cobos Álvarez | 2017-08-08T16:45:37 | servo: Merge #18014 - stylo: We've had bitfield accessors for a while now (from emilio:bitfields); r=SimonSapin
This will allow my work in bug 1362338 to not break stylo.
Source-Repo: https://github.com/servo/servo
Source-Revision: 3c644ea616ba3f614a00834327e3b0196daaf406 | diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs
index fed06fbee..f3bb04f6c 100644
--- a/style/gecko_string_cache/mod.rs
+++ b/style/gecko_string_cache/mod.rs
@@ -156,11 +156,8 @@ impl WeakAtom {
/// Returns the length of the atom string.
#[inline]
pub fn len(&self) -> u32 {... | 1 | 1 | 4 |
7565e7634605344e9ff1a0faa8152780b5fbc998 | Emilio Cobos Álvarez | 2017-08-08T15:06:32 | servo: Merge #18011 - style: Avoid hashing hashes (from emilio:less-dumb-hash); r=nox
These are the last instances I can find of us hashing the atoms hash.
Source-Repo: https://github.com/servo/servo
Source-Revision: dec4ba8ea6adb2477e4d3ba4916c886ac8b1dc0e | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 09e9fc511..193ee9286 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -7,7 +7,6 @@
use Atom;
use atomic_refcell::{AtomicRef, AtomicRefCell, AtomicRefMut};
use dom::TElement;
-use fnv::FnvHashMap;
use gecko::rules::{CounterStyleRule, FontFaceR... | 2 | 7 | 7 |
ee8d8ffa019dea96845f7cd7e6f2adbbe7ec8219 | Fernando Jiménez Moreno | 2017-08-08T13:29:14 | servo: Merge #17973 - stylo: ensure consistent order for custom properties computed values (from ferjm:ordered-map); r=heycam
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
From https://bugzilla.mozilla.org/show_bug.cgi?id=1379577
Source-Repo: https://github.co... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index cb9e39561..c564aad42 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -13,9 +13,10 @@ use properties::{CSSWideKeyword, DeclaredValue};
use selectors::parser::SelectorParseError;
use servo_arc::Arc;
use std::ascii::A... | 2 | 112 | 47 |
e392434dfa1fc0fb1c3f07a20f1b8add5e5bac2e | Emilio Cobos Álvarez | 2017-08-08T11:32:12 | servo: Merge #17999 - style: Use an enumerated array for per-pseudo maps (from emilio:pseudo-enumerated-array); r=heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: b6d46789f8d56dc90d6c6d44f857fc31afd23e51 | diff --git a/style/gecko/generated/pseudo_element_definition.rs b/style/gecko/generated/pseudo_element_definition.rs
index 485d4a023..00081d8ba 100644
--- a/style/gecko/generated/pseudo_element_definition.rs
+++ b/style/gecko/generated/pseudo_element_definition.rs
@@ -175,9 +175,14 @@ pub enum PseudoElement {
+
+... | 6 | 292 | 153 |
654abb0faf858af35827efb312387776b5e6a9b9 | Emilio Cobos Álvarez | 2017-08-08T10:28:35 | servo: Merge #18009 - stylo: Fix skip_root_and_item_display_fixup (from emilio:video-controls); r=heycam
The check isn't doing what the comment is saying.
XBL subtrees for video controls all have the
NODE_IS_IN_NATIVE_ANONYMOUS_SUBTREE flag, but not all of them are NAC
themselves, so we may incorrectly miss blockific... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 6d62f5495..b3cd83ea3 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -238,7 +238,6 @@ impl<'ln> GeckoNode<'ln> {
/// This logic is duplicated in Gecko's nsIContent::IsInAnonymousSubtree.
#[inline]
fn is_in_anonymous_su... | 1 | 1 | 2 |
a9afa286574bf5485076836c8b0fe1421a209a38 | Emilio Cobos Álvarez | 2017-08-08T09:25:24 | servo: Merge #17992 - style: Rework how precomputed pseudo stuff works, to avoid malloc/free churn (from emilio:rework-precomputed-pseudo); r=heycam
This showed up in a few profiles, and was an easy improvement.
Source-Repo: https://github.com/servo/servo
Source-Revision: 69f02f4f7f102a3fe3f82d5f000533a9277d233e | diff --git a/style/selector_map.rs b/style/selector_map.rs
index feba25658..2e2c27840 100644
--- a/style/selector_map.rs
+++ b/style/selector_map.rs
@@ -201,29 +201,6 @@ impl SelectorMap<Rule> {
|block| (block.specificity, block.source_order()));
}
- /// Append to `rule_list` all universa... | 2 | 49 | 57 |
325884ced2d40ed02aea4fdecc3b91e1728590cb | Boris Chiou | 2017-08-08T06:32:06 | servo: Merge #18007 - stylo: Fix the computation of the interpolation of FontWeight (from BorisChiou:stylo/animation/interpolation/font_weight); r=xidorn
Interpolated result of FontWeight is wrong because clamping code is incorrect.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does ... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 19ca7e49e..222027044 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1421,7 +1421,7 @@ impl Animatable for FontW... | 1 | 1 | 1 |
7befa5f47022cac15a15f316bdfeead3a794ec71 | Hiroyuki Ikezoe | 2017-08-08T01:13:32 | servo: Merge #18005 - Don't clear animation only dirty bit during style recalc (from hiikezoe:dont-unset-animation-only-dirty-bit); r=birtles
Unless the element is in a display:none subtree.
After bug 1356141, the setup of animation-only dirty bit should have matched
to normal dirty bit's one (Though they don't match... | diff --git a/style/traversal.rs b/style/traversal.rs
index cd90f5687..a430ad22a 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -563,9 +563,6 @@ where
} else {
element.has_dirty_descendants()
};
- if flags.for_animation_only() {
- unsafe { element.unset_animation_onl... | 1 | 0 | 3 |
f20e7aabd630cecadd4c3cdb066d64abc7137ab1 | Daisuke Akatsuka | 2017-08-08T00:06:43 | servo: Merge #17985 - Make list-style-type animatable (from dadaa:make-list-style-type-animatable); r=hiro
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 68036f26e..52ee3dfd6 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -967,6 +967,31 @@ extern "C" {
pub fn Gecko_CopyCounterStyle(dst: *mut CounterStylePtr,
... | 5 | 86 | 5 |
e11d81add7b07bef6c69b77e20b4130d4e27da50 | Alan Jeffrey | 2017-08-07T21:54:35 | servo: Merge #17845 - Use CSS background-size property when computing the size of a paint worklet (from asajeffrey:script-paint-worklet-background-size); r=glennw
<!-- Please describe your changes on the following line: -->
The size of a paint worklet should be based on the background-size CSS property.
---
<!-- Tha... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index 05dee791c..d3954ad89 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -1177,7 +1177,17 @@ impl FragmentDisplayListBuilding for Fragment {
// https://github.com/w3c/css-houdini-drafts/issues/417... | 1 | 11 | 1 |
2499f8438d39b58cd8672a36efad5e045feaec1e | Emilio Cobos Álvarez | 2017-08-07T18:21:42 | servo: Merge #17998 - style: Remove outdated comments (from emilio:outdated); r=SimonSapin
(And tidy a bit a misindented function while at it).
Source-Repo: https://github.com/servo/servo
Source-Revision: 82de4c49f378aed7c9497ba6995020fa79dbf942 | diff --git a/style/selector_map.rs b/style/selector_map.rs
index 193196c48..feba25658 100644
--- a/style/selector_map.rs
+++ b/style/selector_map.rs
@@ -403,10 +403,12 @@ impl<T: SelectorMapEntry> SelectorMap<T> {
///
/// The first non-None value returned from |f| is returned.
#[inline(always)]
-fn find_from_left<F,... | 1 | 6 | 8 |
d41b2b209c1f1a74ff68c73f59717ba7ad4dd885 | Emilio Cobos Álvarez | 2017-08-07T14:42:16 | servo: Merge #17995 - style: Don't pre-fill eager pseudo-maps (from emilio:less-pseudo-maps); r=SimonSapin
This was needed long time ago for Servo's layout. But I don't think there's any
reason for doing this now.
Source-Repo: https://github.com/servo/servo
Source-Revision: f8abce8b72bf3fb09d39d6c7d708a79d1b89c9db | diff --git a/style/stylist.rs b/style/stylist.rs
index f0b2dcc46..9426ecd11 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1646,14 +1646,10 @@ struct PerOriginCascadeData {
impl PerOriginCascadeData {
fn new() -> Self {
- let mut data = PerOriginCascadeData {
+ Self {
elemen... | 1 | 3 | 11 |
d9638b8946642115ffc49fed6f60087e574baf94 | Emilio Cobos Álvarez | 2017-08-07T12:13:38 | servo: Merge #17993 - style: Avoid hashing the precomputed hash atoms already have (from emilio:rehash); r=SimonSapin
This shaves a fair amount of time of stylist rebuild.
Most of the extra remaining overhead are memory allocations...
I'll try to get those sorted out next, though fixing that may overlap quite a
bit ... | diff --git a/style/lib.rs b/style/lib.rs
index e14537069..fcf487525 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -71,7 +71,7 @@ extern crate ordered_float;
extern crate owning_ref;
extern crate parking_lot;
extern crate pdqsort;
-#[cfg(feature = "gecko")] extern crate precomputed_hash;
+extern crate precomputed_h... | 2 | 46 | 9 |
50f9bb375bf0a060bdbfaf1ed73fffc5097e09f4 | Emilio Cobos Álvarez | 2017-08-07T10:15:37 | servo: Merge #17991 - style: Avoid branching on the origin for each selector when inserting in the cascade data (from emilio:dumb-branches); r=heycam
This is on top of #17990, and it's intended to help with bug 1386045.
Source-Repo: https://github.com/servo/servo
Source-Revision: 806540cabdbca1799dd14bb1c67bd0c86b21f... | diff --git a/style/stylist.rs b/style/stylist.rs
index 636f0646c..f0b2dcc46 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -458,6 +458,10 @@ impl Stylist {
self.effective_media_query_results.saw_effective(stylesheet);
let origin = stylesheet.origin(guard);
+
+ let origin_cascade_data... | 1 | 5 | 2 |
da144633c5e4168360886bc7a59e1ec1384957d1 | Cameron McCormack | 2017-08-07T09:03:24 | servo: Merge #17990 - style: Invert storage of selector maps to key off origin first (from heycam:invert-selector-maps); r=emilio
<!-- Please describe your changes on the following line: -->
This will make it easier to avoid rebuilding all cascade levels when only a style sheet at a particular level changes.
---
<!-... | diff --git a/style/stylist.rs b/style/stylist.rs
index a488ae461..636f0646c 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -51,9 +51,8 @@ pub use ::fnv::FnvHashMap;
/// This structure holds all the selectors and device characteristics
/// for a given document. The selectors are converted into `Rule`s
-/// ... | 1 | 167 | 104 |
4c172b0e90f36657101f36f1098e416d84615593 | Nazım Can Altınova | 2017-08-07T08:08:09 | servo: Merge #17986 - Implement ToAnimatedZero for MozLength (from canaltinova:moz-length); r=hiro
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach tes... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 4419e2921..d6e20b26c 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1364,7 +1364,14 @@ impl Animatable for MozL... | 2 | 10 | 3 |
0c080bdb7b9827a835d2f7739d25df46421d8249 | Bobby Holley | 2017-08-07T07:00:02 | servo: Merge #17988 - Use a 1-entry smallvec in the selector maps (from bholley:smallvec_selectormap); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1363789
Source-Repo: https://github.com/servo/servo
Source-Revision: 19d862a984d11c9d4f97d50924ad2d5fdabaf7e9 | diff --git a/style/selector_map.rs b/style/selector_map.rs
index 0a7ebb656..c4bc3dcad 100644
--- a/style/selector_map.rs
+++ b/style/selector_map.rs
@@ -16,7 +16,7 @@ use selector_parser::SelectorImpl;
use selectors::matching::{matches_selector, MatchingContext, ElementSelectorFlags};
use selectors::parser::{Componen... | 1 | 17 | 10 |
2b6e03bce7f9b8c0587987ff5439517785621e60 | Cameron McCormack | 2017-08-07T05:52:22 | servo: Merge #17987 - style: Remove stray debugging println (from heycam:rm-println); r=upsuper
Left this in accidentally in #17981.
Source-Repo: https://github.com/servo/servo
Source-Revision: 8f34d54b0fa74cfa17f522be836eb259cfc0a905 | diff --git a/style/properties/longhand/font.mako.rs b/style/properties/longhand/font.mako.rs
index 0f7c50e4f..754e4b81a 100644
--- a/style/properties/longhand/font.mako.rs
+++ b/style/properties/longhand/font.mako.rs
@@ -213,7 +213,6 @@ macro_rules! impl_gecko_keyword_conversions {
serialization.pu... | 1 | 0 | 1 |
1cb036af3c546f5bbd9425b3be510abbafb57019 | Emilio Cobos Álvarez | 2017-08-06T11:16:12 | servo: Merge #17966 - style: Less ID revalidation selectors (from emilio:less-id-revalidation-stuff); r=bzbarsky
Avoid adding id selectors that are in the rule hash keyed by that ID to the list
of revalidation selectors.
This partially fixes bug 1369611 (we could look at the rule hash itself to avoid
inserting some m... | diff --git a/style/stylist.rs b/style/stylist.rs
index 18c6ce1be..a488ae461 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1484,16 +1484,23 @@ struct StylistSelectorVisitor<'a> {
state_dependencies: &'a mut ElementState,
}
-fn component_needs_revalidation(c: &Component<SelectorImpl>) -> bool {
+fn com... | 1 | 14 | 6 |
e37503d6fb098bdd654c935eddfa0f9ec2ba0ddd | Nathan Froyd | 2017-08-05T14:58:26 | servo: Merge #17974 - remove testing feature from stylo_tests (from froydnj:remove-testing-feature); r=SimonSapin
`stylo_tests` currently requires a separate version of the `style` crate, compiled with the `testing` feature, so a function testing the size of specified values can be accessed. With a few tweaks, we can... | diff --git a/style/lib.rs b/style/lib.rs
index b82d2fd3c..e14537069 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -171,7 +171,7 @@ pub mod gecko_properties {
}
macro_rules! reexport_computed_values {
- ( $( $name: ident )+ ) => {
+ ( $( { $name: ident, $boxed: expr } )+ ) => {
/// Types for [comput... | 2 | 3 | 39 |
2c175ff93dfbb67bfcfa20fb958ff4f418bee20d | Cameron McCormack | 2017-08-05T10:52:59 | servo: Merge #17982 - style: Don't perform parent display-based style fixups on most pseudos (from heycam:parent-fixup); r=emilio
Reviewed by Emilio in https://bugzilla.mozilla.org/show_bug.cgi?id=1379865.
Source-Repo: https://github.com/servo/servo
Source-Revision: 586f84f5fea9a15c90dc5bc5415e2c5f5caa3ddb | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 5b1cbfdf2..05e2ebbfb 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -115,6 +115,13 @@ impl PseudoElement {
(self.flags() & structs::CSS_PSEUDO_ELEMENT_SUPPORTS_USER_ACTION_STATE) != 0
}
+ ... | 3 | 16 | 1 |
b6d1b16c7873fa6c76d24a95ce578ed46d89d68b | Cameron McCormack | 2017-08-05T09:56:08 | servo: Merge #17981 - style: Preserve font-family identifier sequence when serializing (from heycam:family-serialization); r=emilio
Reviewed by Emilio in https://bugzilla.mozilla.org/show_bug.cgi?id=1384398.
Source-Repo: https://github.com/servo/servo
Source-Revision: 6cb790f8eb5024dba1d82ad5f7fb4bb912aeda46 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 839fdeb1d..de2359193 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2181,7 +2181,7 @@ fn static_assert() {
}
pub fn set_font_family(&mut self, v: longhands::font_family::computed_value::T... | 2 | 54 | 21 |
e7cfddf10fdcac3f59d5a6d4b86392438a422b9c | Bobby Holley | 2017-08-05T08:23:55 | servo: Merge #17980 - Introduce a new flag and use it to be more permissive about cousin sharing (from bholley:fix_initial_sharing); r=emilio
https://bugzilla.mozilla.org/show_bug.cgi?id=1387116
Source-Repo: https://github.com/servo/servo
Source-Revision: b701d726f2840d61573d213f2e2008335dc9831e | diff --git a/style/data.rs b/style/data.rs
index 8e63fb525..07870fad7 100644
--- a/style/data.rs
+++ b/style/data.rs
@@ -22,8 +22,17 @@ bitflags! {
flags RestyleFlags: u8 {
/// Whether the styles changed for this restyle.
const WAS_RESTYLED = 1 << 0,
+ /// Whether the last traversal of thi... | 4 | 45 | 23 |
a26a71dc371d371ade0c878dd49b93438cf8ce6b | Cameron McCormack | 2017-08-05T07:03:47 | servo: Merge #17979 - style: Revert font-family serialization commit #17972 (from heycam:font-family-revert); r=heycam
This reverts commit 4f525f6fa04195cdb93fc4394fbc0c78f2626bd7.
I accidentally included some unrelated changes in #17972, so backing out here.
Source-Repo: https://github.com/servo/servo
Source-Revisi... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 11beac200..839fdeb1d 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2181,7 +2181,7 @@ fn static_assert() {
}
pub fn set_font_family(&mut self, v: longhands::font_family::computed_value::T... | 2 | 19 | 47 |
23b9f15c69d50a0b8e561bbeecb808128ed29f33 | Cameron McCormack | 2017-08-05T02:33:59 | servo: Merge #17972 - style: Allow styles to be computed ignoring existing element data (from heycam:ignore-existing); r=bholley
From https://bugzilla.mozilla.org/show_bug.cgi?id=1384824.
Source-Repo: https://github.com/servo/servo
Source-Revision: ac37f81c1f70f6994444ca0c40ad9d91a228ec87 | diff --git a/layout/query.rs b/layout/query.rs
index 252071e9b..fd9a97f44 100644
--- a/layout/query.rs
+++ b/layout/query.rs
@@ -702,7 +702,7 @@ pub fn process_resolved_style_request<'a, N>(context: &LayoutContext,
thread_local: &mut tlc,
};
- let styles = resolve_style(&mut context, element, RuleInc... | 5 | 53 | 22 |
933fd24a06a92a1fc692fa359dec82d261f0551a | Martin Robinson | 2017-08-04T16:17:24 | servo: Merge #17923 - Fix fixed position items with parents with CSS clips (from mrobinson:fixed-position-css-clip); r=emilio
In order to properly handle CSS clipping, we need to keep track of what
the different kinds of clips that we have. On one hand, clipping due to
overflow rules should respect the containing bloc... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index ba34abea2..8fa0c33df 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -33,8 +33,8 @@ use style::values::computed::Filter;
use style_traits::cursor::Cursor;
use text::TextRun;
use text::glyph::ByteIndex;
-use webrender_api::{sel... | 8 | 125 | 106 |
006effd1fdb768457bab16801de2dd7702ae0597 | Xidorn Quan | 2017-08-04T10:35:41 | servo: Merge #17970 - Preserve unit in specified time value (from upsuper:time-unit); r=emilio
This fixes #15346.
Source-Repo: https://github.com/servo/servo
Source-Revision: 7b299caf9b547412390512ff07a119a47d0cc1bf | diff --git a/style/values/specified/mod.rs b/style/values/specified/mod.rs
index 1728d4113..02ad9ac32 100644
--- a/style/values/specified/mod.rs
+++ b/style/values/specified/mod.rs
@@ -311,11 +311,22 @@ impl BorderStyle {
}
}
+/// Time unit.
+#[derive(Clone, Copy, Debug, HasViewportPercentage, PartialEq, Eq)]
+... | 1 | 29 | 5 |
d64e83ce2ad1b224f5c0a9d5784c159058ef272c | Xidorn Quan | 2017-08-04T09:31:19 | servo: Merge #17971 - Always set mBgPos for LineDirection::Vertical (from upsuper:linear-gradient); r=canaltinova
This fixes [bug 1385469](https://bugzilla.mozilla.org/show_bug.cgi?id=1385469).
Source-Repo: https://github.com/servo/servo
Source-Revision: 187254bf26fc9974c65d061a146bbbbfb484fbd3 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 8e962e4d7..5877e3917 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -229,14 +229,18 @@ impl nsStyleImage {
}
},
LineDirection::Vertical(y) => {
- ... | 1 | 12 | 8 |
c43d66d6de4d54853126c3cf380ec610c8e47832 | Josh Matthews | 2017-08-04T07:10:05 | servo: Merge #17967 - CSS parsing optimizations (from jdm:parsefun); r=SimonSapin
These address some small inefficiencies that showed up while profiling the myspace talos test.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
Source-Repo: https://github.com/s... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 93e653b08..a80fcfb8c 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -30,7 +30,7 @@ use font_metrics::FontMetricsProvider;
#[cfg(feature = "servo")] use logical_geometry::{LogicalM... | 1 | 11 | 12 |
f0940bff8f967391dad61100b2c348e10d90c2b8 | Daisuke Akatsuka | 2017-08-03T23:52:13 | servo: Merge #17964 - Make 'image-orientation' and 'paint-order' animatable (from dadaa:bug1386963); r=hiro
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 7db095ef6..839fdeb1d 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4546,6 +4546,31 @@ fn static_assert() {
pub fn reset_image_orientation(&mut self, other: &Self) {
self.copy_image_ori... | 3 | 51 | 2 |
7810b2f22aa1b469c89b0fd5d395f4026f8be5f3 | Manish Goregaokar | 2017-08-03T21:27:12 | servo: Merge #17969 - Update stylo code to work on nightly (from Manishearth:rustup); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1386887
Source-Repo: https://github.com/servo/servo
Source-Revision: 7cee7d7fcc4194e410fa8a308a77d37ac452778a | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index e46bdfe1e..b6703ab95 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -8,6 +8,7 @@ type nsAString_internal = nsAString;
pub type ServoStyleContextBorrowed<'a> = &'a ::properties::ComputedVa... | 2 | 15 | 4 |
d4cdf00f390406e1245290c5451cd00fd211530c | Emilio Cobos Álvarez | 2017-08-03T16:35:17 | servo: Merge #17968 - style: Prevent cousin sharing if we haven't restyled the parents (from emilio:no-sharing-if-not-restyled); r=bzbarsky
This "fixes" bug 1381821 by disabling the optimization in the cases we can't
prove this is correct. Bug 1387116 tracks fixing the optimization to apply more
broadly.
Bug: 1381821... | diff --git a/style/sharing/checks.rs b/style/sharing/checks.rs
index e7f8db5a5..259cadc95 100644
--- a/style/sharing/checks.rs
+++ b/style/sharing/checks.rs
@@ -19,17 +19,38 @@ use sharing::{StyleSharingCandidate, StyleSharingTarget};
///
/// This is used to know whether we can share style across cousins (if the two
... | 1 | 25 | 4 |
ba8d2d7bb4beb37ce505629fc4ccda321b66a9c6 | Emilio Cobos Álvarez | 2017-08-03T14:36:21 | servo: Merge #17965 - stylo: Avoid recreating the stylist in RebuildAllStyleData (from emilio:rebuild-not); r=heycam
Bug: 1386602
Reviewed-by: heycam
MozReview-Commit-ID: 31G9BLgqEmm
Source-Repo: https://github.com/servo/servo
Source-Revision: 8b5a356c57e6ad9b2d40936760674f96e40e9b1b | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index a9b6e83d3..e46bdfe1e 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -1934,12 +1934,12 @@ extern "C" {
pub fn Servo_StyleSet_Clear(set: RawServoStyleSetBorrowed);
}
extern "C" {
- ... | 2 | 15 | 17 |
16f566e989d3c3743e2feae86c104c022f926b7b | Martin Robinson | 2017-08-03T12:51:22 | servo: Merge #17960 - Fix warning in scroll root id assignment to TableColGroupFlow (from mrobinson:fix-warning-for-table-colgroup); r=emilio
The traversal currently expects every flow to have a scroll root id
assigned, even if it doesn't produce any display items. This change
fixes the error that arises from this sit... | diff --git a/layout/table_colgroup.rs b/layout/table_colgroup.rs
index 44519a3bb..97d0ef890 100644
--- a/layout/table_colgroup.rs
+++ b/layout/table_colgroup.rs
@@ -92,7 +92,11 @@ impl Flow for TableColGroupFlow {
// Table columns are invisible.
fn build_display_list(&mut self, _: &mut DisplayListBuildState) ... | 1 | 5 | 1 |
597f0c966c3398b66d6a632f8420d4da38b569ab | Emilio Cobos Álvarez | 2017-08-03T10:50:18 | servo: Merge #17959 - style: Move nsStyleContext::mParent to GeckoStyleContext (from emilio:no-moar-parent); r=heycam
Unfortunately this means that we lose the NS_STYLE_INHERIT_BIT optimization to
avoid posting changes if we had not requested the struct. In practice, I'm not
sure this optimization matters much, though... | diff --git a/style/gecko/generated/pseudo_element_definition.rs b/style/gecko/generated/pseudo_element_definition.rs
index 46da69d1e..485d4a023 100644
--- a/style/gecko/generated/pseudo_element_definition.rs
+++ b/style/gecko/generated/pseudo_element_definition.rs
@@ -362,7 +362,7 @@ impl PseudoElement {
/// Whe... | 6 | 41 | 5 |
3b77b0c17af6927bacc9314c99ef0f5ad30a6f6b | Xidorn Quan | 2017-08-03T09:46:52 | servo: Merge #17961 - Make font-display descriptor behind the pref (from upsuper:font-display-pref); r=heycam
This is the Servo side change of [bug 1386871](https://bugzilla.mozilla.org/show_bug.cgi?id=1386871).
Source-Repo: https://github.com/servo/servo
Source-Revision: 24b2cd89c124457e837bcde7cc9101747b96e9d4 | diff --git a/style/font_face.rs b/style/font_face.rs
index 23f1496b1..77bf43d20 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -210,6 +210,16 @@ impl Parse for Source {
}
}
+macro_rules! is_descriptor_enabled {
+ ("font-display") => {
+ unsafe {
+ use gecko_bindings::structs::m... | 3 | 19 | 1 |
f9b40d3ec24a3fbbb5da150f713a55e0fa87b795 | Bobby Holley | 2017-08-03T08:46:02 | servo: Merge #17952 - Use drain() over IntoIter on a few SmallVecs (from bholley:drain_smallvec); r=emilio
This is all the ones I could find in style/ and selectors/.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1374848
Source-Repo: https://github.com/servo/servo
Source-Revision: 27d1fbe7eae70603a4f477156360068c... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index e9b59f7f8..06f381d60 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -1528,7 +1528,7 @@ fn parse_compound_selector<'i, 't, P, E, Impl>(
}
builder.push_simple_selector(Component::PseudoElement(p));
- ... | 2 | 2 | 2 |
ab6b1dbad9ce7a341df92c5b43cf7379e0b8ee38 | Fernando Jiménez Moreno | 2017-08-03T07:42:13 | servo: Merge #17957 - stylo: serialize radial gradients computed value using modern unprefi… (from ferjm:bug1380259); r=xidorn
…xed style
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
https://bugzilla.mozilla.org/show_bug.cgi?id=1380259
Source-Repo: https://g... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 5835d217f..8e962e4d7 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -307,7 +307,7 @@ impl nsStyleImage {
Gecko_CreateGradient(gecko_shape,
gecko_size,
... | 1 | 1 | 1 |
5c2644a4dcd3a097d451e68472b82dfa892eacfb | DarkDrek | 2017-08-03T02:01:12 | servo: Merge #17950 - Replace downcast with is (from DarkDrek:downcast_to_is); r=jdm
<!-- Please describe your changes on the following line: -->
I searched for all places where `if let Some(_) = self.downcast::` and replaced them with `::is`
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by ... | diff --git a/script/dom/characterdata.rs b/script/dom/characterdata.rs
index 9db34a49f..747589ada 100644
--- a/script/dom/characterdata.rs
+++ b/script/dom/characterdata.rs
@@ -91,7 +91,7 @@ impl CharacterDataMethods for CharacterData {
// If this is a Text node, we might need to re-parse (say, if our parent
... | 2 | 2 | 2 |
12c81971926c8c671c585ef18e6dea1e6dd7e1b0 | Nicholas Nethercote | 2017-08-03T00:39:15 | servo: Merge #17953 - stylo: Measure Elements and ComputedValues (from nnethercote:bug-1383977); r=Manishearth
This is for https://bugzilla.mozilla.org/show_bug.cgi?id=1383977.
<!-- Please describe your changes on the following line: -->
The patch provides FFI access to Gecko's SeenPtrs type from Rust, in
order to re... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index d8a747582..182acecf8 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -41,6 +41,7 @@ use std::hash::{Hash, Hasher};
use std::iter::{ExactSizeIterator, Iterator};
use std::mem;
use std::ops::{Deref, DerefMut};
+use std::os::raw::c_void;
use std::process;
... | 8 | 139 | 3 |
1993ac94d38390d6737900d8326f88d2ca548dcf | Hiroyuki Ikezoe | 2017-08-02T23:30:07 | servo: Merge #17951 - Make replace_rules_internal return true only if important rules changed (from hiikezoe:import-rule-check); r=emilio
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1367975
---
<!-- Thank you for contributing to Servo! Please replace each ... | diff --git a/style/matching.rs b/style/matching.rs
index 75e45363a..72e110ce1 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -744,15 +744,17 @@ pub trait MatchMethods : TElement {
let replace_rule_node = |level: CascadeLevel,
pdb: Option<ArcBorrow<Locked<PropertyDec... | 2 | 14 | 8 |
0c65293e13b8519317b70f94adc5fb45dcb4185d | Emilio Cobos Álvarez | 2017-08-02T22:35:57 | servo: Merge #17939 - style: Avoid looping through every selector more than twice (from emilio:multiple-walk-selector); r=bzbarsky
I've left the Invalidation stuff on its own since that's more complex, but I
think this may help a bit (perhaps not too much though?) with the slow rebuild
times.
Source-Repo: https://git... | diff --git a/style/stylist.rs b/style/stylist.rs
index e70a0e2fc..db444a538 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -502,19 +502,22 @@ impl Stylist {
self.quirks_mode);
self.invalidation_map.note_selector(selector, self.quirks_mode);
- ... | 1 | 154 | 158 |
0c9221e8cc87e92e5b675c1ce86dfea945a7925c | Hiroyuki Ikezoe | 2017-08-02T21:27:58 | servo: Merge #17944 - Display property animation for SMIL (from hiikezoe:display-property-animation); r=emilio
<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1385089
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the ste... | diff --git a/style/context.rs b/style/context.rs
index bd7e640e0..675fff06c 100644
--- a/style/context.rs
+++ b/style/context.rs
@@ -409,7 +409,7 @@ impl TraversalStatistics {
#[cfg(feature = "gecko")]
bitflags! {
/// Represents which tasks are performed in a SequentialTask of
- /// UpdateAnimations.
+ ///... | 4 | 180 | 11 |
2607adf3201b1554a9eea30f5b8b5393be5db15d | Manish Goregaokar | 2017-08-02T17:26:56 | servo: Merge #17947 - stylo: Support text-zoom (from Manishearth:stylo-text-zoom); r=emilio
r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1358688
Source-Repo: https://github.com/servo/servo
Source-Revision: 756982634023e3bd303a0b511d9066df34f636b0 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 27d8a5f6c..070e2698e 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -186,6 +186,15 @@ impl Device {
pub fn default_background_color(&self) -> RGBA {
convert_nscolor_to_rgba(self.pres_context().m... | 8 | 157 | 24 |
31a57316211e9fa6e3b93e851f9b263c1d773bba | Manish Goregaokar | 2017-08-02T09:10:08 | servo: Merge #17943 - Bump app units to 0.5.2 (from Manishearth:bump-au); r=emilio
Prerequisite for landing text zoom stuff.
Source-Repo: https://github.com/servo/servo
Source-Revision: de5f6f19bd1cb8df92db9bf73ee82b6e27f238c7 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 01436213c..616553a0d 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -30,7 +30,7 @@ testing = []
gecko_debug = ["nsstring_vendor/gecko_debug"]
[dependencies]
-app_units = "0.5.1"
+app_units = "0.5.2"
arrayvec = "0.3.20"
arraydeque = "0.2.3"
atomic_re... | 1 | 1 | 1 |
8a2ec94922d6defe9bc603003ce19b3b36365196 | Corey Farwell | 2017-08-02T08:01:26 | servo: Merge #17883 - Audit usages of unicode case-changing methods (from frewsxcv:frewsxcxv-lowercase); r=SimonSapin
Part of https://github.com/servo/servo/issues/17777.
Source-Repo: https://github.com/servo/servo
Source-Revision: 5fff90c73f77dd9ed41b692e6b3ea960a29ee8a8 | diff --git a/net/fetch/methods.rs b/net/fetch/methods.rs
index b6b5d8023..59da722fb 100644
--- a/net/fetch/methods.rs
+++ b/net/fetch/methods.rs
@@ -21,6 +21,7 @@ use net_traits::request::{Referrer, Request, RequestMode, ResponseTainting};
use net_traits::request::{Type, Origin, Window};
use net_traits::response::{Re... | 10 | 47 | 49 |
6fdf4d8b33319ec60c9c7918a5bcf7625d71cd31 | Xidorn Quan | 2017-08-02T00:35:47 | servo: Merge #17940 - stylo: Support context values for SVG properties (from upsuper:context-value); r=Manishearth
This is the Servo side change of [bug 1338764](https://bugzilla.mozilla.org/show_bug.cgi?id=1338764).
Source-Repo: https://github.com/servo/servo
Source-Revision: ddd779d5b751fa8e173fcbe95a7e1a8af62d1d08 | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index f0078fa23..3cb2183f0 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -172,6 +172,9 @@ unsafe impl Sync for nsStyleQuoteValues {}
use gecko_bindings::structs::nsStyleSVG;
unsafe impl Send ... | 13 | 654 | 255 |
48d8b13a6062ad7c2848b1c02d2db753942cc205 | Daisuke Akatsuka | 2017-08-01T21:34:50 | servo: Merge #17929 - Make grid-template-areas/columns/rows animatable (from dadaa:make-grid-template-XX-animatable); r=hiro,waffles
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__`... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 8f3fb6bf2..5835d217f 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -810,7 +810,8 @@ impl TrackSize<LengthOrPercentage> {
if gecko_min.unit() == nsStyleUnit::eStyleUnit_None {
debug_assert!(ge... | 3 | 140 | 5 |
510efbb9d05f6eb4b0cf27600e6c1057fb164217 | Boris Zbarsky | 2017-08-01T20:01:04 | servo: Merge #17936 - Don't start kicking off work units during parallel stylo traversal until they're actually full (from bzbarsky:parallel-better-sharing); r=bholley
This improves style sharing at the cost of a bit less parallelism. Fixes Gecko
bug 1385982. r=bholley
<!-- Please describe your changes on the follo... | diff --git a/style/parallel.rs b/style/parallel.rs
index 358eeffd5..3703559cd 100644
--- a/style/parallel.rs
+++ b/style/parallel.rs
@@ -34,9 +34,16 @@ use traversal::{DomTraversal, PerLevelTraversalData, PreTraverseToken};
/// The maximum number of child nodes that we will process as a single unit.
///
-/// Larger... | 1 | 46 | 13 |
c2c1a6de3783581336512ebc8f024fffae863821 | Manish Goregaokar | 2017-08-01T17:57:42 | servo: Merge #17934 - Remove doc comment on statement (from Manishearth:doc-comment); r=canaltinova
rustc warns about these now
Source-Repo: https://github.com/servo/servo
Source-Revision: b49311c65a083a9b8eb03741bf7ea980b64f1e03 | diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs
index 37ed00ccf..687c6f17d 100644
--- a/style/values/specified/image.rs
+++ b/style/values/specified/image.rs
@@ -686,14 +686,14 @@ impl LineDirection {
input.try(|i| {
let to_ident = i.try(|i| i.expect_ident_matching("... | 1 | 3 | 3 |
b8cf9bcebfff0f00a94f486d51e3c99a9c0fda80 | Emilio Cobos Álvarez | 2017-08-01T16:20:41 | servo: Merge #17933 - stylo: Fix restyle hint conversion to handle eRestyle_ForceDescendants correctly (from emilio:restyle-hint-conversion); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 9fd081bb1d22f01ed8d90092e922ab4bc4006312 | diff --git a/style/invalidation/element/restyle_hints.rs b/style/invalidation/element/restyle_hints.rs
index aac75ddea..94bab9307 100644
--- a/style/invalidation/element/restyle_hints.rs
+++ b/style/invalidation/element/restyle_hints.rs
@@ -189,7 +189,8 @@ impl Default for RestyleHint {
#[cfg(feature = "gecko")]
im... | 1 | 11 | 1 |
33720b77664601c6aa3f6a1880db3647eccc9c9e | Josh Matthews | 2017-07-31T20:50:14 | servo: Merge #17926 - stylo: Report a specific error for invalid CSS color values (from jdm:valueerr); r=heycam
Reviewed by heycam in https://bugzilla.mozilla.org/show_bug.cgi?id=1381143.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests f... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index c29c7eb52..f0078fa23 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -2881,10 +2881,15 @@ extern "C" {
param:
... | 4 | 73 | 36 |
56203f0a57c56a1feb590817d98e736ddf95ec70 | Alan Jeffrey | 2017-07-31T18:13:26 | servo: Merge #17810 - Script paint worklets speculative evaluation (from asajeffrey:script-paint-worklets-speculative-evaluation); r=emilio
<!-- Please describe your changes on the following line: -->
This PR speculatively calls paint worklets during style, which increases the concurrency, since it increases the chan... | diff --git a/layout/context.rs b/layout/context.rs
index cda381142..76d32eebc 100644
--- a/layout/context.rs
+++ b/layout/context.rs
@@ -4,7 +4,6 @@
//! Data needed by the layout thread.
-use fnv::FnvHashMap;
use fnv::FnvHasher;
use gfx::display_list::{WebRenderImageInfo, OpaqueNode};
use gfx::font_cache_thread... | 12 | 277 | 52 |
4d7251ec09b98701a2072a450856c6a9982f821d | Xidorn Quan | 2017-07-31T04:39:02 | servo: Merge #17922 - stylo: Support layout.css.prefixes.device-pixel-ratio-webkit pref (from upsuper:wk-dpr); r=heycam
This is the Servo side change of [bug 1366956](https://bugzilla.mozilla.org/show_bug.cgi?id=1366956).
Source-Repo: https://github.com/servo/servo
Source-Revision: 06e2997d2834bc43b4cea39dcf7bb2f603d... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 5c275e666..c29c7eb52 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -834,9 +834,6 @@ extern "C" {
ComputedTimingFunction_BeforeFlag)
-> f64... | 5 | 149 | 65 |
46f400c94789d50195a6d1779087d226e112303f | Alan Jeffrey | 2017-07-29T20:32:49 | servo: Merge #17546 - Script paint worklets arguments (from asajeffrey:script-paint-worklets-arguments); r=emilio
<!-- Please describe your changes on the following line: -->
Implement paint worklet arguments.
This is a dependent PR, only the last commit is in this PR.
---
<!-- Thank you for contributing to Servo! P... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index 9df8ab596..b3433e62b 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -548,10 +548,15 @@ impl<'a> CanvasPaintThread<'a> {
}
fn recreate(&mut self, size: Size2D<i32>) {
+ // TODO: clear th... | 6 | 78 | 19 |
23c5cb7fd03c724220ec1cea504d72c03ea38d22 | Cameron McCormack | 2017-07-29T16:16:33 | servo: Merge #17918 - style: Don't remain in an invalid state when encountering an at-rule in the wrong place (from heycam:rule-hierarchy); r=emilio
Currently, attempting to parse an at-rule that is out of place, such as
an @import rule after a regular style rule, will cause the parser state
to be set to Invalid. Thi... | diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs
index 09aedb952..480ccf654 100644
--- a/style/stylesheets/mod.rs
+++ b/style/stylesheets/mod.rs
@@ -255,18 +255,19 @@ impl CssRule {
shared_lock: &shared_lock,
loader: loader,
state: state,
+ had_hierarchy... | 3 | 31 | 20 |
f6ab36e7a8d0dcf0e5e4bbc88aa1304833fe6dcc | Nikhil Shagrithaya | 2017-07-29T15:08:11 | servo: Merge #17914 - Run the async HTML Tokenizer on a new thread (from cynicaldevil:new-parser-thread); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate ... | diff --git a/script/dom/servoparser/async_html.rs b/script/dom/servoparser/async_html.rs
index 243e4452b..59411fda1 100644
--- a/script/dom/servoparser/async_html.rs
+++ b/script/dom/servoparser/async_html.rs
@@ -7,9 +7,8 @@
use dom::bindings::codegen::Bindings::HTMLTemplateElementBinding::HTMLTemplateElementMethods;
... | 1 | 461 | 221 |
b613804e22d6e347e3b8ee55e4c6d9bbcc3ef2d5 | DarkDrek | 2017-07-29T14:01:09 | servo: Merge #17916 - Use AntialiasMode in CanvasPaintThread::new (from DarkDrek:Use_AntialiasMode_in_CanvasPaintThread_new); r=emilio
Change suggested in #17661
<!-- Please describe your changes on the following line: -->
I only changed `canvas_paint_thread.rs` since `CanvasPaintThread::start` is used outside of the... | diff --git a/canvas/canvas_paint_thread.rs b/canvas/canvas_paint_thread.rs
index c285f3aa6..9df8ab596 100644
--- a/canvas/canvas_paint_thread.rs
+++ b/canvas/canvas_paint_thread.rs
@@ -80,13 +80,7 @@ struct CanvasPaintState<'a> {
}
impl<'a> CanvasPaintState<'a> {
- fn new(antialias: bool) -> CanvasPaintState<'a>... | 1 | 8 | 9 |
7609a4c879c8c4a6b6241edfc5d1a629bb880bae | Dzmitry Malyshau | 2017-07-29T12:38:23 | servo: Merge #17908 - WR multi-document update - try 2 (from kvark:wr); r=emilio
<!-- Please describe your changes on the following line: -->
Combines #17892 with the patch to detach style_traits from webrender_api
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is compl... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 051454400..4dd167fa9 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -6,7 +6,7 @@ use CompositionPipeline;
use SendableFrameTree;
use compositor_thread::{CompositorProxy, CompositorReceiver};
use compositor_thread::{In... | 11 | 102 | 71 |
bff411164b46a894dd431f181172abb10e24cc30 | Emilio Cobos Álvarez | 2017-07-29T11:41:27 | servo: Merge #17906 - style: Don't unconditionally generate Calc values when converting background-size from Gecko (from emilio:calc-bgsize); r=hiro,birtles
Bug: 1385140
MozReview-Commit-ID: ERwq50WSvLV
Source-Repo: https://github.com/servo/servo
Source-Revision: 6b320eaad3b0bc5e5efe432f504714156d325c4d | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 2426bef42..8f3fb6bf2 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -102,6 +102,16 @@ impl From<nsStyleCoord_CalcValue> for LengthOrPercentage {
}
}
+impl From<nsStyleCoord_CalcValue> for LengthOrPercentageOr... | 2 | 11 | 1 |
18dc6f81d92cc74d022829f81803c9ea23997766 | Xidorn Quan | 2017-07-29T10:22:20 | servo: Merge #17915 - Remove Gecko_GetMediaFeatures and access nsMediaFeatures::features directly (from upsuper:media-features); r=emilio
This is the Servo side change of [bug 1385529](https://bugzilla.mozilla.org/show_bug.cgi?id=1385529).
Source-Repo: https://github.com/servo/servo
Source-Revision: 03223be66bd6ff501... | diff --git a/style/gecko/generated/bindings.rs b/style/gecko/generated/bindings.rs
index 235ba7f42..5c275e666 100644
--- a/style/gecko/generated/bindings.rs
+++ b/style/gecko/generated/bindings.rs
@@ -78,7 +78,6 @@ use gecko_bindings::structs::nsFont;
use gecko_bindings::structs::nsIAtom;
use gecko_bindings::structs:... | 2 | 2 | 11 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.