sha
stringlengths
40
40
author
stringlengths
1
63
committer
stringlengths
1
41
message
stringlengths
1
65.5k
subject
stringlengths
1
5.64k
subject_length
float64
1
5.64k
is_chore
bool
2 classes
is_bot
bool
2 classes
subject_word_count
float64
1
806
verb_object_spacy
bool
2 classes
verb_object_stanza
bool
2 classes
fits_requirements
bool
2 classes
owner
stringlengths
2
15
repo
stringlengths
2
21
__index_level_0__
int64
0
85k
e711174b5b73c433a8d404130ae5b5bf999c7a95
Matthew Beale
Matthew Beale
Merge pull request #11187 from mixonic/sendAction-with-mut [BUGFIX beta] Handle mut cell action names. Fixes #11176
merge pull request from mixonic/sendaction-with-mut
52
true
false
5
true
false
false
emberjs
ember.js
12,200
458cbebe9d2fb480166f8211fc6594159a4c09ee
Matthew Beale
Matthew Beale
[BUGFIX beta] Handle mut cell action names. Fixes #11176
[bugfix beta] handle mut cell action names. fixes
49
false
false
8
false
false
false
emberjs
ember.js
12,201
6dba87afb90f836c5040d9dbece88572818889a8
Robert Jackson
Robert Jackson
Merge pull request #11178 from jayphelps/key-in-locals [BUGFIX beta] getRoot scope.locals lookup shouldn't rely on truthiness
merge pull request from jayphelps/key-in-locals
48
true
false
5
true
false
false
emberjs
ember.js
12,202
7d1a16a2a406644947cb4a8baddfd4d442f95c9e
Martin Muñoz
Martin Muñoz
Merge pull request #11179 from emberjs/remove-unused-view-code Remove unused _yield and _blockArguments
merge pull request from emberjs/remove-unused-view-code
56
true
false
5
true
false
false
emberjs
ember.js
12,203
aa1607b33c5fa56f566f346bb94480437bc0183a
Tom Dale + Yehuda Katz
Tom Dale
Remove unused _yield and _blockArguments
remove unused _yield and _blockarguments
40
false
false
5
true
true
true
emberjs
ember.js
12,204
3e4fd3451e950dfa270cf89f21463102e604f7c6
Jay Phelps
Jay Phelps
[BUGFIX beta] getRoot scope.locals lookup shouldn't rely on truthiness
[bugfix beta] getroot scope.locals lookup shouldn't rely on truthiness
70
false
false
9
false
false
false
emberjs
ember.js
12,205
e6a165e18fd3b243d8b9b1c45a62a875ce3610d1
Robert Jackson
Robert Jackson
Merge pull request #10980 from artych/namespaced-strings-fix [BUGFIX] Namespaced strings conversions
merge pull request from artych/namespaced-strings-fix
54
true
false
5
true
false
false
emberjs
ember.js
12,206
7d5c8a71b80ca0d99d185ed01f963d6ae4282faf
Robert Jackson
Robert Jackson
Merge pull request #11102 from joeruello/if-docs [DOC canary] Document {{#if}} and {{#unless}} helpers
merge pull request from joeruello/if-docs
42
true
false
5
true
false
false
emberjs
ember.js
12,207
e75b209c69acf888ac1368390da3a259b950e940
joe
joe
[DOC canary] Document {{#if}} and {{#unless}} helpers
[doc canary] document {{#if}} and {{#unless}} helpers
53
false
false
7
false
false
false
emberjs
ember.js
12,208
6380e230d717c6d93ff3ff8b71c360da48c82a6f
Matthew Beale
Matthew Beale
Merge pull request #11146 from YoranBrondsema/yb-fix-documentation-for-each-and-with-helpers Fix documentation for {{each}} and {{with}} helpers
merge pull request from yoranbrondsema/yb-fix-documentation-for-each-and-with-helpers
86
true
false
5
true
false
false
emberjs
ember.js
12,209
7b335140fd1c1a719eb557506b765432343360a9
Matthew Beale
Matthew Beale
Merge pull request #11161 from kamalaknn/bugfix_select_optgroup [BUGFIX BETA] Fix initial selection for select with optgroup
merge pull request from kamalaknn/bugfix_select_optgroup
57
true
false
5
true
false
false
emberjs
ember.js
12,210
5b3b67e539349438aa17c614ae5c0bc2c071a795
Matthew Beale
Matthew Beale
Merge pull request #11168 from drapergeek/patch-1 [DOC release] Fix Enumerable#reject documentation
merge pull request from drapergeek/patch-1
43
true
false
5
true
false
false
emberjs
ember.js
12,211
23423536cfa1f7dcf70e427115ea53ab527226f1
Matthew Beale
Matthew Beale
Merge pull request #11169 from owilliams/fix-component-assert-typo [Doc release] Fix typo in component lookup assert
merge pull request from owilliams/fix-component-assert-typo
60
true
false
5
true
false
false
emberjs
ember.js
12,212
c8fe4ab79bbf1885e890312d1f771ff593d99b0b
Tom Dale
Tom Dale
Add {{each-in}} support for inverse
add {{each-in}} support for inverse
35
false
false
5
false
false
false
emberjs
ember.js
12,213
8eb7a05cc842960fd91940593197ae88fe0b1a0c
Tom Dale
Tom Dale
Implement {{each-in}} helper The {{each-in}} helper is similar to {{each}}, but instead of enumerating array items, it enumerates the properties of an object. If {{each}} is a for loop, you can think of {{each-in}} as a for-in loop.
implement {{each-in}} helper
28
false
false
3
false
false
false
emberjs
ember.js
12,214
82843abdb5820378fec5501dee280b4d4d0554ea
Owain Williams
Owain Williams
Fix typo in component lookup assert “canot” => “cannot”
fix typo in component lookup assert
35
false
false
6
true
true
true
emberjs
ember.js
12,215
5e3600da44d3d590ab5c4d5de9d75c1ab4ad1d44
Robert Jackson
Robert Jackson
Failing test for {{each}} inverse transitioning to template bug.
failing test for {{each}} inverse transitioning to template bug
63
false
false
9
false
false
false
emberjs
ember.js
12,216
e830ce06682cbc9d1eab842aaad761925f6e4c5a
Jason Draper
Jason Draper
[DOC release] Fix Enumerable#reject documentation Reject requires a falsey value to include the item in the array. The previous documentation was contradictory between the first paragraph and the third. This corrects the first sentence so that it is inline with being the inverse of filter().
[doc release] fix enumerable#reject documentation
49
false
false
5
false
false
false
emberjs
ember.js
12,217
e753dfc81637c5f14cac606e3f49d12190d77a70
Robert Jackson
Robert Jackson
Merge pull request #10746 from cibernox/cleanup_new_cp_syntax_conditional_branches Cleanup after new CP syntax became the default
merge pull request from cibernox/cleanup_new_cp_syntax_conditional_branches
76
true
false
5
true
false
false
emberjs
ember.js
12,218
f3a8792e57b525c54345bfc37626dbe6d9611fa7
kamalakannan.n
kamalakannan.n
[BUGFIX BETA] Fix initial selection for select with optgroup
[bugfix beta] fix initial selection for select with optgroup
60
false
false
9
false
false
false
emberjs
ember.js
12,219
257c2bc8dcc4c6f418abf6b1142c688d9dcee0c7
Robert Jackson
Robert Jackson
Merge pull request #11160 from rwjblue/avoid-initializers [BUGFIX beta] Avoid using initializers for default registry setup.
merge pull request from rwjblue/avoid-initializers
51
true
false
5
true
false
false
emberjs
ember.js
12,220
f2540bf3b625e402f65c7bb4afe87acdcddc3004
Robert Jackson
Robert Jackson
Merge pull request #11138 from rwjblue/make-bind-attr-deprecation-more-debuggable Add a better deprecation for `{{bind-attr}}`.
merge pull request from rwjblue/make-bind-attr-deprecation-more-debuggable
75
true
false
5
true
false
false
emberjs
ember.js
12,221
1f088754bfecc313886568c29338c050910fedfc
Robert Jackson
Robert Jackson
[BUGFIX beta] Avoid using initializers for default registry setup. Testing infrastructure can now call `buildRegistry` if it exists, and have a registry setup with all of the defaults (without having to run all the initializers).
[bugfix beta] avoid using initializers for default registry setup
65
false
false
9
false
false
false
emberjs
ember.js
12,222
502bc50b12b11d380af6fa097871ece311ded090
Miguel Camba
Miguel Camba
Clean unnecesary checks for new-cp-syntax feature flag Removed all trace of the feature flag
clean unnecesary checks for new-cp-syntax feature flag
54
false
false
7
false
false
false
emberjs
ember.js
12,223
0fe3ae595f8a0fd2c2daa38dd1a3aa0c27cc7e43
Robert Jackson
Robert Jackson
Post release version bump.
post release version bump
25
false
false
4
false
false
false
emberjs
ember.js
12,224
0a7c0fce26f11f14f66493758d568c00815569f4
Robert Jackson
Robert Jackson
Update CHANGELOG for 1.12.0.
update changelog for 1.12.0
27
false
false
4
true
true
true
emberjs
ember.js
12,225
2615a95536b466bbac039f6d15a19cbf9b6df4cd
Robert Jackson
Robert Jackson
Merge pull request #11158 from rwjblue/enable-feature Enable features for 1.13.
merge pull request from rwjblue/enable-feature
47
true
false
5
true
false
false
emberjs
ember.js
12,226
bfc5431e664986f8fb2871a066e50d5de4727f74
Robert Jackson
Robert Jackson
Fix JSHint error.
fix jshint error
16
false
false
3
true
true
true
emberjs
ember.js
12,227
3d7f31495291251386b1edf223e3646561839791
Robert Jackson
Robert Jackson
[FEATURE ember-htmlbars-component-generation] Enable by default.
[feature ember-htmlbars-component-generation] enable by default
63
false
false
5
false
false
false
emberjs
ember.js
12,228
adc6d93110e46a8cb2288cc21b56e39cdd9eb719
Robert Jackson
Robert Jackson
[FEATURE ember-views-component-block-info] Enable by default. Removed CP's from `Ember.Component` because they actually do not work. `{{hasBlock}}` and `{{hasBlockParams}}` are template locals (not available in JS)
[feature ember-views-component-block-info] enable by default
60
false
false
5
false
false
false
emberjs
ember.js
12,229
a3fad34a69564d8b4735e6574e10d0853db2dbcd
Robert Jackson
Robert Jackson
Merge pull request #11141 from emberjs/angle-bracket-components Implement angle-bracket components
merge pull request from emberjs/angle-bracket-components
57
true
false
5
true
false
false
emberjs
ember.js
12,230
1e7f99149f6a3bb16fa91363baa488b2de531090
Robert Jackson
Robert Jackson
Merge pull request #11155 from rwjblue/use-correct-falsey-semantics Use correct falsey semantics with {{each}} helper.
merge pull request from rwjblue/use-correct-falsey-semantics
61
true
false
5
true
false
false
emberjs
ember.js
12,231
59011e87a9e1d1b54a4255980f95123d9b6183e4
Tom Dale
Robert Jackson
Fix failing node test
fix failing node test
21
false
false
4
true
true
true
emberjs
ember.js
12,232
7194a5e8b85e28ad388365cbf4762d211eb3535e
Tom Dale and Yehuda Katz
Robert Jackson
Implement angle-bracket components This commit adds support for angle-bracket components, including a number of changes from curlies as discussed: 1. <my-component> is inserted with a tagName of `my-component` into the DOM. We plan to support an opt-out in the future (possibly along the line of the web-component `is=` feature). 2. Attributes specified as strings (with “quotation marks”) are inserted into the DOM as attributes. For the most part, this eliminates the need for `attributeBindings`. 3. Angle bracket components do not support attrs at the top-level (the entire attrs proxy functionality is disabled). 4. A number of other legacy behaviors are removed, such as `controller=` and string rendering. 5. Attributes are read-only values by default. We plan to do a more aggressive disabling of legacy functionality; you should assume that by the time Ember 1.13 ships, there will be no deprecated functionality supported with angle bracket components. From a high-level, angle bracket components are a coarse-grained opt-in for Ember 2.0 functionality.
implement angle-bracket components
34
false
false
3
false
false
false
emberjs
ember.js
12,233
c53d94050d502447463a1d6f396e10446e6612c5
Robert Jackson
Robert Jackson
Use correct falsey semantics with {{each}} helper.
use correct falsey semantics with {{each}} helper
49
false
false
7
false
true
false
emberjs
ember.js
12,234
9936dc4e76f0be6ee25aea1af75a2a75e99e0a9d
Robert Jackson
Robert Jackson
Merge pull request #11154 from jayphelps/update-self updateSelf fn is incorrectly named bindSelf (which is different)
merge pull request from jayphelps/update-self
46
true
false
5
true
false
false
emberjs
ember.js
12,235
92e3b27b9f7b433426fbb19d962fab90c539ba13
Jay Phelps
Jay Phelps
updateSelf fn was incorrectly named bindSelf (which is different)
updateself fn was incorrectly named bindself (which is different)
65
false
false
9
false
false
false
emberjs
ember.js
12,236
bfcc15ee3ac2b2b3e4dad6aa0d7a447936302f5a
Robert Jackson
Robert Jackson
Merge pull request #11153 from emberjs/support-parent-rerenders Support parent rerenders
merge pull request from emberjs/support-parent-rerenders
57
true
false
5
true
false
false
emberjs
ember.js
12,237
467eb6d75029bfeb9264ce9db7322b5c691b3bd7
Tom Dale
Tom Dale
Support rerendering parent render nodes In idiomatic Ember, you should render “data-down”: that is, parent components should modify their children, but child components should not mutate their parents, particularly during the rendering process. By violating this rule, it is easy to trigger infinite loops or multiple rendering passes that dramatically harm performance. In certain situations, it was possible in previous versions of Ember to rely on this behavior, and several regressions were reported. This commit adds support for the old behavior and now emits a deprecation to help users migrate to a more performant architecture. In particular, we now track which render nodes have been rendered during a rendering pass. If we detect that a node has been dirtied after it has been rendered (and thus requires an additional rendering pass), we now schedule a re-render appropriately but emit a warning. Note that there *are* legitimate use cases for multi-pass rendering (e.g., measuring rendered text to layout a parent container component) and we intend to add a public API for handling this use case that can still prevent inadvertent pathological performance.
support rerendering parent render nodes
39
false
false
5
false
true
false
emberjs
ember.js
12,238
cecdcdddefddfcce3124e0b4b0f983aa1ab22e27
Edward Faulkner
Edward Faulkner
failing tests for rerender bug
failing tests for rerender bug
30
false
false
5
false
false
false
emberjs
ember.js
12,239
e443d4b1f4685d99ddbddc01468d2a5b8c359508
Yoran Brondsema
Yoran Brondsema
Remove '*.swp' from .gitignore
remove '*.swp' from .gitignore
30
false
false
4
false
true
false
emberjs
ember.js
12,240
c7eef870ba587a7faa013e59fefdd19dd3cb14d1
Yoran Brondsema
Yoran Brondsema
Remove documentation for 'controller=' for {{with}} helper
remove documentation for 'controller=' for {{with}} helper
58
false
false
7
true
true
false
emberjs
ember.js
12,241
e2af440207dcc0b534dd42121706ad4a49b24d24
Yoran Brondsema
Yoran Brondsema
Remove documentation for emptyViewClass for {{each}} helper
remove documentation for emptyviewclass for {{each}} helper
59
false
false
7
true
true
false
emberjs
ember.js
12,242
3caba7e3e103fc95cd91142d25d176188036c9ef
Yoran Brondsema
Yoran Brondsema
Remove the documentation for itemController on {{each}}.
remove the documentation for itemcontroller on {{each}}
55
false
false
7
true
true
false
emberjs
ember.js
12,243
4561c61bcf9c84ae146e509cbd9e7a5b9a5245ba
Yoran Brondsema
Yoran Brondsema
Remove trailing whitespace
remove trailing whitespace
26
false
false
3
true
true
true
emberjs
ember.js
12,244
898d24d11d20bd802809dcee7cedfcbf78655dac
Yoran Brondsema
Yoran Brondsema
Make template in documentation for {{each}} valid.
make template in documentation for {{each}} valid
49
false
false
7
true
true
true
emberjs
ember.js
12,245
9914194260bcad79640287a308a3fd488caafe64
Yoran Brondsema
Yoran Brondsema
Remove documentation for itemViewClass for the {{each}} helper
remove documentation for itemviewclass for the {{each}} helper
62
false
false
8
true
true
false
emberjs
ember.js
12,246
c8f6731de12314b87a71054fd3ae87413c15c3c8
Yoran Brondsema
Yoran Brondsema
Add Vim swp files to .gitignore
add vim swp files to .gitignore
31
false
false
6
true
true
true
emberjs
ember.js
12,247
b288a97672a0e9141e9ae6e9bec30ae70a6007ca
Yoran Brondsema
Yoran Brondsema
Merge branch 'master' into yb-fix-documentation-for-each-and-with-helpers
merge branch 'master' into yb-fix-documentation-for-each-and-with-helpers
73
true
false
5
false
true
false
emberjs
ember.js
12,248
a0ae04f70c9b543bebf3e02df29b530485cc62b6
Robert Jackson
Robert Jackson
Merge pull request #11148 from rwjblue/update-htmlbars Update to HTMLBars 0.13.18.
merge pull request from rwjblue/update-htmlbars
48
true
false
5
true
false
false
emberjs
ember.js
12,249
a20668d29a8760df65490630ae3d0593138f7450
Robert Jackson
Robert Jackson
Merge pull request #11144 from chancancode/glimmer-normalize-arguments-in-new-lifecycle-hooks [Glimmer] Consistently pass `{ oldAttrs, newAttrs }` to `didReceiveAttrs`
merge pull request from chancancode/glimmer-normalize-arguments-in-new-lifecycle-hooks
87
true
false
5
true
false
false
emberjs
ember.js
12,250
76f50357c2a8130564db3f48d21eefc60547fa56
Robert Jackson
Robert Jackson
Update to HTMLBars 0.13.18. Fixes issues with components and views using `tagName` `"svg"`.
update to htmlbars 0.13.18
26
false
false
4
false
false
false
emberjs
ember.js
12,251
826d33d2b6eaf178ac65a22d455b41e4a4c5b205
Yoran Brondsema
Yoran Brondsema
Fix documentation for {{with}} helper.
fix documentation for {{with}} helper
37
false
false
5
true
true
true
emberjs
ember.js
12,252
82fd051b09b2814fa098f21a493eec73bd8e6074
Yoran Brondsema
Yoran Brondsema
Fix documentation for {{each}} helper.
fix documentation for {{each}} helper
37
false
false
5
true
true
true
emberjs
ember.js
12,253
f338f02200cec850fa14da218275771b570392c8
Godfrey Chan
Godfrey Chan
Consistently pass `{ oldAttrs, newAttrs }` to `didReceiveAttrs` Previously, the hook get passed `options={ attrs }` during initial render but `options={ oldAttrs, newAttrs }` during updates.
consistently pass `{ oldattrs, newattrs }` to `didreceiveattrs`
63
false
false
8
false
false
false
emberjs
ember.js
12,254
196b290a5a2955f7f1058c12c70ea42154667091
Robert Jackson
Robert Jackson
Add a better deprecation for `{{bind-attr}}`. Example deprecation: ``` The `bind-attr` helper ('my-app-name/templates/index' @ L1:C7) is deprecated in favor of HTMLBars-style bound attributes"); ```
add a better deprecation for `{{bind-attr}}`
44
false
false
6
true
true
true
emberjs
ember.js
12,255
2b76aa07476f15804b381e052f19999c5cf85fd0
Peter Wagenet
Peter Wagenet
Merge pull request #11137 from wagenet/fix-link-render-node-arrays Recognize array-likes in link-render-node
merge pull request from wagenet/fix-link-render-node-arrays
60
true
false
5
true
false
false
emberjs
ember.js
12,256
b9e1c56456273351d01d9e79b67fb8ccf629d31b
Peter Wagenet
Peter Wagenet
Recognize array-likes in link-render-node Affects if/unless and possibly other places.
recognize array-likes in link-render-node
41
false
false
4
true
false
true
emberjs
ember.js
12,257
ecadea4a4a6ba8d9338fbd1686a5021420cf6e0b
Robert Jackson
Robert Jackson
Merge pull request #11134 from rwjblue/view-action-target `targetObject` for components invoked with {{view}} is correct.
merge pull request from rwjblue/view-action-target
51
true
false
5
true
false
false
emberjs
ember.js
12,258
f3c642dd48a23b92ad9e30addd8134001f6099d9
Robert Jackson
Robert Jackson
Ensure that the `targetObject` for components invoked with {{view}} is correct.
ensure that the `targetobject` for components invoked with {{view}} is correct
78
false
false
11
false
false
false
emberjs
ember.js
12,259
167fe58978a2bd2fed60307434939c908aa24c23
Robert Jackson
Robert Jackson
Merge pull request #11132 from rwjblue/top-level-outlet-gets-controller Ensure top-level outlet has access to `{{controller}}`.
merge pull request from rwjblue/top-level-outlet-gets-controller
65
true
false
5
true
false
false
emberjs
ember.js
12,260
2a66713427cebcf5c7ae61ef90c733e68a28bd60
Edward Faulkner
Robert Jackson
{{view}} helper gives incorrect action target (cherry picked from commit dfaeae56efc8f9a3e70fc60136b336e94428d241)
{{view}} helper gives incorrect action target
45
false
false
6
false
false
false
emberjs
ember.js
12,261
749585a33fb5c0c13dc828e64f2d35e450e39235
Robert Jackson
Robert Jackson
Ensure top-level outlet has access to `{{controller}}`. Fix by @teddyzeenny, tests by @rwjblue.
ensure top-level outlet has access to `{{controller}}`
54
false
false
7
false
false
false
emberjs
ember.js
12,262
5bff8674524100341983120bc34ef718cbe8e91a
Robert Jackson
Robert Jackson
Merge pull request #11131 from rwjblue/can-call-appendTo-twice Ensure that `View.prototype.appendTo` allows additional views to be appended.
merge pull request from rwjblue/can-call-appendto-twice
56
true
false
5
true
false
false
emberjs
ember.js
12,263
44ab9128bcba639c3635e3a3de4f135fe8d89714
Robert Jackson
Robert Jackson
Merge pull request #11130 from rwjblue/components-invoke-render-method Ensure components invoke `render` method.
merge pull request from rwjblue/components-invoke-render-method
64
true
false
5
true
false
false
emberjs
ember.js
12,264
d08535e510019a48d38ba75f63ce742648605244
Robert Jackson
Robert Jackson
Ensure that `View.prototype.appendTo` allows additional views to be appended. Prior to this, only a single view could be appended to the DOM during a single run-loop (due to `run.scheduleOnce`. It should be possible to call `appendTo` more than once per run-loop.
ensure that `view.prototype.appendto` allows additional views to be appended
76
false
false
9
false
true
false
emberjs
ember.js
12,265
8039daec947e9edd598abc0deda90264efb87fa6
Robert Jackson
Robert Jackson
Merge pull request #11129 from rwjblue/legacy-each-view-deprecation Deprecate {{each}} hash arguments that trigger usage of LegacyEachView.
merge pull request from rwjblue/legacy-each-view-deprecation
61
true
false
5
true
false
false
emberjs
ember.js
12,266
072434e787f1c45ee23add2960a1060e444d2914
Robert Jackson
Robert Jackson
Ensure components invoke `render` method.
ensure components invoke `render` method
40
false
false
5
false
false
false
emberjs
ember.js
12,267
f8c468978f263a2a3cd37110f6b9aeda51b66fb3
Robert Jackson
Robert Jackson
Only run Travis against master, beta, and stable branches. This prevents double Travis runs when someone pushes to a branch on `emberjs` org.
only run travis against master, beta, and stable branches
57
false
false
9
false
false
false
emberjs
ember.js
12,268
319fad27bb9873546cea539faddb23d7ce75386c
Robert Jackson
Robert Jackson
Merge pull request #11127 from emberjs/refine-lifecycle-hooks Refine component lifecycle hooks
merge pull request from emberjs/refine-lifecycle-hooks
55
true
false
5
true
false
false
emberjs
ember.js
12,269
49ca1068ecf2a5028cd0237d75477867f17e675d
Robert Jackson
Robert Jackson
Merge pull request #11120 from bantic/fix-with-inverse-template Display the inverse template of a `{{#with}}` block
merge pull request from bantic/fix-with-inverse-template
57
true
false
5
true
false
false
emberjs
ember.js
12,270
501373e7d9952ea95c1e91102272d212523af8ca
Robert Jackson
Robert Jackson
Deprecate {{each}} hash arguments that trigger usage of LegacyEachView. This includes: * `itemController` * `tagName` * `itemView` * `itemViewClass`
deprecate {{each}} hash arguments that trigger usage of legacyeachview
70
false
false
9
false
true
false
emberjs
ember.js
12,271
84c28755c457cc44d261c5bcbdb126ecc214184e
Tom Dale and Yehuda Katz
Tilde Engineering
Refine component lifecycle hooks This commit refines the lifecycle hooks to more completely support the use-cases. On first render (in order): * `didInitAttrs` runs after `attrs` is guaranteed to be up to date. This is more reliable than trying to ensure that `attrs` are always available on `init`. * `didReceiveAttrs` runs after `didInitAttrs` (it also runs on subsequent re-renders, which is useful for logic that is the same on all renders). * `willRender` runs before the template is rendered. It runs when the template is updated for any reason (both initial and re-render, and regardless of whether the change was caused by an attrs change or re-render). * `didInsertElement` runs after the template has rendered and the element is in the DOM. * `didRender` runs after `didInsertElement` (it also runs on subsequent re-renders). On re-render (in order): * `didUpdateAttrs` runs when the attributes of a component have changed (but not when the component is re-rendered, via `component.rerender`, `component.set`, or changes in models or services used by the template). * `didReceiveAttrs`, same as above. * `willUpdate` runs when the component is re-rendering for any reason, including `component.rerender()`, `component.set()` or changes in models or services used by the template. * `willRender`, same as above * `didUpdate` runs after the template has re-rendered and the DOM is now up to date. * `didRender`, same as above. Note that a component is re-rendered whenever: 1. any of its attributes change 2. `component.set()` is called 3. `component.rerender()` is called 4. a property on a model or service used by the template has changed (including through computed properties). Because of the Glimmer engine, these re-renders are fast, and avoid unnecessary work.
refine component lifecycle hooks
32
false
false
4
false
true
false
emberjs
ember.js
12,272
eade3a516b37742c39229ff91536d4a430cd58ad
Cory Forsyth
Cory Forsyth
Display the inverse template of a `{{#with}}` block Fixes #11118
display the inverse template of a `{{#with}}` block
51
false
false
8
true
true
false
emberjs
ember.js
12,273
6af6fa4c6dd754fc722441602c1bc65a7e9359e0
Robert Jackson
Robert Jackson
Merge pull request #11116 from rwjblue/enable-improved-actions-by-default [FEATURE ember-routing-htmlbars-improved-actions] Enable by default.
merge pull request from rwjblue/enable-improved-actions-by-default
67
true
false
5
true
false
false
emberjs
ember.js
12,274
92bf6ef6f3f6c9c9255efb4779dd28a744215ee9
Robert Jackson
Robert Jackson
[FEATURE ember-routing-htmlbars-improved-actions] Enable by default.
[feature ember-routing-htmlbars-improved-actions] enable by default
67
false
false
5
false
false
false
emberjs
ember.js
12,275
44fd58d0cfce82826976f1db0ab42f77e727a995
Robert Jackson
Robert Jackson
Merge pull request #11084 from ef4/yield-to-inverse Enable {{yield to="inverse"}} in components
merge pull request from ef4/yield-to-inverse
45
true
false
5
true
false
false
emberjs
ember.js
12,276
fdb5d74f8c15de72705b7c52b33a41e4d05520bd
Matthew Beale
Matthew Beale
Merge pull request #11110 from rwjblue/avoid-mut-wrapping-closure-actions Avoid wrapping (action 'save') as a mutable cell.
merge pull request from rwjblue/avoid-mut-wrapping-closure-actions
67
true
false
5
true
false
false
emberjs
ember.js
12,277
2af0f5cf7bde7b9fbb37a2d4f034fe76cbbdee6e
Robert Jackson
Robert Jackson
Merge pull request #11106 from rwjblue/view-controller Ensure {{view}} instantiated views are provided with a `controller`.
merge pull request from rwjblue/view-controller
48
true
false
5
true
false
false
emberjs
ember.js
12,278
c564be6fa061bac0b00c3e084849087b108cb06d
Edward Faulkner
Edward Faulkner
Support for {{yield to="inverse"}}
support for {{yield to="inverse"}}
34
false
false
4
false
false
false
emberjs
ember.js
12,279
2b7c8dd1b99ff1f57d6dfd89c338cc8c680d8976
Robert Jackson
Robert Jackson
Ensure {{view}} instantiated views are provided with a `controller`.
ensure {{view}} instantiated views are provided with a `controller`
67
false
false
9
false
false
false
emberjs
ember.js
12,280
6f83cfbd079697f82649087842143ca2fe985958
Robert Jackson
Robert Jackson
Avoid wrapping (action 'save') as a mutable cell. Prior to this when passing actions down more than one layer, the path expression at the middle layer would be re-written as a mutable cell. This means that you can no longer call `this.attrs.someAction()` and would instead have to call `this.attrs.someAction.value()`. This change avoids returning the wrapped object when the upstream streams value is the return value from `(action` invocation.
avoid wrapping (action 'save') as a mutable cell
48
false
false
8
false
true
false
emberjs
ember.js
12,281
fd3d54d02f532f00776a957ef663bc8bc4f93511
Robert Jackson
Robert Jackson
Merge pull request #11105 from rwjblue/ensure-meta-is-tacked-onto-manual-element Ensure that `meta` is attached to manualElement.
merge pull request from rwjblue/ensure-meta-is-tacked-onto-manual-element
74
true
false
5
true
false
false
emberjs
ember.js
12,282
9ba2dbc2802ba64ba984487b665c87efd06ce294
Robert Jackson
Robert Jackson
Merge pull request #11104 from rwjblue/remove-non-htmlbars-path Remove non-HTMLBars template path.
merge pull request from rwjblue/remove-non-htmlbars-path
57
true
false
5
true
false
false
emberjs
ember.js
12,283
84db9ea22c63649fc349d5ebc664995f6e3fcf27
Robert Jackson
Robert Jackson
Ensure that `meta` is attached to manualElement. This should allow the ember-inspector to access the moduleName's for each component being rendered.
ensure that `meta` is attached to manualelement
47
false
false
7
false
false
false
emberjs
ember.js
12,284
ab9276bc5601833ecd1661e4f5daa85dede09497
Matthew Beale
Matthew Beale
Merge pull request #11103 from mixonic/improved-actions sendAction is compatible with improved actions
merge pull request from mixonic/improved-actions
49
true
false
5
true
false
false
emberjs
ember.js
12,285
ed06f9ecc7af2e2191c319162630303540593c52
Robert Jackson
Robert Jackson
Remove non-HTMLBars template path. Manually writing template functions is largely unsupported already. This change removes a guard/check for `isHTMLBars` (we intend to stop stamping all templates with this flag in the future).
remove non-htmlbars template path
33
false
false
4
true
true
true
emberjs
ember.js
12,286
7301768fbb14a4ed8e4202e3c42523f5c95e1c84
Matthew Beale
Matthew Beale
sendAction is compatible with improved actions
sendaction is compatible with improved actions
46
false
false
6
false
false
false
emberjs
ember.js
12,287
737945991229ea3edbbc63b9fe9dbfc0c5feec55
Robert Jackson
Robert Jackson
Merge pull request #11101 from teddyzeenny/rename-component-node More renaming of Component Node to View Node Manager
merge pull request from teddyzeenny/rename-component-node
58
true
false
5
true
false
false
emberjs
ember.js
12,288
d0da3bed7037a99b66e316e50270ab81790b1b96
Teddy Zeenny
Teddy Zeenny
More renaming of Component Node to View Node Manager
more renaming of component node to view node manager
52
false
false
9
false
false
false
emberjs
ember.js
12,289
6b4f704d19a54b62d89e95e386dfa58a84110ef7
Robert Jackson
Robert Jackson
Merge pull request #11099 from teddyzeenny/view-instrumentation Move instrumentation to the node managers
merge pull request from teddyzeenny/view-instrumentation
57
true
false
5
true
false
false
emberjs
ember.js
12,290
5f1cba209b0025d976c3bd5053ea1eea052f5d73
Teddy Zeenny
Teddy Zeenny
Move instrumentation to the node managers Components that don't have a view instance don't go through the renderer. This insures instrumentation is invoked anyway. Also moved system/component-node to node-managers/view-node-manager
move instrumentation to the node managers
41
false
false
6
true
true
true
emberjs
ember.js
12,291
367e5f5ce376cfa6ba93d0d2b91bb4ed48063f52
Robert Jackson
Robert Jackson
Merge pull request #11087 from ef4/mutable-boom Fix automatic mut for non-streams
merge pull request from ef4/mutable-boom
41
true
false
5
true
false
false
emberjs
ember.js
12,292
521673ae6f13c807a2c3779de3b580765ce9146d
Robert Jackson
Robert Jackson
Merge pull request #11097 from rwjblue/add-module-name-for-boostrapped-templates Add `moduleName` to <script type="text/x-handlebars"> templates.
merge pull request from rwjblue/add-module-name-for-boostrapped-templates
74
true
false
5
true
false
false
emberjs
ember.js
12,293
e05feec0d52a4f66308b6547434897b2c01fca60
Edward Faulkner
Edward Faulkner
fix automatic mut for non-streams
fix automatic mut for non-streams
33
false
false
5
true
true
true
emberjs
ember.js
12,294
a99c6bbd81061ce603bc70143a4f84747a936b9e
Robert Jackson
Robert Jackson
Add `moduleName` to <script type="text/x-handlebars"> templates. Hopefully, in the future the Ember Inspector will be able to read the `moduleName` metadata off of a view/component template to display the "real" module name in the view hierarchy display.
add `modulename` to <script type="text/x-handlebars"> templates
63
false
false
6
false
true
false
emberjs
ember.js
12,295
3edba576dcac6a9dc41e0759a2840fe9cfc5d0f3
Robert Jackson
Robert Jackson
Merge pull request #11095 from rwjblue/buildMeta-hook Use `buildMeta` compile option to embed metadata into templates.
merge pull request from rwjblue/buildmeta-hook
47
true
false
5
true
false
false
emberjs
ember.js
12,296
dd4e62085106d54d902a1524fd5bc0fa1a37e15b
Robert Jackson
Robert Jackson
Merge pull request #11083 from tpitale/selection-equality Make equality match the comments
merge pull request from tpitale/selection-equality
51
true
false
5
true
false
false
emberjs
ember.js
12,297
466706d53770933562bf6317b918343d7f155be3
Robert Jackson
Robert Jackson
Use `buildMeta` compile option to embed metadata into templates.
use `buildmeta` compile option to embed metadata into templates
63
false
false
9
true
true
false
emberjs
ember.js
12,298
7803c521af427bb12220652acc5a3d88531ba042
Tony Pitale
Tony Pitale
jshint should ignore this equality
jshint should ignore this equality
34
false
false
5
false
false
false
emberjs
ember.js
12,299