sha stringlengths 40 40 | author stringlengths 1 63 | committer stringlengths 1 41 | message stringlengths 1 65.5k | subject stringlengths 1 5.64k | subject_length float64 1 5.64k | is_chore bool 2 classes | is_bot bool 2 classes | subject_word_count float64 1 806 | verb_object_spacy bool 2 classes | verb_object_stanza bool 2 classes | fits_requirements bool 2 classes | owner stringlengths 2 15 | repo stringlengths 2 21 | __index_level_0__ int64 0 85k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
cb5b850edca3b0fd1b38e7ab3928f0f8099103ed | Robert Jackson | Robert Jackson | Merge pull request #11305 from jbrown/patch-7
Whitespace cleanup | merge pull request from jbrown/patch-7 | 39 | true | false | 5 | true | false | false | emberjs | ember.js | 12,100 |
bc4390859e605906ee0d3fff308dcf508113e560 | Justin Brown | Justin Brown | Whitespace cleanup | whitespace cleanup | 18 | false | false | 2 | false | false | false | emberjs | ember.js | 12,101 |
f4af933f53a29abc328c3872fe95488412397cce | Robert Jackson | Robert Jackson | Merge pull request #11303 from rwjblue/ensure-root-url-is-provided-to-concrete-implementation
[BUGFIX release] Ensure rootURL is preserved in AutoLocation. | merge pull request from rwjblue/ensure-root-url-is-provided-to-concrete-implementation | 87 | true | false | 5 | true | false | false | emberjs | ember.js | 12,102 |
a1fa101ddcb5dca562613bacf49e5df93df7acb3 | Robert Jackson | Robert Jackson | [BUGFIX release] Ensure rootURL is preserved in AutoLocation.
When creating the concrete implementation we must also populate its `rootURL`. | [bugfix release] ensure rooturl is preserved in autolocation | 60 | false | false | 8 | false | false | false | emberjs | ember.js | 12,103 |
3f7cf55e84e101f0ce1e284b089824dfa73b1809 | Martin Muñoz | Martin Muñoz | Merge pull request #11298 from rwjblue/do-not-warn-on-internal-styles
[BUGFIX beta] Do not trigger style warning for `isVisible`. | merge pull request from rwjblue/do-not-warn-on-internal-styles | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 12,104 |
96ae8bbcc85b3df7c05e892683faeab3ea951846 | Robert Jackson | Robert Jackson | Merge pull request #11299 from hibariya/fix-unless-helper
[BUGFIX beta] Fix for `{{#unless arrayLikeObject}}` | merge pull request from hibariya/fix-unless-helper | 51 | true | false | 5 | true | false | false | emberjs | ember.js | 12,105 |
391c565b7f909859e7d431167e5dd1cbd85df550 | Robert Jackson | Robert Jackson | Merge pull request #11300 from mitchlloyd/back-off-assertions
Change view and component resolver assertions to deprecations | merge pull request from mitchlloyd/back-off-assertions | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 12,106 |
0d513645ba6eba7a783de3668b531eebc78dc141 | Mitch Lloyd | Mitch Lloyd | Change view & component assertions to deprecations | change view & component assertions to deprecations | 50 | false | false | 7 | false | true | false | emberjs | ember.js | 12,107 |
2dda9251554e635f8285078af20b016c97318864 | Hika Hibariya | Hika Hibariya | [BUGFIX beta] Fix for `{{#unless arrayLikeObject}}` | [bugfix beta] fix for `{{#unless arraylikeobject}}` | 51 | false | false | 6 | false | false | false | emberjs | ember.js | 12,108 |
f782a716de621c4e6125cae4a9f16856545a79f1 | Robert Jackson | Robert Jackson | [BUGFIX beta] Do not trigger style warning for `isVisible`. | [bugfix beta] do not trigger style warning for `isvisible` | 58 | false | false | 9 | false | false | false | emberjs | ember.js | 12,109 |
4d97d612ebe0841c0d40e57b276c9bc2bf896768 | Robert Jackson | Robert Jackson | Merge pull request #11290 from rwjblue/ensure-multiple-apps-work
[BUGFIX release] Ensure that multiple app event dispatching works properly. | merge pull request from rwjblue/ensure-multiple-apps-work | 58 | true | false | 5 | true | false | false | emberjs | ember.js | 12,110 |
d6ae292140b4ad997faae26595d25e61eedd90fa | Robert Jackson | Robert Jackson | [BUGFIX release] Ensure that multiple app event dispatching works properly. | [bugfix release] ensure that multiple app event dispatching works properly | 74 | false | false | 10 | false | false | false | emberjs | ember.js | 12,111 |
a8ba1eb41b0ae50aaeb5cc6bb5c7e061d88a2741 | Robert Jackson | Robert Jackson | Merge pull request #11289 from chancancode/run-instance-initializers-before-ready
[BUGFIX stable] Instance initializers should run before `App.ready` | merge pull request from chancancode/run-instance-initializers-before-ready | 75 | true | false | 5 | true | false | false | emberjs | ember.js | 12,112 |
a0acc6ef4932c385b4f37cab12e2ea72abfd96c9 | Robert Jackson | Robert Jackson | Merge pull request #11286 from rwjblue/enumerable_utils-deprecation
[BUGFIX beta] Deprecate Ember.EnumerableUtils. | merge pull request from rwjblue/enumerable_utils-deprecation | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 12,113 |
3521d8e86933f6e703bfff324086e9c770a91011 | Robert Jackson | Robert Jackson | [BUGFIX beta] Deprecate Ember.EnumerableUtils. | [bugfix beta] deprecate ember.enumerableutils | 45 | false | false | 4 | false | false | false | emberjs | ember.js | 12,114 |
0dc02ac285977fd14e776d362c6fafeeae1b4cfa | Godfrey Chan | Godfrey Chan | Instance initializers should run before `App.ready`
The original complaint is that routing begins before instance initializers are
run, which means that some routes instances are created *before* the instance
initializers are run, which means that you cannot reliably setup injections for
routes in instance initializers, which are important for e.g. `store:main`.
Since `App.ready` is guaranteed to run before routing begins, this effectively
guarantees that instance initializers are run before routing begins.
Fixes #11172 | instance initializers should run before `app.ready` | 51 | false | false | 6 | false | false | false | emberjs | ember.js | 12,115 |
ea8e0752c5351e9c39d2394abc2050b5050a33c9 | Justin Brown | Justin Brown | [DOC] Favor not using prototype extensions. | [doc] favor not using prototype extensions | 42 | false | false | 6 | false | false | false | emberjs | ember.js | 12,116 |
0738330bc1575b2515bdee1c9721e49b93c57cf5 | Trek Glowacki | Trek Glowacki | Move query parameter cofiguration into the Route | move query parameter cofiguration into the route | 48 | false | false | 7 | true | false | true | emberjs | ember.js | 12,117 |
d42eecab750aa9c77eea55b8ed14e151258eb065 | Robert Jackson | Robert Jackson | Merge pull request #11281 from rwjblue/ensure-deprecation-prints-when-emptu
[BUGFIX beta] Ensure context switching {{each}} deprecation shows when no items present. | merge pull request from rwjblue/ensure-deprecation-prints-when-emptu | 69 | true | false | 5 | true | false | false | emberjs | ember.js | 12,118 |
42cb675490c9e1571b6e76853af6b4f17823294f | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure context switching {{each}} deprecation shows when no items present. | [bugfix beta] ensure context switching {{each}} deprecation shows when no items present | 87 | false | false | 12 | false | false | false | emberjs | ember.js | 12,119 |
444d3e193e74aa65c7579d08664c95656a5d59be | Robert Jackson | Robert Jackson | Merge pull request #11280 from rwjblue/reenable-previously-skipped-test
Reenable previously skipped test for `fillIn` helper. | merge pull request from rwjblue/reenable-previously-skipped-test | 65 | true | false | 5 | true | true | false | emberjs | ember.js | 12,120 |
cc832513c40994cd9d2651bdf1c99f82e60b4e65 | Robert Jackson | Robert Jackson | Merge pull request #11279 from rwjblue/deprecate-each-in
[BUGFIX beta] Deprecate `{{each foo in bar}}`. | merge pull request from rwjblue/deprecate-each-in | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 12,121 |
8a0ff253715d2b19c8dc2e54f459235d906ed906 | Robert Jackson | Robert Jackson | Reenable previously skipped test for `fillIn` helper. | reenable previously skipped test for `fillin` helper | 52 | false | false | 7 | false | false | false | emberjs | ember.js | 12,122 |
6d6576a6563477dce94e957a417482c3039ee850 | Robert Jackson | Robert Jackson | [BUGFIX beta] Deprecate `{{each foo in bar}}`. | [bugfix beta] deprecate `{{each foo in bar}}` | 45 | false | false | 7 | false | false | false | emberjs | ember.js | 12,123 |
10816074ce585bea21908f742a98db4037c7d322 | Robert Jackson | Robert Jackson | Merge pull request #11271 from rwjblue/disable-classNames-classNameBindings-deprecation
[BUGFIX beta] Remove deprecation for `classBinding` and `classNameBindings`. | merge pull request from rwjblue/disable-classnames-classnamebindings-deprecation | 81 | true | false | 5 | true | false | false | emberjs | ember.js | 12,124 |
915a329ddd2a643ada756912569754b1471333d1 | Robert Jackson | Robert Jackson | [BUGFIX beta] Remove deprecation for `classBinding` and `classNameBindings`. | [bugfix beta] remove deprecation for `classbinding` and `classnamebindings` | 75 | false | false | 8 | false | false | false | emberjs | ember.js | 12,125 |
2e0936f930dd0353130c17428977d7cce02b4ed7 | Robert Jackson | Robert Jackson | Merge pull request #11229 from chancancode/rm-view-lifecycle-hooks
[BUGFIX beta] Don't dispatch new lifecycle hooks to views | merge pull request from chancancode/rm-view-lifecycle-hooks | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 12,126 |
5effe0556f0ad8b732867349052dacdf839a7c73 | Robert Jackson | Robert Jackson | Merge pull request #11274 from rwjblue/unify-display-location
[BUGFIX beta] Unify AST plugin location display. | merge pull request from rwjblue/unify-display-location | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 12,127 |
9407d4c018d94816998d8846da37e086a1e2976a | Robert Jackson | Robert Jackson | Merge pull request #11273 from mitchlloyd/deprecate-service-validation
Change assertion to deprecation | merge pull request from mitchlloyd/deprecate-service-validation | 64 | true | false | 5 | true | false | false | emberjs | ember.js | 12,128 |
46f14f88a04624984dd5d5e8bec7b64cc7403fda | Robert Jackson | Robert Jackson | [BUGFIX beta] Unify AST plugin location display.
Fixes a number of AST walker deprecations that were previously always displaying `inline` instead
of the module name. | [bugfix beta] unify ast plugin location display | 47 | false | false | 7 | false | false | false | emberjs | ember.js | 12,129 |
28504216e0cd9b8de8ee4bbb67da6f749addec44 | Mitch Lloyd | Mitch Lloyd | Change assertion to deprecation | change assertion to deprecation | 31 | false | false | 4 | true | true | true | emberjs | ember.js | 12,130 |
850aba37dbac3af52f251a26c3d8fee7e42a86bf | Stanley Stuart | Stanley Stuart | Merge pull request #11272 from fivetanley/bower-publishing
prevent accidental publishing to canary/others by contributors | merge pull request from fivetanley/bower-publishing | 52 | true | false | 5 | true | false | false | emberjs | ember.js | 12,131 |
f1807598c725f6d63371e45664d6504d9c94b2ff | Stanley Stuart | Stanley Stuart | prevent accidental publishing to canary/others by contributors
From the Travis CI docs:
http://docs.travis-ci.com/user/ci-environment/
For builds not triggered by a pull request this is the name of the
branch currently being built; whereas for builds triggered by a pull
request this is the name of the branch targeted by the pull request (in
many cases this will be master, which will publish to "canary").
This was building for branches not intended to be published because they
were opened as a pull request against master (which set `$TAVIS_BRANCH`
to `master` when a pull request was opened). As Ember core contributors
frequently work off the main repository this is an unwanted side effect. | prevent accidental publishing to canary/others by contributors | 62 | false | false | 7 | true | true | false | emberjs | ember.js | 12,132 |
1d91c95f232a4fab9ce045b8a715ad59eca4b618 | Robert Jackson | Robert Jackson | Merge pull request #11270 from rwjblue/ensure-view-registry-is-passed-down
[BUGFIX beta] Ensure view registry is provided to components. | merge pull request from rwjblue/ensure-view-registry-is-passed-down | 68 | true | false | 5 | true | false | false | emberjs | ember.js | 12,133 |
41b4968063425944e9b529ce6ea5c78ba09639e9 | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure view registry is provided to components. | [bugfix beta] ensure view registry is provided to components | 60 | false | false | 9 | false | false | false | emberjs | ember.js | 12,134 |
4218f01c4d7d140921110cbfd7e05f52bcdad3c4 | Robert Jackson | Robert Jackson | Merge pull request #11258 from truenorth/semver
[BUGFIX] Add test for Ember.VERSION SemVer validity | merge pull request from truenorth/semver | 41 | true | false | 5 | true | false | false | emberjs | ember.js | 12,135 |
6c4e5aee469f5217a44650087f6f3793c410d2e2 | Robert Jackson | Robert Jackson | Merge pull request #11267 from rwjblue/disable-angle-bracket-invocation-feature
[FEATURE ember-htmlbars-component-generation] Disabled by default. | merge pull request from rwjblue/disable-angle-bracket-invocation-feature | 73 | true | false | 5 | true | false | false | emberjs | ember.js | 12,136 |
205803437c961f73318229ab9389de50e2c6cc1d | Robert Jackson | Robert Jackson | Merge pull request #11266 from rwjblue/fix-parentView
[BUGFIX beta] Ensure `parentView` includes yielding component. | merge pull request from rwjblue/fix-parentview | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 12,137 |
d905afaf2ea47ebab3f9f8ed90bd5b482b30070e | Robert Jackson | Robert Jackson | Merge pull request #11261 from mitchlloyd/resolver-assertions-no-controller
Validate Ember object types in resolver | merge pull request from mitchlloyd/resolver-assertions-no-controller | 69 | true | false | 5 | true | false | false | emberjs | ember.js | 12,138 |
aa4e4d20a4ce1cd0f58560acffcb2f9f40e6ed47 | Mitch Lloyd | Mitch Lloyd | Consolidate duplicated method | consolidate duplicated method | 29 | false | false | 3 | true | true | true | emberjs | ember.js | 12,139 |
2bd8a29ffde19a76d230f4f70e5c4383ef950c69 | Robert Jackson | Robert Jackson | [FEATURE ember-htmlbars-component-generation] Disabled by default.
A number of issues have been discovered for this feature that make it clear
that further consideration is needed before enabling by default.
* Cannot use angle-bracket invocation in contexts that require specific tags.
For example: you cannot use `<table><custom-row model=stuff></custom-row></table>` because
in a `<table>` context like this, you can only use `<tr>`
* Cannot use angle-bracket invocation to use components in a subdirectory.
* Other things.... | [feature ember-htmlbars-component-generation] disabled by default | 65 | false | false | 5 | false | false | false | emberjs | ember.js | 12,140 |
0bf962d06290ad0bd75bd05ea255652ba2d6d396 | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure `parentView` includes yielding component. | [bugfix beta] ensure `parentview` includes yielding component | 61 | false | false | 7 | false | false | false | emberjs | ember.js | 12,141 |
a876722a99312449cdaf8df51cc80ba9674332fd | Mitch Lloyd | Mitch Lloyd | Validate Ember object types in resolver
This commit adds assertions to ensure that some key object types
are validated when they are resolved:
* Routes
* Components
* Views
* Services
I did not add a validation for controller classes because the
implementation for detection would need to be a little different and
some of Ember's tests play fast (and loose) with with the types of
things they try to pass off as controllers. For now I don't think this
additional validation is worth adding given imminent demise of
Controllers. | validate ember object types in resolver | 39 | false | false | 6 | false | true | false | emberjs | ember.js | 12,142 |
d9889a265b995d8b4e838e081c89c3ec13cbbbf1 | Robert Jackson | Robert Jackson | Merge pull request #11262 from rwjblue/enable-fastboot-tests
Fix basic Fastboot usage. | merge pull request from rwjblue/enable-fastboot-tests | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 12,143 |
2a726161dd80b3cfd5172922106037bbcc3e4d68 | Robert Jackson | Robert Jackson | Fix basic Fastboot usage. | fix basic fastboot usage | 24 | false | false | 4 | true | true | true | emberjs | ember.js | 12,144 |
1596a2b1a2aa245212829141aa556e06e53a886b | Mike North | Mike North | Ember.VERSION alignment w/ SemVer 2.0 | ember.version alignment w/ semver 2.0 | 37 | false | false | 5 | false | false | false | emberjs | ember.js | 12,145 |
84689f4603866351351ab749cd4ab518d550ec4d | Robert Jackson | Robert Jackson | Merge pull request #11260 from csantero/array-arg
[BUGFIX beta] fix passing array argument to action helper | merge pull request from csantero/array-arg | 43 | true | false | 5 | true | false | false | emberjs | ember.js | 12,146 |
cdc44b767c41e933801f58cdcb967ee052b4b0b9 | Christopher Santero | Christopher Santero | [BUGFIX beta] fix passing array argument to action helper | [bugfix beta] fix passing array argument to action helper | 57 | false | false | 9 | false | false | false | emberjs | ember.js | 12,147 |
37f43250df708523e654863b83716515221186a0 | Robert Jackson | Robert Jackson | Merge pull request #11257 from rwjblue/fix-input-on
[BUGFIX beta] Fix `{{input on="foo" action="bar"}}`. | merge pull request from rwjblue/fix-input-on | 45 | true | false | 5 | true | false | false | emberjs | ember.js | 12,148 |
6b909b5fcb7f0fe929b6970e96a6de712890b691 | Robert Jackson | Robert Jackson | [BUGFIX beta] Fix `{{input on="foo" action="bar"}}`. | [bugfix beta] fix `{{input on="foo" action="bar"}}` | 51 | false | false | 6 | false | false | false | emberjs | ember.js | 12,149 |
10f772a2316d756c263b1fd1d471ad69ac9faba4 | Robert Jackson | Robert Jackson | Merge pull request #11253 from teddyzeenny/reset-bug
[BUGFIX release] always pass instance to instance initializers | merge pull request from teddyzeenny/reset-bug | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 12,150 |
8415914815d9815103f698f63e42a37add2d00bb | Teddy Zeenny | Teddy Zeenny | [BUGFIX release] always pass instance to instance initializers | [bugfix release] always pass instance to instance initializers | 62 | false | false | 8 | false | false | false | emberjs | ember.js | 12,151 |
8a829189cc52b79c37b635bcdef1a51c569944ab | Kris Selden | Kris Selden | Merge pull request #10701 from mitchlloyd/refactor-chains-lazy-get
Refactor `lazyGet` | merge pull request from mitchlloyd/refactor-chains-lazy-get | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 12,152 |
1595290495d56cfb058efd2a405616c8dc88a26f | Robert Jackson | Robert Jackson | Merge pull request #10944 from bmac/fix-ember-routing-named-substates
Fix ember-routing-named-substates | merge pull request from bmac/fix-ember-routing-named-substates | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 12,153 |
93da9c57996e9f250ade60897050f8eb1c4ac699 | Matthew Beale | Matthew Beale | Merge pull request #11191 from okuryu/ember-cli-yuidoc
Bump ember-cli-yuidoc version to ^0.7.0 | merge pull request from okuryu/ember-cli-yuidoc | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 12,154 |
5c0fb159692d134c42c281c2c13329b51eaa51ce | Matthew Beale | Matthew Beale | Merge pull request #11246 from eliotsykes/refresh-history-detect-from-modernizr
[BUGFIX beta] Update supportsHistory to use Modernizr latest | merge pull request from eliotsykes/refresh-history-detect-from-modernizr | 73 | true | false | 5 | true | false | false | emberjs | ember.js | 12,155 |
178fee099a9c663f1275a118ccc37f7d67bc9f0f | Eliot Sykes | Eliot Sykes | [BUGFIX beta] Update supportsHistory to use Modernizr latest
The existing supportsHistory check was borrowed from an older
version of Modernizr. This updates the check from the latest
Modernizr history detect[1], to do more thorough User Agent sniffing
:-(.
(Disables jscs around the supportsHistory test to avoid warning
about 2 consecutive newlines when comments are stripped out.)
[1] https://github.com/Modernizr/Modernizr/blob/cc5340e99402d24ede04d9f8a2a38ce8ca4f47ec/feature-detects/history.js | [bugfix beta] update supportshistory to use modernizr latest | 60 | false | false | 8 | false | false | false | emberjs | ember.js | 12,156 |
e82eb27c0441ada8bee3c31571f0864d3fec76f8 | Robert Jackson | Robert Jackson | Merge pull request #11239 from davewasmer/fix-inspect-for-symbols
[BUGFIX beta] Add support for inspecting Symbols | merge pull request from davewasmer/fix-inspect-for-symbols | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 12,157 |
834382ae778be7c1bb24136bc699d2dc90ca2744 | Dave Wasmer | Dave Wasmer | Add support for inspecting symbols
True Symbols cannot be coerced to a string, and typeof returns
'symbol'. This caused the inspect function treat it as a non-object
(which is technically correct, since it's a new primitive type).
Adds an additional check to ensure the inspected value is not a
Symbol before attempting string coercion. Symbols will fail, and
fall through to the toString() implementation, which is the
desired output. | add support for inspecting symbols | 34 | false | false | 5 | true | true | true | emberjs | ember.js | 12,158 |
2a5efd6aa5f30a6173a38cf48aac9877a84de836 | Robert Jackson | Robert Jackson | Merge pull request #11242 from rwjblue/proper-view-for-helpers
[BUGFIX beta] Use the proper options.data.view for Handlebars compat helpers. | merge pull request from rwjblue/proper-view-for-helpers | 56 | true | false | 5 | true | false | false | emberjs | ember.js | 12,159 |
d93977a428c001034d5f9ff78df17c86948b4015 | Robert Jackson | Robert Jackson | [BUGFIX beta] Use the proper options.data.view for Handlebars compat helpers. | [bugfix beta] use the proper options.data.view for handlebars compat helpers | 76 | false | false | 10 | false | false | false | emberjs | ember.js | 12,160 |
1ce6034a37edb6ad8fbbc363b91e37eb98ab6b98 | Robert Jackson | Robert Jackson | Merge pull request #11235 from rwjblue/allow-isVisible-to-be-CP
[BUGFIX beta] Allow `isVisible` to be a computed property. | merge pull request from rwjblue/allow-isvisible-to-be-cp | 57 | true | false | 5 | true | false | false | emberjs | ember.js | 12,161 |
c675839865c40d7349905b2f54c8be34aac2fa18 | Robert Jackson | Robert Jackson | Merge pull request #11234 from rwjblue/fix-legacy-each-itemView-with-non-context-shifting
[BUGFIX beta] Fix {{each item in model itemViewClass="..."}}. | merge pull request from rwjblue/fix-legacy-each-itemview-with-non-context-shifting | 83 | true | false | 5 | true | false | false | emberjs | ember.js | 12,162 |
d1c424cebd984b02f04554e837693a8d0c348410 | Robert Jackson | Robert Jackson | [BUGFIX beta] Allow `isVisible` to be a computed property. | [bugfix beta] allow `isvisible` to be a computed property | 57 | false | false | 9 | false | false | false | emberjs | ember.js | 12,163 |
67780e080a95d065e3e15e031a3b2083c7c5e645 | Robert Jackson | Robert Jackson | [BUGFIX beta] Fix {{each item in model itemViewClass="..."}}.
Previously, we were always context shifting in this case (since no block params
were used). | [bugfix beta] fix {{each item in model itemviewclass="..."}} | 60 | false | false | 8 | false | false | false | emberjs | ember.js | 12,164 |
afe178fcfbfad9beb582edfb9ffd76de65d0e88e | Robert Jackson | Robert Jackson | Merge pull request #11231 from rwjblue/fix-legacy-each-else-block
[BUGFIX beta] Fix {{each}} with `itemViewClass` and {{else}}. | merge pull request from rwjblue/fix-legacy-each-else-block | 59 | true | false | 5 | true | false | false | emberjs | ember.js | 12,165 |
6c2f000f11040709dd8dcdcf07b1224569afde80 | Robert Jackson | Robert Jackson | [BUGFIX beta] Fix {{each}} with `itemViewClass` and {{else}}. | [bugfix beta] fix {{each}} with `itemviewclass` and {{else}} | 60 | false | false | 8 | false | false | false | emberjs | ember.js | 12,166 |
baa457376034e5e3e46366e840b31675b349b619 | Godfrey Chan | Godfrey Chan | Don't dispatch new lifecycle hooks to views
Since 84c2875, the lifecycle hooks are inconsistent between views and
components. For example, the `willReceiveAttrs` hook has been renamed to
`didReceiveAttrs` on components but not on views. Talked to @wycats about it,
the plan is "to remove all of the new lifecycle hooks from views", because
"views are sufficiently crazy that I don't want to try to mix in new semantics".
In this commit:
- [x] :scissors: `didUpdate` from `View`s
- [x] :scissors: `willReceiveAttrs` from `View`s
- [x] Rename `willRender` to `_willRender` on `View`s (for now)
- [x] Rename `willUpdate` to `_willUpdate` on `View`s (for now)
TODO:
- [ ] Refactor internal `View`s to not use `_willRender`
- [ ] Refactor internal `View`s to not use `_willUpdate`
- [ ] :scissors: `_willRender` from `View`s
- [ ] :scissors: `_willUpdate` from `View`s | don't dispatch new lifecycle hooks to views | 43 | false | false | 7 | false | false | false | emberjs | ember.js | 12,167 |
d5a4719f6e29f5130a0d625601af47b41ccf22b7 | Robert Jackson | Robert Jackson | Merge pull request #11228 from rwjblue/fix-legacy-each-itemViewClass-tagName
[BUGFIX beta] Fix {{each}} with `itemViewClass` specified `tagName`. | merge pull request from rwjblue/fix-legacy-each-itemviewclass-tagname | 70 | true | false | 5 | true | false | false | emberjs | ember.js | 12,168 |
49c88b16f22e3e227054b328453040f1ba350f56 | Robert Jackson | Robert Jackson | [BUGFIX beta] Fix {{each}} with `itemViewClass` specified `tagName`. | [bugfix beta] fix {{each}} with `itemviewclass` specified `tagname` | 67 | false | false | 8 | false | false | false | emberjs | ember.js | 12,169 |
79e764e4929e6b1ece6e7684cec1175efa53d58f | Robert Jackson | Robert Jackson | Merge pull request #11227 from rwjblue/fix-aria-role
[BUGFIX beta] Ensure role attribute is applied to views if present. | merge pull request from rwjblue/fix-aria-role | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 12,170 |
a96dda152f5a2a212abc73a24d6ac71b8c855a29 | Robert Jackson | Robert Jackson | Merge pull request #11226 from amiel/label-test-promises
[BUGFIX beta] Pass label to Ember.Test.Promise | merge pull request from amiel/label-test-promises | 50 | true | false | 5 | true | false | false | emberjs | ember.js | 12,171 |
319822568e3ad7a0687211ec56528b491c26409c | Robert Jackson | Robert Jackson | [BUGFIX beta] Ensure role attribute is applied to views if present.
The `role` attribute was previously being applied manually basically forever,
but was removed during the Glimmer view layer rewrite.
This commit brings it back, and adds a few tests for both Ember.View and
Ember.Component to help ensure we don't forget about it in the future. :smiley: | [bugfix beta] ensure role attribute is applied to views if present | 66 | false | false | 11 | false | false | false | emberjs | ember.js | 12,172 |
44c93e0d4b24d40f66ab8bf92c94ce12d57b7475 | Amiel Martin | Amiel Martin | [BUGFIX beta] Pass a label with Ember.Test.promise
This allows promises used in testing code to be labeled:
return Ember.Test.promise((resolve) => Ember.run.later(resolve, 1000), "Stall tests for 1 second"); | [bugfix beta] pass a label with ember.test.promise | 50 | false | false | 7 | false | false | false | emberjs | ember.js | 12,173 |
0d56900937c0cebeff4e60ec68723fde168a1acc | Robert Jackson | Robert Jackson | Merge pull request #11223 from mixonic/unbound-with-container
[BUGFIX beta] Add test for unbound use with a container | merge pull request from mixonic/unbound-with-container | 55 | true | false | 5 | true | false | false | emberjs | ember.js | 12,174 |
90ab46cd20d06f9f06e56bb1722219c718eb40b6 | Matthew Beale | Matthew Beale | [BUGFIX beta] Add test for unbound use with a container
Tests were passing in this case because a container was not present.
With a container, unbound should still work. | [bugfix beta] add test for unbound use with a container | 55 | false | false | 10 | false | false | false | emberjs | ember.js | 12,175 |
e09b0ef654ab7e3b00bb3b44715c9040a67a58d5 | Robert Jackson | Robert Jackson | Merge pull request #11222 from mixonic/component-stuff
[BUGFIX beta] Only pass isComponent with a dash | merge pull request from mixonic/component-stuff | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 12,176 |
c56f6b394a8ef8046ff5574bf17111665727bde9 | Robert Jackson | Robert Jackson | Merge pull request #11220 from dsokolowski/computed_sort_fix
Fix for issue with Em.computed.sort observers | merge pull request from dsokolowski/computed_sort_fix | 54 | true | false | 5 | true | false | false | emberjs | ember.js | 12,177 |
33647888cd2572a10a62fdf2637c47dd96e336ca | Matthew Beale | Matthew Beale | [BUGFIX beta] Only pass isComponent with a dash
Previously, any key looked up in the container was listed as a component
by `isComponent`. Additionally, the assertion for dashless components was
upon lookup in `component_lookup`. This commit makes `isComponent` filter
for dashes as well as presence in the container.
All paths (like `{{dashless}}`) in the container returned true from
`isComponent`, which in turn handled keyword redirects and the catch-all
keyword behavior. It turn out that, using the Ember-CLI resolver, a
module named `app/dashless/template` will resolve both
`template:components/dashless` and `template:dashless`. Thus when using
pods, the `isComponent` check for `dashless` would pass.
This means if `dashless` was used as a bound variable in a template, it
would be treated like a component and throw an error (for not having a
dash).
Additionally, the `isComponent` check not filtering for dashes means all
template keywords (like `yield`, `if`, `outlet`) were creating container
lookups. This is far less performant that splitting than scanning the
string for a dash.
This commit does not fix all cases. If you name a route with a dash, and
use that same dashed name as a variable in a template bad behavior will
manifest: The template of that route will render with a generated
component backing it. This problem must be resolved when routable
components are landed. | [bugfix beta] only pass iscomponent with a dash | 47 | false | false | 8 | false | false | false | emberjs | ember.js | 12,178 |
164a80ed45e0447d3c6d629a941dc0651bd424cb | Daniel | Daniel | [BUGFIX beta] fix for Em.computed.sort issue with leaking observers | [bugfix beta] fix for em.computed.sort issue with leaking observers | 67 | false | false | 9 | false | false | false | emberjs | ember.js | 12,179 |
5ad7d0c988e1590ee1739fdd29f2593513c925cb | Daniel | Daniel | [BUGFIX beta] failing tests for Em.computed.sort issue with leaking observers | [bugfix beta] failing tests for em.computed.sort issue with leaking observers | 77 | false | false | 10 | false | false | false | emberjs | ember.js | 12,180 |
2d128dbd4adba409312c6f3b642d06067c89d5d7 | Dan McClain | Dan McClain | [BUGFIX beta] Allows for an arbitrary # of positional parameters
When the `positionalParams` property on a component is a string, the
positional parameters passed to the component will be an array that is
bound to that attribute, as per requested by @rwjblue here:
https://github.com/emberjs/ember.js/pull/11028#issuecomment-101029926 | [bugfix beta] allows for an arbitrary # of positional parameters | 64 | false | false | 10 | false | false | false | emberjs | ember.js | 12,181 |
76f5665c8ea7d9778aef6c8d09af3b9a3b2484be | Robert Jackson | Robert Jackson | Merge pull request #11205 from paddyobrien/paddy/get-empty-string-length
[BUGFIX release] Fix get with empty string | merge pull request from paddyobrien/paddy/get-empty-string-length | 66 | true | false | 5 | true | false | false | emberjs | ember.js | 12,182 |
05519f79605e86bd2f9f30e01779425864976771 | paddyobrien | paddyobrien | [BUGFIX release] Fix get with empty string | [bugfix release] fix get with empty string | 42 | false | false | 7 | false | false | false | emberjs | ember.js | 12,183 |
9c4faf65ccc4697e160310e23f90f0f5f11e9688 | Robert Jackson | Robert Jackson | Merge pull request #10913 from stefanpenner/allow-destroy-with-visit-without-autoboot
__deprecatedInstance__ is not available when autoboot is disabled, durin... | merge pull request from stefanpenner/allow-destroy-with-visit-without-autoboot | 79 | true | false | 5 | true | false | false | emberjs | ember.js | 12,184 |
c81ba6b57b6a896cabb925192f415372ea7248f3 | Stefan Penner | Stefan Penner | Merge pull request #11208 from emberjs/stefanpenner-patch-1
Update is_none.js | merge pull request from emberjs/stefanpenner-patch-1 | 53 | true | false | 5 | true | false | false | emberjs | ember.js | 12,185 |
011a2c13fe788a8bd5c86243a8e70853804b570c | Stefan Penner | Stefan Penner | Update is_none.js | update is_none.js | 17 | false | false | 2 | true | false | false | emberjs | ember.js | 12,186 |
6a39f56a3fd79085bd40fd113c833b695cc2f3bd | Don Morrison | Robert Jackson | [BUGFIX release] Ensure app booted in visit helper
Problem:
There are reported cases of the currentURL helper returning an empty
string after the release of 1.12.
Tests:
The acceptance tests are not currently checking the currentURL after
using the visit helper. This adds an assertion for the current url after
each currentRoute assertion - the currentRouteName and currentPath
helpers are functioning normally and, in these tests, the currentRoute
is a var set on transition to a new route so there is a need to
specifically check the url.
Fix:
It turns out that this isn't so much a problem with currentURL as it is
the visit helper. When the lazy router location work was completed in
8e130e52 the call to `router.location.setURL()` was moved down in the
else case after checking for readiness deferrals. The problem seems to be
a timing issue with the call to setupRouter after the application is
marked ready. The initialURL, while set, doesn't give us a reliable URL
during tests.
The call to `app.boot()` ensures the application is booted and ready,
the important part for this fix is the call to `advanceReadiness` in
boot - it is there that the router and location are set up.
After the app is booted the call to `setURL` works as expected.
Thanks to @rwjblue for working out the code needed to correct the issue.
(cherry picked from commit 1771aec66937a66571c3b1bdad05b9115696492e) | [bugfix release] ensure app booted in visit helper | 50 | false | false | 8 | false | false | false | emberjs | ember.js | 12,187 |
235516e9453452fb2740c1a0b329062925ab2fe3 | Robert Jackson | Robert Jackson | Merge pull request #11196 from jmurphyau/get-keyword
Implement {{get}} Keyword | merge pull request from jmurphyau/get-keyword | 46 | true | false | 5 | true | false | false | emberjs | ember.js | 12,188 |
003caee52272a56b86b10ed4d49e002b46af42a5 | Robert Jackson | Robert Jackson | Merge pull request #11203 from rwjblue/update-htmlbars
Ensure components for void tagNames do not have childNodes. | merge pull request from rwjblue/update-htmlbars | 48 | true | false | 5 | true | false | false | emberjs | ember.js | 12,189 |
26ad0ba7a83d191a0996fc5f92bfa0b39820f194 | Robert Jackson | Robert Jackson | Ensure components for void tagNames do not have childNodes. | ensure components for void tagnames do not have childnodes | 58 | false | false | 9 | false | false | false | emberjs | ember.js | 12,190 |
bd1d6084d3c918a3cab0a649701ef040c2ad7b42 | James Murphy | James Murphy | Implement {{get}} Keyword
The Syntax: `{{get object path}}`
A new keyword/helper that can be used to allow your object and/or key
values to be dynamic.
Example: {{get person propertyName}} | implement {{get}} keyword | 25 | false | false | 3 | false | true | false | emberjs | ember.js | 12,191 |
cebcd8bf824649c50bd2ab8cc66e159e955ecd7d | Matthew Beale | Matthew Beale | Merge pull request #11194 from mitchlloyd/many-class-name-bindings
[1.13.0.beta1] Don’t stop iteration on first :class in classNameBindings | merge pull request from mitchlloyd/many-class-name-bindings | 60 | true | false | 5 | true | false | false | emberjs | ember.js | 12,192 |
cb43551d516980d61a1587282e57bea9d70f9148 | Mitch Lloyd | Mitch Lloyd | Don’t stop iteration on first :class
Fix for issue #11193 | class | 5 | false | false | 1 | false | false | false | emberjs | ember.js | 12,193 |
28d4c06a7f1f946d241746f7ac3b8c87bfe689f6 | Matthew Beale | Matthew Beale | Merge pull request #11190 from stavarotti/update-docs-ember-namespace
[Doc Canary] Updated Ember namespace documentation. | merge pull request from stavarotti/update-docs-ember-namespace | 63 | true | false | 5 | true | false | false | emberjs | ember.js | 12,194 |
0601e70188683732fb418b3d1580989accdecbed | Ryuichi Okumura | Ryuichi Okumura | Bump ember-cli-yuidoc version to ^0.7.0 | bump ember-cli-yuidoc version to ^0.7.0 | 39 | true | false | 5 | false | false | false | emberjs | ember.js | 12,195 |
01db4c53380c53582fc980ff085147e8a532306c | Steve Chikwaya | Steve Chikwaya | [Doc Canary] Updated Ember namespace documentation. | [doc canary] updated ember namespace documentation | 50 | false | false | 6 | false | false | false | emberjs | ember.js | 12,196 |
cb056448b11d6f1e149a119985dae18ddbf17639 | Robert Jackson | Robert Jackson | Merge pull request #11189 from johanneswuerbach/ember-cli-sauce-130
ember-cli-sauce v1.3.0 | merge pull request from johanneswuerbach/ember-cli-sauce-130 | 61 | true | false | 5 | true | false | false | emberjs | ember.js | 12,197 |
54d3e16046bf6a9ae3bb2202b4b7eb7637d14bd2 | Johannes Würbach | Johannes Würbach | ember-cli-sauce v1.3.0
Use the new `ember sauce:launch`
Replaced start & stop with prefixed commands
Removed duplicated stop | ember-cli-sauce v1.3.0 | 22 | false | false | 2 | false | false | false | emberjs | ember.js | 12,198 |
5fdcedd224e220ff74685cdbf37eb1ef974e912f | Matthew Beale | Matthew Beale | Merge pull request #11171 from emberjs/each-in-helper
Implement {{each-in}} helper | merge pull request from emberjs/each-in-helper | 47 | true | false | 5 | true | false | false | emberjs | ember.js | 12,199 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.