language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
mrdoob
three.js
6580a6e6d23484e437a4ceb0a968d54a47cc0500.json
Escape strings for use in regex search. (#23729)
docs/index.html
@@ -350,6 +350,12 @@ <h1><a href="https://threejs.org">three.js</a></h1> } + function escapeRegExp( string ) { + + return string.replace( /[.*+?^${}()|[\]\\]/g, '\\$&' ); // https://stackoverflow.com/a/6969486/5250847 + + } + function updateFilter() { let v = filterInput.value.trim(); @@ -367,7 +373...
true
Other
mrdoob
three.js
6580a6e6d23484e437a4ceb0a968d54a47cc0500.json
Escape strings for use in regex search. (#23729)
examples/index.html
@@ -249,6 +249,12 @@ <h1><a href="https://threejs.org">three.js</a></h1> } + function escapeRegExp( string ) { + + return string.replace( /[.*+?^${}()|[\]\\]/g, '\\$&' ); // https://stackoverflow.com/a/6969486/5250847 + + } + function updateFilter( files, tags ) { let v = filterInput.value.trim(); @...
true
Other
mrdoob
three.js
d28c286c183d6db719240cd214b42c6338d1b326.json
remove author comments
examples/jsm/loaders/3DMLoader.js
@@ -1,7 +1,3 @@ -/** - * @author Luis Fraguada / https://github.com/fraguada - */ - import { BufferGeometryLoader, FileLoader,
false
Other
mrdoob
three.js
7ab47df7621c655e99fbd4e9f8e934bcf27a3783.json
prefer const updates
examples/js/loaders/EXRLoader.js
@@ -938,15 +938,15 @@ THREE.EXRLoader.prototype = Object.assign( Object.create( THREE.DataTextureLoade for ( let comp = 0; comp < numComp; ++ comp ) { - let type = channelData[ cscSet.idx[ comp ] ].type; + const type = channelData[ cscSet.idx[ comp ] ].type; for ( let y = 8 * blocky; y < 8 * bl...
false
Other
mrdoob
three.js
92b163611488ff62f858a7fd14cd9c85bb1e3c6d.json
maintain texture parameters
examples/jsm/utils/RoughnessMipmapper.js
@@ -7,7 +7,6 @@ */ import { - LinearMipMapLinearFilter, MathUtils, Mesh, NoBlending, @@ -72,7 +71,7 @@ RoughnessMipmapper.prototype = { if ( width !== roughnessMap.image.width || height !== roughnessMap.image.height ) { - var newRoughnessTarget = new WebGLRenderTarget( width, height, { minFilter: Li...
false
Other
mrdoob
three.js
c960bb1b9ce8c409138ac54784e1b44f06477b5e.json
Extend object classes with generic types
src/objects/InstancedMesh.d.ts
@@ -8,7 +8,7 @@ import { Matrix4 } from './../math/Matrix4'; export class InstancedMesh < TGeometry extends Geometry | BufferGeometry = Geometry | BufferGeometry, TMaterial extends Material | Material[] = Material | Material[] -> extends Mesh { +> extends Mesh<TGeometry, TMaterial> { constructor( geometry: ...
true
Other
mrdoob
three.js
c960bb1b9ce8c409138ac54784e1b44f06477b5e.json
Extend object classes with generic types
src/objects/LineLoop.d.ts
@@ -6,7 +6,7 @@ import { BufferGeometry } from '../core/BufferGeometry'; export class LineLoop < TGeometry extends Geometry | BufferGeometry = Geometry | BufferGeometry, TMaterial extends Material | Material[] = Material | Material[] -> extends Line { +> extends Line<TGeometry, TMaterial> { constructor( geo...
true
Other
mrdoob
three.js
c960bb1b9ce8c409138ac54784e1b44f06477b5e.json
Extend object classes with generic types
src/objects/LineSegments.d.ts
@@ -15,7 +15,7 @@ export const LinePieces: number; export class LineSegments < TGeometry extends Geometry | BufferGeometry = Geometry | BufferGeometry, TMaterial extends Material | Material[] = Material | Material[] -> extends Line { +> extends Line<TGeometry, TMaterial> { constructor( geometry?: TGeometry,
true
Other
mrdoob
three.js
c960bb1b9ce8c409138ac54784e1b44f06477b5e.json
Extend object classes with generic types
src/objects/SkinnedMesh.d.ts
@@ -8,7 +8,7 @@ import { BufferGeometry } from '../core/BufferGeometry'; export class SkinnedMesh < TGeometry extends Geometry | BufferGeometry = Geometry | BufferGeometry, TMaterial extends Material | Material[] = Material | Material[] -> extends Mesh { +> extends Mesh<TGeometry, TMaterial> { constructor( ...
true
Other
mrdoob
three.js
a6f25bce55a99918a16c5ff8055ab8a8ea0f577e.json
Remove duplicate transmission property (#22464)
src/materials/MeshPhysicalMaterial.js
@@ -72,7 +72,6 @@ class MeshPhysicalMaterial extends MeshStandardMaterial { this.sheenTint = new Color( 0x000000 ); this.sheenRoughness = 1.0; - this.transmission = 0.0; this.transmissionMap = null; this.thickness = 0.01; @@ -88,7 +87,6 @@ class MeshPhysicalMaterial extends MeshStandardMaterial { th...
false
Other
mrdoob
three.js
595987ef5c783603ad93ee39551906a67eb24a8a.json
Prevent infinite loop in Mesh.raycast(). (#22068)
src/objects/Mesh.js
@@ -170,7 +170,7 @@ class Mesh extends Object3D { const groupMaterial = material[ group.materialIndex ]; const start = Math.max( group.start, drawRange.start ); - const end = Math.min( ( group.start + group.count ), ( drawRange.start + drawRange.count ) ); + const end = Math.min( index.count, ...
false
Other
mrdoob
three.js
a8ebd6d330ec42f87dc037a2e9e992fe1ecc59f1.json
Use roughness-squared in sheen BRDF
src/renderers/shaders/ShaderChunk/bsdfs.glsl.js
@@ -220,8 +220,10 @@ vec3 BRDF_BlinnPhong( const in IncidentLight incidentLight, const in GeometricCo // https://github.com/google/filament/blob/master/shaders/src/brdf.fs float D_Charlie( float roughness, float dotNH ) { + float alpha = pow2( roughness ); + // Estevez and Kulla 2017, "Production Friendly Microfa...
false
Other
mrdoob
three.js
e0dfbc1b44e5c61beaae824e8ed627ba4bdcb23b.json
Improve clearcoat energy conservation (#22389)
src/renderers/shaders/ShaderChunk/lights_physical_pars_fragment.glsl.js
@@ -16,14 +16,10 @@ struct PhysicalMaterial { }; -#define DEFAULT_SPECULAR_COEFFICIENT 0.04 - -// Clear coat directional hemishperical reflectance (this approximation should be improved) -float clearcoatDHRApprox( const in float roughness, const in float dotNL ) { +// temporary +vec3 clearcoatSpecular = vec3( 0.0 ...
true
Other
mrdoob
three.js
e0dfbc1b44e5c61beaae824e8ed627ba4bdcb23b.json
Improve clearcoat energy conservation (#22389)
src/renderers/shaders/ShaderLib/meshphysical_frag.glsl.js
@@ -107,6 +107,16 @@ void main() { vec3 outgoingLight = totalDiffuse + totalSpecular + totalEmissiveRadiance; + #ifdef CLEARCOAT + + float dotNVcc = saturate( dot( geometry.clearcoatNormal, geometry.viewDir ) ); + + vec3 Fcc = F_Schlick( vec3( DEFAULT_SPECULAR_COEFFICIENT ), 1.0, dotNVcc ); + + outgoingLight =...
true
Other
mrdoob
three.js
efba1d0b0150d6fc4987273de0f9fb29275b35f7.json
Build ESM target first. (#22371)
utils/build/rollup.config.js
@@ -275,6 +275,21 @@ ${ code }`; } export default [ + { + input: 'src/Three.js', + plugins: [ + addons(), + glconstants(), + glsl(), + header() + ], + output: [ + { + format: 'esm', + file: 'build/three.module.js' + } + ] + }, { input: 'src/Three.js', plugins: [ @@ -320,20 +335,5 @@ e...
false
Other
mrdoob
three.js
fa64d4a0f3b36fc738128c98862f83cf4ec91ea3.json
Remove unused parameter
src/renderers/shaders/ShaderChunk/envmap_physical_pars_fragment.glsl.js
@@ -7,7 +7,7 @@ export default /* glsl */` #endif - vec3 getLightProbeIndirectIrradiance( const in GeometricContext geometry, const in int maxMIPLevel ) { + vec3 getLightProbeIndirectIrradiance( const in GeometricContext geometry ) { #if defined( ENVMAP_TYPE_CUBE_UV ) @@ -25,7 +25,7 @@ export default /* gl...
true
Other
mrdoob
three.js
fa64d4a0f3b36fc738128c98862f83cf4ec91ea3.json
Remove unused parameter
src/renderers/shaders/ShaderChunk/lights_fragment_maps.glsl.js
@@ -18,19 +18,19 @@ export default /* glsl */` #if defined( USE_ENVMAP ) && defined( STANDARD ) && defined( ENVMAP_TYPE_CUBE_UV ) - iblIrradiance += getLightProbeIndirectIrradiance( /*lightProbe,*/ geometry, maxMipLevel ); + iblIrradiance += getLightProbeIndirectIrradiance( /*lightProbe,*/ geometry ); #endi...
true
Other
mrdoob
three.js
528ada08ea8abfbe4f81ab1ecb08f63396d8c113.json
Simplify Schlick signature (#22316)
src/renderers/shaders/ShaderChunk/bsdfs.glsl.js
@@ -5,6 +5,7 @@ export default /* glsl */` // via 'environmentBRDF' from "Physically Based Shading on Mobile" // https://www.unrealengine.com/blog/physically-based-shading-on-mobile - environmentBRDF for GGX on mobile vec2 integrateSpecularBRDF( const in float dotNV, const in float roughness ) { + const vec4 c0 = ...
true
Other
mrdoob
three.js
528ada08ea8abfbe4f81ab1ecb08f63396d8c113.json
Simplify Schlick signature (#22316)
src/renderers/shaders/ShaderChunk/lights_physical_fragment.glsl.js
@@ -13,7 +13,7 @@ material.specularRoughness = min( material.specularRoughness, 1.0 ); #ifdef SPECULAR - vec3 specularIntensityFactor = vec3( specularIntensity ); + float specularIntensityFactor = specularIntensity; vec3 specularTintFactor = specularTint; #ifdef USE_SPECULARINTENSITYMAP @@ -28,13 +28,13...
true
Other
mrdoob
three.js
528ada08ea8abfbe4f81ab1ecb08f63396d8c113.json
Simplify Schlick signature (#22316)
src/renderers/shaders/ShaderChunk/lights_physical_pars_fragment.glsl.js
@@ -4,7 +4,7 @@ struct PhysicalMaterial { vec3 diffuseColor; float specularRoughness; vec3 specularColor; - vec3 specularColorF90; + float specularF90; #ifdef CLEARCOAT float clearcoat; @@ -93,7 +93,7 @@ void RE_Direct_Physical( const in IncidentLight directLight, const in GeometricC float clearcoatDHR ...
true
Other
mrdoob
three.js
d2fae357d7243cbb219925c2a3f5b8d89e7ebc65.json
improve SkinnedMesh.boneTransform docs (#23422)
docs/api/en/objects/SkinnedMesh.html
@@ -148,9 +148,15 @@ <h3>[method:undefined pose]()</h3> This method sets the skinned mesh in the rest pose (resets the pose). </p> - <h3>[method:Vector3 boneTransform]( [index:Integer], [target:Vector3] )</h3> + <h3>[method:Vector3 boneTransform]( [param:Integer index], [param:Vector3 target] )</h3> <p> ...
false
Other
mrdoob
three.js
63cf8afd7c23c03cc2402c7765a7762b0c39d887.json
clarify the example in SkinnedMesh docs (#23423)
docs/api/en/objects/SkinnedMesh.html
@@ -38,7 +38,8 @@ <h2>Code Example</h2> <code> const geometry = new THREE.CylinderGeometry( 5, 5, 5, 5, 15, 5, 30 ); - // create the skin indices and skin weights + // create the skin indices and skin weights manually + // (typically a loader would read this data from a 3D model for you) const position ...
false
Other
mrdoob
three.js
b44e5a661e6bea2bdb95543acbb2fd6ead39ca8a.json
Fix Live Editor for r137 (#23373) This is a more generic fix than hardcoding checks for 'three'. Also fixes the export function.
manual/examples/resources/editor-settings.js
@@ -61,7 +61,7 @@ function fixSourceLinks(url, source) { const urlPropRE = /(url:\s*)('|")(.*?)('|")/g; const workerRE = /(new\s+Worker\s*\(\s*)('|")(.*?)('|")/g; const importScriptsRE = /(importScripts\s*\(\s*)('|")(.*?)('|")/g; - const moduleRE = /(import.*?)(?!'three')('|")(.*?)('|")/g; + const moduleRE =...
true
Other
mrdoob
three.js
b44e5a661e6bea2bdb95543acbb2fd6ead39ca8a.json
Fix Live Editor for r137 (#23373) This is a more generic fix than hardcoding checks for 'three'. Also fixes the export function.
manual/examples/resources/editor.html
@@ -190,9 +190,6 @@ border-bottom: none !important; border-top: 5px solid #666 !important; } -.button-export { - display: none; /* TODO: Fix export with import maps */ -} .button-result { margin-left: 2em !important; }
true
Other
mrdoob
three.js
b44e5a661e6bea2bdb95543acbb2fd6ead39ca8a.json
Fix Live Editor for r137 (#23373) This is a more generic fix than hardcoding checks for 'three'. Also fixes the export function.
manual/examples/resources/editor.js
@@ -122,6 +122,26 @@ const htmlParts = { }, }; +function getRootPrefix(url) { + const u = new URL(url, window.location.href); + return u.origin; +} + +function removeDotDotSlash(href) { + // assumes a well formed URL. In other words: 'https://..//foo.html" is a bad URL and this code would fail. + const url = ...
true
Other
mrdoob
three.js
b3119d196ae99ed45eabbf173671db53a0001a97.json
Update HTMLMesh.js (#23381) Render number input values in HTMLMesh
examples/jsm/interactive/HTMLMesh.js
@@ -229,7 +229,7 @@ function html2canvas( element ) { drawBorder( style, 'borderBottom', x, y + height, width, 0 ); drawBorder( style, 'borderRight', x + width, y, 0, height ); - if ( element.type === 'color' || element.type === 'text' ) { + if ( element.type === 'color' || element.type === 'text' || elem...
false
Other
mrdoob
three.js
941a09bad225f1294ad4295ab9362eb30fae633f.json
add link to github draft PR page removed add [draft] from title. draft PR is enough and should be perferred
.github/CONTRIBUTING.md
@@ -77,6 +77,6 @@ When you’ve decided to make changes, start with the following: * Once done with a patch / feature do not add more commits to a feature branch * Create separate branches per patch or feature. -* If you make a PR but it is not actually ready to be pulled into the dev branch, add `[Draft]` into the P...
false
Other
mrdoob
three.js
724c0bdf8a6ca5a02745fb2778c9e89431215604.json
Fix typo in GLTFLoader.js accomodate -> accommodate
examples/js/loaders/GLTFLoader.js
@@ -2566,7 +2566,7 @@ THREE.GLTFLoader = ( function () { * Assigns final material to a Mesh, Line, or Points instance. The instance * already has a material (generated from the glTF material options alone) * but reuse of the same glTF material may require multiple threejs materials - * to accomodate different...
false
Other
mrdoob
three.js
761cae1547e0ee5632f242c011ae6fdac187bf2b.json
Fix docs for CurvePath.getCurveLengths
docs/api/en/extras/core/CurvePath.html
@@ -49,8 +49,8 @@ <h3>[method:null add]( [param:Curve curve] )</h3> <h3>[method:null closePath]()</h3> <p>Adds a [page:LineCurve lineCurve] to close the path.</p> - <h3>[method:Float getCurveLengths]()</h3> - <p>Adds together the lengths of the curves in the [page:.curves] array.</p> + <h3>[method:Array getC...
true
Other
mrdoob
three.js
761cae1547e0ee5632f242c011ae6fdac187bf2b.json
Fix docs for CurvePath.getCurveLengths
docs/api/zh/extras/core/CurvePath.html
@@ -49,7 +49,7 @@ <h3>[method:null add]( [param:Curve curve] )</h3> <h3>[method:null closePath]()</h3> <p>添加一条[page:LineCurve lineCurve]用于闭合路径。</p> - <h3>[method:Float getCurveLengths]()</h3> + <h3>[method:Array getCurveLengths]()</h3> <p>将[page:.curves]数组中曲线的长度相加。</p> <h3>[method:Vector getPoint]( [p...
true
Other
mrdoob
three.js
7208eb816b10b291540ae7905555697a4a6a1431.json
Replace soft tags with hard tabs
examples/jsm/loaders/GLTFLoader.js
@@ -258,7 +258,7 @@ var GLTFLoader = ( function () { parser.fileLoader.setRequestHeader( this.requestHeader ); - for ( var i = 0; i < this.pluginCallbacks.length; i ++ ) { + for ( var i = 0; i < this.pluginCallbacks.length; i ++ ) { var plugin = this.pluginCallbacks[ i ]( parser ); plugins[ p...
false
Other
mrdoob
three.js
74533eefd3ded6327ca08c3cae019947861a7f43.json
Improve ACES Filmic tone mapping
src/renderers/shaders/ShaderChunk/tonemapping_pars_fragment.glsl.js
@@ -31,11 +31,42 @@ vec3 OptimizedCineonToneMapping( vec3 color ) { } -// source: https://knarkowicz.wordpress.com/2016/01/06/aces-filmic-tone-mapping-curve/ +// source: https://github.com/selfshadow/ltc_code/blob/master/webgl/shaders/ltc/ltc_blit.fs +vec3 RRTAndODTFit( vec3 v ) { + + vec3 a = v * ( v + 0.02457...
false
Other
mrdoob
three.js
dcc6abe55f67242bc333b07aa0f98a799238805f.json
Change screenSpacePanning default value
docs/examples/en/controls/OrbitControls.html
@@ -236,7 +236,8 @@ <h3>[property:Float rotateSpeed]</h3> <h3>[property:Boolean screenSpacePanning]</h3> <p> Defines how the camera's position is translated when panning. If true, the camera pans in screen space. - Otherwise, the camera pans in the plane orthogonal to the camera's up direction. Default is fal...
true
Other
mrdoob
three.js
dcc6abe55f67242bc333b07aa0f98a799238805f.json
Change screenSpacePanning default value
docs/examples/zh/controls/OrbitControls.html
@@ -234,7 +234,10 @@ <h3>[property:Float rotateSpeed]</h3> <h3>[property:Boolean screenSpacePanning]</h3> <p> 定义当平移的时候摄像机的位置将如何移动。如果为true,摄像机将在屏幕空间内平移。 - 否则,摄像机将在与摄像机向上方向垂直的平面中平移。其默认值为false。 + 否则,摄像机将在与摄像机向上方向垂直的平面中平移。 + Defines how the camera's position is translated when panning. If true, the camera p...
true
Other
mrdoob
three.js
dcc6abe55f67242bc333b07aa0f98a799238805f.json
Change screenSpacePanning default value
examples/js/controls/OrbitControls.js
@@ -64,7 +64,7 @@ THREE.OrbitControls = function ( object, domElement ) { // Set to false to disable panning this.enablePan = true; this.panSpeed = 1.0; - this.screenSpacePanning = false; // if true, pan in screen-space + this.screenSpacePanning = true; // if false, pan orthogonal to world-space direction camera....
true
Other
mrdoob
three.js
dcc6abe55f67242bc333b07aa0f98a799238805f.json
Change screenSpacePanning default value
examples/jsm/controls/OrbitControls.js
@@ -73,7 +73,7 @@ var OrbitControls = function ( object, domElement ) { // Set to false to disable panning this.enablePan = true; this.panSpeed = 1.0; - this.screenSpacePanning = false; // if true, pan in screen-space + this.screenSpacePanning = true; // if false, pan orthogonal to world-space direction camera.up...
true
Other
mrdoob
three.js
14de6bc258762803301a74cf80e137ad25e97f5a.json
Fix a lint error
examples/jsm/loaders/GLTFLoader.js
@@ -1482,7 +1482,7 @@ var GLTFLoader = ( function () { // Use an ImageBitmapLoader if imageBitmaps are supported. Moves much of the // expensive work of uploading a texture to the GPU off the main thread. - if (typeof createImageBitmap !== 'undefined') { + if ( typeof createImageBitmap !== 'undefined' ) { ...
true
Other
mrdoob
three.js
14de6bc258762803301a74cf80e137ad25e97f5a.json
Fix a lint error
src/loaders/TextureLoader.js
@@ -7,7 +7,7 @@ import { ImageLoader } from './ImageLoader.js'; import { Texture } from '../textures/Texture.js'; import { Loader } from './Loader.js'; -function TextureLoader( manager, imageLoader ) { +function TextureLoader( manager ) { Loader.call( this, manager ); @@ -23,7 +23,7 @@ TextureLoader.prototype...
true
Other
mrdoob
three.js
b4d64ca5fb3d25385709b427dfcd8a9242fec78e.json
Add support for LightProbes
src/renderers/shaders/ShaderChunk/lights_lambert_vertex.glsl.js
@@ -13,7 +13,6 @@ backGeometry.viewDir = geometry.viewDir; vLightFront = vec3( 0.0 ); vIndirectFront = vec3( 0.0 ); - #ifdef DOUBLE_SIDED vLightBack = vec3( 0.0 ); vIndirectBack = vec3( 0.0 ); @@ -23,6 +22,18 @@ IncidentLight directLight; float dotNL; vec3 directLightColor_Diffuse; +vIndirectFront += getAm...
true
Other
mrdoob
three.js
b4d64ca5fb3d25385709b427dfcd8a9242fec78e.json
Add support for LightProbes
src/renderers/shaders/ShaderLib/meshlambert_frag.glsl.js
@@ -52,7 +52,6 @@ void main() { #include <emissivemap_fragment> // accumulation - reflectedLight.indirectDiffuse = getAmbientLightIrradiance( ambientLightColor ); #ifdef DOUBLE_SIDED @@ -81,6 +80,7 @@ void main() { reflectedLight.directDiffuse *= BRDF_Diffuse_Lambert( diffuseColor.rgb ) * getShadowMask();...
true
Other
mrdoob
three.js
b886901e6ce83ff42b2286879c58c586e5f2f835.json
Update Collada Exporter to export lightmap uvs
examples/jsm/exporters/ColladaExporter.js
@@ -264,6 +264,13 @@ ColladaExporter.prototype = { triangleInputs += `<input semantic="TEXCOORD" source="#${ uvName }" offset="0" set="0" />`; } + + // serialize lightmap uvs + if ( 'uv2' in bufferGeometry.attributes ) { + var uvName = `${ meshid }-texcoord2`; + gnode += getAttribute( buf...
false
Other
mrdoob
three.js
c0a69a1f79a0b32fcfb69fe6649b933d767be579.json
Add makeEmpty function to Sphere
docs/api/en/math/Sphere.html
@@ -76,6 +76,9 @@ <h3>[method:Float distanceToPoint]( [param:Vector3 point] )</h3> <h3>[method:Boolean empty]()</h3> <p>Checks to see if the sphere is empty (the radius set to 0).</p> + <h3>[method:Sphere makeEmpty]()</h3> + <p>Makes the sphere empty by setting [page:.center center] to (0, 0, 0) and [page:.ra...
true
Other
mrdoob
three.js
c0a69a1f79a0b32fcfb69fe6649b933d767be579.json
Add makeEmpty function to Sphere
docs/api/zh/math/Sphere.html
@@ -73,6 +73,9 @@ <h3>[method:Float distanceToPoint]( [param:Vector3 point] )</h3> <h3>[method:Boolean empty]()</h3> <p>检查球是否为空(其半径设为了0).</p> + <h3>[method:Sphere makeEmpty]()</h3> + <p>Makes the sphere empty by setting [page:.center center] to (0, 0, 0) and [page:.radius radius] to 0.</p> + <h3>[method:Bo...
true
Other
mrdoob
three.js
c0a69a1f79a0b32fcfb69fe6649b933d767be579.json
Add makeEmpty function to Sphere
src/math/Sphere.d.ts
@@ -15,6 +15,7 @@ export class Sphere { clone(): this; copy( sphere: Sphere ): this; empty(): boolean; + makeEmpty(): this; containsPoint( point: Vector3 ): boolean; distanceToPoint( point: Vector3 ): number; intersectsSphere( sphere: Sphere ): boolean;
true
Other
mrdoob
three.js
c0a69a1f79a0b32fcfb69fe6649b933d767be579.json
Add makeEmpty function to Sphere
src/math/Sphere.js
@@ -75,6 +75,15 @@ Object.assign( Sphere.prototype, { }, + makeEmpty: function () { + + this.center.set( 0, 0, 0 ); + this.radius = 0; + + return this; + + }, + containsPoint: function ( point ) { return ( point.distanceToSquared( this.center ) <= ( this.radius * this.radius ) );
true
Other
mrdoob
three.js
7630e7a649738cf28ad4fe5a9235da17d74de30c.json
Update unit tests.
test/unit/src/extras/curves/CatmullRomCurve3.tests.js
@@ -232,10 +232,10 @@ export default QUnit.module( 'Extras', () => { ]; var points = [ - curve.getPointAt( 0 ), - curve.getPointAt( 0.3 ), - curve.getPointAt( 0.5 ), - curve.getPointAt( 1 ) + curve.getPointAt( 0, new Vector3() ), + curve.getPointAt( 0.3, new Vector3() ), + curve....
true
Other
mrdoob
three.js
7630e7a649738cf28ad4fe5a9235da17d74de30c.json
Update unit tests.
test/unit/src/extras/curves/CubicBezierCurve.tests.js
@@ -116,10 +116,10 @@ export default QUnit.module( 'Extras', () => { ]; var points = [ - curve.getPointAt( 0 ), - curve.getPointAt( 0.3 ), - curve.getPointAt( 0.5 ), - curve.getPointAt( 1 ) + curve.getPointAt( 0, new Vector2() ), + curve.getPointAt( 0.3, new Vector2() ), + curve....
true
Other
mrdoob
three.js
7630e7a649738cf28ad4fe5a9235da17d74de30c.json
Update unit tests.
test/unit/src/extras/curves/CubicBezierCurve3.tests.js
@@ -116,10 +116,10 @@ export default QUnit.module( 'Extras', () => { ]; var points = [ - curve.getPointAt( 0 ), - curve.getPointAt( 0.3 ), - curve.getPointAt( 0.5 ), - curve.getPointAt( 1 ) + curve.getPointAt( 0, new Vector3() ), + curve.getPointAt( 0.3, new Vector3() ), + curve....
true
Other
mrdoob
three.js
7630e7a649738cf28ad4fe5a9235da17d74de30c.json
Update unit tests.
test/unit/src/extras/curves/EllipseCurve.tests.js
@@ -107,13 +107,16 @@ export default QUnit.module( 'Extras', () => { var testValues = [ 0, 0.3, 0.5, 0.7, 1 ]; - testValues.forEach( function ( val, i ) { + var p = new Vector2(); + var a = new Vector2(); + + testValues.forEach( function ( val ) { var expectedX = Math.cos( val * Math.PI * 2...
true
Other
mrdoob
three.js
7630e7a649738cf28ad4fe5a9235da17d74de30c.json
Update unit tests.
test/unit/src/extras/curves/LineCurve.tests.js
@@ -66,10 +66,10 @@ export default QUnit.module( 'Extras', () => { ]; var points = [ - curve.getPointAt( 0 ), - curve.getPointAt( 0.3 ), - curve.getPointAt( 0.5 ), - curve.getPointAt( 1 ) + curve.getPointAt( 0, new Vector2() ), + curve.getPointAt( 0.3, new Vector2() ), + curve.ge...
true
Other
mrdoob
three.js
7630e7a649738cf28ad4fe5a9235da17d74de30c.json
Update unit tests.
test/unit/src/extras/curves/LineCurve3.tests.js
@@ -66,10 +66,10 @@ export default QUnit.module( 'Extras', () => { ]; var points = [ - curve.getPointAt( 0 ), - curve.getPointAt( 0.3 ), - curve.getPointAt( 0.5 ), - curve.getPointAt( 1 ) + curve.getPointAt( 0, new Vector3() ), + curve.getPointAt( 0.3, new Vector3() ), + curve.ge...
true
Other
mrdoob
three.js
7630e7a649738cf28ad4fe5a9235da17d74de30c.json
Update unit tests.
test/unit/src/extras/curves/QuadraticBezierCurve.tests.js
@@ -120,10 +120,10 @@ export default QUnit.module( 'Extras', () => { ]; var points = [ - curve.getPointAt( 0 ), - curve.getPointAt( 0.3 ), - curve.getPointAt( 0.5 ), - curve.getPointAt( 1 ) + curve.getPointAt( 0, new Vector2() ), + curve.getPointAt( 0.3, new Vector2() ), + curve....
true
Other
mrdoob
three.js
7630e7a649738cf28ad4fe5a9235da17d74de30c.json
Update unit tests.
test/unit/src/extras/curves/QuadraticBezierCurve3.tests.js
@@ -120,10 +120,10 @@ export default QUnit.module( 'Extras', () => { ]; var points = [ - curve.getPointAt( 0 ), - curve.getPointAt( 0.3 ), - curve.getPointAt( 0.5 ), - curve.getPointAt( 1 ) + curve.getPointAt( 0, new Vector3() ), + curve.getPointAt( 0.3, new Vector3() ), + curve....
true
Other
mrdoob
three.js
7630e7a649738cf28ad4fe5a9235da17d74de30c.json
Update unit tests.
test/unit/src/extras/curves/SplineCurve.tests.js
@@ -111,13 +111,15 @@ export default QUnit.module( 'Extras', () => { QUnit.test( "getPointAt", ( assert ) => { var curve = _curve; + var point = new Vector2(); - assert.ok( curve.getPointAt( 0 ).equals( curve.points[ 0 ] ), "PointAt 0.0 correct" ); - assert.ok( curve.getPointAt( 1 ).equals( curve....
true
Other
mrdoob
three.js
97b1228c876133b07ff14af3d23e62905200c5d6.json
Fix typo in Line3 docs
docs/api/en/math/Line3.html
@@ -98,7 +98,7 @@ <h3>[method:Boolean equals]( [param:Line3 line] )</h3> <p> [page:Line3 line] - [page:Line3] to compare with this one.<br /><br /> - Returns true if both line's [page:.start start] and [page:.end en] points are equal. + Returns true if both line's [page:.start start] and [page:.end end] poin...
false
Other
mrdoob
three.js
75c0df531ebbdcea928eab41e41bb8038d867438.json
Fix binary reading problem of PCD format PCD binary format could look like this: ``` # .PCD v0.7 - Point Cloud Data file format VERSION 0.7 FIELDS x y z _ intensity ring _ SIZE 4 4 4 1 4 2 1 TYPE F F F U F U U COUNT 1 1 1 4 1 1 10 WIDTH 22539 HEIGHT 1 VIEWPOINT 0 0 0 1 0 0 0 POINTS 22539 DATA binary ``` ...
examples/jsm/loaders/PCDLoader.js
@@ -210,7 +210,7 @@ PCDLoader.prototype = Object.assign( Object.create( Loader.prototype ), { } else { PCDheader.offset[ PCDheader.fields[ i ] ] = sizeSum; - sizeSum += PCDheader.size[ i ]; + sizeSum += PCDheader.size[ i ] * PCDheader.count[ i ]; }
false
Other
mrdoob
three.js
a5a5351d0125c708bd7a96b6b7f459c3934957ad.json
fix a spelling bug in LineSegmentsGeometry.js
examples/js/lines/LineSegmentsGeometry.js
@@ -133,7 +133,7 @@ THREE.LineSegmentsGeometry.prototype = Object.assign( Object.create( THREE.Insta }, - fromLineSegements: function ( lineSegments ) { + fromLineSegments: function ( lineSegments ) { var geometry = lineSegments.geometry;
false
Other
mrdoob
three.js
e5f6dbd238cbf098d8f44ccab1a282637a2c5290.json
Update valid far range
docs/api/en/cameras/OrthographicCamera.html
@@ -72,7 +72,7 @@ <h3>[property:Float far]</h3> <p> Camera frustum far plane. Default is *2000*.<br /><br /> - The valid range is between the current value of the [page:.near near] plane and infinity. + Must be greater than the current value of [page:.near near] plane. </p> <h3>[property:Float left]</...
true
Other
mrdoob
three.js
e5f6dbd238cbf098d8f44ccab1a282637a2c5290.json
Update valid far range
docs/api/en/cameras/PerspectiveCamera.html
@@ -63,7 +63,7 @@ <h3>[property:Float far]</h3> <p> Camera frustum far plane. Default is *2000*.<br /><br /> - The valid range is between the current value of the [page:.near near] plane and infinity. + Must be greater than the current value of [page:.near near] plane. </p> <h3>[property:Float film...
true
Other
mrdoob
three.js
e5f6dbd238cbf098d8f44ccab1a282637a2c5290.json
Update valid far range
docs/api/zh/cameras/OrthographicCamera.html
@@ -75,7 +75,7 @@ <h3>[property:Float bottom]</h3> <h3>[property:Float far]</h3> <p> 摄像机视锥体远端面,其默认值为*2000*。<br /><br /> - 其值的有效范围介于[page:.near near](摄像机视锥体近端面)和无穷大之间。 + Must be greater than the current value of [page:.near near] plane. </p>
true
Other
mrdoob
three.js
e5f6dbd238cbf098d8f44ccab1a282637a2c5290.json
Update valid far range
docs/api/zh/cameras/PerspectiveCamera.html
@@ -62,7 +62,7 @@ <h3>[property:Float far]</h3> <p> 摄像机的远端面,默认值是*2000*。 <br /><br /> - 其有效值范围是在当前摄像机[page:.near near] plane(近端面)的值到无穷远之间。 + Must be greater than the current value of [page:.near near] plane. </p> <h3>[property:Float filmGauge]</h3>
true
Other
mrdoob
three.js
1c27b835f30d4e1ea0692f8997d6fefc19f09f22.json
Specify tonemapping exposure
examples/webgl_loader_gltf.html
@@ -87,6 +87,7 @@ renderer.setPixelRatio( window.devicePixelRatio ); renderer.setSize( window.innerWidth, window.innerHeight ); renderer.toneMapping = THREE.ACESFilmicToneMapping; + renderer.toneMappingExposure = 1; renderer.outputEncoding = THREE.sRGBEncoding; container.appendChild( rendere...
true
Other
mrdoob
three.js
1c27b835f30d4e1ea0692f8997d6fefc19f09f22.json
Specify tonemapping exposure
examples/webgl_materials_variations_physical.html
@@ -159,6 +159,7 @@ renderer.outputEncoding = THREE.sRGBEncoding; renderer.toneMapping = THREE.ACESFilmicToneMapping; + renderer.toneMappingExposure = 1; //
true
Other
mrdoob
three.js
1c27b835f30d4e1ea0692f8997d6fefc19f09f22.json
Specify tonemapping exposure
examples/webgl_materials_variations_standard.html
@@ -164,6 +164,7 @@ renderer.outputEncoding = THREE.sRGBEncoding; renderer.toneMapping = THREE.ACESFilmicToneMapping; + renderer.toneMappingExposure = 1; //
true
Other
mrdoob
three.js
474fd78d229508fa56aa6f790fc408973935250d.json
use regex to test
src/extras/ImageUtils.js
@@ -13,7 +13,7 @@ const ImageUtils = { let canvas; var src = image.src; - if ( src[ 0 ] === "d" && src[ 1 ] === "a" && src[ 2 ] === "t" && src[ 3 ] === "a" && src[ 4 ] === ":" ) { + if ( /^data:/i.test( src ) ) { return image.src;
false
Other
mrdoob
three.js
99cced52d11222fa898f8740bbccef1ac7834651.json
add PointsMaterial node system
examples/jsm/renderers/webgpu/WebGPUNodeBuilder.js
@@ -47,7 +47,7 @@ class WebGPUNodeBuilder extends NodeBuilder { const material = this.material; - if ( material.isMeshBasicMaterial ) { + if ( material.isMeshBasicMaterial || material.isPointsMaterial ) { if ( material.colorNode !== undefined ) {
true
Other
mrdoob
three.js
99cced52d11222fa898f8740bbccef1ac7834651.json
add PointsMaterial node system
examples/jsm/renderers/webgpu/WebGPURenderPipelines.js
@@ -797,6 +797,7 @@ class WebGPURenderPipelines { const ShaderLib = { mesh_basic: { vertexShader: `#version 450 + layout(location = 0) in vec3 position; layout(location = 1) in vec2 uv; @@ -818,6 +819,7 @@ const ShaderLib = { gl_Position = cameraUniforms.projectionMatrix * modelUniforms.modelViewMatri...
true
Other
mrdoob
three.js
99cced52d11222fa898f8740bbccef1ac7834651.json
add PointsMaterial node system
examples/webgpu_sandbox.html
@@ -95,6 +95,8 @@ const geometryPoints = new THREE.BufferGeometry().setFromPoints( points ); const materialPoints = new THREE.PointsMaterial(); + materialPoints.colorNode = new Vector3Node( new THREE.Vector3( 0, .6, 1 ) ); + const pointCloud = new THREE.Points( geometryPoints, materialPoints ); ...
true
Other
mrdoob
three.js
535a44942e9f2bfef793e2ac55d26773bccd7709.json
move nodes to webgpu_sandbox example
examples/webgpu_sandbox.html
@@ -19,6 +19,10 @@ import WebGPURenderer from './jsm/renderers/webgpu/WebGPURenderer.js'; import WebGPU from './jsm/renderers/webgpu/WebGPU.js'; + import FloatNode from './jsm/renderers/nodes/inputs/FloatNode.js'; + import Vector3Node from './jsm/renderers/nodes/inputs/Vector3Node.js'; + import Operator...
true
Other
mrdoob
three.js
535a44942e9f2bfef793e2ac55d26773bccd7709.json
move nodes to webgpu_sandbox example
examples/webgpu_sandbox_nodes.html
@@ -1,185 +0,0 @@ -<html lang="en"> - <head> - <title>WebGPU Sandbox</title> - <meta charset="utf-8"> - <meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0"> - <link type="text/css" rel="stylesheet" href="main.css"> - </head> - <body> - <div id="info"> - <a h...
true
Other
mrdoob
three.js
806eb90507bca48a22c86fd12deae7a05c5936d4.json
add opacityNode and rename to colorNode property
examples/jsm/renderers/webgpu/WebGPUNodeBuilder.js
@@ -49,9 +49,15 @@ class WebGPUNodeBuilder extends NodeBuilder { if ( material.isMeshBasicMaterial ) { - if ( material.color.isNode ) { + if ( material.colorNode !== undefined ) { - this.addSlot( 'fragment', new NodeSlot( material.color, 'COLOR', 'vec3' ) ); + this.addSlot( 'fragment', new N...
true
Other
mrdoob
three.js
806eb90507bca48a22c86fd12deae7a05c5936d4.json
add opacityNode and rename to colorNode property
examples/jsm/renderers/webgpu/WebGPURenderPipelines.js
@@ -842,6 +842,10 @@ const ShaderLib = { outColor.rgb = NODE_COLOR; #endif + #ifdef NODE_OPACITY + outColor.a *= NODE_OPACITY; + #endif + outColor.a *= opacityUniforms.opacity; }` },
true
Other
mrdoob
three.js
71a1a013df2bbce56f44cb06f6fd9ba25c4ec532.json
Fix "color" property type on LineBasicMaterial
src/materials/LineBasicMaterial.d.ts
@@ -21,7 +21,7 @@ export class LineBasicMaterial extends Material { /** * @default 0xffffff */ - color: Color | string | number; + color: Color; /** * @default 1
false
Other
mrdoob
three.js
87e22024d85b81297c7a5f0b9482b2b36401ea9d.json
Fix TSDoc for CircleGeometry
src/geometries/CircleGeometry.d.ts
@@ -6,7 +6,7 @@ export class CircleGeometry extends Geometry { * @param [radius=1] * @param [segments=8] * @param [thetaStart=0] - * @param [widthSegments=Math.PI * 2] + * @param [thetaLength=Math.PI * 2] */ constructor( radius?: number,
false
Other
mrdoob
three.js
5fb40fd5e362fd81c4b427718343127f7c0d0c5a.json
Fix TSDoc for CircleBufferGeometry
src/geometries/CircleBufferGeometry.d.ts
@@ -6,7 +6,7 @@ export class CircleBufferGeometry extends BufferGeometry { * @param [radius=1] * @param [segments=8] * @param [thetaStart=0] - * @param [widthSegments=Math.PI * 2] + * @param [thetaLength=Math.PI * 2] */ constructor( radius?: number,
false
Other
mrdoob
three.js
6e6cb3bb651740ff87df93d1190110c169cfdd59.json
Fix typo in ConeGeometry (again)
src/geometries/ConeGeometry.d.ts
@@ -5,7 +5,7 @@ export class ConeGeometry extends CylinderGeometry { /** * @param [radius=1] — Radius of the cone base. * @param [height=1] — Height of the cone. - * @param [radiusSegments=8] — Number of segmented faces around the circumference of the cone. + * @param [radialSegments=8] — Number of segmented ...
false
Other
mrdoob
three.js
7fac5aa010769750c040ae8ced46bb9fb0ab418e.json
Fix typo in ConeBufferGeometry (again)
src/geometries/ConeBufferGeometry.d.ts
@@ -5,7 +5,7 @@ export class ConeBufferGeometry extends CylinderBufferGeometry { /** * @param [radius=1] — Radius of the cone base. * @param [height=1] — Height of the cone. - * @param [radialSegment=8] — Number of segmented faces around the circumference of the cone. + * @param [radialSegments=8] — Number of...
false
Other
mrdoob
three.js
da17ebe2f3ed2c29bef33a438913fe637c98a675.json
Fix typo in ConeBufferGeometry
src/geometries/ConeBufferGeometry.d.ts
@@ -5,7 +5,7 @@ export class ConeBufferGeometry extends CylinderBufferGeometry { /** * @param [radius=1] — Radius of the cone base. * @param [height=1] — Height of the cone. - * @param [radiusSegments=8] — Number of segmented faces around the circumference of the cone. + * @param [radialSegment=8] — Number of...
false
Other
mrdoob
three.js
5e2fe49cec5606e6138a1a59e022d5b2c0e32097.json
Fix typo in CylinderGeometry
src/geometries/CylinderGeometry.d.ts
@@ -6,7 +6,7 @@ export class CylinderGeometry extends Geometry { * @param [radiusTop=1] — Radius of the cylinder at the top. * @param [radiusBottom=1] — Radius of the cylinder at the bottom. * @param [height=1] — Height of the cylinder. - * @param [radiusSegments=8] — Number of segmented faces around the circ...
false
Other
mrdoob
three.js
9d521b63ee2ed91f1fd186d999d7efb278aa25d9.json
Fix TSDoc for CylinderBufferGeometry
src/geometries/CylinderBufferGeometry.d.ts
@@ -6,7 +6,7 @@ export class CylinderBufferGeometry extends BufferGeometry { * @param [radiusTop=1] — Radius of the cylinder at the top. * @param [radiusBottom=1] — Radius of the cylinder at the bottom. * @param [height=1] — Height of the cylinder. - * @param [radiusSegments=8] — Number of segmented faces aro...
false
Other
mrdoob
three.js
43fe1848cb4fcbf75a252bf77588c2bcf2a0577b.json
Fix TSDoc for ConeBufferGeometry
src/geometries/ConeBufferGeometry.d.ts
@@ -3,14 +3,13 @@ import { CylinderBufferGeometry } from './CylinderBufferGeometry'; export class ConeBufferGeometry extends CylinderBufferGeometry { /** - * @param [radiusTop=0] — Radius of the cylinder at the top. - * @param [radiusBottom=1] — Radius of the cylinder at the bottom. - * @param [height=1] — Heig...
false
Other
mrdoob
three.js
59c7df7268da43b7bbe8a54fabfb7d46cff67653.json
Fix TSDoc for CylinderGeometry
src/geometries/CylinderGeometry.d.ts
@@ -10,7 +10,7 @@ export class CylinderGeometry extends Geometry { * @param [heightSegments=1] — Number of rows of faces along the height of the cylinder. * @param [openEnded=false] - A Boolean indicating whether or not to cap the ends of the cylinder. * @param [thetaStart=0] - * @param [widthSegments=Math.PI...
false
Other
mrdoob
three.js
0a1c4ec2e92a05af817815f4d1fcfd2587afe8fb.json
Fix ConeGeometry TSDoc
src/geometries/ConeGeometry.d.ts
@@ -3,14 +3,13 @@ import { CylinderGeometry } from './CylinderGeometry'; export class ConeGeometry extends CylinderGeometry { /** - * @param [radiusTop=0] — Radius of the cylinder at the top. - * @param [radiusBottom=1] — Radius of the cylinder at the bottom. - * @param [height=1] — Height of the cylinder. - *...
false
Other
mrdoob
three.js
455aea186f4c6f85185774b3c4d40b1e32a3598a.json
fix param comment for thetaLength
src/geometries/CylinderBufferGeometry.d.ts
@@ -10,7 +10,7 @@ export class CylinderBufferGeometry extends BufferGeometry { * @param [heightSegments=1] — Number of rows of faces along the height of the cylinder. * @param [openEnded=false] - A Boolean indicating whether or not to cap the ends of the cylinder. * @param [thetaStart=0] - * @param [widthSegm...
false
Other
mrdoob
three.js
e89611f6b056d13b0722811e1934f6af43785c12.json
Remove time variable
examples/webgl_shadow_contact.html
@@ -261,7 +261,7 @@ } - function animate( time ) { + function animate( ) { requestAnimationFrame( animate );
false
Other
mrdoob
three.js
1df61f9c7723dd76841ccf865b0d96574881c7eb.json
Add plane to contact shadow example
examples/webgl_shadow_contact.html
@@ -37,15 +37,21 @@ const CAMERA_HEIGHT = 0.3; var state = { - blur: 3.5, - darkness: 1, - opacity: 1, + shadow: { + blur: 3.5, + darkness: 1, + opacity: 1, + }, + plane: { + color: '#ffffff', + opacity: 1, + }, showWireframe: false, }; var shadowGroup, ...
false
Other
mrdoob
three.js
2508e47271b1c0bd3fa7cc980b87bf0c1d027363.json
Update stats in reder
examples/webgl_shadow_contact.html
@@ -270,6 +270,7 @@ scene.background = initialBackground; renderer.render( scene, camera ); + stats.update(); }
false
Other
mrdoob
three.js
39d5365adbd1763057201cfe879d8a68ce417323.json
reverse changes in core files
src/renderers/shaders/ShaderChunk.d.ts
@@ -43,9 +43,6 @@ export let ShaderChunk: { equirect_vert: string; fog_fragment: string; fog_pars_fragment: string; - geometry_decode_pars_vertex: string; - geometry_decode_normal_vertex: string; - geometry_decode_vertex: string; linedashed_frag: string; linedashed_vert: string; lightmap_fragment: string;
true
Other
mrdoob
three.js
39d5365adbd1763057201cfe879d8a68ce417323.json
reverse changes in core files
src/renderers/shaders/ShaderChunk.js
@@ -33,9 +33,6 @@ import fog_vertex from './ShaderChunk/fog_vertex.glsl.js'; import fog_pars_vertex from './ShaderChunk/fog_pars_vertex.glsl.js'; import fog_fragment from './ShaderChunk/fog_fragment.glsl.js'; import fog_pars_fragment from './ShaderChunk/fog_pars_fragment.glsl.js'; -import geometry_decode_pars_vertex...
true
Other
mrdoob
three.js
39d5365adbd1763057201cfe879d8a68ce417323.json
reverse changes in core files
src/renderers/shaders/ShaderChunk/geometry_decode_normal_vertex.glsl.js
@@ -1,5 +0,0 @@ -export default /* glsl */` -#ifdef USE_PACKED_NORMAL - objectNormal = decodeNormal(objectNormal); -#endif -`;
true
Other
mrdoob
three.js
39d5365adbd1763057201cfe879d8a68ce417323.json
reverse changes in core files
src/renderers/shaders/ShaderChunk/geometry_decode_pars_vertex.glsl.js
@@ -1,64 +0,0 @@ -export default /* glsl */` -#ifdef USE_PACKED_NORMAL -#if USE_PACKED_NORMAL == 0 - vec3 decodeNormal(vec3 packedNormal) - { - float x = packedNormal.x * 2.0 - 1.0; - float y = packedNormal.y * 2.0 - 1.0; - vec2 scth = vec2(sin(x * PI), cos(x * PI)); - vec2 scphi = vec...
true
Other
mrdoob
three.js
39d5365adbd1763057201cfe879d8a68ce417323.json
reverse changes in core files
src/renderers/shaders/ShaderChunk/geometry_decode_vertex.glsl.js
@@ -1,13 +0,0 @@ -export default /* glsl */` -#ifdef USE_PACKED_POSITION - #if USE_PACKED_POSITION == 0 - transformed = ( vec4(transformed, 1.0) * quantizeMatPos ).xyz; - #endif -#endif - -#ifdef USE_UV - #ifdef USE_PACKED_UV - vUv = decodeUV(vUv); - #endif -#endif -`;
true
Other
mrdoob
three.js
32f3fe47c4d8265fd49dea4a2b43ec92699082c6.json
Fix CSM shader
examples/jsm/csm/Shader.js
@@ -79,38 +79,46 @@ IncidentLight directLight; #endif #if defined( USE_SHADOWMAP ) && defined( CSM_FADE ) + vec2 cascade; + float cascadeCenter; + float closestEdge; + float margin; + float csmx; + float csmy; + + #unroll_loop_start for ( int i = 0; i < NUM_DIR_LIGHTS; i ++ ) { directionalLight = direction...
false
Other
mrdoob
three.js
3beb92a363b4ba05fbeb4bf9d686487e437d8aac.json
Remove need to pass camera matrix world to update
examples/jsm/csm/CSM.js
@@ -23,7 +23,6 @@ const _cameraToLightMatrix = new Matrix4(); const _lightSpaceFrustum = new Frustum(); const _frustum = new Frustum(); const _center = new Vector3(); -const _size = new Vector3(); const _bbox = new Box3(); const _uniformArray = []; const _logArray = []; @@ -207,8 +206,9 @@ export default class CS...
true
Other
mrdoob
three.js
3beb92a363b4ba05fbeb4bf9d686487e437d8aac.json
Remove need to pass camera matrix world to update
examples/webgl_shadowmap_csm.html
@@ -224,7 +224,7 @@ requestAnimationFrame( animate ); camera.updateMatrixWorld(); - csm.update( camera.matrixWorld ); + csm.update(); controls.update(); if ( params.orthographic ) {
true
Other
mrdoob
three.js
159da0de8e515c935d44bea5921fb1c18180776b.json
Use alert to make users more aware of errors
editor/js/Loader.js
@@ -232,7 +232,7 @@ var Loader = function ( editor ) { if ( isGLTF1( contents ) ) { - console.error( 'Import of glTF asset not possible. Only versions >= 2.0 are supported. Please try to upgrade the file to glTF 2.0 using glTF-Pipeline.' ); + alert( 'Import of glTF asset not possible. Only versions ...
false
Other
mrdoob
three.js
a921b43d7387b617d3682c112a86c1d5743a59ca.json
Add documentation for DataTexture2DArray
docs/api/en/textures/DataTexture2DArray.html
@@ -0,0 +1,94 @@ +<!DOCTYPE html> +<html lang="en"> + <head> + <meta charset="utf-8" /> + <base href="../../../" /> + <script src="list.js"></script> + <script src="page.js"></script> + <link type="text/css" rel="stylesheet" href="page.css" /> + </head> + <body> + [page:Texture] &rarr; + + <h1>[name]</h1> + + <...
true
Other
mrdoob
three.js
a921b43d7387b617d3682c112a86c1d5743a59ca.json
Add documentation for DataTexture2DArray
docs/api/zh/textures/DataTexture2DArray.html
@@ -0,0 +1,94 @@ +<!DOCTYPE html> +<html lang="zh"> + <head> + <meta charset="utf-8" /> + <base href="../../../" /> + <script src="list.js"></script> + <script src="page.js"></script> + <link type="text/css" rel="stylesheet" href="page.css" /> + </head> + <body> + [page:Texture] &rarr; + + <h1>[name]</h1> + + <...
true
Other
mrdoob
three.js
a921b43d7387b617d3682c112a86c1d5743a59ca.json
Add documentation for DataTexture2DArray
docs/list.js
@@ -338,6 +338,7 @@ var list = { "CompressedTexture": "api/en/textures/CompressedTexture", "CubeTexture": "api/en/textures/CubeTexture", "DataTexture": "api/en/textures/DataTexture", + "DataTexture2DArray": "api/en/textures/DataTexture2DArray", "DataTexture3D": "api/en/textures/DataTexture3D", ...
true
Other
mrdoob
three.js
9175e81dabdffd8967fbf4bf3288de7e4669e302.json
Replace var with let or const in WebGLMorphTargets
src/renderers/webgl/WebGLMorphtargets.js
@@ -19,9 +19,9 @@ function WebGLMorphtargets( gl ) { const influencesList = {}; const morphInfluences = new Float32Array( 8 ); - var workInfluences = []; + const workInfluences = []; - for ( var i = 0; i < 8; i ++ ) { + for ( let i = 0; i < 8; i ++ ) { workInfluences[ i ] = [ i, 0 ]; @@ -85,8 +85,8 @@ fu...
false