language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | mrdoob | three.js | bb3b4900cdefbcac7de9fccb845e48d8e1459d3d.json | add package to package.json | test/package.json | @@ -13,6 +13,7 @@
"pixelmatch": "^5.2.0",
"puppeteer": "3.1.0",
"qunit": "^2.10.0",
+ "rimraf": "^3.0.2",
"serve-handler": "^6.1.2"
},
"license": "MIT" | false |
Other | mrdoob | three.js | 9288ff08e5691f8439d59df9c350543101cbc164.json | remove symbolic link in node_modules | test/package.json | @@ -4,7 +4,7 @@
"description": "This package hiding test dependincies from main repo because puppeteer is pretty big.",
"scripts": {
"dev": "rollup -c rollup.unit.config.js -w -m inline",
- "unit": "rollup -c rollup.unit.config.js && cd unit/build && \"../../qunit\" -r failonlyreporter three.source.unit.j... | false |
Other | mrdoob | three.js | a4bc463fb42f694bdd031fbe6d8e77907aa11e14.json | add build folder also | test/package.json | @@ -4,7 +4,7 @@
"description": "This package hiding test dependincies from main repo because puppeteer is pretty big.",
"scripts": {
"dev": "rollup -c rollup.unit.config.js -w -m inline",
- "unit": "rollup -c rollup.unit.config.js && cd unit && ..\\qunit -r failonlyreporter build\\three.source.unit.js"
+ ... | false |
Other | mrdoob | three.js | e198fe78048cfeb296ef2f5756ac00c4c5e09430.json | Add documentation of hemisphereLightProbe | docs/api/en/lights/HemisphereLightProbe.html | @@ -0,0 +1,46 @@
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+ <meta charset="utf-8" />
+ <base href="../../../" />
+ <script src="list.js"></script>
+ <script src="page.js"></script>
+ <link type="text/css" rel="stylesheet" href="page.css" />
+ </head>
+ <body>
+ [page:Object3D] → [page:Light] → [page:... | true |
Other | mrdoob | three.js | e198fe78048cfeb296ef2f5756ac00c4c5e09430.json | Add documentation of hemisphereLightProbe | docs/api/zh/lights/HemisphereLightProbe.html | @@ -0,0 +1,46 @@
+<!DOCTYPE html>
+<html lang="zh">
+ <head>
+ <meta charset="utf-8" />
+ <base href="../../../" />
+ <script src="list.js"></script>
+ <script src="page.js"></script>
+ <link type="text/css" rel="stylesheet" href="page.css" />
+ </head>
+ <body>
+ [page:Object3D] → [page:Light] → [page:... | true |
Other | mrdoob | three.js | e198fe78048cfeb296ef2f5756ac00c4c5e09430.json | Add documentation of hemisphereLightProbe | docs/list.js | @@ -204,6 +204,7 @@ var list = {
"AmbientLightProbe": "api/en/lights/AmbientLightProbe",
"DirectionalLight": "api/en/lights/DirectionalLight",
"HemisphereLight": "api/en/lights/HemisphereLight",
+ "HemisphereLightProbe": "api/en/lights/HemisphereLightProbe",
"Light": "api/en/lights/Light",
"... | true |
Other | mrdoob | three.js | bbc05ad6538e7014c81008d766f1b742b2cdfdbc.json | add suggestion from mrdoob | examples/webgl_animation_cloth.html | @@ -42,10 +42,11 @@
// http://cg.alexandra.dk/tag/spring-mass-system/
// Real-time Cloth Animation http://www.darwin3d.com/gamedev/articles/col0599.pdf
- var params = {};
- params[ "Enable wind" ] = true;
- params[ "Show ball" ] = false;
- params[ "Toggle pins" ] = togglePins;
+ var params = {
+ ... | false |
Other | mrdoob | three.js | 23054b4e69f65a324fa5efc2ddf9e28733bf3e02.json | Allow the factory to cache controllers
Noticed that there was a significant delay in controllers reappearing after jumping into and out of a system menu, which was primarily caused by re-parsing the glTF assets. This change makes it much smoother.
Also includes a few bug fixes. | examples/jsm/webxr/XRControllerModelFactory.js | @@ -11,15 +11,15 @@ import {
SphereGeometry,
} from "../../../build/three.module.js";
-import { GLTFLoader } from '../loaders/GLTFLoader.js'
+import { GLTFLoader } from '../loaders/GLTFLoader.js';
import {
Constants as MotionControllerConstants,
fetchProfile,
MotionController
-} from '../libs/motion-contr... | false |
Other | mrdoob | three.js | fca61b053d5ccb7d8779abc4e91cf74c7587ea4a.json | Update XRControllerModelFactory based on feedback
Also assed it to three existing examples. Skipped paint/sculpt because they already had simple controller visualizations. | examples/jsm/libs/motion-controllers.module.js | @@ -0,0 +1,397 @@
+/**
+ * @webxr-input-profiles/motion-controllers 0.2.0 https://github.com/immersive-web/webxr-input-profiles
+ */
+
+const Constants = {
+ Handedness: Object.freeze({
+ NONE: 'none',
+ LEFT: 'left',
+ RIGHT: 'right'
+ }),
+
+ ComponentState: Object.freeze({
+ DEFAULT: 'default',
+ T... | true |
Other | mrdoob | three.js | fca61b053d5ccb7d8779abc4e91cf74c7587ea4a.json | Update XRControllerModelFactory based on feedback
Also assed it to three existing examples. Skipped paint/sculpt because they already had simple controller visualizations. | examples/jsm/webxr/XRControllerModelFactory.d.ts | @@ -14,11 +14,10 @@ export class XRControllerModel extends Object3D {
setEnvironmentMap( envMap: Texture ): XRControllerModel;
}
-export class XRControllerModelLoader {
+export class XRControllerModelFactory {
constructor( gltfLoader?: GLTFLoader );
gltfLoader: GLTFLoader | null;
path: string;
- setGLTFLoa... | true |
Other | mrdoob | three.js | fca61b053d5ccb7d8779abc4e91cf74c7587ea4a.json | Update XRControllerModelFactory based on feedback
Also assed it to three existing examples. Skipped paint/sculpt because they already had simple controller visualizations. | examples/jsm/webxr/XRControllerModelFactory.js | @@ -11,13 +11,15 @@ import {
SphereGeometry,
} from "../../../build/three.module.js";
+import { GLTFLoader } from '../loaders/GLTFLoader.js'
+
import {
Constants as MotionControllerConstants,
fetchProfile,
MotionController
-} from 'https://cdn.jsdelivr.net/npm/@webxr-input-profiles/motion-controllers@0.1.0/... | true |
Other | mrdoob | three.js | fca61b053d5ccb7d8779abc4e91cf74c7587ea4a.json | Update XRControllerModelFactory based on feedback
Also assed it to three existing examples. Skipped paint/sculpt because they already had simple controller visualizations. | examples/webxr_vr_ballshooter.html | @@ -20,6 +20,7 @@
import { BoxLineGeometry } from './jsm/geometries/BoxLineGeometry.js';
import { VRButton } from './jsm/webxr/VRButton.js';
+ import { XRControllerModelFactory } from './jsm/webxr/XRControllerModelFactory.js';
var camera, scene, renderer;
var controller1, controller2;
@@ -51,8 +52... | true |
Other | mrdoob | three.js | fca61b053d5ccb7d8779abc4e91cf74c7587ea4a.json | Update XRControllerModelFactory based on feedback
Also assed it to three existing examples. Skipped paint/sculpt because they already had simple controller visualizations. | examples/webxr_vr_cubes.html | @@ -20,6 +20,7 @@
import { BoxLineGeometry } from './jsm/geometries/BoxLineGeometry.js';
import { VRButton } from './jsm/webxr/VRButton.js';
+ import { XRControllerModelFactory } from './jsm/webxr/XRControllerModelFactory.js';
var clock = new THREE.Clock();
@@ -122,6 +123,10 @@
} );
scene.... | true |
Other | mrdoob | three.js | fca61b053d5ccb7d8779abc4e91cf74c7587ea4a.json | Update XRControllerModelFactory based on feedback
Also assed it to three existing examples. Skipped paint/sculpt because they already had simple controller visualizations. | examples/webxr_vr_dragging.html | @@ -19,6 +19,7 @@
import * as THREE from '../build/three.module.js';
import { OrbitControls } from './jsm/controls/OrbitControls.js';
import { VRButton } from './jsm/webxr/VRButton.js';
+ import { XRControllerModelFactory } from './jsm/webxr/XRControllerModelFactory.js';
var container;
var camer... | true |
Other | mrdoob | three.js | 40c35590800745bf1650f1876fdcff844cad6492.json | remove envMap flipping for CUBE_UV textures | examples/webgl_materials_envmaps_parallax.html | @@ -105,8 +105,7 @@
#elif defined( ENVMAP_TYPE_CUBE_UV )
- vec3 queryVec = vec3( flipEnvMap * worldNormal.x, worldNormal.yz );
- vec4 envMapColor = textureCubeUV( envMap, queryVec, 1.0 );
+ vec4 envMapColor = textureCubeUV( envMap, worldNormal, 1.0 );
#else
@@ -172,8 +171,7 @@
... | true |
Other | mrdoob | three.js | 40c35590800745bf1650f1876fdcff844cad6492.json | remove envMap flipping for CUBE_UV textures | src/renderers/shaders/ShaderChunk/envmap_fragment.glsl.js | @@ -40,7 +40,7 @@ export default /* glsl */`
#elif defined( ENVMAP_TYPE_CUBE_UV )
- vec4 envColor = textureCubeUV( envMap, vec3( flipEnvMap * reflectVec.x, reflectVec.yz ), 0.0 );
+ vec4 envColor = textureCubeUV( envMap, reflectVec, 0.0 );
#elif defined( ENVMAP_TYPE_EQUIREC )
| true |
Other | mrdoob | three.js | 40c35590800745bf1650f1876fdcff844cad6492.json | remove envMap flipping for CUBE_UV textures | src/renderers/shaders/ShaderChunk/envmap_physical_pars_fragment.glsl.js | @@ -31,8 +31,7 @@ export default /* glsl */`
#elif defined( ENVMAP_TYPE_CUBE_UV )
- vec3 queryVec = vec3( flipEnvMap * worldNormal.x, worldNormal.yz );
- vec4 envMapColor = textureCubeUV( envMap, queryVec, 1.0 );
+ vec4 envMapColor = textureCubeUV( envMap, worldNormal, 1.0 );
#else
@@ -94,8 +93,7 @@... | true |
Other | mrdoob | three.js | 5dc078a9d60be4811a36d1408f5d8cab3737e383.json | fix NormalNode context | examples/jsm/nodes/accessors/NormalNode.js | @@ -29,6 +29,20 @@ NormalNode.prototype.getShared = function () {
};
+NormalNode.prototype.build = function ( builder, output, uuid, ns ) {
+
+ var contextNormal = builder.context[ this.scope + 'Normal' ];
+
+ if ( contextNormal ) {
+
+ return contextNormal.build( builder, output, uuid, ns );
+
+ }
+
+ return Tem... | true |
Other | mrdoob | three.js | 5dc078a9d60be4811a36d1408f5d8cab3737e383.json | fix NormalNode context | examples/jsm/nodes/accessors/ReflectNode.js | @@ -54,7 +54,7 @@ ReflectNode.prototype.generate = function ( builder, output ) {
case ReflectNode.VECTOR:
- var viewNormalNode = builder.context.viewNormal || new NormalNode( NormalNode.VIEW );
+ var viewNormalNode = new NormalNode( NormalNode.VIEW );
var roughnessNode = builder.context.roughness;
... | true |
Other | mrdoob | three.js | 5dc078a9d60be4811a36d1408f5d8cab3737e383.json | fix NormalNode context | examples/jsm/nodes/materials/nodes/StandardNode.js | @@ -135,6 +135,7 @@ StandardNode.prototype.build = function ( builder ) {
roughness: specularRoughness,
bias: new SpecularMIPLevelNode( specularRoughness ),
viewNormal: new ExpressionNode( 'normal', 'v3' ),
+ worldNormal: new ExpressionNode( 'inverseTransformDirection( geometry.normal, viewMatrix )', 'v3'... | true |
Other | mrdoob | three.js | 5dc078a9d60be4811a36d1408f5d8cab3737e383.json | fix NormalNode context | examples/jsm/nodes/misc/TextureCubeUVNode.js | @@ -84,11 +84,14 @@ TextureCubeUVNode.Nodes = ( function () {
var bilinearCubeUV = new FunctionNode(
`TextureCubeUVData bilinearCubeUV(sampler2D envMap, vec3 direction, float mipInt) {
+
float face = getFace(direction);
float filterInt = max(cubeUV_minMipLevel - mipInt, 0.0);
mipInt = max(mipInt, cub... | true |
Other | mrdoob | three.js | a7c3713d7532dbf305f9923185e457101f6a7cec.json | update default values | examples/jsm/nodes/materials/nodes/StandardNode.js | @@ -17,11 +17,9 @@ function StandardNode() {
Node.call( this );
- this.color = new ColorNode( 0xEEEEEE );
- this.roughness = new FloatNode( 0.5 );
- this.metalness = new FloatNode( 0.5 );
-
- this.energyPreservation = true;
+ this.color = new ColorNode( 0xFFFFFF );
+ this.roughness = new FloatNode( 1 );
+ this.me... | false |
Other | mrdoob | three.js | b98a3a3044a3efc84c833bd0c4cb90b0f491576e.json | Open the helper folder by default | examples/webgl_shadowmap_csm.html | @@ -235,6 +235,8 @@
helperFolder.add( params, 'updateHelper' ).name( 'update' );
+ helperFolder.open();
+
window.addEventListener( 'resize', function () {
camera.aspect = window.innerWidth / window.innerHeight; | false |
Other | mrdoob | three.js | 92f0693914f3202a37aef1699d7cae7f01031dc5.json | Remove unused variables | examples/jsm/csm/CSM.js | @@ -8,11 +8,6 @@ import {
DirectionalLight,
MathUtils,
ShaderChunk,
- LineBasicMaterial,
- Object3D,
- BufferGeometry,
- BufferAttribute,
- Line,
Matrix4,
Box3
} from '../../../build/three.module.js';
@@ -21,9 +16,7 @@ import Shader from './Shader.js';
const _cameraToLightMatrix = new Matrix4();
const _l... | false |
Other | mrdoob | three.js | a4dabf4afc26fab16587f6482d2db848200a3972.json | Remove helper from CSM.js | examples/jsm/csm/CSM.js | @@ -333,68 +333,6 @@ export default class CSM {
}
- helper( cameraMatrix ) {
-
- let geometry, vertices;
- const material = new LineBasicMaterial( { color: 0xffffff } );
- const object = new Object3D();
-
- for ( let i = 0; i < this.frustums.length; i ++ ) {
-
- this.frustums[ i ].toSpace( cameraMatrix, _fr... | false |
Other | mrdoob | three.js | 16217975112392ec4d14d681b96322e23dfa07f4.json | Use CSMHelper in the scene | examples/webgl_shadowmap_csm.html | @@ -21,8 +21,9 @@
import { OrbitControls } from './jsm/controls/OrbitControls.js';
import { GUI } from './jsm/libs/dat.gui.module.js';
import * as CSM from './jsm/csm/CSM.js';
+ import { CSMHelper } from './jsm/csm/CSMHelper.js';
- var renderer, scene, camera, orthoCamera, controls, csm;
+ var rende... | false |
Other | mrdoob | three.js | 1f08ad1f824b1e521a3bf40c5a398aa66321e792.json | Add visibility toggle | examples/jsm/csm/CSMHelper.js | @@ -1,11 +1,26 @@
-import { Group, Mesh, LineSegments, BufferGeometry, LineBasicMaterial, Box3Helper, Box3, PlaneBufferGeometry, MeshBasicMaterial, BufferAttribute, DoubleSide } from '../../../build/three.module.js';
+import {
+ Group,
+ Mesh,
+ LineSegments,
+ BufferGeometry,
+ LineBasicMaterial,
+ Box3Helper,
+ Box3,... | false |
Other | mrdoob | three.js | 7118eec85cfa39602dd4b33db87f6f42214bca9c.json | Update light frustums | examples/jsm/csm/CSMHelper.js | @@ -1,4 +1,4 @@
-import { Group, Mesh, LineSegments, BufferGeometry, LineBasicMaterial, Box3Helper, Box3, PlaneBufferGeometry, MeshBasicMaterial, BufferAttribute } from '../../../build/three.module.js';
+import { Group, Mesh, LineSegments, BufferGeometry, LineBasicMaterial, Box3Helper, Box3, PlaneBufferGeometry, MeshBa... | false |
Other | mrdoob | three.js | 933f7f0c6b64975795a770f63134f6f049841ae6.json | use farthest verts on frustum | examples/jsm/csm/CSM.js | @@ -170,15 +170,29 @@ export default class CSM {
_cameraToLightMatrix.multiplyMatrices( light.shadow.camera.matrixWorldInverse, cameraMatrix );
frustums[ i ].toSpace( _cameraToLightMatrix, _lightSpaceFrustum );
- const farTopRight = _lightSpaceFrustum.vertices.far[ 0 ];
- const nearBotLeft = _lig... | false |
Other | mrdoob | three.js | d527e1b7e4b420c0aef99e161934795f6ac4d50f.json | Use the frustum diagonal | examples/jsm/csm/CSM.js | @@ -182,7 +182,7 @@ export default class CSM {
_bbox.getCenter( _center );
_center.z = _bbox.max.z + this.lightMargin;
- let squaredBBWidth = _lightSpaceFrustum.vertices.far[ 0 ].distanceTo( _lightSpaceFrustum.vertices.far[ 2 ] );
+ let squaredBBWidth = _lightSpaceFrustum.vertices.far[ 0 ].distanceTo( _li... | false |
Other | mrdoob | three.js | 6c687f4c8f0a8b7e6d46d3cea68502e0e5a0eb10.json | Fix pixel swimming | examples/jsm/csm/CSM.js | @@ -181,9 +181,8 @@ export default class CSM {
_bbox.getSize( _size );
_bbox.getCenter( _center );
_center.z = _bbox.max.z + this.lightMargin;
- _center.applyMatrix4( light.shadow.camera.matrixWorld );
- let squaredBBWidth = Math.max( _size.x, _size.y );
+ let squaredBBWidth = _lightSpaceFrustum.ver... | false |
Other | mrdoob | three.js | 973e03e84c3415f78975dd1aeaf9d188e8106470.json | Update csm frustums when resizing window | examples/webgl_shadowmap_csm.html | @@ -212,6 +212,7 @@
camera.updateProjectionMatrix();
updateOrthoCamera();
+ csm.updateFrustums();
renderer.setSize( window.innerWidth, window.innerHeight );
| false |
Other | mrdoob | three.js | 9a768ede0ea7311653576d758dc75de03208eb7b.json | Reuse variables in shader | examples/jsm/csm/Shader.js | @@ -102,15 +102,15 @@ IncidentLight directLight;
directionalLightShadow = directionalLightShadows[ i ];
directLight.color *= all( bvec2( directLight.visible, receiveShadow ) ) ? getShadow( directionalShadowMap[ i ], directionalLightShadow.shadowMapSize, directionalLightShadow.shadowBias, directionalLightShado... | false |
Other | mrdoob | three.js | 05a1ac5eb12a17ef0a1761165f8a02b16a47b890.json | Use nearest cascade edge to compute fade | examples/jsm/csm/Shader.js | @@ -84,10 +84,15 @@ IncidentLight directLight;
directionalLight = directionalLights[ i ];
getDirectionalDirectLightIrradiance( directionalLight, geometry, directLight );
- float margin = 0.25 * pow( linearDepth, 2.0 );
- float csmx = CSM_cascades[ i ].x - margin / 2.0;
- float csmy = CSM_cascades[ i ].y + ma... | false |
Other | mrdoob | three.js | 4e6aee44be75545be6da49daa394f5b204365cb5.json | Update CSM example | examples/webgl_shadowmap_csm.html | @@ -140,7 +140,7 @@
gui.add( params, 'fade' ).onChange( function ( value ) {
csm.fade = value;
- csm.updateUniforms();
+ csm.updateFrustums();
} );
| false |
Other | mrdoob | three.js | 31e4409b4c396292e9c48a83e33d6ef0617ebae6.json | remove extra line | examples/jsm/csm/CSM.js | @@ -400,7 +400,6 @@ export default class CSM {
delete shader.uniforms.cameraNear;
delete shader.uniforms.shadowFar;
-
material.needsUpdate = true;
} ); | false |
Other | mrdoob | three.js | b0436ca155722717d7e9888f2b22e7ed313ae875.json | Add a dispose function | examples/jsm/csm/CSM.js | @@ -386,4 +386,26 @@ export default class CSM {
}
+ dispose() {
+
+ const shaders = this.shaders;
+ shaders.forEach( function ( shader, material ) {
+
+ delete material.onBeforeCompile;
+ delete material.defines.USE_CSM;
+ delete material.defines.CSM_CASCADES;
+ delete material.defines.CSM_FADE;
+
+ d... | false |
Other | mrdoob | three.js | 35101131b7cbc66b1ed377597a27c49a4051c0a1.json | Fix stale values in before compile | examples/jsm/csm/CSM.js | @@ -235,16 +235,16 @@ export default class CSM {
}
const breaksVec2 = [];
- this.getExtendedBreaks( breaksVec2 );
-
- const far = Math.min( this.camera.far, this.maxFar );
+ const self = this;
const shaders = this.shaders;
- const camera = this.camera;
material.onBeforeCompile = function ( shader ) ... | false |
Other | mrdoob | three.js | 78a25d5a88d4034ea8d39f7c158fcc54695f9110.json | Avoid shader duplication | examples/jsm/csm/CSM.js | @@ -53,8 +53,7 @@ export default class CSM {
this.breaks = [];
this.lights = [];
- this.shaders = [];
- this.materials = [];
+ this.shaders = new Map();
this.createLights();
this.getBreaks();
@@ -238,39 +237,39 @@ export default class CSM {
const breaksVec2 = [];
this.getExtendedBreaks( breaksV... | false |
Other | mrdoob | three.js | aebe7760de76744df6c42935e7c341d58dc3fd7a.json | Add fade toggle | examples/jsm/csm/CSM.js | @@ -47,11 +47,13 @@ export default class CSM {
this.lightFar = data.lightFar || 2000;
this.lightMargin = data.lightMargin || 200;
this.customSplitsCallback = data.customSplitsCallback;
+ this.fade = false;
this.mainFrustum = new Frustum();
this.frustums = [];
this.breaks = [];
this.lights = [];
... | true |
Other | mrdoob | three.js | aebe7760de76744df6c42935e7c341d58dc3fd7a.json | Add fade toggle | examples/jsm/csm/Shader.js | @@ -78,6 +78,7 @@ IncidentLight directLight;
DirectionalLightShadow directionalLightShadow;
#endif
+ #if defined( CSM_FADE )
for ( int i = 0; i < NUM_DIR_LIGHTS; i ++ ) {
directionalLight = directionalLights[ i ];
@@ -114,6 +115,26 @@ IncidentLight directLight;
}
}
+ #else
+
+ #pragma unroll_loop
+ ... | true |
Other | mrdoob | three.js | aebe7760de76744df6c42935e7c341d58dc3fd7a.json | Add fade toggle | examples/webgl_shadowmap_csm.html | @@ -26,6 +26,7 @@
var params = {
orthographic: false,
+ fade: false,
far: 1000,
mode: 'practical',
lightX: - 1,
@@ -129,13 +130,22 @@
var gui = new GUI();
+ window.csm = csm;
+
gui.add( params, 'orthographic' ).onChange( function ( value ) {
csm.camera = value ? ort... | true |
Other | mrdoob | three.js | a043873b77552bace57fa455ea9fc547aa505e57.json | Add puppeteer checks to eliminate freezing | .travis.yml | @@ -9,19 +9,19 @@ jobs:
- &lint-n-unit
stage: lint & unit
name: lint
- script: npm run lint
+ script: npm run test-lint
- <<: *lint-n-unit
name: unit
script: npm run test-unit
- &diff
stage: diff
name: diff
- script: FORCE_COLOR=0 npm run test-di... | true |
Other | mrdoob | three.js | a043873b77552bace57fa455ea9fc547aa505e57.json | Add puppeteer checks to eliminate freezing | package.json | @@ -52,9 +52,9 @@
"build-examples": "rollup -c utils/build/rollup-examples.config.js",
"dev": "concurrently --names \"ROLLUP,HTTP\" -c \"bgBlue.bold,bgGreen.bold\" \"rollup -c utils/build/rollup.config.js -w -m inline\" \"serve\"",
"dev-test": "concurrently --names \"ROLLUP,ROLLUPTEST,HTTP\" -c \"bgBlue.... | true |
Other | mrdoob | three.js | a043873b77552bace57fa455ea9fc547aa505e57.json | Add puppeteer checks to eliminate freezing | test/diff/README.md | @@ -15,14 +15,23 @@ npx cross-env VISIBLE=ture npm run test-diff
```
### How it works
+
+| Travis | Attempts |
+|-----------------------------------------|--------------------------------------|
+| 61 from 362 failed, time=21:14 | networkidle0 ti... | true |
Other | mrdoob | three.js | a043873b77552bace57fa455ea9fc547aa505e57.json | Add puppeteer checks to eliminate freezing | test/diff/puppeteer.js | @@ -11,14 +11,8 @@ const png = require( 'pngjs' ).PNG;
const fs = require( 'fs' );
const port = 1234;
-const pixelThreshold = 0.2;
-const maxFailedPixels = 0.05;
-const networkTimeout = 600;
-const networkTax = 2000; // additional timeout for resources size
-const pageSizeMinTax = 1.0; ... | true |
Other | mrdoob | three.js | cf9357b8e1cfd1a3e0287ed87aef66b707d72b9d.json | Reset numIntersection in projectPlanes() | src/renderers/webgl/WebGLClipping.js | @@ -153,6 +153,7 @@ function WebGLClipping() {
}
scope.numPlanes = nPlanes;
+ scope.numIntersection = 0;
return dstArray;
| false |
Other | mrdoob | three.js | fb84d84123f8b433b83c6ffa133a765a00ac380e.json | Fix missing controllerModel usage
The throwing error call directly motionController.assertUrl that will be undefined. Update to controllerModel.motionController.assertUrl. | examples/jsm/webxr/XRControllerModelFactory.js | @@ -281,7 +281,7 @@ var XRControllerModelFactory = ( function () {
null,
() => {
- throw new Error( `Asset ${motionController.assetUrl} missing or malformed.` );
+ throw new Error( `Asset ${controllerModel.motionController.assetUrl} missing or malformed.` );
} );
| false |
Other | mrdoob | three.js | a666176d52bcc7e551a1ead756d8bb64381c3715.json | Add readme page in tests and fix typos | test/diff/README.md | @@ -0,0 +1,31 @@
+# Three.js automatic regression testing with CI
+
+You probably shouldn't run this tests on PC because right now it's not optimized for local usage and you can get different results on different GPUs. Goal is to make quick automated testing inside CI and keep screenshot pack updated for it.
+
+### Loc... | true |
Other | mrdoob | three.js | a666176d52bcc7e551a1ead756d8bb64381c3715.json | Add readme page in tests and fix typos | test/diff/puppeteer.js | @@ -14,7 +14,7 @@ const port = 1234;
const pixelThreshold = 0.2;
const maxFailedPixels = 0.05;
const networkTimeout = 600;
-const networkTax = 2000; // additional timout tax for resources size
+const networkTax = 2000; // additional timeout for resources size
const pageSizeMinTax... | true |
Other | mrdoob | three.js | 8ba1432eac4c0de15f411923dbe44cd0c4ec7c10.json | Update kernelSize type
Fix Inconsistent type on `kernelSize` to a number.
The plain version of the SSAOPass.js takes a number type
but it's typed as a `boolean` here. | examples/jsm/postprocessing/SSAOPass.d.ts | @@ -22,7 +22,7 @@ export class SSAOPass extends Pass {
height: boolean;
clear: boolean;
kernelRadius: number;
- kernelSize: boolean;
+ kernelSize: number;
kernel: Vector3[];
noiseTexture: DataTexture;
output: number; | false |
Other | mrdoob | three.js | 9ae6a5a92fe0107dab5f560d552c8b90b5b3bdc4.json | Remove extra whitespace. | examples/webgl_buffergeometry_instancing_interleaved.html | @@ -232,6 +232,4 @@
</body>
-
-
</html> | false |
Other | mrdoob | three.js | d9a33bfda6f144558e599473431f0ffc8be32449.json | Remove two InstancedBufferGeometry examples. | examples/files.js | @@ -278,10 +278,8 @@ var files = {
"webgl_buffergeometry_drawrange",
"webgl_buffergeometry_indexed",
"webgl_buffergeometry_instancing",
- "webgl_buffergeometry_instancing2",
"webgl_buffergeometry_instancing_billboards",
- "webgl_buffergeometry_instancing_dynamic",
- "webgl_buffergeometry_instancing_inter... | true |
Other | mrdoob | three.js | d9a33bfda6f144558e599473431f0ffc8be32449.json | Remove two InstancedBufferGeometry examples. | examples/webgl_buffergeometry_instancing2.html | @@ -1,232 +0,0 @@
-<!DOCTYPE html>
-<html lang="en">
-<head>
- <title>three.js webgl - instancing test (meshes)</title>
- <meta charset="utf-8">
- <meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0">
- <link type="text/css" rel="stylesheet" href="main.css">
- <styl... | true |
Other | mrdoob | three.js | d9a33bfda6f144558e599473431f0ffc8be32449.json | Remove two InstancedBufferGeometry examples. | examples/webgl_buffergeometry_instancing_dynamic.html | @@ -1,184 +0,0 @@
-<!DOCTYPE html>
-<html lang="en">
-<head>
- <title>three.js webgl - indexed instancing (single box), dynamic updates</title>
- <meta charset="utf-8">
- <meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0">
- <link type="text/css" rel="stylesheet" ... | true |
Other | mrdoob | three.js | 5c863530be7a035308965dc06cb5b0f8a0552716.json | Fix typings and documentation of LoadingManager | src/loaders/LoadingManager.d.ts | @@ -13,23 +13,33 @@ export class LoadingManager {
onError?: ( url: string ) => void
);
+ /**
+ * Will be called when loading of an item starts.
+ * @param url The url of the item that started loading.
+ * @param loaded The number of items already loaded so far.
+ * @param total The total amount of items to b... | false |
Other | mrdoob | three.js | f3ee9b0b72dca0dd641fa2486f42e6341f4f8338.json | Add blank lines | src/audio/PositionalAudio.d.ts | @@ -1,9 +1,10 @@
import { AudioListener } from './AudioListener';
import { Audio } from './Audio';
-// Override getOutput
export class AudioWeaken extends Audio {
+
getOutput(): any;
+
}
export class PositionalAudio extends AudioWeaken { | false |
Other | mrdoob | three.js | c94098295f634599ed510e27792c5e2b618c6b7b.json | Add typings for `stats.module.js`. | examples/jsm/libs/stats.module.d.ts | @@ -0,0 +1,24 @@
+declare interface Stats {
+ REVISION: number;
+ dom: HTMLDivElement;
+ addPanel(panel: Stats.Panel): Stats.Panel;
+ showPanel(id: number): void;
+ begin(): void;
+ end(): void;
+ update(): void;
+ domElement: HTMLDivElement;
+ setMode(id: number): void;
+}
+
+declare function Stats(): Stats;
... | false |
Other | mrdoob | three.js | 7aeb82c872e2df45d299dfeab2ed25c4d9d8b860.json | Fix bug in copyTextureToTexture with pixelStorei | src/renderers/WebGLRenderer.js | @@ -1961,6 +1961,12 @@ function WebGLRenderer( parameters ) {
textures.setTexture2D( dstTexture, 0 );
+ // As another texture upload may have changed pixelStorei
+ // parameters, make sure they are correct for the dstTexture
+ _gl.pixelStorei( _gl.UNPACK_FLIP_Y_WEBGL, dstTexture.flipY );
+ _gl.pixelStorei( _... | false |
Other | mrdoob | three.js | df1be6eaeca1f8b56ba3bd2888504862d355a14c.json | Update example to demonstrate issue | examples/webgl_materials_texture_partialupdate.html | @@ -119,10 +119,11 @@
for ( var i = 0; i < size; i ++ ) {
var stride = i * 3;
+ var gradient = i / size;
- data[ stride ] = r;
- data[ stride + 1 ] = g;
- data[ stride + 2 ] = b;
+ data[ stride ] = r * gradient;
+ data[ stride + 1 ] = g * gradient;
+ data[ stride + 2 ] = b * g... | false |
Other | mrdoob | three.js | 7e51e8d1d181c79a5988a5e73e631c5b462dd221.json | Specify tonemapping exposure for clarity | examples/webgl_loader_gltf.html | @@ -88,6 +88,7 @@
renderer.setPixelRatio( window.devicePixelRatio );
renderer.setSize( window.innerWidth, window.innerHeight );
renderer.toneMapping = THREE.ACESFilmicToneMapping;
+ renderer.toneMappingExposure = 1;
renderer.outputEncoding = THREE.sRGBEncoding;
container.appendChild( rendere... | true |
Other | mrdoob | three.js | 7e51e8d1d181c79a5988a5e73e631c5b462dd221.json | Specify tonemapping exposure for clarity | examples/webgl_loader_gltf_extensions.html | @@ -150,6 +150,7 @@
renderer.setSize( window.innerWidth, window.innerHeight );
renderer.outputEncoding = THREE.sRGBEncoding;
renderer.toneMapping = THREE.ACESFilmicToneMapping;
+ renderer.toneMappingExposure = 1;
renderer.physicallyCorrectLights = true;
document.body.appendChild( renderer.do... | true |
Other | mrdoob | three.js | 7e51e8d1d181c79a5988a5e73e631c5b462dd221.json | Specify tonemapping exposure for clarity | examples/webgl_pmrem_test.html | @@ -46,6 +46,7 @@
// tonemapping
renderer.toneMapping = THREE.ACESFilmicToneMapping;
+ renderer.toneMappingExposure = 1;
document.body.appendChild( renderer.domElement );
| true |
Other | mrdoob | three.js | 3911e78138d1ca0dd41b75b3ebb5ee8d2a051313.json | Remove single instance of whitelist with allowlist
Given the context, allowlist is an appropriate replacement for the
single usage of whitelist in the code. We could call it exactly what
it is, a supported sub-objects name list, but that is getting verbose. | build/three.js | @@ -44276,7 +44276,7 @@
var objectName = results.nodeName.substring( lastDot + 1 );
- // Object names must be checked against a whitelist. Otherwise, there
+ // Object names must be checked against an allowlist. Otherwise, there
// is no way to parse 'foo.bar.baz': 'baz' must be a property, but
... | true |
Other | mrdoob | three.js | 3911e78138d1ca0dd41b75b3ebb5ee8d2a051313.json | Remove single instance of whitelist with allowlist
Given the context, allowlist is an appropriate replacement for the
single usage of whitelist in the code. We could call it exactly what
it is, a supported sub-objects name list, but that is getting verbose. | build/three.module.js | @@ -44244,7 +44244,7 @@ Object.assign( PropertyBinding, {
const objectName = results.nodeName.substring( lastDot + 1 );
- // Object names must be checked against a whitelist. Otherwise, there
+ // Object names must be checked against an allowlist. Otherwise, there
// is no way to parse 'foo.bar.baz': 'b... | true |
Other | mrdoob | three.js | 3911e78138d1ca0dd41b75b3ebb5ee8d2a051313.json | Remove single instance of whitelist with allowlist
Given the context, allowlist is an appropriate replacement for the
single usage of whitelist in the code. We could call it exactly what
it is, a supported sub-objects name list, but that is getting verbose. | src/animation/PropertyBinding.js | @@ -173,7 +173,7 @@ Object.assign( PropertyBinding, {
const objectName = results.nodeName.substring( lastDot + 1 );
- // Object names must be checked against a whitelist. Otherwise, there
+ // Object names must be checked against an allowlist. Otherwise, there
// is no way to parse 'foo.bar.baz': 'baz' ... | true |
Other | mrdoob | three.js | c3003c04a185c4d1f6b8c426d4b6520d237f3676.json | Apply exposure boost to ACES Filmic tone mapping | examples/js/shaders/ACESFilmicToneMappingShader.js | @@ -4,6 +4,9 @@ console.warn( "THREE.ACESFilmicToneMappingShader: As part of the transition to E
*
* ACES Filmic Tone Mapping Shader by Stephen Hill
* source: https://github.com/selfshadow/ltc_code/blob/master/webgl/shaders/ltc/ltc_blit.fs
+ *
+ * this implementation of ACES is modified to accommodate a brighter ... | true |
Other | mrdoob | three.js | c3003c04a185c4d1f6b8c426d4b6520d237f3676.json | Apply exposure boost to ACES Filmic tone mapping | examples/jsm/shaders/ACESFilmicToneMappingShader.js | @@ -3,6 +3,9 @@
*
* ACES Filmic Tone Mapping Shader by Stephen Hill
* source: https://github.com/selfshadow/ltc_code/blob/master/webgl/shaders/ltc/ltc_blit.fs
+ *
+ * this implementation of ACES is modified to accommodate a brighter viewing environment.
+ * the scale factor of 1/0.6 is subjective. see discussion ... | true |
Other | mrdoob | three.js | c3003c04a185c4d1f6b8c426d4b6520d237f3676.json | Apply exposure boost to ACES Filmic tone mapping | src/renderers/shaders/ShaderChunk/tonemapping_pars_fragment.glsl.js | @@ -40,6 +40,9 @@ vec3 RRTAndODTFit( vec3 v ) {
}
+// this implementation of ACES is modified to accommodate a brighter viewing environment.
+// the scale factor of 1/0.6 is subjective. see discussion in #19621.
+
vec3 ACESFilmicToneMapping( vec3 color ) {
// sRGB => XYZ => D65_2_D60 => AP1 => RRT_SAT
@@ -... | true |
Other | mrdoob | three.js | 80d1d8f5d4ae45b8f501ebcd4c167a74167a43a8.json | Create just "lint" and "lint-examples" scripts | package.json | @@ -52,10 +52,8 @@
"dev": "concurrently --names \"ROLLUP,HTTP\" -c \"bgBlue.bold,bgGreen.bold\" \"rollup -c utils/build/rollup.config.js -w -m inline\" \"http-server -c-1 -p 8080\"",
"dev-test": "concurrently --names \"ROLLUP,ROLLUPTEST,HTTP\" -c \"bgBlue.bold,bgRed.bold,bgGreen.bold\" \"rollup -c utils/build... | true |
Other | mrdoob | three.js | 80d1d8f5d4ae45b8f501ebcd4c167a74167a43a8.json | Create just "lint" and "lint-examples" scripts | utils/build/tsconfig-examples.lint.json | @@ -0,0 +1,8 @@
+{
+ "compilerOptions": {
+ "noEmit": true,
+ },
+ "include": [
+ "../../examples/jsm/**/*.ts"
+ ]
+} | true |
Other | mrdoob | three.js | 5b2e5ade36cbf18fb0a0b62140aeb99217711243.json | improve packing geometry | examples/jsm/utils/GeometryPackingUtils.js | @@ -32,51 +32,56 @@ var GeometryPackingUtils = {
result = new Uint16Array(count * 2);
- } else if (encodeMethod == "OCT") {
-
- result = new Int8Array(count * 2);
-
- } else {
+ for (let idx = 0; idx < array.length; idx += 3) {
- console.error("Unrecogni... | true |
Other | mrdoob | three.js | 5b2e5ade36cbf18fb0a0b62140aeb99217711243.json | improve packing geometry | examples/webgl_materials_packed_geometry.html | @@ -32,15 +32,18 @@
var data = {
flatShading: false,
basicEncode: false,
- octEncode: false
+ octEncode: false,
+ quantizePosition: false
};
+ var radius = 100;
+
init();
animate();
function init() {
- GeometryPackingUtils.changeShaderChunk();
+ // GeometryPackingUtils.changeSha... | true |
Other | mrdoob | three.js | 94526d96484269b6c503719fda2c89725bbde77f.json | Use new BufferAttribute.applyMatrix4() method | examples/js/loaders/FBXLoader.js | @@ -1590,7 +1590,7 @@ THREE.FBXLoader = ( function () {
var positionAttribute = new THREE.Float32BufferAttribute( buffers.vertex, 3 );
- preTransform.applyToBufferAttribute( positionAttribute );
+ positionAttribute.applyMatrix4( preTransform );
geo.setAttribute( 'position', positionAttribute );
@@ -... | true |
Other | mrdoob | three.js | 94526d96484269b6c503719fda2c89725bbde77f.json | Use new BufferAttribute.applyMatrix4() method | examples/jsm/loaders/FBXLoader.js | @@ -1638,7 +1638,7 @@ var FBXLoader = ( function () {
var positionAttribute = new Float32BufferAttribute( buffers.vertex, 3 );
- preTransform.applyToBufferAttribute( positionAttribute );
+ positionAttribute.applyMatrix4( preTransform );
geo.setAttribute( 'position', positionAttribute );
@@ -2166,7 +... | true |
Other | mrdoob | three.js | e001a1372d19f21fdf73a6962d57ccb977ed2390.json | update colors for HTML code snippets in dark theme | docs/prettify/threejs.css | @@ -16,6 +16,9 @@ pre.prettyprint, code.prettyprint {
@media (prefers-color-scheme: dark) {
+ pre .tag, code .tag { color: #2194ce; } /* HTML tag */
+ pre .atn, code .atn { color: #BB55FF; } /* HTML attribute name */
+ pre .atv, code .atv { color: #30b030; } /* HTML attribute value */
pre .str, code .str { color... | false |
Other | mrdoob | three.js | 203a725845c30bc2570fd7fa595e51befafc3925.json | Implement support for texture matrix for uv2
Before this change, we only supported one texture matrix for the
material that was applied to uv data based on the first texture, in
priority order, that needed it.
This change adds equivalent support for uv2 - we now transform second UV
channel with a second UV transform ... | src/renderers/WebGLRenderer.js | @@ -2161,6 +2161,40 @@ function WebGLRenderer( parameters ) {
}
+ // uv repeat and offset setting priorities for uv2
+ // 1. ao map
+ // 2. light map
+
+ var uv2ScaleMap;
+
+ if ( material.aoMap ) {
+
+ uv2ScaleMap = material.aoMap;
+
+ } else if ( material.lightMap ) {
+
+ uv2ScaleMap = material.ligh... | true |
Other | mrdoob | three.js | 203a725845c30bc2570fd7fa595e51befafc3925.json | Implement support for texture matrix for uv2
Before this change, we only supported one texture matrix for the
material that was applied to uv data based on the first texture, in
priority order, that needed it.
This change adds equivalent support for uv2 - we now transform second UV
channel with a second UV transform ... | src/renderers/shaders/ShaderChunk/uv2_pars_vertex.glsl.js | @@ -4,5 +4,7 @@ export default /* glsl */`
attribute vec2 uv2;
varying vec2 vUv2;
+ uniform mat3 uv2Transform;
+
#endif
`; | true |
Other | mrdoob | three.js | 203a725845c30bc2570fd7fa595e51befafc3925.json | Implement support for texture matrix for uv2
Before this change, we only supported one texture matrix for the
material that was applied to uv data based on the first texture, in
priority order, that needed it.
This change adds equivalent support for uv2 - we now transform second UV
channel with a second UV transform ... | src/renderers/shaders/ShaderChunk/uv2_vertex.glsl.js | @@ -1,7 +1,7 @@
export default /* glsl */`
#if defined( USE_LIGHTMAP ) || defined( USE_AOMAP )
- vUv2 = uv2;
+ vUv2 = ( uv2Transform * vec3( uv2, 1 ) ).xy;
#endif
`; | true |
Other | mrdoob | three.js | 203a725845c30bc2570fd7fa595e51befafc3925.json | Implement support for texture matrix for uv2
Before this change, we only supported one texture matrix for the
material that was applied to uv data based on the first texture, in
priority order, that needed it.
This change adds equivalent support for uv2 - we now transform second UV
channel with a second UV transform ... | src/renderers/shaders/UniformsLib.d.ts | @@ -8,6 +8,7 @@ export let UniformsLib: {
opacity: IUniform;
map: IUniform;
uvTransform: IUniform;
+ uv2Transform: IUniform;
alphaMap: IUniform;
};
specularmap: { | true |
Other | mrdoob | three.js | 203a725845c30bc2570fd7fa595e51befafc3925.json | Implement support for texture matrix for uv2
Before this change, we only supported one texture matrix for the
material that was applied to uv data based on the first texture, in
priority order, that needed it.
This change adds equivalent support for uv2 - we now transform second UV
channel with a second UV transform ... | src/renderers/shaders/UniformsLib.js | @@ -15,6 +15,7 @@ var UniformsLib = {
map: { value: null },
uvTransform: { value: new Matrix3() },
+ uv2Transform: { value: new Matrix3() },
alphaMap: { value: null },
| true |
Other | mrdoob | three.js | 7f58f35a32a7a3d954d754fe7e6779db413e5940.json | add url to npm in gitignore | .gitignore | @@ -7,7 +7,7 @@ npm-debug.log
.jshintrc
.vs/
-# npm install --prefix test adds files in the test folder.
+# npm install --prefix test adds files in the test folder (https://docs.npmjs.com/configuring-npm/folders.html#executables).
# There are 2 kindsof files, those without extension and those with cmd extension.
... | false |
Other | mrdoob | three.js | 9df4f897493b1054e162df5f496fc83e4b5e28c1.json | add comments to gitignore | .gitignore | @@ -7,6 +7,12 @@ npm-debug.log
.jshintrc
.vs/
+# npm install --prefix test adds files in the test folder.
+# There are 2 kindsof files, those without extension and those with cmd extension.
+# To ignore files without a extension, following precedure is nessecary:
+# - ignore all files in the test folder
+# - unigno... | false |
Other | mrdoob | three.js | b757f656ffed63a0ebfd78b665fdc4b753157d51.json | Add ignore for npm install with prefix | .gitignore | @@ -6,5 +6,12 @@
npm-debug.log
.jshintrc
.vs/
-**/node_modules
+
+test/*
+!test/*/
+!test/*.*
+test/*.cmd
test/unit/build
+
+
+**/node_modules
\ No newline at end of file | false |
Other | mrdoob | three.js | f207d07b33ed7ee39c8ed38544b0abe950862509.json | use media queries | docs/prettify/threejs.css | @@ -1,15 +1,28 @@
-pre .str, code .str { color: #BB55FF; } /* string */
+pre .str, code .str { color: #8000ff; } /* string */
pre .kwd, code .kwd { color: #30b030; } /* keyword */
-pre .com, code .com { color: #666666; } /* comment */
+pre .com, code .com { color: #999999; } /* comment */
pre .typ, code .typ { color:... | false |
Other | mrdoob | three.js | 5c98448ad8d1659f0b338b3fe34978a3b488e0f8.json | avoid the delayed updating of cube cameras
- we can update the unattached cube camera just before attaching it to avoid the unnessary delay
- we don't need to hide the sphere temporarily as we're using single sided materials | examples/webgl_materials_cubemap_dynamic.html | @@ -178,26 +178,22 @@
camera.lookAt( scene.position );
- sphere.visible = false;
-
// pingpong
if ( count % 2 === 0 ) {
+ cubeCamera1.update( renderer, scene );
material.envMap = cubeCamera1.renderTarget.texture;
- cubeCamera2.update( renderer, scene );
} else {
+ cu... | false |
Other | mrdoob | three.js | a4e573604cf1694db8f0059798bc97653fd538a6.json | Update JSM modules. | examples/jsm/renderers/CSS3DRenderer.js | @@ -19,11 +19,15 @@ var CSS3DObject = function ( element ) {
this.addEventListener( 'removed', function () {
- if ( this.element.parentNode !== null ) {
+ this.traverse( function( object ) {
- this.element.parentNode.removeChild( this.element );
+ if ( object.element instanceof Element && object.element.p... | false |
Other | mrdoob | three.js | 912f8c5d83dc65a93055156efbf482c45cc3be3a.json | Rebuild example modules | examples/jsm/controls/OrbitControls.js | @@ -268,7 +268,7 @@ var OrbitControls = function ( object, domElement ) {
document.removeEventListener( 'mousemove', onMouseMove, false );
document.removeEventListener( 'mouseup', onMouseUp, false );
- window.removeEventListener( 'keydown', onKeyDown, false );
+ scope.domElement.removeEventListener( 'keydown'... | false |
Other | mrdoob | three.js | 011f242435076e2b6e5ffbdc68eb0c1485536310.json | use a simple loop | examples/js/loaders/GCodeLoader.js | @@ -204,8 +204,13 @@ THREE.GCodeLoader.prototype = Object.assign( Object.create( THREE.Loader.prototy
var layer = layers[ i ];
- vertex.push( ...layer.vertex )
- pathVertex.push( ...layer.pathVertex )
+ for ( var j = 0; j < layer.vertex.length; j ++ ) {
+ vertex.push(layer.vertex[ j ])
+ ... | true |
Other | mrdoob | three.js | 011f242435076e2b6e5ffbdc68eb0c1485536310.json | use a simple loop | examples/jsm/loaders/GCodeLoader.js | @@ -215,8 +215,13 @@ GCodeLoader.prototype = Object.assign( Object.create( Loader.prototype ), {
var layer = layers[ i ];
- vertex.push( ...layer.vertex )
- pathVertex.push( ...layer.pathVertex )
+ for ( var j = 0; j < layer.vertex.length; j ++ ) {
+ vertex.push(layer.vertex[ j ])
+ }
+
... | true |
Other | mrdoob | three.js | 10e77ccb590f67e7b8035747d3ada1791fb386cd.json | Fix uniforms in ShaderMaterialParameters
This is to ensure the "uniforms" property of ShaderMaterialParameters is used properly if it is given in the ShaderMaterial constructor. | src/materials/ShaderMaterial.d.ts | @@ -12,7 +12,7 @@ import { MaterialParameters, Material } from './Material';
*/
export interface ShaderMaterialParameters extends MaterialParameters {
- uniforms?: any;
+ uniforms?: { [uniform: string]: IUniform };
vertexShader?: string;
fragmentShader?: string;
linewidth?: number; | false |
Other | mrdoob | three.js | 5051428960f3f12e83e0df3ea945d68968b19923.json | Fix panning direction | examples/webgl_video_panorama_equirectangular.html | @@ -105,7 +105,7 @@
if ( isUserInteracting === true ) {
lon = ( onPointerDownPointerX - event.clientX ) * 0.1 + onPointerDownLon;
- lat = ( event.clientY - onPointerDownPointerY ) * 0.1 + onPointerDownLat;
+ lat = ( onPointerDownPointerY - event.clientY ) * 0.1 + onPointerDownLat;
}
| false |
Other | mrdoob | three.js | b1b17b494105916675e57b49d288c2121291a0c7.json | add space around parameters | examples/js/loaders/GCodeLoader.js | @@ -204,8 +204,8 @@ THREE.GCodeLoader.prototype = Object.assign( Object.create( THREE.Loader.prototy
var layer = layers[ i ];
- vertex.push(...layer.vertex)
- pathVertex.push(...layer.pathVertex)
+ vertex.push( ...layer.vertex )
+ pathVertex.push( ...layer.pathVertex )
}
| true |
Other | mrdoob | three.js | b1b17b494105916675e57b49d288c2121291a0c7.json | add space around parameters | examples/jsm/loaders/GCodeLoader.js | @@ -215,8 +215,8 @@ GCodeLoader.prototype = Object.assign( Object.create( Loader.prototype ), {
var layer = layers[ i ];
- vertex.push(...layer.vertex)
- pathVertex.push(...layer.pathVertex)
+ vertex.push( ...layer.vertex )
+ pathVertex.push( ...layer.pathVertex )
}
| true |
Other | mrdoob | three.js | 57a815034605a470bffa0b10af7827966fe959af.json | Add lazy loading to images in examples page | examples/index.html | @@ -169,7 +169,7 @@ <h1><a href="https://threejs.org">three.js</a></h1>
'<div class="card">',
' <a href="' + file + '.html" target="viewer">',
' <div class="cover">',
- ' <img src="screenshots/' + file + '.png" />',
+ ' <img src="screenshots/' + file + '.png" loading="lazy" />',
' </div>... | false |
Other | mrdoob | three.js | b49842a39f34770cfe19befc6611828e37485cc2.json | Add patternTexture in type definition file
Otherwise tsc will complain when an user try to set the texture | examples/jsm/postprocessing/OutlinePass.d.ts | @@ -8,7 +8,8 @@ import {
MeshBasicMaterial,
MeshDepthMaterial,
ShaderMaterial,
- WebGLRenderTarget
+ WebGLRenderTarget,
+ Texture
} from '../../../src/Three';
import { Pass } from './Pass';
@@ -28,6 +29,7 @@ export class OutlinePass extends Pass {
downSampleRatio: number;
pulsePeriod: number;
resolution... | false |
Other | mrdoob | three.js | bb0168be04bfe6ef689250ca428d2906a8bfb040.json | Fix frustum update | examples/jsm/csm/Frustum.js | @@ -25,6 +25,9 @@ export default class Frustum {
getViewSpaceVertices() {
const maxFar = this.maxFar;
+ const projectionMatrix = this.projectionMatrix;
+ const isOrthographic = projectionMatrix.elements[ 2 * 4 + 3 ] === 0;
+
inverseProjectionMatrix.getInverse( this.projectionMatrix );
// 3 --- 0 verti... | true |
Other | mrdoob | three.js | bb0168be04bfe6ef689250ca428d2906a8bfb040.json | Fix frustum update | examples/webgl_shadowmap_csm.html | @@ -216,9 +216,18 @@
csm.update( camera.matrix );
controls.update();
- updateOrthoCamera();
-
- renderer.render( scene, params.orthographic ? orthoCamera : camera );
+
+ if ( params.orthographic ) {
+
+ updateOrthoCamera();
+ csm.updateFrustums();
+ renderer.render( scene, orthoCame... | true |
Other | mrdoob | three.js | aa471233929f7691bfc46474554510aedc8c2cdf.json | Add ortho camera to example | examples/webgl_shadowmap_csm.html | @@ -22,15 +22,50 @@
import { GUI } from './jsm/libs/dat.gui.module.js';
import * as CSM from './jsm/csm/CSM.js';
- var renderer, scene, camera, controls, csm;
+ var renderer, scene, camera, orthoCamera, controls, csm;
+
+ var params = {
+ orthographic: false,
+ far: 1000,
+ mode: 'practical'... | false |
Other | mrdoob | three.js | d1c934903a41bd10c9bfa61dd3c1f88ac4f2d2c4.json | replace frustum vertex with vector3 | examples/jsm/csm/Frustum.js | @@ -3,7 +3,6 @@
*/
import { MathUtils, Vector3 } from '../../../build/three.module.js';
-import FrustumVertex from './FrustumVertex.js';
export default class Frustum {
@@ -36,17 +35,17 @@ export default class Frustum {
// 2 --- 1
this.vertices.near.push(
- new FrustumVertex( this.nearPlaneX, this.ne... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.